| *** lnxnut has quit IRC | 00:12 | |
| *** wchrisj has joined #openstack-keystone | 00:13 | |
| *** zhiyan_ is now known as zhiyan | 00:23 | |
| *** wchrisj has quit IRC | 00:34 | |
| openstackgerrit | wanghong proposed a change to openstack/keystone: list_user_ids_for_project returns user multiple times https://review.openstack.org/89293 | 00:58 |
|---|---|---|
| openstackgerrit | Wei Wang proposed a change to openstack/keystone: add dependencies of keystone dev-enviroment https://review.openstack.org/80474 | 01:05 |
| *** ayoung_afk has quit IRC | 01:10 | |
| *** diegows has quit IRC | 01:33 | |
| *** Eric88 has quit IRC | 02:06 | |
| *** zz_dstanek is now known as dstanek | 02:15 | |
| *** dims has quit IRC | 02:29 | |
| *** dims has joined #openstack-keystone | 02:30 | |
| *** dims has quit IRC | 02:35 | |
| *** dims has joined #openstack-keystone | 02:37 | |
| *** mberlin1 has quit IRC | 02:51 | |
| *** mberlin has joined #openstack-keystone | 02:51 | |
| *** zhiyan is now known as zhiyan_ | 03:50 | |
| *** zhiyan_ is now known as zhiyan | 03:52 | |
| *** chandan_kumar has joined #openstack-keystone | 04:32 | |
| *** dstanek is now known as dstanek_zzz | 05:10 | |
| *** praneshp has joined #openstack-keystone | 05:10 | |
| *** stevemar has joined #openstack-keystone | 05:14 | |
| *** praneshp_ has joined #openstack-keystone | 05:48 | |
| *** praneshp has quit IRC | 05:49 | |
| *** praneshp_ is now known as praneshp | 05:49 | |
| jzl-ctrip | Hi, guys, I just ran into a issue in keystoneclient's tests,which is due to json.dumps behavior on dicts | 06:00 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Imported Translations from Transifex https://review.openstack.org/88503 | 06:01 |
| jzl-ctrip | in some tests, we use mox to fake a HTTP server, the requeste data is logged first, and checked against a laater request | 06:02 |
| jzl-ctrip | and all request data is seriallized in JSON.But json.dumps may return different results for a group of equal dicts | 06:03 |
| *** franco34 has joined #openstack-keystone | 06:17 | |
| *** stevemar has quit IRC | 06:33 | |
| jzl-ctrip | some tests assumpts json.dumps returning same string for any two equal dicts | 06:50 |
| jzl-ctrip | this paste showes how such tests would be breaked:> and all request data is seriallized in JSON.But json.dumps may return | 06:50 |
| jzl-ctrip | +different results for a group of equal dicts | 06:50 |
| jzl-ctrip | > and all request data is seriallized in JSON.But json.dumps may return | 06:50 |
| jzl-ctrip | +different results for a group of equal dicts | 06:50 |
| jzl-ctrip | http://paste.openstack.org/show/76484/ | 06:51 |
| *** praneshp has quit IRC | 06:53 | |
| *** franco34 has quit IRC | 06:57 | |
| openstackgerrit | A change was merged to openstack/python-keystoneclient: Update docs for auth_token middleware config options https://review.openstack.org/73875 | 07:37 |
| *** chandan_kumar has quit IRC | 08:50 | |
| *** henrynash has joined #openstack-keystone | 08:57 | |
| *** henrynash has joined #openstack-keystone | 08:57 | |
| *** chandan_kumar has joined #openstack-keystone | 09:08 | |
| *** bvandenh has joined #openstack-keystone | 09:16 | |
| *** henrynash has quit IRC | 09:26 | |
| *** zhiyan is now known as zhiyan_ | 09:32 | |
| *** leseb has joined #openstack-keystone | 09:40 | |
| *** Daviey has quit IRC | 09:41 | |
| *** Daviey has joined #openstack-keystone | 09:49 | |
| *** LTM has joined #openstack-keystone | 09:50 | |
| LTM | hi | 09:51 |
| LTM | i posted a week back on my devstack which exits on error "+ openstack role add --project --user" | 09:52 |
| LTM | does anyone here faced this or have a clue what causing this | 09:52 |
| LTM | under Ubuntu, the stack.sh works, but RHEL it exits | 09:52 |
| *** LTM has quit IRC | 09:58 | |
| *** chandan_kumar has quit IRC | 10:43 | |
| *** leseb has quit IRC | 10:44 | |
| *** leseb has joined #openstack-keystone | 10:44 | |
| *** leseb has quit IRC | 10:49 | |
| *** chandan_kumar has joined #openstack-keystone | 10:51 | |
| *** diegows has joined #openstack-keystone | 11:12 | |
| *** leseb has joined #openstack-keystone | 11:15 | |
| *** leseb has quit IRC | 11:19 | |
| *** erecio has joined #openstack-keystone | 12:11 | |
| *** leseb has joined #openstack-keystone | 12:15 | |
| *** leseb has quit IRC | 12:20 | |
| *** zhiyan_ is now known as zhiyan | 12:49 | |
| *** ativelkov has joined #openstack-keystone | 13:02 | |
| *** daneyon has joined #openstack-keystone | 13:06 | |
| *** daneyon has joined #openstack-keystone | 13:07 | |
| *** sergmelikyan has joined #openstack-keystone | 13:09 | |
| *** leseb has joined #openstack-keystone | 13:16 | |
| *** wchrisj has joined #openstack-keystone | 13:17 | |
| *** leseb has quit IRC | 13:21 | |
| *** leseb has joined #openstack-keystone | 13:32 | |
| *** dstanek_zzz is now known as dstanek | 13:42 | |
| *** nkinder has quit IRC | 13:42 | |
| *** richm has joined #openstack-keystone | 13:59 | |
| *** dstanek is now known as dstanek_zzz | 14:01 | |
| *** stevemar has joined #openstack-keystone | 14:08 | |
| *** rwsu has joined #openstack-keystone | 14:11 | |
| *** thedodd has joined #openstack-keystone | 14:11 | |
| *** doddstack has joined #openstack-keystone | 14:14 | |
| *** doddstack has quit IRC | 14:14 | |
| *** chandan_kumar has quit IRC | 14:14 | |
| *** doddstack has joined #openstack-keystone | 14:14 | |
| *** doddstack has quit IRC | 14:14 | |
| *** doddstack has joined #openstack-keystone | 14:15 | |
| *** doddstack has quit IRC | 14:16 | |
| *** thedodd has quit IRC | 14:17 | |
| *** dims has quit IRC | 14:27 | |
| *** dims has joined #openstack-keystone | 14:29 | |
| *** topol has joined #openstack-keystone | 14:33 | |
| *** chandan_kumar has joined #openstack-keystone | 14:35 | |
| *** david-lyle has joined #openstack-keystone | 14:36 | |
| *** nkinder has joined #openstack-keystone | 14:41 | |
| *** ayoung has joined #openstack-keystone | 14:42 | |
| *** dstanek_zzz is now known as dstanek | 14:51 | |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Add detailed federation configuration docs https://review.openstack.org/89220 | 15:14 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Add detailed federation configuration docs https://review.openstack.org/89220 | 15:15 |
| *** topol_ has joined #openstack-keystone | 15:15 | |
| *** bknudson1 has joined #openstack-keystone | 15:16 | |
| *** topol has quit IRC | 15:16 | |
| *** topol_ is now known as topol | 15:17 | |
| *** bknudson has quit IRC | 15:17 | |
| stevemar | thanks dolphm ! | 15:19 |
| *** ativelkov is now known as ativelkov_away | 15:23 | |
| *** ativelkov_away is now known as ativelkov | 15:23 | |
| *** chandan_kumar has quit IRC | 15:29 | |
| *** gyee has joined #openstack-keystone | 15:30 | |
| dstanek | is there ever a need to know what plugins are currently enabled? | 15:33 |
| dstanek | i need to know if mine is enabled, but I don't see any generic facilities to do this | 15:34 |
| *** browne has joined #openstack-keystone | 15:34 | |
| *** leseb has quit IRC | 15:35 | |
| *** daneyon has quit IRC | 15:36 | |
| bknudson1 | dstanek: extensions are advertised in v2.0/extensions | 15:36 |
| *** ativelkov has left #openstack-keystone | 15:36 | |
| dstanek | bknudson1: is that a list of only active ones? | 15:37 |
| *** nekron99 has joined #openstack-keystone | 15:37 | |
| bknudson1 | dstanek: it's whatever extensions have registered themselves... if the extension isn't enabled then it wouldn't register itself | 15:37 |
| bknudson1 | although the federation extension seems to register itself even when it's not enabled | 15:37 |
| dstanek | bknudson1: extensions are registered on import right? it's possible that the module is imported, but not in the pipeline | 15:38 |
| dstanek | like federation, my password rotation extension does that | 15:39 |
| bknudson1 | dstanek: they typically register themselves on import | 15:42 |
| *** nekron99 has left #openstack-keystone | 15:43 | |
| *** gokrokve has joined #openstack-keystone | 15:53 | |
| *** zhiyan is now known as zhiyan_ | 15:57 | |
| *** ativelkov has joined #openstack-keystone | 15:58 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Add detailed federation configuration docs https://review.openstack.org/89220 | 15:59 |
| bknudson1 | stevemar: is there a reason ^ is going to keystone and not the config reference -- http://docs.openstack.org/trunk/config-reference/content/ | 16:08 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Add detailed federation configuration docs https://review.openstack.org/89220 | 16:10 |
| stevemar | bknudson1, there were emails exchanged late last week, dolphm suggested placing it at keystone/docs, | 16:12 |
| stevemar | bknudson1, looking at the config reference now, it seems rather bare? just the sample conf and json files? | 16:12 |
| bknudson1 | ok, if docs wants it in the config guide at least they have the contents. | 16:12 |
| bknudson1 | stevemar: the documentation for keystone in general is pretty weak... | 16:13 |
| bknudson1 | I tried to work on the api reference over the weekend a little bit and wound up giving up. | 16:13 |
| dstanek | bknudson1: so i think i'm going to change my extension to register only if it is in the pipeline and then to check if it's active i can just see if it was registered | 16:15 |
| stevemar | bknudson1 at the summit, we should do a session on churning out docs :) i bet we would get pretty far | 16:15 |
| bknudson1 | stevemar: we'd need help from the doc team. | 16:15 |
| bknudson1 | dstanek: I think that's how most of the extensions work, only register if they're in the pipeline. | 16:16 |
| bknudson1 | dstanek: still, there's some oddities in how extension registration works. | 16:16 |
| bknudson1 | dstanek: for example, you could potentially register a v3 extension on the admin pipeline and not on public pipeline... so should a GET /v3/extensions on public return a different list than admin? | 16:18 |
| dstanek | bknudson1: hmmm, yeah ... there is something missing here | 16:19 |
| bknudson1 | (btw, there's no v3/extensions, was just using that as an example) | 16:21 |
| bknudson1 | I think we'll have extensions listed in /v3 response | 16:21 |
| bknudson1 | see https://review.openstack.org/#/c/87786/ | 16:21 |
| bknudson1 | I'll be working on this some more today | 16:22 |
| *** branen has quit IRC | 16:24 | |
| dstanek | bknudson1: on extensions? | 16:25 |
| bknudson1 | dstanek: on the extension advertisement for v3 | 16:25 |
| bknudson1 | first need to update the api spec with the current response for /v3 -- it just says TODO | 16:25 |
| dstanek | well, at least it's accurate | 16:26 |
| *** dstanek is now known as dstanek_zzz | 16:29 | |
| dolphm | bknudson1: v3 doesn't have a separate pipeline for public vs admin | 16:29 |
| dolphm | bknudson1: ... nor should it be deployed that way | 16:30 |
| *** leseb has joined #openstack-keystone | 16:36 | |
| openstackgerrit | Clint "SpamapS" Byrum proposed a change to openstack/keystone: Discourage use of pki_setup https://review.openstack.org/80819 | 16:39 |
| *** leseb has quit IRC | 16:40 | |
| *** leseb has joined #openstack-keystone | 16:45 | |
| stevemar | dolphm, bknudson1, also, i don't think there is any mechanism to see if an extension is v2 or v3 specific right now | 16:46 |
| dolphm | stevemar: GET /v2.0/extensions ? | 16:46 |
| stevemar | dolphm, that will include federation | 16:47 |
| stevemar | dolphm, which is very v3 specific (groups and all) | 16:48 |
| *** harlowja_away is now known as harlowja | 16:48 | |
| *** amcrn has joined #openstack-keystone | 16:49 | |
| *** leseb has quit IRC | 16:49 | |
| dolphm | stevemar: hrm, that's a bug then. extensions not supported by v2 shouldn't be advertised by v2 | 16:55 |
| dolphm | stevemar: the v2 implementation of /extensions is basically backwards though... the application should return an empty extensions response, and extensions should inject themselves into that response | 16:56 |
| *** franco has joined #openstack-keystone | 16:58 | |
| stevemar | dolphm, see https://bugs.launchpad.net/keystone/+bug/1308252 | 16:59 |
| uvirtbot | Launchpad bug 1308252 in keystone "No way to get extensions using V3 API" [Wishlist,In progress] | 16:59 |
| stevemar | the OS-fed extension is listed there | 17:00 |
| dolphm | stevemar: yeah, i disagree with the premise of the bug | 17:00 |
| bknudson1 | dolphm: I thought the v3 pipeline went into the public_api and admin_api but now I see that it's a separate pipeline | 17:06 |
| bknudson1 | I think we need a new function to register v3 extensions, then | 17:06 |
| dolphm | bknudson1: that's what paste does | 17:07 |
| dolphm | bknudson1: it composes middleware | 17:07 |
| bknudson1 | dolphm: so extensions shouldn't have to register themselves? | 17:08 |
| *** ativelkov has left #openstack-keystone | 17:12 | |
| dolphm | bknudson1: with what? | 17:14 |
| dolphm | bknudson1: and for what purpose? | 17:14 |
| bknudson1 | dolphm: so that applications know if the extension is available or not. | 17:15 |
| dolphm | bknudson1: api consumers? | 17:15 |
| bknudson1 | dolphm: right, consumers of the API can find out if the extension is there (and what version it is) | 17:16 |
| dolphm | bknudson1: i wouldnt call that "registration" | 17:18 |
| bknudson1 | dolphm: I don't call that registration either, registration is how the extension tells keystone that it's available so it can advertise it | 17:19 |
| bknudson1 | so keystone can advertise that the extension is available | 17:19 |
| dolphm | bknudson1:the process you're describing is backwards - keystone shouldn't be aware of extensions | 17:19 |
| *** esmute has left #openstack-keystone | 17:20 | |
| *** chandan_kumar has joined #openstack-keystone | 17:21 | |
| *** esmute has joined #openstack-keystone | 17:25 | |
| ayoung | dolphm, "keystone shouldn't be aware of extensions" why not? | 17:36 |
| ayoung | bknudson1, so paste does the import via the python mechansm for "string to python code" in the filter entry, and then actually calls that in the pipeline itself. | 17:42 |
| *** morganfainberg_Z is now known as morganfainberg | 17:42 | |
| ayoung | I put in the code that "self registers" with the extensions collection. I'd be willing to hear a better mechanism? | 17:42 |
| bknudson1 | maybe each extension should have its own paste pipeline? | 17:44 |
| ayoung | bknudson1, what would that buy us? | 17:45 |
| *** leseb has joined #openstack-keystone | 17:46 | |
| bknudson1 | then the extensions wouldn't be stuck under /v3, they could be /OS-FEDERATION for example | 17:46 |
| morganfainberg | mornin | 17:48 |
| ayoung | bknudson1, or just one extenstion pipeline | 17:49 |
| *** leseb has quit IRC | 17:50 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/identity-api: Document GET /v3 https://review.openstack.org/89394 | 17:59 |
| ayoung | morganfainberg, so..we were talking about extensions, and I started thinkg IofC again, and came across these: https://pypi.python.org/pypi/injector/ https://pypi.python.org/pypi/PyContainer | 17:59 |
| morganfainberg | ayoung, yeah reading up in the conversation now. | 18:00 |
| ayoung | bknudson1, we were discussing whether the links in that GET should be links to the modules. identity and so forth | 18:01 |
| *** dstanek_zzz is now known as dstanek | 18:01 | |
| morganfainberg | ayoung, only thing that makes me cringe is pycontainer "It is configured through XML file." | 18:01 |
| morganfainberg | ayoung, in principal i like something generic for this and the concept of self registration | 18:03 |
| *** gokrokve has quit IRC | 18:04 | |
| dstanek | ayoung: snakeguice ftw | 18:05 |
| ayoung | dstanek, have you worked with it before? | 18:06 |
| ayoung | morganfainberg, XML is out | 18:06 |
| ayoung | I want "configured in Python" | 18:06 |
| dstanek | ayoung: i wrote it | 18:07 |
| ayoung | with maybe a few components that can be optionally configured in a flat file like our current paste | 18:07 |
| ayoung | Ha! | 18:07 |
| dstanek | it's based on google guice and configured in Pythnon | 18:07 |
| ayoung | dstanek, Um...then that is on the shortlist | 18:07 |
| dstanek | or Python if you prefer | 18:07 |
| ayoung | No, I prefer Pythnon | 18:08 |
| dstanek | ayoung: i started a PoC or replacing our stuff with it | 18:08 |
| ayoung | dstanek, OK...so lets not start doing decorators as the main way we configure things. | 18:09 |
| dstanek | ayoung: if there is growing interest i'll get something workable to push | 18:09 |
| ayoung | I want to say we have 3 pieces of code: | 18:09 |
| ayoung | required, requiring, and the resolution | 18:09 |
| dstanek | ayoung: i do use decorator, but as a way to advertise what is required of what is provided | 18:09 |
| ayoung | dstanek, there absolutly is | 18:09 |
| ayoung | dstanek, that is an antipattern, really | 18:09 |
| dstanek | other code is need to do the wiring | 18:09 |
| dstanek | ayoung: how so? | 18:10 |
| ayoung | you want to be able to consume other people's code | 18:10 |
| ayoung | and they don't do hte decorator | 18:10 |
| ayoung | so registering a component needs to be done outside the code you are writing | 18:10 |
| dstanek | ayoung: you can still do that easily | 18:10 |
| ayoung | dstanek, yes, but decorator makes that a second class approach. I want it first class | 18:11 |
| dstanek | if you want to be injected with something you use the decorator to say what, but there are ways around it | 18:11 |
| ayoung | dstanek, it means you write your code to the framework, and that is wrong for reusability | 18:11 |
| ayoung | lets keep them separate | 18:11 |
| dstanek | ayoung: you are only declaring types in the decorator | 18:12 |
| ayoung | I know, you would never be able to tell that I felt that way based on the code I wrote in Keystone | 18:12 |
| dstanek | ayoung: https://code.google.com/p/snake-guice/source/browse/tests/system/test_api.py#139 | 18:13 |
| ayoung | dstanek, I realize it is possible, and that it makes of for a lack of type safety in Pyton. It just means that "my code is more equal than yours" when it comes to playing with guice | 18:13 |
| ayoung | dstanek, I'd rather have a separate pyton file that states: here is a component. It has a request/session/app lifespane. It gets name=NAME. It requires .... | 18:14 |
| ayoung | og, and its class is: pythong.class. | 18:14 |
| ayoung | or pythnon | 18:14 |
| dstanek | ayoung: you can do that with snakeguice, but you loose the benefit of see the type in the file itself | 18:15 |
| ayoung | dstanek, understood | 18:15 |
| ayoung | dstanek, I miss type safety. But we are in python. | 18:15 |
| ayoung | With types you can do some better things, I agree. http://adam.younglogic.com/2009/08/cpp-resolver/ | 18:16 |
| dstanek | ayoung: for me it's not about safety, it's about visibilty | 18:16 |
| ayoung | dstanek, all you get in python is "here are the names of the parameters to create the object" | 18:16 |
| dstanek | ayoung: that's the purpose of the decorator - to tell the injector what types you want created for you | 18:17 |
| ayoung | It really doesn't matter what other operations you provide, because you want to reuest other people's code. For instance, SQL Alechmy or LDAP connections | 18:17 |
| dstanek | ayoung: you do that with what's called providers | 18:18 |
| ayoung | dstanek, but then the code you write is *only* usable without your framework. | 18:18 |
| ayoung | Wrappers? | 18:18 |
| *** praneshp has joined #openstack-keystone | 18:18 | |
| ayoung | Or are they "factories" | 18:18 |
| dstanek | ayoung: nope, it's just good OO; yes providers are factories | 18:18 |
| ayoung | dstanek, does a provider always create a new instance? | 18:18 |
| dstanek | no, a provider is a class with a get method. everytime get is called it must return an instance, but not necessarily a new one | 18:19 |
| dstanek | you almost always want it to return a new one though | 18:20 |
| dstanek | it also has the concept of scopes, which give you singleton, request and custom scopes | 18:20 |
| dstanek | so the code doesn't have to worry about scopes - just the IoC framework | 18:21 |
| dstanek | i tried hard to make it work in a way that is framework agnostic for most the the application code | 18:21 |
| dstanek | there is really just a few small shims (adapters) needed to work with it | 18:22 |
| openstackgerrit | A change was merged to openstack/identity-api: Use --publish for openstack-doc-test https://review.openstack.org/89197 | 18:23 |
| ayoung | dstanek, POK, so those two things should be split up. | 18:33 |
| ayoung | you want both a pure factory method (creates a new instance) and a method that returns the cached instance, calling the factory if it does not exist | 18:33 |
| ayoung | It is the registration of the component that specifies the scope, not the code that creates the instance | 18:34 |
| ayoung | the default creator is "call the constructor with these parameters" | 18:34 |
| ayoung | and "these parameters" are fteched from other accessor functions | 18:35 |
| dstanek | ayoung: you are correct and that's how it works | 18:36 |
| ayoung | cool | 18:36 |
| topol | dstanek, in you patch who is setting region.is_configured ??? | 18:36 |
| dstanek | topol: what patch? | 18:36 |
| topol | dstanek, https://review.openstack.org/#/c/84052/5/keystone/common/cache/core.py | 18:36 |
| dstanek | topol: ah, that's the dogpile API | 18:37 |
| dstanek | it is doing that | 18:37 |
| dstanek | topol: i think morganfainberg was worried that I was using an API newer that what we required in the requirements.txt | 18:38 |
| topol | dstanek, any idea whi morganfainberg felt like previously he had to use if 'backend' not in region.__dict__: | 18:38 |
| morganfainberg | dstanek, we're waiting for requirements to merge | 18:38 |
| morganfainberg | once that goes we can merge that | 18:38 |
| topol | dstanek, OK , that makes sense | 18:38 |
| dstanek | morganfainberg: nice | 18:39 |
| morganfainberg | https://review.openstack.org/#/c/84200/ | 18:39 |
| topol | cause I figured, morganfainberg would have certainly used the simple check if it was avail :-) | 18:39 |
| morganfainberg | topol, i contributed the code to dogpile to make the 'backend' not in region.__dict__ a property of the region :) | 18:39 |
| morganfainberg | topol, so, as soon as we update global reqs, we can get to use the new code | 18:40 |
| topol | morganfainberg, outstanding!!! Thanks | 18:40 |
| dstanek | is it just me or it gerrit automatically logging users out? | 18:45 |
| dstanek | topol: did my comment here make sense? https://review.openstack.org/#/c/73368/7/keystone/identity/backends/sql.py | 18:46 |
| topol | dtsanek, your response to my comment made sense. Did you update the comment ina subsequent patch or not yet? | 18:48 |
| topol | dstanek, what did you do to piss off jenkins :-). I noticed it like minus oned all your patches to death | 18:48 |
| dstanek | topol: that's what i'm doing now. bknudson1 gave me an idea on how it check for it | 18:49 |
| ayoung | dstanek, morganfainberg OK, lets use snake-guice as the starting point for any IofC work we do in Keystone. It looks right to me, and we have a desperate need for something like that | 18:49 |
| topol | dstanek, OK, cool! | 18:49 |
| dstanek | topol: ha, it was that damn neutron bug | 18:49 |
| topol | dtsanek, its like a line from Seinfeld... "Neumann!!" err "Neutron!!!" | 18:50 |
| dstanek | ayoung: i'll get you something to start poking at - i started by trying to replace the internals of our dependency module, but just started to rewrite things | 18:50 |
| ayoung | dstanek, token provider is first | 18:51 |
| ayoung | we need to build a pipeline there | 18:51 |
| ayoung | and it stands out as the odd-man in our current dependency module. | 18:51 |
| ayoung | dstanek, our notifications somehow need it, too. | 18:53 |
| *** chandan_kumar has quit IRC | 18:55 | |
| *** chandan_kumar has joined #openstack-keystone | 18:56 | |
| dstanek | ayoung: the one thing i can't model is the circular dependency we have | 18:58 |
| *** gokrokve has joined #openstack-keystone | 18:58 | |
| ayoung | dstanek, that is a problem in most code, too. Usually, you need a proxy | 18:58 |
| dstanek | others have asked me to add that like Google Guice's feature, but i think that's bad design and I don't want to allow it :-) | 18:58 |
| ayoung | a->b->a so first create proxy(b), then create a with proxy(b), finally, when proxy(b) tries to access a call through a proxy as well... | 18:59 |
| ayoung | notifier might help break most of our circulars, too | 19:00 |
| *** browne has quit IRC | 19:00 | |
| *** browne has joined #openstack-keystone | 19:00 | |
| *** wchrisj has quit IRC | 19:00 | |
| *** browne1 has joined #openstack-keystone | 19:01 | |
| ayoung | dstanek, so circular, as I recall, was only necessary because identity and assignment referred to each other. We should not need that, as identity should not need to talk directly to assignmnet | 19:02 |
| dstanek | ayoung: i don't remember because i brought it up a while ago - at the time morganfainberg said it would probably be going away naturally anyway | 19:03 |
| ayoung | dstanek, I'm looking, but it might even be gone already | 19:03 |
| *** browne has quit IRC | 19:04 | |
| ayoung | bknudson1, dstanek, morganfainberg, this is a prereq to compression and should be pushed on a head. https://review.openstack.org/#/c/79411/6 | 19:13 |
| *** arunkant has joined #openstack-keystone | 19:15 | |
| morganfainberg | ayoung, ++ will look at post lunch | 19:17 |
| *** wchrisj has joined #openstack-keystone | 19:18 | |
| ayoung | dstanek, so...the main (only?) thing that identity requires the assignment API for is the Domain enumeration, which you could argue should not be part of the Assignment API anyway. | 19:22 |
| ayoung | and there are comparable things from assignment into identity, revolving mostly around groups. | 19:24 |
| *** dims has quit IRC | 19:25 | |
| *** dims has joined #openstack-keystone | 19:27 | |
| *** erecio has quit IRC | 19:33 | |
| *** erecio has joined #openstack-keystone | 19:33 | |
| *** chandan_kumar has quit IRC | 19:34 | |
| *** leseb has joined #openstack-keystone | 19:40 | |
| bknudson1 | Can someone else try this: tox -e py27 keystone.tests.test_sql_upgrade.VersionTests.test_extension_initial | 19:44 |
| morganfainberg | sec will try in a moment | 19:44 |
| dolphm | bknudson1: AttributeError: 'NoneType' object has no attribute 'startswith' http://pasteraw.com/3y16tiiuo562fuavfrmyc7ligk9uqw8 | 19:45 |
| morganfainberg | dolphm,bknudson1 same | 19:45 |
| *** leseb has quit IRC | 19:46 | |
| bknudson1 | dolphm morganfainberg: thanks, wanted to make sure it wasn't just me. | 19:46 |
| *** dhellmann has joined #openstack-keystone | 19:47 | |
| morganfainberg | bknudson1, we must no longer be setting the default connection string in all test-cases | 19:47 |
| dhellmann | morganfainberg: have a sec for a test question? | 19:47 |
| morganfainberg | dhellmann, sure | 19:48 |
| dhellmann | I'm having some trouble with the logic in http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/ksfixtures/database.py#n79 | 19:48 |
| bknudson1 | maybe CONF isn't getting CONF'd | 19:48 |
| morganfainberg | dhellmann, the auto-find and import sql.py files? | 19:49 |
| dhellmann | I'm trying to package keystone from master, and run the tests. In order to run the tests in the virtualenv I'm creating, I change tox.ini to set a couple of variables differently: http://paste.openstack.org/show/76559/ | 19:49 |
| *** stevemar has quit IRC | 19:49 | |
| dhellmann | morganfainberg: yeah | 19:49 |
| dhellmann | it seems that setting usedevelop=False breaks that function | 19:49 |
| morganfainberg | oh oh i see how it could. | 19:50 |
| morganfainberg | doh* | 19:50 |
| *** stevemar has joined #openstack-keystone | 19:50 | |
| *** wchrisj has quit IRC | 19:50 | |
| dhellmann | because it finds a path for the module with a full path, and the / becomes a . and then import complains that '.home.whatever.some.long.path' has an empty module name | 19:50 |
| dhellmann | at the front there | 19:50 |
| dhellmann | morganfainberg: so we could fix it a couple of ways, either by doing more smart work with the paths, or by converting those modules to be loaded with stevedore | 19:51 |
| dhellmann | morganfainberg: before I submit a patch, I thought I'd see which you all would prefer | 19:51 |
| morganfainberg | dhellmann, the latter would be better | 19:51 |
| morganfainberg | dhellmann, i would rather use stevedore for all of our backends eventually, it makes sense that the tests should be the same | 19:52 |
| dhellmann | ok, I concur, but didn't know if there was some reason it was done this way to begin with | 19:52 |
| morganfainberg | dhellmann, we haven't converted stuff to stevedore yet, afaict that is the reason | 19:52 |
| dhellmann | morganfainberg: ok, I'll go see about that -- would it help if I file a bug, too? | 19:52 |
| morganfainberg | dhellmann, please do! | 19:53 |
| dhellmann | morganfainberg: sure thing, thanks! | 19:53 |
| morganfainberg | dhellmann, awesome :) | 19:53 |
| dhellmann | morganfainberg: do you mind if I just paste this irc chat into the bug description? | 19:54 |
| morganfainberg | go right ahead | 19:54 |
| dhellmann | morganfainberg: https://bugs.launchpad.net/keystone/+bug/1310768 | 19:54 |
| uvirtbot | Launchpad bug 1310768 in keystone "keystone tests fail unless tox is configured "just so"" [Undecided,New] | 19:55 |
| *** thedodd has joined #openstack-keystone | 19:55 | |
| morganfainberg | dhellmann, looks good to me | 19:55 |
| ayoung | bknudson1, I'm trying to shepherd the comporession patch on through. I made the changes you suggested in Set 5 https://review.openstack.org/#/c/79411/5 which lead to me having to put in a stub for keeping the old method name around. | 19:57 |
| dhellmann | morganfainberg: wow, lots of backends :-) | 19:57 |
| morganfainberg | dhellmann, yep | 19:57 |
| morganfainberg | dhellmann, :) | 19:57 |
| morganfainberg | biggest win with stevedore, custome backends can be installed with the entrypoint logic stuff | 19:58 |
| *** amcrn has quit IRC | 19:58 | |
| morganfainberg | dhellmann, big win for me (personally). | 19:58 |
| dhellmann | morganfainberg: how about a patch that registers them, without changing the core code to use them yet? I'm not sure I'm up to that big of a change this week... | 19:59 |
| morganfainberg | dhellmann, small steps of course | 19:59 |
| morganfainberg | dhellmann, i wouldn't want it all changed at once | 19:59 |
| dhellmann | morganfainberg: ok, that much I can do :-) | 19:59 |
| morganfainberg | dhellmann, besides, we shouldn't expect _you_ to be the only one working on it. | 19:59 |
| bknudson1 | ayoung: stub? | 20:01 |
| ayoung | bknudson1, yeah...or am I thinking of the follow on patch...wait one | 20:01 |
| ayoung | bknudson1, I was thinking follow on: https://review.openstack.org/#/c/71181/27/keystoneclient/common/cms.py line 287 | 20:02 |
| ayoung | so https://review.openstack.org/#/c/79411/5 should have all of your recommendations covered | 20:02 |
| bknudson1 | ayoung: ok, now just have to figure out what it's for. | 20:03 |
| ayoung | bknudson1, the patch? | 20:04 |
| bknudson1 | why did we just add universal newlines and now we're removing it again | 20:04 |
| ayoung | universal newlines implies you are doing text only IPC (pipes between parent and child) | 20:05 |
| bknudson1 | oh, it mucks with the input? | 20:05 |
| ayoung | yeah | 20:05 |
| bknudson1 | ok, makes sense | 20:05 |
| ayoung | bknudson1, I was burnt by it when I went to do compression on python33 | 20:05 |
| ayoung | py33 does strings very different from py27 and popen assumes that "universal_newlines" means "it is all string" but for compression, it is binary data | 20:06 |
| ayoung | I split it out from the follow on patch that does the compression because it was a stand along concept, and easier to understand in its own patch, but really only needed for compression | 20:07 |
| bknudson1 | "all line endings will be converted to '\n'" -- so it probably causes a \r\n to switch to \n or something. | 20:08 |
| *** erecio has quit IRC | 20:09 | |
| *** wchrisj has joined #openstack-keystone | 20:10 | |
| *** erecio has joined #openstack-keystone | 20:10 | |
| *** erecio has quit IRC | 20:10 | |
| *** erecio has joined #openstack-keystone | 20:11 | |
| *** leseb has joined #openstack-keystone | 20:13 | |
| *** erecio has quit IRC | 20:14 | |
| *** erecio has joined #openstack-keystone | 20:14 | |
| *** erecio has quit IRC | 20:15 | |
| *** erecio has joined #openstack-keystone | 20:15 | |
| ayoung | bknudson1, that is true, and it corrupts binary data | 20:15 |
| *** browne1 has quit IRC | 20:15 | |
| morganfainberg | ayoung, do we have a BP we're using for the work? should this be associated with the compressed tokens one (if we have it)? | 20:16 |
| bknudson1 | morganfainberg: the follow-on patch has Blueprint: compress-tokens | 20:16 |
| ayoung | https://blueprints.launchpad.net/python-keystoneclient/+spec/compress-tokens | 20:17 |
| morganfainberg | bknudson1, ah. | 20:17 |
| morganfainberg | this probably should be linked to the BP as well, but not going to block on that. | 20:17 |
| morganfainberg | ayoung, looks like most of the code is mechanisms around the bytearray useage | 20:19 |
| morganfainberg | ayoung, am i wrong? | 20:19 |
| morganfainberg | some ' vs " changes for consistency | 20:19 |
| *** daneyon has joined #openstack-keystone | 20:21 | |
| bknudson1 | ayoung morganfainberg: posted my comments on https://review.openstack.org/#/c/79411/ | 20:21 |
| morganfainberg | bknudson1, i agree with the comments 100% | 20:26 |
| morganfainberg | bknudson1, the decode one was the one i was actually going to make (but you beat me to it) | 20:26 |
| dhellmann | morganfainberg: are the backends under keystone.common different from the ones not in common? | 20:31 |
| dhellmann | morganfainberg: the names don't seem to follow the same pattern | 20:31 |
| ayoung | the ' to " was done as a response to your code revewi comments. Grumble Grumble. | 20:31 |
| bknudson1 | I commented on one line to use ' | 20:32 |
| ayoung | I agre on the output one, though...let me get that right.... | 20:32 |
| morganfainberg | dhellmann, hmm. possibly different | 20:32 |
| dhellmann | morganfainberg: ok, I can do those by hand | 20:32 |
| ayoung | bknudson1, yes. but the comment indicated that it should be consistant throughout.... | 20:32 |
| morganfainberg | dhellmann, the ones in common will (hopefully) this cycle move to the oslocache stuff | 20:32 |
| dhellmann | morganfainberg: should I just leave them out? | 20:33 |
| bknudson1 | ayoung: I agree it should be consistent throughout since that's in the keystone coding guideline. | 20:33 |
| * ayoung just grumlbing, but actually agrees | 20:33 | |
| morganfainberg | dhellmann, i'd do them by hand for now | 20:33 |
| dhellmann | ok | 20:33 |
| morganfainberg | dhellmann, if it's not too much extra | 20:33 |
| morganfainberg | work* | 20:33 |
| morganfainberg | doens't hurt to be consistent, might justify renaming them and aliasing the old names to be more consistent in either casew | 20:34 |
| morganfainberg | dhellmann, but just adding them now should be sufficient (other changes down the line) | 20:34 |
| dhellmann | morganfainberg: ok, there are just a few -- the others I have a script to find | 20:35 |
| morganfainberg | dhellmann, cool. thanks for doing this :) | 20:35 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Fix sql_upgrade tests run by themselves https://review.openstack.org/89415 | 20:37 |
| morganfainberg | bknudson1, +2 LGTM ^ | 20:38 |
| bknudson1 | morganfainberg: oh oh... might have posted that too soon. | 20:40 |
| bknudson1 | now the tests run by themselves but other tests don't run. | 20:40 |
| morganfainberg | bknudson1, really? | 20:41 |
| bknudson1 | "table credential already exists ..." from keystone.tests.test_sql_upgrade.SqlUpgradeTests.test_upgrade_service_enabled_cols | 20:41 |
| morganfainberg | that change shouldn't... shouldn't break anything? | 20:41 |
| morganfainberg | hmm | 20:41 |
| morganfainberg | oh i know why | 20:41 |
| morganfainberg | the fixture was designed to create the in-mem db | 20:42 |
| morganfainberg | we need to call the _initialize_sql_session() function in the database fixture module | 20:43 |
| morganfainberg | not use the actual fixture | 20:43 |
| bknudson1 | so they can't use the fixture | 20:43 |
| morganfainberg | bknudson1, correct. | 20:43 |
| morganfainberg | make this non-internal https://github.com/openstack/keystone/blob/master/keystone/tests/ksfixtures/database.py#L59 or make a db_setup fixture that just calls that | 20:44 |
| bknudson1 | I just added the fixture so that it would call the function. | 20:44 |
| morganfainberg | yeah, the fixture does the whole reflection db creation | 20:44 |
| dstanek | yeah, it does lots of work | 20:45 |
| bknudson1 | some kind of composite fixture?? | 20:45 |
| morganfainberg | bknudson1, could make a DBSetup fixture that the Database fixture inherits | 20:46 |
| morganfainberg | bknudson1, the dbsetup fixture could just call that setup function | 20:46 |
| bknudson1 | I think fixtures can do useFixture. | 20:46 |
| morganfainberg | bknudson1, oh if it can, cool. | 20:46 |
| bknudson1 | seems like overkill | 20:46 |
| morganfainberg | bknudson1, not sure which is better, a setup-specific fixture or just directly calling the function | 20:47 |
| dstanek | yeah, they can use useFixture | 20:47 |
| dstanek | bknudson1: not a composite, but creates the full DB schema before each test and removes it after | 20:47 |
| bknudson1 | I'll just make initialize_sql_session and call that... should be safe | 20:48 |
| morganfainberg | sounds good to me | 20:48 |
| bknudson1 | I'll even try it out first this time | 20:48 |
| morganfainberg | hehe | 20:49 |
| *** erecio has quit IRC | 20:54 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Fix sql_upgrade tests run by themselves https://review.openstack.org/89415 | 20:54 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/keystone: Register all backend classes as entry points https://review.openstack.org/89419 | 21:02 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/keystone: Register all backend classes as entry points https://review.openstack.org/89419 | 21:05 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/keystone: Move stevedore to a production requirement https://review.openstack.org/89420 | 21:08 |
| *** browne has joined #openstack-keystone | 21:09 | |
| ayoung | bknudson1, morganfainberg so....the decode does not make sense. You might be making this call with binaryd data. but err is the error message, so you need to decode it to be able to print. | 21:14 |
| morganfainberg | ayoung, the default for that method should return the same as current. if you want binary back it should be requested as such... or a separate method | 21:14 |
| bknudson1 | ayoung: cms_sign_text decodes output | 21:15 |
| bknudson1 | as does cms_verify in auth_token | 21:15 |
| ayoung | bknudson1, right now, yes, but there is going to be a step inbetween in the future | 21:15 |
| ayoung | https://review.openstack.org/#/c/71181/ | 21:16 |
| bknudson1 | ayoung: I'd be ok if the docstring was updated to say that the output is bytes or whatever. | 21:16 |
| ayoung | bknudson1, ++ I can get behind that | 21:16 |
| morganfainberg | i guess we are currently the only consumers of this | 21:18 |
| morganfainberg | so sure | 21:18 |
| ayoung | morganfainberg, bknudson1 so...even err is not decoded unless we are appending our own error message | 21:23 |
| bknudson1 | that's weird | 21:23 |
| morganfainberg | ayoung, hm. | 21:23 |
| ayoung | bknudson1, yeah | 21:23 |
| ayoung | https://review.openstack.org/#/c/79411/6/keystoneclient/common/cms.py | 21:23 |
| morganfainberg | ayoung, i don't like behavior that changes like that | 21:23 |
| ayoung | look at the | 21:23 |
| dstanek | looking at that patch now and part of what confuses me is that i don't know what should return bytes vs. string | 21:23 |
| ayoung | _process_communicate_handle_oserror around line 75 | 21:24 |
| ayoung | dstanek, this is the confusion caused by py27 py33 in the same code base | 21:24 |
| ayoung | output, err = process.communicate(data) | 21:24 |
| *** topol has quit IRC | 21:24 | |
| ayoung | in some cases output is text, in others binary, depending on what is processed. So we assume binary for all cases | 21:25 |
| ayoung | I could do something like: | 21:25 |
| ayoung | if err: err = err.decode('utf-8') | 21:25 |
| ayoung | right before the return call at line 96 | 21:26 |
| ayoung | then err would always be text | 21:26 |
| bknudson1 | ayoung: I like that change, err should always be text. | 21:27 |
| ayoung | bknudson1, OK. I can make that happen. | 21:28 |
| dstanek | ayoung: i like the idea of hiding away all encoding/decoding in _process_communicate_handle_oserror - so nothing else has to change | 21:29 |
| dstanek | would that be possible? | 21:29 |
| ayoung | dstanek, nope | 21:29 |
| ayoung | dstanek, it needs to return binary | 21:29 |
| dstanek | who is expecting the binary | 21:29 |
| ayoung | dstanek, in comporessed, we take tex, sign it into a binary format, compress it, then base64. To verify, reverse the process | 21:30 |
| ayoung | https://review.openstack.org/#/c/71181/27/keystoneclient/common/cms.py dstanek | 21:30 |
| ayoung | see line 175 ish | 21:31 |
| *** wchrisj has quit IRC | 21:31 | |
| ayoung | dstanek, but error comes back as text, and we need to actually inspect the error message for proper error handling. openssl cms bascially returns a single error code, and we need the text to know if it is a cert missing, or something wrong with the input | 21:32 |
| *** franco has quit IRC | 21:32 | |
| dstanek | what uses the output from cms_verify? | 21:32 |
| *** jamielennox|away is now known as jamielennox | 21:32 | |
| *** franco has joined #openstack-keystone | 21:32 | |
| ayoung | Oooh, just realized who https://github.com/mathrock is. Glad to see he is able to contribute directly. | 21:33 |
| ayoung | dstanek, I think I mix in error processing for that to the big patch. That is something else that can be split out. | 21:34 |
| morganfainberg | ayoung, hahah | 21:34 |
| *** openstackstatus has quit IRC | 21:35 | |
| *** openstackstatus has joined #openstack-keystone | 21:36 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Remove _factory methods from auth plugins https://review.openstack.org/81985 | 21:38 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/keystone: Move mutable parameter checking into federation https://review.openstack.org/87849 | 21:43 |
| bknudson1 | global state is a disaster waiting to happen | 21:44 |
| jamielennox | bknudson1: in relation to? | 21:44 |
| morganfainberg | bknudson1, global state? | 21:44 |
| bknudson1 | testing. | 21:44 |
| bknudson1 | e.g., the extension registry | 21:44 |
| bknudson1 | same with the dependency registry | 21:45 |
| jamielennox | bknudson1: ok - yea completely agree | 21:46 |
| openstackgerrit | ayoung proposed a change to openstack/python-keystoneclient: replace double quotes with single. https://review.openstack.org/89428 | 21:46 |
| openstackgerrit | ayoung proposed a change to openstack/python-keystoneclient: remove universal_newlines https://review.openstack.org/79411 | 21:46 |
| dstanek | bknudson1: extension registry? | 21:47 |
| ayoung | bknudson1, that is only modified at startup | 21:47 |
| bknudson1 | ayoung: how about when running tests? then you don't know when it's going to be modified | 21:47 |
| jamielennox | bknudson1: i'd love to kill that dependency resolution - it's unecessary | 21:48 |
| dstanek | jamielennox: what dependency resolution? | 21:48 |
| bknudson1 | dstanek: there's an extension registry -- http://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/extension.py | 21:48 |
| ayoung | jamielennox, so we were talking about using dstanek 's project in its place: nake-guice | 21:48 |
| jamielennox | @provides @depends | 21:48 |
| dstanek | jamielennox: i like the idea there i just don't like that they are automatically created | 21:49 |
| jamielennox | dstanek's project? | 21:49 |
| dstanek | jamielennox: https://code.google.com/p/snake-guice/ | 21:49 |
| dstanek | i think i need to dust off the docs | 21:49 |
| *** franco has quit IRC | 21:56 | |
| *** franco has joined #openstack-keystone | 21:57 | |
| openstackgerrit | ayoung proposed a change to openstack/python-keystoneclient: Compressed Signature and Validation https://review.openstack.org/71181 | 22:00 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Allow registering a v3 extension https://review.openstack.org/89429 | 22:01 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Register v3 extensions as v3 extensions https://review.openstack.org/89430 | 22:01 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Advertise extensions for v3 https://review.openstack.org/87786 | 22:01 |
| *** franco has quit IRC | 22:02 | |
| *** franco has joined #openstack-keystone | 22:02 | |
| bknudson1 | think we could register the extension when the router is created rather than on import? | 22:03 |
| ayoung | jamielennox, so...for the client Kerberos plugin, I prefer "external" to "kerberos" as the method. It works without server side changes | 22:05 |
| ayoung | bknudson1, that is fine, but how are we going to know if the router is created? | 22:06 |
| ayoung | right now, when the import happens, we register the extension, and that is what creates the router | 22:06 |
| jamielennox | ayoung: i don't mind - i wanted kerberos because it was explicit and we could fall back to doing kerberos i python | 22:08 |
| ayoung | jamielennox, yeah, but kerberos plugin is much different from external. I am not certain we are even going to get the python version, and if we don't we end up having to duplicate each of the "eternal" plugins just to change their method strings | 22:09 |
| ayoung | server side plug in is much different | 22:09 |
| bknudson1 | ayoung: the router is referenced in the paste pipeline, e.g., http://git.openstack.org/cgit/openstack/keystone/tree/etc/keystone-paste.ini#n46 | 22:09 |
| dstanek | bknudson1, ayoung: i just implemented my own factory method and use that to register my extension - that gets called by paste | 22:09 |
| bknudson1 | dstanek: why don't we do that will all the extensions? | 22:09 |
| dstanek | bknudson1: we could probably do that. want me to make a patch? | 22:10 |
| *** franco has quit IRC | 22:10 | |
| bknudson1 | dstanek: yes, give it a shot | 22:10 |
| bknudson1 | dstanek: I think we'll have to use the 'factory' method since that's what the paste file refs... | 22:10 |
| bknudson1 | unless we want to change the paste file | 22:11 |
| bknudson1 | dstanek: and I don't know why the v3 extensions are registering as admin and public extensions. | 22:11 |
| *** leseb has quit IRC | 22:12 | |
| dstanek | bknudson1: probably copy/paste code - i'll put together a quick patch to start poking at | 22:16 |
| bknudson1 | dstanek: https://review.openstack.org/#/c/89430/ registers v3 extensions as v3 extensions | 22:17 |
| bknudson1 | I tried writing unit tests for extension registration but it's global state so affects everything & pretty much untestable | 22:18 |
| dstanek | ah, nice - i'll base my work on that review | 22:18 |
| dstanek | how does copyright work in relation to moving logic around? if you have a file that has a copyright headers and move the contents into a different why what needs to happen (if anything)? | 22:26 |
| dstanek | i'm thinking about this review https://review.openstack.org/#/c/87849/2 | 22:26 |
| bknudson1 | dstanek: those parts were just moved and now they're moving back. | 22:34 |
| bknudson1 | like a hot potato | 22:34 |
| dstanek | interesting...so someone added them to a new file and then added their copyright? now they are moving back? | 22:38 |
| bknudson1 | dstanek: https://review.openstack.org/#/c/72581/ | 22:41 |
| *** thedodd has quit IRC | 22:42 | |
| dstanek | bknudson1: this code looks be original and copyrighted to CERN https://review.openstack.org/#/c/84389/13/keystone/tests/test_v3_controller.py | 22:44 |
| dstanek | in the new review it is moved is an existing file without CERNs copyright | 22:45 |
| bknudson1 | I can't believe anyone could be so callous about intellectual property rights! | 22:45 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Advertise extensions for v3 https://review.openstack.org/87786 | 22:46 |
| dstanek | bknudson1: ha ha, i agree! | 22:46 |
| dstanek | i really don't like the fact that the starting point an extension is a router | 22:50 |
| *** nkinder_ has joined #openstack-keystone | 22:52 | |
| *** nkinder has quit IRC | 22:55 | |
| *** david-lyle has quit IRC | 23:03 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Add request/access token and consumer support for keystoneclient https://review.openstack.org/81980 | 23:19 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Authenticate via oauth https://review.openstack.org/81981 | 23:20 |
| *** gokrokve has quit IRC | 23:27 | |
| stevemar | dstanek, i thought lbragstad1 was going to leverage the immutable/mutable param checking | 23:27 |
| stevemar | dstanek, bknudson1 could I get eyes on https://review.openstack.org/#/c/81980/5 ? I made a change to not depend on oauthlib being installed, and would appreciate some feedback in the comments | 23:30 |
| stevemar | dstanek, bknudson1 now that https://review.openstack.org/#/c/80698/ has merged, we'll be able to avoid gate breaks in the future :) | 23:30 |
| openstackgerrit | A change was merged to openstack/keystone: add dependencies of keystone dev-enviroment https://review.openstack.org/80474 | 23:37 |
| *** nkinder_ has quit IRC | 23:41 | |
| *** topol has joined #openstack-keystone | 23:42 | |
| jamielennox | stevemar: oh - was that there immutable work there on purpose? | 23:43 |
| jamielennox | bknudson1, dstanek: i didn't realize that those had just been moved | 23:44 |
| jamielennox | i was looking at moving controllers over to pecan and therefore cleaning them up first and wanted to remove everything that isn't absolutely necessary | 23:45 |
| jamielennox | if there is a purpose for that work then i'm happy to have that patch -1/-2ed - though if there is a purpose to that work i would really expect there to be at least one dependant patch rather than moving it speculatively | 23:48 |
| *** openstackgerrit has quit IRC | 23:50 | |
| *** openstackgerrit has joined #openstack-keystone | 23:50 | |
| *** franco has joined #openstack-keystone | 23:52 | |
| *** gokrokve has joined #openstack-keystone | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!