| *** gokrokve has joined #openstack-keystone | 00:06 | |
| *** amerine has joined #openstack-keystone | 00:11 | |
| *** gokrokve has quit IRC | 00:11 | |
| *** amerine has quit IRC | 00:15 | |
| *** shakamunyi has joined #openstack-keystone | 00:24 | |
| *** diegows has quit IRC | 00:27 | |
| *** diegows has joined #openstack-keystone | 00:55 | |
| *** HenryG_afk is now known as HenryG | 00:57 | |
| *** shakamunyi_ has joined #openstack-keystone | 01:03 | |
| *** gokrokve has joined #openstack-keystone | 01:06 | |
| *** gokrokve has quit IRC | 01:10 | |
| *** amerine has joined #openstack-keystone | 01:12 | |
| *** amerine has quit IRC | 01:16 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Allow retrying some failed requests https://review.openstack.org/118004 | 01:42 |
|---|---|---|
| openstackgerrit | A change was merged to openstack/keystone: Implement validation on Assignment V3 API https://review.openstack.org/86484 | 01:43 |
| openstackgerrit | A change was merged to openstack/keystone: Add string id type validation https://review.openstack.org/108862 | 01:43 |
| openstackgerrit | A change was merged to openstack/keystone: Endpoint table is missing reference to region table https://review.openstack.org/113183 | 01:44 |
| openstackgerrit | A change was merged to openstack/keystone: Add index for actor_id in assignments table. https://review.openstack.org/117541 | 01:44 |
| *** amerine has joined #openstack-keystone | 02:13 | |
| *** amerine has quit IRC | 02:17 | |
| morganfainberg | jamielennox you here? | 02:32 |
| morganfainberg | jamielennox, if so: https://review.openstack.org/#/c/117890/ could use some eyes (you're the only one who can approve changes to it) | 02:33 |
| *** diegows has quit IRC | 02:36 | |
| *** jimhoagland has joined #openstack-keystone | 03:00 | |
| *** gokrokve has joined #openstack-keystone | 03:06 | |
| *** gokrokve has quit IRC | 03:11 | |
| *** amerine has joined #openstack-keystone | 03:13 | |
| *** bknudson has quit IRC | 03:15 | |
| *** amerine has quit IRC | 03:18 | |
| *** jimhoagland has quit IRC | 03:32 | |
| *** jimhoagland has joined #openstack-keystone | 03:33 | |
| *** jimhoagland has quit IRC | 04:04 | |
| *** gokrokve has joined #openstack-keystone | 04:06 | |
| *** gokrokve has quit IRC | 04:11 | |
| *** amerine has joined #openstack-keystone | 04:14 | |
| *** amerine has quit IRC | 04:19 | |
| *** stevemar has joined #openstack-keystone | 04:32 | |
| openstackgerrit | A change was merged to openstack/keystone: Fix token flush fails with recursion depth exception https://review.openstack.org/117869 | 04:47 |
| *** shakamunyi_ has quit IRC | 04:47 | |
| *** shakamunyi has quit IRC | 04:47 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Allow returning None from an auth plugin https://review.openstack.org/118008 | 05:02 |
| *** gokrokve has joined #openstack-keystone | 05:06 | |
| *** stevemar has quit IRC | 05:10 | |
| *** gokrokve has quit IRC | 05:10 | |
| *** stevemar has joined #openstack-keystone | 05:25 | |
| *** jimhoagland has joined #openstack-keystone | 05:28 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/identity-api: Clean up endpoint grouping API https://review.openstack.org/117028 | 05:38 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/identity-api: Add SAML generation route to OS-FEDERATION https://review.openstack.org/113998 | 05:41 |
| *** shakamunyi has joined #openstack-keystone | 05:44 | |
| *** ukalifon has joined #openstack-keystone | 05:44 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Transform a Keystone token to a SAML assertion https://review.openstack.org/110542 | 05:46 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Create SAML generation route and controller https://review.openstack.org/114138 | 05:46 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Create SAML generation route and controller https://review.openstack.org/114138 | 05:48 |
| *** shakamunyi has quit IRC | 05:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Imported Translations from Transifex https://review.openstack.org/111920 | 06:05 |
| *** gokrokve has joined #openstack-keystone | 06:06 | |
| *** gokrokve has quit IRC | 06:11 | |
| *** amerine has joined #openstack-keystone | 06:15 | |
| *** amerine has quit IRC | 06:22 | |
| *** gokrokve has joined #openstack-keystone | 07:06 | |
| *** gokrokve has quit IRC | 07:11 | |
| *** amerine has joined #openstack-keystone | 07:18 | |
| *** henrynash has joined #openstack-keystone | 07:21 | |
| *** amerine has quit IRC | 07:22 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Transform a Keystone token to a SAML assertion https://review.openstack.org/110542 | 07:23 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Create SAML generation route and controller https://review.openstack.org/114138 | 07:24 |
| *** jimhoagland has quit IRC | 07:33 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Implement validation on Policy V3 API https://review.openstack.org/104065 | 07:40 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Implement validation on Credential V3 https://review.openstack.org/98522 | 07:41 |
| *** rm_work|away is now known as rm_work | 07:44 | |
| *** rm_work is now known as rm_work|away | 07:53 | |
| *** stevemar has quit IRC | 07:58 | |
| *** rm_work|away is now known as rm_work | 08:02 | |
| *** gokrokve has joined #openstack-keystone | 08:06 | |
| *** amerine has joined #openstack-keystone | 08:07 | |
| *** gokrokve has quit IRC | 08:11 | |
| *** dobson has quit IRC | 08:12 | |
| *** dobson has joined #openstack-keystone | 08:16 | |
| openstackgerrit | A change was merged to openstack/keystone: add missing log hints for level C/E/I/W https://review.openstack.org/95381 | 08:33 |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: backend for policy endpoint extension https://review.openstack.org/115362 | 08:41 |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: controller for the endpoint policy extension https://review.openstack.org/115746 | 08:43 |
| *** amerine has quit IRC | 08:51 | |
| *** rm_work is now known as rm_work|away | 09:04 | |
| *** gokrokve has joined #openstack-keystone | 09:06 | |
| *** gokrokve has quit IRC | 09:11 | |
| *** bvandenh has quit IRC | 09:29 | |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: controller for the endpoint policy extension https://review.openstack.org/115746 | 09:30 |
| *** bvandenh has joined #openstack-keystone | 09:32 | |
| *** henrynash has quit IRC | 09:33 | |
| *** henrynash has joined #openstack-keystone | 09:38 | |
| *** amerine has joined #openstack-keystone | 09:47 | |
| *** amerine has quit IRC | 09:51 | |
| *** gokrokve has joined #openstack-keystone | 10:06 | |
| *** gokrokve has quit IRC | 10:11 | |
| openstackgerrit | A change was merged to openstack/keystone: Redirect stdout and stderr when using subprocess https://review.openstack.org/51610 | 10:31 |
| *** bvandenh has quit IRC | 10:44 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Fix test mistake with requests-mock https://review.openstack.org/118031 | 10:50 |
| jamielennox | morganfainberg sorry missed it earlier, i don't think it's an issue with requests-mock but the test ^ | 10:56 |
| jamielennox | I should probably do better input validation though, always considered that a use issue | 10:57 |
| jamielennox | Unfortunately httpretty made body= the expected input | 10:58 |
| *** gokrokve has joined #openstack-keystone | 11:06 | |
| *** amerine has joined #openstack-keystone | 11:07 | |
| *** gokrokve has quit IRC | 11:10 | |
| *** amerine has quit IRC | 11:11 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Fix test mistake with requests-mock https://review.openstack.org/118031 | 11:39 |
| *** jschwarz has joined #openstack-keystone | 11:42 | |
| *** Lordanat1 has joined #openstack-keystone | 11:44 | |
| *** Lordanat3 has quit IRC | 11:44 | |
| henrynash | bknudson: fixed up the endpoint policy extension as per your comments: https://review.openstack.org/#/c/115362/ and https://review.openstack.org/#/c/115746/ | 11:44 |
| henrynash | dolphm, stevemar: would quite like to get these in as its an extension, so minimal impact to the rest of the core: https://review.openstack.org/#/c/115362/ and https://review.openstack.org/#/c/115746/ | 11:48 |
| *** gokrokve has joined #openstack-keystone | 12:06 | |
| *** amerine has joined #openstack-keystone | 12:08 | |
| *** gokrokve has quit IRC | 12:11 | |
| *** amerine has quit IRC | 12:13 | |
| *** jamielennox has quit IRC | 12:27 | |
| *** harlowja_away has quit IRC | 12:41 | |
| *** morganfainberg has quit IRC | 12:41 | |
| *** morganfainberg has joined #openstack-keystone | 12:43 | |
| *** morganfainberg has quit IRC | 12:46 | |
| *** morganfainberg has joined #openstack-keystone | 12:46 | |
| *** boris-42_ has joined #openstack-keystone | 12:50 | |
| *** jschwarz_ has joined #openstack-keystone | 12:50 | |
| *** jschwarz has quit IRC | 12:57 | |
| *** boris-42 has quit IRC | 12:57 | |
| *** grantbow has quit IRC | 12:59 | |
| *** amerine has joined #openstack-keystone | 13:01 | |
| *** amerine has quit IRC | 13:06 | |
| *** jschwarz_ has quit IRC | 13:06 | |
| *** jschwarz_ has joined #openstack-keystone | 13:06 | |
| *** gokrokve has joined #openstack-keystone | 13:06 | |
| *** gokrokve has quit IRC | 13:11 | |
| *** grantbow has joined #openstack-keystone | 13:13 | |
| *** grantbow has joined #openstack-keystone | 13:13 | |
| *** ukalifon has quit IRC | 13:57 | |
| *** amerine has joined #openstack-keystone | 14:02 | |
| *** amerine has quit IRC | 14:06 | |
| *** gokrokve has joined #openstack-keystone | 14:06 | |
| openstackgerrit | Andreas Jaeger proposed a change to openstack/keystonemiddleware: Improve help strings https://review.openstack.org/118048 | 14:10 |
| *** gokrokve has quit IRC | 14:11 | |
| openstackgerrit | A change was merged to openstack/keystone: Implement validation on Policy V3 API https://review.openstack.org/104065 | 14:54 |
| *** sagara has joined #openstack-keystone | 15:02 | |
| sagara | Hi | 15:03 |
| *** gokrokve has joined #openstack-keystone | 15:06 | |
| sagara | keystoneclient unit test always fails because of https://bugs.launchpad.net/python-keystoneclient/+bug/1363632 | 15:08 |
| uvirtbot | Launchpad bug 1363632 in python-novaclient "Inconsistency with new requests-mock and requests" [Undecided,In progress] | 15:08 |
| *** gokrokve has quit IRC | 15:10 | |
| *** amirosh has joined #openstack-keystone | 15:15 | |
| *** sagara has quit IRC | 15:29 | |
| *** jschwarz_ has quit IRC | 15:34 | |
| *** amirosh has quit IRC | 15:42 | |
| *** gokrokve has joined #openstack-keystone | 15:42 | |
| *** amirosh has joined #openstack-keystone | 15:43 | |
| *** amirosh has quit IRC | 15:47 | |
| *** bknudson has joined #openstack-keystone | 16:01 | |
| *** gokrokve has quit IRC | 16:04 | |
| *** gokrokve has joined #openstack-keystone | 16:05 | |
| *** gokrokve has quit IRC | 16:09 | |
| openstackgerrit | A change was merged to openstack/keystone: Implement validation on Credential V3 https://review.openstack.org/98522 | 16:23 |
| *** hrybacki has joined #openstack-keystone | 16:24 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Refactor keystone-all and http/keystone https://review.openstack.org/62275 | 16:43 |
| *** gokrokve has joined #openstack-keystone | 17:03 | |
| *** amerine has joined #openstack-keystone | 17:04 | |
| *** gokrokve has quit IRC | 17:07 | |
| *** amerine has quit IRC | 17:10 | |
| *** hrybacki has quit IRC | 17:11 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Lower log level for notification registration https://review.openstack.org/118053 | 17:50 |
| *** ukalifon1 has joined #openstack-keystone | 17:53 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:01 | |
| *** sigmavirus24 has joined #openstack-keystone | 18:01 | |
| morganfainberg | henrynash, hey | 18:01 |
| henrynash | morgfainberg: hi | 18:02 |
| morganfainberg | henrynash, i had a question for you... | 18:02 |
| morganfainberg | henrynash, uh... | 18:02 |
| henrynash | sure | 18:02 |
| morganfainberg | dang it. | 18:02 |
| morganfainberg | let me find that review | 18:02 |
| *** amerine has joined #openstack-keystone | 18:06 | |
| morganfainberg | oh | 18:07 |
| morganfainberg | henrynash, https://bugs.launchpad.net/keystone/+bug/1362678 was this ever an intention? | 18:08 |
| uvirtbot | Launchpad bug 1362678 in keystone "multi-domain has problems with LDAP identity on default domain" [Undecided,New] | 18:08 |
| morganfainberg | henrynash, LDAP as the default domain (identity) and SQL as a backing store for *other* domains? | 18:08 |
| morganfainberg | it seems like a reasonable use-case | 18:08 |
| henrynash | we actually test that in the unit tests | 18:08 |
| henrynash | hmmm, actually maybe we do it slightly differently…we define a specific config file for the default domain and let the regular config file use sql….I should get them to try that | 18:09 |
| morganfainberg | henrynash, LDAP as the default domain? | 18:10 |
| morganfainberg | henrynash, i thnk we test SQL as default and ldap as other domains | 18:10 |
| *** amerine has quit IRC | 18:10 | |
| henrynash | look at class MultiLDAPandSQLIdentity in test_backend_ldap.py | 18:11 |
| morganfainberg | bknudson, https://review.openstack.org/#/c/62275/6/bin/keystone-all would it be possible to make this just an entry point like: https://github.com/openstack/nova/blob/master/setup.cfg#L34-L56 does? | 18:11 |
| morganfainberg | bknudson, instead of needing anything in keystone/bin | 18:11 |
| bknudson | morganfainberg: that would be cool. | 18:12 |
| morganfainberg | henrynash, ok. i'll take a gander, but i was fairly certain we didn't plan for SQL to be the secondary domains. | 18:12 |
| morganfainberg | bknudson, i'd be happy to take a crack at it (and pile onto your review or a followup) if you'd like me to | 18:12 |
| notmyname | FYI, I just answered a question on the mailing list about global swift clusters and kinda hand-waved about keystone in there. | 18:12 |
| bknudson | morganfainberg: y, if you've got the time. | 18:12 |
| morganfainberg | bknudson, sure i'll do it as a followup if we like it we can merge them or keep them separate | 18:13 |
| *** hrybacki has joined #openstack-keystone | 18:13 | |
| bknudson | otherwise I'll get back to it sometime. | 18:13 |
| henrynash | well you can’t have more than one sql config…but if you use sql for all other domains expect those eith specific LDAP ones (incl teh default domain) it will work (I think :-)) | 18:13 |
| morganfainberg | bknudson, should have it today /me is doing code today :) | 18:13 |
| bknudson | wasn't expecting it for juno | 18:13 |
| morganfainberg | henrynash, hrm, i think it gets weird with default, but yeah. i'll try that out | 18:14 |
| morganfainberg | notmyname, *waves hands* spoooooky | 18:14 |
| henrynash | morganfaiberg: yeah, agred | 18:14 |
| morganfainberg | notmyname, have a link (don't see it in my mailbox) | 18:14 |
| morganfainberg | notmyname, or a specific thread-title/keyword | 18:14 |
| morganfainberg | ? | 18:14 |
| morganfainberg | bknudson, it looks like most of the stuff was just moved to nova.cmd instead of being in like nova/bin | 18:16 |
| morganfainberg | bknudson, should be super simple to move. | 18:16 |
| bknudson | morganfainberg: keystone has some odd stuff in keystone-all. | 18:16 |
| morganfainberg | yeah | 18:17 |
| henrynash | morganfainberg: btw, looking for another +2/A on: https://review.openstack.org/#/c/115362/ | 18:17 |
| morganfainberg | aha yeah let me review that before writing more code | 18:17 |
| bknudson | morganfainberg: the only thing left is the possible_topdir = os.path.normpath(os.path.join(os.path.abspath(__file__), oddness. | 18:17 |
| * morganfainberg should also take a shower and og to a coffee shop to work :) | 18:17 | |
| bknudson | it modifies sys.path, and uses it to find the developer conf file. | 18:17 |
| morganfainberg | bknudson, hm. i *think* we can clean that up... i never liked that topdir thing | 18:17 |
| morganfainberg | henrynash, oh! another question, since you did the others, mind rolling a quick "deprecate revoke events kvs backend"? | 18:19 |
| morganfainberg | henrynash, i can do it if you're busy. but it was one that was missed. | 18:19 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 18:19 | |
| henrynash | morgainfainberg: can do later today…jusy hiting the road…. | 18:20 |
| morganfainberg | henrynash, sounds good, if you don't get to it i'll take a crack at it and just add you to the review. | 18:20 |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: controller for the endpoint policy extension https://review.openstack.org/115746 | 18:20 |
| morganfainberg | notmyname, aha just saw it hit my inbox | 18:21 |
| henrynash | bknudson: fixed up https://review.openstack.org/115746 | 18:21 |
| bknudson | henrynash: the sample conf file is messed up. | 18:23 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Lower log level for notification registration https://review.openstack.org/118053 | 18:24 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: General logging cleanup in keystone.notifications https://review.openstack.org/118054 | 18:24 |
| henrynash | bknudson: damn...fixing | 18:25 |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: controller for the endpoint policy extension https://review.openstack.org/115746 | 18:28 |
| henrynash | bknudson: done | 18:29 |
| morganfainberg | henrynash, +2/+A added a couple comments, 100% agree with bknudson's comments | 18:30 |
| morganfainberg | henrynash, my comments are around avoiding SQL object house keeping when we're only ever selecting a specific value. a lot of overhead for not a lot of benefit | 18:30 |
| morganfainberg | or for 0 benefit | 18:30 |
| henrynash | morganfainberg: thanks…I’ll submit a tidy-up patch tonight/tomorrow | 18:30 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Lower log level for notification registration https://review.openstack.org/118053 | 18:30 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: General logging cleanup in keystone.notifications https://review.openstack.org/118054 | 18:30 |
| henrynash | morganfainberg: and if you’re in the mood (!!), there’s the controller patch too: https://review.openstack.org/#/c/115746/ | 18:33 |
| *** henrynash has quit IRC | 18:33 | |
| morganfainberg | bknudson, +2 on both of those cleanup patches (notification logging), nice cleanup | 18:33 |
| bknudson | morganfainberg: thanks! | 18:34 |
| morganfainberg | god, that topdir thing is obnoxious | 18:35 |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Implement validation on the Catalog V3 API https://review.openstack.org/96266 | 18:39 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Fix logging config twice https://review.openstack.org/118055 | 18:41 |
| bknudson | morganfainberg: nova is able to live without topdir? | 18:42 |
| morganfainberg | bknudson, nova also doesn't have a sample config in-tree | 18:42 |
| bknudson | they used to up until not too long ago. | 18:42 |
| morganfainberg | bknudson, yeah this cycle | 18:42 |
| morganfainberg | but they don't do the topdir shennanigans, i think they expect you to either use the default *or* specify the location of your config | 18:43 |
| bknudson | seems like if it's good enough for them it should be good enough for us. | 18:43 |
| bknudson | better to be consistent | 18:43 |
| morganfainberg | bknudson, ++ | 18:43 |
| morganfainberg | bknudson, i'm a fan | 18:43 |
| morganfainberg | i wonder if i can convince keystone to generate a sample config on install. (setup) | 18:44 |
| lbragstad | morganfainberg: I had to rebase https://review.openstack.org/#/c/96266/ due to some conflicts, which removed the -2's from you and dolphm | 18:53 |
| morganfainberg | lbragstad, the +2s? | 18:54 |
| morganfainberg | lbragstad, :P | 18:54 |
| lbragstad | ... | 18:54 |
| lbragstad | yes | 18:54 |
| lbragstad | :) | 18:54 |
| morganfainberg | lbragstad, cause i can -2 it if you *realy* want :P | 18:54 |
| lbragstad | lol | 18:54 |
| morganfainberg | bknudson, i think i can make setup.py generate a sample config on demand | 19:03 |
| morganfainberg | bknudson, well based on how setup.cfg works. | 19:03 |
| *** hrybacki has quit IRC | 19:04 | |
| morganfainberg | bknudson, if it works like i *think* it works, i'll try and propose that instead of needing to keep the config.sample in-tree. | 19:04 |
| *** amerine has joined #openstack-keystone | 19:06 | |
| *** rushiagr_away is now known as rushiagr | 19:08 | |
| *** amerine has quit IRC | 19:11 | |
| morganfainberg | bknudson | 19:22 |
| morganfainberg | bknudson, http://paste.openstack.org/show/103799/ | 19:23 |
| morganfainberg | bknudson, just need a *little* code to make this work but... i think i got it. | 19:23 |
| morganfainberg | when you run setup.cfg it then does the config building | 19:23 |
| *** rushiagr is now known as rushiagr_away | 19:32 | |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Generate sample config on setup https://review.openstack.org/118057 | 19:36 |
| openstackgerrit | A change was merged to openstack/keystone: backend for policy endpoint extension https://review.openstack.org/115362 | 19:43 |
| *** ukalifon1 has quit IRC | 19:48 | |
| *** stevemar has joined #openstack-keystone | 20:03 | |
| *** amerine has joined #openstack-keystone | 20:07 | |
| *** fifieldt_ has quit IRC | 20:11 | |
| *** amerine has quit IRC | 20:12 | |
| bknudson | "TypeError: 'TestVolumeBootPattern' object is not iterable" -- what a weird error. | 20:14 |
| *** fifieldt_ has joined #openstack-keystone | 20:24 | |
| dstanek | bknudson: where'd you see that? | 20:57 |
| bknudson | dstanek: there have been a few tempest failures lately. | 20:57 |
| bknudson | http://logs.openstack.org/46/115746/19/check/check-tempest-dsvm-neutron-full/6b71996/console.html#_2014-08-31_19_17_33_189 | 20:58 |
| bknudson | dstanek: http://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/test_volume_boot_pattern.py#n120 -- looks wrong? | 21:00 |
| dstanek | bknudson: yeah, that should be a list of servers http://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/manager.py#n387 | 21:01 |
| dstanek | maybe 'self._log_console_output([server])' | 21:02 |
| bknudson | dstanek: or maybe not passing servers would work | 21:02 |
| bknudson | dstanek: https://github.com/openstack/tempest/commit/eef192fc3c98a663f99f2fd944611bce0adffc0c | 21:04 |
| bknudson | there's the change... looks like it was () before. | 21:05 |
| bknudson | no reason to change that line that I can see. | 21:05 |
| *** amerine has joined #openstack-keystone | 21:08 | |
| *** amerine has quit IRC | 21:13 | |
| bknudson | Looks like keystoneclient unit tests are broken by requests 2.4.0 | 21:15 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 21:15 | |
| openstackgerrit | Bob Thyne proposed a change to openstack/keystone: Implementation of Endpoint Grouping https://review.openstack.org/111949 | 21:16 |
| morganfainberg | bknudson, yep | 21:23 |
| morganfainberg | bknudson, as is novaclient and neutronclient and.... | 21:23 |
| morganfainberg | this solves keystoneclient's issue but... | 21:24 |
| morganfainberg | https://review.openstack.org/#/c/118031/ | 21:24 |
| morganfainberg | this is probably a better fix: https://review.openstack.org/#/c/117890/ | 21:24 |
| morganfainberg | the first one we can push through, the second one relies only on jamielennox|away | 21:24 |
| bknudson | morganfainberg: that's weird because jamielennox|away proposed the fix to keystoneclient. | 21:26 |
| morganfainberg | bknudson, right. that fix was proposed after the fix to mock-requests was proposed as an alternative | 21:26 |
| morganfainberg | the issue is that requests got stricter and previously valid use of mock-requests now fails (due to an assumption of use) | 21:27 |
| morganfainberg | so, fix everyone: update mock-requests (and maintain backwards compat) | 21:27 |
| morganfainberg | or chase down everyone doing it wrong now and fix them | 21:27 |
| morganfainberg | mock-request fix sounds better to me. | 21:27 |
| morganfainberg | possibly with a "hey, this is wrong you should fix this" warning | 21:28 |
| morganfainberg | bknudson, jamielennox|away is the only core on mock-requests | 21:28 |
| bknudson | but the keystoneclient test would get that warning, so we need both | 21:30 |
| dstanek | morganfainberg, bknudson: since you guys are here...any thoughts on the comments that start on line 53 here - https://review.openstack.org/#/c/111949/26/keystone/contrib/endpoint_filter/backends/sql.py | 21:41 |
| morganfainberg | dstanek, those can't be FKs if assignment LDAP is used (though... it might be weird and not work anyway) | 21:42 |
| dstanek | morganfainberg: if that's the case do we need to fix endpoint and project to know about these records? | 21:43 |
| morganfainberg | dstanek, in what manner? | 21:44 |
| morganfainberg | e.g. if they are deleted? | 21:44 |
| morganfainberg | the project FK is the only real concern | 21:44 |
| dstanek | morganfainberg: yes | 21:44 |
| bknudson | henrynash's extension registered listeners | 21:44 |
| morganfainberg | endpoint could be FK | 21:44 |
| bknudson | callbacks for if the service was deleted | 21:44 |
| morganfainberg | since it's the same system (really) | 21:44 |
| dstanek | bknudson: yes! listeners would be the way | 21:44 |
| bknudson | I wonder where that is... could have sworn I was just looking at it. | 21:47 |
| bknudson | dstanek: not merged yet -- https://review.openstack.org/#/c/115746/19/keystone/contrib/endpoint_policy/controllers.py | 21:49 |
| *** stevemar has quit IRC | 21:50 | |
| *** alex_xu has quit IRC | 21:52 | |
| *** alex_xu has joined #openstack-keystone | 21:53 | |
| morganfainberg | hmmm. | 22:02 |
| morganfainberg | so i can get PBR to do interesting things but i can't seem to get it to generate the sample config in the correct place on both build and develop | 22:03 |
| morganfainberg | in fact, i can't seem to get it to do anything interesting on "develop" | 22:03 |
| *** amerine has joined #openstack-keystone | 22:09 | |
| *** amerine has quit IRC | 22:14 | |
| *** henrynash has joined #openstack-keystone | 22:15 | |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: Mark the revoke kvs backend deprecated, for removal in Kilo https://review.openstack.org/118067 | 22:25 |
| henrynash | morganfainberg: https://review.openstack.org/#/c/118067/ | 22:26 |
| *** henrynash has quit IRC | 22:29 | |
| *** gokrokve has joined #openstack-keystone | 22:32 | |
| openstackgerrit | A change was merged to openstack/python-keystoneclient: Fix test mistake with requests-mock https://review.openstack.org/118031 | 22:37 |
| *** henrynash has joined #openstack-keystone | 22:50 | |
| *** henrynash has quit IRC | 22:58 | |
| *** gokrokve has quit IRC | 23:07 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:12 | |
| *** hrybacki has joined #openstack-keystone | 23:35 | |
| *** stevemar has joined #openstack-keystone | 23:37 | |
| *** oomichi has joined #openstack-keystone | 23:41 | |
| *** jamielennox|away is now known as jamielennox | 23:43 | |
| jamielennox | morganfainberg: i agree that text=body is unintuitive, i expected the request.body to be an actual io object | 23:48 |
| jamielennox | turns out it's not :( | 23:48 |
| *** alex_xu has quit IRC | 23:49 | |
| jamielennox | the intent with the different parameters was to line up with the requests.Response object so the text= param lined up with response.text, body= lined up with response.boy | 23:49 |
| jamielennox | this is partially to do with requests become way more open to what they accept between requests 1.2 and 2.X | 23:49 |
| openstackgerrit | Yukinori Sagara proposed a change to openstack/python-keystoneclient: fix EC2 Signature Version 4 calculation, in the case of POST https://review.openstack.org/116523 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!