| *** mflobo_ has joined #openstack-keystone | 00:01 | |
| *** sigmavirus24b has joined #openstack-keystone | 00:02 | |
| *** cjellick_ has joined #openstack-keystone | 00:03 | |
| *** joesavak has joined #openstack-keystone | 00:03 | |
| openstackgerrit | A change was merged to openstack/keystone: Ensure a consistent transactional context is used https://review.openstack.org/120146 | 00:04 |
|---|---|---|
| *** gus_ has joined #openstack-keystone | 00:06 | |
| *** mhu1 has joined #openstack-keystone | 00:06 | |
| *** dutsmoc has joined #openstack-keystone | 00:07 | |
| *** jraim_ has joined #openstack-keystone | 00:07 | |
| *** rm_work| has joined #openstack-keystone | 00:07 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Fix delete group cleans up role assignments with LDAP https://review.openstack.org/119631 | 00:08 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Ensure identity sql driver supports domain-specific configuration. https://review.openstack.org/121246 | 00:08 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Reduce unit test log level for notifications. https://review.openstack.org/121392 | 00:08 |
| *** mgagne has joined #openstack-keystone | 00:08 | |
| *** d34dh0r53 has joined #openstack-keystone | 00:09 | |
| *** mgagne is now known as Guest72739 | 00:09 | |
| *** dolphm_ has joined #openstack-keystone | 00:09 | |
| *** lbragstad1 has joined #openstack-keystone | 00:12 | |
| *** EmilienM_ has joined #openstack-keystone | 00:13 | |
| *** jraim has quit IRC | 00:13 | |
| *** jsavak has quit IRC | 00:13 | |
| *** nonameentername has quit IRC | 00:13 | |
| *** cjellick has quit IRC | 00:13 | |
| *** adam_g has quit IRC | 00:13 | |
| *** rm_work has quit IRC | 00:13 | |
| *** _d34dh0r53_ has quit IRC | 00:13 | |
| *** sigmavirus24_awa has quit IRC | 00:13 | |
| *** dolphm has quit IRC | 00:13 | |
| *** comstud has quit IRC | 00:13 | |
| *** Guest6936 has quit IRC | 00:13 | |
| *** mhu has quit IRC | 00:13 | |
| *** EmilienM has quit IRC | 00:13 | |
| *** gus has quit IRC | 00:13 | |
| *** mflobo has quit IRC | 00:13 | |
| *** mhu1 is now known as mhu | 00:13 | |
| *** dolphm_ is now known as dolphm | 00:13 | |
| *** jraim_ is now known as jraim | 00:13 | |
| *** EmilienM_ is now known as EmilienM | 00:13 | |
| *** rm_work| is now known as rm_work | 00:13 | |
| *** rm_work has quit IRC | 00:13 | |
| *** rm_work has joined #openstack-keystone | 00:13 | |
| *** packet has joined #openstack-keystone | 00:18 | |
| *** adam_g has joined #openstack-keystone | 00:19 | |
| *** adam_g has quit IRC | 00:19 | |
| *** adam_g has joined #openstack-keystone | 00:19 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: ldap/core deleteTree not always supported https://review.openstack.org/74897 | 00:21 |
| openstackgerrit | A change was merged to openstack/keystonemiddleware: convert the conf value into correct type https://review.openstack.org/113191 | 00:21 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Enhance FakeLdap to require base entry for subtree search https://review.openstack.org/121370 | 00:23 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Refactor FakeLdap to share delete code https://review.openstack.org/121371 | 00:24 |
| *** gus_ is now known as gus | 00:29 | |
| *** packet has quit IRC | 00:32 | |
| *** HenryG has quit IRC | 00:37 | |
| *** ncoghlan has joined #openstack-keystone | 00:45 | |
| *** packet has joined #openstack-keystone | 00:51 | |
| *** dimsum_ has quit IRC | 00:57 | |
| *** mitz_ has joined #openstack-keystone | 01:05 | |
| *** dimsum_ has joined #openstack-keystone | 01:13 | |
| *** packet has quit IRC | 01:15 | |
| *** lbragstad1 has quit IRC | 01:16 | |
| *** packet has joined #openstack-keystone | 01:17 | |
| *** rodrigods has quit IRC | 01:17 | |
| morganfainberg | bknudson, beat me to the rebases | 01:32 |
| morganfainberg | bknudson, just waiting for the final check to pass then should be gating | 01:33 |
| *** wanghong has joined #openstack-keystone | 01:34 | |
| *** dimsum_ has quit IRC | 01:51 | |
| *** ncoghlan is now known as ncoghlan_afk | 01:51 | |
| *** wwriverrat has joined #openstack-keystone | 01:54 | |
| *** alex_xu has joined #openstack-keystone | 01:56 | |
| *** joesavak has quit IRC | 01:59 | |
| *** wanghong has quit IRC | 02:00 | |
| *** lbragstad1 has joined #openstack-keystone | 02:10 | |
| openstackgerrit | A change was merged to openstack/keystone-specs: Add RSS feed https://review.openstack.org/120522 | 02:11 |
| *** wanghong has joined #openstack-keystone | 02:12 | |
| openstackgerrit | A change was merged to openstack/keystone-specs: Remove templates from toctrees https://review.openstack.org/120523 | 02:13 |
| openstackgerrit | A change was merged to openstack/keystone-specs: Use the current date for the copyright statement https://review.openstack.org/120524 | 02:14 |
| *** wwriverrat has quit IRC | 02:23 | |
| jamielennox | morganfainberg: you here? | 02:26 |
| morganfainberg | might be | 02:26 |
| *** wanghong has quit IRC | 02:27 | |
| jamielennox | morganfainberg: do you mind doing a quick read through of a post for me | 02:27 |
| jamielennox | i'm way to close to it and so it makes sense to me | 02:27 |
| morganfainberg | jamielennox, uh sure. but realize i've not had food yet | 02:28 |
| morganfainberg | jamielennox, so brain is a little foggy. shouldn't be a big deal | 02:28 |
| morganfainberg | but if i say something wacky, just disregard it :) | 02:28 |
| jamielennox | morganfainberg: foggy is better - if you don't get it i didn't explain it well | 02:28 |
| jamielennox | https://github.com/jamielennox/jamielennox.github.io/blob/sessions/source/_posts/2014-09-15-how-to-use-keystoneclient-sessions.markdown | 02:28 |
| jamielennox | I can't put everything in there, hoping that will be enough to send people looking through the code | 02:30 |
| jamielennox | then i can do a bunch of docs when i'm back | 02:30 |
| morganfainberg | right | 02:31 |
| morganfainberg | reading now | 02:31 |
| *** ncoghlan_afk is now known as ncoghlan | 02:32 | |
| morganfainberg | looks good to me | 02:32 |
| morganfainberg | pretty straight forward | 02:32 |
| jamielennox | morganfainberg: excellent, done | 02:33 |
| jamielennox | thanks | 02:33 |
| morganfainberg | np | 02:33 |
| morganfainberg | when are you off? | 02:33 |
| jamielennox | mostly trying to just write emails and a few things today - and that should be it | 02:34 |
| morganfainberg | have a good time :) | 02:34 |
| morganfainberg | we'll try not to break the client too badly between now and when you're back | 02:34 |
| jamielennox | oh - i will | 02:35 |
| * morganfainberg could use a nice long vacation | 02:35 | |
| jamielennox | heh, you can't break it more than it already is | 02:35 |
| morganfainberg | jamielennox, ... Challenge Acc... maybe not | 02:36 |
| jamielennox | maybe you can purge it from the internet so i can just start again | 02:36 |
| morganfainberg | Keystoneclient 1.0 | 02:37 |
| morganfainberg | rewrite, incompatible with old versions | 02:37 |
| *** packet has quit IRC | 02:37 | |
| jamielennox | timed to coincide with keystone API v4 is my understanding | 02:37 |
| morganfainberg | pin the global reqs to <1.0 | 02:37 |
| morganfainberg | or more appropriate <=0.999 | 02:37 |
| morganfainberg | eh | 02:38 |
| morganfainberg | i could see a complete re-write of the lib being less work than a new api version | 02:38 |
| morganfainberg | and if it was stated it was going to be incompatible out the gate, i think it could free a lot up | 02:38 |
| jamielennox | the lib bit is easy, trying to convert people will be hard | 02:38 |
| morganfainberg | though it would probably take 2 cycles+ to get it adopted | 02:38 |
| jamielennox | and we still have all the like service catalog hacks to deal with | 02:38 |
| morganfainberg | eh, i'd consider it a valid topic to explore going into L | 02:39 |
| morganfainberg | expecting to be maintaining / developing on 0.XX version for a couple cycles as well, but a full on streamline/cleanup 1.0 isn't a *bad* thing | 02:40 |
| jamielennox | morganfainberg: they're really hard to run out of the same repo with pip | 02:40 |
| jamielennox | essentially you need to write keystoneclient2 | 02:40 |
| morganfainberg | jamielennox, i wouldn't run it out of the same repo | 02:40 |
| morganfainberg | ok so we call it keystoneclient2 | 02:40 |
| morganfainberg | :P | 02:40 |
| morganfainberg | or python-keystoneclient-2 | 02:41 |
| jamielennox | hm, -kerberos still not approved | 02:43 |
| *** wanghong has joined #openstack-keystone | 02:44 | |
| morganfainberg | yeah. | 02:44 |
| morganfainberg | =/ | 02:44 |
| morganfainberg | ooh uh | 02:45 |
| morganfainberg | are we using python-keystoneclient's LP page for those? | 02:45 |
| morganfainberg | my guess is we *shouldn't* because it's gonna be hard to track | 02:45 |
| morganfainberg | i'll go create the LP projects if you haven't | 02:45 |
| *** lbragstad1 has quit IRC | 02:46 | |
| morganfainberg | jamielennox, https://launchpad.net/python-keystoneclient-kerberos | 02:54 |
| jamielennox | morganfainberg: no i didn't create launchpads for it, i figured it was under the same group and drivers | 02:55 |
| jamielennox | and that we weren't going to see that many bugs for it we could probably manage with tags | 02:55 |
| jamielennox | but either way doesn't really bother me | 02:56 |
| morganfainberg | jamielennox, the issue is release milestones under one project gets wonky | 02:56 |
| morganfainberg | jamielennox, you need to create new series and such and it's not straight forward. easier to just make it separate bug trackers :( | 02:57 |
| jamielennox | morganfainberg: ok | 02:57 |
| morganfainberg | jamielennox, anyway you didn't 'group' the new repos | 02:58 |
| morganfainberg | jamielennox, so it would need it's own LP project | 02:58 |
| morganfainberg | nbd really. | 02:58 |
| morganfainberg | could have added it after the fact but i think it's cleaner to have it's own project | 02:59 |
| jamielennox | nbd? | 02:59 |
| morganfainberg | no big deal | 02:59 |
| jamielennox | ok - i haven't seen 'group' before | 02:59 |
| *** KanagarajM has joined #openstack-keystone | 03:01 | |
| *** stevemar has quit IRC | 03:18 | |
| *** stevemar has joined #openstack-keystone | 03:19 | |
| *** david-lyle has joined #openstack-keystone | 03:30 | |
| *** alex_xu has quit IRC | 03:32 | |
| *** alex_xu has joined #openstack-keystone | 03:35 | |
| *** larsks|alt is now known as larsks | 03:35 | |
| openstackgerrit | A change was merged to openstack/keystonemiddleware: Create an Auth Plugin to pass to users https://review.openstack.org/107222 | 03:44 |
| *** gokrokve_ has quit IRC | 03:54 | |
| openstackgerrit | A change was merged to openstack/keystone: ldap/core deleteTree not always supported https://review.openstack.org/74897 | 03:55 |
| *** ncoghlan is now known as ncoghlan_afk | 03:56 | |
| openstackgerrit | Dave Chen proposed a change to openstack/keystone: local configuration should be allowed in "keystone-paste.ini" https://review.openstack.org/121439 | 03:56 |
| *** ncoghlan_afk is now known as ncoghlan | 04:09 | |
| *** gokrokve has joined #openstack-keystone | 04:15 | |
| *** ChanServ sets mode: -v morganfainberg | 04:19 | |
| *** gokrokve has quit IRC | 04:20 | |
| *** gokrokve has joined #openstack-keystone | 04:22 | |
| *** achampion has joined #openstack-keystone | 04:24 | |
| *** achampio1 has quit IRC | 04:27 | |
| *** gokrokve has quit IRC | 04:27 | |
| *** rushiagr_away is now known as rushiagr | 04:37 | |
| *** david-lyle has quit IRC | 04:47 | |
| *** david-lyle has joined #openstack-keystone | 04:48 | |
| *** aix has quit IRC | 05:02 | |
| *** ncoghlan is now known as ncoghlan_afk | 05:06 | |
| *** jraim has quit IRC | 05:10 | |
| *** ncoghlan_afk is now known as ncoghlan | 05:11 | |
| *** jraim_ has joined #openstack-keystone | 05:12 | |
| *** rushiagr is now known as rushiagr_away | 05:24 | |
| ekarlso | jamielennox: u here still or have u left ? | 05:34 |
| ekarlso | anyone else around ? ;) | 05:36 |
| openstackgerrit | Kevin Benton proposed a change to openstack/keystone: Fail on empty userId/username before query https://review.openstack.org/120705 | 05:45 |
| *** stevemar has quit IRC | 05:46 | |
| *** ajayaa has joined #openstack-keystone | 05:49 | |
| *** ukalifon1 has joined #openstack-keystone | 05:54 | |
| *** alex_xu has quit IRC | 05:55 | |
| *** k4n0 has joined #openstack-keystone | 05:57 | |
| *** KanagarajM has quit IRC | 06:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Imported Translations from Transifex https://review.openstack.org/120695 | 06:04 |
| *** wanghong has quit IRC | 06:04 | |
| *** alex_xu has joined #openstack-keystone | 06:14 | |
| *** mflobo_ has quit IRC | 06:16 | |
| *** rushiagr_away is now known as rushiagr | 06:18 | |
| *** achampio1 has joined #openstack-keystone | 06:18 | |
| *** henrynash has joined #openstack-keystone | 06:19 | |
| *** achampion has quit IRC | 06:20 | |
| *** alex_xu has quit IRC | 06:21 | |
| *** alex_xu has joined #openstack-keystone | 06:21 | |
| *** gokrokve has joined #openstack-keystone | 06:22 | |
| *** rushiagr is now known as rushiagr_away | 06:23 | |
| *** palendae has quit IRC | 06:23 | |
| *** gokrokve has quit IRC | 06:23 | |
| *** gokrokve has joined #openstack-keystone | 06:24 | |
| *** palendae has joined #openstack-keystone | 06:25 | |
| jamielennox | ekarlso: in and out | 06:28 |
| ekarlso | jamielennox: so allmost fixed up the cli stuff | 06:28 |
| *** gokrokve has quit IRC | 06:28 | |
| ekarlso | just need to fix tests :( | 06:29 |
| jamielennox | ekarlso: excellent - and all working? | 06:32 |
| ekarlso | jamielennox: allmosT ;) | 06:33 |
| ekarlso | jamielennox: some of the old behaviour is borking atm | 06:44 |
| jamielennox | ekarlso: anything in particular? | 06:45 |
| ekarlso | oh | 06:46 |
| ekarlso | I see why | 06:46 |
| ekarlso | I looked at your patch and removed self.auth_check() | 06:46 |
| ekarlso | jamielennox: is that intended to be removed or ? | 06:47 |
| jamielennox | ekarlso: i can't remember which patch auth_check was on | 06:50 |
| jamielennox | or what it was doing | 06:50 |
| jamielennox | unfortunately none of the clients are standard enough to figure that out | 06:50 |
| ekarlso | ;P | 06:51 |
| ekarlso | I was hoping the CLI plugin would land in J | 06:52 |
| *** david-lyle has quit IRC | 06:52 | |
| ekarlso | that way I don't have to write custom crap for designate v2 | 06:52 |
| ekarlso | since ks now has all the goodies | 06:52 |
| jamielennox | will be released this week | 06:54 |
| jamielennox | umm | 06:54 |
| jamielennox | the main issue is i just don't know what people want, if you can get away with it just use generic.Password as your CLI default | 06:55 |
| ekarlso | jamielennox: so your options atm doesn't honor --os_password but only os-password | 06:55 |
| ekarlso | btw : ) | 06:55 |
| jamielennox | that's good | 06:56 |
| jamielennox | i don't want to drag --os_password around | 06:56 |
| ekarlso | oh ok | 06:56 |
| *** Sanchit has joined #openstack-keystone | 06:56 | |
| jamielennox | if you have --os_password already and need to maintain compatability you can add it and use SUPRESS or something so that it doesn't end up in the --help options | 06:57 |
| jamielennox | but you should be able to do that independently of the plugin | 06:57 |
| Sanchit | Hi. I am trying to configure keystone and start the services. When I run keystone-all command, I am getting this error: ImportError: cannot import name backends. | 06:58 |
| Sanchit | Can anybody explain me the issue and help resolving the same? | 06:58 |
| jamielennox | Sanchit: sounds like you haven't got keystone installed into the python path | 06:58 |
| jamielennox | so like python setup.py install | 06:59 |
| *** KanagarajM has joined #openstack-keystone | 06:59 | |
| *** ajayaa has quit IRC | 06:59 | |
| jamielennox | you should be able to get a python prompt and type import keystone to test that it's picking up the correct directory | 06:59 |
| Sanchit | when i get a python prompt and write >>> import keystone | 07:00 |
| Sanchit | It simply advances to next prompt line | 07:00 |
| ekarlso | jamielennox: what is it that adds the SUPRSES thing ? | 07:00 |
| ekarlso | ahh | 07:01 |
| ekarlso | I see why it broke: ) | 07:01 |
| Sanchit | jamielennox: When I write >>> import keystone >>> from keystone import backends | 07:02 |
| Sanchit | I get the following error: AttributeError: 'module' object has no attribute 'wraps' | 07:02 |
| ekarlso | jamielennox: :'( 1 failure still :p | 07:03 |
| jamielennox | Sanchit: wraps? do you have a line number? that sounds like functools | 07:03 |
| jamielennox | ekarlso: which bit | 07:03 |
| Sanchit | jamielennox: File "keystone/openstack/common/versionutils.py", line 128, in __call__ @six.wraps(func_or_cls) AttributeError: 'module' object has no attribute 'wraps' | 07:04 |
| *** henrynash has quit IRC | 07:04 | |
| Sanchit | jamielennox: Could you please walk me through this? | 07:07 |
| ekarlso | jamielennox: meh, rather 33 failures (forgot to run all tests because I was fixing tests.test_shell | 07:08 |
| ekarlso | jamielennox: I wonder if it's the discover part or smth when the auth plugins are loading that's borking | 07:08 |
| jamielennox | Sanchit: ummm - that just looks like a bug to me, i just don't see how this would be the first time it was found | 07:13 |
| jamielennox | Sanchit: no six.wraps is a thing but it isn't installed on my machine either | 07:15 |
| Sanchit | jamielennox: I am running Python v2.7 | 07:15 |
| Sanchit | When I tried to run tests script in virual environment, It went through quite smoothly. | 07:16 |
| jamielennox | Sanchit: so the problem is the version of the six library | 07:16 |
| jamielennox | it's too old | 07:17 |
| jamielennox | though i can't see what version it is you need | 07:17 |
| ekarlso | jamielennox: nice, this stuff is working nicely! | 07:17 |
| jamielennox | ekarlso: good! i was coming back | 07:17 |
| ekarlso | jamielennox: coming back ? | 07:18 |
| jamielennox | ekarlso: i hadn't answered the last few things you said | 07:18 |
| ekarlso | ah | 07:18 |
| jamielennox | Sanchit: So in six 1.6.1 there is no wraps function, in six 1.7.3 there is - so i'm *guessing* you need six 1.7 | 07:19 |
| jamielennox | Sanchit: so depending on what machine you are working on you probably won't have new enough versions in your system packages | 07:20 |
| Sanchit | jamielennox: I am just on it. Upgrading to six 1.7.0 | 07:20 |
| *** ajayaa has joined #openstack-keystone | 07:20 | |
| jamielennox | i'm on an up to date fedora and i need a virtual env to run things out of git | 07:20 |
| *** gokrokve has joined #openstack-keystone | 07:22 | |
| Sanchit | jamielennox: I upgraded to six 1.7.0 and still the same error. Do I need to reboot? | 07:23 |
| jamielennox | shouldn't | 07:24 |
| jamielennox | Sanchit: import six; print six.__version__ | 07:24 |
| Sanchit | Aaah. Its 1.5.2 | 07:25 |
| Sanchit | Confused!! | 07:25 |
| jamielennox | if you just type six it will show you the path it is getting six from | 07:26 |
| jamielennox | or print six i guess | 07:26 |
| Sanchit | jamielennox: <module 'six' from '/usr/lib/python2.7/dist-packages/six.pyc'> | 07:26 |
| *** gokrokve has quit IRC | 07:26 | |
| jamielennox | so whereever you installed six it is a lower priortiy than that | 07:27 |
| ekarlso | jamielennox: http://paste.ubuntu.com/8348616/ < hmmm requests mock is borking there since sessions is hitting a unmocked addr | 07:27 |
| jamielennox | ekarlso: that looks like discovery | 07:29 |
| ekarlso | jamielennox: yea i figured | 07:29 |
| ekarlso | jamielennox: clue on a fix ? | 07:29 |
| jamielennox | either from the service catalog or the initial call | 07:29 |
| ekarlso | register a stuburl on that endpoint stuff in the test | 07:30 |
| ekarlso | I guess | 07:30 |
| Sanchit | jamielennox: I am a newbie in this field. Could you please guide me in detail on how to go about and fix this discrepency? | 07:30 |
| jamielennox | yea, i'm not sure why it would break now | 07:30 |
| ekarlso | jamielennox: I think it's since I'm loading a plugin by default ? | 07:30 |
| jamielennox | but yes, you should be able to just put a discovery response it for that url | 07:30 |
| ekarlso | don't think it used to do that before | 07:31 |
| jamielennox | oh - yea, that would make sense | 07:31 |
| jamielennox | if nothing is specified by default it would return None | 07:31 |
| jamielennox | so there wouldn't be anything called | 07:31 |
| jamielennox | now it's trying to do real behaviour and the test isn't set up for it | 07:31 |
| jamielennox | Sanchit: how did you install six | 07:31 |
| Sanchit | It was listed as a dependency in requirement.txt in keystone | 07:32 |
| jamielennox | ah, i need to go - going to keep irc open on phone - not sure how this will work | 07:32 |
| jamielennox | right but where did it go | 07:32 |
| ekarlso | jamielennox: going home ? : P | 07:32 |
| jamielennox | if you import sys; print sys.path | 07:32 |
| jamielennox | you will see the directories tht python is looking for code, so six has to go in one of those | 07:33 |
| jamielennox | ekarlso: been working from home, was about to go out when i checked to make sure no-one had said anything on irc | 07:33 |
| jamielennox | that was 30 odd minutes ago | 07:33 |
| Sanchit | jamielennox: >>> import sys >>> sys.path ['', '/home/sanchit/python-swiftclient', '/usr/lib/python2.7/dist-packages', '/home/sanchit/swift', '/home/sanchit/keystone', '/home/sanchit/python-swiftclient/pbr-0.10.0-py2.7.egg', '/usr/local/lib/python2.7/dist-packages/virtualenv-1.11.6-py2.7.egg', '/usr/lib/python2.7', '/usr/lib/python2.7/plat-x86_64-linux-gnu', '/usr/lib/python2.7/lib-tk', '/usr/lib/python2.7/lib-old', '/usr/lib/pytho | 07:34 |
| jamielennox | thats a bit funny looking | 07:35 |
| Sanchit | jamielennox: sorry for that. | 07:35 |
| jamielennox | but wherever you installed six needs to be before /usr/lib/python2.7/dist-packages | 07:36 |
| jamielennox | otherwise it will take that one in priority | 07:36 |
| jamielennox | Sanchit: not your fault - if I really had to i would have done it :) | 07:37 |
| Sanchit | jamielennox: Okay. I'll figure that out. | 07:37 |
| ekarlso | jamielennox: this stuff is pain... | 07:46 |
| ekarlso | now discovery get's pulled in everywhere :P | 07:46 |
| *** BAKfr has joined #openstack-keystone | 07:46 | |
| *** garnav has joined #openstack-keystone | 07:47 | |
| *** jamielennox is now known as jamielennox|away | 07:49 | |
| *** _nonameentername has joined #openstack-keystone | 07:59 | |
| openstackgerrit | wanghong proposed a change to openstack/keystone: add --rebuild option for ssl/pki_setup https://review.openstack.org/88207 | 08:01 |
| *** jamielennox|away is now known as jamielennox | 08:03 | |
| ekarlso | jamielennox: u able to help with that timeout test ? :/ | 08:04 |
| jamielennox | Which timeout test? | 08:04 |
| jamielennox | I can't run it, but if you show me i might be able to help | 08:04 |
| ekarlso | test_shell.ShellTest.test_do_timeout | 08:05 |
| *** ncoghlan has quit IRC | 08:05 | |
| *** ncoghlan has joined #openstack-keystone | 08:05 | |
| *** jraim_ has quit IRC | 08:05 | |
| *** jraim_ has joined #openstack-keystone | 08:05 | |
| *** ukalifon1 has quit IRC | 08:05 | |
| *** ukalifon1 has joined #openstack-keystone | 08:05 | |
| *** k4n0 has quit IRC | 08:05 | |
| *** k4n0 has joined #openstack-keystone | 08:05 | |
| *** Sanchit has quit IRC | 08:06 | |
| *** Sanchit has joined #openstack-keystone | 08:06 | |
| *** KanagarajM has quit IRC | 08:06 | |
| *** KanagarajM has joined #openstack-keystone | 08:06 | |
| ekarlso | http://paste.ubuntu.com/8348796/ < jamielennox there the test is | 08:06 |
| *** garnav has quit IRC | 08:06 | |
| *** garnav has joined #openstack-keystone | 08:06 | |
| jamielennox | What does it do | 08:08 |
| ekarlso | http://paste.ubuntu.com/8348817/ @ jamielennox | 08:08 |
| ekarlso | blows up saying it's never called | 08:09 |
| marekd | anyone using ubuntu 14 for openstack development at the moment? | 08:09 |
| ekarlso | marekd: ye | 08:10 |
| jamielennox | So it looks like the path to calling request has changed, the request is happening where it should hit the mock | 08:11 |
| jamielennox | This is possible actually because i moved the fake session object | 08:12 |
| ekarlso | jamielennox: :| | 08:12 |
| *** wanghong has joined #openstack-keystone | 08:12 | |
| ekarlso | jamielennox: clue on a solution ? | 08:12 |
| jamielennox | So if you're not using sessions then there is an object at the top of httpclient that is used so requests.request would come from there instead of session. Py | 08:13 |
| jamielennox | Change sessions.requests.request to "requests.request" | 08:14 |
| marekd | ekarlso: hm, no problem with python2 so far? | 08:14 |
| jamielennox | Which i think means you have to do just mock. Patch not patch object | 08:14 |
| ekarlso | marekd: nope | 08:14 |
| marekd | ekarlso: i've read they are pushing for py3 | 08:14 |
| ekarlso | marekd: yea | 08:15 |
| marekd | ok i think i will have to give it a try. | 08:15 |
| ekarlso | jamielennox: same thing | 08:22 |
| ekarlso | doesn't get called | 08:22 |
| ekarlso | the requests.request method that is | 08:23 |
| *** f13o has quit IRC | 08:23 | |
| ekarlso | but technically I could patch keystone.session.Session.request instead I guess | 08:23 |
| *** f13o has joined #openstack-keystone | 08:25 | |
| *** jamielennox is now known as jamielennox|away | 08:28 | |
| openstackgerrit | A change was merged to openstack/keystone: Fix delete group cleans up role assignments with LDAP https://review.openstack.org/119631 | 08:28 |
| openstackgerrit | A change was merged to openstack/keystone: Reduce unit test log level for notifications. https://review.openstack.org/121392 | 08:28 |
| *** f13o has quit IRC | 08:32 | |
| *** ajayaa has quit IRC | 08:37 | |
| *** f13o has joined #openstack-keystone | 08:39 | |
| *** diegows has joined #openstack-keystone | 08:43 | |
| *** k4n0 has quit IRC | 08:48 | |
| *** henrynash has joined #openstack-keystone | 08:49 | |
| *** ncoghlan has quit IRC | 08:54 | |
| *** chmouel_ is now known as chmouel | 08:59 | |
| *** k4n0 has joined #openstack-keystone | 09:08 | |
| *** alex_xu has quit IRC | 09:09 | |
| *** Guest37890 is now known as amakarov | 09:10 | |
| *** aix has joined #openstack-keystone | 09:19 | |
| ekarlso | any cli gurus here since jamielennox|away went away ? :) | 09:22 |
| *** gokrokve has joined #openstack-keystone | 09:22 | |
| ekarlso | i'm wondering if it would be bad to move the functionality of the shell class's auth_check() into the given auth plugin instead | 09:23 |
| ekarlso | since if you do ksc --os-auth-plugin v2token for example it will break since the options like username isn't registered | 09:23 |
| *** gokrokve has quit IRC | 09:27 | |
| *** rushiagr_away is now known as rushiagr | 09:42 | |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: Ensure identity sql driver supports domain-specific configuration. https://review.openstack.org/121246 | 09:48 |
| *** henrynash has quit IRC | 09:49 | |
| ukalifon1 | andreaf: Hi, Andrea. did you get a chance to work on https://review.openstack.org/#/c/115279/ ? | 09:51 |
| *** f13o has quit IRC | 09:52 | |
| *** ajayaa has joined #openstack-keystone | 09:56 | |
| andreaf | ukalifon1, Hi - no sorry - I'll spend some time on it today | 10:00 |
| *** Sanchit has quit IRC | 10:00 | |
| andreaf | ukalifon1, I still see only one changeset and don't see your test running? | 10:01 |
| ukalifon1 | andreaf: I thought I fixed it, I'll check if it didn't run. Can you give me an example of something that did run and what you are looking to see in it? | 10:03 |
| andreaf | ukalifon1, for instance there's no trace of your test in http://logs.openstack.org/79/115279/5/check/check-tempest-dsvm-full/cf3f18c/console.html.gz or http://logs.openstack.org/79/115279/5/check/check-tempest-dsvm-full/cf3f18c/logs/tempest.txt.gz | 10:04 |
| andreaf | ukalifon1, it may be you fixed it, but did you push the new code to gerrit? I only see one changeset | 10:05 |
| *** junhongl has joined #openstack-keystone | 10:07 | |
| ukalifon1 | andreaf: There are 5 patch sets in https://review.openstack.org/#/c/115279/ | 10:07 |
| ukalifon1 | is that what you mean? | 10:07 |
| andreaf | ukalifon1, I guess that means I need more coffee :P | 10:08 |
| andreaf | ukalifon1, do you have the link to a log where your test ran? | 10:08 |
| andreaf | ukalifon1, I download your change I'm looking at it anyways | 10:09 |
| ekarlso | hmmm, auth_check is evil... | 10:11 |
| *** sanchit has joined #openstack-keystone | 10:12 | |
| sanchit | jamielennox|away: Hi, I tried fixing the six library issue | 10:13 |
| ekarlso | if you use --os-auth-plugin <name> it doesn't load the wanted options and ks client shell goes bork | 10:13 |
| sanchit | jamielennox|away: I upgraded to six 1.8.0 and I am able to import backends from keystone in python prompt | 10:13 |
| sanchit | jamielennox|away: But, When I try keystone-all, it still displayes error File "/usr/local/bin/keystone-all", line 43, in <module> from keystone import backends ImportError: cannot import name backends | 10:14 |
| sanchit | Can Anyone help mw with this issue | 10:15 |
| sanchit | ? | 10:15 |
| sanchit | me* | 10:15 |
| andreaf | ukalifon1, so you added a new folder but you don't have an __init__.py in it, that's why your test is not picked up | 10:18 |
| andreaf | ukalifon1, do you mind if I upload a new patchset? | 10:19 |
| *** mflobo has joined #openstack-keystone | 10:22 | |
| *** gokrokve has joined #openstack-keystone | 10:22 | |
| andreaf | ukalifon1, ok I added a new patchset - let's wait for it to run | 10:25 |
| ukalifon1 | andreaf: thanks very much | 10:25 |
| andreaf | ukalifon1, https://review.openstack.org/#/c/115279/7 | 10:26 |
| *** gokrokve has quit IRC | 10:27 | |
| *** ajayaa has quit IRC | 10:30 | |
| *** ajayaa has joined #openstack-keystone | 10:31 | |
| *** Krast has joined #openstack-keystone | 10:34 | |
| *** Krast has quit IRC | 10:35 | |
| *** HenryG has joined #openstack-keystone | 10:37 | |
| *** rushiagr is now known as rushiagr_away | 10:37 | |
| *** diegows has quit IRC | 10:38 | |
| *** k4n0 has quit IRC | 10:42 | |
| *** rushiagr_away is now known as rushiagr | 10:44 | |
| *** ajayaa has quit IRC | 10:54 | |
| *** ajayaa has joined #openstack-keystone | 10:54 | |
| *** rushiagr is now known as rushiagr_away | 10:56 | |
| *** k4n0 has joined #openstack-keystone | 11:04 | |
| *** lufix has joined #openstack-keystone | 11:05 | |
| lufix | Is it okay to ask a general keystone question or is this channel meant for developers of keystone only? | 11:07 |
| *** topol has joined #openstack-keystone | 11:07 | |
| ekarlso | grrrr | 11:10 |
| ekarlso | 5 failurse | 11:10 |
| *** afaranha has joined #openstack-keystone | 11:11 | |
| ekarlso | anyone wanna help me conquor ksclient to use sessions atm ? | 11:12 |
| ekarlso | with the cli.. | 11:12 |
| ekarlso | 4 tests are failing on auth_tenant_id auth_user_id being used in the CLI | 11:12 |
| *** dimsum_ has joined #openstack-keystone | 11:12 | |
| *** f13o has joined #openstack-keystone | 11:13 | |
| *** sanchit has quit IRC | 11:16 | |
| *** alex_xu has joined #openstack-keystone | 11:22 | |
| *** gokrokve has joined #openstack-keystone | 11:22 | |
| *** alex_xu has quit IRC | 11:23 | |
| *** alex_xu has joined #openstack-keystone | 11:23 | |
| *** dims_ has joined #openstack-keystone | 11:24 | |
| *** dimsum_ has quit IRC | 11:24 | |
| *** alex_xu has quit IRC | 11:24 | |
| *** alex_xu has joined #openstack-keystone | 11:25 | |
| *** alex_xu has quit IRC | 11:25 | |
| *** samuelmz has joined #openstack-keystone | 11:26 | |
| *** alex_xu has joined #openstack-keystone | 11:27 | |
| *** gokrokve has quit IRC | 11:27 | |
| *** alex_xu has quit IRC | 11:27 | |
| *** alex_xu has joined #openstack-keystone | 11:29 | |
| *** alex_xu has quit IRC | 11:30 | |
| *** dims_ has quit IRC | 11:33 | |
| *** dims has joined #openstack-keystone | 11:33 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed a change to openstack/keystone: Improve list role assignments filters performance https://review.openstack.org/116682 | 11:34 |
| *** KanagarajM has quit IRC | 11:38 | |
| *** rushiagr_away is now known as rushiagr | 11:42 | |
| *** alex_xu has joined #openstack-keystone | 11:48 | |
| *** rodrigods has joined #openstack-keystone | 11:58 | |
| marekd | dolphm: o/ | 12:10 |
| *** dims has quit IRC | 12:18 | |
| *** dims has joined #openstack-keystone | 12:19 | |
| *** gokrokve has joined #openstack-keystone | 12:22 | |
| openstackgerrit | Endre Karlson proposed a change to openstack/python-keystoneclient: Make keystoneclient use an adapter https://review.openstack.org/97681 | 12:24 |
| openstackgerrit | Endre Karlson proposed a change to openstack/python-keystoneclient: Allow retrying some failed requests https://review.openstack.org/118004 | 12:24 |
| openstackgerrit | Endre Karlson proposed a change to openstack/python-keystoneclient: Make Keystone use CLI Plugin https://review.openstack.org/121523 | 12:24 |
| ekarlso | git needs pep8 cleanup :/ | 12:26 |
| ekarlso | anyone wanna take a initial look ? | 12:26 |
| *** gokrokve has quit IRC | 12:27 | |
| openstackgerrit | Peter Razumovsky proposed a change to openstack/keystone: Add a simple module to work with filters and DNs to LDAP backend https://review.openstack.org/117484 | 12:30 |
| *** ajayaa has quit IRC | 12:31 | |
| *** andreaf has quit IRC | 12:35 | |
| marekd | ekarlso: https://review.openstack.org/121523 ? | 12:35 |
| *** andreaf has joined #openstack-keystone | 12:35 | |
| ekarlso | marekd: ya | 12:36 |
| *** gordc has joined #openstack-keystone | 12:43 | |
| *** ajayaa has joined #openstack-keystone | 12:44 | |
| *** afazekas has joined #openstack-keystone | 12:46 | |
| openstackgerrit | Endre Karlson proposed a change to openstack/python-keystoneclient: Make Keystone use CLI Plugin https://review.openstack.org/121523 | 12:49 |
| ekarlso | marekd: anything out of the glance that's bad ? | 12:50 |
| ekarlso | at a glance ) | 12:50 |
| marekd | ekarlso: i will try to look at it later. | 12:51 |
| ekarlso | ok :() | 12:52 |
| ekarlso | s/(// | 12:52 |
| andreaf | ukalifon1: http://logs.openstack.org/79/115279/7/check/check-tempest-dsvm-full/53e9126/logs/tempest.txt.gz#_2014-09-15_11_00_51_901 | 12:55 |
| andreaf | ukalifon1: so the problem seems to be that token generation is controlled for all tests by the auth_version config flag | 12:56 |
| *** diegows has joined #openstack-keystone | 12:56 | |
| andreaf | ukalifon1: so you create a new user in a new domain, and try to obtain a token for it, however the token is requested via v2 API rather than v3 | 12:59 |
| ukalifon1 | andreaf: I'll try to run it with auth_version=v3. Thanks. However, if I'm using auth.KeystoneV3Credentials in my code - shouldn't it also authenticate with v3? | 13:01 |
| ukalifon1 | how will we mix tests of v2 and v3? | 13:02 |
| andreaf | ukalifon1: yes I suppose the code should consider that if you override the config and go for v3 regardless - which is a perfectly valid use case for identity tests - you may expect the token requests to go along via the same api | 13:04 |
| andreaf | ukalifon1: I'll see if I can fix this | 13:04 |
| andreaf | ukalifon1: in fact I expected keystone to be smart enough and generate a token via v2 | 13:05 |
| andreaf | ukalifon1: there's probably I good reason why it's not doing that | 13:05 |
| ukalifon1 | andreaf: Not sure if I understand you... You expect keystone to generate a v3 token via v2? Of course it won't do that | 13:07 |
| andreaf | ukalifon1: I though keystone would generate a v2 token for an user provisioned via v3 api | 13:08 |
| *** alex_xu has quit IRC | 13:08 | |
| ukalifon1 | andreaf: the problem is that v2 won't find the user that I created outside the default domain | 13:08 |
| andreaf | ukalifon1: so v2 only sees the Default domain? | 13:10 |
| ukalifon1 | andreaf: yes, the default domain exists to provide compatibility with v2 | 13:11 |
| andreaf | ukalifon1: understood, thanks | 13:11 |
| ukalifon1 | andreaf: if you create a user with v3 in the default domain, you can get a v2 token | 13:11 |
| *** k4n0 has quit IRC | 13:13 | |
| *** bknudson has quit IRC | 13:15 | |
| andreaf | ukalifon1, https://bugs.launchpad.net/tempest/+bug/1369557 | 13:18 |
| uvirtbot | Launchpad bug 1369557 in tempest "Tempest auth provider uses v2 token with v3 Auth Provider" [Undecided,Confirmed] | 13:18 |
| *** joesavak has joined #openstack-keystone | 13:20 | |
| *** gokrokve has joined #openstack-keystone | 13:22 | |
| *** jamielennox|away is now known as jamielennox | 13:25 | |
| *** gokrokve has quit IRC | 13:27 | |
| *** jamielennox is now known as jamielennox|away | 13:27 | |
| *** sigmavirus24b is now known as sigmavirus24 | 13:31 | |
| *** sigmavirus24 has joined #openstack-keystone | 13:31 | |
| *** afaranha has quit IRC | 13:31 | |
| *** rodrigods has quit IRC | 13:33 | |
| *** samuelmz has quit IRC | 13:33 | |
| *** achampio1 has quit IRC | 13:37 | |
| *** ayoung has joined #openstack-keystone | 13:39 | |
| *** achampion has joined #openstack-keystone | 13:42 | |
| *** ChanServ sets mode: +o dolphm | 13:44 | |
| *** saipandi has joined #openstack-keystone | 13:46 | |
| *** nkinder has joined #openstack-keystone | 13:48 | |
| *** r-daneel__ has joined #openstack-keystone | 13:48 | |
| *** radez_g0n3 is now known as radez | 13:49 | |
| *** jimhoagland has joined #openstack-keystone | 13:51 | |
| *** bknudson has joined #openstack-keystone | 13:52 | |
| *** vhoward has joined #openstack-keystone | 13:54 | |
| *** gokrokve has joined #openstack-keystone | 14:00 | |
| *** ayoung has quit IRC | 14:05 | |
| andreaf | ukalifon1, this should fix your issue https://review.openstack.org/121562 | 14:06 |
| mfisch | nkinder: you in? | 14:09 |
| nkinder | mfisch: yep | 14:09 |
| mfisch | nkinder: would you be so kind to backport this? https://review.openstack.org/#/c/119457/ | 14:10 |
| mfisch | Its causing me headaches in Icehouse | 14:10 |
| *** zzzeek has joined #openstack-keystone | 14:10 | |
| nkinder | mfisch: pretty sure I already proposed it. Let me dig up the review. | 14:11 |
| ukalifon1 | andreaf: Thank you. I will test it soon. Thanks for a very quick fix! | 14:11 |
| nkinder | mfisch: https://review.openstack.org/#/c/119578/ | 14:12 |
| mfisch | awesome | 14:12 |
| mfisch | I tried the one click CP and it failed so I came here since I've not had coffee yet | 14:12 |
| nkinder | mfisch: it has all of the reviews it needs. I believe morganfainberg said he would approve it once the gate settled down. | 14:12 |
| mfisch | yeah he's tired of my emails about this | 14:13 |
| *** stevemar has joined #openstack-keystone | 14:13 | |
| mfisch | we store crazy stuff in our LDAP like pictures of people | 14:13 |
| *** gokrokve has quit IRC | 14:13 | |
| *** jimhoagland has quit IRC | 14:14 | |
| morganfainberg | nkinder, yes i will | 14:18 |
| * morganfainberg goes and hits +A | 14:18 | |
| *** gokrokve has joined #openstack-keystone | 14:20 | |
| *** rwsu has joined #openstack-keystone | 14:21 | |
| *** gokrokve has quit IRC | 14:25 | |
| *** gokrokve has joined #openstack-keystone | 14:25 | |
| *** david-lyle has joined #openstack-keystone | 14:33 | |
| *** gokrokve has quit IRC | 14:44 | |
| *** rodrigods has joined #openstack-keystone | 14:44 | |
| *** rodrigods has quit IRC | 14:44 | |
| *** rodrigods has joined #openstack-keystone | 14:44 | |
| *** gokrokve has joined #openstack-keystone | 14:44 | |
| *** Ephur has joined #openstack-keystone | 14:47 | |
| *** cjellick_ has quit IRC | 14:52 | |
| *** gokrokve has quit IRC | 14:52 | |
| *** jorge_munoz has joined #openstack-keystone | 14:55 | |
| *** dims_ has joined #openstack-keystone | 14:56 | |
| *** dims__ has joined #openstack-keystone | 14:58 | |
| *** dims has quit IRC | 14:59 | |
| *** dims_ has quit IRC | 15:01 | |
| *** jraim_ has quit IRC | 15:04 | |
| *** rushiagr is now known as rushiagr_away | 15:05 | |
| *** jraim has joined #openstack-keystone | 15:06 | |
| nkinder | morganfainberg: thanks! | 15:08 |
| *** rodrigods has quit IRC | 15:08 | |
| *** jimhoagland has joined #openstack-keystone | 15:11 | |
| *** ukalifon1 has quit IRC | 15:14 | |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Allow users to clean up role assignments. https://review.openstack.org/119843 | 15:18 |
| *** zzzeek_ has joined #openstack-keystone | 15:24 | |
| *** zzzeek has quit IRC | 15:24 | |
| *** zzzeek_ is now known as zzzeek | 15:24 | |
| *** diegows has quit IRC | 15:24 | |
| morganfainberg | lbragstad, think that patch will be ready today ^ | 15:30 |
| lbragstad | morganfainberg: i believe so, it was passing Jenkins last week and it had a good review | 15:31 |
| lbragstad | I just addressed those comments and plan on keeping a close eye on it today in case I need to update anything else | 15:31 |
| morganfainberg | lbragstad, bknudson, https://bugs.launchpad.net/keystone/+bug/1329891 i'm not sure we want to try to fix this for RC (or even at all) | 15:32 |
| uvirtbot | Launchpad bug 1329891 in keystone "Keystone Not Able to Add Users to AD/Ldap and OpenLdap due to BAD_ATT_SYNTAX (Invalid DN syntax)" [Medium,Triaged] | 15:32 |
| *** cjellick has joined #openstack-keystone | 15:33 | |
| morganfainberg | lbragstad, ++ | 15:33 |
| *** samuelmz has joined #openstack-keystone | 15:34 | |
| bknudson | morganfainberg: there's no fix proposed so I can't guess what the change is that's being proposed for 1329891 | 15:34 |
| morganfainberg | lbragstad, bknudson, from the AD perspective. I'm not sure about the OpenLDAP bit, but I've run devstack with OpenLDAP and have not seen this issue | 15:35 |
| bknudson | morganfainberg: as I mentioned, I don't see the point to even supporting write to AD. | 15:36 |
| nkinder | morganfainberg: I'm reading it over now | 15:36 |
| morganfainberg | bknudson, i'm fine with punting this if it isn't an openldap issue | 15:36 |
| nkinder | bknudson: I'm also inclined to agree with you about read/write to AD | 15:36 |
| morganfainberg | nkinder, thanks! | 15:36 |
| *** lufix has quit IRC | 15:36 | |
| morganfainberg | we can mark it as wishlist if it's strictly AD | 15:36 |
| nkinder | The 'enabled' attribute thing just seems like a mis-configuration to me | 15:37 |
| morganfainberg | and let it die somewhere down the line. | 15:37 |
| nkinder | If they have it configured for userAccountControl, that part should work fine | 15:37 |
| bknudson | looks like the bug is also complaining about how keystone puts the ID as the CN. | 15:37 |
| lbragstad | we run OpenLDAP in tests right? | 15:37 |
| morganfainberg | in K I expect to have an OpenLDAP gate, but it's a lot of work because devstack doesn't play nice. | 15:37 |
| morganfainberg | lbragstad, sadly no. | 15:37 |
| bknudson | which I don't see how we're going to change that behavior | 15:37 |
| lbragstad | from bknudson's comment "We've got a devstack configuration that creates users in OpenLDAP through Keystone and it doesn't hit the problem with the DN mentioned here." | 15:38 |
| morganfainberg | lbragstad, correct i've *run* devstack with ldap, but we don't gate on it | 15:38 |
| nkinder | I feel like hte rest of this issue is the same as what gyee recently fixed | 15:38 |
| lbragstad | :( | 15:38 |
| bknudson | lbragstad: it's easy to start up devstack with ldap as the backend. | 15:38 |
| nkinder | I think the problem being encountered is that the DN refers to an attribute that is not in the entry | 15:38 |
| morganfainberg | it's not so easy to make the gate play nice with it. | 15:38 |
| lbragstad | gotcha | 15:39 |
| lbragstad | yeah that makes sense | 15:39 |
| morganfainberg | which is why i expect to work on that in K not at the last minute in J | 15:39 |
| lbragstad | ok, well I'd be fine with punting on this if we can provide some documentation that might help the reporter? | 15:39 |
| morganfainberg | besides i want to move to a more functional test framework anyway. | 15:39 |
| morganfainberg | which would make gating on LDAP easier to handle. | 15:39 |
| lbragstad | so they can get around the write with OpenLDAP case anyway, | 15:40 |
| lbragstad | not sure about AD, but I think morganfainberg has a good point about using Keystone to manage AD | 15:40 |
| morganfainberg | nkinder, do you think you'd have the bandwidth to help out the reporter here isolate the OpenLDAP case? | 15:40 |
| nkinder | morganfainberg: I think this might be the same as https://bugs.launchpad.net/keystone/+bug/1340041 | 15:41 |
| uvirtbot | Launchpad bug 1340041 in keystone "OpenLDAP 2.3: naming attribute [...] is not present in entry; Naming violation" [Medium,Fix committed] | 15:41 |
| morganfainberg | ah | 15:41 |
| nkinder | morganfainberg: I'll add some comments | 15:41 |
| morganfainberg | nkinder, ok i'm going to unset Juno RC | 15:41 |
| bknudson | AD doesn't add the naming attribute value? | 15:41 |
| morganfainberg | nkinder, if it is a legitimate case we'll re add it | 15:41 |
| lbragstad | morganfainberg: nkinder thanks | 15:41 |
| nkinder | bknudson: I think it might not. I'd have to double check, but wouldn't be terribly surprised if it rejected it | 15:42 |
| lbragstad | morganfainberg: ++ we'll re add if needed, but I think we'd be safe to remove RC1 as long as we provide some info | 15:42 |
| nkinder | bknudson: I don't see anything about the DN that is illegal from a quick glance at the LP | 15:42 |
| nkinder | bknudson: so I think it's saying that the DN is illegal since it refers to an attribute value that isn't present in the entry | 15:42 |
| morganfainberg | we only have 1 bug left not in-progress. | 15:43 |
| morganfainberg | for RC | 15:43 |
| morganfainberg | https://bugs.launchpad.net/keystone/+bug/1362245 | 15:43 |
| uvirtbot | Launchpad bug 1362245 in openstack-api-site "Update Endpoint Filter APIs" [Undecided,New] | 15:43 |
| bknudson | ok, that would be fixed by the other change to add the value then. of course, then you'd have a multivalued cn. | 15:44 |
| morganfainberg | lbragstad, bknudson, dstanek, stevemar, before I rebase https://review.openstack.org/#/c/119452/ any comments would be appreciated (i'll cover them myself, beyond my one comment about use of a variable called _ ) | 15:46 |
| lbragstad | checking | 15:46 |
| *** gyee has joined #openstack-keystone | 15:50 | |
| lbragstad | morganfainberg: minor comments. | 15:51 |
| morganfainberg | lbragstad, ok | 15:51 |
| *** rodrigods has joined #openstack-keystone | 15:59 | |
| BAKfr | morganfainberg, I've a question about a modification you've done in https://review.openstack.org/#/c/115338/9 | 16:00 |
| BAKfr | in assignement/core.py, line 546, | 16:00 |
| morganfainberg | BAKfr, ok | 16:00 |
| BAKfr | It shouldn't be self._emit_invalidate_user_token_persistence(user['id']) ? | 16:01 |
| BAKfr | instead of self._emit_invalidate_user_token_persistence(user_id) ? | 16:01 |
| morganfainberg | BAKfr, looks like it. | 16:02 |
| morganfainberg | BAKfr, good catch | 16:02 |
| BAKfr | morganfainberg, thanks | 16:03 |
| morganfainberg | BAKfr, please file a bug and if you don't mind submit a fix for that :) | 16:03 |
| BAKfr | morganfainberg, And I've another question, on the same file: can we use "self._emit_invalidate_user_project_tokens_notification()" if project_id is not None ? | 16:04 |
| *** ajayaa has quit IRC | 16:04 | |
| morganfainberg | BAKfr, let me look in a moment | 16:04 |
| *** rushiagr_away is now known as rushiagr | 16:05 | |
| BAKfr | morganfainberg, OK, thanks | 16:05 |
| BAKfr | morganfainberg, I'll submit a fix later :) | 16:05 |
| *** gokrokve has joined #openstack-keystone | 16:06 | |
| morganfainberg | BAKfr, sure, it's not a big change but if you can get it in quickly i'd def. like you to get credit for it :) | 16:06 |
| *** electrichead is now known as redrobot | 16:08 | |
| *** wwriverrat has joined #openstack-keystone | 16:09 | |
| *** marcoemorais has joined #openstack-keystone | 16:10 | |
| *** thiagop has joined #openstack-keystone | 16:10 | |
| morganfainberg | BAKfr, the use of _emit_invalidate_user_project_tokens_notification will only occur with project_id != none | 16:11 |
| openstackgerrit | Alexander Makarov proposed a change to openstack/keystone: LDAP additional attribute mappings validation https://review.openstack.org/118590 | 16:11 |
| morganfainberg | BAKfr, you *could* use it w/ project_id=None but it would just net the same effect as invalidating all user tokens | 16:12 |
| morganfainberg | ok i'm going to get breakfast, when i'm back i'll push the fixes for https://review.openstack.org/#/c/119452/ | 16:15 |
| *** garnav has quit IRC | 16:15 | |
| BAKfr | morganfainberg, when project_id is defined in delete_grant, it would invalidate far less tokens ? | 16:15 |
| morganfainberg | BAKfr, yes, it only revokes tokens for the user scoped to that project | 16:16 |
| *** jraim has quit IRC | 16:17 | |
| BAKfr | morganfainberg, last question, should I submit one commit, or split into two (one for the bugfix, and another one for revoking less tokens ? | 16:17 |
| *** jraim has joined #openstack-keystone | 16:18 | |
| *** jimhoagland has quit IRC | 16:18 | |
| morganfainberg | BAKfr, wait, what case are we using that emit without project id? | 16:18 |
| morganfainberg | BAKfr, in delete_grant it should only ever call that with the complate project_id payload | 16:18 |
| *** wwriverrat has left #openstack-keystone | 16:18 | |
| BAKfr | morganfainberg, when we deletes a domain grant ? | 16:19 |
| morganfainberg | BAKfr, ah ok that one has to revoke *all* tokens for the user | 16:20 |
| BAKfr | morganfainberg, If I gives project_id=None to self._emit_invalidate_user_project_tokens_notification(), it revokes all tokens ? | 16:21 |
| morganfainberg | BAKfr we wont have project_id= None | 16:21 |
| morganfainberg | when dealing with domains grants we use _emit_invalidate_user_token_persistence | 16:21 |
| BAKfr | morganfainberg, ok | 16:21 |
| morganfainberg | BAKfr, so the only bug is the user_id -> user['id'] fix | 16:22 |
| dstanek | morganfainberg: i was already looking at that | 16:22 |
| morganfainberg | dstanek, cool. | 16:22 |
| morganfainberg | dstanek, i've got a patch rolled that handles most of my comments and lbragstad's comments | 16:22 |
| ekarlso | could I get a bit help with https://review.openstack.org/#/c/121523/ ? | 16:22 |
| *** jasonsb_ has quit IRC | 16:22 | |
| dstanek | morganfainberg: ok, i'll refresh and take a look st the new comments | 16:23 |
| morganfainberg | dstanek, i'll look for any comments you have when i'm back from breakfast and roll those into my fix | 16:23 |
| dstanek | morganfainberg: i was going to see why dogpile's backend handles threads improperly, buy got side tracked | 16:23 |
| nkinder | morganfainberg: with the switch to uuid as the defautl token provider, shouldn't a similar change be made to puppet-keystone? | 16:24 |
| nkinder | morganfainberg: I know it falls outside of keystone itself, but I'm not sure if anyone had that on their radar | 16:24 |
| morganfainberg | dstanek, it's an issue with the underlying memcache lib - it explicitly uses thread.local | 16:24 |
| morganfainberg | dstanek, thread.local plays *too* well with eventlet | 16:24 |
| morganfainberg | dstanek, so each request spawns a new client object, consuming all sockets/FDs etc (to a point) potentially allowing for a Dos in some cases | 16:25 |
| morganfainberg | nkinder, i dunno if that team wants to switch it back. | 16:25 |
| morganfainberg | nkinder, i wouldn't be opposed to it. but largely i've left that type of decision to those who run that repo | 16:25 |
| morganfainberg | dstanek, in short eventlet is unsafe to use with the python-memcache library | 16:26 |
| nkinder | morganfainberg: ok, I wonder if they're aware of the default change on the Keystone side (and if they really want pki or have just followed the keystone defaults) | 16:26 |
| morganfainberg | nkinder, def something to follow up on | 16:26 |
| dstanek | morganfainberg: that's really strange. and gc doesn't cleanup after itself? | 16:26 |
| morganfainberg | dstanek, it's not the GC, its that greenthreads are yeilded to another event | 16:27 |
| morganfainberg | dstanek, but it doesn't mean the socket / client doesn't exist | 16:27 |
| lbragstad | morganfainberg: I'd say most of the keystone reviews here are looking good https://gist.github.com/dolph/651c6a1748f69637abd0 | 16:27 |
| morganfainberg | dstanek, some cases gc also delays and takes a long time to cleanup. | 16:27 |
| dstanek | morganfainberg: i just submitted the comments i had so far | 16:28 |
| morganfainberg | dstanek, ++ sounds good. like i said going to get food. | 16:28 |
| morganfainberg | be back shortly | 16:28 |
| morganfainberg | (food and coffee) | 16:28 |
| ekarlso | I would really appreciate someone with more ksclient knowledge to help on that one :) | 16:28 |
| *** KanagarajM has joined #openstack-keystone | 16:29 | |
| *** marcoemorais has quit IRC | 16:34 | |
| *** marcoemorais has joined #openstack-keystone | 16:34 | |
| dstanek | ekarlso: what kind of help are you looking for? | 16:36 |
| ekarlso | dstanek: trying to figure out where it fails | 16:37 |
| ekarlso | but my knowledge of ksclient is thin | 16:37 |
| *** marcoemorais has quit IRC | 16:38 | |
| *** marcoemorais has joined #openstack-keystone | 16:38 | |
| dstanek | ekarlso: have you looked at tempest to see where it's getting the endpoint from? | 16:38 |
| dstanek | ekarlso: maybe the catalog is getting returned to in incorrectly | 16:38 |
| ekarlso | dstanek: nope | 16:39 |
| *** raildo has joined #openstack-keystone | 16:41 | |
| dstanek | ekarlso: what is the cli plugin that you are making? | 16:42 |
| ekarlso | dstanek: it was the idea jamielennox|away had | 16:43 |
| raildo | dolphm, is there a topics list to design summit in Keystone or something like that? | 16:43 |
| ekarlso | basically use a seperate plugin for the cli if a user doesn't specif one | 16:43 |
| raildo | or etherpad | 16:43 |
| dstanek | ekarlso: where did all of these options move to? | 16:44 |
| dstanek | https://review.openstack.org/#/c/121523/2/keystoneclient/shell.py | 16:44 |
| ekarlso | dstanek: they are in the auth plugins | 16:44 |
| ekarlso | ksc.auth.cli.register_* or what the func is called again registers the opts from the plugin cls | 16:45 |
| *** ukalifon has joined #openstack-keystone | 16:45 | |
| dstanek | ekarlso: so those entries are redundant? | 16:47 |
| dstanek | ekarlso: i did a real quick review on that | 16:51 |
| openstackgerrit | A change was merged to openstack/keystone: Making KvsInheritanceTests use backend KVS https://review.openstack.org/118466 | 16:53 |
| *** ayoung has joined #openstack-keystone | 16:54 | |
| *** richm has joined #openstack-keystone | 16:56 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/111620 | 16:59 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/119142 | 16:59 |
| *** dims__ has quit IRC | 16:59 | |
| *** marcoemorais1 has joined #openstack-keystone | 16:59 | |
| *** dims has joined #openstack-keystone | 16:59 | |
| *** afazekas has quit IRC | 17:02 | |
| *** morgan_remote_ has joined #openstack-keystone | 17:02 | |
| openstackgerrit | A change was merged to openstack/keystone: Adds hint about filter placement to extension docs https://review.openstack.org/119834 | 17:02 |
| *** marcoemorais has quit IRC | 17:03 | |
| *** dims has quit IRC | 17:04 | |
| *** harlowja has joined #openstack-keystone | 17:04 | |
| *** dims has joined #openstack-keystone | 17:04 | |
| *** jimbaker has quit IRC | 17:06 | |
| *** afaranha has joined #openstack-keystone | 17:07 | |
| stevemar | morganfainberg, can you add https://review.openstack.org/#/c/121146/ to the list of bugs on your watch list | 17:07 |
| *** andreaf is now known as andreaf_ | 17:07 | |
| morgan_remote_ | dstanek: the upper bound on connections for memcache is meant to be managed with the maxsize value. On line 80. That may be insufficient though. | 17:08 |
| *** jimbaker has joined #openstack-keystone | 17:09 | |
| *** jimbaker has quit IRC | 17:09 | |
| *** jimbaker has joined #openstack-keystone | 17:09 | |
| morgan_remote_ | stevemar: I'll add it when I'm back. dstanek and lbragstad I think can also add to that list. | 17:09 |
| stevemar | add it to all the lists! | 17:10 |
| morgan_remote_ | Hehe. | 17:10 |
| dstanek | morgan_remote_: hmmm. i didn't see that before - i'll take another look in a few | 17:10 |
| lbragstad | stevemar: rc1 list? | 17:10 |
| dstanek | morgan_remote_: i don't understand all the realup | 17:10 |
| morgan_remote_ | dstanek: np. It's unfortunately complex code :(. But mucking with event let and threading always is. | 17:11 |
| dstanek | morgan_remote_: i don't know. without the cleanup i think it could be much cleaner | 17:12 |
| morgan_remote_ | I agree. | 17:12 |
| dstanek | morgan_remote_: available and uses lists with a context manager that moves things between them | 17:13 |
| morgan_remote_ | I am not super happy with the whole need a cleanup thread. | 17:13 |
| dstanek | i'm not sure that we actually need it | 17:13 |
| morgan_remote_ | Maybe I'll take a crack at a complete rework today. | 17:13 |
| morgan_remote_ | Minus the cleanup worker. | 17:13 |
| openstackgerrit | Kévin Bernard-Allies proposed a change to openstack/keystone: Revoke the tokens of group members when a group role is revoked https://review.openstack.org/121628 | 17:13 |
| morgan_remote_ | Still will need some logic for cleaning up dead client connections. But I *think* we can do that inline of the context manager. | 17:16 |
| openstackgerrit | Alexander Makarov proposed a change to openstack/keystone: LDAP additional attribute mappings validation https://review.openstack.org/118590 | 17:17 |
| *** cdnchris has joined #openstack-keystone | 17:17 | |
| dstanek | morgan_remote_: dead meaning the socket died? | 17:17 |
| *** marcoemorais has joined #openstack-keystone | 17:18 | |
| *** marcoemorais1 has quit IRC | 17:18 | |
| ekarlso | dstanek: what entries ? :O | 17:18 |
| stevemar | lbragstad, sorta, it's middleware/client, so not really rc1, but we should get it in | 17:19 |
| dstanek | ekarlso: the ones you deleted | 17:19 |
| morgan_remote_ | Yeah. Or the server marked as dead. You want those clients deleted. | 17:19 |
| lbragstad | stevemar: cool, I'll add it | 17:19 |
| dstanek | morgan_remote_: isn't the server marked dead handled by the memcache library itself? | 17:19 |
| morgan_remote_ | Not well. | 17:19 |
| ekarlso | dstanek: uhm, point is that opts will be loaded from the plugins | 17:19 |
| morgan_remote_ | Python-memcache (in my opinion) is a subwonderful lib all around. | 17:20 |
| *** KanagarajM has quit IRC | 17:20 | |
| dstanek | morgan_remote_: really? i've never seen a problem with it. i'll have to look at the patch again and see what it adds? | 17:20 |
| morgan_remote_ | Well this patch also forces reuse of | 17:21 |
| openstackgerrit | Alexander Makarov proposed a change to openstack/keystone: LDAP additional attribute mappings validation https://review.openstack.org/118590 | 17:21 |
| *** cdnchris has left #openstack-keystone | 17:21 | |
| morgan_remote_ | Connections. And the server being marked dead is more of a if you use the memcache lib directly for handling multiple servers. In this case we pool for each server. | 17:21 |
| morgan_remote_ | So we need to independently mark servers as dead. | 17:23 |
| *** dutsmoc is now known as comstud | 17:24 | |
| *** amcrn has joined #openstack-keystone | 17:26 | |
| *** amakarov is now known as amakarov_away | 17:30 | |
| *** afazekas has joined #openstack-keystone | 17:30 | |
| *** bjornar_ has joined #openstack-keystone | 17:33 | |
| *** BAKfr has quit IRC | 17:33 | |
| *** diegows has joined #openstack-keystone | 17:45 | |
| openstackgerrit | Marek Denis proposed a change to openstack/keystone: Document Keystone2Keystone federation https://review.openstack.org/120584 | 17:46 |
| openstackgerrit | Endre Karlson proposed a change to openstack/python-keystoneclient: Make Keystone use CLI Plugin https://review.openstack.org/121523 | 17:51 |
| ekarlso | dstanek: thnx for the heads up on the obvious errors : ) | 17:52 |
| dstanek | ekarlso: yw...do we no longer support the old style options? | 17:53 |
| *** aix has quit IRC | 17:54 | |
| ekarlso | dstanek: gotta ask jamielennox|away about that one :) | 17:55 |
| dstanek | ekarlso: did he say to remove the tests or did you do it because they were broken? | 17:56 |
| ekarlso | dstanek: I removed them since they broke and I asked him about the - vs _ opts | 17:58 |
| dstanek | ekarlso: i wonder if tempest uses some of those | 18:00 |
| ekarlso | dstanek: :| | 18:00 |
| ekarlso | dstanek: i'll have to check with him in a few hours or tmrw then :) | 18:00 |
| dstanek | ekarlso: he may not be around for a while - i don't remember when his vacation starts, but he's taking one before the summit | 18:01 |
| ekarlso | awww | 18:01 |
| ekarlso | darn :) | 18:01 |
| ekarlso | well i'm not sure then :/ | 18:01 |
| ekarlso | it was a next step thingie for him after the generic plugin if I remember correctly | 18:01 |
| *** marcoemorais has quit IRC | 18:02 | |
| *** marcoemorais has joined #openstack-keystone | 18:02 | |
| *** marcoemorais has quit IRC | 18:03 | |
| *** rushiagr is now known as rushiagr_away | 18:03 | |
| *** afazekas has quit IRC | 18:03 | |
| *** marcoemorais has joined #openstack-keystone | 18:03 | |
| ekarlso | dstanek: but I don't get it, there's 1 test in py34 that's borking :'( | 18:03 |
| dstanek | ekarlso: unit test? | 18:04 |
| ekarlso | yes | 18:04 |
| *** afazekas has joined #openstack-keystone | 18:04 | |
| ekarlso | http://paste.ubuntu.com/8352123/ | 18:04 |
| *** cdnchris has joined #openstack-keystone | 18:05 | |
| *** jasonsb has joined #openstack-keystone | 18:05 | |
| *** dims has quit IRC | 18:06 | |
| dstanek | ekarlso: that's odd - and it works under 3.3? | 18:06 |
| ekarlso | 2,7 works fine | 18:07 |
| *** topol has quit IRC | 18:07 | |
| *** topol has joined #openstack-keystone | 18:08 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Document Keystone2Keystone federation https://review.openstack.org/120584 | 18:09 |
| *** dims has joined #openstack-keystone | 18:11 | |
| *** cdnchris has quit IRC | 18:15 | |
| *** mitz_ has quit IRC | 18:16 | |
| *** cdnchris has joined #openstack-keystone | 18:21 | |
| *** gyee has quit IRC | 18:22 | |
| morganfainberg | dstanek, ok i'm going to take a crack at this pool thing and see if i can remove the cleaner thread. | 18:24 |
| morganfainberg | dstanek, it should be much much easier to read if we do. | 18:24 |
| morganfainberg | dstanek, and less ... scary/brittle | 18:24 |
| *** afazekas has quit IRC | 18:24 | |
| dstanek | morganfainberg: awesome - the current proxy design is likely to break with future dogpile changes if it's not already broken | 18:26 |
| morganfainberg | yeah | 18:26 |
| morganfainberg | and once past RC going to see if we can fix dogpile and the rest of our stuff to use pymemcache | 18:27 |
| morganfainberg | (which looks like it solves all of the thread.local issues) | 18:27 |
| morganfainberg | among other things | 18:27 |
| ekarlso | dstanek: u got a clue on the py34 failure ? | 18:27 |
| dstanek | ekarlso: no, but i can try to apply your patch in a bit and see if i can reproduce | 18:28 |
| ekarlso | dstanek: coolio! | 18:28 |
| *** afazekas has joined #openstack-keystone | 18:29 | |
| dstanek | ekarlso: my working copy is dirty with a change that is waiting on a pbr bugfix so i just have to move it out of the way | 18:29 |
| *** openstackgerrit has quit IRC | 18:32 | |
| *** openstackgerrit has joined #openstack-keystone | 18:32 | |
| *** vhoward has left #openstack-keystone | 18:33 | |
| *** henrynash has joined #openstack-keystone | 18:38 | |
| *** cdnchris has left #openstack-keystone | 18:46 | |
| *** afazekas has quit IRC | 18:47 | |
| *** rushiagr_away is now known as rushiagr | 18:51 | |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Allow users to clean up role assignments. https://review.openstack.org/119843 | 18:51 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed a change to openstack/keystone: Extract Assignment tests from IdentityTestCase https://review.openstack.org/121653 | 18:53 |
| nkinder | lbragstad: does deleting a user automatically clean up the role assignments? | 18:58 |
| nkinder | lbragstad: your code fix for the role cleanup looks good (and it's a real problem I've encountered before), but I want to be sure the test covers it | 18:59 |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: Ensure identity sql driver supports domain-specific configuration. https://review.openstack.org/121246 | 18:59 |
| lbragstad | nkinder: yes, deleting a user should clean up the role assignments | 19:00 |
| nkinder | lbragstad: when using read-only LDAP, a user will be deleted out from under keystone, which leaves role assignments | 19:00 |
| lbragstad | yep | 19:00 |
| lbragstad | in that case, we *should* be able to remove the role assignment | 19:00 |
| samuelmz | lbragstad, ^ Extract Assignment tests from IdentityTestCase (https://review.openstack.org/121653) | 19:00 |
| nkinder | lbragstad: ok, so shouldn't we have a test that simulates no user existing when we try to delete a role assignment? | 19:00 |
| lbragstad | nkinder: self.identity_api.driver.delete_user(user['id']) | 19:01 |
| nkinder | lbragstad: ok, just saw you're calling the driver directly | 19:01 |
| lbragstad | that will remove the user from the identity backend, simulating the LDAP part | 19:01 |
| nkinder | lbragstad: so that bypasses the role cleanup | 19:01 |
| lbragstad | correct | 19:02 |
| nkinder | lbragstad: cool. Good change! | 19:02 |
| lbragstad | nkinder: https://github.com/openstack/keystone/blob/master/keystone/assignment/routers.py#L99 | 19:02 |
| lbragstad | nkinder: https://github.com/openstack/keystone/blob/master/keystone/assignment/controllers.py#L550 | 19:03 |
| *** jsavak has joined #openstack-keystone | 19:03 | |
| lbragstad | nkinder: https://github.com/openstack/keystone/blob/master/keystone/assignment/controllers.py#L491-L514 is what does the calling into the identity api | 19:04 |
| lbragstad | ^ that's the reason I had to call into the identity_api.driver | 19:04 |
| lbragstad | samuelmz: cool! | 19:05 |
| *** joesavak has quit IRC | 19:06 | |
| nkinder | lbragstad: could you use self.assignment_api.add_role_to_user_and_project() in the tests instead of constructing the URLs? | 19:06 |
| lbragstad | nkinder: good point, yes I could do that | 19:07 |
| lbragstad | I was basing it off related (surrounding) test cases | 19:08 |
| *** rushiagr is now known as rushiagr_away | 19:08 | |
| *** jasonsb has quit IRC | 19:09 | |
| henrynash | bknudson: ping | 19:09 |
| bknudson | henrynash: what's up? | 19:09 |
| rodrigods | samuelmz, would be nice to add lbragstad patch as dependency of yours | 19:10 |
| henrynash | bknudson: just wanted to get you view on the sql driver detection….maybe my concern in my response is unfounded? | 19:10 |
| *** ukalifon has quit IRC | 19:11 | |
| henrynash | bknudson: https://review.openstack.org/#/c/121246/ | 19:11 |
| bknudson | henrynash: which one? | 19:13 |
| samuelmz | lbragstad, do you agree with rodrigods? I think the TODO you've added is enough | 19:13 |
| lbragstad | nkinder: I might keep the member_url stuff in the tests just because it makes the self.head/delete/put calls easier with the expected_status assertions | 19:13 |
| nkinder | lbragstad: yes, I was just looking to see if expected_status was supported as a kwarg there (it's not) | 19:13 |
| lbragstad | nkinder: that's handy to have for validating the outcome of the call | 19:14 |
| *** harlowja has quit IRC | 19:14 | |
| *** harlowja_ has joined #openstack-keystone | 19:14 | |
| bknudson | henrynash: my point was that what you have there isn't correct... it doesn't detect if someone provides their own sql backend. | 19:14 |
| lbragstad | samuelmz: I don't think that linking the my patch as a dep is necessary, | 19:14 |
| henrynash | bknudson: as to whether instaed of checking for ‘backends,sql’ in the driver name, your suggestion about adding a call to the driver….my concern is that means you have to load the driver in order to call it…can that means the __init__() method gets called, and (at least conceptually) a driver’s __init__() method might mess up someone elses sql... | 19:15 |
| bknudson | henrynash: also, if there's some concern about loading 2 sql backends, if you do that then the server should be exiting anyways. | 19:15 |
| henrynash | bknduson: but I guess we could say, the only time we would do that - we are going to exception out anyway | 19:15 |
| lbragstad | the information/problem is reflected in the bug (https://bugs.launchpad.net/keystone/+bug/1367778) | 19:16 |
| uvirtbot | Launchpad bug 1367778 in keystone "Extract Assignment related tests from IdentityTestCase" [Low,In progress] | 19:16 |
| henrynash | bknusdon: now that we have made it an exception, not a warning…maybe that’s OK | 19:16 |
| bknudson | is it just random combinations of bknudson? | 19:16 |
| henrynash | ha!!!! | 19:16 |
| bknudson | hehe | 19:16 |
| henrynash | just seeing which one is awake | 19:16 |
| bknudson | bk<tab> works for me | 19:17 |
| henrynash | bknudson: OK, right, yep…I think you’re right…now it’s an exception, we can do what you suggest…I’ll post that as a change later tonight | 19:17 |
| bknudson | henrynash: great, thanks | 19:17 |
| *** marcoemorais has quit IRC | 19:18 | |
| *** marcoemorais has joined #openstack-keystone | 19:18 | |
| samuelmz | lbragstad, ok thanks | 19:26 |
| lbragstad | samuelmz: no problem | 19:27 |
| *** marcoemorais has quit IRC | 19:28 | |
| *** marcoemorais has joined #openstack-keystone | 19:28 | |
| *** morgan_remote_ has quit IRC | 19:30 | |
| *** marcoemorais has quit IRC | 19:31 | |
| *** marcoemorais has joined #openstack-keystone | 19:32 | |
| *** gyee has joined #openstack-keystone | 19:40 | |
| *** jasonsb has joined #openstack-keystone | 19:41 | |
| morganfainberg | dstanek, http://paste.openstack.org/show/111853/ | 19:43 |
| morganfainberg | dstanek, that is a first crack at it sans cleaner thread | 19:45 |
| *** topol has quit IRC | 19:46 | |
| dstanek | morganfainberg: nice, thanks! | 19:46 |
| morganfainberg | dstanek, haven't passed unit tests yet and i haven't added new tests. but it's a start. | 19:46 |
| morganfainberg | dstanek, i also haven't solve the functools.partial bit | 19:47 |
| morganfainberg | dstanek, should i post this with a new changeId so we can compare? or i guess if we don't like it is is trivial to resubmit the old changeset | 19:51 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add a pool of memcached clients https://review.openstack.org/119452 | 19:53 |
| *** ayoung has quit IRC | 19:53 | |
| morganfainberg | dstanek, ^ | 19:54 |
| morganfainberg | there it is posted to gerrit | 19:54 |
| *** jasonsb has quit IRC | 20:00 | |
| *** jraim has quit IRC | 20:00 | |
| *** jraim has joined #openstack-keystone | 20:00 | |
| *** jasonsb has joined #openstack-keystone | 20:02 | |
| *** joesavak has joined #openstack-keystone | 20:05 | |
| *** jsavak has quit IRC | 20:08 | |
| *** nkinder has quit IRC | 20:24 | |
| ekarlso | dstanek: got a look at that patch ? ;) | 20:25 |
| *** gokrokve has quit IRC | 20:32 | |
| *** gokrokve has joined #openstack-keystone | 20:32 | |
| *** dims has quit IRC | 20:34 | |
| *** dims has joined #openstack-keystone | 20:34 | |
| *** ayoung has joined #openstack-keystone | 20:35 | |
| *** dims has quit IRC | 20:39 | |
| *** harlowja_ is now known as harlowja_away | 20:49 | |
| openstackgerrit | David Stanek proposed a change to openstack/python-keystoneclient: Removes temporary fix for doc generation https://review.openstack.org/121667 | 20:53 |
| stevemar | dstanek, does this change work for you? if you do it in keystone? https://review.openstack.org/#/c/121054/3 | 20:55 |
| *** achampio1 has joined #openstack-keystone | 20:56 | |
| dstanek | stevemar: almost; if you make it 'find keystone' i would be OK with it | 20:56 |
| dstanek | stevemar: otherwise it'll run through the tox dirs and others i have locally and take a while | 20:57 |
| stevemar | dstanek, when i try the change, it complains that find isn't installed in my venv | 20:57 |
| stevemar | dstanek, the only way I can get it to work is if i prefix it with bash -c <blah> | 20:58 |
| *** achampion has quit IRC | 20:58 | |
| dstanek | stevemar: you have to tell tox it's cool | 20:59 |
| dstanek | stevemar: http://git.openstack.org/cgit/openstack/keystone/tree/tox.ini#n16 | 20:59 |
| *** fifieldt_ has joined #openstack-keystone | 20:59 | |
| stevemar | ahhh | 20:59 |
| stevemar | just add find to that i suppose? | 20:59 |
| dstanek | stevemar: yes, iirc tox treats that as a list field like commands | 21:01 |
| stevemar | dstanek, gotcha, ty | 21:01 |
| *** fifieldt has quit IRC | 21:03 | |
| *** raildo has quit IRC | 21:07 | |
| *** joesavak has quit IRC | 21:07 | |
| *** nkinder has joined #openstack-keystone | 21:08 | |
| *** richm has quit IRC | 21:12 | |
| *** ayoung has quit IRC | 21:12 | |
| *** richm has joined #openstack-keystone | 21:13 | |
| stevemar | dstanek, i think bknudson just replied to the ML with the ultimate answer | 21:14 |
| dstanek | stevemar: no . though! | 21:16 |
| stevemar | of course :) | 21:16 |
| dstanek | i wonder what platform doesn't have the -delete | 21:16 |
| dstanek | i thought you could just use --delete any any modern platform | 21:17 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add a pool of memcached clients https://review.openstack.org/119452 | 21:25 |
| morganfainberg | dstanek, ok confirmed that patch ^ works | 21:26 |
| morganfainberg | dstanek, the only 2 things left are tests and fixing the functools.partial | 21:26 |
| morganfainberg | any thoughts on how to handle the latter bit | 21:26 |
| morganfainberg | i mean i guess we don't need to wrap in functools.partial, not sure what it's buying us. | 21:28 |
| *** dims has joined #openstack-keystone | 21:29 | |
| *** dims_ has joined #openstack-keystone | 21:31 | |
| dstanek | morganfainberg: you mean the partial in the client proxy? | 21:32 |
| morganfainberg | dstanek, yeah | 21:32 |
| morganfainberg | dstanek, it was the part you were worried about being brittle | 21:32 |
| dstanek | morganfainberg: the pattern we already use for this type of thing is here: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/manager.py#n56 | 21:33 |
| dstanek | i think that would work find with methods, but not properties because of the setattr | 21:33 |
| morganfainberg | dstanek, right, but we can't setattr in this case, because we're throwing out the proxy object since the underlying connection will change | 21:34 |
| dstanek | but if that line was deleted it would be fine | 21:34 |
| morganfainberg | due to it being a pool | 21:34 |
| *** dims has quit IRC | 21:34 | |
| dstanek | i think 'return getattr(self.client_pool, name)' would be enough | 21:35 |
| morganfainberg | ooh i see what is going on here | 21:35 |
| morganfainberg | it needs to be done in a context manager | 21:35 |
| morganfainberg | otherwise you don't free the connection backt o the pool | 21:35 |
| morganfainberg | dstanek, hm. | 21:37 |
| morganfainberg | so we can't just use .get | 21:37 |
| morganfainberg | i think functools partial might be the easiest way to ensure the context | 21:38 |
| *** radez is now known as radez_g0n3 | 21:38 | |
| dstanek | morganfainberg: context? | 21:40 |
| morganfainberg | dstanek, .get() needs to be called in a context manager | 21:40 |
| morganfainberg | it means that as soon as the request is done we free the connection back to the pool | 21:40 |
| morganfainberg | which is what _run_method with functools.partial is doing | 21:41 |
| dstanek | morganfainberg: hmm...yeah that may unfortunately be true in this case | 21:41 |
| dstanek | maybe __getattr__ just needs to be a little more robust | 21:41 |
| dstanek | or we can be explicit in what methods we support | 21:42 |
| *** rkofman has quit IRC | 21:44 | |
| *** rkofman has joined #openstack-keystone | 21:44 | |
| morganfainberg | dstanek, i'm *mostly* ok with this as is. | 21:46 |
| morganfainberg | dstanek, zzzeek just pointed out we could run the TTL reap on a mod of the time instead of every acquire | 21:46 |
| morganfainberg | could save some looping overhead | 21:46 |
| ekarlso | dstanek: ? | 21:47 |
| morganfainberg | dstanek, this is hard to test.. because a lot of it requires eventlet for the threading stuff. | 21:48 |
| morganfainberg | and actual load to cause a slowdown. | 21:50 |
| morganfainberg | oh. crud. this would break string freeze | 21:50 |
| morganfainberg | *sigh* | 21:50 |
| morganfainberg | need to downgrade the log.exception to debug. | 21:50 |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: Ensure identity sql driver supports domain-specific configuration. https://review.openstack.org/121246 | 21:52 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add a pool of memcached clients https://review.openstack.org/119452 | 21:52 |
| dstanek | ekarlso: looking now | 21:52 |
| dstanek | ekarlso: testr has worthless output so i'm looking with nose | 21:53 |
| dstanek | ekarlso: i gets lots of failures | 21:53 |
| *** _cjones_ has joined #openstack-keystone | 21:57 | |
| ekarlso | dstanek: I get 1 | 21:57 |
| _cjones_ | Can I ask some keystone devs a question? Anyone around? | 21:57 |
| _cjones_ | Trying to figure out what the status of this blueprint is: https://wiki.openstack.org/wiki/Blueprint-aws-vpc-support | 21:58 |
| dstanek | ekarlso: i think you are using this backwards...https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertIsInstance | 21:58 |
| morganfainberg | _cjones_, i think that is related to the heirarchical multitenancy stuff that is going into a feature branch for Juno (that is to say, not part of Juno but development is being done to afford quick merging into Kilo when the cycle opens up) | 21:59 |
| morganfainberg | i *think* | 21:59 |
| ekarlso | dstanek: wehere ? | 22:00 |
| dstanek | morganfainberg, _cjones_: that doesn't appear to specify any keystone work | 22:00 |
| _cjones_ | morganfainberg So this going to be a dual effort between keystone & neutron folks. | 22:00 |
| _cjones_ | dstanek: Mostly Neutron work. | 22:00 |
| morganfainberg | _cjones_, it is going to be based on stuff in keystone but there isn't much for us to do, mostly neutron and nova | 22:01 |
| *** amerine has joined #openstack-keystone | 22:01 | |
| dstanek | ekarlso: both place where you added it? | 22:02 |
| _cjones_ | morganfainberg: I'm just concerned about the 1:1 project:vpc mapping. That's not correct. | 22:03 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add a pool of memcached clients https://review.openstack.org/119452 | 22:03 |
| morganfainberg | _cjones_, that is why i *think* it's meant to use the heirarchy | 22:03 |
| dstanek | ekarlso: look at the doc link from above | 22:03 |
| ekarlso | dstanek: ya | 22:04 |
| _cjones_ | morganfainberg: Do you know who in Neutron would be best to talk to about this? | 22:04 |
| morganfainberg | _cjones_, sorry :( no. | 22:04 |
| _cjones_ | mf: Thanks man. I'll enquire there. | 22:04 |
| openstackgerrit | Endre Karlson proposed a change to openstack/python-keystoneclient: Make Keystone use CLI Plugin https://review.openstack.org/121523 | 22:04 |
| morganfainberg | _cjones_, best bet is asking in #openstack-neutron | 22:04 |
| ekarlso | that fixed that thing dstanek :) | 22:04 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add a pool of memcached clients https://review.openstack.org/119452 | 22:06 |
| morganfainberg | i swear i'll get the pep8 fix right one of these times /me needs food | 22:06 |
| morganfainberg | ok going to a late lunch | 22:06 |
| morganfainberg | might help concentration ;) | 22:06 |
| *** david-lyle has quit IRC | 22:06 | |
| *** david-lyle has joined #openstack-keystone | 22:07 | |
| dstanek | morganfainberg: have fun - just about to start dinnering | 22:10 |
| *** jamielennox|away is now known as jamielennox | 22:11 | |
| *** richm has quit IRC | 22:11 | |
| *** richm has joined #openstack-keystone | 22:12 | |
| *** ayoung has joined #openstack-keystone | 22:13 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:17 | |
| *** bknudson has quit IRC | 22:21 | |
| *** henrynash has quit IRC | 22:24 | |
| *** harlowja_away is now known as harlowja_ | 22:24 | |
| *** gokrokve has quit IRC | 22:26 | |
| *** achampio1 has quit IRC | 22:33 | |
| *** achampion has joined #openstack-keystone | 22:35 | |
| *** gordc has quit IRC | 22:37 | |
| *** bjornar_ has quit IRC | 22:39 | |
| *** DavidHu has joined #openstack-keystone | 22:46 | |
| *** jorge_munoz has quit IRC | 22:53 | |
| *** david-lyle has quit IRC | 22:53 | |
| *** dims_ has quit IRC | 23:09 | |
| *** richm has quit IRC | 23:20 | |
| *** diegows has quit IRC | 23:32 | |
| openstackgerrit | Ryan Hsu proposed a change to openstack/keystone: DO NOT MERGE - Squashed commit of the following: https://review.openstack.org/121711 | 23:36 |
| *** mflobo_ has joined #openstack-keystone | 23:43 | |
| *** _cjones_ has quit IRC | 23:46 | |
| *** andreaf has joined #openstack-keystone | 23:48 | |
| *** r-daneel__ has quit IRC | 23:52 | |
| *** andreaf_ has quit IRC | 23:52 | |
| *** mflobo has quit IRC | 23:52 | |
| *** diegows has joined #openstack-keystone | 23:55 | |
| *** dims has joined #openstack-keystone | 23:57 | |
| *** zzzeek has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!