| stevemar | so it is a clean port | 00:00 |
|---|---|---|
| morganfainberg | yeah | 00:00 |
| morganfainberg | but wanted a 2nd pair of eyes before i +2, so it would be both of us +2 at the same time or just hold | 00:00 |
| morganfainberg | it was a "do we need this" i think we should take it for KSC | 00:01 |
| stevemar | so, and we said we're not going to add anything to auth_token unless it's security related | 00:03 |
| morganfainberg | yep | 00:03 |
| morganfainberg | it *could* have a security impact if you place insecure=False or whatever in the wrong config file (api-paste vs .conf) | 00:03 |
| stevemar | true | 00:03 |
| morganfainberg | people shouldn't stick the config in api-paste, but what can we do, we support it for now | 00:03 |
| stevemar | and jamie/dolph were cool with it | 00:03 |
| morganfainberg | yeah | 00:03 |
| stevemar | so i'm good with it | 00:04 |
| morganfainberg | ok please +2/+A i tossed a +2 on it | 00:04 |
| morganfainberg | second one, https://review.openstack.org/#/c/111771/ so do we need this? or can it go in the next KSC release? | 00:05 |
| morganfainberg | heck i'm tempted to make the SSL one a point release following this release anyway because gate is *slow* | 00:05 |
| stevemar | i'm OK with 111771 because marekd is using is in his own code | 00:06 |
| stevemar | it's gone through and fixed a few of the smaller issues | 00:07 |
| stevemar | fwiw, it's as good as the initial saml code, it's just a bunch of weird blocks of SAML code so it looks daunting | 00:07 |
| morganfainberg | stevemar, right, i've had very little drive time with the SAML stuff so i don't understand it atm. | 00:07 |
| stevemar | morganfainberg, we can totally wait, and do a point release if you want | 00:08 |
| morganfainberg | yeah i'd rather do that. | 00:08 |
| morganfainberg | ok. | 00:08 |
| stevemar | only thing is, i've been the only one reviewing it :) | 00:08 |
| morganfainberg | right. | 00:08 |
| stevemar | so i'm eager to get it in haha | 00:08 |
| morganfainberg | heheheh | 00:08 |
| morganfainberg | this is why i'm asking if it can wait for next KSC release | 00:08 |
| morganfainberg | if it shouldn't i can have you step me through it | 00:09 |
| stevemar | yep | 00:09 |
| morganfainberg | and we can get it in tonight | 00:09 |
| stevemar | morganfainberg, i have time for that now, but i dont want to eat up your evening | 00:09 |
| morganfainberg | meh | 00:09 |
| morganfainberg | i don't really have plans. | 00:09 |
| morganfainberg | this is part of the job when i said i'd help cover for dolph while he was out | 00:10 |
| stevemar | :) | 00:10 |
| stevemar | so 4 file changes, 1 actual code, 1 for tests, 2 for 'test data' | 00:11 |
| morganfainberg | ok | 00:11 |
| morganfainberg | i'm less worried about the .xml files | 00:11 |
| *** dims has quit IRC | 00:57 | |
| *** dims has joined #openstack-keystone | 01:01 | |
| *** morgan_remote_ has quit IRC | 01:10 | |
| *** dims has quit IRC | 01:15 | |
| *** dims has joined #openstack-keystone | 01:18 | |
| *** dims has quit IRC | 01:23 | |
| *** dims has joined #openstack-keystone | 01:25 | |
| *** rodrigods_ has joined #openstack-keystone | 01:45 | |
| *** rodrigods_ has quit IRC | 02:09 | |
| *** diegows has quit IRC | 02:30 | |
| *** kevinbenton has quit IRC | 02:31 | |
| *** tristanC has quit IRC | 02:31 | |
| *** lsmola has quit IRC | 02:31 | |
| *** tristanC has joined #openstack-keystone | 02:31 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 02:38 | |
| *** kevinbenton has joined #openstack-keystone | 02:38 | |
| *** lsmola has joined #openstack-keystone | 02:39 | |
| *** stevemar has quit IRC | 02:41 | |
| *** rodrigods_ has joined #openstack-keystone | 02:48 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 03:09 | |
| *** rodrigods_ has quit IRC | 03:52 | |
| *** dims has quit IRC | 04:14 | |
| *** morgan_remote_ has joined #openstack-keystone | 04:24 | |
| *** ukalifon has joined #openstack-keystone | 05:00 | |
| *** stevemar has joined #openstack-keystone | 05:08 | |
| *** dims has joined #openstack-keystone | 05:15 | |
| *** dims has quit IRC | 05:20 | |
| morganfainberg | haha | 05:37 |
| morganfainberg | whoopse thought i was in this channel | 05:38 |
| morganfainberg | stevemar :P | 05:38 |
| stevemar | ahoy hoy | 05:38 |
| morganfainberg | but yeah, gate reset in... 5 | 05:38 |
| stevemar | whats causing the fail? | 05:38 |
| stevemar | i'm only seeing the oslo.messaging fail ... | 05:39 |
| morganfainberg | neutron + test_basic_network | 05:39 |
| morganfainberg | https://jenkins04.openstack.org/job/gate-tempest-dsvm-neutron-full/2373/console | 05:39 |
| morganfainberg | like 3 up from the bottom | 05:39 |
| stevemar | ugh | 05:40 |
| stevemar | i see it now | 05:40 |
| stevemar | that stinks | 05:40 |
| morganfainberg | a lot of nova patches failed tonight | 05:41 |
| morganfainberg | unfortunately we got behind like 10 of them | 05:41 |
| morganfainberg | and ~5 failed | 05:41 |
| morganfainberg | gate was down to 2h prior to that | 05:41 |
| stevemar | ugh | 05:41 |
| stevemar | you can do a release tomorrow i guess | 05:42 |
| morganfainberg | yeah thats my thought. | 05:42 |
| morganfainberg | tomorrow morning before i head to the gym | 05:42 |
| stevemar | i'll recheck things if they fail again and i'm up | 05:42 |
| morganfainberg | i'll be up for a little bit more | 05:44 |
| morganfainberg | but thnx | 05:44 |
| stevemar | ugh | 05:44 |
| stevemar | at least we're at the top of the queue | 05:44 |
| stevemar | 57ish minutes | 05:47 |
| stevemar | gonna wait it out? | 05:47 |
| *** ks-untriaged-bot has joined #openstack-keystone | 05:49 | |
| ks-untriaged-bot | Untriaged bugs so far: | 05:49 |
| ks-untriaged-bot | https://bugs.launchpad.net/python-keystoneclient/+bug/1369300 | 05:49 |
| * morganfainberg is looking into something for a few mins | 05:49 | |
| uvirtbot | Launchpad bug 1369300 in python-keystoneclient "Keystone sessions breaks convenience Client" [Undecided,New] | 05:49 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1367354 | 05:49 |
| uvirtbot | Launchpad bug 1367354 in nova "oslo.db's master breaks unittest in OS projects" [Low,Confirmed] | 05:49 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1208588 | 05:49 |
| ks-untriaged-bot | https://bugs.launchpad.net/python-keystoneclient/+bug/1238965 | 05:49 |
| uvirtbot | Launchpad bug 1208588 in keystone "Support getting Auth attributes from Kerberos PAC" [Wishlist,New] | 05:49 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1360504 | 05:50 |
| uvirtbot | Launchpad bug 1238965 in python-keystoneclient "basic auth" [Wishlist,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1367218 | 05:50 |
| uvirtbot | Launchpad bug 1360504 in tempest "tempest.api.identity.admin.v3.test_credentials.CredentialsTestJSON create credential unauthorized" [Undecided,Invalid] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystonemiddleware/+bug/1278843 | 05:50 |
| uvirtbot | Launchpad bug 1367218 in keystone "Broken mysql connection causes internal server error" [Undecided,New] | 05:50 |
| uvirtbot | Launchpad bug 1278843 in neutron "Neutron doesn't report using a stale CA certificate" [Medium,Confirmed] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1371499 | 05:50 |
| uvirtbot | Launchpad bug 1371499 in keystone "Spelling erros in comments in test_backend_ldap.py" [Low,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/python-keystoneclient/+bug/1245712 | 05:50 |
| uvirtbot | Launchpad bug 1245712 in python-keystoneclient "user_update_password returns token wrapped as User resource" [Undecided,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1367480 | 05:50 |
| uvirtbot | Launchpad bug 1367480 in keystone "Add test for grant CRUD on test_backend" [Undecided,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1363917 | 05:50 |
| uvirtbot | Launchpad bug 1363917 in keystone "Links in `Configuring Federation` documentation return 404" [Undecided,Confirmed] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/pycadf/+bug/1290436 | 05:50 |
| uvirtbot | Launchpad bug 1290436 in pycadf "fix model requirements" [Medium,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1347262 | 05:50 |
| uvirtbot | Launchpad bug 1347262 in keystone "Ldap Live test failures" [Undecided,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1270378 | 05:50 |
| uvirtbot | Launchpad bug 1270378 in keystone "NormalizingFilter performs incorrect validation of PATH_INFO variable" [Undecided,Incomplete] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1371620 | 05:50 |
| uvirtbot | Launchpad bug 1371620 in keystone "Setting up database schema with db_sync fails with OperationalError: (OperationalError) database is locked u'DELETE FROM user_project_metadata' ()" [Undecided,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1363047 | 05:50 |
| uvirtbot | Launchpad bug 1363047 in keystone "test_sql_upgrade and live_test not working for non-sqllite DBs" [High,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1262564 | 05:50 |
| uvirtbot | Launchpad bug 1262564 in keystone "testsuite misfires in 2013.2.1 release" [Undecided,Incomplete] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1370022 | 05:50 |
| uvirtbot | Launchpad bug 1370022 in keystone "Keystone cannot cope with being behind an SSL terminator for version list" [Undecided,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/python-keystoneclient/+bug/1362148 | 05:50 |
| uvirtbot | Launchpad bug 1362148 in python-keystoneclient "http_connect_timeout should be an integer, but it is a boolean" [Undecided,In progress] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1361758 | 05:50 |
| uvirtbot | Launchpad bug 1361758 in keystone "Keystone should bootstrap CONF.member_role_name" [Undecided,Incomplete] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1367740 | 05:50 |
| morganfainberg | we have too many "new" state bugs. | 05:50 |
| uvirtbot | Launchpad bug 1367740 in keystone "Assignment backends raise non-suggestive exception in grant CRUD" [Undecided,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1211965 | 05:50 |
| uvirtbot | Launchpad bug 1211965 in keystone "Unify delegate token identification" [Wishlist,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1245510 | 05:50 |
| uvirtbot | Launchpad bug 1245510 in keystone "syslog setting does not work in keystone" [Undecided,Incomplete] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1371801 | 05:50 |
| uvirtbot | Launchpad bug 1371801 in keystone "Clouds with high usage gets slower because of token table size getting bigger" [Undecided,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/python-keystoneclient/+bug/1367868 | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1274581 | 05:50 |
| uvirtbot | Launchpad bug 1367868 in python-keystoneclient "List inherited role assignments for domains available on keystone API but not on client" [Undecided,In progress] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/python-keystoneclient/+bug/1328469 | 05:50 |
| uvirtbot | Launchpad bug 1274581 in keystone "keystone ldap identity backend will not work without TLS_CACERT path specified in an ldap.conf file" [Low,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1362309 | 05:50 |
| uvirtbot | Launchpad bug 1328469 in keystone "Update test requirement hacking to series 0.9.x" [Low,In progress] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1218942 | 05:50 |
| uvirtbot | Launchpad bug 1362309 in keystone "Creating an endpoint with an invalid service_id returns the wrong error code" [Undecided,In progress] | 05:50 |
| uvirtbot | Launchpad bug 1218942 in keystone "Dependency resolution does not create objects on demand" [Wishlist,New] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/pycadf/+bug/1347868 | 05:50 |
| uvirtbot | Launchpad bug 1347868 in pycadf "pycadf does not work with a templated keystone catalog" [Undecided,In progress] | 05:50 |
| ks-untriaged-bot | https://bugs.launchpad.net/keystone/+bug/1206396 | 05:50 |
| *** ks-untriaged-bot has quit IRC | 05:50 | |
| uvirtbot | Launchpad bug 1206396 in cinder "Name validations for compute resources" [Undecided,Confirmed] | 05:50 |
| morganfainberg | stevemar, I was going to fire that bot up so we have incentive to triage the bugs but i think we need to triage the bugs before we can do that | 05:52 |
| morganfainberg | stevemar, here is the full list: http://paste.openstack.org/show/113825/ | 05:53 |
| stevemar | yowza | 05:54 |
| morganfainberg | stevemar, once we get the release cut, lets do hard core bug triage and get that list to "acceptible" so i can turn on the bot. | 06:00 |
| morganfainberg | we should not have bugs that are in a prioritized state and are "new" https://bugs.launchpad.net/keystone/+bugs?search=Search&field.status=New | 06:00 |
| morganfainberg | stevemar, i want to reject this one as "wont fix" https://bugs.launchpad.net/keystone/+bug/1369388 thoughts? | 06:02 |
| uvirtbot | Launchpad bug 1369388 in keystone "local configuration is not allowed in "keystone-paste.ini"" [Undecided,New] | 06:02 |
| morganfainberg | i don't want to even have the illusion of "you can put local config in the paste-api config" for keystone | 06:03 |
| morganfainberg | maybe we need it to be a friendlier error? | 06:03 |
| morganfainberg | oh i guess we need to fix this . bah | 06:03 |
| stevemar | morganfainberg, i don't understand what is trying to be done | 06:06 |
| morganfainberg | it's a kwarg issue | 06:06 |
| morganfainberg | basically if you put local configs into the paste-ini you get a traceback | 06:07 |
| stevemar | i'm going to try and close https://bugs.launchpad.net/keystone/+bug/1363917 | 06:07 |
| uvirtbot | Launchpad bug 1363917 in keystone "Links in `Configuring Federation` documentation return 404" [Undecided,Confirmed] | 06:07 |
| morganfainberg | because the keystone wsgi class doesn't support **local_config being passed to it | 06:07 |
| morganfainberg | even thought all it should do is drop the values on the floor | 06:07 |
| morganfainberg | the rest of the stack in middleware supports it | 06:07 |
| stevemar | morganfainberg, doing my part! https://review.openstack.org/#/c/122985/ | 06:13 |
| morganfainberg | hehe | 06:13 |
| *** dims has joined #openstack-keystone | 06:16 | |
| stevemar | morganfainberg, invalid? isn't this a BP or new repo? https://bugs.launchpad.net/keystone/+bug/1208588 | 06:17 |
| uvirtbot | Launchpad bug 1208588 in keystone "Support getting Auth attributes from Kerberos PAC" [Wishlist,New] | 06:17 |
| morganfainberg | i think so | 06:17 |
| stevemar | commented | 06:20 |
| *** dims has quit IRC | 06:20 | |
| stevemar | morganfainberg, umm pretty sure we can close this one https://bugs.launchpad.net/python-keystoneclient/+bug/1328469 | 06:20 |
| uvirtbot | Launchpad bug 1328469 in keystone "Update test requirement hacking to series 0.9.x" [Low,In progress] | 06:20 |
| morganfainberg | haha probably | 06:21 |
| stevemar | ahhh only for keystone | 06:21 |
| stevemar | client is still <0.9 | 06:21 |
| morganfainberg | look at the requirements file | 06:21 |
| morganfainberg | ah | 06:21 |
| morganfainberg | mark as confirmed then | 06:21 |
| *** morgan_remote_ has quit IRC | 06:30 | |
| morganfainberg | stevemar, didn't we fix this: https://bugs.launchpad.net/python-keystoneclient/+bug/1336910? | 06:32 |
| uvirtbot | Launchpad bug 1336910 in keystone "oauth1 response content type is incorrect" [Undecided,Fix released] | 06:32 |
| morganfainberg | that's just something from server not client, right? | 06:32 |
| morganfainberg | oh nvm fixed in client as well | 06:32 |
| stevemar | fixed in both spots! | 06:33 |
| morganfainberg | marked as fix released then | 06:33 |
| morganfainberg | ok ok | 06:35 |
| morganfainberg | i'm tired of triaging for the evening. we killed/triaged a number of bugs | 06:36 |
| morganfainberg | but still ogt more to do | 06:36 |
| stevemar | morganfainberg, what do you think... | 06:38 |
| stevemar | for updating the hacking, it's reporting that https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/common/cms.py#L84 is failing cause of \ at end of file | 06:39 |
| morganfainberg | because of a what at the end of file? | 06:39 |
| stevemar | options: 1) remove the \'s, 2) ignore the rule, 3) use > | 06:39 |
| stevemar | errr \ at end of *line* | 06:39 |
| morganfainberg | oh \ at the end of a line? | 06:39 |
| *** alex_xu has joined #openstack-keystone | 06:39 | |
| morganfainberg | just disable that Hacking check | 06:39 |
| morganfainberg | clean it up later | 06:39 |
| stevemar | alright | 06:39 |
| morganfainberg | basically if it's a PITA disable the check, we can cleanup later | 06:40 |
| morganfainberg | if it's trival go ahead and fx | 06:40 |
| stevemar | the problem is, they are comments :( | 06:41 |
| stevemar | i removed them once and bknudson didn't like that, i opened a bug against hacking but that was returned at invalid | 06:42 |
| morganfainberg | so disable the hacking check | 06:42 |
| morganfainberg | it's fine. | 06:42 |
| morganfainberg | we | 06:43 |
| morganfainberg | 'll clean it up later on :) | 06:43 |
| * morganfainberg glares at neutron-full | 06:43 | |
| * morganfainberg taps foot | 06:43 | |
| * morganfainberg wants to cut release | 06:43 | |
| stevemar | morganfainberg, https://review.openstack.org/#/c/122989/ | 06:46 |
| morganfainberg | LGTM | 06:46 |
| morganfainberg | +2 | 06:46 |
| morganfainberg | yay | 06:48 |
| morganfainberg | just wating on post-test cleanup now | 06:48 |
| morganfainberg | xgeeze | 06:48 |
| morganfainberg | 102 minutes for that test to run | 06:49 |
| morganfainberg | that is *slow* | 06:49 |
| stevemar | morganfainberg, ANOTHER! https://review.openstack.org/#/c/122990/ (in my best Thor impression) | 06:55 |
| morganfainberg | ugh. | 06:58 |
| stevemar | dtroyer, go to sleep | 06:58 |
| morganfainberg | i can't push the tag | 06:58 |
| * morganfainberg grumbles | 06:59 | |
| stevemar | stop rechecking things at 3am | 06:59 |
| stevemar | why can't you push it? | 06:59 |
| morganfainberg | don't have permissions to | 06:59 |
| morganfainberg | dolph and the release team might be the only ones who can | 06:59 |
| dtroyer | stevemar: here's how far I've gotten on the low-level API: https://github.com/dtroyer/python-openstackclient/tree/low-level-api-test/openstackclient/api | 06:59 |
| dtroyer | list commands are hard | 06:59 |
| stevemar | morganfainberg, i figured dolph gave you permission before he left :( | 07:00 |
| dtroyer | the osc commands that use those have been converted too | 07:00 |
| morganfainberg | looks like not | 07:00 |
| stevemar | dtroyer, yowza! | 07:00 |
| stevemar | morganfainberg, isn't https://bugs.launchpad.net/keystone/+bug/1200777 resolved by the json home work? | 07:12 |
| uvirtbot | Launchpad bug 1200777 in keystone "No V3 extensions list" [Wishlist,Confirmed] | 07:12 |
| morganfainberg | i think so, but not sure, check with bknudson on that | 07:12 |
| stevemar | i just tried it, doesn't work | 07:13 |
| stevemar | morganfainberg, did lance's work for json schema only touch v3? | 07:32 |
| morganfainberg | think so | 07:32 |
| morganfainberg | ok going to sleep | 07:33 |
| morganfainberg | 'night | 07:33 |
| stevemar | morganfainberg, surely OP will respond https://bugs.launchpad.net/keystone/+bug/1262564 | 07:42 |
| uvirtbot | Launchpad bug 1262564 in keystone "testsuite misfires in 2013.2.1 release" [Undecided,Incomplete] | 07:42 |
| stevemar | haha | 07:42 |
| stevemar | gnite | 07:42 |
| *** bjornar_ has joined #openstack-keystone | 07:56 | |
| *** henrynash has joined #openstack-keystone | 07:56 | |
| *** stevemar has quit IRC | 08:12 | |
| *** bjornar_ has quit IRC | 08:34 | |
| *** andreaf has quit IRC | 08:51 | |
| *** andreaf has joined #openstack-keystone | 08:52 | |
| *** jorge_munoz has joined #openstack-keystone | 09:18 | |
| *** jorge_munoz has left #openstack-keystone | 09:23 | |
| *** ukalifon has quit IRC | 09:43 | |
| *** bjornar_ has joined #openstack-keystone | 09:58 | |
| *** andreaf has quit IRC | 11:27 | |
| *** rodrigods_ has joined #openstack-keystone | 12:16 | |
| *** ekarlso has quit IRC | 12:29 | |
| *** rodrigods_ has quit IRC | 12:52 | |
| *** dims has joined #openstack-keystone | 12:52 | |
| *** rodrigods_ has joined #openstack-keystone | 12:59 | |
| *** dims has quit IRC | 13:58 | |
| *** Clabbe has quit IRC | 14:21 | |
| *** dims has joined #openstack-keystone | 14:28 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:33 | |
| *** rodrigods_ has quit IRC | 14:41 | |
| *** rodrigods_ has joined #openstack-keystone | 14:45 | |
| *** dims has quit IRC | 15:14 | |
| *** rodrigods_ has quit IRC | 15:23 | |
| *** achampio1 has joined #openstack-keystone | 15:28 | |
| *** achampion has quit IRC | 15:29 | |
| *** rodrigods_ has joined #openstack-keystone | 15:41 | |
| *** rushiagr_away is now known as rushiagr | 15:46 | |
| *** stevemar has joined #openstack-keystone | 15:53 | |
| *** achampion has joined #openstack-keystone | 15:58 | |
| *** achampio1 has quit IRC | 16:00 | |
| *** toysrough has joined #openstack-keystone | 16:00 | |
| *** dims has joined #openstack-keystone | 16:18 | |
| *** dims has quit IRC | 16:21 | |
| *** dims has joined #openstack-keystone | 16:22 | |
| *** Daviey has quit IRC | 16:32 | |
| *** Daviey has joined #openstack-keystone | 16:39 | |
| *** rushiagr is now known as rushiagr_away | 16:46 | |
| *** dims has quit IRC | 17:20 | |
| *** stevemar has quit IRC | 17:31 | |
| *** dims has joined #openstack-keystone | 17:38 | |
| *** rushiagr_away is now known as rushiagr | 17:39 | |
| *** dims has quit IRC | 17:53 | |
| *** dims has joined #openstack-keystone | 17:53 | |
| *** rodrigods_ has quit IRC | 17:58 | |
| *** dims has quit IRC | 17:58 | |
| *** rushiagr is now known as rushiagr_away | 18:16 | |
| *** topol has joined #openstack-keystone | 18:22 | |
| *** rodrigods_ has joined #openstack-keystone | 19:03 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 19:15 | |
| *** dims has joined #openstack-keystone | 19:16 | |
| *** dims has quit IRC | 19:33 | |
| *** jamielennox has quit IRC | 19:34 | |
| *** jamielenz has joined #openstack-keystone | 19:35 | |
| *** jamielenz is now known as jamielennox | 19:36 | |
| *** rodrigods_ has quit IRC | 19:49 | |
| *** rodrigods_ has joined #openstack-keystone | 20:01 | |
| *** rodrigods_ has quit IRC | 20:13 | |
| morganfainberg | ugh | 20:28 |
| morganfainberg | middleware somehow got broken. | 20:28 |
| morganfainberg | w.t.f. | 20:28 |
| *** dims has joined #openstack-keystone | 20:28 | |
| morganfainberg | i'll need to come back and look at it later. | 20:29 |
| morganfainberg | ugh | 20:29 |
| *** dims has quit IRC | 20:29 | |
| *** dims has joined #openstack-keystone | 20:29 | |
| *** dims has quit IRC | 20:31 | |
| *** dims has joined #openstack-keystone | 20:42 | |
| *** stevemar has joined #openstack-keystone | 21:02 | |
| bknudson | morganfainberg: is there a bug? | 21:15 |
| bknudson | I get the failure locally here, did a rm -r .tox/py27 | 21:16 |
| *** bjornar_ has quit IRC | 21:16 | |
| bknudson | I'm beginning to think httpretty changes status_code to status. | 21:17 |
| bknudson | nope, must have been a change in keystoneclient | 21:21 |
| *** charz has joined #openstack-keystone | 21:29 | |
| *** Daviey_ has joined #openstack-keystone | 21:30 | |
| *** mitz has quit IRC | 21:31 | |
| *** charz_ has quit IRC | 21:31 | |
| *** Daviey has quit IRC | 21:31 | |
| *** YorikSar has quit IRC | 21:31 | |
| *** Daviey_ is now known as Daviey | 21:31 | |
| *** YorikSar has joined #openstack-keystone | 21:31 | |
| *** mitz has joined #openstack-keystone | 21:32 | |
| *** henrynash has quit IRC | 21:39 | |
| bknudson | why can't I git checkout 0.11.0 in python-keystoneclient? | 21:39 |
| morganfainberg | bknudson, i think there is a new bug somewhere | 21:40 |
| morganfainberg | bknudson, master of middleware is broken. | 21:40 |
| morganfainberg | bknudson, somehow things are out of match | 21:40 |
| bknudson | morganfainberg: I was going to try point my keystonemiddleware at my git checkout of keystoneclient but then it doesn't fail. | 21:40 |
| bknudson | morganfainberg: then I was going to git reset --hard HEAD^ and see where it starts working. | 21:41 |
| morganfainberg | bknudson, so something in ksc broke middleware | 21:41 |
| morganfainberg | it's something about the fixtures i think | 21:41 |
| morganfainberg | but i don't know *why* that changed yet | 21:42 |
| bknudson | so when I run with a fresh tox env it fails as expected | 21:43 |
| bknudson | maybe my repo is out of date. | 21:44 |
| morganfainberg | i only have it fail on py27 | 21:45 |
| morganfainberg | erm py26 | 21:45 |
| bknudson | morganfainberg: HEAD is now at ec57b35 Versioned Endpoint hack for Sessions | 21:47 |
| bknudson | I think that one broke it... was kind of suspecting it. | 21:47 |
| bknudson | morganfainberg: revert it? | 21:47 |
| morganfainberg | oh let me see | 21:47 |
| morganfainberg | ugh | 21:48 |
| morganfainberg | did we break anything else? | 21:48 |
| morganfainberg | i think this also shows a gap in our testing | 21:49 |
| morganfainberg | oh blah BASE_URL = 'http://keystone.server:5000/' | 21:49 |
| morganfainberg | there is the issue | 21:49 |
| morganfainberg | keystonemiddleware expects keystone.example.com | 21:50 |
| morganfainberg | among other things. | 21:50 |
| morganfainberg | yeah we might need to revert it | 21:50 |
| bknudson | morganfainberg: keystonemiddleware makes all sorts of assumptions | 21:51 |
| *** rkofman has quit IRC | 21:51 | |
| morganfainberg | though middleware's test *might* actually be broken | 21:51 |
| morganfainberg | reference = 'https://keystone.example.com:1234/testadmin/v3' | 21:51 |
| morganfainberg | actual = u'http://keystone.server:5000/v2.0' | 21:51 |
| *** rkofman has joined #openstack-keystone | 21:51 | |
| morganfainberg | ooh wait... | 21:51 |
| morganfainberg | am i reading this right that the discovery is chopping the URL in a weird way | 21:52 |
| morganfainberg | ? | 21:52 |
| bknudson | morganfainberg: reading what right? | 21:52 |
| morganfainberg | so we're expecting server:1234/testadmin/v3 | 21:52 |
| morganfainberg | but we're getting back keystone.server:5000/v2 | 21:52 |
| morganfainberg | that looks like something in keystoneclient is broken | 21:53 |
| bknudson | morganfainberg: the catalog has : u'adminURL': u'http://keystone.server:5000/v2.0' | 21:54 |
| morganfainberg | ok so middleware is just... bad at testing then? | 21:55 |
| * morganfainberg apologizes and is brain fried. | 21:55 | |
| morganfainberg | i was actually just about to head out cause no food = no thinky good. | 21:55 |
| bknudson | here's the BASE_URI that the test is expecting: https://keystone.example.com:1234/testadmin | 21:56 |
| morganfainberg | right | 21:56 |
| bknudson | they just seem to be totally different | 21:56 |
| morganfainberg | ok i confirmed reverting that fix solves the middleware gate issue | 21:59 |
| bknudson | the catalog in the _stored_auth_ref doesn't change, it's still got http://keystone.server:5000/v2.0 | 22:00 |
| *** ekarlso has joined #openstack-keystone | 22:01 | |
| *** ekarlso has quit IRC | 22:01 | |
| *** ekarlso has joined #openstack-keystone | 22:01 | |
| bknudson | and then token_auth.get_endpoint(session_, **endpoint_filter) ==> https://keystone.example.com:1234/testadmin/v3 | 22:01 |
| bknudson | whereas with the change in keystoneclient you get http://keystone.server:5000/v2.0 | 22:02 |
| morganfainberg | yeah | 22:02 |
| bknudson | which makes some sense since it's an actual endpoint. | 22:02 |
| bknudson | although the version doesn't match the requested version. | 22:02 |
| morganfainberg | which worries me | 22:02 |
| bknudson | you did {'service_type': 'identity', 'version': 3} and you got back a v2 endpoint | 22:02 |
| bknudson | but without the change it returns an endpoint that's not even in the catalog... so that's also strange. | 22:05 |
| bknudson | ConnectionRefused: Connecti...:5000/',) | 22:06 |
| bknudson | it tried to contact my local server | 22:06 |
| bknudson | so we'd need to httpretty another request | 22:06 |
| bknudson | 'Fallback to using that endpoint as the base url.', url) | 22:07 |
| stevemar | ughhhh GATE is failing hard | 22:07 |
| morganfainberg | stevemar, middleware? | 22:07 |
| bknudson | stevemar: there must have been a keystoneclient release. | 22:07 |
| stevemar | everything | 22:07 |
| morganfainberg | stevemar, really? | 22:07 |
| * morganfainberg is looking at zuul | 22:08 | |
| morganfainberg | it's not *Everything* | 22:08 |
| stevemar | ok ok, not *everything* | 22:08 |
| morganfainberg | stevemar, infact most anything that isn't middleware is failing for different reasons | 22:09 |
| morganfainberg | keystonemiddleware is failing because of the discovery hack | 22:09 |
| morganfainberg | bknudson, i can push a revert of that hack code and we can poke someone to toss a 0.11.1 ksc release out | 22:09 |
| morganfainberg | bknudson, either dolph or TTX. | 22:10 |
| bknudson | morganfainberg: that seems like the best thing to do now... not sure why anyone would be waiting for the hack code. | 22:10 |
| bknudson | morganfainberg: I guess we need to figure out how to do auth_token middleware testing better... the httpretty mocking is going to cause problems. | 22:11 |
| morganfainberg | bknudson, yeah. | 22:11 |
| bknudson | morganfainberg: there should be a way to just disable all network traffic in tests. | 22:11 |
| morganfainberg | well request-mock is a bit better | 22:11 |
| morganfainberg | but... | 22:11 |
| morganfainberg | same concept | 22:11 |
| morganfainberg | https://review.openstack.org/123019 | 22:11 |
| morganfainberg | probably need a bug on this. | 22:12 |
| morganfainberg | https://bugs.launchpad.net/python-keystoneclient/+bug/1372190 | 22:14 |
| uvirtbot | Launchpad bug 1372190 in python-keystoneclient "Version Discovery Hack causing unexpected catalog endpoint results" [Undecided,New] | 22:14 |
| bknudson | let me see if I can figure out what to do for keystonemiddleware... maybe it is better to fix it. | 22:14 |
| morganfainberg | sure. | 22:15 |
| morganfainberg | feel free to close that bug out / abandon the revert if there is a better option | 22:15 |
| * morganfainberg needs to get going | 22:15 | |
| morganfainberg | i'll be back much later tonight probably | 22:15 |
| morganfainberg | i'll try and check my email / bug as I am able to | 22:16 |
| morganfainberg | so if you need me to review/approve something just drop me an email or such. | 22:16 |
| morganfainberg | i'll login and review/poke at/whatever | 22:17 |
| bknudson | will do. | 22:17 |
| stevemar | i'll be around-ish | 22:19 |
| bknudson | well, it does look like it's only 1 small change to keystonemiddleware that will fix... let me post it and see if it works. | 22:20 |
| *** dhellmann has quit IRC | 22:21 | |
| *** mitz_ has quit IRC | 22:21 | |
| *** tristanC has quit IRC | 22:22 | |
| *** jdennis1 has quit IRC | 22:22 | |
| *** dhellmann has joined #openstack-keystone | 22:23 | |
| *** tristanC has joined #openstack-keystone | 22:23 | |
| *** jdennis has joined #openstack-keystone | 22:23 | |
| bknudson | not virtbot? https://review.openstack.org/123021 | 22:25 |
| stevemar | bknudson, yeah virtbot hasn't been notifying us of new changes | 22:36 |
| morganfainberg | bknudson, ah that isn't a bad fix. | 22:40 |
| bknudson | we've got self.SERVICE_URL = 'http://keystone.server:5000/v2.0' and now with the hack it's causing a lookup to self.SERVICE_URL = 'http://keystone.server:5000/' | 22:41 |
| morganfainberg | ahh | 22:42 |
| bknudson | actually it doesn't hit 'http://keystone.server:5000/v2.0' anymore, just 'http://keystone.server:5000/' | 22:44 |
| stevemar | bknudson, reference both bugs in the comment? | 22:45 |
| bknudson | stevemar: what's the other bug? | 22:46 |
| stevemar | 1372190 and 1335726 | 22:46 |
| bknudson | stevemar: morganfainberg: ok, I think https://review.openstack.org/#/c/123021/ takes care of it. Cleaned it up a little | 22:50 |
| morganfainberg | bknudson, cool | 22:50 |
| *** openstackgerrit has joined #openstack-keystone | 22:50 | |
| stevemar | bknudson, also, going to need a bit of guidance on this one: https://review.openstack.org/#/c/122991/ trying to determine if there's even a reason why we need to change this, maybe it's working as designed? | 22:51 |
| morganfainberg | bknudson, ok | 22:51 |
| bknudson | stevemar: I don't think we should be changing the v2 api. | 22:51 |
| morganfainberg | bknudson, +2 on the fix, will abandon the revert /mark the keystoneclient bug invalid | 22:52 |
| stevemar | bknudson, yeah, thats what i was wondering... didn't want to invest time creating tests if that was going to be the consensus | 22:52 |
| morganfainberg | stevemar, lets not add stuff to v2 | 22:53 |
| morganfainberg | stevemar, v2 doesn't need more "features" or "functionality" | 22:53 |
| stevemar | fair enough, the only argument i was thinking was that it breaks api contract | 22:54 |
| *** achudnovets has quit IRC | 22:54 | |
| bknudson | stevemar: where is it documented? | 22:54 |
| *** diegows has joined #openstack-keystone | 22:54 | |
| stevemar | bknudson, http://developer.openstack.org/api-ref-identity-v2.html#admin-tenants | 22:55 |
| bknudson | stevemar: that's the admin api, not the public one. | 22:55 |
| bknudson | stevemar: http://developer.openstack.org/api-ref-identity-v2.html#identity-v2 is the public api. | 22:55 |
| stevemar | whoops | 22:55 |
| stevemar | you are correct | 22:55 |
| stevemar | public api doesn't have it | 22:55 |
| bknudson | public api doesn't have much at all | 22:56 |
| stevemar | seems stupid weird... since it has delete | 22:56 |
| stevemar | but not get | 22:56 |
| *** achudnovets has joined #openstack-keystone | 22:58 | |
| stevemar | abandoning | 22:59 |
| stevemar | and marked as won't fix | 22:59 |
| bknudson | marekd won't fix it. | 23:00 |
| *** dims has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!