| *** boris-42 has joined #openstack-keystone | 00:02 | |
| *** richm has quit IRC | 00:05 | |
| *** piyanai has joined #openstack-keystone | 00:05 | |
| *** hrou has quit IRC | 00:09 | |
| *** zzzeek has quit IRC | 00:10 | |
| *** htruta_ has joined #openstack-keystone | 00:22 | |
| *** geoffarnold has quit IRC | 00:32 | |
| *** darrenc is now known as darrenc_afk | 00:35 | |
| *** _cjones_ has quit IRC | 00:39 | |
| *** hrou has joined #openstack-keystone | 00:44 | |
| *** sunil_ has joined #openstack-keystone | 00:45 | |
| *** stevemar has joined #openstack-keystone | 00:45 | |
| *** ChanServ sets mode: +v stevemar | 00:45 | |
| *** sunil_ is now known as snapdey | 00:48 | |
| *** snapdey has quit IRC | 00:49 | |
| *** darrenc_afk is now known as darrenc | 01:00 | |
| *** mylu has joined #openstack-keystone | 01:03 | |
| *** browne has quit IRC | 01:03 | |
| *** jdandrea has quit IRC | 01:11 | |
| *** amickus has quit IRC | 01:14 | |
| *** hrou has quit IRC | 01:14 | |
| *** hrou has joined #openstack-keystone | 01:15 | |
| *** jasonsb has quit IRC | 01:33 | |
| *** jasonsb has joined #openstack-keystone | 01:34 | |
| *** ankita_wagh has quit IRC | 01:37 | |
| *** davechen1 has joined #openstack-keystone | 01:37 | |
| *** spandhe has quit IRC | 01:38 | |
| *** jasonsb has quit IRC | 01:38 | |
| *** nkinder has quit IRC | 01:43 | |
| openstackgerrit | jiaxi proposed openstack/keystone: Suppressing the request when creating endpoint with invalid urls https://review.openstack.org/200512 | 01:46 |
|---|---|---|
| *** nkinder has joined #openstack-keystone | 01:47 | |
| openstackgerrit | jiaxi proposed openstack/keystone: Suppressing the request when creating endpoint with invalid urls https://review.openstack.org/200512 | 01:50 |
| *** bradjones has quit IRC | 01:54 | |
| *** fangzhou has quit IRC | 01:56 | |
| *** bradjones has joined #openstack-keystone | 01:56 | |
| *** bradjones has quit IRC | 01:56 | |
| *** bradjones has joined #openstack-keystone | 01:56 | |
| *** chenhong has joined #openstack-keystone | 01:57 | |
| *** chenhong1 has joined #openstack-keystone | 02:00 | |
| *** chenhong has quit IRC | 02:01 | |
| *** ankita_wagh has joined #openstack-keystone | 02:03 | |
| *** ankita_wagh has quit IRC | 02:07 | |
| *** ankita_wagh has joined #openstack-keystone | 02:08 | |
| *** stevemar has quit IRC | 02:10 | |
| *** stevemar has joined #openstack-keystone | 02:10 | |
| *** ChanServ sets mode: +v stevemar | 02:10 | |
| *** stevemar has quit IRC | 02:14 | |
| *** dims_ has joined #openstack-keystone | 02:25 | |
| *** mylu has quit IRC | 02:32 | |
| openstackgerrit | Li Yingjun proposed openstack/python-keystoneclient: Fixes table when there are multiline in result data https://review.openstack.org/204342 | 02:34 |
| *** jasonsb has joined #openstack-keystone | 02:35 | |
| *** mylu has joined #openstack-keystone | 02:36 | |
| *** gyee has quit IRC | 02:39 | |
| *** jasonsb has quit IRC | 02:39 | |
| *** davechen1 is now known as davechen | 02:41 | |
| *** browne has joined #openstack-keystone | 02:45 | |
| *** jasonsb has joined #openstack-keystone | 02:45 | |
| *** stevemar has joined #openstack-keystone | 02:49 | |
| *** ChanServ sets mode: +v stevemar | 02:49 | |
| *** jecarey has joined #openstack-keystone | 02:49 | |
| *** hakimo has joined #openstack-keystone | 02:52 | |
| *** hakimo_ has quit IRC | 02:55 | |
| *** jecarey has quit IRC | 03:10 | |
| openstackgerrit | Henrique Truta proposed openstack/keystone: Add is_domain field in Project Table https://review.openstack.org/157427 | 03:10 |
| openstackgerrit | Henrique Truta proposed openstack/keystone: Change project name constraints https://review.openstack.org/158372 | 03:10 |
| *** kiran-r has joined #openstack-keystone | 03:10 | |
| *** mylu has quit IRC | 03:12 | |
| *** dims_ has quit IRC | 03:15 | |
| *** stevemar has quit IRC | 03:22 | |
| *** stevemar has joined #openstack-keystone | 03:22 | |
| *** ChanServ sets mode: +v stevemar | 03:22 | |
| *** stevemar has quit IRC | 03:24 | |
| *** mylu has joined #openstack-keystone | 03:26 | |
| *** kiran-r has quit IRC | 03:28 | |
| *** stevemar has joined #openstack-keystone | 03:29 | |
| *** ChanServ sets mode: +v stevemar | 03:29 | |
| *** ankita_w_ has joined #openstack-keystone | 03:34 | |
| *** piyanai has quit IRC | 03:35 | |
| *** h00327910_ has quit IRC | 03:35 | |
| *** ankita_wagh has quit IRC | 03:37 | |
| mfisch | dolphm: morganfainberg I'm running benchmarks now with your new code that landed to not always do deletes | 03:37 |
| morganfainberg | mfisch: hopefully better | 03:38 |
| morganfainberg | Should be a good bit better afaict | 03:38 |
| morganfainberg | Since revokes happen less than "get" | 03:39 |
| morganfainberg | Now... There *are* still performance issues. | 03:39 |
| morganfainberg | But thats a separate task to identify where and how to handle them | 03:39 |
| *** gus_ is now known as gus | 03:45 | |
| *** mylu has quit IRC | 03:47 | |
| *** dims_ has joined #openstack-keystone | 03:49 | |
| *** mylu has joined #openstack-keystone | 03:53 | |
| *** dims_ has quit IRC | 03:56 | |
| *** mylu has quit IRC | 04:06 | |
| mfisch | morganfainberg: I had an issue with my package build probably nothing until tomorrow | 04:07 |
| morganfainberg | Doh! | 04:07 |
| *** Kennan2 has joined #openstack-keystone | 04:14 | |
| *** Kennan has quit IRC | 04:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystoneauth: Updated from global requirements https://review.openstack.org/204371 | 04:24 |
| *** boris-42 has quit IRC | 04:32 | |
| *** hightall has joined #openstack-keystone | 04:47 | |
| openstackgerrit | Merged openstack/keystone: Avoid the hard coding of admin token https://review.openstack.org/203546 | 04:47 |
| *** htruta_ has quit IRC | 04:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/204300 | 04:56 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystoneauth: Updated from global requirements https://review.openstack.org/204371 | 04:56 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/197254 | 04:56 |
| *** darrenc is now known as darrenc_afk | 04:58 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/203137 | 04:59 |
| *** dramakri has joined #openstack-keystone | 05:05 | |
| *** lhcheng has quit IRC | 05:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/204300 | 05:11 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/204432 | 05:13 |
| *** spandhe has joined #openstack-keystone | 05:21 | |
| *** hrou has quit IRC | 05:25 | |
| *** ankita_wagh has joined #openstack-keystone | 05:38 | |
| *** ankita_w_ has quit IRC | 05:40 | |
| *** spandhe has quit IRC | 05:43 | |
| *** afazekas has quit IRC | 05:55 | |
| *** ankita_wagh has quit IRC | 06:04 | |
| *** darrenc_afk is now known as darrenc | 06:05 | |
| *** stevemar has quit IRC | 06:11 | |
| *** stevemar has joined #openstack-keystone | 06:12 | |
| *** ChanServ sets mode: +v stevemar | 06:12 | |
| *** lhcheng has joined #openstack-keystone | 06:13 | |
| *** ChanServ sets mode: +v lhcheng | 06:13 | |
| *** stevemar has quit IRC | 06:15 | |
| *** topol has joined #openstack-keystone | 06:16 | |
| *** ChanServ sets mode: +v topol | 06:16 | |
| *** dims_ has joined #openstack-keystone | 06:17 | |
| *** ParsectiX has joined #openstack-keystone | 06:19 | |
| *** ankita_wagh has joined #openstack-keystone | 06:21 | |
| *** dims_ has quit IRC | 06:22 | |
| *** kiran-r has joined #openstack-keystone | 06:26 | |
| *** lsmola has joined #openstack-keystone | 06:29 | |
| *** boris-42 has joined #openstack-keystone | 06:29 | |
| *** pnavarro has joined #openstack-keystone | 06:32 | |
| *** afazekas_ has joined #openstack-keystone | 06:39 | |
| marekd | morning. | 06:43 |
| *** dims_ has joined #openstack-keystone | 06:47 | |
| jiaxi | afternoon | 06:49 |
| *** henrynash has joined #openstack-keystone | 06:52 | |
| *** ChanServ sets mode: +v henrynash | 06:52 | |
| *** dims_ has quit IRC | 06:53 | |
| *** rletrocquer has joined #openstack-keystone | 06:54 | |
| *** miguelgrinberg has quit IRC | 06:56 | |
| *** miguelgrinberg has joined #openstack-keystone | 06:58 | |
| openstackgerrit | Deepti Ramakrishna proposed openstack/keystone: Verify that get_trust() fails when auth context is missing. https://review.openstack.org/204461 | 06:59 |
| openstackgerrit | Deepti Ramakrishna proposed openstack/keystone: Reuse token_ref fetched in AuthContextMiddleware. https://review.openstack.org/190863 | 07:05 |
| bigjools | anyone know if the k2k region switcher is still getting looked at / worked on? This review seems like it's stalled. | 07:06 |
| bigjools | https://review.openstack.org/#/c/159910 | 07:06 |
| *** ankita_wagh has quit IRC | 07:06 | |
| marekd | bigjools: it's rather stalled. | 07:08 |
| bigjools | marekd: are you involved in it at all? | 07:09 |
| marekd | not really. | 07:09 |
| bigjools | I want to give it a shove | 07:09 |
| marekd | however, if you have time/resources i can help reviewing etc. | 07:09 |
| marekd | bigjools: yes, please do! | 07:09 |
| marekd | bigjools: make it pass gate tests and i can review then. | 07:09 |
| bigjools | I am playing with it now, and the underlying auth stuff is a problem, it's moved from ksc to keystoneauth and changed signatures | 07:10 |
| bigjools | so trying to get my head around things | 07:10 |
| marekd | bigjools: yes. | 07:11 |
| marekd | bigjools: so, the new stuff is rather easier | 07:11 |
| *** browne has quit IRC | 07:11 | |
| bigjools | yeah it looked it | 07:11 |
| marekd | bigjools: so you are trying to work on https://review.openstack.org/#/c/159910/10 or some other patch? | 07:11 |
| bigjools | marekd: that one. | 07:12 |
| *** dims_ has joined #openstack-keystone | 07:12 | |
| openstackgerrit | Marek Denis proposed openstack/keystone: Correct spacing in ``mapping_combinations.rst`` https://review.openstack.org/204464 | 07:12 |
| bigjools | I wanted to try and get hold of the branch author before committing too hard | 07:13 |
| marekd | henrynash: ^^ easy review! | 07:13 |
| bigjools | but if ther | 07:13 |
| bigjools | e's no reply I'll just dive it | 07:13 |
| marekd | bigjools: talk to the author but i think he is no longer actively working on it. | 07:13 |
| bigjools | in* | 07:13 |
| bigjools | marekd: ah bummer, ok. Was the general approach OK though? | 07:13 |
| bigjools | as soon as I saw a way to not need Shibboleth IdP I was all over it :) | 07:14 |
| marekd | hehe | 07:14 |
| bigjools | is anyone here going to pyconau? | 07:15 |
| marekd | morganfainberg goes for sure. | 07:15 |
| marekd | maybe jamielennox ? | 07:15 |
| bigjools | I'll look forward to meeting a few folks | 07:16 |
| lhcheng | bigjools: I think doug is still working on it | 07:16 |
| lhcheng | he's in the horizon midcycle atm | 07:16 |
| bigjools | ah good to know, thanks lhcheng | 07:16 |
| *** dims_ has quit IRC | 07:16 | |
| lhcheng | https://etherpad.openstack.org/p/YVR-horizon-liberty-priorities | 07:16 |
| marekd | lhcheng: are you at the midcycle too ? | 07:16 |
| lhcheng | see line 102 for the status | 07:16 |
| lhcheng | marekd: nope | 07:17 |
| lhcheng | marekd: got approval to attend only one midcycle | 07:18 |
| lhcheng | marekd: trying to listen remotely in the horizon midcycle whenever I get the chance | 07:19 |
| marekd | lhcheng: bigjools i can review the patch but only if there is somebody willing to work on it. | 07:19 |
| marekd | otherwise waste of time. | 07:20 |
| bigjools | marekd: I want to get it working for sure. I will try to get hold of Doug. | 07:20 |
| henrynash | marekd: done! | 07:20 |
| marekd | henrynash: thank you! | 07:20 |
| lhcheng | bigjools: I haven't reviewed the patch for django_openstack_auth since it is still wip | 07:20 |
| lhcheng | by looking at it, still looks rough | 07:20 |
| bigjools | it is rough | 07:20 |
| marekd | lhcheng: https://review.openstack.org/#/c/204464/ you can be another one! | 07:21 |
| jiaxi | who want to exchange review ? https://review.openstack.org/#/c/203312/ | 07:21 |
| bigjools | and needs changing to work with the new keystoneauth stuff | 07:21 |
| marekd | bigjools: yep, actually the patch has some bad assumptions from the very beginning so i'd consider creating another pass on it, in a separate patchset | 07:21 |
| lhcheng | marekd: looks good! | 07:21 |
| marekd | lhcheng: hard engineering is being done there | 07:22 |
| *** e0ne has joined #openstack-keystone | 07:22 | |
| marekd | lhcheng: thanks. | 07:22 |
| bigjools | marekd: While I am experienced in Python I am rather new to keystone code so I am relying on others for advice in that regard. | 07:23 |
| dramakri | henrynash: ping...Henry, when you get a chance, can you please re-look at https://review.openstack.org/#/c/199414/ ? I have replied to your comment. Thanks! | 07:23 |
| henrynash | dramakri: will do, thx | 07:23 |
| -openstackstatus- NOTICE: zuul is undergoing an emergency restart. Jobs will be re-queued but some events may be lost. | 07:23 | |
| lhcheng | bigjools: IBM demo'd the k2k patch in the summit, I think it also has opportunity for improvement on the changes made on the ui side. | 07:24 |
| lhcheng | marekd: hah yeah that is a tough patch to review :) | 07:25 |
| bigjools | lhcheng: sadly I missed the summit. | 07:26 |
| lhcheng | bigjools: you can watch it here: https://www.openstack.org/summit/vancouver-2015/summit-videos/presentation/enabling-real-world-interoperable-hybrid-cloud-use-cases-using-openstack-and-039s-federated-identity-capabilities | 07:28 |
| marekd | lhcheng: i can you also for this: https://review.openstack.org/#/c/203572/ :-) | 07:28 |
| bigjools | ah cool thanks | 07:28 |
| marekd | bigjools: yeah, all talks were recorded | 07:28 |
| dramakri | henrynash: thanks for the prompt review! | 07:28 |
| lhcheng | you'll see topol -1'd by brant in the video :P | 07:29 |
| henrynash | dramakr: yw | 07:29 |
| lhcheng | marekd: looking | 07:30 |
| marekd | https://review.openstack.org/#/c/203301/2//COMMIT_MSG why bug? | 07:31 |
| *** fhubik has joined #openstack-keystone | 07:31 | |
| marekd | c'mon | 07:31 |
| lhcheng | marekd: it seems like a series of moving files around | 07:32 |
| lhcheng | it would be nice to track why are we moving the files around | 07:33 |
| marekd | eeee | 07:34 |
| *** odyssey4me has quit IRC | 07:34 | |
| *** dramakri has left #openstack-keystone | 07:34 | |
| *** odyssey4me has joined #openstack-keystone | 07:37 | |
| *** dims_ has joined #openstack-keystone | 07:44 | |
| *** afazekas_ has quit IRC | 07:45 | |
| *** dguerri` is now known as dguerri | 07:48 | |
| *** dims_ has quit IRC | 07:54 | |
| *** afazekas_ has joined #openstack-keystone | 07:58 | |
| *** bdossant has joined #openstack-keystone | 08:02 | |
| *** jistr has joined #openstack-keystone | 08:03 | |
| *** e0ne has quit IRC | 08:05 | |
| *** topol has quit IRC | 08:06 | |
| jiaxi | wake it up | 08:06 |
| *** lhcheng has quit IRC | 08:09 | |
| *** aix has joined #openstack-keystone | 08:10 | |
| openstackgerrit | lei zhang proposed openstack/keystone: Set db_options for CONF.database https://review.openstack.org/204487 | 08:11 |
| jiaxi | anyone who want to exchange a review ? | 08:11 |
| jiaxi | https://review.openstack.org/#/c/203312/ | 08:11 |
| *** dims_ has joined #openstack-keystone | 08:12 | |
| openstackgerrit | lei zhang proposed openstack/keystone: Set db_options for CONF.database https://review.openstack.org/204487 | 08:14 |
| -openstackstatus- NOTICE: zuul jobs are currently stuck while problems with gearman are debugged | 08:14 | |
| *** ChanServ changes topic to "zuul jobs are currently stuck while problems with gearman are debugged" | 08:14 | |
| *** dims_ has quit IRC | 08:16 | |
| openstackgerrit | Marek Denis proposed openstack/keystone: Adds a base class for functional tests https://review.openstack.org/203142 | 08:18 |
| *** kiran-r has quit IRC | 08:24 | |
| *** boris-42 has quit IRC | 08:32 | |
| *** dims_ has joined #openstack-keystone | 08:41 | |
| *** dims_ has quit IRC | 08:45 | |
| *** pnavarro is now known as pnavarro|afk | 08:50 | |
| *** stevemar has joined #openstack-keystone | 09:01 | |
| *** ChanServ sets mode: +v stevemar | 09:01 | |
| *** stevemar has quit IRC | 09:05 | |
| *** topol has joined #openstack-keystone | 09:06 | |
| *** ChanServ sets mode: +v topol | 09:06 | |
| *** e0ne has joined #openstack-keystone | 09:07 | |
| *** gus has quit IRC | 09:10 | |
| *** topol has quit IRC | 09:11 | |
| *** dims_ has joined #openstack-keystone | 09:15 | |
| *** dims_ has quit IRC | 09:20 | |
| *** dims_ has joined #openstack-keystone | 09:23 | |
| *** dims_ has quit IRC | 09:27 | |
| *** e0ne has quit IRC | 09:29 | |
| *** hightall has quit IRC | 09:30 | |
| *** fhubik is now known as fhubik_afk | 09:32 | |
| *** pnavarro|afk is now known as pnavarro | 09:34 | |
| *** tsubic has joined #openstack-keystone | 09:39 | |
| *** davechen has left #openstack-keystone | 09:41 | |
| *** fhubik_afk is now known as fhubik | 09:45 | |
| *** dims_ has joined #openstack-keystone | 09:47 | |
| openstackgerrit | Dave Chen proposed openstack/keystone: Minor fix in the `configuration.rst` https://review.openstack.org/204529 | 09:55 |
| jamielennox | bigjools: yep, i'll be at pyconau | 09:56 |
| *** gus has joined #openstack-keystone | 09:57 | |
| openstackgerrit | henry-nash proposed openstack/keystone: Add support for data-driven backend assignment testing https://review.openstack.org/149178 | 10:02 |
| openstackgerrit | henry-nash proposed openstack/keystone: Add support for effective & inherited mode in data driven tests https://review.openstack.org/151623 | 10:03 |
| openstackgerrit | David Charles Kennedy proposed openstack/keystone: Move endpoint catalog filtering to default driver https://review.openstack.org/167675 | 10:05 |
| bigjools | jamielennox: see you there then | 10:05 |
| jamielennox | bigjools: looking forward to it, though a little stressed about the presentations i've got to do | 10:06 |
| bigjools | jamielennox: I avoid stress like that where possible :) | 10:06 |
| jamielennox | bigjools: yea, i'm an idiot but it's how i get sponsored | 10:07 |
| *** topol has joined #openstack-keystone | 10:08 | |
| *** ChanServ sets mode: +v topol | 10:08 | |
| bigjools | all's fair in love and war. And Python. | 10:08 |
| openstackgerrit | henry-nash proposed openstack/keystone: Improve List Role Assignments Filters Performance https://review.openstack.org/137202 | 10:11 |
| openstackgerrit | henry-nash proposed openstack/keystone: Add support for effective & inherited mode in data driven tests https://review.openstack.org/151623 | 10:11 |
| openstackgerrit | henry-nash proposed openstack/keystone: Add support for group membership to data driven assignment tests https://review.openstack.org/151962 | 10:11 |
| openstackgerrit | henry-nash proposed openstack/keystone: Add support for data-driven backend assignment testing https://review.openstack.org/149178 | 10:11 |
| jamielennox | bigjools: all's fair in ruby, in python we obey the rules | 10:12 |
| *** topol has quit IRC | 10:12 | |
| bigjools | I dunno, I've seen some code in my time :) | 10:12 |
| jamielennox | fair | 10:13 |
| openstackgerrit | henry-nash proposed openstack/keystone: Broaden domain-group testing of list_role_assignments https://review.openstack.org/154302 | 10:13 |
| openstackgerrit | henry-nash proposed openstack/keystone: Test list_role_assignment in standard inheritance tests https://review.openstack.org/153897 | 10:13 |
| openstackgerrit | henry-nash proposed openstack/keystone: Support project hierarchies in data driver tests https://review.openstack.org/154485 | 10:14 |
| jamielennox | marekd: how do you guys handle logging out with websso? | 10:15 |
| *** e0ne has joined #openstack-keystone | 10:17 | |
| *** dims_ has quit IRC | 10:18 | |
| *** aix has quit IRC | 10:19 | |
| *** fhubik has quit IRC | 10:23 | |
| *** fhubik has joined #openstack-keystone | 10:23 | |
| marekd | horizon should redirect to keystone.cern.ch/Shibboleth.sso/Logout like URL. | 10:23 |
| marekd | and shibboleth should clean the cookies. | 10:23 |
| marekd | for that session. | 10:23 |
| *** fhubik is now known as fhubik_afk | 10:26 | |
| tsubic | If I run devstack on a single machine, should it matter if I use localhost or the internal IP for the enviornment vars? | 10:33 |
| *** dims_ has joined #openstack-keystone | 10:36 | |
| *** fhubik_afk is now known as fhubik | 10:37 | |
| openstackgerrit | Marek Denis proposed openstack/keystone: Adds a base class for functional tests https://review.openstack.org/203142 | 10:38 |
| openstackgerrit | Marek Denis proposed openstack/keystone: Federation Identity Provider functional tests https://review.openstack.org/203258 | 10:39 |
| *** dims_ has quit IRC | 10:41 | |
| *** dims_ has joined #openstack-keystone | 10:41 | |
| jamielennox | marekd: ok, so nothing is actually required from keystone, you don't kill tokens or anything | 10:47 |
| *** piyanai has joined #openstack-keystone | 10:50 | |
| *** pnavarro is now known as pnavarro|lunch | 10:53 | |
| samueldmq | +ayoung | samueldmq, if the catalog does not have enough information in it to determine the endpoint id, DENY | 10:57 |
| samueldmq | ayoung: that's only valid for endpoint enforcement right ? | 10:57 |
| samueldmq | ayoung: for policy, that means if a request arrives with an URL that doesn't map to the endpoint_id which has the policy associated with it, we wouldn't fetch the policy | 10:58 |
| *** fhubik is now known as fhubik_afk | 11:12 | |
| *** amakarov_away is now known as amakarov | 11:12 | |
| samueldmq | henrynash: thanks for your review on the 'Dynamic Policies Delivering Mechanism' | 11:13 |
| samueldmq | henrynash: did you have a chance to look at the entire spec ? or not yet ? | 11:13 |
| samueldmq | henrynash: I just wanted to know if the rest of it looked clear | 11:13 |
| ParsectiX | hi guys again. | 11:14 |
| ParsectiX | just a quick question. I want to update the default project quota after creating a project. I will use the ProjectManager for this ? | 11:15 |
| samueldmq | ParsectiX: I don't think so, depending on the resource you want to define quotas, you should use different clients | 11:17 |
| samueldmq | ParsectiX: I mean, the service owning the resource is in charge of managing its quota | 11:17 |
| *** aix has joined #openstack-keystone | 11:18 | |
| *** bradjones has quit IRC | 11:18 | |
| samueldmq | ParsectiX: for example, nova has quotas for vcores/ram/disk quota, | 11:18 |
| samueldmq | ParsectiX: tl;dr keystone doesn't manage quotas itself :) | 11:19 |
| *** chenhong1 has quit IRC | 11:20 | |
| *** jaosorior has joined #openstack-keystone | 11:20 | |
| ParsectiX | samueldmq: Thanks. and this what it does ? http://docs.openstack.org/developer/python-keystoneclient/api/keystoneclient.v3.html#keystoneclient.v3.projects.ProjectManager.update | 11:20 |
| *** bradjones has joined #openstack-keystone | 11:20 | |
| *** bradjones has quit IRC | 11:20 | |
| *** bradjones has joined #openstack-keystone | 11:20 | |
| ParsectiX | updates the general info for the project ? | 11:20 |
| breton | yes | 11:21 |
| samueldmq | ParsectiX: exactly, that updates the project information (name, description, enabled ..) :) | 11:21 |
| samueldmq | breton: ++ | 11:21 |
| openstackgerrit | henry-nash proposed openstack/keystone: Remove manager-driver assignment metadata construct https://review.openstack.org/148995 | 11:21 |
| breton | ParsectiX: the list of parameters is the same as for create -- http://docs.openstack.org/developer/python-keystoneclient/api/keystoneclient.v3.html#keystoneclient.v3.projects.ProjectManager.create | 11:22 |
| breton | (I wonder why update is not documented) | 11:22 |
| *** fhubik_afk is now known as fhubik | 11:23 | |
| ParsectiX | breton, samueldmq: thanks guys | 11:24 |
| samueldmq | ParsectiX: np | 11:24 |
| samueldmq | breton: I'll get a new member here to document it, if you aren't going to do so | 11:24 |
| jiaxi | what done np mean ? | 11:25 |
| breton | samueldmq: ok, go ahead | 11:25 |
| ParsectiX | I can do it guys if you guide me as it will be my first contribution | 11:25 |
| ParsectiX | Also found this describing the quotas: http://docs.openstack.org/openstack-ops/content/projects_users.html#quotas | 11:25 |
| samueldmq | jiaxi: 'done' is just.. done :) 'np' is No Problem | 11:25 |
| samueldmq | jiaxi: hope that was your question :) | 11:26 |
| samueldmq | ParsectiX: ah ok go ahead then | 11:26 |
| jiaxi | samueldmq: How to read keystone code ? | 11:26 |
| samueldmq | ParsectiX: do you have setup your accounts etc ? | 11:26 |
| jiaxi | samueldmq: I want to understand keystone throughly | 11:27 |
| samueldmq | jiaxi: what do you mean, get familiar with the code ? you need a specific part of keystone (identity, assignment?)? | 11:27 |
| jiaxi | samueldmq : I need to know all | 11:27 |
| samueldmq | ParsectiX: see http://docs.openstack.org/infra/manual/developers.html | 11:28 |
| samueldmq | ParsectiX: to setup your accounts, env | 11:28 |
| jiaxi | samueldmq : know the data flow, work principle. | 11:28 |
| samueldmq | jiaxi: wow that's too much | 11:28 |
| jiaxi | samueldmq: Today, I read code one by one. | 11:29 |
| samueldmq | jiaxi: keep in mind that know everything is hard, since things are being added/changing all the time | 11:29 |
| jiaxi | A little confused, a little tired. | 11:29 |
| samueldmq | jiaxi: start with documentation, so you can understand better the principles | 11:29 |
| samueldmq | jiaxi: what keystone stands for, etc | 11:29 |
| jiaxi | samueldmq: I have read the docs. | 11:30 |
| jiaxi | samueldmq: I know keystone in general. but not in details. | 11:30 |
| samueldmq | jiaxi: give me an example of what you read in the docs and wanted to see in the code | 11:30 |
| jiaxi | samueldmq : for example. I don't know why the expired trust can't be deleted. | 11:30 |
| samueldmq | jiaxi: getting familiar with the code takes time, that's an exercise | 11:30 |
| samueldmq | jiaxi: reviewing code is a good approach to exercise that | 11:31 |
| ParsectiX | samueldmq: okay | 11:31 |
| samueldmq | jiaxi: ok so let's see a good approach to find that code | 11:31 |
| jiaxi | samueldmq: I read what's function of identity, catalog, token, and so on. | 11:31 |
| jiaxi | samueldmq: The code is too many. I want to know what done the code mean ? every line. | 11:32 |
| jiaxi | samueldmq: I reviewed others code. A little hard for me. I often give +1 | 11:33 |
| samueldmq | jiaxi: k, as I said knowing *all* the code by hard is somehting very... well, I think I can't do that | 11:33 |
| samueldmq | jiaxi: first, put in your mind that you won't get familiar with the keystone code within a week | 11:34 |
| jiaxi | samueldmq: You are right. Maybe I just try to understand keystone more | 11:34 |
| samueldmq | jiaxi: as I said, that's an exercise that takes time, like learning a new language, every day you learn new things | 11:34 |
| samueldmq | jiaxi: yeah that's better now | 11:34 |
| samueldmq | :) | 11:34 |
| samueldmq | jiaxi: in your example, you could start by looking where the trust code lives | 11:35 |
| samueldmq | jiaxi: start looking at https://github.com/openstack/keystone/tree/master/keystone | 11:35 |
| samueldmq | jiaxi: then you can easily see a directory called 'trust', that's where it lives | 11:35 |
| jiaxi | samueldmq: The reason is the trust that expired can't be found | 11:35 |
| samueldmq | jiaxi: one more thing you need to know once you get into that directory | 11:36 |
| samueldmq | jiaxi: in keystone, we organize things in levels.. router -> controller -> manager -> driver | 11:36 |
| jiaxi | samueldmq,dirver is the database ? | 11:36 |
| samueldmq | jiaxi: router receives the requests by URL match and queries the controller | 11:36 |
| *** henrynash has quit IRC | 11:37 | |
| samueldmq | jiaxi: controller asks the proper manager methods to get the response it needs .. then controller do the formatting of the results | 11:37 |
| samueldmq | jiaxi: the manager (core.py) is in charge o the business logic.. i.e most of logic will be there, but it needs to get info from the database | 11:38 |
| jiaxi | samueldmq: It's the manager who does the logical work? | 11:38 |
| samueldmq | jiaxi: so the manager qqueries the driver, that can be sql or ldap drivers | 11:38 |
| samueldmq | jiaxi: in every keystone module you'll find that organization (router -> controller -> manager -> driver) | 11:39 |
| jiaxi | samueldmq: Good guide, It seems that I know better now.. | 11:39 |
| samueldmq | jiaxi: I hope that will help you to get through the code and understand it | 11:39 |
| samueldmq | jiaxi: fell free to ask questions, and exercise learning the code every day :) | 11:40 |
| jiaxi | samueldmq: some files dont's in directory, cli.py config.py etc | 11:40 |
| jiaxi | Why not put the in common ? | 11:40 |
| samueldmq | jiaxi: common is not for 'homeless' files :) it's for common code that is used in several places | 11:41 |
| jiaxi | samueldmq: so cli.py config.py is homeless file ? | 11:42 |
| *** edmondsw has joined #openstack-keystone | 11:43 | |
| ParsectiX | samueldmq: a lot of stuff in this page :) | 11:47 |
| samueldmq | jiaxi: no, as they're a kind of entry point for the service, they live in the main directory | 11:47 |
| samueldmq | jiaxi: that's my understanding | 11:48 |
| samueldmq | ParsectiX: yeah basically just follow the account setups, after that you would be able to login in review.openstack.org | 11:48 |
| samueldmq | ParsectiX: and Installing git-review as well :) | 11:49 |
| ParsectiX | where a you develop guys on a linux box ? | 11:49 |
| jiaxi | samueldmq: Good guide,much better than the doc. | 11:50 |
| samueldmq | ParsectiX: btw you do that just once :) yeah I use an ubuntu box | 11:50 |
| samueldmq | jiaxi: you can always come here and ask quesitons about the code | 11:50 |
| samueldmq | jiaxi: docs are good as well, but asking here can be quicker :) | 11:51 |
| jiaxi | samueldmq: You are so kind. Thank you. | 11:51 |
| samueldmq | jiaxi: you're welcome | 11:51 |
| *** david-lyle has joined #openstack-keystone | 11:52 | |
| jiaxi | samueldmq: Could you have time to review my patch set https://review.openstack.org/#/c/200512/ | 11:53 |
| jiaxi | samueldmq: if have no time ,no problem. I can review your. I have much time. | 11:54 |
| samueldmq | jiaxi: I will review it later today, thanks | 11:55 |
| ayoung | samueldmq, sorry, left this running all night to see what happened with an install. Just seeing your message now, about to head into the office. | 11:55 |
| ayoung | But if dyn pol is on, and there is not enough info to fetch policy, probablyh should be a deny | 11:55 |
| samueldmq | ayoung: np sir | 11:55 |
| ayoung | samueldmq, back in about an hour | 11:55 |
| *** ayoung has quit IRC | 11:55 | |
| samueldmq | ayoung: sure | 11:55 |
| samueldmq | oops | 11:55 |
| *** raildo has joined #openstack-keystone | 12:07 | |
| marekd | dstanek: hi. | 12:10 |
| dstanek | marekd: hi! | 12:10 |
| marekd | https://review.openstack.org/#/c/203142/7 - so there is this patch and i wanted to hear your opinoin whether we should to inherit/reuse as much as possible from unit tests helpers or let's go ahead and almost recode everything. | 12:11 |
| marekd | esp assertValidResponse et all | 12:11 |
| marekd | dstanek: i also think we should't really care about cleaning objects added during tests. All in all this will probably go somewhere in the gate and each time a VM ill be killed, right? | 12:13 |
| marekd | actually i will ask on infra. | 12:13 |
| marekd | dstanek: you may also want to take a look at https://review.openstack.org/#/c/203258/3/keystone/tests/functional/federation/test_v3_crud.py and see it if's going in the right direction. | 12:14 |
| dstanek | marekd: some of those assertion methods could be put somewhere where they can be shared. in the future the v3 tests will go away | 12:14 |
| marekd | dstanek: hum, it's a great refactoring effort | 12:15 |
| marekd | dstanek: cause clearly some of those are in the classes that we don't really want to reuse in functional tests. | 12:15 |
| dstanek | marekd: ah, nice. | 12:15 |
| dstanek | marekd: only pull the things you need, when you need them and it won't be too bad | 12:15 |
| dstanek | rewriting all of the v3 tests will be quite a lot of work for sure | 12:16 |
| *** jdandrea has joined #openstack-keystone | 12:17 | |
| marekd | dstanek: i actually tried to do multi inheritance problem (MRO problems) and gave up for now, but for sure I will want to check whether server responds correctly, not only it's HTTP status code. | 12:18 |
| dstanek | marekd: i can get a patch together on top of yours that brings in that functionality | 12:19 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone-specs: Dynamic Policies Delivering Mechanism https://review.openstack.org/197980 | 12:19 |
| marekd | dstanek: maybe not on top of mine, rather on top of https://review.openstack.org/#/c/203142/7 or simply modify that one. | 12:19 |
| *** fhubik is now known as fhubik_afk | 12:20 | |
| dstanek | marekd: sure | 12:22 |
| *** fhubik_afk is now known as fhubik | 12:22 | |
| marekd | dstanek: thanks. | 12:23 |
| dstanek | marekd: i'm going to go for a morning run and then i'll start working on it shortly after | 12:23 |
| marekd | dstanek: i can probably help in building this framework, as I guess I will be one of the early adopter with my federation functional tests...:-) | 12:23 |
| marekd | sure, no rush | 12:23 |
| dstanek | marekd: i'm pretty sure that the VMs are trashed after use, but i'm curious what infra has to say | 12:23 |
| marekd | dstanek: they are, | 12:23 |
| marekd | dstanek: just confirmed | 12:24 |
| dstanek | cool | 12:24 |
| *** dims_ has quit IRC | 12:24 | |
| dstanek | i'll bring over some of the helpers that i think will be useful | 12:24 |
| marekd | they just suggested cleaning after ourselves as it may be better for us, dev running func tests on local devstacks. | 12:24 |
| marekd | dstanek: i am wondering if there are kind of methods, something like setUp() but called after the test... | 12:25 |
| *** dguerri is now known as dguerri` | 12:25 | |
| marekd | loks like a perfect place for cleaning and not having to call it explicitely every time. | 12:25 |
| breton | marekd: tearDown()? | 12:26 |
| marekd | breton: is it called after each test ? | 12:27 |
| marekd | breton: if it is, that's cool | 12:27 |
| marekd | i was already thinking about some decorators or so | 12:27 |
| breton | marekd: > Method called immediately after the test method has been called and the result recorded | 12:27 |
| marekd | breton: oh, cool | 12:28 |
| marekd | good to know. | 12:28 |
| dstanek | marekd: yeah, tearDown is called after each test, but you don't want to use it | 12:28 |
| marekd | dstanek: why not? | 12:28 |
| dstanek | use clean ups instead like we do in the unit tests | 12:28 |
| * breton is interested why not too | 12:28 | |
| marekd | dstanek: clean ups? | 12:28 |
| marekd | anyway, go running and we talk later | 12:28 |
| dstanek | there are corner cases where tearDown is not called and things are not properly destroyed when there are exceptions during the setUp | 12:28 |
| samueldmq | dstanek: and I think as you add the cleanup calls as you setup, we ensure a proper cleanup will happen (inverse order) | 12:30 |
| dstanek | in the setUp you add a clean up to clean whatever stuff you set up :-) http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/core.py#n335 | 12:30 |
| samueldmq | dstanek: is that right or am I saying silly things ? :) | 12:31 |
| breton | > If setUp() fails, meaning that tearDown() is not called, then any cleanup functions added will still be called | 12:31 |
| breton | that's cool | 12:31 |
| dstanek | hmmm....or maybe it's an exception in tearDown causes tear downs to bail...either way tearDown is broken | 12:31 |
| dstanek | samueldmq: yes, clean ups are called in order | 12:32 |
| samueldmq | I think tear down methods should be teared down ... | 12:32 |
| samueldmq | I wonder why we even have them anyway, if cleanup is always better | 12:33 |
| breton | we don't | 12:34 |
| * breton always wondered why we don't use them. Now he knows. | 12:34 | |
| dstanek | yeah, i spent some time a while back removing them | 12:36 |
| samueldmq | yeah, this guy is always making nice cleanups ^ | 12:37 |
| *** gordc has joined #openstack-keystone | 12:37 | |
| samueldmq | :) | 12:37 |
| *** stevemar has joined #openstack-keystone | 12:39 | |
| *** ChanServ sets mode: +v stevemar | 12:39 | |
| *** piyanai has quit IRC | 12:39 | |
| *** stevemar has quit IRC | 12:43 | |
| *** jsavak has joined #openstack-keystone | 12:49 | |
| marekd | dstanek: ok, so i don't understand - so addCleanup() is called from inside of setUp() ? | 12:50 |
| *** pnavarro|lunch is now known as pnavarro | 12:50 | |
| *** ParsectiX has quit IRC | 12:51 | |
| *** dguerri` is now known as dguerri | 12:51 | |
| lbragstad | dstanek: i think i finished the federation testing stuff... | 12:52 |
| lbragstad | cc marekd ^ | 12:52 |
| breton | marekd: yes | 12:52 |
| breton | marekd: it addCleanup adds a callback | 12:52 |
| marekd | breton: so, addCleanup is called after the tests. | 12:53 |
| breton | err, no | 12:53 |
| breton | addCleanup(function_that_does_cleanup) adds function that does cleanup | 12:53 |
| breton | and that function is called after a test | 12:54 |
| marekd | breton: then i am good, otherwise it would not call after the last tests. | 12:54 |
| *** hrou has joined #openstack-keystone | 12:54 | |
| jiaxi | dstanek: Hello, david. | 12:55 |
| breton | the order is the following: setUp -> test -> tearDown -> function_that_does_cleanup | 12:55 |
| breton | but function_that_does_cleanup is called regardless of previous functions' success | 12:56 |
| *** bknudson has joined #openstack-keystone | 12:59 | |
| *** ChanServ sets mode: +v bknudson | 12:59 | |
| lbragstad | dstanek: https://github.com/lbragstad/keystone-deploy/blob/federation/test_federation_exercises.py should contain everything for setting up two individual keystone nodes, and bootstrapping both the idp and sp | 13:02 |
| *** edmondsw has quit IRC | 13:02 | |
| lbragstad | so, running $ ansible-playbook -i federation-inventory --user="root" deploy.yaml # will give you k2k federation | 13:03 |
| lbragstad | on two separate nodes | 13:04 |
| *** fhubik is now known as fhubik_afk | 13:04 | |
| *** topol has joined #openstack-keystone | 13:07 | |
| *** ChanServ sets mode: +v topol | 13:07 | |
| lbragstad | you should need http://cdn.pasteraw.com/cme0rmk0hearm9pqrqkywdkajb442v3 to deploy, bootstrap, and run a single test against k2k federation | 13:08 |
| lbragstad | cc dolphm marekd ^ | 13:08 |
| *** topol has quit IRC | 13:11 | |
| *** chenhong has joined #openstack-keystone | 13:12 | |
| *** ParsectiX has joined #openstack-keystone | 13:14 | |
| *** stevemar has joined #openstack-keystone | 13:14 | |
| *** ChanServ sets mode: +v stevemar | 13:14 | |
| *** henrynash has joined #openstack-keystone | 13:14 | |
| *** ChanServ sets mode: +v henrynash | 13:14 | |
| samueldmq | henrynash: hey, just saw your review on the middleware spec for dynamic policies | 13:15 |
| samueldmq | henrynash: so basically that's a naming issue ... | 13:15 |
| samueldmq | rihgt ? | 13:15 |
| henrynash | samueldmq: hi | 13:15 |
| samueldmq | henrynash: so the policy stored in the server is not necessarily a complete policy, it can be just some rules, which are customized | 13:16 |
| henrynash | samueldmq: for me, yes…..I think all we doing here is saying “we think keystone should be a polciy CMS”….and here’s how we make it so….and this has nothing to do with polciy being more granular, dynamic or anything else | 13:16 |
| samueldmq | henrynash: so dynamic means dynamically delivered by openstack | 13:17 |
| henrynash | samueldmq: well, are we sure that’s what people will always want? | 13:17 |
| samueldmq | henrynash: but that can be a complete policy | 13:17 |
| henrynash | samueldmq: …will always want.... | 13:17 |
| samueldmq | henrynash: not sure I follow | 13:18 |
| samueldmq | henrynash: btw I have a new patchset with a better problem description... you'll like it better I think https://review.openstack.org/#/c/197980/6/specs/backlog/dynamic-policies-delivering-mechanism.rst | 13:18 |
| henrynash | samueldmq: so I’d have thought that a common scenario would be “my endpoints get their policy from keystone CMS, period.” | 13:18 |
| henrynash | samueldmq: and I don;t want some other mechanism to enable an endpoint to have any other kind of rules | 13:19 |
| henrynash | samuelmq: so I can imagine some providers wanting the one served up form keystone to be the only one, other might want it it overlayed on the local one | 13:19 |
| samueldmq | henrynash: if you want it to be the only one, create a complete policy | 13:20 |
| henrynash | samueldmq: in this patch we should not assume how the endpoint will use the policy…that’s for a differet patch | 13:20 |
| samueldmq | henrynash: overlaying everything is like just it existed all the time | 13:20 |
| henrynash | samueldmq: I don’t mean a unified policy file…. | 13:21 |
| henrynash | samueldmq: just no overlay | 13:21 |
| samueldmq | henrynash: for now we write it in a different policy file, called for example /etc/glance/dynamic-policy.json | 13:21 |
| samueldmq | henrynash: at enforcement time we do the overlay | 13:21 |
| samueldmq | henrynash: so that dynamic-policy.json has priority over policy.json | 13:22 |
| henrynash | samueldmq: so for one thing, I would suggest this is “keystone-cms-polocy.json | 13:22 |
| henrynash | samueldmq: don’t call it dynmaic | 13:22 |
| samueldmq | henrynash: why ? is it confusing calling it dynamic ? | 13:23 |
| henrynash | samueldmq: for me, sure | 13:23 |
| samueldmq | henrynash: for me dynamic means it is dynamically defined (using the api) and dynamically delivered | 13:23 |
| henrynash | samuedmq: I’d like to banish the word dynmical for all these specs and codings | 13:24 |
| samueldmq | henrynash: but I am open on that front | 13:24 |
| samueldmq | henrynash: btw the file naming is configurable in oslo.policy | 13:24 |
| henrynash | samueldmq: and the oslo.policy patch should take a config seting that determins if we overaly the file or ONLY use the keystone cms one and ignore the loca one | 13:24 |
| samueldmq | henrynash: hmm I think I have a solution for your usecase | 13:25 |
| samueldmq | henrynash: if you want to only use the policy from keystone, set the 'policy_file' config to be the same as 'dynamic_policy_file' setting | 13:25 |
| samueldmq | henrynash: if that makes sense, we could configure that, or add a config option | 13:25 |
| samueldmq | I meant 'we could document that' | 13:26 |
| *** ParsectiX has quit IRC | 13:26 | |
| samueldmq | henrynash: this https://github.com/openstack/oslo.policy/blob/master/oslo_policy/opts.py#L28 | 13:26 |
| henrynash | …and if we did that, would our oslo patch be smart enough to not try and overaly with itself? | 13:27 |
| samueldmq | henrynash: would be the same as the new option 'dynamic_policy_file' (ignore the naming..) | 13:27 |
| *** david-lyle has quit IRC | 13:27 | |
| samueldmq | henrynash: sure we can add this inteligence there :) | 13:27 |
| henrynash | samueldmq: so that might work…agreed…..I need to think about my othe goal here ( :-) ), in that I want the ability for keystone to return an ordered list of policies to overaly on each other | 13:28 |
| samueldmq | henrynash: ok so on that point I think keystone should return a single policy, and do some internal overlay if needed | 13:30 |
| *** chenhong1 has joined #openstack-keystone | 13:30 | |
| henrynash | what I want is to add a new API to endpoint policy to return the a list of policies that should be applied for this endpoint - i.e. allowing high level policy rules at the cloud level, to be overridden by those at the service level, to be overriden by those at the region+service level, to be overridden by those at the endpoint level.... | 13:30 |
| samueldmq | henrynash: we'll avoid unecessary network overload | 13:30 |
| samueldmq | henrynash: sure, the result would be a kind of 'effective' policy, right? | 13:31 |
| henrynash | so it *could* do that…..if we think it’s OK to have overalaying in both places | 13:31 |
| henrynash | was trying to avoid duplicating that ability | 13:31 |
| samueldmq | henrynash: so I think the API *always* returns teh effective policy, considering higher policies (service, etc) | 13:31 |
| samueldmq | henrynash: one thing is the overlay inside the API defined policies, so that is managed by keystone | 13:32 |
| henrynash | ah yes, but today the “closest” one wins and superceedes EVREYTHING higher up | 13:32 |
| samueldmq | henrynash: another is how we deal with the old-defined policies, which is an oslo.policy capability | 13:32 |
| *** chenhong has quit IRC | 13:32 | |
| henrynash | yeah, so hence trying to not split this fucntionaliy | 13:33 |
| samueldmq | henrynash: keystone delivers the Custom Policy, what to do with it is to oslo.policy decide, I think that makes sense | 13:34 |
| samueldmq | henrynash: and we avoid oslo.policy knowing about policies hierarchies | 13:34 |
| samueldmq | henrynash: and avoid overload in the responses, etc :) well that makes sense to me | 13:34 |
| henrynash | samueldmq: well, it’s going to know about a hierarchy of 2, right? | 13:34 |
| samueldmq | henrynash: regions can be nested | 13:35 |
| henrynash | samueldmq: ok, I’ll think some more on that score... | 13:35 |
| samueldmq | henrynash: yes please, I like your concerns, and the fact you're getting involved | 13:36 |
| samueldmq | henrynash: thanks | 13:36 |
| samueldmq | henrynash: btw, I will wait to see other people opinion about the policy naming on https://review.openstack.org/#/c/134655/9/specs/backlog/dynamic-policies-fetch-cache.rst | 13:36 |
| samueldmq | henrynash: I am not against, I am very open, just want to make sure we do the better we can :) | 13:37 |
| *** dsirrine has quit IRC | 13:43 | |
| *** TheIntern has joined #openstack-keystone | 13:44 | |
| *** dsirrine has joined #openstack-keystone | 13:45 | |
| jiaxi | In catalog/controller.py @dependency.requires('catalog_api') 34 class Service(controller.V2Controller): | 13:45 |
| jiaxi | where is the catalog_api ? | 13:45 |
| jiaxi | catalog_api will be an attribute of class Service. But how does Service find the catalog_api ? | 13:46 |
| samueldmq | jiaxi: https://github.com/openstack/keystone/blob/master/keystone/catalog/core.py#L88 | 13:47 |
| samueldmq | jiaxi: remember the controller uses the manager, that's the dependency | 13:48 |
| *** dims_ has joined #openstack-keystone | 13:48 | |
| *** edmondsw has joined #openstack-keystone | 13:48 | |
| samueldmq | jiaxi: the link I sent you (core.py) contains the manager | 13:48 |
| samueldmq | jiaxi: remember (router -> controller -> manager -> driver) | 13:48 |
| jiaxi | samueldmq: okay , I will look how does it find the manager. | 13:49 |
| *** ParsectiX has joined #openstack-keystone | 13:50 | |
| *** jecarey has joined #openstack-keystone | 13:52 | |
| samueldmq | bknudson: do you think some documentation on introducing the keystone code would be helpful ? | 13:52 |
| samueldmq | bknudson: I know the code itself is documented, but I mean something else like explaining how our code is organized | 13:53 |
| marekd | stevemar: erm, did oauth deps changed in ksc? | 13:53 |
| bknudson | samueldmq: sure, if we don't have anything already | 13:53 |
| samueldmq | bknudson: the (router -> controller -> manager -> driver) structure, etc | 13:53 |
| samueldmq | bknudson: nice, I will check, thanks | 13:53 |
| marekd | stevemar: some tests are failing on http://cdn.pasteraw.com/98ee5x6uox0n8rf7y53a8mur9ntwn8r | 13:54 |
| marekd | its pure mare | 13:54 |
| marekd | master | 13:54 |
| marekd | which is strange. | 13:54 |
| *** fhubik_afk is now known as fhubik | 13:57 | |
| bknudson | marekd: https://pypi.python.org/pypi/oauthlib -- 2015-07-20 | 13:59 |
| bknudson | might have to cap <1.0.0 in global-requirements | 14:00 |
| samueldmq | bknudson: what is cap ? | 14:02 |
| samueldmq | dstanek: what the right import order in a python file, is it : i) std libs, ii) external libs and then iii) internal deps | 14:03 |
| bknudson | samueldmq: https://www.google.com/search?q=define+cap&ie=utf-8&oe=utf-8 -- see verb #2 | 14:03 |
| ParsectiX | I have an architecture question. I have my public endpoints and use a private internal subnet for the for them inside. when I'm trying to use the APIs from outside in a point they are tying to access a private IP | 14:03 |
| samueldmq | dstanek: so those are three blocks in the file .. should we need more than that in any case ? I'm asking because of the review I got in https://review.openstack.org/#/c/188561/4/keystonemiddleware/auth_token/_policy.py | 14:03 |
| *** btully has joined #openstack-keystone | 14:03 | |
| ParsectiX | and they fail | 14:03 |
| samueldmq | bknudson: yeah, I want to know how that applies in the context of dependencies, I've seen that term sometimes before | 14:04 |
| bknudson | setting the maximum version we allow | 14:05 |
| ParsectiX | can somehow use only the Public andpoints from my laptop that I make the API calls ? | 14:05 |
| samueldmq | bknudson: k so the upper version limit, thanks sir | 14:06 |
| *** zzzeek has joined #openstack-keystone | 14:06 | |
| *** bknudson has quit IRC | 14:06 | |
| *** piyanai has joined #openstack-keystone | 14:07 | |
| marekd | where is bkudson ? :/ | 14:09 |
| marekd | bknudson | 14:09 |
| *** mestery has joined #openstack-keystone | 14:11 | |
| *** bknudson has joined #openstack-keystone | 14:14 | |
| *** ChanServ sets mode: +v bknudson | 14:14 | |
| -openstackstatus- NOTICE: CI is currently recovering from an outage overnight. It is safe to recheck results with NOT_REGISTERED errors. It may take some time for zuul to work through the backlog. | 14:15 | |
| *** ChanServ changes topic to "CI is currently recovering from an outage overnight. It is safe to recheck results with NOT_REGISTERED errors. It may take some time for zuul to work through the backlog." | 14:15 | |
| openstackgerrit | Marek Denis proposed openstack/python-keystoneclient: Constrain oauthlib versions https://review.openstack.org/204632 | 14:15 |
| marekd | bknudson: i don't know whether this is a right way to proceed. | 14:16 |
| marekd | ^^ | 14:16 |
| *** boris-42 has joined #openstack-keystone | 14:16 | |
| *** ParsectiX has quit IRC | 14:16 | |
| marekd | stevemar: ^^ | 14:16 |
| bknudson | marekd: the change will have to be made to http://git.openstack.org/cgit/openstack/requirements/tree/global-requirements.txt first | 14:16 |
| marekd | bknudson: uh, ok | 14:17 |
| *** tsubic has left #openstack-keystone | 14:17 | |
| openstackgerrit | Marek Denis proposed openstack/python-keystoneclient: Constrain oauthlib versions https://review.openstack.org/204632 | 14:17 |
| *** richm has joined #openstack-keystone | 14:17 | |
| jiaxi | https://review.openstack.org/#/c/200512/ | 14:19 |
| *** browne has joined #openstack-keystone | 14:19 | |
| jiaxi | Dolph Mathews suggest me to validate url in V3,too. | 14:20 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:20 | |
| jiaxi | I do not know whether it's proper. Because this bug is caused in v2 | 14:20 |
| marekd | do we have something like Partially-Closes-Bug ? | 14:22 |
| marekd | bknudson: ^^ ? | 14:22 |
| bknudson | marekd: Partial-Bug | 14:22 |
| bknudson | or Related-Bug | 14:23 |
| marekd | bknudson: https://review.openstack.org/#/c/204633/ | 14:23 |
| bknudson | marekd: thanks! | 14:27 |
| *** mylu has joined #openstack-keystone | 14:27 | |
| *** topol has joined #openstack-keystone | 14:29 | |
| *** ChanServ sets mode: +v topol | 14:29 | |
| marekd | bknudson: i am not sure whether we should do this or try adjust ksc code. | 14:29 |
| bknudson | marekd: we'll have to do both | 14:30 |
| bknudson | we'll have to fix keystoneclient eventually | 14:30 |
| marekd | bknudson: oh, so this is just a quick workaround. | 14:30 |
| bknudson | y, if it's easy to fix then there's no need for the cap. | 14:30 |
| breton | henrynash: why -2 on https://review.openstack.org/#/c/168087/2 ? | 14:31 |
| bknudson | but the way things are now we won't be able to merge anything in ksc until the cap is in place or the fix is merged | 14:31 |
| henrynash | breton: talking with jamielennox, we might do away with the raw mode stuff I was using the follow on patch…and hence this patch would not be needed | 14:32 |
| *** piyanai has quit IRC | 14:32 | |
| *** mylu has quit IRC | 14:32 | |
| -openstackstatus- NOTICE: CI is slowly recovering, please be patient while the backlog is worked through. | 14:33 | |
| *** ChanServ changes topic to "Welcome back from the meetup | MidCycle Etherpad: https://etherpad.openstack.org/p/keystone-liberty-midcycle-meetup" | 14:33 | |
| stevemar | marekd: booooooo | 14:44 |
| stevemar | damn oauthlib | 14:44 |
| *** mylu has joined #openstack-keystone | 14:44 | |
| *** ayoung has joined #openstack-keystone | 14:45 | |
| *** ChanServ sets mode: +v ayoung | 14:45 | |
| marekd | stevemar: heh, thought i was boooo'ed :P | 14:45 |
| stevemar | marekd: you? never. only cheers and applause for marek | 14:45 |
| marekd | stevemar: yea, sure! | 14:46 |
| marekd | https://review.openstack.org/#/c/204632/ | 14:46 |
| marekd | feel free to vote | 14:46 |
| marekd | https://review.openstack.org/#/c/204633/ here too | 14:46 |
| *** piyanai has joined #openstack-keystone | 14:49 | |
| breton | marekd: looks like they thought that their get_oauth_params will not be used by anybody | 14:52 |
| *** hrou has quit IRC | 14:53 | |
| *** hrou has joined #openstack-keystone | 14:54 | |
| marekd | breton: maybe :-) | 14:54 |
| marekd | breton: if you have time you can try adjusting ksc | 14:54 |
| marekd | :-) | 14:55 |
| breton | marekd: I will now. We are not planning to drop oauthlib, are we? | 14:55 |
| marekd | stevemar: ^^ ? | 14:55 |
| marekd | breton: ok, so i am going to WIP my patches maybe fixing keystoneclient will be faster | 14:57 |
| *** marzif has quit IRC | 15:00 | |
| *** _hrou_ has joined #openstack-keystone | 15:01 | |
| *** jsavak has quit IRC | 15:03 | |
| *** aix has quit IRC | 15:03 | |
| *** hrou has quit IRC | 15:04 | |
| *** hrou has joined #openstack-keystone | 15:04 | |
| *** _hrou_ has quit IRC | 15:06 | |
| *** mylu has quit IRC | 15:06 | |
| *** TheIntern has quit IRC | 15:08 | |
| *** TheIntern has joined #openstack-keystone | 15:09 | |
| stevemar | marekd: fixing keystoneclient will be the easiest course of action | 15:09 |
| *** david-lyle has joined #openstack-keystone | 15:09 | |
| stevemar | do you have logs? | 15:10 |
| bknudson | run tox -e py27 and you'll see the failure | 15:10 |
| *** mylu has joined #openstack-keystone | 15:10 | |
| marekd | i might get them but ...just pull ksc master and run tox -repy27 | 15:10 |
| marekd | i didn't really dive into root cause of the problem, wanted to do sth else. | 15:11 |
| stevemar | bknudson: i could | 15:11 |
| marekd | i actaly want to move k2k plugin to ksc and start working on osc implementation | 15:11 |
| marekd | as we still don't have ksa released. | 15:11 |
| breton | stevemar: https://github.com/idan/oauthlib/blob/master/oauthlib/oauth1/rfc5849/__init__.py#L181 -- this is the problem | 15:12 |
| breton | stevemar: we pass None as request | 15:12 |
| stevemar | i'm wondering if the server side is broken too | 15:12 |
| *** piyanai has quit IRC | 15:13 | |
| stevemar | thats the second time that method signature has changed on us | 15:13 |
| breton | stevemar: no, the signature has not changed | 15:13 |
| breton | stevemar: they just started to use the parameter | 15:14 |
| stevemar | breton: oh? i thought marek said it did | 15:14 |
| stevemar | ah | 15:14 |
| *** piyanai has joined #openstack-keystone | 15:14 | |
| marekd | stevemar: i did, cause this is something i noticed vaguely but honestly i didn't dive into code.... | 15:14 |
| marekd | well, it's clearly a problem with new version of the lib | 15:15 |
| stevemar | https://github.com/idan/oauthlib/commit/14061935013ae20f58995dd2918c009166010bbc | 15:15 |
| stevemar | yeah, there was a change in the signature | 15:15 |
| breton | but changing the signature the first time was very stupid. | 15:15 |
| stevemar | breton: it happens, i guess... | 15:16 |
| stevemar | marekd i'll look at this after lunch, doing a few things in the morning | 15:17 |
| breton | stevemar: I am looking at it now | 15:17 |
| marekd | stevemar: thanks! | 15:17 |
| bknudson | there's no operators at the nova meetup. :( | 15:20 |
| marekd | are yu at the nova meetup ? | 15:21 |
| stevemar | marekd: yes, he is. the nova meetup is in rochester where bknudson lives :) | 15:21 |
| stevemar | same logic as for why dims_ was at keystone meetup | 15:22 |
| bknudson | dims_ is here too | 15:22 |
| marekd | stevemar: oh, cool! | 15:22 |
| * dims_ waves to stevemar and bknudson and marekd | 15:22 | |
| marekd | dims_: shall i assume you moved to Rochester ? :-) | 15:22 |
| dims_ | marekd: lol | 15:22 |
| marekd | or this implication doesn't work in that direction :D | 15:22 |
| dstanek | samueldmq: did you get the answers to your questions? | 15:22 |
| *** stevemar has quit IRC | 15:29 | |
| *** stevemar has joined #openstack-keystone | 15:29 | |
| *** ChanServ sets mode: +v stevemar | 15:29 | |
| *** diazjf has joined #openstack-keystone | 15:31 | |
| *** stevemar has quit IRC | 15:32 | |
| breton | err | 15:32 |
| breton | _validate_oauth_headers looks very weird. | 15:33 |
| *** nkinder has quit IRC | 15:33 | |
| *** jsavak has joined #openstack-keystone | 15:34 | |
| *** piyanai has quit IRC | 15:35 | |
| *** kiran-r has joined #openstack-keystone | 15:38 | |
| *** chmouel has quit IRC | 15:44 | |
| *** aix has joined #openstack-keystone | 15:46 | |
| *** jsavak has quit IRC | 15:46 | |
| *** jsavak has joined #openstack-keystone | 15:46 | |
| *** aix has quit IRC | 15:46 | |
| *** nkinder has joined #openstack-keystone | 15:49 | |
| *** bdossant has quit IRC | 15:50 | |
| *** chmouel has joined #openstack-keystone | 15:51 | |
| openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Fix the test with oauthlib https://review.openstack.org/204678 | 15:55 |
| *** aix has joined #openstack-keystone | 15:55 | |
| breton | the tests are going to fail, but what do you think of the idea? ^ | 15:55 |
| *** piyanai has joined #openstack-keystone | 15:57 | |
| breton | it seens that `parameters` where used not from requests_mock, but from oauthlib and then compared with parameters from oauthlib. Which is weird. | 15:57 |
| breton | *seems | 15:57 |
| *** TheIntern has quit IRC | 15:58 | |
| *** mylu has quit IRC | 16:00 | |
| *** topol has quit IRC | 16:02 | |
| *** lars1 has quit IRC | 16:03 | |
| *** lars1 has joined #openstack-keystone | 16:03 | |
| *** henrynash has quit IRC | 16:05 | |
| *** mylu has joined #openstack-keystone | 16:08 | |
| *** topol has joined #openstack-keystone | 16:10 | |
| *** ChanServ sets mode: +v topol | 16:10 | |
| *** geoffarnold has joined #openstack-keystone | 16:11 | |
| *** gyee has joined #openstack-keystone | 16:12 | |
| *** ChanServ sets mode: +v gyee | 16:12 | |
| *** piyanai has quit IRC | 16:13 | |
| *** geoffarnold has quit IRC | 16:13 | |
| breton | why do we need time_patcher in keystoneclient/tests/unit/utils.py ? | 16:14 |
| *** fhubik is now known as fhubik_afk | 16:15 | |
| *** jiaxi has quit IRC | 16:16 | |
| *** geoffarnold has joined #openstack-keystone | 16:16 | |
| openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Fix the test with oauthlib https://review.openstack.org/204678 | 16:18 |
| *** chenhong1 has quit IRC | 16:19 | |
| *** jistr has quit IRC | 16:19 | |
| *** iamjarvo has joined #openstack-keystone | 16:20 | |
| *** fhubik_afk is now known as fhubik | 16:21 | |
| *** piyanai has joined #openstack-keystone | 16:24 | |
| *** browne has quit IRC | 16:25 | |
| *** kiran-r has quit IRC | 16:26 | |
| *** ankita_wagh has joined #openstack-keystone | 16:26 | |
| *** lhcheng has joined #openstack-keystone | 16:26 | |
| *** ChanServ sets mode: +v lhcheng | 16:26 | |
| *** jsavak has quit IRC | 16:31 | |
| *** jsavak has joined #openstack-keystone | 16:33 | |
| *** kiran-r has joined #openstack-keystone | 16:38 | |
| *** _cjones_ has joined #openstack-keystone | 16:40 | |
| *** piyanai has quit IRC | 16:45 | |
| *** snapdey has joined #openstack-keystone | 16:45 | |
| *** piyanai has joined #openstack-keystone | 16:49 | |
| *** roxanaghe has joined #openstack-keystone | 16:51 | |
| openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Make OAuth testcase use actual request headers https://review.openstack.org/204678 | 16:52 |
| *** roxanaghe has quit IRC | 16:52 | |
| *** jasonsb has quit IRC | 16:53 | |
| *** roxanaghe has joined #openstack-keystone | 16:53 | |
| breton | stevemar: marekd: https://review.openstack.org/#/c/204678/3/keystoneclient/tests/unit/v3/test_oauth1.py what do you think? | 16:54 |
| *** kiran-r has quit IRC | 16:54 | |
| *** piyanai has quit IRC | 16:55 | |
| *** TheIntern has joined #openstack-keystone | 16:56 | |
| *** jsavak has quit IRC | 16:56 | |
| *** fhubik has quit IRC | 16:57 | |
| *** stevemar has joined #openstack-keystone | 16:57 | |
| *** ChanServ sets mode: +v stevemar | 16:57 | |
| *** ankita_wagh has quit IRC | 16:57 | |
| *** jsavak has joined #openstack-keystone | 17:01 | |
| stevemar | breton: thanks for the fix | 17:02 |
| samueldmq | dstanek: hi, no, actually I think the imports should be that way, but I'd like to confirm with you :) | 17:03 |
| *** piyanai has joined #openstack-keystone | 17:03 | |
| samueldmq | dstanek: to check if I what I think is correct | 17:03 |
| samueldmq | dstanek: sorry was afk (English class) | 17:03 |
| breton | stevemar: I'd really appreciate your review, because I am not sure that it's the right fix | 17:04 |
| breton | I will clean it up and provide a description now | 17:04 |
| *** zzzeek has quit IRC | 17:05 | |
| bknudson | breton: note that the change has to work on <1.0, too. | 17:05 |
| lhcheng | bknudson: how trivial should a patch be to decide that it does not require a bug to be opened? | 17:06 |
| lhcheng | bknudson: like to get your feedback on: https://review.openstack.org/#/c/203297/3 | 17:06 |
| stevemar | bknudson: looks like breton is suggesting to not use get_oauth_params, but rather split the string ourselves | 17:06 |
| bknudson | lhcheng: if a customer wouldn't see it then there's no need for a bug. | 17:07 |
| *** zzzeek has joined #openstack-keystone | 17:07 | |
| bknudson | lhcheng: since customers don't care where clean.py is then there's no need for a bug | 17:08 |
| breton | stevemar: the problem is that get_oauth_params did not do anything about auth_header | 17:08 |
| lhcheng | bknudson: cool, just to want to align the expectation. | 17:08 |
| lhcheng | bknudson: thanks | 17:08 |
| lhcheng | bknudson: I'll revert my vote | 17:08 |
| stevemar | lhcheng: yeah, but we should probably open one for creating the keystone.version module | 17:09 |
| lhcheng | stevemar: ah the last one in the chain, yeah it does update the docs | 17:10 |
| stevemar | lhcheng: yep | 17:10 |
| breton | stevemar: _validate_oauth_headers was supposed to check that auth_headers, which are what manager.create() sent to mocked url, are correct ones, and use oauth_client for comparison | 17:10 |
| stevemar | breton: correct | 17:10 |
| breton | stevemar: but instead it took parameters from oauth_client and compared it basically with themselves, but acquired as attributes | 17:11 |
| *** spandhe has joined #openstack-keystone | 17:12 | |
| breton | stevemar: note that auth_headers passed to _validate_oauth_headers was not used | 17:14 |
| *** marzif has joined #openstack-keystone | 17:15 | |
| *** piyanai has quit IRC | 17:16 | |
| *** ankita_wagh has joined #openstack-keystone | 17:17 | |
| *** aix has quit IRC | 17:20 | |
| *** browne has joined #openstack-keystone | 17:21 | |
| openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Make OAuth testcase use actual request headers https://review.openstack.org/204678 | 17:23 |
| *** e0ne has quit IRC | 17:24 | |
| *** snapdey has quit IRC | 17:24 | |
| *** marzif has quit IRC | 17:25 | |
| *** afazekas_ has quit IRC | 17:26 | |
| *** marzif has joined #openstack-keystone | 17:26 | |
| *** TheIntern has quit IRC | 17:27 | |
| *** snapdey has joined #openstack-keystone | 17:29 | |
| *** marzif has quit IRC | 17:31 | |
| *** marzif has joined #openstack-keystone | 17:32 | |
| *** jasonsb has joined #openstack-keystone | 17:38 | |
| stevemar | classic dolphm | 17:38 |
| *** mylu has quit IRC | 17:40 | |
| *** ericksonsantos has quit IRC | 17:42 | |
| openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Make OAuth testcase use actual request headers https://review.openstack.org/204678 | 17:43 |
| mfisch | morganfainberg, dolphm I'll have some numbers and graphs for you shortly, the tl;dr is that its not helping | 17:46 |
| mfisch | do I need anything besides that patch? I have a package built from yesterday plus I patched your patch on top of the code and restarted | 17:47 |
| morganfainberg | Then it isnt the event db table its the event processing code | 17:47 |
| morganfainberg | We knew that was a bottleneck before | 17:48 |
| *** mylu has joined #openstack-keystone | 17:48 | |
| mfisch | This might still help in the real world reduce deadlocks | 17:48 |
| mfisch | in my test env there's not much going on | 17:48 |
| morganfainberg | Sure. | 17:48 |
| morganfainberg | Deadlock reduction = good | 17:48 |
| mfisch | esp in a globally replicated db | 17:49 |
| morganfainberg | But performance, known bad with the tree matcher. Our slowest tests are the tree thing. | 17:49 |
| morganfainberg | Tl;dr we need a new | 17:49 |
| morganfainberg | Matcher. | 17:49 |
| stevemar | something wrong with gerrit? | 17:49 |
| morganfainberg | stevemar: earlier today. | 17:49 |
| breton | stevemar: it is overloaded now I think | 17:49 |
| mfisch | there was an issue last night with gearman I think | 17:50 |
| morganfainberg | Shpuld be just slow due to recovering from icky earlier on. | 17:50 |
| *** roxanaghe has quit IRC | 17:50 | |
| stevemar | ah | 17:50 |
| *** snapdey has quit IRC | 17:50 | |
| stevemar | i haven't had issues until just now | 17:50 |
| *** TheIntern has joined #openstack-keystone | 17:51 | |
| *** rletrocquer has quit IRC | 17:51 | |
| *** snapdey has joined #openstack-keystone | 17:52 | |
| *** amickus has joined #openstack-keystone | 17:53 | |
| *** roxanaghe has joined #openstack-keystone | 17:55 | |
| *** jasonsb has quit IRC | 17:56 | |
| *** jasonsb_ has joined #openstack-keystone | 17:56 | |
| *** diazjf has quit IRC | 17:56 | |
| stevemar | breton: why remove the timestamp check? | 18:01 |
| mfisch | morganfainberg: I'm not clear on where you are storing the event that has the timestamp | 18:01 |
| mfisch | whats the mechanism there? | 18:01 |
| *** marzif has quit IRC | 18:02 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: test_base64utils works with py34 https://review.openstack.org/203853 | 18:02 |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Fix pemutils for py34 https://review.openstack.org/203892 | 18:02 |
| *** ericksonsantos has joined #openstack-keystone | 18:03 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Fix pemutils for py34 https://review.openstack.org/203892 | 18:03 |
| *** jasonsb has joined #openstack-keystone | 18:03 | |
| *** piyanai has joined #openstack-keystone | 18:04 | |
| *** Kennan has joined #openstack-keystone | 18:04 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Fix test_utils for py34 https://review.openstack.org/203896 | 18:04 |
| *** Kennan2 has quit IRC | 18:04 | |
| *** marzif has joined #openstack-keystone | 18:04 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Ensure database options registered for tests https://review.openstack.org/203900 | 18:04 |
| *** snapdey has quit IRC | 18:05 | |
| *** jasonsb_ has quit IRC | 18:07 | |
| *** marzif_ has joined #openstack-keystone | 18:07 | |
| bknudson | python3 changes ^ | 18:08 |
| *** marzif has quit IRC | 18:11 | |
| *** alex_xu has quit IRC | 18:11 | |
| *** alex_xu has joined #openstack-keystone | 18:13 | |
| *** woodster_ has joined #openstack-keystone | 18:14 | |
| openstackgerrit | Henrique Truta proposed openstack/keystone: Add is_domain field in Project Table https://review.openstack.org/157427 | 18:15 |
| *** marzif_ has quit IRC | 18:19 | |
| *** diazjf has joined #openstack-keystone | 18:19 | |
| openstackgerrit | Deepti Ramakrishna proposed openstack/keystone: Reuse token_ref fetched in AuthContextMiddleware. https://review.openstack.org/190863 | 18:21 |
| openstackgerrit | Henrique Truta proposed openstack/keystone: Change project name constraints https://review.openstack.org/158372 | 18:25 |
| *** piyanai has quit IRC | 18:33 | |
| *** piyanai has joined #openstack-keystone | 18:35 | |
| *** ayoung has quit IRC | 18:36 | |
| *** iamjarvo has quit IRC | 18:41 | |
| *** piyanai has quit IRC | 18:42 | |
| *** dims_ has quit IRC | 18:42 | |
| openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Make OAuth testcase use actual request headers https://review.openstack.org/204678 | 18:44 |
| breton | stevemar: because the timestamp is not passed in actual request | 18:45 |
| mfisch | morganfainberg: no measurable perf impact, but I think it's still useful to not call DELETE so much | 18:45 |
| *** diegoadolfo has joined #openstack-keystone | 18:45 | |
| *** e0ne has joined #openstack-keystone | 18:45 | |
| stevemar | breton: nice patch ;) | 18:46 |
| breton | stevemar: it is generated by oauthlib and is a timestamp, not what we passed before | 18:46 |
| stevemar | breton: mention that in the commit msg | 18:46 |
| breton | stevemar: already there | 18:46 |
| stevemar | breton: sweet | 18:46 |
| *** piyanai has joined #openstack-keystone | 18:47 | |
| *** dims_ has joined #openstack-keystone | 18:47 | |
| lbragstad | morganfainberg: do you want this proposed for a stable freeze exception? https://review.openstack.org/#/c/186376/ | 18:49 |
| diegoadolfo | lbragstad, Hi Lance | 18:50 |
| lbragstad | diegoadolfo: hey | 18:50 |
| diegoadolfo | lbragstad, you would have the time to look me the bug 1474490 | 18:51 |
| openstack | bug 1474490 in Keystone "keystone.tests.unit.common.test_notifications.NotificationsTestCase fails in isolation" [Low,Triaged] https://launchpad.net/bugs/1474490 - Assigned to Diego Adolfo (diegoado) | 18:51 |
| diegoadolfo | lbragstad, Link -> https://bugs.launchpad.net/keystone/+bug/1474490 | 18:51 |
| lbragstad | diegoadolfo: are you attempting to fix it? | 18:53 |
| diegoadolfo | lbragstad, yes | 18:53 |
| diegoadolfo | lbragstad, a few hours | 18:54 |
| lbragstad | diegoadolfo: can you recreate it? | 18:54 |
| lbragstad | with the latest master branch? | 18:55 |
| diegoadolfo | lbragstad, yes | 18:57 |
| lbragstad | diegoadolfo: that trace looks like an import order issue | 18:58 |
| mylu | Hi I'm working on bi-direction k2k for the next step of MOC federation. I see a 401 Unauthorized: could not map user error. can anyone help me with that? | 18:58 |
| mylu | keystone.log in SP shows keystone.contrib.federation.utils [-] identity_values: []. and that explains why it couldn't map user. And my mapped_proproties: : {'group_ids': [], 'user': {'domain': {'id': 'Federated'}, 'type': 'ephemeral'},'group_names': []} | 19:01 |
| diegoadolfo | lbragstad, I found a solution | 19:02 |
| diegoadolfo | lbragstad, What is deleting the following lines | 19:03 |
| diegoadolfo | lbragstad, fixture = self.useFixture(config_fixture.Config(CONF)) | 19:03 |
| diegoadolfo | lbragstad, fixture.config(rpc_backend='fake', notification_driver=['fake']) | 19:04 |
| diegoadolfo | lbragstad, the setup NotificationsTestCase class | 19:05 |
| diegoadolfo | lbragstad, with that all tests are still going and the simple test of this class also passes | 19:07 |
| lbragstad | diegoadolfo: can you propose a patch? it will be easier to iterate over | 19:07 |
| *** iamjarvo has joined #openstack-keystone | 19:07 | |
| diegoadolfo | lbragstad, ok | 19:07 |
| diegoadolfo | lbragstad, I will do that now | 19:08 |
| lbragstad | awesome, thanks! | 19:08 |
| diegoadolfo | lbragstad, Thank you for helping me | 19:09 |
| stevemar | keystoners: assemble to unbreak the keystoneclient gate! https://review.openstack.org/#/c/204678/ | 19:09 |
| lbragstad | diegoadolfo: no problem, it will be easier once you have a review up | 19:09 |
| stevemar | lbragstad: dstanek dolphm ^ | 19:10 |
| *** pauloewerton has joined #openstack-keystone | 19:10 | |
| dstanek | stevemar: looking | 19:12 |
| dstanek | stevemar: breton: why remove the timestamp? | 19:14 |
| *** topol has quit IRC | 19:15 | |
| *** henrynash has joined #openstack-keystone | 19:15 | |
| *** ChanServ sets mode: +v henrynash | 19:15 | |
| *** amakarov is now known as amakarov_away | 19:15 | |
| stevemar | dstanek: refer to commit msg | 19:16 |
| *** Guest4324 has joined #openstack-keystone | 19:17 | |
| *** jdandrea has left #openstack-keystone | 19:18 | |
| *** afazekas has joined #openstack-keystone | 19:19 | |
| openstackgerrit | Merged openstack/keystone: Adding Documentation for Mapping Combinations https://review.openstack.org/192850 | 19:19 |
| dstanek | stevemar: odd | 19:20 |
| *** iamjarvo has quit IRC | 19:20 | |
| stevemar | diazjf: your first keystone commit!!!!!!!!!!!!!! | 19:20 |
| dstanek | diazjf: nice | 19:20 |
| stevemar | diazjf: Merged openstack/keystone: Adding Documentation for Mapping Combinations https://review.openstack.org/192850 YAY | 19:20 |
| stevemar | print that out and frame it | 19:21 |
| dstanek | stevemar: i think mine was a 1 letter doc change while in the airport on the way to interview with Rax | 19:21 |
| stevemar | dstanek: mine: https://review.openstack.org/#/c/18054/ | 19:22 |
| stevemar | hey mordred had +2 on keystone at that time | 19:22 |
| stevemar | dstanek: diazjf definitely picked a harder first patch! | 19:23 |
| openstackgerrit | Merged openstack/keystone: Correct spacing in ``mapping_combinations.rst`` https://review.openstack.org/204464 | 19:23 |
| *** topol has joined #openstack-keystone | 19:24 | |
| *** ChanServ sets mode: +v topol | 19:24 | |
| stevemar | dstanek's first: https://review.openstack.org/#/c/43799/ | 19:24 |
| *** amickus has quit IRC | 19:24 | |
| dstanek | good stuff | 19:24 |
| stevemar | dstanek: solid first patch | 19:25 |
| dstanek | i have to admit the tooling was intimidating at first...so much stuff to know before submitting a patch | 19:25 |
| diazjf | stevemar, thanks :) | 19:27 |
| *** topol has quit IRC | 19:28 | |
| stevemar | dstanek: agreed | 19:31 |
| stevemar | diazjf: frame it | 19:31 |
| stevemar | dstanek: the ksc oauthlib patch make sense? | 19:31 |
| stevemar | oh you already +2/+Aed ;) | 19:31 |
| dstanek | stevemar: yes already +A | 19:31 |
| dstanek | now jenkins just has to do it's job | 19:32 |
| *** jsavak has quit IRC | 19:34 | |
| *** jsavak has joined #openstack-keystone | 19:35 | |
| *** topol has joined #openstack-keystone | 19:38 | |
| *** ChanServ sets mode: +v topol | 19:38 | |
| openstackgerrit | Henrique Truta proposed openstack/keystone: Add is_domain field in Project Table https://review.openstack.org/157427 | 19:39 |
| *** ayoung has joined #openstack-keystone | 19:43 | |
| *** ChanServ sets mode: +v ayoung | 19:43 | |
| henrynash | there are two specs that we agreed should go in on yesterday’s IRC meeting: https://review.openstack.org/#/c/200624/ and https://review.openstack.org/#/c/200434/ - keen to get those specs merged asap…so if anyone can add comments or +1/+2s, please go ahead :-) | 19:47 |
| *** jasonsb has quit IRC | 19:47 | |
| *** jasonsb has joined #openstack-keystone | 19:49 | |
| openstackgerrit | Diego Adolfo proposed openstack/keystone: NotificationsTestCase running in isolation https://review.openstack.org/204739 | 19:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/204432 | 19:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/204432 | 19:51 |
| morganfainberg | lbragstad: can either freeze exception it or grt it in post freeze | 19:54 |
| morganfainberg | lbragstad: your call on how much effort you want to put in. I dont think itll make a huge difference either way. | 19:55 |
| *** snapdey has joined #openstack-keystone | 19:55 | |
| *** iamjarvo has joined #openstack-keystone | 19:56 | |
| *** ankita_w_ has joined #openstack-keystone | 19:59 | |
| *** ankita_wagh has quit IRC | 19:59 | |
| *** ankita_wagh has joined #openstack-keystone | 20:00 | |
| *** ankita_w_ has quit IRC | 20:00 | |
| dolphm | morganfainberg: FYI, i suspect lbragstad is already AFK for the week | 20:03 |
| morganfainberg | Then not a worry. Will just ride out freeze on that patch | 20:03 |
| * morganfainberg sees little benefit to fighting for stable freeze exceptions unless it is right before eol | 20:04 | |
| openstackgerrit | Ian Cordasco proposed openstack/python-keystoneclient: Set reasonable defaults for TCP Keep-Alive https://review.openstack.org/204741 | 20:04 |
| morganfainberg | If the patch matters that much, the distributions will grab it anyway. | 20:04 |
| *** marzif_ has joined #openstack-keystone | 20:05 | |
| lbragstad | morganfainberg: do you have a preference/ | 20:05 |
| bknudson | morganfainberg: I'm grabbing the ldap fix right now! | 20:06 |
| dolphm | sigmavirus24: nice ^ | 20:06 |
| morganfainberg | lbragstad: nope. Really up to you on how much work you want to put in ^^ see my last statement | 20:06 |
| sigmavirus24 | dolphm: file a bug, fix a bug =P | 20:06 |
| morganfainberg | bknudson: my point exactly | 20:06 |
| dolphm | sigmavirus24: according to my metrics, you're not measurably improving openstack, sir. | 20:06 |
| sigmavirus24 | dolphm: too bad | 20:07 |
| sigmavirus24 | I'm apparently in the 20s for reviews across openstack | 20:07 |
| sigmavirus24 | (according to stackalytics) | 20:07 |
| morganfainberg | I hear you have to open bugs and expect someone else to fix it, and whine about the fix being wrong to improve openstack >.> | 20:07 |
| bknudson | nobody counts reviews | 20:07 |
| dolphm | sigmavirus24: nice | 20:07 |
| morganfainberg | (That wasnt directed at anyone particular, most people dont whine) | 20:08 |
| dolphm | morganfainberg: whining is how best motivate the PTL | 20:09 |
| *** TheIntern has quit IRC | 20:13 | |
| *** jasonsb has quit IRC | 20:14 | |
| *** jasonsb has joined #openstack-keystone | 20:14 | |
| dstanek | henrynash: just added some comments on the clarification spec review | 20:17 |
| mfisch | dolphm: do you know why revoke driver is in contrib? | 20:21 |
| sigmavirus24 | morganfainberg: I'd rather sit around all day and fix bugs in openstack than open them and then fix them | 20:21 |
| sigmavirus24 | But infra pinged me about this because it's related to requests so, sorry =P | 20:21 |
| *** diegoadolfo has quit IRC | 20:24 | |
| *** e0ne has quit IRC | 20:26 | |
| raildo | dstanek: I just answered some questions in this spec, just to speed up the review process | 20:26 |
| dstanek | raildo: thanks! do you know about the resources question? | 20:28 |
| openstackgerrit | Merged openstack/keystone: Fix docs in federation.routers https://review.openstack.org/203572 | 20:28 |
| raildo | dstanek: yes, we can have resouces in a project.is_domain=True | 20:30 |
| raildo | dstanek: but you must need grant a role assingment to a user be able to get a project scoped token | 20:30 |
| dstanek | raildo: that review explicitly called out that the project will act as a domain, but not necessarily that it would still act as a project | 20:32 |
| morganfainberg | mfisch: because it was an "extension" before. We're slowly cleaning that up. | 20:32 |
| *** snapdey has quit IRC | 20:33 | |
| mfisch | morganfainberg: thx | 20:33 |
| raildo | dstanek: right... I'll talk with henrynash, we can add some explanation about it | 20:33 |
| raildo | just to be more clear | 20:34 |
| *** mestery has quit IRC | 20:42 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/204432 | 20:42 |
| *** jsavak has quit IRC | 20:43 | |
| *** jsavak has joined #openstack-keystone | 20:43 | |
| openstackgerrit | Henrique Truta proposed openstack/keystone: Change project name constraints https://review.openstack.org/158372 | 20:44 |
| *** henrynash has quit IRC | 20:44 | |
| *** snapdey has joined #openstack-keystone | 20:47 | |
| *** jsavak has quit IRC | 20:47 | |
| *** ankita_w_ has joined #openstack-keystone | 20:47 | |
| *** stevemar has quit IRC | 20:48 | |
| *** stevemar has joined #openstack-keystone | 20:49 | |
| *** ChanServ sets mode: +v stevemar | 20:49 | |
| *** ankita_wagh has quit IRC | 20:51 | |
| *** hrou has quit IRC | 20:53 | |
| *** stevemar has quit IRC | 20:53 | |
| breton | what does pep8 want? http://logs.openstack.org/78/204678/6/gate/gate-python-keystoneclient-pep8/daebddc/console.html | 20:54 |
| dstanek | breton: friends | 20:55 |
| dstanek | breton: it looks like maybe there was a problem with flake8? doesn't look like it found any issues in the code | 20:56 |
| breton | hm, my local tox -e pep8 says that there is unused import | 20:56 |
| breton | I wonder why gate doesn't. | 20:57 |
| openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Make OAuth testcase use actual request headers https://review.openstack.org/204678 | 20:58 |
| breton | dstanek: ^ made pep8 a little happier, please +2 again | 20:59 |
| dstanek | breton: done | 21:00 |
| pauloewerton | hi there. question about keystoneauth | 21:01 |
| pauloewerton | I believe that @missingproperty decorator is incorrectly applied here: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/access.py#L602 | 21:02 |
| pauloewerton | can anyone confirm? | 21:02 |
| *** jasonsb has quit IRC | 21:03 | |
| dstanek | pauloewerton: why do you say that? | 21:03 |
| *** jasonsb has joined #openstack-keystone | 21:03 | |
| pauloewerton | dstanek, other internal properties like _user or _project are marked as @property | 21:04 |
| pauloewerton | also, I'm having issues trying to get domain_id property, for example | 21:05 |
| dstanek | pauloewerton: just quickly looking at the code i don't think it would matter if _domain was @property or @missingproperty if it's failing in _user | 21:07 |
| *** shaleh has quit IRC | 21:08 | |
| pauloewerton | dstanek, it fails when I try to get properties domain_id and domain_name | 21:08 |
| dstanek | pauloewerton: if it was @property you'd just get a keyerror instead of a typeerror | 21:09 |
| dstanek | pauloewerton: oops i meant domain_id and typed _user | 21:09 |
| pauloewerton | I get a keyerror when using @missingproperty and no error at all using @property in _domain | 21:10 |
| *** raildo has quit IRC | 21:10 | |
| dstanek | pauloewerton: i'm not sure how property works then. missingproperty seems to only do something different (return None) if the function fails. since it's the same function called by property i have no idea what's happening. i'd have to get together some test cases to find out. | 21:12 |
| dstanek | pauloewerton: so you actually get back a valid domain when @property is used? | 21:13 |
| pauloewerton | dstanek, I believe so, but I would have to look it up more carefully | 21:14 |
| pauloewerton | but I'm almost sure it returns a valid domain or None, as it was supposed to | 21:15 |
| dstanek | pauloewerton: i would expect you to see a TypeError when using @missingproperty since it defaults to None and domain_id can't handle that | 21:15 |
| pauloewerton | yeah, sorry I get TypeError using @missingproperty not keyerror as I told earlier | 21:16 |
| *** pnavarro has quit IRC | 21:16 | |
| dstanek | pauloewerton: I would only expect a KeyError is a dict is being returned that isn't valid or if you changed @missingproperty to @property you'd also get it | 21:17 |
| *** david-lyle has quit IRC | 21:17 | |
| dstanek | pauloewerton: so i do think there is a bug, but I'm not convinced it's because of the @missingproperty because either way domain_id needs to be smarter | 21:17 |
| dstanek | pauloewerton: can you file a bug? | 21:17 |
| *** jsavak has joined #openstack-keystone | 21:17 | |
| pauloewerton | dstanek, I was going to do just that and submit a fix, bug wanted to confirm first | 21:18 |
| pauloewerton | but* | 21:20 |
| *** TheIntern has joined #openstack-keystone | 21:21 | |
| *** iamjarvo_ has joined #openstack-keystone | 21:22 | |
| *** iamjarvo_ has quit IRC | 21:22 | |
| *** TheIntern has quit IRC | 21:22 | |
| *** iamjarvo_ has joined #openstack-keystone | 21:22 | |
| *** TheIntern has joined #openstack-keystone | 21:23 | |
| dstanek | pauloewerton: i'm not really sure what the fix should be...probably just fixing the things that use _domain? anyway, submit some tests that break without your fix | 21:24 |
| *** iamjarvo has quit IRC | 21:25 | |
| *** marzif_ has quit IRC | 21:25 | |
| pauloewerton | dstanek, I was thinking of just switching decorators from @missingproperty to @property. seems consistent with the other internal properties | 21:26 |
| dstanek | pauloewerton: but that doesn't fix the bug | 21:26 |
| pauloewerton | dstanek, but no problem, I wil file the bug | 21:26 |
| *** dan_ has joined #openstack-keystone | 21:27 | |
| dstanek | it just goes from TypeError to KeyError - the question is what should the behavior be? an exception or a default value? and if an exception...which one? | 21:27 |
| *** dan_ is now known as Guest56855 | 21:27 | |
| *** henrynash has joined #openstack-keystone | 21:29 | |
| *** ChanServ sets mode: +v henrynash | 21:29 | |
| *** snapdey has quit IRC | 21:29 | |
| pauloewerton | dstanek, I see. I'll try to exercise the bug in a test | 21:30 |
| *** e0ne has joined #openstack-keystone | 21:30 | |
| *** hrou has joined #openstack-keystone | 21:30 | |
| *** iamjarvo_ has quit IRC | 21:31 | |
| *** snapdey has joined #openstack-keystone | 21:34 | |
| openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Remove unused time_patcher https://review.openstack.org/204771 | 21:35 |
| *** iamjarvo has joined #openstack-keystone | 21:36 | |
| *** diazjf has left #openstack-keystone | 21:41 | |
| openstackgerrit | Merged openstack/keystone: Refactor websso ``origin`` validation https://review.openstack.org/203525 | 21:42 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/204300 | 21:43 |
| openstackgerrit | henry-nash proposed openstack/keystone-specs: Move inherited assignments to core, and support new inheritance rules https://review.openstack.org/200434 | 21:44 |
| *** mylu has quit IRC | 21:47 | |
| *** dims_ has quit IRC | 21:53 | |
| openstackgerrit | henry-nash proposed openstack/keystone-specs: Clarify project hierachy and parent usage within the API https://review.openstack.org/200624 | 21:54 |
| *** edmondsw has quit IRC | 21:54 | |
| *** e0ne has quit IRC | 21:58 | |
| openstackgerrit | Merged openstack/keystoneauth: Updated from global requirements https://review.openstack.org/204371 | 21:59 |
| openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Remove unused time_patcher https://review.openstack.org/204771 | 22:01 |
| *** tsymanczyk has quit IRC | 22:01 | |
| *** Kennan has quit IRC | 22:02 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:03 | |
| *** Kennan has joined #openstack-keystone | 22:03 | |
| *** gordc has quit IRC | 22:06 | |
| *** tsymanczyk has joined #openstack-keystone | 22:06 | |
| *** htruta_ has joined #openstack-keystone | 22:07 | |
| *** bknudson has quit IRC | 22:08 | |
| *** nkinder has quit IRC | 22:10 | |
| *** jsavak has quit IRC | 22:12 | |
| *** spandhe has quit IRC | 22:15 | |
| pauloewerton | dstanek, link for the bug https://bugs.launchpad.net/keystoneauth/+bug/1477327. can you please take a look when you have some time? | 22:18 |
| openstack | Launchpad bug 1477327 in keystoneauth "TypeError raised when trying to get domain properties in AccessInfo object" [Undecided,New] | 22:18 |
| mfisch | Can someone tell me which of the memcache server list settings are used? Both? I see memcache/servers and cache/memcache_servers | 22:18 |
| pauloewerton | dstanek, I've written a really simple test case, but that reports the exact error I'm getting | 22:18 |
| *** iamjarvo has quit IRC | 22:20 | |
| *** WormMan has left #openstack-keystone | 22:23 | |
| *** henrynash has quit IRC | 22:25 | |
| breton | mfisch: both | 22:29 |
| breton | mfisch: one for cache and one for other stuff | 22:29 |
| mfisch | "other stuff"? | 22:29 |
| breton | mfisch: tokens | 22:32 |
| breton | looks like we removed everything else. | 22:33 |
| breton | mfisch: so yeah, only tokens. | 22:33 |
| breton | why do we have fixtures in keystoneauth outside of tests? | 22:40 |
| *** TheIntern has quit IRC | 22:41 | |
| *** piyanai has quit IRC | 22:45 | |
| *** tsymanczyk has quit IRC | 22:46 | |
| *** piyanai has joined #openstack-keystone | 22:46 | |
| *** piyanai has quit IRC | 22:47 | |
| *** tsymancz1k has joined #openstack-keystone | 22:51 | |
| openstackgerrit | Eric Brown proposed openstack/keystoneauth: py34 not py33 is tested and supported https://review.openstack.org/201088 | 22:57 |
| *** spandhe has joined #openstack-keystone | 23:02 | |
| breton | pauloewerton: it seems that the default fixture token is not domain-scoped | 23:02 |
| breton | pauloewerton: you need to provide domain_id or domain_name to make it scoped-token | 23:02 |
| breton | *to make it domain-scoped | 23:02 |
| *** iamjarvo has joined #openstack-keystone | 23:11 | |
| *** snapdey has quit IRC | 23:12 | |
| *** 77CAAEJLH has joined #openstack-keystone | 23:13 | |
| *** fangzhou has joined #openstack-keystone | 23:19 | |
| *** iamjarvo has quit IRC | 23:26 | |
| *** jasonsb has quit IRC | 23:27 | |
| *** Guest56855 has quit IRC | 23:29 | |
| *** roxanaghe has quit IRC | 23:31 | |
| dstanek | breton: i think that code is flawed | 23:37 |
| *** jecarey has quit IRC | 23:37 | |
| *** ankita_wagh has joined #openstack-keystone | 23:38 | |
| dstanek | pauloewerton: you can submit your test case as a review | 23:38 |
| dstanek | pauloewerton: but change your print to be an assertion of some sort | 23:39 |
| *** ankita_w_ has quit IRC | 23:41 | |
| openstackgerrit | Eric Brown proposed openstack/keystoneauth: py34 not py33 is tested and supported https://review.openstack.org/201088 | 23:42 |
| breton | dstanek: you think a token should be domain-scoped by default? | 23:49 |
| dstanek | breton: why do you say that? | 23:49 |
| *** jecarey has joined #openstack-keystone | 23:50 | |
| breton | dstanek: ok, i misunderstood you. What code if flawed? | 23:51 |
| dstanek | breton: i explain it here https://bugs.launchpad.net/keystoneauth/+bug/1477327 | 23:51 |
| openstack | Launchpad bug 1477327 in keystoneauth "TypeError raised when trying to get domain properties in AccessInfo object" [Low,Confirmed] | 23:51 |
| breton | oh | 23:53 |
| breton | ooh, I see a discussion above | 23:53 |
| *** rm_work is now known as rm_work|away | 23:53 | |
| breton | ok, thanks. | 23:53 |
| dstanek | np | 23:54 |
| *** jaosorior has quit IRC | 23:56 | |
| *** tsymancz1k is now known as tsymanczyk_ | 23:56 | |
| *** tsymanczyk_ is now known as tsymanczyk | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!