openstackgerrit | Roxana Gherle proposed openstack/keystone: Fernet 'expires' value loses 'ms' after validation https://review.openstack.org/210037 | 00:02 |
---|---|---|
*** piyanai has quit IRC | 00:04 | |
jamielennox | dolphm, lbragstad: how do we pass idp id from django_openstack_auth to keystone? | 00:12 |
jamielennox | i'm replying to the thread and at this point i'm concerned i'm missing something obvious | 00:13 |
*** sigmavirus24 is now known as sigmavirus24_awa | 00:14 | |
lbragstad | jamielennox: i'm not real sure | 00:16 |
lbragstad | jamielennox: wouldn't that be something the user would have to know? | 00:16 |
jamielennox | lbragstad: it would be something the user can select | 00:16 |
lbragstad | pull it out of a header? | 00:16 |
dolphm | jamielennox: it's part of the request URI | 00:18 |
dolphm | jamielennox: .../identity_providers/{idp_id}/protocol/{protocol_id} | 00:18 |
jamielennox | dolphm: that path is completely unused for websso | 00:18 |
dolphm | jamielennox: ah, i don't have any clue on websso | 00:19 |
jamielennox | i know this because i did a talk on it last weekend, and i wrote the spec https://review.openstack.org/#/c/199339/ because it's ridiculous that it's not used | 00:19 |
jamielennox | talk: https://youtu.be/YYzJdxI_g6g | 00:21 |
dolphm | jamielennox: oh, fun. | 00:21 |
*** geoffarnold has quit IRC | 00:23 | |
lbragstad | jamielennox: but if the user has to select it, doesn't that violate the public cloud case described on the ML? | 00:24 |
*** stevemar has joined #openstack-keystone | 00:25 | |
*** ChanServ sets mode: +v stevemar | 00:25 | |
jamielennox | lbragstad: currently the user selects a protocol like saml2, that redirects to keystone | 00:26 |
jamielennox | then there is this fuzzy out of keystone's control discovery process that lets the user actually select which real idp they want to use | 00:26 |
jamielennox | you could trim and show what you like there, but i've no idea how you know where that user came from to know what to show | 00:26 |
jamielennox | and Referrer is not an answer | 00:26 |
dolphm | jamielennox: ++ | 00:27 |
*** markvoelker has quit IRC | 00:27 | |
*** chlong has joined #openstack-keystone | 00:27 | |
*** markvoelker has joined #openstack-keystone | 00:28 | |
lbragstad | jamielennox: yeah, but selecting the protocol means the you direct to one IdP per protocol, right? what happens when you have two IdPs that speak saml2? | 00:28 |
* lbragstad starts busting out the rookie questions | 00:28 | |
jamielennox | lbragstad: no - i feel that's the lightbulb question | 00:29 |
*** stevemar has quit IRC | 00:29 | |
jamielennox | like... wait, what? | 00:29 |
lbragstad | :) | 00:29 |
lbragstad | umm... guys? | 00:29 |
jamielennox | ok, somewhat heated reply sent to list | 00:30 |
dolphm | jamielennox: which thread? | 00:30 |
jamielennox | the federated login one | 00:30 |
jamielennox | i don't know which arm, zimbra doesn't show that | 00:30 |
dolphm | jamielennox: got it | 00:31 |
*** iamjarvo has joined #openstack-keystone | 00:33 | |
jamielennox | lbragstad: to somewhat answer the question IdPs now have a remote_ids parameter so you can tell where you received a login saml assertion from to map it back into keystone, but you have to manage what gets shown out of band | 00:33 |
lbragstad | ah, gotcha | 00:34 |
*** narengan has joined #openstack-keystone | 00:35 | |
lbragstad | jamielennox: nice talk, i'm saving that | 00:37 |
*** iamjarvo has quit IRC | 00:37 | |
jamielennox | i feel like ~3 people in the audience actually understood it | 00:38 |
jamielennox | but i was told not to do another high level federation talk | 00:38 |
dolphm | if i had any means of sound, i'd be doing more than watching your lips move around | 00:38 |
lbragstad | jamielennox: as long as you record it, others can come back when they're ready to figure it out | 00:38 |
dolphm | lbragstad: ++ | 00:39 |
jamielennox | yep | 00:39 |
jamielennox | i mean in that case i only set up one idp which doesn't really show this problem because you've no need to figure out which IdP you want | 00:40 |
*** ankita_w_ has joined #openstack-keystone | 00:44 | |
*** ankita_wagh has quit IRC | 00:44 | |
*** jasondotstar has quit IRC | 00:50 | |
*** jasondotstar has joined #openstack-keystone | 00:52 | |
*** dims_ has quit IRC | 00:53 | |
*** jasondotstar has quit IRC | 00:56 | |
*** dims_ has joined #openstack-keystone | 01:09 | |
*** dims__ has joined #openstack-keystone | 01:15 | |
*** dims__ has quit IRC | 01:16 | |
*** dims_ has quit IRC | 01:17 | |
*** dims_ has joined #openstack-keystone | 01:18 | |
*** ankita_w_ has quit IRC | 01:18 | |
*** jasonsb has joined #openstack-keystone | 01:24 | |
*** stevemar has joined #openstack-keystone | 01:26 | |
*** ChanServ sets mode: +v stevemar | 01:26 | |
*** jasondotstar has joined #openstack-keystone | 01:27 | |
*** stevemar has quit IRC | 01:30 | |
*** dims__ has joined #openstack-keystone | 01:42 | |
*** dims_ has quit IRC | 01:44 | |
*** btully has quit IRC | 01:45 | |
*** hrou has joined #openstack-keystone | 01:50 | |
*** dims_ has joined #openstack-keystone | 01:54 | |
*** elmiko has quit IRC | 01:55 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Remove deprecated methods from assignment.Manager https://review.openstack.org/210174 | 01:56 |
*** dims__ has quit IRC | 01:56 | |
*** stevemar has joined #openstack-keystone | 01:57 | |
*** ChanServ sets mode: +v stevemar | 01:57 | |
*** elmiko_ has joined #openstack-keystone | 01:58 | |
stevemar | lhcheng: dude, thanks so much for looking at the osc stuff :) | 02:21 |
lhcheng | stevemar: no problem, ship it :) | 02:23 |
stevemar | lhcheng: yeah, gonna start trying it out now, all the volume commands, and then probably approve it | 02:24 |
lhcheng | stevemar: took me awhile to figure out the volume v2 setting.. OS_VOLUME_API_VERSION=2 | 02:26 |
lhcheng | just in case you might need it too ^ :) | 02:27 |
lhcheng | stevemar: I'm going to grab dinner | 02:28 |
stevemar | lhcheng: small tweaks on the set/unset commands | 02:28 |
lhcheng | ttyl | 02:28 |
stevemar | oops | 02:28 |
stevemar | i'll make the change | 02:28 |
stevemar | go eat! | 02:28 |
lhcheng | okay :) | 02:28 |
lhcheng | thanks | 02:28 |
lhcheng | later! | 02:28 |
*** lhcheng has quit IRC | 02:29 | |
*** markvoelker has quit IRC | 02:30 | |
*** davechen has joined #openstack-keystone | 02:32 | |
*** _cjones_ has joined #openstack-keystone | 02:36 | |
*** _cjones_ has quit IRC | 02:37 | |
*** _cjones_ has joined #openstack-keystone | 02:37 | |
*** davechen1 has joined #openstack-keystone | 02:45 | |
*** davechen has quit IRC | 02:45 | |
*** davechen1 is now known as davechen | 02:46 | |
openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Have the enforcer have its own file cache https://review.openstack.org/209656 | 02:48 |
*** davechen1 has joined #openstack-keystone | 02:49 | |
*** topol has joined #openstack-keystone | 02:51 | |
*** ChanServ sets mode: +v topol | 02:51 | |
*** hakimo_ has joined #openstack-keystone | 02:52 | |
*** davechen has quit IRC | 02:52 | |
*** hakimo has quit IRC | 02:55 | |
*** narengan has quit IRC | 02:56 | |
*** piyanai has joined #openstack-keystone | 02:56 | |
*** narengan has joined #openstack-keystone | 02:57 | |
*** davechen has joined #openstack-keystone | 02:58 | |
*** davechen1 has quit IRC | 03:00 | |
*** narengan has quit IRC | 03:01 | |
*** topol has quit IRC | 03:06 | |
openstackgerrit | Jamie Lennox proposed openstack/python-keystoneclient-kerberos: Disable optional authentication for plugin https://review.openstack.org/188329 | 03:29 |
*** kun_huang has joined #openstack-keystone | 03:29 | |
openstackgerrit | Jamie Lennox proposed openstack/python-keystoneclient-kerberos: Federated Kerberos plugin https://review.openstack.org/173558 | 03:29 |
kun_huang | guys, will keystoneclient support v3 on command line? | 03:29 |
jamielennox | kun_huang: no | 03:30 |
*** markvoelker has joined #openstack-keystone | 03:30 | |
jamielennox | you should use openstackclient | 03:30 |
*** lhcheng has joined #openstack-keystone | 03:30 | |
*** ChanServ sets mode: +v lhcheng | 03:30 | |
*** roxanaghe has quit IRC | 03:32 | |
kun_huang | jamielennox: keystoneclient provide python api only, and openstackclient focus on command line support now? | 03:32 |
stevemar | kun_huang: yes sir! | 03:32 |
kun_huang | stevemar: got it :) | 03:32 |
stevemar | kun_huang: openstackclient has full support for keystone v2 and v3, and some v3 extensions too! | 03:32 |
stevemar | its also got support for cinder and nova commands :) | 03:33 |
jamielennox | stevemar pulls out the elevator pitch | 03:34 |
stevemar | jamielennox: it's oh-so-wonderful! | 03:35 |
*** markvoelker has quit IRC | 03:35 | |
kun_huang | stevemar: thank you :) | 03:36 |
*** zzzeek has quit IRC | 03:38 | |
*** kun_huang has left #openstack-keystone | 03:39 | |
*** _cjones_ has quit IRC | 03:40 | |
*** vivekd has joined #openstack-keystone | 03:48 | |
*** boris-42 has quit IRC | 03:50 | |
*** ankita_wagh has joined #openstack-keystone | 03:53 | |
*** dims_ has quit IRC | 04:04 | |
*** ankita_wagh has quit IRC | 04:09 | |
*** ankita_wagh has joined #openstack-keystone | 04:09 | |
*** jasondotstar has quit IRC | 04:09 | |
*** gyee has quit IRC | 04:13 | |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Move AccessInfo objects into own module https://review.openstack.org/209311 | 04:18 |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Make missingproperty private https://review.openstack.org/209317 | 04:18 |
*** kiran-r has joined #openstack-keystone | 04:34 | |
*** darrenc is now known as darrenc_afk | 04:35 | |
*** _hrou_ has joined #openstack-keystone | 04:38 | |
*** jdandrea has quit IRC | 04:39 | |
*** hrou has quit IRC | 04:40 | |
*** piyanai has quit IRC | 04:43 | |
stevemar | hey jamielennox, interested in taking a high level look at an osc patch | 04:44 |
stevemar | ? | 04:44 |
jamielennox | stevemar: sure | 04:44 |
stevemar | jamielennox: https://review.openstack.org/186720 | 04:44 |
stevemar | its for logging all commands to a file | 04:44 |
jamielennox | stevemar: interesting idea | 04:44 |
stevemar | jamielennox: yeah, it has merit, dtroyer got them to change it from optional CLI args to "please just use OCC" | 04:45 |
jamielennox | stevemar: i kind of think cmd might be more approrpriate | 04:48 |
jamielennox | :) | 04:48 |
stevemar | jamielennox why must you and dtroyer be on polar opposites on so many issues :) | 04:48 |
jamielennox | not likely you are going to want to log everything all the time in like an OCC kind of way | 04:48 |
stevemar | the --log-file option still works | 04:48 |
*** Nirupama has joined #openstack-keystone | 04:51 | |
jamielennox | i can see a reason for it to be in occ | 04:51 |
jamielennox | generally it seems ok | 04:53 |
jamielennox | could be simpler | 04:54 |
jamielennox | you don't need to do a bunch of checking, you only need to check log_file etc when you add handlers | 04:54 |
jamielennox | but meh | 04:54 |
*** navid__ has quit IRC | 04:59 | |
stevemar | jamielennox: just the attitude i was looking for! 'meh' | 04:59 |
jamielennox | stevemar: :) | 05:00 |
*** darrenc_afk is now known as darrenc | 05:01 | |
*** lhcheng_ has joined #openstack-keystone | 05:03 | |
*** _kiran_ has joined #openstack-keystone | 05:06 | |
*** lhcheng has quit IRC | 05:06 | |
*** kiran-r has quit IRC | 05:07 | |
*** ankita_w_ has joined #openstack-keystone | 05:10 | |
*** ankita_wagh has quit IRC | 05:13 | |
*** _kiran_ has quit IRC | 05:16 | |
*** jasondotstar has joined #openstack-keystone | 05:16 | |
*** stevemar has quit IRC | 05:18 | |
*** stevemar has joined #openstack-keystone | 05:18 | |
*** ChanServ sets mode: +v stevemar | 05:18 | |
*** jasondotstar has quit IRC | 05:21 | |
*** dikonoor has joined #openstack-keystone | 05:24 | |
dikonoor | stevemar:Hi Steve | 05:24 |
stevemar | dikonoor: hey hey | 05:25 |
dikonoor | stevemar:I keep seeing the following deprecation warning in the keystone log >> Deprecated: keystone.contrib.endpoint_policy.routers.EndpointPolicyExtension is deprecated as of Liberty in favor of keystone.endpoint_policy.routers.Routers and may be removed in M. | 05:25 |
*** urulama has quit IRC | 05:25 | |
dikonoor | stevemar: https://review.openstack.org/#/c/171448/ seems to have added the deprecation | 05:25 |
*** urulama has joined #openstack-keystone | 05:25 | |
stevemar | dikonoor: yep, we're just moving it from keystone.contrib.endpoint_policy to keystone.endpoint_policy | 05:26 |
dikonoor | stevemar: but I believe the keystone paste file should have been updated accordingly so that this warning doesn't popup | 05:26 |
stevemar | ah | 05:26 |
stevemar | it does that always eh? | 05:26 |
dikonoor | stevemar:https://github.com/openstack/keystone/blob/master/etc/keystone-paste.ini#L46 | 05:26 |
stevemar | let me change that | 05:26 |
dikonoor | stevemar: do you want me to open a LP bug ? | 05:27 |
stevemar | dikonoor: blame jamielennox for that one :) | 05:27 |
stevemar | dikonoor: sure | 05:27 |
jamielennox | what | 05:27 |
dikonoor | stevemar:ok..Let me open a bug and ping you the number here | 05:27 |
jamielennox | now what have i done | 05:27 |
stevemar | jamielennox: broke everything | 05:27 |
dikonoor | stevemar: there might be other entries in the paste file that points to the old stuff | 05:27 |
stevemar | dikonoor: irc will automagically tell us the number | 05:28 |
dikonoor | stevemar:ok cool..hold on then | 05:28 |
stevemar | dikonoor: we plan on moving a few things around, so let me know if you see any other warnings | 05:28 |
jamielennox | did i get that wrong? that was ages ago | 05:29 |
stevemar | jamielennox: was in L1 i think | 05:30 |
jamielennox | yea, i was hoping if i showed how someone else would pick up the others | 05:31 |
*** markvoelker has joined #openstack-keystone | 05:31 | |
stevemar | jamielennox: i plan on it | 05:32 |
stevemar | just been busy with other stuff-n-things | 05:32 |
jamielennox | i saw someone else do one | 05:32 |
stevemar | but my schedule is finally opening up a bit, | 05:32 |
jamielennox | stevemar: right, always more things to od | 05:32 |
stevemar | yeah, fernando, picked it up | 05:32 |
stevemar | i'm helping to train him, but he's on another team | 05:33 |
stevemar | dikonoor: trouble opening the bug? i've got the fix ready to go :) | 05:33 |
*** yottatsa has joined #openstack-keystone | 05:34 | |
dikonoor | stevemar:https://bugs.launchpad.net/keystone/+bug/1482500 | 05:34 |
openstack | Launchpad bug 1482500 in Keystone "Deprecation warning in keystone log for keystone.contrib.endpoint_policy.routers.EndpointPolicyExtension" [Undecided,New] | 05:34 |
stevemar | dikonoor: thanks :) | 05:34 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Reference new endpoint_policy in paste file https://review.openstack.org/210204 | 05:34 |
dikonoor | :) | 05:34 |
stevemar | jamielennox: ^ i changed up a little something there, take a look? | 05:35 |
stevemar | jamielennox: changed the filter from endpoint_policy_extension to endpoint_policy, those should be OK to change right? | 05:35 |
davechen | Ah, this change is necessary, I need update another patch as well. | 05:36 |
jamielennox | stevemar: fine on the change | 05:36 |
jamielennox | stevemar: i'm not sure about the changing _extension | 05:36 |
*** markvoelker has quit IRC | 05:36 | |
jamielennox | it probably doesn't matter because people will have to update paste anyway | 05:36 |
stevemar | jamielennox: yeah, i figured it shouldn't be that much of an issue | 05:37 |
davechen | stevemar, jamielennox, Is there any need to move other extension from the contrib to core? | 05:38 |
stevemar | davechen: probably oauth1, federation and endpoint_filter | 05:38 |
stevemar | fernando started one of those | 05:38 |
stevemar | i think the oauth1 one. | 05:38 |
jamielennox | davechen: all of them hopefully | 05:38 |
davechen | stevemar, jamielennox: yeah, I also have the patch for the endpoint_filter. | 05:39 |
davechen | stevemar, jamielennox: pending for an while, stevemar commented that patch before. | 05:39 |
davechen | stevemar, jamielennox: will update them to fix the merge conflict. | 05:40 |
*** belmoreira has quit IRC | 05:47 | |
*** stevemar has quit IRC | 05:47 | |
dstanek | hey davechen! | 05:48 |
*** stevemar has joined #openstack-keystone | 05:49 | |
*** ChanServ sets mode: +v stevemar | 05:49 | |
dstanek | davechen: did my explanation about the region thing make sense? | 05:50 |
davechen | dstanek: hi David, | 05:51 |
davechen | dstanek: yeah, make sense indeed. | 05:51 |
davechen | dstanek: I am okay with that change, it much better that the original review. | 05:51 |
dstanek | davechen: i wouldn't say much better. they both fix the issue, i just took a different approach | 05:52 |
davechen | dstanek: it fix the issue from the source, but the original review is just make fix the issue. | 05:52 |
davechen | dstanek: yeah, this is why i mark the TODO in the testcase. | 05:53 |
davechen | dstanek: must be in deep night in your region? my boss. | 05:53 |
*** josecastroleon has joined #openstack-keystone | 05:54 | |
dstanek | 02:00 | 05:54 |
davechen | dstanek: impressive!!! | 05:54 |
davechen | dstanek: why work so hard. | 05:54 |
davechen | dstanek: when your patch got merged, I will abandon the original review. | 05:55 |
dstanek | i meant to ask dolphm about it earlier; i'll do that tomorrow | 05:55 |
dstanek | i got bored and decided to jump on an finish up some misc stuff. i haven't been working all day | 05:56 |
dstanek | and stevemar is in the same timezone and should be sleeping | 05:56 |
davechen | dstanek: Just talked a little bit with him :) | 05:57 |
davechen | dstanek: How many children do you have? | 05:57 |
dstanek | davechen: 4 | 05:57 |
davechen | dstanek: wow! | 05:58 |
davechen | dstanek: I just have one daughter. | 05:58 |
dstanek | davechen: going to have any more? | 05:58 |
*** _hrou_ has quit IRC | 05:59 | |
davechen | dstanek: no, I cannot afford to have another. | 05:59 |
davechen | dstanek: although I hope. | 05:59 |
dstanek | davechen: hopefully you will then | 05:59 |
davechen | dstanek: traditionally, it's mean happiness if there are more childre. | 06:00 |
dstanek | ... and some stress | 06:00 |
stevemar | dstanek needs more children | 06:00 |
davechen | dstanek: In China, big family means happiness. | 06:00 |
davechen | more stress... I agree. | 06:01 |
dstanek | stevemar: only 1 more so i can gave a prime number! | 06:01 |
stevemar | should have stuck with 3! | 06:01 |
davechen | stevemar: only two is allowed by government. | 06:02 |
davechen | in my country. | 06:02 |
dstanek | davechen: really? | 06:02 |
davechen | I hate this rule. | 06:02 |
stevemar | i'm enjoying life with 0 :D | 06:03 |
davechen | yup, too many people here. | 06:03 |
*** urulama has quit IRC | 06:03 | |
davechen | enjoy it, enjoy your free life. stevemar. | 06:03 |
stevemar | i do all the time! | 06:04 |
*** urulama has joined #openstack-keystone | 06:04 | |
stevemar | dstanek: btw https://review.openstack.org/#/c/210204/ | 06:05 |
*** Guest58084 has quit IRC | 06:06 | |
stevemar | ahh shoot... i forgot to do a patch i wanted to do... should I boot up my vm and do it? | 06:06 |
dstanek | stevemar: that doesn't exist, does it? | 06:08 |
dstanek | stevemar: i don't have an EndpointPolicyExtension in my routers module | 06:09 |
stevemar | dstanek: huh? | 06:10 |
stevemar | https://github.com/openstack/keystone/blob/master/keystone/contrib/endpoint_policy/routers.py#L25 | 06:11 |
davechen | dstanek: someone has fixed it for you when are you hanging around. :) | 06:11 |
dstanek | stevemar: but your patch changes that to look at keystone.endpoint_policy.routers right? | 06:11 |
dstanek | maybe it's too late and i'm too tire... | 06:12 |
dstanek | err...tired | 06:12 |
davechen | This extension has been deprecated. | 06:12 |
davechen | go to sleep, two super man. | 06:13 |
stevemar | dstanek: i think you need sleep | 06:14 |
stevemar | i regret asking you to look at it :P | 06:14 |
dstanek | davechen: right, but the patch points to a class that doesn't exist | 06:14 |
dstanek | lol | 06:14 |
stevemar | ohhh i see what you mean :) | 06:14 |
stevemar | dstanek: keystone.endpoint_policy.routers:Routers.factory ? | 06:15 |
davechen | the path seems wrong. | 06:16 |
davechen | keystone.endpoint_policy.routers.Routers | 06:17 |
dstanek | stevemar: the RoutersBase classes don't have a factory method. i think we may be missing a class here | 06:17 |
openstackgerrit | Marek Denis proposed openstack/keystone: Refactor: rename Fernet's unscoped federated payload https://review.openstack.org/202190 | 06:17 |
dstanek | stevemar: actually this isn't middleware anymore | 06:18 |
stevemar | dstanek: i think we can just remove it... | 06:19 |
dstanek | stevemar: yes, http://git.openstack.org/cgit/openstack/keystone/tree/keystone/service.py#n121 | 06:19 |
dstanek | we already wire in the routes if configured to do so | 06:19 |
davechen | +1 to remove it. | 06:20 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Reference new endpoint_policy in paste file https://review.openstack.org/210204 | 06:20 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Remove reference of old endpoint_policy in paste file https://review.openstack.org/210204 | 06:21 |
stevemar | thanks dstanek, you're the best! | 06:24 |
stevemar | now i sleep | 06:24 |
stevemar | so long my two daves, dstanek and davechen | 06:24 |
dstanek | stevemar: night, i have a review for you to look at in the morning | 06:25 |
stevemar | pile it on! | 06:25 |
*** stevemar has quit IRC | 06:25 | |
davechen | good dream. :) | 06:27 |
*** belmoreira has joined #openstack-keystone | 06:38 | |
*** vincep has joined #openstack-keystone | 06:53 | |
*** vincep has quit IRC | 07:04 | |
*** jasondotstar has joined #openstack-keystone | 07:05 | |
*** vincep has joined #openstack-keystone | 07:06 | |
*** jasondotstar has quit IRC | 07:09 | |
*** yottatsa has quit IRC | 07:11 | |
*** henrynash has joined #openstack-keystone | 07:12 | |
*** ChanServ sets mode: +v henrynash | 07:12 | |
*** kiran-r has joined #openstack-keystone | 07:17 | |
breton | good morning! | 07:18 |
*** ParsectiX has joined #openstack-keystone | 07:25 | |
*** lhcheng has joined #openstack-keystone | 07:29 | |
*** ChanServ sets mode: +v lhcheng | 07:29 | |
*** lhcheng_ has quit IRC | 07:32 | |
*** markvoelker has joined #openstack-keystone | 07:32 | |
*** markvoelker has quit IRC | 07:37 | |
*** btully has joined #openstack-keystone | 07:38 | |
*** ankita_w_ has quit IRC | 07:41 | |
*** btully has quit IRC | 07:42 | |
*** browne has quit IRC | 07:44 | |
*** fhubik has joined #openstack-keystone | 07:46 | |
*** vivekd has quit IRC | 07:47 | |
*** e0ne has joined #openstack-keystone | 07:55 | |
*** henrynash has quit IRC | 07:56 | |
*** stevemar has joined #openstack-keystone | 07:56 | |
*** ChanServ sets mode: +v stevemar | 07:56 | |
*** stevemar has quit IRC | 07:58 | |
*** fhubik is now known as fhubik_afk | 07:59 | |
*** fhubik_afk is now known as fhubik | 08:01 | |
*** henrynash has joined #openstack-keystone | 08:03 | |
*** ChanServ sets mode: +v henrynash | 08:03 | |
*** chlong has quit IRC | 08:04 | |
*** jistr has joined #openstack-keystone | 08:06 | |
*** e0ne has quit IRC | 08:06 | |
*** fhubik is now known as fhubik_afk | 08:13 | |
*** afazekas_ has joined #openstack-keystone | 08:17 | |
*** topol has joined #openstack-keystone | 08:18 | |
*** ChanServ sets mode: +v topol | 08:18 | |
*** topol has quit IRC | 08:23 | |
*** lhcheng has quit IRC | 08:26 | |
*** fhubik_afk is now known as fhubik | 08:28 | |
*** henrynash has quit IRC | 08:42 | |
*** vivekd has joined #openstack-keystone | 08:44 | |
*** dikonoor has quit IRC | 08:58 | |
*** jasondotstar has joined #openstack-keystone | 09:00 | |
*** vivekd has quit IRC | 09:00 | |
*** vivekd has joined #openstack-keystone | 09:02 | |
*** vivekd_ has joined #openstack-keystone | 09:02 | |
*** vivekd has quit IRC | 09:06 | |
*** vivekd_ is now known as vivekd | 09:06 | |
*** eandersson has joined #openstack-keystone | 09:07 | |
*** dikonoo has joined #openstack-keystone | 09:07 | |
*** lhcheng has joined #openstack-keystone | 09:12 | |
*** ChanServ sets mode: +v lhcheng | 09:12 | |
*** e0ne has joined #openstack-keystone | 09:12 | |
*** vivekd_ has joined #openstack-keystone | 09:17 | |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Import service catalog tests from keystoneclient https://review.openstack.org/210266 | 09:18 |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Allow searching a catalog on service or endpoint id https://review.openstack.org/210267 | 09:18 |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Remove service_type requirement from catalog searching https://review.openstack.org/210268 | 09:19 |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Replace endpoint_type with interface in catalog https://review.openstack.org/210269 | 09:19 |
*** vivekd has quit IRC | 09:21 | |
*** vivekd_ is now known as vivekd | 09:21 | |
*** olmy0414 has joined #openstack-keystone | 09:22 | |
*** btully has joined #openstack-keystone | 09:25 | |
olmy0414 | Hello, could someboby tell me pls, with version of python-openstackclient supports this command : openstack project set --domain ......? With version python-openstackclient-1.0.3 it doen`t work - "openstack project set: error: unrecognized arguments: --domain e8c3b047083d400d90eddae5917d47f2" | 09:25 |
olmy0414 | python-openstackclient-1.0.3-2.el7.noarch.rpm - from Kilo | 09:29 |
*** jasondotstar has quit IRC | 09:29 | |
*** btully has quit IRC | 09:30 | |
*** markvoelker has joined #openstack-keystone | 09:33 | |
*** markvoelker has quit IRC | 09:37 | |
*** vivekd has quit IRC | 09:40 | |
*** vivekd has joined #openstack-keystone | 09:41 | |
*** jasondotstar has joined #openstack-keystone | 09:42 | |
*** vivekd_ has joined #openstack-keystone | 09:46 | |
*** vivekd has quit IRC | 09:48 | |
*** vivekd_ is now known as vivekd | 09:48 | |
*** vivekd_ has joined #openstack-keystone | 09:49 | |
marekd | olmy0414: try help $ openstack help project set | 09:49 |
marekd | and you will see options for your version | 09:49 |
*** vivekd__ has joined #openstack-keystone | 09:53 | |
*** vivekd has quit IRC | 09:53 | |
*** vivekd__ is now known as vivekd | 09:53 | |
*** dims_ has joined #openstack-keystone | 09:54 | |
*** davechen has left #openstack-keystone | 09:54 | |
*** stevemar has joined #openstack-keystone | 09:57 | |
*** ChanServ sets mode: +v stevemar | 09:57 | |
*** vivekd_ has quit IRC | 09:57 | |
*** stevemar has quit IRC | 09:58 | |
*** marzif has joined #openstack-keystone | 09:59 | |
olmy0414 | found it, i need version python-openstackclient-1.5, thanks | 09:59 |
*** olmy0414 has quit IRC | 10:00 | |
*** mestery_ has joined #openstack-keystone | 10:11 | |
*** jasondotstar has quit IRC | 10:13 | |
*** mestery has quit IRC | 10:15 | |
*** e0ne has quit IRC | 10:16 | |
*** lhcheng has quit IRC | 10:17 | |
*** e0ne has joined #openstack-keystone | 10:17 | |
openstackgerrit | Rajesh Tailor proposed openstack/keystone: Fix duplicate-key pylint issue https://review.openstack.org/210300 | 10:17 |
*** divya__ has joined #openstack-keystone | 10:19 | |
*** jistr has quit IRC | 10:20 | |
*** bradjones has quit IRC | 10:20 | |
*** jistr has joined #openstack-keystone | 10:20 | |
*** dikonoo has quit IRC | 10:22 | |
*** nigelb has quit IRC | 10:28 | |
*** nigelb has joined #openstack-keystone | 10:28 | |
*** bradjones_ has joined #openstack-keystone | 10:30 | |
*** bradjones_ is now known as bradjones | 10:30 | |
*** nonameentername has quit IRC | 10:33 | |
*** josecastroleon has quit IRC | 10:38 | |
*** nonameentername has joined #openstack-keystone | 10:39 | |
*** vivekd_ has joined #openstack-keystone | 10:39 | |
*** vivekd__ has joined #openstack-keystone | 10:43 | |
*** bradjones has quit IRC | 10:45 | |
*** vivekd has quit IRC | 10:45 | |
*** kiran-r has quit IRC | 10:45 | |
*** harlowja has quit IRC | 10:45 | |
*** mtreinish has quit IRC | 10:45 | |
*** tsymanczyk has quit IRC | 10:45 | |
*** openstackgerrit has quit IRC | 10:45 | |
*** HenryG has quit IRC | 10:45 | |
*** tobasco has quit IRC | 10:45 | |
*** kfjohnson has quit IRC | 10:45 | |
*** navid_ has quit IRC | 10:45 | |
*** pgbridge has quit IRC | 10:45 | |
*** odyssey4me has quit IRC | 10:45 | |
*** miguelgrinberg has quit IRC | 10:45 | |
*** raginbajin has quit IRC | 10:45 | |
*** dhellmann has quit IRC | 10:45 | |
*** vmbrasseur has quit IRC | 10:45 | |
*** trey has quit IRC | 10:45 | |
*** d0ugal has quit IRC | 10:45 | |
*** pothole has quit IRC | 10:45 | |
*** vivekd__ is now known as vivekd | 10:45 | |
*** fhubik is now known as fhubik_afk | 10:46 | |
*** vivekd_ has quit IRC | 10:47 | |
breton | yeah! I've successfully authenticated with certificate | 10:48 |
breton | https://review.openstack.org/#/c/156870/48 | 10:48 |
*** bradjones has joined #openstack-keystone | 10:49 | |
*** kiran-r has joined #openstack-keystone | 10:49 | |
*** vmbrasseur has joined #openstack-keystone | 10:49 | |
*** harlowja has joined #openstack-keystone | 10:49 | |
*** mtreinish has joined #openstack-keystone | 10:49 | |
*** tsymanczyk has joined #openstack-keystone | 10:49 | |
*** openstackgerrit has joined #openstack-keystone | 10:49 | |
*** HenryG has joined #openstack-keystone | 10:49 | |
*** tobasco has joined #openstack-keystone | 10:49 | |
*** kfjohnson has joined #openstack-keystone | 10:49 | |
*** navid_ has joined #openstack-keystone | 10:49 | |
*** pgbridge has joined #openstack-keystone | 10:49 | |
*** odyssey4me has joined #openstack-keystone | 10:49 | |
*** miguelgrinberg has joined #openstack-keystone | 10:49 | |
*** raginbajin has joined #openstack-keystone | 10:49 | |
*** dhellmann has joined #openstack-keystone | 10:49 | |
*** trey has joined #openstack-keystone | 10:49 | |
*** d0ugal has joined #openstack-keystone | 10:49 | |
*** pothole has joined #openstack-keystone | 10:49 | |
*** bradjones has quit IRC | 10:49 | |
*** bradjones has joined #openstack-keystone | 10:49 | |
*** bradjones has quit IRC | 10:49 | |
*** bradjones has joined #openstack-keystone | 10:49 | |
marekd | ++ | 10:54 |
*** vmbrasseur has quit IRC | 10:58 | |
*** atiwari has quit IRC | 10:58 | |
*** dan has quit IRC | 11:00 | |
*** amakarov_away is now known as amakarov | 11:00 | |
*** dan has joined #openstack-keystone | 11:03 | |
*** vmbrasseur has joined #openstack-keystone | 11:03 | |
*** fhubik_afk is now known as fhubik | 11:04 | |
*** atiwari has joined #openstack-keystone | 11:04 | |
*** vivekd has quit IRC | 11:04 | |
*** piyanai has joined #openstack-keystone | 11:10 | |
*** yottatsa has joined #openstack-keystone | 11:29 | |
*** davidckennedy has joined #openstack-keystone | 11:30 | |
*** markvoelker has joined #openstack-keystone | 11:34 | |
*** yottatsa has quit IRC | 11:34 | |
*** gordc has joined #openstack-keystone | 11:35 | |
*** e0ne has quit IRC | 11:36 | |
*** e0ne has joined #openstack-keystone | 11:37 | |
*** markvoelker has quit IRC | 11:39 | |
*** yottatsa has joined #openstack-keystone | 11:40 | |
*** josecastroleon has joined #openstack-keystone | 11:44 | |
*** yottatsa has quit IRC | 11:52 | |
*** yottatsa has joined #openstack-keystone | 11:53 | |
marekd | lbragstad: ping | 11:53 |
*** yottatsa has quit IRC | 11:54 | |
*** stevemar has joined #openstack-keystone | 11:57 | |
*** ChanServ sets mode: +v stevemar | 11:57 | |
*** stevemar has quit IRC | 12:01 | |
*** raildo has joined #openstack-keystone | 12:08 | |
*** Nirupama has quit IRC | 12:09 | |
*** yottatsa has joined #openstack-keystone | 12:09 | |
*** piyanai has quit IRC | 12:16 | |
*** piyanai has joined #openstack-keystone | 12:16 | |
*** tellesnobrega has quit IRC | 12:17 | |
*** chlong has joined #openstack-keystone | 12:17 | |
*** piyanai has quit IRC | 12:20 | |
*** piyanai has joined #openstack-keystone | 12:20 | |
openstackgerrit | Rajesh Tailor proposed openstack/keystone: Fix unreachable code in test_v3 module https://review.openstack.org/210365 | 12:21 |
*** piyanai has quit IRC | 12:23 | |
*** markvoelker has joined #openstack-keystone | 12:29 | |
*** dims_ has quit IRC | 12:33 | |
*** dims_ has joined #openstack-keystone | 12:34 | |
*** afazekas_ has quit IRC | 12:36 | |
*** bapalm has joined #openstack-keystone | 12:39 | |
*** tellesnobrega has joined #openstack-keystone | 12:42 | |
*** shadower has joined #openstack-keystone | 12:42 | |
*** vincep has quit IRC | 12:47 | |
*** vincep has joined #openstack-keystone | 12:48 | |
*** katkapilatova has joined #openstack-keystone | 12:52 | |
*** e0ne has quit IRC | 12:52 | |
*** ccard has joined #openstack-keystone | 12:55 | |
*** e0ne has joined #openstack-keystone | 12:59 | |
*** zzzeek has joined #openstack-keystone | 12:59 | |
*** kiran-r has quit IRC | 13:04 | |
*** dsirrine has joined #openstack-keystone | 13:13 | |
*** ayoung has joined #openstack-keystone | 13:13 | |
*** ChanServ sets mode: +v ayoung | 13:13 | |
*** hrou has joined #openstack-keystone | 13:20 | |
*** jdandrea has joined #openstack-keystone | 13:21 | |
*** browne has joined #openstack-keystone | 13:25 | |
*** petertr7_away is now known as petertr7 | 13:26 | |
*** TheIntern has joined #openstack-keystone | 13:28 | |
*** browne has quit IRC | 13:31 | |
*** henrynash has joined #openstack-keystone | 13:38 | |
*** ChanServ sets mode: +v henrynash | 13:38 | |
*** henrynash has quit IRC | 13:39 | |
*** mestery_ is now known as mestery | 13:40 | |
*** piyanai has joined #openstack-keystone | 13:43 | |
*** afaranha has joined #openstack-keystone | 13:48 | |
*** afaranha has left #openstack-keystone | 13:48 | |
*** edmondsw has joined #openstack-keystone | 13:49 | |
breton | I wonder | 13:53 |
breton | how do I make an auth plugin which does not involve tokens? | 13:54 |
breton | *that doesn't | 13:54 |
*** rvba has joined #openstack-keystone | 13:57 | |
*** rvba has quit IRC | 13:57 | |
*** rvba has joined #openstack-keystone | 13:57 | |
breton | jamielennox: | 13:58 |
*** stevemar has joined #openstack-keystone | 13:58 | |
*** ChanServ sets mode: +v stevemar | 13:58 | |
*** ParsectiX has quit IRC | 13:59 | |
*** topol has joined #openstack-keystone | 13:59 | |
*** ChanServ sets mode: +v topol | 13:59 | |
*** narengan has joined #openstack-keystone | 14:00 | |
dstanek | breton: i am going to resubmit your notifications review (unchanged) on top of some new tests | 14:00 |
dstanek | breton: isn't gyee doing that with certificates? | 14:01 |
*** stevemar has quit IRC | 14:02 | |
breton | dstanek: he is. There is server-side implementation, but no auth plugin for clients. | 14:02 |
breton | (or I don't know where it is) | 14:02 |
dstanek | i have to imagine that he is. otherwise how would be use it? | 14:04 |
marekd | breton: how would it look like? | 14:04 |
marekd | breton: how would you then transport identity between client and server? | 14:04 |
*** mylu has joined #openstack-keystone | 14:06 | |
breton | like this: http://paste.openstack.org/show/412191/ | 14:06 |
breton | user attributes are retrieved from the certificate | 14:07 |
breton | and mapped how it's done for federation | 14:07 |
*** mylu has quit IRC | 14:08 | |
*** mylu has joined #openstack-keystone | 14:08 | |
marekd | aha x509 everywhere. | 14:10 |
marekd | so the certificate is kind of your token. | 14:10 |
dstanek | yeah, there is not way to do it without some sort of "token" | 14:11 |
*** richm has joined #openstack-keystone | 14:12 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Remove deprecated methods from assignment.Manager https://review.openstack.org/210174 | 14:13 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Stop calling deprecated assignment manager methods https://review.openstack.org/210455 | 14:13 |
breton | yeah. And I don't quite understand now how to tie it to plugin interface. | 14:13 |
openstackgerrit | Paweł Pamuła proposed openstack/keystone: IdP deletion triggers token revocation https://review.openstack.org/210456 | 14:14 |
*** piyanai has quit IRC | 14:16 | |
*** narengan_ has joined #openstack-keystone | 14:16 | |
*** mylu has quit IRC | 14:16 | |
*** mylu has joined #openstack-keystone | 14:18 | |
*** narengan_ has quit IRC | 14:19 | |
*** narengan has quit IRC | 14:19 | |
*** narengan has joined #openstack-keystone | 14:19 | |
*** btully has joined #openstack-keystone | 14:20 | |
* breton is looking at how oauth is done is ksc | 14:20 | |
*** piyanai has joined #openstack-keystone | 14:21 | |
*** narengan has quit IRC | 14:24 | |
*** geoffarnold has joined #openstack-keystone | 14:25 | |
rodrigods | bknudson, ping... regarding your review in https://review.openstack.org/#/c/157427/ | 14:25 |
*** mylu has quit IRC | 14:26 | |
bknudson | rodrigods: what's up? | 14:26 |
rodrigods | bknudson, do you believe it is a blocker we changing that method? I agree with you and htruta | 14:26 |
*** geoffarnold has quit IRC | 14:26 | |
*** geoffarnold has joined #openstack-keystone | 14:27 | |
bknudson | rodrigods: at this point it is a blocker that you're changing the method since supposedly the api is stable. | 14:28 |
bknudson | so we need cores to decide on it. | 14:28 |
bknudson | rodrigods: probably best to bring it up at the weekly meeting | 14:28 |
rodrigods | bknudson, I see... | 14:28 |
bknudson | and post to the -dev mailing ist. | 14:28 |
bknudson | list | 14:29 |
rodrigods | bknudson, will do that | 14:29 |
rodrigods | thx | 14:29 |
bknudson | rodrigods: if you think we'll decide the api is unstable then rebase on https://review.openstack.org/#/c/210174 | 14:29 |
bknudson | or, if you think we'll decide the api is stable then you can change your code to not require the new parameter or something. | 14:30 |
rodrigods | bknudson, that's my understanding | 14:30 |
rodrigods | the api is unstable | 14:30 |
bknudson | y, but if it's unstable then why have the deprecation warning? | 14:31 |
*** mylu has joined #openstack-keystone | 14:31 | |
rodrigods | bknudson, I mean, we'll rebase using your patch that removes the deprecation warning | 14:31 |
bknudson | rodrigods: ok, then you won't have to change keystone/assignment/core.py | 14:32 |
bknudson | because that method is gone | 14:32 |
rodrigods | bknudson, ++ | 14:32 |
htruta | bknudson: that might work for us | 14:33 |
openstackgerrit | David Stanek proposed openstack/keystone: Remove excessive transformation to list https://review.openstack.org/201648 | 14:36 |
openstackgerrit | David Stanek proposed openstack/keystone: Adds/updates notifications test cases https://review.openstack.org/210476 | 14:36 |
openstackgerrit | David Stanek proposed openstack/keystone: Fixes an incorrect docstring in notifications https://review.openstack.org/210477 | 14:36 |
openstackgerrit | David Stanek proposed openstack/keystone: Adds a notification testcase for unbound methods https://review.openstack.org/210478 | 14:36 |
htruta | bknudson: we're kind of running out of time to reseller... do you think that this patch of yours is going to take long to be approved? | 14:36 |
bknudson | htruta: I don't know... patches often take several months to be approved. | 14:37 |
petertr7 | Hi! I'm experiencing something weird with adding roles to users with python-keystone client v2. | 14:38 |
bknudson | If there's any feedback on the patch I'll try to be responsive and update it quickly. | 14:38 |
petertr7 | I seem to be succcesful in executing add_user_role https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v2_0/roles.py#L58. | 14:38 |
htruta | bknudson: I see... this case would mean that reseller won't be available in L | 14:38 |
petertr7 | However when I attempted to use keystone user-role-list --user username it only has the default "_member_" role. If I delete the user and recreate it and add the role again, it says "User pete already has role X in tenant Y". Still, keystone user-role-list does not list any other role. | 14:38 |
bknudson | htruta: keystone has too much technical debt and we need to get rid of it at some point. | 14:39 |
bknudson | rather than continue adding more | 14:39 |
htruta | bknudson: agreed. but I don't think that this bug should've been blocking such a big functionality | 14:40 |
htruta | I mean... we could keep on doing reseller stuff and then rebase to your bug once it is approved | 14:41 |
htruta | not blocking the whole 10+ patches chain right now | 14:41 |
bknudson | htruta: it won't be blocking if you decide that the assignment manager is a stable API and change the implementation so that the interface isn't changed | 14:42 |
*** stevemar has joined #openstack-keystone | 14:42 | |
*** ChanServ sets mode: +v stevemar | 14:42 | |
bknudson | I've spent this whole release trying to clean up technical debt and I'm tired of it. | 14:43 |
htruta | bknudson: seems ok. but what if cores decide that it is unstable? we'd have the block | 14:45 |
htruta | I've spent this whole release trying to make reseller land, and I'm also tired of it : | 14:45 |
htruta | :/ | 14:46 |
bknudson | according to http://stackalytics.com/report/contribution/keystone-group/90 you've done 3 reviews. If you want keystone to move faster then we need more reviews. | 14:48 |
htruta | bknudson: yes, I do. my bad. but rodrigods has also spent a lot of time with me one this and he's made lots of reviews | 14:49 |
dstanek | bknudson: snap | 14:52 |
dstanek | bknudson: you have to stop beating me at reviews! | 14:52 |
*** narengan has joined #openstack-keystone | 14:52 | |
bknudson | dstanek: it's not easy to stay ahead of you. | 14:53 |
*** dims_ is now known as dimsum__ | 14:53 | |
dstanek | bknudson: i would say the reverse. you've just about always on top :-) | 14:53 |
bknudson | dstanek: I'll review some of your patches... that will really show you. | 14:53 |
dstanek | i bet you can't review all of my patches today | 14:54 |
bknudson | I | 14:54 |
*** fhubik has quit IRC | 14:55 | |
bknudson | I've got some more technical debt to try to clean up... I'll try to get to some. | 14:55 |
dstanek | alas...me too. while reviewing and writing some new code i keep running into things that need to be fixed | 14:56 |
bknudson | dstanek: thanks for cleaning it up and not just adding more to the pile. | 14:56 |
bknudson | it'll help us move faster going forward and then we can add new features. | 14:58 |
openstackgerrit | David Stanek proposed openstack/keystone: NotificationsTestCase running in isolation https://review.openstack.org/204739 | 15:00 |
dstanek | ^ that should be a real easy one....i just had to update the commit message | 15:04 |
*** e0ne has quit IRC | 15:05 | |
*** vivekdhayaal has joined #openstack-keystone | 15:05 | |
*** TheIntern is now known as TheIntern_away | 15:06 | |
bknudson | we can't even keep our tests running | 15:06 |
*** narengan has quit IRC | 15:07 | |
*** browne has joined #openstack-keystone | 15:07 | |
dstanek | bknudson: haha, fair point | 15:08 |
*** narengan has joined #openstack-keystone | 15:08 | |
bknudson | dstanek: so no configuration is needed for the tests? | 15:08 |
bknudson | looks like it mocks everything anyways. | 15:08 |
*** narengan_ has joined #openstack-keystone | 15:09 | |
dstanek | yeah, those tests are not the greatest - removing the method now | 15:09 |
bknudson | thanks! | 15:09 |
openstackgerrit | David Stanek proposed openstack/keystone: NotificationsTestCase running in isolation https://review.openstack.org/204739 | 15:10 |
*** TheIntern_away is now known as TheIntern | 15:10 | |
*** narengan_ has quit IRC | 15:11 | |
*** vivekd2 has joined #openstack-keystone | 15:12 | |
bknudson | as far as unit tests go test_send_notification looks pretty good... it's simple and shows the behavior. | 15:12 |
dstanek | there are so many reviews that we can get through with minimal effort (like that one) | 15:12 |
*** narengan_ has joined #openstack-keystone | 15:12 | |
*** vivekdhayaal has quit IRC | 15:12 | |
*** narengan has quit IRC | 15:13 | |
bknudson | here's an easy one already has +2 : https://review.openstack.org/#/c/179259/ | 15:13 |
bknudson | another easy one (no +2): https://review.openstack.org/#/c/187065/ | 15:13 |
bknudson | easy one has +2: https://review.openstack.org/#/c/189029/ | 15:13 |
bknudson | this one is easy for dstanek and has +2: https://review.openstack.org/#/c/194894/ | 15:14 |
*** narengan has joined #openstack-keystone | 15:14 | |
bknudson | this one's easy and fixes another test bug: https://review.openstack.org/#/c/201352/ | 15:14 |
*** lucas___ has joined #openstack-keystone | 15:15 | |
bknudson | this one's pretty easy: https://review.openstack.org/#/c/210455/1 | 15:15 |
breton | https://review.openstack.org/#/c/201352/2 -- this one is not really easy | 15:16 |
breton | https://review.openstack.org/#/c/201352/2 -- it works, but weird. | 15:16 |
*** narengan_ has quit IRC | 15:16 | |
bknudson | breton: it's strange that the option is registered only when the function is called. | 15:16 |
bknudson | breton: I could propose a change to oslo so there's a separate function to register the option? | 15:17 |
*** vivekd2 has quit IRC | 15:19 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Correct enabled emulation query to request no attributes https://review.openstack.org/187065 | 15:21 |
breton | bknudson: maybe. Or just register that option in the bottom of the module | 15:21 |
*** phalmos has joined #openstack-keystone | 15:21 | |
*** r-daneel has joined #openstack-keystone | 15:22 | |
*** mylu has quit IRC | 15:22 | |
*** mylu has joined #openstack-keystone | 15:23 | |
breton | I also hate python for saying "explicit is better than implicit" and making iteration over dict as iteration over its keys. | 15:24 |
bknudson | all sorts of things are implicit in python... for example just adding 2 things together... you don't know if it's 2s-complement modulo or floating point or what. | 15:27 |
bknudson | you'd go crazy if everything was explicit | 15:27 |
bknudson | but you'd probably have a more secure system | 15:27 |
dstanek | breton: :-) | 15:32 |
dstanek | those are design guidelines. doesn't mean everything should/will follow them | 15:32 |
*** browne has quit IRC | 15:32 | |
*** _cjones_ has joined #openstack-keystone | 15:33 | |
*** _cjones_ has quit IRC | 15:33 | |
*** _cjones_ has joined #openstack-keystone | 15:33 | |
*** vincep has quit IRC | 15:34 | |
*** e0ne has joined #openstack-keystone | 15:40 | |
*** e0ne has quit IRC | 15:42 | |
*** gyee has joined #openstack-keystone | 15:42 | |
*** ChanServ sets mode: +v gyee | 15:42 | |
stevemar | dstanek: can you check this: https://review.openstack.org/#/c/207456/ ? | 15:47 |
stevemar | the author gives reason for adding an extra () at the end of a line, but it still seems weird to me | 15:47 |
stevemar | dstanek: in exchange, i'll review your notification patches :) | 15:47 |
dstanek | stevemar: yay.... | 15:48 |
*** phalmos has joined #openstack-keystone | 15:48 | |
*** narengan_ has joined #openstack-keystone | 15:50 | |
*** belmoreira has quit IRC | 15:51 | |
*** Ephur has joined #openstack-keystone | 15:51 | |
*** belmoreira has joined #openstack-keystone | 15:52 | |
*** belmoreira has quit IRC | 15:52 | |
bknudson | breton: here's the proposed change to oslo.log : https://review.openstack.org/#/c/210504/ | 15:52 |
*** yottatsa has quit IRC | 15:52 | |
*** narengan has quit IRC | 15:53 | |
*** phalmos has left #openstack-keystone | 16:03 | |
marekd | stevemar: FYI: https://bugs.launchpad.net/keystone/+bug/1482701 | 16:03 |
openstack | Launchpad bug 1482701 in Keystone "Federation: user's name in rules not respected" [Medium,New] - Assigned to Marek Denis (marek-denis) | 16:03 |
*** _cjones_ has quit IRC | 16:04 | |
*** _cjones_ has joined #openstack-keystone | 16:04 | |
dstanek | stevemar: i wonder if we can get that test to work without that funky mixin | 16:04 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Remove deprecated methods from assignment.Manager https://review.openstack.org/210174 | 16:06 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Stop calling deprecated assignment manager methods https://review.openstack.org/210455 | 16:06 |
geoffarnold | is there an HMT mtg today in #openstack-meeting? | 16:07 |
* geoffarnold juggles odd weeks/even weeks | 16:08 | |
*** josecastroleon has quit IRC | 16:09 | |
stevemar | marekd: ah, it always takes id | 16:10 |
*** katkapilatova has left #openstack-keystone | 16:15 | |
dstanek | stevemar: i want this really bad :-) or for someone to tell me why my data is pulled from the DB in a different order https://review.openstack.org/#/c/210086/ | 16:15 |
ericksonfgds | geoffarnold, not today | 16:16 |
stevemar | dstanek: who knows | 16:16 |
dstanek | not me. i decided it wasn't worth the effort in looking | 16:17 |
*** tsymanczyk has quit IRC | 16:18 | |
*** tsymanczyk has joined #openstack-keystone | 16:18 | |
*** tsymanczyk is now known as Guest46275 | 16:19 | |
dolphm | anyone know how to change the number of lines of context gerrit shows you in a diff? | 16:19 |
bknudson | I always click on the "skipped ... lines" | 16:19 |
dolphm | i swear it used to be in Settings -> Preferences, but now it's definitely not and i'm pretty sure i'm stuck with a setting i don't like anymore | 16:20 |
bknudson | or go to preferences and context "while file" | 16:20 |
bknudson | whole file | 16:20 |
bknudson | also you can pick the # lines in preferences context | 16:20 |
*** jasonsb has quit IRC | 16:20 | |
dolphm | bknudson: where do you have an option about Context? | 16:20 |
bknudson | preferences | 16:21 |
bknudson | at the top of the page | 16:21 |
dolphm | bknudson: i.. don't have that | 16:21 |
bknudson | when looking at a file | 16:21 |
*** jasonsb has joined #openstack-keystone | 16:21 | |
bknudson | might have to click "Differences" | 16:21 |
bknudson | also, I'm using the original coke | 16:21 |
dolphm | bknudson: http://i.imgur.com/YdQG3p6.png | 16:21 |
*** petertr7 is now known as petertr7_away | 16:21 | |
bknudson | dolphm: it's on the individual files | 16:21 |
bknudson | also there's a save button so maybe you can make it the default | 16:22 |
dolphm | bknudson: where do you have a preferences button on the diff screen? | 16:23 |
bknudson | It's right under "Differences" | 16:23 |
*** TheIntern has quit IRC | 16:23 | |
dolphm | oh damn i never noticed the top most menu changed... | 16:23 |
*** henrynash has joined #openstack-keystone | 16:24 | |
*** ChanServ sets mode: +v henrynash | 16:24 | |
dolphm | bknudson: YAY thank you | 16:24 |
bknudson | no problem | 16:24 |
bknudson | I thought you switched to gertty | 16:24 |
*** atiwari has quit IRC | 16:25 | |
*** jasonsb has quit IRC | 16:26 | |
dolphm | bknudson: i tried. the lack of vim keybindings drove me nuts | 16:27 |
dolphm | bknudson: i even hacked on it a bit, but couldn't get it where i wanted it | 16:27 |
*** davidckennedy has quit IRC | 16:28 | |
*** piyanai has quit IRC | 16:28 | |
*** jistr has quit IRC | 16:28 | |
*** ericksonfgds is now known as ericksonsantos | 16:28 | |
*** piyanai has joined #openstack-keystone | 16:29 | |
*** piyanai has quit IRC | 16:29 | |
*** bapalm has quit IRC | 16:31 | |
openstackgerrit | Merged openstack/keystone: Remove unused setUp for RevokeTests https://review.openstack.org/179259 | 16:32 |
*** lucas___ has quit IRC | 16:32 | |
dolphm | bknudson: did you see my second comment on https://review.openstack.org/#/c/210455/2/keystone/tests/unit/filtering.py,unified ? | 16:34 |
*** lucas___ has joined #openstack-keystone | 16:35 | |
bknudson | dolphm: I did... wasn't sure if you wanted me to add docstrings as part of this patch? | 16:35 |
bknudson | I guess it's easy enough. | 16:35 |
dolphm | bknudson: it wasn't the diff that confused me, it was whole structure of the method. i didn't realize it was *intended* to try three different attributes | 16:35 |
bknudson | dolphm: it's a goofy thing to do, especially in a test. | 16:36 |
dolphm | bknudson: a final "if f is None: panic()" would have made it clear too. | 16:36 |
dolphm | bknudson: yeah... i hate conditionals in a test like that :( | 16:36 |
esp | hello dolphm and bknudson, could you please take a look at this again at your convenience? https://review.openstack.org/#/c/208082/ | 16:39 |
esp | thx in advanced! | 16:39 |
*** lucas___ has quit IRC | 16:39 | |
*** stevemar has quit IRC | 16:39 | |
*** piyanai has joined #openstack-keystone | 16:40 | |
dolphm | esp: why didn't gyee approve it? | 16:40 |
dstanek | i am not a fan of the filtering module | 16:41 |
*** stevemar has joined #openstack-keystone | 16:41 | |
*** ChanServ sets mode: +v stevemar | 16:41 | |
* esp shrugs | 16:41 | |
gyee | dolphm, esp also works for HP | 16:41 |
esp | dolphm: maybe he wanted to make sure bknudson and all are cool with it | 16:41 |
gyee | I thought we can't directly patches from the same company | 16:41 |
gyee | approve I mean | 16:41 |
esp | ah, sorry. yeah. I work for hp as well. | 16:41 |
bknudson | "Other than the test name this looks fine." -- so I'm fine with it. | 16:42 |
dolphm | gyee: ah, does lcheng work for HP too? | 16:42 |
bknudson | assuming the test name was changed | 16:42 |
gyee | dolphm, used to be, he's with yahoo now | 16:42 |
dolphm | gyee: ah, well the only thing we like to avoid is 2 reviewers and an author from a single company | 16:42 |
esp | thx bknudson | 16:42 |
gyee | dolphm, k, good to know :) | 16:43 |
esp | def, will be careful who I put on reviews in the future | 16:43 |
gyee | esp, just have your in-law push the patch next time :) | 16:44 |
morgan_503 | esp: don't worry too much, us core reviewers are good about self-policing that same | 16:44 |
morgan_503 | Company thing | 16:44 |
* morgan_503 is still not here. | 16:44 | |
esp | gotcha. | 16:44 |
* esp is a noob | 16:45 | |
*** marzif has quit IRC | 16:45 | |
morgan_503 | We all started as noobs | 16:45 |
morgan_503 | ;) | 16:45 |
gyee | morgan_503 is boxing with the kangaroos | 16:45 |
morgan_503 | I am not. Keep up with teh twitterz | 16:45 |
*** TheIntern has joined #openstack-keystone | 16:46 | |
dolphm | gyee: he lost the fight and got sent home | 16:46 |
*** iamjarvo has joined #openstack-keystone | 16:47 | |
*** lhcheng has joined #openstack-keystone | 16:47 | |
*** ChanServ sets mode: +v lhcheng | 16:47 | |
gyee | lol | 16:48 |
*** TheIntern has quit IRC | 16:49 | |
*** kiran-r has joined #openstack-keystone | 16:51 | |
dolphm | bknudson: this affects stable/kilo as well, right? https://bugs.launchpad.net/keystone/+bug/1482660 | 16:52 |
openstack | Launchpad bug 1482660 in Keystone "Stop using deprecated methods in assignment manager" [Medium,In progress] - Assigned to Brant Knudson (blk-u) | 16:52 |
dstanek | bknudson: what is the . syntax in https://review.openstack.org/#/c/207602/4/tox.ini ? | 16:54 |
*** mylu has quit IRC | 16:57 | |
*** iamjarvo has quit IRC | 16:57 | |
*** roxanaghe has joined #openstack-keystone | 16:59 | |
*** lucas___ has joined #openstack-keystone | 16:59 | |
*** mylu has joined #openstack-keystone | 16:59 | |
*** roxanaghe has quit IRC | 17:03 | |
*** lucas___ has quit IRC | 17:03 | |
lbragstad | bknudson: I think https://review.openstack.org/#/c/208025/1 looks good, if you don't have the time I can address breton's comments | 17:05 |
lbragstad | and push a new revision | 17:05 |
*** annasort has joined #openstack-keystone | 17:05 | |
*** lucas___ has joined #openstack-keystone | 17:05 | |
openstackgerrit | henry-nash proposed openstack/keystone: Enable listing of role assignments in a project hierarchy https://review.openstack.org/208152 | 17:06 |
openstackgerrit | henry-nash proposed openstack/keystone: Enable listing of role assignments in a project hierarchy https://review.openstack.org/208152 | 17:07 |
*** Guest46275 has quit IRC | 17:07 | |
*** kiran-r has quit IRC | 17:07 | |
*** browne has joined #openstack-keystone | 17:10 | |
*** jasonsb has joined #openstack-keystone | 17:12 | |
*** ankita_wagh has joined #openstack-keystone | 17:17 | |
*** geoffarnold has quit IRC | 17:19 | |
*** piyanai has quit IRC | 17:20 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Fix minor comments in apache-httpd.rst docs https://review.openstack.org/210543 | 17:23 |
*** narengan_ has quit IRC | 17:24 | |
*** narengan has joined #openstack-keystone | 17:24 | |
*** atiwari has joined #openstack-keystone | 17:25 | |
*** geoffarnold has joined #openstack-keystone | 17:25 | |
*** narengan_ has joined #openstack-keystone | 17:27 | |
openstackgerrit | Merged openstack/keystone: Fixes an issue with data ordering in the tests https://review.openstack.org/210086 | 17:28 |
*** geoffarnold has quit IRC | 17:28 | |
*** narengan_ has quit IRC | 17:29 | |
*** narengan has quit IRC | 17:29 | |
*** narengan has joined #openstack-keystone | 17:29 | |
*** geoffarnold has joined #openstack-keystone | 17:30 | |
*** narengan has quit IRC | 17:34 | |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Validate domain ownership for v2 tokens https://review.openstack.org/208069 | 17:34 |
*** geoffarnold has quit IRC | 17:36 | |
*** geoffarnold has joined #openstack-keystone | 17:37 | |
*** phalmos has joined #openstack-keystone | 17:38 | |
*** elmiko_ is now known as elmiko | 17:38 | |
*** petertr7_away is now known as petertr7 | 17:39 | |
openstackgerrit | Roxana Gherle proposed openstack/keystone: Fernet 'expires' value loses 'ms' after validation https://review.openstack.org/210037 | 17:41 |
*** piyanai has joined #openstack-keystone | 17:46 | |
stevemar | lhcheng: https://review.openstack.org/#/c/210202/1 | 17:49 |
*** urulama has quit IRC | 17:51 | |
*** phalmos has quit IRC | 17:53 | |
*** lucas___ has quit IRC | 17:56 | |
*** iamjarvo has joined #openstack-keystone | 17:57 | |
lhcheng | stevemar: terry already pushed the button :P looks good | 17:59 |
*** gyee has quit IRC | 18:05 | |
*** jdandrea has left #openstack-keystone | 18:10 | |
openstackgerrit | Merged openstack/keystoneauth: Update .gitignore https://review.openstack.org/209996 | 18:15 |
bknudson | lbragstad: sure, thanks | 18:15 |
lbragstad | bknudson: no problem, I pushed a follow on patch that addresses the comments breton had | 18:16 |
bknudson | dolphm: that bug would also affect stable/kilo. | 18:16 |
bknudson | lbragstad: squash it | 18:16 |
lbragstad | bknudson: ok | 18:16 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Remove reference of old endpoint_policy in paste file https://review.openstack.org/210204 | 18:18 |
*** drjones has joined #openstack-keystone | 18:18 | |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Limit subtree and parents queries https://review.openstack.org/209132 | 18:19 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Add is_domain field in Project Table https://review.openstack.org/157427 | 18:19 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Honor domain operations in project table https://review.openstack.org/143763 | 18:19 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Restrict inherited role assignments to subdomains https://review.openstack.org/164180 | 18:19 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Change project name constraints https://review.openstack.org/158372 | 18:19 |
rodrigods | bknudson, henrynash ^ | 18:19 |
rodrigods | the change in the get_project_by_name signature was unnecessary | 18:19 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Update Httpd configuration docs for sites-available/enabled https://review.openstack.org/208025 | 18:19 |
dstanek | rodrigods: uggg...i was just leaving comments on one of those | 18:20 |
rodrigods | dstanek, sorry =( | 18:20 |
rodrigods | but please leave them in the prev patchset | 18:21 |
rodrigods | we will pay attention | 18:21 |
*** tsymanczyk has joined #openstack-keystone | 18:21 | |
lbragstad | bknudson: fixed and abandon my patch set | 18:21 |
*** josecastroleon has joined #openstack-keystone | 18:21 | |
*** tsymanczyk is now known as Guest35489 | 18:21 | |
lbragstad | cc breton ^ | 18:21 |
*** tsufiev has quit IRC | 18:22 | |
*** tsufiev has joined #openstack-keystone | 18:22 | |
dstanek | lbragstad: if you were going to abandon it then why waste time fixing :-P | 18:22 |
lbragstad | dstanek: I rolled my changes in to bknudson's patch and abandon the one I had | 18:22 |
*** _cjones_ has quit IRC | 18:22 | |
dstanek | rodrigods: we have to figure out how to make some of these changes in even smaller chunks | 18:23 |
dstanek | rodrigods: it would be much easier for you guys to get things merged that way | 18:23 |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Validate domain ownership for v2 tokens https://review.openstack.org/208069 | 18:24 |
*** eandersson has quit IRC | 18:24 | |
bknudson | lbragstad: btw - "ln -s ../sites-available/keystone.conf /etc/$APACHE_DIR/sites-enabled/" works fine | 18:25 |
*** jorge_munoz has quit IRC | 18:25 | |
*** phalmos has joined #openstack-keystone | 18:25 | |
bknudson | that line didn't have to change. | 18:25 |
bknudson | it works the way it is, too. | 18:25 |
lbragstad | bknudson: ok | 18:25 |
*** bapalm has joined #openstack-keystone | 18:26 | |
lbragstad | dolphm: did you happen to see bknudson's comment on this one? https://review.openstack.org/#/c/186376/ | 18:26 |
rodrigods | dstanek, I agree, the first one can definitely be split - but since it had a +2 from henrynash we decided to keep it like that. The huge one is the third, and the most difficult to split because there are too many side effects | 18:27 |
lbragstad | I can respin that pending what you guys think | 18:27 |
htruta | rodrigods: the huge is now the 4th | 18:27 |
htruta | once we've already split it | 18:27 |
rodrigods | htruta, true, the 4th dstanek | 18:27 |
dstanek | rodrigods: that should be a warning flag :-( | 18:27 |
openstackgerrit | Merged openstack/keystone: Allow Domain Admin to get domain details https://review.openstack.org/208082 | 18:28 |
rodrigods | dstanek, replicating all domain operations in the project table is not trivial =( | 18:28 |
dolphm | bknudson: there's a single, clear theme to that patch... i thought we agreed to squash tightly related changes when backporting to stable/*? https://review.openstack.org/#/c/186376/ | 18:28 |
dstanek | rodrigods: i agree, but there has got to be a way to make it more digestible. it might take a few weeks extra, but that's way better than waiting a few months for reviews | 18:29 |
*** amakarov is now known as amakarov_vacatio | 18:29 | |
rodrigods | dstanek, will sit with htruta today and try to figure it out | 18:30 |
rodrigods | at least for the 4th patch | 18:30 |
bknudson | dolphm: you can merge it... it takes more work for me to review it. | 18:30 |
*** divya__ has quit IRC | 18:30 | |
*** amakarov_vacatio has quit IRC | 18:30 | |
dstanek | rodrigods: one easy thing you can do it to take any of the test changes that work without the new code and commit them first in a separate patch | 18:30 |
dolphm | bknudson: in general i might agree, but on that specific review? | 18:31 |
dolphm | bknudson: am i breaking tooling or something? | 18:31 |
htruta | dstanek: the comments you were writing are on the first 2 patche? | 18:31 |
bknudson | dolphm: it's always going to take me more time to review when multiple changes are squashed. | 18:31 |
bknudson | dolphm: y, I just re-cherry-pick and see if it says there's no changes. | 18:31 |
dstanek | htruta: just published to patchset 85 or 157427 | 18:32 |
*** narengan has joined #openstack-keystone | 18:32 | |
bknudson | dolphm: I don't have a tool, I just cherry-pick to see if it complains and then look through the changes in gerrit. | 18:32 |
htruta | dstanek: cool. will look at it with rodrigods | 18:32 |
dolphm | bknudson: that won't catch people slipping in additional changes! | 18:33 |
dstanek | rodrigods: htruta: yeah, "+968, -331" is pretty big | 18:33 |
bknudson | dolphm: I compare both changes in gerrit to see if they slipped in something. | 18:33 |
htruta | dstanek: that should be the honor operations one | 18:33 |
htruta | this is the toughest | 18:34 |
dstanek | dolphm: this one was for you https://review.openstack.org/#/c/210476/ | 18:34 |
dstanek | dolphm: that was to show that breton's change doesn't break the single callback usecase | 18:34 |
dolphm | bknudson: well if you go through that trouble... you might be interested in diffing diffs: git diffdiff <review-number-A> <review-number-B> https://github.com/dolph/dotfiles/blob/master/bin/git-diffdiff | 18:34 |
dolphm | dstanek: ah, looking | 18:35 |
bknudson | dolphm: fancy! | 18:35 |
*** hrou has quit IRC | 18:36 | |
dolphm | bknudson: i always use the original master review as A, then the backport as B | 18:36 |
dolphm | bknudson: lines with only a single + or - are changes in context. lines with a double ++ or -- are differences between the two reviews | 18:37 |
*** bapalm has quit IRC | 18:38 | |
*** opilotte has joined #openstack-keystone | 18:38 | |
bknudson | dolphm: does git-diffdiff handle squashes? | 18:39 |
dolphm | bknudson: nope! | 18:39 |
*** htruta_ has joined #openstack-keystone | 18:39 | |
*** phalmos has quit IRC | 18:40 | |
dstanek | bknudson: if you don't think we need to care about removing manager methods, then i'm fine giving that a +2 | 18:41 |
bknudson | dstanek: I don't think it's a stable interface so we can remove manager methods... although for some reason it was being handled as a stable interface. | 18:41 |
rodrigods | dstanek, just addressed your review. We had an idea on how to split the first patch | 18:41 |
*** narengan has quit IRC | 18:41 | |
rodrigods | do you think it is worthed? | 18:42 |
*** narengan has joined #openstack-keystone | 18:42 | |
*** roxanaghe has joined #openstack-keystone | 18:43 | |
*** bapalm has joined #openstack-keystone | 18:48 | |
*** bapalm has quit IRC | 18:48 | |
*** roxanaghe has quit IRC | 18:49 | |
*** Guest35489 has quit IRC | 18:51 | |
*** josecastroleon has quit IRC | 18:51 | |
openstackgerrit | Olivier Pilotte proposed openstack/keystone: Keystone accepts Group IDs from the IdP without any Domain reference https://review.openstack.org/210581 | 18:51 |
dstanek | rodrigods: i'm all for it. patches that take <day to review are great | 18:52 |
*** gyee has joined #openstack-keystone | 18:52 | |
*** ChanServ sets mode: +v gyee | 18:52 | |
*** hrou has joined #openstack-keystone | 18:54 | |
*** roxanaghe has joined #openstack-keystone | 18:55 | |
*** jecarey has joined #openstack-keystone | 18:58 | |
*** ankita_w_ has joined #openstack-keystone | 19:00 | |
dstanek | it looks like stuff is really getting done today! | 19:01 |
*** jorge_munoz has joined #openstack-keystone | 19:01 | |
*** tsymancz1k has joined #openstack-keystone | 19:02 | |
*** roxanaghe has quit IRC | 19:02 | |
*** jbonjean has quit IRC | 19:03 | |
*** ankita_wagh has quit IRC | 19:03 | |
*** jbonjean has joined #openstack-keystone | 19:04 | |
htruta_ | dstanek, what we saw that could be removed won't make such a difference | 19:04 |
dstanek | htruta_: but that patch may get merged quickly :-) | 19:04 |
htruta_ | it's just some get_project_by_name calls that can be be moved forward | 19:04 |
dstanek | htruta_: i'm not trying to make you do more work for this one. i think it's important to consider for future patches though | 19:05 |
htruta_ | dstanek, we hope so :) | 19:05 |
dstanek | htruta_: if reviews can look at a patch in a few mins then it's much faster to approve. some of the HMT stuff has taken much longer than that | 19:06 |
htruta_ | dstanek, totally agreed | 19:06 |
*** tsymancz1k has quit IRC | 19:07 | |
dstanek | htruta_: some of your patches don't get past my next-review filters. i've been playing with a new one that won't show me reviews with >1000 lines of change | 19:07 |
htruta_ | dstanek, that's only one of our patches :( | 19:08 |
htruta_ | dstanek, so, are we okay with this one you've just reviewed? considering your comments were addressed | 19:09 |
htruta_ | I'll move to the next ones and try to make them pass your filter | 19:09 |
*** jecarey has quit IRC | 19:11 | |
*** jecarey has joined #openstack-keystone | 19:15 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Remove deprecated methods from assignment.Manager https://review.openstack.org/210174 | 19:16 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Stop calling deprecated assignment manager methods https://review.openstack.org/210455 | 19:16 |
*** e0ne has joined #openstack-keystone | 19:17 | |
bknudson | here's another easy one: https://review.openstack.org/#/c/189027/ | 19:19 |
bknudson | here's another easy one: https://review.openstack.org/#/c/189028/ | 19:20 |
*** piyanai has quit IRC | 19:20 | |
openstackgerrit | Merged openstack/keystone: Remove unnecessary check from notifications.py https://review.openstack.org/203069 | 19:22 |
opilotte | here's another easy one: https://review.openstack.org/#/c/210581/ | 19:22 |
openstackgerrit | Olivier Pilotte proposed openstack/keystone: Keystone accepts Group IDs from the IdP without any Domain reference https://review.openstack.org/210581 | 19:26 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Update apache config doc for stevedore drivers https://review.openstack.org/210590 | 19:26 |
*** ayoung has quit IRC | 19:27 | |
dstanek | bknudson: for https://review.openstack.org/#/c/189027/ where are those options actually used? i wanted to verify the default values | 19:30 |
bknudson | it'll be in common.ldap somewhere... | 19:30 |
bknudson | dstanek: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/ldap/core.py#n1163 | 19:31 |
*** narengan has quit IRC | 19:32 | |
openstackgerrit | Merged openstack/keystone: Test to ensure fernet key rotation results in new key sets https://review.openstack.org/192817 | 19:32 |
openstackgerrit | Merged openstack/keystone: Cleanup tearDown in unit tests https://review.openstack.org/207753 | 19:32 |
openstackgerrit | Merged openstack/keystone: Register fatal_deprecations before use https://review.openstack.org/201352 | 19:32 |
*** narengan has joined #openstack-keystone | 19:33 | |
dstanek | bknudson: thx, i guess that's why a grep didn't find it | 19:33 |
openstackgerrit | Merged openstack/keystone: NotificationsTestCase running in isolation https://review.openstack.org/204739 | 19:34 |
openstackgerrit | Merged openstack/keystone: Use extras for ldap dependencies https://review.openstack.org/207602 | 19:34 |
*** narengan_ has joined #openstack-keystone | 19:34 | |
dstanek | opilotte: your commit message summary is a bit long | 19:35 |
*** piyanai has joined #openstack-keystone | 19:37 | |
*** narengan has quit IRC | 19:37 | |
*** ankita_wagh has joined #openstack-keystone | 19:39 | |
*** ayoung has joined #openstack-keystone | 19:40 | |
*** ChanServ sets mode: +v ayoung | 19:40 | |
*** boris-42 has joined #openstack-keystone | 19:40 | |
*** ankita_w_ has quit IRC | 19:41 | |
openstackgerrit | Henrique Truta proposed openstack/keystone: Add is_domain field in Project Table https://review.openstack.org/157427 | 19:46 |
*** ParsectiX has joined #openstack-keystone | 19:49 | |
openstackgerrit | Merged openstack/keystone: Adds/updates notifications test cases https://review.openstack.org/210476 | 19:49 |
openstackgerrit | Merged openstack/keystone: Assignment driver cleaning https://review.openstack.org/209624 | 19:50 |
*** topol has quit IRC | 19:51 | |
*** tsymanczyk has joined #openstack-keystone | 19:53 | |
*** tsymanczyk is now known as Guest12491 | 19:53 | |
*** ayoung has quit IRC | 19:56 | |
openstackgerrit | David Stanek proposed openstack/keystone: Adds a notification testcase for unbound methods https://review.openstack.org/210478 | 19:56 |
openstackgerrit | David Stanek proposed openstack/keystone: Fixes an incorrect docstring in notifications https://review.openstack.org/210477 | 19:56 |
openstackgerrit | David Stanek proposed openstack/keystone: Remove excessive transformation to list https://review.openstack.org/201648 | 19:56 |
*** rm_work|away is now known as rm_work | 19:57 | |
*** iamjarvo has quit IRC | 19:57 | |
*** piyanai has quit IRC | 19:57 | |
openstackgerrit | David Stanek proposed openstack/keystone: Adds a notification testcase for unbound methods https://review.openstack.org/210478 | 20:00 |
openstackgerrit | David Stanek proposed openstack/keystone: Fixes an incorrect docstring in notifications https://review.openstack.org/210477 | 20:00 |
openstackgerrit | David Stanek proposed openstack/keystone: Remove excessive transformation to list https://review.openstack.org/201648 | 20:00 |
*** petertr7 is now known as petertr7_away | 20:02 | |
*** Guest12491 has quit IRC | 20:04 | |
*** piyanai has joined #openstack-keystone | 20:05 | |
*** chlong has quit IRC | 20:06 | |
*** petertr7_away is now known as petertr7 | 20:07 | |
*** ayoung has joined #openstack-keystone | 20:08 | |
*** ChanServ sets mode: +v ayoung | 20:08 | |
*** lhcheng has quit IRC | 20:09 | |
*** gordc has quit IRC | 20:09 | |
dolphm | stevemar: it took most of the day, but i finally got through all those tabs. down to 5! | 20:10 |
*** ayoung has quit IRC | 20:13 | |
*** tsymancz1k has joined #openstack-keystone | 20:15 | |
*** narengan_ has quit IRC | 20:16 | |
*** narengan has joined #openstack-keystone | 20:17 | |
dstanek | dolphm: nice. i have 10 alone that are for vim plugins that i want to look at tonight | 20:18 |
*** narengan has quit IRC | 20:21 | |
openstackgerrit | Dan Nguyen proposed openstack/python-keystoneclient: Add include_subtree to role_list_assignments call https://review.openstack.org/188184 | 20:22 |
openstackgerrit | Dan Nguyen proposed openstack/python-keystoneclient: Add include_subtree to role_list_assignments call https://review.openstack.org/188184 | 20:23 |
raildo | stevemar: ping, can you approve this bp? https://blueprints.launchpad.net/keystone/+spec/list-credentials-by-type | 20:27 |
*** lhcheng has joined #openstack-keystone | 20:28 | |
*** ChanServ sets mode: +v lhcheng | 20:28 | |
*** lhcheng has quit IRC | 20:28 | |
*** lhcheng has joined #openstack-keystone | 20:28 | |
*** ChanServ sets mode: +v lhcheng | 20:28 | |
dolphm | raildo: the spec is already merged | 20:28 |
raildo | dolphm: yes, but bknudson give us a -1 in the implementation, since the bp was not approved for liberty, and this makes sense. | 20:29 |
*** jorge_munoz has quit IRC | 20:30 | |
*** narengan has joined #openstack-keystone | 20:30 | |
dolphm | raildo: milestone targeting is something you can do yourself. if you think you can land it in a specific milestone, you should use the milestone targeting to communicate that. | 20:30 |
dolphm | raildo: bknudson: the "Direction" "Needs approval" / "Approved" has absolutely zero consequence. traditionally, we've used that field to indicate whether the blueprint title contains a pun or not | 20:31 |
raildo | dolphm: hum... I tought that some keystone-core have to do this. | 20:31 |
raildo | thought* | 20:32 |
dolphm | raildo: cores / PTL end up doing it because no one updates their own blueprints statuses until they're harassed about it | 20:32 |
dolphm | raildo: use those fields to realistically communicate your progress | 20:33 |
raildo | dolphm: ok, thanks for the tips :) | 20:33 |
*** topol has joined #openstack-keystone | 20:34 | |
*** ChanServ sets mode: +v topol | 20:34 | |
stevemar | dolphm: congrats! | 20:35 |
*** iurygregory has left #openstack-keystone | 20:39 | |
dgonzalez | Hi all, i think i may have encountered a bug with the region filtering in endpoint list in keystone. | 20:42 |
dgonzalez | When i run “openstack endpoint list --os-url http://192.168.33.10:5000/v3 --os-identity-api-version=3 --service identity --interface public --region RegionTwo --debug” i would expect that it only lists endpoints from RegionTwo. But i get the identity endpoint from RegionOne. I get the following in the debug output: http://paste.openstack.org/show/412228/. | 20:42 |
dgonzalez | Any ideas what might cause this? | 20:42 |
dolphm | dgonzalez: endpoint list is an administrative command designed to allow you to operate on keystone's configuration -- it's not showing you a service catalog tailored to your auth context | 20:43 |
dolphm | dgonzalez: err, i read that as --os-region ... i think you're correct and that's just a lack of filtering implemented somewhere | 20:44 |
dolphm | dgonzalez: https://bugs.launchpad.net/python-openstackclient/+filebug ! | 20:45 |
dgonzalez | dolphm: Yes i agree. This causes problems with devstack in a multi-region setup, because the second region will not register any services, because it thinks all endpoints do already exist for its region | 20:45 |
*** jbonjean has left #openstack-keystone | 20:45 | |
dgonzalez | Ok will do that | 20:45 |
dolphm | stevemar: ^ | 20:45 |
dgonzalez | dolphm: But i don't think this is a problem with python-openstackclient. As you can see in my snippet from the debug output, the region parameter is passed to keystone | 20:47 |
dgonzalez | I would suspect that keystone does the filtering | 20:47 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Add is_domain field in Project Table https://review.openstack.org/157427 | 20:47 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Change project name constraints https://review.openstack.org/158372 | 20:48 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Add is_domain parameter to get_project_by_name https://review.openstack.org/210600 | 20:48 |
rodrigods | dstanek, almost 50 lines smaller ^ | 20:48 |
dstanek | rodrigods: lol, getting there! | 20:49 |
*** e0ne has quit IRC | 20:49 | |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Changing UnexpectedError exception to Unauthorized exception https://review.openstack.org/200868 | 20:49 |
*** piyanai has quit IRC | 20:52 | |
*** piyanai has joined #openstack-keystone | 20:52 | |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Add is_domain field in Project Table https://review.openstack.org/157427 | 20:55 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Change project name constraints https://review.openstack.org/158372 | 20:55 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Add is_domain parameter to get_project_by_name https://review.openstack.org/210600 | 20:55 |
lbragstad | dolphm: dstanek re the manager api not being stable? what was discussed in IRC, I think I missed it | 20:56 |
lbragstad | https://review.openstack.org/#/c/210174/4 | 20:56 |
lbragstad | whatever was discussed in IRC, i'll post in the review so the reason is persisted there. | 20:57 |
dstanek | lbragstad: that the manager interface really isn't stable | 20:57 |
*** raildo has quit IRC | 20:57 | |
lbragstad | dstanek: was it changed without deprecations previously? | 20:58 |
*** piyanai has quit IRC | 20:58 | |
dstanek | lbragstad: yeah, we have done that in the past | 20:59 |
lbragstad | gotcha | 20:59 |
*** htruta_ has quit IRC | 20:59 | |
*** topol has quit IRC | 20:59 | |
*** ankita_w_ has joined #openstack-keystone | 21:00 | |
*** topol has joined #openstack-keystone | 21:00 | |
*** ChanServ sets mode: +v topol | 21:00 | |
*** htruta has quit IRC | 21:02 | |
*** ankita_wagh has quit IRC | 21:03 | |
*** topol has quit IRC | 21:04 | |
*** ayoung has joined #openstack-keystone | 21:04 | |
*** ChanServ sets mode: +v ayoung | 21:04 | |
*** topol has joined #openstack-keystone | 21:05 | |
*** ChanServ sets mode: +v topol | 21:05 | |
*** phalmos has joined #openstack-keystone | 21:06 | |
*** piyanai has joined #openstack-keystone | 21:08 | |
*** ayoung has quit IRC | 21:10 | |
*** roxanaghe has joined #openstack-keystone | 21:11 | |
*** mylu has quit IRC | 21:13 | |
*** ayoung has joined #openstack-keystone | 21:13 | |
*** ChanServ sets mode: +v ayoung | 21:13 | |
*** roxanaghe has quit IRC | 21:13 | |
*** roxanaghe has joined #openstack-keystone | 21:14 | |
*** phalmos has quit IRC | 21:16 | |
*** topol has quit IRC | 21:17 | |
*** ParsectiX has quit IRC | 21:17 | |
*** topol has joined #openstack-keystone | 21:17 | |
*** ChanServ sets mode: +v topol | 21:17 | |
*** gyee has quit IRC | 21:18 | |
*** ParsectiX has joined #openstack-keystone | 21:19 | |
*** _hrou_ has joined #openstack-keystone | 21:19 | |
*** petertr7 is now known as petertr7_away | 21:20 | |
*** hrou has quit IRC | 21:20 | |
stevemar | dolphm: re: https://review.openstack.org/#/c/210204/ - do you still have issues with it? | 21:21 |
stevemar | did you want to keep the filter definition in paste? | 21:21 |
*** ayoung has quit IRC | 21:21 | |
*** topol has quit IRC | 21:22 | |
dolphm | stevemar: only if it's not redundant | 21:24 |
*** _hrou_ has quit IRC | 21:24 | |
dstanek | we certainly love cyclic dependencies! | 21:24 |
stevemar | dolphm: i think it would be, since it's loaded by default now | 21:25 |
dstanek | dolphm: since that was moved from middleware to a real router, why keep the middleware in paste? | 21:25 |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Improve a few random docstrings (H405) https://review.openstack.org/210607 | 21:25 |
*** phalmos has joined #openstack-keystone | 21:26 | |
stevemar | dolphm: any change of you being in austin between aug24 and sept4 ? | 21:26 |
dolphm | stevemar: uhh, am i supposed to be in austin then? | 21:26 |
stevemar | dolphm: nope, i'll be there for ibm stuff | 21:26 |
dolphm | stevemar: that's a long time | 21:27 |
stevemar | dolphm: you should come and hang out in there :) | 21:27 |
stevemar | yes :\ | 21:27 |
dstanek | stevemar: cool, i'll be in SAT for some of that time | 21:27 |
dolphm | stevemar: why yes, i'd be happy to go to salt lick | 21:27 |
dolphm | dstanek: oooh | 21:27 |
stevemar | topol will be missing out :P | 21:27 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Limit subtree and parents queries https://review.openstack.org/209132 | 21:27 |
stevemar | dolphm dstanek and stevemar go to salt lick, it's been decided! | 21:27 |
*** markvoelker has quit IRC | 21:28 | |
dstanek | i'm in SAT from Aug 30 - Sep 4 | 21:28 |
dolphm | lbragstad: ^ | 21:28 |
dstanek | what is salt lick? | 21:28 |
dolphm | dstanek: https://www.saltlickbbq.com/ | 21:28 |
dolphm | stevemar: dstanek: lbragstad: let's sync up closer to august 30 and pick a day that we can all meet somewhere up there | 21:28 |
dolphm | (if not salt lick) | 21:28 |
openstackgerrit | Merged openstack/keystone: Document default value for tree_dn options https://review.openstack.org/189027 | 21:29 |
openstackgerrit | Merged openstack/keystone: Remove unnecessary code for default suffix https://review.openstack.org/189028 | 21:30 |
dolphm | happy friday all - i'm going to go outside now | 21:30 |
*** mylu has joined #openstack-keystone | 21:30 | |
dstanek | dolphm: stevemar lbragstad: sounds like a plan to me | 21:31 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/210609 | 21:31 |
stevemar | dolphm: see ya! | 21:32 |
stevemar | dstanek: its the place where topol ate 2 lbs of brisket | 21:32 |
*** phalmos has quit IRC | 21:32 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/210609 | 21:32 |
*** htruta_ has joined #openstack-keystone | 21:37 | |
dstanek | stevemar: i wonder if that's why he can't run... | 21:37 |
stevemar | dstanek: lol | 21:37 |
stevemar | dstanek: eating 2 lbs of anything will make it hard to run | 21:41 |
*** tsymancz1k has quit IRC | 21:42 | |
openstackgerrit | Merged openstack/keystone: Remove oslo import hacking check https://review.openstack.org/208216 | 21:42 |
openstackgerrit | Merged openstack/keystone: Fix explicit line joining with backslash https://review.openstack.org/209768 | 21:43 |
*** narengan has quit IRC | 21:44 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/210609 | 21:44 |
*** narengan has joined #openstack-keystone | 21:45 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/210609 | 21:46 |
*** annasort has quit IRC | 21:47 | |
*** narengan has quit IRC | 21:49 | |
lbragstad | dstanek: dolphm stevemar works for me! | 21:49 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Improve a few random docstrings (H405) https://review.openstack.org/210607 | 21:50 |
openstackgerrit | David Stanek proposed openstack/keystone: Adds backend check to setup of LDAP tests https://review.openstack.org/210087 | 21:57 |
openstackgerrit | Merged openstack/keystone: Fix duplicate-key pylint issue https://review.openstack.org/210300 | 21:58 |
openstackgerrit | Merged openstack/keystone: Stop calling deprecated assignment manager methods https://review.openstack.org/210455 | 22:02 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/210609 | 22:03 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/210609 | 22:04 |
henrynash | stevemar: hey…and chance you could look at https://review.openstack.org/#/c/137202/ - looking like it’s ready to go | 22:04 |
*** woodster_ has joined #openstack-keystone | 22:08 | |
jamielennox | breton: i'm not here, but if you look at the plugins you want to use get_connection_parameteres and get_headers instead of get_token | 22:09 |
*** henrynash has quit IRC | 22:14 | |
*** piyanai has quit IRC | 22:14 | |
*** tsymanczyk has joined #openstack-keystone | 22:17 | |
*** tsymanczyk is now known as Guest65432 | 22:17 | |
*** dims_ has joined #openstack-keystone | 22:18 | |
*** edmondsw has quit IRC | 22:21 | |
openstackgerrit | Olivier Pilotte proposed openstack/keystone: Keystone accepts Group IDs from the IdP without any Domain reference https://review.openstack.org/210581 | 22:22 |
*** dimsum__ has quit IRC | 22:22 | |
*** stevemar has quit IRC | 22:24 | |
breton | jamielennox: thank you! | 22:25 |
openstackgerrit | Merged openstack/keystone: Fernet 'expires' value loses 'ms' after validation https://review.openstack.org/210037 | 22:28 |
*** markvoelker has joined #openstack-keystone | 22:28 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/210609 | 22:29 |
*** r-daneel has quit IRC | 22:31 | |
*** rharwood has quit IRC | 22:33 | |
*** markvoelker has quit IRC | 22:33 | |
*** rharwood has joined #openstack-keystone | 22:36 | |
openstackgerrit | David Stanek proposed openstack/keystone: Adds a notification testcase for unbound methods https://review.openstack.org/210478 | 22:42 |
*** bradjones has quit IRC | 22:49 | |
openstackgerrit | Merged openstack/keystone: Remove excessive transformation to list https://review.openstack.org/201648 | 22:50 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/210609 | 22:51 |
*** bradjones has joined #openstack-keystone | 22:55 | |
*** bradjones has quit IRC | 22:55 | |
*** bradjones has joined #openstack-keystone | 22:55 | |
*** Guest65432 has quit IRC | 23:00 | |
*** mylu has quit IRC | 23:01 | |
opilotte | dstanek: updated code with tests: https://review.openstack.org/#/c/210581/ | 23:04 |
*** zzzeek has quit IRC | 23:12 | |
*** topol has joined #openstack-keystone | 23:22 | |
*** ChanServ sets mode: +v topol | 23:22 | |
*** tsymanczyk has joined #openstack-keystone | 23:40 | |
*** tsymanczyk is now known as Guest30753 | 23:40 | |
*** jasonsb has quit IRC | 23:45 | |
*** ankita_w_ has quit IRC | 23:47 | |
*** ParsectiX has quit IRC | 23:58 | |
*** markvoelker has joined #openstack-keystone | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!