| openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Identity plugin thread safety https://review.openstack.org/221551 | 00:06 |
|---|---|---|
| *** fangzhou has joined #openstack-keystone | 00:06 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystone: Reject rule if assertion type unset https://review.openstack.org/216088 | 00:09 |
| *** markvoelker has quit IRC | 00:10 | |
| *** shoutm has quit IRC | 00:18 | |
| *** shoutm has joined #openstack-keystone | 00:21 | |
| *** shadower has quit IRC | 00:23 | |
| *** shadower has joined #openstack-keystone | 00:23 | |
| *** btully has quit IRC | 00:25 | |
| *** dsirrine has quit IRC | 00:28 | |
| *** tiny-hands has joined #openstack-keystone | 00:30 | |
| *** markvoelker has joined #openstack-keystone | 00:31 | |
| *** gyee has quit IRC | 00:33 | |
| *** topol has joined #openstack-keystone | 00:35 | |
| *** ChanServ sets mode: +v topol | 00:35 | |
| *** shoutm_ has joined #openstack-keystone | 00:38 | |
| *** topol has quit IRC | 00:40 | |
| *** shoutm has quit IRC | 00:40 | |
| *** jasonsb has joined #openstack-keystone | 00:41 | |
| *** geoffarnold has quit IRC | 00:41 | |
| *** dsirrine has joined #openstack-keystone | 00:42 | |
| *** dims__ has quit IRC | 00:46 | |
| *** dims__ has joined #openstack-keystone | 00:47 | |
| *** jacorob has quit IRC | 00:47 | |
| *** mhu has quit IRC | 00:48 | |
| *** hockeynut_afk has quit IRC | 00:48 | |
| *** lbragstad has quit IRC | 00:48 | |
| *** erhudy has quit IRC | 00:48 | |
| *** eglute_s has quit IRC | 00:48 | |
| *** gus has quit IRC | 00:48 | |
| *** Nakato has quit IRC | 00:48 | |
| *** darrenc has quit IRC | 00:48 | |
| *** sudorandom has quit IRC | 00:48 | |
| *** Guest75828 has quit IRC | 00:48 | |
| *** erhudy has joined #openstack-keystone | 00:48 | |
| *** darrenc has joined #openstack-keystone | 00:49 | |
| *** ayoung_ has quit IRC | 00:49 | |
| *** ayoung has quit IRC | 00:49 | |
| *** jamielennox has quit IRC | 00:49 | |
| *** flwang has quit IRC | 00:49 | |
| *** sigmavirus24_awa has quit IRC | 00:49 | |
| *** dolphm has quit IRC | 00:49 | |
| *** shoutm_ has quit IRC | 00:50 | |
| *** shoutm has joined #openstack-keystone | 00:50 | |
| *** rm_work has quit IRC | 00:50 | |
| *** d34dh0r53 has quit IRC | 00:50 | |
| *** comstud has quit IRC | 00:50 | |
| *** Nakato has joined #openstack-keystone | 00:50 | |
| *** mgagne has quit IRC | 00:50 | |
| *** gus has joined #openstack-keystone | 00:51 | |
| *** dtroyer has quit IRC | 00:51 | |
| *** blewis has joined #openstack-keystone | 00:53 | |
| *** d34dh0r53 has joined #openstack-keystone | 00:53 | |
| *** comstud has joined #openstack-keystone | 00:53 | |
| *** eglute has joined #openstack-keystone | 00:53 | |
| *** rm_work has joined #openstack-keystone | 00:53 | |
| *** rm_work has quit IRC | 00:53 | |
| *** rm_work has joined #openstack-keystone | 00:53 | |
| *** blewis is now known as Guest18499 | 00:53 | |
| *** hockeynut has joined #openstack-keystone | 00:53 | |
| *** mgagne has joined #openstack-keystone | 00:54 | |
| *** jamielennox has joined #openstack-keystone | 00:54 | |
| *** ChanServ sets mode: +v jamielennox | 00:54 | |
| *** sigmavirus24_awa has joined #openstack-keystone | 00:54 | |
| *** lbragstad has joined #openstack-keystone | 00:54 | |
| *** sudorandom has joined #openstack-keystone | 00:54 | |
| *** dtroyer has joined #openstack-keystone | 00:54 | |
| *** ayoung_ has joined #openstack-keystone | 00:54 | |
| *** dolphm has joined #openstack-keystone | 00:54 | |
| *** ChanServ sets mode: +o dolphm | 00:54 | |
| *** jacorob has joined #openstack-keystone | 00:54 | |
| *** ayoung has joined #openstack-keystone | 00:54 | |
| *** ChanServ sets mode: +v ayoung | 00:54 | |
| *** flwang has joined #openstack-keystone | 00:56 | |
| *** mhu has joined #openstack-keystone | 00:56 | |
| *** stevemar has quit IRC | 00:58 | |
| *** stevemar has joined #openstack-keystone | 00:59 | |
| *** ChanServ sets mode: +v stevemar | 00:59 | |
| *** zzzeek has quit IRC | 01:01 | |
| openstackgerrit | Merged openstack/keystone: Remove padding from Fernet tokens https://review.openstack.org/220242 | 01:05 |
| *** ankita___ has quit IRC | 01:06 | |
| *** tsymanczyk has quit IRC | 01:15 | |
| *** diazjf has quit IRC | 01:15 | |
| *** diazjf has joined #openstack-keystone | 01:16 | |
| *** lhcheng has quit IRC | 01:21 | |
| *** madhu_ak has quit IRC | 01:23 | |
| *** darrenc is now known as darrenc_afk | 01:42 | |
| *** ankita_wagh has joined #openstack-keystone | 01:43 | |
| *** tiny-hands has quit IRC | 01:45 | |
| *** nakamura has joined #openstack-keystone | 01:54 | |
| *** geoffarnold has joined #openstack-keystone | 01:59 | |
| *** diazjf has left #openstack-keystone | 02:00 | |
| *** tsymanczyk has joined #openstack-keystone | 02:00 | |
| *** tsymanczyk is now known as Guest26514 | 02:00 | |
| *** geoffarnold has quit IRC | 02:03 | |
| *** geoffarnold has joined #openstack-keystone | 02:05 | |
| *** sdake_ is now known as sdake | 02:06 | |
| *** davechen has joined #openstack-keystone | 02:08 | |
| *** darrenc_afk is now known as darrenc | 02:17 | |
| *** davechen has quit IRC | 02:18 | |
| *** ankita_wagh has quit IRC | 02:19 | |
| *** davechen has joined #openstack-keystone | 02:21 | |
| *** ayoung has quit IRC | 02:22 | |
| *** ayoung_ is now known as ayoung | 02:23 | |
| openstackgerrit | Dave Chen proposed openstack/keystonemiddleware: update middlewarearchitecture.rst https://review.openstack.org/219162 | 02:24 |
| *** topol has joined #openstack-keystone | 02:25 | |
| *** ChanServ sets mode: +v topol | 02:25 | |
| *** sdake_ has joined #openstack-keystone | 02:26 | |
| davechen | Try to test the patch in the KSM again with the patch from lhcheng | 02:26 |
| *** sdake has quit IRC | 02:29 | |
| *** topol has quit IRC | 02:30 | |
| *** fangzhou has quit IRC | 02:31 | |
| *** markvoelker has quit IRC | 02:31 | |
| *** sdake has joined #openstack-keystone | 02:32 | |
| *** sdake_ has quit IRC | 02:35 | |
| *** woodster_ has quit IRC | 02:39 | |
| *** richm has quit IRC | 02:42 | |
| *** Nirupama has joined #openstack-keystone | 02:44 | |
| *** lhcheng has joined #openstack-keystone | 02:50 | |
| *** ChanServ sets mode: +v lhcheng | 02:50 | |
| davechen | lhcheng: ping? | 02:52 |
| davechen | lhcheng: good to see you are online again. | 02:53 |
| *** shoutm has quit IRC | 02:55 | |
| *** albertom has quit IRC | 02:56 | |
| *** dims_ has joined #openstack-keystone | 02:56 | |
| *** dims__ has quit IRC | 02:58 | |
| *** albertom has joined #openstack-keystone | 02:58 | |
| lhcheng | davechen: hello! how is it going? | 03:04 |
| lhcheng | davechen: hope you didn't mind that I submitted a patch for KSC, since it is marked as critical, wanted to go ahead submit the patch. | 03:05 |
| *** shoutm has joined #openstack-keystone | 03:06 | |
| davechen | lhcheng: I saw you patch, nice! | 03:06 |
| davechen | lhcheng: I tried one patch in KSM which depends on that patch but still failed | 03:06 |
| davechen | lhcheng: of course, I need thanks you for digging it out. | 03:06 |
| davechen | lhcheng: I am also take some time to work on that bug but quite not understand the root cause. | 03:06 |
| lhcheng | davechen: I saw your note about keystonemiddleware test still failing.. I don't think using Depends-On on the middleware patch will work, because the test will run against a released version of KSC not from master. | 03:06 |
| davechen | https://review.openstack.org/219162 | 03:06 |
| davechen | see this patch pls | 03:06 |
| stevemar | lhcheng: i didn't forget about your DOA patch :) | 03:07 |
| davechen | has a cross-dependencies on your patch. | 03:07 |
| davechen | but still failed, I tried to test with my fixing in this way and also failed at last. | 03:07 |
| * lhcheng thinks stevemar has psychic power to predict :P | 03:07 | |
| stevemar | maybe i do, maybe i don't | 03:08 |
| lhcheng | davechen: so yeah, the middleware tests runs against a release version of KSC | 03:09 |
| lhcheng | davechen: if you look at the log, you can see it will install: keystoneclient==1.7.0 | 03:09 |
| davechen | lhcheng: I think so, but it work if this is in one project, right? | 03:09 |
| lhcheng | davechen: this doesn't work because of the way the test is setup. since it will install from requirements.txt, and install only released version. | 03:11 |
| *** mylu_ has quit IRC | 03:12 | |
| lhcheng | davechen: I think it could still work on cross-projects, provided that the tests pull the code of dependent project from master. | 03:12 |
| davechen | lhcheng: yeah, 1.7.0 is the current tag of KSC. | 03:13 |
| davechen | lhcheng: I see, thanks. | 03:13 |
| davechen | but it's not, right? | 03:13 |
| lhcheng | davechen: for this case, it's not :) | 03:13 |
| davechen | And do you have idea why "self.session.request" raise exceptions.ConnectionError instead of request.exceptions.ConnectionError | 03:14 |
| davechen | I am stuck in this point. | 03:14 |
| lhcheng | same reason why the problem only show up after KSC was released | 03:14 |
| lhcheng | because middleware tests only runs against released package | 03:14 |
| *** mylu has joined #openstack-keystone | 03:15 | |
| davechen | https://review.openstack.org/#/c/220736/2/keystoneclient/session.py, I know this is not the correct way to fix it, but it really raise exceptions.ConnectionError here. | 03:16 |
| lhcheng | yeah, likely because of: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py#L1522-L1523 | 03:18 |
| davechen | I will look it further, let's get your patch in first. | 03:18 |
| lhcheng | ConnectionError is the same as ConnectionRefused before in KSC, so it was raising ConnectionRefused before | 03:19 |
| davechen | it raises ConnectionRefused before since the exception is not catched in KSC properly. | 03:22 |
| davechen | I think the logic want to catch ConnectionError exception and then re-raise ConnectionRefused | 03:22 |
| davechen | then everyting is okay. | 03:22 |
| davechen | but ConnectionError exception didn't catched in KSC, so it raise ConnectionError and KSM broken here. | 03:23 |
| davechen | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/session.py#L428-L430 | 03:24 |
| lhcheng | that is from requests.exceptions not from KSC | 03:25 |
| lhcheng | there is some opportunity for cleanup, however we can't do it without breaking backward compatibility | 03:26 |
| *** csoukup has joined #openstack-keystone | 03:28 | |
| davechen | yeah, that's what make me confused and depressed, since it really raise the exception defined in KSC (exceptions.ConnectionError). | 03:28 |
| davechen | ConnectionError=ConnectionRefused is properly the workaround for this. | 03:29 |
| davechen | although it | 03:29 |
| davechen | although it is what we did for backward compatibility | 03:29 |
| davechen | anyway, I need take some time to dig into this. | 03:30 |
| *** ayoung has quit IRC | 03:30 | |
| lhcheng | davechen: yup, have to dig further to figure out if we can clean this up. But for now, we should revert back that line. | 03:30 |
| *** geoffarnold is now known as geoffarnoldX | 03:31 | |
| davechen | sure, let'd do it ASAP, it break us for several days. | 03:31 |
| *** markvoelker has joined #openstack-keystone | 03:31 | |
| *** dolphm has quit IRC | 03:33 | |
| *** ankita_wagh has joined #openstack-keystone | 03:33 | |
| *** geoffarnoldX is now known as geoffarnold | 03:33 | |
| *** sdake_ has joined #openstack-keystone | 03:34 | |
| *** sdake has quit IRC | 03:35 | |
| *** sdake has joined #openstack-keystone | 03:35 | |
| *** markvoelker has quit IRC | 03:36 | |
| jamielennox | lhcheng, davechen: you might find (hopefully) that some of this is cleaned up with kestoneauth | 03:37 |
| *** dolphm has joined #openstack-keystone | 03:38 | |
| *** ChanServ sets mode: +o dolphm | 03:38 | |
| *** sdake_ has quit IRC | 03:39 | |
| davechen | jamielennox: copy that, will look into keystoneauth as well, thanks. | 03:39 |
| lhcheng | \o/ | 03:39 |
| morgan | Yeah need to fix and release keystoneclient | 03:40 |
| morgan | If we want to unbreak these things due to the way cross gating works | 03:40 |
| jamielennox | morgan: yep, i haven't seen lhcheng's patch yet | 03:40 |
| davechen | https://review.openstack.org/#/c/221543/ | 03:41 |
| jamielennox | approved | 03:41 |
| morgan | Though keystoneauth should make this easier as we can more easily cross gate on master changes. Ksc has a wider audience | 03:41 |
| jamielennox | well in ksa i removed all the weird rename hacks | 03:41 |
| morgan | Yesh | 03:41 |
| jamielennox | so i'm not sure it's better but at least that shouldn't be a thing anymore | 03:41 |
| lhcheng | yeah, I wonder if there is a smarter way to gate the client packages. we only hit the issue after a client is released. | 03:42 |
| jamielennox | just people will need to update to catch keystoneauth errors instead of keystoneclient errors | 03:42 |
| morgan | jamielennox: once that merges propose a new 1.7.1 to releases repo | 03:42 |
| morgan | Plz | 03:42 |
| morgan | Or i will tomorrow | 03:42 |
| morgan | So we can release/unbreak | 03:42 |
| lhcheng | morgan: are we still on for KSA release in L? | 03:43 |
| morgan | lhcheng: 1.0 is out | 03:43 |
| lhcheng | oh... | 03:43 |
| morgan | And it should be in g-r | 03:43 |
| lhcheng | yay | 03:43 |
| morgan | :) | 03:43 |
| lhcheng | awesome | 03:44 |
| *** ayoung has joined #openstack-keystone | 03:44 | |
| *** ChanServ sets mode: +v ayoung | 03:44 | |
| morgan | We should get django_openstack_auth using it | 03:44 |
| morgan | If we got django_openstack_auth and keystonemiddleware on keystoneauth i'd be stoked | 03:45 |
| lhcheng | Paulo already started working on it: https://review.openstack.org/#/c/205251/ | 03:45 |
| morgan | Woot | 03:45 |
| stevemar | nixe | 03:45 |
| stevemar | nice | 03:45 |
| * stevemar wonders if osc should use ksa | 03:46 | |
| morgan | stevemar: yes. | 03:46 |
| stevemar | we still need ksc anyway | 03:46 |
| stevemar | but i'm assuming the auth bits will be removed there | 03:46 |
| morgan | Ksc wont have session in it | 03:47 |
| morgan | Yeah | 03:47 |
| stevemar | yep | 03:47 |
| morgan | Keystoneauth will be the only place for that stuff | 03:47 |
| morgan | jamielennox: can we move cms to keystonemiddleware? | 03:47 |
| morgan | jamielennox: it doesnt really belong in keystoneclient. And keystone uses both. | 03:47 |
| jamielennox | lhcheng: don't do anything that relies on ksa for L | 03:48 |
| jamielennox | i think it should be out but not depended on | 03:48 |
| jamielennox | morgan: that'd probably be ok, we want keystone to depend on middleware in future anyway | 03:48 |
| morgan | If we use ksa for anything in L, i'd vote keystonemiddleware | 03:48 |
| morgan | jamielennox: that was my thought and wr could drop keystoneclient dep | 03:49 |
| morgan | Except for tests | 03:49 |
| morgan | And that is strictly v2-isms | 03:49 |
| lhcheng | jamielennox: got it. | 03:49 |
| morgan | lhcheng: sdk will start using keystoneauth soon as will shade | 03:50 |
| jamielennox | morgan: yea, it'd be good to approve all that auth_token changes to progress that | 03:50 |
| * lhcheng stamps a -2 on DOA patch to prevent it from merging in L | 03:50 | |
| jamielennox | morgan: i had an item on the agenda for today but i missed the meeting | 03:50 |
| morgan | jamielennox: i missed the meeting too | 03:50 |
| morgan | Mostly | 03:50 |
| jamielennox | morgan: i think we should simply delete the keystoneauth_integration branch of ksc and create a new ksc2 one | 03:50 |
| jamielennox | the stuff that was committed to that branch was under the assumption of ksc1 depending on ksa | 03:51 |
| morgan | Sure? Or is it worth salvaging anything? | 03:51 |
| jamielennox | if we're not going to do that then the drift is more pain that its worth | 03:51 |
| *** dave-mccowan has quit IRC | 03:51 | |
| lhcheng | morgan: sweet! let's get it rolling :) | 03:51 |
| morgan | Ok i'll ask dhellmann to do that and we'll drop in a v2.0 feature branch instead | 03:51 |
| morgan | Based on current master | 03:52 |
| *** davechen is now known as davechen_afk | 03:52 | |
| jamielennox | morgan: cool, i was going to check with bknudson as well but missed him today | 03:52 |
| jamielennox | but most of what he has done to that branch is trying to keep it up to date with master | 03:52 |
| morgan | Yeah check tomrrow and we'll plan for it | 03:52 |
| jamielennox | so i don't expect he'll mind | 03:52 |
| morgan | And we can remove the exclusion of the integration / requirements test | 03:53 |
| jamielennox | right, we won't need that any more because it's released | 03:53 |
| *** davechen_afk has quit IRC | 03:57 | |
| *** davechen has joined #openstack-keystone | 03:58 | |
| *** alex_xu has quit IRC | 04:04 | |
| *** alex_xu has joined #openstack-keystone | 04:05 | |
| *** spandhe has quit IRC | 04:06 | |
| *** Guest26514 has quit IRC | 04:12 | |
| *** dims_ has quit IRC | 04:13 | |
| *** tsymanczyk has joined #openstack-keystone | 04:16 | |
| *** tsymanczyk is now known as Guest94761 | 04:16 | |
| *** hrou has quit IRC | 04:18 | |
| stevemar | jamielennox: help with keystoneauth :P | 04:20 |
| jamielennox | stevemar: oh o, what's up | 04:20 |
| stevemar | from keystoneclient.v2_0 import client -> wheres the client-y bits? | 04:20 |
| jamielennox | ? | 04:20 |
| stevemar | i'm trying to replace this import: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/identity/client.py#L18 | 04:21 |
| stevemar | with something in keystoneauth | 04:21 |
| *** ankita_wagh has quit IRC | 04:21 | |
| stevemar | i'm doing it very mechanically right now :P | 04:21 |
| jamielennox | ok | 04:22 |
| jamielennox | should be fine | 04:22 |
| jamielennox | stevemar: the client bits all still live in ksc, keystoneauth is just like the session and auth plugins | 04:22 |
| stevemar | ksc will still have the client setup bits going forward? | 04:22 |
| stevemar | gotcha | 04:22 |
| stevemar | thats the answer i was looking for | 04:22 |
| stevemar | ! | 04:22 |
| *** lhcheng_ has joined #openstack-keystone | 04:24 | |
| stevemar | jamielennox: another q | 04:26 |
| stevemar | the token_endpoint class that was in ksc, is that now known as 'token'? | 04:26 |
| jamielennox | the setuptools got renamed to admin_token, but please remove OSC adding anything to setuptools | 04:26 |
| *** lhcheng has quit IRC | 04:27 | |
| jamielennox | if OSC knows what class to load then use the class not an entrypoint | 04:27 |
| openstackgerrit | Merged openstack/python-keystoneclient: Adding back exception mapping for ConnectionError https://review.openstack.org/221543 | 04:34 |
| stevemar | jamielennox: i'll toss something up soon | 04:36 |
| stevemar | and add you as a reviewer | 04:36 |
| stevemar | lhcheng_: review for websso stuff is coming up after a short commercial break! | 04:36 |
| jamielennox | stevemar: always a good idea to ping me, too many in the queue otherwise | 04:36 |
| stevemar | fair enough | 04:36 |
| lhcheng_ | stevemar: no rush to do it tonight :) | 04:37 |
| jamielennox | lhcheng_: i do prefer the tuple format, i think the dictionaries aren't intuitive in what is essentially a config file | 04:39 |
| jamielennox | the other comment was about your example config and i don't think it matters so long as you say the actual name doesn't matter it's just the keys have to match | 04:39 |
| lhcheng_ | jamielennox: I am fine either way on the formatting, I think steve like the dict format | 04:40 |
| lhcheng_ | jamielennox: I need a tie-breaker :) | 04:40 |
| jamielennox | stevemar: ^? | 04:40 |
| stevemar | yessum | 04:40 |
| stevemar | i said i like dict :( | 04:40 |
| *** geoffarnold is now known as geoffarnoldX | 04:41 | |
| *** mylu has quit IRC | 04:43 | |
| openstackgerrit | Merged openstack/keystone: Fixed typos in 'developing_drivers' doc https://review.openstack.org/220144 | 04:47 |
| *** btully has joined #openstack-keystone | 04:47 | |
| *** shoutm has quit IRC | 05:01 | |
| lhcheng_ | jamielennox: I am getting some random test failure on keystonemiddleware | 05:01 |
| jamielennox | lhcheng_: and not the one from earlier... | 05:01 |
| lhcheng_ | I just keep on running tox on my local, got P/P/F/F/P/P/F/F | 05:01 |
| lhcheng_ | http://paste.openstack.org/show/451341/ | 05:01 |
| lhcheng_ | davechen tried it on his machine, it seems passing consistently for him | 05:02 |
| davechen | update your oslo log lib. | 05:02 |
| davechen | I remember I meet some problem sometime ago | 05:03 |
| davechen | and update the oslo config fix them. | 05:03 |
| davechen | s/oslo.log/oslo.config | 05:03 |
| jamielennox | and depending on how you're running things do a pip install again so the setuptools entrypoints get refreshed | 05:04 |
| *** shoutm has joined #openstack-keystone | 05:05 | |
| lhcheng_ | pip install on my .tox ? or on my dev machine? | 05:06 |
| jamielennox | if it's tox do a -r for rebuid | 05:06 |
| jamielennox | though it seems unlikely that would be it i think | 05:07 |
| *** Chandan_p has joined #openstack-keystone | 05:12 | |
| *** urulama_ has joined #openstack-keystone | 05:13 | |
| *** urulama_ is now known as urulama | 05:13 | |
| *** geoffarnoldX is now known as geoffarnold | 05:15 | |
| lhcheng_ | no luck, still failing on me now consistently on oslo.config | 05:17 |
| *** geoffarnold is now known as geoffarnoldX | 05:18 | |
| davechen | lhcheng_: anyting changes in your local repo? | 05:20 |
| lhcheng_ | no code changes, just running directly middleware and KSC from master | 05:21 |
| *** clayton has quit IRC | 05:21 | |
| davechen | lhcheng_: maybe this issue is caused by the user-name is configured twice, one is in KSC and the other is from KSM? | 05:22 |
| *** shoutm has quit IRC | 05:22 | |
| davechen | KSM don't have such a configuration options, so it really weird. | 05:23 |
| lhcheng_ | davechen: I can't seem to find where user-name is set | 05:23 |
| davechen | lhcheng_ In KSC. | 05:23 |
| *** clayton has joined #openstack-keystone | 05:26 | |
| davechen | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/auth/identity/v2.py#L189-L195 | 05:26 |
| *** vivekd has joined #openstack-keystone | 05:26 | |
| *** raildo-afk has quit IRC | 05:30 | |
| *** Chandan_p has quit IRC | 05:32 | |
| *** markvoelker has joined #openstack-keystone | 05:32 | |
| *** spandhe has joined #openstack-keystone | 05:32 | |
| openstackgerrit | Jamie Lennox proposed openstack/python-keystoneclient: [WIP] keystoneclient v2 https://review.openstack.org/221596 | 05:33 |
| *** raildo-afk has joined #openstack-keystone | 05:34 | |
| stevemar | jamielennox: so much deleted code | 05:34 |
| jamielennox | stevemar: it mostly all went to ksa rather than just disappeared, but it's still nice | 05:35 |
| stevemar | jamielennox: yep | 05:35 |
| *** markvoelker has quit IRC | 05:37 | |
| *** ekarlso- has joined #openstack-keystone | 05:37 | |
| stevemar | jamielennox: is the s3_token middleware stuff in ksm? | 05:37 |
| jamielennox | stevemar: should be | 05:37 |
| jamielennox | i think - i've never used it myself | 05:37 |
| stevemar | oh right it is - i just remembered that its organized a bit differently | 05:37 |
| stevemar | keystoneclient/openstack/common/apiclient -- good riddance | 05:38 |
| jamielennox | stevemar: :) | 05:39 |
| davechen | stevemar, jamielennox, lhcheng_: pretty easy review, https://review.openstack.org/#/c/217565/, does this make sense? | 05:39 |
| stevemar | davechen: looks good to me | 05:40 |
| stevemar | unless someone says otherwise, i'm +A | 05:40 |
| davechen | stevemar: owesome. | 05:40 |
| jamielennox | davechen: small nits | 05:40 |
| jamielennox | though would prefer to fix the | 05:40 |
| stevemar | jamielennox: weird that memcache_crypt became private, but that's fine | 05:40 |
| stevemar | davechen: address jamie's nits and we'll 2x +2 :P | 05:41 |
| davechen | will do. | 05:41 |
| lhcheng_ | davechen: not sure if this makes a difference, can you try "export TEST_RUN_CONCURRENCY=1" then run the test on your local KSM | 05:43 |
| davechen | sure. | 05:43 |
| *** mylu has joined #openstack-keystone | 05:44 | |
| openstackgerrit | Dave Chen proposed openstack/keystone: Update apache-httpd.rst https://review.openstack.org/217565 | 05:44 |
| *** clayton has quit IRC | 05:45 | |
| *** clayton has joined #openstack-keystone | 05:45 | |
| lhcheng_ | after I set the concurrency to a higher value, the chances of the test failing seem to went down.. | 05:45 |
| davechen | lhcheng_: still pass in my side. | 05:45 |
| davechen | I will try more | 05:45 |
| davechen | stevemar, jamielennox: done :) | 05:46 |
| *** ankita_wagh has joined #openstack-keystone | 05:47 | |
| davechen | lhcheng_ persistent success. | 05:48 |
| stevemar | davechen: one tiny tiny nit :) | 05:48 |
| jamielennox | stevemar: ouch | 05:48 |
| jamielennox | i was going to ignore that | 05:48 |
| stevemar | well, i blame jamielennox | 05:48 |
| stevemar | it's Red Hat in some places and red hat in others. The proper spelling is Red Hat | 05:48 |
| stevemar | since it's a company it gets special capitalization | 05:49 |
| openstackgerrit | Dave Chen proposed openstack/keystone: Update apache-httpd.rst https://review.openstack.org/217565 | 05:49 |
| davechen | stevemar: done this time | 05:49 |
| *** mylu has quit IRC | 05:49 | |
| *** ekarlso- has quit IRC | 05:50 | |
| *** geoffarnoldX is now known as geoffarnold | 05:51 | |
| davechen | better for consistence. | 05:53 |
| lhcheng_ | davechen: thanks for trying it out | 05:53 |
| lhcheng_ | davechen: I wonder if there's a problem with the Config fixture.. still digging into it | 05:54 |
| davechen | lhcheng_ have a good dream, then you will find everyting is fine after you wake up. :) | 05:54 |
| lhcheng_ | davechen: that might be a good idea... | 05:54 |
| lhcheng_ | davechen: will try again tomorrow | 05:54 |
| lhcheng_ | davechen: thanks again for the help | 05:54 |
| davechen | lhcheng_ np, my pleasure. | 05:55 |
| *** clayton has quit IRC | 05:55 | |
| *** dsirrine has quit IRC | 05:57 | |
| *** rm_work has quit IRC | 05:59 | |
| *** rm_work has joined #openstack-keystone | 05:59 | |
| *** rm_work has quit IRC | 06:00 | |
| *** rm_work has joined #openstack-keystone | 06:00 | |
| *** geoffarnold is now known as geoffarnoldX | 06:00 | |
| *** clayton has joined #openstack-keystone | 06:01 | |
| davechen | stevemar, jamielennox: thanks both! | 06:02 |
| stevemar | jamielennox: you have a whopping 2 pep8 errors | 06:02 |
| *** rm_work has quit IRC | 06:02 | |
| jamielennox | that's pretty good actually | 06:02 |
| *** rm_work has joined #openstack-keystone | 06:03 | |
| jamielennox | still gotta see everything that failed subtly | 06:03 |
| jamielennox | stevemar: left some initial comments on https://review.openstack.org/#/c/221593/ | 06:03 |
| stevemar | ty! | 06:03 |
| stevemar | http://paste.openstack.org/show/451454/ | 06:03 |
| stevemar | jamielennox: ^ | 06:03 |
| jamielennox | again i don't think i'd depend on ksa until M but it's good to test | 06:03 |
| *** rm_work has quit IRC | 06:04 | |
| *** rm_work has joined #openstack-keystone | 06:04 | |
| jamielennox | looks like DOA first candidate :http://logs.openstack.org/96/221596/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/ee909ad/logs/devstacklog.txt.gz#_2015-09-09_05_53_11_533 | 06:05 |
| *** rm_work has quit IRC | 06:06 | |
| *** rm_work has joined #openstack-keystone | 06:06 | |
| stevemar | jamielennox: yeah, i know - but wanted to get something WIPish | 06:07 |
| openstackgerrit | Steve Martinelli proposed openstack/python-keystoneclient: trim requirements for ksc https://review.openstack.org/221601 | 06:10 |
| stevemar | jamielennox: piggy backing off of you... ^ | 06:10 |
| jamielennox | stevemar: i'm wondering if it's worth attempting an oslo.client based off of keystoneauth | 06:11 |
| jamielennox | it'd look very similar to the end result of keystoneclient 2 | 06:12 |
| jamielennox | i just don't know if anyone would use it at this point | 06:12 |
| *** shoutm has joined #openstack-keystone | 06:13 | |
| openstackgerrit | Steve Martinelli proposed openstack/python-keystoneclient: trim requirements for ksc https://review.openstack.org/221601 | 06:14 |
| * stevemar shrugs | 06:15 | |
| stevemar | sounds like you got something in mind | 06:15 |
| *** Guest94761 has quit IRC | 06:21 | |
| *** tsymanczyk has joined #openstack-keystone | 06:23 | |
| *** tsymanczyk is now known as Guest92404 | 06:24 | |
| *** EinstCrazy has joined #openstack-keystone | 06:26 | |
| openstackgerrit | Steve Martinelli proposed openstack/python-keystoneclient: trim requirements for ksc https://review.openstack.org/221601 | 06:32 |
| *** henrynash has joined #openstack-keystone | 06:57 | |
| *** ChanServ sets mode: +v henrynash | 06:57 | |
| *** martinus__ has joined #openstack-keystone | 07:01 | |
| *** spandhe has quit IRC | 07:03 | |
| *** lsmola has joined #openstack-keystone | 07:04 | |
| *** vivekd has quit IRC | 07:14 | |
| *** btully has quit IRC | 07:21 | |
| *** ankita_wagh has quit IRC | 07:21 | |
| *** lhcheng_ has quit IRC | 07:23 | |
| *** sdake_ has joined #openstack-keystone | 07:23 | |
| *** ParsectiX has joined #openstack-keystone | 07:27 | |
| *** sdake has quit IRC | 07:27 | |
| *** shoutm has quit IRC | 07:28 | |
| *** shoutm has joined #openstack-keystone | 07:29 | |
| *** shoutm_ has joined #openstack-keystone | 07:31 | |
| *** shoutm has quit IRC | 07:33 | |
| *** markvoelker has joined #openstack-keystone | 07:33 | |
| *** pnavarro has joined #openstack-keystone | 07:35 | |
| *** browne has quit IRC | 07:36 | |
| *** sdake has joined #openstack-keystone | 07:36 | |
| *** markvoelker has quit IRC | 07:38 | |
| *** sdake_ has quit IRC | 07:39 | |
| *** stevemar has quit IRC | 07:48 | |
| *** fhubik has joined #openstack-keystone | 08:02 | |
| openstackgerrit | Merged openstack/keystone: Update apache-httpd.rst https://review.openstack.org/217565 | 08:15 |
| *** shoutm has joined #openstack-keystone | 08:21 | |
| *** shoutm_ has quit IRC | 08:24 | |
| *** jistr has joined #openstack-keystone | 08:32 | |
| *** itlinux has joined #openstack-keystone | 08:44 | |
| itlinux | hi all | 08:44 |
| itlinux | I notice that the RDO kilo, has changed the way the project is behaving, now when I login as admin it goes default to the new project and I cannot switch to the admin project from the UI, what needs to be changed? I tried to remove the admin privileges on the project but it says I am logged in so I cannot change it from the UI. Thanks | 08:46 |
| *** mylu has joined #openstack-keystone | 08:47 | |
| *** mylu has quit IRC | 08:52 | |
| *** e0ne has joined #openstack-keystone | 08:54 | |
| *** markvoelker has joined #openstack-keystone | 09:04 | |
| *** e0ne has quit IRC | 09:04 | |
| *** e0ne has joined #openstack-keystone | 09:07 | |
| *** markvoelker has quit IRC | 09:08 | |
| *** Kennan_Vacation2 has quit IRC | 09:17 | |
| *** fhubik is now known as fhubik_brb | 09:21 | |
| *** Kennan_Vacation has joined #openstack-keystone | 09:25 | |
| *** tsymanczyk has joined #openstack-keystone | 09:38 | |
| *** tsymanczyk is now known as Guest33351 | 09:39 | |
| *** Chandan_p has joined #openstack-keystone | 09:39 | |
| Chandan_p | hi... i am new in openstack.... i am trying to install openstack kilo | 09:40 |
| Chandan_p | i am getting error below mentioned error | 09:41 |
| Chandan_p | root@openstack:~# openstack service create --name keystone --description "OpenStack Identity" identity | 09:41 |
| Chandan_p | ERROR: openstack Unable to establish connection to http://localhost:35357/v2.0/OS-KSADM/services | 09:41 |
| Chandan_p | can anyone plz help me out | 09:41 |
| *** Guest92404 has quit IRC | 09:41 | |
| *** f13o has joined #openstack-keystone | 09:50 | |
| *** fhubik_brb is now known as fhubik | 09:51 | |
| *** davechen has left #openstack-keystone | 09:54 | |
| *** Guest33351 has quit IRC | 09:59 | |
| *** dims__ has joined #openstack-keystone | 10:02 | |
| *** f13o has quit IRC | 10:02 | |
| *** tsymancz1k has joined #openstack-keystone | 10:06 | |
| *** itlinux has quit IRC | 10:24 | |
| *** btully has joined #openstack-keystone | 10:28 | |
| *** fhubik is now known as fhubik_brb | 10:30 | |
| dims__ | jamielennox: ping | 10:31 |
| dims__ | jamielennox: can you please look at this Nova review? https://review.openstack.org/#/c/220767/ | 10:31 |
| *** mylu has joined #openstack-keystone | 10:32 | |
| *** Chandan_p has quit IRC | 10:34 | |
| *** mylu has quit IRC | 10:36 | |
| *** btully has quit IRC | 10:39 | |
| *** btully has joined #openstack-keystone | 10:42 | |
| jamielennox | dims__: it feels like there should be an easier way... | 10:44 |
| jamielennox | dims__: also thinking about this problem i proposed https://review.openstack.org/#/c/221551/1/keystoneauth1/identity/base.py but it won't be useful until at least next cycle | 10:45 |
| *** EinstCrazy has quit IRC | 10:45 | |
| *** btully has quit IRC | 10:47 | |
| *** itlinux has joined #openstack-keystone | 10:47 | |
| *** bradjones has quit IRC | 10:55 | |
| *** topol has joined #openstack-keystone | 11:00 | |
| *** ChanServ sets mode: +v topol | 11:00 | |
| *** martinus__ has quit IRC | 11:01 | |
| *** topol has quit IRC | 11:03 | |
| *** markvoelker has joined #openstack-keystone | 11:04 | |
| dims__ | jamielennox: we need something to go back to kilo, not just liberty | 11:06 |
| *** aix has quit IRC | 11:06 | |
| dims__ | jamielennox: ack will look | 11:07 |
| *** fhubik_brb is now known as fhubik | 11:08 | |
| *** EinstCrazy has joined #openstack-keystone | 11:09 | |
| *** markvoelker has quit IRC | 11:09 | |
| *** e0ne has quit IRC | 11:16 | |
| jamielennox | dims__: i have an idea.. | 11:16 |
| *** pnavarro is now known as pnavarro|lunch | 11:21 | |
| *** amakarov_away is now known as amakarov | 11:21 | |
| *** gordc has joined #openstack-keystone | 11:33 | |
| *** dave-mccowan has joined #openstack-keystone | 11:44 | |
| dims__ | jamielennox: listening :) | 11:47 |
| *** EinstCrazy has quit IRC | 11:51 | |
| *** ParsectiX has quit IRC | 11:53 | |
| *** pnavarro|lunch is now known as pnavarro | 11:58 | |
| *** nicodemos has joined #openstack-keystone | 11:59 | |
| jamielennox | dims__: https://review.openstack.org/#/c/221717/ | 11:59 |
| *** Nirupama has quit IRC | 12:00 | |
| *** e0ne has joined #openstack-keystone | 12:00 | |
| *** henrynash has quit IRC | 12:01 | |
| *** markvoelker has joined #openstack-keystone | 12:02 | |
| *** Protux has quit IRC | 12:03 | |
| *** doug-fish has joined #openstack-keystone | 12:04 | |
| *** woodster_ has joined #openstack-keystone | 12:06 | |
| *** henrynash has joined #openstack-keystone | 12:08 | |
| *** ChanServ sets mode: +v henrynash | 12:08 | |
| *** pc_m has joined #openstack-keystone | 12:11 | |
| *** henrynash has quit IRC | 12:12 | |
| pc_m | hi! I have a pair of bare metal machines that I haven't used in about 2 months. I updated devstack repo and stacked with reclone. It's failing with an error saying that init_poolmanager() in keystoneclient hit a TypeError with socket_options, during g-api startup. | 12:14 |
| pc_m | Has anyone seen this (and resolved the issue)? | 12:14 |
| *** ParsectiX has joined #openstack-keystone | 12:14 | |
| jamielennox | pc_m yes we've seen that | 12:15 |
| *** e0ne has quit IRC | 12:15 | |
| pc_m | I checked the client and on one machine it is using 1.7.0 and on the other commit 28138b5 | 12:15 |
| *** dsirrine has joined #openstack-keystone | 12:15 | |
| jamielennox | pc_m: is this on windows or OSX? | 12:16 |
| pc_m | jamielennox: It looks like there is a commit f630894 that fixes it, but I still see the problem. | 12:16 |
| pc_m | jamielennox: Neither. Running on a system with Ubuntu 14.04 | 12:16 |
| pc_m | blade server | 12:16 |
| jamielennox | really | 12:17 |
| jamielennox | pc_m: https://review.openstack.org/#/c/211686/ | 12:17 |
| jamielennox | which attribute is missing? | 12:17 |
| pc_m | jamielennox: socket_options | 12:18 |
| pc_m | TypeError with unexpected keyword argument | 12:19 |
| pc_m | Glance API calls into keystoneclient session.py init_poolmanager() which complains about the kwarg. | 12:21 |
| pc_m | On one machine, I have commit 28138b5, which is after the commit with the fix (33b24a6), so it should have that fix. | 12:22 |
| *** raildo-afk is now known as raildo | 12:23 | |
| pc_m | jamielennox: HEre's the T/B http://paste.openstack.org/show/452177 | 12:24 |
| *** marzif has quit IRC | 12:25 | |
| *** tiny-hands has joined #openstack-keystone | 12:25 | |
| *** marzif has joined #openstack-keystone | 12:25 | |
| jamielennox | pc_m: interesting, that looks like an old version of requests | 12:27 |
| pc_m | jamielennox: possible. These machines haven't been used for a while so may be old cruft on them. | 12:28 |
| jamielennox | do you know what version? | 12:28 |
| pc_m | pip show requests gives 2.7.0 | 12:29 |
| *** e0ne has joined #openstack-keystone | 12:30 | |
| pc_m | jamielennox: There is a copy of requests in /usr/lib. Wonder if it is hitting that, instead of the one in /usr/local/lib/? | 12:30 |
| *** btully has joined #openstack-keystone | 12:30 | |
| pc_m | jamielennox: removing on one system and trying stacking. | 12:32 |
| *** edmondsw has joined #openstack-keystone | 12:33 | |
| *** btully has quit IRC | 12:35 | |
| *** topol has joined #openstack-keystone | 12:38 | |
| *** ChanServ sets mode: +v topol | 12:38 | |
| *** ParsectiX has quit IRC | 12:39 | |
| openstackgerrit | Jamie Lennox proposed openstack/python-keystoneclient: Identity plugin thread safety https://review.openstack.org/221738 | 12:39 |
| *** ParsectiX has joined #openstack-keystone | 12:39 | |
| *** csoukup has quit IRC | 12:44 | |
| *** ParsectiX has quit IRC | 12:50 | |
| *** aix has joined #openstack-keystone | 12:51 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Identity plugin thread safety https://review.openstack.org/221551 | 12:52 |
| *** Mzoorikh has joined #openstack-keystone | 12:52 | |
| *** dims__ is now known as dims | 12:52 | |
| *** Mzoorikh has quit IRC | 12:53 | |
| *** topol has quit IRC | 12:54 | |
| *** bknudson has joined #openstack-keystone | 12:59 | |
| *** ChanServ sets mode: +v bknudson | 12:59 | |
| *** jsavak has joined #openstack-keystone | 12:59 | |
| *** geoffarnoldX is now known as geoffarnold | 13:02 | |
| *** geoffarnold is now known as geoffarnoldX | 13:04 | |
| *** ParsectiX has joined #openstack-keystone | 13:05 | |
| *** hrou has joined #openstack-keystone | 13:08 | |
| pc_m | jamielennox: After removing the requests dir from /usr/lib/ and relying on the one in /usrlocal/lib, it stacked fine on both systems. Thanks for the lead! | 13:10 |
| *** jecarey has joined #openstack-keystone | 13:13 | |
| *** richm has joined #openstack-keystone | 13:16 | |
| *** raildo is now known as raildo-afk | 13:19 | |
| *** zzzeek has joined #openstack-keystone | 13:21 | |
| *** urulama has quit IRC | 13:24 | |
| *** urulama has joined #openstack-keystone | 13:24 | |
| *** raildo-afk is now known as raildo | 13:26 | |
| *** pc_m has left #openstack-keystone | 13:26 | |
| *** dsirrine has quit IRC | 13:36 | |
| *** dsirrine has joined #openstack-keystone | 13:37 | |
| *** tsymancz1k has quit IRC | 13:47 | |
| *** topol has joined #openstack-keystone | 13:47 | |
| *** ChanServ sets mode: +v topol | 13:47 | |
| *** tsymanczyk has joined #openstack-keystone | 13:49 | |
| *** tsymanczyk is now known as Guest22719 | 13:50 | |
| *** r-daneel has joined #openstack-keystone | 13:51 | |
| *** bknudson has quit IRC | 13:57 | |
| *** shoutm has quit IRC | 13:58 | |
| *** btully has joined #openstack-keystone | 14:00 | |
| *** ParsectiX has quit IRC | 14:05 | |
| *** browne has joined #openstack-keystone | 14:05 | |
| *** devanand1 is now known as devananda | 14:10 | |
| *** slberger has joined #openstack-keystone | 14:17 | |
| *** fhubik is now known as fhubik_brb | 14:17 | |
| *** fhubik_brb is now known as fhubik | 14:19 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Unsure validation of percent encoded fernet tokens https://review.openstack.org/221786 | 14:20 |
| *** csoukup has joined #openstack-keystone | 14:22 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:23 | |
| *** topol has quit IRC | 14:30 | |
| lbragstad | dolphm: ^ legacy padding fix and back port | 14:30 |
| lbragstad | dolphm: er... here is the backport - https://review.openstack.org/#/c/221799/ | 14:36 |
| *** phalmos has joined #openstack-keystone | 14:38 | |
| *** bknudson has joined #openstack-keystone | 14:39 | |
| *** ChanServ sets mode: +v bknudson | 14:39 | |
| *** geoffarnoldX is now known as geoffarnold | 14:45 | |
| *** roxanaghe has joined #openstack-keystone | 14:45 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Unsure validation of percent encoded fernet tokens https://review.openstack.org/221786 | 14:46 |
| *** ebalduf has joined #openstack-keystone | 14:47 | |
| *** bradjones has joined #openstack-keystone | 14:52 | |
| *** bradjones has quit IRC | 14:52 | |
| *** bradjones has joined #openstack-keystone | 14:52 | |
| *** stevemar has joined #openstack-keystone | 14:53 | |
| *** ChanServ sets mode: +v stevemar | 14:53 | |
| openstackgerrit | Henrique Truta proposed openstack/keystone: Some fixes in the is_domain field creation https://review.openstack.org/215167 | 14:53 |
| *** ebalduf has quit IRC | 14:54 | |
| *** thedodd has joined #openstack-keystone | 14:56 | |
| *** ebalduf has joined #openstack-keystone | 14:56 | |
| *** stevemar has quit IRC | 14:56 | |
| *** henrynash has joined #openstack-keystone | 15:00 | |
| *** ChanServ sets mode: +v henrynash | 15:00 | |
| dolphm | lbragstad: i know it means that we're landing Closes-Bug vs Partial-Bug out of order, but would you upgrade https://review.openstack.org/#/c/221786/ to be Partial-Bug since it's improving on an edge case of the bug? (not just showing tests or something for it) | 15:00 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Unsure validation of percent encoded fernet tokens https://review.openstack.org/221786 | 15:02 |
| lbragstad | dolphm: done | 15:02 |
| *** dave-mccowan has quit IRC | 15:02 | |
| *** jistr is now known as jistr|call | 15:02 | |
| dolphm | lbragstad: i reverted the bug status to In Progress too, so we'll have to manually mark it as Fix Committed now | 15:03 |
| lbragstad | dolphm: sounds good | 15:03 |
| *** ebalduf has quit IRC | 15:04 | |
| *** topol has joined #openstack-keystone | 15:06 | |
| *** ChanServ sets mode: +v topol | 15:06 | |
| *** marzif has quit IRC | 15:10 | |
| *** jsavak has quit IRC | 15:11 | |
| openstackgerrit | Matthew Edmonds proposed openstack/keystonemiddleware: only make token invalid when it really is https://review.openstack.org/217373 | 15:12 |
| *** stevemar has joined #openstack-keystone | 15:12 | |
| *** ChanServ sets mode: +v stevemar | 15:12 | |
| *** jsavak has joined #openstack-keystone | 15:15 | |
| *** dave-mccowan has joined #openstack-keystone | 15:16 | |
| *** jsavak has quit IRC | 15:18 | |
| *** jsavak has joined #openstack-keystone | 15:18 | |
| openstackgerrit | Tom Cocozzello proposed openstack/python-keystoneclient: Move .pot file for translation https://review.openstack.org/221473 | 15:18 |
| *** Guest22719 has quit IRC | 15:30 | |
| *** diazjf has joined #openstack-keystone | 15:30 | |
| *** topol_ has joined #openstack-keystone | 15:31 | |
| *** ChanServ sets mode: +v topol_ | 15:31 | |
| *** phalmos has quit IRC | 15:32 | |
| *** topol__ has joined #openstack-keystone | 15:33 | |
| *** topol has quit IRC | 15:33 | |
| *** tsymanczyk has joined #openstack-keystone | 15:35 | |
| *** tsymanczyk is now known as Guest49684 | 15:35 | |
| *** topol_ has quit IRC | 15:36 | |
| *** sdake_ has joined #openstack-keystone | 15:36 | |
| *** KarthikB has joined #openstack-keystone | 15:36 | |
| *** sdake__ has joined #openstack-keystone | 15:39 | |
| *** sdake has quit IRC | 15:40 | |
| morgan | lbragstad, jamielennox, https://review.openstack.org/221847 planned release of 1.7.1 of keystoneclient (hopefully today) | 15:42 |
| morgan | to address middleware issue and windows sock opts | 15:42 |
| morgan | oh erm | 15:42 |
| morgan | sorry | 15:42 |
| morgan | not windows thing | 15:42 |
| *** sdake_ has quit IRC | 15:43 | |
| bknudson | don't forget solaris | 15:43 |
| bknudson | I don't think https://review.openstack.org/#/c/221543/ was the right fix. | 15:43 |
| morgan | bknudson yah different thing | 15:44 |
| morgan | at least the ksm thing was in there | 15:44 |
| *** phalmos has joined #openstack-keystone | 15:45 | |
| *** shoutm has joined #openstack-keystone | 15:46 | |
| *** stevemar has quit IRC | 15:47 | |
| bknudson | looking into the ksm problem, looks like it was ksm was mocking the ksc incorrectly | 15:47 |
| *** sdake has joined #openstack-keystone | 15:47 | |
| *** stevemar has joined #openstack-keystone | 15:48 | |
| *** ChanServ sets mode: +v stevemar | 15:48 | |
| bknudson | the mock was raising ConnectionError where ksc would waris ConenctionRefused | 15:48 |
| bknudson | would raise | 15:48 |
| *** sdake__ has quit IRC | 15:49 | |
| *** gyee has joined #openstack-keystone | 15:49 | |
| *** ChanServ sets mode: +v gyee | 15:49 | |
| *** stevemar has quit IRC | 15:50 | |
| *** Guest49684 has quit IRC | 15:53 | |
| openstackgerrit | Brant Knudson proposed openstack/python-keystoneclient: Revert "Adding back exception mapping for ConnectionError" https://review.openstack.org/221855 | 15:54 |
| openstackgerrit | Brant Knudson proposed openstack/python-keystoneclient: Revert "oslo-incubator apiclient.exceptions to keystoneclient.exceptions" https://review.openstack.org/221856 | 15:54 |
| *** jistr|call is now known as jistr | 15:55 | |
| *** tsymancz1k has joined #openstack-keystone | 15:58 | |
| *** sdake has quit IRC | 15:58 | |
| *** med_ has quit IRC | 15:58 | |
| *** KarthikB has quit IRC | 16:00 | |
| *** itlinux has quit IRC | 16:01 | |
| *** jsavak has quit IRC | 16:07 | |
| *** jsavak has joined #openstack-keystone | 16:08 | |
| *** phalmos has quit IRC | 16:08 | |
| *** fhubik has quit IRC | 16:10 | |
| *** dims has quit IRC | 16:10 | |
| *** dims has joined #openstack-keystone | 16:10 | |
| *** KarthikB has joined #openstack-keystone | 16:18 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Ensure token validation works irrespective of padding https://review.openstack.org/221786 | 16:19 |
| *** pnavarro has quit IRC | 16:21 | |
| edmondsw | lbragstad, I think I've addressed your comments on https://review.openstack.org/#/c/217373/ Can you take another look? | 16:23 |
| lbragstad | edmondsw: sure | 16:23 |
| edmondsw | bknudson, in some ways that change I've proposed relates to your https://review.openstack.org/#/c/221855/ | 16:24 |
| *** urulama has quit IRC | 16:24 | |
| edmondsw | had to switch some things from ConnectionError to ConnectionRefused to get UT passing | 16:25 |
| *** urulama has joined #openstack-keystone | 16:25 | |
| morgan | bknudson: however, this is a change that is likely wider reaching than just ksm | 16:25 |
| morgan | bknudson: if we change the exceptions... we break people | 16:25 |
| morgan | really? revert the API exceptions thing | 16:25 |
| * morgan sigh | 16:25 | |
| morgan | ugh. | 16:26 |
| gyee | morgan, yeah, we can't break people | 16:26 |
| bknudson | I'll re-propose it and see if I can do it without breaking ksm. | 16:26 |
| edmondsw | keystonemiddleware UT was already broken without bknudson's change | 16:26 |
| edmondsw | my change should fix that | 16:26 |
| morgan | before we approve the revert, lets see if we can fix it with reproposal | 16:27 |
| edmondsw | maybe should have split it into a separate commit... | 16:27 |
| morgan | or if it's just worth making the incremental changes needed | 16:27 |
| bknudson | I don't want to keep digging into a hole. | 16:27 |
| bknudson | fill in the hole and start over. | 16:27 |
| morgan | bknudson: at some point you can't just revert and re-propose. | 16:28 |
| morgan | bknudson: i don't agree this is a hole at the moment. it looks like it might be relatively minor overlook | 16:29 |
| morgan | s/overlook/oversight | 16:29 |
| morgan | bknudson: or is this another "eff it, we can do it with 2.0" | 16:29 |
| *** sdake has joined #openstack-keystone | 16:30 | |
| morgan | bknudson: I'm also thinking we're as likely to break people reverting it now fwiw. | 16:30 |
| morgan | since there was a release with this in there | 16:30 |
| *** lhcheng has joined #openstack-keystone | 16:30 | |
| *** ChanServ sets mode: +v lhcheng | 16:30 | |
| *** lhcheng_ has joined #openstack-keystone | 16:32 | |
| *** lhcheng has quit IRC | 16:35 | |
| *** jistr has quit IRC | 16:42 | |
| *** hurgleburgler has joined #openstack-keystone | 16:46 | |
| *** belmoreira has joined #openstack-keystone | 16:46 | |
| *** lsmola has quit IRC | 16:48 | |
| *** spandhe has joined #openstack-keystone | 16:51 | |
| *** KarthikB has quit IRC | 16:55 | |
| *** jistr has joined #openstack-keystone | 16:55 | |
| *** ebalduf has joined #openstack-keystone | 16:57 | |
| *** e0ne has quit IRC | 17:08 | |
| *** KarthikB has joined #openstack-keystone | 17:13 | |
| *** csoukup has quit IRC | 17:18 | |
| *** madhu_ak has joined #openstack-keystone | 17:20 | |
| *** mflobo1 has joined #openstack-keystone | 17:21 | |
| *** ankita_wagh has joined #openstack-keystone | 17:22 | |
| *** mflobo1 has left #openstack-keystone | 17:22 | |
| hogepodge | proposed capability updates for keystone in defcore https://review.openstack.org/#/c/213330/3 | 17:23 |
| hogepodge | morgan: ^^ | 17:23 |
| *** mflobo1 has joined #openstack-keystone | 17:26 | |
| *** exploreshaifali has joined #openstack-keystone | 17:26 | |
| *** mflobo1 has left #openstack-keystone | 17:27 | |
| *** jistr has quit IRC | 17:28 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Ensure token validation works irrespective of padding https://review.openstack.org/221786 | 17:28 |
| *** jsavak has quit IRC | 17:30 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Ensure token validation works irrespective of padding https://review.openstack.org/221786 | 17:30 |
| *** jsavak has joined #openstack-keystone | 17:31 | |
| *** devlaps has joined #openstack-keystone | 17:32 | |
| *** sdake_ has joined #openstack-keystone | 17:37 | |
| openstackgerrit | Matthew Edmonds proposed openstack/keystonemiddleware: only make token invalid when it really is https://review.openstack.org/217373 | 17:40 |
| *** sdake has quit IRC | 17:41 | |
| bknudson | edmondsw: I don't think anyone would complain if the commit was split up. | 17:42 |
| bknudson | then it's easier to understand. | 17:42 |
| edmondsw | lbragstad, I don't think https://review.openstack.org/#/c/221855/ commit is going to affect https://review.openstack.org/217373 | 17:42 |
| edmondsw | bknudson, you agree? | 17:43 |
| edmondsw | bknudson, as for splitting it up... most of it has to stay together, I think. I could split out the ConnectionRefused change, but it kind of makes sense to fix it here, since this change exposed the problem | 17:43 |
| bknudson | edmondsw: we wouldn't have caught the backwards-incompatible change if the auth_token tests were corrected as in https://review.openstack.org/217373 | 17:43 |
| bknudson | (I meant https://review.openstack.org/#/c/221855/ ) | 17:44 |
| bknudson | edmondsw: you can't just propose a change to fix the faked return value? | 17:44 |
| edmondsw | bknudson ? | 17:44 |
| bknudson | edmondsw: we wouldn't have caught the backwards-incompatible change if the auth_token tests were corrected as in https://review.openstack.org/#/c/217373/ ... I guess I was correct the first time. | 17:45 |
| *** sdake_ is now known as sdake | 17:45 | |
| bknudson | edmondsw: I have no idea why most of the changes in https://review.openstack.org/#/c/217373/5/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py are being made.... commit message doesn't say what was wrong. | 17:48 |
| edmondsw | we wouldn't have caught them without https://review.openstack.org/217373 ... it is the changes in __init__.py there that caused things to break, and then for me to fix them | 17:48 |
| edmondsw | the changes in patch set 5 are to fix py34 UT failures | 17:48 |
| bknudson | edmondsw: the auth_token middlware tests were failing before https://review.openstack.org/217373 was proposed. | 17:49 |
| edmondsw | hmm... ok | 17:49 |
| edmondsw | there a bug for that? | 17:49 |
| bknudson | edmondsw: https://bugs.launchpad.net/python-keystoneclient/+bug/1492600 | 17:50 |
| openstack | Launchpad bug 1492600 in python-keystoneclient "ConnectionError exception mapped incorrectly" [Critical,Fix committed] - Assigned to Lin Hua Cheng (lin-hua-cheng) | 17:50 |
| edmondsw | ahh... it failed with InvalidToken... yeah, that makes sense... it would fail differently with my changes | 17:51 |
| edmondsw | but fail either way | 17:51 |
| edmondsw | so bknudson, you'd like me to make the switch to using ConnectionRefused in keystonemiddleware under that bug, and keep the rest under my current commit? | 17:51 |
| bknudson | edmondsw: yes, I'd consider that a fix for the bug. | 17:52 |
| edmondsw | ok, will do | 17:53 |
| *** shoutm has quit IRC | 17:55 | |
| *** jsavak has quit IRC | 17:56 | |
| *** belmoreira has quit IRC | 17:56 | |
| *** jsavak has joined #openstack-keystone | 17:56 | |
| *** jsavak has quit IRC | 17:58 | |
| *** mylu has joined #openstack-keystone | 17:58 | |
| *** diazjf has quit IRC | 17:58 | |
| *** jsavak has joined #openstack-keystone | 17:59 | |
| *** diazjf has joined #openstack-keystone | 18:01 | |
| openstackgerrit | Matthew Edmonds proposed openstack/keystonemiddleware: use ConnectionError for auth_token tests https://review.openstack.org/221897 | 18:05 |
| openstackgerrit | Matthew Edmonds proposed openstack/keystonemiddleware: only make token invalid when it really is https://review.openstack.org/217373 | 18:10 |
| *** med_ has joined #openstack-keystone | 18:12 | |
| *** stevemar has joined #openstack-keystone | 18:13 | |
| *** ChanServ sets mode: +v stevemar | 18:13 | |
| *** thedodd has quit IRC | 18:15 | |
| *** stevemar has quit IRC | 18:16 | |
| *** e0ne has joined #openstack-keystone | 18:23 | |
| *** diazjf has quit IRC | 18:25 | |
| *** diazjf has joined #openstack-keystone | 18:28 | |
| *** mylu has quit IRC | 18:29 | |
| *** aix has quit IRC | 18:29 | |
| *** mylu has joined #openstack-keystone | 18:30 | |
| *** stevemar has joined #openstack-keystone | 18:30 | |
| *** ChanServ sets mode: +v stevemar | 18:30 | |
| *** mylu has quit IRC | 18:31 | |
| *** csoukup has joined #openstack-keystone | 18:31 | |
| *** mylu has joined #openstack-keystone | 18:31 | |
| *** stevemar has quit IRC | 18:33 | |
| *** stevemar has joined #openstack-keystone | 18:34 | |
| *** ChanServ sets mode: +v stevemar | 18:34 | |
| *** josecastroleon has quit IRC | 18:36 | |
| *** urulama_ has joined #openstack-keystone | 18:38 | |
| *** urulama has quit IRC | 18:40 | |
| *** josecastroleon has joined #openstack-keystone | 18:41 | |
| *** stevemar has quit IRC | 18:43 | |
| *** phalmos has joined #openstack-keystone | 18:45 | |
| openstackgerrit | Roman Bogorodskiy proposed openstack/python-keystoneclient: Avoid message concatenation in error path https://review.openstack.org/155758 | 18:47 |
| *** e0ne has quit IRC | 18:47 | |
| openstackgerrit | Matthew Edmonds proposed openstack/keystonemiddleware: Use ConnectionRefused for auth_token tests https://review.openstack.org/221897 | 18:49 |
| morgan | bknudson: are you good with dumping the ksa_integration branch on keystoneclient since we arent doing the same level of compat hacks. Instead we will just spin up a new 2.0 branch and we will start over with 2.0 and not compat in mind | 18:55 |
| morgan | bknudson: this was jamielennox's request | 18:55 |
| bknudson | morgan: I don't agree that we can make 2.0 with no compat in mind. otherwise how is anyone going to upgrade? New version should only remove code not change behavior | 18:56 |
| *** tsymancz1k is now known as tsymanczyk | 18:56 | |
| morgan | bknudson: i really dislike that we must maintain compat forever. Major version changes imply (and rightfully so) no compat guaranteed | 18:57 |
| bknudson | morgan: I'm fine with dumping ksa_integration branch if it was just for testing. | 18:57 |
| bknudson | it's not forever, it's n+2. | 18:57 |
| bknudson | helps to deprecate correctly | 18:57 |
| morgan | Then we should stop pretending to do semver | 18:57 |
| openstackgerrit | Matthew Edmonds proposed openstack/keystonemiddleware: Use ConnectionRefused for auth_token tests https://review.openstack.org/221897 | 18:58 |
| lbragstad | bknudson: just a heads up, I'm going to drop by the qa meeting tomorrow for - https://review.openstack.org/#/c/220272/ since https://review.openstack.org/#/c/220242/ merged. then we should be able to retrigger https://review.openstack.org/#/c/195780/ | 18:58 |
| openstackgerrit | Roman Bogorodskiy proposed openstack/python-keystoneclient: Avoid message concatenation in error path https://review.openstack.org/155758 | 18:58 |
| morgan | So we are going to maintain these horrible compat hacks until 4.x of keystoneclient? | 18:58 |
| bknudson | morgan: that is semver... when you remove function you up the major version #. | 18:59 |
| morgan | Right. We are talking moving to 2.0 | 18:59 |
| bknudson | morgan: 4.x or whatever... by then we'll probably have openstack sdk. | 18:59 |
| morgan | Not 1.xx without the compat | 18:59 |
| morgan | Then we might as well not have split keystoneauth | 18:59 |
| bknudson | I thought sdk was going to use keystoneauth. | 18:59 |
| morgan | It is. | 19:00 |
| *** diazjf has quit IRC | 19:00 | |
| *** thedodd has joined #openstack-keystone | 19:00 | |
| morgan | abd we cant remove the cli then | 19:00 |
| morgan | Either | 19:00 |
| bknudson | that makes it worth it to split out auth | 19:00 |
| bknudson | we can remove the cli for 2.0 if it's deprecated in 1.x | 19:00 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Additional documentation for services https://review.openstack.org/211184 | 19:00 |
| morgan | So we deprecate session in the next release cause ksa is out | 19:00 |
| morgan | Remoce it in 2.0 | 19:01 |
| morgan | No compat | 19:01 |
| bknudson | yes. | 19:01 |
| morgan | Great deprecated in 1.8 | 19:01 |
| *** amakarov is now known as amakarov_away | 19:01 | |
| bknudson | if we want to build session on ksa then it will be a compat layer... otherwise it just sits on whatever it was using before. | 19:01 |
| morgan | I was not advocating removal in the liberty branch (last of the 1.x series) but no compat in the next series (mitaka) | 19:01 |
| morgan | No | 19:02 |
| morgan | The point is keystoneclient shouldnt need in 2.0 to carry the namespace for everyone else | 19:02 |
| morgan | The compat hacks are truely awful | 19:02 |
| bknudson | we already have compat hacks so adding more on top will be doubly bad | 19:03 |
| morgan | Otherwise we are wedged in a cycle still | 19:03 |
| morgan | So my point is lets drop those in the 2.0 release | 19:03 |
| morgan | To move to ksc 2.0 you need to be on ksa | 19:03 |
| morgan | Ksc just losing what goes in ksa | 19:03 |
| morgan | But absolutly a major version bump | 19:03 |
| bknudson | what we need to ensure is that there's a path from 1.x to 2.x | 19:04 |
| morgan | Convert to using ksa | 19:04 |
| morgan | That is the path | 19:04 |
| bknudson | so that might be, use ksc 1.x with ksa. | 19:04 |
| bknudson | then switch ksc 1.x to 2.x | 19:04 |
| bknudson | after you stop using deprecated function in ksc 1.x | 19:04 |
| *** jasonsb has quit IRC | 19:04 | |
| bknudson | then you stuff should just keep working. | 19:05 |
| *** jasonsb has joined #openstack-keystone | 19:05 | |
| morgan | Sure. But my goal is ksc 2 wont have the ksa stuff in it | 19:05 |
| bknudson | then you'll need to make it so ksc1 works with ksa. | 19:05 |
| *** jasonsb has quit IRC | 19:05 | |
| morgan | Sure. | 19:05 |
| bknudson | we can't require a big bang | 19:05 |
| morgan | That is fine. Ksc can do some support code in 1.x | 19:06 |
| *** jasonsb has joined #openstack-keystone | 19:06 | |
| morgan | But 2.x is a no support for ksc versions | 19:06 |
| bknudson | ksc sessions | 19:06 |
| morgan | Right | 19:06 |
| morgan | Ksc 1.x sessions will not work with ksc 2.0 | 19:06 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Ensure token validation works irrespective of padding https://review.openstack.org/221786 | 19:07 |
| morgan | Ksc 1 can do what is needed to support either. | 19:07 |
| bknudson | so we'd deprecate ksc sessions in 1.x saying to switch to ksa sessions | 19:07 |
| morgan | Yes | 19:07 |
| *** diazjf has joined #openstack-keystone | 19:07 | |
| morgan | Ok we are in agreement. | 19:07 |
| bknudson | yep | 19:07 |
| *** e0ne has joined #openstack-keystone | 19:07 | |
| morgan | Cool | 19:08 |
| morgan | That should be an easy code block (since it is purely internal to ksc) | 19:08 |
| *** urulama_ has quit IRC | 19:08 | |
| *** urulama has joined #openstack-keystone | 19:09 | |
| *** boris-42 has quit IRC | 19:10 | |
| *** jasonsb has quit IRC | 19:10 | |
| *** kiran-r has joined #openstack-keystone | 19:17 | |
| *** ankita_w_ has joined #openstack-keystone | 19:19 | |
| *** ankita_wagh has quit IRC | 19:19 | |
| *** edmondsw has quit IRC | 19:25 | |
| *** exploreshaifali has quit IRC | 19:28 | |
| *** kiran-r has quit IRC | 19:29 | |
| *** ankita_w_ has quit IRC | 19:29 | |
| *** ankita_wagh has joined #openstack-keystone | 19:30 | |
| *** e0ne has quit IRC | 19:32 | |
| *** aix has joined #openstack-keystone | 19:33 | |
| *** phalmos has quit IRC | 19:40 | |
| *** phalmos has joined #openstack-keystone | 19:42 | |
| *** devlaps has quit IRC | 19:43 | |
| *** hurgleburgler has left #openstack-keystone | 19:45 | |
| *** mylu has quit IRC | 19:45 | |
| *** mylu has joined #openstack-keystone | 19:46 | |
| *** stevemar has joined #openstack-keystone | 19:46 | |
| *** ChanServ sets mode: +v stevemar | 19:46 | |
| *** KarthikB has quit IRC | 19:48 | |
| *** phalmos has quit IRC | 19:49 | |
| *** mylu has quit IRC | 19:50 | |
| *** roxanaghe has quit IRC | 19:59 | |
| *** boris-42 has joined #openstack-keystone | 20:00 | |
| *** lhcheng_ is now known as lhcheng | 20:00 | |
| *** ChanServ sets mode: +v lhcheng | 20:00 | |
| *** urulama has quit IRC | 20:01 | |
| *** nicodemos has quit IRC | 20:05 | |
| *** KarthikB has joined #openstack-keystone | 20:05 | |
| *** jasonsb has joined #openstack-keystone | 20:05 | |
| *** e0ne has joined #openstack-keystone | 20:11 | |
| *** pnavarro has joined #openstack-keystone | 20:26 | |
| *** KarthikB has quit IRC | 20:27 | |
| *** roxanaghe has joined #openstack-keystone | 20:28 | |
| *** jsavak has quit IRC | 20:34 | |
| *** ankita_w_ has joined #openstack-keystone | 20:36 | |
| *** stevemar has quit IRC | 20:37 | |
| *** ankita_wagh has quit IRC | 20:39 | |
| *** topol__ has quit IRC | 20:41 | |
| *** thedodd has quit IRC | 20:51 | |
| *** dave-mccowan has quit IRC | 20:51 | |
| *** jasonsb has quit IRC | 20:51 | |
| *** KarthikB has joined #openstack-keystone | 20:51 | |
| *** jasonsb has joined #openstack-keystone | 20:52 | |
| *** pnavarro has quit IRC | 20:56 | |
| *** ebalduf has quit IRC | 20:57 | |
| *** darrenc_ has joined #openstack-keystone | 21:02 | |
| *** darrenc has quit IRC | 21:03 | |
| *** tiny-hands has quit IRC | 21:03 | |
| *** bknudson has quit IRC | 21:04 | |
| *** tiny-hands has joined #openstack-keystone | 21:05 | |
| *** tiny-hands has quit IRC | 21:05 | |
| *** sdake has quit IRC | 21:08 | |
| *** ankita_wagh has joined #openstack-keystone | 21:09 | |
| *** ankita_w_ has quit IRC | 21:09 | |
| *** edmondsw has joined #openstack-keystone | 21:10 | |
| *** roxanaghe has quit IRC | 21:14 | |
| *** ankita_w_ has joined #openstack-keystone | 21:15 | |
| *** ankita_wagh has quit IRC | 21:15 | |
| *** ankita_wagh has joined #openstack-keystone | 21:20 | |
| *** ankita_w_ has quit IRC | 21:20 | |
| *** roxanaghe has joined #openstack-keystone | 21:21 | |
| openstackgerrit | Nina Goradia proposed openstack/keystone: Use oslo.log fixture https://review.openstack.org/217362 | 21:28 |
| *** jasonsb has quit IRC | 21:31 | |
| *** dave-mccowan has joined #openstack-keystone | 21:32 | |
| *** jasonsb has joined #openstack-keystone | 21:32 | |
| *** stevemar has joined #openstack-keystone | 21:38 | |
| *** ChanServ sets mode: +v stevemar | 21:38 | |
| *** e0ne has quit IRC | 21:39 | |
| *** bknudson has joined #openstack-keystone | 21:40 | |
| *** ChanServ sets mode: +v bknudson | 21:40 | |
| *** stevemar has quit IRC | 21:41 | |
| *** mestery has quit IRC | 21:41 | |
| *** doug-fish has quit IRC | 21:42 | |
| *** dave-mccowan has quit IRC | 21:42 | |
| *** mestery has joined #openstack-keystone | 21:42 | |
| *** doug-fish has joined #openstack-keystone | 21:42 | |
| *** diazjf has left #openstack-keystone | 21:45 | |
| openstackgerrit | Tom Cocozzello proposed openstack/keystone: Deprecate httpd/keystone.py https://review.openstack.org/221975 | 21:47 |
| lhcheng | bknudson: curious why you changed your mind on https://review.openstack.org/#/c/221855/ | 21:49 |
| bknudson | lhcheng: I can't think of a way to get rid of the apiclient.exceptions in a non-breaking way other that what your fix is doing. | 21:50 |
| bknudson | I'll propose a change to clean it up a little. | 21:50 |
| bknudson | since it's useless to define a class and then rename it so you can't reference it. | 21:50 |
| lhcheng | yeah, the cleanup makes sense. less confusion in the future | 21:51 |
| lhcheng | bknudson: thanks for reviewing that patch | 21:52 |
| *** hrou has quit IRC | 21:52 | |
| bknudson | lhcheng: I made the change that broke it and remembered there was something fishy with those classes | 21:53 |
| bknudson | I should have looked into it some more | 21:53 |
| lhcheng | bknudson: I guess anything that have backward compatibility we should stay away from :) | 21:54 |
| lhcheng | it wasn't clear why it is required | 21:54 |
| bknudson | we have to be able to deprecate and remove old broken garbage. | 21:54 |
| bknudson | somebody wanted to get the client libs using the same exceptions for a while but then they gave up on it. | 21:55 |
| lhcheng | ++ | 21:55 |
| bknudson | they tried to make a breaking change to keystoneclient when they did that but I talked them out of it. | 21:55 |
| bknudson | but then that created this issue when I tried to deprecate the apiclient stuff. | 21:56 |
| *** gordc has quit IRC | 21:56 | |
| lhcheng | ugh | 21:57 |
| lhcheng | so this type of issue only show up after the python-client is release | 21:58 |
| lhcheng | wonder if we can have a smarter gate | 21:58 |
| bknudson | we could catch this if we ran the ksm unit tests for ksc changes. | 21:58 |
| jamielennox | bknudson: ksa should allow us to use the same exceptions for at least HTTP | 21:58 |
| lhcheng | instead of pulling just from release package, use the code in master | 21:58 |
| lhcheng | bknudson: yeah, something like that | 21:58 |
| jamielennox | bknudson: the problem with the oslo incubator apiclient standard exceptions is they were c&p-ed to every project so they weren't the same object, just the same name | 21:59 |
| bknudson | jamielennox: that was in the feature branch? | 21:59 |
| bknudson | jamielennox: we still have apiclient exceptions but now they're referencing keystoneclient exceptions rather than the other way around. | 22:00 |
| jamielennox | bknudson: no, keystoneauth has a lot of standard exceptions, i'm not sure if in keystoneclient we do from keystoneauth1.exceptions.http import * or we just use them from ksa direclty | 22:00 |
| *** slberger has left #openstack-keystone | 22:00 | |
| jamielennox | bknudson: really? | 22:00 |
| jamielennox | apiclient made such a mess, good intentions but ergh | 22:00 |
| bknudson | jamielennox: yes, so now apiclient exceptions is deprecated in favor of keystoneclient exceptions | 22:00 |
| bknudson | remove apiclient exceptions in 2.0 | 22:01 |
| jamielennox | bknudson: i've started a 2.0 branch and it removes a lot of stuff | 22:01 |
| jamielennox | -26k LOC | 22:01 |
| jamielennox | but yes, they're in for sure | 22:01 |
| bknudson | how does keystoneclient have 26k loc to begin with | 22:02 |
| jamielennox | yuo | 22:02 |
| jamielennox | exactly | 22:02 |
| jamielennox | https://review.openstack.org/#/c/221596/ is the review, i have a github branch where they aren't squashed so i can put them up for review later | 22:03 |
| jamielennox | i just wanted to see where zuul broke | 22:03 |
| jamielennox | we can't do anything about fixing it until next cycle anyway so not too worried for now | 22:03 |
| *** geoffarnold has quit IRC | 22:03 | |
| *** geoffarnold has joined #openstack-keystone | 22:04 | |
| *** sdake has joined #openstack-keystone | 22:05 | |
| *** stevemar has joined #openstack-keystone | 22:08 | |
| *** ChanServ sets mode: +v stevemar | 22:08 | |
| jamielennox | morgan, bknudson: my intent for a v2.0 is to really not change the CRUD interfaces at all (small cleanups), just move everything over to using the KSA features and i wasn't thinking we'd provide references to new objects in KSA, just make people move completely over | 22:08 |
| *** bradjones is now known as bradjones|away | 22:09 | |
| morgan | jamielennox: so I think the very simple ksc->ksa session method is needed in ksc | 22:09 |
| morgan | or vice-versa (pick one way) | 22:10 |
| morgan | for the 1.x series | 22:10 |
| jamielennox | why? | 22:10 |
| bknudson | jamielennox: I don't think we can require a big break | 22:10 |
| bknudson | otherwise there's no migration path | 22:10 |
| morgan | to avoid the big break | 22:10 |
| jamielennox | bknudson: there's a migration path | 22:10 |
| morgan | simple, you give a simple way to extract a session and move it, it is added to 1.x series of ksc | 22:10 |
| jamielennox | s/from keystoneclient import session/from keystoneauth1 import session | 22:10 |
| bknudson | jamielennox: what is it? | 22:10 |
| morgan | we have an upgrade path | 22:10 |
| morgan | jamielennox: if session will "just work" no changes needed | 22:11 |
| morgan | then fine | 22:11 |
| morgan | but if code needs changing we just need to cover our bases | 22:11 |
| jamielennox | i purposefully didn't change any interfaces on session/auth plugins | 22:11 |
| morgan | ok cool | 22:11 |
| *** stevemar has quit IRC | 22:11 | |
| morgan | then the path is simple | 22:11 |
| morgan | i hadn't tried that yet | 22:11 |
| jamielennox | so except for loading it should just be create the object from ksa instead | 22:11 |
| bknudson | does "from keystoneauth1 import session" work with ksc v1? | 22:11 |
| jamielennox | the place where it gets slightly tricky is exception handling because now exceptions are being raised from a different place | 22:12 |
| morgan | jamielennox: and loading is (for all intents and purposes) optional at this point | 22:12 |
| *** shoutm has joined #openstack-keystone | 22:12 | |
| *** shoutm has quit IRC | 22:12 | |
| bknudson | nobody handles exceptions anyways | 22:12 |
| morgan | eh. that is an acceptible level of break and a known | 22:12 |
| morgan | except Exception <--- 99% of the cases which means no impact | 22:13 |
| jamielennox | for other clients though (which is generally the problem) i think we'll have to do a compatibility file with their current exceptions | 22:13 |
| bknudson | can we have ksc.exception use ksa.exception? | 22:13 |
| morgan | bknudson: eh, not really a need for it | 22:13 |
| morgan | bknudsonand you'd need to subclass | 22:13 |
| bknudson | you're right, probably a bad idea. | 22:13 |
| morgan | otherwise you're still raising ksa.exception (or you'd need to re-raise) | 22:13 |
| jamielennox | bknudson: so when you request() you can raise_exc=False, most other clients do this so that they can raise there library's exceptions and not keystoneclient anyway | 22:13 |
| bknudson | there's probably a bunch of ksa exceptions that go away. | 22:14 |
| bknudson | oops, ksc exceptions | 22:14 |
| morgan | bknudson: yep | 22:14 |
| morgan | all the session handling stuff | 22:14 |
| jamielennox | i would like to make these the same object but i think we can figure that out | 22:14 |
| morgan | oh... i forgot to do something.. maybe the joke has already been spent though =/ | 22:14 |
| * morgan goes to do thing | 22:14 | |
| jamielennox | bknudson: anyway it'll purposefully break anyone doing Client(username=XXX, ...) etc but i don't want to change the CRUD behaviour on people | 22:15 |
| bknudson | jamielennox: I think that's deprecated now so shouldn't be a problem to remove it. | 22:21 |
| *** ebalduf_ has joined #openstack-keystone | 22:24 | |
| jamielennox | bknudson: so i've got a review i'd like you to look at https://review.openstack.org/#/c/221738/ | 22:24 |
| jamielennox | bknudson: it's small in code, but a bit of a change | 22:25 |
| bknudson | jamielennox: how do you unit test it? | 22:26 |
| jamielennox | bknudson: i've no idea :) | 22:26 |
| jamielennox | i was thinking i could mock() the request() and have it sleep | 22:26 |
| jamielennox | but either way involves bringing threads into the ksc unit tests | 22:27 |
| bknudson | jamielennox: does eventlet override locks so they don't block everything? | 22:27 |
| * bknudson wishes we had real async since it's easier to think about | 22:28 | |
| morgan | ok so we can nuke the old integration branch and make a 2.x branch? | 22:29 |
| morgan | that was the root of all this | 22:29 |
| bknudson | we should look at what the diff in commits are. | 22:29 |
| * jamielennox misses compilers and actually being able to just think about threads normally | 22:29 | |
| bknudson | make sure we're not losing anything | 22:29 |
| jamielennox | https://review.openstack.org/#/q/status:merged+project:openstack/python-keystoneclient+branch:feature/keystoneauth_integration,n,z | 22:30 |
| bknudson | so is that what's going to be in the 2.x branch? | 22:30 |
| jamielennox | so they've all been me trying to make ksc use ksa features directly and not breaking compatibility | 22:30 |
| bknudson | if so, why do we need a different branch? | 22:30 |
| bknudson | "Remove keystoneclient.middleware" isn't | 22:31 |
| jamielennox | bknudson: yep, but that ones fairly easy | 22:31 |
| bknudson | it's a change that someone tried to make in master and I said put it to this other branch instead. | 22:31 |
| jamielennox | there are a few patches that are open against it | 22:32 |
| jamielennox | doc updates etc | 22:32 |
| jamielennox | if we want to make the v2 branch and cherry-pick across first then that's fine as well | 22:32 |
| bknudson | I figured we'd make a keystoneclient 1.x branch off master and then merge keystoneauth_integration into master | 22:33 |
| morgan | bknudson, i think we're ditching some of the compat stuff in the ksc integration branch | 22:33 |
| morgan | that we really don't need | 22:33 |
| *** roxanaghe has quit IRC | 22:34 | |
| bknudson | we could go through and remove the deprecated functionality first so that it's easier | 22:34 |
| bknudson | to see what we don't need | 22:34 |
| *** roxanaghe has joined #openstack-keystone | 22:34 | |
| jamielennox | bknudson: i think based on how long it took us to do ksa a new branch will be useful until it's ready | 22:34 |
| bknudson | ok, either way works for me. | 22:35 |
| bknudson | I just didn't want to lose work that I asked someone to do. | 22:35 |
| *** jecarey has quit IRC | 22:36 | |
| jamielennox | morgan: i don't know what happens to open reviews if we delete the branch, maybe ask for the 2.0 and then we'll delete the integration branch after we've cherry-picked everything | 22:36 |
| *** csoukup has quit IRC | 22:36 | |
| morgan | the open reviews will disappear afaik | 22:36 |
| morgan | gerrit is smart | 22:36 |
| morgan | sometimes too smart | 22:36 |
| morgan | omg gerrit is skynet (cc mordred ) | 22:36 |
| jamielennox | but there are 2 reviews for ksa_integration from non-core | 22:37 |
| morgan | so i can ask for the new branch and then kill the old one easily later | 22:37 |
| jamielennox | https://review.openstack.org/#/c/215261/ will happen automatically in 2 because the adapter default is public endpoints | 22:37 |
| bknudson | I like seeing V-1 on everything | 22:37 |
| jamielennox | and i think https://review.openstack.org/#/c/192438/ is a cherry-pick from master? doug-fish ? | 22:38 |
| bknudson | there shouldn't be any cherry-picking from master to the feature branch | 22:38 |
| bknudson | since we can merge changes from master the old fashioned way | 22:39 |
| *** henrynash has quit IRC | 22:41 | |
| *** henrynash has joined #openstack-keystone | 22:42 | |
| *** ChanServ sets mode: +v henrynash | 22:42 | |
| jamielennox | morgan: it's a bit against the rules but i was wondering about trying to merge https://review.openstack.org/#/c/221738/ before release of 0.7.1 | 22:43 |
| jamielennox | because we're going to have to bump L reqs for 0.7.1 then i can fix the problem in nova properly | 22:43 |
| morgan | we could make it 1.8 | 22:43 |
| morgan | but 1.7.1 shouldn't include that i don't think | 22:43 |
| morgan | or it could | 22:44 |
| jamielennox | that's fair | 22:44 |
| morgan | we could just update the 1.7.1 tag hash | 22:44 |
| morgan | happy to do so if dhellmann hasn't tagged 1.7.1 yet | 22:44 |
| jamielennox | is that a manual process? | 22:45 |
| *** roxanaghe has quit IRC | 22:48 | |
| *** KarthikB has quit IRC | 22:49 | |
| *** darrenc_ is now known as darrenc | 22:51 | |
| *** erhudy1 has joined #openstack-keystone | 22:53 | |
| *** roxanaghe has joined #openstack-keystone | 22:54 | |
| *** markvoelker has quit IRC | 22:56 | |
| *** ebalduf_ has quit IRC | 22:56 | |
| *** roxanaghe has quit IRC | 22:58 | |
| *** roxanaghe has joined #openstack-keystone | 22:59 | |
| *** hrou has joined #openstack-keystone | 23:04 | |
| *** bknudson has quit IRC | 23:06 | |
| morgan | jamielennox: it is handled by the rel team and via a repo now | 23:07 |
| morgan | jamielennox so i think somewhat manual | 23:07 |
| *** spandhe has quit IRC | 23:07 | |
| jamielennox | morgan: yea, i just assumed a large part of that would be so that on post-commit there was a script to make sure all releases were pushed | 23:07 |
| *** david-lyle has quit IRC | 23:11 | |
| *** henrynash has quit IRC | 23:12 | |
| *** spandhe has joined #openstack-keystone | 23:12 | |
| *** david-lyle has joined #openstack-keystone | 23:12 | |
| *** henrynash has joined #openstack-keystone | 23:13 | |
| *** ChanServ sets mode: +v henrynash | 23:13 | |
| *** rdo has quit IRC | 23:17 | |
| *** zzzeek has quit IRC | 23:17 | |
| *** darrenc is now known as darrenc_afk | 23:20 | |
| *** amit213 has quit IRC | 23:22 | |
| *** amit213 has joined #openstack-keystone | 23:22 | |
| *** david-lyle has quit IRC | 23:22 | |
| *** edmondsw has quit IRC | 23:23 | |
| *** david-lyle has joined #openstack-keystone | 23:23 | |
| *** rdo has joined #openstack-keystone | 23:25 | |
| *** bknudson has joined #openstack-keystone | 23:37 | |
| *** ChanServ sets mode: +v bknudson | 23:37 | |
| *** dsirrine has quit IRC | 23:37 | |
| *** jasonsb has quit IRC | 23:40 | |
| *** shoutm has joined #openstack-keystone | 23:44 | |
| *** henrynash has quit IRC | 23:45 | |
| *** jasonsb has joined #openstack-keystone | 23:48 | |
| *** jasonsb has quit IRC | 23:49 | |
| *** dsirrine has joined #openstack-keystone | 23:52 | |
| *** bknudson has quit IRC | 23:56 | |
| *** markvoelker has joined #openstack-keystone | 23:57 | |
| *** fangzhou has joined #openstack-keystone | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!