*** jerrygb has quit IRC | 00:01 | |
*** davechen has joined #openstack-keystone | 00:02 | |
*** davechen1 has joined #openstack-keystone | 00:12 | |
*** davechen has quit IRC | 00:14 | |
stevemar | the stable driver interface are causing me grief | 00:17 |
---|---|---|
*** alex_xu has quit IRC | 00:19 | |
*** david8hu has quit IRC | 00:20 | |
*** alex_xu has joined #openstack-keystone | 00:21 | |
*** david8hu has joined #openstack-keystone | 00:21 | |
*** jimbaker has quit IRC | 00:21 | |
*** jimbaker has joined #openstack-keystone | 00:21 | |
*** jimbaker has quit IRC | 00:22 | |
*** jimbaker has joined #openstack-keystone | 00:22 | |
*** mordred has quit IRC | 00:23 | |
*** mordred has joined #openstack-keystone | 00:23 | |
*** EinstCra_ has quit IRC | 00:24 | |
*** jasonsb has quit IRC | 00:24 | |
*** gyee has joined #openstack-keystone | 00:25 | |
*** ChanServ sets mode: +v gyee | 00:25 | |
*** chlong has joined #openstack-keystone | 00:28 | |
*** gokrokve has joined #openstack-keystone | 00:28 | |
*** mkoderer has quit IRC | 00:30 | |
*** belmoreira has quit IRC | 00:30 | |
*** davechen has joined #openstack-keystone | 00:33 | |
*** davechen1 has quit IRC | 00:36 | |
*** mkoderer has joined #openstack-keystone | 00:37 | |
*** arun_kant has quit IRC | 00:40 | |
*** gokrokve has quit IRC | 00:43 | |
stevemar | anyone around to push through 2 patches? | 00:44 |
stevemar | https://review.openstack.org/#/c/237205/6 | 00:44 |
stevemar | and https://review.openstack.org/#/c/248116/ | 00:44 |
*** gokrokve has joined #openstack-keystone | 00:44 | |
*** tonytan4ever has quit IRC | 00:45 | |
*** RichardRaseley has quit IRC | 00:45 | |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Update coverage to keystoneauth1 https://review.openstack.org/255022 | 00:46 |
gyee | stevemar, looking | 00:47 |
gyee | shaleh, rebase time :) | 00:48 |
shaleh | yay | 00:48 |
shaleh | if it means my code finally gets through I will be happy | 00:48 |
shaleh | the rebase cycle is getting OOOOLLLLDDDD | 00:48 |
* gyee hides | 00:48 | |
*** gokrokve has quit IRC | 00:49 | |
shaleh | tox passes, double check everything is checked in, run git review. It fails on rebase. Fix the minor issue. Submit the review. jenkins fails because the rebase busted something. Sigh. So now it is tox && rebase && tox && review | 00:50 |
*** openstackstatus has quit IRC | 00:50 | |
*** openstack has joined #openstack-keystone | 00:51 | |
gyee | shaleh, looks trivial, you want to rebase now? I can just push it through since stevemar already +2 it | 00:51 |
*** openstackstatus has joined #openstack-keystone | 00:51 | |
*** ChanServ sets mode: +v openstackstatus | 00:51 | |
shaleh | gyee: either push my patch or those two. | 00:52 |
shaleh | gyee: either way, I get to rebase SOMETHING | 00:52 |
*** davechen1 has joined #openstack-keystone | 00:56 | |
*** gokrokve has joined #openstack-keystone | 00:58 | |
*** davechen has quit IRC | 00:59 | |
shaleh | stevemar: bknudson's stuff is heading down the pipe | 00:59 |
shaleh | hopefully that means we can land my two patches tomorrow | 00:59 |
openstackgerrit | Sean Perry proposed openstack/keystone: Clean up new_credential_ref usage and surrounding code https://review.openstack.org/246713 | 01:01 |
*** EinstCrazy has joined #openstack-keystone | 01:03 | |
*** davechen has joined #openstack-keystone | 01:10 | |
*** davechen1 has quit IRC | 01:12 | |
*** tqtran has quit IRC | 01:19 | |
*** pgbridge has quit IRC | 01:19 | |
*** jasonsb has joined #openstack-keystone | 01:34 | |
*** terryyao has joined #openstack-keystone | 01:39 | |
*** alex_xu has quit IRC | 01:41 | |
*** shaleh has quit IRC | 01:41 | |
*** wangqun has joined #openstack-keystone | 01:43 | |
*** alex_xu has joined #openstack-keystone | 01:43 | |
*** esp has joined #openstack-keystone | 01:46 | |
*** jamielennox is now known as jamielennox|away | 01:47 | |
*** wangqun has quit IRC | 01:50 | |
*** gokrokve has quit IRC | 01:50 | |
*** chlong has quit IRC | 02:03 | |
*** gokrokve has joined #openstack-keystone | 02:14 | |
openstackgerrit | Merged openstack/keystone: Remove invalid comment about LDAP domain support https://review.openstack.org/253643 | 02:24 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/254633 | 02:26 |
*** samueldmq has joined #openstack-keystone | 02:27 | |
*** gokrokve has quit IRC | 02:30 | |
*** gokrokve has joined #openstack-keystone | 02:31 | |
*** gokrokve has quit IRC | 02:38 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/254444 | 02:49 |
*** jamielennox|away is now known as jamielennox | 02:50 | |
*** jerrygb has joined #openstack-keystone | 02:57 | |
*** gokrokve has joined #openstack-keystone | 02:59 | |
*** jerrygb has quit IRC | 03:02 | |
*** gokrokve has quit IRC | 03:04 | |
*** fangxu has quit IRC | 03:11 | |
*** chlong has joined #openstack-keystone | 03:16 | |
*** jerrygb has joined #openstack-keystone | 03:18 | |
*** links has joined #openstack-keystone | 03:24 | |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Use SAML2 requests plugin https://review.openstack.org/255056 | 03:28 |
*** jbell8 has joined #openstack-keystone | 03:29 | |
*** spandhe has quit IRC | 03:30 | |
*** terryyao has quit IRC | 03:37 | |
*** alex_xu_ has joined #openstack-keystone | 03:40 | |
*** alex_xu has quit IRC | 03:42 | |
*** davechen has quit IRC | 03:44 | |
*** davechen has joined #openstack-keystone | 03:45 | |
*** davechen1 has joined #openstack-keystone | 03:46 | |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Use SAML2 requests plugin https://review.openstack.org/255056 | 03:46 |
*** jerrygb has quit IRC | 03:48 | |
*** jerrygb has joined #openstack-keystone | 03:48 | |
*** chlong has quit IRC | 03:49 | |
*** davechen has quit IRC | 03:50 | |
jamielennox | stevemar, marekd: that took way too long ^ | 03:50 |
*** alejandrito has quit IRC | 03:52 | |
*** davechen has joined #openstack-keystone | 03:52 | |
*** jerrygb has quit IRC | 03:52 | |
*** fawadkhaliq has joined #openstack-keystone | 03:53 | |
*** chlong has joined #openstack-keystone | 03:53 | |
ayoung | jamielennox, I keep getting a missing module error for netifaces,. I see we removed that in mid 2014, but it seems to be back via oslo_utils | 03:53 |
jamielennox | yea, we got rid of it ages ago - if oslo.utils brought it back they should put a dep on it | 03:54 |
jamielennox | ayoung: ^ | 03:54 |
ayoung | netifaces>=0.10.4 | 03:55 |
ayoung | https://github.com/openstack/oslo.utils/blob/master/requirements.txt | 03:55 |
*** flwang1 has quit IRC | 03:55 | |
*** davechen1 has quit IRC | 03:55 | |
ayoung | jamielennox, how's that work when building a venv? | 03:55 |
jamielennox | ayoung: it should be fine then | 03:56 |
jamielennox | ayoung: oh - look at the last commit | 03:56 |
ayoung | jamielennox, I keep getting an error on unit tests | 03:56 |
ayoung | ours or theirs>? | 03:56 |
jamielennox | theirs | 03:56 |
jamielennox | https://github.com/openstack/oslo.utils/commit/479587c6d9f2fd519f1ea4c7fab3cbf2da1a92f4 | 03:56 |
jamielennox | so they moved it to extras and are reverting it | 03:56 |
jamielennox | so either you're working from a slightly out of date git repo | 03:57 |
stevemar | yeah, i released v3.2.0 which contains netifaces again | 03:57 |
jamielennox | or they haven't published a new oslo.utils yet | 03:57 |
stevemar | it was breaking us | 03:57 |
ayoung | stevemar, still breaking me | 03:57 |
jamielennox | stevemar: should be oslo.utils' fault | 03:57 |
stevemar | ayoung: you should be good if you install a new oslo utils | 03:57 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.policy: Use dict comprehension https://review.openstack.org/255062 | 03:57 |
ayoung | stevemar, tox -r should get it for testing, no? | 03:57 |
jamielennox | ayoung: yep | 03:58 |
stevemar | yep | 03:58 |
jamielennox | i think unless there's something funny with wheel caches | 03:58 |
jamielennox | but yep | 03:58 |
jamielennox | ayoung: kick this off for me: https://review.openstack.org/#/c/255022/ | 04:00 |
*** fawadkhaliq has quit IRC | 04:00 | |
jamielennox | ayoung: i also put my name down to review implied roles, figured i owned you some | 04:00 |
jamielennox | (and it'll be really useful) | 04:00 |
ayoung | jamielennox, I did, but let the record show I think the keystoneauth1 name is dumb | 04:02 |
ayoung | I bet we never have keystoneauth2 | 04:02 |
jamielennox | ayoung: lol, yea, i'm really not sure yet | 04:02 |
jamielennox | morgan was adament and i don't really care | 04:02 |
stevemar | ayoung: let's hope we don't | 04:02 |
*** links has quit IRC | 04:03 | |
*** jerrygb has joined #openstack-keystone | 04:03 | |
*** gyee has quit IRC | 04:03 | |
notmorgan | In this case future proof is better than not | 04:03 |
notmorgan | And I fully expect we will eventually need it. Semver is insufficient for what ksa does. Libtool is a better thing, but eh whatever | 04:04 |
ayoung | notmorgan, why there? | 04:04 |
stevemar | jamielennox: any suggestions on how to review https://review.openstack.org/#/c/255056/ ? | 04:04 |
ayoung | actually...I don't really care | 04:04 |
ayoung | I trust you on this one | 04:04 |
jamielennox | stevemar: faith :( | 04:04 |
jamielennox | stevemar: i tried a variety of things to change it over more subtly but it just doesn't work | 04:04 |
ayoung | jamielennox, rippowam? | 04:05 |
jamielennox | ayoung: what? | 04:05 |
ayoung | to test the saml2 plugin rewrite | 04:05 |
jamielennox | oh | 04:05 |
ayoung | I mean, it should be a drop in replacement, right? | 04:05 |
jamielennox | yea, you could do that, when i last looked it required some rhel72 betas that weren't public yet | 04:05 |
stevemar | notmorgan: not volunteering to champion anything? :) | 04:06 |
ayoung | jamielennox, I think we are still there. I might need to update it anyway. The nightly repo we used has gone away for OSP | 04:06 |
jamielennox | ayoung: i keep having to deal with ubuntu machines and they're just dumb :( | 04:06 |
notmorgan | stevemar: not a chance. | 04:06 |
stevemar | notmorgan: you cheeky guy | 04:06 |
ayoung | jamielennox, they certainly made different design decisions. 32 vs 64 bit on Ubuntu was the thing that I found harder | 04:07 |
jamielennox | ayoung: i'm not sure if i like shibboleth or not, but it's sufficiently different to mod_auth_mellon that it should be packaged for rhel | 04:07 |
notmorgan | What I am not already doing enough on the cross project stuff?! :P | 04:07 |
ayoung | jamielennox, that would git the keycloak tema Apoplexy | 04:08 |
stevemar | notmorgan: :) | 04:08 |
stevemar | notmorgan: you're doing great | 04:08 |
*** aginwala has quit IRC | 04:09 | |
ayoung | um... $ git status | 04:10 |
ayoung | On branch review/henry_nash/bp/assignment-manager-cleanup | 04:10 |
ayoung | Your branch and 'gerrit/master' have diverged, | 04:10 |
ayoung | and have 6 and 24 different commits each, respectively. | 04:10 |
ayoung | (use "git pull" to merge the remote branch into yours) | 04:10 |
ayoung | nothing to commit, working directory clean | 04:10 |
ayoung | [ayoung@ayoung541 keystone]$ git rebase origin/master | 04:10 |
ayoung | Current branch review/henry_nash/bp/assignment-manager-cleanup is up to date. | 04:11 |
ayoung | is that a problem? | 04:11 |
ayoung | I've done git fetch, and, well it looks like origina/master and gerrit/master have diverged | 04:11 |
openstackgerrit | ayoung proposed openstack/keystone: Create new version of assignment driver interface https://review.openstack.org/242853 | 04:12 |
*** dims has joined #openstack-keystone | 04:13 | |
openstackgerrit | ayoung proposed openstack/keystone: Create new version of assignment driver interface https://review.openstack.org/242853 | 04:13 |
*** davechen1 has joined #openstack-keystone | 04:15 | |
*** dims has quit IRC | 04:15 | |
*** davechen has quit IRC | 04:17 | |
*** dims has joined #openstack-keystone | 04:18 | |
*** spandhe has joined #openstack-keystone | 04:18 | |
*** spandhe_ has joined #openstack-keystone | 04:19 | |
jamielennox | stevemar: https://review.openstack.org/#/c/255056/1/samltest.py is a file i accidently checked in i was using to test | 04:19 |
jamielennox | stevemar: all the ips in that are public | 04:20 |
jamielennox | python samltest.py orig to kick it off | 04:20 |
stevemar | ohhh i'm gonna hack into things now | 04:20 |
*** wanghua has joined #openstack-keystone | 04:21 | |
openstackgerrit | ayoung proposed openstack/keystone: Create V9 Role Driver https://review.openstack.org/247805 | 04:22 |
*** gokrokve has joined #openstack-keystone | 04:22 | |
*** davechen has joined #openstack-keystone | 04:22 | |
*** spandhe has quit IRC | 04:23 | |
*** spandhe_ is now known as spandhe | 04:23 | |
*** davechen1 has quit IRC | 04:23 | |
*** terryyao has joined #openstack-keystone | 04:25 | |
*** dims has quit IRC | 04:29 | |
*** gokrokve has quit IRC | 04:30 | |
*** browne has quit IRC | 04:30 | |
openstackgerrit | ayoung proposed openstack/keystone: Implied Roles https://review.openstack.org/242614 | 04:33 |
stevemar | notmorgan: stable drivers interfaces has resulted in a lot of churn :( | 04:37 |
stevemar | https://review.openstack.org/#/c/242853/ | 04:37 |
*** links has joined #openstack-keystone | 04:38 | |
*** fawadkhaliq has joined #openstack-keystone | 04:45 | |
*** fawadkhaliq has quit IRC | 04:47 | |
*** jerrygb has quit IRC | 04:49 | |
*** jbell8 has quit IRC | 04:50 | |
*** jerrygb has joined #openstack-keystone | 04:51 | |
*** jerrygb has quit IRC | 04:51 | |
*** jerrygb has joined #openstack-keystone | 04:51 | |
*** jbell8 has joined #openstack-keystone | 04:52 | |
notmorgan | stevemar: then dump the feature ;) | 04:53 |
notmorgan | Ultimately, that is what happens when something like that doesn't work out. | 04:54 |
*** topol_ has joined #openstack-keystone | 04:56 | |
*** ChanServ sets mode: +v topol_ | 04:56 | |
*** topol_ has quit IRC | 04:57 | |
*** jbell8 has quit IRC | 05:01 | |
*** gokrokve has joined #openstack-keystone | 05:01 | |
*** boris-42_ has quit IRC | 05:03 | |
*** lhcheng has joined #openstack-keystone | 05:06 | |
*** ChanServ sets mode: +v lhcheng | 05:06 | |
openstackgerrit | Merged openstack/keystoneauth: Update coverage to keystoneauth1 https://review.openstack.org/255022 | 05:07 |
*** lhcheng has quit IRC | 05:12 | |
openstackgerrit | Dave Chen proposed openstack/keystone: refactor: move the common code to manager layer https://review.openstack.org/255070 | 05:12 |
davechen | stevemar: ^ | 05:13 |
davechen | does this looks better? | 05:13 |
*** dims has joined #openstack-keystone | 05:20 | |
*** atiwari1 has quit IRC | 05:28 | |
stevemar | davechen: lookin! | 05:28 |
*** gokrokve_ has joined #openstack-keystone | 05:28 | |
*** gokrokve has quit IRC | 05:28 | |
*** atiwari1 has joined #openstack-keystone | 05:29 | |
*** fawadkhaliq has joined #openstack-keystone | 05:33 | |
*** davechen has quit IRC | 05:42 | |
*** roxanaghe has joined #openstack-keystone | 05:42 | |
*** davechen has joined #openstack-keystone | 05:42 | |
*** roxanaghe has quit IRC | 05:42 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.policy: Use dict comprehension https://review.openstack.org/255062 | 05:44 |
*** davechen has left #openstack-keystone | 05:45 | |
*** davechen has joined #openstack-keystone | 05:45 | |
*** davechen1 has joined #openstack-keystone | 05:45 | |
*** davechen has quit IRC | 05:45 | |
*** davechen1 is now known as davechen | 05:45 | |
*** spandhe has quit IRC | 05:45 | |
*** gokrokve_ has quit IRC | 05:51 | |
openstackgerrit | Merged openstack/keystone: Refactor test use of new_*_ref https://review.openstack.org/237205 | 05:51 |
openstackgerrit | Merged openstack/keystone: Pass dict into update() rather than **kwargs https://review.openstack.org/248116 | 05:51 |
*** gokrokve has joined #openstack-keystone | 05:52 | |
*** davechen1 has joined #openstack-keystone | 05:52 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/254633 | 05:53 |
*** davechen has quit IRC | 05:54 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/254633 | 05:54 |
*** vikram has joined #openstack-keystone | 06:02 | |
vikram | Hi | 06:02 |
*** davechen1 has left #openstack-keystone | 06:02 | |
*** Nirupama has joined #openstack-keystone | 06:02 | |
vikram | Can anyone help me with this. | 06:02 |
vikram | I am getting this error wilt running devstack on the master code | 06:02 |
vikram | 2015-12-09 05:32:24.063 | Discovering versions from the identity service failed when creating the password plugin. Attempting to determine version from URL. | 06:02 |
vikram | 2015-12-09 05:32:24.063 | Could not determine a suitable URL for the plugin | 06:03 |
vikram | cinder service not getting started | 06:03 |
stevemar | vikram: just ran into that error | 06:04 |
vikram | stevemar: did you find the fix? | 06:04 |
stevemar | gotta delete the clouds.yaml file that openstack cloud config creates: rm -rf ~/.config/openstack | 06:04 |
vikram | i am using devstack | 06:05 |
vikram | could not find such file | 06:05 |
stevemar | vikram: yes, devstack creates that file | 06:05 |
stevemar | it should | 06:05 |
vikram | ok it me recheck | 06:06 |
vikram | found it | 06:06 |
stevemar | ;) | 06:07 |
vikram | is "auth_url: http://192.168.1.102:35357/v2.0" the issue | 06:07 |
stevemar | vikram: yep | 06:07 |
vikram | keystone version is v2 | 06:07 |
stevemar | just delete it, devstack will create a new one | 06:07 |
vikram | should be v3 i belive | 06:07 |
vikram | ok let me retry | 06:07 |
stevemar | jamielennox: your patch https://review.openstack.org/#/c/255056/1 is le failing | 06:10 |
*** spandhe has joined #openstack-keystone | 06:14 | |
*** jerrygb has quit IRC | 06:17 | |
*** jerrygb has joined #openstack-keystone | 06:17 | |
vikram | stevemar: I am not getting that error now! Thanks for your help! | 06:21 |
*** jerrygb has quit IRC | 06:21 | |
*** alex_xu has joined #openstack-keystone | 06:25 | |
*** aginwala has joined #openstack-keystone | 06:28 | |
*** alex_xu_ has quit IRC | 06:28 | |
*** gokrokve has quit IRC | 06:32 | |
stevemar | vikram: np :) | 06:35 |
*** jbell8 has joined #openstack-keystone | 06:36 | |
*** aginwala has quit IRC | 06:37 | |
*** chlong has quit IRC | 06:40 | |
*** jbell8 has quit IRC | 06:42 | |
openstackgerrit | Rui Chen proposed openstack/python-keystoneclient: Fix Resource.__eq__ mismatch semantics of object equal https://review.openstack.org/251841 | 06:45 |
*** aginwala has joined #openstack-keystone | 06:47 | |
*** vikram has quit IRC | 06:52 | |
*** gildub has quit IRC | 06:53 | |
*** jerrygb has joined #openstack-keystone | 07:00 | |
*** gokrokve has joined #openstack-keystone | 07:02 | |
*** spandhe_ has joined #openstack-keystone | 07:03 | |
*** spandhe has quit IRC | 07:04 | |
*** spandhe_ is now known as spandhe | 07:04 | |
*** fangxu has joined #openstack-keystone | 07:05 | |
*** gildub has joined #openstack-keystone | 07:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/254444 | 07:06 |
*** jerrygb has quit IRC | 07:06 | |
*** gokrokve has quit IRC | 07:07 | |
*** fangxu has quit IRC | 07:14 | |
*** fangxu has joined #openstack-keystone | 07:15 | |
*** jaosorior has joined #openstack-keystone | 07:19 | |
*** jaosorior has quit IRC | 07:19 | |
*** spandhe has quit IRC | 07:20 | |
*** zqfan_travel has joined #openstack-keystone | 07:20 | |
*** jaosorior has joined #openstack-keystone | 07:20 | |
*** rcernin has joined #openstack-keystone | 07:20 | |
*** zqfan_travel is now known as zqfan_AFK | 07:24 | |
*** flwang1 has joined #openstack-keystone | 07:25 | |
*** boris-42_ has joined #openstack-keystone | 07:31 | |
openstackgerrit | Akira YOSHIYAMA proposed openstack/oslo.policy: Fixes combined "and" and "or" rule handling https://review.openstack.org/253763 | 07:38 |
openstackgerrit | Akira YOSHIYAMA proposed openstack/oslo.policy: Fixes combined "and" and "or" rule handling https://review.openstack.org/253763 | 07:43 |
*** e0ne has joined #openstack-keystone | 07:52 | |
openstackgerrit | Merged openstack/keystone: Deprecate the pki and pkiz token providers. https://review.openstack.org/241389 | 07:52 |
*** aginwala has quit IRC | 07:53 | |
openstackgerrit | Akira YOSHIYAMA proposed openstack/oslo.policy: Fixes combined "and" and "or" rule handling https://review.openstack.org/253763 | 07:54 |
*** pece has joined #openstack-keystone | 07:56 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/254633 | 07:56 |
*** flwang1 has quit IRC | 08:00 | |
*** gokrokve has joined #openstack-keystone | 08:03 | |
*** pece has quit IRC | 08:04 | |
*** henrynash has joined #openstack-keystone | 08:08 | |
*** ChanServ sets mode: +v henrynash | 08:08 | |
*** gokrokve has quit IRC | 08:08 | |
*** aginwala has joined #openstack-keystone | 08:14 | |
*** belmoreira has joined #openstack-keystone | 08:15 | |
*** flwang1 has joined #openstack-keystone | 08:16 | |
*** pnavarro has joined #openstack-keystone | 08:17 | |
*** fangxu has quit IRC | 08:20 | |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Use SAML2 requests plugin https://review.openstack.org/255056 | 08:22 |
openstackgerrit | xu-haiwei proposed openstack/keystoneauth: HTTPError should contain 'retry_after' parameter https://review.openstack.org/255128 | 08:25 |
chenke_ | i have a question about keystone, can i post it there? | 08:25 |
*** fawadkhaliq has quit IRC | 08:32 | |
*** aginwala has quit IRC | 08:37 | |
marekd | chenke_: sure | 08:37 |
chenke_ | marked: tku! as i know, keystone could be treat as a Service Provider (SP), does keystone support saml2 protocol to connect to Identity Provider (IdP)? | 08:40 |
chenke_ | my version is Juno. | 08:41 |
marekd | chenke_: yes. | 08:41 |
marekd | just use Apache module for that | 08:41 |
marekd | for instance mod_shib | 08:41 |
marekd | chenke_: your use case is to make keystone a Service provider, so your IdP's users can access your cloud, right? | 08:42 |
chenke_ | marekd: i don't try it until now. my Idp is keycloak, i need to change some config about that and then connect to keystone | 08:44 |
marekd | chenke_: but you know what you are willing to achieve, right? :-) | 08:44 |
marekd | i don't know what keycloak it, but in general it's apache module that does protocol specific work | 08:45 |
marekd | so if you install a module for saml2 effectively keystone (openstack) will "speak" saml2, if you install module for openid connect it will speak openidconnect | 08:45 |
marekd | we tried both protocols. | 08:46 |
marekd | and they work, even in production systems. | 08:46 |
marekd | i suggest reading some documentation as your use case is pretty standard atm :-) | 08:46 |
chenke_ | marekd: that's a good news. At least i know keystone works well with saml2. | 08:46 |
marekd | chenke_: it does :-) | 08:47 |
*** fawadkhaliq has joined #openstack-keystone | 08:48 | |
chenke_ | marekd: in general, what kind of thing should be provided to keystone to finish config? in my opinion, the LDP should provice some thing to keystone for finish config. | 08:48 |
chenke_ | or could you provide some docs about that/ | 08:49 |
*** fawadkhaliq has quit IRC | 08:49 | |
*** flwang1 has quit IRC | 08:49 | |
*** flwang1 has joined #openstack-keystone | 08:49 | |
marekd | LDP? | 08:55 |
marekd | chenke_: i thnk you meant IdP | 08:55 |
*** jaosorior has quit IRC | 08:55 | |
marekd | chenke_: http://docs.openstack.org/developer/keystone/configure_federation.html | 08:56 |
marekd | chenke_: just read until "Keystone as an Identity Provider (IdP)", it's for different use case | 08:56 |
marekd | and examine provided links (like configuring Shibboleth etc) | 08:56 |
*** jerrygb has joined #openstack-keystone | 09:02 | |
*** fhubik has joined #openstack-keystone | 09:02 | |
chenke_ | tku marekd | 09:03 |
marekd | chenke_: no problem :-) | 09:03 |
*** gokrokve has joined #openstack-keystone | 09:04 | |
breton | o/ | 09:05 |
marekd | hi | 09:05 |
*** openstackstatus has quit IRC | 09:05 | |
*** openstack has joined #openstack-keystone | 09:06 | |
*** openstackstatus has joined #openstack-keystone | 09:06 | |
*** ChanServ sets mode: +v openstackstatus | 09:06 | |
*** jerrygb has quit IRC | 09:08 | |
*** gokrokve has quit IRC | 09:09 | |
*** e0ne has quit IRC | 09:15 | |
*** daemontool has joined #openstack-keystone | 09:16 | |
*** jaosorior has joined #openstack-keystone | 09:16 | |
*** fhubik is now known as fhubik_brb | 09:30 | |
*** terryyao has quit IRC | 09:30 | |
*** openstackgerrit has quit IRC | 09:32 | |
*** openstackgerrit has joined #openstack-keystone | 09:32 | |
*** fawadkhaliq has joined #openstack-keystone | 09:34 | |
*** fhubik_brb is now known as fhubik | 09:37 | |
marekd | "I am wondering whether there are people using RBAC at production." - what else could be used instead of RBAC? | 09:38 |
*** lhcheng has joined #openstack-keystone | 09:46 | |
*** ChanServ sets mode: +v lhcheng | 09:46 | |
breton | marekd: in openstack? | 09:57 |
marekd | yes | 09:58 |
breton | nothing else I guess | 09:59 |
marekd | breton: yeah | 09:59 |
marekd | breton: that was my impression as well :-) | 09:59 |
breton | the problem is that even current RBAC is not the proper RBAC | 09:59 |
marekd | breton: why | 09:59 |
*** zqfan_AFK has quit IRC | 10:01 | |
*** openstackgerrit has quit IRC | 10:02 | |
*** openstackgerrit has joined #openstack-keystone | 10:02 | |
* breton looking for a link | 10:06 | |
*** wangqun has joined #openstack-keystone | 10:08 | |
*** e0ne has joined #openstack-keystone | 10:10 | |
*** jamielennox is now known as jamielennox|away | 10:13 | |
*** sileht has quit IRC | 10:16 | |
*** pece has joined #openstack-keystone | 10:16 | |
breton | ok, can't find one. | 10:18 |
breton | marekd: so there are several types of RBAC | 10:18 |
breton | marekd: https://directory.apache.org/fortress/user-guide/1.3-what-rbac-is.html for example | 10:19 |
*** sileht has joined #openstack-keystone | 10:19 | |
breton | marekd: now we have only RBAC0 | 10:19 |
marekd | breton: does it make inaccurate RBAC? | 10:19 |
*** sileht has quit IRC | 10:19 | |
breton | henrynash now implements role hierarchy | 10:19 |
*** sileht has joined #openstack-keystone | 10:20 | |
breton | marekd: people want all other types of RBAC | 10:20 |
*** aix has joined #openstack-keystone | 10:20 | |
henrynash | breton: hi | 10:20 |
henrynash | breton: what’s teh questions? | 10:21 |
breton | henrynash: hi. Nope, no questions, just saying | 10:21 |
breton | marekd: there are already systems that are RBAC-compliant | 10:21 |
henrynash | breton: well, we provide one type of RBAC sure, with our OpenStack slant for sure | 10:22 |
marekd | breton: sure | 10:22 |
breton | for example, Apache Fortress | 10:22 |
marekd | lol, everything is apache now. | 10:22 |
breton | I know that jamielennox|away talked to the author of Apache Fortress about this stuff | 10:23 |
breton | but it didn't get any further | 10:23 |
marekd | breton: when did he talk about that? | 10:24 |
breton | marekd: may 2014: http://lists.openstack.org/pipermail/openstack-dev/2014-May/035305.html | 10:25 |
*** dims has quit IRC | 10:25 | |
*** aix has quit IRC | 10:37 | |
*** jistr has joined #openstack-keystone | 10:39 | |
*** henrynash has quit IRC | 10:56 | |
*** henrynash has joined #openstack-keystone | 10:57 | |
*** ChanServ sets mode: +v henrynash | 10:57 | |
*** fawadkhaliq has quit IRC | 10:57 | |
*** kairat has joined #openstack-keystone | 10:57 | |
*** fawadkhaliq has joined #openstack-keystone | 10:57 | |
*** kairat has left #openstack-keystone | 10:58 | |
*** kairat has joined #openstack-keystone | 10:58 | |
*** lhcheng_ has joined #openstack-keystone | 11:03 | |
*** fawadkhaliq has quit IRC | 11:03 | |
*** jerrygb has joined #openstack-keystone | 11:04 | |
openstackgerrit | Roman Podoliaka proposed openstack/python-keystoneclient: Remove lock object from BaseIdentityPlugin https://review.openstack.org/246521 | 11:05 |
*** lhcheng has quit IRC | 11:06 | |
*** ktychkova has joined #openstack-keystone | 11:07 | |
*** jerrygb has quit IRC | 11:09 | |
*** mhickey has joined #openstack-keystone | 11:13 | |
*** aix has joined #openstack-keystone | 11:14 | |
*** EinstCrazy has quit IRC | 11:24 | |
*** links has quit IRC | 11:26 | |
*** fhubik is now known as fhubik_brb | 11:32 | |
*** dims has joined #openstack-keystone | 11:37 | |
*** wangqun has quit IRC | 11:38 | |
*** fhubik_brb is now known as fhubik | 11:39 | |
*** fhubik is now known as fhubik_brb | 11:47 | |
*** gokrokve has joined #openstack-keystone | 11:50 | |
*** EinstCrazy has joined #openstack-keystone | 11:51 | |
samueldmq | morning keystoners | 11:52 |
*** thiagop has quit IRC | 11:54 | |
*** gokrokve has quit IRC | 11:55 | |
*** lhcheng_ is now known as lhcheng | 12:00 | |
*** ChanServ sets mode: +v lhcheng | 12:00 | |
*** daemontool has quit IRC | 12:04 | |
*** links has joined #openstack-keystone | 12:16 | |
*** chenke__ has joined #openstack-keystone | 12:23 | |
*** gordc has joined #openstack-keystone | 12:24 | |
*** chenke_ has quit IRC | 12:26 | |
openstackgerrit | Akira YOSHIYAMA proposed openstack/oslo.policy: Fixes combined "and" and "or" rule handling https://review.openstack.org/253763 | 12:33 |
kairat | Hello | 12:33 |
kairat | Does anybody know how to load trust-scoped token for a user from configurations that also has project_id parameter? | 12:34 |
*** gildub has quit IRC | 12:34 | |
kairat | auth_method is password | 12:34 |
*** pnavarro is now known as pnavarro|lunch | 12:38 | |
*** fawadkhaliq has joined #openstack-keystone | 12:38 | |
*** alejandrito has joined #openstack-keystone | 12:40 | |
*** jaosorior has quit IRC | 12:42 | |
*** doug-fis_ is now known as doug-fish | 12:42 | |
*** chlong has joined #openstack-keystone | 12:42 | |
*** zqfan_AFK has joined #openstack-keystone | 12:42 | |
*** jaosorior has joined #openstack-keystone | 12:42 | |
*** terryyao has joined #openstack-keystone | 12:43 | |
amakarov | kairat, trust is already scoped to the resource - what's you exact case? | 12:43 |
*** boris-42_ has quit IRC | 12:43 | |
kairat | Ok, i have user configuration in keystone_authtoken group in glance-api.conf | 12:44 |
kairat | I would like to create trusts and re-authenticate when user token expired | 12:45 |
kairat | *trust | 12:45 |
kairat | I also would like to load auth plugins from configuration specified in keystone_authtoken group | 12:46 |
kairat | so I do the following | 12:46 |
kairat | 1. Initialize trustor plugin, session, client with user_token | 12:47 |
kairat | 2. Load trustee (service_user) plugin, session from configuration in glance-api.conf | 12:48 |
*** fhubik_brb is now known as fhubik | 12:48 | |
kairat | 3. request trustee user_id and create trust | 12:49 |
kairat | The last step is load trustee (service user) plugin, session from configuration in glance-api.conf with trust_id specified | 12:50 |
*** terryyao has quit IRC | 12:50 | |
samueldmq | ayoung: morning, you around ? | 12:50 |
samueldmq | ayoung: https://github.com/openstack/keystone/blob/163ee0c2f2181dbd1405ad47bce2c4ea241470b5/keystone/tests/unit/test_auth.py#L989 | 12:51 |
*** terryyao has joined #openstack-keystone | 12:51 | |
kairat | but it seems that it is not possible because there are multiple scopes: project_id from configuration and trust_id | 12:51 |
kairat | I am thinking how to avoid this because it would allow us to forget about CONF.keystone_authtoken values | 12:52 |
kairat | amakarov, here is the example: https://review.openstack.org/#/c/241986/15/glance/common/trust_auth.py | 12:53 |
*** jerrygb has joined #openstack-keystone | 12:53 | |
amakarov | kairat, looking | 12:54 |
kairat | Look at the question at the bottom from Stuart McLaren | 12:55 |
kairat | I also noticed that we cannot load session from configuration because timeout option is absent in keystone_authtoken group | 12:56 |
kairat | So I am waiting for jamielennox|away to be online=) | 12:56 |
openstackgerrit | Akira YOSHIYAMA proposed openstack/oslo.policy: Fixes combined "and" and "or" rule handling https://review.openstack.org/253763 | 13:00 |
*** jdennis has quit IRC | 13:01 | |
*** jdennis has joined #openstack-keystone | 13:01 | |
*** ayoung has quit IRC | 13:02 | |
*** jed56 has quit IRC | 13:03 | |
*** doug-fish has quit IRC | 13:06 | |
*** fhubik has quit IRC | 13:06 | |
amakarov | kairat, how do you want to avoid the case when project in the trust scope differs from that explicitly specified? | 13:07 |
*** pauloewerton has joined #openstack-keystone | 13:07 | |
amakarov | If you want just get a trust scoped token, then use Password method and specify trust_id parameter there - you'll never be able to get trust-scoped token with another project in its scope | 13:10 |
kairat | amakarov, so it is not my case and I was not thinking about it=) | 13:10 |
kairat | yep | 13:11 |
kairat | this is that I am going to do | 13:11 |
kairat | It seems that it is not possible to load from configuration in my case | 13:12 |
*** terryyao has quit IRC | 13:13 | |
amakarov | Looks like I can't understand the case. Why do you need project in config if you already have trust? | 13:13 |
kairat | I need to create trust | 13:13 |
kairat | to create trust I need trustee_user_id | 13:14 |
kairat | to request id of the service user I need to init a project-scoped auth plugin, session, client | 13:14 |
kairat | after that I can create trust | 13:14 |
kairat | This is the common case I think | 13:15 |
kairat | I was trying to follow Stuart suggestion in review: get rid of CONF.keystone_authtoken completely | 13:16 |
kairat | but it turned out that it is not so simple=) | 13:16 |
kairat | *get rid of CONF.keystone_authtoken.xxx completely | 13:17 |
*** chenke_ has joined #openstack-keystone | 13:21 | |
amakarov | ok, to the beginning: so do you want just mix the new trust id into auth credentials from your config? | 13:21 |
amakarov | kairat, ^^ | 13:22 |
*** doug-fish has joined #openstack-keystone | 13:23 | |
samueldmq | dolphm: hi, I would appreciate your view on https://review.openstack.org/#/c/253208/ | 13:23 |
samueldmq | dolphm: it changes status code from 200 to 201 for endpoint crete | 13:24 |
samueldmq | create?* | 13:24 |
*** chenke__ has quit IRC | 13:24 | |
*** terryyao has joined #openstack-keystone | 13:26 | |
kairat | amakarov, yep | 13:27 |
*** fawadkhaliq has quit IRC | 13:27 | |
*** henrynash has quit IRC | 13:28 | |
*** edmondsw has joined #openstack-keystone | 13:36 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Implements base classes for functional tests https://review.openstack.org/253971 | 13:37 |
*** terryyao has quit IRC | 13:38 | |
*** petertr7_away is now known as petertr7 | 13:41 | |
*** jed56 has joined #openstack-keystone | 13:53 | |
*** jerrygb_ has joined #openstack-keystone | 14:08 | |
*** topol has joined #openstack-keystone | 14:11 | |
*** ChanServ sets mode: +v topol | 14:11 | |
*** jerrygb has quit IRC | 14:11 | |
*** pece has quit IRC | 14:11 | |
*** topol has quit IRC | 14:17 | |
*** topol has joined #openstack-keystone | 14:18 | |
*** ChanServ sets mode: +v topol | 14:18 | |
*** breitz has quit IRC | 14:19 | |
*** breitz has joined #openstack-keystone | 14:19 | |
*** gokrokve has joined #openstack-keystone | 14:22 | |
*** ayoung has joined #openstack-keystone | 14:28 | |
*** ChanServ sets mode: +v ayoung | 14:28 | |
openstackgerrit | ayoung proposed openstack/keystone: Implied Roles https://review.openstack.org/242614 | 14:29 |
ayoung | samueldmq, I am now | 14:29 |
ayoung | samueldmq, dman, what was I thinking back then... | 14:30 |
*** kairat has left #openstack-keystone | 14:30 | |
samueldmq | ayoung: hehe I was wondering if that was something that still has some meaning (and then needs to be elaborated) or removed | 14:30 |
samueldmq | ayoung: perhaps just removing it ? | 14:30 |
ayoung | samueldmq, 71c6a4b8 tests/test_auth.py (Dolph Mathews 2013-05-23 11:34:35 -0500 989) # TODO(ayoung): Endpoints | 14:30 |
ayoung | I blame dolphm | 14:31 |
samueldmq | haha | 14:31 |
samueldmq | ayoung: I saw your name there and didn't do a git blame, haha | 14:31 |
ayoung | samueldmq, nah, I think that he did a git blame when he updated those | 14:32 |
ayoung | look at that review. | 14:32 |
ayoung | ita ll adding (name) tothe existing TODOs. | 14:32 |
ayoung | Let me go back one more... | 14:32 |
lbragstad | bknudson stevemar so all the patches to tempest merged for fernet | 14:35 |
*** pnavarro|lunch is now known as pnavarro | 14:36 | |
lbragstad | want me to get a patch up in keystone addressing brants comment here? https://review.openstack.org/#/c/195780/ | 14:36 |
ayoung | samueldmq, like this: | 14:36 |
ayoung | [ayoung@ayoung541 keystone]$ git blame 71c6a4b8^ -- tests/test_auth.py | grep TODO | 14:36 |
ayoung | 601eeb50 tests/test_auth.py (Adam Young 2013-02-26 14:54:32 -0500 599) #TODO Endpoints | 14:36 |
samueldmq | lbragstad: have we fixed the issue or just appied sleep(..) for now ? | 14:36 |
bknudson | lbragstad: you'll have to change devstack so that it sets up fernet by default first | 14:36 |
lbragstad | samueldmq they are just sleeps | 14:37 |
ayoung | samueldmq, so that was the big trusts patch. I'm guessing that I felt we needed to test trusts there somehow... | 14:37 |
samueldmq | ayoung: yes, smart enough using the ^ :) | 14:37 |
lbragstad | samueldmq that's why we have a database for the removal of sql.Dattime | 14:37 |
bknudson | xek: https://bugs.launchpad.net/keystone/+bug/1524124 | 14:37 |
openstack | Launchpad bug 1524124 in OpenStack Identity (keystone) "unscalable database schema design" [Undecided,New] | 14:37 |
lbragstad | bknudson ah, gotcha | 14:37 |
bknudson | if you want to make keystone's default fernet | 14:38 |
bknudson | or maybe keystone could set up fernet itself if it's not already setup? | 14:38 |
samueldmq | ayoung: in other places there is ' Enforce Endpoints for trust' | 14:38 |
samueldmq | ayoung: does that say something to you? | 14:38 |
ayoung | samueldmq, I think, if I can interpret what I meant back then, was that the response should have the appropriate set of endpoints in it due to the impersonation. | 14:38 |
lbragstad | bknudson you mean setup the key repository? | 14:38 |
bknudson | lbragstad: yes | 14:39 |
lbragstad | bknudson that wouldn't be a bad idea, it would be pretty quick too | 14:39 |
*** rderose has joined #openstack-keystone | 14:39 | |
samueldmq | ayoung: or this: https://github.com/openstack/keystone/commit/601eeb50#diff-62cbabeec6b39be14b2e758fccb460c0R83 | 14:39 |
lbragstad | bknudson check if the key_repository exists, if so use it. if not then create one and bootstrap it | 14:39 |
ayoung | samueldmq, but Ithink that predates the endpoint filter, so I don't know how they could ever vary back then | 14:39 |
lhcheng | bknudson: do we support version-less identity endpoint in the service catalog? | 14:40 |
bknudson | lhcheng: I don't know. There's no tempest test for it | 14:40 |
lhcheng | it was recommended to use version-less endpoint here, but I'm not sure if that actually works or supported. https://ask.openstack.org/en/question/67292/what-are-implication-of-using-both-v20-and-v3-endpoint-of-keystone/ | 14:40 |
bknudson | I doubt that it works or is supported | 14:41 |
breton | lhcheng: it should: http://dolphm.com/openstack-keystone-service-catalog/ | 14:41 |
*** bknudson has left #openstack-keystone | 14:41 | |
*** bknudson has joined #openstack-keystone | 14:41 | |
*** ChanServ sets mode: +v bknudson | 14:41 | |
samueldmq | ayoung: perhaps that relates to https://github.com/openstack/keystone/blob/master/keystone/token/providers/common.py#L441 ? | 14:42 |
bknudson | it would be interesting to see a change proposed to devstack that uses versionless endpoint. | 14:42 |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 14:43 |
*** Nirupama has quit IRC | 14:43 | |
ayoung | samueldmq, yeah. I think we had an idea back then that we would do future work with trusts and endpoints, and limiting what was in a token...I am pretty sure that there is no reason to do that now. The endpoint filter code is based on the project ID of the token, and that is the only thing that would come into play. | 14:43 |
*** fawadkhaliq has joined #openstack-keystone | 14:43 | |
ayoung | I think you cn safely remove the comments | 14:43 |
samueldmq | ayoung: makes sense sir, thanks | 14:44 |
lhcheng | bknudson: horizon likely won't work too, since it uses the service catalog to talk to. The version-less endpoint have the assumption that people uses a client that knows how to discover the endpoint. | 14:45 |
bknudson | right, it's the clients that are the problem. | 14:45 |
bknudson | lhcheng: https://review.openstack.org/255294 | 14:48 |
*** gokrokve has quit IRC | 14:49 | |
*** timcline has joined #openstack-keystone | 14:50 | |
*** timcline has quit IRC | 14:52 | |
lhcheng | bknudson: cool, I'm curious with the result | 14:53 |
ayoung | samueldmq, If you want to be strictly dilligent, check that the service catalog back from the response is a correct V2 service catalog. There might be a check elsewhere you can reuse. | 14:53 |
* breton is waiting for the tests to finish too | 14:54 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Remove comments on enforcing endpoints for trust https://review.openstack.org/255305 | 14:59 |
samueldmq | ayoung: ^ | 14:59 |
samueldmq | ayoung: k, let me check | 14:59 |
*** petertr7 is now known as petertr7_away | 15:02 | |
openstackgerrit | Dina Belova proposed openstack/python-keystoneclient: Add shell --profile option to trigger osprofiler from CLI https://review.openstack.org/255308 | 15:02 |
openstackgerrit | Dina Belova proposed openstack/python-keystoneclient: Add shell --profile option to trigger osprofiler from CLI https://review.openstack.org/255308 | 15:03 |
*** roxanaghe has joined #openstack-keystone | 15:04 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:05 | |
ayoung | dstanek, marekd I'd really like to get this moving: https://review.openstack.org/#/c/242853/ . Did he answer your questions well enough? | 15:05 |
*** petertr7_away is now known as petertr7 | 15:06 | |
*** pumaranikar has joined #openstack-keystone | 15:07 | |
*** pumaranikar has quit IRC | 15:07 | |
*** diazjf has joined #openstack-keystone | 15:08 | |
*** pumaranikar has joined #openstack-keystone | 15:08 | |
*** pushkaru has joined #openstack-keystone | 15:08 | |
*** pushkaru has quit IRC | 15:08 | |
*** pumaranikar has quit IRC | 15:09 | |
*** pumaranikar has joined #openstack-keystone | 15:09 | |
*** roxanaghe has quit IRC | 15:09 | |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/keystone: API support for project cascade update https://review.openstack.org/243585 | 15:10 |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/keystone: Manager support for project cascade update https://review.openstack.org/243584 | 15:10 |
*** richm1 is now known as richm | 15:10 | |
dstanek | ayoung: i'm ok with it now. although we should probably start to gate against the new test target | 15:10 |
openstackgerrit | Tom Cocozzello proposed openstack/keystone: fix reuse of variables https://review.openstack.org/245331 | 15:10 |
dstanek | marekd: any reason to hold it up? | 15:11 |
ayoung | dstanek, the legacy target? | 15:16 |
lbragstad | nonameentername added some more comments to your spec - https://review.openstack.org/#/c/130376/ | 15:17 |
dstanek | ayoung: yeah | 15:18 |
ayoung | dstanek, ++ | 15:19 |
*** noqa_v_qoovnie has quit IRC | 15:22 | |
lbragstad | dolphm did you have a writeup on getting tempest running against keystone only? | 15:25 |
*** timcline has joined #openstack-keystone | 15:25 | |
*** davechen has joined #openstack-keystone | 15:27 | |
lbragstad | davechen not sure if you saw it yet but dolphm responded to you here - https://review.openstack.org/#/c/215715/14/keystone/assignment/core.py | 15:29 |
*** gokrokve has joined #openstack-keystone | 15:30 | |
davechen | lbragstad: look in! | 15:30 |
*** Ephur has joined #openstack-keystone | 15:30 | |
*** rderose has quit IRC | 15:30 | |
breton | bknudson: lhcheng: RelativeURIError: Only absolute URIs are allowed. uri = /v2.0h/v2.0t/v2.0t/v2.0p/v2.0:/v2.0/v2.0/v2.01/v2.09/v2.02/v2.0./v2.01/v2.06/v2.08/v2.0./v2.03/v2.03/v2.0./v2.01/v2.0:/v2.03/v2.05/v2.03/v2.05/v2.07/v2.0/tenants | 15:30 |
breton | https://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.ssl.cf1.rackcdn.com/94/255294/1/18800/logs/tempest.txt.gz | 15:31 |
davechen | lbragstad: yes, i meant unittest. | 15:31 |
breton | it seems that tempest cannot into version discovery | 15:31 |
lbragstad | davechen ok | 15:31 |
*** timcline has quit IRC | 15:31 | |
bknudson | breton: so we've got a step 1! | 15:31 |
davechen | lbragstad: i did this before: https://review.openstack.org/#/c/245633/ | 15:32 |
*** timcline has joined #openstack-keystone | 15:32 | |
davechen | lbragstad: i think it's basically the same things. | 15:32 |
bknudson | that's a weird error | 15:32 |
lbragstad | davechen oh, interesting | 15:32 |
lbragstad | davechen checking | 15:32 |
openstackgerrit | Merged openstack/oslo.policy: Use dict comprehension https://review.openstack.org/255062 | 15:33 |
*** gokrokve has quit IRC | 15:35 | |
samueldmq | dstanek: does my reply make sense on https://review.openstack.org/#/c/253219/2/keystone/tests/unit/test_v3_assignment.py ? | 15:35 |
*** belmoreira has quit IRC | 15:39 | |
*** gokrokve has joined #openstack-keystone | 15:45 | |
openstackgerrit | Dina Belova proposed openstack/keystone: === WIP === Integrate OSprofiler in Keystone https://review.openstack.org/103368 | 15:47 |
*** ninag has joined #openstack-keystone | 15:47 | |
*** slberger has joined #openstack-keystone | 15:49 | |
samueldmq | ayoung: I didn't find an easy way to check the v2 catalog validity from within that test is | 15:50 |
samueldmq | ayoung: https://review.openstack.org/#/c/255305/ | 15:50 |
openstackgerrit | Dina Belova proposed openstack/keystone: === WIP === Integrate OSprofiler in Keystone https://review.openstack.org/103368 | 15:50 |
samueldmq | ayoung: would you be okay with just removing them ? | 15:50 |
*** diazjf has quit IRC | 15:50 | |
ayoung | samueldmq, yes | 15:50 |
samueldmq | ayoung: cool, it's up for review, thanks | 15:52 |
*** arunkant_ has joined #openstack-keystone | 15:53 | |
*** daemontool has joined #openstack-keystone | 15:56 | |
*** gokrokve has quit IRC | 15:58 | |
*** gokrokve has joined #openstack-keystone | 15:59 | |
dstanek | samueldmq: yes, just seems like a wasted assert, but it was already there | 16:00 |
* dstanek was inspired by lbragstad and samueldmq to publish a Trello board of the keystone stuff i am working on | 16:00 | |
dstanek | dolphm: you around or on vacation? | 16:01 |
lbragstad | dstanek ? | 16:02 |
lbragstad | dstanek I believe dolphm is on vacation | 16:02 |
*** pgbridge has joined #openstack-keystone | 16:03 | |
dstanek | lbragstad: you were asking me on Thurs or Fri about my lists of bugs; working on publishing the ones i care about - finished starred reviews last night and will work on my own review tonight | 16:03 |
*** zz_john5223 is now known as john5223 | 16:03 | |
*** pumaranikar has quit IRC | 16:04 | |
*** pumaranikar has joined #openstack-keystone | 16:05 | |
lbragstad | dstanek ah, you're making a trello board for them? | 16:06 |
dstanek | lbragstad: yep, it syncs directly from gerrit | 16:07 |
lbragstad | dstanek oh, sweet! | 16:08 |
*** tonytan4ever has joined #openstack-keystone | 16:09 | |
bknudson | dstanek: we had a team here write a tool to sync launchpad bugs with trello | 16:09 |
bknudson | tjcocozz: ^ | 16:09 |
tjcocozz | hello! | 16:10 |
dstanek | bknudson: tjcocozz: is that opensource? that would be my next step | 16:10 |
lbragstad | I'd help weekend warrior open-sourcing it, that would be super helpful | 16:10 |
tjcocozz | It is not opensource, i was advised against it. :/ | 16:11 |
tjcocozz | bknudson, what do you think i should do? | 16:11 |
bknudson | tjcocozz: you need new advisotrs | 16:11 |
bknudson | advisors | 16:11 |
lbragstad | ask forgiveness and not permission | 16:11 |
lbragstad | tjcocozz ^ | 16:11 |
lbragstad | :) | 16:12 |
bknudson | tjcocozz: you'll want to ask for permission in this case, but I can't think of a reason why it would be rejected. talk to chris schaefer | 16:12 |
tjcocozz | bknudson, he is out for a couple weeks. i will find someone to talk too | 16:13 |
dstanek | tjcocozz: then it's a race. i plan on working on the LP stuff soon | 16:14 |
bknudson | dstanek: is your gerrit sync open source? | 16:14 |
dstanek | bknudson: yes, once i finish up adding my stuff i'll publish on github and pypi | 16:15 |
bknudson | great, then we can steal it and not contribute back | 16:15 |
dstanek | i need a name too - it's trellit because the plan was gerrit->trello integration, but last night i decided to add LP bugs too | 16:16 |
dstanek | bknudson: you are more than welcome to steal! | 16:16 |
*** chenke__ has joined #openstack-keystone | 16:17 | |
*** jerrygb_ has quit IRC | 16:18 | |
*** chenke_ has quit IRC | 16:20 | |
bknudson | you guys must not have lawyers watching your every move. | 16:21 |
*** daemontool_ has joined #openstack-keystone | 16:23 | |
*** daemontool has quit IRC | 16:28 | |
*** jaosorior has quit IRC | 16:32 | |
*** rderose has joined #openstack-keystone | 16:35 | |
notmorgan | jamielennox|away: we should convert keystoneclient to use KSA for everything. | 16:37 |
*** ctina_ has joined #openstack-keystone | 16:43 | |
*** topol has quit IRC | 16:47 | |
*** gokrokve has quit IRC | 16:51 | |
dolphm | dstanek: conferencing Tue-Fri this week | 16:55 |
*** gyee has joined #openstack-keystone | 16:56 | |
*** ChanServ sets mode: +v gyee | 16:56 | |
dolphm | dstanek, bknudson, tjcocozz: similar thing i did for rax last year https://github.com/dolph/launchpad2trello/ | 16:56 |
davechen | lbragstad: pls pull the trigger if don't has any concern - https://review.openstack.org/#/c/250032/ | 16:57 |
bknudson | should have known dolphm already had a solution to this! | 16:57 |
bknudson | we'll check with him next time. | 16:58 |
lbragstad | davechen checking it out | 16:58 |
davechen | lbragstad: thanks! :) | 16:59 |
lbragstad | davechen thank you! | 16:59 |
*** petertr7 is now known as petertr7_away | 16:59 | |
*** petertr7_away is now known as petertr7 | 17:00 | |
*** links has quit IRC | 17:01 | |
*** lhcheng has quit IRC | 17:04 | |
*** daemontool_ has quit IRC | 17:08 | |
tjcocozz | dstanek, want to test mine out? | 17:11 |
*** rcernin has quit IRC | 17:11 | |
dstanek | tjcocozz: lp->trello sync? | 17:12 |
tjcocozz | dstanek, yup :) | 17:12 |
tjcocozz | all you need to do is create a trello board and add blt bot to it | 17:12 |
tjcocozz | next time he runs he will add a config card to your board. | 17:12 |
dstanek | tjcocozz: sure | 17:12 |
*** aginwala has joined #openstack-keystone | 17:13 | |
tjcocozz | dstanek, then just edit the config card however you would like. NOTE: the company i work for nor I take responsibility for anything :p | 17:15 |
dstanek | tjcocozz: i probably will just take a look at how you are doing it to see if it's close to what i want | 17:16 |
tjcocozz | dstanek, that is kinda what i expected, i talked to my manager and it looks like within a week i will be able to tell you if i can opensource it or not | 17:17 |
*** jistr has quit IRC | 17:19 | |
*** rderose has quit IRC | 17:19 | |
openstackgerrit | Priti Desai proposed openstack/keystone: Adding role assignment lists unit tests https://review.openstack.org/254436 | 17:20 |
breton | we have a lp->trello sync tool too | 17:21 |
breton | https://github.com/tsufiev/lp2trello | 17:21 |
tjcocozz | it seems like everyones got one | 17:23 |
*** dims has quit IRC | 17:24 | |
samueldmq | dstanek: yes | 17:26 |
openstackgerrit | Tom Cocozzello proposed openstack/python-keystoneclient: WIP set up incude names for list role assignments https://review.openstack.org/255392 | 17:27 |
* samueldmq wants to see dstanek's trello board of keystone stuff | 17:27 | |
*** gokrokve has joined #openstack-keystone | 17:30 | |
*** jbell8 has joined #openstack-keystone | 17:31 | |
davechen | gyee: pls help to take a look at this if you are around, it's pretty easy - https://review.openstack.org/#/c/247900/ | 17:34 |
lbragstad | davechen i responded to one question stevemar had https://review.openstack.org/#/c/250032/ | 17:35 |
gyee | davechen, yes sir | 17:36 |
*** ayoung has quit IRC | 17:37 | |
davechen | lbragstad: ah, it was did in the follow up, i think you it canbe used by controller since i have moved them into manager. | 17:37 |
lbragstad | davechen that was proposed in a follow up? | 17:38 |
davechen | lbragstad: yeah. | 17:38 |
lbragstad | ok checking | 17:38 |
davechen | lbragstad: i moved them into manager so that duplication issue is gone and these methods can be called by both controller and manager. | 17:39 |
davechen | gyee: thanks sir! | 17:39 |
lbragstad | davechen nice | 17:39 |
davechen | i will cherry-pick them to kilo and liberty afterwards. | 17:41 |
gyee | lbragstad, any suggestion with this one? https://review.openstack.org/#/c/233069/10 | 17:43 |
gyee | lbragstad, we can move later if needed, how about lets keep it in there for now? | 17:43 |
lbragstad | gyee breton that's fine with me, maybe update with a comment saying that | 17:44 |
lbragstad | it's a module level function and it's the only one outside of the Hints class | 17:44 |
lbragstad | just made it seem like it should live either in Hints, or be moved somewhere else | 17:45 |
lbragstad | if it's specific to Hints, put it in the calss | 17:45 |
lbragstad | class* | 17:45 |
*** topol has joined #openstack-keystone | 17:48 | |
*** ChanServ sets mode: +v topol | 17:48 | |
*** spandhe has joined #openstack-keystone | 17:48 | |
*** spandhe has quit IRC | 17:49 | |
gyee | lbragstad, yeah, that sounds good | 17:50 |
*** topol has quit IRC | 17:52 | |
*** tonytan4ever has quit IRC | 17:55 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone: Limiting for domain-specific drivers https://review.openstack.org/255408 | 18:01 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone-specs: Fix Create Endpoint API Status Code https://review.openstack.org/255409 | 18:02 |
*** petertr7 is now known as petertr7_away | 18:02 | |
samueldmq | dstanek: ^ | 18:02 |
*** ayoung has joined #openstack-keystone | 18:03 | |
*** ChanServ sets mode: +v ayoung | 18:03 | |
openstackgerrit | Henrique Truta proposed openstack/keystone: Tests for projects acting as domains https://review.openstack.org/211219 | 18:05 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Projects acting as domains https://review.openstack.org/231289 | 18:05 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Removes project.domain_id FK https://review.openstack.org/233274 | 18:05 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Change project name constraints https://review.openstack.org/158372 | 18:05 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Add is_domain parameter to get_project_by_name https://review.openstack.org/210600 | 18:05 |
*** browne has joined #openstack-keystone | 18:06 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone-specs: Fix Create Endpoint API Status Code https://review.openstack.org/255409 | 18:07 |
htruta | hey gyee, samueldmq regarding this patch: https://review.openstack.org/#/c/134095/ | 18:09 |
samueldmq | htruta: hi | 18:10 |
htruta | do you really think that service, region and interface are enough for identifying an endpoint? | 18:10 |
gyee | htruta, yes | 18:11 |
samueldmq | htruta: I think it is | 18:11 |
gyee | Keystone Session said so too :) | 18:12 |
htruta | gyee, samueldmq: cool. thanks | 18:12 |
gyee | if you have two endpoints with the exact same service, region, and interface, Session will only go with the first one | 18:13 |
htruta | gyee: I thought it as a way to have some sort of HA with multiple URLs | 18:13 |
htruta | but doesn't seem the right way to do | 18:13 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/254444 | 18:13 |
*** aginwala has quit IRC | 18:14 | |
gyee | htruta, no | 18:15 |
*** shaleh has joined #openstack-keystone | 18:15 | |
gyee | htruta, lets put it this one, if you know precisely which URL to use, then there's no point of having other attributes | 18:15 |
gyee | s/this one/this way/ | 18:15 |
*** markvoelker has quit IRC | 18:18 | |
*** gyee has quit IRC | 18:19 | |
*** tonytan4ever has joined #openstack-keystone | 18:20 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Remove unfixable FIXME https://review.openstack.org/255419 | 18:21 |
samueldmq | dstanek: stevemar: still related to that ^ | 18:21 |
*** markvoelker has joined #openstack-keystone | 18:21 | |
htruta | gyee: makes sense | 18:22 |
*** spandhe has joined #openstack-keystone | 18:24 | |
openstackgerrit | Sean Perry proposed openstack/keystone: Use new_policy_ref consistently https://review.openstack.org/247257 | 18:25 |
*** pnavarro has quit IRC | 18:29 | |
openstackgerrit | Merged openstack/keystone-specs: Fix Create Endpoint API Status Code https://review.openstack.org/255409 | 18:29 |
*** miyagishi_t has quit IRC | 18:33 | |
openstackgerrit | Henrique Truta proposed openstack/keystone: Constraint to prevent duplicates endpoints https://review.openstack.org/134095 | 18:37 |
*** e0ne has quit IRC | 18:41 | |
*** aginwala has joined #openstack-keystone | 18:42 | |
openstackgerrit | werner mendizabal proposed openstack/keystone-specs: Multifactor Authentication https://review.openstack.org/130376 | 18:43 |
*** aix has quit IRC | 18:43 | |
*** richm has quit IRC | 18:49 | |
*** flwang1 has quit IRC | 18:50 | |
*** flwang1 has joined #openstack-keystone | 18:51 | |
*** lhcheng has joined #openstack-keystone | 18:52 | |
*** ChanServ sets mode: +v lhcheng | 18:52 | |
openstackgerrit | Sean Perry proposed openstack/keystone: Clean up new_credential_ref usage and surrounding code https://review.openstack.org/246713 | 18:53 |
*** aginwala has quit IRC | 18:54 | |
*** ninag has quit IRC | 18:56 | |
*** ninag has joined #openstack-keystone | 18:57 | |
*** gokrokve has quit IRC | 18:57 | |
*** lhcheng has quit IRC | 18:57 | |
*** gokrokve has joined #openstack-keystone | 18:59 | |
*** gokrokve has quit IRC | 18:59 | |
*** flwang1 has quit IRC | 19:00 | |
*** david-ly_ has joined #openstack-keystone | 19:00 | |
*** ninag has quit IRC | 19:01 | |
*** david-ly_ is now known as david-lyle_ | 19:03 | |
*** ninag has joined #openstack-keystone | 19:03 | |
*** david-lyle has quit IRC | 19:03 | |
*** fawadkhaliq has quit IRC | 19:04 | |
*** gokrokve has joined #openstack-keystone | 19:04 | |
*** ninag_ has joined #openstack-keystone | 19:04 | |
*** david-lyle_ is now known as david-lyle | 19:04 | |
*** gokrokve has quit IRC | 19:05 | |
*** ninag__ has joined #openstack-keystone | 19:06 | |
*** gokrokve has joined #openstack-keystone | 19:06 | |
*** ninag__ has quit IRC | 19:07 | |
*** ninag has quit IRC | 19:07 | |
*** doug-fish has quit IRC | 19:08 | |
*** doug-fish has joined #openstack-keystone | 19:09 | |
*** ninag_ has quit IRC | 19:09 | |
*** gokrokve has quit IRC | 19:10 | |
*** ninag has joined #openstack-keystone | 19:10 | |
*** ninag has quit IRC | 19:10 | |
*** aginwala has joined #openstack-keystone | 19:10 | |
*** tsymanczyk has quit IRC | 19:10 | |
*** doug-fish has quit IRC | 19:14 | |
*** gyee has joined #openstack-keystone | 19:14 | |
*** ChanServ sets mode: +v gyee | 19:14 | |
*** e0ne has joined #openstack-keystone | 19:15 | |
*** shaleh is now known as shaleh|away | 19:15 | |
*** petertr7_away is now known as petertr7 | 19:15 | |
*** lhcheng has joined #openstack-keystone | 19:16 | |
*** ChanServ sets mode: +v lhcheng | 19:16 | |
*** lhcheng_ has joined #openstack-keystone | 19:17 | |
*** lhcheng has quit IRC | 19:21 | |
*** tsymanczyk has joined #openstack-keystone | 19:21 | |
*** tsymanczyk is now known as Guest61493 | 19:21 | |
*** doug-fish has joined #openstack-keystone | 19:23 | |
*** doug-fish has quit IRC | 19:23 | |
openstackgerrit | Jorge Munoz proposed openstack/keystone: Reduce revoke events for disabled domains and projects. https://review.openstack.org/253273 | 19:23 |
*** doug-fish has joined #openstack-keystone | 19:23 | |
*** topol has joined #openstack-keystone | 19:30 | |
*** ChanServ sets mode: +v topol | 19:30 | |
*** diazjf has joined #openstack-keystone | 19:33 | |
*** henrynash has joined #openstack-keystone | 19:37 | |
*** ChanServ sets mode: +v henrynash | 19:37 | |
*** _cjones_ has joined #openstack-keystone | 19:45 | |
*** briancurtin has quit IRC | 19:46 | |
*** briancurtin has joined #openstack-keystone | 19:46 | |
openstackgerrit | Jorge Munoz proposed openstack/keystone: Reduce revoke events for disabled domains and projects. https://review.openstack.org/253273 | 19:49 |
*** flwang1 has joined #openstack-keystone | 19:49 | |
*** tqtran has joined #openstack-keystone | 19:49 | |
*** gokrokve has joined #openstack-keystone | 19:51 | |
*** gokrokve has quit IRC | 19:52 | |
*** gokrokve has joined #openstack-keystone | 19:52 | |
*** gokrokve has quit IRC | 19:53 | |
*** steveng has joined #openstack-keystone | 19:54 | |
*** Guest61493 has quit IRC | 19:54 | |
steveng | Hey people.. I have a 10 node setup.. Currently I am using kilo keystone.. But I want to upgrade to liberty but just the keystone.. How do I do that? | 19:55 |
*** john5223 is now known as zz_john5223 | 19:56 | |
*** david-lyle has quit IRC | 19:58 | |
*** david-lyle has joined #openstack-keystone | 19:58 | |
*** tonytan4ever has quit IRC | 19:59 | |
*** aginwala has quit IRC | 20:01 | |
henrynash | ayoung, dstanek, stevemar: feel free for one of you to +A https://review.openstack.org/#/c/242853/ so we can get these new drivers going…. | 20:04 |
*** lhcheng_ has quit IRC | 20:05 | |
*** lhcheng has joined #openstack-keystone | 20:06 | |
*** ChanServ sets mode: +v lhcheng | 20:06 | |
ayoung | henrynash, done. THought I had | 20:06 |
samueldmq | henrynash: nicely done | 20:06 |
*** aginwala has joined #openstack-keystone | 20:07 | |
henrynash | ayoung: thx | 20:07 |
ayoung | henrynash, so, can you explain to me what we can do with DSRs that we cannot do using cross domain group assignements? | 20:07 |
henrynash | ayoung: let’s chat later…if I don’t eat soon, I’ll expire! | 20:08 |
openstackgerrit | Jorge Munoz proposed openstack/keystone: Reduce revoke events for disabled domains and projects. https://review.openstack.org/253273 | 20:08 |
ayoung | henrynash, if you breathe, you inspire. If you don't, you expire | 20:08 |
tjcocozz | At 23, JK Rowling was broke. Tina Fey was working at the Y.M.C.A. Oprah had just gotten fired from her first job as a TV reporter and Walt Disney had declared bankruptcy | 20:11 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Add backend support for deleting a projects list https://review.openstack.org/245916 | 20:14 |
*** gildub has joined #openstack-keystone | 20:16 | |
*** tonytan4ever has joined #openstack-keystone | 20:18 | |
*** aginwala has quit IRC | 20:19 | |
openstackgerrit | ayoung proposed openstack/keystone: Updated Cloudsample https://review.openstack.org/240720 | 20:21 |
ayoung | tjcocozz, I just scrolled up to see your earlier conversation. I was about to boot you as a bot. | 20:24 |
*** gokrokve has joined #openstack-keystone | 20:24 | |
*** steveng has quit IRC | 20:24 | |
ayoung | steveng, do you have keystone running in its own VM/COntainer/Host? | 20:24 |
*** aginwala has joined #openstack-keystone | 20:24 | |
*** steveng has joined #openstack-keystone | 20:25 | |
tjcocozz | ayoung, i will try to sound more human. sorry :) | 20:25 |
* tjcocozz wew that was a close one | 20:26 | |
ayoung | tjcocozz, not required. I'm already convinced bknudson is an android. And not the cell phone | 20:26 |
* bknudson that was a close one! | 20:26 | |
ayoung | Fairly certain bknudson was ported from one of those military bomb defusing robots actually | 20:27 |
ayoung | Yup...that has to be it...lot of things make sense once you assume that. | 20:27 |
bknudson | I'll use that as my avatar | 20:27 |
*** gokrokve has quit IRC | 20:27 | |
*** gokrokve has joined #openstack-keystone | 20:28 | |
ayoung | http://www.engineering.com/Portals/0/BlogFiles/DesignerEdge/0613/john-hopkins-bomb-disposal-robot.jpg | 20:28 |
bknudson | that one has creepy hands | 20:29 |
*** petertr7 is now known as petertr7_away | 20:31 | |
*** tsymanczyk has joined #openstack-keystone | 20:34 | |
*** tsymanczyk is now known as Guest71412 | 20:34 | |
*** RichardRaseley has joined #openstack-keystone | 20:35 | |
*** petertr7_away is now known as petertr7 | 20:37 | |
*** belmoreira has joined #openstack-keystone | 20:41 | |
*** gokrokve has quit IRC | 20:43 | |
openstackgerrit | Jorge Munoz proposed openstack/keystone: Reduce revoke events for disabled domains and projects. https://review.openstack.org/253273 | 20:49 |
*** dims has joined #openstack-keystone | 20:49 | |
*** diazjf has quit IRC | 20:50 | |
*** diazjf has joined #openstack-keystone | 20:52 | |
*** mhickey has quit IRC | 20:53 | |
openstackgerrit | werner mendizabal proposed openstack/keystone-specs: Multifactor Authentication https://review.openstack.org/130376 | 20:55 |
*** jasonsb has quit IRC | 20:56 | |
*** diazjf has quit IRC | 20:57 | |
*** diazjf has joined #openstack-keystone | 20:58 | |
*** dims has quit IRC | 20:58 | |
stevemar | i like how the cameras make it seem like it has a face | 20:59 |
nonameentername | gyee: could you please review my blueprint, when you get a change? https://review.openstack.org/#/c/130376 thanks! | 20:59 |
stevemar | gyee: yes yes review :) | 21:00 |
*** dims has joined #openstack-keystone | 21:00 | |
stevemar | nonameentername: the API changes should go here: https://github.com/openstack/keystone-specs/blob/master/api/v3/identity-api-v3.rst | 21:00 |
stevemar | but we can figure that out later... | 21:00 |
*** dims has quit IRC | 21:01 | |
nonameentername | stevemar: ok, thanks! | 21:01 |
lbragstad | stevemar oh good catch, nonameentername sorry for the bum steer | 21:01 |
lbragstad | stevemar is it cool to do those as a dependent patch? | 21:02 |
stevemar | lbragstad: sure | 21:02 |
lbragstad | good to know | 21:02 |
stevemar | lbragstad: remember to mark those as "experimental" | 21:02 |
lbragstad | stevemar makes sense | 21:03 |
*** raildo is now known as raildo-afk | 21:06 | |
*** ctina_ has quit IRC | 21:09 | |
*** pauloewerton has quit IRC | 21:13 | |
*** atiwari1 has quit IRC | 21:16 | |
*** atiwari1 has joined #openstack-keystone | 21:18 | |
gyee | nonameentername, stevemar, on it, sorry I just got back to my desk | 21:25 |
*** steveng has quit IRC | 21:25 | |
*** shaleh|away is now known as shaleh | 21:26 | |
*** belmoreira has quit IRC | 21:26 | |
*** aginwala has quit IRC | 21:26 | |
stevemar | gyee: s'all good | 21:26 |
notmorgan | zigo: ping re debconf stuff | 21:28 |
notmorgan | zigo: i think you've been covering some of it on the ML but I'd like to actually do something a bit more real-time if you're available | 21:28 |
shaleh | stevemar, gyee: my last two outstanding unit test reviews have passed Jenkins. Please send them down the pipe. | 21:30 |
gyee | shaleh, yes sir | 21:30 |
stevemar | shaleh: never! | 21:30 |
gyee | hah! | 21:30 |
stevemar | shaleh: at least, not without links | 21:30 |
gyee | s/links/beers/ | 21:30 |
shaleh | stevemar: heh | 21:31 |
shaleh | stevemar: https://review.openstack.org/246713 https://review.openstack.org/247257 | 21:31 |
* notmorgan drops the mic | 21:32 | |
* notmorgan kicks the mic off the stage...afraid ayoung will pick it up :P | 21:32 | |
gyee | ayoung love da mic | 21:32 |
notmorgan | dolphm: do you want auto OP in this channel still or do you want to just +V? like everyone else | 21:32 |
shaleh | in unit/test_backend_sql.py there is a method called clean_up_entities. Am I wrong or is that not method doing useless cleanup? | 21:32 |
*** e0ne has quit IRC | 21:32 | |
* ayoung don't need a mike with the horn.... | 21:34 | |
ayoung | unless there ar guitars with Amps. Hate playing against amps. | 21:34 |
gyee | my ears don't get along well with amps | 21:35 |
ayoung | I think shaleh and samueldmq are racing to see who can clean up more code. Should we start taking bets> | 21:37 |
openstackgerrit | Merged openstack/keystone: Update docs for legacy keystone extensions https://review.openstack.org/247900 | 21:37 |
shaleh | ayoung: not competing. | 21:38 |
ayoung | shaleh, its like Gimli and Legolas at Helms Deep. Which one of you is the dwarf and which one is the pretty boy elf? | 21:38 |
lbragstad | ayoung challenge accepted | 21:39 |
*** gordc has quit IRC | 21:39 | |
shaleh | ayoung: having met Samuel I think he is closer to Legolas even though I have better hair :-) | 21:39 |
lbragstad | shaleh that should be your next halloween idea | 21:39 |
shaleh | lbragstad: heh. If I put a robe on everyone thinks I am Jesus. | 21:40 |
lbragstad | shaleh lol | 21:40 |
shaleh | lbragstad: am I wrong or is the cleanup method happening around 621 in test_backend_sql.py a waste of time? | 21:41 |
lbragstad | shaleh checking | 21:42 |
ayoung | lbragstad, um...was the challenge you accepted blowing me off the stage with an amplified guitar? Looks like I'll be packing my microphone after all. | 21:42 |
*** jlk has joined #openstack-keystone | 21:42 | |
jlk | Where in the database is the role assignments tracked? | 21:43 |
lbragstad | shaleh kind of, doesn't look like it's used anywhere | 21:43 |
jlk | mysql backend | 21:43 |
shaleh | lbragstad: the test function right below it calls it. | 21:43 |
shaleh | addCleanup() | 21:43 |
shaleh | but it is cleaning up after a unit test. There should not be anything left behind anyways. | 21:44 |
*** steveng has joined #openstack-keystone | 21:44 | |
shaleh | maybe if this was a functional test with concerns over what row data is left behind | 21:44 |
lbragstad | shaleh where is it called? | 21:45 |
*** rharwood has left #openstack-keystone | 21:45 | |
shaleh | test_list_entities_filtered_by_domain(), the addCleanup() line | 21:45 |
samueldmq | ayoung: shaleh: hey what's up ? :) | 21:45 |
shaleh | when that one test is run, it cleans up after itself | 21:45 |
stevemar | notmorgan: that was a good burn on ayoung | 21:46 |
shaleh | samueldmq: ayoung was making me choose between Gimli and Legolas. You were the other one :-) | 21:46 |
notmorgan | stevemar: hehe | 21:46 |
notmorgan | stevemar: some jokes just never die ;) | 21:46 |
notmorgan | stevemar: at least ayoung has a sense of humor about it | 21:46 |
shaleh | samueldmq: I figured based on stature and build Legolas was a better fit even though I have better hair :-) | 21:46 |
gyee | jlk, take a look at the assignments table | 21:46 |
lbragstad | shaleh https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_backend_sql.py#L624 doesn't do anything with https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_backend_sql.py#L621 | 21:47 |
*** gordc has joined #openstack-keystone | 21:47 | |
jlk | gyee: yup, found it there, thanks. | 21:47 |
samueldmq | shaleh: haha I'll let my hair and beard grow then | 21:48 |
samueldmq | shaleh: actually beard would be required for Gimli :) | 21:49 |
*** richm1 has joined #openstack-keystone | 21:49 | |
shaleh | lbragstad: ah, slightly different line numbers. The method at 636 calls 624 | 21:49 |
ayoung | notmorgan, stevemar me picking up the mike is a real issue, isn't it? | 21:50 |
notmorgan | ayoung: always. | 21:50 |
shaleh | lbragstad: my opinion at the moment is the method at 624 is superfluous | 21:50 |
notmorgan | ayoung: mostly cause the rooms are small | 21:50 |
notmorgan | ayoung: not really for any other reason | 21:50 |
notmorgan | :P | 21:50 |
ayoung | 968696 | 21:50 |
lbragstad | shaleh your opinion has nothing to do with https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_backend_sql.py#L621 then? | 21:50 |
gyee | ayoung, https://review.openstack.org/#/c/240720/ | 21:51 |
shaleh | lbragstad: correct. In my code 621 is the cleanup method. | 21:51 |
gyee | that one still wrong | 21:51 |
shaleh | lbragstad: the joys of in process patches | 21:51 |
*** zz_john5223 is now known as john5223 | 21:52 | |
lbragstad | shaleh so you want to get rid of the method at 624 because it's only used in one place? | 21:52 |
shaleh | lbragstad: no. Because it is doing a useless cleanup after a unit test call. | 21:52 |
shaleh | lbragstad: with setUp() called before each test method what is there to really cleanup? | 21:52 |
shaleh | lbragstad: if this were a functional test with a mysql behind it I could understand it | 21:53 |
shaleh | lbragstad: and yes, I have tested it. There is no difference with or without the cleanup call. | 21:53 |
lbragstad | shaleh ah, you're saying that unit tests shouldn't have to bother cleaning things up | 21:53 |
bknudson | shaleh: we had memory problems before in the unit tests because the TestCase object was sticking around after running it. | 21:53 |
bknudson | so we added code to remove references to objects | 21:53 |
shaleh | bknudson: good to know | 21:53 |
lbragstad | I was just about to say, bknudson or dstanek would probably have a better answer for that | 21:54 |
*** diazjf has quit IRC | 21:54 | |
shaleh | this is why I asked instead of submitting a patch. Sometimes the rationale is not obvious. | 21:54 |
bknudson | I thought we had a method in the base test case to handle this which maybe would have made this code more obvious | 21:55 |
dstanek | shaleh: yeah, you may not notice the clean up issues at the small scale, but it's really important | 21:55 |
bknudson | http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/core.py#n460 | 21:56 |
bknudson | it's cleanup_instance | 21:56 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/254444 | 21:56 |
dstanek | i actually make a fix for this in a unittest subsclass, but it was ugly and invasive | 21:56 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/255553 | 21:56 |
*** tonytan4ever has quit IRC | 21:56 | |
bknudson | (I wonder if the TODO couldn't be done now?) | 21:56 |
notmorgan | bknudson: i'm going to do terrible things to keystonemiddleware soon. | 21:57 |
notmorgan | bknudson: anything i should poke at while i'm in there? | 21:57 |
lbragstad | shaleh fyi - http://cdn.pasteraw.com/fquvs3hxsigfloun94p9vyok21rl6v5 this passes tests locally | 21:57 |
bknudson | none of this really explains the memory leak problem. | 21:57 |
notmorgan | except the token hashing thing. | 21:57 |
notmorgan | bknudson: wait what memory leak? | 21:57 |
* notmorgan reads up | 21:58 | |
*** topol has quit IRC | 21:58 | |
notmorgan | oh in tests.. | 21:58 |
shaleh | lbragstad: fun | 21:58 |
dstanek | bknudson: can't remove the comment yet, but i think very soon | 21:58 |
lbragstad | shaleh nuke it! | 21:58 |
shaleh | lbragstad: so much left over debris | 21:58 |
*** topol has joined #openstack-keystone | 21:58 | |
*** ChanServ sets mode: +v topol | 21:58 | |
shaleh | lbragstad: my current round of minor cleanups is all of the 'self.foo =' where there is no reason for it to be a member variable. | 21:58 |
shaleh | lbragstad: I killed a fair amount of those during my last round | 21:59 |
bknudson | notmorgan: I'm sure jamielennox|away has some changes in flight? | 21:59 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: refactor: Remove unused test method https://review.openstack.org/255559 | 21:59 |
bknudson | I don't have anything going on | 21:59 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Use assertDictEqual instead of assertEqualPolicies https://review.openstack.org/251482 | 21:59 |
notmorgan | bknudson: some. i'm just digging through massive amounts of client/auth/middleware code | 21:59 |
lbragstad | shaleh ^ | 21:59 |
notmorgan | bknudson: oh, i will have a patch soon to make keystone-manage able to bootstrap a cloud | 21:59 |
stevemar | gyee: push this one through: https://review.openstack.org/#/c/251482/ | 21:59 |
notmorgan | bknudson: will want your eyes on that so we can kill admin_token | 22:00 |
notmorgan | bknudson: cause admin_token is bad. | 22:00 |
bknudson | nobody like admin_token but everyone uses it | 22:00 |
gyee | stevemar, ack | 22:00 |
notmorgan | bknudson: exactly. so just like doing the thing with the middleware fixture... screw it, lets just fix it | 22:00 |
notmorgan | bknudson: :) | 22:00 |
bknudson | notmorgan: the only auth_token middleware change I have is related to an embargoed bug | 22:01 |
notmorgan | bknudson: right | 22:01 |
notmorgan | bknudson: and that one i expect you've got handled | 22:01 |
shaleh | lbragstad: it looks like it is implemented to satisfy the one from test_backend BTW | 22:02 |
lbragstad | shaleh it looks like a different implementation | 22:03 |
shaleh | lbragstad: test_filter_value_wider_than_field() in test_backend.py | 22:03 |
*** topol has quit IRC | 22:03 | |
shaleh | lbragstad: the code checks for None which is the default implementation. | 22:04 |
*** edmondsw has quit IRC | 22:04 | |
lbragstad | shaleh but it has nothing to do with the code that I just removed | 22:04 |
lbragstad | right? | 22:04 |
shaleh | lbragstad: I believe the method you removed implements the abstract interface with a defined size | 22:05 |
shaleh | lbragstad: yay confusing object inheritance | 22:05 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/254633 | 22:05 |
shaleh | lbragstad: put a break in the method and run in a debugger | 22:05 |
shaleh | lbragstad: or just throw an exception | 22:05 |
lbragstad | shaleh stange, i completely removed that method, ran the tests, and everything passed... | 22:06 |
lbragstad | strange* | 22:06 |
shaleh | lbragstad: because if the value is None the tests short circuit | 22:07 |
lbragstad | shaleh the _get_user_name_field_size method in test_backend.py:FilterTests doesn't call super at all either? | 22:07 |
shaleh | lbragstad: someone was lazy and did not toss a NotImplementedError | 22:08 |
*** richm1 has quit IRC | 22:09 | |
shaleh | lbragstad: the idea looks to be implementing an abstract interface. test_backend defines a dummy method with the intent that ones deriving from it will override it | 22:09 |
shaleh | lbragstad: test_filter_value_wider_than_field() just immediately exists if you do not override the get_user_name_size | 22:10 |
shaleh | lbragstad: so the tests passed but did not fully test the code either | 22:10 |
lbragstad | hmmmm | 22:11 |
shaleh | lbragstad: poor design. It should have thrown NotImplemented and forced everyone to implement something | 22:11 |
*** aginwala has joined #openstack-keystone | 22:11 | |
*** zqfan_AFK has quit IRC | 22:11 | |
shaleh | lbragstad: re-implement your patch as adding a comment indicating what the method is doing. aka I know this looks useless but there is a reason.... | 22:12 |
*** jasonsb has joined #openstack-keystone | 22:14 | |
lbragstad | shaleh moves to wip | 22:14 |
lbragstad | moved* | 22:14 |
*** jasonsb has quit IRC | 22:14 | |
*** jasonsb has joined #openstack-keystone | 22:15 | |
*** petertr7 is now known as petertr7_away | 22:18 | |
*** jasonsb has quit IRC | 22:20 | |
*** shaleh is now known as shaleh|away | 22:25 | |
*** alejandrito has quit IRC | 22:26 | |
*** david-lyle has quit IRC | 22:34 | |
*** briancurtin has quit IRC | 22:38 | |
*** david-ly_ has joined #openstack-keystone | 22:39 | |
*** henrynash has quit IRC | 22:39 | |
*** atiwari2 has joined #openstack-keystone | 22:41 | |
*** henrynash has joined #openstack-keystone | 22:41 | |
*** ChanServ sets mode: +v henrynash | 22:41 | |
*** henrynash has quit IRC | 22:42 | |
*** atiwari1 has quit IRC | 22:43 | |
*** andrewbogott has quit IRC | 22:44 | |
*** david-ly_ is now known as david-lyle | 22:45 | |
lbragstad | nonameentername o/ would you be able to go through the previous comments and mark the ones that you addressed as done (https://review.openstack.org/#/c/130376/)? | 22:46 |
lbragstad | nonameentername just thinking that it will help the other reviewers know what has been addressed, etc.. especially gyee's comments | 22:47 |
*** harlowja has quit IRC | 22:51 | |
*** harlowja has joined #openstack-keystone | 22:51 | |
*** davechen has left #openstack-keystone | 22:58 | |
*** boris-42_ has joined #openstack-keystone | 22:59 | |
*** tonytan4ever has joined #openstack-keystone | 23:00 | |
*** topol has joined #openstack-keystone | 23:00 | |
*** ChanServ sets mode: +v topol | 23:00 | |
zigo | notmorgan: pong | 23:01 |
bknudson | these unicode descriptions go into weird details: https://codepoints.net/U+1F4A9 | 23:03 |
bknudson | https://codepoints.net/U+1F4A6 | 23:03 |
bknudson | "SPLASHING SWEAT SYMBOL" -- " Maximum sweat rates of an adult can be up to 2–4 liters per hour" | 23:04 |
*** gokrokve has joined #openstack-keystone | 23:04 | |
*** topol has quit IRC | 23:04 | |
*** doug-fish has quit IRC | 23:06 | |
*** navidp has quit IRC | 23:06 | |
zigo | bknudson: 囧 | 23:08 |
zigo | :) | 23:08 |
*** gokrokve has quit IRC | 23:08 | |
bknudson | what's that one? | 23:11 |
*** timcline has quit IRC | 23:11 | |
*** atiwari2 has quit IRC | 23:13 | |
*** atiwari1 has joined #openstack-keystone | 23:13 | |
bknudson | 😁 | 23:14 |
*** navidp has joined #openstack-keystone | 23:16 | |
*** pumaranikar has quit IRC | 23:17 | |
*** pushkaru has joined #openstack-keystone | 23:18 | |
*** shaleh|away has quit IRC | 23:19 | |
*** jbell8 has quit IRC | 23:19 | |
*** slberger has left #openstack-keystone | 23:24 | |
*** Ephur has quit IRC | 23:25 | |
*** briancurtin has joined #openstack-keystone | 23:28 | |
*** pushkaru has quit IRC | 23:30 | |
*** jbell8 has joined #openstack-keystone | 23:32 | |
ayoung | https://translate.google.com/#auto/en/%E5%9B%A7 | 23:37 |
*** rcernin has joined #openstack-keystone | 23:37 | |
openstackgerrit | Jorge Munoz proposed openstack/keystone: Reduce revoke events for disabled domains and projects. https://review.openstack.org/253273 | 23:39 |
*** pgbridge has quit IRC | 23:40 | |
*** andrewbogott has joined #openstack-keystone | 23:41 | |
*** gordc has quit IRC | 23:44 | |
*** lhcheng_ has joined #openstack-keystone | 23:46 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:48 | |
openstackgerrit | Jorge Munoz proposed openstack/keystone: Reduce revoke events for disabled domains and projects. https://review.openstack.org/253273 | 23:48 |
*** lhcheng has quit IRC | 23:50 | |
notmorgan | dstanek: ping - for tests how the heck do I get the default domain populated in a sane way? | 23:53 |
openstackgerrit | Jorge Munoz proposed openstack/keystone: Reduce revoke events for disabled domains and projects. https://review.openstack.org/253273 | 23:53 |
notmorgan | dstanek: i'm running into an issue where it's just not populating afaict wth the DB fixture | 23:53 |
zigo | bknudson: It's Chinese for "jiong": http://www.chinasmack.com/glossary#%E5%9B%A7 | 23:53 |
zigo | Very famous over there ... | 23:53 |
zigo | notmorgan: Do you still want to discuss? | 23:54 |
notmorgan | zigo: yes, but in the middle of something atm | 23:54 |
zigo | notmorgan: Tomorrow then. | 23:55 |
notmorgan | ok | 23:55 |
*** lhcheng_ has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!