| *** roxanaghe has joined #openstack-keystone | 00:00 | |
| *** dims has joined #openstack-keystone | 00:01 | |
| openstackgerrit | Morgan Fainberg proposed openstack/python-keystoneclient: Add positional to requirements https://review.openstack.org/268378 | 00:03 |
|---|---|---|
| openstackgerrit | Morgan Fainberg proposed openstack/python-keystoneclient: Use positional library instead of local code https://review.openstack.org/268379 | 00:03 |
| *** kibm has quit IRC | 00:03 | |
| notmorgan | stevemar, jamielennox: using positional in ksc ^ | 00:03 |
| *** dims has quit IRC | 00:04 | |
| *** lhcheng has quit IRC | 00:08 | |
| *** lhcheng has joined #openstack-keystone | 00:12 | |
| *** ChanServ sets mode: +v lhcheng | 00:12 | |
| *** roxanaghe has quit IRC | 00:14 | |
| *** roxanaghe has joined #openstack-keystone | 00:16 | |
| *** kibm has joined #openstack-keystone | 00:19 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystoneauth: Add positional library https://review.openstack.org/268383 | 00:19 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystoneauth: Use positional package instead of local code https://review.openstack.org/268384 | 00:19 |
| notmorgan | stevemar, jamielennox: ^ likewise. we can do direct import down the line, but this is the lowest change delta to get us using the lib. | 00:20 |
| jamielennox | notmorgan: did g-r pass? | 00:29 |
| *** roxanaghe has quit IRC | 00:29 | |
| notmorgan | jamielennox: it's depends-on for the G-R | 00:30 |
| notmorgan | and i'm poking at people for that | 00:31 |
| *** roxanaghe has joined #openstack-keystone | 00:31 | |
| openstackgerrit | Merged openstack/python-keystoneclient: Mark password/secret options as secret https://review.openstack.org/268198 | 00:31 |
| *** dims has joined #openstack-keystone | 00:32 | |
| jamielennox | we'll need to keep it around in ksc for a little bit because of the auth_token dep | 00:32 |
| *** kibm has quit IRC | 00:46 | |
| jamielennox | stevemar: ugh, so much has changed | 00:56 |
| *** kibm has joined #openstack-keystone | 01:04 | |
| *** drjones has quit IRC | 01:06 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users: unified identity https://review.openstack.org/262045 | 01:13 |
| *** lhcheng has quit IRC | 01:14 | |
| *** jasonsb has joined #openstack-keystone | 01:16 | |
| *** jasonsb has quit IRC | 01:18 | |
| *** jasonsb has joined #openstack-keystone | 01:21 | |
| *** dims has quit IRC | 01:23 | |
| *** kibm has quit IRC | 01:36 | |
| *** lhcheng has joined #openstack-keystone | 01:37 | |
| *** ChanServ sets mode: +v lhcheng | 01:37 | |
| *** EinstCrazy has joined #openstack-keystone | 01:38 | |
| *** lhcheng has quit IRC | 01:38 | |
| *** lhcheng has joined #openstack-keystone | 01:38 | |
| *** ChanServ sets mode: +v lhcheng | 01:38 | |
| *** dims has joined #openstack-keystone | 01:46 | |
| jamielennox | stevemar: https://review.openstack.org/#/c/230157/ | 01:47 |
| *** jasonsb has quit IRC | 01:52 | |
| *** jasonsb has joined #openstack-keystone | 01:56 | |
| *** kibm has joined #openstack-keystone | 01:56 | |
| *** lhcheng has quit IRC | 01:56 | |
| *** lhcheng has joined #openstack-keystone | 02:00 | |
| *** ChanServ sets mode: +v lhcheng | 02:00 | |
| *** lhcheng_ has joined #openstack-keystone | 02:01 | |
| *** lhcheng has quit IRC | 02:01 | |
| *** david-lyle_ has joined #openstack-keystone | 02:08 | |
| *** david-lyle has quit IRC | 02:09 | |
| *** EinstCrazy has quit IRC | 02:10 | |
| *** nkinder has quit IRC | 02:10 | |
| *** nkinder has joined #openstack-keystone | 02:10 | |
| stevemar | jamielennox: that is a damn sneaky exception that was missing | 02:14 |
| openstackgerrit | Merged openstack/keystoneauth: Mark password/secret options as secret https://review.openstack.org/268199 | 02:14 |
| *** kibm has quit IRC | 02:14 | |
| *** shoutm has joined #openstack-keystone | 02:26 | |
| *** hideme has quit IRC | 02:28 | |
| jamielennox | stevemar: yea, we transitioned to webob in there which made raising the right error code easier | 02:28 |
| jamielennox | stevemar: also everything has _nearly_ the same name | 02:28 |
| stevemar | jamielennox: didn't even cross my mind to think of looking at the webob exceptions | 02:29 |
| *** alex_xu has quit IRC | 02:29 | |
| jamielennox | stevemar: yea, unless you create an actual webob middleware object they are never caught and converted back to an actual response | 02:30 |
| jamielennox | reading back through stable/kilo though, it is much nicer today | 02:30 |
| *** spandhe has quit IRC | 02:32 | |
| *** kibm has joined #openstack-keystone | 02:34 | |
| *** alex_xu has joined #openstack-keystone | 02:36 | |
| openstackgerrit | henry-nash proposed openstack/keystone: Implied Roles API https://review.openstack.org/242614 | 02:37 |
| stevemar | jamielennox: agreed, you did a fantastic job refactoring that behemoth | 02:37 |
| stevemar | jamielennox: have you taken a look at the keystonemiddleware description in the README? | 02:38 |
| stevemar | jamielennox: "This package contains middleware modules designed to provide authentication and authorization features to web services other than Keystone" | 02:38 |
| stevemar | :) | 02:38 |
| openstackgerrit | henry-nash proposed openstack/keystone: Add tests for role management with v3policy file https://review.openstack.org/261846 | 02:38 |
| jamielennox | oh yea, now that it's release we can actually look at merging the use it in keystone one | 02:39 |
| stevemar | true true | 02:39 |
| jamielennox | have to update the private symbols | 02:39 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 02:41 | |
| *** hideme has joined #openstack-keystone | 02:42 | |
| openstackgerrit | henry-nash proposed openstack/keystone: Add tests for role management with v3policy file https://review.openstack.org/261846 | 02:44 |
| openstackgerrit | henry-nash proposed openstack/keystone: Add CRUD support for domain specific roles https://review.openstack.org/261870 | 02:48 |
| *** jasonsb has quit IRC | 02:50 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 02:51 | |
| openstackgerrit | Dave Chen proposed openstack/keystone: Implied roles driver and manager https://review.openstack.org/264260 | 02:53 |
| *** lhcheng_ has quit IRC | 02:54 | |
| stevemar | jamielennox: now to figure how why you can't set trust as a scope with OSC and authenticate! | 02:56 |
| jamielennox | stevemar: oh? that should work | 02:56 |
| stevemar | jamielennox: naw http://paste.openstack.org/show/484039/ | 02:56 |
| stevemar | Using parameters {'username': 'trustee', 'password': '***', 'auth_url': 'http://172.16.240.162:5000/v2.0', 'trust_id': 'cf884b664f5b42f7b1f1a98cef5da399'} | 02:57 |
| jamielennox | stevemar: that's OSC getting in the way of just letting ksa handle it | 02:57 |
| stevemar | probs | 02:57 |
| stevemar | theres still some ksa integration work taht needs to be done in osc, and neither dtroyer or i have had the time to do it | 02:57 |
| jamielennox | was just wondering how dtroyer was going with that | 02:58 |
| jamielennox | i have some stuff i did in ksa to enable caching that will require that | 02:58 |
| stevemar | you'll like this | 02:58 |
| openstackgerrit | ayoung proposed openstack/keystone: Implied Roles API https://review.openstack.org/242614 | 02:59 |
| stevemar | jamielennox: https://github.com/openstack/python-openstackclient/blob/678e69064854e3a3d3499171b0a29f30f2771840/openstackclient/api/auth.py#L45 | 03:00 |
| stevemar | so get_plugin_list | 03:01 |
| stevemar | its getting them from keystoneclient.auth.base | 03:01 |
| stevemar | not ksa :( | 03:01 |
| stevemar | so yeah, there's some untangling to do with ksa/osc/occ | 03:01 |
| stevemar | doesn't help that they all came out at the same time | 03:02 |
| stevemar | err ksa and occ, *not* osc | 03:02 |
| jamielennox | yea, i thought the plan was just to replace it all with the os-client-config stuff | 03:02 |
| stevemar | i'm game with that | 03:02 |
| jamielennox | i am coming to terms with os-client-config, i still don't think they should do everything | 03:02 |
| jamielennox | that it does, but mordred has put it _everywhere_ so i may as well get used to it | 03:02 |
| stevemar | topol: hows that bouncer working out for you? | 03:03 |
| *** mc_nair_ has joined #openstack-keystone | 03:03 | |
| stevemar | jamielennox: anywho | 03:03 |
| stevemar | jamielennox: it's saturday for you! | 03:03 |
| stevemar | go do something fun | 03:03 |
| jamielennox | yea, but it's pretty miserable outside | 03:03 |
| *** jasonsb has joined #openstack-keystone | 03:03 | |
| stevemar | ah | 03:04 |
| stevemar | same here, but oppositey | 03:04 |
| stevemar | its all slush, snow, wind and miserableness | 03:05 |
| *** mc_nair has quit IRC | 03:05 | |
| *** mc_nair_ is now known as mc_nair | 03:05 | |
| jamielennox | ah, no it's still ~25 it just rains everytime i want to do something | 03:06 |
| openstackgerrit | Jamie Lennox proposed openstack/keystone: Make AuthContext depend on auth_token middleware https://review.openstack.org/255686 | 03:07 |
| *** kibm has quit IRC | 03:08 | |
| stevemar | jamielennox: it knows | 03:12 |
| stevemar | jamielennox: pour yourself a nice cup of tea/coffee/scotch and play some torchlight | 03:13 |
| stevemar | i'll figure out the trust stuff tomorrow, see i can but another bandaid on osc :\ | 03:13 |
| openstackgerrit | henry-nash proposed openstack/keystone: Modify rules in the v3 policy sample for domain specifc roles https://review.openstack.org/262078 | 03:16 |
| *** woodster_ has quit IRC | 03:16 | |
| openstackgerrit | henry-nash proposed openstack/keystone: Modify implied roles to honor domain specific roles https://review.openstack.org/263064 | 03:17 |
| *** alex_xu has quit IRC | 03:18 | |
| stevemar | meanwhile henrynash_ is burning the midnight oil | 03:20 |
| stevemar | o/ | 03:20 |
| *** henrynash_ has quit IRC | 03:20 | |
| jamielennox | stevemar: i've looked at the osc ksa conversion before, it's harder than i would expect | 03:24 |
| jamielennox | lots of edge cases | 03:24 |
| stevemar | yep | 03:24 |
| stevemar | jamielennox: usually dtroyer pulls those off with magic | 03:25 |
| stevemar | but... | 03:25 |
| stevemar | he is occupied atm | 03:25 |
| *** alex_xu has joined #openstack-keystone | 03:26 | |
| *** kibm has joined #openstack-keystone | 03:28 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/pycadf: Updated from global requirements https://review.openstack.org/268503 | 03:31 |
| stevemar | proposal bot is updating all the things! | 03:31 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/268513 | 03:32 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient-kerberos: Updated from global requirements https://review.openstack.org/268514 | 03:32 |
| stevemar | specifically the licences of all the things | 03:32 |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Remove unnecessary _reject_request function https://review.openstack.org/268546 | 03:33 |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Remove unnecessary _reject_request function https://review.openstack.org/268546 | 03:35 |
| *** jasonsb has quit IRC | 03:40 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Remove except Exception handler https://review.openstack.org/268553 | 03:42 |
| *** lhcheng has joined #openstack-keystone | 03:58 | |
| *** ChanServ sets mode: +v lhcheng | 03:58 | |
| *** richm has quit IRC | 04:01 | |
| *** lhcheng has quit IRC | 04:03 | |
| openstackgerrit | Dave Chen proposed openstack/keystone: Enable `id`, `enabled` attributes filtering for list IdP API https://review.openstack.org/215041 | 04:04 |
| *** alex_xu has quit IRC | 04:08 | |
| openstackgerrit | Merged openstack/python-keystoneclient-kerberos: Updated from global requirements https://review.openstack.org/268514 | 04:09 |
| *** alex_xu has joined #openstack-keystone | 04:09 | |
| *** kibm has quit IRC | 04:11 | |
| *** spzala has joined #openstack-keystone | 04:15 | |
| *** spzala has quit IRC | 04:20 | |
| *** dims has quit IRC | 04:26 | |
| *** kibm has joined #openstack-keystone | 04:29 | |
| *** alex_xu has quit IRC | 04:45 | |
| *** alex_xu has joined #openstack-keystone | 04:48 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Group common PKI validation code - Tests https://review.openstack.org/268556 | 04:50 |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Group common PKI validation code - Refactor https://review.openstack.org/268557 | 04:50 |
| *** kibm has quit IRC | 04:59 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystone: Use our own request in base wsgi class https://review.openstack.org/244472 | 04:59 |
| *** jasonsb has joined #openstack-keystone | 04:59 | |
| *** shoutm has quit IRC | 05:00 | |
| *** agireud has quit IRC | 05:19 | |
| *** kibm has joined #openstack-keystone | 05:19 | |
| *** agireud has joined #openstack-keystone | 05:22 | |
| *** ankita_wagh has joined #openstack-keystone | 05:31 | |
| *** kibm has quit IRC | 05:40 | |
| *** kibm has joined #openstack-keystone | 05:41 | |
| *** agireud has quit IRC | 05:43 | |
| *** roxanaghe has quit IRC | 05:43 | |
| *** agireud has joined #openstack-keystone | 05:44 | |
| stevemar | what the heckarooni is going on with the eventlet job | 05:45 |
| *** kibm has quit IRC | 05:45 | |
| stevemar | apparently everything barfed | 05:45 |
| stevemar | oh a bunch of timeouts | 05:46 |
| stevemar | yay | 05:46 |
| stevemar | i'll recheck all of these tomorrow when the gate is empty ;) | 05:47 |
| *** lhcheng has joined #openstack-keystone | 05:47 | |
| *** ChanServ sets mode: +v lhcheng | 05:47 | |
| *** henrynash_ has joined #openstack-keystone | 05:51 | |
| *** ChanServ sets mode: +v henrynash_ | 05:51 | |
| *** lhcheng has quit IRC | 05:52 | |
| *** agireud has quit IRC | 05:53 | |
| *** agireud has joined #openstack-keystone | 05:55 | |
| openstackgerrit | henry-nash proposed openstack/keystone: Modify rules for domain specific role assignments https://review.openstack.org/263549 | 06:01 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Imported Translations from Zanata https://review.openstack.org/268567 | 06:02 |
| *** lhcheng has joined #openstack-keystone | 06:11 | |
| *** ChanServ sets mode: +v lhcheng | 06:11 | |
| *** agireud has quit IRC | 06:13 | |
| *** agireud has joined #openstack-keystone | 06:15 | |
| *** fawadkhaliq has joined #openstack-keystone | 06:17 | |
| *** jasonsb has quit IRC | 06:17 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Remove unnecessary _reject_request function https://review.openstack.org/268546 | 06:33 |
| *** agireud has quit IRC | 06:36 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Group common PKI validation code - Refactor https://review.openstack.org/268557 | 06:36 |
| *** agireud has joined #openstack-keystone | 06:38 | |
| *** ankita_wagh has quit IRC | 06:38 | |
| *** henrynash has quit IRC | 06:41 | |
| *** henrynash_ is now known as henrynash | 06:41 | |
| *** henrynash has quit IRC | 06:42 | |
| *** agireud has quit IRC | 06:43 | |
| *** roxanaghe has joined #openstack-keystone | 06:44 | |
| *** agireud has joined #openstack-keystone | 06:45 | |
| *** roxanaghe has quit IRC | 06:49 | |
| *** agireud has quit IRC | 06:52 | |
| *** agireud has joined #openstack-keystone | 06:54 | |
| *** agireud has quit IRC | 07:01 | |
| *** agireud has joined #openstack-keystone | 07:03 | |
| *** henrynash has joined #openstack-keystone | 07:21 | |
| *** ChanServ sets mode: +v henrynash | 07:21 | |
| *** lhcheng has quit IRC | 07:23 | |
| *** jaosorior has joined #openstack-keystone | 07:43 | |
| *** EinstCrazy has joined #openstack-keystone | 07:48 | |
| *** spandhe has joined #openstack-keystone | 07:48 | |
| *** henrynash has quit IRC | 07:58 | |
| *** itlinux has quit IRC | 08:01 | |
| *** shoutm has joined #openstack-keystone | 08:11 | |
| openstackgerrit | Merged openstack/oslo.policy: Updated from global requirements https://review.openstack.org/268492 | 08:13 |
| *** pnavarro has joined #openstack-keystone | 08:14 | |
| *** spzala has joined #openstack-keystone | 08:16 | |
| *** spzala has quit IRC | 08:21 | |
| *** agireud has quit IRC | 08:26 | |
| *** agireud has joined #openstack-keystone | 08:28 | |
| *** vgridnev has joined #openstack-keystone | 08:28 | |
| *** pnavarro has quit IRC | 08:47 | |
| *** boris-42 has joined #openstack-keystone | 08:54 | |
| *** spandhe has quit IRC | 09:08 | |
| *** agireud has quit IRC | 09:30 | |
| *** agireud has joined #openstack-keystone | 09:32 | |
| *** fawadkhaliq has quit IRC | 09:41 | |
| *** pnavarro has joined #openstack-keystone | 09:47 | |
| *** agireud has quit IRC | 09:57 | |
| *** agireud has joined #openstack-keystone | 09:59 | |
| *** shoutm has quit IRC | 10:01 | |
| *** agireud has quit IRC | 10:10 | |
| *** agireud has joined #openstack-keystone | 10:12 | |
| *** pnavarro has quit IRC | 10:14 | |
| *** pnavarro has joined #openstack-keystone | 10:21 | |
| *** agireud has quit IRC | 10:29 | |
| *** agireud has joined #openstack-keystone | 10:32 | |
| *** pnavarro has quit IRC | 10:39 | |
| *** agireud has quit IRC | 10:47 | |
| *** agireud has joined #openstack-keystone | 10:49 | |
| *** shoutm has joined #openstack-keystone | 11:05 | |
| *** agireud has quit IRC | 11:08 | |
| *** agireud has joined #openstack-keystone | 11:11 | |
| *** spzala has joined #openstack-keystone | 11:16 | |
| *** spzala has quit IRC | 11:20 | |
| openstackgerrit | Merged openstack/keystone: Support the reading of default values of domain configuration options https://review.openstack.org/260335 | 11:36 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/264346 | 11:42 |
| *** agireud has quit IRC | 11:50 | |
| *** agireud has joined #openstack-keystone | 11:52 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 11:54 | |
| *** agireud has quit IRC | 12:14 | |
| *** agireud has joined #openstack-keystone | 12:17 | |
| *** agireud has quit IRC | 12:24 | |
| *** agireud has joined #openstack-keystone | 12:26 | |
| *** agireud has quit IRC | 12:43 | |
| *** agireud has joined #openstack-keystone | 12:46 | |
| *** agireud has quit IRC | 12:51 | |
| *** agireud has joined #openstack-keystone | 12:54 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 13:05 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: WIP: Extract assignment backend tests to own file https://review.openstack.org/268307 | 13:06 |
| *** agireud has quit IRC | 13:18 | |
| *** agireud has joined #openstack-keystone | 13:21 | |
| *** jaosorior has quit IRC | 13:23 | |
| *** boris-42 has quit IRC | 13:33 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Move invalid cache handling off cache object https://review.openstack.org/268662 | 13:37 |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Make cache interface the same as oslo_cache https://review.openstack.org/268663 | 13:37 |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Use oslo_config in auth_token middleware https://review.openstack.org/268664 | 13:37 |
| *** dims has joined #openstack-keystone | 13:49 | |
| *** agireud has quit IRC | 13:56 | |
| *** agireud has joined #openstack-keystone | 13:59 | |
| *** roxanaghe has joined #openstack-keystone | 14:08 | |
| *** roxanaghe has quit IRC | 14:09 | |
| *** vivekd has joined #openstack-keystone | 14:15 | |
| openstackgerrit | Merged openstack/keystone: Improve Conflict error message in IdP creation https://review.openstack.org/265279 | 14:16 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Extract assignment backend tests to its own file https://review.openstack.org/268307 | 14:22 |
| *** BrAsS_mOnKeY is now known as g2` | 14:23 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Extract assignment backend tests to its own file https://review.openstack.org/268307 | 14:24 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/264346 | 14:38 |
| *** EinstCrazy has quit IRC | 14:39 | |
| *** jamielennox is now known as jamielennox|away | 14:58 | |
| *** vgridnev has quit IRC | 15:01 | |
| *** tsymanczyk has quit IRC | 15:17 | |
| *** vivekd has quit IRC | 15:24 | |
| *** pnavarro has joined #openstack-keystone | 15:30 | |
| *** tsymanczyk has joined #openstack-keystone | 15:33 | |
| *** tsymanczyk is now known as Guest31270 | 15:34 | |
| *** vgridnev has joined #openstack-keystone | 15:34 | |
| *** pnavarro has quit IRC | 15:34 | |
| *** itlinux has joined #openstack-keystone | 15:58 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users: unified identity https://review.openstack.org/262045 | 16:03 |
| *** spzala has joined #openstack-keystone | 16:07 | |
| *** lhcheng has joined #openstack-keystone | 16:09 | |
| *** ChanServ sets mode: +v lhcheng | 16:09 | |
| *** lhcheng_ has joined #openstack-keystone | 16:11 | |
| *** lhcheng has quit IRC | 16:11 | |
| *** phalmos has joined #openstack-keystone | 16:16 | |
| *** henrynash has joined #openstack-keystone | 16:17 | |
| *** ChanServ sets mode: +v henrynash | 16:17 | |
| *** henrynash has quit IRC | 16:19 | |
| topol | stevemar, bouncer seems to work. | 16:20 |
| *** shoutm has quit IRC | 16:23 | |
| *** phalmos has quit IRC | 16:27 | |
| *** dims has quit IRC | 16:38 | |
| *** spzala has quit IRC | 17:13 | |
| *** lhcheng_ has quit IRC | 17:13 | |
| *** spzala has joined #openstack-keystone | 17:14 | |
| *** spzala has quit IRC | 17:19 | |
| *** kibm has joined #openstack-keystone | 17:26 | |
| *** kibm has quit IRC | 17:31 | |
| *** vgridnev has quit IRC | 17:45 | |
| *** fawadkhaliq has joined #openstack-keystone | 17:52 | |
| *** fawadkhaliq has quit IRC | 17:52 | |
| *** spandhe has joined #openstack-keystone | 17:52 | |
| *** fawadkhaliq has joined #openstack-keystone | 17:52 | |
| samueldmq | WIP: Extract assignment backend tests to own file | 17:55 |
| *** henrynash has joined #openstack-keystone | 17:59 | |
| *** ChanServ sets mode: +v henrynash | 17:59 | |
| *** henrynash has quit IRC | 18:00 | |
| *** goodygum has quit IRC | 18:02 | |
| *** henrynash has joined #openstack-keystone | 18:06 | |
| *** ChanServ sets mode: +v henrynash | 18:06 | |
| samueldmq | henrynash: hi | 18:13 |
| henrynash | samueldmq: hi | 18:13 |
| samueldmq | henrynash: quick question: do you like this https://review.openstack.org/#/c/268307/ ? | 18:13 |
| samueldmq | henrynash: the idea is to split test_backend.py ( > 6.6k lines) into test_assignment_backend, test_identity_backend, and so on | 18:14 |
| *** dims has joined #openstack-keystone | 18:14 | |
| henrynash | samueldmq: so absolutely ok with the concept…..probably I need to look through it and see if there are tests that fall in between the various camps…..but good in principle | 18:15 |
| samueldmq | henrynash: nice | 18:15 |
| samueldmq | henrynash: after this, test_backend sql and test_backend_ldap would also be split | 18:16 |
| henrynash | yes | 18:16 |
| samueldmq | henrynash: yes lots of files added, but this helps us to keep files smaller and simpler to understand/maintain | 18:16 |
| samueldmq | henrynash: and even keep track of testes behavior/what's missing | 18:16 |
| henrynash | agreed…test_backend is a monster | 18:17 |
| samueldmq | henrynash: ++ | 18:17 |
| samueldmq | henrynash: thanks | 18:18 |
| henrynash | actually….I wonder if these should move to backend.assignment ? | 18:20 |
| henrynash | samueldmq: when you have a moment, perhaps you could look at: https://review.openstack.org/#/c/265650/ | 18:24 |
| samueldmq | henrynash: sure will look | 18:25 |
| samueldmq | henrynash: first priority in review, that and the roles-related bps | 18:26 |
| samueldmq | henrynash: tell me, what is a backend? | 18:26 |
| samueldmq | henrynash: backend = manager + driver ? | 18:26 |
| henrynash | samueldmq: under test.unit, we have started migrating backend tests to unit.backed…each under a subdiretcory (e.g role, domain_config et.c) | 18:27 |
| henrynash | samueldmq: basically, yes, things that used to be in test_backend, rather than just rename them test_backend_role.py…we jave been placing them in their own subdir under unit.backend | 18:28 |
| samueldmq | henrynash: nice, got it | 18:29 |
| samueldmq | henrynash: so I can split that file, and actually put them into their own directories as well | 18:29 |
| samueldmq | henrynash: question is if I should do split+move in one shot | 18:30 |
| henrynash | samueldmq: where backend.assigmnent.core.py would be what you have extracted, and then backend.assigmnent.test_sql.py would be the equivilent of what you plan to have in test_backenf_assignment_sql.py | 18:30 |
| henrynash | samueldmq: hmm, good question | 18:31 |
| samueldmq | henrynash: oh perfect | 18:31 |
| samueldmq | henrynash: nice, I really like that.. I think I can do into a single shot, but: | 18:31 |
| henrynash | samueldmq: yes, I think so too | 18:31 |
| samueldmq | henrynash: extracto from test_bakcned to own core.py inside own dir | 18:31 |
| samueldmq | henrynash: then extract from test_backend_sql to sql.py inside own dir | 18:32 |
| henrynash | samuedlmq: agreed | 18:32 |
| samueldmq | henrynash: nice, will do :) | 18:32 |
| samueldmq | henrynash: I am confident that we will have a much better notion of what our tests are | 18:32 |
| henrynash | samuedlmq: yep.... | 18:32 |
| samueldmq | henrynash: cool, regarding the role changes for this cycle, we have implied roles + domain roles ? | 18:33 |
| samueldmq | is that riht ? | 18:33 |
| samueldmq | right* | 18:33 |
| henrynash | samuedlmq: I think those are the only ‘role’ ones….(they both change the tests in backend.role for instance) | 18:34 |
| samueldmq | yep | 18:34 |
| samueldmq | henrynash: where should I start for reviewing those ? | 18:35 |
| henrynash | samueldmq: the changed assignmenst too of course, as does the one I pointed you at a little while back | 18:35 |
| samueldmq | henrynash: ++ | 18:35 |
| henrynash | so bottom of the stack is: https://review.openstack.org/#/c/264260/ | 18:35 |
| henrynash | (actually there was one that already merged that just created the role inference sql table) | 18:35 |
| henrynash | samuedlmq: the bottom two are basically adam’s implied roles (I implemented the changes for list_role_assignments for him, hence my being co-author) | 18:36 |
| samueldmq | henrynash: nice, all specs merged ? | 18:37 |
| henrynash | samuedlmq: and then above those two are the domain specific role ones, starting at: https://review.openstack.org/#/c/261846/ | 18:37 |
| henrynash | samueldmq: yes | 18:37 |
| samueldmq | henrynash: nice, I will review them | 18:38 |
| samueldmq | henrynash: hopefully my background on roles will help :) | 18:39 |
| henrynash | samueldmq: thx…and yes I would think so!! | 18:39 |
| henrynash | samuedlmq: ok, speak later | 18:39 |
| *** henrynash has quit IRC | 18:39 | |
| *** fawadkhaliq has quit IRC | 18:43 | |
| *** spzala has joined #openstack-keystone | 18:44 | |
| *** spzala has quit IRC | 18:50 | |
| *** dims has quit IRC | 18:58 | |
| *** jasonsb has joined #openstack-keystone | 18:59 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Extract assignment backend tests to its own file https://review.openstack.org/268307 | 19:10 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Extract assignment backend tests https://review.openstack.org/268307 | 19:13 |
| *** jasonsb has quit IRC | 19:15 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Extract resource backend tests https://review.openstack.org/268702 | 19:16 |
| *** jasonsb has joined #openstack-keystone | 19:28 | |
| *** dims has joined #openstack-keystone | 19:28 | |
| *** jasonsb has quit IRC | 19:32 | |
| *** spzala has joined #openstack-keystone | 19:45 | |
| *** spzala has quit IRC | 19:51 | |
| *** henrynash has joined #openstack-keystone | 19:54 | |
| *** ChanServ sets mode: +v henrynash | 19:54 | |
| *** nkinder has quit IRC | 19:55 | |
| *** dims_ has joined #openstack-keystone | 20:06 | |
| *** dims has quit IRC | 20:07 | |
| *** spzala has joined #openstack-keystone | 20:19 | |
| *** henrynash has quit IRC | 20:24 | |
| openstackgerrit | Merged openstack/oslo.policy: Revert "Pass environment variables of proxy to tox" https://review.openstack.org/267740 | 20:26 |
| *** spzala has quit IRC | 20:29 | |
| *** henrynash has joined #openstack-keystone | 20:39 | |
| *** ChanServ sets mode: +v henrynash | 20:39 | |
| *** david-lyle_ has quit IRC | 20:44 | |
| *** spandhe has quit IRC | 20:51 | |
| *** jsavak has joined #openstack-keystone | 20:55 | |
| *** henrynash has quit IRC | 20:58 | |
| *** lhcheng has joined #openstack-keystone | 21:00 | |
| *** ChanServ sets mode: +v lhcheng | 21:00 | |
| *** lhcheng_ has joined #openstack-keystone | 21:01 | |
| *** e0ne has joined #openstack-keystone | 21:04 | |
| *** lhcheng has quit IRC | 21:05 | |
| *** lhcheng_ has quit IRC | 21:08 | |
| *** david-lyle has joined #openstack-keystone | 21:19 | |
| *** dims_ has quit IRC | 21:28 | |
| *** ankita_wagh has joined #openstack-keystone | 21:29 | |
| *** jamielennox|away is now known as jamielennox | 21:40 | |
| *** jsavak has quit IRC | 21:41 | |
| *** jsavak has joined #openstack-keystone | 21:42 | |
| *** e0ne has quit IRC | 21:44 | |
| *** jsavak has quit IRC | 21:45 | |
| *** phalmos has joined #openstack-keystone | 21:48 | |
| *** jasonsb has joined #openstack-keystone | 21:50 | |
| *** phalmos has quit IRC | 21:52 | |
| *** jasonsb has quit IRC | 21:54 | |
| *** itlinux has quit IRC | 21:55 | |
| *** phalmos has joined #openstack-keystone | 21:56 | |
| *** ankita_wagh has quit IRC | 22:49 | |
| *** ankita_wagh has joined #openstack-keystone | 23:05 | |
| *** ankita_wagh has quit IRC | 23:06 | |
| *** ankita_wagh has joined #openstack-keystone | 23:11 | |
| *** ankita_w_ has joined #openstack-keystone | 23:12 | |
| *** ankita_wagh has quit IRC | 23:16 | |
| *** nkinder has joined #openstack-keystone | 23:32 | |
| *** phalmos has quit IRC | 23:40 | |
| *** nkinder has quit IRC | 23:52 | |
| *** dims has joined #openstack-keystone | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!