notmorgan | stevemar: -1 sorry | 00:00 |
---|---|---|
notmorgan | we went through this already. | 00:00 |
notmorgan | actually -2. | 00:00 |
stevemar | did it screw over too many people? | 00:00 |
notmorgan | deprecating it is a serious issue and yelling OMG DEPRECATED with our default shipped config is bad | 00:00 |
stevemar | hmm, okay | 00:00 |
notmorgan | heck, i convinced ayoung to move the other warning down to only when it's configured | 00:00 |
stevemar | notmorgan: i am trying to close this bug: https://bugs.launchpad.net/keystone/+bug/1545789 | 00:01 |
openstack | Launchpad bug 1545789 in OpenStack Identity (keystone) "keystone ADMIN_TOKEN set by default can lead to default insecure deployment" [Medium,In progress] - Assigned to Steve Martinelli (stevemar) | 00:01 |
notmorgan | that just needs the doc change | 00:01 |
stevemar | i guess there is nothing left to do | 00:01 |
stevemar | which docs? | 00:01 |
notmorgan | showing that if admin_token config option is not configured it wont work | 00:01 |
notmorgan | and that thye should use bootstrap instead | 00:01 |
ayoung | notmorgan, I think cuz I origianlly submitted the commit with Partial_Bug its not updating | 00:01 |
stevemar | ayoung: if it's closed, the mark it as such | 00:02 |
notmorgan | ayoung: did you move your other one to closes-bug? | 00:02 |
*** browne has quit IRC | 00:02 | |
notmorgan | oh yeah just close it and hit the doc change... or steve can hit the doc change w/ that patch ^^ | 00:02 |
notmorgan | instead of "deprecating" | 00:02 |
stevemar | notmorgan: we've got bootstrap docs here: http://docs.openstack.org/developer/keystone/configuringservices.html | 00:03 |
stevemar | our docs stink | 00:03 |
ayoung | notmorgan, nah, it still said partial | 00:04 |
ayoung | http://git.openstack.org/cgit/openstack/keystone/commit/?id=37e9d6bbf14531201dc228694552dc64ac03edd0 | 00:04 |
ayoung | use the same bug to get rid of the warning unless set to None? | 00:04 |
stevemar | ayoung: at this point open a new bug | 00:05 |
stevemar | i'm closing this one | 00:05 |
ayoung | stevemar, you do it. I'm sick of this issue! | 00:05 |
stevemar | yay! | 00:05 |
stevemar | me too :) | 00:05 |
ayoung | actually, I'm elbow deep in Puppet right now | 00:05 |
*** tobe has quit IRC | 00:06 | |
*** aginwala has quit IRC | 00:06 | |
stevemar | notmorgan: https://review.openstack.org/#/c/279908/ should close out another bug | 00:07 |
patchbot | stevemar: patch 279908 - keystone - handle unicode names for federated users | 00:07 |
*** browne has joined #openstack-keystone | 00:07 | |
stevemar | we're so close to closing out all our bugs -_- | 00:08 |
*** fpatwa has joined #openstack-keystone | 00:08 | |
stevemar | i'm still not clear if this is an issue: https://bugs.launchpad.net/keystone/+bug/1539766 | 00:08 |
openstack | Launchpad bug 1539766 in OpenStack Identity (keystone) "trust redelegation allows trustee to create a trust (with impersonation set to true) from a redelegated trust (with impersonation set to false)" [High,In progress] - Assigned to Jorge Munoz (jorge-munoz) | 00:08 |
openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users - Separate user identities https://review.openstack.org/278570 | 00:08 |
*** aginwala has joined #openstack-keystone | 00:08 | |
*** mylu has joined #openstack-keystone | 00:13 | |
*** josecastroleon has quit IRC | 00:18 | |
*** mylu has quit IRC | 00:19 | |
*** josecastroleon has joined #openstack-keystone | 00:19 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users - Separate user identities https://review.openstack.org/278570 | 00:20 |
openstackgerrit | Merged openstack/keystone: Adds user_description_attribute mapping support to the LDAP backend https://review.openstack.org/276873 | 00:20 |
*** mylu has joined #openstack-keystone | 00:21 | |
*** mylu has quit IRC | 00:22 | |
*** mylu has joined #openstack-keystone | 00:22 | |
*** mylu has quit IRC | 00:28 | |
*** fpatwa has quit IRC | 00:29 | |
*** fpatwa has joined #openstack-keystone | 00:29 | |
*** jbell8 has quit IRC | 00:30 | |
*** jbell8 has joined #openstack-keystone | 00:31 | |
*** fpatwa has quit IRC | 00:32 | |
*** jamielennox|away is now known as jamielennox | 00:33 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/281605 | 00:34 |
*** gildub has left #openstack-keystone | 00:35 | |
*** mylu has joined #openstack-keystone | 00:36 | |
notmorgan | stevemar: it is an issue because it opens doors for person X to delegate to Y and then person Y to delegate being person X to person Z | 00:36 |
notmorgan | stevemar: and indefintiely deep | 00:36 |
notmorgan | impersonation should stop with Y, redelegation can happen, just not with impersonation | 00:36 |
notmorgan | though ideally, impersonation should probably be banned from ever being redelegated at all, mutual exclusion | 00:37 |
openstackgerrit | Merged openstack/python-keystoneclient: Add back a bandit tox job https://review.openstack.org/281549 | 00:37 |
*** roxanaghe has quit IRC | 00:40 | |
*** browne has quit IRC | 00:41 | |
*** shoutm has quit IRC | 00:44 | |
*** shoutm has joined #openstack-keystone | 00:45 | |
*** josecastroleon has quit IRC | 00:49 | |
*** mylu has quit IRC | 00:49 | |
*** josecastroleon has joined #openstack-keystone | 00:50 | |
*** fpatwa has joined #openstack-keystone | 00:52 | |
notmorgan | bknudson_: i am guessing we are un-merging bandit job from pep8? ^ | 00:55 |
notmorgan | stevemar: https://bugs.launchpad.net/keystone/+bug/1541656 i just responded | 01:00 |
openstack | Launchpad bug 1541656 in OpenStack Identity (keystone) "OAuth Identity token gives Forbidden" [Undecided,New] | 01:00 |
notmorgan | stevemar: i think this is a mis-use of the CLI. | 01:00 |
notmorgan | stevemar: not a bug in Oauth | 01:00 |
notmorgan | stevemar: they are explicitly asking for a rescope even if it's to the same project | 01:01 |
notmorgan | stevemar: and if oauth tokens are explicitly unscoped we need to fix the code, but iirc they are scoped | 01:01 |
*** tobe has joined #openstack-keystone | 01:04 | |
*** jbell8 has quit IRC | 01:16 | |
*** jbell8 has joined #openstack-keystone | 01:16 | |
*** fpatwa has quit IRC | 01:18 | |
*** josecastroleon has quit IRC | 01:20 | |
*** josecastroleon has joined #openstack-keystone | 01:21 | |
*** davechen has joined #openstack-keystone | 01:22 | |
*** mylu has joined #openstack-keystone | 01:23 | |
*** mylu has quit IRC | 01:26 | |
*** EinstCrazy has joined #openstack-keystone | 01:28 | |
*** mylu has joined #openstack-keystone | 01:31 | |
*** EinstCrazy has quit IRC | 01:32 | |
*** mylu has quit IRC | 01:33 | |
*** sdake_ has joined #openstack-keystone | 01:34 | |
*** EinstCrazy has joined #openstack-keystone | 01:35 | |
*** sdake has quit IRC | 01:36 | |
*** sdake has joined #openstack-keystone | 01:38 | |
*** sdake_ has quit IRC | 01:41 | |
*** rk4n has quit IRC | 01:42 | |
*** josecastroleon has quit IRC | 01:50 | |
*** josecastroleon has joined #openstack-keystone | 01:52 | |
*** aginwala has quit IRC | 01:54 | |
*** chlong_ has joined #openstack-keystone | 01:56 | |
*** tobe has quit IRC | 01:56 | |
*** aginwala has joined #openstack-keystone | 01:56 | |
*** jamielennox is now known as jamielennox|away | 02:02 | |
*** david-lyle_ has joined #openstack-keystone | 02:04 | |
*** david-lyle_ is now known as david-lyle | 02:05 | |
*** dan_nguyen has quit IRC | 02:09 | |
*** shoutm has quit IRC | 02:11 | |
*** sdake_ has joined #openstack-keystone | 02:11 | |
*** jbell8 has quit IRC | 02:12 | |
*** sdake has quit IRC | 02:12 | |
*** jamielennox|away is now known as jamielennox | 02:12 | |
*** john5223 has joined #openstack-keystone | 02:14 | |
*** shoutm has joined #openstack-keystone | 02:16 | |
*** josecastroleon has quit IRC | 02:21 | |
*** josecastroleon has joined #openstack-keystone | 02:22 | |
*** jamielennox is now known as jamielennox|away | 02:24 | |
*** jamielennox|away is now known as jamielennox | 02:25 | |
*** jamielennox is now known as jamielennox|away | 02:26 | |
*** dims has joined #openstack-keystone | 02:28 | |
*** dims_ has quit IRC | 02:29 | |
*** su_zhang has quit IRC | 02:30 | |
*** aginwala has quit IRC | 02:30 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/281601 | 02:32 |
*** jamielennox|away is now known as jamielennox | 02:33 | |
*** markvoelker_ has quit IRC | 02:34 | |
*** jamielennox is now known as jamielennox|away | 02:34 | |
*** jamielennox|away is now known as jamielennox | 02:35 | |
*** jamielennox is now known as jamielennox|away | 02:36 | |
*** sdake_ is now known as sdake | 02:37 | |
*** jbell8 has joined #openstack-keystone | 02:43 | |
*** jbell8 has quit IRC | 02:51 | |
*** jamielennox|away is now known as jamielennox | 02:51 | |
*** josecastroleon has quit IRC | 02:52 | |
*** josecastroleon has joined #openstack-keystone | 02:53 | |
*** jasonsb has joined #openstack-keystone | 02:59 | |
stevemar | notmorgan: i do think the oauth bug is probably CLI related, but i left it open just to make sure | 03:11 |
notmorgan | right just pointing out what i saw at a glance | 03:11 |
*** rderose has joined #openstack-keystone | 03:11 | |
notmorgan | didn't feel like testing it myself cause oauth code in keystone makes my brain hurt :( | 03:12 |
notmorgan | and i might be drinking a beer | 03:12 |
notmorgan | and beer > oauthcode | 03:12 |
stevemar | notmorgan: true that | 03:12 |
stevemar | notmorgan: i'm drinking rooibos tea | 03:12 |
notmorgan | i am prob gonna earl grey this up soon enough :) | 03:13 |
notmorgan | had a meeting earlier today and made coffee for the first time in 5 days | 03:13 |
notmorgan | was delicious. | 03:13 |
notmorgan | but i over ground the beans... so... tomorrow i must also make coffee | 03:14 |
stevemar | this is a nice fix by matty edmonds https://review.openstack.org/#/c/282080/1 | 03:14 |
patchbot | stevemar: patch 282080 - keystone - Allow user list without specifying domain | 03:14 |
stevemar | notmorgan: instant ftw | 03:14 |
stevemar | s/nice/clever | 03:14 |
*** lhcheng has quit IRC | 03:18 | |
*** krotscheck_dr is now known as krotscheck_afk | 03:18 | |
*** sdake has quit IRC | 03:21 | |
*** josecastroleon has quit IRC | 03:23 | |
*** josecastroleon has joined #openstack-keystone | 03:24 | |
*** links has joined #openstack-keystone | 03:30 | |
*** dims has quit IRC | 03:32 | |
*** richm has quit IRC | 03:33 | |
stevemar | notmorgan: were you at the openstack meetup in pdx? | 03:34 |
openstackgerrit | Merged openstack/python-keystoneclient: Implied Roles https://review.openstack.org/280983 | 03:34 |
*** markvoelker has joined #openstack-keystone | 03:34 | |
*** dims has joined #openstack-keystone | 03:34 | |
*** dims has quit IRC | 03:37 | |
notmorgan | stevemar: nope | 03:37 |
notmorgan | stevemar: i forgot it was today | 03:37 |
notmorgan | =/ | 03:37 |
*** markvoelker has quit IRC | 03:39 | |
stevemar | lol | 03:40 |
stevemar | notmorgan: toronto one is next week | 03:41 |
*** david-lyle_ has joined #openstack-keystone | 03:42 | |
*** david-lyle has quit IRC | 03:45 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users - Separate user identities https://review.openstack.org/278570 | 03:47 |
openstackgerrit | Raildo Mascena proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 03:51 |
*** josecastroleon has quit IRC | 03:54 | |
*** josecastroleon has joined #openstack-keystone | 03:55 | |
*** rderose has quit IRC | 03:55 | |
*** shoutm_ has joined #openstack-keystone | 03:56 | |
*** lhcheng has joined #openstack-keystone | 03:56 | |
*** ChanServ sets mode: +v lhcheng | 03:56 | |
*** lhcheng has quit IRC | 03:57 | |
*** shoutm has quit IRC | 03:58 | |
*** david-lyle has joined #openstack-keystone | 04:00 | |
*** david-lyle_ has quit IRC | 04:03 | |
*** david_lyle__ has joined #openstack-keystone | 04:03 | |
*** david-lyle has quit IRC | 04:04 | |
*** gyee has quit IRC | 04:07 | |
*** david_lyle__ has quit IRC | 04:08 | |
*** josecastroleon has quit IRC | 04:24 | |
*** josecastroleon has joined #openstack-keystone | 04:25 | |
*** lhcheng has joined #openstack-keystone | 04:33 | |
*** ChanServ sets mode: +v lhcheng | 04:33 | |
*** dikonoor has joined #openstack-keystone | 04:36 | |
*** su_zhang has joined #openstack-keystone | 04:40 | |
*** shoutm_ has quit IRC | 04:45 | |
*** shoutm has joined #openstack-keystone | 04:45 | |
*** vivekd has joined #openstack-keystone | 04:47 | |
*** josecastroleon has quit IRC | 04:55 | |
*** josecastroleon has joined #openstack-keystone | 04:56 | |
bigjools | hey, if I have a Client that was passed endpoint as one of the kwargs and then call client.authenticate(), it blows up because auth_url is not defined. Is this expected or a bug? I can still use the client but I just want to see if the credentials work before doing anything with it. | 05:00 |
*** GB21 has joined #openstack-keystone | 05:10 | |
bigjools | Well filed it as https://bugs.launchpad.net/python-keystoneclient/+bug/1547331 | 05:22 |
openstack | Launchpad bug 1547331 in python-keystoneclient "AuthorizationFailure: Authorization failed: Cannot authenticate without an auth_url" [Undecided,New] | 05:22 |
*** josecastroleon has quit IRC | 05:26 | |
*** josecastroleon has joined #openstack-keystone | 05:27 | |
*** dave-mccowan has quit IRC | 05:28 | |
*** vivekd has quit IRC | 05:28 | |
*** markvoelker has joined #openstack-keystone | 05:36 | |
*** rcernin has joined #openstack-keystone | 05:37 | |
*** markvoelker has quit IRC | 05:40 | |
*** GB21 has quit IRC | 05:42 | |
*** lhcheng_ has joined #openstack-keystone | 05:47 | |
*** lhcheng has quit IRC | 05:47 | |
*** su_zhang has quit IRC | 05:53 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Time-based One-time Password https://review.openstack.org/274901 | 05:54 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Time-based One-time Password https://review.openstack.org/274901 | 05:56 |
*** josecastroleon has quit IRC | 05:56 | |
*** scorpio has joined #openstack-keystone | 05:57 | |
*** josecastroleon has joined #openstack-keystone | 05:58 | |
*** scorpio is now known as chengkunye | 05:58 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Time-based One-time Password https://review.openstack.org/274901 | 05:59 |
*** su_zhang has joined #openstack-keystone | 06:02 | |
*** vivekd has joined #openstack-keystone | 06:02 | |
*** GB21 has joined #openstack-keystone | 06:04 | |
*** Nirupama has joined #openstack-keystone | 06:07 | |
*** tsymanczyk has joined #openstack-keystone | 06:08 | |
*** Guest49413 has quit IRC | 06:08 | |
*** tsymancz2k has quit IRC | 06:08 | |
*** tsymanczyk is now known as Guest12568 | 06:08 | |
*** tsymancz1k has joined #openstack-keystone | 06:13 | |
*** GB21 has quit IRC | 06:14 | |
*** GB21 has joined #openstack-keystone | 06:17 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Allow user list without specifying domain https://review.openstack.org/282080 | 06:18 |
*** belmoreira has joined #openstack-keystone | 06:23 | |
*** dikonoor has quit IRC | 06:27 | |
*** josecastroleon has quit IRC | 06:28 | |
*** josecastroleon has joined #openstack-keystone | 06:29 | |
*** GB21 has quit IRC | 06:30 | |
*** GB21 has joined #openstack-keystone | 06:31 | |
*** jaosorior has joined #openstack-keystone | 06:48 | |
*** GB21 has quit IRC | 06:52 | |
*** jasonsb has quit IRC | 06:52 | |
*** GB21 has joined #openstack-keystone | 06:56 | |
*** woodster_ has quit IRC | 06:56 | |
*** EinstCra_ has joined #openstack-keystone | 06:57 | |
*** EinstCrazy has quit IRC | 06:59 | |
*** GB21 has quit IRC | 07:08 | |
*** GB21 has joined #openstack-keystone | 07:10 | |
*** GB21 has quit IRC | 07:22 | |
*** GB21 has joined #openstack-keystone | 07:22 | |
*** ianw has quit IRC | 07:30 | |
*** ianw has joined #openstack-keystone | 07:31 | |
*** henrynash has joined #openstack-keystone | 07:32 | |
*** ChanServ sets mode: +v henrynash | 07:32 | |
*** GB21 has quit IRC | 07:34 | |
*** GB21 has joined #openstack-keystone | 07:34 | |
*** markvoelker has joined #openstack-keystone | 07:36 | |
*** aginwala has joined #openstack-keystone | 07:40 | |
*** markvoelker has quit IRC | 07:40 | |
*** chlong_ has quit IRC | 07:41 | |
*** pcaruana has joined #openstack-keystone | 07:45 | |
*** e0ne has joined #openstack-keystone | 07:49 | |
*** EinstCra_ has quit IRC | 07:52 | |
*** GB21 has quit IRC | 07:56 | |
*** boris-42 has joined #openstack-keystone | 08:04 | |
*** shoutm has quit IRC | 08:05 | |
*** shoutm has joined #openstack-keystone | 08:14 | |
henrynash | morning | 08:17 |
breton | morning | 08:18 |
*** shoutm has quit IRC | 08:18 | |
*** henrynash has quit IRC | 08:20 | |
*** henrynash has joined #openstack-keystone | 08:35 | |
*** ChanServ sets mode: +v henrynash | 08:35 | |
*** rk4n has joined #openstack-keystone | 08:35 | |
henrynash | anyone know much about degugging tests in our keystoneclient library? | 08:36 |
*** GB21 has joined #openstack-keystone | 08:36 | |
*** josecastroleon has quit IRC | 08:40 | |
*** josecastroleon has joined #openstack-keystone | 08:41 | |
*** annasort_ has joined #openstack-keystone | 08:45 | |
*** e0ne_ has joined #openstack-keystone | 08:46 | |
*** fhubik has joined #openstack-keystone | 08:48 | |
*** e0ne has quit IRC | 08:48 | |
*** annasort has quit IRC | 08:48 | |
*** tsymancz1k has quit IRC | 08:48 | |
*** Guest12568 has quit IRC | 08:48 | |
*** annasort_ is now known as annasort | 08:48 | |
*** e0ne_ has quit IRC | 08:48 | |
*** tsymanczyk has joined #openstack-keystone | 08:51 | |
*** tsymanczyk is now known as Guest17647 | 08:51 | |
*** tsymancz1k has joined #openstack-keystone | 08:52 | |
*** su_zhang has quit IRC | 08:53 | |
*** lhcheng_ is now known as lhcheng | 08:55 | |
*** ChanServ sets mode: +v lhcheng | 08:55 | |
*** henrynash has quit IRC | 08:57 | |
*** lhcheng has quit IRC | 08:57 | |
*** pnavarro has joined #openstack-keystone | 09:02 | |
*** GB21 has quit IRC | 09:10 | |
*** rk4n has quit IRC | 09:13 | |
*** aginwala has quit IRC | 09:29 | |
*** d0ugal has quit IRC | 09:30 | |
*** d0ugal has joined #openstack-keystone | 09:31 | |
*** d0ugal has quit IRC | 09:31 | |
*** d0ugal has joined #openstack-keystone | 09:31 | |
*** d0ugal has quit IRC | 09:31 | |
*** d0ugal has joined #openstack-keystone | 09:32 | |
*** d0ugal has quit IRC | 09:32 | |
*** d0ugal has joined #openstack-keystone | 09:32 | |
*** markvoelker has joined #openstack-keystone | 09:37 | |
*** markvoelker has quit IRC | 09:42 | |
*** mhickey has joined #openstack-keystone | 09:53 | |
*** davechen has left #openstack-keystone | 09:55 | |
*** rk4n has joined #openstack-keystone | 09:56 | |
*** rk4n_ has joined #openstack-keystone | 10:27 | |
*** rk4n has quit IRC | 10:29 | |
*** pnavarro has quit IRC | 10:45 | |
*** henrynash has joined #openstack-keystone | 10:50 | |
*** ChanServ sets mode: +v henrynash | 10:50 | |
*** vivekd has quit IRC | 11:21 | |
*** rk4n has joined #openstack-keystone | 11:22 | |
*** vivekd has joined #openstack-keystone | 11:24 | |
*** rk4n_ has quit IRC | 11:25 | |
*** vivekd_ has joined #openstack-keystone | 11:26 | |
*** linkmark has joined #openstack-keystone | 11:28 | |
*** vivekd has quit IRC | 11:29 | |
*** vivekd_ is now known as vivekd | 11:29 | |
*** d0ugal has quit IRC | 11:31 | |
*** d0ugal has joined #openstack-keystone | 11:31 | |
*** d0ugal has quit IRC | 11:31 | |
*** d0ugal has joined #openstack-keystone | 11:31 | |
*** rk4n_ has joined #openstack-keystone | 11:33 | |
*** vivekd has quit IRC | 11:35 | |
*** chengkunye has quit IRC | 11:35 | |
*** rk4n has quit IRC | 11:36 | |
openstackgerrit | henry-nash proposed openstack/python-keystoneclient: Support creation of domain specific roles https://review.openstack.org/282017 | 11:36 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: API support for project cascade update https://review.openstack.org/243585 | 11:38 |
*** markvoelker has joined #openstack-keystone | 11:38 | |
*** josecastroleon has quit IRC | 11:41 | |
*** josecastroleon has joined #openstack-keystone | 11:42 | |
*** markvoelker has quit IRC | 11:42 | |
openstackgerrit | henry-nash proposed openstack/python-keystoneclient: Support creation of domain specific roles https://review.openstack.org/282017 | 11:48 |
*** dave-mccowan has joined #openstack-keystone | 11:49 | |
*** henrynash has quit IRC | 11:59 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: API support for project cascade update https://review.openstack.org/243585 | 12:06 |
*** chlong_ has joined #openstack-keystone | 12:11 | |
*** josecastroleon has quit IRC | 12:11 | |
*** josecastroleon has joined #openstack-keystone | 12:12 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 12:21 |
*** EinstCrazy has joined #openstack-keystone | 12:27 | |
bigjools | I have converted some old code to use sessions when instantiating a client, but it was depending on the service_catalog which is no longer on the client. If I use client.endpoints.list() instead, the service_type is not in the endpoints returned, but the old code needed that. Is there any way to get the service_type out of the endpoints? | 12:29 |
*** dims_ has joined #openstack-keystone | 12:29 | |
bigjools | or is there a way to access the old service_catalog with sessions? | 12:30 |
*** toddnni has quit IRC | 12:31 | |
*** fpatwa has joined #openstack-keystone | 12:32 | |
*** gordc has joined #openstack-keystone | 12:35 | |
*** raildo-afk is now known as raildo | 12:35 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 12:38 |
*** raildo is now known as raildo-afk | 12:38 | |
*** raildo-afk is now known as raildo | 12:39 | |
samueldmq | raildo: htruta: I gave a couple of updates on 243585 and 244248 | 12:40 |
*** jaosorior has quit IRC | 12:40 | |
samueldmq | raildo: htruta: please take a look at +1 if you're okay with the changes | 12:40 |
raildo | samueldmq: looking | 12:40 |
samueldmq | stevemar: cc ^ | 12:41 |
*** jaosorior has joined #openstack-keystone | 12:41 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 12:43 |
*** rodrigods has quit IRC | 12:43 | |
*** sdake has joined #openstack-keystone | 12:43 | |
*** rodrigods has joined #openstack-keystone | 12:43 | |
samueldmq | raildo: ^ one more edit on the commit message (Partially-implements should be Implements) | 12:43 |
htruta | samueldmq, stevemar: should we add the release note at the last patch of the chain? | 12:44 |
*** fpatwa has quit IRC | 12:45 | |
*** jaosorior has quit IRC | 12:46 | |
*** jaosorior has joined #openstack-keystone | 12:46 | |
samueldmq | htruta: hmm, yes, that too | 12:48 |
samueldmq | htruta: remember to mention both update and delete operations in the release note | 12:51 |
htruta | samueldmq, stevemar: just to go with the flow: https://review.openstack.org/#/c/274836/ | 12:53 |
patchbot | htruta: patch 274836 - keystone-specs - Fix cascade operations documentation | 12:53 |
*** markvoelker has joined #openstack-keystone | 12:54 | |
*** ninag has joined #openstack-keystone | 12:55 | |
*** markvoelker has quit IRC | 12:58 | |
*** rk4n_ has quit IRC | 13:01 | |
*** rk4n has joined #openstack-keystone | 13:02 | |
*** markvoelker has joined #openstack-keystone | 13:04 | |
*** krotscheck_afk is now known as krotscheck | 13:05 | |
*** vivekd has joined #openstack-keystone | 13:06 | |
*** rk4n_ has joined #openstack-keystone | 13:06 | |
*** mylu has joined #openstack-keystone | 13:08 | |
*** mylu has quit IRC | 13:09 | |
openstackgerrit | Raildo Mascena proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 13:10 |
raildo | samueldmq: htruta release note done ^ | 13:10 |
*** rk4n has quit IRC | 13:10 | |
*** doug-fish has joined #openstack-keystone | 13:26 | |
*** dtroyer has quit IRC | 13:26 | |
*** edmondsw has joined #openstack-keystone | 13:28 | |
*** clenimar has joined #openstack-keystone | 13:29 | |
stevemar | raildo: samueldmq htruta will review the API changes today | 14:00 |
stevemar | just catching up on email ^_^ | 14:01 |
raildo | stevemar: np. thanks sir :) | 14:03 |
*** toddnni has joined #openstack-keystone | 14:04 | |
openstackgerrit | Matthew Edmonds proposed openstack/keystone: Update default domain's description https://review.openstack.org/281381 | 14:05 |
*** Ephur has joined #openstack-keystone | 14:11 | |
*** Nirupama has quit IRC | 14:12 | |
*** nkinder has joined #openstack-keystone | 14:18 | |
tjcocozz_ | bknudson_, now that its slow around here. i like how you implemented https://review.openstack.org/#/c/202760/5 much better than mine. | 14:19 |
patchbot | tjcocozz_: patch 202760 - python-openstackclient - Same exception handling for gets() in find_resource (ABANDONED) | 14:19 |
*** josecastroleon has quit IRC | 14:21 | |
bknudson_ | tjcocozz_: y, but it didn't work since there's all sorts of weird exceptions raised | 14:21 |
tjcocozz_ | bknudson_, probable the right exceptions though | 14:22 |
tjcocozz_ | probably | 14:22 |
*** josecastroleon has joined #openstack-keystone | 14:22 | |
bknudson_ | tjcocozz_: also, looks like I was trying to fix the same issue with get() params earlier: https://review.openstack.org/#/c/202748/ | 14:23 |
patchbot | bknudson_: patch 202748 - python-openstackclient - Query args for get-only (ABANDONED) | 14:23 |
bknudson_ | back in juno | 14:23 |
bknudson_ | july | 14:23 |
tjcocozz_ | bknudson_, why are people not accepting this change? | 14:24 |
bknudson_ | tjcocozz_: because https://review.openstack.org/#/c/202395/ merged instead | 14:25 |
patchbot | bknudson_: patch 202395 - python-openstackclient - Fix the way we call find_resource when only using ID (MERGED) | 14:25 |
stevemar | tjcocozz_: we are not accepting it because we don't like bknudson_ | 14:25 |
bknudson_ | tjcocozz_: it was low priority for me so I didn't keep it up to date. | 14:26 |
tjcocozz_ | bknudson_, lolz if bknudson_ patches merged everyone would be in a better place | 14:27 |
bknudson_ | plus, openstackclient people don't like outsider non-establishment renegades like me. | 14:27 |
tjcocozz_ | ha i need to learn how to type that was supose to go to stevemar | 14:27 |
*** doug-fish is now known as doug_fish | 14:27 | |
*** links has quit IRC | 14:27 | |
stevemar | tjcocozz_: it's true regardless | 14:28 |
stevemar | bknudson_: the osc team doesn't take kindly to renegade strangers | 14:28 |
bknudson_ | I'm like the Sarah Palin of openstack | 14:28 |
stevemar | tjcocozz_: ask newly minted OSC core, and guy who probably sits 10 feet from you, rtheis | 14:29 |
bknudson_ | rtheis is in sauk center! | 14:29 |
*** jsavak has joined #openstack-keystone | 14:30 | |
bknudson_ | rtheis is new so maybe I can influence him before he learns the culture. | 14:30 |
tjcocozz_ | stevemar, haha whats his full name? | 14:30 |
bknudson_ | it's probably in the review guidelines. | 14:30 |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Shadow users - Shadow federated users https://review.openstack.org/279162 | 14:31 |
bknudson_ | tjcocozz_: do you want me to restore https://review.openstack.org/#/c/202748/ ? | 14:33 |
patchbot | bknudson_: patch 202748 - python-openstackclient - Query args for get-only (ABANDONED) | 14:33 |
stevemar | bknudson_: what's a sauk center? | 14:33 |
*** vivekd has quit IRC | 14:34 | |
bknudson_ | stevemar: it's the birthplace of sinclair lewis, author of the jungle | 14:34 |
bknudson_ | read a book | 14:34 |
*** doug_fish is now known as doug-fish | 14:34 | |
stevemar | bknudson_: i picked up neuromancer and dune from our condo library | 14:34 |
*** dansmith is now known as superdan | 14:34 | |
tjcocozz_ | bknudson_, i added some functional tests to mine to make sure it doesn't digress. also there are a lot more try catches in there now idk if it will work | 14:34 |
*** amakarov_away is now known as amakarov | 14:35 | |
stevemar | neuruomancer has never been taken out, and the last times dune was taken out was 2009 and 1998 | 14:35 |
bknudson_ | http://cdn.meme.am/instances/500x/53539458.jpg | 14:35 |
bknudson_ | both of those are classics | 14:35 |
bknudson_ | you'll be changing your nick to muad-dib soon enough | 14:36 |
amakarov | stevemar, ayoung hi! One question: is it OK that we rely on cascaded deletion performed by third-party rdbms in implied roles? | 14:36 |
ayoung | amakarov, I think so | 14:37 |
tjcocozz_ | bknudson_, actually if yours makes more sense. i think you should re open it, and i will take it over if anyone has some push back. | 14:37 |
ayoung | that is what we use a database for: to enforce referential integrity | 14:37 |
ayoung | I don;t want to have to reimplement all of that in the code layer, | 14:37 |
*** petertr7_away is now known as petertr7 | 14:37 | |
bknudson_ | tjcocozz_: restored! | 14:37 |
ayoung | which is one reason you see the KVS backends being removed. | 14:38 |
bknudson_ | amakarov: just document in the driver spec what the function needs to do. | 14:38 |
*** henrynash has joined #openstack-keystone | 14:38 | |
*** ChanServ sets mode: +v henrynash | 14:38 | |
amakarov | bknudson_, there is a critical bug to fix: https://bugs.launchpad.net/keystone/+bug/1546562 | 14:39 |
openstack | Launchpad bug 1546562 in OpenStack Identity (keystone) "deleting role with implied role fails" [Critical,In progress] - Assigned to Alexander Makarov (amakarov) | 14:39 |
bknudson_ | what makes this critical? it's breaking the gate? | 14:39 |
amakarov | stevemar, ^^ | 14:39 |
amakarov | bknudson_, it actually disables the feature - looks just "high" for me | 14:40 |
*** rderose has joined #openstack-keystone | 14:41 | |
*** gordc has quit IRC | 14:42 | |
stevemar | bknudson_: critical cause i thought it was broken on all DBs | 14:42 |
*** openstackgerrit_ has quit IRC | 14:43 | |
tjcocozz_ | bknudson_, i don't see how this bug fixes the problem it is still passing kwargs too get() | 14:43 |
tjcocozz_ | bknudson_, i was looking at this bug https://review.openstack.org/#/c/202760/5 | 14:43 |
patchbot | tjcocozz_: patch 202760 - python-openstackclient - Same exception handling for gets() in find_resource (ABANDONED) | 14:43 |
stevemar | being unable to delete a role seems pretty critical to me :\ | 14:43 |
*** gordc has joined #openstack-keystone | 14:43 | |
bknudson_ | tjcocozz_: https://review.openstack.org/#/c/202760/5 doesn't fix the bug you were looking at. | 14:44 |
patchbot | bknudson_: patch 202760 - python-openstackclient - Same exception handling for gets() in find_resource (ABANDONED) | 14:44 |
*** openstackgerrit_ has joined #openstack-keystone | 14:44 | |
stevemar | ayoung: please state why you disagree with henrynash: https://review.openstack.org/#/c/282080/ :O | 14:45 |
patchbot | stevemar: patch 282080 - keystone - Allow user list without specifying domain | 14:45 |
bknudson_ | tjcocozz_: https://review.openstack.org/#/c/202748/ might be the one | 14:45 |
patchbot | bknudson_: patch 202748 - python-openstackclient - Query args for get-only | 14:45 |
tjcocozz_ | bknudson_, i doen't this one pass kwargs to get() as well? https://review.openstack.org/#/c/202748/2/openstackclient/common/utils.py | 14:45 |
patchbot | tjcocozz_: patch 202748 - python-openstackclient - Query args for get-only | 14:45 |
bknudson_ | tjcocozz_: it passes get_kwargs which isn't kwargs. | 14:46 |
bknudson_ | tjcocozz_: from https://review.openstack.org/#/c/202748/2/openstackclient/identity/v3/project.py , looks like keystone does have query params for /v3/project/<id> | 14:47 |
patchbot | bknudson_: patch 202748 - python-openstackclient - Query args for get-only | 14:47 |
*** dtroyer has joined #openstack-keystone | 14:48 | |
bknudson_ | tjcocozz_: rebase the change and fix the merge conflicts and see if it fixes the user show problem. | 14:48 |
*** roxanaghe has joined #openstack-keystone | 14:48 | |
*** openstackgerrit_ has quit IRC | 14:49 | |
tjcocozz_ | bknudson_, okay i will | 14:49 |
stevemar | ayoung: i appreciate your gusto in closing the mitaka bugs | 14:51 |
tjcocozz_ | bknudson_, i understand now. i don't this will work for get(users) since you can't pass any kwargs while in this case you are still passing an empty dictionary. | 14:52 |
*** vivekd has joined #openstack-keystone | 14:53 | |
bknudson_ | tjcocozz_: like this? http://paste.openstack.org/show/487582/ | 14:53 |
*** richm has joined #openstack-keystone | 14:54 | |
tjcocozz_ | bknudson_, oh that makes sense since it is an empty dictionary of positional arguments | 14:54 |
bknudson_ | tjcocozz_: that should have been **{}, but it works either way | 14:55 |
tjcocozz_ | bknudson_, i undersand you point though. | 14:55 |
bknudson_ | tjcocozz_: if you look at the docstring for find_resource it doesn't match how the function works. | 14:56 |
bknudson_ | the docstring says :param kwargs: To be used in calling .find() | 14:56 |
bknudson_ | put kwargs was also used in the call to get() | 14:56 |
*** roxanaghe has quit IRC | 14:57 | |
*** roxanagh_ has joined #openstack-keystone | 14:57 | |
tjcocozz_ | bknudson_, haha good eyes, i didn't notice that. | 14:57 |
*** openstackgerrit_ has joined #openstack-keystone | 14:57 | |
*** openstackgerrit_ has quit IRC | 14:59 | |
tjcocozz_ | bknudson_, what if other people are relying on passing their values for the get() through **kwargs? | 15:00 |
*** openstackgerrit_ has joined #openstack-keystone | 15:00 | |
bknudson_ | tjcocozz_: then there are going to be a lot of bugs | 15:00 |
tjcocozz_ | bknudson_, i think somewhere in here you need to call manager.get(int(name_or_id), **kwargs) | 15:00 |
tjcocozz_ | bknudson_, i think somewhere in here you need to call manager.get(name_or_id, **kwargs) | 15:00 |
*** linkmark has quit IRC | 15:02 | |
bknudson_ | openstackclient makes a lot of assumptions about how the managers work | 15:03 |
*** su_zhang has joined #openstack-keystone | 15:04 | |
tjcocozz_ | bknudson_, agreed. its hard to follow sometimes | 15:05 |
*** jasonsb has joined #openstack-keystone | 15:10 | |
*** dave-mccowan has quit IRC | 15:11 | |
*** vivekd has quit IRC | 15:12 | |
stevemar | tjcocozz_: tell that rtheis guy to fix it | 15:12 |
tjcocozz_ | stevemar, i may have too | 15:13 |
*** links has joined #openstack-keystone | 15:13 | |
*** roxanagh_ has quit IRC | 15:13 | |
*** slberger has joined #openstack-keystone | 15:15 | |
*** dhellmann has quit IRC | 15:16 | |
openstackgerrit | Clenimar Filemon proposed openstack/keystoneauth: Add is_domain to keystoneauth token https://review.openstack.org/282377 | 15:16 |
*** dhellmann has joined #openstack-keystone | 15:19 | |
*** phalmos has joined #openstack-keystone | 15:19 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:19 | |
openstackgerrit | Marek Denis proposed openstack/keystoneauth: Fix docstring in identity.v3.oidc module https://review.openstack.org/282380 | 15:21 |
*** dave-mccowan has joined #openstack-keystone | 15:25 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Remove setting class variable https://review.openstack.org/282383 | 15:27 |
*** josecastroleon has quit IRC | 15:27 | |
*** dims_ has quit IRC | 15:27 | |
*** su_zhang has quit IRC | 15:27 | |
*** tcline has joined #openstack-keystone | 15:27 | |
*** dan_nguyen has joined #openstack-keystone | 15:28 | |
*** su_zhang has joined #openstack-keystone | 15:28 | |
*** timcline has quit IRC | 15:28 | |
*** josecastroleon has joined #openstack-keystone | 15:29 | |
*** tcline has left #openstack-keystone | 15:29 | |
*** timcline has joined #openstack-keystone | 15:30 | |
*** sdake_ has joined #openstack-keystone | 15:30 | |
*** jbell8 has joined #openstack-keystone | 15:31 | |
*** sdake has quit IRC | 15:31 | |
*** jsavak has quit IRC | 15:32 | |
*** jsavak has joined #openstack-keystone | 15:32 | |
*** su_zhang has quit IRC | 15:32 | |
*** spzala has joined #openstack-keystone | 15:35 | |
*** mvk has quit IRC | 15:36 | |
openstackgerrit | Brant Knudson proposed openstack/keystone-specs: Cleanup formatting https://review.openstack.org/282393 | 15:40 |
*** jaosorior has quit IRC | 15:44 | |
*** rk4n_ has quit IRC | 15:44 | |
openstackgerrit | Merged openstack/keystone-specs: Cleanup formatting https://review.openstack.org/282393 | 15:46 |
*** annasort has quit IRC | 15:53 | |
*** annasort has joined #openstack-keystone | 15:53 | |
*** jsavak has quit IRC | 15:57 | |
*** jsavak has joined #openstack-keystone | 15:59 | |
openstackgerrit | Clenimar Filemon proposed openstack/keystoneauth: Add is_domain to keystoneauth token https://review.openstack.org/282377 | 16:01 |
*** clenimar has quit IRC | 16:04 | |
*** pushkaru has joined #openstack-keystone | 16:09 | |
*** pcaruana has quit IRC | 16:10 | |
*** jsavak has quit IRC | 16:11 | |
*** jsavak has joined #openstack-keystone | 16:12 | |
openstackgerrit | werner mendizabal proposed openstack/keystone: Time-based One-time Password https://review.openstack.org/274901 | 16:13 |
*** vivekd has joined #openstack-keystone | 16:14 | |
*** woodster_ has joined #openstack-keystone | 16:15 | |
*** mhickey has quit IRC | 16:21 | |
*** jasonsb has quit IRC | 16:23 | |
*** mylu has joined #openstack-keystone | 16:25 | |
*** jbell8 has quit IRC | 16:25 | |
*** jbell8_ has joined #openstack-keystone | 16:25 | |
*** diazjf has joined #openstack-keystone | 16:26 | |
*** phalmos has quit IRC | 16:27 | |
*** fhubik has quit IRC | 16:32 | |
*** su_zhang has joined #openstack-keystone | 16:33 | |
*** belmoreira has quit IRC | 16:35 | |
*** rderose has quit IRC | 16:36 | |
*** phalmos has joined #openstack-keystone | 16:38 | |
*** diazjf has quit IRC | 16:39 | |
*** josecastroleon has quit IRC | 16:40 | |
*** josecastroleon has joined #openstack-keystone | 16:41 | |
notmorgan | oh hai | 16:42 |
*** mylu has quit IRC | 16:48 | |
*** gyee has joined #openstack-keystone | 16:48 | |
*** ChanServ sets mode: +v gyee | 16:48 | |
amakarov | ayoung, do keystone support sqlite as a backend? | 16:51 |
*** su_zhang_ has joined #openstack-keystone | 16:53 | |
*** links has quit IRC | 16:53 | |
*** don_nalezyty has joined #openstack-keystone | 16:54 | |
*** diazjf has joined #openstack-keystone | 16:55 | |
*** su_zhang has quit IRC | 16:56 | |
*** jsavak has quit IRC | 16:56 | |
*** jsavak has joined #openstack-keystone | 16:57 | |
*** rcernin has quit IRC | 16:58 | |
ayoung | amakarov, not in production | 16:59 |
stevemar | amakarov: only in tests | 17:00 |
*** rderose has joined #openstack-keystone | 17:02 | |
*** e0ne has joined #openstack-keystone | 17:02 | |
*** su_zhang_ has quit IRC | 17:02 | |
notmorgan | it would be nice if we didnt even need to use it in tests | 17:03 |
stevemar | notmorgan: yep | 17:04 |
stevemar | amakarov and ayoung did one of you want to toss up a new patch for https://review.openstack.org/#/c/281921/ ? | 17:05 |
patchbot | stevemar: patch 281921 - keystone - Implied roles index with cascading update/delete | 17:05 |
amakarov | stevemar, working on it | 17:06 |
notmorgan | stevemar: ok patchbot just saved me having to look at the thing to know what it was. | 17:06 |
notmorgan | woo | 17:06 |
stevemar | amakarov: cool - just wanted to know, i was about to pull it down :D | 17:06 |
stevemar | i'll review the API support for project cascade instead ^_^ | 17:06 |
raildo | yay | 17:07 |
*** mylu has joined #openstack-keystone | 17:08 | |
*** lhcheng has joined #openstack-keystone | 17:08 | |
*** ChanServ sets mode: +v lhcheng | 17:08 | |
*** lhcheng_ has joined #openstack-keystone | 17:10 | |
*** lhcheng has quit IRC | 17:10 | |
notmorgan | !! | 17:14 |
openstack | notmorgan: Error: "!" is not a valid command. | 17:14 |
notmorgan | >.> | 17:14 |
*** josecastroleon has quit IRC | 17:15 | |
*** josecastroleon has joined #openstack-keystone | 17:17 | |
*** phalmos has quit IRC | 17:18 | |
*** lhcheng_ has quit IRC | 17:23 | |
*** lhcheng has joined #openstack-keystone | 17:23 | |
*** ChanServ sets mode: +v lhcheng | 17:23 | |
*** jsavak has quit IRC | 17:25 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Don't mutate input parameter https://review.openstack.org/282439 | 17:28 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Fix inconsistencies between Oauth1DriverV8 interface and driver https://review.openstack.org/282440 | 17:28 |
*** jsavak has joined #openstack-keystone | 17:28 | |
*** rcernin has joined #openstack-keystone | 17:30 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Fix inconsistencies between Oauth1DriverV8 interface and driver https://review.openstack.org/282440 | 17:30 |
*** doug-fish is now known as doug_fish | 17:31 | |
notmorgan | bknudson_: commented on https://review.openstack.org/#/c/282439/1 | 17:31 |
patchbot | notmorgan: patch 282439 - keystone - Don't mutate input parameter | 17:31 |
*** doug_fish is now known as doug-fish | 17:31 | |
bknudson_ | bikeshedding!!! | 17:32 |
notmorgan | bknudson_: yep. :) but figured i'd point out that the copy might be superfluous. | 17:32 |
stevemar | bknudson_: openstack is all about the bikeshedding | 17:32 |
notmorgan | not that i'd -1 over it. | 17:32 |
notmorgan | :) | 17:33 |
* notmorgan know bknudson_ likes clean code. | 17:33 | |
openstackgerrit | Merged openstack/keystone: Allow user list without specifying domain https://review.openstack.org/282080 | 17:33 |
bknudson_ | I'll give it a shot. | 17:34 |
bknudson_ | notmorgan: for this one, it's probably the caller that should have set the consumer secret (the manager) | 17:34 |
notmorgan | bknudson_: likely | 17:34 |
bknudson_ | rather than having this done in the driver | 17:34 |
notmorgan | bknudson_: in fact, i'd support moving that up to the manager more than having the driver set it | 17:35 |
bknudson_ | ok, let me try that instead. | 17:35 |
*** Ephur has quit IRC | 17:35 | |
notmorgan | that seems like business logic not "prepare data to store it" logic | 17:35 |
*** dims has joined #openstack-keystone | 17:35 | |
bknudson_ | somebody might say that's not backwards-compatible | 17:35 |
*** jsavak has quit IRC | 17:37 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/281605 | 17:37 |
notmorgan | bknudson_: actually, i think it would be | 17:37 |
*** GB21 has joined #openstack-keystone | 17:38 | |
notmorgan | bknudson_: if they overrid the logic in the driver, it's still overridden | 17:38 |
notmorgan | if they don't the value is still set | 17:38 |
*** su_zhang has joined #openstack-keystone | 17:38 | |
*** jsavak has joined #openstack-keystone | 17:38 | |
bknudson_ | you're right. | 17:38 |
*** su_zhang has quit IRC | 17:40 | |
*** su_zhang has joined #openstack-keystone | 17:41 | |
*** jbell8_ has quit IRC | 17:41 | |
*** jsavak has quit IRC | 17:41 | |
*** jsavak has joined #openstack-keystone | 17:42 | |
*** josecastroleon has quit IRC | 17:46 | |
openstackgerrit | Merged openstack/keystone: handle unicode names for federated users https://review.openstack.org/279908 | 17:47 |
*** josecastroleon has joined #openstack-keystone | 17:47 | |
stevemar | notmorgan: bknudson_ can you guys take a peek at https://review.openstack.org/#/c/277436/ ? | 17:48 |
patchbot | stevemar: patch 277436 - keystone - Return 404 instead of 401 for tokens w/o roles | 17:48 |
stevemar | looks like it needs love | 17:49 |
stevemar | lbragstad is out for a few days | 17:49 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/281605 | 17:49 |
notmorgan | stevemar: -2, taking the ball and going home :P oh i mean.. yeah i'll look at it | 17:49 |
openstackgerrit | Alexander Makarov proposed openstack/keystone: Implied roles index with cascading update/delete https://review.openstack.org/281921 | 17:50 |
notmorgan | huh | 17:50 |
notmorgan | why did he add ._get_token_id ? | 17:50 |
notmorgan | oh.. oh... ick | 17:51 |
notmorgan | stevemar: this is.. euuwww. | 17:51 |
bknudson_ | ick pretty much covers all the token generation code | 17:51 |
*** phalmos has joined #openstack-keystone | 17:51 | |
notmorgan | bknudson_: it's better than what we had in havana | 17:52 |
notmorgan | bknudson_: but ... thats not saying much | 17:52 |
stevemar | notmorgan: i asked you since you did all that token refactoring business :\ | 17:52 |
notmorgan | 'damnation through faint praise' | 17:52 |
amakarov | ayoung, I have a stupid question: what's the proper way to run keystone functional tests? | 17:53 |
stevemar | heeh | 17:53 |
lbragstad_ | what's up? sounds like questions on the token provider stuff? | 17:53 |
stevemar | ayoung: amakarov: we dont have functional tests for keystone set up yet :( | 17:53 |
notmorgan | lbragstad_: oh hi. yes. also if youre driving, get off irc :) | 17:53 |
notmorgan | stevemar: you put the FUN in functional :P | 17:54 |
lbragstad_ | notmorgan lol not currently | 17:55 |
notmorgan | lbragstad_: ok. then you can stay ;) | 17:55 |
lbragstad_ | notmorgan what can I help with? | 17:55 |
ayoung | dstanek, ^^ amakarov has a question for you | 17:55 |
*** petertr7 is now known as petertr7_away | 17:55 | |
amakarov | stevemar, well, I assume, I have to convince others that this works by betting my word on that? :) | 17:55 |
notmorgan | lbragstad_: https://review.openstack.org/#/c/277436/3 test failing! | 17:55 |
patchbot | notmorgan: patch 277436 - keystone - Return 404 instead of 401 for tokens w/o roles | 17:55 |
notmorgan | lbragstad_: it's all 'splody | 17:55 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Fix inconsistencies between Oauth1DriverV8 interface and driver https://review.openstack.org/282440 | 17:56 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Oauth1 manager sets consumer secret https://review.openstack.org/282439 | 17:56 |
*** annasort has quit IRC | 17:56 | |
amakarov | dstanek, can you please help me with functional testing here: https://review.openstack.org/#/c/281921/ ? | 17:56 |
patchbot | amakarov: patch 281921 - keystone - Implied roles index with cascading update/delete | 17:56 |
*** annasort has joined #openstack-keystone | 17:56 | |
stevemar | amakarov: yeah, not sure what to do about that | 18:01 |
stevemar | notmorgan: advice? | 18:01 |
notmorgan | stevemar: i have none | 18:01 |
stevemar | damn | 18:01 |
*** jsavak has quit IRC | 18:01 | |
stevemar | i could pull it down and test it, but... that doesn't scale well :) | 18:01 |
notmorgan | oh wait i do. don't use sqlite | 18:02 |
notmorgan | :P | 18:02 |
*** jsavak has joined #openstack-keystone | 18:03 | |
amakarov | notmorgan, you saved my day! )) | 18:03 |
stevemar | i'm kinda excited about all the networking commands we added to osc this release :) | 18:04 |
stevemar | it's pretty slick | 18:04 |
stevemar | https://github.com/openstack/python-openstackclient/blob/master/setup.cfg#L326-L345 | 18:04 |
amakarov | stevemar, maybe try creating rally scenario? We have non-voting job... | 18:04 |
stevemar | amakarov: true | 18:05 |
notmorgan | stevemar: experimental | 18:05 |
stevemar | yep | 18:05 |
notmorgan | amakarov: ^ | 18:05 |
stevemar | i knows | 18:05 |
stevemar | oh, i wonder how our uwsgi job is doing?! | 18:05 |
stevemar | bknudson_: that merged | 18:05 |
stevemar | bknudson_: gate-tempest-dsvm-keystone-uwsgi-full-nvNOT_REGISTERED (non-voting) | 18:06 |
stevemar | womp womp | 18:06 |
notmorgan | http://logs.openstack.org/83/282383/1/check/gate-tempest-dsvm-keystone-uwsgi-full-nv/446fb00/ | 18:06 |
*** jbell8 has joined #openstack-keystone | 18:07 | |
lbragstad_ | notmorgan raildo gyee responded - https://review.openstack.org/#/c/277436/3 | 18:07 |
patchbot | lbragstad_: patch 277436 - keystone - Return 404 instead of 401 for tokens w/o roles | 18:07 |
lbragstad_ | that's new | 18:07 |
notmorgan | lbragstad_: yep | 18:07 |
raildo | lbragstad_: thanks lbragstad_ :) | 18:08 |
raildo | so many repetitions... sorry | 18:08 |
lbragstad_ | raildo no problem - I didn't get around to refactoring the tests, but that shouldn't be too bad. I would assume most of that work is just changing the exception to match NotFound instead of Unauthorized. | 18:09 |
stevemar | notmorgan: i also +2'ed TOTP, so that happened | 18:09 |
notmorgan | wuuuuuut!? | 18:10 |
notmorgan | :P | 18:10 |
gyee | lbragstad, I think moving that check higher up would be able to catch all | 18:12 |
gyee | notmorgan, stevemar, so I want to test the totp patch along with my keystoneauth1 plugin | 18:12 |
gyee | problem is openstack client still loading the plugins from keystoneclient namespace | 18:13 |
stevemar | gyee: i am OK with you +2/+W the TOTP patch | 18:13 |
stevemar | if you think it's ready | 18:13 |
gyee | when are we expect to switch over to keystoneauth1 namespace? | 18:13 |
stevemar | gyee: when someone does the work? | 18:13 |
gyee | stevemar, hah | 18:13 |
notmorgan | gyee: when osc moves to ksa? | 18:13 |
gyee | stevarmar, yeah, the totp patch looks good now | 18:13 |
gyee | notmorgan, right | 18:14 |
gyee | right now its still loading the plugins from keystoneclient namespace | 18:14 |
stevemar | gyee: you bet it does! | 18:14 |
lbragstad_ | gyee works for me - I'll try and get another version uploaded... I've moved to to WIP until then | 18:14 |
gyee | lbragstad_, thank you sir | 18:14 |
stevemar | gyee: i wanted to look into that this week, but things came up | 18:14 |
gyee | stevemar, notmorgan, it its OK to park the totp auth plugin in keystoneauth for now | 18:15 |
gyee | ? | 18:15 |
stevemar | gyee: of course | 18:15 |
notmorgan | yep | 18:15 |
gyee | allllrighty then | 18:15 |
stevemar | gyee: i didn't want the totp in keystoneauth merged, just a strategy for it | 18:16 |
*** arunkant has quit IRC | 18:16 | |
*** vivekd has quit IRC | 18:16 | |
*** arunkant has joined #openstack-keystone | 18:16 | |
raildo | lbragstad_: that was i thought, if want some help, I can work on it | 18:17 |
*** josecastroleon has quit IRC | 18:17 | |
*** chlong_ has quit IRC | 18:18 | |
stevemar | raildo: lbragstad_ is away for a few days, if you want to post a new version, please do | 18:18 |
*** josecastroleon has joined #openstack-keystone | 18:18 | |
raildo | stevemar: so, I will, thanks | 18:19 |
stevemar | gyee: oops, the TOTP fail is a legit fail | 18:19 |
*** aginwala has joined #openstack-keystone | 18:20 | |
*** mylu has quit IRC | 18:20 | |
gyee | stevemar, ah shucks, let me see | 18:20 |
stevemar | gyee: commented | 18:21 |
stevemar | man i got really hungry all of a sudden | 18:21 |
*** dims_ has joined #openstack-keystone | 18:22 | |
gyee | foood | 18:22 |
*** browne has joined #openstack-keystone | 18:23 | |
*** dims has quit IRC | 18:25 | |
*** Dave has quit IRC | 18:25 | |
*** david8hu has quit IRC | 18:25 | |
*** mariusv has quit IRC | 18:25 | |
*** haneef has quit IRC | 18:25 | |
*** sshen has quit IRC | 18:25 | |
*** krotscheck has quit IRC | 18:25 | |
*** dobson has quit IRC | 18:25 | |
*** marekd has quit IRC | 18:25 | |
*** clayton has quit IRC | 18:25 | |
*** mkoderer__ has quit IRC | 18:25 | |
*** aginwala has quit IRC | 18:25 | |
*** krotscheck has joined #openstack-keystone | 18:25 | |
*** haneef has joined #openstack-keystone | 18:25 | |
*** david8hu has joined #openstack-keystone | 18:25 | |
*** Dave_____ has joined #openstack-keystone | 18:26 | |
*** sshen has joined #openstack-keystone | 18:26 | |
*** clayton has joined #openstack-keystone | 18:26 | |
*** dobson has joined #openstack-keystone | 18:26 | |
*** mkoderer__ has joined #openstack-keystone | 18:27 | |
*** marekd has joined #openstack-keystone | 18:27 | |
*** gordc has quit IRC | 18:27 | |
*** miguelgrinberg has quit IRC | 18:27 | |
*** bradjones has quit IRC | 18:27 | |
*** raginbajin has quit IRC | 18:27 | |
*** SamYaple has quit IRC | 18:27 | |
*** blogan has quit IRC | 18:27 | |
*** jdennis has quit IRC | 18:27 | |
*** lifeless has quit IRC | 18:27 | |
*** SamYaple has joined #openstack-keystone | 18:27 | |
*** raginbaj- has joined #openstack-keystone | 18:27 | |
*** blogan has joined #openstack-keystone | 18:27 | |
*** lifeless has joined #openstack-keystone | 18:27 | |
*** david-lyle has joined #openstack-keystone | 18:27 | |
*** jdennis has joined #openstack-keystone | 18:28 | |
*** bradjones has joined #openstack-keystone | 18:28 | |
*** bradjones has quit IRC | 18:28 | |
*** bradjones has joined #openstack-keystone | 18:28 | |
*** clayton_ has joined #openstack-keystone | 18:28 | |
*** miguelgrinberg has joined #openstack-keystone | 18:28 | |
*** clayton has quit IRC | 18:28 | |
*** raginbaj- is now known as raginbajin | 18:29 | |
*** flaper87 has quit IRC | 18:29 | |
*** flaper87 has joined #openstack-keystone | 18:29 | |
*** gordc has joined #openstack-keystone | 18:29 | |
*** clayton_ is now known as clayton | 18:29 | |
openstackgerrit | Merged openstack/keystoneauth: Fix docstring in identity.v3.oidc module https://review.openstack.org/282380 | 18:30 |
*** wanghua has quit IRC | 18:30 | |
*** jdennis has quit IRC | 18:33 | |
*** lhcheng has quit IRC | 18:35 | |
*** lhcheng has joined #openstack-keystone | 18:35 | |
*** ChanServ sets mode: +v lhcheng | 18:35 | |
*** wanghua has joined #openstack-keystone | 18:36 | |
*** pushkaru has quit IRC | 18:36 | |
dstanek | amakarov: did you get your question answered? | 18:37 |
amakarov | dstanek, no. | 18:37 |
* amakarov digging into rally | 18:38 | |
dstanek | gyee: are you working on https://review.openstack.org/#/c/274901 ? i have a few more changes to push | 18:38 |
dstanek | amakarov: what's the question? | 18:38 |
amakarov | how to run functional tests | 18:38 |
dstanek | amakarov: tox -e functional | 18:39 |
amakarov | dstanek, do we have it in gerrit? | 18:40 |
dstanek | amakarov: nothing in jenkins runs that yet. i think there are still outstanding reviews for stuff. | 18:40 |
amakarov | dstanek, ok, understood | 18:40 |
gyee | dstanek, yeah, just need to catch the TypeError in the plugin when base32 decode fail | 18:41 |
gyee | dstanek, maybe you can just that line | 18:42 |
dstanek | gyee: ok, i'll wait for you then | 18:42 |
dstanek | git st | 18:42 |
dstanek | lol | 18:42 |
openstackgerrit | guang-yee proposed openstack/keystone: Time-based One-time Password https://review.openstack.org/274901 | 18:42 |
gyee | dstanek, she's all yours | 18:42 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/281601 | 18:43 |
dstanek | gyee: thx | 18:44 |
dstanek | gyee: did you add a test showing the typeerror? | 18:45 |
amakarov | dstanek, waht does it mean: "db type could not be determined" ? | 18:45 |
dstanek | amakarov: you have to delete your .testrepository directory | 18:45 |
gyee | dstanek, no, its the same test for corrupted cred | 18:46 |
dstanek | test tools in python 3 doesn't work when it is create with python2 | 18:46 |
dstanek | gyee: that triggered a typeerror? | 18:46 |
gyee | dstanek, yes, for py27 | 18:46 |
gyee | but not py34 | 18:46 |
*** petertr7_away is now known as petertr7 | 18:47 | |
dstanek | hmm...that's strange because the tests passed without it | 18:47 |
gyee | decode returns either TypeError or ValueError | 18:47 |
bknudson_ | stevemar: I just did what they told me to do! | 18:48 |
*** josecastroleon has quit IRC | 18:48 | |
*** doug-fish has quit IRC | 18:48 | |
gyee | I think TypeError is return if detects a non-base32 digit, ValueError for incorrect padding maybe | 18:48 |
gyee | I'll need to check the doc | 18:48 |
notmorgan | dstanek: *shrug* | 18:49 |
dstanek | gyee: did you actually see a TypeError raised or is it caught somewhere? | 18:49 |
dstanek | notmorgan: ? | 18:49 |
*** josecastroleon has joined #openstack-keystone | 18:49 | |
dstanek | gyee: i was actually thinking of dropping the except keyerror, valueerror since nothing actually triggers it | 18:50 |
rodrigods | gyee, ping... about x509. Does it has support in keystonemiddleware already? | 18:50 |
*** doug-fish has joined #openstack-keystone | 18:50 | |
*** sdake_ is now known as sdake | 18:50 | |
dstanek | gyee: actually coverage is showing me that it is, but the method never fails | 18:51 |
gyee | rodrigods, not yet, Sam's working on it | 18:52 |
gyee | dstanek, strange, I can reproduce the failure in my dev env | 18:52 |
rodrigods | gyee, so tokenless auth can't be used yet by service users, right? or is there a hack that we can do? | 18:52 |
rodrigods | tokenless auth with x509 | 18:53 |
*** browne has quit IRC | 18:53 | |
dstanek | gyee: can you give me the stacktrace? | 18:53 |
gyee | dstanek, http://paste.openstack.org/show/487613/ | 18:54 |
*** doug-fish has quit IRC | 18:55 | |
*** EinstCrazy has quit IRC | 18:56 | |
*** rcernin has quit IRC | 18:56 | |
dstanek | nonameentername: you around? | 18:56 |
dstanek | gyee: yeah, i can see that block being hit now | 18:57 |
gyee | dstanek, I don't think we need that padding code | 18:57 |
gyee | if base32 decode fail, we bail | 18:58 |
gyee | no need for artificial padding | 18:58 |
dstanek | gyee: we do only because in the documentation we are telling users to strip out the padding | 18:58 |
gyee | why? | 18:59 |
dstanek | gyee: not sure | 18:59 |
*** spzala has quit IRC | 18:59 | |
dstanek | i would have to defer to nonameentername | 18:59 |
gyee | totp credential should be done via provisioning | 18:59 |
gyee | no need to manually manipulate it at all | 18:59 |
dstanek | gyee: i don't follow. the user won't be able to manage credentials themselves? | 19:00 |
gyee | rodrigods, right, Sam's working on an X.509 auth plugin right now, he'll post a WIP patch soon | 19:00 |
rodrigods | gyee, got it... thanks! please add me as reviewer :) | 19:00 |
gyee | rodrigods, sure, I'll let him know | 19:01 |
gyee | dstanek, they can, but that's usually done via a provisioning tool, like openstack CLI or UI | 19:01 |
gyee | they don't have to do the base32 dance themselves | 19:01 |
*** petertr7 is now known as petertr7_away | 19:02 | |
*** jsavak has quit IRC | 19:02 | |
*** jsavak has joined #openstack-keystone | 19:03 | |
*** browne has joined #openstack-keystone | 19:03 | |
gyee | rodrigods, actuall, https://review.openstack.org/#/c/246615/ | 19:05 |
patchbot | gyee: patch 246615 - python-keystoneclient - Auth plugin for X.509 tokenless authz (ABANDONED) | 19:05 |
gyee | but he'll have a better version up soon | 19:05 |
rodrigods | gyee, i saw that, was trying to find the keystoneauth one | 19:05 |
rodrigods | :) | 19:05 |
gyee | yeah, he's working that one | 19:06 |
*** mylu has joined #openstack-keystone | 19:08 | |
*** ktychkova has quit IRC | 19:09 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Implied roles index with cascading update/delete https://review.openstack.org/281921 | 19:11 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Remove useless {} from __table_args__ https://review.openstack.org/282510 | 19:11 |
stevemar | ayoung: not sure we can do a functional test for https://review.openstack.org/#/c/281921/ | 19:12 |
patchbot | stevemar: patch 281921 - keystone - Implied roles index with cascading update/delete | 19:12 |
stevemar | but we need the fix, i tested it manually and it works | 19:12 |
ayoung | stevemar, good to know. Lets put in a bug for the functional test and drive on with this | 19:13 |
ayoung | stevemar, first functional test should be moving our migration tests to MySQL | 19:14 |
stevemar | ayoung: alright -- meh to the bug for this specific issue, i'd say it's part of the larger overall effort to not use sqlite | 19:14 |
stevemar | yep | 19:14 |
ayoung | stevemar, without a functional test this is untested, so bug for this one, I'd say | 19:15 |
stevemar | alrighty | 19:16 |
stevemar | ayoung: my counter to that is all our FKs and casades are untested :) | 19:16 |
*** mariusv has joined #openstack-keystone | 19:17 | |
*** mariusv is now known as Guest61736 | 19:17 | |
*** e0ne has quit IRC | 19:18 | |
ayoung | stevemar, that would be a good name for the bug | 19:18 |
*** josecastroleon has quit IRC | 19:19 | |
*** josecastroleon has joined #openstack-keystone | 19:20 | |
dstanek | gyee: do you think i should remove the padding then and just expect people to supply the padding if they use the credentials api? | 19:21 |
*** rcernin has joined #openstack-keystone | 19:23 | |
*** e0ne has joined #openstack-keystone | 19:23 | |
*** e0ne has quit IRC | 19:25 | |
*** petertr7_away is now known as petertr7 | 19:26 | |
*** timcline_ has joined #openstack-keystone | 19:26 | |
stevemar | ayoung: dolphm getting a poke internally about this bug: https://bugs.launchpad.net/keystone/+bug/1503312 | 19:27 |
openstack | Launchpad bug 1503312 in OpenStack Identity (keystone) "Optimization: Don't rebuild revoke-tree in each validate-token call" [Medium,In progress] - Assigned to Sonali (sonali-pitre) | 19:27 |
stevemar | looks like memoize doesn't work on a multi-node keystone | 19:28 |
dolphm | notmorgan: ^ | 19:29 |
notmorgan | stevemar: memoize works fine | 19:30 |
notmorgan | stevemar: you must share a common memcache backen | 19:30 |
notmorgan | d | 19:30 |
notmorgan | on the multi-node keystone | 19:30 |
stevemar | notmorgan: looks like they did that, according to the bug report? | 19:30 |
notmorgan | nope clearly not. | 19:30 |
notmorgan | the tree is still rebuilt, just the DB query is not | 19:31 |
stevemar | notmorgan: https://bugs.launchpad.net/keystone/+bug/1503312/comments/15 | 19:32 |
openstack | Launchpad bug 1503312 in OpenStack Identity (keystone) "Optimization: Don't rebuild revoke-tree in each validate-token call" [Medium,In progress] - Assigned to Sonali (sonali-pitre) | 19:32 |
notmorgan | orthey have something else going on | 19:32 |
notmorgan | OR the revoke event is generally not cachable because the query is different | 19:32 |
notmorgan | basically, the revoke tree is icky and hard to cache. | 19:32 |
stevemar | notmorgan: so it could still be a legit bug? | 19:33 |
ayoung | stevemar, as I said, it is supposed to use Memoize. I don't know how you could avoid rebuilding the tree without that | 19:33 |
gyee | dstanek, I think we should remove the padding | 19:33 |
notmorgan | unlikely | 19:34 |
ayoung | and dropping a slew of the revocation events would also reduce it | 19:34 |
notmorgan | it is unlikely a real bug | 19:34 |
dstanek | gyee: ok, i'll do that an update the docs | 19:34 |
gyee | I think it was there to help curl testing | 19:34 |
ayoung | so...meh? | 19:34 |
dstanek | gyee: why do you think that? | 19:34 |
gyee | like 'I hate to encode the '=' in curl!' :_ | 19:34 |
gyee | :) | 19:34 |
notmorgan | stevemar: also, remember depending on what version of keystone, there was the kvs backend that wasn't really using memoize correctly | 19:35 |
notmorgan | stevemar: i am guessing they are doing master-master-master keystone | 19:36 |
stevemar | notmorgan: ayoung, is there anything in the config that should be changed? | 19:36 |
notmorgan | and galera gets granky | 19:36 |
notmorgan | cranky* | 19:36 |
notmorgan | the deadlocks are likely a sign of that | 19:36 |
gyee | dstanek, we'll need to update the docs when the auth plugin and openstackclient patches land | 19:36 |
notmorgan | also are we using select for update? /me should check | 19:36 |
notmorgan | cause that results in a deadlock that you need to rollback in galera | 19:36 |
*** mylu has quit IRC | 19:36 | |
notmorgan | deadlock is the error: rollback fixes | 19:37 |
ayoung | stevemar, I don't know. I have not really thought about that in a long time. I could see the "stale tree" thing happening | 19:37 |
notmorgan | then retry | 19:37 |
ayoung | so, cache timeout needs to be relatively short. But not rebuild every time | 19:37 |
stevemar | ayoung: according to the bug, its 1200 | 19:37 |
ayoung | stevemar, I commented on the review and there was no follow up | 19:38 |
notmorgan | stevemar: the best thing they can do is put a null revoke driver in for uuid | 19:38 |
notmorgan | that just does no revocation event storage and returns empty lists | 19:39 |
notmorgan | stevemar: that will eliminate their problem | 19:39 |
ayoung | stevemar, note that I said "Is the MEMOIZE the problem? If So, remove the decorator code as well." | 19:39 |
notmorgan | ayoung: memoize is not the problem. | 19:39 |
notmorgan | ayoung: they're getting deadlocks in the db | 19:39 |
ayoung | notmorgan, and then the rest of my comment stands | 19:39 |
notmorgan | ayoung: among other things | 19:39 |
ayoung | ok | 19:39 |
notmorgan | i'm almost certain they are doing master-master-master all writing to the local dbs in galera | 19:40 |
notmorgan | based on the info | 19:40 |
notmorgan | which will net weird behaviors | 19:40 |
stevemar | notmorgan: can you comment in the bug? just a few lines | 19:40 |
openstackgerrit | Alexander Makarov proposed openstack/keystone: Implied roles index with cascading update/delete https://review.openstack.org/281921 | 19:40 |
notmorgan | galera recommends write to one place. | 19:40 |
*** su_zhang has quit IRC | 19:41 | |
amakarov | stevemar, oops :) ^^ | 19:41 |
stevemar | amakarov: it's OK :) | 19:41 |
*** su_zhang has joined #openstack-keystone | 19:41 | |
amakarov | stevemar, if rally test fails we can fix it later | 19:41 |
stevemar | amakarov: yep | 19:42 |
*** mylu has joined #openstack-keystone | 19:43 | |
notmorgan | stevemar: commented | 19:45 |
*** rcernin has quit IRC | 19:45 | |
notmorgan | stevemar: but basically, i moved it back to incomplete | 19:45 |
notmorgan | there are 2-3 reports of things going on | 19:46 |
*** su_zhang has quit IRC | 19:46 | |
notmorgan | this is not a confined bug "we have an issue rebuilding the tree all the time", "we have db deadlocks", etc | 19:46 |
*** mylu has quit IRC | 19:48 | |
*** josecastroleon has quit IRC | 19:50 | |
*** jsavak has quit IRC | 19:50 | |
*** josecastroleon has joined #openstack-keystone | 19:50 | |
*** jsavak has joined #openstack-keystone | 19:51 | |
notmorgan | stevemar: -2 on that patch | 19:51 |
notmorgan | stevemar: addressing @memoize issue if there are any will result in the -2 being lifted | 19:52 |
notmorgan | stevemar: but i am very very very against implementing an in-process cache like they are doing. | 19:52 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Cleanup docstrings in session module https://review.openstack.org/282518 | 19:52 |
notmorgan | it's the wrong approach. | 19:52 |
notmorgan | dolphm: ^ cc | 19:52 |
dolphm | stevemar: what was the internal poke you got, anyway? | 19:53 |
dolphm | stevemar: did someone reproduce the issue? that's what was i really waiting to hear on the bug report, because otherwise i agree with notmorgan and ayoung | 19:54 |
notmorgan | i am guessing they are causing invalidate churn | 19:54 |
stevemar | dolphm: just a poke about the status of the bug and the patch, i hadn't been following it too closely so i wasn't aware of the desire for feedback from y'all | 19:54 |
notmorgan | dolphm: basically deleting tokens. | 19:54 |
dolphm | stevemar: but why did someone care about the bug? | 19:54 |
notmorgan | which will invalidate cache issue a new one. | 19:55 |
notmorgan | new event* | 19:55 |
stevemar | dolphm: cause they filed it? | 19:55 |
dolphm | stevemar: oh, i assumed you meant someone not in the bug discussion | 19:55 |
dolphm | when you said "internal" poke | 19:55 |
stevemar | dolphm: no, they were actually waiting for more feedback | 19:55 |
stevemar | dolphm: they poked me! | 19:55 |
stevemar | dolphm: looks like it was a holding pattern :) | 19:56 |
notmorgan | so, my guess is: logout/delete of token explicitly | 19:57 |
notmorgan | and their "fix" wont "fix" the issue | 19:58 |
notmorgan | or, #2, their memcache server is wildly underspec on memory and is LRUing out the pages. | 19:58 |
*** jsavak has quit IRC | 19:59 | |
*** jsavak has joined #openstack-keystone | 20:00 | |
*** gordc has quit IRC | 20:02 | |
*** diazjf has quit IRC | 20:11 | |
*** Dave_____ is now known as Dave | 20:13 | |
*** su_zhang has joined #openstack-keystone | 20:14 | |
samueldmq | htruta: raildo: you guys updating 244248 ? | 20:17 |
raildo | samueldmq: working on it | 20:17 |
*** nkinder has quit IRC | 20:17 | |
samueldmq | raildo: perfect! | 20:18 |
*** su_zhang has quit IRC | 20:18 | |
*** josecastroleon has quit IRC | 20:20 | |
*** josecastroleon has joined #openstack-keystone | 20:22 | |
samueldmq | raildo: htruta: tjcocozz_: I actually liked the API examples we had in 274836 | 20:23 |
* tjcocozz_ is looking | 20:23 | |
htruta | samueldmq: but those were endpoints. Now we don't have endpoints | 20:24 |
openstackgerrit | Raildo Mascena proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 20:24 |
samueldmq | htruta: why can't we just have modified it to PATCH /projects/{project_id}?cascade | 20:26 |
samueldmq | htruta: it's still an endpoint being executed with a query param, isn't it ? | 20:26 |
htruta | samueldmq: it is not the template of it. The sections are for specific calls | 20:26 |
samueldmq | htruta: I am not against it, but I think it's more useful and clearer if we have examples | 20:26 |
htruta | samueldmq: a query param does not create a new endpoint | 20:27 |
samueldmq | htruta: so add ?cascade to the examples of PATCH /projects/{id} | 20:28 |
samueldmq | which is an endpint and has examples ? | 20:28 |
htruta | samueldmq: that makes total sense!! good idea | 20:28 |
samueldmq | htruta: ++ | 20:28 |
*** dims_ has quit IRC | 20:31 | |
*** jsavak has quit IRC | 20:34 | |
*** jsavak has joined #openstack-keystone | 20:35 | |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Cleanup docstrings in session module https://review.openstack.org/282518 | 20:37 |
notmorgan | stevemar: some dude in australia keeps trying to take over my IRC account :P | 20:37 |
notmorgan | stevemar: [misconfigured client i think] | 20:38 |
notmorgan | but endless nickserv auth failures and SASL auth failures | 20:38 |
notmorgan | hehe | 20:38 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Cleanup docstrings https://review.openstack.org/282518 | 20:39 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Cleanup docstrings https://review.openstack.org/282518 | 20:42 |
*** diazjf has joined #openstack-keystone | 20:42 | |
*** sdake has quit IRC | 20:44 | |
*** diazjf has quit IRC | 20:48 | |
*** josecastroleon has quit IRC | 20:51 | |
*** ayoung has quit IRC | 20:52 | |
*** josecastroleon has joined #openstack-keystone | 20:53 | |
*** diazjf has joined #openstack-keystone | 20:54 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users - Separate user identities https://review.openstack.org/278570 | 20:56 |
*** jasonsb has joined #openstack-keystone | 20:58 | |
*** timcline_ has quit IRC | 21:04 | |
*** su_zhang has joined #openstack-keystone | 21:11 | |
*** notmorgan is now known as morgan | 21:13 | |
*** e0ne has joined #openstack-keystone | 21:16 | |
*** e0ne has quit IRC | 21:21 | |
*** jbell8 has quit IRC | 21:22 | |
*** josecastroleon has quit IRC | 21:22 | |
*** jbell8 has joined #openstack-keystone | 21:23 | |
*** Ephur has joined #openstack-keystone | 21:23 | |
*** josecastroleon has joined #openstack-keystone | 21:24 | |
*** jasonsb has quit IRC | 21:24 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users - Shadow federated users https://review.openstack.org/279162 | 21:25 |
*** lucas_ has joined #openstack-keystone | 21:25 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users - Shadow federated users https://review.openstack.org/279162 | 21:26 |
openstackgerrit | Raildo Mascena proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 21:30 |
raildo | rodrigods, ^ =D | 21:31 |
breton | notmorgan should complaint not to stevemar, but to jamielennox. he is Australia-core. | 21:34 |
morgan | hm? | 21:34 |
stevemar | haha | 21:34 |
rodrigods | raildo, great! | 21:34 |
morgan | oh | 21:34 |
morgan | hah | 21:34 |
stevemar | :) | 21:34 |
stevemar | we can get jamielennox to find this fake morgan | 21:34 |
morgan | stevemar: cuse clearly jamielennox knows everyone in australia | 21:34 |
raildo | rodrigods, now, let's get a beer and enjoy the weekend \o/ | 21:35 |
stevemar | raildo: rodrigods i'll be doing the same! | 21:35 |
stevemar | morgan: obviously | 21:35 |
raildo | stevemar, yay =D | 21:35 |
rodrigods | raildo, stevemar cheers | 21:35 |
breton | tomorrow is a normal business day in russia | 21:36 |
kfox1111 | seeing a very weird problem with our neutron server. I'm contimplating trying switching from pki tokens to uuid ones. can this be done on the fly without restarting/reconfiguring all the openstack services? | 21:36 |
rodrigods | breton, whaaat? | 21:36 |
breton | but then monday and tuesday are holidays | 21:37 |
rodrigods | hmm nice | 21:37 |
stevemar | kfox1111: probably need to restart keystone | 21:37 |
kfox1111 | yeah. was assuming that one. but will the clients automatically switch over to uuid processing? | 21:38 |
kfox1111 | basically just stop keystone, switch backend to uuid, delete * from tokens, and restart keystone? | 21:39 |
stevemar | kfox1111: they should... a bunch won't be validated | 21:39 |
stevemar | kfox1111: what you said, yes | 21:39 |
stevemar | kfox1111: the clients (keystonemiddleware) shouldn't need to change i think | 21:39 |
stevemar | let me take a quick look | 21:40 |
kfox1111 | (the problem at the moment seems to be neutron spawning off openssl processes faster then it can feed them, which is causing retransmits, and then more processes forked... neutron's basically broken... not sure if this is a cause or an effect, but an issue) | 21:41 |
morgan | kfox1111: you'll need to restart neutron unfortunately, keystone can't validate multiple types of tokens at once, so if there is any fall back to asking keystone action, you'll fail. | 21:41 |
kfox1111 | (kind of wonder if switching to uuid tokens will speed things back up enogh to clear things) | 21:41 |
stevemar | kfox1111: might have to unset a few config options in keystonemiddleware (like keyfile / certfile) | 21:42 |
morgan | middleware should just work even with certs still in config though if it gets a uuid token it should be sane. - the issue depends on what version a few versions of ksm did a bad job of handling a broken service token | 21:43 |
stevemar | err signing_dir actually | 21:43 |
morgan | switching token formats really isn't an "on-the-fly" kind of thing afaik | 21:43 |
kfox1111 | yeah, signing_dir is set... | 21:43 |
kfox1111 | was afraid of that... | 21:43 |
*** edmondsw has quit IRC | 21:44 | |
kfox1111 | the existing production services hosted out of the cloud are still working.... | 21:44 |
*** dave-mccowan has quit IRC | 21:44 | |
kfox1111 | really don't want to restart neutron-openvswitch-agent | 21:44 |
*** timcline has quit IRC | 21:46 | |
kfox1111 | it would probably work on the fly if we were going from uuid->fernet... but the pki one.... :/ | 21:46 |
*** e0ne has joined #openstack-keystone | 21:47 | |
kfox1111 | so the middleware doesn't pick the processing path based on something in the token? | 21:47 |
kfox1111 | the config determines if its pki or uuid? | 21:47 |
*** e0ne has quit IRC | 21:48 | |
openstackgerrit | Raildo Mascena proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 21:48 |
morgan | kfox1111: it's from the token, but some versions of KSM don't handle as well when you invalidate their token out frm under them | 21:49 |
morgan | kfox1111: it's a lot safer to restart services. | 21:49 |
morgan | kfox1111: even uuid -> fernet isn't really guaranteed | 21:49 |
*** josecastroleon has quit IRC | 21:53 | |
*** josecastroleon has joined #openstack-keystone | 21:54 | |
*** dave-mccowan has joined #openstack-keystone | 21:57 | |
*** phalmos has quit IRC | 22:01 | |
*** timcline has joined #openstack-keystone | 22:03 | |
*** lucas_ has quit IRC | 22:04 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: API support for project cascade update https://review.openstack.org/243585 | 22:04 |
samueldmq | stevemar: ping | 22:06 |
kfox1111 | morgan: oh, really? ok. I was considering migrating to uuid so later I could switch seamlessly to fernet. | 22:07 |
kfox1111 | but I'll just skip the uuid step then. | 22:07 |
morgan | kfox1111: might be easier | 22:08 |
morgan | kfox1111: you'll likely run into much the same issues. if moving between pki -> uuid is painful, moving uuid->fernet will be different painful | 22:08 |
dolphm | morgan: reading back... but not seeing the uuid->fernet pain you're referring to? | 22:09 |
*** jsavak has quit IRC | 22:09 | |
kfox1111 | so far, it seems like it was a neutron + file descrptor limit + nova-api retry's and pki validation all working badly together. | 22:09 |
morgan | dolphm: just in general, moving between token formats is going to be painful | 22:09 |
kfox1111 | neutron server was spawning openssl processes, zombies started piling up, then enough openssl processes stacked up, they starved out even reading, then ran out of file descriptors. :/ | 22:09 |
dolphm | morgan: afaik, ksm should just start calling back to keystone when it's not clearly a PKI token | 22:10 |
dolphm | morgan: this is a good question for mfisch | 22:10 |
morgan | dolphm: should. but there were versions of ksm that were really broken | 22:10 |
*** annasort has quit IRC | 22:10 | |
dolphm | morgan: oh | 22:10 |
dolphm | was not aware | 22:10 |
mfisch | whats up? | 22:10 |
morgan | dolphm: i've never seen a clean change token format w/o restarting services play | 22:10 |
mfisch | we bounced everything | 22:10 |
dolphm | mfisch: in your experience, did you have to restart other services (i.e. keystonemiddleware.auth_token) when switching to fernet? | 22:10 |
morgan | it might work in some cases, but i don't think we;ve ever tested it...sooooooo | 22:10 |
mfisch | yes | 22:11 |
morgan | so "if it isn't tested it is broken" | 22:11 |
dolphm | mfisch: what was the consequence if you didn't? | 22:11 |
mfisch | and the reason why is that I had an old middleware that couldnt handle invalid tokens | 22:11 |
morgan | gonna stand by this one | 22:11 |
mfisch | that was supposed to be fixed | 22:11 |
dolphm | ah | 22:11 |
mfisch | IIRC my old middleware kept tokens for an hour | 22:11 |
morgan | dolphm: :) but we still don't test swapping token formats | 22:11 |
mfisch | bouncing API services is pretty meh for us | 22:11 |
morgan | so i make no warranties and will recommend bouncing things | 22:11 |
kfox1111 | :) | 22:11 |
mfisch | I thought recent middleware would say "hey this token isnt working, better get a new one!" | 22:11 |
mfisch | which would just "work" | 22:12 |
morgan | mfisch: it should | 22:12 |
kfox1111 | if neutron could bounce services without dropping thigns off the network, it would be just fine with us. | 22:12 |
mfisch | so I agree it should and I didnt try it | 22:12 |
mfisch | kfox1111: you can restart neutron-server all day long bro | 22:12 |
kfox1111 | I've rarely seen that happen though. :/ | 22:12 |
dolphm | oooh, the middleware *own* token... not tokens it was trying to validate. | 22:12 |
mfisch | kfox1111: dont bounce the ovs-plugin or l3 agent | 22:12 |
morgan | but .. we don't test swapping the token format out :P so by that token... it's broken in openstack, or likely to be broken randomly | 22:12 |
mfisch | dolphm: yep | 22:12 |
morgan | dolphm: yeah it's the ksm's own token | 22:12 |
mfisch | the service's own personal token | 22:12 |
mfisch | We have a list of "safe" services to restart, for stuff like this or when rabbit dies | 22:13 |
dolphm | i'd hope things based on keystoneauth are now solid | 22:13 |
kfox1111 | oh, thats right... openvswitch-agent probably doesn't use a keystone token... | 22:13 |
mfisch | yep | 22:13 |
kfox1111 | probabl l3-agent too... | 22:13 |
mfisch | probably only neutron-server | 22:13 |
kfox1111 | ok. cool. that should be safe then. | 22:13 |
*** petertr7 is now known as petertr7_away | 22:13 | |
morgan | until we start testing swap token format out mid-flight i just am not comfortable recommending people swap formats w/o bouncing the services | 22:13 |
morgan | it likely isn't a bad test to write | 22:13 |
*** jsavak has joined #openstack-keystone | 22:13 | |
mfisch | kfox1111: for neutron we ONLY did neutron-server | 22:13 |
kfox1111 | we're going to have to bounce things when we do liberty soon, so I'll just do it then. | 22:13 |
morgan | and yeah only neton-server i think has ksm | 22:14 |
mfisch | would be cool to see if it just worked if you have a newish keystone middleware | 22:14 |
kfox1111 | just didn't want to bounds things on a friday when things were kind of broken. | 22:14 |
kfox1111 | if the issue really was just invalid token handling bugs, | 22:14 |
kfox1111 | then you could just test for that case. | 22:14 |
mfisch | kfox1111: we dont touch neutron-dhcp-agent neutron-metadata-agent neutron-l3-agent or neutron-plugin-openvswitch-agent | 22:14 |
kfox1111 | cool. that helps. :) | 22:15 |
mfisch | once on fernet the only real change to a service like neutron is that the token it has suddenly is broken | 22:15 |
mfisch | kfox1111: let me post my whole list, its probably over kill for a token format swap | 22:15 |
mfisch | kfox1111: https://gist.github.com/matthewfischer/6c564366b7538a422feb | 22:16 |
mfisch | again thats overkill but safeish | 22:16 |
mfisch | also good for when rabbit has a problem | 22:16 |
mfisch | kfox1111: if you decide not to restart stuff let me know what happens please | 22:16 |
openstackgerrit | Raildo Mascena proposed openstack/keystone: API support for project cascade delete https://review.openstack.org/244248 | 22:20 |
openstackgerrit | Merged openstack/keystone: Oauth1 manager sets consumer secret https://review.openstack.org/282439 | 22:20 |
kfox1111 | mfisch: aweseome. thanks. :) | 22:20 |
mfisch | good luck | 22:20 |
mfisch | its nowhere NEAR as bad as upgrading rabbit or openstack | 22:21 |
kfox1111 | mfisch: I think I got the error cleared for now. I'm going to push mgmt to let me get to liberty, then I'll enable fernet at the same time. | 22:21 |
kfox1111 | I'm running fernet tokens fine in prod with one of our liberty clouds. not sure I want to try it on kilo. | 22:21 |
mfisch | we've only run it on kilo so far | 22:21 |
mfisch | we're not on L yet | 22:21 |
mfisch | except for a few services | 22:22 |
kfox1111 | oh. run into any issues? | 22:22 |
mfisch | IIRC we needed soemthing in horizon | 22:22 |
mfisch | but we run horizon pretty close to master | 22:22 |
mfisch | no other issues | 22:22 |
mfisch | services mostly dont care what the token is, could be a cat picture for all they care | 22:22 |
kfox1111 | yeah, I thought I remember a fernet token issue. which was why I was waiting for liberty. | 22:23 |
kfox1111 | but I could run liberty horizon too, with kilo everything else. | 22:23 |
mfisch | our horizon guy says "certain version of django openstack auth needed from approx > Feb 2015" | 22:23 |
kfox1111 | sounds about right. | 22:24 |
*** josecastroleon has quit IRC | 22:24 | |
*** browne has quit IRC | 22:25 | |
*** josecastroleon has joined #openstack-keystone | 22:25 | |
*** browne has joined #openstack-keystone | 22:26 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/281601 | 22:27 |
*** jbell8 has quit IRC | 22:27 | |
*** annasort has joined #openstack-keystone | 22:28 | |
*** henrynash has quit IRC | 22:31 | |
*** mylu has joined #openstack-keystone | 22:31 | |
*** annasort has quit IRC | 22:32 | |
*** mylu has quit IRC | 22:32 | |
*** mylu has joined #openstack-keystone | 22:32 | |
*** sdake has joined #openstack-keystone | 22:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/281605 | 22:34 |
*** dims has joined #openstack-keystone | 22:36 | |
*** diazjf1 has joined #openstack-keystone | 22:36 | |
*** diazjf has quit IRC | 22:38 | |
*** ninag has quit IRC | 22:39 | |
*** annasort has joined #openstack-keystone | 22:41 | |
*** annasort has quit IRC | 22:45 | |
openstackgerrit | Merged openstack/keystone: Fix inconsistencies between Oauth1DriverV8 interface and driver https://review.openstack.org/282440 | 22:49 |
*** su_zhang has quit IRC | 22:50 | |
openstackgerrit | Merged openstack/keystoneauth: Cleanup docstrings https://review.openstack.org/282518 | 22:50 |
*** su_zhang has joined #openstack-keystone | 22:50 | |
*** david-lyle has quit IRC | 22:50 | |
*** david-lyle has joined #openstack-keystone | 22:51 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/281605 | 22:51 |
*** su_zhang has quit IRC | 22:52 | |
*** su_zhang has joined #openstack-keystone | 22:52 | |
*** david-lyle has quit IRC | 22:54 | |
*** david-lyle has joined #openstack-keystone | 22:54 | |
*** josecastroleon has quit IRC | 22:55 | |
*** josecastroleon has joined #openstack-keystone | 22:57 | |
*** mylu has quit IRC | 23:05 | |
*** mylu has joined #openstack-keystone | 23:08 | |
*** annasort has joined #openstack-keystone | 23:13 | |
*** slberger has left #openstack-keystone | 23:14 | |
*** annasort has quit IRC | 23:18 | |
*** roxanaghe has joined #openstack-keystone | 23:22 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:22 | |
*** mylu has quit IRC | 23:24 | |
*** jsavak has quit IRC | 23:26 | |
*** josecastroleon has quit IRC | 23:26 | |
*** roxanagh_ has joined #openstack-keystone | 23:27 | |
*** pushkaru has joined #openstack-keystone | 23:27 | |
*** josecastroleon has joined #openstack-keystone | 23:27 | |
*** mylu has joined #openstack-keystone | 23:29 | |
*** david-lyle_ has joined #openstack-keystone | 23:29 | |
*** david-lyle has quit IRC | 23:30 | |
*** roxanaghe has quit IRC | 23:30 | |
*** mylu has quit IRC | 23:30 | |
*** mylu has joined #openstack-keystone | 23:30 | |
*** sdake has quit IRC | 23:35 | |
*** annasort has joined #openstack-keystone | 23:35 | |
*** mylu has quit IRC | 23:39 | |
*** annasort has quit IRC | 23:39 | |
*** don_nalezyty has quit IRC | 23:43 | |
*** josecastroleon has quit IRC | 23:57 | |
*** pushkaru has quit IRC | 23:58 | |
*** josecastroleon has joined #openstack-keystone | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!