morgan | bknudson: globa _TheWorst | 00:07 |
---|---|---|
morgan | bknudson: _TheWorst = True | 00:07 |
morgan | global* | 00:07 |
*** fawadkhaliq has quit IRC | 00:07 | |
*** fawadkhaliq has joined #openstack-keystone | 00:08 | |
*** gyee has quit IRC | 00:20 | |
*** pumarani__ has quit IRC | 00:25 | |
*** fawadkhaliq has quit IRC | 00:28 | |
*** fawadkhaliq has joined #openstack-keystone | 00:29 | |
*** markvoelker has joined #openstack-keystone | 00:35 | |
*** fawadkhaliq has quit IRC | 00:40 | |
*** markvoelker has quit IRC | 00:41 | |
*** stingaci has quit IRC | 00:46 | |
*** richm has quit IRC | 01:00 | |
*** sdake_ has joined #openstack-keystone | 01:02 | |
*** sdake has quit IRC | 01:02 | |
*** sdake_ is now known as sdake | 01:08 | |
*** pushkaru has joined #openstack-keystone | 01:16 | |
*** pushkaru has quit IRC | 01:22 | |
*** phalmos has joined #openstack-keystone | 01:28 | |
*** EinstCrazy has joined #openstack-keystone | 01:31 | |
*** rderose has quit IRC | 01:37 | |
*** phalmos has quit IRC | 01:39 | |
openstackgerrit | Li Yingjun proposed openstack/keystone: Fix KeyError when rename to a name is already in use https://review.openstack.org/301418 | 01:43 |
*** woodster_ has quit IRC | 01:47 | |
*** mylu has quit IRC | 01:47 | |
*** mylu has joined #openstack-keystone | 01:49 | |
ayoung | morgan, do we need to fix the microsecond time recording in Fernet tokens in order to get revoke events to work? | 01:50 |
morgan | Uhm. Not sure | 01:51 |
morgan | We should be killing microseconds anywhere though. | 01:51 |
lbragstad | ayoung last I talked to morgan about that - we were going to leave revocation events and fernet timestamps as it | 01:51 |
lbragstad | and mock the clock | 01:51 |
morgan | And mock clock for tests. | 01:51 |
ayoung | lbragstad, so, even time.sleep(1) does not seem to be doing things right for the latest tests | 01:52 |
ayoung | I am not certain it is the same issue | 01:52 |
lbragstad | I abandon my patch to add subsecond precision to revocation events shortly after the midcycle | 01:52 |
morgan | We want subsecond to go away | 01:52 |
morgan | Not add more n | 01:52 |
lbragstad | ayoung ahh - I thought dolphm and I had similar issues when we tried that | 01:52 |
ayoung | so, we have a slew of tests where the wrong tokens are getting revoked for the one second after the delete event...I would not think that was the same thing | 01:53 |
ayoung | In most cases of the tests it is the admin token | 01:53 |
ayoung | we still have this morgan http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/test_v2.py#n1239 | 01:54 |
morgan | We also have a number of tokens that used admin and non admin tokens for the same thing b | 01:54 |
morgan | I ran across the issue when trying to squash extensions. | 01:54 |
morgan | And had fixed a lot of it. | 01:54 |
ayoung | so If I find throwing a sleep(1) in fixes the test, it is probably a case where the wrong token is used, or token for the wrong user? | 01:55 |
morgan | A sleep(1) fixing it is a mock the clock, if sleep doesn't fix it, it is the wrong token (likely shared admin/non admin token in the same test) | 01:56 |
morgan | Just a guess | 01:56 |
ayoung | morgan, see this one http://logs.openstack.org/93/278693/7/check/gate-keystone-python27-db/f793954/testr_results.html.gz | 01:58 |
ayoung | morgan, it does not always fail | 01:59 |
ayoung | it has a sleep(1) | 01:59 |
ayoung | and it is annoying me | 01:59 |
morgan | That sounds like a timing issue then. | 01:59 |
morgan | Vs wrong token. | 01:59 |
morgan | So mocking the clock properly vs sleep will be more reliable. | 01:59 |
*** stingaci has joined #openstack-keystone | 02:02 | |
ayoung | morgan, there are too many of them. I tried mocking the clock, too. SOmething is wrong here. | 02:02 |
*** cburgess has quit IRC | 02:05 | |
*** bapalm has quit IRC | 02:06 | |
*** cburgess has joined #openstack-keystone | 02:07 | |
*** zqfan has joined #openstack-keystone | 02:12 | |
*** gerhardqux has quit IRC | 02:13 | |
*** bapalm has joined #openstack-keystone | 02:13 | |
*** gerhardqux has joined #openstack-keystone | 02:13 | |
*** tristanC has quit IRC | 02:13 | |
*** wanghua has joined #openstack-keystone | 02:13 | |
*** tristanC has joined #openstack-keystone | 02:14 | |
*** mylu has quit IRC | 02:18 | |
*** mylu has joined #openstack-keystone | 02:33 | |
*** markvoelker has joined #openstack-keystone | 02:37 | |
*** markvoelker has quit IRC | 02:42 | |
*** rk4n has joined #openstack-keystone | 02:46 | |
*** lhcheng has quit IRC | 02:51 | |
*** mylu has quit IRC | 03:02 | |
*** mylu has joined #openstack-keystone | 03:02 | |
openstackgerrit | ayoung proposed openstack/keystone: Make fernet support trust auth against v2.0 https://review.openstack.org/278693 | 03:03 |
jamielennox | sigh, 6 months between blog posts is too long, whole ruby versions EOLed under me | 03:04 |
*** sdake_ has joined #openstack-keystone | 03:12 | |
*** mylu has quit IRC | 03:12 | |
*** sdake has quit IRC | 03:15 | |
*** sdake has joined #openstack-keystone | 03:18 | |
*** mylu has joined #openstack-keystone | 03:19 | |
*** links has joined #openstack-keystone | 03:20 | |
*** lhcheng has joined #openstack-keystone | 03:20 | |
*** ChanServ sets mode: +v lhcheng | 03:20 | |
*** sdake_ has quit IRC | 03:20 | |
*** lhcheng has quit IRC | 03:20 | |
*** lhcheng has joined #openstack-keystone | 03:21 | |
*** ChanServ sets mode: +v lhcheng | 03:21 | |
*** akanksha_ has joined #openstack-keystone | 03:23 | |
*** mylu has quit IRC | 03:29 | |
prosun | I wonder what does "openstack-attic" at the prefix of most project names in review.openstack.org mean? | 03:31 |
*** mylu has joined #openstack-keystone | 03:31 | |
*** anush_ has joined #openstack-keystone | 03:35 | |
prosun | ahhh... I see, attic means "a space or room just below the roof of a building". Yea, I found it ! | 03:40 |
*** mylu has quit IRC | 03:48 | |
*** mylu has joined #openstack-keystone | 03:49 | |
*** jasonsb has joined #openstack-keystone | 03:52 | |
stevemar | prosun: attic: where you store stuff you don't want to ever see again :) | 04:01 |
prosun | stevemar: gotcha. | 04:05 |
*** Nirupama has joined #openstack-keystone | 04:07 | |
prosun | I wonder why the API URL /v2.0/endpoints for creating endpoints is not listed in official Identity API v2.0 or its extensions or Identity Admin API 2.0 ? See the comment https://bugs.launchpad.net/keystone/+bug/1557166/comments/5 for details | 04:11 |
openstack | Launchpad bug 1557166 in OpenStack Identity (keystone) "V2 Endpoint creation with missing region returns 500" [Undecided,New] - Assigned to Kanika Singh (kanikasingh-1490) | 04:11 |
*** sheel has joined #openstack-keystone | 04:12 | |
*** roxanagh_ has joined #openstack-keystone | 04:31 | |
*** markvoelker has joined #openstack-keystone | 04:38 | |
*** mylu has quit IRC | 04:42 | |
*** markvoelker has quit IRC | 04:42 | |
*** lhcheng has quit IRC | 04:45 | |
*** spandhe has joined #openstack-keystone | 04:49 | |
*** EinstCrazy has quit IRC | 04:55 | |
*** EinstCrazy has joined #openstack-keystone | 05:05 | |
*** EinstCra_ has joined #openstack-keystone | 05:17 | |
*** dave-mccowan has quit IRC | 05:19 | |
*** EinstCrazy has quit IRC | 05:19 | |
*** roxanagh_ has quit IRC | 05:20 | |
*** rk4n has joined #openstack-keystone | 05:24 | |
*** lupine has quit IRC | 05:33 | |
*** lupine has joined #openstack-keystone | 05:35 | |
*** markvoelker has joined #openstack-keystone | 05:38 | |
openstackgerrit | Colleen Murphy proposed openstack/keystonemiddleware: Only confirm token binding on one token https://review.openstack.org/304400 | 05:39 |
*** spandhe has quit IRC | 05:40 | |
*** spandhe has joined #openstack-keystone | 05:42 | |
*** markvoelker has quit IRC | 05:43 | |
*** lhcheng has joined #openstack-keystone | 05:45 | |
*** ChanServ sets mode: +v lhcheng | 05:45 | |
*** dan_nguyen has quit IRC | 05:49 | |
*** fawadkhaliq has joined #openstack-keystone | 05:49 | |
*** rmizuno has joined #openstack-keystone | 05:58 | |
*** rmizuno has quit IRC | 06:10 | |
*** spandhe has quit IRC | 06:10 | |
*** ksnihyr has joined #openstack-keystone | 06:12 | |
*** c_soukup has joined #openstack-keystone | 06:16 | |
*** akanksha_ has quit IRC | 06:17 | |
*** csoukup has quit IRC | 06:19 | |
*** stingaci has quit IRC | 06:24 | |
*** tesseract has joined #openstack-keystone | 06:24 | |
*** tesseract is now known as Guest15115 | 06:24 | |
*** fawadkhaliq has quit IRC | 06:26 | |
*** mylu has joined #openstack-keystone | 06:27 | |
*** fawadkhaliq has joined #openstack-keystone | 06:29 | |
*** mylu has quit IRC | 06:32 | |
*** henrynash has joined #openstack-keystone | 06:39 | |
*** ChanServ sets mode: +v henrynash | 06:39 | |
*** anush_ has quit IRC | 06:39 | |
*** henrynash has quit IRC | 06:39 | |
*** stingaci has joined #openstack-keystone | 06:54 | |
*** stingaci has quit IRC | 06:59 | |
*** jaosorior has joined #openstack-keystone | 07:19 | |
*** sdake_ has joined #openstack-keystone | 07:24 | |
*** sdake has quit IRC | 07:26 | |
*** sdake has joined #openstack-keystone | 07:27 | |
*** sdake_ has quit IRC | 07:30 | |
*** markvoelker has joined #openstack-keystone | 07:39 | |
*** jamielennox is now known as jamielennox|away | 07:42 | |
*** rk4n has quit IRC | 07:43 | |
*** markvoelker has quit IRC | 07:44 | |
openstackgerrit | Merged openstack/keystonemiddleware: Create signing_dir upon first usage https://review.openstack.org/304255 | 07:46 |
*** henrynash has joined #openstack-keystone | 07:46 | |
*** ChanServ sets mode: +v henrynash | 07:46 | |
*** jaosorior has quit IRC | 07:47 | |
*** jaosorior has joined #openstack-keystone | 07:48 | |
*** e0ne has joined #openstack-keystone | 07:49 | |
*** daemontool_ has joined #openstack-keystone | 07:50 | |
*** henrynash has quit IRC | 07:52 | |
*** daemontool has quit IRC | 07:53 | |
*** lhcheng has quit IRC | 07:55 | |
*** stingaci has joined #openstack-keystone | 07:56 | |
*** fawadkhaliq has quit IRC | 08:01 | |
*** stingaci has quit IRC | 08:02 | |
*** e0ne has quit IRC | 08:04 | |
*** rk4n has joined #openstack-keystone | 08:17 | |
*** rk4n has quit IRC | 08:17 | |
*** rk4n has joined #openstack-keystone | 08:17 | |
*** jistr has joined #openstack-keystone | 08:25 | |
*** naresht has joined #openstack-keystone | 08:25 | |
*** mylu has joined #openstack-keystone | 08:28 | |
*** mylu has quit IRC | 08:32 | |
*** e0ne has joined #openstack-keystone | 08:33 | |
openstackgerrit | Merged openstack/keystone: Fixes bug where the updated federated display_name is not returned https://review.openstack.org/301987 | 08:35 |
openstackgerrit | Merged openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/303131 | 08:37 |
openstackgerrit | Merged openstack/keystoneauth: Fix doc build if git is absent https://review.openstack.org/303466 | 08:38 |
*** agireud has quit IRC | 08:39 | |
*** agireud has joined #openstack-keystone | 08:42 | |
*** agireud has quit IRC | 08:44 | |
andreykurilin__ | Can someone help me with keystoneclient? | 08:50 |
*** agireud has joined #openstack-keystone | 08:52 | |
openstackgerrit | Ryosuke Mizuno proposed openstack/keystone: Add keystone service ID to observer audit https://review.openstack.org/303963 | 08:58 |
*** dims has quit IRC | 09:04 | |
*** dims has joined #openstack-keystone | 09:05 | |
openstackgerrit | Merged openstack/keystone: Clean up test case for shadow users https://review.openstack.org/302123 | 09:10 |
openstackgerrit | Merged openstack/keystone: Simplify chained comparison https://review.openstack.org/302279 | 09:10 |
*** stingaci has joined #openstack-keystone | 09:14 | |
openstackgerrit | Merged openstack/keystone: create a new `advanced topics` section in the docs https://review.openstack.org/292227 | 09:14 |
*** openstackgerrit has quit IRC | 09:17 | |
*** openstackgerrit has joined #openstack-keystone | 09:17 | |
*** stingaci has quit IRC | 09:18 | |
*** gangadhar has joined #openstack-keystone | 09:19 | |
*** c_soukup has quit IRC | 09:25 | |
*** c_soukup has joined #openstack-keystone | 09:26 | |
*** e0ne has quit IRC | 09:29 | |
*** e0ne has joined #openstack-keystone | 09:31 | |
*** markvoelker has joined #openstack-keystone | 09:40 | |
*** markvoelker has quit IRC | 09:45 | |
openstackgerrit | Morgan Fainberg proposed openstack/keystone: Set the values for the request_local_cache https://review.openstack.org/304486 | 09:49 |
morgan | DinaBelova: ^ | 09:49 |
DinaBelova | morgan ack | 09:49 |
morgan | DinaBelova: my original test case was without memcache on | 09:49 |
morgan | DinaBelova: since the REGENERATE_NEEDED exception does an explicit set | 09:50 |
morgan | DinaBelova: it worked well. so basically we ended up skipping request_local when memcache hit unless an explicit set occured | 09:50 |
morgan | DinaBelova: inital tests on a VM, ~30-50 seconds reduction in test runtime with this fix | 09:50 |
morgan | DinaBelova: not tested with tempest yet | 09:50 |
morgan | :) | 09:51 |
DinaBelova | morgan thanks you sir for the update :) | 09:51 |
morgan | looking at the other bug you filed. | 09:51 |
morgan | also, proposing this fix as a backport to stab/mitaka | 09:51 |
openstackgerrit | Kanika Singh proposed openstack/keystone: Add a condition for 'region' parameter https://review.openstack.org/304489 | 09:53 |
*** vnogin has joined #openstack-keystone | 09:54 | |
*** vnogin has left #openstack-keystone | 09:54 | |
*** openstackstatus has quit IRC | 09:57 | |
*** openstack has joined #openstack-keystone | 09:58 | |
*** openstackstatus has joined #openstack-keystone | 09:59 | |
*** ChanServ sets mode: +v openstackstatus | 09:59 | |
morgan | DinaBelova: https://bugs.launchpad.net/keystone/+bug/1567413 | 10:11 |
openstack | Launchpad bug 1567413 in OpenStack Identity (keystone) "Keystone fetches data from Memcache even if caching is explicitly turned off" [Undecided,New] | 10:11 |
*** sdake has quit IRC | 10:11 | |
morgan | DinaBelova: did you run the test immediately following another testrun without clearing memcache? | 10:11 |
morgan | DinaBelova: and/or without resetting the values of the memcache server connections to empty or the dogpile backend to null again? | 10:12 |
morgan | DinaBelova: commented on the bug. | 10:12 |
*** jaosorior has quit IRC | 10:21 | |
*** jaosorior has joined #openstack-keystone | 10:22 | |
*** jed56 has quit IRC | 10:23 | |
*** vnogin has joined #openstack-keystone | 10:32 | |
DinaBelova | I did not clear the memcache, but I think in case of turned off caching it should not even try to fetch the data? | 10:39 |
*** EinstCra_ has quit IRC | 10:52 | |
*** daemontool_ has quit IRC | 10:54 | |
*** daemontool has joined #openstack-keystone | 10:54 | |
*** dave-mccowan has joined #openstack-keystone | 11:01 | |
*** adam_ has joined #openstack-keystone | 11:25 | |
adam_ | Has anyone had any issues with keystone before where wsgi locks are stuck in deleted causing the disk to show as full? (/run/apache2/wsgi.23561.0.1.lock (deleted)) | 11:26 |
*** e0ne has quit IRC | 11:30 | |
adam_ | Here's the paste, disk is showing as full, keystone seem to have 206 apache2 wsgi locks stuck in 'deleted', stopping apache clears them, but they return under different pid's once it starts back up. http://paste.openstack.org/show/493761/ | 11:37 |
*** doug-fish has joined #openstack-keystone | 11:39 | |
*** markvoelker has joined #openstack-keystone | 11:41 | |
*** markvoelker has quit IRC | 11:45 | |
*** openstack has quit IRC | 12:04 | |
*** openstack has joined #openstack-keystone | 12:05 | |
*** markvoelker has joined #openstack-keystone | 12:12 | |
*** tlbr has quit IRC | 12:14 | |
*** gordc has joined #openstack-keystone | 12:15 | |
*** tlbr has joined #openstack-keystone | 12:15 | |
*** rodrigods has quit IRC | 12:24 | |
*** rodrigods has joined #openstack-keystone | 12:24 | |
*** jamielennox|away is now known as jamielennox | 12:26 | |
*** c_soukup has quit IRC | 12:28 | |
*** richm has joined #openstack-keystone | 12:34 | |
*** e0ne has joined #openstack-keystone | 12:36 | |
*** mhickey has joined #openstack-keystone | 12:37 | |
*** tlbr has quit IRC | 12:43 | |
*** tlbr has joined #openstack-keystone | 12:43 | |
*** links has quit IRC | 12:52 | |
*** tlbr has quit IRC | 12:54 | |
*** gsilvis_ is now known as gsilvis | 12:59 | |
*** ninag has joined #openstack-keystone | 13:02 | |
openstackgerrit | ayoung proposed openstack/keystone: Make fernet support trust auth against v2.0 https://review.openstack.org/278693 | 13:03 |
dstanek | adam_: you're thinking that Keystone/mod_wsgi is filling up your disk? | 13:04 |
*** pauloewerton has joined #openstack-keystone | 13:05 | |
*** Nirupama has quit IRC | 13:07 | |
*** tlbr has joined #openstack-keystone | 13:08 | |
*** EinstCrazy has joined #openstack-keystone | 13:09 | |
*** pushkaru has joined #openstack-keystone | 13:11 | |
*** ayoung has quit IRC | 13:12 | |
*** doug-fish has quit IRC | 13:19 | |
adam_ | dstanek: I've moved on from wsgi as realized they're 0 length lock files anyway. Still can't find what's using 100% disk though sadly. | 13:20 |
*** EinstCrazy has quit IRC | 13:21 | |
adam_ | dstanek: du -h max-depth=1 on the 100% disk only shows as 1.3G, not the 39G is says it's using | 13:21 |
dstanek | adam_: you can always do a down and dirty 'du -sh /*' and start to narrow it down | 13:21 |
dstanek | adam_: what does 'df -h' show? | 13:21 |
adam_ | 'df -h' shows as 100% | 13:22 |
adam_ | I'll show you the paste of du -sh /* as that all looks fine too | 13:22 |
*** tlbr has quit IRC | 13:23 | |
adam_ | dstanek: here you go, everything looks fine here; http://paste.openstack.org/show/493792/ | 13:24 |
*** tlbr has joined #openstack-keystone | 13:24 | |
dstanek | adam_: what does your df -h look like? | 13:25 |
*** tellesnobrega is now known as tellesnobrega_af | 13:25 | |
adam_ | dstanek: df -h output - http://paste.openstack.org/show/493794/ | 13:26 |
*** doug-fish has joined #openstack-keystone | 13:27 | |
*** rderose has joined #openstack-keystone | 13:27 | |
dstanek | adam_: i've not seen anything like that before. have you done the windows fix are rebooted? | 13:28 |
*** mylu has joined #openstack-keystone | 13:29 | |
dstanek | adam_: if you would have had mount points i would have told you to unmount and check again, but you don't | 13:30 |
adam_ | dstanek: not yet, I don't have KVM/console to these servers until our canadian partner comes online so avoiding doing it at the mo, but guess it's worth a try | 13:31 |
dstanek | a reboot would clear tmp files and stop any processes that are writing. although i can't imagine anything has written 38G to disk and not committed it to a file | 13:32 |
*** raildo is now known as raildo-afk | 13:32 | |
*** jsavak has joined #openstack-keystone | 13:32 | |
dstanek | adam_: no root is a bummer :-( | 13:32 |
adam_ | dstanek: Oh, I have root, but if it didn't come online for what ever reason I wouldn't be able to do much with it | 13:33 |
adam_ | dstanek: I'll go for it though, not much else I can do at the moment with keystone unavaliable anyway | 13:34 |
*** edmondsw has joined #openstack-keystone | 13:34 | |
samueldmq | morning keystoners | 13:36 |
*** links has joined #openstack-keystone | 13:36 | |
Anticimex | is there any way to retrieve a keystone token via Horizon? | 13:37 |
*** mylu has quit IRC | 13:37 | |
Anticimex | use case: when using SAML2 federation and the IdP isn't compatible with ECP, users are prevented from authenticating from CLI | 13:37 |
*** mylu has joined #openstack-keystone | 13:38 | |
*** knikolla has joined #openstack-keystone | 13:42 | |
*** EinstCrazy has joined #openstack-keystone | 13:42 | |
*** ametts has joined #openstack-keystone | 13:43 | |
*** woodburn has joined #openstack-keystone | 13:48 | |
adam_ | dstanek: Found the cause, it's an issue with the control instance, keystone runs as an lxc container on control1, and the disk is full on there, my mistake for not checking further down the chain | 13:54 |
dstanek | adam_: ah, that explains why you couldn't see it | 13:55 |
*** timcline has joined #openstack-keystone | 13:58 | |
*** spzala has joined #openstack-keystone | 14:01 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add users functional tests https://review.openstack.org/289306 | 14:07 |
*** c_soukup has joined #openstack-keystone | 14:07 | |
*** links has quit IRC | 14:08 | |
*** woodster_ has joined #openstack-keystone | 14:10 | |
*** timcline has quit IRC | 14:12 | |
*** timcline has joined #openstack-keystone | 14:13 | |
*** doug-fish has quit IRC | 14:16 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:18 | |
*** Bjoern_ has joined #openstack-keystone | 14:18 | |
Bjoern_ | Morning | 14:20 |
*** Bjoern_ is now known as BjoernT | 14:20 | |
*** tellesnobrega_af is now known as tellesnobrega | 14:22 | |
*** naresht has quit IRC | 14:23 | |
*** timcline has quit IRC | 14:26 | |
*** phalmos has joined #openstack-keystone | 14:29 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 14:29 | |
*** vnogin has quit IRC | 14:30 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:30 | |
*** sdake has joined #openstack-keystone | 14:32 | |
BjoernT | Quick question, in regards to https://github.com/openstack/keystone/blob/master/etc/policy.v3cloudsample.json. The admin_domain_id needs to be updated with the real domain ID chosen to be the admin, inside the cloud_admin rule, in particular around domain_id:admin_domain_id rule ? | 14:33 |
dims | morgan : we don't need any fixes in oslo.cache right? https://review.openstack.org/#/c/304486 | 14:34 |
morgan | DinaBelova: unfortunately the turn "off" needs to be a bit more involved as evedenced by how dogpile works | 14:34 |
*** slberger has joined #openstack-keystone | 14:34 | |
morgan | dims: we could use a fix for setting defaults | 14:35 |
*** spandhe has joined #openstack-keystone | 14:35 | |
morgan | dims: but not for that to land | 14:35 |
morgan | dims: :) | 14:35 |
openstackgerrit | Alexander Makarov proposed openstack/keystone: Add set_config_defaults() call to tests https://review.openstack.org/304674 | 14:35 |
dims | cool thanks morgan i was just catching up on DinaBelova 's bug reports. looks like you handled both :) https://bugs.launchpad.net/keystone/+bug/1567413 was the other one | 14:36 |
openstack | Launchpad bug 1567413 in OpenStack Identity (keystone) "Keystone fetches data from Memcache even if caching is explicitly turned off" [Medium,Triaged] | 14:36 |
morgan | dims: yep. | 14:36 |
dims | thanks morgan! | 14:36 |
openstackgerrit | Alexander Makarov proposed openstack/keystone: Add DB operations tracing https://review.openstack.org/294535 | 14:36 |
morgan | dims: https://review.openstack.org/#/c/277198/ would be the thing that needs the setdefaults function | 14:37 |
patchbot | morgan: patch 277198 - keystone - Default caching to on for request-local caching. | 14:37 |
*** spandhe has quit IRC | 14:37 | |
morgan | but that is a questionable patch to begin with | 14:37 |
dims | y looking | 14:38 |
amakarov | morgan, o/ | 14:40 |
morgan | amakarov: hi | 14:40 |
adam_ | dstanek: all sorted now, thanks for stepping in to help though! | 14:40 |
amakarov | looks like we have wrong tests initialization :) | 14:40 |
morgan | amakarov: ? | 14:40 |
morgan | amakarov: need to be a bit more clear - i just woke up... | 14:41 |
amakarov | https://bugs.launchpad.net/keystone/+bug/1569389 | 14:41 |
openstack | Launchpad bug 1569389 in OpenStack Identity (keystone) "set_config_defaults() never called on testing" [Undecided,In progress] - Assigned to Alexander Makarov (amakarov) | 14:41 |
morgan | amakarov: ah in unit tests yeah. | 14:41 |
amakarov | this caused Dina's osprofiles patch chain to fail | 14:41 |
morgan | well it is called... in some cases | 14:41 |
morgan | just not in all | 14:41 |
morgan | where we standup a whole keystone, it is called | 14:42 |
morgan | the restful patches | 14:42 |
morgan | s/patches/tests | 14:42 |
morgan | we need to call it (likely) in keystone.tests.unit.core | 14:43 |
*** mvk has quit IRC | 14:43 | |
morgan | though lets be fair, i am on the fence if unit tests need osprofiler | 14:43 |
morgan | if that makes sense. | 14:43 |
amakarov | morgan, one thing I'm worried about: is it legal to put this call right after config.configure in the wery root of keystone tests... But tests looks happy )) | 14:44 |
amakarov | s/looks/look/ | 14:44 |
morgan | it should be fine to call it anypoint | 14:44 |
morgan | after config.configure() | 14:44 |
morgan | but like i said... do we *reall* want to run osprofiler in unit tests? | 14:44 |
morgan | what is the win? | 14:44 |
dims | morgan : we usually have set_defaults() in other oslo libs, i think oslo.cache is more complicated setup/configure :) so we may need bknudson's help :) | 14:44 |
morgan | dims: right... or mine :P considering oslo.cache is almost 100% my code :P | 14:45 |
amakarov | morgan, hm, that is the question! | 14:45 |
morgan | amakarov: i'm thinking the answer is we don't profile unit tests | 14:45 |
DinaBelova | amakarov it's interesting | 14:45 |
DinaBelova | when I added this locally | 14:45 |
DinaBelova | it did not help | 14:45 |
morgan | amakarov: profiling unit tests seems weird. | 14:45 |
dims | morgan : haha. i mean help to make it look like other oslo projects :) | 14:45 |
morgan | dims: dogpile needs some fixes too. which i've got on my personal backlog | 14:46 |
DinaBelova | amakarov - but probably I had poisoned virtualenv | 14:46 |
morgan | but E_LOOKING_FOR_WORK | 14:46 |
dims | morgan : cool | 14:46 |
morgan | since most work is openstack i've been staying focused there. | 14:46 |
DinaBelova | morgan even if the setup will be processed, without needed wrappers tests won't be traced :) | 14:47 |
amakarov | DinaBelova, well, the patch chain just passed unit tests on my brand new virtualenv | 14:47 |
DinaBelova | amakarov ack | 14:47 |
*** mylu has quit IRC | 14:47 | |
morgan | DinaBelova: it also may just be fine as is | 14:47 |
morgan | ;) | 14:47 |
morgan | as amakarov is showing | 14:47 |
DinaBelova | morgan indeed | 14:47 |
*** raildo-afk is now known as raildo | 14:48 | |
morgan | DinaBelova: so the issue with cache off is we only test if we should store new values; if dogpile is connected to memcache it'll still do requests to it | 14:48 |
morgan | DinaBelova: the SHOULD_CACHE_FN is the magic. | 14:48 |
morgan | DinaBelova: not sure if we want to make [cache]\enabled=false force dogpile to disconnect from memcache as well | 14:49 |
morgan | which would be a fix to oslo.cache | 14:49 |
morgan | dims: ^ cc (since it might be oslo.cache related) | 14:50 |
DinaBelova | morgan oh... I did not realize this. Just when I set caching to disabled, I expected not to see these connections | 14:50 |
DinaBelova | yes, let's ask dims | 14:50 |
morgan | DinaBelova: :) your bug indicated i didn't cover that case directly, documentation or otherwise. | 14:50 |
dims | DinaBelova : i'd definitely want to see a review filed in oslo.cache for debate. yes, i'd support it | 14:51 |
*** sdake_ has joined #openstack-keystone | 14:51 | |
DinaBelova | morgan well, that's also a result, I'm happy I could help | 14:51 |
DinaBelova | dims ack | 14:51 |
DinaBelova | I think I'll be able to do commit tomorrow | 14:51 |
dims | good work DinaBelova ! | 14:52 |
morgan | dims: there are two ways to fix it: 1 - reset the region to the default dogpile.null region | 14:52 |
morgan | dims: which would be done at configuration of the cache region opbject | 14:52 |
morgan | dims: or in each project we unset the memcache server bits [not in oslo.cache] | 14:52 |
* dims listening | 14:52 | |
morgan | since keystone is the only thing using oslo.cache... | 14:53 |
morgan | :P | 14:53 |
morgan | really | 14:53 |
morgan | well with @memoize | 14:53 |
dims | lol, let's try #1 and #2 as fallback :) | 14:53 |
DinaBelova | dims morgan - ack | 14:53 |
morgan | DinaBelova: happy to let you hack up the code for this or i can right now | 14:53 |
morgan | DinaBelova: your call :) | 14:54 |
DinaBelova | morgan I'll be able to jump to this tomorrow :) if you have time today - u'r welcome to do that yourself :) | 14:54 |
morgan | sure. should be really quick | 14:54 |
DinaBelova | morgan ack, thanks :) | 14:55 |
*** sdake has quit IRC | 14:55 | |
dims | thanks morgan | 14:56 |
*** gangadhar has quit IRC | 14:56 | |
*** ametts has quit IRC | 14:59 | |
*** mylu has joined #openstack-keystone | 14:59 | |
morgan | dims: almost done | 14:59 |
morgan | updating tests and will propose. | 15:00 |
*** mvk has joined #openstack-keystone | 15:00 | |
*** diazjf has joined #openstack-keystone | 15:04 | |
dims | morgan : awesome! thanks | 15:04 |
*** afazekas has quit IRC | 15:09 | |
*** afazekas has joined #openstack-keystone | 15:09 | |
*** phalmos has quit IRC | 15:09 | |
*** sdake has joined #openstack-keystone | 15:12 | |
morgan | dims: https://review.openstack.org/304688 | 15:14 |
morgan | DinaBelova: ^cc | 15:14 |
*** mylu has quit IRC | 15:16 | |
*** sdake_ has quit IRC | 15:16 | |
*** mylu has joined #openstack-keystone | 15:16 | |
*** adam_ has quit IRC | 15:16 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add users functional tests https://review.openstack.org/289306 | 15:17 |
*** openstackgerrit has quit IRC | 15:18 | |
*** openstackgerrit has joined #openstack-keystone | 15:18 | |
*** doug-fish has joined #openstack-keystone | 15:19 | |
*** ayoung has joined #openstack-keystone | 15:20 | |
*** ChanServ sets mode: +v ayoung | 15:20 | |
*** doug-fish has quit IRC | 15:24 | |
openstackgerrit | ayoung proposed openstack/keystone: Make fernet support trust auth against v2.0 https://review.openstack.org/278693 | 15:24 |
*** TxGVNN has joined #openstack-keystone | 15:24 | |
*** jaosorior has quit IRC | 15:24 | |
stevemar | morgan: thanks for all the reviews last night | 15:28 |
*** phalmos has joined #openstack-keystone | 15:28 | |
morgan | stevemar: i didn't review anything last night >.> | 15:28 |
morgan | stevemar: insomniacmorgan did | 15:28 |
morgan | :P | 15:28 |
morgan | sadly fell asleep early and woek up at midnight. figured i might as well review things until i fell alseep | 15:29 |
morgan | stevemar: https://review.openstack.org/#/q/I4857cfe1e62d54c3c89a0206ffc895c4cf681ce5,n,z | 15:29 |
morgan | straightforward fix, but good to land. will improve request local cache | 15:30 |
morgan | stevemar: and do we want to propose request local to stable/liberty? i know dolphm was interested in that | 15:30 |
dolphm | morgan: did you see the performance / caching conversation on the list? | 15:31 |
*** tellesnobrega is now known as tellesnobrega_af | 15:33 | |
*** yarkot_ has joined #openstack-keystone | 15:38 | |
*** phalmos has quit IRC | 15:39 | |
*** sdake_ has joined #openstack-keystone | 15:41 | |
*** doug-fish has joined #openstack-keystone | 15:42 | |
*** sdake has quit IRC | 15:43 | |
*** fesp has joined #openstack-keystone | 15:43 | |
*** phalmos has joined #openstack-keystone | 15:43 | |
*** anush_ has joined #openstack-keystone | 15:45 | |
*** fesp has quit IRC | 15:45 | |
morgan | dolphm: from DinaBelova ? | 15:46 |
morgan | dolphm: and mfisch ? | 15:46 |
*** doug-fish has quit IRC | 15:46 | |
DinaBelova | heh, it looks like morgan knows all about this :) | 15:46 |
morgan | dolphm: proposed fixes for both bufs. | 15:47 |
morgan | bugs* | 15:47 |
*** doug-fish has joined #openstack-keystone | 15:52 | |
*** EinstCrazy has quit IRC | 15:53 | |
*** doug-fis_ has joined #openstack-keystone | 15:54 | |
*** fawadkhaliq has joined #openstack-keystone | 15:55 | |
*** sdake_ has quit IRC | 15:55 | |
*** sdake has joined #openstack-keystone | 15:55 | |
ayoung | lbragstad, so on https://review.openstack.org/#/c/278693/ I'm not 100% comfortable with it. The 21 second delay was just a slip that I left in there, but there is something wrong with the revocation checking mechanism. I don't like the way we have to play around with delays. THere is something else more wrong here, with the wrong tokens getting revoked and all that. It might be, as morgan suggested, that it is due to bad tests, but that one | 15:57 |
ayoung | should not ever get a forbidden error, and that is how it was failing | 15:57 |
patchbot | ayoung: patch 278693 - keystone - Make fernet support trust auth against v2.0 | 15:57 |
*** doug-fish has quit IRC | 15:58 | |
ayoung | Just had a thought...with the mock we might be able to make it easier to reproduce...let me see. | 15:58 |
*** gyee has joined #openstack-keystone | 16:00 | |
*** ChanServ sets mode: +v gyee | 16:00 | |
*** timcline has joined #openstack-keystone | 16:00 | |
BjoernT | dolphm: Quick question, in regards to https://github.com/openstack/keystone/blob/master/etc/policy.v3cloudsample.json. The admin_domain_id needs to be updated with the real domain ID chosen to be the admin, inside the cloud_admin rule, in particular around domain_id:admin_domain_id rule ? | 16:01 |
*** jsavak has quit IRC | 16:02 | |
*** doug-fish has joined #openstack-keystone | 16:02 | |
*** jsavak has joined #openstack-keystone | 16:02 | |
openstackgerrit | Alexander Makarov proposed openstack/keystone: Add DB operations tracing https://review.openstack.org/294535 | 16:03 |
*** doug-fish has quit IRC | 16:03 | |
*** doug-fish has joined #openstack-keystone | 16:04 | |
*** doug-fish has quit IRC | 16:04 | |
*** doug-fish has joined #openstack-keystone | 16:05 | |
*** doug-fis_ has quit IRC | 16:05 | |
*** dan_nguyen has joined #openstack-keystone | 16:06 | |
*** doug-fish has quit IRC | 16:09 | |
*** fawadkhaliq has quit IRC | 16:09 | |
anteaya | stevemar: so keystone mid-cycle plans? | 16:12 |
anteaya | stevemar: thought about toronto at all? | 16:12 |
anteaya | it is beautiful in the summer | 16:12 |
* anteaya pictures just finding a parking spot as opposed to having to fly | 16:13 | |
morgan | anteaya, stevemar: I vote brazil and we visit samueldmq :P | 16:13 |
*** fawadkhaliq has joined #openstack-keystone | 16:13 | |
* morgan cant actually do that trip yet | 16:13 | |
anteaya | morgan: oh yes, brazil would be great too | 16:13 |
anteaya | brazil as a first choice, toronto as a back up? | 16:14 |
bknudson | don't need to worry about summer/winter in brazil | 16:15 |
bknudson | I'd prefer to go to brazil in the winter | 16:15 |
anteaya | good point | 16:15 |
anteaya | how long are brazil visas good for? | 16:16 |
anteaya | australian visas are good for a year | 16:16 |
htruta | wow! midcycle brazil ++ | 16:16 |
raildo | anteaya: http://brazil.travisa.com/ | 16:17 |
raildo | anteaya: there is a couple of tips on this link | 16:17 |
anteaya | raildo: thanks | 16:17 |
*** jasonsb has quit IRC | 16:18 | |
bknudson | looks like visa is waived due to olympics | 16:18 |
bknudson | I'd still get a visa just in case. | 16:19 |
raildo | "However, in light of the Rio 2016 Olympics, American, Australian, Canadian and Japanese nationals going to Brazil exclusively for tourism activities, entering Brazil between June 1st and September 18th, 2016, will be eligible for a 90 day, non-extendable, unilateral visa waiver counted from the first entry within that period. " | 16:19 |
bknudson | brazil might not even have a govt anymore. | 16:20 |
dstanek | my travel options to Brazil were not great the last time i looked | 16:20 |
*** lhcheng has joined #openstack-keystone | 16:20 | |
*** ChanServ sets mode: +v lhcheng | 16:20 | |
stevemar | bknudson: only for tourism | 16:20 |
*** lhcheng has quit IRC | 16:20 | |
stevemar | bknudson: if we go with toronto, then we can have a group jays game outing :P | 16:20 |
*** lhcheng has joined #openstack-keystone | 16:21 | |
*** ChanServ sets mode: +v lhcheng | 16:21 | |
bknudson | stevemar: do you still say you're coming to the us on "business"? | 16:21 |
stevemar | bknudson: "business" is OK | 16:21 |
stevemar | bknudson: "work" is OH GOD WHAT HAVE I DONE! | 16:21 |
anteaya | exactly | 16:22 |
anteaya | business only | 16:22 |
anteaya | never ever work | 16:22 |
*** ksnihyr has quit IRC | 16:22 | |
dstanek | when i went to CA, I just let them know I was only there to party | 16:22 |
bknudson | is this when you were 18? | 16:23 |
bknudson | 18-20 | 16:24 |
anteaya | dstanek: california? | 16:24 |
*** alex_xu_ has quit IRC | 16:24 | |
dstanek | anteaya: Canada | 16:24 |
dstanek | bknudson: no, pycon! | 16:24 |
dstanek | it was not a lie. there is no business or learning at pycon | 16:25 |
*** BigWillie has joined #openstack-keystone | 16:25 | |
bknudson | py is short for partay | 16:25 |
anteaya | dstanek: was nice to have you last time | 16:25 |
dstanek | anteaya: you Canadians are nice :-) | 16:26 |
anteaya | awe thank you | 16:26 |
anteaya | :) | 16:26 |
stevemar | looks like the midcycle should happen either R14, R13, R12: http://releases.openstack.org/newton/schedule.html | 16:26 |
stevemar | R12 is N2 milestone | 16:26 |
*** ebalduf_ has joined #openstack-keystone | 16:26 | |
stevemar | R13 is july 4th holiday | 16:26 |
bknudson | all the midcycles are going to be at the same time | 16:27 |
anteaya | great, neither nova nor cinder wants those weeks | 16:27 |
stevemar | anteaya: when are they doing theirs? | 16:27 |
anteaya | bknudson: no, have you read the nova and cinder threads on the mailing list? | 16:27 |
anteaya | nova wants R-15 or R-11 | 16:27 |
mordred | brazil is awesome. getting the visa for us folks is pretty easy - just use travisa | 16:27 |
bknudson | I think I'd have to go to chicago to get a visa. | 16:28 |
mordred | I recommend going ahead and getting the 5-year multiple-entry | 16:28 |
*** TxGVNN has quit IRC | 16:28 | |
mordred | bknudson: you can send your passport to the visa processing people | 16:28 |
bknudson | ah | 16:28 |
mordred | and they will handle the consulate interactions | 16:28 |
mordred | http://brazil.travisa.com/ | 16:28 |
*** stingaci has joined #openstack-keystone | 16:29 | |
anteaya | cinder want r-17, 14, 11, 10 or 9 | 16:29 |
*** alex_xu has joined #openstack-keystone | 16:30 | |
anteaya | if keystone likes 14, 13, or 12 then the only potential conflict is with cinder for 14 | 16:30 |
bknudson | "It is extremely important that the business letter includes the statement that "no technical work or assistance" will be provided during stay in Brazil." | 16:31 |
anteaya | don't flip a switch | 16:32 |
dstanek | bknudson: that's neat. i have a legal excuse to why i can't work! | 16:32 |
anteaya | or tell anyone which switch to flip | 16:32 |
anteaya | dstanek: you can type, just don't talk about it | 16:32 |
openstackgerrit | Ron De Rose proposed openstack/keystone: Concrete role assignments for federated users https://review.openstack.org/284943 | 16:32 |
dstanek | anteaya: what if my home network goes down and my wife needs help? can i provide assistance? | 16:33 |
*** lupine has quit IRC | 16:33 | |
*** lupine has joined #openstack-keystone | 16:33 | |
*** mylu has quit IRC | 16:34 | |
anteaya | yes | 16:35 |
anteaya | only via typing or texing | 16:35 |
anteaya | or emailing | 16:35 |
anteaya | if on the phone you have to be alone in a closed room | 16:35 |
openstackgerrit | Ron De Rose proposed openstack/keystone: Concrete role assignments for federated users https://review.openstack.org/284943 | 16:38 |
morgan | dstanek: ugh i dislike os x more and more | 16:39 |
dstanek | morgan: yup | 16:39 |
morgan | mordred: i think i'm going to do the brazil visa soon for $reasons$ | 16:39 |
mordred | visiting samueldmq is a good reason | 16:40 |
morgan | mordred: agreeed | 16:40 |
morgan | also because brazil | 16:40 |
raildo | as I said, on the release S, we should make the summit in Brazil and will be called "OpenStack Samba" :P | 16:41 |
dstanek | morgan: why are you still using it? | 16:42 |
morgan | dstanek: waiting for my new x1c to arrive | 16:43 |
morgan | dstanek: needed a laptop *that day*, and had a ton of apple credit | 16:43 |
morgan | a macbook retina was like $200 out of pocket | 16:43 |
morgan | :P | 16:43 |
anteaya | raildo: a summit in Brazil would be great | 16:44 |
morgan | (the core-m thing) since they had a deal going on. | 16:44 |
dstanek | morgan: wow really? i'd buy that just to put linux on it. why so cheap? | 16:44 |
raildo | anteaya: ++ | 16:44 |
morgan | dstanek: i had $1200 credit. core M is pretty anemic | 16:44 |
breton | Tickets from Moscow to Rio and back cost 1k USD :( | 16:44 |
morgan | dstanek: also i like the idea of a netbook that weighs less than 2lbs :P | 16:44 |
gyee | ++ for midcycle in brazil! | 16:44 |
morgan | breton: PDX -> Rio isn't exactly *cheap* either | 16:45 |
morgan | breton: ;) | 16:45 |
morgan | dstanek: i've been trying to install linux on it, but it's not gone well (yet) | 16:45 |
morgan | using it w/ VMs is impossible though | 16:45 |
*** doug-fish has joined #openstack-keystone | 16:46 | |
breton | morgan: and ~1d of travel too | 16:48 |
morgan | breton: yup. but #worthit if the midcycle is in brazil ;) | 16:48 |
dstanek | breton: some of my options were 30-40 hrs. travel time :-( | 16:48 |
morgan | dstanek: ouch | 16:49 |
*** mhickey has quit IRC | 16:49 | |
dstanek | that's like to Paris and back and the to Paris again :-) | 16:49 |
*** fawadkhaliq has quit IRC | 16:50 | |
gyee | dstanek, 30-40 hours? | 16:53 |
*** fawadkhaliq has joined #openstack-keystone | 16:53 | |
breton | in fact, we should have had midcycle in Brazil in mitaka, because the carnival was February 5 - February 10. | 16:53 |
lbragstad | dolphm mfisch meeting? | 16:54 |
morgan | lbragstad: meeeeeetings | 16:55 |
morgan | lbragstad: mmeeeeeeeeeeeeeeetings | 16:55 |
*** Guest15115 has quit IRC | 16:55 | |
lbragstad | just doing the dreadful | 16:55 |
openstackgerrit | Boris Bobrov proposed openstack/python-keystoneclient: Support flag `truncated` returned by identity service https://review.openstack.org/293048 | 16:55 |
openstackgerrit | Ron De Rose proposed openstack/keystone: Concrete role assignments for federated users https://review.openstack.org/284943 | 16:56 |
*** spandhe has joined #openstack-keystone | 16:57 | |
*** trown is now known as trown|lunch | 16:57 | |
*** chrisshattuck has joined #openstack-keystone | 16:59 | |
*** ksnihyr has joined #openstack-keystone | 17:04 | |
*** diazjf has quit IRC | 17:07 | |
*** raildo is now known as raildo-afk | 17:08 | |
*** browne has joined #openstack-keystone | 17:08 | |
*** diazjf has joined #openstack-keystone | 17:09 | |
*** doug-fish has quit IRC | 17:10 | |
*** doug-fish has joined #openstack-keystone | 17:11 | |
*** zqfan has quit IRC | 17:12 | |
*** doug-fish has quit IRC | 17:13 | |
morgan | hey gyee | 17:13 |
morgan | you're online! | 17:13 |
*** jistr has quit IRC | 17:15 | |
*** diazjf1 has joined #openstack-keystone | 17:15 | |
*** slberger1 has joined #openstack-keystone | 17:18 | |
lbragstad | dolphm mfisch https://review.openstack.org/#/c/241389/ | 17:18 |
patchbot | lbragstad: patch 241389 - keystone - Deprecate the pki and pkiz token providers. (MERGED) | 17:18 |
*** slberger has quit IRC | 17:18 | |
*** diazjf has quit IRC | 17:19 | |
morgan | lbragstad: ? | 17:20 |
morgan | oh | 17:20 |
morgan | hah | 17:20 |
lbragstad | morgan meetings ;) | 17:20 |
morgan | lbragstad: yah | 17:21 |
morgan | lbragstad: i realized after. | 17:21 |
*** doug-fish has joined #openstack-keystone | 17:22 | |
*** pnavarro has joined #openstack-keystone | 17:27 | |
*** doug-fish has quit IRC | 17:27 | |
*** raildo-afk is now known as raildo | 17:29 | |
openstackgerrit | ayoung proposed openstack/keystone: [WIP]Make fernet default token provider https://review.openstack.org/258650 | 17:32 |
*** aimeeU has joined #openstack-keystone | 17:34 | |
*** shaleh has joined #openstack-keystone | 17:35 | |
*** tellesnobrega_af is now known as tellesnobrega | 17:37 | |
*** doug-fish has joined #openstack-keystone | 17:39 | |
*** sdake_ has joined #openstack-keystone | 17:40 | |
*** stingaci has quit IRC | 17:41 | |
*** sdake has quit IRC | 17:43 | |
morgan | ayoung: getting close! | 17:43 |
*** pnavarro has quit IRC | 17:44 | |
*** ametts has joined #openstack-keystone | 17:45 | |
*** jaosorior has joined #openstack-keystone | 17:45 | |
morgan | dims: oh i just saw i have core on oslo.cache :P | 17:51 |
stevemar | morgan: you've had it for a while | 17:52 |
morgan | i know | 17:52 |
dims | morgan :) | 17:52 |
morgan | but.. | 17:52 |
* morgan needs to recruit more cache-saavy folks | 17:52 | |
dims | ++ morgan ! | 17:53 |
shaleh | morgan: point the rest of us at good resources :-) I am happy to become cache savvy | 17:53 |
*** sdake has joined #openstack-keystone | 17:54 | |
morgan | shaleh: hehe. we might need to chat (are you at the summit?) over a beer... or whiskey | 17:54 |
gyee | shaleh knows his whiskey | 17:54 |
*** jsavak has quit IRC | 17:55 | |
gyee | the man take his alcohol seriously | 17:55 |
*** sigmavirus24 is now known as sigmavirus24_awa | 17:55 | |
stevemar | gyee: he sounds like you! o_O | 17:56 |
gyee | hah | 17:56 |
gyee | we on the same team | 17:56 |
*** BigWillie has quit IRC | 17:56 | |
*** sdake_ has quit IRC | 17:57 | |
*** BigWillie has joined #openstack-keystone | 17:57 | |
*** trown|lunch is now known as trown | 17:57 | |
*** yarkot_ has quit IRC | 17:57 | |
samueldmq | almost that time! | 17:58 |
samueldmq | :) | 17:58 |
*** jaosorior has quit IRC | 17:59 | |
*** diazjf1 has quit IRC | 17:59 | |
*** stingaci has joined #openstack-keystone | 18:06 | |
*** jsavak has joined #openstack-keystone | 18:07 | |
*** rk4n has quit IRC | 18:09 | |
*** pnavarro has joined #openstack-keystone | 18:11 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 18:12 | |
*** pushkaru has quit IRC | 18:13 | |
ayoung | shaleh, https://review.openstack.org/#/c/290253/ care to approve or comment on the changes I made | 18:24 |
patchbot | ayoung: patch 290253 - python-openstackclient - Implied Roles | 18:24 |
shaleh | ayoung: I noticed but have not had a chance | 18:25 |
shaleh | ayoung: I will do so today. Thanks for circling back around to this. | 18:26 |
*** slberger1 has quit IRC | 18:31 | |
*** jsavak has quit IRC | 18:31 | |
*** jsavak has joined #openstack-keystone | 18:32 | |
*** pushkaru has joined #openstack-keystone | 18:34 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 18:35 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 18:35 | |
*** mvk has quit IRC | 18:37 | |
*** fawadkhaliq has quit IRC | 18:38 | |
*** fawadkhaliq has joined #openstack-keystone | 18:38 | |
*** raildo is now known as raildo-afk | 18:41 | |
*** fawadkhaliq has quit IRC | 18:43 | |
*** fawadkhaliq has joined #openstack-keystone | 18:43 | |
*** daemontool has quit IRC | 18:45 | |
*** yarkot_ has joined #openstack-keystone | 18:46 | |
*** fawadkhaliq has quit IRC | 18:52 | |
*** fawadkhaliq has joined #openstack-keystone | 18:54 | |
*** raildo-afk is now known as raildo | 18:56 | |
*** fawadkhaliq has quit IRC | 18:58 | |
*** ametts has quit IRC | 18:58 | |
*** fawadkhaliq has joined #openstack-keystone | 18:59 | |
*** fawadkhaliq has quit IRC | 19:00 | |
ayoung | RH Openstack effort started with annual team meetings in Dublin Ireland. Marc McC and Eoghan were very close to home. | 19:00 |
*** fawadkhaliq has joined #openstack-keystone | 19:01 | |
morgan | ireland is awesome | 19:01 |
morgan | so awesome | 19:01 |
morgan | i want to go back :) | 19:01 |
ayoung | raildo, http://logs.openstack.org/50/258650/35/check/gate-keystone-python34-db/299cc3c/testr_results.html.gz Fernet Passed 2.7 failed on 3.4 | 19:02 |
morgan | stevemar: next week shoud be 100% design summit planning | 19:02 |
morgan | meeting wise | 19:02 |
morgan | as a thought | 19:02 |
ayoung | morgan, agreed | 19:02 |
ayoung | morgan, do you think Keystone should have its own mailing list? I'd like to drop 90% of what is on the openstack-dev list, and maybe we should start a trend. | 19:03 |
*** diazjf has joined #openstack-keystone | 19:03 | |
morgan | ayoung: filters | 19:03 |
ayoung | and then when something goes on dev, it is really a cross project thing | 19:03 |
shaleh | ayoung: your update to the review looks good. Just needs a doc update now as per Lin's comment. | 19:03 |
ayoung | morgan, filters won't do it | 19:03 |
morgan | no keystone should not have a dedicated ML | 19:03 |
ayoung | shaleh, ah. can you take that? | 19:03 |
morgan | ayoung: i think you can subscribe to tags only | 19:03 |
morgan | in the interface | 19:03 |
shaleh | ayoung: yeah, I think so. | 19:03 |
stevemar | ayoung: use tags | 19:04 |
* morgan has actual filters based on subject too | 19:04 | |
shaleh | the OS mailing list is sooo damn painful in outlook | 19:04 |
stevemar | morgan: i will have a rough design schedule done by EOD i think, i'll send it to you for review | 19:04 |
morgan | sounds good | 19:04 |
morgan | i have *another* meeting now on tuesdays :P | 19:04 |
morgan | so end of day is solid | 19:05 |
*** shaleh is now known as shaleh|away | 19:07 | |
*** rk4n has joined #openstack-keystone | 19:09 | |
dstanek | shaleh|away: everything in painful in outlook | 19:12 |
morgan | solution: don't use outlook | 19:13 |
morgan | :P | 19:13 |
*** raildo is now known as raildo-afk | 19:14 | |
ayoung | morgan, can you look at the failure on Fernet? I did something to the cache layer, http://logs.openstack.org/50/258650/35/check/gate-keystone-python34-db/299cc3c/testr_results.html.gz Fernet Passed 2.7 failed on 3.4 | 19:14 |
morgan | ayoung: sure. was lurking in -infra meeting | 19:14 |
*** rk4n has quit IRC | 19:15 | |
morgan | ayoung: which fail specifically? | 19:15 |
ayoung | morgan, the one I was looking at was the Catalog one. Failed in the SQL read | 19:16 |
*** mylu has joined #openstack-keystone | 19:16 | |
morgan | ayoung: keystone.tests.unit.test_catalog.V2CatalogTestCase >? | 19:16 |
morgan | huh and also only failing in py3? | 19:17 |
gyee | dtroyer, so we no longer have rejoin-stack.sh, are we expected to reinstall devstack everytime now? | 19:17 |
dims | stevemar : shade is very resistant to injecting keystoneclient from git :( | 19:17 |
morgan | dims: technology wise or... people wise | 19:18 |
morgan | cause people wise, i understand the sentiment | 19:18 |
morgan | :P | 19:18 |
dims | morgan : won't go there right now :) | 19:18 |
dims | morgan : still looking at options :) | 19:18 |
morgan | hehe | 19:18 |
morgan | why does it need to be sourced from git? | 19:18 |
morgan | ayoung: uhm how did you end up with a bad PK param set? | 19:19 |
dims | well. somehow test without making a python-keystoneclient release | 19:19 |
morgan | dims: oooh | 19:19 |
morgan | uhm | 19:19 |
ayoung | morgan, because some people don't understand why we have package management systems | 19:19 |
ayoung | morgan, I suspect it was removing the caches | 19:19 |
*** fawadkhaliq has quit IRC | 19:20 | |
ayoung | but those are the token caches, and this is project. It is strange | 19:20 |
morgan | File "/home/jenkins/workspace/gate-keystone-python34-db/keystone/token/providers/common.py", line 245, in _get_filtered_project | 19:20 |
*** fawadkhaliq has joined #openstack-keystone | 19:20 | |
morgan | it's in project things | 19:20 |
ayoung | morgan, right, but I don't touch anything near that in the patch | 19:21 |
morgan | i am kindof baffled how you got this to fail in opy3 and not py2 | 19:21 |
ayoung | https://review.openstack.org/#/c/258650/35/keystone/token/provider.py is the closest, and I thin k the coe that calls it is from there | 19:21 |
patchbot | ayoung: patch 258650 - keystone - [WIP]Make fernet default token provider | 19:21 |
*** vgridnev has joined #openstack-keystone | 19:21 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Concrete role assignments for federated users https://review.openstack.org/284943 | 19:22 |
ayoung | morgan, this effort has exposed a few surprises. Fernet was not quite baked yet, I think | 19:22 |
bknudson | everybody is using fernet in production already | 19:23 |
ayoung | bknudson, I didn't say they weren't. I said it wasn't fully baked yet, and I stand behind that | 19:23 |
ayoung | there are things that were not complete. | 19:23 |
ayoung | We didn't discover until setting the default to be Fernet | 19:23 |
dims | breton : still around? was the shade problem when it was running its functional tests | 19:24 |
*** mylu has quit IRC | 19:24 | |
*** gyee has quit IRC | 19:24 | |
*** mylu has joined #openstack-keystone | 19:26 | |
*** gyee has joined #openstack-keystone | 19:26 | |
*** ChanServ sets mode: +v gyee | 19:26 | |
*** ninag has quit IRC | 19:26 | |
*** mylu has quit IRC | 19:26 | |
*** ninag has joined #openstack-keystone | 19:27 | |
morgan | ayoung: i'm guessing somehow a dict is being passed as project_id to ._get_filtered_project | 19:28 |
morgan | ayoung: which gives you too many elements to make the PK of project.id | 19:29 |
morgan | trying to find it | 19:29 |
*** ninag_ has joined #openstack-keystone | 19:30 | |
*** gyee has quit IRC | 19:31 | |
*** ninag has quit IRC | 19:31 | |
morgan | ayoung: ok so i think the only way to track this is to see what those arguments are going to need to do a little debugging, will be post next meeting | 19:33 |
*** doug-fish has quit IRC | 19:33 | |
*** mylu has joined #openstack-keystone | 19:33 | |
*** doug-fis_ has joined #openstack-keystone | 19:35 | |
*** doug-fis_ has quit IRC | 19:36 | |
*** mylu has quit IRC | 19:36 | |
*** mvk has joined #openstack-keystone | 19:36 | |
*** doug-fis_ has joined #openstack-keystone | 19:36 | |
*** doug-fis_ has quit IRC | 19:36 | |
*** mylu has joined #openstack-keystone | 19:36 | |
*** doug-fis_ has joined #openstack-keystone | 19:36 | |
ayoung | morgan, let me see if I can reproduce | 19:38 |
*** doug-fish has joined #openstack-keystone | 19:38 | |
morgan | ayoung: sounds good. fwiw it looks like you're just getting the wrong values for the project_id | 19:39 |
morgan | somehow. | 19:39 |
*** ninag_ has quit IRC | 19:40 | |
*** doug-fis_ has quit IRC | 19:41 | |
*** ninag has joined #openstack-keystone | 19:41 | |
ayoung | dstanek, running just one unit test in py34 does not work the same as py27? | 19:41 |
ayoung | tox -e py34 -- keystone.tests.unit.test_auth.AuthCatalog.test_validate_catalog_disabled_endpoint | 19:41 |
*** spzala has quit IRC | 19:42 | |
*** doug-fish has quit IRC | 19:42 | |
*** spzala has joined #openstack-keystone | 19:43 | |
*** spzala has quit IRC | 19:43 | |
breton | dims: it was shade, yes. We haven't figured out what's the problem they had. | 19:44 |
*** ninag has quit IRC | 19:45 | |
ayoung | morgan, OK, I can reproduce. Had to activate the py34 venv in .tox and then ran | 19:45 |
ayoung | python setup.py testr --testr-args="keystone.tests.unit.test_auth.AuthCatalog.test_validate_catalog_disabled_endpoint" | 19:45 |
ayoung | File "/opt/stack/keystone/keystone/token/providers/common.py", line 516, in get_token_data looks like it was near where I was messing with things | 19:46 |
morgan | ayoung: yeah | 19:47 |
ayoung | morgan, OK, I bet I called that function wrong | 19:47 |
ayoung | File "/opt/stack/keystone/keystone/token/providers/common.py", line 775, in validate_non_persistent_token | 19:47 |
bknudson | https://review.openstack.org/#/c/304837/ in openstack/requirements should fix keystone's requirements update troubles. | 19:48 |
patchbot | bknudson: patch 304837 - requirements - Fix update to support extras | 19:48 |
ayoung | (user_id, methods, audit_ids, domain_id, project_id, trust_id, | 19:48 |
ayoung | federated_info, access_token_id, created_at, expires_at) = ( | 19:48 |
ayoung | self.token_formatter.validate_token(token_id)) | 19:48 |
*** e0ne has quit IRC | 19:48 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: WIP - Drop EPHEMERAL user type https://review.openstack.org/296639 | 19:49 |
*** shaleh|away is now known as shaleh | 19:49 | |
bknudson | oh, jamielennox has a fix already | 19:49 |
shaleh | ayoung: have a moment for a side convo regarding the OSC changes? | 19:50 |
*** daemontool has joined #openstack-keystone | 19:50 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 19:50 | |
ayoung | shaleh, sure, but I'm pretty easy there. If you have a change to make, I'm probably down with ti. | 19:50 |
ayoung | What's up | 19:50 |
openstackgerrit | Ron De Rose proposed openstack/keystone: WIP - Drop EPHEMERAL user type https://review.openstack.org/296639 | 19:51 |
ayoung | shaleh, Keystone love noise. | 19:52 |
ayoung | Have the convo here | 19:52 |
shaleh | fair enough | 19:52 |
shaleh | ayoung: the patch is missing the most important part -- what the command line itself is called | 19:53 |
*** raildo-afk is now known as raildo | 19:53 | |
shaleh | ayoung: I am thinking "osc role implied add/delete | 19:53 |
ayoung | shaleh, I thought it did that already | 19:53 |
ayoung | what does the test show? | 19:53 |
shaleh | ayoung: heh. If you do not add it to setup.cfg it does not exist. | 19:53 |
shaleh | ayoung: no entry point no way in | 19:54 |
ayoung | shaleh, entrypoint? | 19:54 |
shaleh | the class names are irrelevant | 19:54 |
ayoung | I thought it was on the role entrypoint | 19:54 |
ayoung | OK | 19:54 |
ayoung | make it happen! | 19:54 |
*** mylu has quit IRC | 19:54 | |
shaleh | ayoung: I was giving you a chance to bikeshed | 19:54 |
ayoung | shaleh, Bikes stay in the Garage | 19:54 |
shaleh | ayoung: I prefer add/delete for the CLI over "create" since the roles exist we are just adding them together | 19:55 |
*** diazjf has quit IRC | 19:55 | |
*** yarkot_ has quit IRC | 19:55 | |
ayoung | shaleh, I'm really not picky on that. I can get behind add/delete | 19:55 |
*** mylu has joined #openstack-keystone | 19:55 | |
shaleh | ayoung: k | 19:55 |
*** doug-fish has joined #openstack-keystone | 19:56 | |
roxanaghe | hey morgan | 19:57 |
*** rk4n has joined #openstack-keystone | 19:57 | |
roxanaghe | morgan, you mind giving me some feedback on some initial implementation of ldap3 mock | 19:57 |
roxanaghe | morgan, I want to make sure I'm on the right track | 19:58 |
*** diazjf has joined #openstack-keystone | 19:58 | |
ayoung | roxanaghe, if the tests still run, and we can remove python-ldap, you are on the right track | 19:58 |
roxanaghe | morgan, https://github.com/roxanagherle/ldap3/blob/master/ldap3/strategy/mockSync.py this is what I have so far and it works for the read-only operations that we support | 19:59 |
roxanaghe | ayoung, hehe yeah that's the plan | 19:59 |
ayoung | roxanaghe, looking | 20:00 |
morgan | roxanaghe: sure when i'm done with my next meeting | 20:00 |
*** tqtran has joined #openstack-keystone | 20:00 | |
ayoung | roxanaghe, FreeIPA is leaving its stamp on ldap3 I see... | 20:00 |
morgan | roxanaghe: also yay! :) | 20:00 |
*** mylu has quit IRC | 20:01 | |
*** jsavak has quit IRC | 20:01 | |
*** mylu has joined #openstack-keystone | 20:02 | |
ayoung | roxanaghe, so probably should check to see if they do any mocking likethis already, and if they do, mathc what they use for the DN...probably Example.com. I'd refacto to have the common strings like that definied once at the top of the file and easy to swap | 20:03 |
*** diazjf has quit IRC | 20:03 | |
ayoung | but the idea is cool; have a standard, read only dataset available from the mock side of the library. I could see that being a big success | 20:03 |
*** jsavak has joined #openstack-keystone | 20:04 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 20:05 | |
roxanaghe | ayoung, yes, I was using that FreeIpa demo server for testing, so I got those answers as my mock dataset | 20:07 |
*** mylu has quit IRC | 20:07 | |
roxanaghe | ayoung, you mean if ldap3 is doing any mocking of this sort? | 20:07 |
*** slberger has joined #openstack-keystone | 20:08 | |
roxanaghe | ayoung, oh I misunderstood, you referring to the mock DN | 20:09 |
*** mylu has joined #openstack-keystone | 20:09 | |
shaleh | ayoung: I was just telling her that if the MockSync took the dataset as input it would be even better. It could fall back to the default dataset if one is not provided. | 20:09 |
*** jsavak has quit IRC | 20:11 | |
*** fawadkhaliq has quit IRC | 20:11 | |
*** fawadkhaliq has joined #openstack-keystone | 20:12 | |
*** mylu has quit IRC | 20:12 | |
*** jsavak has joined #openstack-keystone | 20:12 | |
*** mylu has joined #openstack-keystone | 20:14 | |
*** anush_ has quit IRC | 20:17 | |
*** anush_ has joined #openstack-keystone | 20:18 | |
openstackgerrit | Navid Pustchi proposed openstack/keystoneauth: Removing tox ignore D401 and make it compliant https://review.openstack.org/304843 | 20:19 |
shaleh | ayoung: is there no way in the keystoneclient to call GET /roles/{prior_role_id}/implies?? | 20:20 |
*** mylu has quit IRC | 20:21 | |
openstackgerrit | Navid Pustchi proposed openstack/keystoneauth: Removing tox ignore D401 and make it compliant https://review.openstack.org/304843 | 20:24 |
*** tellesnobrega is now known as tellesnobrega_af | 20:28 | |
*** anush_ has quit IRC | 20:29 | |
*** aimeeU has quit IRC | 20:31 | |
*** mylu has joined #openstack-keystone | 20:31 | |
*** mylu has quit IRC | 20:33 | |
*** yarkot_ has joined #openstack-keystone | 20:35 | |
*** mylu has joined #openstack-keystone | 20:36 | |
*** mylu has quit IRC | 20:40 | |
*** spzala has joined #openstack-keystone | 20:46 | |
*** mylu has joined #openstack-keystone | 20:47 | |
*** gyee has joined #openstack-keystone | 20:47 | |
*** ChanServ sets mode: +v gyee | 20:47 | |
*** BigWillie has quit IRC | 20:48 | |
*** mvk_ has joined #openstack-keystone | 20:49 | |
*** spzala has quit IRC | 20:50 | |
*** mylu has quit IRC | 20:51 | |
*** e0ne has joined #openstack-keystone | 20:52 | |
*** mvk has quit IRC | 20:53 | |
*** doug-fish has quit IRC | 20:58 | |
*** diazjf has joined #openstack-keystone | 20:58 | |
*** doug-fish has joined #openstack-keystone | 20:59 | |
*** diazjf has quit IRC | 20:59 | |
*** pauloewerton has quit IRC | 21:01 | |
*** doug-fis_ has joined #openstack-keystone | 21:01 | |
*** phalmos has quit IRC | 21:02 | |
*** mylu has joined #openstack-keystone | 21:02 | |
*** fawadkhaliq has quit IRC | 21:03 | |
*** doug-fish has quit IRC | 21:03 | |
*** mylu has quit IRC | 21:03 | |
*** fawadkhaliq has joined #openstack-keystone | 21:03 | |
*** jsavak has quit IRC | 21:05 | |
*** mylu has joined #openstack-keystone | 21:05 | |
*** sdake has quit IRC | 21:05 | |
*** jsavak has joined #openstack-keystone | 21:05 | |
*** ametts has joined #openstack-keystone | 21:06 | |
*** raildo is now known as raildo-afk | 21:06 | |
dims | mordred : stevemar : morgan : managed to run shade with python-keystone from git i think (http://logs.openstack.org/33/304833/2/check/gate-shade-dsvm-functional-keystone2/623a103/console.html#_2016-04-12_20_25_57_427) | 21:06 |
mordred | dims: woot! | 21:06 |
stevemar | nice | 21:06 |
stevemar | dims: what magic? | 21:06 |
morgan | black magic | 21:07 |
morgan | voodoo magic? | 21:07 |
dims | hack tox.ini https://review.openstack.org/#/c/304833/ | 21:07 |
patchbot | dims: patch 304833 - openstack-infra/shade - [WIP] Test with a python-keystoneclient change fro... | 21:07 |
morgan | dims: oh my | 21:07 |
stevemar | hmmm | 21:07 |
dims | i have to check if the https://review.openstack.org/#/c/293048 actually got applied properly | 21:08 |
*** spzala has joined #openstack-keystone | 21:08 | |
morgan | roxanaghe: here now looking at your code stuff | 21:08 |
morgan | roxanaghe: :) | 21:08 |
*** sdake has joined #openstack-keystone | 21:08 | |
breton | dims: it would be more interesting to run this with https://review.openstack.org/#/c/280162/ | 21:09 |
patchbot | breton: patch 280162 - python-keystoneclient - Support `truncated` flag returned by identity service (MERGED) | 21:09 |
*** mylu has quit IRC | 21:09 | |
breton | dims: (it was reverted because it broke shade) | 21:09 |
*** mylu has joined #openstack-keystone | 21:09 | |
morgan | also nice on the standard mock dataset | 21:10 |
dims | breton : ack | 21:10 |
dims | breton : let me try that | 21:10 |
breton | in fact, i was almost sure that https://review.openstack.org/#/c/293048 won't break anything because it adds new methods and doesn't change existing | 21:10 |
*** jsavak has quit IRC | 21:11 | |
dims | breton: you are tight | 21:11 |
dims | right :) | 21:11 |
*** mylu has quit IRC | 21:11 | |
*** trown is now known as trown|outtypewww | 21:11 | |
morgan | dolphm: do you have phone # things for geekdom sf? i have tried to use their form and it errors. | 21:12 |
bknudson | we had the security meetup at geekdom sf and it worked pretty well. | 21:14 |
*** ninag has joined #openstack-keystone | 21:16 | |
bknudson | lots of hipsters around there, though, so watch out. | 21:16 |
*** fawadkhaliq has quit IRC | 21:18 | |
*** fawadkhaliq has joined #openstack-keystone | 21:18 | |
ayoung | shaleh, did I miss that? I might have. | 21:18 |
*** mylu has joined #openstack-keystone | 21:18 | |
ayoung | I thought I covered all the use cases. I'd have to look, though. | 21:19 |
*** e0ne has quit IRC | 21:20 | |
*** ninag has quit IRC | 21:20 | |
ayoung | lbragstad, so, the dissassemble and assemble methods on the token_formatters should not work in tuples. The list is too long, and too accident prone. It should be using the token model objects. | 21:20 |
ayoung | I'm not sure if that is the python3 problem, but I would not be surprised. | 21:21 |
lbragstad | ayoung I think the reason why we did that is because the payload types were all accepting different arguments depending on which payload was assembling the token | 21:22 |
lbragstad | ayoung then bknudson refactored it so that they all take the same arguments | 21:22 |
bknudson | lbragstad: ayoung: it would be great if they worked with token model objects. | 21:23 |
ayoung | lbragstad, lbragstad the degree to which this code base is allergic to basic OO techniques has always astounded me | 21:23 |
lbragstad | ayoung bknudson so - how would we go about that change | 21:23 |
bknudson | it used to be they all took different arguments and there was a switch. | 21:23 |
lbragstad | yeach | 21:23 |
ayoung | bknudson, it might happen in Newton. | 21:23 |
lbragstad | if, elif, elif, elif, elif.... else.... | 21:24 |
lbragstad | it was a huge case statement | 21:24 |
ayoung | Its ok, we have the model now. I could rework it, but I want to potentially backport the fernet fixes | 21:24 |
lbragstad | s/case/if/ | 21:24 |
ayoung | so a refactoring like that might be too much to do up front. | 21:24 |
bknudson | fix the bugs first | 21:25 |
lbragstad | ayoung do you just want to pass the token model to the assemble method? | 21:25 |
*** e0ne has joined #openstack-keystone | 21:25 | |
ayoung | lbragstad, yeah,that is how It will look post refactor | 21:25 |
lbragstad | a token model object* | 21:25 |
ayoung | lbragstad, same thing with the revocation code | 21:25 |
ayoung | there was a reason I was proposing a builder pattern for this. Lots of things need to construct the auth data | 21:26 |
ayoung | but jamielennox and I had differernt views. His was optimized for reading the token verified data out of JSON for the client use case. I would have just marshalled right to Python. | 21:26 |
ayoung | however, oslo context happended first. | 21:27 |
ayoung | thing is, this code passes in python 27, it is just 34 that is wonky. time to debug | 21:27 |
openstackgerrit | Navid Pustchi proposed openstack/keystoneauth: Removing tox ignore D401 and make it compliant https://review.openstack.org/304843 | 21:27 |
*** ninag has joined #openstack-keystone | 21:27 | |
*** e0ne has quit IRC | 21:27 | |
lbragstad | ayoung what's the issue with it in py34? | 21:28 |
ayoung | lbragstad, I'll link... | 21:28 |
*** c_soukup has quit IRC | 21:28 | |
*** ninag has quit IRC | 21:28 | |
ayoung | File "/opt/stack/keystone/keystone/token/providers/common.py", line 775, in validate_non_persistent_token | 21:28 |
*** ninag has joined #openstack-keystone | 21:28 | |
ayoung | lbragstad, some of the tests are failing. I traced it to here | 21:28 |
ayoung | the failing tests are | 21:29 |
ayoung | http://logs.openstack.org/50/258650/35/check/gate-keystone-python34-db/299cc3c/testr_results.html.gz | 21:29 |
ayoung | look for keystone.tests.unit.test_auth.AuthCatalog | 21:29 |
ayoung | if you look at the stack trace, the final error indicates it got passed a back project.id | 21:30 |
ayoung | I think that the code here is improprely marshalling | 21:30 |
*** lhcheng has quit IRC | 21:37 | |
*** sheel has quit IRC | 21:37 | |
*** ninag has quit IRC | 21:37 | |
ayoung | lbragstad, it might be that it was code never tested before. The project.id value is b'bar' so I would think that sqlalchemy should accept it | 21:38 |
*** ninag has joined #openstack-keystone | 21:38 | |
*** ninag has quit IRC | 21:38 | |
*** ninag has joined #openstack-keystone | 21:39 | |
ayoung | but python3 should not be voting yet, should it? Or do we just comment out the ldap code for python3? | 21:39 |
*** ksnihyr has quit IRC | 21:41 | |
lbragstad | hmmm | 21:45 |
lbragstad | this - sqlalchemy.exc.InvalidRequestError: Incorrect number of values in identifier to formulate primary key for query.get(); primary key columns are 'project.id' | 21:46 |
lbragstad | how would that fail for py34 but not for py27? | 21:46 |
lbragstad | I feel like it should marshall the same regardless | 21:46 |
*** ayoung has quit IRC | 21:46 | |
*** lhcheng has joined #openstack-keystone | 21:46 | |
*** ChanServ sets mode: +v lhcheng | 21:46 | |
*** lhcheng_ has joined #openstack-keystone | 21:47 | |
*** lhcheng has quit IRC | 21:47 | |
*** eandersson_ has quit IRC | 21:47 | |
*** vgridnev has quit IRC | 21:47 | |
*** knikolla has quit IRC | 21:50 | |
*** sdake_ has joined #openstack-keystone | 21:53 | |
*** mylu has quit IRC | 21:53 | |
*** pushkaru has quit IRC | 21:54 | |
*** sdake has quit IRC | 21:54 | |
*** browne has quit IRC | 22:03 | |
*** mylu has joined #openstack-keystone | 22:04 | |
*** sdake has joined #openstack-keystone | 22:04 | |
*** sdake_ has quit IRC | 22:06 | |
*** gordc has quit IRC | 22:07 | |
*** knikolla has joined #openstack-keystone | 22:11 | |
*** mylu has quit IRC | 22:12 | |
*** mylu has joined #openstack-keystone | 22:13 | |
*** ninag has quit IRC | 22:13 | |
*** ninag has joined #openstack-keystone | 22:14 | |
*** ninag has quit IRC | 22:14 | |
*** doug-fis_ has quit IRC | 22:14 | |
*** ninag has joined #openstack-keystone | 22:14 | |
*** fawadkhaliq has quit IRC | 22:16 | |
*** fawadkhaliq has joined #openstack-keystone | 22:16 | |
*** ninag has quit IRC | 22:19 | |
*** slberger has left #openstack-keystone | 22:20 | |
*** anush_ has joined #openstack-keystone | 22:21 | |
*** pnavarro has quit IRC | 22:22 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:23 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 22:24 | |
*** sdake has quit IRC | 22:25 | |
*** rk4n has quit IRC | 22:29 | |
*** chrisshattuck has quit IRC | 22:30 | |
*** chrisshattuck has joined #openstack-keystone | 22:31 | |
*** ayoung has joined #openstack-keystone | 22:31 | |
*** ChanServ sets mode: +v ayoung | 22:31 | |
*** gordc has joined #openstack-keystone | 22:32 | |
*** stingaci has quit IRC | 22:32 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:34 | |
*** ninag has joined #openstack-keystone | 22:37 | |
*** lhcheng_ has quit IRC | 22:37 | |
*** ametts has quit IRC | 22:37 | |
breton | dims: nope, something is wrong with https://review.openstack.org/#/c/304833/3. It should fail! | 22:38 |
patchbot | breton: patch 304833 - openstack-infra/shade - [WIP] Test with a python-keystoneclient change fro... | 22:38 |
*** chrisshattuck has quit IRC | 22:39 | |
*** chrisshattuck has joined #openstack-keystone | 22:40 | |
*** ninag has quit IRC | 22:41 | |
*** gordc has quit IRC | 22:44 | |
*** ebalduf_ has quit IRC | 22:47 | |
*** stingaci has joined #openstack-keystone | 22:48 | |
*** lhcheng has joined #openstack-keystone | 22:48 | |
*** ChanServ sets mode: +v lhcheng | 22:48 | |
*** mylu has quit IRC | 22:50 | |
*** mylu has joined #openstack-keystone | 22:52 | |
*** anush_ has quit IRC | 22:53 | |
*** mylu has quit IRC | 23:01 | |
*** browne has joined #openstack-keystone | 23:01 | |
*** mylu has joined #openstack-keystone | 23:01 | |
*** edmondsw has quit IRC | 23:01 | |
*** bknudson has left #openstack-keystone | 23:02 | |
*** BjoernT has quit IRC | 23:03 | |
roxanaghe | morgan, I'm back too | 23:03 |
roxanaghe | morgan, what did you think? | 23:03 |
*** spzala has quit IRC | 23:08 | |
*** spzala has joined #openstack-keystone | 23:08 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/300626 | 23:09 |
*** jamielennox is now known as jamielennox|away | 23:09 | |
*** spzala has quit IRC | 23:13 | |
*** bknudson has joined #openstack-keystone | 23:13 | |
*** ChanServ sets mode: +v bknudson | 23:13 | |
*** jamielennox|away is now known as jamielennox | 23:13 | |
*** fawadkhaliq has quit IRC | 23:13 | |
*** fawadkhaliq has joined #openstack-keystone | 23:14 | |
morgan | roxanaghe: got distracted with late lunch. | 23:18 |
morgan | ;) | 23:18 |
*** sdake has joined #openstack-keystone | 23:18 | |
roxanaghe | morgan, no worries - whenever you have time | 23:19 |
*** chrisshattuck has quit IRC | 23:22 | |
*** stingaci has quit IRC | 23:24 | |
*** timcline has quit IRC | 23:26 | |
dims | breton : the patch did not get applied. | 23:29 |
morgan | mfisch: dunno if you're around.. but........... wanted to talk caching | 23:45 |
*** stingaci has joined #openstack-keystone | 23:45 | |
morgan | gyee: pssst press "go" on this https://review.openstack.org/#/c/303688/1/doc/source/auth-totp.rst | 23:45 |
patchbot | morgan: patch 303688 - keystone - fix typo | 23:45 |
*** anush_ has joined #openstack-keystone | 23:50 | |
*** sdake has quit IRC | 23:50 | |
*** dan_nguyen has quit IRC | 23:52 | |
*** tqtran has quit IRC | 23:53 | |
*** Raildo has joined #openstack-keystone | 23:54 | |
*** yarkot_ has quit IRC | 23:55 | |
*** Raildo_ has joined #openstack-keystone | 23:55 | |
*** browne has quit IRC | 23:58 | |
*** Raildo has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!