Monday, 2016-10-17

*** haplo37_ has quit IRC00:12
*** haplo37_ has joined #openstack-keystone00:14
*** _d34dh0r53_ is now known as d34dh0r5300:18
*** markvoelker_ has quit IRC00:18
*** hoangcx has joined #openstack-keystone00:39
*** david_cu has joined #openstack-keystone00:55
*** guoshan has quit IRC00:57
openstackgerritGeorge Tian proposed openstack/keystone: Code cleanup  https://review.openstack.org/38479801:07
*** guoshan has joined #openstack-keystone01:22
*** wangqun has joined #openstack-keystone01:37
*** davechen has joined #openstack-keystone01:50
*** wangqun_ has joined #openstack-keystone02:45
*** wangqun has quit IRC02:47
*** code-R has joined #openstack-keystone03:06
*** kiran-r has joined #openstack-keystone03:12
openstackgerritDave Chen proposed openstack/keystone: [api-ref] Fix couple of issues on OS-INHERIT API  https://review.openstack.org/38712903:15
davechenrodrigods: low handing fruit after reviewing your patch ;)03:17
*** code-R_ has joined #openstack-keystone03:17
*** code-R has quit IRC03:18
*** code-R_ has quit IRC03:18
*** code-R has joined #openstack-keystone03:18
*** kiran-r has quit IRC03:29
*** chlong has joined #openstack-keystone03:30
*** kiran-r has joined #openstack-keystone03:39
*** code-R has quit IRC03:44
*** dave-mccowan has quit IRC03:51
*** code-R has joined #openstack-keystone04:04
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements  https://review.openstack.org/38713804:06
*** guoshan has quit IRC04:07
*** TonyXu has joined #openstack-keystone04:09
*** adriant has quit IRC04:34
openstackgerritayoung proposed openstack/keystone: Refactor assert_admin move to authorization  https://review.openstack.org/38715104:59
openstackgerritayoung proposed openstack/keystone: Refactor Authorization move _build_policy_check_credentials to authorization.py  https://review.openstack.org/38715204:59
openstackgerritayoung proposed openstack/keystone: Move more authorization functions to authorization.py  https://review.openstack.org/38715304:59
openstackgerritayoung proposed openstack/keystone: Refactor authorization move filterprotected to authorization.py  https://review.openstack.org/38715404:59
openstackgerritayoung proposed openstack/keystone: moved get_token_ref to authorization  https://review.openstack.org/38715504:59
openstackgerritayoung proposed openstack/keystone: Refactoring authorization.  Merge logic into check_policy, made decorator functions identical  https://review.openstack.org/38715604:59
openstackgerritayoung proposed openstack/keystone: Refactoring Authorization.  Unified decorator functions.  https://review.openstack.org/38715704:59
openstackgerritayoung proposed openstack/keystone: Refactor Authorization: Pep8 cleanup  https://review.openstack.org/38715804:59
*** sheel has joined #openstack-keystone05:00
openstackgerritayoung proposed openstack/keystone: Refactor Authorziation:  https://review.openstack.org/38716105:03
openstackgerritPraveen N proposed openstack/keystone: changed domain id to name in JSON request  https://review.openstack.org/38716205:06
openstackgerritayoung proposed openstack/keystone: Refactor Authorization:  https://review.openstack.org/38716105:06
openstackgerritJamie Lennox proposed openstack/keystone: Allow fetching an expired token  https://review.openstack.org/38209805:15
*** gsilvis has quit IRC05:17
*** qwertyco has joined #openstack-keystone05:29
*** gsilvis has joined #openstack-keystone05:35
*** jaosorior has joined #openstack-keystone05:48
*** rcernin has joined #openstack-keystone06:06
openstackgerritMerged openstack/keystone: Updated from global requirements  https://review.openstack.org/38713806:19
bretonmorning, keystone06:33
*** LiYuenan has joined #openstack-keystone06:37
LiYuenanHello everyone! I am Yuenan Li. I have a question about keystone fernet key. When I deploy keystone, did I need initialize Fernet key repositories in all controller nodes? And how about bootstrap the Identity service?06:40
bretonyou need to initialize fernet key repo on 1 controller node and then copy the keys to all other nodes.06:44
bretoni don't understand the question about bootstrap :)06:44
LiYuenandid i need bootstrap in a controller node or in every controller nodes?06:46
odyssey4meLiYuenan just one - all the bootstrap does it setup the initial admin role, service, etc so that you can from then on interact with the API06:53
*** aloga has joined #openstack-keystone06:57
LiYuenanOh. When I deploy openstack newton keystone, I find that mitaka only need initialize Fernet key repositories once:# keystone-manage fernet_setup --keystone-user keystone --keystone-group keystone  But newton need twice06:58
LiYuenan# keystone-manage fernet_setup --keystone-user keystone --keystone-group keystone06:59
LiYuenan# keystone-manage credential_setup --keystone-user keystone --keystone-group keystone06:59
*** tesseract has joined #openstack-keystone07:03
*** tesseract is now known as Guest2107707:04
davechenLiYuenan: since in newton we use fernet key for credential encryption, the second command you list above.07:04
LiYuenanI appreciate your help :)07:06
*** amoralej|off is now known as amoralej07:16
*** kiran-r has quit IRC07:27
*** openstackgerrit has quit IRC07:34
*** openstackgerrit has joined #openstack-keystone07:34
LiYuenandavechen: When I run #keystone-manage credential_setup --keystone-user keystone --keystone-group keystone07:47
LiYuenanusage: keystone-manage [bootstrap|db_sync|db_version|domain_config_upload|fernet_rotate|fernet_setup|mapping_purge|mapping_engine|pki_setup|saml_idp_metadata|ssl_setup|token_flush]07:47
LiYuenankeystone-manage: error: argument command: invalid choice: 'credential_setup' (choose from 'bootstrap', 'db_sync', 'db_version', 'domain_config_upload', 'fernet_rotate', 'fernet_setup', 'mapping_purge', 'mapping_engine', 'pki_setup', 'saml_idp_metadata', 'ssl_setup', 'token_flush')07:47
davechenLiYuenan: update your code base.07:51
*** rvba has quit IRC07:54
LiYuenanI07:54
LiYuenandavechen: I will try in a docker07:55
LiYuenandavechen: I should copy /etc/keystone/fernet-keys to other controller nodes?07:56
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-keystone08:01
*** qwertyco has quit IRC08:10
davechenLiYuenan: I haven't try it in the doker with multiple controller, but I think you should do that.08:19
*** TonyXu has quit IRC08:20
*** TonyXu has joined #openstack-keystone08:22
*** mkoshiya has joined #openstack-keystone08:29
*** pnavarro has joined #openstack-keystone08:30
*** davechen has left #openstack-keystone08:31
*** voelzmo has joined #openstack-keystone08:31
*** voelzmo has quit IRC08:32
*** pjm6 has joined #openstack-keystone08:33
mkoshiyaHi, all. Could you please review bp/return-request-id-to-caller - https://review.openstack.org/#/c/261188/ , and bp/log-request-id - https://review.openstack.org/#/c/352858/ .08:48
mkoshiyahttps://review.openstack.org/#/c/261188/ has already got a Code-Review +1 in the previous Patch Set.08:50
*** code-R has quit IRC08:52
*** pcaruana has joined #openstack-keystone09:08
*** flwang1 has joined #openstack-keystone09:15
*** mkoshiya has quit IRC09:15
flwang1hi there, any idea for error "keystoneauth1.exceptions.auth.AuthorizationFailure: Authorization failed: You are not authorized to perform the requested action. (HTTP 403) (Request-ID: req-3a6495b2-664d-4c35-9154-5d4c9b8f1eba)" ?09:16
*** chlong has quit IRC09:26
*** nishaYadav has joined #openstack-keystone09:29
nishaYadavhey all!09:30
nishaYadavhey samueldmq09:39
*** jaosorior has quit IRC09:41
*** jaosorior has joined #openstack-keystone09:42
samueldmqnishaYadav: hi09:42
samueldmqhi keystone09:42
*** code-R has joined #openstack-keystone09:45
*** code-R_ has joined #openstack-keystone09:46
*** wangqun_ has quit IRC09:49
*** code-R has quit IRC09:49
*** asettle has joined #openstack-keystone09:58
*** asettle has quit IRC10:05
*** hoangcx has quit IRC10:27
*** asettle has joined #openstack-keystone10:30
*** haplo37_ has quit IRC10:44
*** guoshan has joined #openstack-keystone10:45
*** nishaYadav has quit IRC10:46
*** haplo37_ has joined #openstack-keystone10:46
*** nishaYadav has joined #openstack-keystone10:48
*** nishaYadav is now known as Guest4543810:49
*** Guest45438 is now known as nishaYadav_10:49
*** voelzmo has joined #openstack-keystone10:52
*** voelzmo has quit IRC11:02
*** voelzmo has joined #openstack-keystone11:06
*** nicolasbock has joined #openstack-keystone11:09
*** asettle has quit IRC11:11
*** asettle has joined #openstack-keystone11:16
*** asettle has quit IRC11:23
*** dave-mccowan has joined #openstack-keystone11:30
*** GB21 has joined #openstack-keystone11:35
*** guoshan has quit IRC11:47
*** twouters has left #openstack-keystone11:56
*** nishaYadav_ has quit IRC12:01
*** pece has joined #openstack-keystone12:02
*** edmondsw has joined #openstack-keystone12:06
*** amoralej is now known as amoralej|lunch12:11
*** raildo has joined #openstack-keystone12:11
*** maticue has joined #openstack-keystone12:16
*** Guest23990 is now known as zigo12:21
*** admin0 has joined #openstack-keystone12:22
admin0hey all .. what does “BadRequest: Expecting to find domain in user - the server could not comply with the request since it is either malformed or otherwise incorrect” mean ?12:22
*** asettle has joined #openstack-keystone12:38
*** sileht has quit IRC12:42
*** sileht has joined #openstack-keystone12:50
*** GB21 has quit IRC12:58
*** voelzmo has quit IRC13:04
*** voelzmo has joined #openstack-keystone13:05
*** pcaruana has quit IRC13:18
*** jperry has joined #openstack-keystone13:23
lbragstadLiYuenan by default, both fernet repositories are kept separate13:30
lbragstadLiYuenan on is used for token encryption and decryption, while the other is used for credential encryption and decryption.13:31
lbragstadLiYuenan if you haven't made any changes to your `keystone.conf [fernet_tokens] key_repository` value, `keystone-manage fernet_setup` will automatically populate `/etc/keystone/fernet-keys/` with keys - https://github.com/openstack/keystone/blob/master/etc/keystone.conf.sample#L888-L90913:34
lbragstadLiYuenan it will do the same thing with `keystone-manage credential-setup` but it will use `/etc/keystone/credential-keys/`13:34
lbragstadLiYuenan both of these repositories will need to be securely copied to all keystone nodes in your deployment. LiYuenan13:35
*** agireud has quit IRC13:35
*** agireud has joined #openstack-keystone13:39
*** guoshan has joined #openstack-keystone13:46
*** voelzmo has quit IRC13:50
dolphmstevemar: this requires PTL acknowledgement https://review.openstack.org/#/c/387447/13:51
*** voelzmo has joined #openstack-keystone13:51
*** voelzmo has quit IRC13:53
*** voelzmo has joined #openstack-keystone13:53
*** asettle has quit IRC14:02
*** haplo37_ has quit IRC14:02
*** gagehugo has joined #openstack-keystone14:03
*** amoralej|lunch is now known as amoralej14:03
*** hogepodge has quit IRC14:04
openstackgerritabdul nizamuddin proposed openstack/pycadf: Changed the home-page link  https://review.openstack.org/38745514:04
*** haplo37_ has joined #openstack-keystone14:05
lbragstadLiYuenan I did short write up of key management for credential encryption - https://gist.github.com/lbragstad/ddfb10f9f9048414d1f781ba006e95d1#encrypted-credential-key-management14:06
*** sc68cal_ is now known as sc68cal14:10
*** sheel has quit IRC14:10
*** chris_hultin|AWA is now known as chris_hultin14:19
*** guoshan has quit IRC14:26
*** mfisch` is now known as mfisch14:30
*** mfisch is now known as Guest5621814:30
*** michauds has joined #openstack-keystone14:31
*** richm has joined #openstack-keystone14:31
openstackgerritAlvaro Lopez Garcia proposed openstack/keystoneauth: oidc: fix OpenID Connect authorization code grant_type  https://review.openstack.org/33000614:34
*** guoshan has joined #openstack-keystone14:35
*** nkinder has joined #openstack-keystone14:35
openstackgerritLance Bragstad proposed openstack/keystone: Use issue_v3_token instead of issue_v2_token  https://review.openstack.org/38666514:37
openstackgerritLance Bragstad proposed openstack/keystone: refactor the token controller  https://review.openstack.org/38672614:37
*** asettle has joined #openstack-keystone14:37
openstackgerritLance Bragstad proposed openstack/keystone: Remove issue_v2_token  https://review.openstack.org/38676214:38
openstackgerritLance Bragstad proposed openstack/keystone: Remove issue_v3_token in favor of issue_token  https://review.openstack.org/38683714:42
*** asettle has quit IRC14:44
*** ravelar has joined #openstack-keystone14:46
knikolla_o/14:51
*** Ephur has joined #openstack-keystone14:53
openstackgerritAlvaro Lopez Garcia proposed openstack/keystone-specs: OpenID Connect improved support  https://review.openstack.org/37398314:54
openstackgerritGage Hugo proposed openstack/keystone-specs: PCI-DSS Expired Password Users  https://review.openstack.org/38383214:58
*** guoshan has quit IRC15:01
*** pcaruana has joined #openstack-keystone15:03
*** voelzmo has quit IRC15:03
*** jlwhite has quit IRC15:03
*** antwash has quit IRC15:04
*** knikolla_ has quit IRC15:09
*** mvk has quit IRC15:09
*** knikolla has joined #openstack-keystone15:11
*** jlwhite has joined #openstack-keystone15:12
*** antwash has joined #openstack-keystone15:13
bknudsonodd thing in v2 tokens:15:18
bknudson"expires": "2016-10-17T16:17:56Z",15:18
bknudson"issued_at": "2016-10-17T15:17:56.000000Z",15:18
*** code-R_ has quit IRC15:26
*** rcernin has quit IRC15:26
openstackgerritGage Hugo proposed openstack/keystone: Doctor check for LDAP domain specific configs  https://review.openstack.org/36143515:31
*** ravelar has quit IRC15:33
openstackgerritTin Lam proposed openstack/keystone-specs: PCI-DSS Expired Password Users  https://review.openstack.org/38383215:36
*** lamt has joined #openstack-keystone15:39
*** ravelar has joined #openstack-keystone15:40
*** agrebennikov has joined #openstack-keystone15:40
*** agrebennikov has quit IRC15:40
*** agrebennikov has joined #openstack-keystone15:41
*** agrebennikov has quit IRC15:41
*** agrebennikov has joined #openstack-keystone15:41
*** agrebennikov has quit IRC15:42
*** agrebennikov has joined #openstack-keystone15:42
*** agrebennikov has quit IRC15:42
*** agrebennikov has joined #openstack-keystone15:44
*** jistr is now known as jistr|biab15:46
*** agrebennikov has quit IRC15:46
*** code-R has joined #openstack-keystone15:46
openstackgerritMerged openstack/keystone: Code cleanup  https://review.openstack.org/38479815:47
*** agrebennikov has joined #openstack-keystone15:48
*** code-R_ has joined #openstack-keystone15:50
*** david-lyle_ has joined #openstack-keystone15:52
*** david-lyle has quit IRC15:53
*** hogepodge has joined #openstack-keystone15:53
*** code-R has quit IRC15:53
*** gagehugo has quit IRC15:53
openstackgerritMerged openstack/pycadf: Changed the home-page link  https://review.openstack.org/38745515:54
openstackgerritayoung proposed openstack/keystone: Refactor Authorization:  https://review.openstack.org/38716115:54
*** code-R_ has quit IRC16:00
*** code-R has joined #openstack-keystone16:01
knikollarodrigods, hi16:05
*** Guest56218 is now known as mfisch16:06
*** mfisch is now known as Guest877016:06
openstackgerritRichard Avelar proposed openstack/keystone: Remove unused statements in matches  https://review.openstack.org/38754816:07
*** admin0 has quit IRC16:08
*** rcernin has joined #openstack-keystone16:10
*** Guest8770 is now known as mfisch16:10
*** mfisch has quit IRC16:10
*** mfisch has joined #openstack-keystone16:10
maticueHi everyone, one simple question for Kilo nova compute service that involves keystone authentication.... when I delete a VM, nova-compute service tries to de-allocate the network port from the VM. To run this action, nova-compute service needs to ask authorization. This authorization request is using [keystone_authtoken] section or [neutron] section?16:14
*** Zer0Byte__ has joined #openstack-keystone16:20
*** jistr|biab is now known as jistr16:22
*** gyee has joined #openstack-keystone16:22
*** david-lyle_ is now known as david-lyle16:24
*** code-R has quit IRC16:41
*** ravelar has quit IRC16:42
*** ravelar has joined #openstack-keystone16:42
*** browne has joined #openstack-keystone16:43
*** markvoelker has joined #openstack-keystone16:46
*** voelzmo has joined #openstack-keystone16:46
*** markvoelker_ has joined #openstack-keystone16:49
*** voelzmo has quit IRC16:50
*** voelzmo has joined #openstack-keystone16:50
*** markvoelker has quit IRC16:51
openstackgerritMerged openstack/keystone: Optimize remove unused variable  https://review.openstack.org/38436916:54
*** voelzmo has quit IRC16:55
*** jaosorior has quit IRC16:57
lbragstadstevemar quick question - if we've removed (or are going to remove) something in Ocata, but a bug comes through saying there is an issue with it in a stable branch, how do we triage that?16:57
*** amoralej is now known as amoralej|off16:57
*** lamt has quit IRC17:00
*** kiran-r has joined #openstack-keystone17:01
*** ravelar has quit IRC17:05
*** jaosorior has joined #openstack-keystone17:06
lbragstadcc dolphm or dstanek ^17:11
*** pece has quit IRC17:12
*** Ephur has quit IRC17:17
*** tqtran has joined #openstack-keystone17:21
*** gagehugo has joined #openstack-keystone17:21
openstackgerritRon De Rose proposed openstack/keystone: Remove backend dependencies from token provider  https://review.openstack.org/38613617:23
*** ravelar has joined #openstack-keystone17:29
openstackgerritRon De Rose proposed openstack/keystone: Remove backend dependencies from token provider  https://review.openstack.org/38613617:31
openstackgerritGage Hugo proposed openstack/keystone: Doctor check for LDAP domain specific configs  https://review.openstack.org/36143517:32
*** sheel has joined #openstack-keystone17:36
*** admin0 has joined #openstack-keystone17:36
*** admin0 has left #openstack-keystone17:38
*** haplo37_ has quit IRC17:40
*** jaosorior has quit IRC17:41
*** jaosorior has joined #openstack-keystone17:41
*** dave-mccowan has quit IRC17:42
*** haplo37_ has joined #openstack-keystone17:42
openstackgerritRon De Rose proposed openstack/keystone: Validate mapping exists when creating/updating a protocol  https://review.openstack.org/36239717:43
*** dave-mccowan has joined #openstack-keystone17:43
*** ayoung has joined #openstack-keystone17:45
*** ChanServ sets mode: +v ayoung17:45
*** spzala has joined #openstack-keystone17:46
*** jaosorior has quit IRC17:51
*** pnavarro has quit IRC17:51
*** ravelar1 has joined #openstack-keystone17:54
*** ravelar has quit IRC17:56
*** kiran-r has quit IRC18:00
*** ravelar1 has quit IRC18:00
*** lamt has joined #openstack-keystone18:01
*** lamt has quit IRC18:03
*** markvoelker_ has quit IRC18:03
openstackgerritGage Hugo proposed openstack/keystone: Doctor check for LDAP domain specific configs  https://review.openstack.org/36143518:09
*** lamt has joined #openstack-keystone18:12
*** code-R has joined #openstack-keystone18:16
*** code-R_ has joined #openstack-keystone18:23
*** tran has joined #openstack-keystone18:24
*** code-R has quit IRC18:26
*** ravelar1 has joined #openstack-keystone18:28
*** Guest21077 has quit IRC18:29
*** ravelar1 has quit IRC18:29
*** ravelar has joined #openstack-keystone18:36
openstackgerritGage Hugo proposed openstack/keystone: Doctor check for LDAP domain specific configs  https://review.openstack.org/36143518:41
*** ravelar has quit IRC18:51
*** med_` is now known as medberry19:03
*** medberry has joined #openstack-keystone19:03
*** thiagolib has joined #openstack-keystone19:05
*** tran has quit IRC19:10
openstackgerritGage Hugo proposed openstack/keystone: Doctor check for LDAP domain specific configs  https://review.openstack.org/36143519:12
*** ravelar has joined #openstack-keystone19:12
*** kiran-r has joined #openstack-keystone19:16
stevemardolphm: ack19:20
*** asettle has joined #openstack-keystone19:24
* lbragstad sets http://lists.openstack.org/pipermail/openstack-dev/2016-October/105844.html on ayoung's desk19:24
*** ravelar has quit IRC19:28
*** ravelar has joined #openstack-keystone19:29
stevemarlbragstad: i thought the same thing :)19:30
lbragstadstevemar sounds like fun19:32
*** gyee has quit IRC19:37
*** ravelar has quit IRC19:42
*** jperry has quit IRC19:45
*** sheel has quit IRC19:50
openstackgerritRon De Rose proposed openstack/keystone: Validate mapping exists when creating/updating a protocol  https://review.openstack.org/36239719:56
*** spzala has quit IRC19:58
*** spzala has joined #openstack-keystone19:59
*** spzala has quit IRC19:59
*** spzala has joined #openstack-keystone19:59
*** brad[] has quit IRC20:00
*** mfisch has quit IRC20:00
*** medberry has quit IRC20:00
*** med_ has joined #openstack-keystone20:00
*** mfisch has joined #openstack-keystone20:00
*** mfisch has quit IRC20:01
*** mfisch has joined #openstack-keystone20:01
*** med_ is now known as Guest6284620:01
*** tqtran has quit IRC20:02
*** code-R_ has quit IRC20:12
Zer0Byte__hey guys20:21
*** brad[] has joined #openstack-keystone20:21
*** flwang1 has quit IRC20:21
*** pcaruana has quit IRC20:25
*** tqtran has joined #openstack-keystone20:33
*** asettle has quit IRC20:33
*** markvoelker has joined #openstack-keystone20:34
*** code-R has joined #openstack-keystone20:35
*** jperry has joined #openstack-keystone20:37
*** markvoelker_ has joined #openstack-keystone20:37
openstackgerritSteve Martinelli proposed openstack/keystone: changed domain id to name in JSON request  https://review.openstack.org/38716220:37
openstackgerritSteve Martinelli proposed openstack/keystone: changed domain id to name in JSON request  https://review.openstack.org/38716220:38
openstackgerritRon De Rose proposed openstack/keystone: Remove backend dependencies from token provider  https://review.openstack.org/38613620:39
*** markvoelker has quit IRC20:41
openstackgerritRon De Rose proposed openstack/keystone: Remove backend dependencies from token provider  https://review.openstack.org/38613620:42
ayounglbragstad, TYVM20:43
ayounghenrynash, lbragstad, jamielennox  BTW whomever is interested in reviewing https://review.openstack.org/#/c/387161/  that is a squash of the other patches all listed in the same topic.20:44
ayoungrderose, && for you as well.  I left the step by step refactoring in Gerrit to explain it, but bit sure if that is the best approach20:46
stevemarbrowne: why not include keystone in https://review.openstack.org/#/c/387670/1//COMMIT_MSG ?20:47
stevemarbrowne: duh cause it's already voting20:49
*** adriant has joined #openstack-keystone20:51
openstackgerritRon De Rose proposed openstack/keystone: Remove backend dependencies from token provider  https://review.openstack.org/38613620:51
brownestevemar: :)20:55
*** Ephur has joined #openstack-keystone20:58
*** haplo37_ has quit IRC21:01
*** haplo37_ has joined #openstack-keystone21:03
*** gagehugo has quit IRC21:04
*** mvk has joined #openstack-keystone21:05
*** raildo has quit IRC21:08
*** edmondsw has quit IRC21:10
*** nicolasbock has quit IRC21:10
lbragstaddstanek I think https://review.openstack.org/#/c/386136/8 is ready21:10
stevemarlbragstad: i'm looking at that now :D21:16
lbragstadstevemar sweet21:16
stevemarwell, not now now, but soon21:16
lbragstadstevemar can we take the 'do not merge' off of this? https://review.openstack.org/#/c/367052/21:17
jamielennoxayoung: i had a bit of a look through that yesterday - what's the end goal there?21:17
stevemarlbragstad: sure, feel free to change it21:17
*** spzala has quit IRC21:18
stevemarlbragstad: should it depend-on something?21:18
*** chris_hultin is now known as chris_hultin|AWA21:19
lbragstadstevemar this depends on your patch - https://review.openstack.org/#/c/345688/21:19
*** spzala has joined #openstack-keystone21:19
lbragstadstevemar which also has a dependency on https://review.openstack.org/#/q/I7208bf6cb9329d6ca1f49409da44b0537c74aea9,n,z21:19
stevemarlbragstad: so is the game plan to make it the default in devstack and see what breaks?21:20
stevemarthen make it the default in keystone?21:20
lbragstadnope - nothing should break this time21:20
stevemarwell yes, that's what i mean -- change it and see/hope nothing breaks -- we should have all the things fixed21:21
lbragstadapproval order should be https://review.openstack.org/#/c/376526/ -> https://review.openstack.org/#/c/367595/ -> https://review.openstack.org/#/c/367384/ -> https://review.openstack.org/#/c/367052/ -> https://review.openstack.org/#/c/345688/ (being last)21:21
lbragstaddansmith and sdague have approved the grenade change21:21
lbragstadbut that is dependent on us merging a release note21:22
lbragstadthen it's just the change to tempest and devstack21:22
lbragstadafter that we're home free to make it the default21:22
*** asettle has joined #openstack-keystone21:33
*** asettle has quit IRC21:39
openstackgerritLance Bragstad proposed openstack/keystone: Switch fernet to be the default token provider.  https://review.openstack.org/34568821:39
ayoungjamielennox, so the whole thing started with me trying to get is_admin_project support, and realizing that the trusts code did an end run around the rest of our enforcement21:39
ayoungso the goal is to get a single path for building the auth structure to pass to policy, and to reduce things like you were complaaining about "flatten_dict"21:40
ayoungjamielennox, If you look at the original implementation, the decorators were not even calling check_policy, although they were essentially copie and pasted gode from ti21:40
ayoungit21:40
ayoungso I also consier this a paydown of technical debt "removing cut and paste code"21:41
ayoungjamielennox, the Keystone path to policy enforcement is tangled and overgrown.  Just trying to take a machete to it without chopping off my own foot21:42
*** flwang1 has joined #openstack-keystone21:46
stevemarayoung: is tripleo the same thing as RDO? whats an rdo manager / rdo director?21:47
ayoungstevemar, sort of...RDO is the packages21:48
jamielennoxayoung: so i've hit a similar problem with the allow_expired patch, https://review.openstack.org/#/c/382098/ that fetches the subject token twice21:48
ayoungtripleo is hte installer, so it used the RDO packages21:48
jamielennoxayoung: but my intention here was not to do one decorator to rule them all - but get rid of the decorator and put enforce calls into the controllers21:48
ayoungdirector is not an RDO piece, it is the downstream RH supported installer, based on Tripleo21:48
ayoungjamielennox, yep, and this goes a long way toward that21:48
ayoungjamielennox, so look at all the ones that have callbacks21:49
ayoungthose are basically wrapping check_policy anywah21:49
jamielennoxayoung: right, anything passing a callback is because you just can't provide enough control from the decorator to do what you want, so if we could inline the protected call that would go away21:50
ayoungjamielennox, so you could probably inline the @controller.protected calls after this patch21:50
ayoungthe filterprotected need a little more support, but should be pretty easy to reverse from what is done now21:50
ayoungjamielennox, but even if we left the decorators, for now, it should be more supportable.21:51
jamielennoxayoung: ok, i just saw it and thought you were running in a completely opposite direction21:52
*** code-R has quit IRC21:54
ayoungjamielennox, Nope, I 'm with you on this.21:57
*** code-R has joined #openstack-keystone21:57
ayoungjamielennox, the tricky part of this patch was dealing with how the parameters are built for the decorators. I tried to get all that into a single function, but it really is two distince mechanisms: protecte4d vs filterprotected both make use of both *args and **kwargs in different and non-compatible ways21:59
*** Ephur has quit IRC22:03
*** rcernin has quit IRC22:06
*** code-R has quit IRC22:07
openstackgerritMerged openstack/keystone: Drop MANIFEST.in - it's not needed by pbr  https://review.openstack.org/38638422:10
*** spzala has quit IRC22:17
jamielennoxayoung: right - i'm hoping the key to simplify that  will be not actually doing that in the decorator22:18
*** gyee has joined #openstack-keystone22:19
ayoungjamielennox, TBH, th thing I like about the decorator right now is the easy of grepping for it, but that is only because I am refactoring.  I'd like to make sure that when we do replace it, we make the replacement one line, and no cut/paste boilerplate22:19
*** jperry has quit IRC22:27
*** lamt has quit IRC22:41
openstackgerritAdrian Turjak proposed openstack/keystone: adding combined password and totp auth plugin  https://review.openstack.org/34342222:55
*** michauds has quit IRC23:00
*** markvoelker_ has quit IRC23:01
openstackgerritMerged openstack/keystone: Fix a docstring typo in test_v3_resource.py  https://review.openstack.org/37761823:10
openstackgerritEric Brown proposed openstack/keystone: Updates to the architecture doc  https://review.openstack.org/38770923:11
openstackgerritayoung proposed openstack/keystone: Refactor is_admin  https://review.openstack.org/38771023:16
*** haplo37_ has quit IRC23:29
*** haplo37_ has joined #openstack-keystone23:30
*** lamt has joined #openstack-keystone23:31
openstackgerritayoung proposed openstack/keystone: Add is_admin_project check to policy.json  https://review.openstack.org/25763623:39
ayoungjamielennox, ^^ is where I was going with that23:40
*** chlong has joined #openstack-keystone23:40
*** agrebennikov has quit IRC23:46
jamielennoxayoung: how would you feel about putting some of that on the request object?23:46
jamielennoxor does it make sense?23:46
ayoungjamielennox, what specifically do you want to move?23:47
ayoungjamielennox, I guess I'd be in favor.  It is stuff that is common to requests, so that would be a logical place to find it, as opposed to on the controllers.23:47
ayoungI hadn't really mapped out a full object model of how the policy check should look.  I guess I'd need to diagram that up before I voiced any strong opinions23:49
jamielennoxayoung: i was just thinknig what i would want the interface to look like at the end - because that's currently not it23:50
jamielennoxand what we would need to refactor to get there23:50
ayoung++23:50
jamielennoxideally we want to get to using to_policy_values which i think is currently at request.context.to_policy_values23:50
jamielennoxthe enforce signature is def enforce(self, rule, target, creds, do_raise=False, ..)23:51
*** guoshan has joined #openstack-keystone23:51
jamielennoxcreds is from request.context, do_raise doesn't change23:51
jamielennoxso i was thinking like23:52
*** kiran-r has quit IRC23:52
jamielennoxrequest.policy_check(rule, target_dict)23:52
jamielennoxresponsibility for loading the target is in the controller - like it always should have been23:52
jamielennoxrule becomes a manually entered string - which means no more messing around with function names23:53
*** LiYuenan has quit IRC23:54
jamielennoxi would need to check where request params end up in policy to see how they play in, but i don't think that's hard23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!