rodrigods | grr pep8 | 00:00 |
---|---|---|
lbragstad | we could roll it all together | 00:00 |
lbragstad | which would maintain the original author, too | 00:00 |
lbragstad | rodrigods you could also assert each key is 32 bytes instead of greater than 0 | 00:01 |
lbragstad | self.assertEqual(len(key), 32) | 00:01 |
lbragstad | ^ this probably makes more sense than self.assertGreater() | 00:01 |
lbragstad | or might be more readable | 00:01 |
rodrigods | lbragstad, need to leave :( | 00:03 |
rodrigods | i can fix when i come back | 00:03 |
lbragstad | rodrigods no worries | 00:03 |
lbragstad | rodrigods i'm just about to wrap up for the day, too | 00:03 |
stevemar | samueldmq: rodrigods openstack will only support python 3.5.x | 00:04 |
samueldmq | stevemar: nice, thanks! | 00:09 |
*** agrebennikov has quit IRC | 00:10 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: listing revoke events should be admin only https://review.openstack.org/416841 | 00:10 |
dstanek | we should move to 3.6! | 00:11 |
samueldmq | stevemar: there is also https://review.openstack.org/#/c/417238, just in the case you missed it :) | 00:11 |
dstanek | lbragstad: great. just got done with dinner. i'll take a look in a sec | 00:11 |
dstanek | samueldmq: i would think we shouldn't be using that classifier anymore | 00:12 |
samueldmq | dstanek: the 3.4 one ? | 00:13 |
dstanek | samueldmq: yeah, that supposed to indicate what we support and test for | 00:17 |
samueldmq | dstanek: agreed, most of changes are on the gate already https://review.openstack.org/#/q/topic:rm_py34 | 00:17 |
samueldmq | stevemar: do services need to get the revocation list ? | 00:22 |
samueldmq | stevemar: I guess no as fernet is default, just confirming | 00:22 |
samueldmq | stevemar: nvm, commented in the patch | 00:29 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: listing revoke events should be admin only https://review.openstack.org/416841 | 00:35 |
openstackgerrit | Eric Brown proposed openstack/pycadf: Remove references to Python 3.4 https://review.openstack.org/417255 | 00:37 |
*** dave-mccowan has joined #openstack-keystone | 00:37 | |
openstackgerrit | Merged openstack/keystone: Use assertGreater(len(x), y) instead of assertTrue(len(x) > y) https://review.openstack.org/412083 | 00:40 |
samueldmq | lbragstad: so, shadow mapping ... | 00:40 |
samueldmq | :-) | 00:40 |
*** adrian_otto has joined #openstack-keystone | 00:41 | |
samueldmq | lbragstad: dstanek: I saw a couple of patches going up today, are all the bits up for review already? | 00:41 |
*** markvoelker has quit IRC | 00:41 | |
*** spzala has joined #openstack-keystone | 00:44 | |
*** adrian_otto has quit IRC | 00:49 | |
*** guoshan has joined #openstack-keystone | 00:53 | |
*** adrian_otto has joined #openstack-keystone | 00:55 | |
*** guoshan has quit IRC | 00:57 | |
samueldmq | stevemar: dstanek: re: https://review.openstack.org/#/c/182658 | 00:58 |
*** stingaci has joined #openstack-keystone | 00:58 | |
samueldmq | stevemar: dstanek: I propose creating a brand new manager in contrib/endpoint_group.py (new file) for endpoint_group CRUD | 00:59 |
samueldmq | just as it is for endpoints | 00:59 |
*** markvoelker has joined #openstack-keystone | 00:59 | |
samueldmq | and the endpoint_group/project relationship would be in contrib/endpoint_filter, just as it is for endpoint/project relationship | 00:59 |
*** jose-phillips has quit IRC | 01:00 | |
*** stingaci has quit IRC | 01:03 | |
*** lamt has quit IRC | 01:06 | |
openstackgerrit | Merged openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/414397 | 01:13 |
*** samueldmq has quit IRC | 01:13 | |
*** abhishekk has quit IRC | 01:13 | |
*** gagehugo has quit IRC | 01:13 | |
*** nikhil has quit IRC | 01:13 | |
*** Dinesh_Bhor has quit IRC | 01:13 | |
*** agarner has quit IRC | 01:13 | |
*** robcresswell has quit IRC | 01:13 | |
*** jlvillal has quit IRC | 01:13 | |
*** flaper87 has quit IRC | 01:13 | |
*** jlopezgu has quit IRC | 01:13 | |
*** basilAB has quit IRC | 01:13 | |
*** DuncanT has quit IRC | 01:13 | |
*** andreaf has quit IRC | 01:13 | |
*** baffle has quit IRC | 01:13 | |
*** jlwhite has quit IRC | 01:13 | |
*** mkoderer__ has quit IRC | 01:13 | |
*** Kimmo_ has quit IRC | 01:13 | |
*** bknudson has quit IRC | 01:13 | |
*** timburke has quit IRC | 01:13 | |
*** johnthetubaguy has quit IRC | 01:13 | |
*** boris-42 has quit IRC | 01:13 | |
*** pkoraca has quit IRC | 01:13 | |
*** crinkle_ has quit IRC | 01:13 | |
*** sc68cal has quit IRC | 01:13 | |
*** aloga has quit IRC | 01:13 | |
*** hugokuo has quit IRC | 01:13 | |
*** dgonzalez has quit IRC | 01:13 | |
*** evrardjp has quit IRC | 01:13 | |
*** waj334 has quit IRC | 01:13 | |
*** jamielennox has quit IRC | 01:13 | |
*** pumaranikar has quit IRC | 01:13 | |
*** NikitaKonovalov has quit IRC | 01:13 | |
*** dolphm has quit IRC | 01:13 | |
*** vern has quit IRC | 01:13 | |
*** johnthetubaguy_ has joined #openstack-keystone | 01:14 | |
*** baffle has joined #openstack-keystone | 01:14 | |
*** dolphm_ has joined #openstack-keystone | 01:14 | |
*** Kimmo_ has joined #openstack-keystone | 01:14 | |
*** jlvillal has joined #openstack-keystone | 01:14 | |
*** aleph1 has joined #openstack-keystone | 01:14 | |
*** dgonzalez has joined #openstack-keystone | 01:14 | |
*** evrardjp_ has joined #openstack-keystone | 01:14 | |
*** jlwhite has joined #openstack-keystone | 01:14 | |
*** Dinesh_Bhor has joined #openstack-keystone | 01:14 | |
*** crinkle_ has joined #openstack-keystone | 01:14 | |
*** aloga has joined #openstack-keystone | 01:14 | |
*** ChanServ sets mode: +o dolphm_ | 01:14 | |
*** gagehugo has joined #openstack-keystone | 01:14 | |
*** evrardjp_ is now known as evrardjp | 01:14 | |
*** johnthetubaguy_ is now known as johnthetubaguy | 01:14 | |
*** NikitaKonovalov has joined #openstack-keystone | 01:14 | |
*** timburke has joined #openstack-keystone | 01:14 | |
*** dolphm_ is now known as dolphm | 01:14 | |
*** vern has joined #openstack-keystone | 01:14 | |
*** mkoderer___ has joined #openstack-keystone | 01:15 | |
*** adrian_otto has quit IRC | 01:15 | |
*** hugokuo has joined #openstack-keystone | 01:15 | |
*** bknudson has joined #openstack-keystone | 01:16 | |
*** ChanServ sets mode: +v bknudson | 01:16 | |
*** sc68cal has joined #openstack-keystone | 01:16 | |
*** andreaf has joined #openstack-keystone | 01:16 | |
*** AndyWojo has quit IRC | 01:17 | |
*** serverascode has quit IRC | 01:17 | |
*** jamielennox has joined #openstack-keystone | 01:18 | |
*** ChanServ sets mode: +v jamielennox | 01:18 | |
*** esp has quit IRC | 01:19 | |
*** robcresswell has joined #openstack-keystone | 01:19 | |
*** jlopezgu has joined #openstack-keystone | 01:19 | |
*** dave-mccowan has quit IRC | 01:21 | |
*** samueldmq has joined #openstack-keystone | 01:21 | |
*** ChanServ sets mode: +v samueldmq | 01:21 | |
openstackgerrit | Merged openstack/keystoneauth: Remove references to Python 3.4 https://review.openstack.org/417236 | 01:21 |
*** liujiong has joined #openstack-keystone | 01:21 | |
*** pumaranikar has joined #openstack-keystone | 01:22 | |
*** dave-mccowan has joined #openstack-keystone | 01:23 | |
*** waj334 has joined #openstack-keystone | 01:24 | |
*** pkoraca has joined #openstack-keystone | 01:25 | |
*** AndyWojo has joined #openstack-keystone | 01:25 | |
*** boris-42 has joined #openstack-keystone | 01:25 | |
*** DuncanT has joined #openstack-keystone | 01:26 | |
*** nikhil has joined #openstack-keystone | 01:27 | |
*** stingaci has joined #openstack-keystone | 01:29 | |
*** stingaci has quit IRC | 01:33 | |
*** browne has quit IRC | 01:43 | |
*** serverascode has joined #openstack-keystone | 01:43 | |
*** stingaci has joined #openstack-keystone | 01:48 | |
*** guoshan has joined #openstack-keystone | 01:49 | |
*** stingaci has quit IRC | 01:52 | |
openstackgerrit | Merged openstack/keystone: Correct invalid rst in api docs https://review.openstack.org/416711 | 01:53 |
openstackgerrit | Merged openstack/keystone: Fix issues with keystone-dsvm-py35-functional-v3-only on py35 https://review.openstack.org/412500 | 01:53 |
openstackgerrit | Merged openstack/keystonemiddleware: Remove references to Python 3.4 https://review.openstack.org/417237 | 01:55 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Improve assertion in test https://review.openstack.org/417239 | 01:56 |
*** dave-mccowan has quit IRC | 02:22 | |
*** catintheroof has joined #openstack-keystone | 02:22 | |
*** edtubill has joined #openstack-keystone | 02:24 | |
openstackgerrit | Merged openstack/python-keystoneclient: Remove references to Python 3.4 https://review.openstack.org/417238 | 02:28 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD https://review.openstack.org/417263 | 02:38 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD https://review.openstack.org/417263 | 02:40 |
*** catintheroof has quit IRC | 02:50 | |
*** ravelar has joined #openstack-keystone | 02:51 | |
*** ravelar has quit IRC | 02:51 | |
*** davechen has quit IRC | 02:52 | |
*** edtubill has quit IRC | 02:52 | |
*** edtubill has joined #openstack-keystone | 02:52 | |
*** edtubill has quit IRC | 03:02 | |
*** edtubill has joined #openstack-keystone | 03:05 | |
lbragstad | samueldmq should be! | 03:09 |
*** spzala has quit IRC | 03:13 | |
*** edtubill has quit IRC | 03:19 | |
*** spzala has joined #openstack-keystone | 03:52 | |
*** guoshan has quit IRC | 03:55 | |
*** itisha has quit IRC | 04:02 | |
*** dikonoor has joined #openstack-keystone | 04:03 | |
*** spzala has quit IRC | 04:07 | |
*** nicolasbock has joined #openstack-keystone | 04:35 | |
*** links has joined #openstack-keystone | 04:40 | |
*** stingaci has joined #openstack-keystone | 04:55 | |
*** stingaci has quit IRC | 05:02 | |
*** davechen has joined #openstack-keystone | 05:04 | |
*** gagehugo has quit IRC | 05:30 | |
*** gagehugo has joined #openstack-keystone | 05:33 | |
*** guoshan has joined #openstack-keystone | 05:38 | |
*** guoshan has quit IRC | 05:45 | |
*** guoshan has joined #openstack-keystone | 05:46 | |
*** guoshan has quit IRC | 05:56 | |
*** guoshan has joined #openstack-keystone | 06:00 | |
*** spzala has joined #openstack-keystone | 06:08 | |
*** spzala has quit IRC | 06:12 | |
*** edtubill has joined #openstack-keystone | 06:14 | |
*** edtubill has quit IRC | 06:30 | |
openstackgerrit | Merged openstack/keystone: Improve assertion in test https://review.openstack.org/417239 | 06:30 |
openstackgerrit | Merged openstack/keystone: Fixed 7 tests running twice in v3 identity https://review.openstack.org/416765 | 06:37 |
*** richm has quit IRC | 06:41 | |
*** adriant has quit IRC | 06:46 | |
*** rcernin has quit IRC | 06:55 | |
*** tesseract has joined #openstack-keystone | 07:09 | |
*** pcaruana has joined #openstack-keystone | 07:10 | |
*** udesale has joined #openstack-keystone | 07:12 | |
*** rcernin has joined #openstack-keystone | 07:13 | |
*** trananhkma has joined #openstack-keystone | 07:28 | |
openstackgerrit | Eric Brown proposed openstack/keystone: Remove references to Python 3.4 https://review.openstack.org/417235 | 07:30 |
*** voelzmo has joined #openstack-keystone | 07:34 | |
*** voelzmo has quit IRC | 07:42 | |
openstackgerrit | Abhishek Kekane proposed openstack/keystoneauth: Log request-id for each api call https://review.openstack.org/392442 | 07:48 |
*** oomichi has quit IRC | 08:02 | |
*** oomichi has joined #openstack-keystone | 08:03 | |
*** voelzmo has joined #openstack-keystone | 08:11 | |
*** voelzmo has quit IRC | 08:15 | |
*** voelzmo has joined #openstack-keystone | 08:17 | |
*** voelzmo has quit IRC | 08:20 | |
*** EmilienM has quit IRC | 08:24 | |
*** udesale has quit IRC | 08:31 | |
*** waj334 has quit IRC | 08:31 | |
*** robcresswell has quit IRC | 08:31 | |
*** dolphm has quit IRC | 08:31 | |
*** johnthetubaguy has quit IRC | 08:31 | |
*** markvoelker has quit IRC | 08:31 | |
*** harlowja has quit IRC | 08:31 | |
*** g2 has quit IRC | 08:31 | |
*** afazekas has quit IRC | 08:31 | |
*** sheel has quit IRC | 08:31 | |
*** davechen has quit IRC | 08:31 | |
*** links has quit IRC | 08:31 | |
*** AndyWojo has quit IRC | 08:31 | |
*** jamielennox has quit IRC | 08:31 | |
*** Dinesh_Bhor has quit IRC | 08:31 | |
*** crinkle_ has quit IRC | 08:31 | |
*** tlbr has quit IRC | 08:31 | |
*** mtreinish has quit IRC | 08:31 | |
*** rdo has quit IRC | 08:31 | |
*** openstackgerrit has quit IRC | 08:31 | |
*** charz has quit IRC | 08:31 | |
*** oomichi has quit IRC | 08:31 | |
*** serverascode has quit IRC | 08:31 | |
*** pumaranikar has quit IRC | 08:31 | |
*** samueldmq has quit IRC | 08:31 | |
*** jlvillal has quit IRC | 08:31 | |
*** sileht has quit IRC | 08:31 | |
*** sudorandom has quit IRC | 08:31 | |
*** ayoung has quit IRC | 08:31 | |
*** trananhkma has quit IRC | 08:31 | |
*** dikonoor has quit IRC | 08:31 | |
*** nikhil has quit IRC | 08:31 | |
*** DuncanT has quit IRC | 08:31 | |
*** vern has quit IRC | 08:31 | |
*** NikitaKonovalov has quit IRC | 08:31 | |
*** rarora has quit IRC | 08:31 | |
*** zeus has quit IRC | 08:31 | |
*** timss has quit IRC | 08:31 | |
*** mancdaz has quit IRC | 08:31 | |
*** raj_singh has quit IRC | 08:31 | |
*** slunkad has quit IRC | 08:31 | |
*** woodburn has quit IRC | 08:31 | |
*** Nakato has quit IRC | 08:31 | |
*** nklenke has quit IRC | 08:31 | |
*** gus has quit IRC | 08:31 | |
*** fungi has quit IRC | 08:31 | |
*** boris-42 has quit IRC | 08:31 | |
*** masterjcool has quit IRC | 08:31 | |
*** wolsen has quit IRC | 08:31 | |
*** rm_work has quit IRC | 08:31 | |
*** hyakuhei has quit IRC | 08:31 | |
*** BlackDex has quit IRC | 08:31 | |
*** rcernin has quit IRC | 08:31 | |
*** guoshan has quit IRC | 08:31 | |
*** gagehugo has quit IRC | 08:31 | |
*** jlopezgu has quit IRC | 08:31 | |
*** hugokuo has quit IRC | 08:31 | |
*** jlwhite has quit IRC | 08:31 | |
*** jgrassler has quit IRC | 08:31 | |
*** bandrus has quit IRC | 08:31 | |
*** nkinder has quit IRC | 08:31 | |
*** _nonameentername has quit IRC | 08:31 | |
*** Guest66666 has quit IRC | 08:31 | |
*** dmellado_ has quit IRC | 08:31 | |
*** dancn has quit IRC | 08:31 | |
*** pkoraca has quit IRC | 08:31 | |
*** Kimmo_ has quit IRC | 08:31 | |
*** baffle has quit IRC | 08:31 | |
*** d0ugal has quit IRC | 08:31 | |
*** htruta has quit IRC | 08:31 | |
*** tonyb has quit IRC | 08:31 | |
*** lifeless has quit IRC | 08:31 | |
*** eglute has quit IRC | 08:31 | |
*** rodrigods has quit IRC | 08:31 | |
*** Tahvok has quit IRC | 08:31 | |
*** bknudson has quit IRC | 08:31 | |
*** evrardjp has quit IRC | 08:31 | |
*** mkoderer___ has quit IRC | 08:31 | |
*** d34dh0r53 has quit IRC | 08:31 | |
*** Anticimex has quit IRC | 08:31 | |
*** zzzeek has quit IRC | 08:31 | |
*** rha has quit IRC | 08:31 | |
*** jrist_ has quit IRC | 08:31 | |
*** yarkot has quit IRC | 08:31 | |
*** r1chardj0n3s has quit IRC | 08:31 | |
*** frickler has quit IRC | 08:31 | |
*** peterstac has quit IRC | 08:31 | |
*** arunkant has quit IRC | 08:31 | |
*** alex_xu has quit IRC | 08:31 | |
*** pcaruana has quit IRC | 08:31 | |
*** tesseract has quit IRC | 08:31 | |
*** nicolasbock has quit IRC | 08:31 | |
*** andreaf has quit IRC | 08:31 | |
*** aleph1 has quit IRC | 08:31 | |
*** dgonzalez has quit IRC | 08:31 | |
*** SamYaple has quit IRC | 08:31 | |
*** topol_ has quit IRC | 08:31 | |
*** rvba has quit IRC | 08:31 | |
*** zhugaoxiao has quit IRC | 08:31 | |
*** kevinbenton has quit IRC | 08:31 | |
*** erhudy has quit IRC | 08:31 | |
*** jidar has quit IRC | 08:31 | |
*** akrzos has quit IRC | 08:31 | |
*** clayton has quit IRC | 08:31 | |
*** liujiong has quit IRC | 08:31 | |
*** sc68cal has quit IRC | 08:31 | |
*** timburke has quit IRC | 08:31 | |
*** aloga has quit IRC | 08:31 | |
*** sirushti has quit IRC | 08:31 | |
*** gsilvis has quit IRC | 08:31 | |
*** Trident has quit IRC | 08:31 | |
*** cburgess has quit IRC | 08:31 | |
*** haplo37_ has quit IRC | 08:31 | |
*** jdennis has quit IRC | 08:31 | |
*** ktychkova has quit IRC | 08:31 | |
*** david-lyle has quit IRC | 08:31 | |
*** toddnni has quit IRC | 08:31 | |
*** hrybacki has quit IRC | 08:34 | |
*** NikitaKonovalov has joined #openstack-keystone | 08:37 | |
*** gagehugo has joined #openstack-keystone | 08:37 | |
*** Nakato has joined #openstack-keystone | 08:37 | |
*** EmilienM has joined #openstack-keystone | 08:37 | |
*** mvk has joined #openstack-keystone | 08:37 | |
*** oomichi has joined #openstack-keystone | 08:37 | |
*** trananhkma has joined #openstack-keystone | 08:37 | |
*** rcernin has joined #openstack-keystone | 08:37 | |
*** udesale has joined #openstack-keystone | 08:37 | |
*** pcaruana has joined #openstack-keystone | 08:37 | |
*** tesseract has joined #openstack-keystone | 08:37 | |
*** davechen has joined #openstack-keystone | 08:37 | |
*** links has joined #openstack-keystone | 08:37 | |
*** nicolasbock has joined #openstack-keystone | 08:37 | |
*** serverascode has joined #openstack-keystone | 08:37 | |
*** nikhil has joined #openstack-keystone | 08:37 | |
*** boris-42 has joined #openstack-keystone | 08:37 | |
*** AndyWojo has joined #openstack-keystone | 08:37 | |
*** pkoraca has joined #openstack-keystone | 08:37 | |
*** waj334 has joined #openstack-keystone | 08:37 | |
*** pumaranikar has joined #openstack-keystone | 08:37 | |
*** liujiong has joined #openstack-keystone | 08:37 | |
*** samueldmq has joined #openstack-keystone | 08:37 | |
*** jlopezgu has joined #openstack-keystone | 08:37 | |
*** robcresswell has joined #openstack-keystone | 08:37 | |
*** jamielennox has joined #openstack-keystone | 08:37 | |
*** andreaf has joined #openstack-keystone | 08:37 | |
*** sc68cal has joined #openstack-keystone | 08:37 | |
*** bknudson has joined #openstack-keystone | 08:37 | |
*** hugokuo has joined #openstack-keystone | 08:37 | |
*** mkoderer___ has joined #openstack-keystone | 08:37 | |
*** vern has joined #openstack-keystone | 08:37 | |
*** timburke has joined #openstack-keystone | 08:37 | |
*** aloga has joined #openstack-keystone | 08:37 | |
*** crinkle_ has joined #openstack-keystone | 08:37 | |
*** Dinesh_Bhor has joined #openstack-keystone | 08:37 | |
*** jlwhite has joined #openstack-keystone | 08:37 | |
*** evrardjp has joined #openstack-keystone | 08:37 | |
*** dgonzalez has joined #openstack-keystone | 08:37 | |
*** aleph1 has joined #openstack-keystone | 08:37 | |
*** jlvillal has joined #openstack-keystone | 08:37 | |
*** Kimmo_ has joined #openstack-keystone | 08:37 | |
*** dolphm has joined #openstack-keystone | 08:37 | |
*** tepper.freenode.net sets mode: +vvvo samueldmq jamielennox bknudson dolphm | 08:37 | |
*** baffle has joined #openstack-keystone | 08:37 | |
*** johnthetubaguy has joined #openstack-keystone | 08:37 | |
*** markvoelker has joined #openstack-keystone | 08:37 | |
*** SamYaple has joined #openstack-keystone | 08:37 | |
*** sirushti has joined #openstack-keystone | 08:37 | |
*** harlowja has joined #openstack-keystone | 08:37 | |
*** d0ugal has joined #openstack-keystone | 08:37 | |
*** d34dh0r53 has joined #openstack-keystone | 08:37 | |
*** Anticimex has joined #openstack-keystone | 08:37 | |
*** openstackgerrit has joined #openstack-keystone | 08:37 | |
*** rarora has joined #openstack-keystone | 08:37 | |
*** tlbr has joined #openstack-keystone | 08:37 | |
*** sileht has joined #openstack-keystone | 08:37 | |
*** g2 has joined #openstack-keystone | 08:37 | |
*** mtreinish has joined #openstack-keystone | 08:37 | |
*** Trident has joined #openstack-keystone | 08:37 | |
*** gsilvis has joined #openstack-keystone | 08:37 | |
*** topol_ has joined #openstack-keystone | 08:37 | |
*** rvba has joined #openstack-keystone | 08:37 | |
*** rdo has joined #openstack-keystone | 08:37 | |
*** afazekas has joined #openstack-keystone | 08:37 | |
*** zeus has joined #openstack-keystone | 08:37 | |
*** htruta has joined #openstack-keystone | 08:37 | |
*** jgrassler has joined #openstack-keystone | 08:37 | |
*** sheel has joined #openstack-keystone | 08:37 | |
*** zzzeek has joined #openstack-keystone | 08:37 | |
*** rha has joined #openstack-keystone | 08:37 | |
*** zhugaoxiao has joined #openstack-keystone | 08:37 | |
*** charz has joined #openstack-keystone | 08:37 | |
*** mancdaz has joined #openstack-keystone | 08:37 | |
*** tonyb has joined #openstack-keystone | 08:37 | |
*** jrist_ has joined #openstack-keystone | 08:37 | |
*** bandrus has joined #openstack-keystone | 08:37 | |
*** nkinder has joined #openstack-keystone | 08:37 | |
*** raj_singh has joined #openstack-keystone | 08:37 | |
*** yarkot has joined #openstack-keystone | 08:37 | |
*** r1chardj0n3s has joined #openstack-keystone | 08:37 | |
*** kevinbenton has joined #openstack-keystone | 08:37 | |
*** lifeless has joined #openstack-keystone | 08:37 | |
*** cburgess has joined #openstack-keystone | 08:37 | |
*** slunkad has joined #openstack-keystone | 08:37 | |
*** woodburn has joined #openstack-keystone | 08:37 | |
*** _nonameentername has joined #openstack-keystone | 08:37 | |
*** eglute has joined #openstack-keystone | 08:37 | |
*** rodrigods has joined #openstack-keystone | 08:37 | |
*** sudorandom has joined #openstack-keystone | 08:37 | |
*** haplo37_ has joined #openstack-keystone | 08:37 | |
*** Guest66666 has joined #openstack-keystone | 08:37 | |
*** frickler has joined #openstack-keystone | 08:37 | |
*** masterjcool has joined #openstack-keystone | 08:37 | |
*** nklenke has joined #openstack-keystone | 08:37 | |
*** jdennis has joined #openstack-keystone | 08:37 | |
*** ayoung has joined #openstack-keystone | 08:37 | |
*** wolsen has joined #openstack-keystone | 08:37 | |
*** rm_work has joined #openstack-keystone | 08:37 | |
*** Tahvok has joined #openstack-keystone | 08:37 | |
*** hyakuhei has joined #openstack-keystone | 08:37 | |
*** peterstac has joined #openstack-keystone | 08:37 | |
*** fungi has joined #openstack-keystone | 08:37 | |
*** gus has joined #openstack-keystone | 08:37 | |
*** ktychkova has joined #openstack-keystone | 08:37 | |
*** BlackDex has joined #openstack-keystone | 08:37 | |
*** david-lyle has joined #openstack-keystone | 08:37 | |
*** arunkant has joined #openstack-keystone | 08:37 | |
*** alex_xu has joined #openstack-keystone | 08:37 | |
*** erhudy has joined #openstack-keystone | 08:37 | |
*** jidar has joined #openstack-keystone | 08:37 | |
*** dancn has joined #openstack-keystone | 08:37 | |
*** toddnni has joined #openstack-keystone | 08:37 | |
*** akrzos has joined #openstack-keystone | 08:37 | |
*** clayton has joined #openstack-keystone | 08:37 | |
*** tepper.freenode.net sets mode: +v ayoung | 08:37 | |
*** timss has joined #openstack-keystone | 08:38 | |
*** EmilienM has quit IRC | 08:39 | |
*** EmilienM has joined #openstack-keystone | 08:39 | |
*** dmellado has joined #openstack-keystone | 08:39 | |
*** jraim has quit IRC | 08:40 | |
*** andrewbogott has quit IRC | 08:40 | |
*** cargonza has quit IRC | 08:40 | |
*** raddaoui has quit IRC | 08:40 | |
*** ctracey has quit IRC | 08:40 | |
*** AndyWojo has quit IRC | 08:40 | |
*** serverascode has quit IRC | 08:41 | |
openstackgerrit | Tin Lam proposed openstack/keystone: [WIP] Filtering invalid resources should return 400 Bad Request https://review.openstack.org/417315 | 08:41 |
*** nikhil has quit IRC | 08:41 | |
*** asettle has joined #openstack-keystone | 08:41 | |
*** DuncanT has joined #openstack-keystone | 08:45 | |
*** trananhkma has quit IRC | 08:45 | |
*** guoshan has joined #openstack-keystone | 08:46 | |
openstackgerrit | Shan Guo proposed openstack/keystone: Retry on deadlock Transactions in backend https://review.openstack.org/416872 | 08:47 |
*** AndyWojo has joined #openstack-keystone | 08:48 | |
*** raddaoui has joined #openstack-keystone | 08:49 | |
*** cargonza has joined #openstack-keystone | 08:51 | |
*** andrewbogott has joined #openstack-keystone | 08:52 | |
*** hrybacki has joined #openstack-keystone | 08:54 | |
*** nikhil has joined #openstack-keystone | 08:56 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-keystone | 09:00 | |
*** ctracey has joined #openstack-keystone | 09:02 | |
*** jraim has joined #openstack-keystone | 09:02 | |
*** serverascode has joined #openstack-keystone | 09:02 | |
*** guoshan has quit IRC | 09:07 | |
*** spzala has joined #openstack-keystone | 09:09 | |
*** spzala has quit IRC | 09:13 | |
*** timss has quit IRC | 09:27 | |
*** timss has joined #openstack-keystone | 09:27 | |
*** evrardjp has quit IRC | 09:33 | |
*** mvk has quit IRC | 09:33 | |
*** evrardjp has joined #openstack-keystone | 09:33 | |
*** nishaYadav has joined #openstack-keystone | 09:57 | |
*** nishaYadav is now known as Guest98550 | 09:58 | |
*** Guest98550 is now known as nishaYadav_ | 09:58 | |
*** liujiong has quit IRC | 10:05 | |
openstackgerrit | Merged openstack/pycadf: Remove references to Python 3.4 https://review.openstack.org/417255 | 10:06 |
*** udesale has quit IRC | 10:08 | |
*** mvk has joined #openstack-keystone | 10:20 | |
*** dikonoor has joined #openstack-keystone | 10:21 | |
nishaYadav_ | o/ | 11:06 |
*** richm has joined #openstack-keystone | 11:14 | |
nishaYadav_ | stevemar, hey! | 11:19 |
*** maestropandy has joined #openstack-keystone | 11:30 | |
*** maestropandy has left #openstack-keystone | 11:31 | |
*** dave-mccowan has joined #openstack-keystone | 12:03 | |
*** edmondsw has joined #openstack-keystone | 12:05 | |
*** edmondsw has quit IRC | 12:06 | |
*** edmondsw has joined #openstack-keystone | 12:06 | |
*** jamielennox is now known as jamielennox|away | 12:08 | |
openstackgerrit | Merged openstack/keystone: Remove references to Python 3.4 https://review.openstack.org/417235 | 12:13 |
stevemar | nishaYadav_: o/ | 12:13 |
rodrigods | stevemar, around for a couple of minutes to discuss the options for https://review.openstack.org/#/c/415906/10 ? | 12:15 |
nishaYadav_ | stevemar, hi | 12:15 |
nishaYadav_ | rodrigods, o/ | 12:15 |
rodrigods | hi nishaYadav_ :) | 12:15 |
stevemar | rodrigods: yep, just booking some travel | 12:15 |
rodrigods | stevemar, so... the option there is to create a new fk(cascade=true) in the expand phase with triggers to avoid writes to the protocol and idp tables | 12:16 |
rodrigods | later, in the contract phase, we drop the old the fk | 12:16 |
rodrigods | the doubt that i have is how to differ between the new fk and the old one | 12:17 |
rodrigods | or... we can leave it as it is and add an exempt for it | 12:18 |
stevemar | rodrigods: yeah, i'm really not sure how to differ btwn the keys | 12:21 |
stevemar | you can file an exception, i'm OK with that | 12:21 |
rodrigods | stevemar, ok, maybe we can gather some feedback in the review itself | 12:22 |
*** catintheroof has joined #openstack-keystone | 12:32 | |
*** catintheroof has quit IRC | 12:32 | |
*** catintheroof has joined #openstack-keystone | 12:32 | |
*** nishaYadav_ has quit IRC | 12:36 | |
*** catintheroof has quit IRC | 12:36 | |
*** catintheroof has joined #openstack-keystone | 12:37 | |
*** maestropandy has joined #openstack-keystone | 13:04 | |
*** maestropandy has left #openstack-keystone | 13:04 | |
*** spzala has joined #openstack-keystone | 13:10 | |
*** maestropandy1 has joined #openstack-keystone | 13:10 | |
*** maestropandy1 has left #openstack-keystone | 13:10 | |
*** maestropandy2 has joined #openstack-keystone | 13:13 | |
*** maestropandy2 has left #openstack-keystone | 13:13 | |
*** spzala has quit IRC | 13:14 | |
edmondsw | trying to help someone figure out a ci failure where 27 keystone tests around federation fail because they're policy forbidden. I'm assuming it's something to do with how they setup devstack. Tips on how to setup devstack for federation? | 13:17 |
*** maestropandy has joined #openstack-keystone | 13:27 | |
rodrigods | edmondsw, we have a plugin for it | 13:28 |
rodrigods | edmondsw, you enable keystone's plugin via "enable_plugin ..." | 13:28 |
rodrigods | and enable the federation service | 13:28 |
rodrigods | "enable_service keystone-saml2-federation" | 13:28 |
rodrigods | we have a bug that prevents all tests to pass, it is being addressed at https://review.openstack.org/#/c/415906/ | 13:29 |
rodrigods | dstanek, around? i'm trying to run keystone's tests against a local mysql setup with no luck | 13:31 |
*** maestropandy has quit IRC | 13:32 | |
edmondsw | rodrigods tx. And it's always been this way, right? No recent changes? This CI used to work fine... | 13:33 |
rodrigods | edmondsw, this is pretty new... I mean, ocata new | 13:33 |
edmondsw | hm, ok | 13:34 |
rodrigods | this is for functional tests, unit tests should work without it | 13:34 |
edmondsw | sure... it's functional that is blowing up | 13:34 |
rodrigods | edmondsw, besides that... we had a problem yesterday due a change in tempest | 13:34 |
*** nklenke has quit IRC | 13:34 | |
rodrigods | edmondsw, it was fixed here: https://review.openstack.org/#/c/417030/ | 13:35 |
rodrigods | stevemar, is it ok to put URLs in our docstring? need to update the docstring at test_sql_upgrade | 13:43 |
*** thorst_ has joined #openstack-keystone | 13:46 | |
edmondsw | rodrigods could you take a look at the failing CI's logs and see if it's the same issue you were seeing yesterday? http://184.172.12.213/69/416969/3/check/nova-powervm-pvm-dsvm-tempest-full/0302777/ | 13:48 |
rodrigods | edmondsw, yes, exactly the same issues | 13:51 |
edmondsw | rodrigods, thanks! | 13:51 |
edmondsw | thorst_ ^ | 13:51 |
thorst_ | edmondsw rodrigods: Thank you much...scratched my head for hours on that one yesterday... | 13:51 |
rodrigods | thorst_, :) | 13:52 |
edmondsw | thorst_ helps to ask! :) | 13:52 |
thorst_ | +1 | 13:52 |
*** spzala has joined #openstack-keystone | 13:54 | |
samueldmq | morning | 14:01 |
samueldmq | keystone working hours ? | 14:02 |
*** chlong has joined #openstack-keystone | 14:02 | |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Cascade delete federated_user fk https://review.openstack.org/415906 | 14:09 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Fix minor typo https://review.openstack.org/417388 | 14:09 |
rodrigods | "Fix minor typo" should be easy to approve ^ | 14:09 |
*** lamt has joined #openstack-keystone | 14:13 | |
stevemar | rodrigods: sure, put URLs in a docstring *shrug* | 14:15 |
stevemar | rodrigods: put a damn poem if it makes sense :) | 14:15 |
dstanek | samueldmq: morning | 14:23 |
samueldmq | dstanek: o/ | 14:23 |
samueldmq | stevemar: maybe the siphonaptera ? | 14:23 |
lbragstad | bug day! | 14:28 |
*** jaugustine has joined #openstack-keystone | 14:29 | |
*** dikonoor has quit IRC | 14:30 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD https://review.openstack.org/417263 | 14:33 |
samueldmq | lbragstad: dstanek: I will work to close this bug today ^ | 14:34 |
openstackgerrit | David Stanek proposed openstack/keystoneauth: Add __ne__ built-in function https://review.openstack.org/398294 | 14:34 |
samueldmq | well, not really a bug, but add that support in ksc | 14:34 |
lbragstad | samueldmq cool - sounds good | 14:35 |
stevemar | samueldmq: i'll be happy to review it :) | 14:35 |
lbragstad | same her e | 14:35 |
samueldmq | stevemar: lbragstad: nice, I will need help. I am not really a ninja in ksc yet | 14:36 |
samueldmq | hehe | 14:36 |
stevemar | samueldmq: look at how i did the implied roles work if you need a pointer | 14:36 |
*** links has quit IRC | 14:37 | |
stevemar | dstanek: funny, i was going to ask you about https://review.openstack.org/#/c/416830/ | 14:37 |
samueldmq | stevemar: kk will look for sure | 14:38 |
stevemar | dstanek: theres a KSC version of it | 14:38 |
dstanek | stevemar: what about it? i don't get why it's being changed | 14:39 |
stevemar | dstanek: see the bug report | 14:39 |
stevemar | dstanek: someone thought it could be done using non private functions and without mock | 14:39 |
stevemar | but... looks like he was off a bit? | 14:39 |
*** edtubill has joined #openstack-keystone | 14:41 | |
*** nklenke has joined #openstack-keystone | 14:41 | |
*** Dave has quit IRC | 14:41 | |
dstanek | hmmm.... let me take a quick peek and see if it can now be done a different way | 14:41 |
dstanek | that run_check method is run by *all* tests and not just one of them | 14:42 |
*** topol_ is now known as topol | 14:44 | |
*** ChanServ sets mode: +v topol | 14:44 | |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Update docstring at test_sql_upgrade https://review.openstack.org/417402 | 14:49 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Update docstring at test_sql_upgrade https://review.openstack.org/417402 | 14:49 |
*** nicolasbock has quit IRC | 15:04 | |
*** chris_hultin|AWA is now known as chris_hultin | 15:07 | |
*** voelzmo has joined #openstack-keystone | 15:14 | |
*** jaugustine_ has joined #openstack-keystone | 15:14 | |
*** phalmos has joined #openstack-keystone | 15:15 | |
*** phalmos has quit IRC | 15:20 | |
*** nicolasbock has joined #openstack-keystone | 15:20 | |
*** voelzmo has quit IRC | 15:20 | |
lbragstad | Does anyone here know if the owner of this patch hangs out in IRC at all? https://review.openstack.org/#/c/304489/ | 15:25 |
lbragstad | doesn't look like that ^ patch has been touched in a long time | 15:26 |
lbragstad | with a little work - we could use it to close https://bugs.launchpad.net/keystone/+bug/1557166 | 15:27 |
openstack | Launchpad bug 1557166 in OpenStack Identity (keystone) "V2 Endpoint creation with missing region returns 500" [Undecided,In progress] - Assigned to Kanika Singh (kanikasingh-1490) | 15:27 |
*** phalmos has joined #openstack-keystone | 15:28 | |
gagehugo | o/ | 15:30 |
lbragstad | gagehugo o/ | 15:31 |
*** jrist_ is now known as jrist | 15:33 | |
*** jrist has quit IRC | 15:33 | |
*** jrist has joined #openstack-keystone | 15:33 | |
dstanek | stevemar: i can 't see a good way to do it. maybe sigmavirus knows? | 15:34 |
sigmavirus | Those words usually mean I should run and hide | 15:34 |
sigmavirus | I mean, what's up? | 15:34 |
dstanek | i just want to call checker.run_check(something) and have it work, but that means i'd have to replicate register_check(), check_ast() and others | 15:34 |
sigmavirus | Flake8? | 15:34 |
dstanek | sigmavirus: was trying to see if there was a better way to run my checks without mocking | 15:35 |
dstanek | https://review.openstack.org/#/c/416830/1 | 15:35 |
dstanek | hmmm....i may just be thinking about this backward though | 15:35 |
dstanek | i could somehow attach the code to the classes and test based on that | 15:37 |
lbragstad | stevemar do we document endpoint groups anywhere? | 15:38 |
*** andrewbogott has quit IRC | 15:38 | |
*** andrewbogott has joined #openstack-keystone | 15:38 | |
sigmavirus | What if I take over that review from stevemar and dig around a bit more? | 15:38 |
sigmavirus | I have a very unfortunate understanding of all this nonsense | 15:38 |
stevemar | sigmavirus: you're more than welcome to | 15:39 |
dstanek | sigmavirus: sure, if you have the free time. | 15:39 |
sigmavirus | dstanek: that's a loaded statement, sir, and you know it | 15:40 |
stevemar | sigmavirus: there are 2 patches up for the bug, the KSC one is a bit easier, the keystone one mocks something at the base class | 15:40 |
dstanek | sigmavirus: i was just thinking that each class would have a new attribute 'CODES = []' that could be used in the select instead of hard coding the K333 | 15:40 |
dstanek | stevemar: keystone is what i am looking at now because it's a much more interesting case | 15:40 |
stevemar | sigmavirus: dstanek i was actually thinking we could just remove the K333 hacking check from the code base, i don't think importing oslo.log will work any longer? | 15:40 |
sigmavirus | dstanek: so here's the thing I'd like to accomplish by taking over the changes: making it easier for Keystone to transition to Flake8 3 when hacking does | 15:40 |
sigmavirus | stevemar: it won't | 15:41 |
dstanek | sigmavirus: whatever works | 15:41 |
dstanek | i'll move on to the next thing in my list then | 15:41 |
stevemar | sigmavirus: dstanek yeah, so for the keystoneclient side, we can remove that check | 15:41 |
sigmavirus | sounds then like you don't need me anyway? | 15:42 |
dstanek | sigmavirus: for keystone we do | 15:42 |
dstanek | we have 6 or 7 checks there and when i did it i unfortunately patched some internals of the libs | 15:43 |
dstanek | and had to use internals to get the reporting data i needed | 15:43 |
stevemar | sigmavirus: so to clarify, we need you for https://review.openstack.org/#/c/416830/ :) | 15:44 |
stevemar | i will rework https://review.openstack.org/#/c/416829/ to remove the hacking check, it's no longer necessary | 15:44 |
sigmavirus | roger, stevemar dstanek | 15:44 |
dstanek | sigmavirus: have fun and many thanks! | 15:44 |
sigmavirus | dstanek: for certain quantities of fun ... I will! | 15:45 |
sigmavirus | and you're welcome | 15:45 |
*** Dave has joined #openstack-keystone | 15:49 | |
*** ravelar has joined #openstack-keystone | 15:50 | |
*** mvk has quit IRC | 15:50 | |
openstackgerrit | Steve Martinelli proposed openstack/python-keystoneclient: remove hacking checks from keystoneclient https://review.openstack.org/416829 | 15:51 |
*** rcernin has quit IRC | 15:53 | |
*** jvarlamova_ has quit IRC | 15:55 | |
stevemar | dstanek: ^ | 15:56 |
openstackgerrit | Ron De Rose proposed openstack/keystone: Require domain_id when registering Identity Providers https://review.openstack.org/399684 | 16:05 |
*** Dave has quit IRC | 16:05 | |
*** voelzmo has joined #openstack-keystone | 16:06 | |
dstanek | stevemar: great thanks! | 16:08 |
*** toddnni has quit IRC | 16:15 | |
*** sheel has quit IRC | 16:17 | |
*** agrebennikov has joined #openstack-keystone | 16:20 | |
*** jaugustine_ has quit IRC | 16:28 | |
*** adrian_otto has joined #openstack-keystone | 16:28 | |
*** toddnni has joined #openstack-keystone | 16:28 | |
*** diazjf has joined #openstack-keystone | 16:30 | |
lbragstad | stevemar ping - is this example right? http://developer.openstack.org/api-ref/identity/v3-ext/index.html#os-ep-filter-api | 16:32 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Retry on deadlock Transactions in backend https://review.openstack.org/416872 | 16:32 |
stevemar | samueldmq: ^ | 16:33 |
stevemar | lbragstad: hmmm | 16:33 |
stevemar | lbragstad: what makes youthink its wrong? | 16:33 |
lbragstad | stevemar the filters dictionary of the endpoint group has keys of 'interface' and 'service_id', but then it says that it will filter based on 'region_id'? | 16:33 |
lbragstad | it's saying the service_id == region_id in the example? | 16:34 |
*** stingaci has joined #openstack-keystone | 16:34 | |
*** diazjf has quit IRC | 16:35 | |
stevemar | i guess it's poorly worded | 16:35 |
stevemar | also we dont need the ``'s on ``region_id = "1b501"`` | 16:35 |
edmondsw | lbragstad doesn't appear to be on regularly: https://www.google.com/search?q=site%3Aeavesdrop.openstack.org+kanika&ie=utf-8&oe=utf-8 | 16:35 |
*** diazjf has joined #openstack-keystone | 16:36 | |
lbragstad | edmondsw gotcha - good to know... nice google query btw | 16:36 |
stevemar | lbragstad: looks wrong to me :) | 16:36 |
stevemar | lbragstad: https://github.com/openstack/keystone-specs/blob/master/attic/v3/identity-api-v3-os-ep-filter-ext.rst#endpoint-group | 16:36 |
stevemar | lbragstad: i'll fix it up quickly | 16:37 |
lbragstad | stevemar nice - thanks! | 16:37 |
lbragstad | I was gonna say - i have no idea how that association makes sense | 16:37 |
lbragstad | stevemar you could go ahead and remove the interface from that example too, since I don't think that is suppose to be there either. | 16:38 |
stevemar | yep | 16:38 |
*** itisha has joined #openstack-keystone | 16:39 | |
lbragstad | stevemar that whole section needs love | 16:41 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: [api] fix ep filter example https://review.openstack.org/417443 | 16:44 |
stevemar | lbragstad: cooooming up | 16:44 |
*** mjb has quit IRC | 16:44 | |
*** mjb has joined #openstack-keystone | 16:44 | |
*** tesseract has quit IRC | 16:47 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove endpoint_id parameter from EP-FILTER docs https://review.openstack.org/417445 | 16:47 |
*** jose-phillips has joined #openstack-keystone | 16:50 | |
stevemar | lamt: oh wow, i didn't know we even tested invalid filters https://review.openstack.org/#/c/417315/1/keystone/tests/unit/test_v3_filters.py | 16:51 |
samueldmq | hey, we're getting things done ! o/ | 16:51 |
stevemar | lamt: thanks for picking it up! | 16:51 |
samueldmq | lbragstad: want to give https://review.openstack.org/#/c/399684 another look ? | 16:52 |
lamt | stevemar: Np. I didn't either, but right now it just siliently dropping bad query parameter. | 16:52 |
samueldmq | lbragstad: I doing the last check before approving, if you are okay with it too | 16:52 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Fix region_id responses and requests to be consistent https://review.openstack.org/417446 | 16:54 |
lbragstad | stevemar well need those two patches, too ^ | 16:54 |
dstanek | ok, today's meetings are now over! | 16:55 |
*** jaosorior has joined #openstack-keystone | 16:55 | |
openstackgerrit | Steve Martinelli proposed openstack/python-keystoneclient: remove hacking checks from keystoneclient https://review.openstack.org/416829 | 16:56 |
stevemar | lunch soon :) | 16:56 |
gagehugo | rderose ping: I'm not really sure what needs to be changed in the api-ref for https://review.openstack.org/#/c/404022/ | 16:57 |
gagehugo | yay lunch | 16:57 |
rderose | gagehugo: somehow we need to document in our API that this method does not require token authentication | 16:58 |
gagehugo | rderose: ah ok, ty | 16:58 |
samueldmq | lbragstad: want to approve that one too or just send another patch set to Steve's ? | 16:58 |
*** jaugustine_ has joined #openstack-keystone | 16:59 | |
lbragstad | samueldmq which one? | 16:59 |
samueldmq | lbragstad: https://review.openstack.org/#/c/417446 | 16:59 |
samueldmq | or just update https://review.openstack.org/#/c/417443 | 16:59 |
lbragstad | samueldmq either way works for me - I can pull it into the previous one | 17:00 |
lbragstad | doesn't matter to me | 17:00 |
samueldmq | lbragstad: I mean, that will cause a merge conflict, Steve's is gating | 17:02 |
samueldmq | lbragstad: either submit another patchset to his or update yours | 17:02 |
samueldmq | lbragstad: I don't mind either, let's just get it done :0 | 17:02 |
samueldmq | :) | 17:02 |
lbragstad | rderose https://review.openstack.org/#/c/399684/36 looks good to me | 17:03 |
lbragstad | samueldmq well - if stevemar's is gating lets not update it | 17:03 |
samueldmq | lbragstad: ++ | 17:03 |
rderose | lbragstad: cool, thanks! | 17:04 |
lbragstad | samueldmq i'll just resolve the merge conflict later with a follow on - and i'm sure i'll have more fixes to the OS-EP-FILTER docs anyway | 17:04 |
samueldmq | lbragstad: ++ | 17:04 |
rderose | and thanks stevemar and samueldmq for your reviews on that patch :) | 17:04 |
*** esp has joined #openstack-keystone | 17:08 | |
samueldmq | rderose: np, approved, well done | 17:09 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD https://review.openstack.org/417263 | 17:10 |
samueldmq | stevemar: dstanek: lbragstad: I am getting errors like http://paste.openstack.org/show/594135/ on ^ | 17:10 |
samueldmq | requests_mock.exceptions.NoMockAddress: No mock address: GET http://127.0.0.1:5000/v3/OS-EP-FILTER/endpoint_groups | 17:11 |
samueldmq | might be something really simple I am missing | 17:11 |
lbragstad | samueldmq i want to say the client uses inspection to create mock urls (?) | 17:11 |
lbragstad | so you might need to add the path somewhere in the client? | 17:12 |
samueldmq | lbragstad: hmm maybe, I will have a glance on that direction, thanks | 17:12 |
openstackgerrit | Tin Lam proposed openstack/keystone: [WIP] Filtering invalid resources should return 400 Bad Request https://review.openstack.org/417315 | 17:16 |
dstanek | samueldmq: let me know if you need any help | 17:20 |
*** jaosorior has quit IRC | 17:21 | |
*** nicolasbock has quit IRC | 17:23 | |
lbragstad | so - just to give people a status. I am going to be working on triaging bugs today, specifically the ones we have in progress | 17:24 |
lbragstad | i want to make sure we keep the ball rolling on bugs we have patches in review for | 17:25 |
lbragstad | and a side-effect of doing just on https://bugs.launchpad.net/keystone/+bug/1642985 - i am going through the OS-EP-FILTER documentation | 17:25 |
openstack | Launchpad bug 1642985 in OpenStack Identity (keystone) "Support for arrays of entities in endpoint group definition" [Wishlist,In progress] - Assigned to Jose Castro Leon (jose-castro-leon) | 17:25 |
lbragstad | and just for some stats - this morning we had 116 open bugs | 17:27 |
samueldmq | dstanek: kk thanks, I am trying a few things here | 17:28 |
openstackgerrit | Gage Hugo proposed openstack/keystone: Allow user to change own expired password https://review.openstack.org/404022 | 17:29 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Remove comment from previous migration https://review.openstack.org/417455 | 17:29 |
lbragstad | stevemar looking through the OS-EP-FILTER examples again, and maybe we should change it back to service_id instead of region_id... all the responses are written to return projects based on the service_id filter | 17:34 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Cascade delete federated_user fk https://review.openstack.org/415906 | 17:35 |
*** jaugustine_ has quit IRC | 17:38 | |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Update docstring at test_sql_upgrade https://review.openstack.org/417402 | 17:40 |
dstanek | fg | 17:42 |
*** woodster_ has joined #openstack-keystone | 17:47 | |
*** jerrygb has joined #openstack-keystone | 17:50 | |
openstackgerrit | Merged openstack/keystone: Fix minor typo https://review.openstack.org/417388 | 17:54 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD https://review.openstack.org/417263 | 17:59 |
*** browne has joined #openstack-keystone | 18:00 | |
*** pcaruana has quit IRC | 18:01 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Force users to immediately change their password upon first use https://review.openstack.org/403916 | 18:04 |
*** spzala has quit IRC | 18:05 | |
*** spzala has joined #openstack-keystone | 18:06 | |
*** thorst_ has quit IRC | 18:10 | |
gagehugo | many changes | 18:10 |
*** spzala has quit IRC | 18:10 | |
stevemar | lbragstad: oh? | 18:11 |
stevemar | lbragstad: i'll fix it up then | 18:11 |
openstackgerrit | Merged openstack/keystoneauth: Add __ne__ built-in function https://review.openstack.org/398294 | 18:12 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Retry on deadlock Transactions in backend https://review.openstack.org/416872 | 18:14 |
*** mvk has joined #openstack-keystone | 18:20 | |
*** jdennis has quit IRC | 18:22 | |
*** jdennis has joined #openstack-keystone | 18:22 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD https://review.openstack.org/417263 | 18:26 |
samueldmq | dstanek: lbragstad: stevemar ^ it is reviewable now, tests passing and has docs | 18:27 |
samueldmq | notice I have not put it into the v3/contrib as OS-EP-FILTER it is not an extension in keystone server anymore | 18:28 |
samueldmq | let me know if you agree with that | 18:28 |
*** jaugustine_ has joined #openstack-keystone | 18:29 | |
*** jaugustine_ has quit IRC | 18:34 | |
*** jaugustine_ has joined #openstack-keystone | 18:41 | |
*** thorst_ has joined #openstack-keystone | 18:42 | |
stevemar | samueldmq: should be fine | 18:45 |
stevemar | samueldmq: i'll try it out | 18:49 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Update docstring at test_sql_upgrade https://review.openstack.org/417402 | 18:49 |
samueldmq | stevemar: nice, thanks! | 18:50 |
samueldmq | stevemar: I will write a few functional tests in a follow up | 18:50 |
samueldmq | can't do that now :( | 18:50 |
*** jerrygb_ has joined #openstack-keystone | 18:57 | |
*** jerrygb has quit IRC | 19:00 | |
openstackgerrit | Merged openstack/keystone: Require domain_id when registering Identity Providers https://review.openstack.org/399684 | 19:03 |
samueldmq | rderose: ^ \o/ | 19:04 |
rderose | samueldmq: sweet! \o/ | 19:09 |
openstackgerrit | Ron De Rose proposed openstack/keystone: Update docs to require domain_id when registering Identity Providers https://review.openstack.org/399157 | 19:09 |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Cascade delete federated_user fk https://review.openstack.org/415906 | 19:11 |
stevemar | dstanek: around? | 19:13 |
stevemar | dstanek: this bug has been waiting for your final approval: https://review.openstack.org/#/c/380376/ | 19:13 |
*** voelzmo has quit IRC | 19:20 | |
*** voelzmo has joined #openstack-keystone | 19:21 | |
*** raginbajin has quit IRC | 19:21 | |
*** marekd has quit IRC | 19:22 | |
*** voelzmo has quit IRC | 19:25 | |
openstackgerrit | Gage Hugo proposed openstack/keystone: Allow user to change own expired password https://review.openstack.org/404022 | 19:26 |
*** jaugustine_ has quit IRC | 19:28 | |
*** jaugustine_ has joined #openstack-keystone | 19:31 | |
openstackgerrit | Merged openstack/keystone: [api] fix ep filter example https://review.openstack.org/417443 | 19:33 |
lamt | Should https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_v3_identity.py#L197 be ?domain_id= and not ?domain-id=? | 19:38 |
openstackgerrit | Merged openstack/keystone: Remove endpoint_id parameter from EP-FILTER docs https://review.openstack.org/417445 | 19:39 |
ayoung | stevemar, any low hanging fruit for review? | 19:39 |
*** ravelar has quit IRC | 19:41 | |
openstackgerrit | Merged openstack/python-keystoneclient: remove hacking checks from keystoneclient https://review.openstack.org/416829 | 19:41 |
stevemar | lamt: i think we want to keep it as domain-id, but assert that it results in a 400 now | 19:41 |
stevemar | ayoung: ummm | 19:41 |
lamt | stevemar: thanks | 19:41 |
*** spzala has joined #openstack-keystone | 19:42 | |
stevemar | ayoung: i think we got the easy ones | 19:42 |
ayoung | stevemar, I'm going to try and see why https://review.openstack.org/#/c/257636/ is failing, and resubmit, but could you please review the prereqs | 19:42 |
ayoung | be nice to at least close 968696 on the Keystone side | 19:43 |
stevemar | ayoung: wilco, it's been on my list of things to review for a while | 19:43 |
ayoung | stevemar, thanks | 19:43 |
*** jerrygb_ has quit IRC | 19:43 | |
*** voelzmo has joined #openstack-keystone | 19:47 | |
*** nkinder has quit IRC | 19:53 | |
*** nkinder has joined #openstack-keystone | 19:53 | |
*** ravelar has joined #openstack-keystone | 19:54 | |
*** voelzmo_ has joined #openstack-keystone | 19:59 | |
*** jerrygb has joined #openstack-keystone | 20:02 | |
*** voelzmo has quit IRC | 20:02 | |
*** jerrygb has quit IRC | 20:03 | |
*** jerrygb has joined #openstack-keystone | 20:03 | |
*** voelzmo_ has quit IRC | 20:03 | |
stevemar | samueldmq can you revisit https://review.openstack.org/#/c/413869/3 | 20:09 |
stevemar | anyone feel like picking up https://review.openstack.org/#/c/416260/ ? it just needs one test to pass :\ | 20:10 |
dstanek | stevemar: i'll take a look at it | 20:11 |
stevemar | sure, i'm looking at another bug, figured i'd spread the bug love | 20:11 |
lbragstad | stevemar do we have a convention for controllers requiring a bunch of managers? | 20:12 |
*** ravelar has quit IRC | 20:12 | |
lbragstad | or should the controllers only care about their respective managers and have the managers require other managers? | 20:12 |
stevemar | lbragstad: i think we only create a manager when we need one | 20:12 |
*** jerrygb_ has joined #openstack-keystone | 20:13 | |
lbragstad | stevemar sure - let me grab an example | 20:13 |
stevemar | ya, might be easier that way :) | 20:13 |
*** jaugustine_ has quit IRC | 20:13 | |
lbragstad | stevemar https://github.com/openstack/keystone/blob/64dbcf159d5c164547885fa619b7e3c8fb5dc72f/keystone/catalog/controllers.py#L430-L440 | 20:14 |
lbragstad | stevemar take a look at that comment ^ | 20:14 |
lbragstad | stevemar that specific controller has a dependency on the resource_api in order to validate some piece of that request https://github.com/openstack/keystone/blob/64dbcf159d5c164547885fa619b7e3c8fb5dc72f/keystone/catalog/controllers.py#L408 | 20:14 |
*** jerrygb has quit IRC | 20:15 | |
lbragstad | is that something we would consider business logic that should be handled by the manager? | 20:15 |
lbragstad | stevemar I just stumbled across this as I'm working on the documentation and noticed that - I wasn't sure if we had a convention for that or not | 20:15 |
samueldmq | stevemar: I will revisit that in a bit once I am on the laptop again | 20:16 |
dstanek | lbragstad: i would say that's a manager thing | 20:17 |
*** jerrygb has joined #openstack-keystone | 20:17 | |
lbragstad | dstanek yeah - that's what i was thinking | 20:17 |
*** jaugustine_ has joined #openstack-keystone | 20:17 | |
lbragstad | dstanek it seems like a total nit - but i didn't know the answer | 20:17 |
*** voelzmo has joined #openstack-keystone | 20:19 | |
*** jerrygb_ has quit IRC | 20:19 | |
*** jaugustine_ has quit IRC | 20:21 | |
*** ayoung_ has joined #openstack-keystone | 20:22 | |
*** voelzmo has quit IRC | 20:23 | |
openstackgerrit | Gage Hugo proposed openstack/keystone: Fixed not in toctree warnings when building docs https://review.openstack.org/417497 | 20:24 |
*** ayoung_ has quit IRC | 20:25 | |
ayoung | stevemar, all of the failing tests in https://review.openstack.org/#/c/257636/ have to do with domain scoped tokens | 20:26 |
ayoung | I freaken hate domain scoped tokens | 20:26 |
ayoung | I might need to update the policy.json so that some of the operations for domain stuff accepts domain scoped tokens for the default policy file...think that is safe? | 20:27 |
*** diazjf has quit IRC | 20:31 | |
*** spzala has quit IRC | 20:37 | |
samueldmq | stevemar: about https://review.openstack.org/#/c/413869/3/ | 20:38 |
samueldmq | stevemar: I am fine with that as it is, however as per my comment I think 'this folder' would sound better than 'the following folder' since it's in that folder | 20:39 |
samueldmq | I can do a quick edit/reply on that if you want | 20:39 |
*** nkinder has quit IRC | 20:42 | |
*** jaugustine_ has joined #openstack-keystone | 20:42 | |
*** stingaci has quit IRC | 20:43 | |
dstanek | samueldmq: what's a folder? | 20:43 |
samueldmq | dstanek: a directory ? | 20:44 |
samueldmq | dstanek: if it is not the right naming, I am just re-using what's in https://review.openstack.org/#/c/413869/3/superseded/README.rst | 20:44 |
samueldmq | :) | 20:44 |
*** spzala has joined #openstack-keystone | 20:45 | |
samueldmq | dstanek always asks me hard questions | 20:46 |
*** ravelar has joined #openstack-keystone | 20:47 | |
dstanek | lol, i don't use windows so i don't always remember the terminology | 20:49 |
*** spzala has quit IRC | 20:49 | |
dstanek | stevemar: i swear i saw a review that was using content-type to decide if something should be logged | 20:53 |
ayoung | GAH! so the cloudsample rule can't pass in the case of the test keystone.tests.unit.test_v3_identity.IdentityTestCase.test_create_user_without_domain becasue we have nio domainid in the user object to check | 20:54 |
ayoung | Do we have an "is none" check we can do? | 20:55 |
*** nkinder has joined #openstack-keystone | 20:55 | |
*** voelzmo has joined #openstack-keystone | 20:56 | |
*** Dave has joined #openstack-keystone | 21:00 | |
*** voelzmo has quit IRC | 21:01 | |
openstackgerrit | Gage Hugo proposed openstack/keystone: Remove stevedore warning when building docs https://review.openstack.org/417508 | 21:02 |
samueldmq | dstanek: hehe | 21:02 |
samueldmq | dstanek: so there was one from me .. want a link ? | 21:02 |
dstanek | samueldmq: sure | 21:03 |
samueldmq | dstanek: https://review.openstack.org/#/q/topic:bug/1616105 | 21:03 |
*** spzala has joined #openstack-keystone | 21:04 | |
*** spzala has quit IRC | 21:05 | |
*** spzala has joined #openstack-keystone | 21:05 | |
*** dave-mccowan has quit IRC | 21:10 | |
*** browne has quit IRC | 21:13 | |
*** voelzmo has joined #openstack-keystone | 21:14 | |
*** catintheroof has quit IRC | 21:18 | |
*** voelzmo has quit IRC | 21:18 | |
*** browne has joined #openstack-keystone | 21:19 | |
*** chris_hultin is now known as chris_hultin|AWA | 21:22 | |
*** jaugustine_ has quit IRC | 21:25 | |
*** asettle has quit IRC | 21:25 | |
ayoung | stevemar, dstanek samueldmq I want to break backwards compatibility and I have a really good reason | 21:25 |
ayoung | test_create_user_without_domain | 21:26 |
ayoung | uses the domain from the token if not specified | 21:26 |
ayoung | none of our policy files yet would actually let that pass | 21:26 |
ayoung | pretty sure that the cloudsample must not test it, as the check it has for that policy rule does not pass | 21:27 |
dstanek | ayoung: what do you want to do? | 21:27 |
ayoung | in order to make it work, we need to enforce policy inside the create_user call, and default the value prior to passing to policy | 21:27 |
ayoung | dstanek, drop the rule that says you can create a user without specifying a domain_id for the user | 21:28 |
ayoung | or, stated better, start requiring a domain_id on a create user call | 21:28 |
openstackgerrit | Merged openstack/keystone: Wrap invalidation region to context-local cache https://review.openstack.org/380376 | 21:28 |
dstanek | ayoung: what do we do now? try to get the default domain? | 21:28 |
ayoung | dstanek, I think that it matches the domain_id from the requesting user's token | 21:29 |
stevemar | dstanek: there were several fixes for content-type that went around | 21:29 |
dstanek | that's kinda weird | 21:29 |
stevemar | dstanek: we needed fixes for logging response and request, for both KSC and KSA | 21:30 |
*** dave-mccowan has joined #openstack-keystone | 21:30 | |
dstanek | stevemar: i have the test working...manually testing and looking for corner cases | 21:30 |
ayoung | its a case of enforcing policy on the content of the request, which is OK, but that is the scope check, and in this case, there is no way to default the scope check: | 21:30 |
ayoung | we are asking policy to know that, in this case, if the domain_id is not specified, it is OK to let the call through | 21:30 |
ayoung | but in other cases, where the domain_id does not match, we should deny the request | 21:31 |
ayoung | its icky | 21:31 |
*** voelzmo has joined #openstack-keystone | 21:32 | |
dstanek | ayoung: so the options are to either enforce policy after the domain has been picked or to just for users to start using a domain? | 21:34 |
dstanek | for some reason i thought that v3 force you to supply a domain when creating a user | 21:35 |
ayoung | dstanek, not according to the unit test | 21:35 |
ayoung | dstanek, to make this work, here is what I would have to do: | 21:35 |
ayoung | 1. replace the decorator code with inlie code that does the same thing (not a big deal, we want to head that way anyway) | 21:35 |
*** voelzmo has quit IRC | 21:36 | |
ayoung | 2. validate the auth token, becuase right now that is done inside the validation logic. Don't have the domiaiNid yet | 21:36 |
ayoung | 3. check the user object from the request, and, if it is missing the domain_id, populate it from the token | 21:36 |
ayoung | and...I think it wouild need logic to look for both the domain_id or the domain_name, based on other APIs | 21:37 |
openstackgerrit | Steve Martinelli proposed openstack/keystone-specs: add a README file to the superseded spec folder https://review.openstack.org/413869 | 21:37 |
ayoung | dstanek, so, while it is do-able, it is ugly. And, AFAICT, it has never really worked | 21:38 |
ayoung | well, it has if you used project scoped tokens, the v3 api with standard policy, and accepted role:admin for anything | 21:38 |
ayoung | the moment you try to enforce scope, it blows up | 21:38 |
ayoung | dstanek, I'm almost tempted to work through it just to see how bad the code actually is | 21:39 |
ayoung | its the token validation part that I don;t like ATM | 21:39 |
samueldmq | ayoung: lbragstad easy +A https://review.openstack.org/#/c/413869 | 21:40 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Remove stevedore warning when building docs https://review.openstack.org/417508 | 21:40 |
ayoung | samueldmq, https://review.openstack.org/#/c/413869/4/superseded/README.rst Does not list the spec you removed in this review | 21:41 |
samueldmq | ayoung: which one ? | 21:42 |
ayoung | https://review.openstack.org/#/c/413869/4/specs/keystone/ocata/token-provider-cleanup.rst samueldmq | 21:42 |
samueldmq | ayoung: that's true :( stevemar ^ | 21:44 |
stevemar | oh damn, nice catch ayoung | 21:46 |
stevemar | umm, anyone know why i moved it there? :) | 21:46 |
*** nkinder has quit IRC | 21:48 | |
*** voelzmo has joined #openstack-keystone | 21:50 | |
*** thorst_ has quit IRC | 21:50 | |
*** edtubill has quit IRC | 21:52 | |
*** stingaci has joined #openstack-keystone | 21:52 | |
lbragstad | i think some of the tables we have in our api-ref contains lists and they don't render properly | 21:54 |
*** voelzmo has quit IRC | 21:54 | |
lbragstad | http://developer.openstack.org/api-ref/identity/v3/index.html?expanded=create-service-detail,create-endpoint-detail for example | 21:54 |
*** spzala has quit IRC | 21:56 | |
samueldmq | lbragstad: those are rendering okay to me | 21:56 |
samueldmq | lbragstad: is there anything specific on the tables you think they're rendering wrongly ? | 21:57 |
lbragstad | samueldmq if you look closely at the 'Request Parameters' table | 21:57 |
samueldmq | lbragstad: nvm, it's the lists, not the tables themselves | 21:57 |
* samueldmq facepalm | 21:57 | |
lbragstad | right - it looks like we're trying to use lists inside the table | 21:58 |
samueldmq | ++ | 21:58 |
*** stingaci has quit IRC | 21:58 | |
lbragstad | and it's not rendering properly... | 21:58 |
lbragstad | i had to re-read it 5 times to figure out what was going on | 21:58 |
samueldmq | 10 times here | 22:00 |
samueldmq | :) | 22:00 |
*** catintheroof has joined #openstack-keystone | 22:01 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD https://review.openstack.org/417263 | 22:02 |
*** nkinder has joined #openstack-keystone | 22:02 | |
*** thorst_ has joined #openstack-keystone | 22:05 | |
*** jaugustine_ has joined #openstack-keystone | 22:09 | |
samueldmq | I can call it a day, I am checking out for the week | 22:09 |
samueldmq | have a great weekend, keystoners | 22:09 |
dstanek | samueldmq: you too | 22:09 |
lbragstad | samueldmq thanks for the help today - have a nice weekend! | 22:10 |
samueldmq | dstanek: lbragstad o/ | 22:10 |
*** thorst_ has quit IRC | 22:11 | |
samueldmq | lbragstad: suer | 22:11 |
*** jerrygb has quit IRC | 22:13 | |
*** jaugustine_ has quit IRC | 22:13 | |
*** jaugustine_ has joined #openstack-keystone | 22:17 | |
*** dave-mccowan has quit IRC | 22:22 | |
openstackgerrit | Samuel Pilla proposed openstack/keystone: Add password expiration queries for PCI-DSS https://review.openstack.org/403898 | 22:29 |
openstackgerrit | Gage Hugo proposed openstack/keystone: Fixed not in toctree warnings when building docs https://review.openstack.org/417497 | 22:34 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: [api-ref] Clean up OS-EP-FILTER documentation https://review.openstack.org/417528 | 22:39 |
*** asettle has joined #openstack-keystone | 22:39 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: [api-ref] Clean up OS-EP-FILTER documentation https://review.openstack.org/417528 | 22:40 |
*** lamt has quit IRC | 22:43 | |
*** jaugustine_ has quit IRC | 22:44 | |
*** jaugustine has quit IRC | 22:44 | |
*** asettle has quit IRC | 22:48 | |
*** diazjf has joined #openstack-keystone | 22:57 | |
*** diazjf has quit IRC | 22:59 | |
*** thorst has joined #openstack-keystone | 23:00 | |
*** thorst has quit IRC | 23:03 | |
*** edmondsw has quit IRC | 23:06 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: [api-ref] Clean up OS-EP-FILTER association docs https://review.openstack.org/417533 | 23:08 |
lbragstad | stevemar ok - i think i'm done with the OS-EP-FILTER docs ^ | 23:08 |
*** blake has joined #openstack-keystone | 23:17 | |
openstackgerrit | David Stanek proposed openstack/python-keystoneclient: Do not log binary data during request https://review.openstack.org/416260 | 23:31 |
*** jamielennox|away is now known as jamielennox | 23:39 | |
*** spzala has joined #openstack-keystone | 23:41 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!