*** chlong has quit IRC | 00:01 | |
*** stingaci has joined #openstack-keystone | 00:02 | |
*** edtubill has joined #openstack-keystone | 00:03 | |
*** lucas__ has quit IRC | 00:04 | |
*** stingaci has quit IRC | 00:07 | |
*** guoshan has joined #openstack-keystone | 00:09 | |
*** guoshan has quit IRC | 00:14 | |
*** agrebennikov has quit IRC | 00:19 | |
morgan | stevemar: huh. supposedly authContext should have protected against changing user_id... but clearly it didnt | 00:29 |
---|---|---|
morgan | oooh maybe it did | 00:29 |
ayoung | morgan, remove your change and run the test | 00:30 |
morgan | ooor. it didn't. | 00:30 |
morgan | ayoung: i just did doesn't get caught properly in the __setitem__ for AuthContext | 00:31 |
ayoung | ah...so not the first time someone thought of it. | 00:31 |
*** itisha has quit IRC | 00:32 | |
morgan | ayoung: yeah my test fails w/o special code to verify no change. plugins should not under any circumstance be able to change some values in AuthContext | 00:34 |
morgan | so something wonky is happening | 00:34 |
morgan | https://www.irccloud.com/pastebin/lhxZyDDY/ | 00:35 |
morgan | ^ that should totally prevent my test from failing | 00:35 |
morgan | tests of setting directly on AuthContext show that is in-fact the case. | 00:36 |
morgan | i think. | 00:36 |
morgan | yeah direct test of AuthContext object shows correct behavior. | 00:37 |
morgan | but the auth controller behaves differently | 00:37 |
*** thorst_ has joined #openstack-keystone | 00:38 | |
*** jose-phillips has quit IRC | 00:40 | |
*** thorst_ has quit IRC | 00:43 | |
morgan | huh. this is weird. | 00:43 |
*** hoangcx has joined #openstack-keystone | 00:48 | |
*** tqtran has joined #openstack-keystone | 00:49 | |
*** gyee has quit IRC | 00:54 | |
*** edtubill has quit IRC | 00:56 | |
*** thorst_ has joined #openstack-keystone | 00:59 | |
*** thorst_ has quit IRC | 01:03 | |
morgan | ayoung: i think i found the issue... | 01:04 |
morgan | ayoung: our tests suck | 01:04 |
ayoung | morgan, this is news? | 01:04 |
*** thorst_ has joined #openstack-keystone | 01:04 | |
morgan | yeah we explicitly make a dict() in tests | 01:04 |
morgan | instead of using the AuthContext object | 01:04 |
*** thorst_ has quit IRC | 01:04 | |
morgan | *facepalm* | 01:04 |
morgan | ayoung: i'm inclined to require controllers.Auth.authenticate() to receive an AuthContext item not a dict | 01:06 |
morgan | i know that isn't pythonic...but... | 01:06 |
morgan | it would ensure we are actually testing things. | 01:06 |
*** liujiong has joined #openstack-keystone | 01:16 | |
ayoung | dicts are not pythonic | 01:16 |
ayoung | morgan, did I mention that I am working in golang now? | 01:17 |
morgan | ayoung: you have. | 01:18 |
ayoung | morgan, it still does not have a preprocessor, so you can't do some essential things to avoid boilerplate code, but it is nice having a real type system again | 01:19 |
ayoung | morgan, headed into the office tomorrow. Meeting with BU/MOC folks. Hoping to have a team of students to work on the policy stuff for this semester | 01:21 |
morgan | cool | 01:23 |
*** ayoung has quit IRC | 01:28 | |
*** guoshan has joined #openstack-keystone | 01:34 | |
*** guoshan has quit IRC | 01:39 | |
*** guoshan has joined #openstack-keystone | 01:40 | |
openstackgerrit | Morgan Fainberg proposed openstack/keystone: Force use of AuthContext object in .authentcate() https://review.openstack.org/419693 | 01:51 |
*** adrian_otto has quit IRC | 01:52 | |
*** edtubill has joined #openstack-keystone | 02:00 | |
*** thorst_ has joined #openstack-keystone | 02:05 | |
*** phalmos has quit IRC | 02:05 | |
*** thorst_ has quit IRC | 02:08 | |
*** markvoelker has quit IRC | 02:09 | |
*** browne has quit IRC | 02:09 | |
*** dave-mccowan has joined #openstack-keystone | 02:17 | |
*** edtubill has quit IRC | 02:43 | |
openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/keystonemiddleware: Fix logging usage from oslo.log https://review.openstack.org/419724 | 02:46 |
*** spzala has joined #openstack-keystone | 02:51 | |
*** guoshan has quit IRC | 02:55 | |
*** guoshan has joined #openstack-keystone | 03:02 | |
*** edtubill has joined #openstack-keystone | 03:03 | |
*** edtubill has quit IRC | 03:03 | |
*** guoshan has quit IRC | 03:07 | |
*** guoshan has joined #openstack-keystone | 03:07 | |
*** tqtran has quit IRC | 03:09 | |
*** adrian_otto has joined #openstack-keystone | 03:22 | |
*** edtubill has joined #openstack-keystone | 03:23 | |
openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/keystonemiddleware: use oslo.log instead of logging https://review.openstack.org/419724 | 03:24 |
*** thorst_ has joined #openstack-keystone | 03:35 | |
stevemar | morgan: looks like some tests fail :( | 03:36 |
*** thorst_ has quit IRC | 03:37 | |
morgan | stevemar: hmm. | 03:37 |
morgan | stevemar: weird. it passed locally | 03:38 |
morgan | stevemar: but it's agood thing anywhere that test is failing, we are not protecting against auth plugins providing inaccurant and inconsistent data | 03:38 |
morgan | stevemar: we can ditch the new test actually | 03:41 |
*** adrian_otto has quit IRC | 03:41 | |
morgan | stevemar: do you think that error should be 500 or 401? | 03:52 |
morgan | stevemar: see rodrigods ' comment | 03:52 |
*** links has joined #openstack-keystone | 03:54 | |
*** guoshan has quit IRC | 03:55 | |
stevemar | morgan: def 401 | 03:59 |
morgan | ok fixed the errors (the dsvm error looks transient) | 04:01 |
morgan | waitng for another local run | 04:01 |
morgan | will push then | 04:01 |
*** spzala has quit IRC | 04:02 | |
*** tqtran has joined #openstack-keystone | 04:09 | |
*** kiran-r has joined #openstack-keystone | 04:09 | |
*** tqtran has quit IRC | 04:11 | |
*** nicolasbock has quit IRC | 04:16 | |
stevemar | why did i just find out about https://www.eventbrite.com/e/pycaribbean-2017-tickets-25625212701 | 04:19 |
*** adriant has quit IRC | 04:23 | |
*** dikonoor has joined #openstack-keystone | 04:24 | |
*** guoshan has joined #openstack-keystone | 04:27 | |
*** guoshan has quit IRC | 04:31 | |
*** guoshan has joined #openstack-keystone | 04:32 | |
*** guoshan has quit IRC | 04:37 | |
*** markvoelker has joined #openstack-keystone | 04:52 | |
*** masber has joined #openstack-keystone | 04:57 | |
openstackgerrit | Merged openstack/keystone: Adds projects mapping to the mapping engine https://review.openstack.org/410949 | 04:58 |
*** lucas__ has joined #openstack-keystone | 05:09 | |
*** adrian_otto has joined #openstack-keystone | 05:13 | |
*** lucas__ has quit IRC | 05:15 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: fix broken links https://review.openstack.org/419763 | 05:17 |
openstackgerrit | Steve Martinelli proposed openstack/keystonemiddleware: fix broken links https://review.openstack.org/419764 | 05:20 |
*** markvoelker_ has joined #openstack-keystone | 05:22 | |
openstackgerrit | Morgan Fainberg proposed openstack/keystone: Force use of AuthContext object in .authentcate() https://review.openstack.org/419693 | 05:25 |
*** v1k0d3n has joined #openstack-keystone | 05:26 | |
*** markvoelker has quit IRC | 05:26 | |
*** dave-mccowan has quit IRC | 05:27 | |
*** guoshan has joined #openstack-keystone | 05:37 | |
*** thorst_ has joined #openstack-keystone | 05:37 | |
*** adrian_otto has quit IRC | 05:40 | |
*** guoshan has quit IRC | 05:42 | |
*** thorst_ has quit IRC | 05:42 | |
*** hoangcx has quit IRC | 05:47 | |
*** stingaci has joined #openstack-keystone | 06:04 | |
*** stingaci has quit IRC | 06:08 | |
*** guoshan has joined #openstack-keystone | 06:09 | |
*** hoangcx has joined #openstack-keystone | 06:10 | |
*** v1k0d3n has quit IRC | 06:12 | |
*** dikonoor has quit IRC | 06:16 | |
*** hoangcx has quit IRC | 06:19 | |
*** guoshan has quit IRC | 06:24 | |
*** guoshan has joined #openstack-keystone | 06:24 | |
*** oomichi has quit IRC | 06:25 | |
*** oomichi has joined #openstack-keystone | 06:26 | |
*** oomichi has quit IRC | 06:30 | |
*** oomichi has joined #openstack-keystone | 06:31 | |
*** kiran-r has quit IRC | 06:35 | |
*** oomichi has quit IRC | 06:38 | |
*** oomichi has joined #openstack-keystone | 06:40 | |
*** richm has quit IRC | 06:41 | |
*** oomichi has quit IRC | 06:55 | |
*** oomichi has joined #openstack-keystone | 06:57 | |
*** Jack_I has joined #openstack-keystone | 07:05 | |
Jack_I | Folks! | 07:05 |
Jack_I | Who's broken newton? | 07:06 |
Jack_I | :) | 07:06 |
Jack_I | openstack endpoint list: __init__() got an unexpected keyword argument 'app_name' | 07:06 |
*** tqtran has joined #openstack-keystone | 07:11 | |
*** tesseract has joined #openstack-keystone | 07:11 | |
*** tqtran has quit IRC | 07:13 | |
openstackgerrit | Tovin Seven proposed openstack/keystone: Add DB operations tracing https://review.openstack.org/294535 | 07:23 |
*** voelzmo has joined #openstack-keystone | 07:23 | |
*** nikhil has quit IRC | 07:28 | |
*** hyakuhei has quit IRC | 07:30 | |
*** dhellmann has quit IRC | 07:30 | |
*** portdirect has quit IRC | 07:30 | |
*** voelzmo has quit IRC | 07:31 | |
*** nikhil has joined #openstack-keystone | 07:31 | |
*** portdirect has joined #openstack-keystone | 07:32 | |
*** dhellmann has joined #openstack-keystone | 07:35 | |
*** thorst_ has joined #openstack-keystone | 07:39 | |
*** hyakuhei has joined #openstack-keystone | 07:39 | |
*** AlexeyAbashkin has joined #openstack-keystone | 07:39 | |
*** voelzmo has joined #openstack-keystone | 07:41 | |
*** thorst_ has quit IRC | 07:43 | |
*** stingaci has joined #openstack-keystone | 07:51 | |
*** stingaci has quit IRC | 07:55 | |
*** guoshan has quit IRC | 07:55 | |
*** guoshan has joined #openstack-keystone | 07:56 | |
*** hyakuhei has quit IRC | 07:57 | |
*** aloga has quit IRC | 08:05 | |
*** aloga has joined #openstack-keystone | 08:05 | |
*** hyakuhei has joined #openstack-keystone | 08:06 | |
*** stingaci has joined #openstack-keystone | 08:10 | |
*** guoshan has quit IRC | 08:21 | |
*** guoshan has joined #openstack-keystone | 08:21 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-keystone | 09:00 | |
*** mvk has quit IRC | 09:25 | |
*** voelzmo has quit IRC | 09:29 | |
*** voelzmo has joined #openstack-keystone | 09:50 | |
*** mvk has joined #openstack-keystone | 09:56 | |
*** sheel has joined #openstack-keystone | 09:56 | |
*** hyakuhei has quit IRC | 09:58 | |
*** hyakuhei has joined #openstack-keystone | 09:58 | |
*** hyakuhei has quit IRC | 09:58 | |
*** hyakuhei has joined #openstack-keystone | 09:58 | |
*** voelzmo has quit IRC | 10:07 | |
*** liujiong has quit IRC | 10:08 | |
*** openstackgerrit has quit IRC | 10:18 | |
*** voelzmo has joined #openstack-keystone | 10:26 | |
*** guoshan has quit IRC | 10:31 | |
*** richm has joined #openstack-keystone | 11:13 | |
*** openstackgerrit has joined #openstack-keystone | 11:19 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone: Drop type in filters https://review.openstack.org/419451 | 11:19 |
openstackgerrit | Xuepeng Ji proposed openstack/python-keystoneclient: Removes unnecessary utf-8 encoding https://review.openstack.org/419889 | 11:26 |
*** nicolasbock has joined #openstack-keystone | 11:40 | |
*** thorst_ has joined #openstack-keystone | 11:40 | |
*** thorst_ has quit IRC | 11:45 | |
stevemar | breton & rodrigods since you two reviewed the keystone patch, how about the keystonemiddleware patch too? https://review.openstack.org/#/c/419764/ | 11:45 |
stevemar | whos ready for some bug stomping action? :) lbragstad dstanek | 11:47 |
*** voelzmo has quit IRC | 11:47 | |
*** openstackgerrit has quit IRC | 11:47 | |
*** voelzmo has joined #openstack-keystone | 11:50 | |
*** voelzmo has quit IRC | 11:50 | |
*** voelzmo has joined #openstack-keystone | 11:52 | |
*** voelzmo has quit IRC | 11:57 | |
*** ayoung has joined #openstack-keystone | 11:57 | |
*** ChanServ sets mode: +v ayoung | 11:57 | |
breton | i'll be ready in 1.5h | 12:05 |
*** openstackgerrit has joined #openstack-keystone | 12:05 | |
openstackgerrit | Merged openstack/keystone: fix broken links https://review.openstack.org/419763 | 12:05 |
stevemar | breton: sounds good to me | 12:18 |
*** voelzmo has joined #openstack-keystone | 12:19 | |
*** thiagolib has joined #openstack-keystone | 12:23 | |
*** catintheroof has joined #openstack-keystone | 12:30 | |
*** catintheroof has quit IRC | 12:31 | |
*** catintheroof has joined #openstack-keystone | 12:32 | |
*** thorst_ has joined #openstack-keystone | 12:41 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: update sample config for ocata release https://review.openstack.org/419949 | 12:58 |
*** voelzmo has quit IRC | 13:03 | |
*** thorst_ has quit IRC | 13:05 | |
*** thorst_ has joined #openstack-keystone | 13:09 | |
*** asettle__ has joined #openstack-keystone | 13:19 | |
*** asettle has quit IRC | 13:19 | |
openstackgerrit | Merged openstack/python-keystoneclient: Removes unnecessary utf-8 encoding https://review.openstack.org/419889 | 13:22 |
*** Dinesh_Bhor has quit IRC | 13:29 | |
openstackgerrit | Merged openstack/keystonemiddleware: fix broken links https://review.openstack.org/419764 | 13:30 |
*** asettle__ is now known as asettle | 13:33 | |
*** voelzmo has joined #openstack-keystone | 13:37 | |
*** AlexeyAbashkin has quit IRC | 13:37 | |
*** AlexeyAbashkin has joined #openstack-keystone | 13:40 | |
*** edmondsw has joined #openstack-keystone | 13:45 | |
breton | what to fix? | 13:55 |
stevemar | breton: you had something cooking didn't you? | 13:55 |
stevemar | breton: mapping purge? | 13:56 |
stevemar | breton: morgan also proposed https://review.openstack.org/#/c/419693/ | 13:56 |
stevemar | if you want to take over an old patch: https://review.openstack.org/#/c/304489/ | 13:56 |
stevemar | theres a bug here: https://docs.google.com/spreadsheets/d/156q820cXcEc8Y9YWQgoc_hyOm3AZ2jtMQM3zdDhwGFU/edit?usp=sharing | 13:57 |
breton | stevemar: i had 2 things -- check the patch that adds a query to fetch users with expiring passwords and the issue with shadow users not getting added to a group | 13:57 |
breton | *to any groups | 13:57 |
stevemar | breton: ++ | 13:57 |
stevemar | breton: rderose has been doing some of the shadow user work | 13:58 |
breton | the first one is a new feature and the second one is too big and relies on other patches | 13:58 |
stevemar | breton: https://review.openstack.org/#/q/topic:bug/1642687 | 13:58 |
breton | so i will probably take over https://review.openstack.org/#/c/304489/ | 13:58 |
morgan | mornin' | 13:58 |
stevemar | morgan: you're up early | 13:58 |
stevemar | i mean, i was up at the same time, but because a little humanoid woke me | 13:59 |
morgan | yah. making breakfast :) | 13:59 |
stevemar | breton: for 304489, i think only the test needs to be moved (for now) | 13:59 |
*** jaugustine has joined #openstack-keystone | 14:02 | |
stevemar | breton: we both commented on the same bug :P | 14:04 |
*** v1k0d3n has joined #openstack-keystone | 14:11 | |
stevemar | breton: thanks for doing a bunch of bug triaging the last few months | 14:13 |
breton | stevemar: happy to help | 14:17 |
knikolla | hey all. i'll be missing the keystone office hours today. have to be offsite. :( | 14:17 |
*** jperry has joined #openstack-keystone | 14:18 | |
*** edtubill has quit IRC | 14:23 | |
*** Ephur has joined #openstack-keystone | 14:37 | |
morgan | knikolla: it happens | 14:39 |
*** tqtran has joined #openstack-keystone | 14:39 | |
*** tqtran has quit IRC | 14:41 | |
dstanek | knikolla: offsite doing something fun i hope | 14:42 |
*** chlong has joined #openstack-keystone | 14:45 | |
*** markvoelker has joined #openstack-keystone | 14:51 | |
*** markvoelker_ has quit IRC | 14:51 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone: Handling of 'region' parameter as None https://review.openstack.org/304489 | 14:51 |
*** spzala has joined #openstack-keystone | 14:51 | |
*** edtubill has joined #openstack-keystone | 14:55 | |
*** jperry has quit IRC | 14:56 | |
*** jperry has joined #openstack-keystone | 14:57 | |
*** sheel has quit IRC | 14:57 | |
*** edtubill has quit IRC | 14:59 | |
*** dave-mccowan has joined #openstack-keystone | 15:00 | |
lbragstad | stevemar o/ | 15:04 |
*** jaosorior has joined #openstack-keystone | 15:05 | |
breton | that feel when forgot password from local postgres | 15:06 |
stevemar | hehe | 15:06 |
*** jaosorior has quit IRC | 15:07 | |
*** ayoung has quit IRC | 15:09 | |
lbragstad | has anyone happen to see http://lists.openstack.org/pipermail/openstack-dev/2017-January/110060.html ? | 15:12 |
*** jaosorior has joined #openstack-keystone | 15:16 | |
*** jaosorior has quit IRC | 15:19 | |
*** jaosorior has joined #openstack-keystone | 15:22 | |
*** dancn has quit IRC | 15:27 | |
*** markvoelker has quit IRC | 15:28 | |
*** chris_hultin|AWA is now known as chris_hultin | 15:29 | |
*** edtubill has joined #openstack-keystone | 15:32 | |
*** dancn has joined #openstack-keystone | 15:40 | |
*** phalmos has joined #openstack-keystone | 15:45 | |
lbragstad | if anyone is looking for a relatively straight forward bug to work on - https://bugs.launchpad.net/keystone/+bug/1656026 might be a good candidate | 15:48 |
openstack | Launchpad bug 1656026 in OpenStack Identity (keystone) "Exception don't follow a punctuation convention" [Undecided,New] | 15:48 |
*** mvk has quit IRC | 15:51 | |
edtubill | lbragstad: So I think I figured out what was happening to my federation environment from yesterday. It seems that validating scoped federated tokens won't work for UUID tokens but it works for fernet tokens. I switched to fernet tokens and federated token validation started working again :) | 15:51 |
*** agrebennikov has joined #openstack-keystone | 15:52 | |
lbragstad | edtubill huh... | 15:52 |
lbragstad | edtubill that's concerning | 15:53 |
lbragstad | cc stevemar dstanek ^ | 15:53 |
edtubill | lbragstad: So I guess I'll file a bug for someone to verify? | 15:53 |
*** markvoelker has joined #openstack-keystone | 15:54 | |
lbragstad | edtubill yeah | 15:54 |
lbragstad | edtubill and the *only* change you made was switching `keystone.conf [token] provider = fernet` right? | 15:55 |
*** markvoelker_ has joined #openstack-keystone | 15:55 | |
openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Cascade delete federated_user fk https://review.openstack.org/415906 | 15:55 |
*** markvoelker has quit IRC | 15:55 | |
edtubill | And I ran that command `keystone-manage fernet_tokens` | 15:55 |
*** spzala has quit IRC | 15:55 | |
lbragstad | `keystone-manage fernet_setup`? | 15:56 |
*** spzala has joined #openstack-keystone | 15:56 | |
edtubill | oh yeah that one... couldn't remember it exactly. | 15:56 |
lbragstad | cool - ok | 15:56 |
lbragstad | rderose o/ | 15:56 |
rderose | lbragstad: morning | 15:57 |
lbragstad | rderose morning! | 15:57 |
lbragstad | rderose do you know if we removed support for federated token types? | 15:57 |
rderose | lbragstad: no, not yet | 15:57 |
lbragstad | ok | 15:57 |
*** phalmos has quit IRC | 15:57 | |
lbragstad | edtubill and just to confirm, you used a devstack installation, right? | 15:58 |
edtubill | yup with saml | 15:59 |
lbragstad | edtubill did you setup the federated bits by hand or did you rely on some sort of automation (through devstack/ansible/etc..)? | 15:59 |
morgan | rderose: allo! | 16:00 |
*** spzala has quit IRC | 16:00 | |
edtubill | I have a vagrant setup that runs a bash script to setup the environment. | 16:00 |
rderose | morgan: allo! | 16:01 |
edtubill | so it runs devstack and then a bash script to setup federation. | 16:01 |
*** spzala has joined #openstack-keystone | 16:01 | |
lbragstad | edtubill got it | 16:02 |
lbragstad | edtubill well - i'm going to start standing up an environment | 16:03 |
morgan | stevemar: i cna't get reno to generate a release note thing for me | 16:03 |
morgan | the venv wont even build | 16:04 |
morgan | something wrong locally on my machine | 16:04 |
lbragstad | morgan that doesn't sound good | 16:04 |
morgan | yeah it's just something wrong here. | 16:04 |
lbragstad | edtubill let me know if/when you file the bug so that I can track what I find there, too | 16:04 |
morgan | lbragstad: i can hand add a reno for my bug fix | 16:05 |
morgan | but it's not going to be auto-generated | 16:05 |
lbragstad | morgan what change? | 16:05 |
morgan | (honestly, i really dislike the "generate a reno stub" workflow) | 16:05 |
morgan | the authcontext fix | 16:05 |
lbragstad | morgan if you want to push what you have, I can add the release note for you | 16:05 |
lbragstad | ah | 16:05 |
morgan | i need to supply a typo fix | 16:05 |
morgan | but otherwise it just needs the reno | 16:05 |
morgan | like i said, i can do it by hand | 16:06 |
morgan | nbd | 16:06 |
lbragstad | morgan https://review.openstack.org/#/c/419693/ | 16:06 |
morgan | yah | 16:06 |
lbragstad | morgan do release notes need to be auto generated? | 16:06 |
morgan | nah. just easier than needing to hand-build a uuid-thing name | 16:07 |
lbragstad | morgan actually - I think what i meant to ask was "when release notes are built, is the releasenotes/notes/ directory just parse: | 16:07 |
lbragstad | parsed*? | 16:07 |
morgan | yah afaik | 16:07 |
lbragstad | ah - ok | 16:07 |
lbragstad | edtubill were you using a specific distro? | 16:08 |
*** voelzmo has quit IRC | 16:08 | |
*** voelzmo has joined #openstack-keystone | 16:08 | |
*** voelzmo has quit IRC | 16:08 | |
*** phalmos has joined #openstack-keystone | 16:10 | |
breton | how do i run mysql upgrade tests on a live database? | 16:11 |
breton | there was some username/password that i was expected to use | 16:12 |
lbragstad | breton yep | 16:12 |
lbragstad | breton trying to find the link | 16:13 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone: Force use of AuthContext object in .authentcate() https://review.openstack.org/419693 | 16:14 |
morgan | lbragstad: ^ | 16:14 |
lbragstad | morgan awesome | 16:15 |
lbragstad | morgan you had some comments on https://review.openstack.org/#/c/285315/4 | 16:15 |
breton | openstack_citest | 16:15 |
*** adrian_otto has joined #openstack-keystone | 16:16 | |
morgan | lbragstad: hehe | 16:16 |
lbragstad | breton yeah - that's it | 16:16 |
morgan | lbragstad: sigh. i think i'm giving up on taking over python-memcached and going to spin a replacement patch for us | 16:16 |
lbragstad | breton that's a page documenting everything for it, but I can't seem to find it | 16:17 |
*** stingaci has quit IRC | 16:17 | |
morgan | it's been really hard to coordinate the handover from the current maintainer. | 16:17 |
morgan | i think i can do it all with pymemcached now or memcachedclient | 16:17 |
lbragstad | morgan what's your replacement patch going to be? | 16:17 |
morgan | pymemcached being the clear better choice. | 16:17 |
morgan | it's just going to change oslo.cache to lean on pymemcached first | 16:17 |
morgan | i also need to catch up with zzzeek and check on dogpile.cache and get back involved there | 16:18 |
lbragstad | ah - sure | 16:18 |
lbragstad | that makes sense | 16:18 |
zzzeek | morgan: woop! | 16:18 |
morgan | there is some pending cleanup patches I owe him. | 16:18 |
morgan | zzzeek: ;) | 16:18 |
morgan | zzzeek: thankfully dogpile is nice and stable | 16:18 |
lbragstad | morgan but oslo.cache will have a direct dependency on pymemcached, right? | 16:18 |
* lbragstad loves stable | 16:19 | |
morgan | lbragstad: well possibly | 16:19 |
morgan | lbragstad: haven't gotten that far. need to see what it does | 16:19 |
morgan | but in short i want to build pymemcached backend for dogpile first, then lean on it as the default in oslo.cache | 16:19 |
lbragstad | sure | 16:19 |
morgan | then we can just divorce ourselves from python-memcached in openstack | 16:19 |
morgan | since python-memcached is sortof (at best) py3 workable | 16:20 |
morgan | and the explicit thread.local leaning is bad news | 16:20 |
lbragstad | morgan i know i've asked this before - but what was the reason for conditional importing of python-memcached? | 16:20 |
morgan | i think we can also untangle dogpile.cache from leaning on it. | 16:20 |
morgan | lbragstad: deployers got cranky about the package | 16:20 |
morgan | and it was buggy/weird/hard-to-work-with | 16:20 |
lbragstad | morgan ah | 16:21 |
morgan | also packagers disliked it (hi zigo! :) ) | 16:21 |
lbragstad | morgan are we sure pymemcached doesn't have those problems | 16:21 |
lbragstad | ? | 16:21 |
morgan | yes | 16:21 |
lbragstad | cool | 16:21 |
morgan | it is very good code | 16:21 |
morgan | and maintained by pinterest | 16:22 |
morgan | if we have issues i'll go chase down jogo | 16:22 |
morgan | ;) | 16:22 |
openstackgerrit | Ron De Rose proposed openstack/keystone: WIP - Add domain_id to the user table https://review.openstack.org/409874 | 16:23 |
lbragstad | pymemcached is?! | 16:25 |
morgan | yep | 16:26 |
lbragstad | huh - nice | 16:26 |
morgan | https://github.com/pinterest/pymemcache | 16:26 |
lbragstad | morgan so - another dumb question, if we wanted to use that instead of python-memcached, all we'd really need to do is get oslo.cache using it? | 16:28 |
*** stingaci has joined #openstack-keystone | 16:28 | |
morgan | and change the default(s) in either oslo.cache or the overrides we set | 16:29 |
morgan | preferably just switch oslo.cache to lean on pymemcache impl instead for the next (Pike) release | 16:30 |
lbragstad | because most things (with the exception of keystonemiddleware) should be using oslo.cache? | 16:30 |
morgan | yep | 16:30 |
lbragstad | cool | 16:30 |
morgan | and ksm should be too | 16:30 |
morgan | ftr | 16:30 |
lbragstad | so - keystonemiddleware should be | 16:30 |
breton | oh these talks on dropping python-memcached again | 16:30 |
breton | what issues does it cause now? | 16:30 |
morgan | breton: yeah but it's much easier now | 16:30 |
*** phalmos has quit IRC | 16:30 | |
morgan | breton: i've been trying to take it over so we can maintain it | 16:30 |
morgan | it still isn't really py3 friendly and still leans too much on thread.local | 16:30 |
lbragstad | morgan gotcha - is there any tribal knowledge around why ksm doesn't use oslo.cache now? | 16:31 |
morgan | we want to just dump it for those reasons | 16:31 |
morgan | lbragstad: uhm... i think it is related to thread.local issues with custom wsgi impls | 16:31 |
morgan | but i can work around that now. | 16:31 |
morgan | the fact that most projects can't be run under uwsgi or apache is the issue. | 16:31 |
lbragstad | morgan so ksm uses python-memcached directly to get around those issues? | 16:32 |
morgan | lbragstad: as i recall that was why i didn't convert it to dogpile | 16:32 |
morgan | but oslo.cache makes this easier | 16:32 |
*** stingaci has quit IRC | 16:32 | |
morgan | also we dont memoize in ksm | 16:33 |
lbragstad | morgan does ksm rely on thread.local for certain things? | 16:33 |
morgan | which meant it had a lot of extra code loaded in. | 16:33 |
morgan | lbragstad: no. but since eventlet is still a thing | 16:33 |
morgan | we need thread.locals to make it "functional" in base configs where a pool is not configured | 16:33 |
morgan | it's "wonky" | 16:33 |
lbragstad | oh - because some services don't run in apache | 16:33 |
morgan | basically, no one spent the time to convert it yet | 16:33 |
morgan | and caching is hard(tm) | 16:34 |
lbragstad | er - a non-eventlet environment | 16:34 |
lbragstad | caching is hard.. | 16:34 |
morgan | it's one of the two hardest problems in compture science | 16:34 |
morgan | caching, naming things, and off-by-one errors | 16:34 |
edtubill | lbragstad: I was using ubuntu trusty64 | 16:34 |
lbragstad | morgan don't forget revocation | 16:34 |
lbragstad | edtubill cool | 16:35 |
morgan | dolphm: i have to brag a little today. cooked eggs in my carbon steel pan... better non-stick seasoning than the "non-stick" pans | 16:35 |
morgan | dolphm: literally wiped the food out of the pan after cooling. nothing left over ^_^ | 16:35 |
morgan | lbragstad: ^ carbon steel > all other pans (for skillets/crepe pans/similar shape) | 16:36 |
lbragstad | morgan s/carbon steel/cast iron/ | 16:36 |
morgan | though i want to upgrade to the "de Buyer" pans. | 16:36 |
lbragstad | ;) | 16:36 |
morgan | lbragstad: if you like cast iron, you'll love carbon steel | 16:36 |
morgan | i have both | 16:36 |
*** pcaruana has joined #openstack-keystone | 16:36 | |
morgan | i use carbon steel far far more often | 16:36 |
lbragstad | morgan yeah? | 16:37 |
morgan | (very similar, but carbon steel tends to be 25% lighter) | 16:37 |
morgan | carbon steel only comes in a few shapes though | 16:37 |
morgan | but right now only de Buyer is really making quality ones | 16:37 |
morgan | also the handles there are riveted instead of spot welded. | 16:37 |
morgan | seems like the other pans (like i have) are having some QC issues with the welding | 16:38 |
morgan | lbragstad: but yeah, get some carbon steel skillets. they really are amazing | 16:38 |
*** chlong has quit IRC | 16:38 | |
morgan | "de Buyer Mineral B Element" is what you should look at | 16:39 |
morgan | maybe $50-$100 per pan, really not bad. | 16:39 |
morgan | for the larger ones | 16:39 |
lbragstad | oooof | 16:39 |
morgan | like 15-17" diameter | 16:39 |
morgan | the small ones are usually in the $40 range | 16:39 |
morgan | or so | 16:39 |
morgan | and these are the best ones I've seen | 16:40 |
morgan | so you pay a bit premium | 16:40 |
lbragstad | i will say that is one of the biggest reason why I like cast iron, you can usually find them for dirt cheap | 16:40 |
lbragstad | and with a little sand paper and some sweat - you can restore them | 16:41 |
morgan | $75 for a 17" skillet is pretty reasonable (because shipping and such) | 16:41 |
morgan | also, if you have burners to use a 17" skillet on... | 16:41 |
*** stingaci has joined #openstack-keystone | 16:41 | |
morgan | i mena... those are gigantic | 16:41 |
lbragstad | morgan right... even 15" skillets are hard to cook with if you want the entire thing hot | 16:41 |
morgan | lbragstad: yeah carbon steel is the same, worst case you scrub them down with seriously abrasive stuff and they are restorable | 16:42 |
morgan | as long as rust hasn't eaten through them | 16:42 |
bknudson | I cooked up pork loin using sous vide last night and it was delicious | 16:42 |
morgan | niiiiice | 16:42 |
lbragstad | bknudson you've taken up sous vide?!?! | 16:42 |
bknudson | yes, it's easy. just need the cooker | 16:42 |
*** chlong has joined #openstack-keystone | 16:43 | |
morgan | we did stuffed chicken breast a few nights ago | 16:43 |
morgan | turned out amazing | 16:43 |
morgan | sear it with some panko then toss the whole skillet in the oven | 16:43 |
morgan | and then nom. | 16:43 |
* lbragstad has never tried sous vide | 16:43 | |
morgan | sous vide is awesome | 16:43 |
morgan | but the cooker is important | 16:43 |
lbragstad | hmmm | 16:43 |
morgan | i don't have room for the cooker/storing it | 16:44 |
morgan | or i'd consider it | 16:44 |
morgan | will have to wait until i have a bigger kitchen | 16:44 |
bknudson | you can get a sous vide heater that's just a wand. | 16:44 |
morgan | bknudson: not really the same imo | 16:44 |
lbragstad | bknudson so you can do sous vide in your tub? | 16:44 |
lbragstad | or your sink? | 16:44 |
*** lamt has joined #openstack-keystone | 16:45 | |
lbragstad | or any apparatus that holds water | 16:45 |
bknudson | you can do it in a pot | 16:45 |
bknudson | yes, or a plastic tub | 16:45 |
morgan | lbragstad: lol nah in a big pot | 16:45 |
morgan | bknudson: ick in a plastic tub... just no :P | 16:45 |
* morgan also needs a giant jar boiling pot again | 16:45 | |
bknudson | I got a gourmia like this: http://greatestcookers.com/gourmia-gmc650p-11-in-1-sous-vide-multi-cooker-purple-stainless-steel-lcd-display-multiple-cooking-options-bonus-accessories-cookbook/ | 16:45 |
morgan | but again, no room | 16:45 |
bknudson | since I didn't have a slow cooker already | 16:46 |
lbragstad | I'm a fan of a good sear on whatever i'm cooking | 16:46 |
morgan | bknudson: yeah those are nice | 16:46 |
bknudson | you sear it on a pan after you take it out of the water | 16:46 |
bknudson | otherwise it looks like a turd | 16:46 |
morgan | bknudson: not crazy or too fancy, just basic and functional | 16:46 |
lbragstad | bknudson lol - you're not selling it | 16:46 |
lbragstad | ;) | 16:46 |
bknudson | the result is delicious | 16:47 |
*** jose-phillips has joined #openstack-keystone | 16:47 | |
morgan | next big task for me is to start making my own bread, and soup stock. | 16:47 |
lbragstad | i eat with my eyes :) | 16:47 |
bknudson | it looks good after it's done on the stove. | 16:47 |
morgan | bknudson: ++ | 16:47 |
lbragstad | morgan we make all of our own bread | 16:47 |
morgan | lbragstad: yeah i have a kitchen i can do that now. | 16:47 |
lbragstad | morgan and by we I mean my wife | 16:48 |
morgan | lbragstad: so going to start doing it. debating on a sourdough starter | 16:48 |
lbragstad | morgan it can be alot of work - but it's worth it | 16:48 |
*** chlong has quit IRC | 16:48 | |
morgan | lbragstad: hehe my gf and I share the cooking | 16:48 |
morgan | her dad is an amazing chef. | 16:48 |
morgan | so we are getting some awesome recipes | 16:48 |
morgan | we're going to start making east-coast style bagels ;) | 16:49 |
lbragstad | morgan don't hesitate to send some my way ;) | 16:49 |
morgan | and even our own english muffins. | 16:49 |
morgan | and work up to home made croissants | 16:49 |
morgan | and pastries | 16:49 |
*** AlexeyAbashkin has quit IRC | 16:49 | |
* lbragstad drools | 16:49 | |
morgan | lbragstad: for sure | 16:49 |
dolphm | morgan: i still have that one pan you recommended in my amazon saved items -- trying to justify getting rid of another one to buy it | 16:50 |
morgan | dolphm: hehe get the de buyer version now | 16:50 |
morgan | dolphm: the one i got a year ago is having serious QC issues now | 16:50 |
lbragstad | lol | 16:50 |
morgan | the welds don't hold up | 16:50 |
morgan | de buyer is riveted | 16:50 |
lbragstad | dolphm if you want to off load any cast iron, you know where to send it | 16:50 |
morgan | basically they got recommended by 2 or three big "kitchen" article places | 16:51 |
dolphm | lbragstad: my cast iron dutch oven is the prime candidate | 16:51 |
morgan | and ramped up production and things got bad :( | 16:51 |
morgan | oooh I have a williams sonoma gift card somewhere... | 16:51 |
lbragstad | dolphm prime as in prime to get rid of? | 16:51 |
morgan | i should use that | 16:51 |
dolphm | morgan: oh, boo | 16:51 |
dolphm | lbragstad: yes | 16:51 |
morgan | dolphm: de buyer stuff is ~+$10-15 more | 16:52 |
morgan | and way higher quality | 16:52 |
dolphm | lbragstad: it weighs like 35 pounds empty, and it's not easy to wipe out because the lid is spiked | 16:52 |
morgan | just get the mineral b element | 16:52 |
morgan | dolphm: oh i'd never use that as you just described =/ | 16:52 |
*** lamt has quit IRC | 16:52 | |
lbragstad | dolphm 5 qt? | 16:52 |
lbragstad | or 7? | 16:52 |
dolphm | lbragstad: i would have estimated 6 | 16:53 |
dolphm | lbragstad: probably 5-6 | 16:53 |
morgan | lbragstad: i'd guess 7 with 35lbs | 16:53 |
dolphm | it's the same size as my 6 quart, but the interior capacity might be less | 16:53 |
morgan | dolphm: ahh | 16:53 |
dolphm | actually, maybe it is 7 ... it's probably taller too | 16:53 |
morgan | yeah if it isn't "easy to clean", I tend to stop using the thing | 16:53 |
dolphm | morgan: yeah... if anything splatters on the lid it's no fun | 16:54 |
morgan | i have a cast iron (with enamel on the bottom for ease of cleaning) but it is a PITA to clean because the shape... i stopped using it | 16:54 |
lbragstad | those le cruset dutch ovens are awesome... | 16:54 |
morgan | i have things that are better suited for the ame thing. | 16:54 |
morgan | lbragstad: they sure do cook things well. | 16:55 |
dolphm | type of lid: http://thumbs.worthpoint.com/zoom/images2/1/0614/19/vintage-lodge-10cf2-12-cast-iron-deep_1_2c66a340484ece379c5e9c4b80d20642.jpg | 16:55 |
lbragstad | i've been trying to come up with an excuse to get one | 16:55 |
morgan | dolphm: #nope | 16:55 |
morgan | :P | 16:55 |
dolphm | theoretically they return condensed moisture back to the food, but ... it seems more like a good idea than a useful feature | 16:56 |
morgan | i just reseasoned the carbon steel... i think i'm up to ~10-15 nice layers on it and the thing is almost black colored now. nothing sticks to it. so great | 16:56 |
lbragstad | dolphm i've wondered if you really need that many spikes to achieve that though | 16:57 |
dolphm | lbragstad: exactly | 16:57 |
morgan | though the 15" one i have i have to oven season, i can't heat it enough on the stove to properly season it | 16:57 |
morgan | lbragstad: i also want a stove with a french burner | 16:57 |
lbragstad | dolphm even half the amount would make that easier to clean | 16:57 |
dolphm | lbragstad: i bet one in the middle with a properly shape to the interior of the lid would do a better job | 16:57 |
morgan | dolphm: ++ | 16:57 |
lbragstad | the spacing is just dense enough to be a PITA | 16:57 |
morgan | dolphm: probably | 16:57 |
dolphm | lbragstad: ++ | 16:57 |
*** stingaci has quit IRC | 16:59 | |
*** chlong has joined #openstack-keystone | 16:59 | |
lbragstad | dolphm I don't think the le cruset dutch oven lids have that concept | 17:00 |
lbragstad | but i also can't find a picture | 17:00 |
morgan | lbragstad: they dont afaik | 17:02 |
stevemar | this hackathon has turned into a cookout | 17:03 |
*** phalmos has joined #openstack-keystone | 17:03 | |
lbragstad | you know - that would be an awesome idea for a "team bonding event" | 17:03 |
morgan | stevemar: nothing wrong with it | 17:04 |
morgan | lbragstad: ++ | 17:04 |
lbragstad | morgan dolphm and I talked about doing a seafood boil for a team event once or twice | 17:06 |
*** chlong has quit IRC | 17:09 | |
*** phalmos has quit IRC | 17:11 | |
morgan | lbragstad: hehe | 17:13 |
lbragstad | morgan i even built a tool for it ;) https://github.com/lbragstad/boiler | 17:14 |
morgan | lol nice | 17:15 |
openstackgerrit | Merged openstack/keystone: update sample config for ocata release https://review.openstack.org/419949 | 17:16 |
*** lamt has joined #openstack-keystone | 17:18 | |
openstackgerrit | Samuel Pilla proposed openstack/keystone: Update endpoint api for optional region_id and extras https://review.openstack.org/420085 | 17:20 |
lbragstad | rodrigods ping? is there a way to use the functional keystone plugins to setup federation stuff with devstack? | 17:20 |
*** asettle has quit IRC | 17:23 | |
*** adrian_otto has quit IRC | 17:24 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Force use of AuthContext object in .authentcate() https://review.openstack.org/419693 | 17:29 |
*** tqtran has joined #openstack-keystone | 17:33 | |
openstackgerrit | Samuel Pilla proposed openstack/keystone: Update endpoint api for optional region_id https://review.openstack.org/420085 | 17:33 |
*** mvk has joined #openstack-keystone | 17:38 | |
*** stephen-la has quit IRC | 17:48 | |
rodrigods | lbragstad, yep, we already do this in the v3-only job | 17:53 |
lbragstad | rodrigods sweet | 17:53 |
rodrigods | lbragstad, and now that https://review.openstack.org/#/c/415906/ is going to merge | 17:53 |
lbragstad | i just got done installing a new devstack | 17:53 |
rodrigods | everything should work fine | 17:53 |
rodrigods | lbragstad, did you enable the keystone-saml2-federation service? | 17:54 |
lbragstad | cool | 17:54 |
lbragstad | rodrigods i didn't | 17:54 |
lbragstad | rodrigods do i have to start over? | 17:54 |
lbragstad | rodrigods also - i'm looking for docs on the process but wasn't able to find any | 17:54 |
rodrigods | lbragstad, so you need to enable the keystone plugin and the keystone-saml2-service in local.conf | 17:54 |
lbragstad | rodrigods ok | 17:55 |
rodrigods | lbragstad, https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/keystone.yaml#L101-L102 | 17:55 |
rodrigods | lbragstad, so you put the following lines in your local.conf prior stack.sh | 17:55 |
lbragstad | ah - cool | 17:55 |
lbragstad | rodrigods so that is going to set up keystone to be a service provider, complete with idp, mapping, etc... right? | 17:56 |
rodrigods | lbragstad, http://paste.openstack.org/raw/594872/ | 17:56 |
rodrigods | lbragstad, yes... the idp is testshib | 17:56 |
lbragstad | rodrigods so - that is what goes in local.conf? | 17:56 |
rodrigods | lbragstad, http://paste.openstack.org/raw/594872/ | 17:56 |
lbragstad | rodrigods is this documented anywhere? | 18:00 |
lbragstad | like - for developers? | 18:00 |
rodrigods | lbragstad, good question | 18:00 |
rodrigods | i don't think so heh | 18:01 |
lbragstad | rodrigods :) | 18:02 |
lbragstad | rodrigods "psh - what docs? we have docs?" | 18:02 |
rodrigods | :) | 18:02 |
lbragstad | rodrigods i also assume when you do this you trim the enabled services for devstack? | 18:03 |
rodrigods | lbragstad, never executed it enabling another service | 18:03 |
stevemar | leaving for lunch soon, please leave me a list of reviews to look over! :) | 18:04 |
lbragstad | rodrigods http://paste.openstack.org/raw/594872/ is your local.conf right? | 18:04 |
rodrigods | lbragstad, hmm i have a [localrc] there i think | 18:05 |
lbragstad | oh - ok | 18:05 |
lbragstad | rodrigods http://cdn.pasteraw.com/g0wabxe4kjio8o8q82udj1ybtm0s2p1 | 18:06 |
rodrigods | lbragstad, my local.conf | 18:06 |
rodrigods | lbragstad, http://paste.openstack.org/raw/594876/ | 18:07 |
lbragstad | rodrigods so once you have that you run 'stack.sh'? | 18:09 |
rodrigods | lbragstad, yes | 18:09 |
lbragstad | rodrigods sweet - thanks! | 18:10 |
lbragstad | rodrigods testing it out now | 18:10 |
rodrigods | lbragstad, ++ let me know if you have more questions | 18:10 |
lbragstad | rodrigods will do | 18:10 |
*** links has quit IRC | 18:12 | |
lbragstad | rodrigods going to use https://etherpad.openstack.org/p/keystone-tempest-federated-setup as a notepad | 18:12 |
lbragstad | then - based on ^ I'll propose a doc patch | 18:12 |
rodrigods | lbragstad, awesome :) | 18:13 |
lbragstad | rodrigods feel free to brain dump there | 18:13 |
rodrigods | lbragstad, devstack still recognizes localrc? | 18:13 |
lbragstad | rodrigods doesn't look like it | 18:14 |
lbragstad | fixed | 18:14 |
rodrigods | cool | 18:14 |
lbragstad | cc dstanek ^ | 18:14 |
lbragstad | dstanek we're going to use https://etherpad.openstack.org/p/keystone-tempest-federated-setup to gather notes on setting up federation using the keystone_tempest plugin | 18:14 |
rodrigods | lbragstad, the plugin also sets up a basic env for the tests: https://github.com/openstack/keystone/blob/master/devstack/lib/federation.sh#L90-L98 | 18:16 |
rodrigods | lbragstad, and... sets some settings used by the tests: https://github.com/openstack/keystone/blob/master/devstack/lib/federation.sh#L15-L29 | 18:16 |
lbragstad | rodrigods cool | 18:16 |
*** browne has joined #openstack-keystone | 18:16 | |
rodrigods | if you need to add anything for the shadow mapping tests | 18:16 |
lbragstad | rodrigods the only thing would probably be a new mapping | 18:17 |
rodrigods | lbragstad, the mapping we build in the test itself... | 18:17 |
rodrigods | let me find here | 18:17 |
rodrigods | lbragstad, https://github.com/openstack/keystone/blob/master/keystone_tempest_plugin/tests/scenario/test_federated_authentication.py#L58-L86 | 18:18 |
lbragstad | o | 18:18 |
lbragstad | ok | 18:18 |
lbragstad | sweet | 18:18 |
lbragstad | that makes sense | 18:18 |
*** spzala has quit IRC | 18:18 | |
rodrigods | lbragstad, i think you can basically reuse the class there and add verifications that makes sense for shadow mapping | 18:18 |
lbragstad | cool | 18:19 |
lbragstad | rodrigods thanks! | 18:19 |
*** spzala has joined #openstack-keystone | 18:22 | |
*** pcaruana has quit IRC | 18:26 | |
*** Jack_V has joined #openstack-keystone | 18:28 | |
*** Jack_I has quit IRC | 18:32 | |
*** Jack_V has quit IRC | 18:37 | |
*** pcaruana has joined #openstack-keystone | 18:39 | |
openstackgerrit | Merged openstack/keystone: Cascade delete federated_user fk https://review.openstack.org/415906 | 18:40 |
*** Jack_I has joined #openstack-keystone | 18:40 | |
rodrigods | breton, ^ thanks for testing this | 18:41 |
*** Jack_I has quit IRC | 18:52 | |
*** tesseract has quit IRC | 18:53 | |
*** chris_hultin is now known as chris_hultin|AWA | 18:56 | |
*** openstack has joined #openstack-keystone | 18:57 | |
*** chris_hultin|AWA is now known as chris_hultin | 18:58 | |
*** pcaruana has quit IRC | 19:02 | |
*** phalmos has joined #openstack-keystone | 19:05 | |
kfox1111 | can a username or a domain name contain a '\' ? | 19:09 |
*** jamielennox is now known as jamielennox|away | 19:12 | |
*** chlong has joined #openstack-keystone | 19:14 | |
*** adrian_otto has joined #openstack-keystone | 19:15 | |
rodrigods | kfox1111, yes | 19:16 |
kfox1111 | rodrigods: k. thanks. | 19:18 |
kfox1111 | any reserved characters? | 19:18 |
*** asettle has joined #openstack-keystone | 19:19 | |
*** markvoelker_ has quit IRC | 19:19 | |
*** markvoelker has joined #openstack-keystone | 19:20 | |
*** markvoelker has quit IRC | 19:25 | |
*** phalmos has quit IRC | 19:38 | |
*** phalmos has joined #openstack-keystone | 19:40 | |
*** jdennis has joined #openstack-keystone | 19:41 | |
*** jdennis1 has quit IRC | 19:41 | |
*** adrian_otto has quit IRC | 19:43 | |
*** spzala has quit IRC | 19:45 | |
*** Guest87783 is now known as med_ | 19:47 | |
*** med_ has joined #openstack-keystone | 19:47 | |
*** med_ is now known as medberry | 19:47 | |
*** openstackstatus has quit IRC | 19:57 | |
*** openstack has joined #openstack-keystone | 19:57 | |
*** openstackstatus has joined #openstack-keystone | 19:58 | |
*** ChanServ sets mode: +v openstackstatus | 19:58 | |
*** stingaci has joined #openstack-keystone | 19:59 | |
*** david-lyle is now known as baling-wire | 20:00 | |
morgan | by default, no | 20:02 |
morgan | kfox1111: we have discussed requiring web-safe | 20:02 |
morgan | but ... we haven't implemented that iirc for users | 20:02 |
morgan | (it is optional for projects iirc) | 20:03 |
morgan | maybe domains have optional web-safe requirement | 20:03 |
morgan | i know we did it for one of the resources | 20:03 |
morgan | lbragstad, rodrigods: should be a quick +3 https://review.openstack.org/#/c/419693/ | 20:04 |
*** stingaci has quit IRC | 20:04 | |
kfox1111 | morgan: k. | 20:11 |
kfox1111 | the k8s folks are trying to munge domain/user/password authentication in again rather then do token based. | 20:11 |
kfox1111 | I didn't think there was a safe way to put domain/user into one field. | 20:12 |
openstackgerrit | Ron De Rose proposed openstack/keystone: WIP - Add domain_id to the user table https://review.openstack.org/409874 | 20:16 |
morgan | kfox1111: there isn't, but it could be represented as json... each time | 20:18 |
*** iurygregory has quit IRC | 20:18 | |
kfox1111 | they are trying to make their existing username/passowrd based, server side authentication work. | 20:21 |
kfox1111 | it only takes two fields from users, 'username' and 'password'. | 20:21 |
kfox1111 | json would work, but really ugly for a user to type. | 20:21 |
kfox1111 | I keep telling them its a bad model alltogether though. | 20:21 |
*** spzala has joined #openstack-keystone | 20:21 | |
kfox1111 | they should just pass a keystone token from the client to the server and have the server validate the token with keystone. | 20:22 |
kfox1111 | and just call out to 'openstack token issue' from kubecli to get a token. | 20:22 |
kfox1111 | safer, more flexible, and works with the config piplelines already established for other openstack cli's. | 20:22 |
portdirect | kfox1111: they support openIDC? | 20:23 |
portdirect | ^^ thats a question :) | 20:23 |
kfox1111 | not sure. | 20:23 |
kfox1111 | but they seem to think keystone is something you just authenticate against. | 20:24 |
kfox1111 | not that keystone is really about multitenant authorization. | 20:24 |
portdirect | yeah - but at the moment k8s is not really following keystones model | 20:24 |
portdirect | :( | 20:24 |
openstackgerrit | Merged openstack/keystone: Changed 'Driver' reference to 'TokenDriverBase' https://review.openstack.org/419663 | 20:25 |
kfox1111 | portdirect: pm | 20:25 |
*** openstackstatus has quit IRC | 20:27 | |
*** openstack has joined #openstack-keystone | 20:27 | |
stevemar | breton: still around? | 20:28 |
*** openstackstatus has joined #openstack-keystone | 20:28 | |
*** ChanServ sets mode: +v openstackstatus | 20:28 | |
stevemar | rderose: you are the king of patch sets | 20:28 |
stevemar | rderose: you must have been that guy who hit ctrl+s to save his word doc every 5 minutes :P | 20:29 |
morgan | stevemar: this looks like much much too big of a try-block | 20:39 |
morgan | https://github.com/openstack/keystone/blob/master/keystone/auth/controllers.py#L425-L458 | 20:39 |
*** raildo has quit IRC | 20:41 | |
openstackgerrit | Gage Hugo proposed openstack/keystone: Exclude 'keystone_tempest_plugin' in doc build https://review.openstack.org/420171 | 20:42 |
gagehugo | ^ that might be an iffy change | 20:42 |
*** chris_hultin is now known as chris_hultin|AWA | 20:42 | |
rderose | stevemar: that's me! | 20:44 |
rderose | I'm that guy :) | 20:44 |
*** jaosorior has quit IRC | 20:45 | |
*** jaosorior has joined #openstack-keystone | 20:45 | |
rderose | btw stevemar, I think that issue we had where we needed the repo files to be unique has raised it's ugly head again: | 20:45 |
morgan | gagehugo: that isa fine change | 20:45 |
rderose | http://logs.openstack.org/74/409874/29/check/gate-keystone-python27-db-ubuntu-xenial/d2a60fd/testr_results.html.gz | 20:45 |
morgan | gagehugo: i don't see a reason we should include the tempest plugin as an api doc | 20:45 |
rderose | stevemar: http://paste.openstack.org/show/594895/ | 20:46 |
morgan | gagehugo: +1, with comment to consider +2 once jenkins weighs in... erm zuul. | 20:46 |
gagehugo | morgan: yeah I was curious about that, whether to live with the warnings & having incomplete docs vs just living with the issues | 20:46 |
morgan | stevemar: do we consider the auth plugin interface (keystone server side) a contract since it loads from entry points? | 20:47 |
rderose | stevemar: I'm calling expand in the test, but it's failing from a file in contract. anyway, I'll keep playing with this. | 20:47 |
morgan | stevemar: looking at changing how plugins respond when succeeding (aka, they don't actually set data in the authcontext itself. | 20:47 |
morgan | stevemar: the .authenticate method would be responsible for tracking success/fail in AuthContext | 20:48 |
morgan | and building off the response expecting a result of like: NamedTuple(Return=Success|Fail|Insufficient, Error=IfExceptionThenException, ResponseBody=ResponseData) | 20:49 |
morgan | rderose: ^ if you have any thoughts, that would be welcome | 20:49 |
morgan | then the .authenticate method would bundle failure info and the wrapper authenticate_for_token would be strictly responsible for raising failures (Unauthorized, Insufficient Auth Methods, etc) | 20:50 |
*** phalmos has quit IRC | 20:51 | |
morgan | lbragstad: ^ your input welcome as well | 20:52 |
dstanek | morgan: we no longer have code contracts right? | 20:53 |
*** Jack_I has joined #openstack-keystone | 20:55 | |
morgan | dstanek: no idea | 20:58 |
morgan | dstanek: i am asking on this front | 20:58 |
morgan | dstanek: if not, sure this is easy | 20:58 |
morgan | it's a bit weird to assume the plugin changes AuthContext as i'm looking over the code, when we could have just returned values directly to .authenticate and let it muck with AuthContext with more control. | 20:59 |
dstanek | morgan: if we could get rid of side effects i'd be super happy | 21:00 |
morgan | dstanek: i think we can. we don't need to pass AuthContext to the plugins | 21:01 |
morgan | we can just expect a named tuple return and we can set the values directly | 21:02 |
*** lucas__ has joined #openstack-keystone | 21:02 | |
morgan | i'm not going to move the whole auth path to functional to start, but it'll be easier to move that way with each step | 21:02 |
*** Jack_I has quit IRC | 21:03 | |
*** browne has quit IRC | 21:07 | |
*** thiagolib has quit IRC | 21:08 | |
*** browne has joined #openstack-keystone | 21:09 | |
*** rha has quit IRC | 21:14 | |
*** adrian_otto has joined #openstack-keystone | 21:16 | |
*** adrian_otto has quit IRC | 21:22 | |
*** chris_hultin|AWA is now known as chris_hultin | 21:31 | |
*** chris_hultin is now known as chris_hultin|AWA | 21:32 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: WIP - Add domain_id to the user table https://review.openstack.org/409874 | 21:33 |
*** lucas__ has quit IRC | 21:39 | |
openstackgerrit | Gage Hugo proposed openstack/keystone: Corrected punctuation on multiple exceptions https://review.openstack.org/420187 | 21:40 |
*** diazjf has joined #openstack-keystone | 21:48 | |
breton | stevemar: kinda | 21:58 |
*** jamielennox|away is now known as jamielennox | 21:59 | |
*** stingaci has joined #openstack-keystone | 22:00 | |
*** diazjf has quit IRC | 22:00 | |
*** diazjf has joined #openstack-keystone | 22:02 | |
*** diazjf has quit IRC | 22:02 | |
*** thorst_ has quit IRC | 22:02 | |
*** thorst has joined #openstack-keystone | 22:03 | |
*** edtubill has quit IRC | 22:04 | |
*** stingaci has quit IRC | 22:04 | |
*** gyee has joined #openstack-keystone | 22:05 | |
*** stewie925 has joined #openstack-keystone | 22:05 | |
*** thorst has quit IRC | 22:07 | |
stewie925 | happy Friday guys | 22:09 |
stewie925 | I am trying to create a tenant-network, but I am getting a "keystoneclient.session Request returned failure status: 500" | 22:15 |
*** adrian_otto has joined #openstack-keystone | 22:25 | |
*** baling-wire is now known as david-lyle | 22:26 | |
*** thorst has joined #openstack-keystone | 22:28 | |
*** spzala has quit IRC | 22:29 | |
*** thorst has quit IRC | 22:31 | |
*** catintheroof has quit IRC | 22:38 | |
openstackgerrit | Gage Hugo proposed openstack/keystone: Corrected punctuation on multiple exceptions https://review.openstack.org/420187 | 22:39 |
*** wasmum has joined #openstack-keystone | 22:52 | |
gagehugo | stewie925: did anything show up in the log? | 22:52 |
stewie925 | hey gage - http://paste.openstack.org/show/594899/ | 22:53 |
*** jaugustine has quit IRC | 22:53 | |
stewie925 | I did a --debug and post the results there - looks like keystone is complaining | 22:53 |
stewie925 | btw, I was successful creating the external network as admin | 22:54 |
lamt | stewie925 : can you check the keystone log? should be in /var/log/keystone/* | 22:55 |
stewie925 | let me check | 22:55 |
stewie925 | oh I found something - let me chec | 22:58 |
*** jperry has quit IRC | 23:03 | |
stewie925 | lamt: gagehugo: thank you - found the error and had it fixed | 23:05 |
gagehugo | \o/ | 23:06 |
lamt | stewie925 great to hear | 23:06 |
rderose | stewie925: what was the issue? | 23:07 |
stewie925 | rderose: hi | 23:07 |
rderose | hi | 23:07 |
stewie925 | it was a wsgi-script that I had to update - it was parsing incorrectly so I was getting an error | 23:07 |
rderose | stewie925: ah, I see | 23:08 |
*** asettle has quit IRC | 23:19 | |
openstackgerrit | Gage Hugo proposed openstack/keystone: Allow user to change own expired password https://review.openstack.org/404022 | 23:19 |
*** asettle has joined #openstack-keystone | 23:20 | |
*** asettle is now known as Guest11517 | 23:21 | |
*** edmondsw has quit IRC | 23:29 | |
*** adrian_otto has quit IRC | 23:31 | |
*** jaosorior has quit IRC | 23:31 | |
*** thorst has joined #openstack-keystone | 23:32 | |
*** edmondsw has joined #openstack-keystone | 23:36 | |
*** thorst has quit IRC | 23:37 | |
*** chlong has quit IRC | 23:38 | |
*** edmondsw_ has joined #openstack-keystone | 23:38 | |
*** edmonds__ has joined #openstack-keystone | 23:40 | |
*** edmondsw has quit IRC | 23:41 | |
*** edmondsw_ has quit IRC | 23:43 | |
*** edmonds__ has quit IRC | 23:47 | |
*** harlowja has quit IRC | 23:56 | |
*** Ephur has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!