*** jlopezgu_ has quit IRC | 00:01 | |
*** spzala has quit IRC | 00:02 | |
*** jdennis has quit IRC | 00:03 | |
*** jdennis1 has joined #openstack-keystone | 00:03 | |
*** adrian_otto has quit IRC | 00:16 | |
*** dave-mccowan has quit IRC | 00:29 | |
*** Aqsa has quit IRC | 00:31 | |
*** Shunli has joined #openstack-keystone | 00:44 | |
*** agrebennikov_ has quit IRC | 00:46 | |
*** guoshan has joined #openstack-keystone | 00:48 | |
*** dave-mccowan has joined #openstack-keystone | 00:48 | |
*** dave-mcc_ has joined #openstack-keystone | 00:55 | |
*** dave-mccowan has quit IRC | 00:57 | |
*** tovin07 has joined #openstack-keystone | 00:58 | |
*** spzala has joined #openstack-keystone | 01:08 | |
*** dave-mccowan has joined #openstack-keystone | 01:09 | |
*** wxy has quit IRC | 01:10 | |
*** wxy has joined #openstack-keystone | 01:10 | |
*** dave-mcc_ has quit IRC | 01:11 | |
*** liujiong has joined #openstack-keystone | 01:12 | |
*** MasterOfBugs has joined #openstack-keystone | 01:17 | |
*** spzala has quit IRC | 01:20 | |
*** spzala has joined #openstack-keystone | 01:20 | |
*** spzala has quit IRC | 01:21 | |
*** spzala has joined #openstack-keystone | 01:21 | |
*** guoshan has quit IRC | 01:22 | |
*** zhurong has joined #openstack-keystone | 01:26 | |
*** jamielennox is now known as jamielennox|away | 01:39 | |
*** jamielennox|away is now known as jamielennox | 01:48 | |
*** spzala has quit IRC | 01:56 | |
*** spzala has joined #openstack-keystone | 01:56 | |
*** guoshan has joined #openstack-keystone | 01:57 | |
*** knangia has quit IRC | 02:01 | |
*** spzala has quit IRC | 02:02 | |
*** guoshan has quit IRC | 02:03 | |
*** ravelar has quit IRC | 02:04 | |
*** guoshan has joined #openstack-keystone | 02:04 | |
*** spzala has joined #openstack-keystone | 02:19 | |
*** kukacz has quit IRC | 02:20 | |
*** spzala has quit IRC | 02:23 | |
*** namnh has joined #openstack-keystone | 02:33 | |
*** knikolla has quit IRC | 02:38 | |
*** aleph1 has quit IRC | 02:38 | |
*** phalmos_ has quit IRC | 02:43 | |
*** phalmos has joined #openstack-keystone | 02:44 | |
openstackgerrit | zhongshengping proposed openstack/oslo.policy master: Check reStructuredText documents for common style issues. https://review.openstack.org/449410 | 02:45 |
---|---|---|
*** aleph1 has joined #openstack-keystone | 02:47 | |
*** raginbajin has quit IRC | 02:47 | |
*** knikolla has joined #openstack-keystone | 02:50 | |
*** raginbajin has joined #openstack-keystone | 02:52 | |
*** spzala has joined #openstack-keystone | 03:00 | |
*** spzala has quit IRC | 03:05 | |
*** dave-mccowan has quit IRC | 03:08 | |
*** prashkre has joined #openstack-keystone | 03:26 | |
*** edmondsw has quit IRC | 03:32 | |
*** spzala has joined #openstack-keystone | 03:42 | |
*** spzala has quit IRC | 03:47 | |
*** knangia has joined #openstack-keystone | 03:52 | |
*** guoshan has quit IRC | 03:56 | |
*** edmondsw has joined #openstack-keystone | 03:59 | |
*** edmondsw has quit IRC | 04:04 | |
*** zhurong has quit IRC | 04:07 | |
*** spzala has joined #openstack-keystone | 04:09 | |
*** htruta` has quit IRC | 04:11 | |
*** htruta has joined #openstack-keystone | 04:12 | |
*** spzala has quit IRC | 04:13 | |
*** prashkre has quit IRC | 04:19 | |
*** links has joined #openstack-keystone | 04:20 | |
*** prashkre has joined #openstack-keystone | 04:34 | |
openstackgerrit | junboli proposed openstack/keystone master: Remove log translations https://review.openstack.org/449427 | 04:43 |
*** namnh has quit IRC | 04:47 | |
openstackgerrit | junboli proposed openstack/keystone master: Remove log translations https://review.openstack.org/449427 | 04:54 |
*** rderose has quit IRC | 04:54 | |
*** spzala has joined #openstack-keystone | 05:01 | |
*** spzala has quit IRC | 05:06 | |
*** zhurong has joined #openstack-keystone | 05:16 | |
*** prashkre has quit IRC | 05:22 | |
*** prashkre has joined #openstack-keystone | 05:22 | |
*** spzala has joined #openstack-keystone | 05:23 | |
*** spzala has quit IRC | 05:27 | |
*** eandersson_ has joined #openstack-keystone | 05:38 | |
*** eandersson has quit IRC | 05:42 | |
*** richm has quit IRC | 05:44 | |
*** spzala has joined #openstack-keystone | 06:00 | |
*** knangia has quit IRC | 06:01 | |
*** spzala has quit IRC | 06:05 | |
*** aojea has joined #openstack-keystone | 06:12 | |
*** aojea has quit IRC | 06:18 | |
*** MasterOfBugs has quit IRC | 06:32 | |
*** spzala has joined #openstack-keystone | 06:42 | |
*** spzala has quit IRC | 06:47 | |
*** mvk has quit IRC | 06:47 | |
*** edmondsw has joined #openstack-keystone | 06:59 | |
*** edmondsw has quit IRC | 07:04 | |
*** spzala has joined #openstack-keystone | 07:10 | |
*** spzala has quit IRC | 07:15 | |
*** Andrew_jedi has joined #openstack-keystone | 07:25 | |
*** Andrew_jedi has quit IRC | 07:30 | |
*** tesseract has joined #openstack-keystone | 07:31 | |
*** Aqsa has joined #openstack-keystone | 07:41 | |
*** liujiong has quit IRC | 07:45 | |
*** spzala has joined #openstack-keystone | 07:52 | |
*** jaosorior has joined #openstack-keystone | 07:55 | |
*** spzala has quit IRC | 07:57 | |
*** prashkre has quit IRC | 07:57 | |
*** prashkre has joined #openstack-keystone | 07:58 | |
*** belmoreira has joined #openstack-keystone | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-keystone | 08:01 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.policy master: Simplify message of exception PolicyNotAuthorized https://review.openstack.org/449470 | 08:03 |
*** aojea has joined #openstack-keystone | 08:18 | |
*** aojea has quit IRC | 08:18 | |
*** aojea has joined #openstack-keystone | 08:19 | |
*** prashkre has quit IRC | 08:23 | |
*** prashkre has joined #openstack-keystone | 08:24 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystonemiddleware master: Imported Translations from Zanata https://review.openstack.org/449484 | 08:30 |
*** spzala has joined #openstack-keystone | 08:33 | |
*** spzala has quit IRC | 08:38 | |
*** alex_xu has quit IRC | 08:58 | |
*** alex_xu has joined #openstack-keystone | 08:59 | |
*** alex_xu has quit IRC | 09:01 | |
*** alex_xu has joined #openstack-keystone | 09:02 | |
*** alex_xu has quit IRC | 09:06 | |
*** alex_xu has joined #openstack-keystone | 09:07 | |
openstackgerrit | junboli proposed openstack/keystone master: Remove log translations https://review.openstack.org/449427 | 09:09 |
*** aojea_ has joined #openstack-keystone | 09:10 | |
*** aojea has quit IRC | 09:12 | |
*** spzala has joined #openstack-keystone | 09:15 | |
*** spzala has quit IRC | 09:19 | |
ma9_ | I'm debugging the HTTP communication when logging into Horizon. How can I see the token I was given by Keystone? I'm reading that It uses sessions ID as token… is it the same thing? https://wiki.openstack.org/wiki/OSSN/OSSN-0017 | 09:29 |
*** pnavarro has joined #openstack-keystone | 09:29 | |
*** bjornar_ has joined #openstack-keystone | 09:32 | |
bjornar_ | how do I send config-dir to initialize_public_application() | 09:32 |
*** jrist has quit IRC | 09:34 | |
*** prashkre has quit IRC | 09:40 | |
*** prashkre has joined #openstack-keystone | 09:42 | |
*** prashkre_ has joined #openstack-keystone | 09:43 | |
*** prashkre has quit IRC | 09:43 | |
*** Shunli has quit IRC | 09:46 | |
*** prashkre_ has quit IRC | 09:46 | |
*** prashkre has joined #openstack-keystone | 09:47 | |
*** spzala has joined #openstack-keystone | 09:48 | |
*** prashkre has quit IRC | 09:49 | |
*** prashkre has joined #openstack-keystone | 09:50 | |
*** prashkre has quit IRC | 09:50 | |
*** prashkre has joined #openstack-keystone | 09:52 | |
*** spzala has quit IRC | 09:53 | |
*** prashkre_ has joined #openstack-keystone | 09:56 | |
*** mvk has joined #openstack-keystone | 09:57 | |
*** prashkre has quit IRC | 09:58 | |
*** pcaruana has joined #openstack-keystone | 10:05 | |
*** richm has joined #openstack-keystone | 10:13 | |
*** prashkre__ has joined #openstack-keystone | 10:23 | |
*** prashkre_ has quit IRC | 10:24 | |
*** prashkre_ has joined #openstack-keystone | 10:24 | |
*** prashkre__ has quit IRC | 10:28 | |
*** spzala has joined #openstack-keystone | 10:29 | |
*** spzala has quit IRC | 10:34 | |
*** edmondsw has joined #openstack-keystone | 10:35 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.policy master: Simplify message of exception PolicyNotAuthorized https://review.openstack.org/449470 | 10:36 |
dstanek | ma9_: how are you debugg? | 10:37 |
dstanek | *debugging | 10:37 |
*** nicolasbock has joined #openstack-keystone | 10:38 | |
ma9_ | using firefox developer tools | 10:39 |
ma9_ | looking at the network traffic | 10:39 |
ma9_ | *dstanek | 10:39 |
ma9_ | is it so that the keystone token is saved into memcached and never reached the web browser? | 10:40 |
ma9_ | instead, a session id is used to keep the web browser session with horizon? | 10:40 |
*** zhurong has quit IRC | 10:40 | |
*** edmondsw has quit IRC | 10:40 | |
dstanek | ma9_: yeah, i don't think you'll ever see a token unless you see the traffic between horizon and keystone (horizon actually has it, not just in memcached) | 10:41 |
ma9_ | I see. The reasoning behind this is that I'm using Keycloack to implement SSO. It works form Horizon but not from the CLI as far as I know… so I was hoping to be able to get the Token from Horizon and reuse it on the CLI somehow | 10:42 |
dstanek | ma9_: does it support ECP? | 10:43 |
ma9_ | the communication betweek Keystone and Keycloack can work wither with OIDC or SAML. I thnk ECP is supported but I'm not 100% sure. | 10:45 |
ma9_ | (Keycloack then is a broker for different backends, for example LDAP/KRB,AD,Shibboleth,OIDC… but that's not visible on the keystone side) | 10:46 |
dstanek | how are you trying to use it from the command line OIDC or SAML? | 10:47 |
dstanek | ma9_: or taking a step back.... what part is not working? is keystone responding incorrectly? | 10:48 |
Dinesh_Bhor | dstanek: Hi, I have written some tests for request-id. Whenever you get time please take a look at it and give your valuable suggestions: https://review.openstack.org/#/c/329913/ | 10:52 |
ma9_ | RedHat told us the CLI does not work with KEycloack… but is the CLI supposed to be able to work with SAML if ECP is supported? I found this document which maybe explains how to do it: https://platform9.com/support/using-openstack-cli-saml-authentication/ | 10:54 |
*** prashkre__ has joined #openstack-keystone | 11:05 | |
*** rmascena has joined #openstack-keystone | 11:06 | |
*** Dinesh_Bhor has quit IRC | 11:07 | |
*** prashkre_ has quit IRC | 11:08 | |
dstanek | ma9_: yes, if the IdP support ECP the command line should work | 11:08 |
ma9_ | do you know if there is some official documentation for that? I could not find much | 11:10 |
dstanek | ma9_: for what IdP? | 11:10 |
dstanek | is keycloak the IdP? | 11:10 |
ma9_ | yes | 11:11 |
dstanek | it looks like it might be. if you can't you that from the command line then this won't work | 11:12 |
*** bjornar_ has quit IRC | 11:12 | |
ma9_ | I will contact the RH support, and continue investigating | 11:14 |
*** prashkre__ has quit IRC | 11:14 | |
ma9_ | thanks for now! | 11:14 |
*** prashkre has joined #openstack-keystone | 11:15 | |
dstanek | ma9_: np. just for reference when talking to redhad. saml has a couple different profiles. one is the normal web flow and another is ECP the command line one (the others are not relevant for this usecase) | 11:19 |
dstanek | it seems that many products don't support ecp yet | 11:20 |
*** tovin07 is now known as tovin07_at_work | 11:20 | |
*** Dinesh_Bhor has joined #openstack-keystone | 11:20 | |
dstanek | https://en.wikipedia.org/wiki/SAML_2.0#SAML_2.0_Profiles | 11:20 |
*** tovin07_at_work has quit IRC | 11:20 | |
openstackgerrit | junboli proposed openstack/keystone master: Remove log translations https://review.openstack.org/449427 | 11:23 |
*** edmondsw has joined #openstack-keystone | 11:32 | |
*** spzala has joined #openstack-keystone | 11:50 | |
*** prashkre has quit IRC | 11:52 | |
*** prashkre has joined #openstack-keystone | 11:52 | |
dstanek | happy bug day! | 11:55 |
*** spzala has quit IRC | 11:56 | |
*** pnavarro has quit IRC | 12:00 | |
*** links has quit IRC | 12:02 | |
*** links has joined #openstack-keystone | 12:05 | |
*** d0ugal has quit IRC | 12:24 | |
*** spzala has joined #openstack-keystone | 12:32 | |
*** spzala has quit IRC | 12:37 | |
ma9_ | thank you dstanek | 12:44 |
dstanek | ma9_: np | 12:45 |
*** prashkre has quit IRC | 12:48 | |
*** lamt has joined #openstack-keystone | 12:52 | |
*** lamt has quit IRC | 12:52 | |
*** david-lyle has quit IRC | 12:55 | |
*** lamt has joined #openstack-keystone | 12:56 | |
*** spilla has joined #openstack-keystone | 12:56 | |
*** spzala has joined #openstack-keystone | 13:06 | |
*** spilla has quit IRC | 13:07 | |
*** spilla has joined #openstack-keystone | 13:09 | |
*** spzala has quit IRC | 13:12 | |
*** jrist has joined #openstack-keystone | 13:22 | |
*** agrebennikov_ has joined #openstack-keystone | 13:36 | |
*** Dinesh_Bhor has quit IRC | 13:39 | |
*** d0ugal has joined #openstack-keystone | 13:45 | |
*** spzala has joined #openstack-keystone | 13:45 | |
*** spzala has quit IRC | 13:50 | |
*** links has quit IRC | 13:53 | |
*** phalmos has quit IRC | 13:57 | |
*** ma9_ has quit IRC | 13:59 | |
*** jlopezgu_ has joined #openstack-keystone | 14:05 | |
*** dave-mccowan has joined #openstack-keystone | 14:08 | |
*** spzala has joined #openstack-keystone | 14:08 | |
*** lamt has quit IRC | 14:09 | |
openstackgerrit | junboli proposed openstack/keystone master: Remove log translations https://review.openstack.org/449427 | 14:10 |
*** pnavarro has joined #openstack-keystone | 14:12 | |
knikolla | morning o/ | 14:18 |
lbragstad | knikolla o/ | 14:20 |
*** spzala has quit IRC | 14:21 | |
*** chlong has joined #openstack-keystone | 14:25 | |
*** david-lyle has joined #openstack-keystone | 14:26 | |
dstanek | lbragstad: new patch just about ready for the webob thing......just waiting on the full test suite to run | 14:27 |
lbragstad | dstanek awesome - thank you for doing taht | 14:27 |
lbragstad | cc jdennis1 ^ | 14:27 |
lbragstad | I'd like to get that merged today (to close the bug) and also so requirements can make that bump | 14:27 |
lbragstad | cc dims ^ | 14:27 |
dims | yay, thanks lbragstad | 14:28 |
lbragstad | dims i didn't do anything - dstanek did it all ;) | 14:28 |
dims | thanks dstanek ! | 14:29 |
dstanek | lbragstad: i stepped back rethought it and did the simplest thing to make it work. i haven't compared it to my original patch though :-) was trying not to bias the work towards the complicated | 14:29 |
dstanek | dims: my pleasure | 14:29 |
*** alex_xu has quit IRC | 14:37 | |
*** alex_xu has joined #openstack-keystone | 14:38 | |
*** ravelar has joined #openstack-keystone | 14:39 | |
jdennis1 | lbragstad, dstanek: I will review, I've got meetings for the next few hours though ... | 14:40 |
lbragstad | jdennis1 no worries - whenever you get a minute, it'd be nice to have your opinion on it | 14:41 |
*** spzala has joined #openstack-keystone | 14:43 | |
*** phalmos has joined #openstack-keystone | 14:45 | |
*** erhudy has quit IRC | 14:50 | |
dstanek | ok, passes. going to snag my original commit message | 14:51 |
*** lucasxu has joined #openstack-keystone | 14:59 | |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Address comments from Steve Mar Policy in Code 5 https://review.openstack.org/448826 | 15:02 |
*** rmascena is now known as rmascena|lunch | 15:04 | |
lbragstad | dstanek sweet | 15:05 |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Address comments from Policy in Code 5 https://review.openstack.org/448826 | 15:11 |
*** rderose has joined #openstack-keystone | 15:14 | |
*** david-lyle has quit IRC | 15:15 | |
*** edtubill has joined #openstack-keystone | 15:15 | |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Remove policy file from source and refactor tests https://review.openstack.org/449675 | 15:16 |
openstackgerrit | David Stanek proposed openstack/keystone master: Small fixes for WebOb 1.7 compatibiltity https://review.openstack.org/422234 | 15:17 |
lbragstad | here's one that we can probably merge at some point today - https://review.openstack.org/#/c/437441/15 | 15:22 |
ravelar | lbragstad I have a problem with that test. | 15:24 |
lbragstad | ravelar which one? | 15:24 |
ravelar | lbragstad there is essentially no way to get that error in db_sync check to return without the dbmigration error that I created to raise first | 15:25 |
ravelar | even if I were to call db_sync check directly | 15:25 |
ravelar | the only way I could possibly get it to return that message in db_sync check is if I were to mock stuff to pretend that dbmigration didnt work and then mock stuff to pretend that it was still out of order (at which point I feel like it would be meaningless since its not really testing what would happen) | 15:26 |
lbragstad | hmm | 15:26 |
ravelar | and I understand that "we shouldn't remove that test because db_sync has that as a possible if statement" but this patch solves that | 15:27 |
ravelar | which is why I wanted to remove it from the beginning when writing this patch | 15:27 |
ravelar | however, I understand keeping it there. I am just not sure there is a sensible way to test it since it can never run now | 15:28 |
ravelar | so i am stuck lol | 15:28 |
lbragstad | dstanek just to clarify - with your latest patch set https://review.openstack.org/#/c/447712/1 is now irrelevant, right? | 15:28 |
lbragstad | ravelar i'll have another look at it | 15:28 |
lbragstad | ravelar i'm happy to see that we're not just removing the test though | 15:29 |
ravelar | lbragstad thank you! :) | 15:29 |
ravelar | lbragstad yeah no problem, totally understand | 15:29 |
dstanek | lbragstad: i'm not sure what you were trying to do there | 15:29 |
lbragstad | ravelar in your latest patch you've replaced it with three other tests | 15:29 |
lbragstad | dstanek me either, i was trying to work jdennis1's comment in, but didn't fully understand them - i'm going to abandon | 15:29 |
ravelar | lbragstad well the full summary is db_sync check used to have to take care of the case where it was run out of order (but that would only tell you after the fact, not as it was happening) | 15:30 |
*** jaosorior has quit IRC | 15:30 | |
lbragstad | ravelar ah | 15:31 |
ravelar | lbragstad now this patch does it as it happens, so that already stops it from ever occurring in db_sync check. On top of that, db_sync check has to pull all the repos so if it were to occur in the db_sync check method, it would again raise my error | 15:31 |
ravelar | before it gets to the if statement | 15:31 |
lbragstad | hmm | 15:31 |
ravelar | so I could never get to the if statement even if I wanted, unless I mocked stuff in test to do really weird things and lie lol | 15:31 |
*** Joannah has joined #openstack-keystone | 15:32 | |
ravelar | hence I removed the one test in db_sync check and made tests for the change I made | 15:32 |
ravelar | that does this for db_sync check now | 15:32 |
ravelar | is that making sense? sorry I feel like texting all this isn't too clear | 15:32 |
lbragstad | ravelar i'll revisit the patch | 15:34 |
ravelar | lbragstad alrighty, thanks. Let me know if there is anything you have a question about | 15:34 |
*** prashkre has joined #openstack-keystone | 15:36 | |
lbragstad | ravelar reviewing it again quick | 15:39 |
*** rderose_ has joined #openstack-keystone | 15:40 | |
*** knangia has joined #openstack-keystone | 15:42 | |
*** rderose has quit IRC | 15:43 | |
*** rderose_ has quit IRC | 15:43 | |
openstackgerrit | Felipe Monteiro proposed openstack/keystone master: Allow policy actions in code to be importable https://review.openstack.org/449694 | 15:44 |
*** rderose has joined #openstack-keystone | 15:44 | |
*** gyee has joined #openstack-keystone | 15:45 | |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Remove unnecessary revocation events https://review.openstack.org/448186 | 15:46 |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Remove unused revoke_by_project_role_assignment https://review.openstack.org/448613 | 15:46 |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Remove unused revoke_by_domain_role_assignment https://review.openstack.org/448615 | 15:46 |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Remove unnecessary revocation events revoke grant https://review.openstack.org/448192 | 15:46 |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Remove unnecessary revocation events https://review.openstack.org/447562 | 15:46 |
*** d0ugal has quit IRC | 15:52 | |
*** bjornar_ has joined #openstack-keystone | 16:00 | |
*** pcaruana has quit IRC | 16:03 | |
dstanek | rderose: looking at the bug to remove the ephemeral user type....is that something that is possible? | 16:11 |
rderose | dstanek: I think so, I mean federated users are no longer ephemeral | 16:12 |
rderose | dstanek: we'd still support the API, but refactor underlying code | 16:13 |
*** d0ugal has joined #openstack-keystone | 16:14 | |
*** d0ugal has quit IRC | 16:14 | |
*** d0ugal has joined #openstack-keystone | 16:14 | |
dstanek | rderose: well I don't know, that's why i'm asking :-) they are not ephemeral in the sense that we have them persisted...but is there still a different between mapping to a user in another backend using type:local+domain vs ephemeral groups? | 16:16 |
rderose | dstanek: not following your question | 16:20 |
rderose | dstanek: the only difference is that a federated user will get the mapped group roles | 16:20 |
*** belmoreira has quit IRC | 16:21 | |
*** d0ugal has quit IRC | 16:22 | |
*** lamt has joined #openstack-keystone | 16:23 | |
dstanek | rderose: ephemeral users were dynamically put into groups. local users were mapped to an existing user. i'm not sure if they could have dynamic groups or not. i'm asking if they are both the same now? | 16:24 |
dstanek | can they both be mapped to a local user to get concrete roles *and* dynamic groups to get additional roles? | 16:25 |
rderose | dstanek: yes, they both can | 16:25 |
rderose | however, a local user would have to have a federated profile (can't do this yet - ravelar's patch) to get dynamic group roles | 16:28 |
dstanek | rderose: shouldn't that aleady be possible? or did we break it? | 16:29 |
dstanek | rderose: i thought a 'local' user wouldn't get a federated_user record | 16:29 |
*** Joannah has quit IRC | 16:30 | |
rderose | dstanek: correct, currently a local could not get a federated_user record | 16:31 |
dstanek | rderose: right, but i can federate into keystone get a local user and dynamic groups right? | 16:32 |
rderose | dstanek: you ca federate in, we'll create a user > federated_user record (shadow mapping) | 16:33 |
rderose | and you'll get the mapped group roles | 16:33 |
rderose | so yes | 16:33 |
dstanek | rderose: so you can't map to an existing local user anymore? | 16:33 |
*** david-lyle has joined #openstack-keystone | 16:33 | |
rderose | dstanek: I don't think so | 16:34 |
*** niteshnarayanlal has joined #openstack-keystone | 16:34 | |
dstanek | hmmm.... that's not good | 16:34 |
rderose | dstanek: we had someone try that recently and only got the dynamic group roles; not the mapped local user roles | 16:34 |
dstanek | so local and ephemeral do have different behavior now | 16:35 |
rderose | of course, you could assign concrete role assignments to federated users and they will get the concrete roles and dynamic group roles | 16:35 |
rderose | dstanek: well, mapping a federated user to a local user doesn't work as I thought it would | 16:36 |
rderose | not sure if that is broken, or if it has never worked | 16:36 |
dstanek | rderose: at one time it did work | 16:36 |
rderose | dstanek: do we have test coverage? | 16:37 |
dstanek | rderose: so in today's world what should happen if i wnat to map to a local user? or maybe i just can't anymore? | 16:37 |
dstanek | rderose: we've never had functional test coverage for federation | 16:37 |
rderose | hmm... | 16:37 |
dstanek | it sucks that we lost merek. he was the guys that not only knew how everything worked, but why it had to work that way | 16:38 |
rderose | dstanek: I see | 16:38 |
rderose | dstanek: yeah, it totally seemed reasonable to me that you should be able to map a federated user to a local user, and get the local user roles | 16:39 |
dstanek | i wonder what version cern is on? i'm wondering if we broken them with our federation changes | 16:41 |
rderose | dstanek: not sure. maybe not, as I don't think it would be common for you to create local users for federation mapping | 16:42 |
rderose | dstanek: maybe for admins | 16:42 |
rderose | but not normal users | 16:42 |
*** nishaYadav has joined #openstack-keystone | 16:44 | |
nishaYadav | o/ | 16:45 |
*** MasterOfBugs has joined #openstack-keystone | 16:46 | |
dstanek | rderose: not sure. most of the federation was driven by cern and ibm i believe | 16:47 |
rderose | I see | 16:47 |
*** niteshnarayanlal has quit IRC | 16:47 | |
*** rmascena|lunch is now known as rmascena | 16:50 | |
rderose | dstanek: last I looked at the code/docs, I don't think we actually implemented mapping a federated user to a local user | 16:50 |
dstanek | n0tn0wm4n | 16:51 |
dstanek | kdirdir | 16:51 |
rderose | dstanek: if you provided a local user ID and name, it would simply be used as the ephemeral user's id and name | 16:51 |
dstanek | futte | 16:51 |
dstanek | lol | 16:51 |
rderose | dstanek: but not actually tied to a local user | 16:51 |
dstanek | alter.py just went nutz | 16:51 |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Add federated support for get user https://review.openstack.org/448730 | 16:52 |
dstanek | f0urt33ntH! | 16:52 |
dstanek | a3rt fir$t | 16:52 |
dstanek | grrrr.....sorry... turning off the plugin... | 16:52 |
rderose | dstanek: huh?? | 16:53 |
dstanek | rderose: i've been writing a plugin for weechat to alert me when thinks are happening. it just went nuts printing out hostnames in chat and giving me messages for *every* chat event in every channel i'm in | 16:54 |
rderose | haha | 16:54 |
knikolla | dstanek: we have functional test coverage for federation | 16:54 |
rderose | I see | 16:54 |
dstanek | knikolla: we have some tests now, but that's all after these changes. | 16:55 |
dstanek | knikolla: do you know if we test local users or what the behavior is? | 16:55 |
knikolla | dstanek: https://github.com/openstack/keystone/blob/master/keystone_tempest_plugin/tests/scenario/test_federated_authentication.py | 16:55 |
*** aojea_ has quit IRC | 16:56 | |
dstanek | knikolla: doesn't look like it | 16:56 |
knikolla | we only test the saml auth flow, but not local users | 16:56 |
knikolla | yes | 16:56 |
dstanek | knikolla: the local users use the SAML flow | 16:56 |
knikolla | the terminology is a bit tricky after the introduction of the shadow backend | 16:57 |
dstanek | knikolla: so basically at one type you could specify type:local + domain in the mapping to map to a local user | 16:57 |
dstanek | i'm pretty sure i remember it working and i'm just trying to confirm | 16:58 |
knikolla | dstanek: i have some old mappings. let me check | 16:58 |
*** edtubill has quit IRC | 16:58 | |
knikolla | dstanek: this still works for me https://github.com/knikolla/ansible-k2k/blob/master/roles/federation-sp/files/register_identity_providers.py#L99-L124 | 16:59 |
knikolla | not sure if it's because of the presence of the group too | 16:59 |
*** edtubill has joined #openstack-keystone | 17:00 | |
dstanek | knikolla: does that map back to a local user in SQL? | 17:00 |
*** niteshnarayanlal has joined #openstack-keystone | 17:00 | |
knikolla | dstanek: oh, my whole life is a lie. it doesn't. | 17:01 |
knikolla | too much automation i haven't touched in a year. | 17:02 |
dstanek | lol | 17:05 |
dstanek | brb...still getting fork bombed so i'm killing weechat for a sec | 17:05 |
dstanek | let's see if that's better... | 17:06 |
dstanek | rderose: knikolla: https://lists.launchpad.net/yahoo-eng-team/msg62331.html | 17:06 |
dstanek | https://wiki.geant.org/download/attachments/53117373/20160122%20-%20Federated%20access%20to%20Openstack.pdf?version=1&modificationDate=1453390823908&api=v2 | 17:06 |
dstanek | there are lots of non-OpenStack resources talking about the local mapping thing | 17:07 |
dstanek | i'll have to fire up a new environment and give it a try | 17:07 |
knikolla | dstanek: let me know. i remember i asked your help a few months ago about that, but i forgot the specifics. | 17:09 |
knikolla | i think i wasn't able to get it working. | 17:10 |
rderose | dstanek: from looking at the code, you can specify a user type and domain | 17:10 |
rderose | dstanek: which can then be used for federation | 17:11 |
dstanek | rderose: so i believe that what is supposed to happen is that you map to a local user and then all operations/tokens/etc are for their id | 17:12 |
rderose | dstanek: yeah, I think that happens | 17:12 |
rderose | dstanek: but it doesn't pull in the mapped local user role assignments | 17:12 |
rderose | dstanek: which is what I would expect | 17:12 |
rderose | dstanek: so I think you can map to a local user, but you still only get the mapped group roles | 17:14 |
*** catintheroof has joined #openstack-keystone | 17:14 | |
*** catintheroof has quit IRC | 17:15 | |
*** catintheroof has joined #openstack-keystone | 17:15 | |
rderose | dstanek: and just a side note, we're only shadowing users (and shadow mapping for that matter) for ephemeral users | 17:16 |
*** d0ugal has joined #openstack-keystone | 17:17 | |
rderose | but not when you specify a user type and domain | 17:17 |
*** lamt has quit IRC | 17:17 | |
dstanek | i wonder what yahoo is expecting to happen. | 17:21 |
dstanek | lbragstad: https://bugs.launchpad.net/keystone/+bug/1602081 | 17:26 |
openstack | Launchpad bug 1602081 in OpenStack Identity (keystone) "Use oslo.context's policy dict" [High,In progress] - Assigned to Jamie Lennox (jamielennox) | 17:26 |
dstanek | done? | 17:26 |
openstackgerrit | Richard Avelar proposed openstack/keystone master: Add a note to db_sync configuration section https://review.openstack.org/449744 | 17:26 |
lbragstad | dstanek check | 17:27 |
lbragstad | checking* | 17:27 |
*** ravelar has quit IRC | 17:27 | |
lbragstad | dstanek looks like https://review.openstack.org/#/c/371856/ was the only related fix merged to keystone | 17:29 |
dstanek | that's what i was thinking. so it's safe to mark as done right? | 17:36 |
*** lucasxu has quit IRC | 17:36 | |
lbragstad | dstanek looking at the patch | 17:36 |
dstanek | lbragstad: the commit message says related not closes, but no other patch has been proposed | 17:39 |
lbragstad | dstanek right | 17:39 |
lbragstad | dstanek i double checked the bug, too | 17:39 |
lbragstad | i'll have to dig into the patch | 17:40 |
dstanek | lbragstad: ok, no worries. i can dig into it. didn't know if you knew the status offhand | 17:44 |
* dstanek is running to go get a late lunch | 17:44 | |
*** ravelar has joined #openstack-keystone | 17:44 | |
*** spzala has quit IRC | 17:45 | |
*** spzala has joined #openstack-keystone | 17:47 | |
*** tesseract has quit IRC | 17:50 | |
*** spzala has quit IRC | 17:52 | |
*** spzala has joined #openstack-keystone | 17:52 | |
*** bjornar_ has quit IRC | 17:56 | |
*** bas_____ has joined #openstack-keystone | 18:01 | |
*** nishaYadav has quit IRC | 18:01 | |
*** jlopezgu_ has quit IRC | 18:01 | |
*** dolphm is now known as dr_dolphm | 18:02 | |
*** bjornar_ has joined #openstack-keystone | 18:05 | |
*** thiagolib has joined #openstack-keystone | 18:09 | |
bas_____ | Hi! Can I write here about Outreachy? There's no one in opw channel | 18:10 |
rodrigods | bas_____, sure, we are here to help | 18:11 |
openstackgerrit | prashkre proposed openstack/keystone master: Error messages are not translating with locale. https://review.openstack.org/449769 | 18:11 |
rodrigods | bas_____, you can also try the #openstack-outreachy channel | 18:11 |
*** d0ugal has quit IRC | 18:17 | |
bas_____ | oh, sorry, I'll go there then | 18:18 |
*** mvk has quit IRC | 18:23 | |
*** chlong has quit IRC | 18:24 | |
*** MasterOfBugs has quit IRC | 18:28 | |
*** lamt has joined #openstack-keystone | 18:40 | |
*** MasterOfBugs has joined #openstack-keystone | 18:46 | |
*** lucasxu has joined #openstack-keystone | 18:50 | |
lbragstad | ravelar do you know if upgrades.upgrade() is called anywhere? | 18:55 |
lbragstad | ravelar i'm running coverage on you patch now | 18:55 |
ravelar | lbragstad unit tests | 18:56 |
ravelar | lbragstad but not anywhere else | 18:56 |
*** Aqsa has quit IRC | 18:56 | |
ravelar | lbragstad I believe, its been a couple months since looking at it, let me recheck that | 18:57 |
dstanek | lbragstad: jamielennox's commit message on that patchs leads me to believethat the is still quite a bit of work to be done | 18:57 |
ravelar | the gist that I got when doing the patch was that (although highly unlikely the database would ever let you contract without running expand first) there wasn't a logical validation to stop it | 18:58 |
ravelar | and the unit tests would allow you to do something like that because of that method upgrades (which wasn't actually used from keystone-manage db_sync but was in unit tests) | 18:58 |
*** mvk has joined #openstack-keystone | 19:00 | |
*** bjornar_ has quit IRC | 19:02 | |
lbragstad | dstanek i got that impression, too... but it's not really laid out in any detail | 19:03 |
lbragstad | ravelar this is the latest coverage report i'm generating with your patch - http://104.130.175.68/cover/keystone_common_sql_upgrades_py.html | 19:03 |
ravelar | https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_sql_upgrade.py#L226-L240 | 19:04 |
ravelar | https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_sql_upgrade.py#L219-L224 | 19:04 |
knikolla | this release note seems to be in the wrong folder :/ https://github.com/openstack/keystone/tree/master/keystone/releasenotes/notes | 19:05 |
*** bas_____ has quit IRC | 19:05 | |
lbragstad | ravelar yeah - my last question doesn't really make sense - upgrade is called everywhere... | 19:06 |
lbragstad | just through it was strange because there are a couple untested cases in that method | 19:06 |
*** nishaYadav has joined #openstack-keystone | 19:08 | |
dstanek | lbragstad: lol, the webob patch fails tests because it expects the new behavior....i think i'm going to delete the those test checks | 19:11 |
lbragstad | dstanek yeah - that works for me | 19:11 |
lbragstad | it doesn't make sense to keep those assertions around | 19:12 |
ravelar | lbragstad so what is the consensus on the patch? lol im confused | 19:12 |
lbragstad | ravelar i'm trying to understand the approach to testing | 19:13 |
lbragstad | technically the tests you've written should cover the cases, but they don't appear to | 19:13 |
lbragstad | ravelar like here - http://104.130.175.68/cover/keystone_common_sql_upgrades_py.html | 19:13 |
dstanek | lbragstad: needs to kick off one more build...then i'll make those changes | 19:13 |
lbragstad | lines 306, 319, and 330 | 19:13 |
lbragstad | dstanek thanks | 19:14 |
ravelar | lbragstad ah okay lol | 19:14 |
lbragstad | ravelar line 1709 here https://review.openstack.org/#/c/437441/15/keystone/tests/unit/test_sql_upgrade.py | 19:15 |
dstanek | lbragstad: talking to you really helps tune my scripts heuristics :-) | 19:16 |
lbragstad | makes me think we should be covering the expand method at line 306 - http://104.130.175.68/cover/keystone_common_sql_upgrades_py.html | 19:16 |
lbragstad | dstanek at least i'm good for somethin' | 19:16 |
dstanek | :-) | 19:16 |
dstanek | i was working on my alert.py script last night and when i enabled it today it went crazy | 19:17 |
lbragstad | dstanek what's it do? | 19:17 |
dstanek | it's a weechat plugin to alter me of conversations | 19:18 |
lbragstad | ah | 19:18 |
dstanek | most scripts see your nick and alter you. i actually wanted to track conversations. for example, i got an alert for 'ah' just now | 19:18 |
dstanek | it knows that we are talking | 19:19 |
lbragstad | ... | 19:19 |
lbragstad | is it working? | 19:19 |
dstanek | but when you talked to ravelar i also got an alert | 19:19 |
dstanek | yep that works fine :-) | 19:19 |
lbragstad | :) | 19:19 |
lbragstad | interesting | 19:19 |
lbragstad | so i don't have to use your nick dstanek constantly?! | 19:19 |
dstanek | i was adding two unrelated features last night. one to parse a message and try to figure out if it was for another conversation and not for me and another to parse user's user/profile details | 19:20 |
dstanek | lbragstad: exactly | 19:20 |
*** erhudy has joined #openstack-keystone | 19:20 | |
lbragstad | lol nice | 19:20 |
dstanek | lbragstad: do you use weechat? | 19:20 |
lbragstad | textual | 19:21 |
dstanek | ah | 19:21 |
dstanek | first version of my script: https://gist.github.com/dstanek/d1bdc7eae621e821087d0a514d10dfd5 | 19:21 |
lbragstad | sweet! | 19:22 |
dstanek | conversation tracking in detail is tricky. even as a human i don't always know what message is for me if someone is having multiple conversations. you have to read it and see if it fits in what the discussion. | 19:24 |
dstanek | i need machine learning for my IRC alerts! | 19:24 |
lbragstad | right | 19:24 |
lbragstad | dstanek or just make it a convention to use peoples nicks ;) | 19:25 |
dstanek | we've been chattin and for the last 6 mins you haven't mentioned my nick. so if i switched contexts i might now know you were trying to talk to e | 19:26 |
dstanek | me | 19:26 |
lbragstad | dstanek true | 19:26 |
dstanek | good times | 19:27 |
ravelar | lbragstad sorry for the delay, meeting | 19:28 |
lbragstad | ravelar no worries | 19:29 |
ravelar | lbragstad upgrades.upgrade is only used in test_sql_upgrade right? | 19:29 |
ravelar | upgrades the file however is used in different places | 19:29 |
lbragstad | yeah - it's used all over in test_sql_upgrades | 19:30 |
ravelar | lbragstad is it possible that the only reason out of order is possible is because the unit tests use upgrades.upgrade | 19:30 |
ravelar | and upgrades.upgrade isn't the same thing that db_sync uses to do rolling upgrades | 19:31 |
lbragstad | i think that's the part that threw me off | 19:32 |
ravelar | lbragstad yeah I remember being mildly confused/annoyed that it was implemented that way when I was writing it | 19:33 |
ravelar | when I was writing the validation* | 19:33 |
ravelar | cause I had to add it to the upgrades since that was the only way it was being tests in unit tests | 19:33 |
ravelar | not just the main work flow of db_sync | 19:34 |
lbragstad | ravelar so with your tests, when you call self.expand(), what does that call? | 19:35 |
ravelar | upgrades.upgrade | 19:36 |
ravelar | cause nothing was calling db_sync directly | 19:36 |
ravelar | however, same validation is in both with my validation method | 19:36 |
ravelar | just have the method run before the schema is upgraded | 19:36 |
ravelar | in both upgrades.upgrade (unit tests) and upgrades.expand_schema, migrade_data(), etc | 19:37 |
lbragstad | ahhhhhhhhhhhhhhh | 19:39 |
ravelar | lbragstad so the big picture here is that you have this being run when db_sync is executed https://github.com/openstack/keystone/blob/master/keystone/common/sql/upgrades.py#L262-L293 | 19:39 |
lbragstad | so that's why expand_schema, migrate_data, and contract_schema don't show any test coverage | 19:40 |
lbragstad | yup | 19:40 |
ravelar | lbragstad and then you have this being run for unit tests https://github.com/openstack/keystone/blob/master/keystone/common/sql/upgrades.py#L42-L69 | 19:40 |
ravelar | lbragstad yeah i know its weird | 19:40 |
* lbragstad shakes head | 19:40 | |
lbragstad | wow | 19:40 |
ravelar | lbragstad didn't understand it either | 19:40 |
lbragstad | that took me *way* too long to figure out | 19:40 |
* ravelar nods head with lbragstad | 19:42 | |
lbragstad | it'd be super nice if the implementation and the tests used the *same* entry point | 19:42 |
ravelar | lbragstad should I do that as well? | 19:42 |
lbragstad | then we wouldn't have false positives in test coverage | 19:42 |
ravelar | lbragstad right | 19:42 |
lbragstad | ravelar you could, but I wouldn't hold up the patch you have for it | 19:42 |
lbragstad | i think that's it's own thing that needs to be refactored | 19:43 |
ravelar | lbragstad well as long as I have confirmation to redo it, wasn't sure if there was a reason for it till you confirmed otherwise with me lol | 19:43 |
ravelar | lbragstad, I could refactor first, then come back the validation stuff after I do proper test coverage and if it is still needed | 19:43 |
*** bjornar_ has joined #openstack-keystone | 19:43 | |
lbragstad | yeah - that'd work | 19:44 |
lbragstad | it depends on how long you think the refactor will take | 19:44 |
ravelar | lbragstad sweeet! hmm will I will take a stab at it lol | 19:44 |
ravelar | and in the process probably hit why it was done that way in the first place when I get to a road block or something | 19:44 |
lbragstad | because if it ends up being a sprawling change, i'd opt to fix the bug first then propose the cleanup afterwords | 19:44 |
ravelar | ahh okay i see | 19:45 |
*** Aqsa has joined #openstack-keystone | 19:45 | |
openstackgerrit | Kristi Nikolla proposed openstack/keystone master: Move release note from /keystone/releasenotes to /releasenotes https://review.openstack.org/449798 | 19:48 |
*** ynirk has left #openstack-keystone | 19:55 | |
lbragstad | dstanek you haven't been following the translation discussions have you? | 19:58 |
lbragstad | dstanek it might relate to https://review.openstack.org/#/c/449769/1 | 19:58 |
lbragstad | dstanek but i want to say that the discussion was only removing translated *logs* | 19:58 |
* lbragstad goes to double check | 19:58 | |
dstanek | lbragstad: looking | 19:58 |
dstanek | lbragstad: that is us no translating error messages back to the user | 19:59 |
lbragstad | dstanek | 19:59 |
lbragstad | dstanek right | 19:59 |
lbragstad | dstanek which is OK I think? | 20:00 |
dstanek | lbragstad: ok, not to translate? | 20:00 |
lbragstad | dstanek meaning that it is OK to fix? | 20:00 |
lbragstad | dstanek i'm double checking http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html | 20:00 |
lbragstad | which seems specific to translating logs not error messages back to the user | 20:00 |
dstanek | lbragstad: i'm guessing so. my understanding of that was that we didn't want to translate log messages anymore | 20:01 |
lbragstad | in this case I don't think we're translating logs - but an actual error message, so we should be good to fix | 20:01 |
lbragstad | right - ok cool | 20:01 |
lbragstad | same page | 20:01 |
dstanek | lbragstad: actually is prevents *anything* from being translated. we still have to remove the _* stuff to stop translating logs | 20:02 |
lbragstad | dstanek what prevents anything from being translated? | 20:02 |
dstanek | lbragstad: that bugs means that nothing is currently being translated | 20:05 |
dstanek | i help them debug it in chat and gave them the fix | 20:05 |
*** spzala has quit IRC | 20:05 | |
*** spzala has joined #openstack-keystone | 20:06 | |
dstanek | lbragstad: that was this conversation: http://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2017-03-20.log.html#t2017-03-20T14:02:49 | 20:08 |
openstackgerrit | prashkre proposed openstack/keystone master: Error messages are not translating with locale. https://review.openstack.org/449769 | 20:08 |
lbragstad | dstanek oh - right | 20:09 |
lbragstad | dstanek i see what you mean | 20:09 |
lbragstad | dstanek i saw a patch for the removal of the log translations floating around at some point this last week | 20:09 |
prashkre | dstanek:lbragstad: Hi. Thanks for reivew and comments on https://review.openstack.org/#/c/449769/. I have update release notes with link to bug.. please review again. | 20:10 |
lbragstad | prashkre reviewing again now | 20:10 |
*** spzala has quit IRC | 20:10 | |
lbragstad | prashkre thanks for the quick turn around | 20:10 |
dstanek | already did :-) | 20:11 |
prashkre | dstanek. new patch proposed addressing lbragstad comment. | 20:11 |
openstackgerrit | David Stanek proposed openstack/keystone master: Small fixes for WebOb 1.7 compatibiltity https://review.openstack.org/422234 | 20:12 |
lbragstad | dstanek nice - i just pulled ^ that up agin | 20:12 |
lbragstad | again* | 20:12 |
dstanek | lbragstad: i tested on both 1.6.0 and 1.7.2 | 20:13 |
lbragstad | dstanek thanks for doing that | 20:13 |
prashkre | lbragstad:dstanek: Thanks for quick review. | 20:15 |
*** spzala has joined #openstack-keystone | 20:15 | |
*** aojea has joined #openstack-keystone | 20:18 | |
*** thiagolib has quit IRC | 20:21 | |
openstackgerrit | Kristi Nikolla proposed openstack/keystone master: Move release note from /keystone/releasenotes to /releasenotes https://review.openstack.org/449798 | 20:22 |
*** nishaYadav has quit IRC | 20:23 | |
*** niteshnarayanlal has quit IRC | 20:27 | |
*** richm has quit IRC | 20:33 | |
*** phalmos has quit IRC | 20:37 | |
dstanek | lbragstad: work in the i18n one for keystone.... these tests look to be useless https://review.openstack.org/#/c/447864/3/keystone/tests/unit/test_exception.py,unified | 20:38 |
dstanek | i think i'm going to remove | 20:38 |
lbragstad | dstanek sounds good | 20:39 |
dstanek | lbragstad: i think i'm going to go get an early dinner and then finish up that patch | 20:41 |
openstackgerrit | Kristi Nikolla proposed openstack/keystone master: Move release note from /keystone/releasenotes to /releasenotes https://review.openstack.org/449798 | 20:42 |
dstanek | lbragstad: bugs still in the mid-90s :-( | 20:42 |
lbragstad | dstanek works for me - i have family coming into town shortly and i have to run some errands in a bit anyway | 20:42 |
lbragstad | dstanek i know, i wanted to get into the 80s today | 20:42 |
dstanek | lbragstad: cool, if you're not online this weekend i'll see you on monday | 20:42 |
lbragstad | we have a couple fixes that will be gating shortly though | 20:42 |
dstanek | lbragstad: i'm not done for the day yet :-) | 20:42 |
lbragstad | dstanek i'll be online later | 20:43 |
lbragstad | dstanek i'm trudging through a bunch of antwash's patches ;) | 20:43 |
dstanek | lbragstad: have you +2 ready :-) | 20:43 |
lbragstad | we lucked out and got the DocumentedRuleDefault object in the oslo.policy 1.21.0 release | 20:43 |
dstanek | nice | 20:43 |
lbragstad | so all those patches antwash proposed are passing | 20:44 |
lbragstad | which means we should be able to knock out the policy-docs spec next week | 20:44 |
dstanek | looks like stevemar still has his +2 handy | 20:45 |
* dstanek is walking out of the door | 20:46 | |
*** dave-mccowan has quit IRC | 21:01 | |
*** links has joined #openstack-keystone | 21:05 | |
*** aojea has quit IRC | 21:06 | |
*** pramodrj07 has joined #openstack-keystone | 21:16 | |
*** rmascena has quit IRC | 21:18 | |
*** MasterOfBugs has quit IRC | 21:20 | |
*** antwash_ has quit IRC | 21:21 | |
*** jlopezgu has quit IRC | 21:21 | |
*** aojea has joined #openstack-keystone | 21:22 | |
*** spilla has quit IRC | 21:24 | |
*** edtubill has quit IRC | 21:26 | |
openstackgerrit | junboli proposed openstack/keystone master: Remove log translations https://review.openstack.org/449427 | 21:57 |
*** pramodrj07 has quit IRC | 22:03 | |
*** pramodrj07 has joined #openstack-keystone | 22:03 | |
*** knikolla has left #openstack-keystone | 22:03 | |
*** prashkre has quit IRC | 22:08 | |
*** richm has joined #openstack-keystone | 22:26 | |
*** lucasxu has quit IRC | 22:27 | |
*** richm has left #openstack-keystone | 22:29 | |
*** spzala has quit IRC | 22:30 | |
openstackgerrit | Merged openstack/keystone master: Error messages are not translating with locale. https://review.openstack.org/449769 | 22:52 |
*** aojea has quit IRC | 22:59 | |
*** erhudy has quit IRC | 23:00 | |
*** jlopezgu has joined #openstack-keystone | 23:02 | |
*** jlopezgu has quit IRC | 23:03 | |
*** jlopezgu has joined #openstack-keystone | 23:09 | |
*** richm1 has joined #openstack-keystone | 23:13 | |
*** markvoelker has quit IRC | 23:24 | |
*** links has quit IRC | 23:24 | |
*** agrebennikov_ has quit IRC | 23:26 | |
*** lamt has quit IRC | 23:41 | |
*** lucasxu has joined #openstack-keystone | 23:45 | |
*** spzala has joined #openstack-keystone | 23:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!