| *** gongysh has joined #openstack-keystone | 00:05 | |
| *** gongysh has quit IRC | 00:06 | |
| * samueldmq 's back | 00:12 | |
| *** openstackstatus has quit IRC | 00:13 | |
| *** openstackstatus has joined #openstack-keystone | 00:14 | |
| *** ChanServ sets mode: +v openstackstatus | 00:14 | |
| samueldmq | lbragstad: you around ? | 00:21 |
|---|---|---|
| *** jmlowe has joined #openstack-keystone | 00:30 | |
| samueldmq | lbragstad: talked in -infra, I am finding my +2s sticky sometimes in gerrit | 00:31 |
| samueldmq | and other times it's really odd, like in https://review.openstack.org/#/c/466066/ | 00:31 |
| samueldmq | I had +2ed, -1ed and finished with a +2 even if I didn't give a +2, that's odd | 00:31 |
| samueldmq | I was wondering if you (or any other cores) were seeing the same | 00:32 |
| *** zhugaoxiao has quit IRC | 00:39 | |
| *** Administrator__ has quit IRC | 00:39 | |
| *** spzala has joined #openstack-keystone | 00:41 | |
| samueldmq | ah gerrit automatically adds your vote back if the patch comes to the same state of a previous patchset you had a vote on | 00:42 |
| samueldmq | that's interesting | 00:42 |
| *** liujiong has joined #openstack-keystone | 00:59 | |
| *** akrzos has quit IRC | 00:59 | |
| *** akrzos has joined #openstack-keystone | 01:06 | |
| samueldmq | lbragstad: all patches in bug/1696574 will need updates in those policy in code descriptions, used to generate the sample file :) | 01:17 |
| samueldmq | lbragstad: I guess they can come as follow-up | 01:17 |
| *** xuhaigang has joined #openstack-keystone | 01:22 | |
| samueldmq | lbragstad: we need stable cores to look at https://review.openstack.org/#/c/469069 and https://review.openstack.org/#/c/469514 | 01:25 |
| samueldmq | is morgan a stable core? ^ | 01:25 |
| samueldmq | or stevemar ? | 01:26 |
| openstackgerrit | Merged openstack/keystone master: Use DocumentedRuleDefault for token operations https://review.openstack.org/449255 | 01:27 |
| *** Shunli has joined #openstack-keystone | 01:31 | |
| *** hoonetorg has quit IRC | 01:35 | |
| openstackgerrit | Merged openstack/keystone master: Move related project information into main doc https://review.openstack.org/476675 | 01:35 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone master: Add annotation about token authenticate https://review.openstack.org/472511 | 01:45 |
| *** hoonetorg has joined #openstack-keystone | 01:52 | |
| *** dave-mccowan has joined #openstack-keystone | 02:03 | |
| *** shuyingya has joined #openstack-keystone | 02:06 | |
| *** shuyingya has quit IRC | 02:06 | |
| *** shuyingya has joined #openstack-keystone | 02:06 | |
| *** shuyingya has quit IRC | 02:07 | |
| *** shuyingya has joined #openstack-keystone | 02:07 | |
| *** zhurong has joined #openstack-keystone | 02:09 | |
| *** tobberydberg has joined #openstack-keystone | 02:11 | |
| *** shuyingya has quit IRC | 02:13 | |
| *** shuyingya has joined #openstack-keystone | 02:13 | |
| *** tobberydberg has quit IRC | 02:16 | |
| *** phalmos has quit IRC | 02:23 | |
| *** spzala has quit IRC | 02:41 | |
| *** spzala has joined #openstack-keystone | 02:42 | |
| *** spzala has quit IRC | 02:46 | |
| openstackgerrit | Merged openstack/keystone master: Split test_get_head_catalog_no_token https://review.openstack.org/476710 | 02:46 |
| openstackgerrit | Merged openstack/keystoneauth master: Updated from global requirements https://review.openstack.org/474649 | 02:50 |
| openstackgerrit | Merged openstack/keystonemiddleware master: Fix html_last_updated_fmt for Python3 https://review.openstack.org/472619 | 02:56 |
| openstackgerrit | Merged openstack/keystonemiddleware master: Removing double spaces https://review.openstack.org/474845 | 02:57 |
| *** zhurong has quit IRC | 02:58 | |
| *** markvoelker has quit IRC | 02:59 | |
| *** zhurong has joined #openstack-keystone | 02:59 | |
| openstackgerrit | Merged openstack/keystonemiddleware master: Updated from global requirements https://review.openstack.org/472903 | 03:00 |
| *** markvoelker has joined #openstack-keystone | 03:00 | |
| *** sbezverk has joined #openstack-keystone | 03:01 | |
| *** thorst has joined #openstack-keystone | 03:03 | |
| *** thorst has quit IRC | 03:04 | |
| *** markvoelker has quit IRC | 03:05 | |
| *** nicolasbock has joined #openstack-keystone | 03:16 | |
| *** edmondsw has quit IRC | 03:17 | |
| *** namnh has joined #openstack-keystone | 03:21 | |
| *** zhurong has quit IRC | 04:02 | |
| *** dave-mccowan has quit IRC | 04:05 | |
| *** markvoelker has joined #openstack-keystone | 04:14 | |
| *** links has joined #openstack-keystone | 04:16 | |
| *** tobberydberg has joined #openstack-keystone | 04:27 | |
| *** tobberydberg has quit IRC | 04:31 | |
| *** zhurong has joined #openstack-keystone | 04:35 | |
| *** markvoelker has quit IRC | 04:48 | |
| *** edmondsw has joined #openstack-keystone | 04:49 | |
| *** edmondsw has quit IRC | 04:54 | |
| *** spzala has joined #openstack-keystone | 04:55 | |
| *** spzala has quit IRC | 04:59 | |
| openstackgerrit | Merged openstack/keystone master: Ensure the endpoint filter API supports HEAD https://review.openstack.org/473855 | 05:07 |
| openstackgerrit | Merged openstack/keystone master: Add HEAD API to domain config https://review.openstack.org/472876 | 05:07 |
| openstackgerrit | Merged openstack/keystone master: Move domain config to DocumentedRuleDefault https://review.openstack.org/449337 | 05:11 |
| openstackgerrit | Merged openstack/keystone master: Ensure the ec2 API supports HEAD https://review.openstack.org/473882 | 05:11 |
| openstackgerrit | Merged openstack/keystone master: Ensure oauth API supports HEAD https://review.openstack.org/473891 | 05:12 |
| openstackgerrit | Merged openstack/keystone master: Ensure the trust API supports HEAD requests https://review.openstack.org/473902 | 05:23 |
| openstackgerrit | Merged openstack/keystone master: Ensure HEAD is supported with simple cert https://review.openstack.org/473893 | 05:23 |
| openstackgerrit | Merged openstack/keystone master: Ensure the endpoint policy API supports HEAD https://review.openstack.org/473885 | 05:23 |
| *** markvoelker has joined #openstack-keystone | 05:24 | |
| *** spzala has joined #openstack-keystone | 05:25 | |
| *** spzala has quit IRC | 05:30 | |
| *** markvoelker has quit IRC | 05:31 | |
| *** markvoelker has joined #openstack-keystone | 05:36 | |
| *** thorst has joined #openstack-keystone | 05:36 | |
| *** thorst has quit IRC | 05:40 | |
| *** markvoelker has quit IRC | 05:41 | |
| *** spzala has joined #openstack-keystone | 05:42 | |
| *** spzala has quit IRC | 05:46 | |
| *** markvoelker has joined #openstack-keystone | 05:52 | |
| morgan | Yes I am a stable core | 05:55 |
| -openstackstatus- NOTICE: unknown issue with the git farm, everything broken - we're investigating | 06:02 | |
| *** ChanServ changes topic to "unknown issue with the git farm, everything broken - we're investigating" | 06:02 | |
| *** spzala has joined #openstack-keystone | 06:05 | |
| *** gyee has quit IRC | 06:08 | |
| *** markvoelker has quit IRC | 06:08 | |
| *** spzala has quit IRC | 06:10 | |
| *** markvoelker has joined #openstack-keystone | 06:12 | |
| *** markvoelker has quit IRC | 06:27 | |
| *** rcernin_ has joined #openstack-keystone | 06:32 | |
| *** spzala has joined #openstack-keystone | 06:36 | |
| *** edmondsw has joined #openstack-keystone | 06:37 | |
| *** spzala has quit IRC | 06:40 | |
| *** edmondsw has quit IRC | 06:42 | |
| *** spzala has joined #openstack-keystone | 07:03 | |
| *** spzala has quit IRC | 07:08 | |
| *** pcaruana has joined #openstack-keystone | 07:18 | |
| *** markvoelker has joined #openstack-keystone | 07:21 | |
| *** markvoelker has quit IRC | 07:26 | |
| *** markvoelker has joined #openstack-keystone | 07:28 | |
| *** spzala has joined #openstack-keystone | 07:34 | |
| *** gongysh has joined #openstack-keystone | 07:35 | |
| *** markvoelker has quit IRC | 07:35 | |
| *** spzala has quit IRC | 07:39 | |
| *** tesseract has joined #openstack-keystone | 07:45 | |
| *** spzala has joined #openstack-keystone | 07:48 | |
| *** junbo has joined #openstack-keystone | 07:48 | |
| *** pooja_jadhav has quit IRC | 07:49 | |
| *** spzala has quit IRC | 07:52 | |
| *** f13o has joined #openstack-keystone | 07:57 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-keystone | 08:00 | |
| *** admcleod_ has quit IRC | 08:00 | |
| -openstackstatus- NOTICE: ok git.openstack.org is working again, you can recheck failed jobs | 08:02 | |
| *** ChanServ changes topic to "ok git.openstack.org is working again, you can recheck failed jobs" | 08:02 | |
| *** markvoelker has joined #openstack-keystone | 08:09 | |
| *** cristicalin has joined #openstack-keystone | 08:14 | |
| *** markvoelker has quit IRC | 08:14 | |
| *** markvoelker has joined #openstack-keystone | 08:16 | |
| *** f13o has quit IRC | 08:16 | |
| *** markvoelker has quit IRC | 08:20 | |
| knikolla | o/ morning! | 08:23 |
| openstackgerrit | Van Hung Pham proposed openstack/keystonemiddleware master: Using assertFalse(A) instead of assertEqual(False, A) https://review.openstack.org/476832 | 08:23 |
| cmurphy | knikolla: morning! welcome to the quiet side of the world | 08:23 |
| knikolla | cmurphy: thanks! | 08:25 |
| knikolla | cmurphy: how's germany? | 08:25 |
| cmurphy | knikolla: it is great, perfect biergarten weather | 08:25 |
| cmurphy | knikolla: where are you at? | 08:26 |
| *** edmondsw has joined #openstack-keystone | 08:26 | |
| knikolla | cmurphy: visiting home in Albania. | 08:26 |
| cmurphy | knikolla: awesome, i've never been there | 08:27 |
| knikolla | cmurphy: wouldn't really recommend it. I was in Germany just a week prior to the summit though. :) Have friends in Karlsruhe and Darmstadt. | 08:27 |
| cmurphy | neat :) | 08:28 |
| *** markvoelker has joined #openstack-keystone | 08:28 | |
| *** edmondsw has quit IRC | 08:30 | |
| *** f13o has joined #openstack-keystone | 08:32 | |
| *** shuyingya has quit IRC | 08:33 | |
| *** spzala has joined #openstack-keystone | 08:34 | |
| *** xuhaigang has quit IRC | 08:35 | |
| openstackgerrit | Van Hung Pham proposed openstack/keystoneauth master: Using assertFalse(A) instead of assertEqual(False, A) https://review.openstack.org/476837 | 08:35 |
| *** markvoelker has quit IRC | 08:35 | |
| *** spzala has quit IRC | 08:38 | |
| *** f13o has quit IRC | 08:44 | |
| *** markvoelker has joined #openstack-keystone | 08:49 | |
| *** pnavarro has quit IRC | 08:52 | |
| *** henrynash has joined #openstack-keystone | 08:53 | |
| *** pnavarro has joined #openstack-keystone | 08:53 | |
| *** xuhaigang has joined #openstack-keystone | 08:53 | |
| *** markvoelker has quit IRC | 08:58 | |
| *** f13o has joined #openstack-keystone | 09:02 | |
| *** spzala has joined #openstack-keystone | 09:02 | |
| *** markvoelker has joined #openstack-keystone | 09:05 | |
| *** shuyingya has joined #openstack-keystone | 09:05 | |
| *** pnavarro has quit IRC | 09:05 | |
| *** pnavarro has joined #openstack-keystone | 09:06 | |
| *** spzala has quit IRC | 09:08 | |
| *** markvoelker has quit IRC | 09:09 | |
| *** ChanServ changes topic to "Pike release schedule: https://releases.openstack.org/pike/schedule.html | Meeting agenda: https://etherpad.openstack.org/p/keystone-weekly-meeting | Bugs that need triaging: http://bit.ly/2iJuN1h" | 09:10 | |
| *** aselius has quit IRC | 09:10 | |
| *** f13o has quit IRC | 09:14 | |
| *** henrynash has quit IRC | 09:15 | |
| *** markvoelker has joined #openstack-keystone | 09:21 | |
| *** markvoelker has quit IRC | 09:25 | |
| *** markvoelker has joined #openstack-keystone | 09:27 | |
| *** gongysh has quit IRC | 09:28 | |
| *** Shunli has quit IRC | 09:31 | |
| *** markvoelker has quit IRC | 09:33 | |
| *** spzala has joined #openstack-keystone | 09:33 | |
| *** zhurong has quit IRC | 09:37 | |
| *** spzala has quit IRC | 09:38 | |
| *** markvoelker has joined #openstack-keystone | 09:47 | |
| *** spzala has joined #openstack-keystone | 09:48 | |
| *** spzala has quit IRC | 09:52 | |
| *** cristicalin has quit IRC | 09:54 | |
| *** markvoelker has quit IRC | 09:55 | |
| *** chlong has quit IRC | 10:03 | |
| *** namnh has quit IRC | 10:03 | |
| *** liujiong has quit IRC | 10:04 | |
| *** henrynash has joined #openstack-keystone | 10:09 | |
| *** junbo has quit IRC | 10:10 | |
| *** junbo has joined #openstack-keystone | 10:13 | |
| *** edmondsw has joined #openstack-keystone | 10:14 | |
| *** edmondsw has quit IRC | 10:18 | |
| *** spzala has joined #openstack-keystone | 10:18 | |
| *** henrynash has quit IRC | 10:20 | |
| *** spzala has quit IRC | 10:23 | |
| *** markvoelker has joined #openstack-keystone | 10:25 | |
| *** ppiela has quit IRC | 10:27 | |
| *** ppiela has joined #openstack-keystone | 10:27 | |
| *** markvoelker has quit IRC | 10:29 | |
| *** markvoelker has joined #openstack-keystone | 10:31 | |
| *** spzala has joined #openstack-keystone | 10:34 | |
| *** spzala has quit IRC | 10:38 | |
| *** markvoelker has quit IRC | 10:40 | |
| *** markvoelker has joined #openstack-keystone | 10:42 | |
| *** sjain has joined #openstack-keystone | 10:44 | |
| *** markvoelker has quit IRC | 10:53 | |
| sjain | asettle: are the OS specific changes in the openstack-manuals done, can I pull them to keystone directory? | 10:54 |
| asettle | sjain: lemme just have a peak :) | 10:54 |
| sjain | sure | 10:54 |
| asettle | Not quite: https://review.openstack.org/475435 | 10:55 |
| asettle | https://review.openstack.org/475395 | 10:55 |
| asettle | This one has gone thorugh though: https://review.openstack.org/473579 | 10:55 |
| asettle | I think you need this one too: https://review.openstack.org/#/c/472275/ | 10:56 |
| sjain | okay cool I can work on these install guides for now | 10:56 |
| sjain | thanks :) | 10:56 |
| sjain | btw asettle: I hope there are no more changes in install guides? | 10:57 |
| sjain | *upcoming changes | 10:57 |
| asettle | sjain: the master branch is frozen :) | 10:57 |
| asettle | Unless its migration related | 10:57 |
| sjain | cool, thanks! | 10:58 |
| asettle | You're welcome :) | 10:58 |
| *** raildo has joined #openstack-keystone | 10:58 | |
| *** spzala has joined #openstack-keystone | 11:03 | |
| *** spzala has quit IRC | 11:07 | |
| *** ducttape_ has joined #openstack-keystone | 11:09 | |
| *** shuyingya has quit IRC | 11:09 | |
| *** shuyingy_ has joined #openstack-keystone | 11:09 | |
| *** ducttape_ has quit IRC | 11:13 | |
| *** markvoelker has joined #openstack-keystone | 11:14 | |
| *** pnavarro has quit IRC | 11:15 | |
| *** sjain has quit IRC | 11:16 | |
| *** pnavarro has joined #openstack-keystone | 11:19 | |
| *** markvoelker has quit IRC | 11:21 | |
| *** markvoelker has joined #openstack-keystone | 11:24 | |
| *** sjain has joined #openstack-keystone | 11:26 | |
| *** markvoelker has quit IRC | 11:29 | |
| *** openstackgerrit has quit IRC | 11:33 | |
| *** spzala has joined #openstack-keystone | 11:34 | |
| *** spzala has quit IRC | 11:39 | |
| *** f13o has joined #openstack-keystone | 11:39 | |
| *** henrynash has joined #openstack-keystone | 11:40 | |
| *** sjain has quit IRC | 11:43 | |
| *** henrynash has quit IRC | 11:44 | |
| *** markvoelker has joined #openstack-keystone | 11:48 | |
| *** spzala has joined #openstack-keystone | 11:50 | |
| *** markvoelker has quit IRC | 11:53 | |
| *** markvoelker has joined #openstack-keystone | 11:54 | |
| *** spzala has quit IRC | 11:54 | |
| *** sjain_ has joined #openstack-keystone | 11:55 | |
| *** markvoelker has quit IRC | 11:58 | |
| *** shuyingy_ has quit IRC | 11:58 | |
| *** thorst has joined #openstack-keystone | 12:00 | |
| *** jistr is now known as jistr|errand | 12:00 | |
| *** markvoelker has joined #openstack-keystone | 12:11 | |
| *** pnavarro has quit IRC | 12:12 | |
| *** markvoelker has quit IRC | 12:15 | |
| *** markvoelker has joined #openstack-keystone | 12:18 | |
| *** dave-mccowan has joined #openstack-keystone | 12:19 | |
| *** edmondsw has joined #openstack-keystone | 12:21 | |
| *** markvoelker has quit IRC | 12:25 | |
| vladiskuz | breton: Do you know how to configure Ceph with Keystone using Fernet token? | 12:33 |
| *** f13o has quit IRC | 12:36 | |
| *** f13o has joined #openstack-keystone | 12:44 | |
| breton | vladiskuz: nope | 12:45 |
| breton | vladiskuz: maybe ceph folks know | 12:45 |
| *** spzala has joined #openstack-keystone | 12:47 | |
| *** sjain_ has quit IRC | 12:50 | |
| *** spzala has quit IRC | 12:52 | |
| *** lucasxu has joined #openstack-keystone | 12:56 | |
| *** catintheroof has joined #openstack-keystone | 13:00 | |
| *** bknudson has joined #openstack-keystone | 13:01 | |
| *** slunkad_ has quit IRC | 13:02 | |
| *** Dinesh_Bhor has quit IRC | 13:10 | |
| *** spzala has joined #openstack-keystone | 13:18 | |
| hrybacki | lbragstad knikolla reminder that we make the call at 5PM EST tonight regarding: https://beta.doodle.com/poll/epvs95npfvrd3h5e#table So far we have seven responses with the most agreed upon time block being Tuesday evenings. However it looks like cmurphy can't make that block so we may opt for another? | 13:20 |
| *** spzala has quit IRC | 13:23 | |
| cmurphy | well don't block it on account of me, i can work on bugs at other times | 13:24 |
| cmurphy | and my tuesday evening conflict is temporary | 13:24 |
| *** jistr|errand is now known as jistr | 13:25 | |
| knikolla | hrybacki: ack. | 13:25 |
| knikolla | Tuesday morning seems the other best day | 13:26 |
| knikolla | Time* | 13:27 |
| knikolla | Since same day :P | 13:27 |
| *** ducttape_ has joined #openstack-keystone | 13:32 | |
| hrybacki | knikolla: and lines up nicely with our meeting :) | 13:33 |
| knikolla | Yep | 13:34 |
| *** spzala has joined #openstack-keystone | 13:37 | |
| *** jmlowe has quit IRC | 13:40 | |
| *** shuyingya has joined #openstack-keystone | 13:47 | |
| *** shuyingya has quit IRC | 13:51 | |
| *** chlong has joined #openstack-keystone | 13:56 | |
| *** bknudson1 has joined #openstack-keystone | 13:58 | |
| *** bknudson has quit IRC | 14:00 | |
| *** ducttape_ has quit IRC | 14:00 | |
| *** jmlowe has joined #openstack-keystone | 14:16 | |
| *** aojea has joined #openstack-keystone | 14:31 | |
| lbragstad | knikolla: hrybacki that sounds good - i was looking at the responses yesterday | 14:35 |
| *** openstackgerrit has joined #openstack-keystone | 14:36 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: DO NOT MERGE: Testing rolling upgrades https://review.openstack.org/476143 | 14:36 |
| hrybacki | is there a way to see the self url for a project when using the openstack client? | 14:36 |
| lbragstad | hrybacki: i don't think so - or not that i know of | 14:36 |
| hrybacki | I know they are in the response body | 14:36 |
| hrybacki | lbragstad: okay, thanks | 14:36 |
| lbragstad | nice work team! https://twitter.com/andymccrae/status/878235743998455808 | 14:41 |
| hrybacki | lbragstad++ nice! | 14:42 |
| lbragstad | this is also a good read - http://blog.andy.mc.it/testing-your-project-with-openstack-ansible/ | 14:42 |
| knikolla | hrybacki: what do you mean by self url for a project? | 14:42 |
| lbragstad | andymccr: odyssey4me we still have a little bit of work to do there to make sure we test the stable/master case, right? | 14:42 |
| andymccr | lbragstad: i put a fix in for that already - lemme double check | 14:43 |
| lbragstad | i think it was if A is propose to stable and B is propose to master, the need to be tested at the same time | 14:43 |
| hrybacki | knikolla: specifically I'm trying to find out what OpenStack client is getting out of the resposne in links.projects[whatever].links.self | 14:44 |
| hrybacki | https://paste.fedoraproject.org/ | 14:44 |
| hrybacki | my bad: https://paste.fedoraproject.org/paste/KBfnkvCJi-MuGb1T-CFHHg | 14:44 |
| andymccr | lbragstad: hmm you mean you have a stable patch and a master patch - to test both? hmm not sure how we would achieve that | 14:45 |
| knikolla | hrybacki: i usually do a `openstack token issue` and see whatever project that gives me. | 14:46 |
| hrybacki | knikolla: trying to figure out if OSC would return project links tied to the InternalURL rather than the PublicURL. In this case, W.X.Y.Z is the PublicURL | 14:46 |
| odyssey4me | andymccr lbragstad yeah, we'd have to work that out - although not sure what the urgency is at the moment | 14:46 |
| lbragstad | andymccr: yeah - it was a super interesting testing edge case that clarkb and fungi described | 14:46 |
| knikolla | You can do that with --debug and see the response in the token. Maybe. | 14:46 |
| odyssey4me | we can fence against that interfering for now by just ensuring that we block any stable branch zuul changes from being included | 14:46 |
| andymccr | how do those repos get cloned? | 14:46 |
| knikolla | hrybacki: oh i see. | 14:47 |
| lbragstad | odyssey4me: yeah - that's a good point, i was more of less just trying to figure out what the next steps were | 14:47 |
| andymccr | like if i have a stable branch and a master branch - where do they go? | 14:47 |
| andymccr | if we know that it should be reasonably ok | 14:47 |
| odyssey4me | andymccr we'd need to set out two folders to scan, one with the old repositories (for the stable branch) and one for the new | 14:47 |
| odyssey4me | then ensure the clone map knows where to put which | 14:47 |
| lbragstad | something like /opt/stack/old/keystone and /opt/stack/new/keystone | 14:47 |
| andymccr | hmm yeah | 14:47 |
| odyssey4me | ^ yeah, that's what devstack-gate does | 14:48 |
| hrybacki | knikolla: ack. I've modified my identity endpoint to use the machines loopback address as the InternalURL to help me figure it out | 14:48 |
| andymccr | i fixed the case where stable/pike --> master will cause teh keystone package to be used by both since the package constraints file is name-spaced by version now | 14:48 |
| lbragstad | old being stable/ocata + any dependent patches and new being master + and patches in review | 14:48 |
| odyssey4me | which is why infra suggested we work out how to use devstack gate and switch to it instead of reinventong the wheel | 14:48 |
| andymccr | odyssey4me: yeah i thinkt hat is probably a better way to go | 14:48 |
| lbragstad | well - the devstack gate tooling | 14:48 |
| lbragstad | or job template? | 14:48 |
| odyssey4me | lbragstad tooling | 14:48 |
| odyssey4me | it does a bunch of stuff we also do | 14:49 |
| odyssey4me | if we can converge, it'll be less burden for us all | 14:49 |
| lbragstad | ++ | 14:49 |
| knikolla | hrybacki: i would assume the openstackclient ignores self links and instead rebuilds the link itself. | 14:49 |
| odyssey4me | but unfortunately that also means it'll take time to figure out, because the paradigms are quite different | 14:49 |
| lbragstad | andymccr: regarding http://blog.andy.mc.it/testing-your-project-with-openstack-ansible/ | 14:49 |
| knikolla | When trying to access a resource. | 14:50 |
| lbragstad | andymccr: another big advantage we saw with using osa over devstack was that we could do more with less gate resources | 14:50 |
| *** sjain has joined #openstack-keystone | 14:50 | |
| andymccr | lbragstad: ahh good point - i can add that in :) | 14:50 |
| lbragstad | (e.g. running the upgrade across containers instead of across vms, hopefully making it more friendly for infra) | 14:50 |
| *** jistr is now known as jistr|mtg | 14:54 | |
| *** bknudson1 has quit IRC | 14:57 | |
| *** ducttape_ has joined #openstack-keystone | 15:00 | |
| *** rcernin_ has quit IRC | 15:01 | |
| *** bknudson has joined #openstack-keystone | 15:02 | |
| breton | what is today's way of having a superadmin user? Admin role in is_admin_project? | 15:09 |
| lbragstad | breton: that works isn't finished | 15:10 |
| lbragstad | breton: admin is still technically super admin | 15:10 |
| breton | lbragstad: ok. I am planning to implement is_admin_project thingy in panko and was making sure. | 15:11 |
| *** ducttape_ has quit IRC | 15:11 | |
| *** aselius has joined #openstack-keystone | 15:11 | |
| *** ducttape_ has joined #openstack-keystone | 15:11 | |
| lbragstad | breton: we do have this, too https://review.openstack.org/#/c/464763/ | 15:12 |
| lbragstad | which was proposed partially because of http://lists.openstack.org/pipermail/openstack-dev/2017-June/118047.html | 15:13 |
| lbragstad | breton: these might give you more context http://lists.openstack.org/pipermail/openstack-dev/2017-May/117419.html | 15:13 |
| lbragstad | http://lists.openstack.org/pipermail/openstack-dev/2017-May/117441.html | 15:14 |
| *** aojea has quit IRC | 15:15 | |
| lbragstad | breton: i plan on starting that implementation ^ next week | 15:16 |
| lbragstad | or at least a PoC of it | 15:16 |
| *** links has quit IRC | 15:16 | |
| breton | >_> | 15:17 |
| breton | ok | 15:18 |
| breton | lbragstad: do you think i should wait with my implementation? | 15:18 |
| lbragstad | well - you're going to be waiting on keystone for fixes regardless :/ | 15:20 |
| *** sjain has quit IRC | 15:20 | |
| breton | what fixes for example? | 15:21 |
| lbragstad | breton: you're going to be waiting for is_admin_project to finish being implemented or global roles to be implemented | 15:21 |
| breton | lbragstad: yeah, but what's left from is_admin_project? | 15:22 |
| breton | lbragstad: i know that not all projects use it today | 15:22 |
| lbragstad | breton: a few fixes in keystone, but quite a bit of work cross project | 15:22 |
| lbragstad | breton: i listed the pros and cons of each in the ^ thread above | 15:23 |
| breton | lbragstad: nah, i don't depend on cross-project work if i implement it in panko | 15:23 |
| lbragstad | samueldmq: https://specs.openstack.org/openstack/docs-specs/specs/pike/os-manuals-migration.html merged - so we can start merging patches that migrate things from openstack-manuals | 15:26 |
| lbragstad | samueldmq: not sure if sjain has seen ^ that yet | 15:27 |
| *** jistr|mtg is now known as jistr | 15:30 | |
| *** ducttape_ has quit IRC | 15:43 | |
| *** ducttape_ has joined #openstack-keystone | 15:47 | |
| *** ducttap__ has joined #openstack-keystone | 15:55 | |
| *** ducttape_ has quit IRC | 15:57 | |
| *** ducttape_ has joined #openstack-keystone | 15:57 | |
| *** ducttap__ has quit IRC | 16:00 | |
| *** sjain_ has joined #openstack-keystone | 16:07 | |
| sjain_ | @lbragstad, thanks for taking care of that related projects section :) | 16:09 |
| sjain_ | I saw that other specs patch merged, I'm just waiting for other migration related patches to be merged | 16:10 |
| sjain_ | some of them change the docs a bit, I'll address all the reviews while merging those new ones | 16:11 |
| *** pcaruana has quit IRC | 16:18 | |
| *** links has joined #openstack-keystone | 16:18 | |
| *** lucasxu has quit IRC | 16:19 | |
| *** gyee has joined #openstack-keystone | 16:21 | |
| lbragstad | sjain_: awesome - i'll be focusing on those reviews today | 16:26 |
| lbragstad | sjain_: i'd like to get as much of the migration done as possible, so we can spend next week removing duplicate documentation | 16:27 |
| mordred | morgan, cmurphy, samueldmq: I'm adding the tests to the discovery patch series - and there's an interface that feels awkward using it in the tests | 16:27 |
| mordred | we haven't cut a release with the first 3 patches of the series in it yet - so I'm inclined to change the interface | 16:28 |
| morgan | Great it is on my review list today | 16:28 |
| morgan | Let's change it | 16:28 |
| morgan | But let's land that asap | 16:28 |
| mordred | cool - I'll have at least the first one done real soon | 16:28 |
| sjain_ | @lbragstad: I checked with asettle, they are still working on improving certain docs, should I wait for them or start working on those patches | 16:28 |
| mordred | ++ | 16:28 |
| morgan | I want to be super careful on landed interface changes n | 16:28 |
| lbragstad | sjain_: are there any sections they aren't working on that we can port over today? | 16:28 |
| sjain_ | I can try and improve admin guides | 16:29 |
| sjain_ | and configuration guides too | 16:30 |
| *** rmascena has joined #openstack-keystone | 16:31 | |
| *** raildo has quit IRC | 16:34 | |
| *** spzala has quit IRC | 16:39 | |
| samueldmq | mordred: morgan: great, looking forward to looking at the patches (and tests) | 16:43 |
| *** jdennis has quit IRC | 16:46 | |
| lbragstad | sjain_: sounds good | 16:46 |
| samueldmq | lbragstad: nice! | 16:46 |
| samueldmq | are there things we want to start merging already? | 16:46 |
| lbragstad | sjain_: let me know if you need anything - i'm going to start digging into doug's comment https://review.openstack.org/#/c/474543/3 | 16:46 |
| samueldmq | I saw there are a couple of docs that have been reworked by the docs team before we start migrating | 16:46 |
| samueldmq | I saw some patches from dhellmann | 16:47 |
| lbragstad | samueldmq: that's what we need to figure out - it sounds like there are a few things that the docs team is still working on, so i'm not sure if they are ready to migrate yet | 16:47 |
| *** sjain__ has joined #openstack-keystone | 16:51 | |
| *** sjain_ has quit IRC | 16:51 | |
| samueldmq | lbragstad: knikolla: we doing bug smash today? | 16:54 |
| sjain__ | @lbragstad: I had a look, The admin guides have not changed so I'll make a patch for that, install guides are currently under some change | 16:55 |
| sjain__ | and I'm not sure how to address Doug's comment in https://review.openstack.org/#/c/474543/, so for now I'll just merge changes I made initially by copying | 16:56 |
| cmurphy | wow nova has 800 open bugs http://lists.openstack.org/pipermail/openstack-dev/2017-June/118868.html - we're not doing so bad :) | 16:56 |
| lbragstad | cmurphy: lol | 16:58 |
| lbragstad | sjain__: cool - let's try and get the admin-guides merged over today then | 16:59 |
| lbragstad | samueldmq: I'm probably going to be focusing on docs most of the day with sjain__ | 16:59 |
| lbragstad | samueldmq: we have yet to release our new office hour time, too | 16:59 |
| samueldmq | lbragstad: gotcha | 17:00 |
| lbragstad | samueldmq: per hrybacki's comment earlier | 17:00 |
| samueldmq | I've reviewed mostly of sjain__ 's work yesterday | 17:00 |
| samueldmq | we had good comments from cmurphy there | 17:00 |
| sjain__ | samueldmq: for the patches I uploaded yesterday, should I just abandon the first three? | 17:00 |
| samueldmq | sjain__: I think the second is fine, I +2ed it iirc | 17:01 |
| sjain__ | okay, will the second one merge without the 1st? | 17:01 |
| sjain__ | because you asked to revert the changes in 1st | 17:02 |
| lbragstad | i think the good thing about migrating the admin-guide first is that there is a *lot* of duplicate stuff in our tree that we can remove | 17:09 |
| lbragstad | once the admin-guide is in keystone, we can start consolidating all those duplicate topics | 17:10 |
| lbragstad | which can be done in parallel | 17:10 |
| *** tesseract has quit IRC | 17:11 | |
| *** f13o has quit IRC | 17:13 | |
| lbragstad | sjain__: https://review.openstack.org/#/c/469515/ is in merge conflict - but it would be a good starting point | 17:15 |
| lbragstad | sjain__: would you like to perform the rebase or would you like me to? | 17:15 |
| sjain__ | Thanks lbragstad, but I just removed that merge conflict :) | 17:15 |
| *** links has quit IRC | 17:15 | |
| lbragstad | sjain__: oh - awesome! | 17:16 |
| lbragstad | sjain__: you're two steps ahead of me | 17:16 |
| sjain__ | I was just wondering should I apply your comments here or in next patch? | 17:16 |
| sjain__ | right now I'm trying to make the structure consistent with that spec | 17:17 |
| lbragstad | sjain__: oh - we can address those in a follow on | 17:17 |
| lbragstad | sjain__: i can help with that | 17:17 |
| sjain__ | sure, then I'll quickly push that change | 17:18 |
| *** lucasxu has joined #openstack-keystone | 17:20 | |
| samueldmq | migrating the admin docs? | 17:22 |
| lbragstad | samueldmq: yeah - i think we're going to start there because the docs team doesn't appear to be changing that content at the moment | 17:23 |
| lbragstad | according to the specification - the admin guide should live under doc/source/admin | 17:23 |
| samueldmq | lbragstad: sjain__ hmm yeah I guess that is fine now that https://review.openstack.org/#/c/475435/ is merged | 17:24 |
| lbragstad | https://specs.openstack.org/openstack/docs-specs/specs/pike/os-manuals-migration.html | 17:24 |
| samueldmq | we'll probably need sjain__ to migrate them again, as https://review.openstack.org/#/c/475435/ changed things there | 17:24 |
| sjain__ | oh but are any keystone docs changed | 17:25 |
| sjain__ | I just checked, I couldn't find any | 17:25 |
| *** f13o has joined #openstack-keystone | 17:27 | |
| samueldmq | sjain__: there was a bunch of doc/admin-guide/source/identity-* that got removed in that patch | 17:28 |
| samueldmq | wouldnt that affect us? | 17:28 |
| lbragstad | samueldmq: it would - but i think we want to pull that content over to our project | 17:28 |
| sjain__ | those are all those docs that I migrated | 17:28 |
| samueldmq | ah yes | 17:28 |
| samueldmq | I thought they were just cleaning up a couple of things they didnt want us to migrate | 17:29 |
| lbragstad | the docs team is fulfilling their part of this spec https://specs.openstack.org/openstack/docs-specs/specs/pike/admin-guide-repos.html | 17:29 |
| sjain__ | plus is this merged, https://review.openstack.org/#/c/475435/ | 17:29 |
| sjain__ | ? | 17:29 |
| samueldmq | but that's what comes after the migration actually | 17:29 |
| lbragstad | it looks like everything sjain__ migrated was removed - so i think we're good | 17:30 |
| sjain__ | I just did git pull in that repo, and didn't find any change in admin-guides at least | 17:30 |
| samueldmq | yeah I think we're fine | 17:30 |
| lbragstad | not sure if that was suppose to be removed before all the projects had a change to migrate though | 17:30 |
| samueldmq | what are we waiting on then? | 17:30 |
| sjain__ | @lbragstad: is that patch merged already? | 17:30 |
| samueldmq | let's get that in :D | 17:30 |
| samueldmq | sjain__: no it's not, I guess just after all projects migrate | 17:30 |
| lbragstad | sjain__: not yet - it's going through the gate as we speak | 17:30 |
| samueldmq | lbragstad: ++ but the top parent has workflow-1, I guess they're waiting on the migrations to complete maybe | 17:31 |
| samueldmq | it wouldnt make sense to remove without migrating in first place | 17:31 |
| lbragstad | samueldmq: oh - sur e | 17:31 |
| openstackgerrit | Samriddhi proposed openstack/keystone master: Added keystone admin guides to documentation https://review.openstack.org/469515 | 17:31 |
| lbragstad | yep - ok | 17:31 |
| lbragstad | we're good then | 17:31 |
| lbragstad | i didn't see the dependent patches | 17:31 |
| sjain__ | this we will need to check for all the repos, that all the changes are done before I migrate them | 17:32 |
| sjain__ | plus, ^^ admin guides done! | 17:33 |
| *** spzala has joined #openstack-keystone | 17:33 | |
| lbragstad | sjain__: yeah - the install and configuration guides are left | 17:33 |
| sjain__ | should I do them now, or lets wait for the doc team, we can improve these admin guides now | 17:34 |
| samueldmq | sjain__: I think lbragstad is saying they will be kept there ? | 17:35 |
| lbragstad | no - we will have to migrate those, too | 17:35 |
| samueldmq | hm I thought I had seen some of the repos would be kept there | 17:35 |
| lbragstad | these are all the open patches against the openstack-manuals project https://review.openstack.org/#/q/project:openstack/openstack-manuals+status:open | 17:35 |
| lbragstad | https://specs.openstack.org/openstack/docs-specs/specs/pike/os-manuals-migration.html#what-is-happening-to-each-guide | 17:35 |
| lbragstad | the HA guide, security guide, operator guide, etc... are going to stay in openstack-manuals | 17:36 |
| lbragstad | the installation guide, project installation guides, administrator guides, and configuration references are going to move into project rees | 17:37 |
| lbragstad | trees* | 17:37 |
| samueldmq | lbragstad: not sure about the Configuration Reference | 17:37 |
| samueldmq | I see in the spec they talking about some of that going to oslo.config, and other things | 17:37 |
| samueldmq | ah ok: "The remainder will be removed, and replaced with new pages in the in-tree documentation built using oslo_config.sphinxext" | 17:38 |
| lbragstad | samueldmq: dhellmann had a comment about that here - https://review.openstack.org/#/c/474543/3 | 17:38 |
| samueldmq | but I guess we need to wait on first step "A few pages will move from openstack-manuals to the user-facing documentation in oslo.config" | 17:38 |
| lbragstad | so - our job would be to leverage the work done in oslo.config to generate the documentation for the configuration references | 17:38 |
| sjain__ | can some please explain me this oslo_config part | 17:39 |
| lbragstad | that way we don't have to maintain the configuration reference, instead it will be generated automatically | 17:39 |
| sjain__ | :) | 17:39 |
| samueldmq | lbragstad: hmm that;s interesting | 17:39 |
| lbragstad | sjain__: oslo.config is a library keystone consumes to handle configuration needs for our project | 17:39 |
| lbragstad | sjain__: let me grab an example | 17:39 |
| samueldmq | how will that be generated automatically? | 17:39 |
| samueldmq | where did they get the install instructions from? | 17:39 |
| lbragstad | samueldmq: that's the part that needs attention ;) | 17:40 |
| samueldmq | lbragstad: so basically they want to create an standard to reprensent how to configure services? | 17:40 |
| lbragstad | sjain__: in keystone, we define the configuration options we want | 17:40 |
| lbragstad | sjain__: like this https://github.com/openstack/keystone/blob/d6160630b03d0bbfc179f6b507db1e92d57562cc/keystone/conf/default.py#L40-L50 | 17:40 |
| samueldmq | and then generate docs automatically from that? | 17:40 |
| lbragstad | samueldmq: yep | 17:40 |
| samueldmq | interesting | 17:41 |
| lbragstad | sjain__: that uses the oslo.config library https://github.com/openstack/keystone/blob/d6160630b03d0bbfc179f6b507db1e92d57562cc/keystone/conf/default.py#L13 | 17:41 |
| samueldmq | yeah, we will need to parallelize | 17:41 |
| samueldmq | there is a LOT of work going on in docs | 17:41 |
| sjain__ | ohkay I understood a bit | 17:42 |
| lbragstad | sjain__: that library let's us define help text, descriptions, and defaults for our configuration options. we can then reference it in other parts of our code where we have business logic that needs to use configuration | 17:42 |
| samueldmq | lbragstad: https://review.openstack.org/#/c/469515 should be good to merge | 17:42 |
| lbragstad | sjain__: but - another cool oslo.config let's us do is generate sample configuration files based on what we define in code | 17:42 |
| lbragstad | another cool thing* | 17:43 |
| sjain__ | oh so it will automatically generate those files too | 17:43 |
| lbragstad | sjain__: so - for example, if you take the keystone project and run `tox -e genconfig` | 17:43 |
| lbragstad | you can an updated version based on what is maintained and tested in code | 17:43 |
| lbragstad | i think what the documentation team is suggesting | 17:44 |
| lbragstad | is that we enhance the functionality of oslo.config's configuration generation bits to make it handle the generation of the configuration reference as well | 17:44 |
| lbragstad | (before oslo.config, each project had to manually update their sample configuration files - this is still the case with the configuration reference guide) | 17:45 |
| lbragstad | which means a lot of copy/paste | 17:45 |
| sjain__ | oh, so for these config docs we need to connect it to oslo.config rather than simply copying the docs | 17:45 |
| lbragstad | and a lot of room for error | 17:45 |
| lbragstad | sjain__: yep - exactly | 17:45 |
| lbragstad | the trick is that we don't know if oslo.config will render things nicely or exactly the way we expect the configuration reference to look | 17:45 |
| lbragstad | so - there might be work to improve *how* things render in oslo.config | 17:46 |
| samueldmq | lbragstad: https://review.openstack.org/#/c/469515 is a +2 from me | 17:46 |
| samueldmq | compared with docs in opentack-manuals, it's a really clean copy-paste from there | 17:46 |
| lbragstad | once that is done, each project should create a configuration reference section in there doc/source tree and just tell oslo.config where the configuration module is and to generatea configuration reference | 17:46 |
| samueldmq | should be fine to get in | 17:46 |
| lbragstad | samueldmq: cool - reviewing | 17:48 |
| sjain__ | see this one https://review.openstack.org/#/c/475395/ | 17:49 |
| sjain__ | for install guides | 17:49 |
| sjain__ | removing project specific docs | 17:50 |
| sjain__ | that means may be this is complete | 17:50 |
| lbragstad | sjain__: yes - i would say so | 17:50 |
| sjain__ | I was most concerned for https://review.openstack.org/#/c/473579/, this is merged | 17:50 |
| lbragstad | sjain__: i'm looking through all the open openstack-manual patches, but i'm not seeing anything that is changing the content that we have to be worries about | 17:50 |
| lbragstad | sjain__: yeah - so long as we have copy that includes that patch, I think we're good to move that stuff over whenever | 17:51 |
| sjain__ | these install docs have changed, from what I added in previous patch | 17:51 |
| sjain__ | so I think I'll start with this one | 17:52 |
| sjain__ | it will require some rearranging | 17:52 |
| samueldmq | it wouldn't hurt to double check with asettle and dhellmann what's ready for migration already | 17:52 |
| samueldmq | aside from the admin guides, just to make sure we are all in the same page | 17:53 |
| samueldmq | sjain__: but yeah, from the spec it's clear the Installation Guide wil lcome in-tree | 17:54 |
| samueldmq | we would just need to wait for https://review.openstack.org/#/c/473579/ | 17:55 |
| samueldmq | but it's been merged | 17:55 |
| samueldmq | so you should be able to update your migration to keystone | 17:55 |
| lbragstad | samueldmq: yeah - so we're good to move that to keystone whenever | 17:55 |
| samueldmq | lbragstad: ++ | 17:55 |
| sjain__ | yeah, so I'll migrate those then | 17:55 |
| lbragstad | i'm +2 on the admin guide | 17:55 |
| lbragstad | waiting for jenkins to verify it and I'll kick it through | 17:56 |
| sjain__ | thanks :) | 17:56 |
| lbragstad | let's see if we can do the same with the install guide today | 17:56 |
| lbragstad | then the only big piece left is working our the configuration reference bits with oslo.config | 17:56 |
| lbragstad | out* | 17:56 |
| samueldmq | ++ that'd be awesome | 17:59 |
| sjain__ | one query: how are these install-guides different from the ones we right now have in getting-started/general info | 18:00 |
| lbragstad | sjain__: the install guides from openstack-manuals were the official installation guides | 18:01 |
| lbragstad | sjain__: more than likely the ones that operators reference when doing an installation | 18:02 |
| lbragstad | sjain__: the ones we have in tree are kind of a mish-mash of developer and operator installation techniques | 18:02 |
| sjain__ | oh alright, but was adding those in general section | 18:03 |
| sjain__ | should I add them to operator? | 18:03 |
| lbragstad | sjain__: the installation guide from openstack-manuals? | 18:03 |
| sjain__ | yes | 18:03 |
| lbragstad | sjain__: i'd create a new place for it | 18:04 |
| lbragstad | sjain__: put them under doc/source/install | 18:04 |
| sjain__ | no in the layout | 18:04 |
| lbragstad | sjain__: i'd make it its own top-level section | 18:05 |
| lbragstad | just like `API Reference` | 18:05 |
| lbragstad | I'd make one called `Installation Guide` and have it render everything under doc/source/install | 18:05 |
| sjain__ | ohkay, makes sense | 18:06 |
| sjain__ | thanks! | 18:06 |
| lbragstad | sjain__: yep | 18:06 |
| lbragstad | sjain__: that way we keep the two sets of documentation separate for the time being | 18:06 |
| *** aojea has joined #openstack-keystone | 18:06 | |
| lbragstad | then we can slowly go through all the installation docs *not* in doc/source/install and either move it to the appropriate section of doc/source/install or delete it | 18:06 |
| sjain__ | cool! | 18:07 |
| lbragstad | that's going to be the fun part because we get to remove all the duplicate code | 18:08 |
| lbragstad | s/code/docs/ | 18:08 |
| *** aojea has quit IRC | 18:11 | |
| *** spzala has quit IRC | 18:16 | |
| *** spzala has joined #openstack-keystone | 18:17 | |
| *** spzala has quit IRC | 18:18 | |
| *** spzala has joined #openstack-keystone | 18:18 | |
| *** spzala has quit IRC | 18:23 | |
| lbragstad | sjain__: one last comment on https://review.openstack.org/#/c/469515/3 to be consistent with the installation guide | 18:31 |
| *** spzala has joined #openstack-keystone | 18:40 | |
| sjain__ | @lbragstad: should I place it very top or before/after operator docs | 18:43 |
| sjain__ | samueldmq: ^^ | 18:43 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Add history behind why keystone has two ports https://review.openstack.org/476703 | 18:45 |
| *** bknudson has quit IRC | 18:58 | |
| openstackgerrit | Samriddhi proposed openstack/keystone master: Added keystone admin guides to documentation https://review.openstack.org/469515 | 19:13 |
| *** clayton has quit IRC | 19:19 | |
| *** MasterOfBugs has joined #openstack-keystone | 19:19 | |
| *** clayton has joined #openstack-keystone | 19:21 | |
| *** ducttape_ has quit IRC | 19:21 | |
| *** ducttape_ has joined #openstack-keystone | 19:22 | |
| lbragstad | sjain__: what you have there is perfect, | 19:26 |
| lbragstad | thanks | 19:26 |
| lbragstad | https://review.openstack.org/#/c/469515/4 samueldmq | 19:26 |
| sjain__ | cool | 19:26 |
| sjain__ | I'm almost done with install guides | 19:26 |
| sjain__ | have a look at the last section of https://raw.githubusercontent.com/openstack/openstack-manuals/master/doc/install-guide/source/index-ubuntu.rst | 19:27 |
| *** dave-mccowan has quit IRC | 19:29 | |
| lbragstad | sjain__: yep | 19:29 |
| lbragstad | sjain__: wondering what to do about the other projects referenced there? | 19:29 |
| sjain__ | I removed those | 19:29 |
| sjain__ | I just copied keystone docs | 19:29 |
| lbragstad | ++ i think that's fine | 19:30 |
| sjain__ | nd rearranged a little bit | 19:30 |
| sjain__ | I'm getting some issues with rendering | 19:30 |
| lbragstad | sjain__: hmm | 19:30 |
| sjain__ | which I'm not able to figure out | 19:30 |
| sjain__ | I'll push the changes | 19:30 |
| lbragstad | sjain__: cool - do that and i'll see if i can recreate | 19:31 |
| sjain__ | can you have a look at those pls | 19:31 |
| sjain__ | thanks :) | 19:31 |
| openstackgerrit | Samriddhi proposed openstack/keystone master: WIP: Added keystone installation guides https://review.openstack.org/474545 | 19:32 |
| sjain__ | the issue is with 'Install and configure' page, there are multiple links appearing | 19:32 |
| *** jmlowe has quit IRC | 19:39 | |
| lbragstad | sjain__: this is what i'm getting locally when i run `tox -e docs` | 19:41 |
| lbragstad | http://paste.openstack.org/show/613544/ | 19:41 |
| lbragstad | full trace - http://paste.openstack.org/show/613546/ | 19:42 |
| sjain__ | strange, that file is uploaded here https://review.openstack.org/#/c/474545/ | 19:43 |
| lbragstad | sjain__: ah - nevermind | 19:44 |
| lbragstad | sjain__: i have something wrong in my local env | 19:44 |
| lbragstad | rerunning now | 19:44 |
| lbragstad | sjain__: ok - that time it worked | 19:46 |
| lbragstad | sjain__: i see the Installation Guides section just under the Related Projects bit | 19:46 |
| lbragstad | which seems fine | 19:46 |
| sjain__ | yeah navigate to any one | 19:47 |
| sjain__ | and open install and configure | 19:47 |
| lbragstad | ok - i'm in index-debian.html | 19:47 |
| sjain__ | open contents in that | 19:49 |
| lbragstad | sjain__: well - there are four sections rendering, right? | 19:49 |
| lbragstad | sjain__: each section is for a different platform | 19:49 |
| sjain__ | offside.. there was some text common in abstract which I brought on first rendering page | 19:49 |
| sjain__ | yes right | 19:50 |
| sjain__ | but in each section again they are rendering all the docs and not specific to that section | 19:50 |
| lbragstad | sjain__: i think that was something specific to the docs project that made less duplication for the maintainers of openstack-manuals? | 19:52 |
| lbragstad | asettle: would be the person to ask there though | 19:52 |
| sjain__ | okay, looks like the issue is with :blob: directive | 19:53 |
| sjain__ | I'll ask her tomorrow | 19:53 |
| lbragstad | yeah - i'd like to have her opinion on that change | 19:54 |
| lbragstad | it's obvious that all the installation stuff needs to go in doc/source/install | 19:54 |
| lbragstad | but i wonder if we label each section according to the platform | 19:54 |
| lbragstad | e.g. Ubuntu install and configure | 19:55 |
| lbragstad | or how we go about that | 19:55 |
| sjain__ | yeah, lets see what she says | 19:56 |
| sjain__ | we will make the changes then | 19:56 |
| lbragstad | does someone else want to give this another look? https://review.openstack.org/#/c/469515/ | 19:56 |
| * lbragstad steps away for 15 minutes | 20:00 | |
| *** f13o has quit IRC | 20:05 | |
| *** sjain__ has quit IRC | 20:05 | |
| morgan | lbragstad: i'm happy to +2/+A it, but that is a brutally large patchset | 20:06 |
| morgan | lbragstad: it's just a straight copy from the previous location(s), right? | 20:06 |
| cmurphy | yes, and it's identical to the openstack-manuals except for identity-management.rst changes the title | 20:08 |
| cmurphy | lbragstad: is that one good to go or are we waiting on something from asettle? | 20:09 |
| morgan | cmurphy: lbragstad +2'd it | 20:09 |
| *** aojea has joined #openstack-keystone | 20:16 | |
| *** f13o has joined #openstack-keystone | 20:17 | |
| *** aojea has quit IRC | 20:20 | |
| lbragstad | cmurphy: nope the admin guide is ready to go | 20:31 |
| lbragstad | cmurphy: we're going to wait on some clarification from asettle on the installation and configuration guides | 20:31 |
| cmurphy | okay cool | 20:31 |
| *** ducttap__ has joined #openstack-keystone | 20:32 | |
| lbragstad | which is fine because the admin guide has a ton of good information that we duplicated in our dev docs, so we can probably start working on removing that duplication once the admin-guide merges | 20:32 |
| cmurphy | samueldmq is on top of it | 20:33 |
| samueldmq | approved :) | 20:33 |
| *** ducttape_ has quit IRC | 20:36 | |
| *** f13o has quit IRC | 20:47 | |
| *** lucasxu has quit IRC | 20:53 | |
| *** ducttap__ has quit IRC | 20:53 | |
| *** nicolasbock has quit IRC | 20:58 | |
| *** catinthe_ has joined #openstack-keystone | 21:10 | |
| *** catintheroof has quit IRC | 21:12 | |
| openstackgerrit | Merged openstack/keystone master: Add HEAD APIs to federated API https://review.openstack.org/472858 | 21:13 |
| openstackgerrit | Samuel Pilla proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 21:16 |
| *** spzala has quit IRC | 21:17 | |
| *** bknudson has joined #openstack-keystone | 21:18 | |
| *** pramodrj07 has joined #openstack-keystone | 21:18 | |
| *** ducttape_ has joined #openstack-keystone | 21:19 | |
| *** pramodrj07 has quit IRC | 21:19 | |
| *** pramodrj07 has joined #openstack-keystone | 21:19 | |
| *** ducttap__ has joined #openstack-keystone | 21:20 | |
| *** PramodJ has joined #openstack-keystone | 21:21 | |
| *** MasterOfBugs has quit IRC | 21:22 | |
| *** ducttape_ has quit IRC | 21:23 | |
| *** pramodrj07 has quit IRC | 21:25 | |
| openstackgerrit | Merged openstack/keystone master: Add annotation about token authenticate https://review.openstack.org/472511 | 21:31 |
| * knikolla is wondering how old this note is https://git.openstack.org/cgit/openstack/keystone/tree/doc/source/devref/development_best_practices.rst#n328 | 21:48 | |
| *** dave-mccowan has joined #openstack-keystone | 21:49 | |
| *** catinthe_ has quit IRC | 21:52 | |
| *** PramodJ has quit IRC | 21:57 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Move version discovery logic to keystoneauth1.discover https://review.openstack.org/469086 | 22:03 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add url manipulation and microversion collection https://review.openstack.org/469087 | 22:03 |
| mordred | morgan, cmurph, samueldmq: first patch shouild be good - second patch still needs work but I figured I'd push it up so you could see where it's going | 22:04 |
| mordred | morgan: there are literally zero things about hte tests in the second one that are going to make you happier to be alive | 22:04 |
| cmurphy | ha | 22:04 |
| mordred | because, you know - to test this, it means constructing the evil catalog entries | 22:05 |
| mordred | BUT - it's a great exercise | 22:05 |
| openstackgerrit | Merged openstack/keystone master: Added keystone admin guides to documentation https://review.openstack.org/469515 | 22:06 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add url manipulation and microversion collection https://review.openstack.org/469087 | 22:19 |
| mordred | cmurphy, morgan: actually, apparently just pushing it up allowed me to see the problem, so that's neat | 22:19 |
| cmurphy | \o/ | 22:20 |
| mordred | although WOW I just found a fun new bog :) | 22:22 |
| *** dave-mccowan has quit IRC | 22:24 | |
| *** chlong has quit IRC | 22:45 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add url manipulation and microversion collection https://review.openstack.org/469087 | 22:46 |
| mordred | cmurphy: I found that 3.20 was being parsed into (3, 2) - which isn't quite the expectation | 22:46 |
| cmurphy | hahahaha | 22:48 |
| cmurphy | i can imagine being really confused trying to use nova 2.20 and getting nova 2.2 | 22:48 |
| morgan | cmurphy: oh man | 22:53 |
| morgan | that would be bad | 22:53 |
| morgan | mordred: LOL | 22:53 |
| morgan | mordred: yeah..... *whoopse* | 22:53 |
| mordred | :) | 22:53 |
| morgan | need to do those as stings | 22:53 |
| morgan | strings | 22:53 |
| mordred | it's otherwise VERY comprehensively tested | 22:53 |
| morgan | not floats | 22:53 |
| morgan | ^_^ | 22:53 |
| morgan | reviewing | 22:53 |
| mordred | morgan: be prepared for eye-gouging | 22:54 |
| morgan | hmm | 22:54 |
| morgan | mordred: you know... if we handle all versions a tuples | 22:54 |
| morgan | (X, Y, ZZ) | 22:54 |
| morgan | all the math works | 22:54 |
| morgan | #sidecomment | 22:54 |
| morgan | because version = str(float(int(version))) is going to run into similar issues | 22:55 |
| morgan | god, how did that ever work | 22:55 |
| morgan | :P | 22:55 |
| mordred | :) | 22:55 |
| *** eandersson has quit IRC | 22:56 | |
| *** eandersson has joined #openstack-keystone | 22:56 | |
| morgan | mordred: uh | 22:56 |
| mordred | morgan: yah | 22:56 |
| morgan | am i mis-reading this? we still have the 3.20->3.2 issue | 22:56 |
| mordred | we don't - added test to prove | 22:56 |
| mordred | although looking at it I'm confused as to why it works | 22:57 |
| morgan | yeah | 22:57 |
| morgan | something is wonky atm | 22:57 |
| morgan | re-reading the code | 22:57 |
| mordred | oh - it works because int('3.20') throws | 22:57 |
| mordred | so that line ONLY works for strings that cleanly are single ints | 22:58 |
| mordred | and strings that are not pure ints fall through to the split line | 22:58 |
| mordred | that at least warrants a commant | 22:58 |
| morgan | oh gross | 22:58 |
| morgan | yeah | 22:59 |
| morgan | it has to be an int, or it has some breaking logic | 22:59 |
| morgan | you know... i almost think we should move the if-checks into the try-except | 22:59 |
| morgan | ohw ait no. | 22:59 |
| morgan | euw | 22:59 |
| morgan | this is ... trying really hard to normalize every possible form | 23:00 |
| mordred | yah. and it's got a bunchof backwards compats terror atached | 23:00 |
| morgan | so i'd make the ifs Elifs | 23:00 |
| morgan | tbh | 23:00 |
| morgan | it would make it a lot cleaner | 23:00 |
| morgan | or at least easier to read | 23:00 |
| mordred | yes. I agree - we do not need fallthrough there | 23:01 |
| morgan | if string: do X, elif float: do Y, elif int: do x | 23:01 |
| morgan | it's fine as is | 23:01 |
| morgan | i mean, not worth re-spinning on that alone but | 23:01 |
| morgan | gross | 23:01 |
| mordred | well - I think the one thing does need a comment | 23:03 |
| mordred | and you haven't read much more of that patch yet :) | 23:03 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add url manipulation and microversion collection https://review.openstack.org/469087 | 23:04 |
| mordred | morgan: ^^ how's that look | 23:04 |
| mordred | elifs and more comments | 23:04 |
| mordred | 188757 | 23:04 |
| mordred | and a pin, apparenlty | 23:04 |
| mordred | :) | 23:04 |
| *** ducttap__ has quit IRC | 23:04 | |
| morgan | hehe | 23:06 |
| morgan | well then | 23:06 |
| morgan | i was commenting! :P | 23:06 |
| morgan | looking it over again | 23:06 |
| morgan | i think it'll be good | 23:06 |
| mordred | oh - I'll go read both versions | 23:06 |
| morgan | nah, it's all good | 23:07 |
| morgan | my comments were nits at best | 23:07 |
| *** bknudson has quit IRC | 23:08 | |
| *** bknudson has joined #openstack-keystone | 23:08 | |
| morgan | see in-line nits | 23:09 |
| morgan | +1 until CI response | 23:09 |
| morgan | then will upgrade to +2 | 23:09 |
| *** bknudson has quit IRC | 23:13 | |
| *** spzala has joined #openstack-keystone | 23:18 | |
| *** spzala has quit IRC | 23:22 | |
| cmurphy | gonna look at this again tomorrow morning, it's getting too late for my brain | 23:24 |
| morgan | heh | 23:33 |
| morgan | cmurphy: simple solution - 1) stare at it until brain bleeds, 2) ???, 3) merge code, 4) profit | 23:33 |
| cmurphy | haha | 23:35 |
| *** edmondsw has quit IRC | 23:47 | |
| *** edmondsw has joined #openstack-keystone | 23:48 | |
| *** edmondsw has quit IRC | 23:52 | |
| *** gyee has quit IRC | 23:52 | |
| mordred | morgan: that's my process most times | 23:55 |
| morgan | mordred: you also often include beer-mouth and poolside hacking | 23:56 |
| mordred | morgan: I agree, btw, with one of your nits about the comment not being useful - it's definitely too snark. the thing I think it _should_ point out is that attaching a v2 version discovery document to a service called "volumev3" isn't a test bug - so maybe a followup with less snark :) | 23:57 |
| mordred | morgan: and YES to beer-mouth and poolside hacking | 23:57 |
| morgan | mordred: or smoking large cuts of meat | 23:57 |
| mordred | mmm | 23:57 |
| mordred | meat | 23:57 |
| morgan | yep, it's a nit | 23:57 |
| morgan | not worth another patch | 23:57 |
| morgan | but man... snaaaark | 23:57 |
| * morgan beer mouths | 23:57 | |
| morgan | mordred: it's a legit test case | 23:58 |
| morgan | mordred: next place i live (looking at options) will include a place to BBQ and a place to smoke meats | 23:58 |
| morgan | and possibly a pool | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!