| *** spzala has joined #openstack-keystone | 00:31 | |
| *** bknudson has joined #openstack-keystone | 01:59 | |
| *** bknudson has quit IRC | 01:59 | |
| *** edmondsw has joined #openstack-keystone | 02:10 | |
| *** edmondsw has quit IRC | 02:14 | |
| *** nicolasbock has joined #openstack-keystone | 02:46 | |
| *** goofie_ has quit IRC | 02:54 | |
| *** goofie_ has joined #openstack-keystone | 03:10 | |
| *** nicolasbock has quit IRC | 03:14 | |
| *** edmondsw has joined #openstack-keystone | 03:58 | |
| *** edmondsw has quit IRC | 04:02 | |
| *** aojea has joined #openstack-keystone | 05:24 | |
| *** aojea has quit IRC | 05:29 | |
| *** spzala has quit IRC | 05:34 | |
| *** edmondsw has joined #openstack-keystone | 05:46 | |
| *** edmondsw has quit IRC | 05:50 | |
| *** links has joined #openstack-keystone | 05:55 | |
| *** mvk has quit IRC | 06:14 | |
| *** links has quit IRC | 06:20 | |
| *** goofie_ has quit IRC | 06:34 | |
| *** brad[] has quit IRC | 06:35 | |
| *** brad[] has joined #openstack-keystone | 06:36 | |
| *** spzala has joined #openstack-keystone | 07:35 | |
| *** spzala has quit IRC | 07:40 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-keystone | 08:00 | |
| *** pepenemov has joined #openstack-keystone | 08:00 | |
| *** spzala has joined #openstack-keystone | 08:05 | |
| *** spzala has quit IRC | 08:13 | |
| *** spzala has joined #openstack-keystone | 09:10 | |
| *** spzala has quit IRC | 09:14 | |
| *** pepenemov has quit IRC | 09:20 | |
| *** edmondsw has joined #openstack-keystone | 09:22 | |
| *** aojea has joined #openstack-keystone | 09:25 | |
| *** edmondsw has quit IRC | 09:26 | |
| *** aojea has quit IRC | 09:30 | |
| *** goofie_ has joined #openstack-keystone | 10:19 | |
| *** edmondsw has joined #openstack-keystone | 11:10 | |
| *** spzala has joined #openstack-keystone | 11:10 | |
| *** edmondsw has quit IRC | 11:14 | |
| *** spzala has quit IRC | 11:16 | |
| *** hoonetorg has quit IRC | 11:28 | |
| *** hoonetorg has joined #openstack-keystone | 11:41 | |
| *** dave-mccowan has joined #openstack-keystone | 11:48 | |
| *** goofie_ has quit IRC | 11:56 | |
| *** aojea has joined #openstack-keystone | 12:09 | |
| *** spzala has joined #openstack-keystone | 12:12 | |
| *** shuyingya has joined #openstack-keystone | 12:13 | |
| *** spzala has quit IRC | 12:16 | |
| *** aojea has quit IRC | 12:19 | |
| *** goofie_ has joined #openstack-keystone | 12:56 | |
| *** edmondsw has joined #openstack-keystone | 12:58 | |
| *** edmondsw has quit IRC | 13:02 | |
| *** goofie_ has quit IRC | 13:14 | |
| *** goofie_ has joined #openstack-keystone | 13:20 | |
| *** goofie_ has quit IRC | 13:33 | |
| *** aojea has joined #openstack-keystone | 13:37 | |
| *** dave-mccowan has quit IRC | 13:48 | |
| *** spzala has joined #openstack-keystone | 13:55 | |
| *** spzala_ has joined #openstack-keystone | 13:55 | |
| *** spzala has quit IRC | 13:55 | |
| *** spzala_ has quit IRC | 14:03 | |
| *** shuyingya has quit IRC | 14:18 | |
| *** aojea has quit IRC | 14:23 | |
| *** goofie_ has joined #openstack-keystone | 14:39 | |
| *** spzala has joined #openstack-keystone | 14:46 | |
| *** edmondsw has joined #openstack-keystone | 14:46 | |
| *** iurygregory has quit IRC | 14:50 | |
| *** edmondsw has quit IRC | 14:51 | |
| *** shuyingya has joined #openstack-keystone | 14:58 | |
| *** shuyingya has quit IRC | 15:02 | |
| mordred | cmurphy: so, remember yesterday when I said something about not wanting to rebase the stack to remove that parameter? | 15:02 |
|---|---|---|
| mordred | cmurphy: I was just adding another test and have discovered that I believe there is a (reasonably deep and obscure) logic flaw that probaby nobody will ever hit but that is wrong nonetheless - and which I think is going to need me to do that rebase anyway | 15:03 |
| mordred | yay me | 15:03 |
| cmurphy | mordred: oh yay | 15:07 |
| *** aojea has joined #openstack-keystone | 15:09 | |
| *** aojea has quit IRC | 15:13 | |
| mordred | cmurphy: yah. tell me about it. the 'issue' I found is that if you get an EndpointData and ask it for two different versions, it'll run discovery again even if it has the data it needs from the first run becuase it caches discovery by the requested endpoint and only keeps results in the EndpointData | 15:14 |
| mordred | cmurphy: so if the first versioned endpoint requested needed the unversioned discovery document to be fetched (meaning the whole list was available) - it doesn't know that it can satisfy a subsequent request for a different version using data it already has | 15:14 |
| mordred | now - to be fair, the chances of ANYONE ever actually wanting to do that and being pissed about the additional fetch are like 0.000001% | 15:15 |
| mordred | but we did the work and saved the data and have an api that lets that request be made pretty easily - so there is no reason to do it wrong (at least now that we konw it's wrong) | 15:16 |
| cmurphy | yeah if we have caches probably best to use the caches :) | 15:17 |
| mordred | yup :) | 15:30 |
| mordred | cmurphy: also - tests are awesome | 15:30 |
| *** aojea has joined #openstack-keystone | 15:31 | |
| cmurphy | indeed | 15:31 |
| *** aojea has quit IRC | 15:36 | |
| *** dave-mccowan has joined #openstack-keystone | 15:36 | |
| mordred | cmurphy: OH - I just realized why this logic shows up now and not earlier in the stack - it's actually the 'optimize to not fetch urls when you don't need to' patch that triggers the sadness - so I may not need to rebase the entire thing | 15:39 |
| *** spzala has quit IRC | 16:17 | |
| *** aojea has joined #openstack-keystone | 16:18 | |
| *** spzala has joined #openstack-keystone | 16:24 | |
| *** afazekas has quit IRC | 16:25 | |
| *** mordred has quit IRC | 16:29 | |
| *** spzala has quit IRC | 16:29 | |
| *** edmondsw has joined #openstack-keystone | 16:34 | |
| *** aojea_ has joined #openstack-keystone | 16:37 | |
| *** edmondsw has quit IRC | 16:39 | |
| *** aojea has quit IRC | 16:40 | |
| *** aojea_ has quit IRC | 16:42 | |
| *** aojea has joined #openstack-keystone | 16:42 | |
| *** aojea has quit IRC | 16:53 | |
| *** aojea_ has joined #openstack-keystone | 16:53 | |
| *** afazekas has joined #openstack-keystone | 17:01 | |
| *** goofie_ has quit IRC | 17:07 | |
| *** mordred has joined #openstack-keystone | 17:07 | |
| *** spzala has joined #openstack-keystone | 17:26 | |
| *** spzala has quit IRC | 17:30 | |
| *** sbezverk has quit IRC | 18:00 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystoneauth master: Rework discovery cache https://review.openstack.org/477149 | 18:12 |
| *** spzala has joined #openstack-keystone | 18:18 | |
| samueldmq | mordred: ^ added more tests and a comment | 18:18 |
| samueldmq | mordred: the behavior of get_endpoint is changed in that patch (even if the get_endpoint_data behavior is kept) | 18:19 |
| samueldmq | see my comment inline | 18:19 |
| *** edmondsw has joined #openstack-keystone | 18:22 | |
| *** edmondsw has quit IRC | 18:26 | |
| *** spzala has quit IRC | 18:31 | |
| *** dave-mccowan has quit IRC | 18:44 | |
| *** aojea_ has quit IRC | 19:07 | |
| *** aojea has joined #openstack-keystone | 19:14 | |
| *** aojea has quit IRC | 19:18 | |
| *** ducttape_ has joined #openstack-keystone | 19:22 | |
| *** ducttap__ has quit IRC | 19:22 | |
| *** tobberydberg has joined #openstack-keystone | 20:11 | |
| *** f13o has joined #openstack-keystone | 20:18 | |
| *** sjain_ has joined #openstack-keystone | 20:24 | |
| mordred | samueldmq: cool - I've also got another set of updates coming from today | 20:29 |
| *** spzala has joined #openstack-keystone | 20:31 | |
| mordred | samueldmq: ah - yes - good point - I think we should definitely keep self._discovery_cache in that call (and remove the cache=None argument) - we can add the cache argument to the keystoneauth1.discovery.get_discovery call in the next patch when we move it - and have the method in that path always pass in self._discovery_cache to the cache argument | 20:31 |
| mordred | samueldmq: good catch on teh behavior change@ | 20:32 |
| mordred | ! | 20:32 |
| *** spzala has quit IRC | 20:35 | |
| *** shuyingya has joined #openstack-keystone | 20:36 | |
| *** aojea has joined #openstack-keystone | 20:36 | |
| *** sjain_ has quit IRC | 20:39 | |
| *** shuyingya has quit IRC | 20:40 | |
| *** tobberydberg has quit IRC | 20:59 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Update mocks and make sure double-discovery works https://review.openstack.org/477242 | 20:59 |
| *** tobberydberg has joined #openstack-keystone | 20:59 | |
| *** tobberydberg has quit IRC | 21:04 | |
| *** jdennis has joined #openstack-keystone | 21:06 | |
| *** goofie has joined #openstack-keystone | 21:08 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Rework discovery cache https://review.openstack.org/477149 | 21:38 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Move version discovery logic to keystoneauth1.discover https://review.openstack.org/469086 | 21:38 |
| mordred | samueldmq: that's got your updates in it ^^ but also removed the addition of the cache parameter to the auth plugin call, since it's not really a necessary api addition any more | 21:39 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Expose getting EndpointData on adapter and session https://review.openstack.org/469091 | 21:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add support for version ranges https://review.openstack.org/469090 | 21:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Support a list of interface values https://review.openstack.org/477169 | 21:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Support explicitly requesting the 'latest' version https://review.openstack.org/469089 | 21:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add flags to turn discovery on and off https://review.openstack.org/469088 | 21:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Plumb endpoint_override through get_endpoint_data https://review.openstack.org/469092 | 21:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Update mocks and make sure double-discovery works https://review.openstack.org/477242 | 21:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Optimize matching version no microversion needed https://review.openstack.org/470274 | 21:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add url manipulation and microversion collection https://review.openstack.org/469087 | 21:47 |
| *** edmondsw has joined #openstack-keystone | 21:58 | |
| *** edmondsw has quit IRC | 22:03 | |
| *** aojea has quit IRC | 22:27 | |
| *** f13o has quit IRC | 22:35 | |
| *** edmondsw has joined #openstack-keystone | 22:37 | |
| *** edmondsw has quit IRC | 22:37 | |
| *** edmondsw has joined #openstack-keystone | 22:38 | |
| *** edmondsw has quit IRC | 22:42 | |
| *** shuyingya has joined #openstack-keystone | 22:55 | |
| *** shuyingya has quit IRC | 23:00 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Ensure double-discovery and project_id manipulation works https://review.openstack.org/477242 | 23:03 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Refactor volume mock urls in identity_common tests https://review.openstack.org/477246 | 23:03 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Expose getting EndpointData on adapter and session https://review.openstack.org/469091 | 23:29 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add support for version ranges https://review.openstack.org/469090 | 23:29 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Support a list of interface values https://review.openstack.org/477169 | 23:29 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Plumb endpoint_override through get_endpoint_data https://review.openstack.org/469092 | 23:29 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Ensure we discover only when we should https://review.openstack.org/477242 | 23:29 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Optimize matching version no microversion needed https://review.openstack.org/470274 | 23:29 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Refactor volume mock urls in identity_common tests https://review.openstack.org/477246 | 23:29 |
| mordred | cmurphy, samueldmq, morgan: ok - I WAS able to get a large portion of that latest patch split into an insolated test refactor patch and two pieces of it applied to the earlier patches in the stack they were fixing | 23:30 |
| mordred | the final state in the patch adds tests then ties off on getting the discover_versions argument to be in the state we want it | 23:30 |
| morgan | Sounds good. | 23:31 |
| mordred | discover_versions argument is the only thing I can't go back and get working properly in the stack from the start without majorly reworking all the tests | 23:31 |
| * mordred flogs self | 23:31 | |
| morgan | Eh | 23:31 |
| morgan | *shrug* | 23:32 |
| mordred | yah. that's about where I got to | 23:32 |
| mordred | I'm more interesting in making sure the stack works :) | 23:32 |
| jamielennox | mordred: whoa | 23:33 |
| * mordred waves at jamielennox | 23:33 | |
| jamielennox | mordred: where do you want to manage _discovery_cache from? | 23:38 |
| *** shuyingya has joined #openstack-keystone | 23:41 | |
| mordred | jamielennox: main goal is auth plugin being able to pass one in in the following patch - but being able to pass in a dict to be able to share version discovery across more than one session (since version discovery isn't auth/user specific) is a nice side-benefit | 23:44 |
| *** shuyingya has quit IRC | 23:45 | |
| *** spzala has joined #openstack-keystone | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!