| *** thorst has joined #openstack-keystone | 00:01 | |
| *** thorst has quit IRC | 00:03 | |
| *** spzala has joined #openstack-keystone | 00:13 | |
| *** spzala has quit IRC | 00:13 | |
| *** spzala has joined #openstack-keystone | 00:13 | |
| openstackgerrit | Merged openstack/keystone master: Remove the revocation api config section https://review.openstack.org/477653 | 00:22 |
|---|---|---|
| *** sjain has quit IRC | 00:25 | |
| *** zhurong has quit IRC | 00:45 | |
| *** hoonetorg has quit IRC | 00:53 | |
| openstackgerrit | Merged openstack/keystone master: Remove note about kvs from admin-guide https://review.openstack.org/477693 | 00:55 |
| *** lucasxu has joined #openstack-keystone | 00:57 | |
| *** lucasxu has quit IRC | 00:57 | |
| *** thorst has joined #openstack-keystone | 01:04 | |
| *** hoonetorg has joined #openstack-keystone | 01:05 | |
| *** thorst has quit IRC | 01:10 | |
| *** aojea has joined #openstack-keystone | 01:16 | |
| *** hoonetorg has quit IRC | 01:16 | |
| *** aojea has quit IRC | 01:23 | |
| *** liujiong has joined #openstack-keystone | 01:23 | |
| *** Shunli has joined #openstack-keystone | 01:26 | |
| stevemar | lbragstad: i think stable/newton is toast http://logs.openstack.org/14/469514/1/check/gate-keystone-dsvm-functional-ubuntu-xenial/18ee462/console.html#_2017-06-26_20_49_55_031021 | 01:28 |
| *** hoonetorg has joined #openstack-keystone | 01:30 | |
| *** xuhaigang has joined #openstack-keystone | 01:31 | |
| *** aselius has quit IRC | 02:08 | |
| *** goofie has quit IRC | 02:10 | |
| *** zsli_ has joined #openstack-keystone | 02:25 | |
| *** yushb has joined #openstack-keystone | 02:26 | |
| *** yushb has left #openstack-keystone | 02:26 | |
| *** zsli__ has joined #openstack-keystone | 02:27 | |
| *** Shunli has quit IRC | 02:27 | |
| *** zsli_ has quit IRC | 02:31 | |
| *** wlfightup has joined #openstack-keystone | 02:55 | |
| wlfightup | https://ask.openstack.org/en/question/108031/why-the-new-version-of-keystone-must-use-apache/ | 02:57 |
| *** wlfightup_ has joined #openstack-keystone | 02:59 | |
| wlfightup | welcome | 03:00 |
| *** wlfightup has quit IRC | 03:02 | |
| *** wlfightup_ is now known as wlfightup | 03:02 | |
| *** zsli__ has quit IRC | 03:02 | |
| *** zsli_ has joined #openstack-keystone | 03:02 | |
| *** wlfightup_ has joined #openstack-keystone | 03:02 | |
| wlfightup_ | hello everyone | 03:03 |
| wlfightup | hi | 03:04 |
| *** wlfightup_ has quit IRC | 03:06 | |
| *** aojea has joined #openstack-keystone | 03:09 | |
| *** aojea has quit IRC | 03:13 | |
| *** thorst has joined #openstack-keystone | 03:35 | |
| *** thorst has quit IRC | 03:41 | |
| *** links has joined #openstack-keystone | 03:42 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 04:02 | |
| *** zsli_ has quit IRC | 04:14 | |
| *** zsli_ has joined #openstack-keystone | 04:14 | |
| *** spzala has quit IRC | 04:28 | |
| *** spzala has joined #openstack-keystone | 04:28 | |
| *** spzala has quit IRC | 04:33 | |
| *** spzala has joined #openstack-keystone | 04:36 | |
| *** zhurong has joined #openstack-keystone | 04:36 | |
| *** thorst has joined #openstack-keystone | 04:38 | |
| *** thorst has quit IRC | 04:43 | |
| *** htruta` has joined #openstack-keystone | 05:11 | |
| *** htruta has quit IRC | 05:13 | |
| *** breton has quit IRC | 05:13 | |
| *** EmilienM has quit IRC | 05:13 | |
| *** adriant has quit IRC | 05:13 | |
| *** chrome0 has quit IRC | 05:14 | |
| *** raj_singh has quit IRC | 05:14 | |
| *** adriant has joined #openstack-keystone | 05:14 | |
| *** raj_singh has joined #openstack-keystone | 05:15 | |
| *** chrome0 has joined #openstack-keystone | 05:15 | |
| *** john5223_ has quit IRC | 05:17 | |
| *** breton has joined #openstack-keystone | 05:19 | |
| *** EmilienM has joined #openstack-keystone | 05:20 | |
| *** adriant has quit IRC | 05:20 | |
| *** adriant has joined #openstack-keystone | 05:20 | |
| *** adriant67 has joined #openstack-keystone | 05:25 | |
| *** adriant67 has quit IRC | 05:25 | |
| *** adriant has quit IRC | 05:25 | |
| *** adriant has joined #openstack-keystone | 05:25 | |
| *** tobberydberg has joined #openstack-keystone | 05:27 | |
| *** masber has joined #openstack-keystone | 05:33 | |
| *** oomichi_ has joined #openstack-keystone | 05:36 | |
| *** ianw_ has joined #openstack-keystone | 05:36 | |
| *** oomichi has quit IRC | 05:39 | |
| *** ianw has quit IRC | 05:39 | |
| *** oomichi_ is now known as oomichi | 05:39 | |
| *** ianw_ is now known as ianw | 05:39 | |
| *** aojea has joined #openstack-keystone | 05:39 | |
| *** eglute_s has quit IRC | 05:41 | |
| *** eglute has joined #openstack-keystone | 05:44 | |
| *** wlfightup has quit IRC | 05:54 | |
| *** rcernin has joined #openstack-keystone | 05:55 | |
| *** aojea has quit IRC | 06:05 | |
| *** wlfightup has joined #openstack-keystone | 06:06 | |
| *** ayoung has quit IRC | 06:12 | |
| *** ayoung has joined #openstack-keystone | 06:24 | |
| *** rcernin has quit IRC | 06:26 | |
| *** spzala has quit IRC | 06:29 | |
| *** rcernin has joined #openstack-keystone | 06:32 | |
| openstackgerrit | wangzhenyu proposed openstack/keystoneauth master: Enable some off-by-default checks https://review.openstack.org/477775 | 06:41 |
| *** thorst has joined #openstack-keystone | 06:47 | |
| *** clayton has quit IRC | 06:48 | |
| *** thorst has quit IRC | 06:52 | |
| *** tesseract has joined #openstack-keystone | 06:55 | |
| *** xuhaigang has quit IRC | 07:08 | |
| *** clayton has joined #openstack-keystone | 07:11 | |
| *** gyee has quit IRC | 07:23 | |
| *** f13o has joined #openstack-keystone | 07:27 | |
| *** pcaruana has joined #openstack-keystone | 07:32 | |
| *** xuhaigang has joined #openstack-keystone | 07:33 | |
| *** toddnni has joined #openstack-keystone | 07:33 | |
| *** f13o has quit IRC | 07:35 | |
| *** f13o has joined #openstack-keystone | 07:50 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** spzala has joined #openstack-keystone | 08:00 | |
| *** zzzeek has joined #openstack-keystone | 08:03 | |
| *** aojea has joined #openstack-keystone | 08:05 | |
| *** spzala has quit IRC | 08:05 | |
| *** aojea has quit IRC | 08:28 | |
| *** aojea has joined #openstack-keystone | 08:34 | |
| *** thorst has joined #openstack-keystone | 08:49 | |
| *** thorst has quit IRC | 08:53 | |
| *** d0ugal has quit IRC | 08:58 | |
| *** d0ugal_ has joined #openstack-keystone | 08:59 | |
| *** d0ugal_ has quit IRC | 08:59 | |
| *** d0ugal has joined #openstack-keystone | 08:59 | |
| *** d0ugal has quit IRC | 08:59 | |
| *** d0ugal has joined #openstack-keystone | 08:59 | |
| *** spzala has joined #openstack-keystone | 09:01 | |
| *** spzala has quit IRC | 09:06 | |
| *** zsli_ has quit IRC | 09:11 | |
| *** Shunli has joined #openstack-keystone | 09:11 | |
| *** zsli_ has joined #openstack-keystone | 09:15 | |
| *** zsli_ has quit IRC | 09:16 | |
| *** Shunli has quit IRC | 09:17 | |
| openstackgerrit | zhengliuyang proposed openstack/keystone master: Remove hash_algorithms from performance.rst https://review.openstack.org/469333 | 09:21 |
| *** Shunli has joined #openstack-keystone | 09:21 | |
| *** Shunli has quit IRC | 09:27 | |
| *** jmlowe_ has joined #openstack-keystone | 09:27 | |
| *** iogg has joined #openstack-keystone | 09:29 | |
| *** mvk has quit IRC | 09:30 | |
| *** jlvillal_ has joined #openstack-keystone | 09:33 | |
| *** d0ugal has quit IRC | 09:34 | |
| *** chrome0 has quit IRC | 09:34 | |
| *** hoonetorg has quit IRC | 09:34 | |
| *** jmlowe has quit IRC | 09:34 | |
| *** mgagne has quit IRC | 09:35 | |
| *** jlvillal has quit IRC | 09:35 | |
| *** chrome0 has joined #openstack-keystone | 09:35 | |
| *** jlvillal_ is now known as jlvillal | 09:36 | |
| *** jlvillal is now known as Guest60319 | 09:37 | |
| *** mgagne has joined #openstack-keystone | 09:37 | |
| *** mgagne is now known as Guest28796 | 09:37 | |
| *** d0ugal has joined #openstack-keystone | 09:40 | |
| *** hoonetorg has joined #openstack-keystone | 09:41 | |
| *** chlong has joined #openstack-keystone | 09:46 | |
| *** mvk has joined #openstack-keystone | 09:57 | |
| *** spzala has joined #openstack-keystone | 10:02 | |
| *** spzala has quit IRC | 10:06 | |
| samueldmq | morning keystone | 10:11 |
| *** thorst has joined #openstack-keystone | 10:26 | |
| *** thorst has quit IRC | 10:29 | |
| *** wlfightup has quit IRC | 10:31 | |
| *** wlfightup has joined #openstack-keystone | 10:38 | |
| *** chlong_ has joined #openstack-keystone | 11:04 | |
| *** chlong has quit IRC | 11:04 | |
| *** johnthetubaguy has quit IRC | 11:16 | |
| *** johnthetubaguy has joined #openstack-keystone | 11:18 | |
| *** raildo has joined #openstack-keystone | 11:21 | |
| openstackgerrit | zhengliuyang proposed openstack/keystone master: Improper handle about building list of token deletion https://review.openstack.org/475100 | 11:33 |
| *** aojea has quit IRC | 11:34 | |
| *** liujiong has quit IRC | 11:36 | |
| knikolla | o/ morning | 11:57 |
| *** xuhaigang has quit IRC | 11:58 | |
| *** f13o has quit IRC | 12:09 | |
| *** edmondsw has joined #openstack-keystone | 12:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.policy master: Updated from global requirements https://review.openstack.org/478056 | 12:20 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/pycadf master: Updated from global requirements https://review.openstack.org/470137 | 12:20 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/478078 | 12:21 |
| *** f13o has joined #openstack-keystone | 12:22 | |
| *** lifeless has quit IRC | 12:30 | |
| *** pnavarro has joined #openstack-keystone | 12:37 | |
| *** hrybacki|trainin is now known as hrybacki | 12:38 | |
| *** f13o has quit IRC | 12:40 | |
| *** lifeless has joined #openstack-keystone | 12:43 | |
| *** spilla has joined #openstack-keystone | 12:52 | |
| *** lucasxu has joined #openstack-keystone | 13:05 | |
| openstackgerrit | Samriddhi proposed openstack/keystone master: Migrated docs from devdocs to user docs https://review.openstack.org/476200 | 13:06 |
| *** ducttape_ has quit IRC | 13:08 | |
| *** ducttape_ has joined #openstack-keystone | 13:32 | |
| *** ducttape_ has quit IRC | 13:34 | |
| *** ducttape_ has joined #openstack-keystone | 13:35 | |
| *** thorst has joined #openstack-keystone | 13:40 | |
| *** sbezverk has quit IRC | 13:44 | |
| *** thorst has quit IRC | 13:44 | |
| *** sbezverk has joined #openstack-keystone | 13:45 | |
| *** bknudson has joined #openstack-keystone | 13:46 | |
| *** iogg is now known as ioggstream | 13:47 | |
| *** thorst has joined #openstack-keystone | 13:54 | |
| *** thorst has quit IRC | 13:56 | |
| openstackgerrit | Samriddhi proposed openstack/keystone master: Expanded the best practices subsection in devdocs https://review.openstack.org/476541 | 14:00 |
| ioggstream | hi @all | 14:02 |
| *** bknudson has quit IRC | 14:09 | |
| *** bknudson has joined #openstack-keystone | 14:09 | |
| lbragstad | o/ | 14:10 |
| *** f13o has joined #openstack-keystone | 14:16 | |
| *** spilla has quit IRC | 14:17 | |
| openstackgerrit | Samriddhi proposed openstack/keystone master: Reorganised developer documentation https://review.openstack.org/476606 | 14:27 |
| *** aojea has joined #openstack-keystone | 14:28 | |
| *** aselius has joined #openstack-keystone | 14:30 | |
| *** d0ugal has quit IRC | 14:32 | |
| *** d0ugal has joined #openstack-keystone | 14:32 | |
| *** d0ugal has quit IRC | 14:32 | |
| *** d0ugal has joined #openstack-keystone | 14:32 | |
| openstackgerrit | Samriddhi proposed openstack/keystone master: Reorganised developer documentation https://review.openstack.org/476606 | 14:33 |
| *** spzala has joined #openstack-keystone | 14:35 | |
| *** phalmos has joined #openstack-keystone | 14:59 | |
| lbragstad | cmurphy: how familiar with our ldap docs are you? | 15:00 |
| openstackgerrit | Samriddhi proposed openstack/keystone master: Added new subsections to developer docs https://review.openstack.org/476635 | 15:00 |
| cmurphy | lbragstad: i've been known to read them from time to time | 15:00 |
| lbragstad | cmurphy: ok - i have a patch set on the way that attempts to consolidate a bunch of what we have between the admin-guide and the operator docs | 15:01 |
| lbragstad | cmurphy: i'll probably need you to keep me honest | 15:01 |
| cmurphy | lbragstad: okay i will make sure to check it out | 15:01 |
| lbragstad | awesome - thanks | 15:01 |
| cmurphy | lbragstad: possibly not till tomorrow though | 15:02 |
| lbragstad | cmurphy: yeah - that's fine, i'm still munging stuff locally | 15:02 |
| *** Guest60319 is now known as jlvillal | 15:04 | |
| *** rcernin has quit IRC | 15:04 | |
| *** links has quit IRC | 15:05 | |
| *** tobberyd_ has joined #openstack-keystone | 15:07 | |
| *** tobberydberg has quit IRC | 15:11 | |
| *** tobberyd_ has quit IRC | 15:11 | |
| *** thorst has joined #openstack-keystone | 15:13 | |
| morgan | hmm. | 15:13 |
| morgan | o/ lbragstad | 15:13 |
| *** lucasxu has quit IRC | 15:14 | |
| *** lucasxu has joined #openstack-keystone | 15:16 | |
| *** jsavak has joined #openstack-keystone | 15:24 | |
| *** lucasxu has quit IRC | 15:28 | |
| *** thorst has quit IRC | 15:29 | |
| *** Shoaibwr12 has quit IRC | 15:30 | |
| *** f13o has quit IRC | 15:30 | |
| *** Shoaibwr12 has joined #openstack-keystone | 15:30 | |
| morgan | oh wow, i haven't seen jsavak in ages | 15:30 |
| *** gyee has joined #openstack-keystone | 15:34 | |
| *** pnavarro has quit IRC | 15:35 | |
| *** tobberydberg has joined #openstack-keystone | 15:36 | |
| *** aojea has quit IRC | 15:37 | |
| *** jsavak has quit IRC | 15:37 | |
| *** aojea has joined #openstack-keystone | 15:38 | |
| *** jsavak has joined #openstack-keystone | 15:38 | |
| *** tobberydberg has quit IRC | 15:39 | |
| *** tobberydberg has joined #openstack-keystone | 15:39 | |
| *** tobberydberg has quit IRC | 15:39 | |
| *** tobberydberg has joined #openstack-keystone | 15:39 | |
| *** tobberydberg has quit IRC | 15:41 | |
| *** tobberydberg has joined #openstack-keystone | 15:42 | |
| *** aojea has quit IRC | 15:42 | |
| *** jsavak has quit IRC | 15:43 | |
| *** tobberydberg has quit IRC | 15:46 | |
| *** wlfightup has quit IRC | 15:48 | |
| *** jsavak has joined #openstack-keystone | 15:59 | |
| openstackgerrit | Merged openstack/oslo.policy master: Updated from global requirements https://review.openstack.org/478056 | 16:00 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Consolidate LDAP documentation into admin-guide https://review.openstack.org/478206 | 16:00 |
| openstackgerrit | Merged openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/478078 | 16:01 |
| *** gyee has quit IRC | 16:02 | |
| *** links has joined #openstack-keystone | 16:02 | |
| *** chlong has joined #openstack-keystone | 16:05 | |
| *** chlong has quit IRC | 16:05 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove duplicate logging documentation https://review.openstack.org/477692 | 16:08 |
| *** pcaruana has quit IRC | 16:09 | |
| *** thorst has joined #openstack-keystone | 16:11 | |
| *** lucasxu has joined #openstack-keystone | 16:16 | |
| lbragstad | alright - breaking for lunch | 16:18 |
| *** gyee has joined #openstack-keystone | 16:25 | |
| *** rderose has joined #openstack-keystone | 16:26 | |
| *** lucasxu has quit IRC | 16:29 | |
| *** lucasxu has joined #openstack-keystone | 16:30 | |
| *** tesseract has quit IRC | 16:40 | |
| *** lwanderley has joined #openstack-keystone | 16:42 | |
| *** jsavak has quit IRC | 16:48 | |
| *** jsavak has joined #openstack-keystone | 16:49 | |
| *** lucasxu has quit IRC | 16:49 | |
| *** jsavak has quit IRC | 16:53 | |
| *** links has quit IRC | 16:57 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Consolidate LDAP documentation into admin-guide https://review.openstack.org/478206 | 17:01 |
| *** jsavak has joined #openstack-keystone | 17:03 | |
| *** aojea has joined #openstack-keystone | 17:08 | |
| *** spzala has quit IRC | 17:10 | |
| *** spzala has joined #openstack-keystone | 17:10 | |
| *** lucasxu has joined #openstack-keystone | 17:12 | |
| *** mvk has quit IRC | 17:27 | |
| openstackgerrit | Jaewoo Park proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 17:31 |
| *** ducttape_ has quit IRC | 17:37 | |
| *** aojea has quit IRC | 17:41 | |
| *** spilla has joined #openstack-keystone | 17:41 | |
| *** aojea has joined #openstack-keystone | 17:42 | |
| *** aojea has quit IRC | 17:46 | |
| *** lwanderley has quit IRC | 17:47 | |
| *** Shoaibwr12 has quit IRC | 17:48 | |
| *** lwanderley has joined #openstack-keystone | 17:52 | |
| hrybacki | lbragstad: so office hours will kick off each week with our meeting? | 17:53 |
| lbragstad | hrybacki: essentially | 17:53 |
| hrybacki | wonderful | 17:53 |
| lbragstad | hrybacki: or right after is what i was thinking | 17:53 |
| lbragstad | should make for a nice transition | 17:53 |
| hrybacki | agreed | 17:53 |
| lbragstad | and if we have extra time each week in the meeting we can use it for triage or whatever | 17:53 |
| hrybacki | ++ | 17:53 |
| *** links has joined #openstack-keystone | 17:55 | |
| hrybacki | lbragstad: i'll be a few mins late to the mtg | 17:55 |
| lbragstad | hrybacki: no worries - thanks for the heads | 17:56 |
| lbragstad | up | 17:56 |
| *** links has quit IRC | 18:02 | |
| *** sjain_ has joined #openstack-keystone | 18:06 | |
| *** spzala has quit IRC | 18:10 | |
| *** spzala has joined #openstack-keystone | 18:11 | |
| *** spzala has quit IRC | 18:15 | |
| *** spzala has joined #openstack-keystone | 18:16 | |
| *** ioggstream has quit IRC | 18:22 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Add is_admin_project check to policy for non scoped operations https://review.openstack.org/257636 | 18:31 |
| *** lwanderley has quit IRC | 18:43 | |
| *** spzala has quit IRC | 18:53 | |
| *** jsavak has quit IRC | 18:54 | |
| *** spzala has joined #openstack-keystone | 18:54 | |
| *** jsavak has joined #openstack-keystone | 18:54 | |
| *** jsavak has quit IRC | 18:59 | |
| *** spzala has quit IRC | 18:59 | |
| lbragstad | o/ | 18:59 |
| gagehugo | o/ | 18:59 |
| lbragstad | office hours will be starting shortly | 18:59 |
| *** jsavak has joined #openstack-keystone | 18:59 | |
| knikolla | I can't attend for these few weeks i'm in europe, but after that i should be a go. | 19:02 |
| *** aojea has joined #openstack-keystone | 19:03 | |
| hrybacki | o/ | 19:03 |
| hrybacki | knikolla: ack | 19:03 |
| samueldmq | I will be back in a bit for office hours | 19:05 |
| *** spilla has quit IRC | 19:07 | |
| *** tobberydberg has joined #openstack-keystone | 19:07 | |
| *** jsavak has quit IRC | 19:08 | |
| *** sjain_ has quit IRC | 19:09 | |
| *** jsavak has joined #openstack-keystone | 19:09 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone master: Remove support for direct import of drivers https://review.openstack.org/478243 | 19:13 |
| samueldmq | lbragstad: ^ let's see what jenkins says about it | 19:13 |
| lbragstad | alrighty | 19:13 |
| lbragstad | #startmeeting keystone-office-hours | 19:14 |
| openstack | Meeting started Tue Jun 27 19:14:03 2017 UTC and is due to finish in 60 minutes. The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot. | 19:14 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 19:14 |
| openstack | The meeting name has been set to 'keystone_office_hours' | 19:14 |
| hrybacki | o/ | 19:14 |
| gagehugo | o/ | 19:14 |
| lbragstad | o/ | 19:14 |
| hrybacki | cool. what now? | 19:15 |
| lamt | o/ | 19:15 |
| lbragstad | next - let's go through what we want to try and get done | 19:16 |
| lbragstad | this can be patches in review | 19:16 |
| lbragstad | or bugs in LP | 19:16 |
| hrybacki | what needs help the most right now? | 19:16 |
| lbragstad | i use https://goo.gl/ZgrrT7 | 19:17 |
| lbragstad | #link https://goo.gl/ZgrrT7 | 19:17 |
| gagehugo | lbragstad oh nice | 19:17 |
| hrybacki | same | 19:18 |
| lbragstad | the idea came from dstanek | 19:18 |
| *** ducttape_ has joined #openstack-keystone | 19:18 | |
| lbragstad | but the objective was to draw attention to the patches we have in review that already close bugs | 19:18 |
| lbragstad | instead of automatically going to launchpad to find something to fix | 19:18 |
| lbragstad | not to shamelessly plug my own patch but.. | 19:19 |
| lbragstad | #link https://review.openstack.org/#/c/475472/ seems to be close | 19:19 |
| lbragstad | #link https://review.openstack.org/#/c/475929/ is good | 19:20 |
| lbragstad | i can review ^ | 19:20 |
| * lbragstad can't do much, be he can review 7 lines of code | 19:20 | |
| hrybacki | I'll peak at your commit now lbragstad | 19:20 |
| hrybacki | /s/commit/review/ | 19:20 |
| lbragstad | hrybacki: thanks! | 19:20 |
| gagehugo | same | 19:20 |
| *** aojea has quit IRC | 19:21 | |
| gagehugo | lbragstad I went with a more generic message for https://review.openstack.org/#/c/475929/ | 19:21 |
| *** aojea has joined #openstack-keystone | 19:21 | |
| gagehugo | not sure if we want to tell the user that the backend is ldap | 19:21 |
| *** mvk has joined #openstack-keystone | 19:23 | |
| lbragstad | gagehugo: ok - i think that's fine | 19:24 |
| *** aojea has quit IRC | 19:26 | |
| lbragstad | #action review https://review.openstack.org/#/c/475472/ | 19:26 |
| lbragstad | #action review https://review.openstack.org/#/c/475929/ | 19:27 |
| lbragstad | #link https://review.openstack.org/#/c/475100/ | 19:27 |
| lbragstad | ^ that's another one that's ready for review and closes a bug | 19:27 |
| lbragstad | #undo | 19:27 |
| openstack | Removing item from minutes: #link https://review.openstack.org/#/c/475100/ | 19:27 |
| lbragstad | maybe not - triaging the bug | 19:28 |
| *** rderose has quit IRC | 19:28 | |
| hrybacki | lbragstad: gagehugo general question -- when do we add tests? | 19:29 |
| lbragstad | hrybacki: unit tests? | 19:29 |
| hrybacki | e.g. for gagehugo's review, would we want to add a test that checks the proper exception is caught? | 19:29 |
| * hrybacki nods | 19:29 | |
| gagehugo | hrybacki yeah should probably do that | 19:29 |
| lbragstad | hrybacki: yeah - that'd be good | 19:30 |
| hrybacki | do we have a general policy for that though? | 19:30 |
| lbragstad | gagehugo: think you can find a seem to test that? | 19:30 |
| lbragstad | hrybacki: typically every patch should be accompanied with tests | 19:31 |
| *** tobberydberg has quit IRC | 19:31 | |
| hrybacki | ack | 19:31 |
| lbragstad | some cases where that's not always the case is ldap stuff (because of integration issues and the slippery slope of mocking and cli stuff) | 19:31 |
| gagehugo | I'll find where we are testing invalid credentials | 19:31 |
| *** tobberydberg has joined #openstack-keystone | 19:31 | |
| *** spzala has joined #openstack-keystone | 19:31 | |
| *** tobberydberg has quit IRC | 19:33 | |
| *** tobberydberg has joined #openstack-keystone | 19:33 | |
| gagehugo | I don't think there are any current ldap unit tests for authing | 19:42 |
| hrybacki | that is a bug in and of itself haha | 19:42 |
| lamt | it might be in the functional test | 19:43 |
| hrybacki | confused why steve gave +2 here: https://review.openstack.org/#/c/477638/ but left corrections in his comments | 19:43 |
| lamt | if deals with ldap | 19:43 |
| gagehugo | nope | 19:46 |
| *** ducttape_ has quit IRC | 19:46 | |
| cmurphy | hey guys | 19:46 |
| cmurphy | how is bug day going? | 19:46 |
| lbragstad | cmurphy: o/ | 19:46 |
| *** jsavak has quit IRC | 19:46 | |
| *** ducttape_ has joined #openstack-keystone | 19:46 | |
| hrybacki | o/ | 19:47 |
| hrybacki | lots of patches to review here cmurphy: https://goo.gl/H86e37 | 19:48 |
| lbragstad | #link https://review.openstack.org/#/c/473245/3 | 19:48 |
| *** jsavak has joined #openstack-keystone | 19:48 | |
| lbragstad | ^ that's a good one, too | 19:48 |
| cmurphy | hrybacki: lbragstad sweet | 19:49 |
| *** aojea has joined #openstack-keystone | 19:53 | |
| *** tobberydberg has quit IRC | 19:59 | |
| *** tobberydberg has joined #openstack-keystone | 19:59 | |
| *** tobberydberg has quit IRC | 20:00 | |
| *** tobberydberg has joined #openstack-keystone | 20:00 | |
| *** tobberydberg has quit IRC | 20:01 | |
| *** tobberydberg has joined #openstack-keystone | 20:01 | |
| *** rmascena has joined #openstack-keystone | 20:07 | |
| *** rmascena has quit IRC | 20:09 | |
| lbragstad | #link https://review.openstack.org/#/c/473245/3 has some good oauth tests in it if anyone is interested | 20:10 |
| *** raildo has quit IRC | 20:10 | |
| hrybacki | lbragstad: reviewing that now | 20:10 |
| lbragstad | hrybacki: awesome | 20:10 |
| hrybacki | I love how documented these test are | 20:14 |
| *** ioggstream has joined #openstack-keystone | 20:18 | |
| lbragstad | yeah - that's nice | 20:19 |
| lbragstad | samueldmq: it'd be good to get your opinion on https://review.openstack.org/#/c/475472/ when you have a minute | 20:20 |
| *** thorst has quit IRC | 20:21 | |
| *** sjmc7 has joined #openstack-keystone | 20:46 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Validate rolling upgrade is run in order https://review.openstack.org/437441 | 20:46 |
| lbragstad | cc cmurphy hrybacki gagehugo ^ | 20:47 |
| *** lucasxu has quit IRC | 20:48 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Validate rolling upgrade is run in order https://review.openstack.org/437441 | 20:54 |
| * samueldmq is back | 21:00 | |
| *** ducttape_ has quit IRC | 21:01 | |
| samueldmq | lbragstad: looking | 21:02 |
| hrybacki | Have to head to my next meeting -- will finish looking over ^ first thing in the morning! | 21:04 |
| morgan | I saw a ping of my name in the meetings ng | 21:09 |
| *** jsavak has quit IRC | 21:09 | |
| sjmc7 | afternoon, folks. we’ve been doing some scale/stress testing and seen high request times listing projects (specifically, GET /users/<userid>/projects) when a user has access to a lot of them (0.1 seconds with a couple of assignments up to 4-5 seconds with 500). obviously there’s much more data being pulled out of the database, but flat out listing the projects is very fast, so my guess is it’s the role assignment calculations taking the time | 21:09 |
| morgan | Something about options? | 21:09 |
| sjmc7 | does anyone have any suggestions if there’s something i can tweak or optimize? i know it’s not a common scenario | 21:09 |
| morgan | sjmc7: yep it is the role calculation. Unfortunately that is going to be somewhat slow :( | 21:10 |
| sjmc7 | no magic SQL index i can add? :) | 21:10 |
| morgan | Not really. We can't do joins because that information could be in different backends | 21:10 |
| *** tobberydberg has quit IRC | 21:11 | |
| lbragstad | morgan: ah - we were wondering when we can remove https://github.com/openstack/keystone/blob/9070172084fe31c9564de38886662fb198de68cb/keystone/conf/eventlet_server.py | 21:11 |
| morgan | User might be LDAP, project might be database, and roles could be something else. :( | 21:11 |
| *** tobberydberg has joined #openstack-keystone | 21:11 | |
| sjmc7 | yeah, that makes sense | 21:11 |
| morgan | lbragstad: remove it | 21:11 |
| morgan | lbragstad: eventlet is dead | 21:11 |
| morgan | For keystone * | 21:12 |
| lbragstad | morgan: ok - so those weren't there for backwards compat? | 21:12 |
| morgan | Might have been, we used eventlet for testing for a while after we stopped supporting it for deployment | 21:12 |
| morgan | Might have been that. We don't do that anymore | 21:12 |
| morgan | (or shouldn't) | 21:12 |
| lbragstad | we still have the eventlet entry points | 21:12 |
| morgan | Eventlet should be dead, no? | 21:13 |
| morgan | We don't import it, we don't depend on ot | 21:13 |
| lbragstad | morgan: well - i can run keystone locally using keystone-wsgi-admin | 21:13 |
| morgan | Again, I say make the last vestige disappear. | 21:13 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Document and add release note for HEAD APIs https://review.openstack.org/478284 | 21:15 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Document and add release note for HEAD APIs https://review.openstack.org/478284 | 21:15 |
| *** ioggstream has quit IRC | 21:15 | |
| lbragstad | morgan: ok | 21:16 |
| lbragstad | cc cmurphy samueldmq hrybacki gagehugo ^ that one closes another bug | 21:18 |
| sjmc7 | morgan: do you know where the time’s getting spent? querying role assignments is also very fast - is there a lot of manipulation of the result going on in code? | 21:19 |
| lbragstad | sjmc7: do you happen to have caching enabled? | 21:20 |
| sjmc7 | no, we don’t | 21:21 |
| *** tobberydberg has quit IRC | 21:21 | |
| lbragstad | sjmc7: that may have a significant impact on your results | 21:21 |
| *** tobberydberg has joined #openstack-keystone | 21:21 | |
| sjmc7 | yeah, i imagine it would. i’ll give that a go, thanks | 21:22 |
| *** ducttape_ has joined #openstack-keystone | 21:23 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove duplicate list() call when list projects https://review.openstack.org/478286 | 21:26 |
| lbragstad | sjmc7: ^ looking at the code now | 21:26 |
| *** tobberydberg has quit IRC | 21:26 | |
| sjmc7 | lbragstad: thanks. i had a look, and it looked pretty straightforward (retrieve the assignments, retrieve all the projects by id) | 21:27 |
| sjmc7 | but there’s something goign on - listing assignments with GET /role_assignments?user.id takes around 0.1 seconds and GET /projects is about 0.2 (including outputting to the terminal) | 21:28 |
| sjmc7 | again, i know this isn’t exactly a common case that’d be optimized for | 21:28 |
| lbragstad | we seem to jump from https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/assignment/core.py#L232 | 21:28 |
| lbragstad | right to the resource driver https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/resource/backends/sql.py#L85-L93 | 21:28 |
| sjmc7 | yeah | 21:29 |
| lbragstad | sjmc7: do you have any insight or ability to time each line in https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/assignment/core.py#L226 ? | 21:29 |
| sjmc7 | yeah, i can do that | 21:30 |
| lbragstad | sjmc7: hmmmm | 21:31 |
| sjmc7 | i think this might be an old version (newton?) but it doesn’t look like it’s changed much | 21:32 |
| lbragstad | sjmc7: since we don't define that method in the resource manager, i wonder if it's even possible to cache it ? | 21:32 |
| samueldmq | lbragstad: done in the GET/HEAD reviews | 21:32 |
| sjmc7 | # TODO(henry-nash): We might want to consider list limiting this at some | 21:32 |
| sjmc7 | # point in the future. | 21:32 |
| samueldmq | I will need a bit of time to test that one in the db_sync check in my environment | 21:32 |
| sjmc7 | someoen was here before me :) | 21:32 |
| lbragstad | samueldmq: awesome - thanks for the feedback | 21:32 |
| *** phalmos has quit IRC | 21:32 | |
| samueldmq | sure | 21:32 |
| lbragstad | sjmc7: we typically implement caching based on method arguments | 21:34 |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Clarify LDAP invalid credentials exception https://review.openstack.org/475929 | 21:34 |
| lbragstad | sjmc7: like this https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/token/provider.py#L180 | 21:34 |
| gagehugo | lbragstad hrybacki ^ | 21:35 |
| lbragstad | gagehugo: running tests on it now | 21:35 |
| gagehugo | also I noticed that one added test is being ran 8 times | 21:35 |
| *** ducttape_ has quit IRC | 21:35 | |
| lbragstad | gagehugo: it's probably because that test module is being inherited in other places | 21:36 |
| gagehugo | lbragstad yeah | 21:36 |
| gagehugo | I wonder if that could be cleaned up? | 21:36 |
| lbragstad | i have a hard time wrapping my head around the dependencies of ldap/sql test modules | 21:36 |
| lbragstad | gagehugo: oh - i'm sure it could | 21:36 |
| *** thorst has joined #openstack-keystone | 21:36 | |
| *** bknudson has quit IRC | 21:37 | |
| lbragstad | sjmc7: since we don't have those methods defined in the resource manager, i'm not sure it's possible to cache them | 21:37 |
| sjmc7 | that’s sad :( | 21:37 |
| lbragstad | sjmc7: i'd be curious to see if your results change with caching enabled | 21:37 |
| lbragstad | sjmc7: if not - that's certainly a bug | 21:37 |
| lbragstad | sjmc7: and we can get a fix up easy enough and possibly backported to ocata (we won't be able to backport to newton though) | 21:38 |
| lbragstad | sjmc7: it was likely missed because the method is defined in the driver and there isn't much business logic to move it up to the manager | 21:38 |
| sjmc7 | ok. just generating timing info now | 21:40 |
| *** thorst has quit IRC | 21:42 | |
| cmurphy | I don't really know what to make of https://review.openstack.org/#/c/466567 - I'm trying to curl those APIs and they're broken because there's no pki_setup | 21:42 |
| sjmc7 | lbragstad: looks like all the time’s taken inside list_role_assignments | 21:44 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Move list projects from ids to manager and cache https://review.openstack.org/478293 | 21:44 |
| lbragstad | sjmc7: that's a total wild guess | 21:45 |
| lbragstad | ^ | 21:45 |
| lbragstad | sjmc7: here - https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/assignment/core.py#L227 ? | 21:45 |
| sjmc7 | yep | 21:46 |
| sjmc7 | i’ll jam some timing info in there | 21:46 |
| lbragstad | sjmc7: hmm - https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/assignment/backends/sql.py#L190-L247 doesn't look trivial | 21:47 |
| sjmc7 | no, but calling GET /role_assignments?user.id= *is* quick | 21:47 |
| lbragstad | sjmc7: hmm - which eventually calls into https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/assignment/core.py#L882 | 21:50 |
| sjmc7 | those role assignment functions do get complicated quick | 21:53 |
| lbragstad | sjmc7: both of those API end up calling the same driver method | 21:53 |
| sjmc7 | yeah :( | 21:53 |
| gagehugo | lbragstad I'm getting 2 failures, I wonder if I can move this test to another class where it won't be ran 8 times | 21:54 |
| *** ioggstream has joined #openstack-keystone | 21:54 | |
| lbragstad | gagehugo: yeah - i got a couple, too | 21:54 |
| lbragstad | sjmc7: i wonder if it's a difference of using `effective` or not | 21:55 |
| lbragstad | sjmc7: https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/assignment/core.py#L228 | 21:55 |
| sjmc7 | yeah, there’s a branch on that | 21:55 |
| sjmc7 | gonna put some more timing around it | 21:56 |
| lbragstad | the GET /role_assignment?user.id= API doesn't calculate effective role assignments unless you ask it to | 21:56 |
| lbragstad | sjmc7: but... list_projects_for_users does no matter what | 21:56 |
| sjmc7 | ah, just spits them out from the DB | 21:56 |
| sjmc7 | the list_effective function i can see would be expensive | 21:57 |
| lbragstad | here - https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/assignment/core.py#L931-L935 | 21:58 |
| lbragstad | yeah - maybe time that? | 21:58 |
| sjmc7 | yep | 21:59 |
| lbragstad | sjmc7: https://github.com/openstack/keystone/blob/a1976aa2c9b70de30ea6f646b430bd49f82dbcc1/keystone/assignment/core.py#L692 looks intense, too | 21:59 |
| *** aojea has quit IRC | 22:01 | |
| *** aojea has joined #openstack-keystone | 22:01 | |
| sjmc7 | yep :) | 22:03 |
| sjmc7 | yeah, so calling /users/abc/projects list_effective is taking around 4 seconds. list_direct is very fast | 22:05 |
| lbragstad | sjmc7: so - sounds like effectively role assignments could be improved | 22:05 |
| *** aojea has quit IRC | 22:05 | |
| sjmc7 | yeah, looks like it. it seems it’s unlikely to be the database since wit a few hundred rows even a full table scan will be very quick | 22:06 |
| lbragstad | yeah - effective role assignment probably has a lot of marshalling in python | 22:06 |
| lbragstad | which is more likely the case | 22:07 |
| lbragstad | sjmc7: would you be able to open a bug against keystone and include your timing? | 22:08 |
| sjmc7 | yeah, will do | 22:08 |
| lbragstad | sjmc7: thanks | 22:09 |
| lbragstad | hrybacki: gagehugo cmurphy lamt that about does it for office hours | 22:09 |
| lbragstad | thanks for coming! | 22:09 |
| lbragstad | #endmeeting | 22:09 |
| openstack | Meeting ended Tue Jun 27 22:09:54 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 22:09 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2017/keystone_office_hours.2017-06-27-19.14.html | 22:09 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/keystone_office_hours/2017/keystone_office_hours.2017-06-27-19.14.txt | 22:09 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2017/keystone_office_hours.2017-06-27-19.14.log.html | 22:09 |
| cmurphy | \o/ | 22:10 |
| lbragstad | i kinda like using the meeting bot | 22:10 |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Clarify LDAP invalid credentials exception https://review.openstack.org/475929 | 22:16 |
| *** phalmos has joined #openstack-keystone | 22:16 | |
| *** thorst has joined #openstack-keystone | 22:16 | |
| gagehugo | lbragstad tests pass there ^ | 22:17 |
| *** thorst has quit IRC | 22:17 | |
| lbragstad | gagehugo: cool - reviewing it quick | 22:17 |
| lbragstad | hrybacki: any thoughts on my comments here? or should we address it in another patch set https://review.openstack.org/#/c/449246/6/keystone/common/policies/implied_role.py ? | 22:21 |
| sjmc7 | https://bugs.launchpad.net/keystone/+bug/1700852 lbragstad . i have to step away, thanks for the help | 22:21 |
| openstack | Launchpad bug 1700852 in OpenStack Identity (keystone) "Slow listing projects for user with many role assignments" [Undecided,New] | 22:21 |
| lbragstad | sjmc7: no problem - thanks for opening the bug | 22:22 |
| *** ducttape_ has joined #openstack-keystone | 22:22 | |
| *** spzala has quit IRC | 22:28 | |
| *** spzala has joined #openstack-keystone | 22:29 | |
| *** phalmos_ has joined #openstack-keystone | 22:33 | |
| *** spzala has quit IRC | 22:33 | |
| *** phalmos has quit IRC | 22:35 | |
| *** phalmos has joined #openstack-keystone | 22:38 | |
| *** phalmos_ has quit IRC | 22:38 | |
| *** phalmos has quit IRC | 22:58 | |
| openstackgerrit | Merged openstack/keystone master: Implement HEAD for assignment API https://review.openstack.org/473912 | 22:59 |
| *** ioggstream has quit IRC | 23:04 | |
| *** hoonetorg has quit IRC | 23:09 | |
| *** hoonetorg has joined #openstack-keystone | 23:26 | |
| *** phalmos has joined #openstack-keystone | 23:27 | |
| *** ducttape_ has quit IRC | 23:28 | |
| *** phalmos_ has joined #openstack-keystone | 23:29 | |
| *** phalmos has quit IRC | 23:32 | |
| openstackgerrit | Jaewoo Park proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 23:41 |
| *** phalmos_ has quit IRC | 23:42 | |
| *** phalmos has joined #openstack-keystone | 23:43 | |
| *** spzala has joined #openstack-keystone | 23:47 | |
| openstackgerrit | Merged openstack/keystone master: Move ec2 credential policies to DocumentedRuleDefault https://review.openstack.org/449235 | 23:47 |
| *** thorst has joined #openstack-keystone | 23:51 | |
| *** spzala has quit IRC | 23:51 | |
| *** thorst has quit IRC | 23:52 | |
| *** phalmos has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!