*** lwanderley has joined #openstack-keystone | 00:06 | |
*** jmlowe has quit IRC | 00:18 | |
*** jmlowe has joined #openstack-keystone | 00:19 | |
*** jmlowe has quit IRC | 00:19 | |
*** jmlowe has joined #openstack-keystone | 00:20 | |
*** jmlowe_ has joined #openstack-keystone | 00:22 | |
*** jmlowe has quit IRC | 00:24 | |
*** lbragsta_ has quit IRC | 00:28 | |
*** thorst has joined #openstack-keystone | 00:31 | |
*** catintheroof has joined #openstack-keystone | 00:33 | |
*** thorst has quit IRC | 00:36 | |
*** Shunli has joined #openstack-keystone | 00:46 | |
*** lwanderley has quit IRC | 01:02 | |
*** thorst has joined #openstack-keystone | 01:03 | |
*** aojea has joined #openstack-keystone | 01:08 | |
*** aojea has quit IRC | 01:13 | |
*** r-daneel has joined #openstack-keystone | 01:18 | |
*** azurepancake has joined #openstack-keystone | 01:52 | |
*** ducttap__ has joined #openstack-keystone | 02:02 | |
*** lwanderley has joined #openstack-keystone | 02:05 | |
*** r-daneel has quit IRC | 02:06 | |
*** azurepancake has quit IRC | 02:11 | |
*** ducttap__ has quit IRC | 02:12 | |
*** ducttape_ has joined #openstack-keystone | 02:19 | |
*** ducttap__ has joined #openstack-keystone | 02:21 | |
*** ducttape_ has quit IRC | 02:21 | |
*** catintheroof has quit IRC | 02:22 | |
*** ducttap__ has quit IRC | 02:22 | |
*** r-daneel has joined #openstack-keystone | 02:23 | |
*** ducttape_ has joined #openstack-keystone | 02:23 | |
*** ducttape_ has quit IRC | 02:24 | |
*** ducttap__ has joined #openstack-keystone | 02:24 | |
*** ducttap__ has quit IRC | 02:28 | |
*** ducttap__ has joined #openstack-keystone | 02:34 | |
*** ducttap__ has quit IRC | 02:38 | |
*** ducttape_ has joined #openstack-keystone | 02:38 | |
*** ducttap__ has joined #openstack-keystone | 02:40 | |
*** ducttape_ has quit IRC | 02:40 | |
*** ducttap__ has quit IRC | 02:44 | |
*** sbezverk has quit IRC | 02:44 | |
*** lbragsta_ has joined #openstack-keystone | 02:47 | |
*** ChanServ sets mode: +o lbragsta_ | 02:47 | |
*** thorst has joined #openstack-keystone | 03:04 | |
*** Shunli has quit IRC | 03:05 | |
*** Shunli has joined #openstack-keystone | 03:05 | |
*** aojea has joined #openstack-keystone | 03:09 | |
*** thorst has quit IRC | 03:10 | |
*** aojea has quit IRC | 03:14 | |
*** mtreinish has quit IRC | 03:14 | |
*** ducttape_ has joined #openstack-keystone | 03:19 | |
*** mtreinish has joined #openstack-keystone | 03:20 | |
*** ducttape_ has quit IRC | 03:31 | |
*** links has joined #openstack-keystone | 03:46 | |
*** ducttape_ has joined #openstack-keystone | 03:52 | |
*** ducttap__ has joined #openstack-keystone | 03:54 | |
*** ducttape_ has quit IRC | 03:54 | |
mordred | efried_zzz, morgan, lbragstad, cmurphy: I found one more little bug in the latest ksa (somewhere in a refactor we stopped setting a variable to a value) - the fix is small and I've got it locally - but I'm working through making sure it's the only one rel quick | 03:55 |
---|---|---|
*** ducttap__ has quit IRC | 03:55 | |
mordred | (this is the result of working on patches to consume) | 03:56 |
morgan | Omg time zone shift. | 03:56 |
morgan | Is it 3.0.2 worthy? | 03:57 |
morgan | If so, propose a blacklist of 3.0.1? | 03:57 |
morgan | And I'm going to sigh a lot at you. | 03:57 |
morgan | You owe keystone folks whiskey for 3.0.1 btw ;) | 03:58 |
morgan | (not me, since I won't be in the same locale as you and the other contributors) | 03:59 |
*** lbragsta_ has quit IRC | 04:02 | |
*** lbragsta_ has joined #openstack-keystone | 04:03 | |
*** ChanServ sets mode: +o lbragsta_ | 04:03 | |
*** lbragsta_ has quit IRC | 04:35 | |
*** lwanderley has quit IRC | 04:38 | |
*** lwanderley has joined #openstack-keystone | 04:40 | |
*** lwanderley has quit IRC | 04:47 | |
*** sbezverk has joined #openstack-keystone | 04:51 | |
*** ducttape_ has joined #openstack-keystone | 04:53 | |
*** Dinesh_Bhor has joined #openstack-keystone | 04:56 | |
*** ducttape_ has quit IRC | 04:58 | |
*** wasmum has quit IRC | 05:01 | |
*** wasmum has joined #openstack-keystone | 05:02 | |
*** thorst has joined #openstack-keystone | 05:05 | |
*** aojea has joined #openstack-keystone | 05:10 | |
*** thorst has quit IRC | 05:10 | |
*** aojea has quit IRC | 05:15 | |
*** boris-42____ has joined #openstack-keystone | 05:30 | |
*** aojea has joined #openstack-keystone | 05:44 | |
mordred | morgan: yes 3.0.2 worthy - but no, don't need a blacklist | 05:55 |
mordred | morgan: andyes to whiskey | 05:55 |
mordred | morgan: it's not a thing that will break anyone currently - it's a thing that is missing that's needed to actually use the new calls (and we have the attribute and expose it - we just forgot to actually, you know, write data into it) | 05:56 |
morgan | Ah | 05:56 |
mordred | morgan: we don't actualy record the major version of the endpoint we discover :) | 05:57 |
morgan | Ouch | 05:57 |
mordred | yah. kinda funny | 05:57 |
mordred | I have a patch that fixes it that's nice and small - writing tests ... | 05:58 |
morgan | We may want to blacklist 3.0.1 as well then... Just for the sake of people leaning on new functionality and it not working. | 05:58 |
morgan | Once 3.0.2 is released. | 05:58 |
mordred | yah | 05:58 |
mordred | ++ | 05:58 |
morgan | Also.. | 05:58 |
morgan | Sigh | 05:58 |
morgan | Sigh | 05:58 |
mordred | yah | 05:58 |
morgan | Sigh | 05:58 |
morgan | lbragstad: ^cc | 05:59 |
mordred | morgan: I actually have a video of your face sighing playing in a loop | 05:59 |
morgan | Dims ^cc | 05:59 |
*** ducttape_ has joined #openstack-keystone | 06:03 | |
*** ducttape_ has quit IRC | 06:08 | |
*** aojea has quit IRC | 06:10 | |
*** rcernin has joined #openstack-keystone | 06:23 | |
*** thorst has joined #openstack-keystone | 06:27 | |
*** thorst has quit IRC | 06:31 | |
*** zsli_ has joined #openstack-keystone | 06:41 | |
*** Shunli has quit IRC | 06:44 | |
*** ducttape_ has joined #openstack-keystone | 06:57 | |
*** phalmos has quit IRC | 07:01 | |
*** ducttape_ has quit IRC | 07:02 | |
*** nicolasbock has joined #openstack-keystone | 07:03 | |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Record the discovered major api version https://review.openstack.org/486506 | 07:09 |
mordred | morgan, lbragstad, efried_zzz, cmurphy: ^^ there's the missing bit related to consuming the results | 07:10 |
mordred | along with tests | 07:10 |
jamielennox | what have we done... | 07:10 |
mordred | morning jamielennox ! | 07:10 |
jamielennox | nope, but it's the first time i've looked in today | 07:10 |
jamielennox | mordred: o/ | 07:10 |
mordred | jamielennox: not morning for me either - although I haven't managed yet top leave my hotel room | 07:11 |
jamielennox | mordred: do you even care about little things like sun position any more | 07:11 |
mordred | jamielennox: (enjoying the lovely vistas of beijing on your side of the pacific) | 07:11 |
jamielennox | oh, nice | 07:12 |
mordred | jamielennox: oh golly no - I try to disavow any and all ideas that the sun is an absolute concept | 07:12 |
*** wasmum has quit IRC | 07:28 | |
*** aojea has joined #openstack-keystone | 07:28 | |
*** wasmum has joined #openstack-keystone | 07:28 | |
*** belmoreira has joined #openstack-keystone | 07:39 | |
*** david-lyle has quit IRC | 07:50 | |
*** dklyle has joined #openstack-keystone | 07:50 | |
*** wasmum has quit IRC | 08:13 | |
*** wasmum has joined #openstack-keystone | 08:14 | |
*** thorst has joined #openstack-keystone | 08:27 | |
*** thorst has quit IRC | 08:32 | |
*** dklyle has quit IRC | 08:32 | |
*** dklyle has joined #openstack-keystone | 08:33 | |
*** dklyle has quit IRC | 08:36 | |
*** david-lyle has joined #openstack-keystone | 08:47 | |
*** david-lyle has quit IRC | 08:49 | |
*** david-lyle has joined #openstack-keystone | 08:50 | |
*** dklyle has joined #openstack-keystone | 08:53 | |
*** david-lyle has quit IRC | 08:53 | |
*** ducttape_ has joined #openstack-keystone | 08:58 | |
*** jaosorior has joined #openstack-keystone | 09:02 | |
*** ducttape_ has quit IRC | 09:03 | |
*** boris-42____ has quit IRC | 09:19 | |
*** zsli_ has quit IRC | 09:29 | |
*** ducttape_ has joined #openstack-keystone | 10:04 | |
*** ducttap__ has joined #openstack-keystone | 10:07 | |
*** ducttape_ has quit IRC | 10:08 | |
*** ducttap__ has quit IRC | 10:12 | |
*** thorst has joined #openstack-keystone | 10:29 | |
*** thorst has quit IRC | 10:33 | |
*** r-daneel has quit IRC | 10:55 | |
*** lwanderley has joined #openstack-keystone | 11:01 | |
*** Dinesh_Bhor has quit IRC | 11:07 | |
*** raildo has joined #openstack-keystone | 11:08 | |
*** rmascena has joined #openstack-keystone | 11:35 | |
*** raildo has quit IRC | 11:37 | |
*** thorst has joined #openstack-keystone | 11:54 | |
*** dikonoor has joined #openstack-keystone | 11:55 | |
*** thorst_ has joined #openstack-keystone | 11:56 | |
*** thorst_ has quit IRC | 11:56 | |
*** thorst_ has joined #openstack-keystone | 11:57 | |
*** belmoreira has quit IRC | 11:58 | |
*** thorst has quit IRC | 11:58 | |
*** ducttape_ has joined #openstack-keystone | 12:03 | |
*** ducttape_ has quit IRC | 12:08 | |
* dims peeks | 12:31 | |
*** catintheroof has joined #openstack-keystone | 12:42 | |
*** lwanderley has quit IRC | 12:50 | |
*** chlong has joined #openstack-keystone | 12:53 | |
*** edmondsw has joined #openstack-keystone | 12:59 | |
*** r-daneel has joined #openstack-keystone | 13:09 | |
*** lucasxu has joined #openstack-keystone | 13:11 | |
samueldmq | morning | 13:12 |
*** r-daneel has quit IRC | 13:13 | |
*** ducttape_ has joined #openstack-keystone | 13:15 | |
*** gagehugo has quit IRC | 13:15 | |
*** links has quit IRC | 13:20 | |
*** gagehugo has joined #openstack-keystone | 13:21 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone master: Update docs: fernet is the default provider https://review.openstack.org/486608 | 13:23 |
*** ducttape_ has quit IRC | 13:29 | |
*** efried_zzz is now known as efried | 13:29 | |
*** Dinesh_Bhor has joined #openstack-keystone | 13:40 | |
efried | mordred Reviewed | 13:40 |
*** ducttape_ has joined #openstack-keystone | 13:43 | |
*** aselius has joined #openstack-keystone | 13:49 | |
samueldmq | gagehugo: hi, you around? re project tags | 14:03 |
knikolla | o/ | 14:04 |
lbragstad | i've proposed new stable releases for both ocata and newton https://review.openstack.org/#/c/486626/ and https://review.openstack.org/#/c/486621/ | 14:11 |
gagehugo | samueldmq o/ | 14:25 |
openstackgerrit | Merged openstack/keystonemiddleware master: Updated from global requirements https://review.openstack.org/486321 | 15:01 |
*** lucasxu has quit IRC | 15:03 | |
openstackgerrit | Merged openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/486336 | 15:11 |
samueldmq | gagehugo: o/ | 15:13 |
*** dklyle is now known as david-lyle | 15:14 | |
*** dikonoor has quit IRC | 15:14 | |
gagehugo | samueldmq what's up? | 15:14 |
samueldmq | gagehugo: I am trying to understand a bit more the chain of patches for project tags | 15:14 |
samueldmq | and I saw you're maintaining it | 15:15 |
openstackgerrit | Eric Fried proposed openstack/keystoneauth master: Make discover._version_between more lenient https://review.openstack.org/485827 | 15:16 |
samueldmq | gagehugo: I saw there is a 1k+ LOC patch that implements it, but still has WIP in the commit title | 15:16 |
samueldmq | is all the implementation in that single patch/ | 15:16 |
gagehugo | samueldmq most of it is, we have pulled the schema and DB migration out into their own patches | 15:17 |
gagehugo | I was going to take a look at the unit tests, I think those can be cleaned up a bit | 15:17 |
gagehugo | today* | 15:18 |
samueldmq | gagehugo: cool, is the feature ready? | 15:18 |
samueldmq | why is there a WIP in the title? it's been 80 patch sets already | 15:18 |
gagehugo | samueldmq not yet, it is close though | 15:18 |
samueldmq | WIP: Add project tags | 15:19 |
samueldmq | Add database migration for project tags | 15:19 |
samueldmq | Add JSON schema validation for project tags | 15:19 |
samueldmq | gagehugo: are these all ^ ? | 15:19 |
gagehugo | yes | 15:19 |
gagehugo | other than the KSC | 15:19 |
openstackgerrit | Eric Fried proposed openstack/keystoneauth master: Make discover._version_between more lenient https://review.openstack.org/485827 | 15:20 |
gagehugo | https://review.openstack.org/#/c/485344/ | 15:20 |
gagehugo | ^ that too is blocking the main patch | 15:20 |
gagehugo | with tempest | 15:20 |
*** chlong_ has joined #openstack-keystone | 15:21 | |
samueldmq | gagehugo: nice. looks like I have everything I need to start reviewing | 15:22 |
samueldmq | thanks | 15:22 |
*** chlong has quit IRC | 15:24 | |
openstackgerrit | Merged openstack/keystonemiddleware master: Enable sphinx todo extension https://review.openstack.org/484415 | 15:26 |
openstackgerrit | Merged openstack/keystone master: Optional request parameters should be not required https://review.openstack.org/485416 | 15:30 |
*** rcernin has quit IRC | 15:34 | |
*** wasmum has quit IRC | 15:36 | |
*** wasmum has joined #openstack-keystone | 15:39 | |
openstackgerrit | Merged openstack/keystone master: Add a hacking rule for string interpolation at logging https://review.openstack.org/484250 | 15:39 |
openstackgerrit | Merged openstack/keystone master: Fix wording of configuration help text https://review.openstack.org/485760 | 15:39 |
samueldmq | gagehugo: posted a couple of initial comments/questions to that review | 15:39 |
gagehugo | samueldmq thanks! I'll take a look | 15:40 |
samueldmq | gagehugo: sure. hopefully we will get that ready for landing soon | 15:40 |
samueldmq | thanks for working on that | 15:40 |
*** lwanderley has joined #openstack-keystone | 15:44 | |
*** lwanderley has quit IRC | 15:55 | |
*** lwanderley has joined #openstack-keystone | 15:55 | |
*** rmascena is now known as raildo | 15:56 | |
*** nicolasbock has quit IRC | 15:57 | |
*** rcernin has joined #openstack-keystone | 15:58 | |
*** jmlowe_ has quit IRC | 15:59 | |
openstackgerrit | Merged openstack/keystone master: Enable sphinx todo extension https://review.openstack.org/484411 | 16:00 |
*** aojea has quit IRC | 16:03 | |
*** lwanderley has quit IRC | 16:04 | |
*** aojea has joined #openstack-keystone | 16:12 | |
*** chlong__ has joined #openstack-keystone | 16:13 | |
*** chlong_ has quit IRC | 16:13 | |
openstackgerrit | Jaewoo Park proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 16:15 |
*** lwanderley has joined #openstack-keystone | 16:16 | |
*** aojea has quit IRC | 16:17 | |
*** lwanderley has quit IRC | 16:19 | |
*** aojea has joined #openstack-keystone | 16:21 | |
*** lwanderley has joined #openstack-keystone | 16:24 | |
*** aojea has quit IRC | 16:26 | |
*** aojea has joined #openstack-keystone | 16:31 | |
*** aojea has quit IRC | 16:36 | |
*** aojea has joined #openstack-keystone | 16:40 | |
*** chlong_ has joined #openstack-keystone | 16:40 | |
*** chlong__ has quit IRC | 16:41 | |
*** aojea has quit IRC | 16:44 | |
dims | lbragstad : around? need a quick check of "GET /v3/auth/tokens" API | 16:50 |
dims | (or anyone else who knows is fine too :) | 16:50 |
lbragstad | dims: yep | 16:50 |
dims | does X-Auth-Token need to have some kind of admin privs? | 16:51 |
dims | "A valid authentication token for an administrative user." - i see that in https://developer.openstack.org/api-ref/identity/v3/?expanded=validate-and-show-information-for-token-detail,password-authentication-with-unscoped-authorization-detail,token-authentication-with-explicit-unscoped-authorization-detail#validate-and-show-information-for-token | 16:52 |
dims | api-ref does not seem to show that - http://git.openstack.org/cgit/openstack/keystone/tree/api-ref/source/v3/authenticate-v3.inc#n437 | 16:52 |
lbragstad | dims: no not necessarily | 16:54 |
lbragstad | if you generate a token regardless of the roles on that token you can use it to validate itself | 16:55 |
dims | seems like i can do a curl using the "demo" devstack account and that works just fine | 16:55 |
lbragstad | in order to validate other tokens, you need to be administrative | 16:55 |
lbragstad | so - i as a user without administrative rights can't validate a token i steal from you | 16:55 |
jlvillal | morgan: Any plans to update the 'positional' library to remove the deprecation warning? | 16:56 |
jlvillal | python3.5/site-packages/positional/__init__.py:74: DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() instead | 16:56 |
jlvillal | spec = inspect.getargspec(func) | 16:56 |
lbragstad | dims: that is enforced by https://github.com/openstack/keystone/blob/7c3acf34fada67fd86442c1882954e903a335fd0/keystone/common/policies/token.py#L26 | 16:57 |
lbragstad | dims: https://github.com/openstack/keystone/blob/7c3acf34fada67fd86442c1882954e903a335fd0/keystone/common/policies/base.py#L29 | 16:57 |
*** lwanderley has quit IRC | 16:57 | |
lbragstad | which allows admins to validate tokens for other users in the system *or* for a user to validate their own token | 16:58 |
dims | perfect. i wanted to make sure "whoami" scenario is supported thanks lbragstad | 17:02 |
lbragstad | dims: no problem | 17:02 |
dims | lbragstad : will be using it in k8s - https://github.com/dims/kubernetes/commit/9780fb65d63a5b6a98fdfea5e0c9ab82f089950e | 17:02 |
lbragstad | oh - nice | 17:03 |
*** chlong_ has quit IRC | 17:08 | |
*** harlowja has joined #openstack-keystone | 17:09 | |
*** chlong_ has joined #openstack-keystone | 17:10 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 17:17 |
*** jmlowe has joined #openstack-keystone | 17:22 | |
*** jmlowe has quit IRC | 17:22 | |
*** jmlowe has joined #openstack-keystone | 17:25 | |
*** jmlowe has quit IRC | 17:26 | |
*** jmlowe has joined #openstack-keystone | 17:29 | |
*** jmlowe has quit IRC | 17:31 | |
*** otleimat has joined #openstack-keystone | 17:31 | |
*** jmlowe has joined #openstack-keystone | 17:31 | |
*** thorst_ has quit IRC | 17:38 | |
*** thorst has joined #openstack-keystone | 17:44 | |
*** thorst has quit IRC | 17:49 | |
*** mvk has quit IRC | 17:52 | |
*** wasmum has quit IRC | 18:09 | |
*** wasmum has joined #openstack-keystone | 18:10 | |
*** thorst has joined #openstack-keystone | 18:12 | |
*** rcernin has quit IRC | 18:16 | |
*** wasmum has quit IRC | 18:41 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 18:42 |
*** wasmum has joined #openstack-keystone | 18:43 | |
openstackgerrit | prashkre proposed openstack/keystone master: Filter users and groups in ldap https://review.openstack.org/485302 | 18:48 |
morgan | jlvillal: I had not seen it, happy to take a pr for that fix. | 19:08 |
morgan | jlvillal: I can look at it (or jamielennox can) in a few days. | 19:08 |
*** ducttape_ has quit IRC | 19:14 | |
*** thorst is now known as thorst_afk | 19:15 | |
*** ducttape_ has joined #openstack-keystone | 19:16 | |
*** ducttape_ has quit IRC | 19:19 | |
*** ducttape_ has joined #openstack-keystone | 19:19 | |
*** ducttape_ has quit IRC | 19:24 | |
*** ducttape_ has joined #openstack-keystone | 19:35 | |
jlvillal | morgan: Thanks. I did create a github issue for it: https://github.com/morganfainberg/positional/issues/24 | 19:35 |
openstackgerrit | prashkre proposed openstack/keystone master: Filter users and groups in ldap https://review.openstack.org/485302 | 19:36 |
morgan | Ty | 19:44 |
*** prashkre has joined #openstack-keystone | 19:50 | |
lbragstad | edmondsw: do you have any theories on why https://review.openstack.org/#/c/485818/4 is failing? | 19:55 |
edmondsw | let me look | 19:55 |
lbragstad | how removing a v3 policy breaks a v2.0 API completely blows my mind | 19:55 |
lbragstad | i've spent most of today trying to recreate it - i can't | 19:56 |
*** raildo has quit IRC | 19:56 | |
edmondsw | yeah, that's very odd | 19:57 |
lbragstad | the weird part is that the users actually changes their password using v2.0 | 19:58 |
lbragstad | but they go to authenticate with the new password and it fails | 19:58 |
* knikolla looking also | 19:59 | |
knikolla | so the first error is on update password. so the password doesn't get changed. | 19:59 |
lbragstad | i ran the test locally with tempest but it passes when i have the config right | 19:59 |
knikolla | that explains the 401. | 19:59 |
* knikolla needs more coffee | 20:01 | |
lbragstad | at this point https://github.com/openstack/tempest/blob/ae90da579661f408444cba2c8fb87407c98f42da/tempest/api/identity/v2/test_users.py#L48-L50 | 20:02 |
lbragstad | the user should be able to authenticate with their new password | 20:02 |
lbragstad | but apparently that's not true http://logs.openstack.org/18/485818/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4906f8d/console.html#_2017-07-22_20_55_24_976185 | 20:02 |
edmondsw | lbragstad this doesn't seem right... https://github.com/openstack/tempest/blob/ae90da579661f408444cba2c8fb87407c98f42da/tempest/api/identity/v2/test_users.py#L94-L97 | 20:06 |
edmondsw | shouldn't the old token still work? | 20:06 |
lbragstad | edmondsw: well - a revocation event will be persisted because the password used to get that token has changed | 20:06 |
edmondsw | and looks like it worked here: http://logs.openstack.org/18/485818/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4906f8d/console.html#_2017-07-22_20_55_24_977455 | 20:06 |
lbragstad | so the original token should match that revocation event | 20:07 |
knikolla | might be related to this? https://bugs.launchpad.net/keystone/+bug/1703917 | 20:07 |
openstack | Launchpad bug 1703917 in OpenStack Identity (keystone) "Sometimes test_update_user_password fails with Unauthorized" [Medium,Triaged] | 20:07 |
knikolla | thought the logs there have the v3 api | 20:07 |
knikolla | though* | 20:07 |
edmondsw | I wish that log had request ids... | 20:07 |
lbragstad | edmondsw: that last link you sent | 20:08 |
lbragstad | edmondsw: that's the response of the v2.0 change password api | 20:08 |
lbragstad | not an authentication response | 20:08 |
lbragstad | https://github.com/openstack/keystone/blob/7c3acf34fada67fd86442c1882954e903a335fd0/keystone/v2_crud/user_crud.py#L106 | 20:09 |
*** aojea has joined #openstack-keystone | 20:09 | |
edmondsw | oh, I thought it was the following auth attempt, my bad | 20:09 |
lbragstad | edmondsw: yeah - it's weird | 20:09 |
edmondsw | lbragstad so here we change the password from E7... to J5... http://logs.openstack.org/18/485818/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4906f8d/console.html#_2017-07-22_20_55_24_976463 | 20:10 |
lbragstad | yep | 20:10 |
lbragstad | which comes into here | 20:10 |
lbragstad | https://github.com/openstack/keystone/blob/7c3acf34fada67fd86442c1882954e903a335fd0/keystone/v2_crud/user_crud.py#L52 | 20:10 |
edmondsw | but then when we go to change it back, instead of changing it to E7... we change it to F3... ? http://logs.openstack.org/18/485818/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4906f8d/console.html#_2017-07-22_20_55_24_977972 | 20:10 |
lbragstad | oh - that's weird | 20:11 |
knikolla | because of compliance… need to be unique within n last passwords | 20:12 |
lbragstad | yeah | 20:13 |
lbragstad | https://github.com/openstack/tempest/blob/ae90da579661f408444cba2c8fb87407c98f42da/tempest/api/identity/v2/test_users.py#L61-L65 | 20:13 |
*** aojea has quit IRC | 20:13 | |
edmondsw | lbragstad the 404 must mean the user is NotFound? | 20:13 |
edmondsw | well, says "Failed to validate token"... so that's weird but makes more sense | 20:14 |
lbragstad | yeah | 20:14 |
lbragstad | that 404 is also coming from the _restore_password method | 20:15 |
lbragstad | which might not be functioning properly if the previous auth didn't work? | 20:15 |
* efried sheepishly asks if we've tried it with ksa2 | 20:17 | |
knikolla | lbragstad: isn't that the output of the assertraises? | 20:17 |
*** aojea has joined #openstack-keystone | 20:18 | |
knikolla | so everything is fine including the 401. | 20:18 |
knikolla | but the next password change fails. | 20:18 |
knikolla | cause otherwise the tempest test would have stopped and failed at the 401 | 20:18 |
knikolla | rather than 404 | 20:18 |
lbragstad | well - the 401 is coming from https://github.com/openstack/tempest/blob/ae90da579661f408444cba2c8fb87407c98f42da/tempest/api/identity/v2/test_users.py#L48-L50 | 20:19 |
knikolla | hmm… right | 20:20 |
lbragstad | at that point - the test has failed which kicks off the cleanup actions | 20:20 |
knikolla | i see | 20:21 |
lbragstad | at least if i'm reading http://logs.openstack.org/18/485818/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4906f8d/console.html#_2017-07-22_20_55_24_975935 right | 20:21 |
knikolla | has the password been changed at that point? | 20:21 |
knikolla | cause if so. the code wouldn't reach this point https://github.com/openstack/tempest/blob/ae90da579661f408444cba2c8fb87407c98f42da/tempest/api/identity/v2/test_users.py#L54 | 20:21 |
knikolla | therefore having the old password in the credentials | 20:21 |
lbragstad | yeah - it should have changed | 20:22 |
lbragstad | http://logs.openstack.org/18/485818/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4906f8d/logs/screen-keystone.txt.gz#_Jul_22_20_32_54_585883 | 20:22 |
lbragstad | at least according to ^ | 20:22 |
*** aojea has quit IRC | 20:22 | |
lbragstad | which is here - https://github.com/openstack/keystone/blob/7c3acf34fada67fd86442c1882954e903a335fd0/keystone/v2_crud/user_crud.py#L106 | 20:22 |
lbragstad | and we've already reset the password after normalizing the data https://github.com/openstack/keystone/blob/7c3acf34fada67fd86442c1882954e903a335fd0/keystone/v2_crud/user_crud.py#L84-L86 | 20:23 |
lbragstad | then again - i have absolutely no idea how this is popping up on a v3 policy change. | 20:26 |
knikolla | https://bugs.launchpad.net/keystone/+bug/1703917 makes me think it's a transient failure | 20:28 |
openstack | Launchpad bug 1703917 in OpenStack Identity (keystone) "Sometimes test_update_user_password fails with Unauthorized" [Medium,Triaged] | 20:28 |
knikolla | so might not be related to the change | 20:28 |
lbragstad | knikolla: that's a possibility | 20:29 |
lbragstad | the more i dig into this - the more i don't think it's a keystone bug | 20:30 |
knikolla | i was able to reproduce a similar bug by running that single tempest test on a loop until it failed https://bugs.launchpad.net/keystone/+bug/1702211 | 20:31 |
openstack | Launchpad bug 1702211 in OpenStack Identity (keystone) "test_password_history_not_enforced_in_admin_reset failed in tempest test" [Undecided,Confirmed] | 20:31 |
knikolla | probably worth trying the same thing on master as see if we hit that failure with no changes | 20:31 |
knikolla | and* | 20:31 |
lbragstad | yeah | 20:31 |
lbragstad | i wonder if it something with how the clients are setup | 20:32 |
knikolla | that's what i'm thinking too | 20:32 |
openstackgerrit | Gage Hugo proposed openstack/keystone master: WIP: Add new tags attribute to project https://review.openstack.org/470317 | 20:32 |
knikolla | or rather how the clients cope with password changes | 20:33 |
gagehugo | knikolla same with the reproducing | 20:33 |
lbragstad | this is where my knowledge of tempest gets a little fuzzy | 20:33 |
knikolla | random failures are always fun stuff | 20:34 |
lbragstad | but i wonder if the same client is getting used across multiple test classes | 20:34 |
knikolla | maybe that rare case where two password changing tests run at the same time | 20:34 |
knikolla | if so | 20:34 |
lbragstad | right - which seems crazy unlikely | 20:35 |
lbragstad | but... | 20:35 |
knikolla | also don't think it's true. | 20:35 |
knikolla | as i was able to reproduce the second failure i linked on a single test | 20:35 |
knikolla | running repeatedly | 20:35 |
knikolla | and serially. | 20:35 |
lbragstad | oh - sure | 20:35 |
*** aojea has joined #openstack-keystone | 20:45 | |
*** ducttap__ has joined #openstack-keystone | 20:46 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove policy for self-service password changes https://review.openstack.org/485818 | 20:46 |
lbragstad | cc knikolla ^ | 20:46 |
lbragstad | added a depends on to see if we can get some more logging | 20:47 |
knikolla | lbragstad: good idea | 20:48 |
knikolla | i'm digging into tempest | 20:48 |
knikolla | it's an interesting onion of abstractions | 20:48 |
lbragstad | knikolla: cool - if you end up recreating that transient i'd be curious to know what that log says | 20:48 |
*** aojea has quit IRC | 20:50 | |
*** ducttape_ has quit IRC | 20:50 | |
*** lwanderley has joined #openstack-keystone | 20:56 | |
*** aojea has joined #openstack-keystone | 21:03 | |
lbragstad | knikolla: whenever i get it to fail locally i get this instead of a 401 http://paste.openstack.org/show/616354/ | 21:03 |
*** edmondsw has quit IRC | 21:04 | |
*** edmondsw has joined #openstack-keystone | 21:04 | |
knikolla | lbragstad: interesting. | 21:05 |
*** edmondsw_ has joined #openstack-keystone | 21:05 | |
lbragstad | i can't seem to get it to give me a 401 | 21:06 |
knikolla | let's see if the latest patchset still fails | 21:06 |
knikolla | might be something specific to the way devstack-gate configures things | 21:07 |
*** lwanderley has quit IRC | 21:08 | |
*** edmondsw has quit IRC | 21:09 | |
*** aojea has quit IRC | 21:09 | |
*** edmondsw_ has quit IRC | 21:10 | |
*** lwanderley has joined #openstack-keystone | 21:11 | |
*** jmlowe has quit IRC | 21:11 | |
prashkre | lbragstad: could you please help me on the release notes issue w.r.t https://review.openstack.org/#/c/485302/ | 21:11 |
lbragstad | prashkre: yeah - i can take a look | 21:12 |
prashkre | I see it is failing in some invocation error. | 21:12 |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add new tags attribute to project https://review.openstack.org/470317 | 21:14 |
*** lwanderley has quit IRC | 21:20 | |
*** lwanderley has joined #openstack-keystone | 21:20 | |
*** aojea has joined #openstack-keystone | 21:21 | |
*** prashkre has quit IRC | 21:22 | |
*** aojea has quit IRC | 21:26 | |
*** mvk has joined #openstack-keystone | 21:28 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add new tags attribute to project https://review.openstack.org/470317 | 21:34 |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add JSON schema validation for project tags https://review.openstack.org/484483 | 21:34 |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add database migration for project tags https://review.openstack.org/484456 | 21:34 |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add policy for project tags https://review.openstack.org/486757 | 21:34 |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Record the discovered major api version https://review.openstack.org/486506 | 21:37 |
*** edmondsw has joined #openstack-keystone | 21:39 | |
*** aojea has joined #openstack-keystone | 21:40 | |
mordred | efried: ^^ updated that - I can't find a good thing to assert in the previous patch - the requests_mock request blows up if the / is wrong, but the endpoint_data results aren't really super useful to assert on ... | 21:42 |
mordred | efried: maybe need to look at calls... | 21:42 |
*** edmondsw has quit IRC | 21:44 | |
*** aojea has quit IRC | 21:44 | |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Record the discovered major api version https://review.openstack.org/486506 | 21:46 |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add tests to specifically test trailing slash behavior https://review.openstack.org/486355 | 21:46 |
*** jmlowe has joined #openstack-keystone | 21:49 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add new tags attribute to project https://review.openstack.org/470317 | 21:52 |
*** ducttape_ has joined #openstack-keystone | 22:06 | |
*** aojea has joined #openstack-keystone | 22:07 | |
*** ducttap__ has quit IRC | 22:09 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add missing comma to json sample https://review.openstack.org/486780 | 22:10 |
*** aojea has quit IRC | 22:12 | |
*** lwanderley has quit IRC | 22:21 | |
openstackgerrit | Jaewoo Park proposed openstack/keystone master: Add new tags attribute to project https://review.openstack.org/470317 | 22:27 |
*** ducttape_ has quit IRC | 22:36 | |
*** lwanderley has joined #openstack-keystone | 22:39 | |
lbragstad | asettle: curious if you have input on https://bugs.launchpad.net/keystone/+bug/1587777 ? | 22:41 |
openstack | Launchpad bug 1587777 in OpenStack Identity (keystone) "Mitaka: dashboard performance" [Undecided,New] | 22:41 |
*** ducttape_ has joined #openstack-keystone | 22:47 | |
*** ducttape_ has quit IRC | 22:51 | |
*** ducttape_ has joined #openstack-keystone | 22:51 | |
*** ducttape_ has quit IRC | 23:02 | |
*** ducttape_ has joined #openstack-keystone | 23:11 | |
*** ducttape_ has quit IRC | 23:12 | |
*** ducttape_ has joined #openstack-keystone | 23:16 | |
*** aojea has joined #openstack-keystone | 23:20 | |
*** catintheroof has quit IRC | 23:21 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Prep for is_admin_project for scoped operations https://review.openstack.org/462670 | 23:23 |
*** aojea has quit IRC | 23:24 | |
*** lwanderley has quit IRC | 23:26 | |
*** aojea has joined #openstack-keystone | 23:29 | |
*** lwanderley has joined #openstack-keystone | 23:30 | |
*** aojea has quit IRC | 23:33 | |
*** lwanderley has quit IRC | 23:34 | |
*** chlong__ has joined #openstack-keystone | 23:36 | |
*** lwanderley has joined #openstack-keystone | 23:37 | |
*** chlong_ has quit IRC | 23:37 | |
*** aojea has joined #openstack-keystone | 23:38 | |
*** aojea has quit IRC | 23:42 | |
openstackgerrit | Nicolas Helgeson proposed openstack/keystone master: Add new tags attribute to project https://review.openstack.org/470317 | 23:48 |
*** lwanderley has quit IRC | 23:48 | |
*** lwanderley has joined #openstack-keystone | 23:50 | |
*** sjain has joined #openstack-keystone | 23:55 | |
openstackgerrit | Samriddhi proposed openstack/keystone master: Improve docs about token persistence drivers https://review.openstack.org/476384 | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!