| *** andreykurilin has joined #openstack-keystone | 00:00 | |
| *** timss has joined #openstack-keystone | 00:00 | |
| *** slunkad has joined #openstack-keystone | 00:00 | |
| *** szaher has joined #openstack-keystone | 00:00 | |
| *** charz has joined #openstack-keystone | 00:00 | |
| *** jidar has joined #openstack-keystone | 00:00 | |
| *** mtreinish has joined #openstack-keystone | 00:00 | |
| *** sasaniak has joined #openstack-keystone | 00:00 | |
| *** jaosorior has joined #openstack-keystone | 00:00 | |
| *** Dave has joined #openstack-keystone | 00:00 | |
| *** rha has joined #openstack-keystone | 00:00 | |
| *** zzzeek has joined #openstack-keystone | 00:00 | |
| *** openstackgerrit has joined #openstack-keystone | 00:00 | |
| *** gyee has joined #openstack-keystone | 00:00 | |
| *** jamespage has joined #openstack-keystone | 00:00 | |
| *** kmalloc has joined #openstack-keystone | 00:00 | |
| *** flwang has joined #openstack-keystone | 00:00 | |
| *** mordred has joined #openstack-keystone | 00:00 | |
| *** wasmum has joined #openstack-keystone | 00:00 | |
| *** dtroyer has joined #openstack-keystone | 00:00 | |
| *** afazekas has joined #openstack-keystone | 00:00 | |
| *** kfox1111 has joined #openstack-keystone | 00:00 | |
| *** ducttape_ has joined #openstack-keystone | 00:00 | |
| *** jmlowe has joined #openstack-keystone | 00:00 | |
| *** d0ugal has joined #openstack-keystone | 00:00 | |
| *** rybridges has joined #openstack-keystone | 00:00 | |
| *** chlong_ has joined #openstack-keystone | 00:00 | |
| *** david-lyle has joined #openstack-keystone | 00:00 | |
| *** otleimat has joined #openstack-keystone | 00:00 | |
| *** aselius has joined #openstack-keystone | 00:00 | |
| *** clenimar has joined #openstack-keystone | 00:00 | |
| *** flaper87 has joined #openstack-keystone | 00:00 | |
| *** hoonetorg has joined #openstack-keystone | 00:00 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 00:00 | |
| *** sapd has joined #openstack-keystone | 00:00 | |
| *** mattoliverau has joined #openstack-keystone | 00:00 | |
| *** jrist has joined #openstack-keystone | 00:00 | |
| *** davechen has joined #openstack-keystone | 00:00 | |
| *** ebbex has joined #openstack-keystone | 00:00 | |
| *** efried_zzz has joined #openstack-keystone | 00:00 | |
| *** josecastroleon has joined #openstack-keystone | 00:00 | |
| *** jistr|off has joined #openstack-keystone | 00:00 | |
| *** lifeless_ has joined #openstack-keystone | 00:00 | |
| *** ppiela_ has joined #openstack-keystone | 00:00 | |
| *** portdirect has joined #openstack-keystone | 00:00 | |
| *** nkinder has joined #openstack-keystone | 00:00 | |
| *** junbo has joined #openstack-keystone | 00:00 | |
| *** adriant has joined #openstack-keystone | 00:00 | |
| *** Adri2000 has joined #openstack-keystone | 00:00 | |
| *** iurygregory has joined #openstack-keystone | 00:00 | |
| *** DinaBelova has joined #openstack-keystone | 00:00 | |
| *** ianw has joined #openstack-keystone | 00:00 | |
| *** odyssey4me has joined #openstack-keystone | 00:00 | |
| *** rodrigods has joined #openstack-keystone | 00:00 | |
| *** asettle has joined #openstack-keystone | 00:00 | |
| *** dutsmoc has joined #openstack-keystone | 00:00 | |
| *** cloudnull has joined #openstack-keystone | 00:00 | |
| *** mfisch` has joined #openstack-keystone | 00:00 | |
| *** htruta` has joined #openstack-keystone | 00:00 | |
| *** Nakato has joined #openstack-keystone | 00:00 | |
| *** bigjools has joined #openstack-keystone | 00:00 | |
| *** oomichi has joined #openstack-keystone | 00:00 | |
| *** masber has joined #openstack-keystone | 00:00 | |
| *** dims has joined #openstack-keystone | 00:00 | |
| *** robcresswell has joined #openstack-keystone | 00:00 | |
| *** kaisers2 has joined #openstack-keystone | 00:00 | |
| *** zeus has joined #openstack-keystone | 00:00 | |
| *** clarkb has joined #openstack-keystone | 00:00 | |
| *** rarora has joined #openstack-keystone | 00:00 | |
| *** eglute has joined #openstack-keystone | 00:00 | |
| *** d34dh0r53 has joined #openstack-keystone | 00:00 | |
| *** rvba has joined #openstack-keystone | 00:00 | |
| *** brad[] has joined #openstack-keystone | 00:00 | |
| *** jdennis has joined #openstack-keystone | 00:00 | |
| *** baffle has joined #openstack-keystone | 00:00 | |
| *** med_ has joined #openstack-keystone | 00:00 | |
| *** jmccrory has joined #openstack-keystone | 00:00 | |
| *** BlackDex has joined #openstack-keystone | 00:00 | |
| *** timothyb89 has joined #openstack-keystone | 00:00 | |
| *** obre has joined #openstack-keystone | 00:00 | |
| *** jamielennox has joined #openstack-keystone | 00:00 | |
| *** tristanC has joined #openstack-keystone | 00:00 | |
| *** timburke has joined #openstack-keystone | 00:00 | |
| *** andreaf has joined #openstack-keystone | 00:00 | |
| *** cburgess has joined #openstack-keystone | 00:00 | |
| *** Trident has joined #openstack-keystone | 00:00 | |
| *** Adobeman has joined #openstack-keystone | 00:00 | |
| *** breton has joined #openstack-keystone | 00:00 | |
| *** alex_xu has joined #openstack-keystone | 00:00 | |
| *** diablo_rojo_phon has joined #openstack-keystone | 00:00 | |
| *** mancdaz has joined #openstack-keystone | 00:00 | |
| *** freerunner has joined #openstack-keystone | 00:00 | |
| *** samueldmq has joined #openstack-keystone | 00:00 | |
| *** knikolla has joined #openstack-keystone | 00:00 | |
| *** cmurphy has joined #openstack-keystone | 00:00 | |
| *** toddnni has joined #openstack-keystone | 00:00 | |
| *** dgonzalez has joined #openstack-keystone | 00:00 | |
| *** melwitt has joined #openstack-keystone | 00:00 | |
| *** hrybacki has joined #openstack-keystone | 00:00 | |
| *** kairat has joined #openstack-keystone | 00:00 | |
| *** vaishali has joined #openstack-keystone | 00:00 | |
| *** basilAB has joined #openstack-keystone | 00:00 | |
| *** johnthetubaguy has joined #openstack-keystone | 00:00 | |
| *** lamt has joined #openstack-keystone | 00:00 | |
| *** andymccr has joined #openstack-keystone | 00:00 | |
| *** NikitaKonovalov has joined #openstack-keystone | 00:00 | |
| *** peterstac has joined #openstack-keystone | 00:00 | |
| *** dougshelley66 has joined #openstack-keystone | 00:00 | |
| *** mrhillsman has joined #openstack-keystone | 00:00 | |
| *** mgagne has joined #openstack-keystone | 00:00 | |
| *** EmilienM has joined #openstack-keystone | 00:00 | |
| *** akrzos has joined #openstack-keystone | 00:00 | |
| *** gus has joined #openstack-keystone | 00:00 | |
| *** zigo has joined #openstack-keystone | 00:00 | |
| *** fungi has joined #openstack-keystone | 00:00 | |
| *** dstanek has joined #openstack-keystone | 00:00 | |
| *** kencjohnston_ has joined #openstack-keystone | 00:00 | |
| *** bradjones has joined #openstack-keystone | 00:00 | |
| *** Tahvok has joined #openstack-keystone | 00:00 | |
| *** matteus has joined #openstack-keystone | 00:00 | |
| *** evrardjp has joined #openstack-keystone | 00:00 | |
| *** wolsen has joined #openstack-keystone | 00:00 | |
| *** chris_hultin|AWA has joined #openstack-keystone | 00:00 | |
| *** ayoung has joined #openstack-keystone | 00:00 | |
| *** gus has quit IRC | 00:00 | |
| *** ChanServ has joined #openstack-keystone | 00:00 | |
| *** tepper.freenode.net sets mode: +o ChanServ | 00:00 | |
| *** markvoelker has quit IRC | 00:01 | |
| *** dulek has joined #openstack-keystone | 00:03 | |
| *** kmalloc is now known as Guest11213 | 00:03 | |
| *** clayton has joined #openstack-keystone | 00:04 | |
| *** tobberydberg has joined #openstack-keystone | 00:04 | |
| *** rm_work has joined #openstack-keystone | 00:04 | |
| *** john5223 has joined #openstack-keystone | 00:05 | |
| *** stevemar has joined #openstack-keystone | 00:06 | |
| *** hemna has joined #openstack-keystone | 00:07 | |
| *** tobberydberg has quit IRC | 00:08 | |
| *** tobberydberg has joined #openstack-keystone | 00:09 | |
| *** markvoelker has joined #openstack-keystone | 00:10 | |
| *** tobberyd_ has joined #openstack-keystone | 00:11 | |
| *** tobberydberg has quit IRC | 00:14 | |
| *** catintheroof has joined #openstack-keystone | 00:15 | |
| *** tobberyd_ has quit IRC | 00:15 | |
| *** thorst has joined #openstack-keystone | 00:16 | |
| *** tobberydberg has joined #openstack-keystone | 00:23 | |
| *** tobberyd_ has joined #openstack-keystone | 00:26 | |
| *** tobberydberg has quit IRC | 00:28 | |
| *** tobberyd_ has quit IRC | 00:31 | |
| *** catintheroof has quit IRC | 00:48 | |
| *** zhurong has joined #openstack-keystone | 00:49 | |
| *** spzala has joined #openstack-keystone | 00:50 | |
| *** lucasxu has joined #openstack-keystone | 01:00 | |
| *** dave-mccowan has joined #openstack-keystone | 01:10 | |
| *** zzzeek has quit IRC | 01:14 | |
| *** zzzeek has joined #openstack-keystone | 01:15 | |
| *** tobberydberg has joined #openstack-keystone | 01:33 | |
| *** tobberyd_ has joined #openstack-keystone | 01:35 | |
| *** tobberydberg has quit IRC | 01:37 | |
| *** tobberyd_ has quit IRC | 01:37 | |
| *** tobberydberg has joined #openstack-keystone | 01:37 | |
| *** Shunli has joined #openstack-keystone | 01:37 | |
| *** tobberydberg has quit IRC | 01:42 | |
| *** tobberydberg has joined #openstack-keystone | 01:44 | |
| *** zxy has joined #openstack-keystone | 01:45 | |
| *** tobberydberg has quit IRC | 01:48 | |
| *** zsli_ has joined #openstack-keystone | 01:49 | |
| *** Shunli has quit IRC | 01:52 | |
| *** otleimat has quit IRC | 01:56 | |
| *** lucasxu has quit IRC | 01:56 | |
| *** thorst has quit IRC | 01:59 | |
| *** aselius has quit IRC | 02:04 | |
| *** chlong_ has quit IRC | 02:12 | |
| *** lucasxu has joined #openstack-keystone | 02:27 | |
| *** tobberydberg has joined #openstack-keystone | 02:28 | |
| *** tobberyd_ has joined #openstack-keystone | 02:32 | |
| *** tobberydberg has quit IRC | 02:33 | |
| *** tobberyd_ has quit IRC | 02:37 | |
| *** tobberydberg has joined #openstack-keystone | 02:46 | |
| openstackgerrit | zhiguo.li proposed openstack/keystone master: Add the step to create a domain https://review.openstack.org/493729 | 02:49 |
|---|---|---|
| *** tobberydberg has quit IRC | 02:51 | |
| openstackgerrit | zhiguo.li proposed openstack/keystone master: Add the step to create a domain https://review.openstack.org/493729 | 02:52 |
| *** tobberydberg has joined #openstack-keystone | 02:53 | |
| *** gus has joined #openstack-keystone | 02:54 | |
| *** zsli_ is now known as Shunli | 03:01 | |
| *** tobberydberg has quit IRC | 03:04 | |
| *** dave-mccowan has quit IRC | 03:15 | |
| *** spzala has quit IRC | 03:20 | |
| *** links has joined #openstack-keystone | 03:34 | |
| *** rajalokan has joined #openstack-keystone | 03:37 | |
| *** Dinesh_Bhor_ has joined #openstack-keystone | 03:41 | |
| *** lucasxu has quit IRC | 03:43 | |
| *** markvoelker has quit IRC | 03:56 | |
| *** lucasxu has joined #openstack-keystone | 03:58 | |
| *** lucasxu has quit IRC | 04:03 | |
| *** d0ugal has quit IRC | 04:06 | |
| *** BlackDex has quit IRC | 04:07 | |
| *** jamielennox has quit IRC | 04:07 | |
| *** lamt has quit IRC | 04:07 | |
| *** andymccr has quit IRC | 04:07 | |
| *** BlackDex has joined #openstack-keystone | 04:08 | |
| *** lamt has joined #openstack-keystone | 04:11 | |
| *** andymccr has joined #openstack-keystone | 04:12 | |
| *** mvk_ has joined #openstack-keystone | 04:15 | |
| *** jamielennox has joined #openstack-keystone | 04:17 | |
| *** rcernin has joined #openstack-keystone | 04:19 | |
| *** d0ugal has joined #openstack-keystone | 04:20 | |
| *** tobberydberg has joined #openstack-keystone | 04:22 | |
| *** tobberydberg has quit IRC | 04:22 | |
| *** tobberydberg has joined #openstack-keystone | 04:22 | |
| *** tobberydberg has quit IRC | 04:26 | |
| openstackgerrit | zhiguo.li proposed openstack/keystone master: Add the step to create a domain https://review.openstack.org/493729 | 04:28 |
| *** gyee has quit IRC | 04:32 | |
| *** nicolasbock has joined #openstack-keystone | 04:52 | |
| *** rcernin has quit IRC | 04:52 | |
| *** nicolasbock has quit IRC | 04:59 | |
| *** Dinesh_Bhor_ has quit IRC | 05:01 | |
| *** nicolasbock has joined #openstack-keystone | 05:04 | |
| *** tobberydberg has joined #openstack-keystone | 05:21 | |
| *** tobberydberg has quit IRC | 05:25 | |
| *** tobberydberg has joined #openstack-keystone | 05:41 | |
| *** markvoelker has joined #openstack-keystone | 05:57 | |
| *** zxy has quit IRC | 06:19 | |
| *** spzala has joined #openstack-keystone | 06:20 | |
| *** spzala has quit IRC | 06:24 | |
| *** markvoelker has quit IRC | 06:30 | |
| openstackgerrit | zhengliuyang proposed openstack/keystone master: Add explain of mapping group attribute https://review.openstack.org/493765 | 06:59 |
| *** rcernin has joined #openstack-keystone | 07:01 | |
| *** thorst has joined #openstack-keystone | 07:03 | |
| *** pcaruana has joined #openstack-keystone | 07:06 | |
| *** thorst has quit IRC | 07:07 | |
| *** gus has quit IRC | 07:09 | |
| *** gus has joined #openstack-keystone | 07:09 | |
| *** aojea has joined #openstack-keystone | 07:19 | |
| *** tesseract has joined #openstack-keystone | 07:27 | |
| *** gus has quit IRC | 07:28 | |
| *** markvoelker has joined #openstack-keystone | 07:28 | |
| *** zxy has joined #openstack-keystone | 07:38 | |
| *** aojea has quit IRC | 07:38 | |
| *** markvoelker has quit IRC | 08:00 | |
| *** rajalokan1 has joined #openstack-keystone | 08:11 | |
| *** rajalokan has quit IRC | 08:13 | |
| *** rajalokan1 is now known as rajalokan | 08:13 | |
| *** sasaniak has left #openstack-keystone | 08:45 | |
| *** lifeless_ is now known as lifeless | 08:56 | |
| *** markvoelker has joined #openstack-keystone | 08:57 | |
| *** thorst has joined #openstack-keystone | 09:04 | |
| *** thorst has quit IRC | 09:08 | |
| *** zxy has quit IRC | 09:21 | |
| *** zxy has joined #openstack-keystone | 09:22 | |
| *** Shunli has quit IRC | 09:30 | |
| *** markvoelker has quit IRC | 09:31 | |
| *** aojea has joined #openstack-keystone | 09:44 | |
| *** thorst has joined #openstack-keystone | 10:05 | |
| *** edmondsw has joined #openstack-keystone | 10:06 | |
| *** thorst has quit IRC | 10:09 | |
| *** edmondsw has quit IRC | 10:10 | |
| *** spzala has joined #openstack-keystone | 10:21 | |
| *** spzala has quit IRC | 10:26 | |
| *** markvoelker has joined #openstack-keystone | 10:28 | |
| *** hyakuhei has joined #openstack-keystone | 10:43 | |
| *** hyakuhei has quit IRC | 10:43 | |
| *** hyakuhei has joined #openstack-keystone | 10:43 | |
| *** hyakuhei has quit IRC | 10:43 | |
| *** hyakuhei has joined #openstack-keystone | 10:43 | |
| *** rajalokan has quit IRC | 10:49 | |
| *** rajalokan has joined #openstack-keystone | 10:51 | |
| *** markvoelker has quit IRC | 11:00 | |
| *** zhurong has quit IRC | 11:08 | |
| *** zhurong has joined #openstack-keystone | 11:12 | |
| *** rajalokan has quit IRC | 11:16 | |
| *** rajalokan has joined #openstack-keystone | 11:18 | |
| *** thorst has joined #openstack-keystone | 11:25 | |
| *** rajalokan has quit IRC | 11:29 | |
| *** thorst has quit IRC | 11:29 | |
| *** rajalokan has joined #openstack-keystone | 11:35 | |
| *** clarkb has quit IRC | 11:52 | |
| *** dave-mccowan has joined #openstack-keystone | 11:54 | |
| *** gus has joined #openstack-keystone | 11:55 | |
| *** markvoelker has joined #openstack-keystone | 11:57 | |
| *** raildo has joined #openstack-keystone | 11:59 | |
| *** thorst has joined #openstack-keystone | 12:03 | |
| *** aojea has quit IRC | 12:17 | |
| *** clarkb has joined #openstack-keystone | 12:19 | |
| *** markvoelker has quit IRC | 12:21 | |
| *** markvoelker has joined #openstack-keystone | 12:21 | |
| *** zhurong has quit IRC | 12:27 | |
| *** edmondsw has joined #openstack-keystone | 12:46 | |
| *** catintheroof has joined #openstack-keystone | 12:53 | |
| *** rajalokan has quit IRC | 12:59 | |
| *** lucasxu has joined #openstack-keystone | 13:05 | |
| *** rajalokan has joined #openstack-keystone | 13:13 | |
| *** spzala has joined #openstack-keystone | 13:13 | |
| mordred | lbragstad, samueldmq, cmurphy, efried_zzz: heads up - I've found a bug in the version discovery | 13:19 |
| mordred | working up a fix (well, working up a description of what the bug actually is) | 13:20 |
| mordred | the issue at hand is an extra unnecessary version document fetch | 13:20 |
| mordred | so it's not *broken* per-se - but it's definitely doing an extra call we don't intend for it to do | 13:21 |
| mordred | there's also one additional thing I've got a tiny patch for- (I'm working on getting shade to consume ksa discovery atm, which is mostly going great) | 13:21 |
| samueldmq | mordred: neat | 13:22 |
| samueldmq | mordred: Did you find that issue when working in using new ksa abilities into shade? | 13:23 |
| samueldmq | I saw the tests were breaking for ab extra call in that patch... (just out of curiosity) | 13:23 |
| cmurphy | mordred: yay bugs | 13:25 |
| mordred | samueldmq: yah | 13:28 |
| *** rajalokan has quit IRC | 13:31 | |
| *** chlong_ has joined #openstack-keystone | 13:38 | |
| lbragstad | mordred: ack | 13:47 |
| *** sjain has joined #openstack-keystone | 13:57 | |
| *** links has quit IRC | 14:06 | |
| *** prashkre has joined #openstack-keystone | 14:18 | |
| *** sjain has quit IRC | 14:25 | |
| *** slunkad has quit IRC | 14:28 | |
| *** sjain has joined #openstack-keystone | 14:31 | |
| *** slunkad has joined #openstack-keystone | 14:32 | |
| *** efried_zzz is now known as efried | 14:37 | |
| efried | mordred I suspect I know the fetch you're talking about. I thought it was weird, but didn't know it was actually extraneous. | 14:38 |
| lbragstad | cmurphy: samueldmq curious to get your feedback on https://review.openstack.org/#/c/493621 and https://review.openstack.org/#/c/493259 | 14:41 |
| lbragstad | if/when you have some time | 14:41 |
| samueldmq | lbragstad: I can take a look at it today for sure (later today) | 14:42 |
| samueldmq | thanks for the heads up | 14:42 |
| lbragstad | samueldmq: thanks | 14:42 |
| cmurphy | lbragstad: can do | 14:43 |
| *** rajalokan has joined #openstack-keystone | 14:45 | |
| *** prashkre has quit IRC | 14:47 | |
| *** prashkre has joined #openstack-keystone | 14:50 | |
| *** sjain has quit IRC | 14:50 | |
| mordred | efried: well.... I've exercise every possible edgecase known to man over in shade-land | 14:51 |
| mordred | efried: but that also means I can describe the actual consumption flow that leads to it very well now :) | 14:51 |
| efried | That's a good thing. Someone oughtta understand it. Just don't get hit by a bus, eh? | 14:52 |
| mordred | yah | 14:52 |
| mordred | well - I've got three patches coming - one of them adds a new method because the specifics of this get a little silly and it's not reasonable to expect users to know all the details | 14:52 |
| *** tobberyd_ has joined #openstack-keystone | 14:53 | |
| mordred | efried: tl;dr - you use ksa+version discovery to get an adapter. now you want to know what *major* version of the api was found. because calling get_endpoint_data on an adapter implies "I want the discovery document" it fetches it - but if you only want the api version found, there are multiple common cases where discovery learned that information from the URL | 14:54 |
| mordred | efried: so when you call get_endpoint_data so you can read endpoint_data.api_version - you're implying you want more data than you do | 14:54 |
| mordred | when what you really want to know is "what major version of the api is this adapter talking to?" | 14:55 |
| mordred | so the extra-complete verison of this is to allow passing endpoint_filter kwargs through get_endpoint_data in adapter to allow someone to set discover_versions=False (or honestly anything else) ... but that's an insane interface for normal humans who are not us | 14:55 |
| mordred | tha tmay not ahve been a tl;dr | 14:56 |
| *** tobberydberg has quit IRC | 14:56 | |
| *** tobberyd_ has quit IRC | 14:57 | |
| efried | mordred I have precisely the same issue when I just want an endpoint, but can't use get_endpoint(). | 14:58 |
| mordred | efried: good. then for you the **kwargs patch will help | 14:58 |
| efried | I would love to be able to limit get_endpoint_data() to just a certain version, which may in fact mean that it doesn't go over the wire at all, because everything it needs is in the service catalog. | 14:58 |
| efried | To be fair, though, the reason I can't use get_endpoint() directly is always... bugs. | 14:59 |
| efried | whole stack of 'em. | 14:59 |
| efried | ("...in the service catalog..." or the URL itself, I suppose) | 14:59 |
| mordred | efried: we should investigate the issues with get_endpoint - I apologize for not having been more active in your consume patches so far - it's been a busy last 2 weeks | 15:01 |
| *** rcernin has quit IRC | 15:01 | |
| efried | mordred It's like you've got a day job or something. | 15:02 |
| efried | mordred Yeah, as you look through the nova code, the ratio of LOC to comments like "TODO(efried): remove once bug #xxxxxxx is fixed" is lower than I'd like :) | 15:02 |
| mordred | ugh :) | 15:03 |
| mordred | well - in other news, I did realize that part of my shade consume problem is that I was trying to be too clever and not letting ksa handle enough things for me - and the more I let it handle the logic the more things worked | 15:04 |
| mordred | so that's a good vote of confidence for theksa patches :) | 15:04 |
| mordred | (that's almost never the case otherwise) | 15:04 |
| cmurphy | \o/ | 15:05 |
| mordred | oh goodie. there's a new hacking rule we're hitting | 15:08 |
| mordred | oh. no. nevermind. that's a random file in my repo | 15:09 |
| * mordred shuts up | 15:09 | |
| *** aselius has joined #openstack-keystone | 15:13 | |
| knikolla | o/ | 15:16 |
| *** hrybacki is now known as hrybacki|mtg | 15:17 | |
| mordred | cmurphy, efried: I'm going to push the patches up without tests first (I'm testing them with shade's unit tests atm) to make sure you're ok with the approach | 15:18 |
| Guest11213 | lbragstad: the fixes for created_at_int are all working | 15:19 |
| *** Guest11213 is now known as kmalloc | 15:19 | |
| efried | mordred I'm okay with that approach. | 15:19 |
| cmurphy | mordred: mmk | 15:19 |
| *** kmalloc has joined #openstack-keystone | 15:19 | |
| kmalloc | lbragstad: sorry for being so frustrated yesterday, just chasing down DB issues has not made me happy. | 15:20 |
| gagehugo | knikolla o/ | 15:20 |
| kmalloc | mordred: git clean -fdx ; tox -epep8 :P | 15:20 |
| mordred | kmalloc: yup! :) | 15:21 |
| kmalloc | mordred: i am sad i wont get other datetime fields in keystone moved to int in pike | 15:22 |
| kmalloc | but... at least we have a template to eliminate datetime and need to normalize datetime as much | 15:22 |
| mordred | ++ | 15:22 |
| mordred | also - I need to send that email ... | 15:22 |
| kmalloc | which one? | 15:22 |
| mordred | the "we should declare a minimum mysql" | 15:22 |
| kmalloc | oh yeah | 15:23 |
| kmalloc | that one | 15:23 |
| kmalloc | please do. | 15:23 |
| kmalloc | or at least make it super clear if we already have one | 15:23 |
| kmalloc | i couldn't really find one | 15:23 |
| kmalloc | besides "what we test on" | 15:23 |
| kmalloc | which isn't good enough | 15:23 |
| *** pcaruana has quit IRC | 15:24 | |
| lbragstad | kmalloc: no worries | 15:24 |
| kmalloc | mordred: looks like i need to head to the PTG. I'll book hotel/flight/etc soon | 15:24 |
| kmalloc | mordred: =/ was hoping to get to stay home again. | 15:24 |
| kmalloc | mordred: i wont book for Sydney though, so no need to justify my travel for that. | 15:25 |
| kmalloc | since i know AUS is super spendy to get people to/from | 15:25 |
| *** akrzos is now known as akrzos-lunch | 15:26 | |
| lbragstad | kmalloc: i went ahead and added you to the etherpad | 15:27 |
| kmalloc | thanks | 15:27 |
| kmalloc | still. *sigh* I would rather not travel. | 15:27 |
| kmalloc | but it sounds like this might be important enough to do so. | 15:28 |
| *** links has joined #openstack-keystone | 15:32 | |
| *** mvk_ has quit IRC | 15:32 | |
| *** prashkre has quit IRC | 15:33 | |
| *** gyee has joined #openstack-keystone | 15:36 | |
| mordred | kmalloc: nod re: travel | 15:36 |
| mordred | kmalloc: also - fwiw, I believe we do declare and inferrable mysql minimum (although I'm writing the email and govenance patch right now so we can clarify) | 15:36 |
| mordred | kmalloc: because the PTI declares that we support latest Ubuntu LTS and latest CentOS - that means our de-facto minimum mysql supported version is mariadb 5.5 and mysql-server 5.7 | 15:37 |
| kmalloc | mordred: ++ great. i like having clear minimums | 15:37 |
| mordred | but - let's make that explicit rather than implied | 15:37 |
| kmalloc | mordred: makes it easier to ensure we have $feature$ we need. | 15:37 |
| kmalloc | yeah | 15:37 |
| kmalloc | implied = bad news because we assume something that may or may not be the case. | 15:37 |
| kmalloc | nothing really says openstack can't run on ancient mysql :P | 15:38 |
| kmalloc | except we don't test it :P | 15:38 |
| mordred | which is to sya - if you WANT to do microversion timestamps instead of int, I believe that's not super out of bounds - but given usage pattern there's actuall no benefit to datetime/timestamp columns over bigint columns, so I'd just do what you have :) | 15:39 |
| kmalloc | exactly | 15:39 |
| kmalloc | and i like that we can use bigint consistently and eventually only convert to datetime objects/strings at the controller level | 15:39 |
| *** tesseract has quit IRC | 15:44 | |
| *** tobberydberg has joined #openstack-keystone | 15:45 | |
| lbragstad | kmalloc: use bigint consistently through out the application? | 15:48 |
| *** hrybacki|mtg is now known as hrybacki | 15:49 | |
| kmalloc | lbragstad: that would be my goal | 15:49 |
| *** tobberydberg has quit IRC | 15:50 | |
| *** mvk_ has joined #openstack-keystone | 15:50 | |
| kmalloc | lbragstad: and compare int everywhere | 15:50 |
| kmalloc | only convert to isotime on REST / json | 15:50 |
| *** prashkre has joined #openstack-keystone | 15:52 | |
| *** mvk has joined #openstack-keystone | 15:55 | |
| cmurphy | lbragstad: mordred going offline for a bit but will review all the things later tonight | 15:55 |
| *** spilla has joined #openstack-keystone | 15:57 | |
| *** mvk_ has quit IRC | 15:57 | |
| mordred | kmalloc: "Declaring explicit minimum database versions" is the email thread title, https://review.openstack.org/493932 is the governance patch | 16:00 |
| kmalloc | thanks | 16:00 |
| *** links has quit IRC | 16:01 | |
| lbragstad | kmalloc: yeah - that makes sense, whether or not it's int or datetime or something else, i'd just like it to be consistent :) | 16:04 |
| lbragstad | kmalloc: testing https://review.openstack.org/#/c/493259/9 locally again | 16:04 |
| lbragstad | https://review.openstack.org/#/c/493259/9 my comments are minor - but i think it's getting close | 16:04 |
| lbragstad | kmalloc: waiting for other reviewers to weigh in on it | 16:05 |
| *** prashkre has quit IRC | 16:13 | |
| *** mvk_ has joined #openstack-keystone | 16:23 | |
| *** mvk has quit IRC | 16:26 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Add int storage of datetime for password created/expires https://review.openstack.org/493259 | 16:29 |
| lbragstad | kmalloc: addressed my comments ^ | 16:29 |
| kmalloc | cool | 16:32 |
| *** rajalokan has quit IRC | 16:39 | |
| lbragstad | taking lunch quick | 16:58 |
| *** rajalokan has joined #openstack-keystone | 17:01 | |
| *** catintheroof has quit IRC | 17:05 | |
| *** akrzos-lunch is now known as akrzos | 17:05 | |
| *** catintheroof has joined #openstack-keystone | 17:06 | |
| *** catintheroof has quit IRC | 17:10 | |
| rodrigods | lbragstad, mind revisiting https://review.openstack.org/#/c/420893/ ? | 17:25 |
| rodrigods | i think the decision is clearly to have FKs when possible | 17:25 |
| lbragstad | cc kmalloc^ | 17:30 |
| lbragstad | kmalloc: with the direction of FK becoming more of a thing - do you think we should have a session on it? | 17:31 |
| lbragstad | kmalloc: i remember dstanek having opinions on it, too | 17:31 |
| kmalloc | *shrug* | 17:31 |
| kmalloc | if we are re-aligning backends / merging them | 17:31 |
| lbragstad | maybe a hallway track discussion will suffice | 17:31 |
| kmalloc | then yes. | 17:31 |
| *** mvk_ has quit IRC | 17:32 | |
| kmalloc | i honestly think we went way too far in splitting things | 17:32 |
| kmalloc | fwiw, i think we should re-merge the roles abckend with assignment | 17:32 |
| lbragstad | that was dstanek's argument, too | 17:32 |
| *** sbezverk has joined #openstack-keystone | 17:32 | |
| kmalloc | catalog, identity, assignment, credentials | 17:32 |
| kmalloc | that should be the configurable bits | 17:32 |
| kmalloc | the rest should either be part of those *or* not configurable | 17:33 |
| lbragstad | s/catalog// | 17:33 |
| lbragstad | consul* | 17:33 |
| kmalloc | doesn't matter what the backend is we need to still provide the catalog API for query purposes | 17:33 |
| kmalloc | so, if it is consul backed, sure, fine | 17:33 |
| kmalloc | if it isn't, sure fine, but it is distinct | 17:33 |
| *** edmondsw has quit IRC | 17:35 | |
| *** thorst has quit IRC | 17:35 | |
| * kmalloc never understood why we *HAD* to split roles from assignment | 17:36 | |
| kmalloc | i know what the arguments were, it never made sense to me | 17:36 |
| lbragstad | kmalloc: that happened a long time ago - i'm not sure i was around then | 17:37 |
| *** thorst has joined #openstack-keystone | 17:37 | |
| *** szaher has quit IRC | 17:38 | |
| kmalloc | you were | 17:38 |
| kmalloc | it wasn't that long ago | 17:38 |
| kmalloc | but... it always felt like the wrong approach | 17:38 |
| kmalloc | storing the roles/role data separately from user->resource->role bits | 17:38 |
| *** lwanderley has joined #openstack-keystone | 17:39 | |
| *** thorst has quit IRC | 17:41 | |
| *** prashkre has joined #openstack-keystone | 17:41 | |
| *** thorst has joined #openstack-keystone | 17:54 | |
| *** thorst has quit IRC | 17:58 | |
| *** sjain has joined #openstack-keystone | 17:58 | |
| *** thorst has joined #openstack-keystone | 17:59 | |
| *** lwanderley has quit IRC | 18:02 | |
| *** edmondsw has joined #openstack-keystone | 18:05 | |
| *** edmondsw has quit IRC | 18:05 | |
| *** prashkre has quit IRC | 18:05 | |
| *** edmondsw has joined #openstack-keystone | 18:06 | |
| *** prashkre has joined #openstack-keystone | 18:09 | |
| *** lwanderley has joined #openstack-keystone | 18:10 | |
| *** prashkre has quit IRC | 18:10 | |
| *** leticiafw has joined #openstack-keystone | 18:16 | |
| *** lwanderley has quit IRC | 18:17 | |
| *** leticiafw is now known as lwanderley | 18:17 | |
| stevemar | o/ | 18:31 |
| stevemar | lbragstad: good news for knikolla? :) | 18:31 |
| lbragstad | stevemar: yessir | 18:32 |
| stevemar | heyooo | 18:32 |
| knikolla | stevemar: \o/ | 18:34 |
| stevemar | knikolla: welcome to club | 18:36 |
| stevemar | you are now a guardian of the ... gate? | 18:36 |
| knikolla | stevemar: galaxy? | 18:37 |
| knikolla | groot | 18:37 |
| samueldmq | knikolla: lbragstad: yes I think I was the one who convinced henrynash to work on that too | 18:42 |
| samueldmq | :-) | 18:42 |
| samueldmq | but basically the idea was that we have targets (project/domain) and actors (user/group) out of assignment, and then we did for roles too | 18:42 |
| kmalloc | and i am thinking that is very wrong | 18:42 |
| samueldmq | it's still into the same structure in code, but presented as separate things | 18:43 |
| kmalloc | we should merge role stuff back into assignment | 18:43 |
| samueldmq | if we have good reasons for it, I am not opposed | 18:43 |
| kmalloc | ease of maintaining code | 18:44 |
| kmalloc | that is a good reason in my book | 18:44 |
| cmurphy | hmm as someone who has written an out of tree assignment driver i'm kind of a fan of resources and roles being separate from assignment | 18:46 |
| samueldmq | kmalloc: that is a good reason, but I don't see that as an issue on maintaining code | 18:47 |
| samueldmq | but I might be missing some aspects of the entire discussion | 18:47 |
| kmalloc | it's a complexity thing | 18:47 |
| kmalloc | and adding more ways things can be out of keystone's control | 18:47 |
| kmalloc | it also means we can use FKs in the backend... | 18:48 |
| kmalloc | which makes life easier | 18:48 |
| kmalloc | esp. for highly-relational data | 18:48 |
| *** nicolasbock has quit IRC | 18:49 | |
| kmalloc | cores: please look at https://review.openstack.org/#/c/493259/ and https://review.openstack.org/#/c/493621/ | 18:50 |
| kmalloc | those are needed for rc | 18:50 |
| cmurphy | looking now | 18:51 |
| samueldmq | gagehugo and I are also going ot make a few tests locally | 18:51 |
| kmalloc | the SQL resource one is easy | 18:52 |
| gagehugo | yeah I'm running against it now | 18:52 |
| kmalloc | the password created_at_int one is more complex | 18:52 |
| cmurphy | kmalloc: i'm really uneasy about https://review.openstack.org/#/c/493621 | 18:53 |
| cmurphy | "since ocata" is really not that long ago | 18:53 |
| cmurphy | this could really surprise someone upgrading from newton | 18:53 |
| kmalloc | i doubt it | 18:53 |
| kmalloc | i seriously doubt anyone has ever replaced the resource backend | 18:54 |
| kmalloc | but the bigger thing is, i really don't want to backport schema fixes | 18:54 |
| kmalloc | schema fixes make me far more nervous to backport than maybe making someone unhappy | 18:55 |
| *** mjax has joined #openstack-keystone | 18:55 | |
| kmalloc | schema fixes backporting is always scary and has potential to make the schema inconsistent down the line because things go sideways | 18:55 |
| kmalloc | or even harder to debug/fix for someone who somehow missed the backport/forward fix. | 18:55 |
| kmalloc | it is likely to surprise the same potential folks as it is upgrading from newton unless they're edmondsw and don't use SQL identity for anything (even a domain-specific backend) | 18:56 |
| lbragstad | cmurphy: i had the same thought - and i sent http://lists.openstack.org/pipermail/openstack-dev/2017-August/121139.html | 18:56 |
| lbragstad | #startmeeting keystone-office-hours | 18:57 |
| openstack | Meeting started Tue Aug 15 18:57:46 2017 UTC and is due to finish in 60 minutes. The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot. | 18:57 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 18:57 |
| openstack | The meeting name has been set to 'keystone_office_hours' | 18:57 |
| cmurphy | edmondsw: you +1'd it, you're not aware of a use case for a non-sql resource backend? | 18:57 |
| kmalloc | #topic lbragstad is cool. | 18:58 |
| kmalloc | >.> | 18:58 |
| lbragstad | woo | 18:58 |
| edmondsw | cmurphy I am not... we use sql in PowerVC | 18:58 |
| kmalloc | the resource backend is so highly keystone/openstack specific it is unlikely to be replaced | 18:58 |
| kmalloc | imo | 18:58 |
| kmalloc | HPE did it sortof, but we put everything in mongo | 18:58 |
| kmalloc | which was when there were far less backend options | 18:58 |
| edmondsw | kmalloc why? | 18:59 |
| kmalloc | because someone decided mongodb was the best choice | 18:59 |
| kmalloc | i really don't know, it pre-dated me working at HPE | 18:59 |
| kmalloc | this was for the public cloud. | 18:59 |
| edmondsw | just seems silly :) | 18:59 |
| cmurphy | i could see projects being mapped to like github org memberships or some other corporate resource designator | 18:59 |
| kmalloc | and all the resource data was merged into assignment, so it was an all-or-nothing deal for resources | 18:59 |
| samueldmq | kmalloc: cmurphy I also don't understand why we aren't following the deprecation process before removing the capability of setting an non-sql backend for that | 19:00 |
| cmurphy | samueldmq: well because it doesn't work | 19:00 |
| kmalloc | at all | 19:00 |
| cmurphy | already | 19:00 |
| kmalloc | it's broken as it sits if you use identity SQL at all | 19:00 |
| cmurphy | if we'd figured it out ahead of time we could have done a normal deprecation | 19:00 |
| kmalloc | i'll plan to implement a test that explodes if there are FKs across subsystems | 19:01 |
| kmalloc | but i need to figure out the way to do that in queens | 19:01 |
| kmalloc | not in pike-rc | 19:01 |
| kmalloc | it's ... not going to be a fun test, but it'll prevent this in the future | 19:01 |
| kmalloc | and i want to do a final collapse/kill of the old migration_repo | 19:01 |
| lbragstad | kmalloc: well - your patch is allowing FKs between subsystems | 19:02 |
| kmalloc | lbragstad: the new test would prevent future cases. resource would be explicitly allowed | 19:02 |
| kmalloc | or we allow FKs between systems where possible | 19:02 |
| kmalloc | *shrug* | 19:02 |
| samueldmq | seems interesting | 19:02 |
| samueldmq | kmalloc: btw I left a comment (2) in https://review.openstack.org/#/c/493621 | 19:02 |
| samueldmq | I am confused with a comment you elft tehre | 19:02 |
| *** sbezverk has quit IRC | 19:03 | |
| *** gyee has quit IRC | 19:03 | |
| *** chlong_ has quit IRC | 19:03 | |
| *** zxy has quit IRC | 19:03 | |
| *** d0ugal has quit IRC | 19:03 | |
| *** andymccr has quit IRC | 19:03 | |
| lbragstad | the more i think about this the more i want to dedicate time at the ptg to discuss where we allow FKs and where we don't | 19:03 |
| lbragstad | but those bits kind of confuse me | 19:03 |
| *** andymccr_ has joined #openstack-keystone | 19:03 | |
| *** gyee has joined #openstack-keystone | 19:03 | |
| *** zxy has joined #openstack-keystone | 19:03 | |
| kmalloc | samueldmq: replied | 19:04 |
| *** d0ugal has joined #openstack-keystone | 19:04 | |
| *** chlong_ has joined #openstack-keystone | 19:04 | |
| kmalloc | lbragstad: basically it is simple: if you can configure non-SQL, you cannot have an FK from one sql system to it (meaning cannot go either way) | 19:04 |
| kmalloc | if you allow FKs, they will break inserts if the data isn't housed in the same DB | 19:04 |
| kmalloc | you cannot insert a user into User table now unless the domain the user belongs to is in the resource table | 19:05 |
| samueldmq | kmalloc: well, re-replied, I don't really agree. but I think that might be a separate conversation | 19:05 |
| kmalloc | samueldmq: the only reason we ever had a manager was for abstraction/pivot for backends. if there is no pivot, the manager and driver could be collapsed | 19:06 |
| samueldmq | kmalloc: the docs says different, https://github.com/openstack/keystone/blob/master/keystone/common/manager.py#L153-L162 | 19:06 |
| kmalloc | business logic between backends goes in the manager, but if the manager doesn't need to pass data through, i can avoid | 19:06 |
| samueldmq | we don't document the pivot for backends as being the only reason | 19:07 |
| kmalloc | https://github.com/openstack/keystone/blob/master/keystone/common/manager.py#L160 | 19:07 |
| kmalloc | if there is no dynamic backend, it doesn't need to pass data through | 19:07 |
| *** lwanderley has quit IRC | 19:07 | |
| samueldmq | well, resource manager is pretty complex already with all the is-domain thing and all (create_project is 40 LOC) | 19:08 |
| samueldmq | adding the specific bits to store that into SQL would make it worse | 19:08 |
| lbragstad | hrybacki: knikolla and i had a discussion yesterday about preparing a demo for the ptg on global roles | 19:08 |
| kmalloc | a lot of that could be simplified if it didn't need to pass to the backend | 19:08 |
| lbragstad | hrybacki: notes from that meeting are available here - https://etherpad.openstack.org/p/keystone-global-roles-poc | 19:08 |
| kmalloc | samueldmq: a lot of the manager code could lean directly on SQL to do the work. | 19:09 |
| samueldmq | kmalloc: ok, it's worth it a try to see if we can save maintainer time | 19:09 |
| kmalloc | samueldmq: that is my thought | 19:09 |
| samueldmq | I guess that's your point too | 19:09 |
| * samueldmq nods | 19:09 | |
| hrybacki | lbragstad: knikolla ack, looking | 19:10 |
| samueldmq | kmalloc: test_sql_upgrade.py gets executed against real sql, correct? | 19:11 |
| samueldmq | I mean, not sqlite | 19:11 |
| hrybacki | decent amount of work before PTG | 19:11 |
| lbragstad | hrybacki: yeah | 19:12 |
| lbragstad | hrybacki: i'm going to start working on item #1 this week - since i proposed the original patch/implementatin | 19:12 |
| hrybacki | but def. worthwhile. I see you have already started | 19:12 |
| lbragstad | implementation* | 19:12 |
| hrybacki | lbragstad: presently putting out a fire but will re-read the spec and look over the task breakdown so I can figure out how I may best help | 19:16 |
| lbragstad | hrybacki: ack | 19:19 |
| kmalloc | samueldmq: both | 19:20 |
| samueldmq | kmalloc: kk | 19:21 |
| *** ducttap__ has joined #openstack-keystone | 19:26 | |
| *** ducttape_ has quit IRC | 19:26 | |
| knikolla | lbragstad: https://review.openstack.org/#/c/494004/ | 19:41 |
| knikolla | ^^ removes the uwsgi job | 19:41 |
| lbragstad | knikolla: nice - thanks for proposing that | 19:41 |
| knikolla | lbragstad: fastest patch i've ever gotten merged. | 19:43 |
| lbragstad | :) | 19:43 |
| samueldmq | kmalloc: lbragstad I have one more question in https://review.openstack.org/#/c/493259 | 19:48 |
| samueldmq | inline | 19:48 |
| lbragstad | i think that comment is referencing https://review.openstack.org/#/c/493259/10/keystone/common/sql/contract_repo/versions/024_contract_create_created_at_int_columns.py | 19:50 |
| gagehugo | lbragstad speaking of the gate, did we ever decide about skipping functional tests for doc changes? https://review.openstack.org/#/c/492630/ | 19:50 |
| lbragstad | samueldmq: i asked in an earlier patch set - https://review.openstack.org/#/c/493259/7/keystone/identity/backends/sql_model.py | 19:51 |
| lbragstad | gagehugo: i think the consensus was that we should not run functional tests on doc changes to conserve resources | 19:51 |
| *** sjain has quit IRC | 19:51 | |
| knikolla | gagehugo: ++ | 19:51 |
| knikolla | i see jobs being queued a lot these days | 19:52 |
| gagehugo | it looks like other projects do have something to skip tests for just docs/api-ref/non-code | 19:52 |
| lbragstad | yeah - line 1481 | 19:52 |
| lbragstad | https://review.openstack.org/#/c/492630/4/zuul/layout.yaml | 19:53 |
| lbragstad | that's neat | 19:53 |
| *** dklyle has joined #openstack-keystone | 19:53 | |
| lbragstad | and line 1479 | 19:53 |
| *** raildo has quit IRC | 19:55 | |
| gagehugo | yeah | 19:55 |
| gagehugo | if thats ok then I can take a look at proposing something | 19:57 |
| *** david-lyle has quit IRC | 19:57 | |
| samueldmq | lbragstad: for https://review.openstack.org/#/c/493621/ | 19:59 |
| samueldmq | we wait a bit on feedback from the ML topic? | 19:59 |
| samueldmq | fyi I just approved kmalloc's change fixing bug 1702211 | 20:00 |
| openstack | bug 1702211 in OpenStack Identity (keystone) "test_password_history_not_enforced_in_admin_reset failed in tempest test" [Medium,In progress] https://launchpad.net/bugs/1702211 - Assigned to Lance Bragstad (lbragstad) | 20:00 |
| kmalloc | ok | 20:00 |
| kmalloc | i'll wait for it to merge | 20:00 |
| kmalloc | lbragstad: want me to push the stable/pike version once master merges? | 20:01 |
| lbragstad | kmalloc: yes please | 20:01 |
| kmalloc | ok done | 20:01 |
| lbragstad | kmalloc: thanks | 20:01 |
| lbragstad | samueldmq: yeah - i'd like to have operator feedback before merging it but i also realize that might be unlikely | 20:01 |
| kmalloc | lbragstad: looks like you have +2 on stable/pike | 20:02 |
| lbragstad | i saw that :) | 20:02 |
| kmalloc | lbragstad: so you can +2 the stable/pike of changed_at | 20:02 |
| samueldmq | lbragstad: well maybe just wait a bit until we're sure the gate has been 100% fixed? | 20:02 |
| lbragstad | samueldmq: the change that is gating now should fix the gate | 20:02 |
| kmalloc | samueldmq: ^ folks have run 300+ iterations locally | 20:03 |
| samueldmq | lbragstad: exactly, I fully expect it too. | 20:03 |
| kmalloc | and prior, it was hitting ~60-70 | 20:03 |
| kmalloc | without a failure | 20:03 |
| lbragstad | cmurphy: ran it up to 2500 without a failure | 20:03 |
| kmalloc | i stand corrected | 20:03 |
| kmalloc | 2000+ | 20:03 |
| kmalloc | :) | 20:03 |
| kmalloc | but... was it OVER 9000!?! | 20:03 |
| lbragstad | i ran it and walked away from my computer saturday and it ran 3500+ | 20:03 |
| samueldmq | yes, no reason for the gate to be unhappy! | 20:03 |
| * kmalloc ducks. | 20:03 | |
| lbragstad | almost | 20:03 |
| *** tobberydberg has joined #openstack-keystone | 20:04 | |
| lbragstad | also - that means there were thousands of revocation events stored in sql | 20:04 |
| lbragstad | and keystone will still running way better than it did in the past | 20:04 |
| samueldmq | lbragstad: ++ | 20:04 |
| *** mjax has quit IRC | 20:04 | |
| lbragstad | the database improvement with the revocation table work well | 20:05 |
| *** spilla has quit IRC | 20:05 | |
| samueldmq | true | 20:05 |
| samueldmq | also, well done with finding and fixing that bug quickly kmalloc and lbragstad | 20:05 |
| samueldmq | \o/ | 20:05 |
| lbragstad | that was all kmalloc | 20:05 |
| samueldmq | bugs like that in RC phase are always interesting | 20:06 |
| *** sbezverk has joined #openstack-keystone | 20:12 | |
| *** raildo has joined #openstack-keystone | 20:13 | |
| kmalloc | we still need to fix the invalidation race | 20:14 |
| kmalloc | but... | 20:14 |
| kmalloc | that is much smaller | 20:14 |
| *** aojea has joined #openstack-keystone | 20:14 | |
| *** tobberydberg has quit IRC | 20:15 | |
| *** aojea has quit IRC | 20:15 | |
| samueldmq | kmalloc: what is that invalidation race thing ? | 20:16 |
| kmalloc | samueldmq: we do an update after invalidating the cache | 20:21 |
| kmalloc | ... always invalidate *after* update | 20:21 |
| samueldmq | kmalloc: where is that ? update of what? | 20:21 |
| samueldmq | should be a quick fix, right? | 20:21 |
| kmalloc | user data i think. i found it in the password change hunt | 20:21 |
| kmalloc | for the created_at_int thing | 20:21 |
| samueldmq | :( | 20:22 |
| kmalloc | sec, i can find it again in a moment | 20:22 |
| samueldmq | kmalloc: would be good to get in for rc too, right? | 20:22 |
| samueldmq | kk | 20:22 |
| kmalloc | https://github.com/openstack/keystone/blob/2164d0550c39a07b9c0dacc6c2167d0018b0c7bd/keystone/identity/core.py#L1092-L1099 | 20:22 |
| kmalloc | it is always good for RC, but it isn't a blocker | 20:23 |
| kmalloc | it can land in queens | 20:23 |
| kmalloc | i don't think that has *ever* caused a real issue | 20:23 |
| samueldmq | kmalloc: ah got it | 20:24 |
| samueldmq | like another process getting in in the meantime | 20:24 |
| samueldmq | and re-setting the thing to the old entity before it gets effectively updated | 20:24 |
| samueldmq | that's not easy to happen, I agree | 20:25 |
| *** raildo has quit IRC | 20:26 | |
| kmalloc | a read on another keystone process for the user will cache the wrong data | 20:27 |
| kmalloc | it's not even that theoretical | 20:27 |
| kmalloc | thankfully, it's not superduper important. | 20:27 |
| kmalloc | because cache expires pretty fast | 20:27 |
| lbragstad | well - our bug queue is *almost* back under 100 open bugs | 20:33 |
| lbragstad | considering it was up to the 130s at various times throughout the release | 20:34 |
| kmalloc | did you count ksa, ksc, ksm too? | 20:36 |
| kmalloc | or just server? | 20:36 |
| *** iogg has joined #openstack-keystone | 20:37 | |
| lbragstad | just server | 20:38 |
| *** sbezverk has quit IRC | 20:47 | |
| cmurphy | anything else burning that we should look right now? | 20:51 |
| *** lucasxu has quit IRC | 20:54 | |
| *** rcernin has joined #openstack-keystone | 20:54 | |
| knikolla | lbragstad: might want to get this in too in pike? https://review.openstack.org/#/c/492694/ | 20:56 |
| *** catintheroof has joined #openstack-keystone | 20:57 | |
| lbragstad | knikolla: yeah - that wouldn't be a bad one to include | 20:57 |
| knikolla | thanks cmurphy | 20:58 |
| lbragstad | knikolla: wooo - look at that shiny +2 | 20:59 |
| knikolla | lbragstad: \o/ | 20:59 |
| *** aojea has joined #openstack-keystone | 21:03 | |
| *** mjax has joined #openstack-keystone | 21:06 | |
| gagehugo | lbragstad knikolla https://review.openstack.org/#/c/494018/ | 21:13 |
| *** rajalokan has quit IRC | 21:19 | |
| gagehugo | knikolla I think we could include coverage in the skip? | 21:25 |
| gagehugo | It looks like everything it covers is in keystone/* excluding tests | 21:25 |
| gagehugo | so for docs that should be fine | 21:25 |
| knikolla | gagehugo: yep. i think so | 21:26 |
| gagehugo | oh that test generates a 14M html file | 21:27 |
| *** mordred has quit IRC | 21:27 | |
| *** mordred has joined #openstack-keystone | 21:27 | |
| knikolla | gagehugo: coverage? | 21:27 |
| gagehugo | nah the regex checking in that change ^ | 21:27 |
| gagehugo | I'll add coverage and fix that | 21:28 |
| knikolla | yep. it was loading for a while | 21:28 |
| knikolla | Regex ^gate-(keystone|tempest|grenade|keystoneclient)-dvsm-.*$ has no matches in job list | 21:29 |
| *** iogg has quit IRC | 21:29 | |
| openstackgerrit | Eric Fried proposed openstack/keystoneauth master: Adapter.get_conf_options(deprecated_opts) https://review.openstack.org/490895 | 21:33 |
| *** itlinux has joined #openstack-keystone | 21:38 | |
| itlinux | hello all.. is there a way to do ldap nested groups? TY | 21:38 |
| gagehugo | knikolla fixed | 21:41 |
| cmurphy | efried: thanks | 21:50 |
| efried | cmurphy Thank you :) | 21:50 |
| mjax | Hey guys, I'm trying to set up domain specific identity driver configurations on keystone, but am getting this error: Failed to load 'keystone.identity.backends.Athens.Identity' using stevedore: No 'keystone.identity' driver found, looking for 'keystone.identity.backends.Athens.Identity' load_driver /opt/stack/keystone/keystone/common/manager.py:76 | 21:57 |
| mjax | anyone familiar with domain specific config setup? | 21:57 |
| lbragstad | mjax: looks like you need to configure the entry point with stevedore | 21:59 |
| lbragstad | which is typically done in setup.cfg | 21:59 |
| lbragstad | #endmeeting | 22:00 |
| openstack | Meeting ended Tue Aug 15 22:00:03 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 22:00 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2017/keystone_office_hours.2017-08-15-18.57.html | 22:00 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/keystone_office_hours/2017/keystone_office_hours.2017-08-15-18.57.txt | 22:00 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2017/keystone_office_hours.2017-08-15-18.57.log.html | 22:00 |
| mjax | I need to do that even if I specified the full filepath in the keystone.conf file? | 22:02 |
| *** chlong_ has quit IRC | 22:08 | |
| *** dave-mccowan has quit IRC | 22:08 | |
| *** thorst has quit IRC | 22:12 | |
| *** clayton has quit IRC | 22:19 | |
| *** clayton has joined #openstack-keystone | 22:19 | |
| lbragstad | mjax: i think so - keystone needs to know how to resolve the entry point and we use stevedore to do that | 22:24 |
| *** edmondsw has quit IRC | 22:25 | |
| mjax | lbragstad: I tried changing the keystone/setup.cfg [entry_points] to include Athens = keystone.identity.backends.Athens:Identity, but am getting the same error | 22:27 |
| lbragstad | mjax: did you reinstall or rebuild? | 22:28 |
| mjax | just restart httpd | 22:28 |
| lbragstad | using setup.py? | 22:29 |
| lbragstad | you'll likely need to rebuild keystone | 22:29 |
| mjax | would I just run setup.py | 22:29 |
| mjax | i haven't tried rebuilding before | 22:29 |
| lbragstad | (e.g. using `pip install -e /path/to/source/`) | 22:30 |
| lbragstad | or python setup.py devel | 22:30 |
| mjax | I'll give the setup.py a shot | 22:30 |
| lbragstad | https://stackoverflow.com/questions/1471994/what-is-setup-py | 22:30 |
| mjax | lbragstad: thanks you were right, got rid of that error | 22:37 |
| *** itlinux has quit IRC | 22:44 | |
| *** gyee has quit IRC | 22:44 | |
| *** gyee has joined #openstack-keystone | 22:44 | |
| *** SamYaple has quit IRC | 23:00 | |
| *** SamYaple has joined #openstack-keystone | 23:00 | |
| *** catintheroof has quit IRC | 23:11 | |
| *** rcernin has quit IRC | 23:12 | |
| *** thorst has joined #openstack-keystone | 23:13 | |
| *** thorst has quit IRC | 23:17 | |
| *** itlinux has joined #openstack-keystone | 23:26 | |
| *** lwanderley has joined #openstack-keystone | 23:42 | |
| *** thorst has joined #openstack-keystone | 23:43 | |
| *** lwanderley has quit IRC | 23:43 | |
| *** dave-mccowan has joined #openstack-keystone | 23:46 | |
| *** thorst has quit IRC | 23:48 | |
| *** edmondsw has joined #openstack-keystone | 23:56 | |
| *** lwanderley has joined #openstack-keystone | 23:57 | |
| *** lwanderley has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!