*** AlexeyAbashkin has joined #openstack-keystone | 00:07 | |
*** mvk has quit IRC | 00:08 | |
*** mvk has joined #openstack-keystone | 00:11 | |
*** AlexeyAbashkin has quit IRC | 00:11 | |
*** lbragstad has joined #openstack-keystone | 00:30 | |
*** ChanServ sets mode: +o lbragstad | 00:30 | |
*** jmlowe has joined #openstack-keystone | 00:36 | |
*** annp has quit IRC | 00:56 | |
*** lbragstad has quit IRC | 01:00 | |
*** threestrands has joined #openstack-keystone | 01:01 | |
*** threestrands has quit IRC | 01:02 | |
*** threestrands has joined #openstack-keystone | 01:02 | |
*** oikiki has quit IRC | 01:04 | |
*** oikiki has joined #openstack-keystone | 01:05 | |
*** markvoelker has quit IRC | 01:12 | |
*** dave-mccowan has quit IRC | 01:13 | |
*** Anticime1 is now known as Anticimex | 01:14 | |
*** namnh has joined #openstack-keystone | 01:16 | |
*** itlinux has joined #openstack-keystone | 01:24 | |
*** threestrands has quit IRC | 01:28 | |
*** rcernin has quit IRC | 01:46 | |
*** rcernin has joined #openstack-keystone | 01:47 | |
*** oikiki has quit IRC | 01:49 | |
*** oikiki has joined #openstack-keystone | 01:50 | |
*** jmlowe has quit IRC | 01:52 | |
*** edmondsw has joined #openstack-keystone | 01:55 | |
*** annp has joined #openstack-keystone | 01:56 | |
*** jmlowe has joined #openstack-keystone | 01:57 | |
*** markvoelker has joined #openstack-keystone | 01:58 | |
*** edmondsw has quit IRC | 02:00 | |
*** markvoelker has quit IRC | 02:03 | |
*** dave-mccowan has joined #openstack-keystone | 02:04 | |
*** AlexeyAbashkin has joined #openstack-keystone | 02:07 | |
*** AlexeyAbashkin has quit IRC | 02:11 | |
*** jmlowe has quit IRC | 02:11 | |
*** oikiki has quit IRC | 02:16 | |
*** oikiki has joined #openstack-keystone | 02:19 | |
*** oikiki has quit IRC | 02:45 | |
*** oikiki has joined #openstack-keystone | 02:46 | |
*** r-daneel has joined #openstack-keystone | 02:50 | |
*** markvoelker has joined #openstack-keystone | 02:52 | |
openstackgerrit | wangqi proposed openstack/keystoneauth master: fix minor typos in tox_install.sh https://review.openstack.org/548128 | 02:54 |
---|---|---|
*** oikiki has quit IRC | 03:01 | |
*** mvk has quit IRC | 03:04 | |
*** r-daneel has quit IRC | 03:08 | |
*** r-daneel has joined #openstack-keystone | 03:08 | |
*** links has joined #openstack-keystone | 03:25 | |
*** markvoelker has quit IRC | 03:27 | |
*** edmondsw has joined #openstack-keystone | 03:43 | |
*** edmondsw has quit IRC | 03:47 | |
*** nicolasbock has quit IRC | 04:23 | |
*** markvoelker has joined #openstack-keystone | 04:44 | |
*** dave-mccowan has quit IRC | 05:04 | |
*** markvoelker has quit IRC | 05:18 | |
openstackgerrit | melissaml proposed openstack/oslo.policy master: Update the invalid url for page https://review.openstack.org/548148 | 05:23 |
*** edmondsw has joined #openstack-keystone | 05:31 | |
*** r-daneel has quit IRC | 05:32 | |
*** edmondsw has quit IRC | 05:36 | |
*** markvoelker has joined #openstack-keystone | 06:35 | |
*** masuberu has quit IRC | 06:47 | |
*** masber has joined #openstack-keystone | 07:08 | |
*** markvoelker has quit IRC | 07:08 | |
*** edmondsw has joined #openstack-keystone | 07:19 | |
*** edmondsw has quit IRC | 07:24 | |
*** pcaruana has joined #openstack-keystone | 07:30 | |
*** martinus__ has joined #openstack-keystone | 07:39 | |
*** masber has quit IRC | 07:39 | |
*** AlexeyAbashkin has joined #openstack-keystone | 07:43 | |
*** masber has joined #openstack-keystone | 07:52 | |
*** namnh_ has joined #openstack-keystone | 08:01 | |
*** namnh has quit IRC | 08:05 | |
*** tesseract has joined #openstack-keystone | 08:14 | |
*** namnh has joined #openstack-keystone | 08:22 | |
*** rcernin has quit IRC | 08:23 | |
*** namnh_ has quit IRC | 08:24 | |
*** wangqiangbj_ has quit IRC | 08:27 | |
*** markvoelker has joined #openstack-keystone | 08:27 | |
*** markvoelker_ has joined #openstack-keystone | 08:29 | |
*** markvoelker has quit IRC | 08:33 | |
*** david-lyle has quit IRC | 08:36 | |
*** david-lyle has joined #openstack-keystone | 08:36 | |
*** jaosorior has joined #openstack-keystone | 08:37 | |
*** lbragstad has joined #openstack-keystone | 08:54 | |
*** ChanServ sets mode: +o lbragstad | 08:54 | |
*** masber has quit IRC | 09:00 | |
*** raildo has joined #openstack-keystone | 09:02 | |
*** edmondsw has joined #openstack-keystone | 09:08 | |
*** lbragstad_ has joined #openstack-keystone | 09:09 | |
*** lbragstad has quit IRC | 09:10 | |
*** r-daneel has joined #openstack-keystone | 09:10 | |
*** jgr has joined #openstack-keystone | 09:11 | |
*** edmondsw has quit IRC | 09:12 | |
*** zhurong has joined #openstack-keystone | 09:14 | |
*** masber has joined #openstack-keystone | 09:14 | |
*** d0ugal has joined #openstack-keystone | 09:32 | |
*** namnh_ has joined #openstack-keystone | 09:46 | |
*** raildo has quit IRC | 09:46 | |
*** namnh has quit IRC | 09:49 | |
*** raildo has joined #openstack-keystone | 09:54 | |
*** d0ugal has quit IRC | 10:00 | |
*** jaosorior has quit IRC | 10:01 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add functional testing gate https://review.openstack.org/531014 | 10:07 |
*** namnh has joined #openstack-keystone | 10:15 | |
*** namnh_ has quit IRC | 10:17 | |
*** szaher_ has joined #openstack-keystone | 10:18 | |
-openstackstatus- NOTICE: gerrit is being restarted due to extreme slowness | 10:22 | |
*** d0ugal has joined #openstack-keystone | 10:27 | |
*** david-lyle has quit IRC | 10:40 | |
*** raildo has quit IRC | 10:42 | |
*** d0ugal has quit IRC | 10:44 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add functional testing gate https://review.openstack.org/531014 | 10:52 |
*** r-daneel has quit IRC | 10:55 | |
*** david-lyle has joined #openstack-keystone | 10:55 | |
*** edmondsw has joined #openstack-keystone | 10:56 | |
*** edmondsw has quit IRC | 11:00 | |
*** AlexeyAbashkin has quit IRC | 11:04 | |
*** namnh has quit IRC | 11:06 | |
*** aloga has quit IRC | 11:10 | |
*** aloga has joined #openstack-keystone | 11:10 | |
*** aloga has quit IRC | 11:10 | |
*** aloga has joined #openstack-keystone | 11:11 | |
*** annp has quit IRC | 11:12 | |
*** aloga has quit IRC | 11:14 | |
*** aloga has joined #openstack-keystone | 11:15 | |
*** links has quit IRC | 11:15 | |
*** AlexeyAbashkin has joined #openstack-keystone | 11:15 | |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Api-ref: fix resource_limit format https://review.openstack.org/548231 | 11:21 |
zigo | https://stretch-queens.infomaniak.ch/job/keystone/5/console <--- Got 3 unit test errors when building in Stretch, could anyone help? | 11:23 |
*** david-lyle has quit IRC | 11:25 | |
*** lbragstad_ has quit IRC | 11:26 | |
gagehugo | zigo looking | 11:26 |
*** jrist has quit IRC | 11:27 | |
*** links has joined #openstack-keystone | 11:28 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add functional testing gate https://review.openstack.org/531014 | 11:29 |
*** nicolasbock has joined #openstack-keystone | 11:31 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add functional testing gate https://review.openstack.org/531014 | 11:50 |
gagehugo | zigo let me spin up a debian stretch img and test it out | 11:52 |
*** jrist has joined #openstack-keystone | 11:53 | |
*** jrist has quit IRC | 11:53 | |
*** jrist has joined #openstack-keystone | 11:53 | |
*** david-lyle has joined #openstack-keystone | 11:54 | |
*** zhurong has quit IRC | 11:54 | |
zigo | gagehugo: you can use my stretch backport repository: deb http://stretch-queens.infomaniak.ch stretch-queens-backports-nochange main | 12:02 |
zigo | deb http://stretch-queens.infomaniak.ch stretch-queens-backports main | 12:02 |
zigo | Source package is at https://salsa.debian.org/openstack-team/services/keystone | 12:03 |
zigo | I don't have the issue in Sid. | 12:04 |
*** szaher_ has quit IRC | 12:07 | |
*** david-lyle has quit IRC | 12:16 | |
*** jrist has quit IRC | 12:16 | |
*** jrist has joined #openstack-keystone | 12:20 | |
*** edmondsw has joined #openstack-keystone | 12:24 | |
*** markvoelker_ has quit IRC | 12:25 | |
*** r-daneel has joined #openstack-keystone | 12:33 | |
*** david-lyle has joined #openstack-keystone | 12:34 | |
openstackgerrit | Merged openstack/keystone master: Remove unnecessary config overrides from fernet tests https://review.openstack.org/547156 | 12:37 |
*** dave-mccowan has joined #openstack-keystone | 13:13 | |
*** mvk has joined #openstack-keystone | 13:28 | |
*** markvoelker has joined #openstack-keystone | 13:28 | |
openstackgerrit | Merged openstack/keystone master: Consolidate endpoint-filtering.rst https://review.openstack.org/547291 | 13:30 |
*** rarora has quit IRC | 13:31 | |
*** lbragstad_ has joined #openstack-keystone | 13:33 | |
*** lbragstad_ is now known as lbragstad | 13:33 | |
*** ChanServ sets mode: +o lbragstad | 13:33 | |
*** jaosorior has joined #openstack-keystone | 13:34 | |
*** zhurong has joined #openstack-keystone | 13:34 | |
*** r-daneel has quit IRC | 13:37 | |
*** zhurong has quit IRC | 13:43 | |
*** srf has joined #openstack-keystone | 13:45 | |
srf | hello i want to ask how to get tokens identity using curl | 13:46 |
openstackgerrit | Colleen Murphy proposed openstack/keystone master: Work around deprecations for opportunistic tests https://review.openstack.org/531577 | 13:46 |
srf | i follow this https://docs.openstack.org/keystone/pike/api_curl_examples.html, and get error curl: (7) Failed to connect to localhost port 5000: Connection refused | 13:47 |
*** jaosorior has quit IRC | 13:47 | |
*** szaher_ has joined #openstack-keystone | 13:49 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Add functional testing gate https://review.openstack.org/531014 | 13:58 |
*** david-lyle has quit IRC | 14:02 | |
*** dklyle has joined #openstack-keystone | 14:02 | |
*** dklyle has quit IRC | 14:06 | |
*** zhurong has joined #openstack-keystone | 14:08 | |
gagehugo | srf is keystone listening on 5000? | 14:11 |
*** jmlowe has joined #openstack-keystone | 14:12 | |
*** zhurong has quit IRC | 14:15 | |
srf | i follow https://docs.openstack.org/keystone/pike/api_curl_examples.html, is deferent? | 14:16 |
*** szaher_ has quit IRC | 14:27 | |
*** srf has quit IRC | 14:28 | |
gagehugo | srf what happens when you curl "http://localhost:5000/v3/"? | 14:33 |
*** jrist has quit IRC | 14:33 | |
*** d0ugal has joined #openstack-keystone | 14:35 | |
*** charz has quit IRC | 14:36 | |
*** szaher_ has joined #openstack-keystone | 14:36 | |
*** charz has joined #openstack-keystone | 14:39 | |
*** jrist has joined #openstack-keystone | 14:39 | |
*** zhurong has joined #openstack-keystone | 14:43 | |
*** robertomls has joined #openstack-keystone | 14:43 | |
*** spilla has joined #openstack-keystone | 14:44 | |
*** itlinux has quit IRC | 14:55 | |
*** r-daneel has joined #openstack-keystone | 14:55 | |
*** karthi has joined #openstack-keystone | 14:58 | |
*** masber has quit IRC | 14:58 | |
*** karthi has quit IRC | 14:59 | |
gagehugo | zigo those failures are very weird | 15:08 |
zigo | gagehugo: Could you reproduce it? | 15:08 |
*** r-daneel has quit IRC | 15:08 | |
gagehugo | zigo no | 15:08 |
zigo | gagehugo: Did you use my repository to pull all the dependencies / | 15:09 |
zigo | ? | 15:09 |
zigo | You should not attempt to use tox, that would defeat it. | 15:09 |
gagehugo | ah | 15:09 |
gagehugo | looking at the tests that failed though makes me wonder | 15:09 |
*** jmlowe_ has joined #openstack-keystone | 15:09 | |
gagehugo | since there are others with project tags that use the same functionality which pass... | 15:10 |
zigo | I just follow the requirements, but sometime they are just wrong. | 15:10 |
gagehugo | other tests* | 15:10 |
zigo | Oh... | 15:10 |
zigo | gagehugo: You've seen I'm using Python 3, right? | 15:10 |
gagehugo | zigo ah | 15:11 |
gagehugo | hmm | 15:11 |
zigo | I've switched all of the services to it. | 15:11 |
*** jmlowe has quit IRC | 15:11 | |
zigo | Keystone included. | 15:11 |
gagehugo | it looks like it's failing on "self._create_project_and_tags" | 15:12 |
gagehugo | but most of the project tags test use that and only 3 of them fail | 15:13 |
zigo | gagehugo: Does it look like broken test to you, or broken functionality? | 15:13 |
gagehugo | zigo not sure, we don't have debian images on the upstream openstack gate atm | 15:16 |
zigo | gagehugo: Again, I don't think that's related to what image, but the version of python libs, maybe. | 15:17 |
* zigo goes to fetch kids at school | 15:17 | |
*** david-lyle has joined #openstack-keystone | 15:36 | |
*** jaosorior has joined #openstack-keystone | 15:41 | |
*** itlinux has joined #openstack-keystone | 15:42 | |
*** dave-mccowan has quit IRC | 15:45 | |
*** jaosorior has quit IRC | 15:51 | |
*** d0ugal has quit IRC | 16:00 | |
gagehugo | zigo maybe? | 16:02 |
*** links has quit IRC | 16:04 | |
*** htruta has quit IRC | 16:06 | |
*** pcaruana has quit IRC | 16:07 | |
*** david-lyle has quit IRC | 16:15 | |
*** dklyle has joined #openstack-keystone | 16:15 | |
*** aloga_ has joined #openstack-keystone | 16:17 | |
zigo | gagehugo: I'm back. | 16:21 |
gagehugo | zigo what is running the unit tests? | 16:22 |
gagehugo | something is putting the array into a string | 16:26 |
gagehugo | and hitting this https://github.com/openstack/keystone/blob/stable/queens/keystone/resource/backends/sql.py#L335-L337 | 16:27 |
gagehugo | which will throw the error shown in those 3 failing tests | 16:27 |
*** Supun has joined #openstack-keystone | 16:28 | |
gagehugo | only the tests with >= 8 tags created will fail | 16:30 |
gagehugo | they all use random uuids for the values, so technically 5 tags in an array will be less than 255 | 16:31 |
gagehugo | I wonder if whatever is running the tests is escaping things | 16:31 |
*** szaher_ has quit IRC | 16:32 | |
*** zhurong has quit IRC | 16:45 | |
*** r-daneel has joined #openstack-keystone | 16:46 | |
*** markvoelker has quit IRC | 16:55 | |
*** aloga_ has quit IRC | 17:01 | |
*** lbragstad has quit IRC | 17:07 | |
*** dave-mccowan has joined #openstack-keystone | 17:08 | |
*** mvk has quit IRC | 17:14 | |
*** AlexeyAbashkin has quit IRC | 17:15 | |
*** gyee has joined #openstack-keystone | 17:16 | |
*** Supun has quit IRC | 17:21 | |
*** Supun has joined #openstack-keystone | 17:22 | |
*** oikiki has joined #openstack-keystone | 17:31 | |
*** dave-mccowan has quit IRC | 17:33 | |
*** links has joined #openstack-keystone | 17:35 | |
*** Supun has quit IRC | 17:40 | |
*** Supun has joined #openstack-keystone | 17:41 | |
*** Supun has quit IRC | 17:58 | |
*** Supun has joined #openstack-keystone | 17:58 | |
*** dave-mccowan has joined #openstack-keystone | 18:01 | |
*** david-lyle_ has joined #openstack-keystone | 18:01 | |
*** harlowja has joined #openstack-keystone | 18:03 | |
*** dklyle has quit IRC | 18:05 | |
*** AlexeyAbashkin has joined #openstack-keystone | 18:26 | |
*** AlexeyAbashkin has quit IRC | 18:30 | |
*** gyee has quit IRC | 18:31 | |
*** tesseract has quit IRC | 18:31 | |
*** david-lyle_ has quit IRC | 18:34 | |
gagehugo | zigo oh it runs stestr under the hood | 18:37 |
gagehugo | your python lib version idea may be accurate... | 18:38 |
*** dave-mccowan has quit IRC | 18:56 | |
*** david-lyle has joined #openstack-keystone | 18:58 | |
zigo | gagehugo: Yes, in packaging, we can't run tox, so we just do what tox.ini says ... | 19:05 |
*** AlexeyAbashkin has joined #openstack-keystone | 19:08 | |
*** AlexeyAbashkin has quit IRC | 19:13 | |
*** dave-mccowan has joined #openstack-keystone | 19:13 | |
gagehugo | I'm not familiar with debian, but from the output logs it looks like something is escaping characters in the tags array | 19:14 |
gagehugo | "String length exceeded. The length of string \\\'[\\\'f8d9333f7b8b4ba1b1d60e49b10132d2\\\' that is very weird | 19:15 |
*** Supun has quit IRC | 19:16 | |
*** Supun has joined #openstack-keystone | 19:17 | |
zigo | gagehugo: What you can do is just git clone https://salsa.debian.org/openstack-team/services/keystone ; cd keystone ; ./debian/rules gen-orig-xz ; dpkg-buildpackage | 19:17 |
zigo | Dependencies are where I showed you. | 19:17 |
zigo | Thanks a lot for investigating anyway. | 19:18 |
zigo | That's very nice of you. | 19:18 |
*** Supun has quit IRC | 19:19 | |
*** Supun has joined #openstack-keystone | 19:19 | |
*** Supun has quit IRC | 19:19 | |
kmalloc | gagehugo: uhm. that @expression is bad | 19:29 |
kmalloc | like... why are we doing .Name? | 19:29 |
kmalloc | thats... what the heck? | 19:29 |
kmalloc | we need to stop applying hybrid properties randomly | 19:30 |
kmalloc | people don't seem to understand hybrid properties. | 19:30 |
kmalloc | zigo: ^ cc. | 19:30 |
zigo | kmalloc: Are you suggesting a patch? :) | 19:31 |
kmalloc | i am suggesting someone needs to produce a patch | 19:31 |
gagehugo | kmalloc I may have followed the password usage of @expression | 19:32 |
kmalloc | i don't understand why we're doing project.tags returns projecttag.Name | 19:32 |
kmalloc | yeah | 19:32 |
kmalloc | that is broken | 19:32 |
kmalloc | you're returning the name of a single project tag in some cases | 19:32 |
gagehugo | ah | 19:33 |
kmalloc | namely when you're dealing with uninstantiated objects | 19:33 |
kmalloc | @expression handles class like usage | 19:33 |
kmalloc | vs. instance like usage | 19:33 |
gagehugo | that may be what is throwing the entire array into that | 19:33 |
kmalloc | in the case of Password you only ever have a single password | 19:33 |
kmalloc | so, we reference the password. | 19:33 |
kmalloc | it's the same kind of issue we're having with uhm... another feature | 19:34 |
gagehugo | yeah | 19:34 |
gagehugo | weird that this has only show up with zigo's debian build | 19:34 |
gagehugo | shown* | 19:34 |
gagehugo | but honestly that makes sense | 19:35 |
kmalloc | it is possibly something wonky with the non-tox environemtn | 19:36 |
kmalloc | tox does other magic sometimes. | 19:36 |
kmalloc | in fact we have the same issue with Password | 19:37 |
kmalloc | just different represenation of the issue | 19:38 |
kmalloc | basically, we need to drop the .expression for Password as well. | 19:38 |
kmalloc | extra long passwords are inappropriately being not-hashed. | 19:38 |
kmalloc | before being checked for length | 19:39 |
gagehugo | kmalloc so a @hybrid_property without an expression should be a @property then? | 19:42 |
kmalloc | no. | 19:43 |
kmalloc | i am not sure why you're doing an expression here. | 19:43 |
kmalloc | you can probably just drop .expression | 19:43 |
kmalloc | method | 19:43 |
kmalloc | afaict | 19:43 |
gagehugo | I think I ran into some issue when I didn't have it, lemme check | 19:44 |
kmalloc | see http://docs.sqlalchemy.org/en/latest/orm/extensions/hybrid.html for what a hybrid is actually for | 19:44 |
kmalloc | it is mostly for cases when you need to handle a behavior difference | 19:46 |
kmalloc | for say a difference between a default and not | 19:46 |
kmalloc | so, i think you can swap to plain @property | 19:47 |
kmalloc | from @hybrid | 19:47 |
kmalloc | and drop the .expression | 19:47 |
gagehugo | ah, tags wouldn't have a behavior difference | 19:47 |
kmalloc | there is zero case you should have a project object not instanciated with tags | 19:47 |
gagehugo | yeah | 19:48 |
kmalloc | the key is like the length value, where by default you're doing return func.abs(cls.length) / 2 instead of return abs(self.length) / 2 | 19:48 |
kmalloc | likewise we should never have a password without a hash... | 19:49 |
gagehugo | ok | 19:49 |
gagehugo | I'll take a look at it | 19:49 |
kmalloc | so i'd try swapping tags to @property | 19:49 |
kmalloc | and drop .expression | 19:49 |
kmalloc | it might need other things | 19:49 |
kmalloc | but that would be where i start | 19:49 |
gagehugo | zigo I'll try to get a patch up somewhat quickly, currently 8 PM here | 19:50 |
gagehugo | kmalloc will do! | 19:50 |
zigo | gagehugo: Are you in Dublin ? :) | 19:50 |
kmalloc | the other option is, you might need to make .expression simply return [] | 19:50 |
gagehugo | zigo aye | 19:50 |
kmalloc | if you can't make the non-hybrid version work | 19:50 |
zigo | gagehugo: I wish I was there too... | 19:50 |
kmalloc | zigo: it's ok man, i'm not there either. | 19:50 |
zigo | I miss seeing the OpenStack folks. | 19:50 |
gagehugo | zigo kmalloc we are supposed to get a lot of snow here... | 19:51 |
zigo | Lots of them, I consider friends. | 19:51 |
gagehugo | yeah I miss seeing kmalloc here :( | 19:51 |
zigo | gagehugo: It was -15 C this morning where I live. :P | 19:51 |
gagehugo | ewww | 19:51 |
gagehugo | it's been ~0C here | 19:52 |
zigo | (I live at 1000m in the mountain) | 19:52 |
kmalloc | I live at ~50m over sea level | 19:52 |
kmalloc | it's been 0-2c today | 19:52 |
kmalloc | maybe only 25m over sea level | 19:52 |
kmalloc | :P | 19:52 |
kmalloc | we got snow a few days ago | 19:53 |
* gagehugo gets ready to go get sushi | 19:53 | |
gagehugo | kmalloc thanks, that was bothering me all day | 19:53 |
gagehugo | but that honestly makes a lot of sense | 19:53 |
gagehugo | since we've seen weird things with that password .expression | 19:54 |
openstackgerrit | Gage Hugo proposed openstack/keystone master: WIP Remove @expression from tags https://review.openstack.org/548399 | 19:57 |
kmalloc | the .expression part should only ever be called when in the "class" form, so if you can't make it work w/o .expression or with standard @property, make .expression return [] and we can troubleshoot from there | 19:59 |
kmalloc | another option is possibly: @balance.expression | 19:59 |
kmalloc | def balance(cls): | 19:59 |
kmalloc | return select([func.sum(SavingsAccount.balance)]).\ | 19:59 |
kmalloc | where(SavingsAccount.user_id==cls.id).\ | 19:59 |
kmalloc | label('total_balance') | 19:59 |
kmalloc | something like that | 19:59 |
kmalloc | where you do the explicit select | 20:00 |
*** ayushin78 has joined #openstack-keystone | 20:05 | |
zigo | gagehugo: Thanks, will try the patch. | 20:11 |
*** ayushin78 has quit IRC | 20:17 | |
*** links has quit IRC | 20:30 | |
*** markvoelker_ has joined #openstack-keystone | 20:51 | |
*** oikiki has quit IRC | 20:52 | |
*** oikiki has joined #openstack-keystone | 20:52 | |
kmalloc | zigo: it will fail pep8 | 21:07 |
kmalloc | but that is because hybrid_property is imported there. | 21:08 |
*** panbalag has quit IRC | 21:11 | |
zigo | kmalloc: I'm not sure if its my env that changed or what, but keystone builds in my stretch CI now ! :) | 21:24 |
zigo | (with your patch) | 21:24 |
kmalloc | weird. | 21:24 |
kmalloc | but sure. | 21:25 |
zigo | kmalloc: I don't run pep8 tests (that's useless for packaging...). | 21:25 |
kmalloc | zigo: fwiw, you should probably firewall off your jenkins... last i heard jenkins wasn't really secure to expose to the internet. | 21:25 |
kmalloc | even w/ passwords and what not. | 21:25 |
zigo | kmalloc: I don't have much choice, it needs webhooks from salsa.debian.org. | 21:26 |
zigo | But you're probably right. | 21:26 |
zigo | Jenkins is a piece of junk ! :) | 21:26 |
kmalloc | you might be able to isolate just the webhooks and from that source. | 21:26 |
zigo | Though it's easy to setup. | 21:26 |
zigo | Yup. | 21:26 |
kmalloc | eh, it isn't junk, it does what it does ok | 21:26 |
kmalloc | it has limits | 21:26 |
kmalloc | there are other options that are better in some cases. | 21:27 |
zigo | Like buildbot ? | 21:27 |
zigo | I only heard bad things about it. | 21:27 |
* kmalloc shrugs. | 21:27 | |
kmalloc | if it works, keep using it. but just work to limit exposure ;) | 21:27 |
kmalloc | anyway. that patch should pass everything but pep8 afict | 21:27 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: WIP Remove @expression from tags https://review.openstack.org/548399 | 21:30 |
*** aloga_ has joined #openstack-keystone | 21:33 | |
*** panbalag has joined #openstack-keystone | 21:51 | |
*** martinus__ has quit IRC | 21:58 | |
*** AlexeyAbashkin has joined #openstack-keystone | 22:05 | |
*** AlexeyAbashkin has quit IRC | 22:09 | |
*** mvk has joined #openstack-keystone | 22:36 | |
*** oikiki has quit IRC | 22:38 | |
*** oikiki has joined #openstack-keystone | 22:38 | |
*** itlinux has quit IRC | 22:40 | |
*** rcernin has joined #openstack-keystone | 22:59 | |
*** spilla has quit IRC | 23:07 | |
*** oikiki has quit IRC | 23:19 | |
*** edmondsw has quit IRC | 23:32 | |
*** edmondsw has joined #openstack-keystone | 23:32 | |
*** edmondsw has quit IRC | 23:36 | |
*** aloga_ has quit IRC | 23:41 | |
*** edmondsw has joined #openstack-keystone | 23:43 | |
*** edmondsw has quit IRC | 23:48 | |
*** r-daneel has quit IRC | 23:53 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!