Wednesday, 2018-05-16

*** eschwartz has quit IRC00:00
*** ztrawhcse has joined #openstack-keystone00:01
*** dklyle has quit IRC00:24
*** dklyle has joined #openstack-keystone00:32
*** ztrawhcse is now known as eschwartz00:33
*** linhnm has joined #openstack-keystone00:33
*** Dinesh_Bhor has joined #openstack-keystone00:37
*** spilla has quit IRC00:43
*** germs_ has quit IRC00:48
*** dklyle has quit IRC00:53
*** dave-mcc_ has quit IRC00:59
*** edmondsw has joined #openstack-keystone01:18
*** dklyle has joined #openstack-keystone01:20
*** edmondsw has quit IRC01:22
*** dklyle has quit IRC01:29
*** r-daneel has quit IRC01:30
*** gyee has quit IRC01:38
*** gyankum has joined #openstack-keystone01:55
*** dave-mccowan has joined #openstack-keystone02:03
*** annp has quit IRC02:03
*** annp has joined #openstack-keystone02:03
*** linhnm has quit IRC02:03
*** nicolasbock has quit IRC02:24
*** dave-mccowan has quit IRC02:32
*** Dinesh__Bhor has joined #openstack-keystone03:18
*** annp has quit IRC03:20
*** gyankum has quit IRC03:20
*** Dinesh_Bhor has quit IRC03:21
*** panbalag has joined #openstack-keystone03:24
*** panbalag has left #openstack-keystone03:24
*** links has joined #openstack-keystone03:41
*** sonuk has joined #openstack-keystone03:56
*** gyankum has joined #openstack-keystone04:10
*** edmondsw has joined #openstack-keystone04:32
*** brad[] has quit IRC04:33
Shilpacmurphy: hi04:35
*** jaosorior has quit IRC04:40
*** jaosorior has joined #openstack-keystone04:47
*** jaosorior has quit IRC04:54
*** Dinesh__Bhor has quit IRC05:00
*** jaosorior has joined #openstack-keystone05:02
*** sapd has quit IRC05:17
*** annp has joined #openstack-keystone05:34
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert Keystone to use Flask  https://review.openstack.org/56837705:36
*** Dinesh_Bhor has joined #openstack-keystone05:42
*** sapd has joined #openstack-keystone05:56
wxylbragstad: Re https://review.openstack.org/#/c/568541, the "project_id" in "create_limits" is designed as that the admin can create limit for different projects.06:24
wxyThe policy is admin_required and system scoped by default. https://github.com/openstack/keystone/blob/master/keystone/common/policies/limit.py#L42-L4806:26
*** Dinesh_Bhor has quit IRC06:28
wxyI think the "project_id" can be optional and be pulled from the token.06:29
*** martinus__ has joined #openstack-keystone06:43
*** edmondsw has quit IRC06:49
openstackgerritwangxiyuan proposed openstack/keystone master: Remove some unused functions  https://review.openstack.org/56842907:01
openstackgerritwangxiyuan proposed openstack/keystone master: Remove eventlet related configuration  https://review.openstack.org/56876407:01
*** rcernin has quit IRC07:10
*** tesseract has joined #openstack-keystone07:17
*** bhagyashri_s has quit IRC07:36
*** bhagyashri_s has joined #openstack-keystone07:37
*** aloga has joined #openstack-keystone07:39
openstackgerritMerged openstack/oslo.policy master: Include both new and deprecated rules in generated sample  https://review.openstack.org/56867607:40
*** AlexeyAbashkin has joined #openstack-keystone07:42
*** dims has quit IRC07:59
*** dims has joined #openstack-keystone08:02
*** dims has quit IRC08:07
*** dims has joined #openstack-keystone08:07
*** edmondsw has joined #openstack-keystone08:20
*** edmondsw has quit IRC08:25
*** links has quit IRC09:07
*** jistr has quit IRC09:09
*** jistr has joined #openstack-keystone09:12
*** links has joined #openstack-keystone09:23
*** myrat has joined #openstack-keystone09:47
*** ispp has joined #openstack-keystone09:49
*** ispp has left #openstack-keystone09:50
*** ispp has quit IRC09:50
*** issp has joined #openstack-keystone09:50
*** issp has quit IRC09:50
*** ispp has joined #openstack-keystone09:51
*** ispp has quit IRC09:51
*** ispp has joined #openstack-keystone09:52
myrati write the command openstack create -enable --description "First project" P0109:52
myratthen i got error Missing value auth-urk required for auth plugin password09:52
*** edmondsw has joined #openstack-keystone10:08
*** sapd has quit IRC10:10
*** sapd has joined #openstack-keystone10:11
*** edmondsw has quit IRC10:13
*** obre has quit IRC10:25
*** obre has joined #openstack-keystone10:25
*** obre has quit IRC10:28
*** obre has joined #openstack-keystone10:28
*** nicolasbock has joined #openstack-keystone10:32
*** dave-mccowan has joined #openstack-keystone10:42
*** links has quit IRC10:44
*** pooja_jadhav has quit IRC10:54
*** nicolasbock has quit IRC10:54
*** links has joined #openstack-keystone10:58
*** ispp has quit IRC11:04
*** ispp has joined #openstack-keystone11:06
*** nicolasbock has joined #openstack-keystone11:10
*** Shilpa has quit IRC11:22
*** jaosorior has quit IRC11:23
*** jaosorior has joined #openstack-keystone11:42
*** raildo has joined #openstack-keystone11:44
*** rmascena has joined #openstack-keystone11:44
*** pooja_jadhav has joined #openstack-keystone11:54
*** bhagyashri_s has quit IRC11:55
*** edmondsw has joined #openstack-keystone11:57
*** edmondsw has quit IRC12:01
*** panbalag has joined #openstack-keystone12:02
*** ispp has quit IRC12:03
*** edmondsw has joined #openstack-keystone12:07
*** edmondsw has quit IRC12:07
*** ispp has joined #openstack-keystone12:14
*** bhagyashris has joined #openstack-keystone12:28
*** dklyle has joined #openstack-keystone12:30
*** edmondsw has joined #openstack-keystone12:36
*** myrat has quit IRC12:38
*** dklyle has quit IRC12:39
*** r-daneel has joined #openstack-keystone12:47
*** panbalag has left #openstack-keystone12:49
*** felipemonteiro has joined #openstack-keystone12:59
*** rmascena has quit IRC13:01
*** pcichy has joined #openstack-keystone13:01
*** felipemonteiro has quit IRC13:03
hrybackio/13:09
*** r-daneel_ has joined #openstack-keystone13:15
*** Shilpa has joined #openstack-keystone13:16
*** r-daneel has quit IRC13:16
*** r-daneel_ is now known as r-daneel13:16
*** brad[] has joined #openstack-keystone13:23
*** spilla has joined #openstack-keystone13:32
lbragstado/13:34
lbragstadwxy: oh - cool13:34
lbragstadwxy: so then as we remove the @protected decorator, we can clarify those cases in the API13:35
*** sonuk has quit IRC13:44
*** prashkre has joined #openstack-keystone13:45
prashkrelbragstad: Hi. Good morning!.13:47
lbragstadprashkre: o/13:47
prashkrelbragstad: please review https://review.openstack.org/#/c/568373/ when you have time today.13:47
lbragstadprashkre: sounds good - i'll have a look13:52
*** mvk has quit IRC13:52
prashkrelbragstad: Thank you!14:00
*** nicolasbock has quit IRC14:06
*** xinran__ has joined #openstack-keystone14:06
hrybackiknikolla: if create_project_tags are admin specific api actions, would update_project_tags also fall into admin actions?14:07
*** gyankum has quit IRC14:09
*** r-daneel has quit IRC14:20
*** nicolasbock has joined #openstack-keystone14:23
*** felipemonteiro has joined #openstack-keystone14:25
*** germs has joined #openstack-keystone14:27
*** germs has quit IRC14:27
*** germs has joined #openstack-keystone14:27
hrybackifelipemonteiro: I can't recall -- were you going to be in attendance at Summit?14:27
felipemonteirohrybacki: yes, whole week14:27
hrybackifelipemonteiro: excellent me too -- my calendar is pretty packed up but I'd like to sit down with you for 30 mins at some point if possible14:28
*** mvk has joined #openstack-keystone14:29
felipemonteirohrybacki: i'd like that, i guess we can coordinate over irc? there's another patrole core also going, rick bartra14:31
hrybackifelipemonteiro: irc works for me. Freenode is always live on my phone14:31
hrybackiand I may install twitter for the conf. @harryrybacki14:32
*** germs has quit IRC14:32
felipemonteiroit's also on my phone, it's just a matter of paying better attention to it :)14:32
*** prashkre has quit IRC14:34
lbragstadwhat are you using for irc apps?14:37
lbragstador a mobile irc client?14:37
hrybackilbragstad: I use irccloud14:38
lbragstadahh14:38
hrybacki$5/mo but the web client is a decent bouncer and the mobile app is pretty alright14:38
*** r-daneel has joined #openstack-keystone14:38
hrybackihonestly one of my better monthly subscriptions14:39
*** felipemonteiro_ has joined #openstack-keystone14:41
*** felipemonteiro has quit IRC14:44
*** Alexey_Abashkin has joined #openstack-keystone14:44
*** felipemonteiro has joined #openstack-keystone14:44
*** AlexeyAbashkin has quit IRC14:46
*** Alexey_Abashkin is now known as AlexeyAbashkin14:46
*** felipemonteiro_ has quit IRC14:46
*** ksavich has joined #openstack-keystone14:49
*** dklyle has joined #openstack-keystone14:53
*** ispp has quit IRC14:57
*** links has quit IRC14:58
*** ispp has joined #openstack-keystone15:05
gagehugoo/15:10
*** dklyle has quit IRC15:12
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Collect timing information for API calls  https://review.openstack.org/56887715:16
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add oslo.config option for split-loggers  https://review.openstack.org/56887815:16
mordredcmurphy: do you remember who is was who was asking about how to support split-loggers in services a while back?15:16
mordredI wanna say it was bhagyashris ...15:17
mordredbhagyashris: ^^ were you the one asking about split loggers in config files?15:17
*** dklyle has joined #openstack-keystone15:18
*** prashkre has joined #openstack-keystone15:19
mordredor was it pooja_jadhav ?15:22
* mordred has bad memory15:22
*** prashkre has quit IRC15:24
*** dklyle has quit IRC15:24
*** dklyle has joined #openstack-keystone15:26
*** ispp has quit IRC15:27
ayoungmordred, kmalloc who drove and what was the thing about short term X509 certs from a few years back?15:27
ayoungIIRC it was the head of the Security group, and he worked for ... HPE?15:28
ayoungthey had a CA with 1 hour X509 certs, or something?15:28
mordredayoung: I have no memory of such a thing15:29
ayoungmordred, the dude that was the head of the security group...can't remember his name15:30
ayoungRob Clack15:30
ayoungClark15:30
mordredyah. I can see his face but am going blank on his ...yes15:30
mordredi believe he's at IBM now in Ben de Bont's team15:30
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Return the endpoint_override from EndpointData  https://review.openstack.org/49194715:30
*** dklyle has quit IRC15:31
ayoungGot it. thanks15:32
ayoungAnchor!15:34
*** gyankum has joined #openstack-keystone15:39
cmurphymordred: it was pooja_jadhav15:43
cmurphyat least that was one person asking about it recently15:44
mordredcmurphy: cool15:47
mordredcmurphy: thanks!15:47
mordredpooja_jadhav: the patch I just pushed up, https://review.openstack.org/568878 - should do what you're looking for15:48
mordredcmurphy: also, that patch might explain better what his issue was15:48
*** pcichy has quit IRC15:51
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Stop using pbr autodoc  https://review.openstack.org/56888915:56
mordredkmalloc: ^^ there's a stab at dealing with the doc situation - and also making there be less magic in our docs build15:57
kmallocmordred: tnhx16:04
kmalloci was trying to figure that out last night16:04
*** itlinux has joined #openstack-keystone16:05
itlinuxhello guys.. I have AD enabled and at times I get this error An unexpected error prevented the server from fulfilling your request. (HTTP 500)16:05
*** rmascena has joined #openstack-keystone16:05
*** rmascena is now known as raildo_16:05
itlinuxcan someone point me what could be the cause..16:06
itlinuxI can telnet to ldaps port server fine16:06
itlinuxGalera is running in HA mode16:06
kmallocayoung: i don't remember either, but it was called ephemeral ssl i think16:07
kmallocayoung: something like that16:07
*** raildo has quit IRC16:08
kmallocmordred: ftr, i don't mind autodoc from PBR16:08
kmallocmordred: i was wondering why it suddently lost a file though16:09
*** jmlowe has quit IRC16:09
kmalloclost a file from the toctree16:09
*** edmondsw has quit IRC16:15
mordredkmalloc: yah - me too. I looked at that for a while and could not see a reason forit16:15
mordredkmalloc: also - I hope you enjoy the little collection of ksa patches I made for you this morning :)16:17
kmallocmordred: hehe16:17
kmalloci think there is something weird in how we are doing sphinx in ksa...16:18
kmallocdid we have a new PBR release recently?16:18
kmallocanyway, looking at the KSA stuff once i get coffee in my system :)16:18
kmallocand once the doc fix check passes, it's gettnig merged16:18
*** edmondsw_ has joined #openstack-keystone16:18
ayoungkmalloc, it was Anchor, and yeah, Ephemeral was the key word16:20
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Allow registering additional plugin loaders  https://review.openstack.org/33312616:20
*** edmondsw_ has quit IRC16:23
*** germs has joined #openstack-keystone16:28
*** germs has quit IRC16:28
*** germs has joined #openstack-keystone16:28
mordredkmalloc: I went and abandoned a few patches that were old and pretty certainly either abandoned or irrelegant at this point. https://review.openstack.org/#/q/project:openstack/keystoneauth+status:open is actually not a bad list now - 6 out of the 9 should be landable short-term- of the remaining 3 one is blocked on sdk (which Im trying to get fixed today) one is in active work - and one seems like16:28
mordreda good idea but may need a little more work16:28
mordredlbragstad: ^^16:28
lbragstadmordred: ack - thanks for the heads up16:28
*** gyee has joined #openstack-keystone16:29
*** felipemonteiro has quit IRC16:31
*** germs has quit IRC16:32
openstackgerritBen Nemec proposed openstack/oslo.policy master: Include deprecated_reason when deprecated_rule is set  https://review.openstack.org/56868716:35
*** itlinux has quit IRC16:36
kmalloclbragstad: hmm. this flask conversion is getting complex.16:38
kmalloclbragstad: because... webob vs werkzeug16:38
*** felipemonteiro has joined #openstack-keystone16:38
lbragstadwe already use webob16:39
lbragstaddoes it not integrate well with webob?16:39
*** felipemonteiro has quit IRC16:45
openstackgerritMerged openstack/keystone master: Remove some unused functions  https://review.openstack.org/56842916:45
openstackgerritMerged openstack/keystone master: Add conceptual overview of the service catalog  https://review.openstack.org/56397416:45
kmalloclbragstad: it is looking like webob and werkzeug are two implementations of the same concept16:48
kmallocand flask leans on werkzeug16:48
lbragstadbah16:48
kmallocwebob is related to paste.16:48
kmallocthe issue i'm running into is middleware.16:49
kmallocbecause it is assumed we're webob.dec.wsgify it16:49
lbragstadi wonder how hard it would be to convert to werkzeug16:49
kmallocthat is what i'm looking at, but all the external middleware is webob16:49
kmallocseeing if i can make them play nice.16:49
*** links has joined #openstack-keystone16:54
kmalloclbragstad: we may not be able to use flask easily16:56
kmalloclbragstad: we may be better off looking at pyramid or something similar16:56
lbragstadhmm16:56
kmallocthat is webob based.16:56
*** felipemonteiro has joined #openstack-keystone16:56
*** raildo_ is now known as raildo16:58
kmallocor we could look into something like falcon.16:59
openstackgerritLance Bragstad proposed openstack/oslo.policy master: Add examples and clarification around scope_types  https://review.openstack.org/56890116:59
lbragstadfalcon is nice16:59
lbragstadfrom the examples i've seen or the services i've seen use it17:00
*** panbalag has joined #openstack-keystone17:00
*** panbalag has left #openstack-keystone17:00
*** felipemonteiro has quit IRC17:03
* lbragstad breaks to get a run in over lunch17:03
*** felipemonteiro has joined #openstack-keystone17:04
*** germs has joined #openstack-keystone17:04
*** germs has quit IRC17:04
*** germs has joined #openstack-keystone17:04
*** germs has quit IRC17:04
*** germs has joined #openstack-keystone17:05
*** germs has quit IRC17:05
*** germs has joined #openstack-keystone17:05
*** germs has quit IRC17:05
kmalloclbragstad: yeah.17:05
*** germs has joined #openstack-keystone17:06
kmalloclbragstad: /me gets ready to throw out a couple days of work and take another hack at this.17:06
kmalloclbragstad: looks like falcon at least plays nice with webob based middleware.17:06
*** germs has quit IRC17:06
kmalloccmurphy: the autodoc issue with ksa both mordred and I looked at, this might be just a stop-gap17:07
*** ksavich has quit IRC17:07
kmalloccmurphy: i watn to use autodoc, but somehow we're losing a file from the toctree17:07
kmalloccmurphy: and it's breaking every single patch to ksa.17:07
*** germs has joined #openstack-keystone17:07
kmallocand... this might be a bug in pbr 4.0.317:09
*** pcichy has joined #openstack-keystone17:10
*** itlinux has joined #openstack-keystone17:12
kmalloccmurphy: nope, i am really unsure what changed... it was *just* working17:14
cmurphypbr did just release 37 hours ago which was around the time it broke, but i can't reproduce it with pbr 4.0.3 yet17:15
*** links has quit IRC17:16
*** AlexeyAbashkin has quit IRC17:16
*** spilla has quit IRC17:18
*** spilla has joined #openstack-keystone17:21
*** tesseract has quit IRC17:27
*** mvk has quit IRC17:27
openstackgerritColleen Murphy proposed openstack/keystoneauth master: [DNM] See if latest pbr is causing our docs problems  https://review.openstack.org/56890917:33
cmurphykmalloc: mordred seems magically fixed? https://review.openstack.org/#/c/568877 unless i'm missing a relationship with 568889 somewhere17:36
*** eschwartz has quit IRC17:39
kmalloccmurphy: i hate magic17:40
kmalloc:P17:40
kmalloctrying a clean rebuild of my environment17:40
kmallocfwiw, i was getting the same xactl error locally17:40
kmallocStill am17:41
kmallocclean tox environment17:41
kmalloccmurphy: ... *blink*17:43
kmalloci don't know how this is working.17:43
kmalloci can't get it to work locally17:43
gagehugomagic17:44
*** ztrawhcse has joined #openstack-keystone17:45
kmallocyep, i cannot build the docs locally at all17:45
cmurphyi can't reproduce the problem at all17:47
kmalloccmurphy: this is highly frustrating. =/17:47
cmurphy:(17:48
kmalloci just don't know what could be making this work/notwork in various environments17:48
kmalloci'd hope that it was relatively the same17:48
kmalloci've tried python2.7, pyton3.6, python 3.5, master, different versions of pbr, different versions of sphinx, different hashes [known to work] of keystoneauth17:49
kmalloci think i've spent now 3 hours of trying to figure out how in the heck we've lost a file in the toctree17:49
kmalloci mean, i knidof just want to turn off warning-as-error for the moment.17:50
cmurphyi would support turning off warning-is-error more than abandoning autodoc altogether as a stopgap17:51
kmalloccmurphy: and i'm not seeing how it's possible to turn warning-as-error off17:53
kmallocthere is a sphinx flag to enable that17:53
kmallocand i think we somehow magically enable it17:53
kmalloci'm... very displeased with the volume of magic in our doc build17:54
cmurphyit's in setup.cfg17:55
mordredcmurphy: fwiw, almost nobody uses the autodoc feature in openstack anymore17:55
mordred12 repos, to be precise17:55
cmurphymordred: what's the alternative? is everyone really manually curating api docs?17:55
kmalloccmurphy: thnx.17:56
mordredyeah ... I mean- you don't need to manually curate all the docs - just the list of modules - so the only skew really comes when you add a new module and don't reference it anywhere17:56
kmallocmordred: so your fix seems to nuke a doc file, fwiw.17:57
mordredkmalloc: it does? bother17:57
kmallocmordred: is there a plan to drop autodoc feature from pbr17:57
mordredkmalloc: there are definitely people who would like to - but I don't know if it's gotten as far as a 'plan'17:58
kmallocmordred: oh no it doesn't17:58
kmallocmordred: nvm, i was mis-reading17:58
mordredthere was also talk about taking the feature and turning it in to a sphinx plugin17:58
kmalloci inverted the diff i was looking at.17:58
mordred(which is honestly how it should have been implemented in the first place)17:58
kmallocmordred: ftr, it seems like autodoc is flaky in keystoneauth now, some patches pass some dont, some environments success and some don't and if they don't they never will.17:59
*** jmlowe has joined #openstack-keystone17:59
kmallocso it might be worth tossing a massive "DO NOT USE THIS" around autodoc in pbr17:59
kmallocif we can't isolate the weirdness.17:59
mordredkmalloc: yah17:59
mordredI should probably just go around making patches to the 12 repos that are using it17:59
kmalloclocally i can't make it work, locally cmurphy can't get it to fail. in the gate we have a mix.17:59
mordredyah. which is ... WEIRD17:59
kmallocnow... i am on 18.04 here18:00
kmallocbut i tried py2.7, 3.5, 3.6 and many many variations on the installed deps18:00
kmallocand it never succeeded18:00
cmurphyoh i finally got it to fail, using a new xenial image18:00
mordred\o/18:00
kmalloccmurphy: *blink* well, that is a plus... i think?18:01
kmallocat least we're trending towards consistent failure :P18:01
cmurphyit's complaining about a different file though :P18:01
kmallocwhich one is it complaining about for you?18:01
cmurphy/home/devuser/keystoneauth/doc/source/api/keystoneauth1.loading.rst:document isn't included in any toctree18:01
kmalloc...18:01
kmallocyeah i think autodoc is weirdly broken18:01
mordredthing is- they SO ARE included in toctrees18:02
kmallocmordred: oh i know they are.18:02
kmalloci see them.18:02
cmurphythe sphinx/pbr integration has been broken like this before https://github.com/sphinx-doc/sphinx/issues/444618:02
kmallochm.18:03
mordredfwiw, stephenfin in that discussion is the one openstack-side who has been advocating for getting autodoc out of pbr18:04
kmallocmordred: Sphinx1.7.4 seems to be the culprit.18:04
kmallocoh wait no18:05
kmallocstill had error off18:05
kmallocsrry18:05
cmurphyi can reproduce with pbr 4.0.2 so it's not that18:07
kmallocyeah no idea, sphinx seems to be working just finx.18:07
kmallocfine* except this error at earlier versions18:07
kmallocsphinx 1.6.5 works18:08
kmallocooookay18:08
kmallocso sphinx 1.7 is busted on this front18:08
kmalloci'm not sure it's worth fixing autodoc if only 12 repos use it18:08
kmallocif we can simply list modules and be ok [not need to do wholesale doc gen]18:08
kmalloci'm not too upset about the change18:08
*** felipemonteiro has quit IRC18:10
kmallocyep, looks like every release of sphinx past 1.6.5 is busted.18:10
* kmalloc refreshes coffee.18:12
*** pcichy has quit IRC18:15
*** gyankum has quit IRC18:24
kmalloccmurphy: holding on +A on the autodoc change until you're ok with it (move your -1 off) or if you have another alternative happy to roll with it18:34
*** felipemonteiro has joined #openstack-keystone18:35
cmurphykmalloc: removing my -1 because i'll be out for the rest of the day and can't help fix it18:39
kmalloccmurphy: ok, if we can re-use autodoc down the line, we can revert this.18:40
kmalloccmurphy: and i'll fast-track revert at that point18:40
kmallocunless pbr drops autodoc... then... well...18:40
cmurphykmalloc: but also as i commented i don't think it's really urgent, https://review.openstack.org/#/c/568365/ is going to pass when the results come back18:41
kmalloccmurphy: my big concern is that is has been inconsistent.18:41
mordredHOW WEIRD18:41
cmurphykmalloc: i agree that's a concern but it's not a blocking-all-work concern18:42
cmurphyanymore18:42
cmurphycomputers suck18:42
mordredthe so suck18:42
kmallocyesssss.18:45
kmallocok so i'll hold it at a +2, if we see more breakage i'll merge18:45
kmallocif it dies down, we can leave it in-queue for now and discuss more down the line18:45
kmallocmake sure we aren't adding too much pain for ourselves18:46
kmalloccmurphy: -1 workflow wile we hold it in the holding pattern18:46
*** jmlowe has quit IRC18:47
*** panbalag has joined #openstack-keystone18:47
lbragstadspeaking of suck... i've been putting of this transient timing issue in tests for too long18:49
lbragstadi need to get around to that today18:49
openstackgerritFelipe Monteiro proposed openstack/keystone-specs master: Patrole (RBAC) Keystone Gating  https://review.openstack.org/46467818:49
*** pcichy has joined #openstack-keystone18:49
*** pcichy has quit IRC18:55
*** edmondsw has joined #openstack-keystone18:57
*** jmlowe has joined #openstack-keystone18:59
*** spilla_ has joined #openstack-keystone19:02
*** spilla has quit IRC19:02
*** panbalag has left #openstack-keystone19:06
lbragstadkmalloc: do you have any ideas on how to make testcase setup thread safe?19:10
*** dklyle has joined #openstack-keystone19:18
*** mvk has joined #openstack-keystone19:22
*** prashkre has joined #openstack-keystone19:22
*** dtroyer has quit IRC19:28
*** dtroyer has joined #openstack-keystone19:28
mordredlbragstad: it should be thread safe already19:28
mordredlbragstad: test parallelism is done with multiple processes19:29
mordredlbragstad: but that's 'should' - what are you running in to?19:29
lbragstadtrue - it might not be the testcase setup then... we have a singleton in keystone to resolve the dependency tree19:29
lbragstadand that gets used in tests19:30
mordredah. yeah. so it's possible one test is mutating it and a following test is getting the dirty object19:30
lbragstadhttps://github.com/openstack/keystone/blob/master/keystone/common/provider_api.py#L34-L5019:30
lbragstadwhich gets invoked by https://github.com/openstack/keystone/blob/master/keystone/server/backends.py#L43-L5319:31
lbragstadspecifically when a manager is instantiated19:31
lbragstadso - i think the problem is when multiple threads are trying to load the backends at the same time?19:31
* lbragstad grabs a trace19:32
*** panbalag has joined #openstack-keystone19:33
*** prashkre has quit IRC19:33
lbragstadhttp://paste.openstack.org/raw/721126/19:34
lbragstadin that case, is the best answer to teach the test setup how to handle the singleton and what to do if it isn't available/19:35
mordredyah ... lemme look at that setup code real quick19:35
mordredlbragstad: keystone/tests/unit/base_classes.py doesn't seem to be in my tree19:36
lbragstadmordred: sorry - https://review.openstack.org/#/c/559129/419:36
lbragstad^ that probably helps19:36
mordredyup!19:36
lbragstadthe commit message of https://review.openstack.org/#/c/558903/ describes what i'm trying to do19:37
mordredoh - actually19:38
mordredIthink it's not even about parallel - tests each run inside of a single python process, and setUp runs at the beginning of each test19:38
mordredso self.bootstrapper = bootstrap.Bootstrapper() in setUp is going to run the bootstrap code a second time19:39
lbragstadyeah - that makes sense19:40
mordredyou might want to just put in a cleanup method that unlocks - or blanks out the registry19:40
mordredsomething something19:40
lbragstadhmm - looks like we do that here - https://github.com/openstack/keystone/blob/master/keystone/tests/unit/core.py#L705 but that's not in base19:40
lbragstadlet me try that quick19:41
mordredyup. I bet that'll do you19:41
*** panbalag has left #openstack-keystone19:42
lbragstadmordred: good call - testing it out quick19:43
mordredlbragstad, kmalloc:I fixed the sdk test that's been holding up the stable/queens ksa requirements sync19:46
mordredas soon as it lands (it passed check) - I'll recheck the requirements patch19:46
kmallocPerfect!19:47
*** david-lyle has joined #openstack-keystone19:49
*** dklyle has quit IRC19:51
openstackgerritLance Bragstad proposed openstack/oslo.policy master: Add examples and clarification around scope_types  https://review.openstack.org/56890119:59
*** sapd_ has joined #openstack-keystone20:00
*** jmlowe has quit IRC20:00
openstackgerritLance Bragstad proposed openstack/keystone master: Decouple bootstrap from cli module  https://review.openstack.org/55890320:03
openstackgerritLance Bragstad proposed openstack/keystone master: Introduce new TokenModel object  https://review.openstack.org/55912920:03
lbragstadsweet ^20:03
lbragstadmordred: i owe you a smoked sandwich of some kind next week20:03
*** sapd has quit IRC20:03
openstackgerritGage Hugo proposed openstack/keystone master: Handle empty token key files  https://review.openstack.org/54678520:04
*** spilla_ has quit IRC20:04
mordredlbragstad: \o/20:05
lbragstadiirc http://www.devilselbowalehouse.com/ is pretty good20:05
lbragstadi remember they had a menu item where you could order a shot of bourbon, a glass of beer, and a cup full of bacon20:06
hrybackithat domain name though -_- 'devil se linu, nope. devil sels, nope. devil's love bowls, nope.'20:07
hrybackianyone else have hard time parsing sentences without spaces?20:07
lbragstadi have a hard time with sentences _with_ spaces20:08
mordred++20:08
mordredhrybacki: I thnk "devil's love bowls" clearlyneeds to be the name of somethign though20:09
lbragstadsounds like a terrifyingly good bbq joint20:09
hrybackilol20:09
mordredif anyone is bored: https://review.openstack.org/#/c/568877/1 and https://review.openstack.org/#/c/568878/1 are both good to go20:16
mordredand https://review.openstack.org/#/c/568640/ is green again lbragstad kmalloc20:17
lbragstadi can review those20:22
mordred\o/20:23
mordredhttps://review.openstack.org/#/c/491947 is another nice and easy one20:24
*** raildo has quit IRC20:31
*** spilla has joined #openstack-keystone20:31
*** oikiki has joined #openstack-keystone20:38
mordredlbragstad: thanks - good catch on the timings patch - update coming that fixes it and adds test coverage for that20:44
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Collect timing information for API calls  https://review.openstack.org/56887720:44
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add oslo.config option for split-loggers  https://review.openstack.org/56887820:44
mordredlbragstad: thereyago20:44
openstackgerritMerged openstack/keystoneauth master: Fix logging of encoded headers  https://review.openstack.org/56836520:45
lbragstadsweet20:46
*** martinus__ has quit IRC20:48
mordredyay thefix landed!20:53
mordredlbragstad, kmalloc: remote:   https://review.openstack.org/568959 Release keystoneauth 3.6.220:54
mordredthere's a releases patch to get a bugfix release out there for the glanceclient bug20:54
*** spilla has quit IRC21:10
*** itlinux has quit IRC21:13
*** panbalag has joined #openstack-keystone21:20
*** panbalag has left #openstack-keystone21:21
*** ztrawhcse is now known as eschwartz21:25
*** oikiki has quit IRC21:29
*** dave-mccowan has quit IRC21:32
lbragstadkmalloc: sweet - it's passing https://review.openstack.org/#/c/559129/521:35
*** d0ugal_ has joined #openstack-keystone21:39
*** dave-mccowan has joined #openstack-keystone21:41
*** d0ugal has quit IRC21:41
*** oikiki has joined #openstack-keystone21:42
*** dave-mcc_ has joined #openstack-keystone21:48
*** dave-mccowan has quit IRC21:48
*** itlinux has joined #openstack-keystone21:51
openstackgerritMerged openstack/keystoneauth master: Return the endpoint_override from EndpointData  https://review.openstack.org/49194721:52
*** oikiki has quit IRC22:03
*** xinran__ has quit IRC22:07
*** mchlumsky has quit IRC22:13
*** rcernin has joined #openstack-keystone22:25
*** andreaf has quit IRC22:29
*** andreaf has joined #openstack-keystone22:29
*** itlinux has quit IRC22:33
*** felipemonteiro has quit IRC22:37
*** d0ugal__ has joined #openstack-keystone22:39
*** d0ugal_ has quit IRC22:41
*** jmlowe has joined #openstack-keystone22:49
*** edmondsw has quit IRC22:50
*** felipemonteiro has joined #openstack-keystone22:59
*** edmondsw has joined #openstack-keystone23:11
*** oikiki has joined #openstack-keystone23:18
*** germs has quit IRC23:33
*** germs has joined #openstack-keystone23:35
*** germs has quit IRC23:35
*** germs has joined #openstack-keystone23:35
*** felipemonteiro has quit IRC23:48

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!