*** eschwartz has quit IRC | 00:00 | |
*** ztrawhcse has joined #openstack-keystone | 00:01 | |
*** dklyle has quit IRC | 00:24 | |
*** dklyle has joined #openstack-keystone | 00:32 | |
*** ztrawhcse is now known as eschwartz | 00:33 | |
*** linhnm has joined #openstack-keystone | 00:33 | |
*** Dinesh_Bhor has joined #openstack-keystone | 00:37 | |
*** spilla has quit IRC | 00:43 | |
*** germs_ has quit IRC | 00:48 | |
*** dklyle has quit IRC | 00:53 | |
*** dave-mcc_ has quit IRC | 00:59 | |
*** edmondsw has joined #openstack-keystone | 01:18 | |
*** dklyle has joined #openstack-keystone | 01:20 | |
*** edmondsw has quit IRC | 01:22 | |
*** dklyle has quit IRC | 01:29 | |
*** r-daneel has quit IRC | 01:30 | |
*** gyee has quit IRC | 01:38 | |
*** gyankum has joined #openstack-keystone | 01:55 | |
*** dave-mccowan has joined #openstack-keystone | 02:03 | |
*** annp has quit IRC | 02:03 | |
*** annp has joined #openstack-keystone | 02:03 | |
*** linhnm has quit IRC | 02:03 | |
*** nicolasbock has quit IRC | 02:24 | |
*** dave-mccowan has quit IRC | 02:32 | |
*** Dinesh__Bhor has joined #openstack-keystone | 03:18 | |
*** annp has quit IRC | 03:20 | |
*** gyankum has quit IRC | 03:20 | |
*** Dinesh_Bhor has quit IRC | 03:21 | |
*** panbalag has joined #openstack-keystone | 03:24 | |
*** panbalag has left #openstack-keystone | 03:24 | |
*** links has joined #openstack-keystone | 03:41 | |
*** sonuk has joined #openstack-keystone | 03:56 | |
*** gyankum has joined #openstack-keystone | 04:10 | |
*** edmondsw has joined #openstack-keystone | 04:32 | |
*** brad[] has quit IRC | 04:33 | |
Shilpa | cmurphy: hi | 04:35 |
---|---|---|
*** jaosorior has quit IRC | 04:40 | |
*** jaosorior has joined #openstack-keystone | 04:47 | |
*** jaosorior has quit IRC | 04:54 | |
*** Dinesh__Bhor has quit IRC | 05:00 | |
*** jaosorior has joined #openstack-keystone | 05:02 | |
*** sapd has quit IRC | 05:17 | |
*** annp has joined #openstack-keystone | 05:34 | |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert Keystone to use Flask https://review.openstack.org/568377 | 05:36 |
*** Dinesh_Bhor has joined #openstack-keystone | 05:42 | |
*** sapd has joined #openstack-keystone | 05:56 | |
wxy | lbragstad: Re https://review.openstack.org/#/c/568541, the "project_id" in "create_limits" is designed as that the admin can create limit for different projects. | 06:24 |
wxy | The policy is admin_required and system scoped by default. https://github.com/openstack/keystone/blob/master/keystone/common/policies/limit.py#L42-L48 | 06:26 |
*** Dinesh_Bhor has quit IRC | 06:28 | |
wxy | I think the "project_id" can be optional and be pulled from the token. | 06:29 |
*** martinus__ has joined #openstack-keystone | 06:43 | |
*** edmondsw has quit IRC | 06:49 | |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Remove some unused functions https://review.openstack.org/568429 | 07:01 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Remove eventlet related configuration https://review.openstack.org/568764 | 07:01 |
*** rcernin has quit IRC | 07:10 | |
*** tesseract has joined #openstack-keystone | 07:17 | |
*** bhagyashri_s has quit IRC | 07:36 | |
*** bhagyashri_s has joined #openstack-keystone | 07:37 | |
*** aloga has joined #openstack-keystone | 07:39 | |
openstackgerrit | Merged openstack/oslo.policy master: Include both new and deprecated rules in generated sample https://review.openstack.org/568676 | 07:40 |
*** AlexeyAbashkin has joined #openstack-keystone | 07:42 | |
*** dims has quit IRC | 07:59 | |
*** dims has joined #openstack-keystone | 08:02 | |
*** dims has quit IRC | 08:07 | |
*** dims has joined #openstack-keystone | 08:07 | |
*** edmondsw has joined #openstack-keystone | 08:20 | |
*** edmondsw has quit IRC | 08:25 | |
*** links has quit IRC | 09:07 | |
*** jistr has quit IRC | 09:09 | |
*** jistr has joined #openstack-keystone | 09:12 | |
*** links has joined #openstack-keystone | 09:23 | |
*** myrat has joined #openstack-keystone | 09:47 | |
*** ispp has joined #openstack-keystone | 09:49 | |
*** ispp has left #openstack-keystone | 09:50 | |
*** ispp has quit IRC | 09:50 | |
*** issp has joined #openstack-keystone | 09:50 | |
*** issp has quit IRC | 09:50 | |
*** ispp has joined #openstack-keystone | 09:51 | |
*** ispp has quit IRC | 09:51 | |
*** ispp has joined #openstack-keystone | 09:52 | |
myrat | i write the command openstack create -enable --description "First project" P01 | 09:52 |
myrat | then i got error Missing value auth-urk required for auth plugin password | 09:52 |
*** edmondsw has joined #openstack-keystone | 10:08 | |
*** sapd has quit IRC | 10:10 | |
*** sapd has joined #openstack-keystone | 10:11 | |
*** edmondsw has quit IRC | 10:13 | |
*** obre has quit IRC | 10:25 | |
*** obre has joined #openstack-keystone | 10:25 | |
*** obre has quit IRC | 10:28 | |
*** obre has joined #openstack-keystone | 10:28 | |
*** nicolasbock has joined #openstack-keystone | 10:32 | |
*** dave-mccowan has joined #openstack-keystone | 10:42 | |
*** links has quit IRC | 10:44 | |
*** pooja_jadhav has quit IRC | 10:54 | |
*** nicolasbock has quit IRC | 10:54 | |
*** links has joined #openstack-keystone | 10:58 | |
*** ispp has quit IRC | 11:04 | |
*** ispp has joined #openstack-keystone | 11:06 | |
*** nicolasbock has joined #openstack-keystone | 11:10 | |
*** Shilpa has quit IRC | 11:22 | |
*** jaosorior has quit IRC | 11:23 | |
*** jaosorior has joined #openstack-keystone | 11:42 | |
*** raildo has joined #openstack-keystone | 11:44 | |
*** rmascena has joined #openstack-keystone | 11:44 | |
*** pooja_jadhav has joined #openstack-keystone | 11:54 | |
*** bhagyashri_s has quit IRC | 11:55 | |
*** edmondsw has joined #openstack-keystone | 11:57 | |
*** edmondsw has quit IRC | 12:01 | |
*** panbalag has joined #openstack-keystone | 12:02 | |
*** ispp has quit IRC | 12:03 | |
*** edmondsw has joined #openstack-keystone | 12:07 | |
*** edmondsw has quit IRC | 12:07 | |
*** ispp has joined #openstack-keystone | 12:14 | |
*** bhagyashris has joined #openstack-keystone | 12:28 | |
*** dklyle has joined #openstack-keystone | 12:30 | |
*** edmondsw has joined #openstack-keystone | 12:36 | |
*** myrat has quit IRC | 12:38 | |
*** dklyle has quit IRC | 12:39 | |
*** r-daneel has joined #openstack-keystone | 12:47 | |
*** panbalag has left #openstack-keystone | 12:49 | |
*** felipemonteiro has joined #openstack-keystone | 12:59 | |
*** rmascena has quit IRC | 13:01 | |
*** pcichy has joined #openstack-keystone | 13:01 | |
*** felipemonteiro has quit IRC | 13:03 | |
hrybacki | o/ | 13:09 |
*** r-daneel_ has joined #openstack-keystone | 13:15 | |
*** Shilpa has joined #openstack-keystone | 13:16 | |
*** r-daneel has quit IRC | 13:16 | |
*** r-daneel_ is now known as r-daneel | 13:16 | |
*** brad[] has joined #openstack-keystone | 13:23 | |
*** spilla has joined #openstack-keystone | 13:32 | |
lbragstad | o/ | 13:34 |
lbragstad | wxy: oh - cool | 13:34 |
lbragstad | wxy: so then as we remove the @protected decorator, we can clarify those cases in the API | 13:35 |
*** sonuk has quit IRC | 13:44 | |
*** prashkre has joined #openstack-keystone | 13:45 | |
prashkre | lbragstad: Hi. Good morning!. | 13:47 |
lbragstad | prashkre: o/ | 13:47 |
prashkre | lbragstad: please review https://review.openstack.org/#/c/568373/ when you have time today. | 13:47 |
lbragstad | prashkre: sounds good - i'll have a look | 13:52 |
*** mvk has quit IRC | 13:52 | |
prashkre | lbragstad: Thank you! | 14:00 |
*** nicolasbock has quit IRC | 14:06 | |
*** xinran__ has joined #openstack-keystone | 14:06 | |
hrybacki | knikolla: if create_project_tags are admin specific api actions, would update_project_tags also fall into admin actions? | 14:07 |
*** gyankum has quit IRC | 14:09 | |
*** r-daneel has quit IRC | 14:20 | |
*** nicolasbock has joined #openstack-keystone | 14:23 | |
*** felipemonteiro has joined #openstack-keystone | 14:25 | |
*** germs has joined #openstack-keystone | 14:27 | |
*** germs has quit IRC | 14:27 | |
*** germs has joined #openstack-keystone | 14:27 | |
hrybacki | felipemonteiro: I can't recall -- were you going to be in attendance at Summit? | 14:27 |
felipemonteiro | hrybacki: yes, whole week | 14:27 |
hrybacki | felipemonteiro: excellent me too -- my calendar is pretty packed up but I'd like to sit down with you for 30 mins at some point if possible | 14:28 |
*** mvk has joined #openstack-keystone | 14:29 | |
felipemonteiro | hrybacki: i'd like that, i guess we can coordinate over irc? there's another patrole core also going, rick bartra | 14:31 |
hrybacki | felipemonteiro: irc works for me. Freenode is always live on my phone | 14:31 |
hrybacki | and I may install twitter for the conf. @harryrybacki | 14:32 |
*** germs has quit IRC | 14:32 | |
felipemonteiro | it's also on my phone, it's just a matter of paying better attention to it :) | 14:32 |
*** prashkre has quit IRC | 14:34 | |
lbragstad | what are you using for irc apps? | 14:37 |
lbragstad | or a mobile irc client? | 14:37 |
hrybacki | lbragstad: I use irccloud | 14:38 |
lbragstad | ahh | 14:38 |
hrybacki | $5/mo but the web client is a decent bouncer and the mobile app is pretty alright | 14:38 |
*** r-daneel has joined #openstack-keystone | 14:38 | |
hrybacki | honestly one of my better monthly subscriptions | 14:39 |
*** felipemonteiro_ has joined #openstack-keystone | 14:41 | |
*** felipemonteiro has quit IRC | 14:44 | |
*** Alexey_Abashkin has joined #openstack-keystone | 14:44 | |
*** felipemonteiro has joined #openstack-keystone | 14:44 | |
*** AlexeyAbashkin has quit IRC | 14:46 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 14:46 | |
*** felipemonteiro_ has quit IRC | 14:46 | |
*** ksavich has joined #openstack-keystone | 14:49 | |
*** dklyle has joined #openstack-keystone | 14:53 | |
*** ispp has quit IRC | 14:57 | |
*** links has quit IRC | 14:58 | |
*** ispp has joined #openstack-keystone | 15:05 | |
gagehugo | o/ | 15:10 |
*** dklyle has quit IRC | 15:12 | |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Collect timing information for API calls https://review.openstack.org/568877 | 15:16 |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add oslo.config option for split-loggers https://review.openstack.org/568878 | 15:16 |
mordred | cmurphy: do you remember who is was who was asking about how to support split-loggers in services a while back? | 15:16 |
mordred | I wanna say it was bhagyashris ... | 15:17 |
mordred | bhagyashris: ^^ were you the one asking about split loggers in config files? | 15:17 |
*** dklyle has joined #openstack-keystone | 15:18 | |
*** prashkre has joined #openstack-keystone | 15:19 | |
mordred | or was it pooja_jadhav ? | 15:22 |
* mordred has bad memory | 15:22 | |
*** prashkre has quit IRC | 15:24 | |
*** dklyle has quit IRC | 15:24 | |
*** dklyle has joined #openstack-keystone | 15:26 | |
*** ispp has quit IRC | 15:27 | |
ayoung | mordred, kmalloc who drove and what was the thing about short term X509 certs from a few years back? | 15:27 |
ayoung | IIRC it was the head of the Security group, and he worked for ... HPE? | 15:28 |
ayoung | they had a CA with 1 hour X509 certs, or something? | 15:28 |
mordred | ayoung: I have no memory of such a thing | 15:29 |
ayoung | mordred, the dude that was the head of the security group...can't remember his name | 15:30 |
ayoung | Rob Clack | 15:30 |
ayoung | Clark | 15:30 |
mordred | yah. I can see his face but am going blank on his ...yes | 15:30 |
mordred | i believe he's at IBM now in Ben de Bont's team | 15:30 |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Return the endpoint_override from EndpointData https://review.openstack.org/491947 | 15:30 |
*** dklyle has quit IRC | 15:31 | |
ayoung | Got it. thanks | 15:32 |
ayoung | Anchor! | 15:34 |
*** gyankum has joined #openstack-keystone | 15:39 | |
cmurphy | mordred: it was pooja_jadhav | 15:43 |
cmurphy | at least that was one person asking about it recently | 15:44 |
mordred | cmurphy: cool | 15:47 |
mordred | cmurphy: thanks! | 15:47 |
mordred | pooja_jadhav: the patch I just pushed up, https://review.openstack.org/568878 - should do what you're looking for | 15:48 |
mordred | cmurphy: also, that patch might explain better what his issue was | 15:48 |
*** pcichy has quit IRC | 15:51 | |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Stop using pbr autodoc https://review.openstack.org/568889 | 15:56 |
mordred | kmalloc: ^^ there's a stab at dealing with the doc situation - and also making there be less magic in our docs build | 15:57 |
kmalloc | mordred: tnhx | 16:04 |
kmalloc | i was trying to figure that out last night | 16:04 |
*** itlinux has joined #openstack-keystone | 16:05 | |
itlinux | hello guys.. I have AD enabled and at times I get this error An unexpected error prevented the server from fulfilling your request. (HTTP 500) | 16:05 |
*** rmascena has joined #openstack-keystone | 16:05 | |
*** rmascena is now known as raildo_ | 16:05 | |
itlinux | can someone point me what could be the cause.. | 16:06 |
itlinux | I can telnet to ldaps port server fine | 16:06 |
itlinux | Galera is running in HA mode | 16:06 |
kmalloc | ayoung: i don't remember either, but it was called ephemeral ssl i think | 16:07 |
kmalloc | ayoung: something like that | 16:07 |
*** raildo has quit IRC | 16:08 | |
kmalloc | mordred: ftr, i don't mind autodoc from PBR | 16:08 |
kmalloc | mordred: i was wondering why it suddently lost a file though | 16:09 |
*** jmlowe has quit IRC | 16:09 | |
kmalloc | lost a file from the toctree | 16:09 |
*** edmondsw has quit IRC | 16:15 | |
mordred | kmalloc: yah - me too. I looked at that for a while and could not see a reason forit | 16:15 |
mordred | kmalloc: also - I hope you enjoy the little collection of ksa patches I made for you this morning :) | 16:17 |
kmalloc | mordred: hehe | 16:17 |
kmalloc | i think there is something weird in how we are doing sphinx in ksa... | 16:18 |
kmalloc | did we have a new PBR release recently? | 16:18 |
kmalloc | anyway, looking at the KSA stuff once i get coffee in my system :) | 16:18 |
kmalloc | and once the doc fix check passes, it's gettnig merged | 16:18 |
*** edmondsw_ has joined #openstack-keystone | 16:18 | |
ayoung | kmalloc, it was Anchor, and yeah, Ephemeral was the key word | 16:20 |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Allow registering additional plugin loaders https://review.openstack.org/333126 | 16:20 |
*** edmondsw_ has quit IRC | 16:23 | |
*** germs has joined #openstack-keystone | 16:28 | |
*** germs has quit IRC | 16:28 | |
*** germs has joined #openstack-keystone | 16:28 | |
mordred | kmalloc: I went and abandoned a few patches that were old and pretty certainly either abandoned or irrelegant at this point. https://review.openstack.org/#/q/project:openstack/keystoneauth+status:open is actually not a bad list now - 6 out of the 9 should be landable short-term- of the remaining 3 one is blocked on sdk (which Im trying to get fixed today) one is in active work - and one seems like | 16:28 |
mordred | a good idea but may need a little more work | 16:28 |
mordred | lbragstad: ^^ | 16:28 |
lbragstad | mordred: ack - thanks for the heads up | 16:28 |
*** gyee has joined #openstack-keystone | 16:29 | |
*** felipemonteiro has quit IRC | 16:31 | |
*** germs has quit IRC | 16:32 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.policy master: Include deprecated_reason when deprecated_rule is set https://review.openstack.org/568687 | 16:35 |
*** itlinux has quit IRC | 16:36 | |
kmalloc | lbragstad: hmm. this flask conversion is getting complex. | 16:38 |
kmalloc | lbragstad: because... webob vs werkzeug | 16:38 |
*** felipemonteiro has joined #openstack-keystone | 16:38 | |
lbragstad | we already use webob | 16:39 |
lbragstad | does it not integrate well with webob? | 16:39 |
*** felipemonteiro has quit IRC | 16:45 | |
openstackgerrit | Merged openstack/keystone master: Remove some unused functions https://review.openstack.org/568429 | 16:45 |
openstackgerrit | Merged openstack/keystone master: Add conceptual overview of the service catalog https://review.openstack.org/563974 | 16:45 |
kmalloc | lbragstad: it is looking like webob and werkzeug are two implementations of the same concept | 16:48 |
kmalloc | and flask leans on werkzeug | 16:48 |
lbragstad | bah | 16:48 |
kmalloc | webob is related to paste. | 16:48 |
kmalloc | the issue i'm running into is middleware. | 16:49 |
kmalloc | because it is assumed we're webob.dec.wsgify it | 16:49 |
lbragstad | i wonder how hard it would be to convert to werkzeug | 16:49 |
kmalloc | that is what i'm looking at, but all the external middleware is webob | 16:49 |
kmalloc | seeing if i can make them play nice. | 16:49 |
*** links has joined #openstack-keystone | 16:54 | |
kmalloc | lbragstad: we may not be able to use flask easily | 16:56 |
kmalloc | lbragstad: we may be better off looking at pyramid or something similar | 16:56 |
lbragstad | hmm | 16:56 |
kmalloc | that is webob based. | 16:56 |
*** felipemonteiro has joined #openstack-keystone | 16:56 | |
*** raildo_ is now known as raildo | 16:58 | |
kmalloc | or we could look into something like falcon. | 16:59 |
openstackgerrit | Lance Bragstad proposed openstack/oslo.policy master: Add examples and clarification around scope_types https://review.openstack.org/568901 | 16:59 |
lbragstad | falcon is nice | 16:59 |
lbragstad | from the examples i've seen or the services i've seen use it | 17:00 |
*** panbalag has joined #openstack-keystone | 17:00 | |
*** panbalag has left #openstack-keystone | 17:00 | |
*** felipemonteiro has quit IRC | 17:03 | |
* lbragstad breaks to get a run in over lunch | 17:03 | |
*** felipemonteiro has joined #openstack-keystone | 17:04 | |
*** germs has joined #openstack-keystone | 17:04 | |
*** germs has quit IRC | 17:04 | |
*** germs has joined #openstack-keystone | 17:04 | |
*** germs has quit IRC | 17:04 | |
*** germs has joined #openstack-keystone | 17:05 | |
*** germs has quit IRC | 17:05 | |
*** germs has joined #openstack-keystone | 17:05 | |
*** germs has quit IRC | 17:05 | |
kmalloc | lbragstad: yeah. | 17:05 |
*** germs has joined #openstack-keystone | 17:06 | |
kmalloc | lbragstad: /me gets ready to throw out a couple days of work and take another hack at this. | 17:06 |
kmalloc | lbragstad: looks like falcon at least plays nice with webob based middleware. | 17:06 |
*** germs has quit IRC | 17:06 | |
kmalloc | cmurphy: the autodoc issue with ksa both mordred and I looked at, this might be just a stop-gap | 17:07 |
*** ksavich has quit IRC | 17:07 | |
kmalloc | cmurphy: i watn to use autodoc, but somehow we're losing a file from the toctree | 17:07 |
kmalloc | cmurphy: and it's breaking every single patch to ksa. | 17:07 |
*** germs has joined #openstack-keystone | 17:07 | |
kmalloc | and... this might be a bug in pbr 4.0.3 | 17:09 |
*** pcichy has joined #openstack-keystone | 17:10 | |
*** itlinux has joined #openstack-keystone | 17:12 | |
kmalloc | cmurphy: nope, i am really unsure what changed... it was *just* working | 17:14 |
cmurphy | pbr did just release 37 hours ago which was around the time it broke, but i can't reproduce it with pbr 4.0.3 yet | 17:15 |
*** links has quit IRC | 17:16 | |
*** AlexeyAbashkin has quit IRC | 17:16 | |
*** spilla has quit IRC | 17:18 | |
*** spilla has joined #openstack-keystone | 17:21 | |
*** tesseract has quit IRC | 17:27 | |
*** mvk has quit IRC | 17:27 | |
openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: [DNM] See if latest pbr is causing our docs problems https://review.openstack.org/568909 | 17:33 |
cmurphy | kmalloc: mordred seems magically fixed? https://review.openstack.org/#/c/568877 unless i'm missing a relationship with 568889 somewhere | 17:36 |
*** eschwartz has quit IRC | 17:39 | |
kmalloc | cmurphy: i hate magic | 17:40 |
kmalloc | :P | 17:40 |
kmalloc | trying a clean rebuild of my environment | 17:40 |
kmalloc | fwiw, i was getting the same xactl error locally | 17:40 |
kmalloc | Still am | 17:41 |
kmalloc | clean tox environment | 17:41 |
kmalloc | cmurphy: ... *blink* | 17:43 |
kmalloc | i don't know how this is working. | 17:43 |
kmalloc | i can't get it to work locally | 17:43 |
gagehugo | magic | 17:44 |
*** ztrawhcse has joined #openstack-keystone | 17:45 | |
kmalloc | yep, i cannot build the docs locally at all | 17:45 |
cmurphy | i can't reproduce the problem at all | 17:47 |
kmalloc | cmurphy: this is highly frustrating. =/ | 17:47 |
cmurphy | :( | 17:48 |
kmalloc | i just don't know what could be making this work/notwork in various environments | 17:48 |
kmalloc | i'd hope that it was relatively the same | 17:48 |
kmalloc | i've tried python2.7, pyton3.6, python 3.5, master, different versions of pbr, different versions of sphinx, different hashes [known to work] of keystoneauth | 17:49 |
kmalloc | i think i've spent now 3 hours of trying to figure out how in the heck we've lost a file in the toctree | 17:49 |
kmalloc | i mean, i knidof just want to turn off warning-as-error for the moment. | 17:50 |
cmurphy | i would support turning off warning-is-error more than abandoning autodoc altogether as a stopgap | 17:51 |
kmalloc | cmurphy: and i'm not seeing how it's possible to turn warning-as-error off | 17:53 |
kmalloc | there is a sphinx flag to enable that | 17:53 |
kmalloc | and i think we somehow magically enable it | 17:53 |
kmalloc | i'm... very displeased with the volume of magic in our doc build | 17:54 |
cmurphy | it's in setup.cfg | 17:55 |
mordred | cmurphy: fwiw, almost nobody uses the autodoc feature in openstack anymore | 17:55 |
mordred | 12 repos, to be precise | 17:55 |
cmurphy | mordred: what's the alternative? is everyone really manually curating api docs? | 17:55 |
kmalloc | cmurphy: thnx. | 17:56 |
mordred | yeah ... I mean- you don't need to manually curate all the docs - just the list of modules - so the only skew really comes when you add a new module and don't reference it anywhere | 17:56 |
kmalloc | mordred: so your fix seems to nuke a doc file, fwiw. | 17:57 |
mordred | kmalloc: it does? bother | 17:57 |
kmalloc | mordred: is there a plan to drop autodoc feature from pbr | 17:57 |
mordred | kmalloc: there are definitely people who would like to - but I don't know if it's gotten as far as a 'plan' | 17:58 |
kmalloc | mordred: oh no it doesn't | 17:58 |
kmalloc | mordred: nvm, i was mis-reading | 17:58 |
mordred | there was also talk about taking the feature and turning it in to a sphinx plugin | 17:58 |
kmalloc | i inverted the diff i was looking at. | 17:58 |
mordred | (which is honestly how it should have been implemented in the first place) | 17:58 |
kmalloc | mordred: ftr, it seems like autodoc is flaky in keystoneauth now, some patches pass some dont, some environments success and some don't and if they don't they never will. | 17:59 |
*** jmlowe has joined #openstack-keystone | 17:59 | |
kmalloc | so it might be worth tossing a massive "DO NOT USE THIS" around autodoc in pbr | 17:59 |
kmalloc | if we can't isolate the weirdness. | 17:59 |
mordred | kmalloc: yah | 17:59 |
mordred | I should probably just go around making patches to the 12 repos that are using it | 17:59 |
kmalloc | locally i can't make it work, locally cmurphy can't get it to fail. in the gate we have a mix. | 17:59 |
mordred | yah. which is ... WEIRD | 17:59 |
kmalloc | now... i am on 18.04 here | 18:00 |
kmalloc | but i tried py2.7, 3.5, 3.6 and many many variations on the installed deps | 18:00 |
kmalloc | and it never succeeded | 18:00 |
cmurphy | oh i finally got it to fail, using a new xenial image | 18:00 |
mordred | \o/ | 18:00 |
kmalloc | cmurphy: *blink* well, that is a plus... i think? | 18:01 |
kmalloc | at least we're trending towards consistent failure :P | 18:01 |
cmurphy | it's complaining about a different file though :P | 18:01 |
kmalloc | which one is it complaining about for you? | 18:01 |
cmurphy | /home/devuser/keystoneauth/doc/source/api/keystoneauth1.loading.rst:document isn't included in any toctree | 18:01 |
kmalloc | ... | 18:01 |
kmalloc | yeah i think autodoc is weirdly broken | 18:01 |
mordred | thing is- they SO ARE included in toctrees | 18:02 |
kmalloc | mordred: oh i know they are. | 18:02 |
kmalloc | i see them. | 18:02 |
cmurphy | the sphinx/pbr integration has been broken like this before https://github.com/sphinx-doc/sphinx/issues/4446 | 18:02 |
kmalloc | hm. | 18:03 |
mordred | fwiw, stephenfin in that discussion is the one openstack-side who has been advocating for getting autodoc out of pbr | 18:04 |
kmalloc | mordred: Sphinx1.7.4 seems to be the culprit. | 18:04 |
kmalloc | oh wait no | 18:05 |
kmalloc | still had error off | 18:05 |
kmalloc | srry | 18:05 |
cmurphy | i can reproduce with pbr 4.0.2 so it's not that | 18:07 |
kmalloc | yeah no idea, sphinx seems to be working just finx. | 18:07 |
kmalloc | fine* except this error at earlier versions | 18:07 |
kmalloc | sphinx 1.6.5 works | 18:08 |
kmalloc | ooookay | 18:08 |
kmalloc | so sphinx 1.7 is busted on this front | 18:08 |
kmalloc | i'm not sure it's worth fixing autodoc if only 12 repos use it | 18:08 |
kmalloc | if we can simply list modules and be ok [not need to do wholesale doc gen] | 18:08 |
kmalloc | i'm not too upset about the change | 18:08 |
*** felipemonteiro has quit IRC | 18:10 | |
kmalloc | yep, looks like every release of sphinx past 1.6.5 is busted. | 18:10 |
* kmalloc refreshes coffee. | 18:12 | |
*** pcichy has quit IRC | 18:15 | |
*** gyankum has quit IRC | 18:24 | |
kmalloc | cmurphy: holding on +A on the autodoc change until you're ok with it (move your -1 off) or if you have another alternative happy to roll with it | 18:34 |
*** felipemonteiro has joined #openstack-keystone | 18:35 | |
cmurphy | kmalloc: removing my -1 because i'll be out for the rest of the day and can't help fix it | 18:39 |
kmalloc | cmurphy: ok, if we can re-use autodoc down the line, we can revert this. | 18:40 |
kmalloc | cmurphy: and i'll fast-track revert at that point | 18:40 |
kmalloc | unless pbr drops autodoc... then... well... | 18:40 |
cmurphy | kmalloc: but also as i commented i don't think it's really urgent, https://review.openstack.org/#/c/568365/ is going to pass when the results come back | 18:41 |
kmalloc | cmurphy: my big concern is that is has been inconsistent. | 18:41 |
mordred | HOW WEIRD | 18:41 |
cmurphy | kmalloc: i agree that's a concern but it's not a blocking-all-work concern | 18:42 |
cmurphy | anymore | 18:42 |
cmurphy | computers suck | 18:42 |
mordred | the so suck | 18:42 |
kmalloc | yesssss. | 18:45 |
kmalloc | ok so i'll hold it at a +2, if we see more breakage i'll merge | 18:45 |
kmalloc | if it dies down, we can leave it in-queue for now and discuss more down the line | 18:45 |
kmalloc | make sure we aren't adding too much pain for ourselves | 18:46 |
kmalloc | cmurphy: -1 workflow wile we hold it in the holding pattern | 18:46 |
*** jmlowe has quit IRC | 18:47 | |
*** panbalag has joined #openstack-keystone | 18:47 | |
lbragstad | speaking of suck... i've been putting of this transient timing issue in tests for too long | 18:49 |
lbragstad | i need to get around to that today | 18:49 |
openstackgerrit | Felipe Monteiro proposed openstack/keystone-specs master: Patrole (RBAC) Keystone Gating https://review.openstack.org/464678 | 18:49 |
*** pcichy has joined #openstack-keystone | 18:49 | |
*** pcichy has quit IRC | 18:55 | |
*** edmondsw has joined #openstack-keystone | 18:57 | |
*** jmlowe has joined #openstack-keystone | 18:59 | |
*** spilla_ has joined #openstack-keystone | 19:02 | |
*** spilla has quit IRC | 19:02 | |
*** panbalag has left #openstack-keystone | 19:06 | |
lbragstad | kmalloc: do you have any ideas on how to make testcase setup thread safe? | 19:10 |
*** dklyle has joined #openstack-keystone | 19:18 | |
*** mvk has joined #openstack-keystone | 19:22 | |
*** prashkre has joined #openstack-keystone | 19:22 | |
*** dtroyer has quit IRC | 19:28 | |
*** dtroyer has joined #openstack-keystone | 19:28 | |
mordred | lbragstad: it should be thread safe already | 19:28 |
mordred | lbragstad: test parallelism is done with multiple processes | 19:29 |
mordred | lbragstad: but that's 'should' - what are you running in to? | 19:29 |
lbragstad | true - it might not be the testcase setup then... we have a singleton in keystone to resolve the dependency tree | 19:29 |
lbragstad | and that gets used in tests | 19:30 |
mordred | ah. yeah. so it's possible one test is mutating it and a following test is getting the dirty object | 19:30 |
lbragstad | https://github.com/openstack/keystone/blob/master/keystone/common/provider_api.py#L34-L50 | 19:30 |
lbragstad | which gets invoked by https://github.com/openstack/keystone/blob/master/keystone/server/backends.py#L43-L53 | 19:31 |
lbragstad | specifically when a manager is instantiated | 19:31 |
lbragstad | so - i think the problem is when multiple threads are trying to load the backends at the same time? | 19:31 |
* lbragstad grabs a trace | 19:32 | |
*** panbalag has joined #openstack-keystone | 19:33 | |
*** prashkre has quit IRC | 19:33 | |
lbragstad | http://paste.openstack.org/raw/721126/ | 19:34 |
lbragstad | in that case, is the best answer to teach the test setup how to handle the singleton and what to do if it isn't available/ | 19:35 |
mordred | yah ... lemme look at that setup code real quick | 19:35 |
mordred | lbragstad: keystone/tests/unit/base_classes.py doesn't seem to be in my tree | 19:36 |
lbragstad | mordred: sorry - https://review.openstack.org/#/c/559129/4 | 19:36 |
lbragstad | ^ that probably helps | 19:36 |
mordred | yup! | 19:36 |
lbragstad | the commit message of https://review.openstack.org/#/c/558903/ describes what i'm trying to do | 19:37 |
mordred | oh - actually | 19:38 |
mordred | Ithink it's not even about parallel - tests each run inside of a single python process, and setUp runs at the beginning of each test | 19:38 |
mordred | so self.bootstrapper = bootstrap.Bootstrapper() in setUp is going to run the bootstrap code a second time | 19:39 |
lbragstad | yeah - that makes sense | 19:40 |
mordred | you might want to just put in a cleanup method that unlocks - or blanks out the registry | 19:40 |
mordred | something something | 19:40 |
lbragstad | hmm - looks like we do that here - https://github.com/openstack/keystone/blob/master/keystone/tests/unit/core.py#L705 but that's not in base | 19:40 |
lbragstad | let me try that quick | 19:41 |
mordred | yup. I bet that'll do you | 19:41 |
*** panbalag has left #openstack-keystone | 19:42 | |
lbragstad | mordred: good call - testing it out quick | 19:43 |
mordred | lbragstad, kmalloc:I fixed the sdk test that's been holding up the stable/queens ksa requirements sync | 19:46 |
mordred | as soon as it lands (it passed check) - I'll recheck the requirements patch | 19:46 |
kmalloc | Perfect! | 19:47 |
*** david-lyle has joined #openstack-keystone | 19:49 | |
*** dklyle has quit IRC | 19:51 | |
openstackgerrit | Lance Bragstad proposed openstack/oslo.policy master: Add examples and clarification around scope_types https://review.openstack.org/568901 | 19:59 |
*** sapd_ has joined #openstack-keystone | 20:00 | |
*** jmlowe has quit IRC | 20:00 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Decouple bootstrap from cli module https://review.openstack.org/558903 | 20:03 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Introduce new TokenModel object https://review.openstack.org/559129 | 20:03 |
lbragstad | sweet ^ | 20:03 |
lbragstad | mordred: i owe you a smoked sandwich of some kind next week | 20:03 |
*** sapd has quit IRC | 20:03 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Handle empty token key files https://review.openstack.org/546785 | 20:04 |
*** spilla_ has quit IRC | 20:04 | |
mordred | lbragstad: \o/ | 20:05 |
lbragstad | iirc http://www.devilselbowalehouse.com/ is pretty good | 20:05 |
lbragstad | i remember they had a menu item where you could order a shot of bourbon, a glass of beer, and a cup full of bacon | 20:06 |
hrybacki | that domain name though -_- 'devil se linu, nope. devil sels, nope. devil's love bowls, nope.' | 20:07 |
hrybacki | anyone else have hard time parsing sentences without spaces? | 20:07 |
lbragstad | i have a hard time with sentences _with_ spaces | 20:08 |
mordred | ++ | 20:08 |
mordred | hrybacki: I thnk "devil's love bowls" clearlyneeds to be the name of somethign though | 20:09 |
lbragstad | sounds like a terrifyingly good bbq joint | 20:09 |
hrybacki | lol | 20:09 |
mordred | if anyone is bored: https://review.openstack.org/#/c/568877/1 and https://review.openstack.org/#/c/568878/1 are both good to go | 20:16 |
mordred | and https://review.openstack.org/#/c/568640/ is green again lbragstad kmalloc | 20:17 |
lbragstad | i can review those | 20:22 |
mordred | \o/ | 20:23 |
mordred | https://review.openstack.org/#/c/491947 is another nice and easy one | 20:24 |
*** raildo has quit IRC | 20:31 | |
*** spilla has joined #openstack-keystone | 20:31 | |
*** oikiki has joined #openstack-keystone | 20:38 | |
mordred | lbragstad: thanks - good catch on the timings patch - update coming that fixes it and adds test coverage for that | 20:44 |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Collect timing information for API calls https://review.openstack.org/568877 | 20:44 |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add oslo.config option for split-loggers https://review.openstack.org/568878 | 20:44 |
mordred | lbragstad: thereyago | 20:44 |
openstackgerrit | Merged openstack/keystoneauth master: Fix logging of encoded headers https://review.openstack.org/568365 | 20:45 |
lbragstad | sweet | 20:46 |
*** martinus__ has quit IRC | 20:48 | |
mordred | yay thefix landed! | 20:53 |
mordred | lbragstad, kmalloc: remote: https://review.openstack.org/568959 Release keystoneauth 3.6.2 | 20:54 |
mordred | there's a releases patch to get a bugfix release out there for the glanceclient bug | 20:54 |
*** spilla has quit IRC | 21:10 | |
*** itlinux has quit IRC | 21:13 | |
*** panbalag has joined #openstack-keystone | 21:20 | |
*** panbalag has left #openstack-keystone | 21:21 | |
*** ztrawhcse is now known as eschwartz | 21:25 | |
*** oikiki has quit IRC | 21:29 | |
*** dave-mccowan has quit IRC | 21:32 | |
lbragstad | kmalloc: sweet - it's passing https://review.openstack.org/#/c/559129/5 | 21:35 |
*** d0ugal_ has joined #openstack-keystone | 21:39 | |
*** dave-mccowan has joined #openstack-keystone | 21:41 | |
*** d0ugal has quit IRC | 21:41 | |
*** oikiki has joined #openstack-keystone | 21:42 | |
*** dave-mcc_ has joined #openstack-keystone | 21:48 | |
*** dave-mccowan has quit IRC | 21:48 | |
*** itlinux has joined #openstack-keystone | 21:51 | |
openstackgerrit | Merged openstack/keystoneauth master: Return the endpoint_override from EndpointData https://review.openstack.org/491947 | 21:52 |
*** oikiki has quit IRC | 22:03 | |
*** xinran__ has quit IRC | 22:07 | |
*** mchlumsky has quit IRC | 22:13 | |
*** rcernin has joined #openstack-keystone | 22:25 | |
*** andreaf has quit IRC | 22:29 | |
*** andreaf has joined #openstack-keystone | 22:29 | |
*** itlinux has quit IRC | 22:33 | |
*** felipemonteiro has quit IRC | 22:37 | |
*** d0ugal__ has joined #openstack-keystone | 22:39 | |
*** d0ugal_ has quit IRC | 22:41 | |
*** jmlowe has joined #openstack-keystone | 22:49 | |
*** edmondsw has quit IRC | 22:50 | |
*** felipemonteiro has joined #openstack-keystone | 22:59 | |
*** edmondsw has joined #openstack-keystone | 23:11 | |
*** oikiki has joined #openstack-keystone | 23:18 | |
*** germs has quit IRC | 23:33 | |
*** germs has joined #openstack-keystone | 23:35 | |
*** germs has quit IRC | 23:35 | |
*** germs has joined #openstack-keystone | 23:35 | |
*** felipemonteiro has quit IRC | 23:48 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!