*** felipemonteiro has joined #openstack-keystone | 00:05 | |
*** felipemonteiro_ has quit IRC | 00:07 | |
*** bigdogstl has quit IRC | 00:11 | |
*** r-daneel has quit IRC | 00:14 | |
adriant | knikolla: you might be interesting in taking a look at Adjutant, because it has something that already does what: https://github.com/CCI-MOC/ksproj does | 00:21 |
---|---|---|
adriant | the part that is missing is a better way to handle the TOC confirmation, which I've got planned to solve. | 00:22 |
adriant | nvm, it was mentioned, I just didn't read far enough... | 00:24 |
kmalloc | adriant: hilarious, ksproj is exactly what i wrote for metacloud [way back in the day, but it was first in horizon then as a keystone extension, never upstream] | 00:26 |
kmalloc | ksproj is so much better than what i wrote | 00:26 |
adriant | kmalloc: that's why I'm trying to get Adjutant added as an official project, stop us all from writing the same thing over again separately :P | 00:27 |
kmalloc | adriant: i need to take a look at it. | 00:27 |
kmalloc | it's been on my list for a while | 00:27 |
adriant | It has issues, most of which are planned for refactor, but the core concept is mostly simple, and started off as a system to handle a new user signup process | 00:28 |
adriant | and then shit like user invite and password reset just kind of... fit and were added. | 00:28 |
kmalloc | doesn't https://github.com/openstack/adjutant/blob/master/adjutant/middleware.py#L20 KSM already do that? | 00:29 |
kmalloc | ando https://github.com/openstack/adjutant/blob/master/adjutant/middleware.py#L69 can be replaced with (mostly) oslo.middleware.Debug | 00:29 |
adriant | kmalloc: you're probably right | 00:29 |
kmalloc | i'm just nit picking but if it makes it easier for you :) | 00:30 |
kmalloc | yay! | 00:30 |
kmalloc | [just first place i looked] | 00:30 |
adriant | a lot of that was written ages ago and needs a rework | 00:30 |
adriant | it's just a case of 'it works so I don't have as much time to make it better because priorities | 00:30 |
kmalloc | right | 00:32 |
kmalloc | yeah there is a lot of stuff to be done in general for cleanup | 00:32 |
kmalloc | looking at it now, it's not bad, just def. needs some time to make it better :) | 00:33 |
* adriant is very very aware | 00:33 | |
kmalloc | it might also benefit from another change i wnat to make to ekystone | 00:34 |
adriant | there is so much I have/want to rewrite across all the projects I work on :( | 00:34 |
kmalloc | allow for "external" data store in a clean place with an appropriate key-structure (works like extras but doesn't suck) | 00:34 |
kmalloc | i want to re-write keystone in rust. | 00:34 |
kmalloc | >.> | 00:34 |
kmalloc | that isn't going to happen anytime soon | 00:34 |
kmalloc | but it owuld be a ton of fun | 00:34 |
kmalloc | heck, i kinda want to fork keystone and re-write the whole thing witha V4 API and a translation middleware for v3-isms. | 00:35 |
kmalloc | but as of right now.. i feel good, got a big chunk of the work to move away from webob into keystone :) | 00:36 |
adriant | kmalloc, regarding KSM, your talking about: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_request.py ? | 00:37 |
adriant | I don't see any nice way to just get a dict of all the user data | 00:37 |
adriant | but I've never really looked too much into it | 00:37 |
kmalloc | there is a number of ways to slice it | 00:37 |
kmalloc | might need to do it via oslo.context | 00:38 |
adriant | To be honest, I'm going to be reworking that whole part, and how I handle policy quite a bit | 00:38 |
kmalloc | which is maybe what i'm thinking | 00:38 |
adriant | and I need to start pulling in a lot of the oslo stuff | 00:39 |
*** felipemonteiro_ has joined #openstack-keystone | 00:42 | |
kmalloc | :) | 00:43 |
*** felipemonteiro has quit IRC | 00:43 | |
kmalloc | another option is to look how swift does it | 00:44 |
kmalloc | and pull in zero oslo things | 00:44 |
adriant | an option, but I'm going to add partial support for oslo.policy at least in some fashion | 00:45 |
*** Dinesh_Bhor has joined #openstack-keystone | 00:46 | |
adriant | Swift terrifies me... I use it, but it terrifies me | 00:47 |
*** r-daneel has joined #openstack-keystone | 01:04 | |
*** gyee has quit IRC | 01:05 | |
*** namnh has joined #openstack-keystone | 01:25 | |
sapd | lbragstad: yes. It takes 0.5 seconds | 01:51 |
*** itlinux has joined #openstack-keystone | 01:56 | |
*** zxy has joined #openstack-keystone | 02:01 | |
*** lifeless_ has joined #openstack-keystone | 02:22 | |
*** lifeless has quit IRC | 02:23 | |
wxy | cmurphy: here is the following patch by Lance: https://review.openstack.org/#/c/573292 I'd like to know if it addressed your thought completely | 02:39 |
*** markvoelker has quit IRC | 03:00 | |
*** markvoelker has joined #openstack-keystone | 03:02 | |
*** ckonstanski has quit IRC | 03:05 | |
*** markvoelker has quit IRC | 03:07 | |
openstackgerrit | Chen proposed openstack/python-keystoneclient master: Trival fix in docstring https://review.openstack.org/573489 | 03:07 |
*** markvoelker has joined #openstack-keystone | 03:12 | |
*** felipemonteiro has joined #openstack-keystone | 03:24 | |
*** felipemonteiro_ has quit IRC | 03:26 | |
knikolla | adriant: i've been meaning to give adjutant a try | 03:34 |
*** dave-mcc_ has quit IRC | 03:44 | |
*** mvk has joined #openstack-keystone | 03:48 | |
*** germs has joined #openstack-keystone | 03:54 | |
*** germs has quit IRC | 03:54 | |
*** germs has joined #openstack-keystone | 03:54 | |
*** felipemonteiro has quit IRC | 04:03 | |
kmalloc | lbragstad: +2, comment in-line for token-model | 04:16 |
*** germs has quit IRC | 04:22 | |
*** Kumar has joined #openstack-keystone | 04:24 | |
*** Kumar_ has joined #openstack-keystone | 04:30 | |
*** Kumar has quit IRC | 04:30 | |
*** Kumar__ has joined #openstack-keystone | 04:32 | |
*** Kumar_ has quit IRC | 04:35 | |
*** Kumar__ has quit IRC | 04:38 | |
*** Kumar_ has joined #openstack-keystone | 04:38 | |
*** links has joined #openstack-keystone | 04:41 | |
*** Kumar_ has quit IRC | 04:46 | |
*** Dinesh_Bhor has quit IRC | 05:01 | |
*** bhagyashri_s has quit IRC | 05:01 | |
*** bhagyashri_s has joined #openstack-keystone | 05:05 | |
*** Dinesh_Bhor has joined #openstack-keystone | 05:05 | |
*** lifeless_ has quit IRC | 05:26 | |
*** lifeless has joined #openstack-keystone | 05:26 | |
*** vrv_ has joined #openstack-keystone | 05:41 | |
*** AlexeyAbashkin has joined #openstack-keystone | 05:48 | |
*** Alexey_Abashkin has joined #openstack-keystone | 05:54 | |
*** AlexeyAbashkin has quit IRC | 05:55 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 05:55 | |
*** Dinesh__Bhor has joined #openstack-keystone | 05:56 | |
*** Dinesh_Bhor has quit IRC | 05:56 | |
*** pcaruana has joined #openstack-keystone | 05:57 | |
-openstackstatus- NOTICE: Zuul stopped receiving gerrit events around 04:00UTC; any changes submitted between then and now will probably require a "recheck" comment to be requeued. Thanks! | 06:01 | |
*** Dinesh__Bhor has quit IRC | 06:10 | |
*** Dinesh_Bhor has joined #openstack-keystone | 06:13 | |
*** pcaruana has quit IRC | 06:14 | |
*** pcaruana has joined #openstack-keystone | 06:15 | |
*** dklyle has quit IRC | 06:44 | |
jaosorior | ayoung: hey! thanks for sharing it and checking it out! Still a lot of work to do there :D | 06:51 |
*** jaosorior has quit IRC | 06:58 | |
*** d0ugal has joined #openstack-keystone | 07:03 | |
*** Dinesh__Bhor has joined #openstack-keystone | 07:11 | |
*** Dinesh_Bhor has quit IRC | 07:11 | |
*** rcernin has quit IRC | 07:13 | |
cmurphy | wxy: i agree with your comment, would like to see max_project_tree_depth mentioned | 07:14 |
*** Alexey_Abashkin has joined #openstack-keystone | 07:23 | |
*** jistr is now known as jistr|reloc | 07:25 | |
*** AlexeyAbashkin has quit IRC | 07:26 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 07:26 | |
*** Dinesh__Bhor has quit IRC | 07:28 | |
*** annp has quit IRC | 07:39 | |
*** rcernin has joined #openstack-keystone | 07:48 | |
*** dklyle has joined #openstack-keystone | 08:06 | |
*** AlexeyAbashkin has quit IRC | 08:06 | |
*** lifeless has quit IRC | 08:09 | |
*** lifeless has joined #openstack-keystone | 08:10 | |
*** annp has joined #openstack-keystone | 08:14 | |
*** jistr|reloc is now known as jistr | 08:19 | |
*** AlexeyAbashkin has joined #openstack-keystone | 08:28 | |
*** markvoelker has quit IRC | 08:37 | |
*** markvoelker has joined #openstack-keystone | 08:38 | |
*** markvoelker has quit IRC | 08:42 | |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Add policy for limit model protection https://review.openstack.org/562714 | 08:47 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Implement enforcement model logic in Manager https://review.openstack.org/562715 | 08:47 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Expose endpoint to return enforcement model https://review.openstack.org/562716 | 08:47 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: [WIP] Strict two level hierarchical limit https://review.openstack.org/557696 | 08:47 |
*** Alexey_Abashkin has joined #openstack-keystone | 09:00 | |
*** d0ugal_ has joined #openstack-keystone | 09:00 | |
*** d0ugal has quit IRC | 09:00 | |
*** d0ugal_ has quit IRC | 09:00 | |
*** AlexeyAbashkin has quit IRC | 09:01 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 09:01 | |
*** d0ugal has joined #openstack-keystone | 09:01 | |
*** lifeless_ has joined #openstack-keystone | 09:03 | |
*** lifeless has quit IRC | 09:03 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone master: Allow domain admin listing their domain https://review.openstack.org/573365 | 09:09 |
openstackgerrit | Shuo Liu proposed openstack/python-keystoneclient master: fix keytone to keystone in yaml file https://review.openstack.org/573633 | 09:11 |
*** lifeless_ is now known as lifeless | 09:13 | |
*** edmondsw has joined #openstack-keystone | 09:26 | |
*** edmondsw has quit IRC | 09:30 | |
*** lifeless_ has joined #openstack-keystone | 09:30 | |
*** lifeless has quit IRC | 09:32 | |
*** jaosorior has joined #openstack-keystone | 09:36 | |
*** liuzz has quit IRC | 09:37 | |
*** evrardjp has quit IRC | 09:53 | |
*** evrardjp has joined #openstack-keystone | 09:56 | |
*** lifeless has joined #openstack-keystone | 09:58 | |
*** lifeless_ has quit IRC | 09:58 | |
*** evrardjp_ has joined #openstack-keystone | 10:01 | |
*** evrardjp has quit IRC | 10:01 | |
*** namnh has quit IRC | 10:03 | |
*** evrardjp_ has quit IRC | 10:05 | |
*** evrardjp has joined #openstack-keystone | 10:06 | |
*** annp has quit IRC | 10:09 | |
*** lifeless_ has joined #openstack-keystone | 10:23 | |
*** lifeless has quit IRC | 10:24 | |
*** rcernin has quit IRC | 10:37 | |
*** markvoelker has joined #openstack-keystone | 10:38 | |
*** lifeless_ has quit IRC | 10:39 | |
*** lifeless has joined #openstack-keystone | 10:55 | |
*** markvoelker has quit IRC | 11:13 | |
*** dklyle has quit IRC | 11:46 | |
*** AlexeyAbashkin has quit IRC | 11:53 | |
*** AlexeyAbashkin has joined #openstack-keystone | 11:54 | |
*** dklyle has joined #openstack-keystone | 11:56 | |
*** dklyle has quit IRC | 12:02 | |
*** AlexeyAbashkin has quit IRC | 12:12 | |
*** AlexeyAbashkin has joined #openstack-keystone | 12:12 | |
*** nicolasbock has joined #openstack-keystone | 12:13 | |
openstackgerrit | Kim Bao Long proposed openstack/keystone master: Remove NotImplementedError exception https://review.openstack.org/573678 | 12:13 |
*** mugsie_ is now known as mugsie | 12:14 | |
*** markvoelker has joined #openstack-keystone | 12:16 | |
*** AlexeyAbashkin has quit IRC | 12:30 | |
*** raildo has joined #openstack-keystone | 12:30 | |
*** AlexeyAbashkin has joined #openstack-keystone | 12:33 | |
*** AlexeyAbashkin has quit IRC | 12:41 | |
*** AlexeyAbashkin has joined #openstack-keystone | 12:41 | |
*** bhagyashris_ has joined #openstack-keystone | 12:44 | |
*** pooja-jadhav has joined #openstack-keystone | 12:45 | |
*** pooja_jadhav has quit IRC | 12:48 | |
*** bhagyashri_s has quit IRC | 12:48 | |
*** mchlumsky has joined #openstack-keystone | 12:52 | |
*** ninag has joined #openstack-keystone | 12:54 | |
*** ninag has quit IRC | 12:54 | |
*** AlexeyAbashkin has quit IRC | 12:56 | |
*** AlexeyAbashkin has joined #openstack-keystone | 12:57 | |
*** dklyle has joined #openstack-keystone | 12:58 | |
*** edmondsw has joined #openstack-keystone | 13:02 | |
*** edmondsw has quit IRC | 13:06 | |
*** d0ugal_ has joined #openstack-keystone | 13:08 | |
*** d0ugal has quit IRC | 13:08 | |
*** d0ugal_ has quit IRC | 13:08 | |
*** d0ugal has joined #openstack-keystone | 13:08 | |
*** d0ugal has quit IRC | 13:08 | |
*** d0ugal has joined #openstack-keystone | 13:08 | |
*** jaosorior has quit IRC | 13:29 | |
*** dklyle has quit IRC | 13:29 | |
*** dklyle has joined #openstack-keystone | 13:31 | |
*** jmlowe has quit IRC | 13:35 | |
*** links has quit IRC | 13:46 | |
-openstackstatus- NOTICE: A misapplied distro security package update caused many jobs to fail with a MERGER_FAILURE error between ~06:30-12:30 UTC; these can be safely rechecked now that the problem has been addressed | 13:46 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone-specs master: Address follow-on comments in strict-two-level spec https://review.openstack.org/573292 | 13:53 |
openstackgerrit | Raildo Mascena proposed openstack/keystone master: Exposing bug/1754677 https://review.openstack.org/570438 | 13:53 |
*** edmondsw has joined #openstack-keystone | 13:54 | |
*** dklyle has quit IRC | 13:55 | |
*** jmlowe has joined #openstack-keystone | 14:07 | |
*** felipemonteiro has joined #openstack-keystone | 14:12 | |
*** jmlowe has quit IRC | 14:15 | |
*** zxy has quit IRC | 14:20 | |
*** AlexeyAbashkin has quit IRC | 14:21 | |
*** jistr is now known as jistr|mtg | 14:28 | |
*** r-daneel has quit IRC | 14:37 | |
*** jmlowe has joined #openstack-keystone | 14:39 | |
*** felipemonteiro_ has joined #openstack-keystone | 14:39 | |
*** felipemonteiro has quit IRC | 14:43 | |
*** spilla has joined #openstack-keystone | 14:51 | |
*** r-daneel has joined #openstack-keystone | 15:01 | |
*** r-daneel_ has joined #openstack-keystone | 15:05 | |
*** r-daneel has quit IRC | 15:06 | |
*** r-daneel_ is now known as r-daneel | 15:06 | |
*** d0ugal has quit IRC | 15:14 | |
*** jistr|mtg is now known as jistr | 15:16 | |
*** dklyle has joined #openstack-keystone | 15:20 | |
kmalloc | o/ | 15:20 |
lbragstad | qq on https://review.openstack.org/#/c/559129/ | 15:20 |
kmalloc | lbragstad: don't set the non-internal ones in __init__ | 15:21 |
kmalloc | you're setting te non-internal names, through the @property | 15:21 |
kmalloc | hence the errors | 15:21 |
kmalloc | only set self.__* not self.* for @property | 15:21 |
kmalloc | __init__ can easily touch internal things | 15:21 |
lbragstad | ahhh | 15:23 |
*** dave-mccowan has joined #openstack-keystone | 15:25 | |
kmalloc | lbragstad: yep ;) | 15:27 |
lbragstad | about to wrap up another fix and i'll give that a shot | 15:27 |
kmalloc | cool | 15:27 |
*** dklyle has quit IRC | 15:28 | |
*** dklyle has joined #openstack-keystone | 15:32 | |
*** dave-mccowan has quit IRC | 15:32 | |
*** dklyle has quit IRC | 15:39 | |
*** elibrokeit is now known as noteli | 15:40 | |
*** noteli is now known as elibrokeit | 15:41 | |
*** lbragstad is now known as elbragstad | 15:44 | |
*** r-daneel has quit IRC | 16:09 | |
*** r-daneel_ has joined #openstack-keystone | 16:09 | |
*** r-daneel_ is now known as r-daneel | 16:11 | |
openstackgerrit | Morgan Fainberg proposed openstack/python-keystoneclient master: Fix python3 test compat https://review.openstack.org/573773 | 16:13 |
openstackgerrit | Morgan Fainberg proposed openstack/python-keystoneclient master: fix tox python3 overrides https://review.openstack.org/573339 | 16:14 |
kmalloc | elbragstad: ^ apparantly we don't actually hit that test case that i fixed... | 16:17 |
kmalloc | but.... | 16:17 |
kmalloc | ah if block around it | 16:18 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement enforcement model logic in Manager https://review.openstack.org/562715 | 16:23 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Expose endpoint to return enforcement model https://review.openstack.org/562716 | 16:23 |
openstackgerrit | Lance Bragstad proposed openstack/keystone-specs master: Address follow-on comments in strict-two-level spec https://review.openstack.org/573292 | 16:25 |
ayoung | kmalloc, as the app cred bugs start pouring in, I can't help but think that we duplicated what we have with Trusts. I wonder if we can unify that code base. | 16:42 |
ayoung | For example https://bugs.launchpad.net/keystone/+bug/1773967 | 16:42 |
openstack | Launchpad bug 1773967 in OpenStack Identity (keystone) "Application credentials can't be used with group-only role assignments" [High,Confirmed] - Assigned to Rajat Sharma (tajar29) | 16:42 |
kmalloc | we can possibly merge, but trusts are a bit more special | 16:42 |
ayoung | Seems to me that an App Credential should only vary from the current definition of a trust in that the trustee is not a full user, but instead an App Cred entity. | 16:43 |
kmalloc | more so, it's a self-trust | 16:43 |
ayoung | There is no reason trusts should be more special, though. They were written for the same use case, just with a more constrained requirement | 16:43 |
ayoung | not really | 16:43 |
kmalloc | app-creds are. | 16:43 |
ayoung | the app cred is not "me" | 16:43 |
kmalloc | it is. | 16:43 |
ayoung | it is a pseudo user controlled by me | 16:43 |
kmalloc | they are tied to the user lifecycle | 16:43 |
ayoung | Agreed, and IO don't want to break that | 16:44 |
kmalloc | and it is *you* from ID etc perspectives | 16:44 |
ayoung | but separate that from the delegation | 16:44 |
kmalloc | it is a reduced permission set, but still you | 16:44 |
ayoung | think of it as a 2 stage process | 16:44 |
kmalloc | app cred changes AuthZ, not AuthN | 16:44 |
ayoung | it limits AuthN for that cred, based on the user | 16:44 |
kmalloc | Trusts change both AuthN and AuthZ | 16:44 |
kmalloc | (potentially) | 16:44 |
kmalloc | app creds cannot change AuthN | 16:44 |
kmalloc | it does not limit AuthN in any way, you're still you. | 16:45 |
kmalloc | we could merge some of the code / data structures. | 16:46 |
kmalloc | but... trusts are far further reaching | 16:46 |
kmalloc | can you do a self-trust? | 16:48 |
kmalloc | i don't think that really works... does it? | 16:48 |
ayoung | Trusts are limited to only scaling down AuthN from one user to another | 16:48 |
ayoung | app creds are that and a bit more: | 16:48 |
ayoung | they are first, an AuthZ entity | 16:48 |
ayoung | A Subject in X509 tersm, a principal in Kerb | 16:49 |
kmalloc | you're conflating AuthN and AuthZ | 16:49 |
ayoung | no I am not...pay attention | 16:49 |
ayoung | this is my lifes' work :) | 16:49 |
ayoung | app creds are both | 16:49 |
ayoung | 1 AuthZ credential | 16:49 |
ayoung | you could make an App Cred with 0 power | 16:49 |
kmalloc | App Creds provide AuthN, they do not change AuthN Data from the original user. | 16:49 |
ayoung | and then 2 a delegation of data from the original user to the subject/pricipal | 16:50 |
kmalloc | Trust *can* change AuthN data [we say don't do it, we allow it] | 16:50 |
ayoung | change how? | 16:50 |
kmalloc | impersonation | 16:50 |
kmalloc | hold on in a meeting | 16:50 |
ayoung | NP. I got to run, too | 16:51 |
*** felipemonteiro_ has quit IRC | 16:54 | |
*** ayoung has quit IRC | 16:56 | |
*** r-daneel has quit IRC | 17:00 | |
*** pcaruana has quit IRC | 17:02 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Introduce new TokenModel object https://review.openstack.org/559129 | 17:15 |
elbragstad | kmalloc: ^ cleaned up | 17:15 |
elbragstad | fwiw - is anyone else is willing to review https://review.openstack.org/#/c/540803/15 and it's follow on - it's ready | 17:15 |
elbragstad | we should try and merge that by EOD if people are ok/happy with it | 17:16 |
-openstackstatus- NOTICE: The Zuul scheduler was offline briefly to clean up from debugging a nodepool issue, so changes uploaded or approved between 16:50 and 17:15 UTC may need to be rechecked or reapproved (all already queued changes are in the process of being reenqueued now) | 17:24 | |
kmalloc | elbragstad: mmmm Habanero and cheese omlette | 17:28 |
kmalloc | good breakfast | 17:28 |
kmalloc | (aslo, somehow ended up with mild pepper this time, eating one raw produced only mild burning in the mouthhole) | 17:28 |
kmalloc | elbragstad: +2 on the new tokenmodel | 17:31 |
elbragstad | too hot for me | 17:38 |
elbragstad | here in the midwest we have this *super* spicy condiment called ketchup | 17:39 |
elbragstad | it's ridiculous | 17:39 |
elbragstad | people literally put it on their burgers, idk what's wrong with them | 17:39 |
*** raildo has quit IRC | 17:39 | |
openstackgerrit | Stephen Finucane proposed openstack/oslo.policy master: generator: Reimplement wrapping of 'description' https://review.openstack.org/485646 | 17:41 |
elbragstad | can olso libraries have dependencies on clients? | 17:51 |
elbragstad | e.g. oslo.limit having a dependency on python-keystoneclient/ | 17:52 |
*** raildo has joined #openstack-keystone | 18:16 | |
kmalloc | uj | 18:17 |
kmalloc | uh* | 18:17 |
kmalloc | no | 18:17 |
kmalloc | don't do that | 18:17 |
kmalloc | really don't. use KSA and direct rest calls if you must | 18:17 |
*** itlinux has quit IRC | 18:18 | |
kmalloc | think of it this way, SDK may lean on oslo.* at some point | 18:19 |
kmalloc | ksc will be replaced with SDK [I hope] in most cases. | 18:19 |
kmalloc | you wouldn't want SDK -> OSLO -> SDK | 18:20 |
*** dingjin has joined #openstack-keystone | 18:21 | |
*** vrv_ has quit IRC | 18:21 | |
*** dingjin has quit IRC | 18:22 | |
elbragstad | ah | 18:29 |
elbragstad | makes sense | 18:29 |
*** rmcall has joined #openstack-keystone | 18:30 | |
kmalloc | elbragstad: https://review.openstack.org/#/c/573461/2 | 18:34 |
kmalloc | that should fix the concern with the debug_middleware help text | 18:34 |
elbragstad | awesome | 18:34 |
kmalloc | elbragstad: and i think that clears the way [with some trivial +2s] for the rest of the chain to land | 18:34 |
kmalloc | should prob take like 5m to review the last bits and push it through. | 18:35 |
knikolla | so casual nick friday is a regular thing now? | 18:35 |
elbragstad | :) | 18:36 |
kmalloc | knikolla: my nic is always casual... THATS RIGHT it socializes before sending traffic to Layer2... wait... no that isn't it. | 18:36 |
kmalloc | ok ok that was a bad joke. | 18:36 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Remove duplicated test https://review.openstack.org/572943 | 18:38 |
kmalloc | elbragstad: ^ done, fixes the nit. | 18:38 |
elbragstad | ack- thanks | 18:39 |
knikolla | elbragstad: hahaha, it took me a couple of reads :) | 18:39 |
elbragstad | lol | 18:39 |
kmalloc | knikolla: going to bug you for a quick (haha, "quick") review of https://review.openstack.org/#/c/571979/6 | 18:39 |
elbragstad | it only took me about 4 years to come up with one | 18:39 |
knikolla | kmalloc: it's actually going to be quick as i went through 80% of that yesterday | 18:40 |
kmalloc | hah | 18:40 |
kmalloc | ok then | 18:40 |
elbragstad | knikolla: the unified limit spec is ready for eyes too ;) | 18:40 |
kmalloc | elbragstad: so... version -> Flask and... app cred? | 18:40 |
kmalloc | what is going to be the least impactful (REST URL prefix wise)? | 18:41 |
elbragstad | as far as the first flask native subsystem? | 18:41 |
kmalloc | yeah | 18:41 |
elbragstad | sure | 18:41 |
elbragstad | what ever is easiest? | 18:41 |
kmalloc | i worry /user /group /project /domain is brutal | 18:41 |
kmalloc | maybe /ec2token :P | 18:41 |
kmalloc | actually was thinking maybe /auth | 18:41 |
elbragstad | it might help (at least me anyways) reviewers wrap their minds around the flask frame work to see it with a more trivial subsystem | 18:41 |
kmalloc | maybe i'll do s3/ec2 since they are in .contrib and have next to no larger impact | 18:42 |
kmalloc | ok so i'll spin up a trivial patch that makes keystone.subsystem and then start working on each of the subsequent subsystems. ideally we should have __all__ in subsystem.__init__ but maybe i'll punt on that so the flask stuff can be parallelized | 18:44 |
knikolla | can we please drop OS-FEDERATION from the URLs at some point? :) | 18:55 |
kmalloc | knikolla: we can deprecate it we cannot remove it | 18:56 |
kmalloc | knikolla: it is part of the V3 API spec... unless we want microversions or v4 | 18:56 |
knikolla | ++ for deprecation | 18:56 |
kmalloc | now, we can totally move to better URL paths. | 18:57 |
kmalloc | lets hold off until Flaskification work is done to do that though | 18:57 |
knikolla | \o/ | 18:57 |
rodrigods | we can duplicate the API while we deprecate the old one | 18:58 |
kmalloc | or at least the URIs that have OS-FEDERATION in them | 18:58 |
kmalloc | rodrigods: that would be the plan | 18:58 |
rodrigods | +1 | 18:59 |
*** rmcall has quit IRC | 19:02 | |
kmalloc | elbragstad, knikolla: keystone.subsystem.version or keystone.subsystem.discovery or keystone.subsystem.root ? | 19:13 |
kmalloc | i lean towards .discovery | 19:13 |
elbragstad | is it for version specific stuff? | 19:13 |
elbragstad | and jsonhome? | 19:14 |
kmalloc | JSON home stuff | 19:14 |
knikolla | ++ on discovery | 19:14 |
kmalloc | like /v3 root, and / | 19:14 |
elbragstad | ++ discovery seems like an appropriate name | 19:14 |
kmalloc | it's replacing keystone.version.routers/controllers/etc | 19:14 |
kmalloc | version.service is special and will probably be moved into server.flask | 19:14 |
kmalloc | elbragstad: i'm going to leave the version_string in keystone.version | 19:23 |
kmalloc | used for the API doc thing only | 19:23 |
elbragstad | ok | 19:23 |
*** itlinux has joined #openstack-keystone | 19:26 | |
*** mvk has quit IRC | 19:28 | |
*** dklyle has joined #openstack-keystone | 19:32 | |
*** jmlowe has quit IRC | 19:33 | |
*** dklyle has quit IRC | 19:37 | |
*** martinus__ has joined #openstack-keystone | 19:43 | |
*** lifeless has quit IRC | 19:46 | |
*** bhagyashri_s has joined #openstack-keystone | 20:00 | |
*** pooja_jadhav has joined #openstack-keystone | 20:00 | |
*** pooja-jadhav has quit IRC | 20:03 | |
*** bhagyashris_ has quit IRC | 20:03 | |
*** ckonstanski has joined #openstack-keystone | 20:07 | |
elbragstad | does anyone else want to give https://review.openstack.org/#/c/540803/ a review? otherwise I can take the existing +2's and upgrade one to a +A | 20:11 |
*** bhagyashris_ has joined #openstack-keystone | 20:11 | |
*** pooja-jadhav has joined #openstack-keystone | 20:12 | |
*** bhagyashri_s has quit IRC | 20:15 | |
*** pooja_jadhav has quit IRC | 20:15 | |
*** lifeless has joined #openstack-keystone | 20:22 | |
knikolla | elbragstad: giving it a read now | 20:28 |
elbragstad | aweomse - thank you knikolla | 20:29 |
openstackgerrit | Lance Bragstad proposed openstack/python-keystoneclient master: Add support for registered limits https://review.openstack.org/537668 | 20:34 |
openstackgerrit | Merged openstack/keystone master: Add in ability to load DEBUG middleware https://review.openstack.org/572826 | 20:37 |
openstackgerrit | Merged openstack/keystone master: Add Flaskification release-note https://review.openstack.org/572827 | 20:37 |
*** mchlumsky has quit IRC | 20:39 | |
*** martinus__ has quit IRC | 20:45 | |
knikolla | elbragstad: looks good and in line with what we discussed and agreed in vancouver. | 20:46 |
elbragstad | :) | 20:46 |
*** ayoung has joined #openstack-keystone | 20:55 | |
*** r-daneel has joined #openstack-keystone | 21:05 | |
*** r-daneel_ has joined #openstack-keystone | 21:08 | |
*** r-daneel has quit IRC | 21:09 | |
*** r-daneel_ is now known as r-daneel | 21:09 | |
elbragstad | ayoung: do you care to revisit https://review.openstack.org/#/c/540803/15 and it's follow up? | 21:14 |
ayoung | elbragstad, can I change the name right now? | 21:14 |
elbragstad | i address everything else in a follow up - but ididn't change the title of the commit because i didn't want to wipe out the existing votes | 21:15 |
ayoung | I think I want that. | 21:16 |
ayoung | I'm ok considering the existing votes stickey and +2A after that | 21:16 |
ayoung | we can speed it through.... | 21:16 |
ayoung | Strict Two-Level Hierarchical Enforcement Model -> Strict Two-Level Limits Enforcement Model | 21:17 |
ayoung | that work for you? | 21:17 |
openstackgerrit | ayoung proposed openstack/keystone-specs master: Strict Two-Level Limits Enforcement Model https://review.openstack.org/540803 | 21:18 |
ayoung | kmalloc, knikolla ^^ OK by you? | 21:19 |
*** jmlowe has joined #openstack-keystone | 21:19 | |
elbragstad | i'm good with it, just didn't want to wipe out votes was all | 21:20 |
kmalloc | Yeah that's fine | 21:20 |
*** dklyle has joined #openstack-keystone | 21:26 | |
*** rmascena has joined #openstack-keystone | 21:27 | |
knikolla | ++ | 21:27 |
*** raildo has quit IRC | 21:29 | |
*** rmascena has quit IRC | 21:30 | |
ayoung | knikolla, kmalloc I +2Ad it. Feel free to formally add your +2s on as well | 21:30 |
*** sonuk_ has joined #openstack-keystone | 21:41 | |
*** jmlowe has quit IRC | 21:43 | |
*** sonuk has quit IRC | 21:45 | |
*** jmlowe has joined #openstack-keystone | 21:48 | |
*** felipemonteiro has joined #openstack-keystone | 21:51 | |
*** lifeless_ has joined #openstack-keystone | 21:58 | |
*** jmlowe has quit IRC | 22:00 | |
*** lifeless has quit IRC | 22:00 | |
*** jmlowe has joined #openstack-keystone | 22:01 | |
*** r-daneel has quit IRC | 22:03 | |
*** nicolasbock has quit IRC | 22:06 | |
*** jmlowe has quit IRC | 22:15 | |
*** jmlowe has joined #openstack-keystone | 22:20 | |
*** lbragstad has joined #openstack-keystone | 22:25 | |
*** ChanServ sets mode: +o lbragstad | 22:25 | |
*** elbragstad has quit IRC | 22:25 | |
openstackgerrit | Lance Bragstad proposed openstack/python-keystoneclient master: Add support for registered limits https://review.openstack.org/537668 | 22:28 |
lbragstad | i think the create API for registered limits is a bit strange with the client bits and the existing client tests | 22:28 |
lbragstad | pushing what i have for now, but that might need a pair of eyes from someone who is more familiar with ksc | 22:29 |
*** r-daneel has joined #openstack-keystone | 22:30 | |
*** harlowja has joined #openstack-keystone | 22:30 | |
*** lifeless_ is now known as lifeless | 22:41 | |
*** felipemonteiro has quit IRC | 22:44 | |
*** felipemonteiro has joined #openstack-keystone | 22:57 | |
*** r-daneel_ has joined #openstack-keystone | 23:01 | |
*** r-daneel has quit IRC | 23:03 | |
*** r-daneel_ is now known as r-daneel | 23:03 | |
*** ckonstanski has quit IRC | 23:16 | |
*** ckonstanski has joined #openstack-keystone | 23:20 | |
*** felipemonteiro has quit IRC | 23:23 | |
*** r-daneel has quit IRC | 23:25 | |
*** r-daneel has joined #openstack-keystone | 23:33 | |
openstackgerrit | Merged openstack/keystone-specs master: Strict Two-Level Limits Enforcement Model https://review.openstack.org/540803 | 23:39 |
*** felipemonteiro has joined #openstack-keystone | 23:40 | |
*** spilla has quit IRC | 23:48 | |
*** r-daneel has quit IRC | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!