| kmalloc | adriant: hm. that is one massive patchset | 00:05 |
|---|---|---|
| adriant | kmalloc: the auth receipts one? | 00:06 |
| kmalloc | adriant: not sure if it could have been broken up, but (as guilty as I am of 1000+ line changes right now), that is a lot to review at once. | 00:06 |
| kmalloc | yeah | 00:06 |
| adriant | I mean, I could break the provider logic and tests into one patch | 00:06 |
| kmalloc | that might make it a lot easier to review | 00:06 |
| kmalloc | at 2000+ lines of change | 00:06 |
| adriant | then add the auth controller logic and tests in another | 00:06 |
| adriant | THEN the docs | 00:06 |
| kmalloc | yeah and i would prob add the docs in the final one | 00:06 |
| kmalloc | if you don't mind, i mean, I'll review it if that is too much work (as is) | 00:07 |
| kmalloc | but it also means that if one bit changes you can keep it somewhat isolated. | 00:07 |
| *** edmondsw has joined #openstack-keystone | 00:07 | |
| kmalloc | i tried to do a lot of that wiht flask code, but sometimes you still end up with 500LOC and 500 lines of test. | 00:07 |
| adriant | I don't think it will be too hard to split them... | 00:09 |
| * adriant says tentatively | 00:10 | |
| adriant | although the provider patch will still be large | 00:10 |
| adriant | since that's the bulk of it | 00:10 |
| adriant | yeah, the provider logic (plus conf, plus cli) and tests still looks to be around 1500-2000 LOC | 00:11 |
| *** edmondsw has quit IRC | 00:12 | |
| adriant | docs I can easily split out, and I think doing that is probably not a bad idea, since I can tackle the docs in one or two patch for MFA as a whole, and those aren't exactly going to be a feature freeze issue, so safer to cut those out of the patch that is time sensitive | 00:13 |
| adriant | kmalloc: I'll split the docs out, but I'm not sure how else to split the rest nicely when there is a bit of overlap, and most of the controller logic is tiny anyway.' | 00:35 |
| openstackgerrit | Adrian Turjak proposed openstack/keystone master: Implement auth receipts spec https://review.openstack.org/572286 | 01:30 |
| openstackgerrit | Adrian Turjak proposed openstack/keystone master: [WIP] Add documentation for Auth Receipts and MFA https://review.openstack.org/580535 | 01:30 |
| adriant | kmalloc: I've cut the doc changes out at least, but I think I'll leave the giant patch as is other wise :/ | 01:31 |
| *** gyee has quit IRC | 01:45 | |
| *** s10 has quit IRC | 01:45 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Strict two level limit model https://review.openstack.org/557696 | 01:51 |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Add project_id filter for listing limit https://review.openstack.org/579330 | 01:51 |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Add show hierarchy filter https://review.openstack.org/579331 | 01:51 |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Update project depth check https://review.openstack.org/580258 | 01:51 |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: [WIP]Add project hierarchical tree check when Keystone start https://review.openstack.org/580331 | 01:51 |
| *** edmondsw has joined #openstack-keystone | 01:55 | |
| *** edmondsw has quit IRC | 02:00 | |
| *** annp has joined #openstack-keystone | 02:19 | |
| *** jmlowe has quit IRC | 02:34 | |
| openstackgerrit | Tuan Do Anh proposed openstack/keystone master: Change "a SQL" to "an SQL" https://review.openstack.org/579432 | 02:41 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Flesh out and add testing for flask_RESTful scaffolding https://review.openstack.org/578190 | 02:41 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Make keystone.server.flask more interesting for importing https://review.openstack.org/579928 | 02:43 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix keystone.common.rbac_enforcer.__init__.py exporting https://review.openstack.org/579930 | 02:43 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Do not use flask.g imported as g https://review.openstack.org/579985 | 02:43 |
| kmalloc | o | 02:43 |
| kmalloc | ok | 02:43 |
| *** sonuk has joined #openstack-keystone | 03:26 | |
| *** edmondsw has joined #openstack-keystone | 03:43 | |
| *** edmondsw has quit IRC | 03:48 | |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone master: Fix keystone-manage saml_idp_metadata under python3 https://review.openstack.org/580553 | 04:28 |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone master: Added keystone identity provider installation to Devstack plugin https://review.openstack.org/484121 | 04:29 |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone-tempest-plugin master: Keystone to Keystone tests https://review.openstack.org/580041 | 04:30 |
| knikolla | it's too hot to sleep :/ | 04:32 |
| *** pcichy has joined #openstack-keystone | 05:09 | |
| *** edmondsw has joined #openstack-keystone | 05:31 | |
| *** edmondsw has quit IRC | 05:36 | |
| *** masber has joined #openstack-keystone | 05:39 | |
| cmurphy | adriant: sorry I was asleep | 05:48 |
| *** nicolasbock has joined #openstack-keystone | 06:08 | |
| *** vishakha has quit IRC | 06:29 | |
| *** vishakha has joined #openstack-keystone | 06:41 | |
| *** dmellado has joined #openstack-keystone | 06:46 | |
| *** s10 has joined #openstack-keystone | 06:50 | |
| *** martinus__ has joined #openstack-keystone | 06:51 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Add project hierarchical tree check when Keystone start https://review.openstack.org/580331 | 06:57 |
| *** edmondsw has joined #openstack-keystone | 07:20 | |
| *** edmondsw has quit IRC | 07:24 | |
| *** rcernin has quit IRC | 07:29 | |
| *** tosky has joined #openstack-keystone | 07:36 | |
| *** amoralej|off is now known as amoralej | 07:46 | |
| *** s10 has quit IRC | 08:05 | |
| *** apdibbo_ has joined #openstack-keystone | 08:10 | |
| *** apdibbo_ has quit IRC | 08:11 | |
| *** nicolasbock has quit IRC | 08:15 | |
| *** nicolasbock has joined #openstack-keystone | 08:15 | |
| *** nicolasbock_ has joined #openstack-keystone | 08:23 | |
| *** nicolasbock has quit IRC | 08:25 | |
| *** nicolasbock_ has quit IRC | 08:36 | |
| *** nicolasbock_ has joined #openstack-keystone | 08:43 | |
| *** ispp has joined #openstack-keystone | 09:00 | |
| *** edmondsw has joined #openstack-keystone | 09:08 | |
| *** edmondsw has quit IRC | 09:12 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Remove enable config option of trust feature https://review.openstack.org/580587 | 09:26 |
| openstackgerrit | Gergely Csatari proposed openstack/keystone master: Clarifications to API & Scenario Tests https://review.openstack.org/580589 | 09:33 |
| *** pcichy has quit IRC | 09:57 | |
| *** pcichy has joined #openstack-keystone | 09:57 | |
| *** annp has quit IRC | 10:18 | |
| *** tommylikehu has quit IRC | 10:26 | |
| *** tommylikehu has joined #openstack-keystone | 10:26 | |
| *** ispp has quit IRC | 10:29 | |
| *** bigjools has left #openstack-keystone | 10:30 | |
| *** vishakha has quit IRC | 10:56 | |
| *** edmondsw has joined #openstack-keystone | 10:56 | |
| *** edmondsw has quit IRC | 11:00 | |
| *** vishakha has joined #openstack-keystone | 11:12 | |
| *** ispp has joined #openstack-keystone | 11:28 | |
| *** edmondsw has joined #openstack-keystone | 11:44 | |
| *** pcichy has quit IRC | 11:58 | |
| *** pcichy has joined #openstack-keystone | 11:59 | |
| *** raildo has joined #openstack-keystone | 12:21 | |
| *** s10 has joined #openstack-keystone | 12:46 | |
| *** jmlowe has joined #openstack-keystone | 12:49 | |
| *** pcichy has quit IRC | 12:51 | |
| *** amoralej is now known as amoralej|lunch | 13:02 | |
| *** felipemonteiro_ has joined #openstack-keystone | 13:09 | |
| *** felipemonteiro__ has joined #openstack-keystone | 13:10 | |
| *** felipemonteiro_ has quit IRC | 13:14 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Remove enable config option of trust feature https://review.openstack.org/580587 | 13:42 |
| *** sapd_ has joined #openstack-keystone | 13:53 | |
| *** sapd has quit IRC | 13:53 | |
| *** ispp has quit IRC | 13:59 | |
| *** josecastroleon has quit IRC | 14:00 | |
| knikolla | o/ | 14:00 |
| *** josecastroleon has joined #openstack-keystone | 14:01 | |
| *** ispp has joined #openstack-keystone | 14:01 | |
| *** ispp has quit IRC | 14:04 | |
| *** amoralej|lunch is now known as amoralej | 14:04 | |
| *** edmondsw has quit IRC | 14:23 | |
| *** edmondsw has joined #openstack-keystone | 14:24 | |
| *** edmondsw has quit IRC | 14:27 | |
| *** edmondsw has joined #openstack-keystone | 14:32 | |
| *** felipemonteiro__ has quit IRC | 14:38 | |
| *** nicodemus_ has joined #openstack-keystone | 14:41 | |
| nicodemus_ | Morning! | 14:44 |
| *** vishakha has quit IRC | 14:47 | |
| nicodemus_ | I'm trying to configure Keystone federation, with keystone as an SP and an external IdP. I'm using Mellon for handling the SAML part, but have an error: http://paste.openstack.org/show/725267/ | 14:47 |
| nicodemus_ | Has anyone seen such error before? | 14:47 |
| *** vishakha has joined #openstack-keystone | 14:48 | |
| *** ispp has joined #openstack-keystone | 14:59 | |
| *** ispp has quit IRC | 15:02 | |
| *** deepak_mourya has quit IRC | 15:03 | |
| *** openstackgerrit has quit IRC | 15:19 | |
| *** ispp has joined #openstack-keystone | 15:20 | |
| *** josecastroleon has quit IRC | 15:21 | |
| *** ispp has quit IRC | 15:31 | |
| *** aojea has joined #openstack-keystone | 16:08 | |
| *** aojea has quit IRC | 16:16 | |
| *** jmlowe has quit IRC | 16:17 | |
| larsks | nicodemus_: have you created an identity provider in keystone? | 16:31 |
| *** pcichy has joined #openstack-keystone | 16:48 | |
| nicodemus_ | larsks: I did | 16:50 |
| nicodemus_ | but it turned out that the callback was failing | 16:50 |
| larsks | Well, that's everything I know about federation :) | 16:50 |
| nicodemus_ | rule of thumb, use the same path for the single sign on as in the Mellon endpoint | 16:51 |
| larsks | I've recently been tacking openid federation in tripleo and the keystone puppet module. Mellon is next on my list... | 16:51 |
| larsks | s/tacking/tackling/ | 16:51 |
| *** amoralej is now known as amoralej|off | 17:04 | |
| *** itlinux has joined #openstack-keystone | 17:27 | |
| *** nicodemus_ has quit IRC | 17:51 | |
| *** itlinux has quit IRC | 17:56 | |
| *** itlinux has joined #openstack-keystone | 17:57 | |
| *** itlinux has quit IRC | 17:57 | |
| *** jmlowe has joined #openstack-keystone | 18:02 | |
| kmalloc | adriant: i left a bunch of comments on the receipt patch | 18:09 |
| kmalloc | adriant: i skipped reviewing the tests for now. they looked ok-ish, but there are some other changes I'd like to see that may impact the tests. | 18:09 |
| *** jmlowe_ has joined #openstack-keystone | 18:21 | |
| *** jmlowe has quit IRC | 18:23 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 18:24 | |
| *** AlexeyAbashkin has quit IRC | 18:43 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 18:47 | |
| *** aojea has joined #openstack-keystone | 18:51 | |
| *** aojea has quit IRC | 18:54 | |
| *** jmlowe_ has quit IRC | 18:56 | |
| *** AlexeyAbashkin has quit IRC | 18:59 | |
| *** s10 has quit IRC | 19:02 | |
| *** gyee has joined #openstack-keystone | 19:32 | |
| *** ayoung has quit IRC | 19:36 | |
| *** ayoung has joined #openstack-keystone | 19:48 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 19:58 | |
| *** AlexeyAbashkin has quit IRC | 20:05 | |
| *** edmondsw_ has joined #openstack-keystone | 20:09 | |
| *** edmondsw has quit IRC | 20:11 | |
| *** pcichy has quit IRC | 20:26 | |
| *** ayoung has quit IRC | 20:45 | |
| *** ayoung has joined #openstack-keystone | 20:47 | |
| *** jmlowe has joined #openstack-keystone | 21:01 | |
| *** martinus__ has quit IRC | 21:03 | |
| *** jmlowe has quit IRC | 21:11 | |
| *** nicolasbock_ has quit IRC | 21:15 | |
| *** aojea has joined #openstack-keystone | 21:34 | |
| *** jmlowe has joined #openstack-keystone | 21:49 | |
| *** edmondsw_ has quit IRC | 21:53 | |
| *** edmondsw has joined #openstack-keystone | 22:49 | |
| *** edmondsw has quit IRC | 22:54 | |
| *** openstackgerrit has joined #openstack-keystone | 23:15 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Expose random uuid bug in cadf notifications https://review.openstack.org/580780 | 23:15 |
| *** aojea has quit IRC | 23:17 | |
| *** raildo has quit IRC | 23:18 | |
| *** rcernin has joined #openstack-keystone | 23:36 | |
| *** masuberu has joined #openstack-keystone | 23:38 | |
| *** masber has quit IRC | 23:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!