*** gyee has quit IRC | 00:15 | |
kmalloc | knikolla, cmurphy: about to post a patchset that will pass tests. again, this is ugly and i def. need solid eyes on it. | 01:09 |
---|---|---|
knikolla | kmalloc: will give it a first pass tomorrow. | 01:14 |
kmalloc | knikolla: thnx | 01:51 |
kmalloc | ugh, we have a broken json_home document | 01:52 |
*** aojea has joined #openstack-keystone | 02:02 | |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-FEDERATION to flask native dispatching https://review.openstack.org/591082 | 02:02 |
*** aojea has quit IRC | 02:06 | |
*** dklyle has quit IRC | 03:50 | |
*** zhurong has joined #openstack-keystone | 04:36 | |
*** hoonetorg has quit IRC | 04:46 | |
*** hoonetorg has joined #openstack-keystone | 05:00 | |
*** zhurong has quit IRC | 05:43 | |
*** viks_ has quit IRC | 06:20 | |
*** zhurong has joined #openstack-keystone | 07:39 | |
*** zhurong has quit IRC | 08:42 | |
*** _ix_ has joined #openstack-keystone | 09:01 | |
*** _ix has quit IRC | 09:04 | |
*** zhurong has joined #openstack-keystone | 09:33 | |
*** zhurong has quit IRC | 10:31 | |
*** dave-mccowan has joined #openstack-keystone | 10:43 | |
*** dave-mccowan has quit IRC | 10:50 | |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Refactor ProviderAPIs object to better design pattern https://review.openstack.org/571955 | 13:02 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix RBACEnforcer get_member_from_driver mechanism https://review.openstack.org/591146 | 13:02 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert groups API to flask native dispatching https://review.openstack.org/591147 | 13:02 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix RBACEnforcer get_member_from_driver mechanism https://review.openstack.org/591146 | 13:05 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert groups API to flask native dispatching https://review.openstack.org/591147 | 13:05 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: import zuul job settings from project-config https://review.openstack.org/588697 | 14:45 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: add python 3.6 unit test job https://review.openstack.org/589599 | 14:45 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: fix documentation build https://review.openstack.org/591154 | 14:45 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix RBACEnforcer get_member_from_driver mechanism https://review.openstack.org/591146 | 15:39 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert groups API to flask native dispatching https://review.openstack.org/591147 | 15:39 |
*** shyamb has joined #openstack-keystone | 16:09 | |
*** shyamb has quit IRC | 16:15 | |
*** orange_julius74 has joined #openstack-keystone | 16:45 | |
orange_julius74 | Hey guys. I left my regular account logged in at work =( I've create a patch for the LDAPPool issue we have been discussing. Its in my github currently. What is the best way to get it into the project? | 16:46 |
orange_julius74 | Is the ldappool github accepting pull requests or should it go elsewhere? | 16:47 |
*** _ix has joined #openstack-keystone | 17:22 | |
kmalloc | orange_julius74: no worries, you'll need to submit it to gerrit (review.openstack.org) | 17:25 |
*** _ix_ has quit IRC | 17:25 | |
kmalloc | orange_julius74: https://docs.openstack.org/zaqar/latest/contributor/first_patch.html best reference guide i have | 17:26 |
orange_julius74 | Alrighty. I'll start working on that. Thanks! | 17:26 |
kmalloc | well one of them, obviously zaquar replaced with ldappool | 17:26 |
kmalloc | ;) | 17:26 |
orange_julius74 | Adding a test for this might be a little funky. I'm still sorting that out now | 17:27 |
kmalloc | let me know, i spend a lot of time writing wonky tests, i can probably give advice if you need it | 17:27 |
kmalloc | :) | 17:27 |
* kmalloc sighs. My patch stack is getting a bit deep again: https://review.openstack.org/#/q/status:open+project:openstack/keystone+branch:master+topic:bug/1776504 | 17:28 | |
kmalloc | cmurphy: after flask, i think i'll be working on stand-alone keystone stuff [or at least piling on to that] | 17:29 |
kmalloc | cmurphy: since flask should help to make it a bit easier. | 17:29 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: import zuul job settings from project-config https://review.openstack.org/588697 | 17:32 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: add python 3.6 unit test job https://review.openstack.org/589599 | 17:32 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: fix gate https://review.openstack.org/591162 | 17:32 |
orange_julius74 | Alright so I tried to keep the test inline with what was already there. I'm going to clean up the commits and fix a few indentation issues, but I was hoping to get your thoughts. https://github.com/ragingpastry/ldappool/blob/fix-pool-retry/ldappool/tests/test_ldapconnection.py | 17:35 |
kmalloc | cool. | 17:35 |
kmalloc | let me finish my test run and i'll take a look | 17:35 |
* kmalloc is running unit tests before adding yet-another-patch to the huge pile of "omg flask" conversion patches | 17:36 | |
orange_julius74 | Some things: _bind_fails on line 50 wasn't actually used so I kinda took over that. Looking back I probably should make a new function there. I also removed ldap.INVALID_CREDENTIALS from the check here: https://github.com/ragingpastry/ldappool/blob/fix-pool-retry/ldappool/__init__.py#L272 . It made sense to me since that is being throw up above and | 17:37 |
orange_julius74 | lets us test for invalid_credentials more specifically. Let me know if this sucks =P | 17:37 |
kmalloc | i doubt it will suck ;) | 17:37 |
kmalloc | hey, you're fixing a real bug for us, that in my mind already says "this doesn't suck" | 17:38 |
kmalloc | (even if you need some adjustments to the code to land it, still not "sucking") | 17:38 |
orange_julius74 | hehe alrighty. Well let me know whenever you get a chance! I'll be around | 17:41 |
kmalloc | do we need to actually raise up INVALID_CREDENTIALS or would a break of the loop be more correct? /me is still reading | 17:42 |
orange_julius74 | We could certainly just break out of the loop. It might be more clean to have all of the raise logic in one place (272) | 17:44 |
kmalloc | that was my initial thought | 17:44 |
kmalloc | i don't have a problem with it as is | 17:44 |
kmalloc | but it might be a lot cleaner to just break and raise out at 272 as needed | 17:44 |
orange_julius74 | Yup for sure. I'll change that | 17:44 |
kmalloc | if you have issues getting that patch into gerrit, i can help | 17:45 |
kmalloc | and submit on your behalf, but would pref if you can do it | 17:45 |
kmalloc | i'll also want to see the test(s) running in our gate. :) | 17:45 |
kmalloc | overall, i like the direction | 17:45 |
kmalloc | and it's a nice and simple patch | 17:45 |
*** aojea has joined #openstack-keystone | 17:46 | |
orange_julius74 | Cool I'll make that change and get working on getting patch into gerrit. Does the test I added make sense? | 17:53 |
*** aojea has quit IRC | 18:04 | |
kmalloc | mostly | 18:11 |
kmalloc | i don't see anything wonky with it at first glance | 18:12 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix a translation of log https://review.openstack.org/591164 | 18:31 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-INHERIT API to flask native dispatching https://review.openstack.org/591165 | 18:31 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-INHERIT API to flask native dispatching https://review.openstack.org/591165 | 20:17 |
*** Nel1x has joined #openstack-keystone | 20:52 | |
*** Nel1x has quit IRC | 21:19 | |
*** Nel1x has joined #openstack-keystone | 21:19 | |
openstackgerrit | Nick Wilburn proposed openstack/ldappool master: fix ldappool bad password retry logic https://review.openstack.org/591174 | 21:52 |
* orange_julius74 crosses fingers | 21:53 | |
*** evrardjp has quit IRC | 21:55 | |
kmalloc | woot | 22:09 |
kmalloc | thats a good first patch if i ever saw one:) | 22:09 |
kmalloc | orange_julius74: commented on your patch in gerrit. I'll upgrade to a +2 when i have a little more time to eyeball it. but it looks good. | 22:15 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: add lib-forward-testing-python3 test job https://review.openstack.org/591185 | 22:22 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.policy master: add lib-forward-testing-python3 test job https://review.openstack.org/591189 | 22:22 |
orange_julius74 | Awsome! | 22:49 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Add safety to the inferred target extraction during enforcement https://review.openstack.org/591203 | 23:09 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert role_assignments API to flask native dispatching https://review.openstack.org/590518 | 23:10 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert system (role) api to flask native dispatching https://review.openstack.org/590588 | 23:10 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Move json_home "extension" rel functions https://review.openstack.org/591025 | 23:10 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-FEDERATION to flask native dispatching https://review.openstack.org/591082 | 23:11 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Refactor ProviderAPIs object to better design pattern https://review.openstack.org/571955 | 23:11 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix RBACEnforcer get_member_from_driver mechanism https://review.openstack.org/591146 | 23:11 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert groups API to flask native dispatching https://review.openstack.org/591147 | 23:11 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix a translation of log https://review.openstack.org/591164 | 23:11 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-INHERIT API to flask native dispatching https://review.openstack.org/591165 | 23:11 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!