| *** gyee has quit IRC | 00:00 | |
| *** mvkr has quit IRC | 00:05 | |
| *** jessegler has quit IRC | 00:05 | |
| *** mvkr has joined #openstack-keystone | 00:18 | |
| *** imacdonn has quit IRC | 00:49 | |
| *** imacdonn has joined #openstack-keystone | 00:49 | |
| *** felipemonteiro has joined #openstack-keystone | 01:04 | |
| wxy-xiyuan | kmalloc: yeah, we have a option "unique_last_password_count", but it can't handle the case pw1 -> pw1. Since the minimum is 1 means there is no limit. So If we want to fix with it, we should let the minimum=0 means no limit. But it'll break the options default behavior. I'm not sure it's a good way? | 01:05 |
|---|---|---|
| wxy-xiyuan | https://bugs.launchpad.net/keystone/+bug/1787874 | 01:05 |
| openstack | Launchpad bug 1787874 in OpenStack Identity (keystone) "There is no way to forbid users changing password to itself" [Undecided,In progress] - Assigned to wangxiyuan (wangxiyuan) | 01:05 |
| *** bzhao__ has joined #openstack-keystone | 01:10 | |
| kmalloc | wxy-xiyuan: doing this in the controller is 100% wrong in either case. Also, changing the behavior is technically an API contract break | 01:12 |
| kmalloc | wxy-xiyuan: if anything it should be done in the same place we do the password history check. | 01:12 |
| kmalloc | wxy-xiyuan: right now the code doesn't actually check the password, it just fails if the password is the same, which is not the same thing as what you're trying to do. | 01:14 |
| kmalloc | You'll need to check the password and the new password (hashing) against the current and fail in the following ways: 1) original password is not valid, current behavior, 2) new password matches hash and original password matches, 400, 3) original password matches, new password does not: update to new password | 01:16 |
| kmalloc | So, in short, don't do it in the controller, do it in the manager/where we do history check. | 01:16 |
| wxy-xiyuan | kmalloc: OK. I'll look into the password history part to see what we can do there. | 01:16 |
| kmalloc | Cool | 01:19 |
| kmalloc | Also, make sure to clear it with lbragstad and clearly communicate this is a change in api behavior (in the release note) | 01:20 |
| kmalloc | I'll +2 it with those additional bits with the logic below the controller. | 01:20 |
| *** felipemonteiro has quit IRC | 01:27 | |
| bzhao__ | wxy-xiyuan: six | 01:28 |
| lbragstad | kmalloc: wxy-xiyuan i'm still parsing email but i should be back to reviews tomorrow - i hope | 01:57 |
| *** felipemonteiro has joined #openstack-keystone | 02:00 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: [WIP] Change unique_last_password_count default to 0 https://review.openstack.org/593476 | 02:28 |
| *** felipemonteiro has quit IRC | 02:43 | |
| vishakha | wxy-xiyuan: Ok thanks. I will put the comment on the patch. and will leave as it is. | 03:00 |
| *** markvoelker has joined #openstack-keystone | 03:01 | |
| vishakha | wxy-xiyuan: one more thing should I make you remember to discuss this in PTG?? | 03:02 |
| wxy-xiyuan | vishakha: we have a list for PTG topic here: https://etherpad.openstack.org/p/keystone-stein-ptg I'll update it later. | 03:05 |
| wxy-xiyuan | I'm not sure I'll attend PTG or not (Depend on my employer), Lance can pick it up I guess | 03:07 |
| vishakha | wxy-xiyuan: Yes pls update the topic list. | 03:09 |
| *** Nel1x has quit IRC | 03:34 | |
| *** felipemonteiro has joined #openstack-keystone | 04:25 | |
| *** hoonetorg has quit IRC | 04:29 | |
| *** markvoelker has quit IRC | 04:32 | |
| *** markvoelker has joined #openstack-keystone | 04:43 | |
| *** hoonetorg has joined #openstack-keystone | 04:47 | |
| *** shyamb has joined #openstack-keystone | 04:49 | |
| *** markvoelker has quit IRC | 04:52 | |
| *** hoonetorg has quit IRC | 04:54 | |
| *** hoonetorg has joined #openstack-keystone | 05:06 | |
| *** jaosorior has quit IRC | 05:45 | |
| *** jaosorior has joined #openstack-keystone | 05:47 | |
| *** shyamb has quit IRC | 05:56 | |
| *** shyamb has joined #openstack-keystone | 06:11 | |
| *** josecastroleon has joined #openstack-keystone | 06:12 | |
| *** shyamb has quit IRC | 06:29 | |
| *** rcernin has quit IRC | 06:38 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Change unique_last_password_count default to 0 https://review.openstack.org/593476 | 06:39 |
| *** rcernin has joined #openstack-keystone | 06:40 | |
| *** shyamb has joined #openstack-keystone | 06:41 | |
| *** pcaruana has joined #openstack-keystone | 06:42 | |
| *** rcernin has quit IRC | 06:51 | |
| *** shyamb has quit IRC | 07:18 | |
| *** shyamb has joined #openstack-keystone | 07:18 | |
| *** shyam89 has joined #openstack-keystone | 07:19 | |
| *** shyamb has quit IRC | 07:22 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Change unique_last_password_count default to 0 https://review.openstack.org/593476 | 07:26 |
| *** shyam89 has quit IRC | 07:28 | |
| *** shyam89 has joined #openstack-keystone | 07:28 | |
| *** shyam89 has quit IRC | 07:34 | |
| *** shyam89 has joined #openstack-keystone | 07:35 | |
| *** shyam89 has quit IRC | 07:39 | |
| *** shyam89 has joined #openstack-keystone | 07:43 | |
| *** felipemonteiro has quit IRC | 07:57 | |
| *** shyam89 has quit IRC | 07:59 | |
| *** shyamb has joined #openstack-keystone | 07:59 | |
| *** yankcrime has joined #openstack-keystone | 08:11 | |
| *** shyamb has quit IRC | 08:29 | |
| *** shyamb has joined #openstack-keystone | 08:52 | |
| cmurphy | lbragstad: since you're up, want to ack https://review.openstack.org/593613 and https://review.openstack.org/593606 ? | 09:21 |
| lbragstad | cmurphy: ack - thanks for keeping an eye on that | 09:23 |
| cmurphy | np | 09:23 |
| cmurphy | the releases one won't pass until the project-config one is in | 09:23 |
| lbragstad | oh - good call | 09:23 |
| *** ktibi has joined #openstack-keystone | 10:17 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/keystone master: Implement Trust Flush via keystone-manage. https://review.openstack.org/589378 | 10:21 |
| ktibi | hi keystone. Simple question about domain and LDAP. Can I use a domain which use LDAP backend for user and tenant and keep sql for service user like nova, glance.... ??? | 10:26 |
| *** Rhvs has quit IRC | 10:29 | |
| *** Rhvs has joined #openstack-keystone | 10:31 | |
| lbragstad | ktibi: yeah - that's a supported deployment pattern | 10:33 |
| ktibi | lbragstad, great ;) thx | 10:33 |
| lbragstad | ktibi: https://docs.openstack.org/keystone/latest/admin/identity-domain-specific-config.html | 10:33 |
| *** shyamb has quit IRC | 10:43 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone-specs master: Repropose capability lists to Stein https://review.openstack.org/594123 | 10:43 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone-specs master: Switch to stestr https://review.openstack.org/581326 | 11:06 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone-specs master: Repropose capability lists to Stein https://review.openstack.org/594123 | 11:08 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone-specs master: Move MFA receipt specification to Stein https://review.openstack.org/594129 | 11:08 |
| lbragstad | adriant: ^ | 11:08 |
| lbragstad | jgrassler ^ | 11:09 |
| lbragstad | feel free to take those over if there are details that need to be updated | 11:09 |
| lbragstad | i mainly just wanted to update the rocky specs repository to be accurate with what actually landed | 11:09 |
| lbragstad | hrybacki: fyi - i created a new stein trello board | 11:23 |
| lbragstad | hrybacki: kmalloc also - do you happen to know if mike has an irc nick and is available? https://review.openstack.org/#/c/541903/6 | 11:31 |
| lbragstad | i have a few questions regarding the actual jwt implementation and he seems pretty familiar with the underlying library bits | 11:31 |
| *** shyamb has joined #openstack-keystone | 11:38 | |
| hrybacki | lbragstad: mike? | 12:15 |
| lbragstad | mike fedosin | 12:15 |
| hrybacki | hmm, doesn't ring a bell. Memory lapse or? | 12:16 |
| lbragstad | https://review.openstack.org/#/c/541903/ | 12:17 |
| lbragstad | he was apparently reviewing the jwt stuff | 12:17 |
| *** raildo has joined #openstack-keystone | 12:17 | |
| lbragstad | and appears to be from redhat | 12:17 |
| hrybacki | he does, lemme look intenrallyh | 12:19 |
| wxy-xiyuan | lbragstad: called mfedosin in glance channel. He was one of Glance core reviewer. | 12:20 |
| lbragstad | oh - nice | 12:20 |
| lbragstad | wxy-xiyuan: good call - thanks | 12:20 |
| hrybacki | wxy-xiyuan: beat me to it :) | 12:21 |
| wxy-xiyuan | hah | 12:21 |
| lbragstad | hrybacki: also - let me know if you want go through the trello board prior to denver | 12:25 |
| lbragstad | both Rocky and Stein | 12:25 |
| openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Add Keystone2Keystone example https://review.openstack.org/594156 | 12:50 |
| cmurphy | wxy-xiyuan: ^ | 12:50 |
| *** ktibi has quit IRC | 12:56 | |
| *** shyamb has quit IRC | 13:05 | |
| *** s10 has joined #openstack-keystone | 13:08 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Convert policy API to flask https://review.openstack.org/589950 | 13:16 |
| hrybacki | lbragstad: I would. I'll shoot you a calendar invite if that works? | 13:48 |
| lbragstad | wfm | 13:48 |
| *** felipemonteiro has joined #openstack-keystone | 13:59 | |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.policy master: sphinxext: Start parsing 'DocumentedRuleDefault.description' as rST https://review.openstack.org/594222 | 14:05 |
| *** felipemonteiro has quit IRC | 14:07 | |
| *** shyamb has joined #openstack-keystone | 14:16 | |
| *** lbragstad has quit IRC | 14:26 | |
| *** felipemonteiro has joined #openstack-keystone | 14:26 | |
| *** felipemonteiro has quit IRC | 14:32 | |
| gagehugo | o/ | 14:35 |
| *** wxy| has joined #openstack-keystone | 14:44 | |
| *** shyamb has quit IRC | 14:44 | |
| *** r-daneel has joined #openstack-keystone | 14:47 | |
| *** felipemonteiro has joined #openstack-keystone | 14:56 | |
| *** felipemonteiro has quit IRC | 15:02 | |
| *** lbragstad has joined #openstack-keystone | 15:02 | |
| *** ChanServ sets mode: +o lbragstad | 15:02 | |
| *** felipemonteiro has joined #openstack-keystone | 15:03 | |
| *** felipemonteiro has quit IRC | 15:05 | |
| *** pcaruana has quit IRC | 15:09 | |
| hrybacki | o/ | 15:10 |
| *** s10 has quit IRC | 15:18 | |
| *** felipemonteiro has joined #openstack-keystone | 15:30 | |
| *** felipemonteiro has quit IRC | 15:32 | |
| kmalloc | lbragstad: going to be a little late to the meeting today | 15:33 |
| lbragstad | thanks for the heads up | 15:33 |
| kmalloc | lbragstad: dog walk and need to call health insurance company :( | 15:34 |
| *** dklyle has quit IRC | 15:41 | |
| *** dklyle has joined #openstack-keystone | 15:44 | |
| *** timburke has quit IRC | 15:45 | |
| *** gyee has joined #openstack-keystone | 15:56 | |
| *** itlinux has joined #openstack-keystone | 15:59 | |
| *** ayoung has joined #openstack-keystone | 16:07 | |
| *** s10 has joined #openstack-keystone | 16:39 | |
| * gagehugo goes to grab lunch | 16:42 | |
| *** wxy| has quit IRC | 16:43 | |
| *** s10 has quit IRC | 16:46 | |
| *** felipemonteiro has joined #openstack-keystone | 16:48 | |
| *** markvoelker has joined #openstack-keystone | 16:50 | |
| *** felipemonteiro has quit IRC | 16:52 | |
| *** nicolasbock has joined #openstack-keystone | 16:59 | |
| lbragstad | #startmeeting keystone-office-hours | 17:01 |
| openstack | lbragstad: Error: Can't start another meeting, one is in progress. Use #endmeeting first. | 17:01 |
| lbragstad | #endmeeting | 17:01 |
| *** openstack changes topic to "Rocky release schedule: https://releases.openstack.org/rocky/schedule.html | Meeting agenda: https://etherpad.openstack.org/p/keystone-weekly-meeting | Bugs that need triaging: http://bit.ly/2iJuN1h | Trello: https://trello.com/b/wmyzbFq5/keystone-rocky-roadmap !!NOTE!! This Channel is Logged ( https://tinyurl.com/OpenStackKeystone )" | 17:01 | |
| openstack | Meeting ended Tue Aug 21 17:01:43 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:01 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-08-07-17.00.html | 17:01 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-08-07-17.00.txt | 17:01 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-08-07-17.00.log.html | 17:01 |
| lbragstad | nice | 17:02 |
| lbragstad | i think that's a new record of longest office-hours session | 17:02 |
| lbragstad | (two weeks) | 17:02 |
| lbragstad | #startmeeting keystone-office-hours | 17:03 |
| openstack | Meeting started Tue Aug 21 17:03:17 2018 UTC and is due to finish in 60 minutes. The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot. | 17:03 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 17:03 |
| *** openstack changes topic to " (Meeting topic: keystone-office-hours)" | 17:03 | |
| *** ChanServ changes topic to "Rocky release schedule: https://releases.openstack.org/rocky/schedule.html | Meeting agenda: https://etherpad.openstack.org/p/keystone-weekly-meeting | Bugs that need triaging: http://bit.ly/2iJuN1h | Trello: https://trello.com/b/wmyzbFq5/keystone-rocky-roadmap !!NOTE!! This Channel is Logged ( https://tinyurl.com/OpenStackKeystone )" | 17:03 | |
| openstack | The meeting name has been set to 'keystone_office_hours' | 17:03 |
| kmalloc | ayoung: responded to that email re: ksm and flask apps without paste | 17:03 |
| ayoung | TYVM | 17:04 |
| kmalloc | ayoung: it is a little wonky becuase yo have to do hoops to load the middleware correctly, but keystone.server.flask.core has code that does exactly what was being asked for. | 17:04 |
| ayoung | looking | 17:04 |
| kmalloc | https://github.com/openstack/keystone/blob/c896f911efecfddf07a3d1117ced7fc271ee70cb/keystone/server/flask/core.py#L125 | 17:04 |
| ayoung | kmalloc, I don't think they are doing Stevedore. Is that a requirement? | 17:06 |
| kmalloc | nope | 17:06 |
| kmalloc | but we use it to load since we only really have entry points we can lean on in some cases. | 17:07 |
| kmalloc | stevedore makes it a little easer in some ways, harder in others. | 17:07 |
| * lbragstad goes to make coffee | 17:07 | |
| ayoung | so in their code, they explicitly load KSM and add it to the pipeline | 17:07 |
| ayoung | ksm = keystonemiddleware.auth.something | 17:08 |
| kmalloc | yeah, in the flask way they'd load (import) ksm and then do flask_app.wsgi_app = ksm_init_func_name(flask_app.wsgi_app) | 17:08 |
| openstackgerrit | 98k proposed openstack/keystone master: import zuul job settings from project-config https://review.openstack.org/594440 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystone master: switch documentation job to new PTI https://review.openstack.org/594441 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystone master: add python 3.6 unit test job https://review.openstack.org/594442 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystone master: import zuul job settings from project-config https://review.openstack.org/594443 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystone master: switch documentation job to new PTI https://review.openstack.org/594444 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystoneauth master: import zuul job settings from project-config https://review.openstack.org/594445 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystoneauth master: switch documentation job to new PTI https://review.openstack.org/594446 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystoneauth master: add python 3.6 unit test job https://review.openstack.org/594447 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystoneauth master: add lib-forward-testing-python3 test job https://review.openstack.org/594448 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystoneauth master: import zuul job settings from project-config https://review.openstack.org/594449 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystoneauth master: switch documentation job to new PTI https://review.openstack.org/594450 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystonemiddleware master: import zuul job settings from project-config https://review.openstack.org/594451 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystonemiddleware master: switch documentation job to new PTI https://review.openstack.org/594452 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystonemiddleware master: add python 3.6 unit test job https://review.openstack.org/594453 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystonemiddleware master: add lib-forward-testing-python3 test job https://review.openstack.org/594454 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystonemiddleware master: import zuul job settings from project-config https://review.openstack.org/594455 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystonemiddleware master: switch documentation job to new PTI https://review.openstack.org/594456 | 17:08 |
| openstackgerrit | 98k proposed openstack/keystone-specs master: import zuul job settings from project-config https://review.openstack.org/594457 | 17:09 |
| openstackgerrit | 98k proposed openstack/keystone-tempest-plugin master: import zuul job settings from project-config https://review.openstack.org/594458 | 17:09 |
| openstackgerrit | 98k proposed openstack/ldappool master: import zuul job settings from project-config https://review.openstack.org/594459 | 17:09 |
| openstackgerrit | 98k proposed openstack/ldappool master: add python 3.6 unit test job https://review.openstack.org/594460 | 17:09 |
| ayoung | ksm_factory = keystonemiddleware.auth_token.app_factory | 17:09 |
| kmalloc | omg. | 17:09 |
| openstackgerrit | 98k proposed openstack/pycadf master: import zuul job settings from project-config https://review.openstack.org/594461 | 17:09 |
| openstackgerrit | 98k proposed openstack/pycadf master: switch documentation job to new PTI https://review.openstack.org/594462 | 17:09 |
| openstackgerrit | 98k proposed openstack/pycadf master: add python 3.6 unit test job https://review.openstack.org/594463 | 17:09 |
| openstackgerrit | 98k proposed openstack/pycadf master: add lib-forward-testing-python3 test job https://review.openstack.org/594464 | 17:09 |
| openstackgerrit | 98k proposed openstack/pycadf master: import zuul job settings from project-config https://review.openstack.org/594465 | 17:09 |
| openstackgerrit | 98k proposed openstack/pycadf master: switch documentation job to new PTI https://review.openstack.org/594466 | 17:09 |
| openstackgerrit | 98k proposed openstack/python-keystoneclient master: import zuul job settings from project-config https://review.openstack.org/594467 | 17:09 |
| openstackgerrit | 98k proposed openstack/python-keystoneclient master: switch documentation job to new PTI https://review.openstack.org/594468 | 17:09 |
| openstackgerrit | 98k proposed openstack/python-keystoneclient master: add python 3.6 unit test job https://review.openstack.org/594469 | 17:09 |
| openstackgerrit | 98k proposed openstack/python-keystoneclient master: add lib-forward-testing-python3 test job https://review.openstack.org/594470 | 17:09 |
| openstackgerrit | 98k proposed openstack/python-keystoneclient master: import zuul job settings from project-config https://review.openstack.org/594471 | 17:09 |
| openstackgerrit | 98k proposed openstack/python-keystoneclient master: switch documentation job to new PTI https://review.openstack.org/594472 | 17:09 |
| * kmalloc wants to kick openstackgerrit all of a sudden | 17:09 | |
| kmalloc | lbragstad: are we moving to py3.6 ^ just because... | 17:11 |
| kmalloc | lbragstad: i'm not opposed to it, just want to know if it's really a project plan | 17:12 |
| kmalloc | ayoung: there is some magic config stuff that has to be passed around with the factory methods | 17:12 |
| kmalloc | ayoung: but you can also directly call init, if you're directly importing | 17:12 |
| ayoung | kmalloc, I'd like to give them a more workable example | 17:13 |
| ayoung | let me see if I have their code. might be easier to discuss | 17:13 |
| kmalloc | unfortunately, that is about as workable as you get with webob-middleware wrapping flask | 17:13 |
| kmalloc | i looked in depth into this | 17:13 |
| kmalloc | ksm is very webob oriented | 17:13 |
| kmalloc | so you need to webob-based things. | 17:13 |
| kmalloc | it passes down the request and all that stuff just fine, and flask turns it into a werkzeug request a-ok | 17:14 |
| ayoung | kmalloc, I just mean something they can actually code. I don't think we've given enough info yet | 17:14 |
| kmalloc | sure. i was largely assuming they can derive how it works from our code, but if they need more detail, i can help supply | 17:14 |
| kmalloc | i am not in the business of assuming someone can't read the code and either a) determine they have enough info, or b) ask more questions | 17:15 |
| kmalloc | i offered to help further if needed. | 17:15 |
| kmalloc | (for that reason) | 17:15 |
| *** dave-mccowan has quit IRC | 17:44 | |
| lbragstad | what just happened? | 17:50 |
| kmalloc | lbragstad: someone proposed a TON of "py3.6" stuff | 17:51 |
| gagehugo | oh wow | 17:52 |
| *** portdirect has quit IRC | 17:54 | |
| mtreinish | kmalloc: I think that's all generated by a script. dhellmann has been talking about it on the ML | 18:03 |
| lbragstad | that reminds me - i need to get to that thread | 18:10 |
| kmalloc | mtreinish: its spaaaaaaaaaaaamy :) | 18:13 |
| lbragstad | ok - qq | 18:14 |
| lbragstad | i'm trying to figure out the best way to implements DRY tests for https://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/policies/credential.py#n21 | 18:14 |
| lbragstad | and this is the skeleton i have so far http://paste.openstack.org/show/728547/ | 18:15 |
| lbragstad | does anyone have a better idea for testing this stuff? | 18:18 |
| lbragstad | i'll settle with http://paste.openstack.org/show/728547/ for now since it's arguable better organized that what we have in test_v3_protection, but open to suggestions if anyone has them | 18:18 |
| kmalloc | lbragstad: hm | 18:24 |
| lbragstad | feels like i'm duplicating a lot still | 18:25 |
| lbragstad | and with how many of these we're going to have to write, i'd like to start off on a better foot if possible | 18:25 |
| kmalloc | right, so you are going to duplicate a lot | 18:25 |
| kmalloc | it's the nature of testing. | 18:25 |
| kmalloc | you can combine *some* things | 18:26 |
| kmalloc | in external functions/methods that do the work that is common | 18:26 |
| kmalloc | but testing *is* a lot less DRY than the rest of python | 18:26 |
| kmalloc | code | 18:26 |
| kmalloc | lbragstad: the key is that testing really is going to duplicate work because each test really is isolated for the most part. | 18:29 |
| kmalloc | e.g. "get_me_a_token" type method is good to abstract out, "do a request that affects credentials in X way" probably shouldn't be abstracted out | 18:30 |
| *** dave-mccowan has joined #openstack-keystone | 18:30 | |
| kmalloc | the workflow of "after setup", should be explicit imo | 18:30 |
| *** dave-mccowan has quit IRC | 18:35 | |
| lbragstad | maybe something like this? http://paste.openstack.org/show/728550/ | 18:35 |
| *** NobodyCam has quit IRC | 18:37 | |
| *** sonuk has quit IRC | 18:37 | |
| *** rledisez has quit IRC | 18:37 | |
| *** lamt has quit IRC | 18:37 | |
| *** eEbx has quit IRC | 18:37 | |
| *** kencjohnston has quit IRC | 18:37 | |
| *** fungi has quit IRC | 18:37 | |
| *** kencjohnston_ has joined #openstack-keystone | 18:38 | |
| *** rledisez has joined #openstack-keystone | 18:38 | |
| lbragstad | actually - http://paste.openstack.org/show/728552/ | 18:39 |
| kmalloc | lbragstad: that doesn't look too bad, however, i highly recommend not doing "mixin" style objects. It makes the analysis (static and otherwise) harder. | 18:39 |
| kmalloc | lbragstad: so, imo, don't have objects not based upon the unit test base. | 18:39 |
| lbragstad | you mean have all test classes inherit from the test class directly instead of `object`? | 18:40 |
| kmalloc | yeah | 18:40 |
| kmalloc | if it's a common "case" make the common case on the module base test. | 18:40 |
| kmalloc | i really really hate the whole "this object implements tests and is just mixed in to make it work" | 18:41 |
| kmalloc | i would rather see fully featured test cases. | 18:42 |
| *** Chealion has quit IRC | 18:42 | |
| *** breton has quit IRC | 18:42 | |
| *** dstanek has quit IRC | 18:42 | |
| *** TheJulia has quit IRC | 18:42 | |
| *** tobberydberg has quit IRC | 18:42 | |
| *** hrybacki has quit IRC | 18:42 | |
| *** mnaser has quit IRC | 18:42 | |
| *** tsufiev has quit IRC | 18:42 | |
| kmalloc | e.g.: TestCase->CredentialBaseTestCase[common code/common tests]->OverrideTestCaseClass[overrides/specifics] | 18:42 |
| *** dstanek has joined #openstack-keystone | 18:42 | |
| kmalloc | but thats just me. | 18:43 |
| lbragstad | yeah - i can see the point | 18:43 |
| kmalloc | remember special cases such as (iirc) _ prefixed tests aren't run. | 18:43 |
| lbragstad | yeah - test's have to start with `test` | 18:44 |
| lbragstad | otherwise i don't think they're picked up by discovery | 18:44 |
| kmalloc | if we are "mixing" in tests because we're doing DRY, i think we're just doing it wrong, it means we are over-doing the DRY bit. | 18:44 |
| kmalloc | i would be 100% ok with tests being all explicit no shared code, because it is explicit | 18:45 |
| kmalloc | it doesn't allow "accidently" changing one test and affecting others | 18:45 |
| kmalloc | there are cases where it has been painful to fix things because tests are so inter-mingled | 18:45 |
| kmalloc | tests are a case i would highly advocate for not DRYing *except* to make adding new tests easy. but any/all code flow for a test should be explicit. | 18:46 |
| *** jrist has quit IRC | 18:46 | |
| *** fungi has joined #openstack-keystone | 18:48 | |
| *** TheJulia has joined #openstack-keystone | 19:02 | |
| *** mnaser has joined #openstack-keystone | 19:09 | |
| *** r-daneel has quit IRC | 19:24 | |
| *** r-daneel has joined #openstack-keystone | 19:24 | |
| *** breton has joined #openstack-keystone | 19:29 | |
| gagehugo | lbragstad kmalloc was this resolved: https://bugs.launchpad.net/keystone/+bug/1778603 | 19:31 |
| openstack | Launchpad bug 1778603 in OpenStack Identity (keystone) "Documentation builds failing with Sphinx 1.7.5" [High,In progress] - Assigned to Morgan Fainberg (mdrnstm) | 19:31 |
| lbragstad | i don't think so | 19:32 |
| lbragstad | to work around is to not use v 1.7.5 | 19:32 |
| lbragstad | otherwise - it needs to be fixed upstream | 19:32 |
| lbragstad | https://github.com/oauthlib/oauthlib/issues/558 | 19:33 |
| *** melwitt has quit IRC | 19:33 | |
| *** mancdaz has quit IRC | 19:34 | |
| *** chrome0 has quit IRC | 19:34 | |
| *** Dano8080 has quit IRC | 19:34 | |
| *** melwitt has joined #openstack-keystone | 19:34 | |
| gagehugo | ah | 19:36 |
| *** chrome0 has joined #openstack-keystone | 19:36 | |
| gagehugo | wasn't sure if the work-around was enough on our end | 19:37 |
| *** evrardjp has quit IRC | 19:39 | |
| *** jistr|off has quit IRC | 19:39 | |
| *** timothyb89 has quit IRC | 19:39 | |
| *** Neptu has quit IRC | 19:39 | |
| *** rodrigods has quit IRC | 19:39 | |
| *** tadams12083_ has quit IRC | 19:39 | |
| lbragstad | we'll need to consume a version of oauthlib that fixes the issues i tink | 19:42 |
| lbragstad | thin* | 19:42 |
| * lbragstad gives up | 19:43 | |
| lbragstad | i didn't want to spell that work correctly anyway | 19:43 |
| *** Neptu has joined #openstack-keystone | 19:43 | |
| * lbragstad sigh | 19:43 | |
| gagehugo | lol | 19:43 |
| *** samueldmq has quit IRC | 19:46 | |
| * cmurphy pats lbragstad on the head | 19:47 | |
| *** jistr has joined #openstack-keystone | 19:47 | |
| *** Rhvs has quit IRC | 19:47 | |
| *** BlackDex has quit IRC | 19:48 | |
| *** wxy-xiyuan has quit IRC | 19:48 | |
| *** samueldmq has joined #openstack-keystone | 19:49 | |
| *** BlackDex has joined #openstack-keystone | 19:52 | |
| *** r-daneel has quit IRC | 20:03 | |
| *** r-daneel has joined #openstack-keystone | 20:03 | |
| *** Tahvok_ has joined #openstack-keystone | 20:12 | |
| *** gmann_ has joined #openstack-keystone | 20:13 | |
| *** jaosorior_ has joined #openstack-keystone | 20:14 | |
| *** jaosorior has quit IRC | 20:17 | |
| *** edmondsw_ has joined #openstack-keystone | 20:18 | |
| *** Tahvok has quit IRC | 20:19 | |
| *** edmondsw has quit IRC | 20:19 | |
| *** gmann has quit IRC | 20:19 | |
| *** hugokuo has quit IRC | 20:19 | |
| *** edmondsw_ is now known as edmondsw | 20:19 | |
| *** gmann_ is now known as gmann | 20:19 | |
| *** Tahvok_ is now known as Tahvok | 20:19 | |
| *** blake has joined #openstack-keystone | 20:29 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: WIP: re-use bootstrap in tests https://review.openstack.org/564905 | 20:43 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: WIP: Implement scope_type checking for credentials https://review.openstack.org/594547 | 20:43 |
| lbragstad | super super rough ^ | 20:43 |
| lbragstad | but i'd appreciate any early feedback | 20:43 |
| lbragstad | (the tests aren't very DRY) | 20:43 |
| lbragstad | and i need to open a bug for that API | 20:44 |
| lbragstad | but we should be able to do more things like that throughout stein hopefully, as apis convert to flask | 20:44 |
| lbragstad | #endmeeting | 20:45 |
| *** openstack changes topic to "Rocky release schedule: https://releases.openstack.org/rocky/schedule.html | Meeting agenda: https://etherpad.openstack.org/p/keystone-weekly-meeting | Bugs that need triaging: http://bit.ly/2iJuN1h | Trello: https://trello.com/b/wmyzbFq5/keystone-rocky-roadmap !!NOTE!! This Channel is Logged ( https://tinyurl.com/OpenStackKeystone )" | 20:45 | |
| openstack | Meeting ended Tue Aug 21 20:45:30 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 20:45 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-08-21-17.03.html | 20:45 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-08-21-17.03.txt | 20:45 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-08-21-17.03.log.html | 20:45 |
| *** raildo has quit IRC | 20:46 | |
| * lbragstad steps away | 20:49 | |
| *** blake has quit IRC | 20:53 | |
| *** blake has joined #openstack-keystone | 20:54 | |
| *** harlowja has joined #openstack-keystone | 21:02 | |
| *** itlinux has quit IRC | 21:51 | |
| *** blake_ has joined #openstack-keystone | 21:55 | |
| *** blake_ has quit IRC | 21:55 | |
| *** blake has quit IRC | 21:59 | |
| *** rha has quit IRC | 22:02 | |
| *** rcernin has joined #openstack-keystone | 22:10 | |
| *** r-daneel has quit IRC | 23:09 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!