*** devx has quit IRC | 00:11 | |
*** aning has quit IRC | 00:11 | |
*** aning has joined #openstack-keystone | 00:12 | |
*** gyee has quit IRC | 00:15 | |
*** devx has joined #openstack-keystone | 00:16 | |
*** rcernin has quit IRC | 00:29 | |
*** zhurong has joined #openstack-keystone | 00:49 | |
*** zhurong has quit IRC | 00:50 | |
*** Dinesh_Bhor has joined #openstack-keystone | 01:21 | |
wxy-xiyuan | lbragstad: I'll add sdk patch today. | 01:23 |
---|---|---|
*** gagehugo_ has quit IRC | 01:24 | |
*** gagehugo has joined #openstack-keystone | 01:25 | |
kmalloc | hopefully i'll have the last bits of webob shredded from keystone soon (last vestiges) | 01:28 |
kmalloc | it's so close... | 01:28 |
kmalloc | i can taste it | 01:28 |
openstackgerrit | Merged openstack/keystone master: Convert auth to flask native dispatching https://review.openstack.org/603461 | 01:52 |
*** rcernin has joined #openstack-keystone | 02:01 | |
lbragstad | wxy-xiyuan cool - happy to review whenever | 02:20 |
*** dave-mccowan has quit IRC | 02:21 | |
*** itlinux_ has joined #openstack-keystone | 02:28 | |
*** itlinux has quit IRC | 02:31 | |
openstackgerrit | Merged openstack/keystone master: Auth flask conversion cleanup https://review.openstack.org/608756 | 02:34 |
*** felipemonteiro has joined #openstack-keystone | 02:38 | |
*** lbragstad has quit IRC | 02:40 | |
tonyb | lbragstad, gagehugo: Yeah the bump of oslo.log (and other libraries) is a policy violation. However I admit I'm a little on the fence about it as clearly the version we're listing are bogus so anyone using thin will be broken. | 03:53 |
tonyb | lbragstad, gagehugo: Perhaps we can look at the chnage again and see which, if any, are testing only issues or issues only when certain config options are set | 03:54 |
*** shyamb has joined #openstack-keystone | 03:57 | |
*** felipemonteiro has quit IRC | 04:11 | |
*** felipemonteiro has joined #openstack-keystone | 04:17 | |
*** shyamb has quit IRC | 04:24 | |
*** shyamb has joined #openstack-keystone | 04:35 | |
*** felipemonteiro has quit IRC | 04:41 | |
*** shyamb has quit IRC | 04:53 | |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.policy master: Implement base for pluggable policy drivers https://review.openstack.org/577807 | 05:04 |
*** shyamb has joined #openstack-keystone | 05:05 | |
*** hoonetorg has quit IRC | 05:09 | |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.policy master: Implement base for pluggable policy drivers https://review.openstack.org/577807 | 05:12 |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.policy master: Implement base for pluggable policy drivers https://review.openstack.org/577807 | 05:15 |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.policy master: POC: Add Open Policy Agent driver https://review.openstack.org/604038 | 05:18 |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.policy master: POC: Add Open Policy Agent driver https://review.openstack.org/604038 | 05:21 |
*** aojea has joined #openstack-keystone | 05:33 | |
*** aojea has quit IRC | 05:42 | |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.policy master: POC: Add Open Policy Agent driver https://review.openstack.org/604038 | 05:52 |
*** pcaruana has joined #openstack-keystone | 06:01 | |
*** shyamb has quit IRC | 06:24 | |
*** dims has quit IRC | 06:29 | |
*** dims has joined #openstack-keystone | 06:33 | |
*** jrist has joined #openstack-keystone | 06:33 | |
*** dims has quit IRC | 06:38 | |
*** dims has joined #openstack-keystone | 06:39 | |
*** shyamb has joined #openstack-keystone | 06:50 | |
*** rcernin has quit IRC | 07:01 | |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.policy master: Implement base for pluggable policy drivers https://review.openstack.org/577807 | 07:04 |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.policy master: POC: Add Open Policy Agent driver https://review.openstack.org/604038 | 07:04 |
*** jrist has quit IRC | 07:09 | |
*** errr has joined #openstack-keystone | 07:31 | |
*** shyamb has quit IRC | 07:43 | |
*** Dinesh_Bhor has quit IRC | 08:03 | |
errr | Im trying to map federated users to local ones. I have the following mapping file: https://gist.github.com/michaelrice/67dc4cce606dc208d45482b54060ac76 and testing with the mapping engine it seems like it would work, but when I log in I get: Could not map any federated user properties to identity values. Check debug logs or the mapping used for additional details. | 08:17 |
errr | Do I have my mapping file created wrong? | 08:18 |
*** shyamb has joined #openstack-keystone | 08:27 | |
openstackgerrit | Vishakha Agarwal proposed openstack/keystone master: Remaining cases of MappingEngineTester https://review.openstack.org/606912 | 08:33 |
*** mvkr has quit IRC | 08:38 | |
cmurphy | errr: did you check the debug logs? there should be a few lines in there about what the mapped values came out to | 08:38 |
openstackgerrit | Merged openstack/keystone master: Replace openSUSE experimental check with newer version https://review.openstack.org/609465 | 08:39 |
errr | cmurphy: as in keystone.log? | 08:39 |
cmurphy | errr: yes | 08:39 |
cmurphy | with debug=true in keystone.conf | 08:40 |
cmurphy | possibly insecure_debug=true too but i don't think that's necessary for those mapping engine logs | 08:40 |
errr | I think I just have insecure_debug enabled | 08:40 |
cmurphy | you need debug too, one doesn't imply the other | 08:41 |
errr | cmurphy: what am I looking for in here. Now there is so much output. | 08:44 |
cmurphy | heh | 08:46 |
cmurphy | let me check | 08:46 |
errr | thanks | 08:50 |
cmurphy | errr: http://paste.openstack.org/show/731881/ | 08:51 |
cmurphy | the top half is the assertion values and the bottom half is the mapping | 08:51 |
errr | there is no "mapped_properties" entry for this user | 08:53 |
errr | the assertion data is there for that user, but not the mapped_properties | 08:54 |
errr | well now its working. I didnt change anything.. wtf | 08:57 |
openstackgerrit | Vishakha Agarwal proposed openstack/keystone master: Fix wrong URL of keystone-specs https://review.openstack.org/609629 | 08:57 |
cmurphy | errr: magic | 08:58 |
errr | ¯\_(ツ)_/¯ | 08:58 |
errr | so is there a way to disable to local login abilities for users I map via federation? | 09:00 |
cmurphy | you could make sure the local users don't have passwords set | 09:02 |
errr | ok | 09:02 |
errr | thanks for the help :) | 09:02 |
cmurphy | yw :) | 09:02 |
*** mvkr has joined #openstack-keystone | 09:09 | |
*** nicolasbock has quit IRC | 09:12 | |
*** jistr is now known as jistr|call | 09:12 | |
*** Dinesh_Bhor has joined #openstack-keystone | 09:14 | |
*** Dinesh_Bhor has quit IRC | 09:28 | |
*** shyamb has quit IRC | 09:34 | |
*** shyamb has joined #openstack-keystone | 09:34 | |
*** shyamb has quit IRC | 09:39 | |
*** shyamb has joined #openstack-keystone | 09:42 | |
*** imacdonn has quit IRC | 09:52 | |
*** imacdonn has joined #openstack-keystone | 09:53 | |
*** Dinesh_Bhor has joined #openstack-keystone | 10:08 | |
*** dmellado has quit IRC | 10:17 | |
*** shyamb has quit IRC | 10:35 | |
*** jistr|call is now known as jistr | 11:00 | |
*** shyamb has joined #openstack-keystone | 11:01 | |
*** shyamb has quit IRC | 11:06 | |
*** Emine has joined #openstack-keystone | 11:13 | |
*** belmorei_ has joined #openstack-keystone | 11:14 | |
*** shyamb has joined #openstack-keystone | 11:14 | |
*** belmoreira has quit IRC | 11:17 | |
*** Dinesh_Bhor has quit IRC | 11:26 | |
*** belmorei_ has quit IRC | 11:36 | |
*** aojea has joined #openstack-keystone | 11:40 | |
*** Dinesh_Bhor has joined #openstack-keystone | 11:44 | |
*** Dinesh_Bhor has quit IRC | 11:45 | |
*** shyamb has quit IRC | 11:45 | |
*** shyamb has joined #openstack-keystone | 11:45 | |
*** dave-mccowan has joined #openstack-keystone | 12:06 | |
*** dmellado has joined #openstack-keystone | 12:10 | |
gagehugo | o/ | 12:12 |
*** dave-mccowan has quit IRC | 12:19 | |
*** aojea has quit IRC | 12:55 | |
*** aojea has joined #openstack-keystone | 12:55 | |
hrybacki | gagehugo: that balance is kmalloc ;)] | 12:56 |
*** aojea has quit IRC | 13:00 | |
*** shyamb has quit IRC | 13:01 | |
*** dims has quit IRC | 13:12 | |
*** dims has joined #openstack-keystone | 13:14 | |
*** felipemonteiro has joined #openstack-keystone | 13:17 | |
*** dims has quit IRC | 13:19 | |
*** lbragstad has joined #openstack-keystone | 13:31 | |
*** ChanServ sets mode: +o lbragstad | 13:31 | |
*** jrist has joined #openstack-keystone | 13:33 | |
*** aojea has joined #openstack-keystone | 13:36 | |
*** felipemonteiro has quit IRC | 13:44 | |
aning | Question about unique_last_password_count in keystone.conf ... if it is set to 3, I expect keystone keep the past 3 passwords in DB, is that right? | 13:58 |
aning | In my keystone, I set it to 2, but I saw 4 past passwords in "password" table, how come? | 14:00 |
lbragstad | aning keystone only stores the hashes - but let me see if i can recreate | 14:03 |
aning | lbragstad: well in my deployment the restriction to renew old passwords doesn't work | 14:05 |
aning | lbragstad: right Im aware that only passwords are stored, and they are hashed by bcrypt. | 14:06 |
aning | lbragstad: only password hash | 14:06 |
*** aojea has quit IRC | 14:07 | |
lbragstad | i just rotated passwords and I have my unique_last_password_count set to 2 | 14:12 |
*** mvkr has quit IRC | 14:12 | |
lbragstad | but i only see 3 password hashes in the password table | 14:13 |
lbragstad | if i continue changing my password to unique passwords, the oldest password hash is cleaned up from the database | 14:14 |
lbragstad | there is code in the sql driver to pull only the most recent hashes based on the configuration option | 14:16 |
lbragstad | https://git.openstack.org/cgit/openstack/keystone/tree/keystone/identity/backends/sql.py#n234 | 14:17 |
lbragstad | does that help answer your question aning? | 14:17 |
*** mchlumsky has joined #openstack-keystone | 14:18 | |
aning | lbragstad: if you set to 2, I think keystone only need to store 2. | 14:18 |
aning | lbragstad: actually we need to store only 1 | 14:18 |
lbragstad | is that due to a security requirement? | 14:20 |
*** jrist has quit IRC | 14:20 | |
aning | lbragstad: because if the count is 2, that means you can't reuse the past 1 previous password. | 14:20 |
lbragstad | if the count is two in the database? | 14:21 |
aning | lbragstad: no, it's not a security requirement, just wondering why we store more than enough. | 14:21 |
aning | no, is the unique_last_password_count is set to 2 | 14:21 |
*** dims has joined #openstack-keystone | 14:22 | |
*** knikolla has joined #openstack-keystone | 14:22 | |
lbragstad | if you set unique_last_password_count to 2 you should be able to use the password you just used | 14:22 |
aning | lbragstad: BTW we are on PIKE | 14:23 |
lbragstad | shouldn't* | 14:23 |
lbragstad | ok - good to know | 14:23 |
aning | lbragstad: right, but why we need to store 2 passwords then? | 14:23 |
lbragstad | because keystone needs to be able to verify the password your trying to use doesn't match the last two used | 14:24 |
aning | lbragstad: we only need to store the password I just used. | 14:24 |
aning | lbragstad: we are doing some bean counting here :) | 14:25 |
lbragstad | bean counting is always fun | 14:25 |
lbragstad | aning so what's your policy on passwords? you just want to make sure users can't use the password they just used? | 14:26 |
aning | lbragstad: right | 14:26 |
lbragstad | if i'm a user in your deployment, i should be able to change my password from `password` -> `new_pass` -> `password`? | 14:26 |
aning | I want the user NOT able to reuse the past 2 previous passwords, meaning the user shouldn't be able to do what you said. | 14:28 |
lbragstad | ok | 14:28 |
aning | My understanding is that I need to set unique_last_password_count = 3 | 14:28 |
aning | since unique_last_password_count actually include the one the user want to change to. | 14:29 |
lbragstad | so you want to be able to have users change passwords from `password1` -> `password2` -> `password3` -> `password1`? | 14:29 |
aning | Need to rush to a meeting and will be back in half hour. | 14:29 |
lbragstad | ok | 14:30 |
*** dave-mccowan has joined #openstack-keystone | 14:31 | |
lbragstad | aning for when you get back, i was able to set unique_last_password_count = 2 and achieved the outcome you wanted | 14:33 |
lbragstad | there are three records in the keystone.password table because it stores both old passwords and the current password | 14:33 |
lbragstad | if you're looking at the database, you can tell which one is the current one in use by the expires_at and expires_at_int columes | 14:34 |
lbragstad | those get set when a password is invalidated by a new password | 14:34 |
lbragstad | in my test i started with `password1`, changed it to `password2` and then to `password3` before I could change it back to `password1` | 14:35 |
*** dims has quit IRC | 14:43 | |
*** dims has joined #openstack-keystone | 14:48 | |
*** openstackgerrit has quit IRC | 14:58 | |
*** openstackgerrit has joined #openstack-keystone | 14:58 | |
*** aojea has joined #openstack-keystone | 14:59 | |
aning | lbragstad: Thanks for the experiment. I think there might be an issue in our deployment. | 15:02 |
aning | lbragstad: BTW, you are testing on the latest right? | 15:03 |
*** lbragstad has quit IRC | 15:04 | |
*** lbragstad has joined #openstack-keystone | 15:05 | |
*** ChanServ sets mode: +o lbragstad | 15:05 | |
*** gyee has joined #openstack-keystone | 15:08 | |
*** lbragstad has quit IRC | 15:18 | |
*** lbragstad has joined #openstack-keystone | 15:19 | |
*** ChanServ sets mode: +o lbragstad | 15:19 | |
*** openstackgerrit has quit IRC | 15:22 | |
*** mugsie has joined #openstack-keystone | 15:23 | |
*** mvkr has joined #openstack-keystone | 15:27 | |
kmalloc | o/ | 15:29 |
kmalloc | \o | 15:29 |
kmalloc | \o/ | 15:30 |
*** aojea has quit IRC | 15:31 | |
*** openstackgerrit has joined #openstack-keystone | 15:35 | |
openstackgerrit | guang-yee proposed openstack/keystone master: add unit tests for healthcheck https://review.openstack.org/609549 | 15:35 |
*** jrist has joined #openstack-keystone | 15:50 | |
*** dklyle has quit IRC | 15:53 | |
*** Emine has quit IRC | 15:55 | |
*** dklyle has joined #openstack-keystone | 15:58 | |
*** jrist has quit IRC | 15:59 | |
*** aojea has joined #openstack-keystone | 16:02 | |
*** mvkr has quit IRC | 16:16 | |
*** aojea has quit IRC | 16:34 | |
*** dmellado has quit IRC | 16:34 | |
*** dklyle has quit IRC | 17:04 | |
*** aojea has joined #openstack-keystone | 17:04 | |
*** mbuil has quit IRC | 17:13 | |
*** sayalilunkad has quit IRC | 17:15 | |
*** sayalilunkad has joined #openstack-keystone | 17:19 | |
*** etp has joined #openstack-keystone | 17:31 | |
*** dklyle has joined #openstack-keystone | 17:35 | |
*** aojea has quit IRC | 17:36 | |
*** andreykurilin has quit IRC | 17:50 | |
*** andreykurilin has joined #openstack-keystone | 17:51 | |
*** mvkr has joined #openstack-keystone | 18:00 | |
*** openstackgerrit has quit IRC | 18:20 | |
*** dmellado has joined #openstack-keystone | 18:27 | |
*** openstackstatus has quit IRC | 18:28 | |
*** openstackstatus has joined #openstack-keystone | 18:29 | |
*** ChanServ sets mode: +v openstackstatus | 18:29 | |
*** openstackgerrit has joined #openstack-keystone | 18:43 | |
openstackgerrit | Lance Bragstad proposed openstack/oslo.policy master: Add guidelines for naming policies https://review.openstack.org/606214 | 18:43 |
*** dave-mccowan has quit IRC | 18:54 | |
kmalloc | lbragstad: next flask patch i'm posting converts exception handling to flask native and removes the last non-authtoken middleware | 18:55 |
kmalloc | the final patch will be migrating authcontext to internal-load only (no stevedore) | 18:55 |
kmalloc | and then i'm whacking away at the old wsgi code so that we're free and clear of the legacy stuff (and closing the bug) | 18:55 |
kmalloc | i'll open a new bug specifically for authcontext to be ... smarter | 18:56 |
kmalloc | and less webob specific (or at least not need to be as heavily modified in tree) | 18:56 |
*** dave-mccowan has joined #openstack-keystone | 18:58 | |
*** dave-mccowan has quit IRC | 19:03 | |
*** dave-mccowan has joined #openstack-keystone | 19:04 | |
lbragstad | nice | 19:06 |
lbragstad | that sounds good | 19:06 |
kmalloc | lbragstad: https://bugs.launchpad.net/keystonemiddleware/+bug/1797446 | 19:08 |
openstack | Launchpad bug 1797446 in keystonemiddleware "Make AuthContextMiddleware more flask friendly" [Wishlist,Triaged] | 19:08 |
lbragstad | cool | 19:08 |
kmalloc | this is winding down nicely | 19:09 |
kmalloc | maybe another 3-5 more patches and flask is done. | 19:09 |
kmalloc | done(tm) | 19:09 |
*** aojea has joined #openstack-keystone | 19:12 | |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Register exceptions with a Flask Error Handler https://review.openstack.org/609796 | 19:39 |
*** aojea has quit IRC | 19:46 | |
kmalloc | lbragstad: ooh a bunch of our tests assume we have the URL Normalizing middleware in place | 20:17 |
kmalloc | (basically strip the trailing '/' or rewrite '' to '/' | 20:18 |
kmalloc | *facepalm* | 20:18 |
*** clarkb has joined #openstack-keystone | 20:19 | |
lbragstad | hmm | 20:20 |
lbragstad | we should have the opposite implemented, rigth? | 20:20 |
lbragstad | fwiw - i went through all the flask patches | 20:21 |
lbragstad | ooooo | 20:21 |
lbragstad | zuul.openstack.org got a facelift | 20:21 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Make Request Logging a little better https://review.openstack.org/609804 | 20:22 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Internally defined middleware don't use stevedore https://review.openstack.org/609805 | 20:22 |
*** aojea has joined #openstack-keystone | 20:39 | |
*** pcaruana has quit IRC | 20:40 | |
kmalloc | lbragstad: test_wsgi will go away shortly | 20:41 |
kmalloc | lbragstad: i need to finish the last couple patches here and we're set. | 20:41 |
lbragstad | sweet | 20:45 |
kmalloc | and i responded to your other comment. | 20:46 |
kmalloc | on the set unenforced ok | 20:46 |
kmalloc | i'm almost done with all the cleanup that will mean we just start whacking away at the code that is from webob-era | 20:46 |
kmalloc | and we'll be 100% flask (except AuthContextMW) | 20:46 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Internally defined middleware don't use stevedore https://review.openstack.org/609805 | 20:49 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert Normalizing filter to flask native Middleware https://review.openstack.org/609815 | 20:49 |
kmalloc | lbragstad: annnnnd here we go, last patch for flaskification before just massive cleanup | 20:55 |
kmalloc | lbragstad: phew... we are... there | 20:55 |
lbragstad | nice :) | 20:55 |
kmalloc | the cleanup patch will close the bug. | 20:56 |
kmalloc | my brain hurts from this still btw. | 20:56 |
kmalloc | it's been a brutal cleanup | 20:56 |
*** aojea has quit IRC | 21:09 | |
*** dave-mccowan has quit IRC | 21:28 | |
*** dave-mccowan has joined #openstack-keystone | 21:33 | |
kmalloc | lbragstad: ahhh the params stuff (openstack.params) was old webob legacy stuff | 21:37 |
kmalloc | lbragstad: no wonder it wasn't easy to dig up | 21:37 |
lbragstad | mmm | 21:37 |
kmalloc | basically it was how we passed param stuff from one api down to the next. largely not needed once the API stopped being "configurable" on what could be enabled / disabled | 21:37 |
kmalloc | so users could pass something down that could be acted on by say projects | 21:37 |
kmalloc | i think it's old old old old paste-ini related ick | 21:38 |
kmalloc | like not something we used past essex era | 21:38 |
kmalloc | but we carried forevere. | 21:38 |
*** johnsom has joined #openstack-keystone | 21:40 | |
johnsom | Is the keystone middleware audit code dead? | 21:47 |
johnsom | It appears to be mis-matching the services. | 21:50 |
lbragstad | johnsom have an example/ | 21:51 |
johnsom | lbragstad I'm always getting "keystone" as the target. It looks like this code: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/audit/_api.py#L270 is trying to match the service by the endpoint IP, which isn't going to work with the stacked endpoints. | 21:53 |
johnsom | https://www.irccloud.com/pastebin/nOfRd6xB/ | 21:53 |
kmalloc | johnsom: it might be very much out of date | 21:54 |
johnsom | lbragstad Mostly I didn't want to spend a bunch of time figuring out if I did something wrong for finding out if this is still a thing... A lot of the audit maps looked pretty out of date | 21:54 |
kmalloc | it seems to be mostly unmaintained. | 21:54 |
kmalloc | though i don't think that is because it isn't wanted | 21:55 |
kmalloc | just no one has stepped up to help keep it going (and add full end to end testing)( | 21:55 |
kmalloc | lbragstad: the big test. running unit tests with all the old code ripped out | 21:55 |
kmalloc | lbragstad: lets see if it works. feeling good so far. | 21:56 |
kmalloc | lbragstad: OMG, clean py27 test run, running py35 now. and one more bit of shuffle code and we're free and clear of flaskification | 21:59 |
*** aojea has joined #openstack-keystone | 22:01 | |
lbragstad | 0.0 | 22:01 |
lbragstad | it can't be that easy, can it? | 22:01 |
* lbragstad waits to get kicked by someone | 22:01 | |
kmalloc | lbragstad: dude, you're going to love this last patch | 22:05 |
kmalloc | ok... here we go, last code shuffle done... one more pass on unit tests... | 22:08 |
openstackgerrit | ayoung proposed openstack/keystone master: Re-enable REMOTE_USER tests https://review.openstack.org/609834 | 22:09 |
openstackgerrit | Merged openstack/keystone master: add unit tests for healthcheck https://review.openstack.org/609549 | 22:10 |
kmalloc | lbragstad: i.. i think this is going to pass.... | 22:11 |
kmalloc | lbragstad: also hah "that easy" | 22:11 |
* kmalloc eyes https://review.openstack.org/#/q/status:merged+project:openstack/keystone+branch:master+topic:bug/1776504 | 22:12 | |
kmalloc | erm | 22:12 |
johnsom | Yeah, ok, so it assumes unique IP:Ports for each endpoint. If I bypass that everything starts working as it should. | 22:12 |
kmalloc | that one: https://review.openstack.org/#/q/project:openstack/keystone+branch:master+topic:bug/1776504 | 22:15 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Move AuthContextMiddleware https://review.openstack.org/609836 | 22:19 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Flask comment/docstring cleanup https://review.openstack.org/609837 | 22:19 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Cleanup test_wsgi https://review.openstack.org/609838 | 22:19 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Remove pre-flask legacy code https://review.openstack.org/609839 | 22:19 |
*** openstackgerrit has quit IRC | 22:19 | |
*** openstackgerrit has joined #openstack-keystone | 22:19 | |
kmalloc | lbragstad: ^ 609839. Closes the flask bug. | 22:19 |
kmalloc | lbragstad: +213, -1642 | 22:20 |
kmalloc | hehehe | 22:20 |
johnsom | nice | 22:20 |
kmalloc | #success Keystone Flask Conversion Final Patch submitted to gerrit. | 22:21 |
openstackstatus | kmalloc: Added success to Success page (https://wiki.openstack.org/wiki/Successes) | 22:21 |
kmalloc | lbragstad: ~99 commits. | 22:22 |
kmalloc | lbragstad: this might take the record for volume of code change for a single "feature" / cleanup. | 22:22 |
*** rcernin has joined #openstack-keystone | 22:23 | |
kmalloc | lbragstad, cmurphy, gagehugo, hrybacki, ayoung, knikolla, wxy-xiyuan, rodrigods: https://review.openstack.org/#/c/609839/ final flask patch (in the stack) | 22:24 |
kmalloc | should be 100% ready for eyes up the outstanding patches. | 22:24 |
kmalloc | https://review.openstack.org/#/q/(topic:bug/1776504+OR+topic:flaskification)+(status:open+OR+status:merged) | 22:25 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Remove paste-ini https://review.openstack.org/609841 | 22:28 |
*** openstackstatus has quit IRC | 22:28 | |
*** openstackstatus has joined #openstack-keystone | 22:29 | |
*** ChanServ sets mode: +v openstackstatus | 22:29 | |
*** aojea has quit IRC | 22:33 | |
kmalloc | lbragstad: 93 commits, +14147 lines, -12999 lines | 22:49 |
*** spotz has quit IRC | 23:17 | |
*** mattoliverau has quit IRC | 23:18 | |
*** aojea has joined #openstack-keystone | 23:26 | |
*** spotz has joined #openstack-keystone | 23:55 | |
*** aojea has quit IRC | 23:57 | |
*** lbragstad has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!