*** aojea has quit IRC | 00:15 | |
*** blake has quit IRC | 00:30 | |
*** gyee has quit IRC | 00:33 | |
*** aojea has joined #openstack-keystone | 00:56 | |
*** aojea has quit IRC | 01:00 | |
*** aojea has joined #openstack-keystone | 01:08 | |
*** aojea has quit IRC | 01:13 | |
*** Nel1x has joined #openstack-keystone | 01:16 | |
openstackgerrit | zhongshengping proposed openstack/oslo.limit master: Update mailinglist from dev to discuss https://review.openstack.org/621795 | 01:39 |
---|---|---|
*** erus has quit IRC | 01:43 | |
*** erus has joined #openstack-keystone | 01:44 | |
*** aojea has joined #openstack-keystone | 01:56 | |
*** dklyle has quit IRC | 02:12 | |
*** dklyle has joined #openstack-keystone | 02:13 | |
*** Dinesh_Bhor has joined #openstack-keystone | 02:13 | |
*** aojea has quit IRC | 02:19 | |
*** Dinesh_Bhor has quit IRC | 02:39 | |
*** Dinesh_Bhor has joined #openstack-keystone | 02:48 | |
*** imacdonn has quit IRC | 02:52 | |
*** imacdonn has joined #openstack-keystone | 02:53 | |
*** aojea has joined #openstack-keystone | 03:11 | |
*** Nel1x has quit IRC | 03:16 | |
*** nehaalhat has quit IRC | 03:32 | |
openstackgerrit | Vieri proposed openstack/keystonemiddleware master: Change openstack-dev to openstack-discuss https://review.openstack.org/622764 | 03:37 |
*** aojea has quit IRC | 03:37 | |
openstackgerrit | Vieri proposed openstack/keystoneauth master: Change openstack-dev to openstack-discuss https://review.openstack.org/622765 | 03:38 |
openstackgerrit | Vieri proposed openstack/keystone-tempest-plugin master: Change openstack-dev to openstack-discuss https://review.openstack.org/622766 | 03:39 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Add domain level limit support - Manager https://review.openstack.org/621468 | 03:50 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: [WIP]Add domain level limit support - API https://review.openstack.org/622773 | 03:50 |
*** Dinesh_Bhor has quit IRC | 03:56 | |
openstackgerrit | Merged openstack/keystone-specs master: Change openstack-dev to openstack-discuss https://review.openstack.org/621893 | 04:02 |
*** itlinux has joined #openstack-keystone | 04:12 | |
*** mordred has quit IRC | 04:57 | |
*** mordred has joined #openstack-keystone | 04:57 | |
*** Dinesh_Bhor has joined #openstack-keystone | 05:02 | |
*** aojea has joined #openstack-keystone | 05:22 | |
*** aojea has quit IRC | 05:27 | |
*** dmellado has quit IRC | 05:46 | |
*** dmellado has joined #openstack-keystone | 05:48 | |
cosss_ | Thanks @kmalloc will take a look into the code. | 05:48 |
cosss_ | I think this could be it: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/discover.py | 05:51 |
*** dmellado has quit IRC | 05:55 | |
*** dmellado has joined #openstack-keystone | 05:57 | |
*** dmellado has quit IRC | 06:02 | |
*** dmellado has joined #openstack-keystone | 06:14 | |
*** nehaalhat has joined #openstack-keystone | 06:18 | |
kmalloc | cosss_: it works for a lot of bits | 06:27 |
*** Dinesh_Bhor has quit IRC | 06:57 | |
*** pcaruana has joined #openstack-keystone | 07:10 | |
*** Dinesh_Bhor has joined #openstack-keystone | 07:16 | |
*** takamatsu has joined #openstack-keystone | 07:21 | |
*** amoralej|off is now known as amoralej | 08:14 | |
*** awalende has joined #openstack-keystone | 08:20 | |
*** awalende_ has joined #openstack-keystone | 08:33 | |
*** awalende has quit IRC | 08:35 | |
*** jmlowe has quit IRC | 08:35 | |
*** aojea_ has joined #openstack-keystone | 09:03 | |
*** aojea_ has quit IRC | 09:07 | |
*** xek has joined #openstack-keystone | 09:21 | |
*** Dinesh_Bhor has quit IRC | 09:25 | |
openstackgerrit | wangxiyuan proposed openstack/keystone master: [WIP]Add domain level limit support - API https://review.openstack.org/622773 | 09:26 |
*** trident has quit IRC | 09:29 | |
*** Dinesh_Bhor has joined #openstack-keystone | 09:30 | |
*** trident has joined #openstack-keystone | 09:31 | |
*** rcernin has quit IRC | 09:38 | |
openstackgerrit | wangqiang-bj proposed openstack/python-keystoneclient master: fix typos https://review.openstack.org/622908 | 09:43 |
*** Dinesh_Bhor has quit IRC | 10:31 | |
*** shrasool has joined #openstack-keystone | 10:48 | |
*** Dinesh_Bhor has joined #openstack-keystone | 10:54 | |
*** Dinesh_Bhor has quit IRC | 10:59 | |
*** xek has quit IRC | 11:12 | |
*** xek has joined #openstack-keystone | 11:26 | |
*** xek has quit IRC | 11:38 | |
*** sayalilunkad has quit IRC | 12:11 | |
*** sayalilunkad has joined #openstack-keystone | 12:37 | |
*** raildo has joined #openstack-keystone | 12:42 | |
*** shrasool has quit IRC | 12:47 | |
*** jdennis has quit IRC | 13:20 | |
*** amoralej is now known as amoralej|lunch | 13:23 | |
*** raildo has quit IRC | 13:24 | |
*** raildo has joined #openstack-keystone | 13:24 | |
nehaalhat | Hi, Ia any one aware about how to run tempest test cases for python-keystoneclient | 13:28 |
nehaalhat | Is* | 13:28 |
*** aojea has joined #openstack-keystone | 13:45 | |
*** raildo has quit IRC | 13:54 | |
*** raildo has joined #openstack-keystone | 13:55 | |
cmurphy | nehaalhat: keystoneclient doesn't have tempest tests since it's not a service, do you want to run the functional tests? | 13:57 |
*** raildo has quit IRC | 14:00 | |
*** amoralej|lunch is now known as amoralej | 14:04 | |
*** bzhao__ has quit IRC | 14:18 | |
openstackgerrit | Colleen Murphy proposed openstack/ldappool master: Fix releasenotes build https://review.openstack.org/622977 | 14:34 |
*** jdennis has joined #openstack-keystone | 14:53 | |
knikolla | o/ | 15:05 |
lbragstad | o/ | 15:06 |
gagehugo | o/ | 15:06 |
cmurphy | ~o~ | 15:06 |
cmurphy | erus: from our discussion yesterday I went and distilled the first few tasks into a list of goals and minitasks in this etherpad, easier than trying to use trello i think https://etherpad.openstack.org/p/outreachy-keystone-federation-tasks let me know if that is helpful (cc kmalloc and knikolla ) | 15:09 |
cmurphy | imus: i went ahead and did the same for you https://etherpad.openstack.org/p/outreachy-keystone-api-unit-tests-tasks | 15:09 |
erus | Hi cmurphy how are you? I created the account in trello, it's erus :) I will check the etherpad thanks | 15:12 |
lbragstad | erus is your trello id @erus8? | 15:13 |
erus | Sip sorry | 15:13 |
erus | I was changing it | 15:13 |
erus | Erus is already taken | 15:14 |
lbragstad | oh - that's fine, i was just searching for you so i could add you to the keystone team | 15:14 |
lbragstad | (in trello) | 15:14 |
imus | hi cmurphy. Ok sounds good I will take a look | 15:15 |
*** jdennis has quit IRC | 15:15 | |
*** kklimonda has joined #openstack-keystone | 15:15 | |
erus | I changed it to erudyn instead of erus8 | 15:17 |
erus | :) | 15:17 |
lbragstad | sweet | 15:18 |
lbragstad | invite is on the way | 15:18 |
cmurphy | thanks lbragstad | 15:19 |
lbragstad | yup - does imus have an account? | 15:19 |
kklimonda | is there a way to refresh token without user credentials? | 15:20 |
cmurphy | lbragstad: i added imus already | 15:20 |
lbragstad | oh - perfect | 15:20 |
erus | Thanks o/ | 15:22 |
*** shrasool has joined #openstack-keystone | 15:22 | |
*** itlinux has quit IRC | 15:22 | |
cmurphy | kklimonda: you can use token auth to get a new token using your current token https://developer.openstack.org/api-ref/identity/v3/index.html?expanded=token-authentication-with-scoped-authorization-detail#authentication-and-token-management but if you're using something like keystoneauth that should all be taken care of under the hood | 15:27 |
kklimonda | cmurphy: but the new token has the same expiration date from little testing I've done | 15:28 |
kklimonda | so the new token isn't really of much use, the only use case I see for that is generating tokens with a tighter scope | 15:29 |
*** jdennis has joined #openstack-keystone | 15:32 | |
*** raildo has joined #openstack-keystone | 15:33 | |
cmurphy | kklimonda: hmm you're right, i didn't expect that | 15:34 |
*** awalende_ has quit IRC | 15:35 | |
erus | I was reading the etherpad thanks it's very detailed :) | 15:35 |
erus | Why do I need to use the vnc to log into the vm? | 15:43 |
cmurphy | erus: horizon has a vnc console built into it | 15:43 |
cmurphy | it's just a useful way to get into the vm in case networking isn't working | 15:44 |
erus | And what's the main difference of using vnc instead of ssh? | 15:54 |
cmurphy | erus: vnc is graphical, ssh is text-only | 16:02 |
erus | I see, I thought there was another difference thanks. | 16:05 |
*** awalende has joined #openstack-keystone | 16:08 | |
*** jmlowe has joined #openstack-keystone | 16:12 | |
*** awalende has quit IRC | 16:12 | |
*** aojea has quit IRC | 16:14 | |
*** pcaruana has quit IRC | 16:18 | |
*** aojea has joined #openstack-keystone | 16:19 | |
*** aojea has quit IRC | 16:20 | |
*** raildo has quit IRC | 16:24 | |
*** aojea has joined #openstack-keystone | 16:25 | |
*** jdennis has quit IRC | 16:26 | |
*** aojea has quit IRC | 16:30 | |
*** gyee has joined #openstack-keystone | 16:34 | |
*** itlinux has joined #openstack-keystone | 16:37 | |
*** aojea has joined #openstack-keystone | 16:37 | |
*** raildo has joined #openstack-keystone | 16:38 | |
*** jdennis has joined #openstack-keystone | 16:44 | |
*** awalende has joined #openstack-keystone | 16:55 | |
*** awalende has quit IRC | 16:56 | |
*** erus has quit IRC | 16:56 | |
*** jdennis has quit IRC | 16:57 | |
*** erus has joined #openstack-keystone | 16:59 | |
*** jdennis has joined #openstack-keystone | 17:23 | |
*** shrasool has quit IRC | 17:27 | |
lbragstad | jdennis https://review.openstack.org/#/c/622618/ | 17:39 |
lbragstad | ^ that should include the patch you wrote for logging RBAC enforcement data | 17:39 |
*** shrasool has joined #openstack-keystone | 17:40 | |
lbragstad | does anyone happen to know the author of https://review.openstack.org/#/c/615354/ or their IRC nic? | 17:41 |
lbragstad | just out of curiosity | 17:41 |
*** zioproto has quit IRC | 17:51 | |
*** zioproto has joined #openstack-keystone | 17:52 | |
*** aojea has quit IRC | 17:53 | |
*** aojea has joined #openstack-keystone | 17:53 | |
*** aojea has quit IRC | 17:59 | |
*** dnguyen has joined #openstack-keystone | 18:00 | |
*** shrasool_ has joined #openstack-keystone | 18:03 | |
*** shrasool has quit IRC | 18:04 | |
*** shrasool_ is now known as shrasool | 18:04 | |
*** dave-mccowan has joined #openstack-keystone | 18:09 | |
*** shrasool has quit IRC | 18:13 | |
kmalloc | i don't lbragstad | 18:13 |
lbragstad | ack | 18:16 |
kmalloc | hmm. | 18:31 |
kmalloc | interesting. | 18:31 |
kmalloc | lbragstad: doh, i need to move my desk.... | 18:31 |
kmalloc | like 2 feet over. | 18:31 |
kmalloc | ... the desk weighs like 300lbs w/ nothing on it :P | 18:31 |
lbragstad | call in some reinforcements... | 18:34 |
*** aojea has joined #openstack-keystone | 18:35 | |
*** amoralej is now known as amoralej|off | 18:58 | |
*** aojea has quit IRC | 19:07 | |
kmalloc | lbragstad: so... when are you going to be in seattle to help? :P | 19:13 |
kmalloc | blah. hopefully the nouveau driver in 4.17? is less crashy than the one in 4.15 | 19:13 |
* kmalloc does do-dist-upgrade and holds on | 19:14 | |
gagehugo | kmalloc: it's buggy af | 19:14 |
kmalloc | if this doesn't work... time to download fedora and maybe it will be slightly better | 19:14 |
kmalloc | gagehugo: i can't get past the login screen now | 19:14 |
gagehugo | yeah | 19:14 |
kmalloc | gagehugo: nouveau crashes and the machine needs a hard-reset to continue working | 19:14 |
kmalloc | as in... reset button or sysrq. can't issue reboot/shutdown | 19:15 |
gagehugo | I had to add nouveau.modeset=0 in grub | 19:15 |
gagehugo | and then install nvidia's drivers | 19:15 |
kmalloc | gagehugo: hmm what does that do? i would like to use the real nvidia driver... but i it's a real pita to install. | 19:15 |
kmalloc | oh | 19:15 |
kmalloc | that. | 19:15 |
lbragstad | man - tough week for the home team | 19:15 |
kmalloc | yeah i would rather not. | 19:16 |
gagehugo | https://www.if-not-true-then-false.com/2015/fedora-nvidia-guide/ | 19:16 |
kmalloc | the real nvidia driver is kindof awful to deal with in linux | 19:16 |
gagehugo | ^ fedora anyway | 19:16 |
kmalloc | especially with secure boot | 19:16 |
gagehugo | it works though :p | 19:16 |
gagehugo | but yes | 19:16 |
kmalloc | i really didn't want to run fedora on this machine | 19:16 |
kmalloc | maybe 4.17/4.18 will be less crashy | 19:17 |
gagehugo | I used the same process for ubuntu | 19:17 |
kmalloc | and this isn't even on a new GPU... it's just a 1080 series | 19:17 |
kmalloc | a 2+ year old GPU should not be this crashy. | 19:17 |
kmalloc | i loathe to think what a 2080 would be like. | 19:17 |
gagehugo | heh | 19:18 |
gagehugo | but yeah I fought nouvaeu last week | 19:20 |
lbragstad | gagehugo you're running fedora? | 19:22 |
gagehugo | lbragstad: yeah 29, switched over from ubuntu 18.04 | 19:22 |
* lbragstad nods | 19:22 | |
lbragstad | kmalloc you're still on 18.04? | 19:22 |
gagehugo | which I went to 18.04 when I had issues with 28 graphics | 19:22 |
kmalloc | lbragstad: workstation/virt target | 19:23 |
kmalloc | lbragstad: i tend to roll that and home servers slower than laptop | 19:23 |
kmalloc | lbragstad: specifically because i don't want a "new bleeding edge thing" to break the workflow. | 19:24 |
lbragstad | hm | 19:24 |
lbragstad | so this is on your x1c? | 19:24 |
kmalloc | no | 19:24 |
kmalloc | on the threadripper | 19:24 |
lbragstad | oh | 19:24 |
lbragstad | nvm | 19:24 |
gagehugo | 18.04 was pretty stable imo with the nvidia drivers | 19:24 |
kmalloc | the x1c is 18.10 | 19:24 |
lbragstad | ahh | 19:24 |
kmalloc | gagehugo: i plugged 2 monitors in and can never login again, even clearing configs, etc. the module just crashes | 19:24 |
lbragstad | kmalloc you have a 6th gen or a 5th gen? | 19:24 |
kmalloc | gagehugo: even with updates. | 19:25 |
kmalloc | lbragstad: x1c6 | 19:25 |
kmalloc | gagehugo: and reinstall(s). | 19:25 |
kmalloc | gagehugo: it might be the GPU, but i doubt it, the GPU was just fine until the second monitor was plugged in, and the monitors were confirmed working prior to that. | 19:25 |
kmalloc | lbragstad: with the 1080p screen and like 256GB storage. it's the issued laptop i got from red hat. | 19:26 |
lbragstad | ahh | 19:26 |
kmalloc | its the one i had at the summit. its not bad. | 19:26 |
lbragstad | the x1c6 you mean? | 19:26 |
kmalloc | 18.10 made it much much more usable | 19:26 |
kmalloc | yeah | 19:26 |
lbragstad | interesting... | 19:26 |
kmalloc | the x1c6 | 19:26 |
lbragstad | mine died this week | 19:26 |
kmalloc | there is one oddity, you need to disable "wake from sleep when lid opens" | 19:27 |
kmalloc | otherwise it burns like 2W of power when sleeping | 19:27 |
kmalloc | so when you open the lid, you have to press the power button to wake it | 19:27 |
lbragstad | yeah - i've heard of that one in some other reports | 19:27 |
kmalloc | it's not terrible | 19:27 |
kmalloc | otherwise the laptop is solid. | 19:27 |
kmalloc | it's my only complaint | 19:27 |
kmalloc | though if i was buying myself a computer, i'd be comparing x1c6 vs x1extreme | 19:28 |
kmalloc | depending on use-cases | 19:28 |
*** shrasool has joined #openstack-keystone | 19:28 | |
gagehugo | I like my t480s | 19:28 |
gagehugo | the x1extreme looks cool | 19:29 |
lbragstad | i'm hesitant about another x1 at this point | 19:29 |
kmalloc | as long as i get the next business-day-on-site warranty (3yrs) i don't view then x1 as a liability | 19:30 |
kmalloc | i don't like the xps13 | 19:30 |
lbragstad | i have to dig into it over the weekend, but it sounds like the x1c5 had a bunch of people had to have motherboards replaced due to design issues | 19:30 |
gagehugo | I assume they will announce the new thinkpads next month-ish? | 19:30 |
kmalloc | https://www.irccloud.com/pastebin/hhPtI5IF/ | 19:31 |
kmalloc | well then. | 19:31 |
kmalloc | I guess it is time to re-install... and possibly try the actual nvidia drivers. | 19:32 |
lbragstad | have fun | 19:32 |
kmalloc | this is stupid annoying. | 19:32 |
gagehugo | kmalloc: yup :( | 19:32 |
*** shrasool has quit IRC | 19:33 | |
*** shrasool has joined #openstack-keystone | 19:34 | |
kmalloc | gagehugo: that was similar to what you were seing, eys? | 19:34 |
gagehugo | kmalloc: yup, it would hard lock sometime around the login screen | 19:34 |
kmalloc | oh interesting... so now it works. i guess 2 monitors is too much for the nouveau driver *eyeroll* | 19:35 |
gagehugo | lbragstad: I got arch booting on my tiny second ssd, but that's as far as I got | 19:35 |
gagehugo | kmalloc: lol | 19:36 |
lbragstad | kmalloc rbac enforcer question for you | 19:40 |
lbragstad | here - https://review.openstack.org/#/c/605851/5/keystone/api/domains.py@80 | 19:41 |
lbragstad | i can do that in the actual enforcer, can't i? | 19:41 |
lbragstad | because i think it's tripping on a programming error | 19:41 |
lbragstad | becuase it' | 19:42 |
lbragstad | because tempest is calling GET /v3/domains/Default | 19:42 |
lbragstad | http://logs.openstack.org/51/605851/5/check/tempest-full/5249460/controller/logs/screen-keystone.txt.gz#_Nov_28_18_18_21_512883 | 19:42 |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Only run pep8 job when changing python files https://review.openstack.org/623057 | 19:43 |
kmalloc | hm | 19:45 |
kmalloc | you can do it with the build_target function | 19:45 |
kmalloc | same as we did other places | 19:45 |
kmalloc | and you can just let it 404 directly, should raise up the appropriate 403 that way | 19:46 |
kmalloc | the RBACEnforcer is pretty safe when it deals with the build_target function passed to it | 19:46 |
*** aojea has joined #openstack-keystone | 19:52 | |
kmalloc | well... more likely | 19:56 |
kmalloc | oh yeah | 19:56 |
kmalloc | it's not found the domain because we're erroring before enforcement is done | 19:56 |
kmalloc | that is expected "fail safe" behavior | 19:56 |
*** jaosorior has joined #openstack-keystone | 20:03 | |
lbragstad | ok - i built a new enforcement method | 20:10 |
lbragstad | but yeah - i see what you mean | 20:10 |
lbragstad | i think i got it working | 20:10 |
*** shrasool has quit IRC | 20:10 | |
lbragstad | new build_enforcement_target method* | 20:10 |
*** shrasool has joined #openstack-keystone | 20:27 | |
kmalloc | yep | 20:51 |
kmalloc | basically that sanity check always ensures we don't have 1) unenforced apis (except where explicitly designated) and 2) don't leak information unless explicitly intended | 20:52 |
*** dnguyen has quit IRC | 21:02 | |
*** dnguyen has joined #openstack-keystone | 21:03 | |
*** shrasool has quit IRC | 21:22 | |
lbragstad | jdennis kmalloc i think we have a regression in the new oslo.policy version? | 21:46 |
kmalloc | do we? | 21:46 |
lbragstad | https://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/test_v3_identity.py#n650 fails when we use oslo.policy 1.43.0 | 21:47 |
kmalloc | hah | 21:47 |
kmalloc | no we don't have a regression | 21:47 |
kmalloc | oslo.policy is explicitly logging all details now. | 21:47 |
lbragstad | about the target | 21:47 |
lbragstad | and since users have password entries... | 21:47 |
kmalloc | we place all values from the params into the target dict | 21:48 |
kmalloc | oslo.policy now logs the target dict, possibly w/o masking | 21:48 |
lbragstad | yeah | 21:48 |
kmalloc | so it's not really a regression | 21:48 |
kmalloc | it's oslo.policy has added a new feature, and our test assumed oslo.policy doesn't log | 21:49 |
kmalloc | it might show masking is not working 100%. | 21:49 |
lbragstad | what i meant was a regression in behavior based on the tests | 21:49 |
lbragstad | which is just checking if a string of output contains a specific subset | 21:50 |
kmalloc | ah we just need to mask the target dict | 21:50 |
kmalloc | *shrug* | 21:50 |
kmalloc | we only mask creds | 21:50 |
lbragstad | so - this seems like a one off case | 21:51 |
kmalloc | https://github.com/openstack/oslo.policy/commit/f1505dd4071d9b73c21be683db4c9911ea8f8058#diff-dfed0f2e6c2b5b9444b6b05744f0698bR855 | 21:51 |
lbragstad | that's only really applicable to keystone? | 21:51 |
kmalloc | we're the only one who tests for things like "secrets aren't logged" | 21:51 |
kmalloc | explicitly | 21:51 |
lbragstad | test out put https://pasted.tech/pastes/345b45821968a779d52d8f73dcd9fe639e945efb.raw | 21:52 |
kmalloc | if we just add a mask line for the target dict before logging, we're good | 21:52 |
lbragstad | in oslo.policy? | 21:52 |
lbragstad | or in keystone? | 21:53 |
kmalloc | in oslo.policy | 21:53 |
kmalloc | see the link ^ github | 21:53 |
kmalloc | that was jdennis' patch | 21:53 |
lbragstad | yeah - i saw | 21:53 |
kmalloc | and it misses masking the target dict | 21:53 |
kmalloc | also... we might be mangling the creds dict now that i look at it | 21:53 |
kmalloc | not that password should *ever* be in the dicts.... | 21:53 |
kmalloc | but it happens. | 21:54 |
kmalloc | i can roll up a patch shortly to fix this. | 21:54 |
kmalloc | i have a phone call i need to hop on, and then need to go pick up car. but i should have a full fix posted by tomorrow. | 21:54 |
kmalloc | and we can do a ban of the current (latest) release and issue a bug fix release that covers our bases. | 21:55 |
openstackgerrit | Lance Bragstad proposed openstack/oslo.policy master: Prevent sensitive target data from being logged https://review.openstack.org/623081 | 21:59 |
lbragstad | ^ fix is up, probably needs a bug report though | 21:59 |
lbragstad | and we'll have to release oslo.policy again | 22:00 |
*** rcernin has joined #openstack-keystone | 22:03 | |
openstackgerrit | Lance Bragstad proposed openstack/oslo.policy master: Prevent sensitive target data from being logged https://review.openstack.org/623081 | 22:06 |
*** prometheanfire has joined #openstack-keystone | 22:09 | |
prometheanfire | new olso.policy breaking tests for keystone http://logs.openstack.org/20/622820/1/check/cross-keystone-py27/b10706b/testr_results.html.gz | 22:09 |
prometheanfire | https://review.openstack.org/622820 | 22:09 |
lbragstad | prometheanfire fixed https://review.openstack.org/623081 | 22:09 |
prometheanfire | :D | 22:10 |
prometheanfire | should that policy version be masked? | 22:10 |
lbragstad | for keystone, yes | 22:10 |
lbragstad | it's because we pass a user reference into policy enforcement | 22:10 |
lbragstad | and the user reference can contain sensitive information | 22:11 |
lbragstad | (password for example) | 22:11 |
prometheanfire | ok, I'm open to an argument being made to reject it globally, if it's known to be very bad | 22:11 |
lbragstad | i can't think of another service that would be affected | 22:11 |
prometheanfire | k | 22:12 |
lbragstad | but - don't quote me on that | 22:12 |
prometheanfire | lbragstad: mind comenting so we can abandon that review? | 22:13 |
lbragstad | prometheanfire done | 22:14 |
prometheanfire | ty | 22:15 |
lbragstad | no problem | 22:15 |
lbragstad | kmalloc i updated https://review.openstack.org/#/c/623081/2 to be more consistent the convention jdennis had in his patch | 22:16 |
kmalloc | k | 22:17 |
kmalloc | lbragstad: i think we have another bug | 22:18 |
lbragstad | ? | 22:18 |
kmalloc | sec. | 22:18 |
kmalloc | wrapping up phone call | 22:18 |
kmalloc | but we need a copy/deepcopy of the creds/target dict | 22:19 |
kmalloc | for masking | 22:19 |
kmalloc | we are breaking data in the cred/target dict passed down to policy enforcer | 22:19 |
kmalloc | because masker changes the data | 22:19 |
kmalloc | i think | 22:20 |
kmalloc | i need to check more closely on how we usetarget_dict / creds_dict | 22:20 |
kmalloc | nvm | 22:21 |
kmalloc | i am wrong | 22:21 |
kmalloc | we're good | 22:21 |
openstackgerrit | Lance Bragstad proposed openstack/oslo.policy master: Prevent sensitive target data from being logged https://review.openstack.org/623081 | 22:23 |
lbragstad | i deepcopied anyway | 22:23 |
kmalloc | we only use creds_dict and target_dict explicitly in the logging | 22:23 |
kmalloc | we explictly cast to dict() via the dict() constructor to handle the mutablemapping case | 22:24 |
lbragstad | true | 22:24 |
kmalloc | but we sitll pass mutablemapping down to the enforcer if needed. | 22:24 |
lbragstad | correct | 22:24 |
kmalloc | so we're good, we should comment that creds_dict and target_dict should NEVER be used outside of the logging | 22:24 |
kmalloc | otherwise that deepcopy isn't needed | 22:24 |
kmalloc | ... or.. wait | 22:24 |
kmalloc | lets leave the deepcopy | 22:24 |
kmalloc | it saves the potential referential key change in the non-mutablemapping form | 22:25 |
kmalloc | it slower(tm) but probably just safer | 22:25 |
lbragstad | yeah - ok | 22:25 |
lbragstad | in that case - it's ready for review | 22:25 |
kmalloc | cool. | 22:26 |
kmalloc | thnx | 22:26 |
kmalloc | let me look | 22:26 |
kmalloc | should be a quick +2 | 22:26 |
kmalloc | lbragstad: done. +2 | 22:27 |
kmalloc | lgtm | 22:27 |
lbragstad | sweet - thanks | 22:27 |
kmalloc | if it passes zuul i'll happily +A as a quick "get it fixed" land | 22:27 |
lbragstad | bnemec reviewed the first iteration, too | 22:27 |
lbragstad | so i assume he'll be ok to revisit it as well | 22:27 |
kmalloc | ++ | 22:28 |
kmalloc | ok need to run to get car | 22:29 |
kmalloc | only 6 weeks since rear end to get it fixed :P | 22:29 |
bnemec | Yeah, I'm good with it. | 22:30 |
bnemec | I was kind of waiting to see what the final version would be. :-) | 22:30 |
*** mchlumsky has quit IRC | 22:30 | |
lbragstad | good call bnemec | 22:30 |
kmalloc | bnemec: ++ | 22:33 |
*** dave-mccowan has quit IRC | 22:35 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement system reader role in domains API https://review.openstack.org/605485 | 22:37 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement system member role domain test coverage https://review.openstack.org/605849 | 22:37 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement system admin role in domains API https://review.openstack.org/605850 | 22:37 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Allow domain users to access the GET domain API https://review.openstack.org/605851 | 22:37 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Allow project users to retrieve domains https://review.openstack.org/605871 | 22:37 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove domain policies from policy.v3cloudsample.json https://review.openstack.org/605876 | 22:37 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove domain policies from policy.v3cloudsample.json https://review.openstack.org/605876 | 22:40 |
*** itlinux has quit IRC | 22:40 | |
*** rcernin has quit IRC | 22:52 | |
*** rcernin has joined #openstack-keystone | 22:52 | |
*** aojea has quit IRC | 22:53 | |
*** aojea has joined #openstack-keystone | 22:54 | |
*** aojea has quit IRC | 22:58 | |
*** dnguyen has quit IRC | 22:59 | |
*** dnguyen has joined #openstack-keystone | 23:02 | |
*** prometheanfire has left #openstack-keystone | 23:17 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!