| *** markvoelker has joined #openstack-keystone | 00:34 | |
| *** markvoelker has quit IRC | 00:39 | |
| *** markvoelker has joined #openstack-keystone | 01:05 | |
| *** whoami-rajat has joined #openstack-keystone | 01:17 | |
| *** jamesmcarthur has joined #openstack-keystone | 01:28 | |
| *** markvoelker has quit IRC | 01:32 | |
| *** markvoelker has joined #openstack-keystone | 01:34 | |
| *** jamesmcarthur has quit IRC | 01:49 | |
| *** lbragstad has quit IRC | 02:09 | |
| adriant | cmurphy, kmalloc: Would there be any major pushback if I (in the future once I'm actually done with MFA shit) write up a spec for user owned key/value metadata? Essentially, I, a user in Keystone, can set and edit my own metadata. I want this specifically for settings. Like "favourite projects" or "items_per_page" etc. Because there are a ton of us | 02:13 |
|---|---|---|
| adriant | ability and UX things that need some user setting store that OpenStack doesn't have. | 02:13 |
| adriant | favourite_projects (a comma separated id list), actually being a big usability that Horizon could have to tailor the project dropdown select in cases where a user has 30+ projects. | 02:14 |
| adriant | The only sane place such a store could live is in keystone sadly, and it has to be an API the user themselves can edit. | 02:14 |
| adriant | The current plan I have is to do a lot of this in cookies, but that's not really a good solution, and it's possible other services or tools could use this if it existed. | 02:16 |
| adriant | We could potentially do this with user_options, but then we'd had to add to keystone each option that we'd want to use elsewhere, while a generic k/v store would be flexible to play with without needing to involve keystone code every time. | 02:18 |
| adriant | And we'd need to open user options to themselves in some fashion (so their token/horizon can set/edit them). | 02:19 |
| adriant | Just a thought from some UX related discussions I had today with colleagues, thought I'd pick your brains :) | 02:20 |
| *** lbragstad has joined #openstack-keystone | 02:25 | |
| *** ChanServ sets mode: +o lbragstad | 02:25 | |
| kmalloc | adriant: random user supplied/no validation? or something like resource-options but allow users to set them? | 02:48 |
| kmalloc | adriant: we have historically pushed back on keystone storing the user's options on the user object. | 02:49 |
| kmalloc | adriant: and commented it should be something owned by horizon, but i get that isn't the architecture of openstack. | 02:49 |
| adriant | there sadly isn't a better place to store them :( | 02:50 |
| kmalloc | i am *very* against unbounded key-value-store | 02:50 |
| adriant | Horizon is by design ephemeral | 02:50 |
| kmalloc | i would rather have an easy-to-approve set of options under user_options | 02:50 |
| kmalloc | that way it's not add because maybe we might use it in the future or something... so why not just add them | 02:50 |
| adriant | if the process for adding new 'user managed' user option is easy, documented etc, then I can live with that | 02:51 |
| kmalloc | you will need to add policy enhancements/workflows to allow for some options to be user-controlled vs admin controlled | 02:51 |
| kmalloc | e.g. PCI-DSS "no password expiry" should not be user controlled | 02:51 |
| kmalloc | i am not against this. | 02:51 |
| adriant | can we make this something a little different like user-settings rather than options? so we can policy wise separate it? | 02:52 |
| kmalloc | *shrug* sure. | 02:52 |
| kmalloc | however... | 02:52 |
| adriant | then anything that is a 'setting' is always user controlled | 02:52 |
| kmalloc | i would recommend making it an option-by-option choice | 02:52 |
| adriant | or some shit | 02:52 |
| kmalloc | and just use user-options | 02:52 |
| adriant | that works | 02:52 |
| kmalloc | no migrations needed, etc | 02:52 |
| adriant | I can work with that | 02:53 |
| kmalloc | we can add policy entry (default) per option and a default | 02:53 |
| kmalloc | allow it to be overridden | 02:53 |
| kmalloc | so you could allow a user to set MFA options for example | 02:53 |
| adriant | yep, that would be great | 02:53 |
| kmalloc | :) | 02:53 |
| adriant | because some clouds would just outright expose that, while others might eventually use Adjutant for safer workflows around that setup | 02:54 |
| kmalloc | maybe this was part of the original "future" design goals of the reasource options | 02:54 |
| kmalloc | we will need to communicate with a GET maybe what options a user is allowed to set in their current context. | 02:54 |
| kmalloc | but that should not be terrible | 02:55 |
| kmalloc | and this means we gate that options are actually used/justified not just "oh cause we can have any we want just add one for now maybe we'll use it in the future" | 02:55 |
| kmalloc | it saves potential ick in the DB | 02:55 |
| adriant | What I can then one day do is implement the existing Horizon option in keystone (once the admin/user policy stuff exists), and horizon can even read the cookies and set the values from them automatically if the cookie existed. | 02:55 |
| kmalloc | thats far beyond anything i'm getting involved with ;) | 02:56 |
| kmalloc | but sure. | 02:56 |
| adriant | so to a user the transition once keystone supports them is invisible | 02:56 |
| adriant | and means I can potentially implement some stuff like fav projects now, using cookies, and migrate to using keystone later maybe | 02:57 |
| adriant | hmmm | 02:57 |
| *** markvoelker has quit IRC | 02:57 | |
| * adriant plots things | 02:57 | |
| adriant | kmalloc: and nah, that's not your problem. I just would like some nice way to handle this stuff, and horizon can easily check: "if keystone version above X, do thing" | 02:59 |
| adriant | not exactly micro versions, but Keystone's base API does return the version, and that's easy to check by | 03:00 |
| *** vishakha has joined #openstack-keystone | 04:14 | |
| openstackgerrit | Rabi Mishra proposed openstack/keystoneauth master: Set Content-Type header explictly for LegacyJsonAdapter https://review.openstack.org/643505 | 04:21 |
| *** dave-mccowan has quit IRC | 04:30 | |
| *** lbragstad has quit IRC | 04:31 | |
| *** sapd1 has joined #openstack-keystone | 05:04 | |
| *** rcernin has quit IRC | 05:58 | |
| *** rcernin has joined #openstack-keystone | 06:13 | |
| *** pcaruana has joined #openstack-keystone | 07:36 | |
| *** rcernin has quit IRC | 07:59 | |
| *** xek has quit IRC | 08:13 | |
| *** xek has joined #openstack-keystone | 08:13 | |
| *** tkajinam has quit IRC | 08:18 | |
| *** pcaruana has quit IRC | 08:24 | |
| *** pcaruana|afk| has joined #openstack-keystone | 08:24 | |
| *** emine__ has joined #openstack-keystone | 08:26 | |
| *** markvoelker has joined #openstack-keystone | 08:27 | |
| *** awalende has joined #openstack-keystone | 08:33 | |
| *** shyamb has joined #openstack-keystone | 08:52 | |
| *** shyamb has quit IRC | 09:08 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 09:30 | |
| *** Dinesh__Bhor has joined #openstack-keystone | 09:30 | |
| *** Dinesh__Bhor has quit IRC | 09:30 | |
| *** Dinesh_Bhor has quit IRC | 09:30 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 09:31 | |
| *** vishakha has quit IRC | 09:40 | |
| *** shyamb has joined #openstack-keystone | 10:10 | |
| *** shyamb has quit IRC | 10:50 | |
| cmurphy | adriant: user settable options makes sense to me for things like mfa but favorite_projects seems really horizon-specific to me | 10:50 |
| *** shyamb has joined #openstack-keystone | 11:07 | |
| *** BlackDex has quit IRC | 11:28 | |
| *** BlackDex has joined #openstack-keystone | 11:57 | |
| *** FlorianFa has quit IRC | 12:14 | |
| *** jamesmcarthur has joined #openstack-keystone | 12:20 | |
| *** markvoelker has quit IRC | 12:25 | |
| *** pcaruana has joined #openstack-keystone | 12:26 | |
| *** pcaruana|afk| has quit IRC | 12:28 | |
| *** jamesmcarthur has quit IRC | 12:36 | |
| *** shyamb has quit IRC | 12:37 | |
| *** shyamb has joined #openstack-keystone | 12:39 | |
| *** shyamb has quit IRC | 12:39 | |
| *** shyamb has joined #openstack-keystone | 12:39 | |
| *** shyamb has quit IRC | 12:40 | |
| *** jamesmcarthur has joined #openstack-keystone | 12:48 | |
| *** raildo has joined #openstack-keystone | 13:01 | |
| *** dave-mccowan has joined #openstack-keystone | 13:02 | |
| *** imus has joined #openstack-keystone | 13:03 | |
| *** pcaruana has quit IRC | 13:36 | |
| *** TheJulia is now known as needssleep | 13:59 | |
| *** jamesmcarthur has quit IRC | 13:59 | |
| *** efried is now known as fried_rice | 14:00 | |
| *** awalende has quit IRC | 14:11 | |
| *** awalende has joined #openstack-keystone | 14:12 | |
| openstackgerrit | Merged openstack/keystone master: trivial: fix broken link in trust API reference https://review.openstack.org/643148 | 14:15 |
| *** awalende_ has joined #openstack-keystone | 14:15 | |
| *** awalende has quit IRC | 14:16 | |
| *** awalende_ has quit IRC | 14:17 | |
| *** pcaruana has joined #openstack-keystone | 14:17 | |
| *** pcaruana|afk| has joined #openstack-keystone | 14:17 | |
| *** pcaruana|afk| has quit IRC | 14:17 | |
| *** jhesketh_ has quit IRC | 14:20 | |
| *** jamesmcarthur has joined #openstack-keystone | 14:31 | |
| gagehugo | o/ | 14:46 |
| *** jhesketh_ has joined #openstack-keystone | 14:46 | |
| cmurphy | \o | 14:47 |
| *** jhesketh has quit IRC | 14:49 | |
| *** jhesketh has joined #openstack-keystone | 14:49 | |
| *** jhesketh_ has quit IRC | 14:51 | |
| *** raildo has quit IRC | 14:51 | |
| *** raildo has joined #openstack-keystone | 14:52 | |
| *** jhesketh has quit IRC | 14:54 | |
| *** jaosorior has quit IRC | 14:56 | |
| *** jhesketh has joined #openstack-keystone | 15:03 | |
| *** erus has joined #openstack-keystone | 15:35 | |
| erus | o/ | 15:35 |
| *** gyee has joined #openstack-keystone | 16:23 | |
| *** erus has quit IRC | 16:23 | |
| *** erus has joined #openstack-keystone | 16:24 | |
| *** kmalloc is now known as needscoffee | 16:25 | |
| needscoffee | cmurphy, gagehugo, gyee: This is fun https://code.activestate.com/recipes/474088-tail-call-optimization-decorator/ Not that we do a lot of recursive stuff in keystone, but hey, it's cool. | 16:26 |
| gagehugo | interesting | 16:27 |
| needscoffee | alternative approach https://chrispenner.ca/posts/python-tail-recursion | 16:27 |
| erus | needscoffee :o | 16:48 |
| *** raildo has quit IRC | 16:51 | |
| *** raildo has joined #openstack-keystone | 16:52 | |
| *** jamesmcarthur has quit IRC | 17:00 | |
| *** jamesmcarthur has joined #openstack-keystone | 17:01 | |
| *** itlinux has quit IRC | 17:18 | |
| gyee | needscoffee, we have lots of decorators in keystone :-) | 17:47 |
| gyee | made my head spin every time inspecting them tracebacks | 17:49 |
| needscoffee | gyee: we have a lot less now. | 17:50 |
| gyee | oh good | 17:51 |
| needscoffee | gyee: losing the enforcement decorator was a good start. | 17:51 |
| needscoffee | :) | 17:51 |
| *** jamesmcarthur has quit IRC | 18:20 | |
| *** dmellado has quit IRC | 19:17 | |
| *** dave-mccowan has quit IRC | 19:18 | |
| *** dave-mccowan has joined #openstack-keystone | 19:30 | |
| *** jamesmcarthur has joined #openstack-keystone | 19:31 | |
| *** mchlumsky_ has quit IRC | 19:34 | |
| *** openstack has joined #openstack-keystone | 19:41 | |
| *** ChanServ sets mode: +o openstack | 19:41 | |
| *** dave-mccowan has quit IRC | 19:43 | |
| *** pcaruana has quit IRC | 19:59 | |
| openstackgerrit | Corey Bryant proposed openstack/keystone master: PY3: Ensure LDAP searches use unicode attributes https://review.openstack.org/643670 | 20:00 |
| coreycb | if anyone has cycles to review this i'd appreciate it very much. we have a customer deployment tripping over it. | 20:02 |
| *** jamesmcarthur has quit IRC | 20:09 | |
| *** emine__ has quit IRC | 20:14 | |
| *** erus has quit IRC | 20:14 | |
| *** erus has joined #openstack-keystone | 20:15 | |
| coreycb | jdennis: maybe you can take a look at that ^ when you get a chance | 20:16 |
| jdennis | coreycb: looking now ... | 20:20 |
| *** jamesmcarthur has joined #openstack-keystone | 20:24 | |
| coreycb | jdennis: thanks very much | 20:24 |
| *** dmellado has joined #openstack-keystone | 20:29 | |
| *** whoami-rajat has quit IRC | 20:46 | |
| *** jamesmcarthur has quit IRC | 20:59 | |
| *** imus has quit IRC | 21:03 | |
| *** erus has quit IRC | 21:03 | |
| *** erus has joined #openstack-keystone | 21:03 | |
| *** lbragstad has joined #openstack-keystone | 21:08 | |
| *** ChanServ sets mode: +o lbragstad | 21:08 | |
| jdennis | coreycb: fix looks good but we need to figure out why the existing unit tests didn't catch such an obvious flaw, I -1 for now but will +1 once we figure out why the tests didn't catch this. | 21:09 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement domain reader functionality for projects https://review.openstack.org/624218 | 21:19 |
| *** jamesmcarthur has joined #openstack-keystone | 21:22 | |
| *** erus has quit IRC | 21:24 | |
| *** erus has joined #openstack-keystone | 21:24 | |
| *** jamesmcarthur has quit IRC | 21:27 | |
| *** raildo has quit IRC | 21:34 | |
| coreycb | jdennis: thanks. agreed on unit tests. i'll revisit those. | 21:39 |
| lbragstad | does anyone want to take another swing at https://review.openstack.org/#/c/638563/ ? | 21:42 |
| *** awalende has joined #openstack-keystone | 22:13 | |
| *** erus has quit IRC | 22:13 | |
| *** erus has joined #openstack-keystone | 22:13 | |
| *** awalende has quit IRC | 22:17 | |
| *** markvoelker has joined #openstack-keystone | 22:20 | |
| *** jamesmcarthur has joined #openstack-keystone | 22:24 | |
| *** jamesmcarthur has quit IRC | 22:24 | |
| *** markvoelker has quit IRC | 22:24 | |
| *** markvoelker has joined #openstack-keystone | 22:51 | |
| *** erus has quit IRC | 22:57 | |
| *** erus has joined #openstack-keystone | 22:58 | |
| rm_work | cmurphy / lbragstad why is https://review.openstack.org/#/c/643021/ back to 3.37.0? | 23:34 |
| *** erus has quit IRC | 23:34 | |
| rm_work | That doesn't actually resolve the issue! And you've already workflowed it? | 23:34 |
| *** erus has joined #openstack-keystone | 23:35 | |
| rm_work | lbragstad: can you kill the workflow on that patch? | 23:35 |
| rm_work | erg maybe i can do it | 23:36 |
| rm_work | ah ok nm, it's on top of another patch | 23:38 |
| rm_work | so it's not merging yet | 23:38 |
| rm_work | that's good :D | 23:38 |
| rm_work | i'll fix it anyway | 23:39 |
| rm_work | i think maybe it accidentally got reverted to an old version when rebasing | 23:39 |
| rm_work | and that +A worried me a bit lol | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!