openstackgerrit | ayoung proposed openstack/keystone master: Replace UUID with id_generator for Federated users https://review.openstack.org/605169 | 00:06 |
---|---|---|
openstackgerrit | Merged openstack/keystone master: DRY: Remove redundant policies from policy.v3cloudsample.json https://review.openstack.org/622589 | 00:16 |
cmurphy | okay now https://review.openstack.org/649344 is ready kmalloc lbragstad | 00:17 |
*** jamesmcarthur has quit IRC | 00:24 | |
*** raildo has quit IRC | 00:28 | |
*** raildo has joined #openstack-keystone | 00:35 | |
lbragstad | cmurphy done - pending you're cool with a self-approval | 00:35 |
lbragstad | rc2 is so close i can taste it | 00:35 |
*** jamesmcarthur has joined #openstack-keystone | 00:55 | |
*** jamesmcarthur has quit IRC | 00:55 | |
*** jamesmcarthur has joined #openstack-keystone | 00:56 | |
*** lbragstad_ has joined #openstack-keystone | 01:10 | |
*** ChanServ sets mode: +o lbragstad_ | 01:10 | |
*** lbragstad has quit IRC | 01:12 | |
*** phasespace has quit IRC | 01:12 | |
*** kklimonda has quit IRC | 01:12 | |
*** spotz has quit IRC | 01:12 | |
*** kklimonda has joined #openstack-keystone | 01:12 | |
*** erus has quit IRC | 01:40 | |
*** erus has joined #openstack-keystone | 01:41 | |
*** shyamb has joined #openstack-keystone | 01:55 | |
*** whoami-rajat has joined #openstack-keystone | 01:57 | |
*** raildo has quit IRC | 02:06 | |
*** spsurya has joined #openstack-keystone | 02:12 | |
*** jamesmcarthur has quit IRC | 02:31 | |
*** jamesmcarthur has joined #openstack-keystone | 03:01 | |
*** lbragstad_ is now known as lbragstad | 03:14 | |
*** shyamb has quit IRC | 03:26 | |
*** shyamb has joined #openstack-keystone | 03:41 | |
*** shyamb has quit IRC | 03:46 | |
*** whoami-rajat has quit IRC | 04:57 | |
*** shyamb has joined #openstack-keystone | 05:11 | |
*** shyamb has quit IRC | 05:16 | |
*** shyamb has joined #openstack-keystone | 05:26 | |
*** lbragstad has quit IRC | 05:28 | |
*** vishakha has joined #openstack-keystone | 05:42 | |
*** shyamb has quit IRC | 06:05 | |
*** shyamb has joined #openstack-keystone | 06:16 | |
*** shyamb has quit IRC | 06:18 | |
*** shyamb has joined #openstack-keystone | 06:18 | |
*** pcaruana has joined #openstack-keystone | 06:36 | |
*** pcaruana has quit IRC | 06:38 | |
*** pcaruana has joined #openstack-keystone | 06:38 | |
*** phasespace has joined #openstack-keystone | 06:52 | |
*** tkajinam has quit IRC | 06:58 | |
*** tkajinam has joined #openstack-keystone | 07:03 | |
*** shyamb has quit IRC | 07:05 | |
*** shyamb has joined #openstack-keystone | 07:05 | |
*** whoami-rajat has joined #openstack-keystone | 07:13 | |
*** awalende has joined #openstack-keystone | 07:13 | |
*** bbobrov has quit IRC | 07:17 | |
*** bbobrov has joined #openstack-keystone | 07:17 | |
*** xek has joined #openstack-keystone | 07:19 | |
*** jistr is now known as jistr|afk | 07:22 | |
*** shyamb has quit IRC | 08:26 | |
*** tkajinam has quit IRC | 08:45 | |
*** shyamb has joined #openstack-keystone | 09:06 | |
*** xek has quit IRC | 09:20 | |
*** xek has joined #openstack-keystone | 09:21 | |
*** xek has quit IRC | 09:22 | |
*** whoami-rajat has quit IRC | 09:37 | |
*** markvoelker has joined #openstack-keystone | 09:55 | |
*** shyamb has quit IRC | 09:56 | |
*** shyamb has joined #openstack-keystone | 10:00 | |
*** erus has quit IRC | 10:11 | |
*** erus has joined #openstack-keystone | 10:11 | |
*** shyamb has quit IRC | 10:23 | |
*** shyamb has joined #openstack-keystone | 10:23 | |
*** markvoelker has quit IRC | 10:27 | |
*** Dinesh_Bhor has quit IRC | 10:34 | |
*** shyamb has quit IRC | 10:46 | |
*** mvkr has quit IRC | 11:01 | |
*** jistr|afk is now known as jistr | 11:02 | |
*** hoonetorg has joined #openstack-keystone | 11:16 | |
*** markvoelker has joined #openstack-keystone | 11:24 | |
*** erus has quit IRC | 11:24 | |
*** erus has joined #openstack-keystone | 11:25 | |
*** erus has quit IRC | 11:30 | |
*** erus has joined #openstack-keystone | 11:31 | |
*** rcernin has quit IRC | 11:38 | |
*** raildo has joined #openstack-keystone | 11:38 | |
cmurphy | https://review.openstack.org/649589 | 11:45 |
*** yan0s has joined #openstack-keystone | 11:52 | |
*** mvkr has joined #openstack-keystone | 11:54 | |
*** markvoelker has quit IRC | 11:57 | |
*** shyamb has joined #openstack-keystone | 12:02 | |
*** odyssey4me has quit IRC | 12:12 | |
*** whoami-rajat has joined #openstack-keystone | 12:19 | |
*** odyssey4me has joined #openstack-keystone | 12:26 | |
*** jamesmcarthur has quit IRC | 12:26 | |
*** jamesmcarthur has joined #openstack-keystone | 12:27 | |
*** shyamb has quit IRC | 12:33 | |
*** shyamb has joined #openstack-keystone | 12:34 | |
*** jamesmcarthur has quit IRC | 12:36 | |
*** jamesmcarthur_ has joined #openstack-keystone | 12:43 | |
*** lbragstad has joined #openstack-keystone | 12:56 | |
*** ChanServ sets mode: +o lbragstad | 12:56 | |
*** jmlowe has quit IRC | 12:57 | |
*** shyamb has quit IRC | 13:10 | |
openstackgerrit | Lance Bragstad proposed openstack/oslo.policy master: Clarify policy_file configuration option help text https://review.openstack.org/649606 | 13:12 |
*** vishakha has quit IRC | 13:21 | |
*** dklyle has quit IRC | 13:30 | |
*** dklyle has joined #openstack-keystone | 13:31 | |
*** jmlowe has joined #openstack-keystone | 13:49 | |
*** awalende has quit IRC | 14:03 | |
*** awalende has joined #openstack-keystone | 14:03 | |
*** awalende_ has joined #openstack-keystone | 14:07 | |
*** awalende has quit IRC | 14:08 | |
*** awalende_ has quit IRC | 14:11 | |
*** dklyle has quit IRC | 14:15 | |
gagehugo | o/ | 14:32 |
cmurphy | \o | 14:32 |
lbragstad | o/ | 14:34 |
* lbragstad isn't quite sure what the deal is with the rc2 release patch | 14:34 | |
cmurphy | sphinx 2.0 release | 14:35 |
cmurphy | they're working on it | 14:35 |
*** awalende has joined #openstack-keystone | 14:35 | |
*** awalende has quit IRC | 14:39 | |
*** dklyle has joined #openstack-keystone | 14:41 | |
lbragstad | ah | 14:41 |
*** erus has quit IRC | 15:08 | |
*** erus has joined #openstack-keystone | 15:09 | |
*** phasespace has quit IRC | 15:12 | |
*** erus has quit IRC | 15:24 | |
*** erus has joined #openstack-keystone | 15:25 | |
*** mvkr has quit IRC | 15:28 | |
bnemec | kmalloc: Did we need https://review.openstack.org/#/c/644774/ for stein? | 15:32 |
bnemec | I guess that's probably backportable so if it misses the final release it's not the end of the world. | 15:33 |
kmalloc | bnemec: backport it after s releases | 15:33 |
kmalloc | way easier at this point | 15:33 |
bnemec | kmalloc: Sounds good, thanks. | 15:33 |
*** erus has quit IRC | 15:37 | |
*** erus has joined #openstack-keystone | 15:37 | |
*** shyamb has joined #openstack-keystone | 15:44 | |
*** erus has quit IRC | 15:44 | |
*** erus has joined #openstack-keystone | 15:45 | |
*** jamesmcarthur_ has quit IRC | 15:53 | |
*** phasespace has joined #openstack-keystone | 15:58 | |
*** yan0s has quit IRC | 16:09 | |
*** jamesmcarthur has joined #openstack-keystone | 16:12 | |
*** jamesmcarthur has quit IRC | 16:15 | |
*** jamesmcarthur has joined #openstack-keystone | 16:23 | |
knikolla | o/ | 16:32 |
*** erus has quit IRC | 16:32 | |
*** erus has joined #openstack-keystone | 16:33 | |
*** spsurya has quit IRC | 16:46 | |
*** jamesmcarthur has quit IRC | 16:52 | |
*** shyamb has quit IRC | 16:53 | |
*** jamesmcarthur has joined #openstack-keystone | 16:56 | |
openstackgerrit | Merged openstack/oslo.policy master: Clarify policy_file configuration option help text https://review.openstack.org/649606 | 17:17 |
ayoung | cmurphy, I've found a couple other places where the Federation tests have failed. | 17:21 |
ayoung | I suspect that the CADF code is being overly sensitive when creating a notification | 17:21 |
cmurphy | ayoung: have a link? | 17:25 |
ayoung | AND...the log is gone here is the code that fails in keystone http://git.openstack.org/cgit/openstack/keystone/tree/keystone/notifications.py#n723 | 17:27 |
*** spsurya has joined #openstack-keystone | 17:28 | |
ayoung | It calls https://git.openstack.org/cgit/openstack/pycadf/tree/pycadf/credential.py#n87 | 17:29 |
ayoung | # FederatedCredential.user | 17:29 |
ayoung | setattr(self, FED_CRED_KEYNAME_USER, user) | 17:29 |
ayoung | So username, not ID | 17:29 |
ayoung | Ah, but that is a key, bet it is a whole dictionary | 17:29 |
ayoung | And here is the exception raised https://git.openstack.org/cgit/openstack/pycadf/tree/pycadf/cadftype.py#n66 | 17:30 |
ayoung | self.func(value) is the lambda | 17:31 |
ayoung | Where is stevemar when you need him? He did all the cadf work IIRC | 17:34 |
*** jamesmcarthur has quit IRC | 17:35 | |
ayoung | cmurphy, looks like the lambda is here https://git.openstack.org/cgit/openstack/pycadf/tree/pycadf/credential.py#n39 | 17:37 |
ayoung | so, it is not coming across as a string type? | 17:37 |
cmurphy | really strange | 17:44 |
ayoung | cmurphy, got a paste for you...1 sec | 17:45 |
cmurphy | RBAC: auth_context: {'token': <TokenModel (audit_id=egOx1wPnSwezUpnI57-XYA, audit_chain_id=['egOx1wPnSwezUpnI57-XYA']) at 0x7f2839645080>, 'domain_id': None, 'trust_id': None, 'trustor_id': None, 'trustee_id': None, 'domain_name': None, 'group_ids': [], 'user_id': '18fafa79e50f4d06b04364624730f378', 'user_domain_id': 'default', 'system_scope': None, 'project_id': | 17:45 |
cmurphy | '485249bc0c6e4f788494f2952f7e5d6f', 'project_domain_id': 'default', 'roles': ['member', 'reader', 'admin'], 'is_admin_project': True, 'service_user_id': None, 'service_user_domain_id': None, 'service_project_id': None, 'service_project_domain_id': None, 'service_roles': []} {{(pid=15674) fill_context /opt/stack/keystone/keystone/server/flask/request_processing/middleware/auth_context.py:472}} | 17:45 |
cmurphy | user_id looks like it should be fine there | 17:45 |
ayoung | http://paste.openstack.org/show/748826/ | 17:45 |
ayoung | https://docs.python.org/3/library/hashlib.html | 17:48 |
ayoung | hash.hexdigest() | 17:48 |
ayoung | Like digest() except the digest is returned as a string object of double length, containing only hexadecimal digits. This may be used to exchange the value safely in email or other non-binary environments. | 17:48 |
ayoung | https://git.openstack.org/cgit/openstack/pycadf/tree/pycadf/credential.py#n71 that is where the lambda is set, and it is still just looking for a string | 17:50 |
ayoung | I'm tempted to put in some logging into the patch and see if we can get a smoking gun. | 17:52 |
ayoung | Maybe the hash is returning None for some reason | 17:52 |
*** jmlowe has quit IRC | 17:52 | |
*** jmlowe has joined #openstack-keystone | 17:55 | |
*** erus has quit IRC | 18:00 | |
*** erus has joined #openstack-keystone | 18:01 | |
cmurphy | ayoung: what version of python3 did you use for http://paste.openstack.org/show/748826/ ? i wonder if hexdigest() returns something that's not quite a string on python3.6 | 18:07 |
ayoung | 37...native to Fedora. Let me try 3.6 | 18:07 |
cmurphy | seems like older versions of py3 had a slightly different behavior https://stackoverflow.com/questions/3583265/compare-result-from-hexdigest-to-a-string | 18:08 |
ayoung | py36 seems to produce the same thing | 18:10 |
*** lbragstad has quit IRC | 18:11 | |
cmurphy | hmm | 18:12 |
*** lbragstad has joined #openstack-keystone | 18:12 | |
*** ChanServ sets mode: +o lbragstad | 18:12 | |
*** jamesmcarthur has joined #openstack-keystone | 18:17 | |
*** jamesmcarthur has quit IRC | 18:21 | |
*** samueldmq has joined #openstack-keystone | 18:25 | |
*** erus has quit IRC | 18:25 | |
*** erus has joined #openstack-keystone | 18:26 | |
*** jamesmcarthur has joined #openstack-keystone | 18:31 | |
*** jmlowe has quit IRC | 18:57 | |
ayoung | cmurphy, what do you want me to do about the change? | 19:05 |
ayoung | I can add a test that ensures the id generator value is a string | 19:06 |
ayoung | Or maybe it should that the value generated that way passes pyCadf? | 19:06 |
cmurphy | ayoung: are there other changes where this bug is appearing? if so then we can go ahead with your change and file a bug for the issue, if not then something in your patch needs to be fixed | 19:09 |
cmurphy | i haven't seen this bug appear anywhere else so far | 19:10 |
ayoung | how do we confirm it is a bug? | 19:12 |
cmurphy | i've been trying to trigger it with https://review.openstack.org/649453 | 19:14 |
*** erus has quit IRC | 19:14 | |
cmurphy | of course zuul is not super speedy this week | 19:14 |
*** erus has joined #openstack-keystone | 19:15 | |
cmurphy | i'll deploy your change locally and see if i can trigger it | 19:15 |
*** erus has quit IRC | 19:20 | |
*** erus has joined #openstack-keystone | 19:21 | |
*** jmlowe has joined #openstack-keystone | 19:48 | |
*** jamesmcarthur has quit IRC | 19:55 | |
*** awalende has joined #openstack-keystone | 20:20 | |
*** whoami-rajat has quit IRC | 20:29 | |
*** jamesmcarthur has joined #openstack-keystone | 20:33 | |
*** jamesmcarthur has quit IRC | 20:39 | |
mnaser | hi friends. how much stuff in rc2 were ~really~ critical vs rc1 (aka, is there some sort of 'list of bugs we caught in rc2' ?) | 20:40 |
mnaser | just to know if we need to quickly leap onto rc2 | 20:40 |
*** jamesmcarthur has joined #openstack-keystone | 20:41 | |
lbragstad | i don't think there was anything super critical | 20:42 |
lbragstad | https://launchpad.net/keystone/+milestone/stein-rc2 are the specific bugs that were included in rc2 | 20:42 |
lbragstad | lot of scope types work | 20:43 |
lbragstad | some performance stuff | 20:43 |
*** rcernin has joined #openstack-keystone | 20:44 | |
*** spsurya has quit IRC | 20:59 | |
cmurphy | ayoung: well i can't reproduce it at all | 21:05 |
cmurphy | totally clueless | 21:05 |
*** pcaruana has quit IRC | 21:06 | |
openstackgerrit | ayoung proposed openstack/keystone master: Replace UUID with id_generator for Federated users https://review.openstack.org/605169 | 21:13 |
*** rcernin has quit IRC | 21:42 | |
*** raildo has quit IRC | 21:45 | |
openstackgerrit | ayoung proposed openstack/keystone master: Test case for id Generator https://review.openstack.org/649747 | 21:47 |
ayoung | cmurphy, ^^ that is the start for testing. | 21:48 |
*** awalende has quit IRC | 21:59 | |
*** jamesmcarthur has quit IRC | 22:14 | |
*** jamesmcarthur has joined #openstack-keystone | 22:32 | |
*** jamesmcarthur has quit IRC | 22:32 | |
*** lbragstad has quit IRC | 22:49 | |
*** lbragstad has joined #openstack-keystone | 22:50 | |
*** ChanServ sets mode: +o lbragstad | 22:50 | |
*** tkajinam has joined #openstack-keystone | 23:04 | |
*** erus has quit IRC | 23:10 | |
*** erus has joined #openstack-keystone | 23:11 | |
*** ayoung has quit IRC | 23:18 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!