*** markvoelker has quit IRC | 00:00 | |
openstackgerrit | ayoung proposed openstack/keystone master: Explicit Project ID https://review.opendev.org/664746 | 00:10 |
---|---|---|
*** jamesmcarthur has quit IRC | 00:39 | |
*** zzzeek has quit IRC | 00:47 | |
*** zzzeek has joined #openstack-keystone | 00:47 | |
*** joshualyle has quit IRC | 00:52 | |
*** markvoelker has joined #openstack-keystone | 00:57 | |
*** markvoelker has quit IRC | 01:31 | |
*** dave-mccowan has quit IRC | 01:34 | |
*** dave-mccowan has joined #openstack-keystone | 01:40 | |
*** spsurya has joined #openstack-keystone | 01:52 | |
wxy-xiyuan | cmurphy: Really really sorry that I forgot the meeting! I'll review the video and the etherpad notes. If I have any feedback, I'll leave comments or let you know. Sorry again. :( | 01:54 |
*** zzzeek has quit IRC | 01:57 | |
*** zzzeek has joined #openstack-keystone | 01:58 | |
*** itlinux has joined #openstack-keystone | 01:58 | |
openstackgerrit | wangxiyuan proposed openstack/keystone master: [api-ref] Fix nocatalog description for unscoped token https://review.opendev.org/660902 | 02:05 |
*** zzzeek has quit IRC | 02:13 | |
*** itlinux_ has joined #openstack-keystone | 02:14 | |
*** zzzeek has joined #openstack-keystone | 02:16 | |
*** itlinux has quit IRC | 02:18 | |
*** markvoelker has joined #openstack-keystone | 02:27 | |
*** itlinux_ has quit IRC | 02:54 | |
*** markvoelker has quit IRC | 03:01 | |
*** itlinux has joined #openstack-keystone | 03:34 | |
*** itlinux has quit IRC | 03:36 | |
*** dave-mccowan has quit IRC | 03:46 | |
*** kklimonda has quit IRC | 03:48 | |
*** kklimonda has joined #openstack-keystone | 03:48 | |
*** markvoelker has joined #openstack-keystone | 03:58 | |
openstackgerrit | Merged openstack/keystone master: Report correct domain in federated user token https://review.opendev.org/653068 | 04:26 |
*** markvoelker has quit IRC | 04:32 | |
*** whoami-rajat has joined #openstack-keystone | 04:51 | |
*** pcaruana has joined #openstack-keystone | 04:54 | |
*** pcaruana has quit IRC | 04:59 | |
openstackgerrit | Vishakha Agarwal proposed openstack/keystone master: Remove deprecated admin_endpoint https://review.opendev.org/664246 | 05:12 |
*** vishakha has joined #openstack-keystone | 05:14 | |
*** markvoelker has joined #openstack-keystone | 05:29 | |
cmurphy | It's okay wxy-xiyuan I know it was really late for you | 05:42 |
*** joshualyle has joined #openstack-keystone | 05:49 | |
*** markvoelker has quit IRC | 06:02 | |
*** takamatsu has quit IRC | 06:46 | |
*** pcaruana has joined #openstack-keystone | 06:56 | |
*** markvoelker has joined #openstack-keystone | 06:59 | |
*** tesseract has joined #openstack-keystone | 07:14 | |
*** dmellado has quit IRC | 07:17 | |
*** rcernin has quit IRC | 07:22 | |
*** dmellado has joined #openstack-keystone | 07:29 | |
*** markvoelker has quit IRC | 07:33 | |
*** takamatsu has joined #openstack-keystone | 07:37 | |
*** tkajinam has quit IRC | 08:23 | |
*** markvoelker has joined #openstack-keystone | 08:30 | |
*** imacdonn has quit IRC | 08:38 | |
*** imacdonn has joined #openstack-keystone | 08:39 | |
*** takamatsu has quit IRC | 08:39 | |
*** takamatsu has joined #openstack-keystone | 08:40 | |
*** jaosorior has quit IRC | 08:51 | |
*** markvoelker has quit IRC | 09:03 | |
*** takamatsu has quit IRC | 09:14 | |
*** shyamb has joined #openstack-keystone | 09:23 | |
*** liushuo has joined #openstack-keystone | 09:46 | |
*** takamatsu has joined #openstack-keystone | 09:51 | |
*** markvoelker has joined #openstack-keystone | 10:00 | |
*** shyamb has quit IRC | 10:04 | |
frickler | kmalloc: bnemec: could you add https://review.opendev.org/651790 to your review list, please? would be great if we could get that released before the end of the cycle is dooming again | 10:09 |
*** shyamb has joined #openstack-keystone | 10:13 | |
*** takamatsu has quit IRC | 10:16 | |
*** markvoelker has quit IRC | 10:34 | |
*** takamatsu has joined #openstack-keystone | 10:49 | |
*** joshualyle has quit IRC | 10:52 | |
*** jaosorior has joined #openstack-keystone | 10:53 | |
*** jaosorior has quit IRC | 11:15 | |
*** shyamb has quit IRC | 11:17 | |
*** jaosorior has joined #openstack-keystone | 11:28 | |
*** shyamb has joined #openstack-keystone | 11:36 | |
*** dave-mccowan has joined #openstack-keystone | 12:17 | |
*** raildo has joined #openstack-keystone | 12:28 | |
*** jamesmcarthur has joined #openstack-keystone | 12:41 | |
*** jaosorior has quit IRC | 12:41 | |
*** shyamb has quit IRC | 12:56 | |
*** markvoelker has joined #openstack-keystone | 13:01 | |
*** jamesmcarthur has quit IRC | 13:05 | |
*** rafaelweingartne has joined #openstack-keystone | 13:13 | |
*** stingrayza has quit IRC | 13:19 | |
*** lbragstad has joined #openstack-keystone | 13:20 | |
*** stingrayza has joined #openstack-keystone | 13:21 | |
lbragstad | kmalloc ping me whenever you want to start going through the testresources stuff | 13:26 |
*** pcaruana has quit IRC | 13:30 | |
*** pcaruana|afk| has joined #openstack-keystone | 13:30 | |
*** jaosorior has joined #openstack-keystone | 13:32 | |
*** dklyle has quit IRC | 13:34 | |
*** markvoelker has quit IRC | 13:34 | |
bnemec | frickler: Voted, but I'm not keystone core so my opinion is of limited value here. :-) | 13:36 |
*** jamesmcarthur has joined #openstack-keystone | 13:46 | |
*** jaosorior has quit IRC | 13:50 | |
kmalloc | frickler: +3 | 13:53 |
kmalloc | lbragstad: need coffee | 13:54 |
*** vishakha has quit IRC | 13:54 | |
*** whoami-rajat has quit IRC | 13:55 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: trivial: Fix grammatical issues in unified limits doc https://review.opendev.org/664933 | 13:55 |
lbragstad | kmalloc ack | 13:55 |
*** whoami-rajat has joined #openstack-keystone | 14:01 | |
*** jaosorior has joined #openstack-keystone | 14:04 | |
*** takamatsu has quit IRC | 14:18 | |
*** vishalmanchanda has joined #openstack-keystone | 14:26 | |
*** takamatsu has joined #openstack-keystone | 14:31 | |
*** markvoelker has joined #openstack-keystone | 14:32 | |
kmalloc | lbragstad: o/ | 14:33 |
lbragstad | o/ | 14:34 |
kmalloc | ok so, starting on my coffee | 14:35 |
lbragstad | sounds good | 14:35 |
kmalloc | where are we starting | 14:35 |
lbragstad | i'm working on fixing a bunch of unified limit docs at the moment | 14:35 |
kmalloc | k | 14:35 |
lbragstad | so if you need time to make coffee, that's cool | 14:35 |
kmalloc | nah i have coffee on my desk | 14:36 |
lbragstad | oh - ok | 14:36 |
kmalloc | i need to break at 9am (pacific) | 14:36 |
lbragstad | so - i missed some bits that you and lifeless were talking about | 14:36 |
kmalloc | for a call. | 14:36 |
lbragstad | ok - so we have about an hour and a half | 14:36 |
kmalloc | hour or so | 14:37 |
kmalloc | can hop on a hang out if it helps. | 14:38 |
lbragstad | sure | 14:38 |
lbragstad | https://hangouts.google.com/call/Y8BsXU-vQ1YBPDBLxcg9AEEE | 14:38 |
kmalloc | warming up my mic | 14:38 |
*** takamatsu has quit IRC | 14:38 | |
*** liushuo has quit IRC | 14:44 | |
*** dklyle has joined #openstack-keystone | 14:45 | |
kmalloc | lbragstad: https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/test_fixtures.py#L603-L608 | 14:45 |
frickler | bnemec: kmalloc: marvellous, thanks. assuming it passes gate, whom should I nag about doing a keystonemiddleware release? or is there some schedule for that already? | 14:51 |
ayoung | kmalloc, so I cobbled this up: https://review.opendev.org/#/c/664746/ for explicit project IDs and things break because all our tests pre-allocate the project ID | 14:53 |
ayoung | so...I can add an additional value (explicit_project_id) like I did for domains, which is, I think the only real solution | 14:54 |
bnemec | frickler: cmurphy (PTL) or knikolla (release liaison) would be the people to talk to. | 14:56 |
bnemec | You can also request the release yourself (https://releases.openstack.org/reference/using.html) and then they just need to ack it in Gerrit. | 14:56 |
kmalloc | ayoung: the new stuff lbragstad is doing for the bootstrapper might make this easier | 15:01 |
kmalloc | going forwar5d | 15:01 |
ayoung | kmalloc, how so? | 15:02 |
kmalloc | testresources | 15:05 |
*** markvoelker has quit IRC | 15:05 | |
kmalloc | so we can be more directed about what we need and carry db state through. | 15:05 |
kmalloc | ayoung: sorry crossing threads | 15:06 |
ayoung | its ok, answer when you canfocus on it | 15:06 |
*** jaosorior has quit IRC | 15:06 | |
*** pcaruana|afk| has quit IRC | 15:30 | |
*** notq has joined #openstack-keystone | 15:35 | |
openstackgerrit | Merged openstack/keystonemiddleware master: Add a new option to choose the Identity endpoint https://review.opendev.org/651790 | 15:47 |
notq | attempting to reply to a code comment, i've chosen reply, added details, and now it says it's a draft. How do I save this draft? | 15:52 |
ayoung | submit the review | 15:53 |
ayoung | notq, ^^ | 15:53 |
notq | I don't see a submit button. How does one submit the review? | 15:54 |
kmalloc | notq: at the top of the page "reply" | 15:54 |
notq | ty | 15:55 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Update unified limit documentation https://review.opendev.org/664933 | 16:01 |
*** markvoelker has joined #openstack-keystone | 16:02 | |
*** gyee has joined #openstack-keystone | 16:03 | |
*** pcaruana|afk| has joined #openstack-keystone | 16:09 | |
*** rafaelweingartne has quit IRC | 16:12 | |
openstackgerrit | ayoung proposed openstack/keystone master: Explicit Project ID https://review.opendev.org/664746 | 16:15 |
ayoung | cmurphy, kmalloc, ^^ needs a release note, but that is roughly what we need for sync. | 16:16 |
*** ayoung has quit IRC | 16:24 | |
*** markvoelker has quit IRC | 16:36 | |
openstackgerrit | Nathan Oyler proposed openstack/keystone master: Add cadf auditing to credentials https://review.opendev.org/664618 | 16:45 |
*** ayoung has joined #openstack-keystone | 16:47 | |
*** ayoung has quit IRC | 17:06 | |
*** jamesmcarthur has quit IRC | 17:12 | |
*** spsurya has quit IRC | 17:19 | |
*** ayoung has joined #openstack-keystone | 17:25 | |
*** markvoelker has joined #openstack-keystone | 17:33 | |
*** adriant has quit IRC | 17:35 | |
*** adriant has joined #openstack-keystone | 17:36 | |
*** jamesmcarthur has joined #openstack-keystone | 17:45 | |
*** jamesmcarthur has quit IRC | 17:45 | |
*** jamesmcarthur has joined #openstack-keystone | 17:45 | |
kmalloc | ayoung: commented, looks close needs a json_schema update, RFE Bug in commit, and release note | 17:57 |
lbragstad | i think we're going to need to unwind a whole bunch of stuff to get this to work kmalloc :( | 18:01 |
lbragstad | i'll push the updated version i have | 18:01 |
lbragstad | it breaks attempting to run the tests because the provider registry is locked | 18:01 |
lbragstad | e.g., things are running out of order | 18:02 |
kmalloc | lbragstad: yup, i also don't think we're going to see a huge increase in speed with this. | 18:03 |
lbragstad | lemme push what i have - about to hop into a meeting but it shouldn't last that long | 18:03 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: WIP: use testresources for sharing across unit tests https://review.opendev.org/663065 | 18:05 |
lbragstad | kmalloc ^ | 18:05 |
*** markvoelker has quit IRC | 18:06 | |
*** tesseract has quit IRC | 18:54 | |
*** markvoelker has joined #openstack-keystone | 19:03 | |
*** xek_ has joined #openstack-keystone | 19:24 | |
*** jamesmcarthur has quit IRC | 19:36 | |
*** markvoelker has quit IRC | 19:37 | |
openstackgerrit | Nathan Oyler proposed openstack/keystone master: Add cadf auditing to credentials https://review.opendev.org/664618 | 19:38 |
*** jenglisch has quit IRC | 19:39 | |
*** jenglisch has joined #openstack-keystone | 19:43 | |
*** jamesmcarthur has joined #openstack-keystone | 19:43 | |
*** hoonetorg has quit IRC | 19:51 | |
*** whoami-rajat has quit IRC | 19:55 | |
lbragstad | kmalloc based on the new failures i'm getting, i think we need to have the config fixture and key repository fixtures setup before we can setup the bootstrap fixture | 19:58 |
lbragstad | so, i guess that makes the dependency config -> key repositories -> bootstrap | 19:59 |
lbragstad | if bootstrap() is called without config or key repositories setup, it'll blow up trying to load the fernet token provider since the key repo doesn't exist, yet | 19:59 |
lbragstad | the interesting part is that the resources list in TestCase is getting resolved at import time | 20:00 |
lbragstad | and the key repository fixture needs to be called with the config fixture, according to the method signature of KeyRepository() | 20:01 |
*** hoonetorg has joined #openstack-keystone | 20:03 | |
openstackgerrit | Nathan Oyler proposed openstack/keystone master: Add cadf auditing to credentials https://review.opendev.org/664618 | 20:08 |
frickler | cmurphy: knikolla: do you want me to propose a keystonemiddleware release patch for you or do you want some other patches to get in first? I'm assuming that this would be a new minor version, i.e. 6.1.0? | 20:10 |
kmalloc | lbragstad: figured | 20:12 |
kmalloc | frickler: you can do it, just pink cmurphy and knikolla to +1 / ack it | 20:13 |
frickler | kmalloc: o.k., will do, thx | 20:16 |
notq | cmurphy: hoping this time :) | 20:18 |
*** jamesmcarthur has quit IRC | 20:23 | |
lbragstad | kmalloc it doesn't look like testresources calls useFixture at all, does it? | 20:24 |
lbragstad | i can't seem to find it | 20:24 |
kmalloc | No it doesnt | 20:24 |
lbragstad | asking because i know that's what we use to setup fixture for tests, today | 20:24 |
kmalloc | It abstracts that away | 20:25 |
kmalloc | No need, because the resourcemanager controls the fixture instead of the test class | 20:25 |
cmurphy | notq: i have bad news for you | 20:25 |
lbragstad | hmm | 20:27 |
lbragstad | i wonder if there is a way to get access to that stuff in the process of setting up other dependent fixtures | 20:28 |
notq | I ran the tox, and it didn't complain :( | 20:28 |
lbragstad | https://pasted.tech/pastes/c0322fd6e75196d2cdd15513a4c33bf1d6202e8b.raw is what i have locally on top of the latest patchset | 20:29 |
notq | How do I split that line up to meet pep8? Does the http_client align with credential_id as well? | 20:29 |
notq | oh you provided a paste, ok | 20:30 |
*** xek_ has quit IRC | 20:34 | |
openstackgerrit | Nathan Oyler proposed openstack/keystone master: Add cadf auditing to credentials https://review.opendev.org/664618 | 20:34 |
*** markvoelker has joined #openstack-keystone | 20:34 | |
cmurphy | notq: lgtm | 20:36 |
lbragstad | kmalloc i summarized it in the review, maybe we can ask lifeless to fact check it? | 20:45 |
lbragstad | review: https://review.opendev.org/#/c/663065/3 | 20:45 |
cmurphy | kmalloc: hmm taiga doesn't seem to have a concept of teams on their own, at least not with the free plan, you just have teams per board | 20:53 |
cmurphy | which is different from trello...but probably okay since they are public boards anyway | 20:53 |
kmalloc | cmurphy: yeah =/ | 20:53 |
kmalloc | it's just a little pain you need to add people to the boarss | 20:54 |
kmalloc | boards | 20:54 |
kmalloc | turns out it's an RFE (long standing) | 20:54 |
*** vishalmanchanda has quit IRC | 20:55 | |
*** markvoelker has quit IRC | 21:08 | |
*** pcaruana|afk| has quit IRC | 21:16 | |
frickler | cmurphy: knikolla: keystonemiddleware release request https://review.opendev.org/665021 . I'm also checking with the release team why there was no automatic release made for train-1 milestone | 21:31 |
cmurphy | i thought they didn't do milestone releases any more | 21:36 |
cmurphy | in any case it's not a service | 21:37 |
frickler | cmurphy: there was one for stein-1 it seems I4b2d57bd31cb244cb02c7a45b8637579cc240ed7 | 21:43 |
*** raildo has quit IRC | 21:47 | |
*** markvoelker has joined #openstack-keystone | 22:05 | |
*** notq has quit IRC | 22:12 | |
*** markvoelker has quit IRC | 22:38 | |
*** rcernin has joined #openstack-keystone | 22:41 | |
*** tkajinam has joined #openstack-keystone | 22:56 | |
*** jamesmcarthur has joined #openstack-keystone | 22:59 | |
*** lifeless has quit IRC | 23:05 | |
*** jamesmcarthur has quit IRC | 23:08 | |
*** markvoelker has joined #openstack-keystone | 23:35 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!