| *** markvoelker has joined #openstack-keystone | 00:02 | |
| *** markvoelker has quit IRC | 00:06 | |
| *** markvoelker has joined #openstack-keystone | 00:45 | |
| *** jamesmcarthur has quit IRC | 00:57 | |
| *** markvoelker has quit IRC | 01:09 | |
| *** jamesmcarthur has joined #openstack-keystone | 01:19 | |
| *** jamesmcarthur has quit IRC | 01:32 | |
| *** markvoelker has joined #openstack-keystone | 02:01 | |
| *** jamesmcarthur has joined #openstack-keystone | 02:03 | |
| *** markvoelker has quit IRC | 02:06 | |
| *** markvoelker has joined #openstack-keystone | 02:32 | |
| *** whoami-rajat has joined #openstack-keystone | 02:38 | |
| *** markvoelker has quit IRC | 02:42 | |
| *** jamesmcarthur has quit IRC | 03:11 | |
| *** markvoelker has joined #openstack-keystone | 03:13 | |
| *** markvoelker has quit IRC | 03:17 | |
| openstackgerrit | zhufl proposed openstack/keystone master: Fix missing print format and missing ws between words https://review.opendev.org/674521 | 03:24 |
|---|---|---|
| *** jamesmcarthur has joined #openstack-keystone | 03:42 | |
| *** markvoelker has joined #openstack-keystone | 04:28 | |
| *** jamesmcarthur has quit IRC | 04:30 | |
| *** markvoelker has quit IRC | 04:33 | |
| *** jamesmcarthur has joined #openstack-keystone | 05:04 | |
| *** vishalmanchanda has joined #openstack-keystone | 05:13 | |
| *** jaosorior has joined #openstack-keystone | 05:41 | |
| *** jamesmcarthur has quit IRC | 05:53 | |
| *** dancn has joined #openstack-keystone | 06:03 | |
| *** jamesmcarthur has joined #openstack-keystone | 06:23 | |
| *** jamesmcarthur has quit IRC | 06:27 | |
| *** obre has joined #openstack-keystone | 06:29 | |
| *** jamesmcarthur has joined #openstack-keystone | 06:49 | |
| *** jamesmcarthur has quit IRC | 06:54 | |
| *** rcernin has quit IRC | 07:04 | |
| *** xek has joined #openstack-keystone | 07:05 | |
| *** pcaruana has joined #openstack-keystone | 07:08 | |
| *** markvoelker has joined #openstack-keystone | 07:17 | |
| *** tesseract has joined #openstack-keystone | 07:17 | |
| *** xek has quit IRC | 07:28 | |
| *** markvoelker has quit IRC | 07:51 | |
| *** tkajinam has quit IRC | 08:11 | |
| *** tesseract-RH has joined #openstack-keystone | 08:22 | |
| *** tesseract has quit IRC | 08:22 | |
| *** tesseract-RH has quit IRC | 08:24 | |
| *** tesseract has joined #openstack-keystone | 08:24 | |
| *** dancn has quit IRC | 08:33 | |
| *** dancn has joined #openstack-keystone | 08:39 | |
| *** jaosorior has quit IRC | 08:51 | |
| *** markvoelker has joined #openstack-keystone | 08:56 | |
| *** markvoelker has quit IRC | 09:30 | |
| *** dasp has quit IRC | 09:49 | |
| *** dasp has joined #openstack-keystone | 09:49 | |
| *** spsurya has joined #openstack-keystone | 09:50 | |
| *** dancn has quit IRC | 10:01 | |
| *** jaosorior has joined #openstack-keystone | 10:05 | |
| *** mvkr has joined #openstack-keystone | 10:18 | |
| openstackgerrit | Merged openstack/keystone master: Followup for remove signing[config]. https://review.opendev.org/673476 | 10:35 |
| *** markvoelker has joined #openstack-keystone | 10:38 | |
| *** markvoelker has quit IRC | 10:43 | |
| *** dancn has joined #openstack-keystone | 11:00 | |
| *** kplant has joined #openstack-keystone | 11:12 | |
| *** jaosorior has quit IRC | 11:23 | |
| *** raildo has joined #openstack-keystone | 11:44 | |
| *** jamesmcarthur has joined #openstack-keystone | 11:46 | |
| *** markvoelker has joined #openstack-keystone | 11:55 | |
| *** markvoelker has quit IRC | 12:02 | |
| *** markvoelker has joined #openstack-keystone | 12:02 | |
| *** jamesmcarthur has quit IRC | 12:05 | |
| *** markvoelker has quit IRC | 12:09 | |
| *** jaosorior has joined #openstack-keystone | 12:10 | |
| *** markvoelker has joined #openstack-keystone | 12:11 | |
| *** raildo has quit IRC | 12:24 | |
| *** raildo has joined #openstack-keystone | 12:32 | |
| *** jroll has quit IRC | 12:39 | |
| *** jroll has joined #openstack-keystone | 12:39 | |
| *** jamesmcarthur has joined #openstack-keystone | 12:41 | |
| *** joshualyle has joined #openstack-keystone | 13:01 | |
| *** jamesmcarthur has quit IRC | 13:04 | |
| *** joshualyle has quit IRC | 13:04 | |
| *** jamesmcarthur has joined #openstack-keystone | 13:15 | |
| *** pcaruana has quit IRC | 13:47 | |
| *** pcaruana has joined #openstack-keystone | 14:00 | |
| *** jaosorior has quit IRC | 14:36 | |
| *** jaosorior has joined #openstack-keystone | 14:39 | |
| *** bnemec-pto is now known as bnemec | 15:01 | |
| *** dancn has quit IRC | 15:48 | |
| *** gyee has joined #openstack-keystone | 15:48 | |
| *** tesseract has quit IRC | 16:04 | |
| *** Horrorcat has quit IRC | 16:33 | |
| *** jamesmcarthur has quit IRC | 16:39 | |
| *** raildo has quit IRC | 16:40 | |
| *** raildo has joined #openstack-keystone | 16:48 | |
| *** markvoelker has quit IRC | 16:49 | |
| *** jamesmcarthur has joined #openstack-keystone | 16:54 | |
| *** markvoelker has joined #openstack-keystone | 17:01 | |
| *** jamesmcarthur has quit IRC | 17:07 | |
| *** jamesmcarthur has joined #openstack-keystone | 17:12 | |
| *** jamesmcarthur has quit IRC | 17:32 | |
| *** jamesmcarthur has joined #openstack-keystone | 17:37 | |
| *** jamesmcarthur_ has joined #openstack-keystone | 17:39 | |
| *** jamesmcarthur has quit IRC | 17:41 | |
| *** jamesmcarthur has joined #openstack-keystone | 17:42 | |
| *** jamesmcarthur_ has quit IRC | 17:43 | |
| *** jamesmcarthur has quit IRC | 17:48 | |
| *** jamesmcarthur has joined #openstack-keystone | 17:53 | |
| *** jamesmcarthur_ has joined #openstack-keystone | 18:03 | |
| *** jamesmcarthur has quit IRC | 18:06 | |
| *** jamesmcarthur has joined #openstack-keystone | 18:13 | |
| *** jamesmcarthur_ has quit IRC | 18:14 | |
| *** jamesmcarthur_ has joined #openstack-keystone | 18:24 | |
| *** jamesmcarthur has quit IRC | 18:26 | |
| *** jamesmcarthur has joined #openstack-keystone | 18:28 | |
| *** jamesmcarthur_ has quit IRC | 18:30 | |
| *** jamesmcarthur_ has joined #openstack-keystone | 18:34 | |
| *** jamesmca_ has joined #openstack-keystone | 18:36 | |
| *** jamesmcarthur has quit IRC | 18:36 | |
| *** jamesmcarthur_ has quit IRC | 18:39 | |
| *** jamesmca_ has quit IRC | 18:41 | |
| *** jamesmcarthur has joined #openstack-keystone | 18:46 | |
| *** jamesmcarthur_ has joined #openstack-keystone | 18:48 | |
| *** spsurya has quit IRC | 18:49 | |
| *** jamesmcarthur has quit IRC | 18:50 | |
| *** jamesmcarthur has joined #openstack-keystone | 18:53 | |
| *** jamesmcarthur_ has quit IRC | 18:55 | |
| *** jamesmcarthur has quit IRC | 19:01 | |
| *** jamesmcarthur_ has joined #openstack-keystone | 19:01 | |
| *** jamesmcarthur_ has quit IRC | 19:06 | |
| *** jamesmcarthur has joined #openstack-keystone | 19:12 | |
| openstackgerrit | Colleen Murphy proposed openstack/oslo.policy master: Add attribute to suppress deprecation warnings https://review.opendev.org/673932 | 19:13 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Suppress policy deprecation warnings in unit tests https://review.opendev.org/673933 | 19:13 |
| *** jamesmcarthur has quit IRC | 19:17 | |
| *** jamesmcarthur has joined #openstack-keystone | 19:19 | |
| *** jamesmcarthur has quit IRC | 19:24 | |
| kmalloc | cmurphy: commnented on ^ those two | 19:25 |
| kmalloc | cmurphy: is the .zuul change expected in the keystone patch? | 19:25 |
| cmurphy | kmalloc: it's needed to test the oslo change, will W-1 this ps and undo it on the next one | 19:26 |
| kmalloc | ++ | 19:26 |
| kmalloc | wfm | 19:27 |
| cmurphy | re attribute naming it's only for deprecation warnings, let me fix the name | 19:27 |
| kmalloc | also wfm, still +2 on the oslo.policy change. | 19:27 |
| kmalloc | don't forget to bump the minimum on oslo.policy once we do a release :) | 19:28 |
| cmurphy | may actually need to do that release before we can merge the keystone change | 19:28 |
| bnemec | Yep. | 19:29 |
| bnemec | I can wait the weekly Oslo releases on it if that would help. | 19:30 |
| bnemec | I don't think a lot merged last week anyway, just looking through the IRC logs. | 19:30 |
| bnemec | Also, commented on the policy change. | 19:30 |
| *** jamesmcarthur has joined #openstack-keystone | 19:31 | |
| * bnemec is paranoid about adding public things that can be misused | 19:31 | |
| cmurphy | i'd have to think for a minute what the test fixture would look like to set the private attribute | 19:32 |
| openstackgerrit | Colleen Murphy proposed openstack/oslo.policy master: Add attribute to suppress deprecation warnings https://review.opendev.org/673932 | 19:35 |
| *** jamesmcarthur_ has joined #openstack-keystone | 19:36 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Suppress policy deprecation warnings in unit tests https://review.opendev.org/673933 | 19:37 |
| bnemec | It might be as simple as just setting the private member on the Enforcer class in setUp. | 19:37 |
| *** jamesmcarthur has quit IRC | 19:37 | |
| bnemec | I guess it could be done as a followup, but once the public member is added it would be a breaking change to make it private. | 19:38 |
| *** jamesmcarthur has joined #openstack-keystone | 19:38 | |
| kmalloc | even in tests i don't want to have projects lean on a private attribute | 19:39 |
| bnemec | They wouldn't, the fixture would provide a stable public interface to it. | 19:39 |
| kmalloc | hmm. weould need to become a class-level attr then... i think | 19:40 |
| bnemec | Technically I guess the fixture could also be used in runtime code, but that would go against common practice in OpenStack. | 19:40 |
| *** jamesmcarthur_ has quit IRC | 19:40 | |
| bnemec | Oh, hmm, I thought it already was, but I was thinking of suppress_deprecation_warnings in https://review.opendev.org/#/c/673933/8/keystone/common/rbac_enforcer/enforcer.py | 19:40 |
| kmalloc | it is class level, but i'd want to avoid a self.XXXX reference instead lean directly on class lookup | 19:41 |
| kmalloc | if we are doing it as a private+fixture | 19:41 |
| kmalloc | the enforcer is used... oddly at times | 19:42 |
| kmalloc | *shrug* | 19:43 |
| bnemec | Yeah, I don't want to be too pedantic about this. It's Python, so no matter what we do someone _could_ misuse it if they try hard enough. | 19:43 |
| kmalloc | honestly, i just don't care as long as we eliminate these log lines for tests. | 19:43 |
| bnemec | I'm +2 on it as-is, so it's kind of a moot point. :-) | 19:44 |
| kmalloc | :) | 19:44 |
| *** kplant has quit IRC | 19:47 | |
| *** jamesmcarthur has quit IRC | 19:48 | |
| *** jamesmcarthur has joined #openstack-keystone | 20:27 | |
| *** jamesmcarthur has quit IRC | 20:47 | |
| *** jamesmcarthur has joined #openstack-keystone | 20:48 | |
| *** jamesmcarthur has quit IRC | 20:48 | |
| *** jamesmcarthur has joined #openstack-keystone | 20:48 | |
| *** vishalmanchanda has quit IRC | 21:03 | |
| *** jamesmcarthur has quit IRC | 21:18 | |
| *** jamesmcarthur has joined #openstack-keystone | 21:20 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Suppress policy deprecation warnings in unit tests https://review.opendev.org/673933 | 21:22 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Suppress policy deprecation warnings in unit tests https://review.opendev.org/673933 | 21:23 |
| *** jamesmcarthur has quit IRC | 21:25 | |
| *** markvoelker has quit IRC | 21:29 | |
| cmurphy | https://review.opendev.org/673932 should be g2g | 21:32 |
| *** jamesmcarthur has joined #openstack-keystone | 21:49 | |
| *** jamesmcarthur has quit IRC | 21:55 | |
| *** whoami-rajat has quit IRC | 21:58 | |
| *** rcernin has joined #openstack-keystone | 22:06 | |
| cmurphy | not sure if there's a reasonable way to address the actual complaint in https://bugs.launchpad.net/bugs/1836568 the enforcer would have to persist not just to the flask context but the wsgi app itself | 22:14 |
| openstack | Launchpad bug 1836568 in oslo.policy "Logs filled with unnecessary policy deprecation warnings" [Undecided,In progress] - Assigned to Colleen Murphy (krinkle) | 22:14 |
| bnemec | My only thought was to dump a map of deprecated rules to booleans that would indicate whether a warning has been logged into a shared memory space somehow that oslo.policy would check before logging. | 22:19 |
| bnemec | I think that would make it not matter what process the library was running in. | 22:20 |
| bnemec | Although that might be a problem if you had duplicate policy names... | 22:20 |
| kmalloc | bnemec: eh i wouldn't do that. sounds awful | 22:22 |
| bnemec | It's also a bit leaky as we have no way of cleaning up the shared memory, which is basically the same problem we have with lock files for interprocess communication. | 22:22 |
| bnemec | Will this become more of a problem as services migrate to stuff like the scope-based rules? As in every service will be deprecating most/all of their rules and will spam the logs a lot at startup? | 22:24 |
| cmurphy | yep | 22:24 |
| bnemec | Ick | 22:25 |
| cmurphy | what if instead of addressing it directly we try to mitigate it by batching the warnings and emitting it as a single warning instead of one for each policy, and omitting the "As of the Stein release bla bla" explanation | 22:43 |
| bnemec | That might make it easier to dedupe your logs. | 22:45 |
| *** markvoelker has joined #openstack-keystone | 22:46 | |
| *** jamesmcarthur has joined #openstack-keystone | 22:48 | |
| *** tkajinam has joined #openstack-keystone | 22:56 | |
| *** markvoelker has quit IRC | 23:20 | |
| openstackgerrit | Colleen Murphy proposed openstack/oslo.policy master: (WIP) Batch deprecation warnings https://review.opendev.org/674711 | 23:29 |
| cmurphy | maybe like that ^ it doesn't make it that much less noisy without also shrinking the reason but might make it possible to do filtering | 23:30 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!