| *** gyee has quit IRC | 00:53 | |
| *** markvoelker has joined #openstack-keystone | 01:01 | |
| *** markvoelker has quit IRC | 01:05 | |
| *** ayoung has quit IRC | 01:24 | |
| *** dave-mccowan has quit IRC | 01:31 | |
| *** tkajinam has quit IRC | 01:54 | |
| cmurphy | wxy-xiyuan: i am stepping out for a couple of hours, would you mind keeping an eye on https://etherpad.openstack.org/p/keystone-train-feature-freeze-todo and hitting recheck when needed? or ask vishakha when she comes online | 01:57 |
|---|---|---|
| *** tkajinam has joined #openstack-keystone | 02:11 | |
| *** markvoelker has joined #openstack-keystone | 02:26 | |
| *** tkajinam has quit IRC | 02:36 | |
| *** markvoelker has quit IRC | 02:36 | |
| *** markvoelker has joined #openstack-keystone | 02:38 | |
| *** markvoelker has quit IRC | 02:43 | |
| *** tkajinam has joined #openstack-keystone | 02:56 | |
| *** dklyle has quit IRC | 02:57 | |
| *** sapd1 has joined #openstack-keystone | 03:00 | |
| *** dklyle has joined #openstack-keystone | 03:00 | |
| *** Ben78 has quit IRC | 03:05 | |
| *** markvoelker has joined #openstack-keystone | 04:16 | |
| *** markvoelker has quit IRC | 04:21 | |
| openstackgerrit | Merged openstack/keystone master: Implement system admin for implied roles https://review.opendev.org/680796 | 04:33 |
| openstackgerrit | Merged openstack/keystone master: Implement system reader for OAUTH1 consumers https://review.opendev.org/680793 | 04:39 |
| *** pcaruana has joined #openstack-keystone | 05:02 | |
| *** Luzi has joined #openstack-keystone | 05:23 | |
| *** tkajinam has quit IRC | 05:54 | |
| *** tkajinam has joined #openstack-keystone | 06:03 | |
| *** xek has joined #openstack-keystone | 06:03 | |
| *** xek has quit IRC | 06:12 | |
| *** xek has joined #openstack-keystone | 06:13 | |
| *** tkajinam_ has joined #openstack-keystone | 06:19 | |
| *** tkajinam has quit IRC | 06:22 | |
| *** trident has quit IRC | 06:55 | |
| *** xek has quit IRC | 06:56 | |
| *** trident has joined #openstack-keystone | 07:07 | |
| *** Florian has joined #openstack-keystone | 07:10 | |
| *** tesseract has joined #openstack-keystone | 07:15 | |
| openstackgerrit | Ralf Haferkamp proposed openstack/keystone master: Fix PostgreSQL specifc issue with credentials encoding https://review.opendev.org/681736 | 07:17 |
| *** jaosorior has joined #openstack-keystone | 07:35 | |
| *** ivve has joined #openstack-keystone | 08:00 | |
| *** tkajinam_ has quit IRC | 08:01 | |
| *** awalende has joined #openstack-keystone | 08:04 | |
| BlackDex | /part | 08:31 |
| *** BlackDex has left #openstack-keystone | 08:31 | |
| *** markvoelker has joined #openstack-keystone | 08:44 | |
| *** markvoelker has quit IRC | 08:49 | |
| *** jaosorior has quit IRC | 09:00 | |
| *** Florian has quit IRC | 09:19 | |
| *** FlorianFa has joined #openstack-keystone | 09:19 | |
| *** jawad_axd has joined #openstack-keystone | 09:19 | |
| *** ivve has quit IRC | 09:32 | |
| *** tkajinam has joined #openstack-keystone | 10:05 | |
| *** ivve has joined #openstack-keystone | 10:05 | |
| *** pcaruana has quit IRC | 10:11 | |
| openstackgerrit | Merged openstack/keystone master: Implement system reader & member for domain config API https://review.opendev.org/679623 | 10:15 |
| openstackgerrit | Merged openstack/keystone master: Implement system admin for domain config API https://review.opendev.org/679750 | 10:19 |
| openstackgerrit | Merged openstack/keystone master: Add Domain User for security compliance domain config API https://review.opendev.org/679966 | 10:19 |
| openstackgerrit | Merged openstack/keystone master: Add Project User coverage for domain config API https://review.opendev.org/680341 | 10:19 |
| *** awalende has quit IRC | 10:52 | |
| *** awalende has joined #openstack-keystone | 10:53 | |
| *** awalende has quit IRC | 10:54 | |
| *** awalende has joined #openstack-keystone | 10:54 | |
| *** jawad_axd has quit IRC | 10:55 | |
| *** jawad_axd has joined #openstack-keystone | 10:55 | |
| *** pcaruana has joined #openstack-keystone | 11:24 | |
| *** jawad_axd has quit IRC | 11:37 | |
| *** jawad_axd has joined #openstack-keystone | 11:37 | |
| *** zaneb has quit IRC | 11:48 | |
| *** zaneb has joined #openstack-keystone | 11:49 | |
| *** awalende has quit IRC | 12:01 | |
| *** awalende has joined #openstack-keystone | 12:02 | |
| *** markvoelker has joined #openstack-keystone | 12:04 | |
| *** awalende has quit IRC | 12:06 | |
| *** awalende has joined #openstack-keystone | 12:09 | |
| *** tbarron has joined #openstack-keystone | 12:12 | |
| *** tkajinam has quit IRC | 12:25 | |
| *** jaosorior has joined #openstack-keystone | 12:27 | |
| *** jawad_ax_ has joined #openstack-keystone | 12:38 | |
| *** jawad_axd has quit IRC | 12:41 | |
| *** Luzi has quit IRC | 13:06 | |
| *** jawad_ax_ has quit IRC | 13:18 | |
| *** jawad_axd has joined #openstack-keystone | 13:19 | |
| *** jawad_ax_ has joined #openstack-keystone | 13:22 | |
| *** jawad_axd has quit IRC | 13:24 | |
| *** jaosorior has quit IRC | 13:26 | |
| *** jawad_ax_ has quit IRC | 13:28 | |
| *** jawad_axd has joined #openstack-keystone | 13:29 | |
| *** jawad_axd has quit IRC | 13:33 | |
| lbragstad | looks like we cut our feature freeze list in half | 13:46 |
| lbragstad | everything for system-scope + default roles is in the gate | 13:46 |
| lbragstad | except https://review.opendev.org/645968 | 13:47 |
| lbragstad | https://review.opendev.org/667730 | 13:47 |
| lbragstad | https://review.opendev.org/667731 | 13:47 |
| lbragstad | if folks could review those ^ they're pretty trivial | 13:47 |
| lbragstad | all the resource options stuff is still waiting to be verified | 13:47 |
| lbragstad | access rules need to be reviewed, too https://review.opendev.org/#/c/668238/ | 13:48 |
| lbragstad | but both dependent patches on ^ have been +2'd and +W'd so just the first one really needs some eyes | 13:48 |
| openstackgerrit | Merged openstack/keystone master: Implement resource options for roles and projects https://review.opendev.org/678322 | 13:49 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Make system tokens work with domain-specific drivers https://review.opendev.org/681833 | 13:56 |
| *** raildo has joined #openstack-keystone | 14:08 | |
| *** xek has joined #openstack-keystone | 14:32 | |
| *** xek_ has joined #openstack-keystone | 14:35 | |
| *** xek has quit IRC | 14:37 | |
| *** rcernin has quit IRC | 14:42 | |
| *** Ben78 has joined #openstack-keystone | 14:51 | |
| *** cp- has quit IRC | 15:12 | |
| *** awalende has quit IRC | 15:13 | |
| *** awalende has joined #openstack-keystone | 15:13 | |
| *** jamesmcarthur has joined #openstack-keystone | 15:15 | |
| *** cp- has joined #openstack-keystone | 15:17 | |
| *** awalende_ has joined #openstack-keystone | 15:18 | |
| *** awalende has quit IRC | 15:18 | |
| openstackgerrit | Merged openstack/keystone master: Remove implied roles policies from v3cloudsample https://review.opendev.org/680797 | 15:20 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Remove system Domain Config from policy.v3cloudsample.json https://review.opendev.org/680357 | 15:22 |
| *** awalende_ has quit IRC | 15:23 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Implement system scope for domain role management https://review.opendev.org/680844 | 15:23 |
| *** tesseract has quit IRC | 15:25 | |
| *** ivve has quit IRC | 15:29 | |
| *** dklyle has quit IRC | 15:35 | |
| *** dklyle has joined #openstack-keystone | 15:36 | |
| lbragstad | anyone want to kick https://review.opendev.org/#/c/645968/16 through? | 16:11 |
| cmurphy | kmalloc: gagehugo ^ | 16:12 |
| lbragstad | the patches dependent on 645968 looks good, too | 16:12 |
| gagehugo | looking | 16:32 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Expose access rules as its own API https://review.opendev.org/668238 | 16:41 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add access rules to token validation https://review.opendev.org/631993 | 16:41 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Update API version for access rules https://review.opendev.org/671374 | 16:41 |
| *** gyee has joined #openstack-keystone | 16:44 | |
| *** markvoelker has quit IRC | 16:45 | |
| *** bnemec is now known as beekneemech | 16:48 | |
| *** markvoelker has joined #openstack-keystone | 16:49 | |
| beekneemech | cmurphy: I found out that https://bugs.launchpad.net/keystone/+bug/1836568 also affects oslopolicy-list-redundant. Would you prefer I open a separate bug for that or just pile on to that one? | 16:49 |
| openstack | Launchpad bug 1836568 in OpenStack Identity (keystone) "Logs filled with unnecessary policy deprecation warnings" [High,In progress] - Assigned to Colleen Murphy (krinkle) | 16:49 |
| cmurphy | beekneemech: if it's the same bug probably makes sense to track it in the same place? | 16:51 |
| *** cmurphy is now known as cmorpheus | 16:51 | |
| beekneemech | My concern was that I think we need to disable the warnings entirely in this tool, so it probably needs a different fix from Keystone proper. | 16:53 |
| *** markvoelker has quit IRC | 16:53 | |
| beekneemech | But I guess we did that for the unit tests too, so that's the same sort of thing. | 16:53 |
| cmorpheus | beekneemech: hmm well i don't have strong feelings either way | 16:54 |
| beekneemech | I'll throw a comment in the original bug and if we decide a separate bug would be good that's easy enough to do. | 16:55 |
| beekneemech | "Timeout error, please try again in a few minutes." | 16:59 |
| * beekneemech shakes his fist at launchpad | 16:59 | |
| beekneemech | I think I'm going to print out a copy of https://vignette.wikia.nocookie.net/disney/images/9/9b/Croppedimage318436-jetmcquackintera.png/revision/latest?cb=20140724152301 that I can throw things at when Launchpad pisses me off. | 17:00 |
| *** xek_ has quit IRC | 17:08 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.policy master: Ignore warnings in oslopolicy-list-redundant https://review.opendev.org/682117 | 17:10 |
| cmorpheus | beekneemech: did you have any issues submitting your forum session? my abstract is only 960 characters but the form is giving me errors about exceeding the 1000 character limit (and then doesn't say by how much) | 17:30 |
| beekneemech | cmorpheus: I had an issue submitting my first one because it kept telling me I had to add speakers, even though I had. | 17:31 |
| beekneemech | That was resolved over last weekend though. | 17:32 |
| cmorpheus | hmm | 17:32 |
| cmorpheus | well removing the etherpad link made it work somehow | 17:33 |
| beekneemech | Seems like their input validation code could use some work. :-) | 17:33 |
| beekneemech | On a semi-related note, I'm rather disturbed how many bugs in oslo.policy I'm finding while working on my demo talk. | 17:35 |
| cmorpheus | it's okay i don't think anyone uses oslo.policy | 17:36 |
| beekneemech | :-P | 17:37 |
| beekneemech | Although that's kind of why I submitted the talk. I'm not sure how many people outside of Keystone and Oslo know these tools exist. | 17:37 |
| lbragstad | ^ | 17:39 |
| lbragstad | to me, oslo.policy is like that old pair of jeans you have that just sit in the closet and when you put them on you find an old crusty $20 in the pocket | 17:39 |
| beekneemech | If I had $20 for every time that has happened... | 17:41 |
| lbragstad | i mean, a $20 is a $20, but it's probably been through the wash a few times and it's still dirty | 17:42 |
| lbragstad | that won't stop you from using it though | 17:42 |
| beekneemech | I generally assume all money is full of disgusting things. If it's been through my wash at least I know it didn't spend last weekend at the strip club. *shudder* | 17:48 |
| *** markvoelker has joined #openstack-keystone | 17:51 | |
| *** jamesmcarthur has quit IRC | 18:26 | |
| *** xek_ has joined #openstack-keystone | 18:54 | |
| *** markvoelker has quit IRC | 19:04 | |
| *** markvoelker has joined #openstack-keystone | 19:06 | |
| *** markvoelker has quit IRC | 19:16 | |
| *** markvoelker has joined #openstack-keystone | 19:17 | |
| *** mriedem has joined #openstack-keystone | 19:52 | |
| mriedem | since clarkb's email i got looking at http://status.openstack.org/elastic-recheck/#1686542 again, | 19:53 |
| mriedem | and it looks like keystone's openstack-tox-lower-constraints job has the most hits | 19:53 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=(message%3A%20%5C%22FAILED%20with%20status%3A%20137%5C%22%20OR%20message%3A%20%5C%22FAILED%20with%20status%3A%20143%5C%22%20OR%20message%3A%20%5C%22RUN%20END%20RESULT_TIMED_OUT%5C%22)%20AND%20NOT%20message%3A%5C%22POST-RUN%20END%20RESULT_TIMED_OUT%5C%22%20AND%20tags%3A%20%5C%22console%5C%22%20AND%20voting%3A1%20AND%20build_queue%3Agate%20AND%20project%3A%5C | 19:54 |
| mriedem | penstack%2Fkeystone%5C%22%20AND%20build_name%3A%5C%22openstack-tox-lower-constraints%5C%22&from=10d | 19:54 |
| mriedem | so might be worth investigating if that job has some really slow tests for some reason, | 19:54 |
| mriedem | or if the job timeout needs to be bumped up? | 19:54 |
| lbragstad | mriedem we've been bumping the timeout | 19:54 |
| lbragstad | it's our api protection tests | 19:54 |
| mriedem | since around 9/10 or 9/11? | 19:54 |
| lbragstad | yeah | 19:54 |
| lbragstad | well - before that | 19:54 |
| lbragstad | but the test coverage has been expanding - resulting in longer run times | 19:55 |
| lbragstad | we have a plan to refactor those tests into their own tox environments and their own job | 19:55 |
| lbragstad | https://review.opendev.org/#/c/680788/ | 19:55 |
| mriedem | it's curious that it's higher on the lower-constraints job than just the py36/py27 jobs | 19:55 |
| cmorpheus | because i missed the lower-constraints job on the first goaround | 19:56 |
| lbragstad | https://review.opendev.org/#/c/681161/ | 19:56 |
| mriedem | ah | 19:56 |
| mriedem | i see a buttload of deprecation warnings in those job logs as well, | 19:57 |
| mriedem | Method 'CORS.set_latent()' has moved to 'method.set_defaults()': | 19:57 |
| mriedem | >1000 times | 19:57 |
| mriedem | that's going to kick the subunit parser failures maybe | 19:57 |
| mriedem | http://status.openstack.org/elastic-recheck/#1813147 | 19:57 |
| lbragstad | https://review.opendev.org/#/c/681621/1 is another bump | 19:57 |
| mriedem | are you still seeing subunit parser failures? | 19:58 |
| cmorpheus | i don't recall seeing that for keystone | 19:58 |
| mriedem | in nova if we don't have an immediate need to fix the deprecation warnings from the other libraries, or they are transitive dep warnings, then we have a warnings filter fixture to only log those once | 19:58 |
| mriedem | note that those console logs also get indexed, every line | 19:59 |
| mriedem | so it's a strain on the ES cluster | 19:59 |
| mriedem | anyway, if you have part time people looking for low hanging fruit, squashing those warnings is easy to do (normally) | 20:03 |
| lbragstad | cmorpheus didn't you have a patch related to that? | 20:03 |
| cmorpheus | mriedem: have an example of the subunit parser failure for keystone? | 20:03 |
| cmorpheus | lbragstad: not that i recall | 20:03 |
| * lbragstad might be thinking of something else | 20:04 | |
| cmorpheus | unless you're talking about the policy warnings | 20:04 |
| mriedem | cmorpheus: i don't see any recent ones in logstash, | 20:04 |
| lbragstad | yeah - maybe that was it | 20:04 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22subunit.parser%5C%22%20AND%20message%3A%5C%22FAILED%5C%22%20AND%20tags%3A%5C%22console%5C%22%20AND%20voting%3A1%20AND%20project%3A%5C%22openstack%2Fkeystone%5C%22&from=7d | 20:04 |
| mriedem | i thought that was something you were looking at a couple of weeks ago but i could be wrong | 20:04 |
| cmorpheus | we were looking at deprecation warnings emitted by oslo.policy but they weren't causing subunit parser failures iirc | 20:05 |
| cmorpheus | https://review.opendev.org/673932 | 20:05 |
| openstackgerrit | Ben Nemec proposed openstack/oslo.policy master: Fix reference cycle caused by deprecated sample override https://review.opendev.org/682150 | 20:10 |
| beekneemech | ^That's kind of icky. | 20:11 |
| beekneemech | Can anyone remind what the purpose of dumping out the "old_rule: rule:new_rule" rules in the sample policy files is? | 20:12 |
| * cmorpheus looks at lbragstad | 20:13 | |
| beekneemech | It seems like if you're generating a new sample policy, your code would already be referencing the new name anyway. | 20:13 |
| cmorpheus | fyi from clarkb https://gist.githubusercontent.com/cboylan/82f43a9c345100efcf155f82d936edf4/raw/9862d29614b9a541c35368971472f50e477d9782/keystone%2520unittest%2520runtimes | 20:15 |
| lbragstad | beekneemech it was for an upgrade case iirc | 20:19 |
| beekneemech | lbragstad: As in you'd generate a sample policy file on Train to use with Stein? | 20:20 |
| beekneemech | Oh, would that be for migrating from not-policy-in-code to policy-in-code? | 20:21 |
| beekneemech | Also, this can totally wait until you're all not in feature freeze crunch. I'm just trying to chase down as many of these problems as I can while they're fresh in my mind. | 20:26 |
| *** baffle has quit IRC | 20:42 | |
| openstackgerrit | Merged openstack/keystone master: Implement domain reader support for grants https://review.opendev.org/645968 | 20:43 |
| *** baffle has joined #openstack-keystone | 20:49 | |
| cmorpheus | lbragstad: do you have a tldr on why setUpClass and setUpModule weren't right for the protection tests? | 20:50 |
| lbragstad | they apparently don't work well with serialization? | 20:50 |
| lbragstad | clarkb had to explain it to me | 20:51 |
| *** openstackgerrit has quit IRC | 20:51 | |
| *** mriedem has left #openstack-keystone | 20:54 | |
| *** openstackgerrit has joined #openstack-keystone | 20:54 | |
| openstackgerrit | Merged openstack/keystone master: Implement domain admin support for grants https://review.opendev.org/667730 | 20:54 |
| lbragstad | last one for grants https://review.opendev.org/#/c/667731/ | 20:56 |
| lbragstad | needs some review love though | 20:56 |
| *** markvoelker has quit IRC | 20:57 | |
| lbragstad | cmorpheus kmalloc was in that discussion, too | 20:59 |
| lbragstad | i believe we were talking about it in this channel | 20:59 |
| lbragstad | just not exactly sure when we had that discussion, i just know it was before i started chasing the whole testresources approach | 21:00 |
| cmorpheus | lbragstad: yeah i was hoping someone had a tldr from memory so i didn't have to do archeology in my logs | 21:00 |
| * lbragstad wishes http://eavesdrop.openstack.org/irclogs/ had a built in grep feature | 21:01 | |
| lbragstad | cmorpheus boom http://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2019-05-31.log.html#t2019-05-31T23:21:56 | 21:02 |
| *** pcaruana has quit IRC | 21:03 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Remove obsolete grant policies from policy.v3cloudsample.json https://review.opendev.org/667731 | 21:04 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Alphabetize removed policies in tests https://review.opendev.org/682163 | 21:04 |
| cmorpheus | that's a little vague but sounds like i don't want to go down that rabbithole | 21:05 |
| cmorpheus | please review https://review.opendev.org/682163 so we can stop wasting resources on rebasing the v3cloudsample things | 21:06 |
| lbragstad | fwiw - we can get rid of that test once we remove policy.v3cloudsample.json completely | 21:12 |
| lbragstad | iirc | 21:12 |
| *** raildo has quit IRC | 21:13 | |
| *** Ben78 has quit IRC | 21:20 | |
| *** xek_ has quit IRC | 21:46 | |
| *** xek has joined #openstack-keystone | 21:47 | |
| *** xek has quit IRC | 21:49 | |
| *** xek has joined #openstack-keystone | 21:49 | |
| *** xek_ has joined #openstack-keystone | 21:52 | |
| *** xek has quit IRC | 21:55 | |
| *** markvoelker has joined #openstack-keystone | 22:09 | |
| *** markvoelker has quit IRC | 22:14 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Implement system admin for OAUTH1 consumers https://review.opendev.org/680794 | 22:26 |
| *** xek_ has quit IRC | 22:59 | |
| *** gyee has quit IRC | 23:32 | |
| *** gyee has joined #openstack-keystone | 23:35 | |
| *** gyee has quit IRC | 23:51 | |
| *** rcernin has joined #openstack-keystone | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
