| *** mhen_ is now known as mhen | 01:28 | |
| mhen | Hi. I'm currently trying to check protection and unit tests for my domain manager implementation. Are protection tests known to be broken on current master? | 11:15 |
|---|---|---|
| mhen | For example, this reference does not seem to resolve: https://github.com/openstack/keystone/blob/master/keystone/tests/protection/v3/test_application_credential.py#L104 | 11:16 |
| mhen | This "RULE_SYSTEM_READER_OR_OWNER" does not seem to be defined anywhere. | 11:16 |
| gtema | mhen, tests are not broken, since they executed and pass. I agree it is weird there is code like that. I assume this is something very old which is not invoked and as such does not fail (long live the type check) | 14:14 |
| mhen | It is invoked (and fails) if I try to run the protection tests locally using "tox -e protection". | 14:15 |
| gtema | oh sorry, I swapped the zeroes | 14:16 |
| gtema | https://838e8809c9c087f1d2df-d66d94e8460be82c507ecb0f70cc3225.ssl.cf2.rackcdn.com/923749/1/check/keystone-protection-functional/739c7f9/testr_results.html | 14:17 |
| gtema | that is one random result from one of the last changes | 14:17 |
| gtema | it shows some tests which apparently come from tempest plugin | 14:17 |
| gtema | and most likely I misinterpreted the same name "protection" | 14:18 |
| mhen | yes, that is using the tempest plugin (a different repo and entirely different tests) | 14:18 |
| gtema | so right, tox -e protection is not being executed and fails | 14:18 |
| mhen | so, those tests are unmaintained and I should look at the tempest plugin instead I guess? | 14:19 |
| gtema | most likely yes | 14:19 |
| gtema | we can probably discuss that topic tomorrow in reviewaton | 14:19 |
| mhen | ftr, 304 out of 1879 protection unit tests are failing for me locally on an unmodified copy of current master | 15:13 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Add pre-commit https://review.opendev.org/c/openstack/keystone/+/923991 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Fix bindep for py312 job https://review.opendev.org/c/openstack/keystone/+/923992 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.auth https://review.opendev.org/c/openstack/keystone/+/923993 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.credential https://review.opendev.org/c/openstack/keystone/+/923994 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.application_credential https://review.opendev.org/c/openstack/keystone/+/923995 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.application_catalog https://review.opendev.org/c/openstack/keystone/+/923996 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.identity https://review.opendev.org/c/openstack/keystone/+/923997 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.oauth https://review.opendev.org/c/openstack/keystone/+/923998 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.federation https://review.opendev.org/c/openstack/keystone/+/923999 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.role https://review.opendev.org/c/openstack/keystone/+/924000 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.resource https://review.opendev.org/c/openstack/keystone/+/924001 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.limit https://review.opendev.org/c/openstack/keystone/+/924002 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.api remains https://review.opendev.org/c/openstack/keystone/+/924003 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.server https://review.opendev.org/c/openstack/keystone/+/924004 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.cmd https://review.opendev.org/c/openstack/keystone/+/924005 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.common https://review.opendev.org/c/openstack/keystone/+/924006 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify keystone.protection tests https://review.opendev.org/c/openstack/keystone/+/924007 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Blackify everything else https://review.opendev.org/c/openstack/keystone/+/924008 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Enable black in pre-commit https://review.opendev.org/c/openstack/keystone/+/924009 | 19:44 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Enable pyupgrade https://review.opendev.org/c/openstack/keystone/+/924010 | 19:44 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!