| *** __ministry is now known as Guest1303 | 01:06 | |
| *** mhen_ is now known as mhen | 02:18 | |
| *** __ministry is now known as Guest1320 | 04:10 | |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Enable projects and domains pagination https://review.opendev.org/c/openstack/keystone/+/933598 | 09:30 |
|---|---|---|
| opendevreview | Artem Goncharov proposed openstack/keystone master: Enable projects and domains pagination https://review.opendev.org/c/openstack/keystone/+/933598 | 11:05 |
| stephenfin | frickler: Sorry, I only got to look at that now. I did a bisect and this commit is the issue: https://github.com/openstack/keystoneauth/commit/2ab36152059a42028d69eb710de1f6298676dd43 | 11:45 |
| stephenfin | frickler: The root cause is a change in behavior in the system_scoped property. Previously that would return True or None. Now it returns True or False. You can prove this by applying the following patch, then the test starts passing https://paste.openstack.org/show/bto711b8zHSVi1dmsABF/ | 12:01 |
| stephenfin | frickler: IMO the "new" behavior is correct and the fix lies in Horizon. I'll submit a patch to update that. CC: gtema | 12:02 |
| stephenfin | PS: you can run tests with 'pytest openstack_auth --ds=openstack_auth.tests.settings -v' if you wanted to verify that patch yourself | 12:03 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Enable projects and domains pagination https://review.opendev.org/c/openstack/keystone/+/933598 | 12:05 |
| frickler | stephenfin: thx for looking into this. it also reminds me that an u-c bump for pytest is also pending due to horizon | 12:10 |
| stephenfin | frickler: https://review.opendev.org/c/openstack/horizon/+/936454 | 13:39 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Enable projects and domains pagination https://review.opendev.org/c/openstack/keystone/+/933598 | 14:14 |
| frickler | stephenfin: that looks worse than I expected, thx for the link and the patch | 14:21 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!