| *** elodilles_pto is now known as elodilles | 07:52 | |
| opendevreview | Yushiro Furukawa proposed openstack/keystone master: Avoid refetching credentials in list API https://review.opendev.org/c/openstack/keystone/+/996623 | 09:27 |
|---|---|---|
| opendevreview | Artem Goncharov proposed openstack/keystone master: [DNM] Debug failing job https://review.opendev.org/c/openstack/keystone/+/996625 | 09:58 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: [DNM] Debug failing job https://review.opendev.org/c/openstack/keystone/+/996625 | 14:30 |
| zigo | What's Artem Goncharov 's nick ? | 14:40 |
| zigo | artem: In here: https://review.opendev.org/c/openstack/keystone/+/931959/7/keystone/common/sql/migrations/versions/27e647c0fad4_initial_version.py | 14:40 |
| zigo | you've switched to an f string. The result is that now, we can't use dashes in the db name: it's not escaped or something... | 14:40 |
| zigo | (that's what my colleague says) | 14:40 |
| gtema | it's gtema | 14:41 |
| zigo | Ah, thanks ! :) | 14:41 |
| gtema | this conversion was done automatically by ruff | 14:41 |
| zigo | Do you think my colleagues are right? | 14:41 |
| zigo | I think they are wrong, I don't see why using %s would magically add `` escape chars. | 14:42 |
| gtema | should not be the case, I don't know any potential issue with this | 14:42 |
| gtema | >>> db = "a-b.c_d@e" | 14:43 |
| gtema | >>> print(f"this is the result: {db}") | 14:43 |
| gtema | this is the result: a-b.c_d@e | 14:43 |
| zigo | Right. | 14:43 |
| zigo | Anyways, using a dash in the db name isn't working ! :) | 14:44 |
| gtema | maybe there are some unicode chars that have issues. Not even the "'" in the url is causing issue for my tiny test | 14:45 |
| zigo | Ok. | 14:51 |
| gmaan | gtema: for keystone-protection-functional job failure, this is fix? https://review.opendev.org/c/openstack/keystone/+/996623 | 18:19 |
| gtema | this in one of the possibilities, but I do not get why this change passed k2k job which fails on other changes | 18:20 |
| gtema | not k2k - oidc-federation fails on other changes (e.g. https://review.opendev.org/c/openstack/keystone/+/996625) and I am absolutely not able to explain this failure. It's poltergeist | 18:23 |
| -Guest12850- NOTICE: The Gerrit service on review.opendev.org will be offline briefly one hour from now, at 21:00 UTC, while we rename a project. | 20:01 | |
| -Guest12850- NOTICE: The Gerrit service on review.opendev.org is going offline momentarily at 21:00 UTC while we rename a project, but will return within a few minutes. | 20:59 | |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!