| *** mhen_ is now known as mhen | 03:04 | |
| opendevreview | Grzegorz Grasza proposed openstack/keystone master: Allow domain-scoped tokens to manage own application credentials https://review.opendev.org/c/openstack/keystone/+/1014733 | 11:24 |
|---|---|---|
| opendevreview | Thomas Goirand proposed openstack/keystone master: Run dummy password check on early auth failures https://review.opendev.org/c/openstack/keystone/+/1014736 | 12:37 |
| opendevreview | Grzegorz Grasza proposed openstack/keystone-tempest-plugin master: Expect 403 for project admin on other users' application credentials https://review.opendev.org/c/openstack/keystone-tempest-plugin/+/1014738 | 12:50 |
| opendevreview | Grzegorz Grasza proposed openstack/keystone master: Allow domain-scoped tokens to manage own application credentials https://review.opendev.org/c/openstack/keystone/+/1014733 | 13:13 |
| opendevreview | Grzegorz Grasza proposed openstack/keystone-tempest-plugin master: Expect 403 for project admin on other users' application credentials https://review.opendev.org/c/openstack/keystone-tempest-plugin/+/1014738 | 13:18 |
| opendevreview | Grzegorz Grasza proposed openstack/keystone-tempest-plugin master: Expect 403 for project admin on other users' application credentials https://review.opendev.org/c/openstack/keystone-tempest-plugin/+/1014738 | 13:19 |
| opendevreview | Grzegorz Grasza proposed openstack/keystone master: Allow domain-scoped tokens to manage own application credentials https://review.opendev.org/c/openstack/keystone/+/1014733 | 13:36 |
| opendevreview | Thomas Goirand proposed openstack/keystone master: Run dummy password check on early auth failures https://review.opendev.org/c/openstack/keystone/+/1014736 | 15:47 |
| zigo | gtema: Hi. Do you agree with my idea ? ^ | 15:47 |
| gtema | zigo - yes, this is something what rs project does since the beginning. However just doing it for password is not sufficient - same need to be done for appcreds (or everywhere where secret hashing is done). I didn't review you change in detail though - just confirming this is something what needs to be done | 15:50 |
| opendevreview | Thomas Goirand proposed openstack/keystone master: Run dummy secret check on early auth failures https://review.opendev.org/c/openstack/keystone/+/1014736 | 16:44 |
| zigo | gtema: Better now? :) | 16:44 |
| zigo | In a few places, I also switched from 404 to 401 to avoid the same issue as in 2018. | 16:44 |
| gtema | yes, but I would still need to review it deeper for corner cases. Usually you may want to use random passwords in such cases since it is a user-controlled secret. Also need to check all "raise" places to capture from where, under which condition and which exception can be thrown | 16:46 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!