*** daneyon has quit IRC | 00:01 | |
*** The_Ball has joined #openstack-kolla | 00:04 | |
*** ravig has quit IRC | 00:07 | |
*** ravig has joined #openstack-kolla | 00:07 | |
*** ravig has quit IRC | 00:11 | |
*** ravig has joined #openstack-kolla | 00:11 | |
*** rhallisey has quit IRC | 00:12 | |
Daviey | sdake: Hey, this is the version stuff i was talking about - https://github.com/Daviey/tmp-kolla-version | 00:13 |
---|---|---|
Daviey | standalone example | 00:13 |
Daviey | Mech422: That isn't monitoring the grafana stuff.. that is utilization stuff isn't it? | 00:14 |
Daviey | Mech422: I only care about, "is stuff working".. that other branch is "how hard is it working?" | 00:14 |
Daviey | Unless i am mistaken? | 00:14 |
*** jruano has joined #openstack-kolla | 00:24 | |
*** david-lyle_ has joined #openstack-kolla | 00:27 | |
*** david-lyle_ has quit IRC | 00:31 | |
*** sdake has quit IRC | 00:36 | |
*** ravig has quit IRC | 00:52 | |
*** ravig has joined #openstack-kolla | 00:58 | |
*** banix has joined #openstack-kolla | 00:59 | |
*** sdake has joined #openstack-kolla | 01:01 | |
*** daneyon_ has quit IRC | 01:06 | |
*** jruano has quit IRC | 01:08 | |
*** jruano has joined #openstack-kolla | 01:10 | |
*** jruano has quit IRC | 01:12 | |
*** jruano has joined #openstack-kolla | 01:22 | |
*** jruano has quit IRC | 01:25 | |
*** Jeffrey4l_ has joined #openstack-kolla | 01:30 | |
*** unicell has quit IRC | 01:31 | |
*** sdake_ has joined #openstack-kolla | 01:33 | |
*** sdake has quit IRC | 01:36 | |
*** banix has quit IRC | 02:02 | |
*** jruano has joined #openstack-kolla | 02:07 | |
*** Jeffrey4l_ has quit IRC | 02:07 | |
*** harlowja_at_home has quit IRC | 02:09 | |
*** daneyon has joined #openstack-kolla | 02:23 | |
*** JianqingJiang has joined #openstack-kolla | 02:25 | |
*** sdake has joined #openstack-kolla | 02:26 | |
*** sdake_ has quit IRC | 02:27 | |
*** daneyon has quit IRC | 02:28 | |
*** david-lyle_ has joined #openstack-kolla | 02:29 | |
*** bootsha has joined #openstack-kolla | 02:30 | |
*** david-lyle_ has quit IRC | 02:33 | |
*** bootsha has quit IRC | 02:34 | |
*** sdake has quit IRC | 02:38 | |
openstackgerrit | qinchunhua proposed openstack/kolla: Python 3: dict.iteritems() https://review.openstack.org/346294 | 02:49 |
openstackgerrit | qinchunhua proposed openstack/kolla: Python 3: dict.iteritems() https://review.openstack.org/346294 | 02:50 |
*** jruano has quit IRC | 02:53 | |
*** Jeffrey4l_ has joined #openstack-kolla | 02:59 | |
*** ravig has quit IRC | 02:59 | |
*** ravig has joined #openstack-kolla | 03:00 | |
*** godleon has joined #openstack-kolla | 03:21 | |
*** ravig has quit IRC | 03:27 | |
*** bootsha has joined #openstack-kolla | 03:31 | |
*** bootsha has quit IRC | 03:35 | |
*** ravig has joined #openstack-kolla | 03:43 | |
*** ravig has quit IRC | 03:51 | |
*** ravig has joined #openstack-kolla | 03:53 | |
*** sdake has joined #openstack-kolla | 03:55 | |
*** ravig has quit IRC | 03:57 | |
*** ravig has joined #openstack-kolla | 03:58 | |
*** sdake has quit IRC | 04:20 | |
*** JianqingJiang has quit IRC | 04:26 | |
*** ravig has quit IRC | 04:27 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/kolla: Customizations for aodh https://review.openstack.org/346299 | 04:29 |
*** salv-orlando has quit IRC | 04:31 | |
*** bootsha has joined #openstack-kolla | 04:31 | |
*** bootsha has quit IRC | 04:36 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/kolla: Customizations for gnocchi https://review.openstack.org/346300 | 04:41 |
*** bootsha has joined #openstack-kolla | 04:59 | |
*** bootsha has quit IRC | 05:03 | |
*** zhubingbing has joined #openstack-kolla | 05:16 | |
*** unicell has joined #openstack-kolla | 05:22 | |
*** salv-orlando has joined #openstack-kolla | 05:28 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/kolla: Customizations for aodh https://review.openstack.org/346299 | 05:31 |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/kolla: Customizations for aodh https://review.openstack.org/346299 | 05:33 |
*** salv-orlando has quit IRC | 05:34 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/kolla: Customizations for gnocchi https://review.openstack.org/346300 | 05:37 |
*** ravig has joined #openstack-kolla | 05:45 | |
Mech422 | Daviey: mewald's stuff includes more then just grafana | 05:49 |
Mech422 | Daviey: I _think_ he has an monitoring component in there as well | 05:50 |
Mech422 | Daviey: or rather, I think telegraf can generate 'alert' type events | 05:51 |
Mech422 | Daviey: oh - my bad, Kapacitor handles the alerting - he didn't merge Kapacitor | 05:51 |
*** godleon has quit IRC | 05:59 | |
*** unicell has quit IRC | 06:05 | |
zhubingbing | hello all | 06:07 |
zhubingbing | i have I have a few questions to ask | 06:08 |
zhubingbing | I would like to contribute to the kolla code, but do not know how to start? Can you give me an example or a direction to let me go | 06:09 |
zhubingbing | example write role? | 06:09 |
*** unicell has joined #openstack-kolla | 06:21 | |
*** ravig has quit IRC | 06:29 | |
*** salv-orlando has joined #openstack-kolla | 06:30 | |
*** salv-orlando has quit IRC | 06:35 | |
*** ravig has joined #openstack-kolla | 06:39 | |
*** ravig has quit IRC | 06:46 | |
*** ravig has joined #openstack-kolla | 06:47 | |
*** daneyon has joined #openstack-kolla | 06:54 | |
*** daneyon has quit IRC | 06:58 | |
*** harlowja_at_home has joined #openstack-kolla | 07:05 | |
*** zhubingbing has quit IRC | 07:27 | |
*** godleon has joined #openstack-kolla | 07:29 | |
*** harlowja_at_home has quit IRC | 07:29 | |
*** salv-orlando has joined #openstack-kolla | 07:31 | |
*** david-lyle_ has joined #openstack-kolla | 07:34 | |
*** salv-orlando has quit IRC | 07:36 | |
*** david-lyle_ has quit IRC | 07:39 | |
*** ravig has quit IRC | 07:49 | |
*** ravig has joined #openstack-kolla | 07:49 | |
*** coolsvap has quit IRC | 07:51 | |
*** ravig has quit IRC | 07:52 | |
*** ravig has joined #openstack-kolla | 07:52 | |
*** mewald has joined #openstack-kolla | 08:02 | |
mewald | good morning, I have this pep8 error from Jenkins. I don't know what this is about or where to find it. Can anybody help? https://review.openstack.org/#/c/345938/ | 08:09 |
patchbot | mewald: patch 345938 - kolla - Implement Basic Performance Monitoring | 08:09 |
*** unicell1 has joined #openstack-kolla | 08:15 | |
*** unicell has quit IRC | 08:16 | |
*** ravig has quit IRC | 08:20 | |
*** ravig has joined #openstack-kolla | 08:24 | |
*** sdake has joined #openstack-kolla | 08:30 | |
*** salv-orlando has joined #openstack-kolla | 08:32 | |
*** sdake has quit IRC | 08:32 | |
*** salv-orlando has quit IRC | 08:37 | |
*** daneyon has joined #openstack-kolla | 08:42 | |
*** ravig has quit IRC | 08:43 | |
*** ravig has joined #openstack-kolla | 08:44 | |
*** bdaca has joined #openstack-kolla | 08:46 | |
*** daneyon has quit IRC | 08:46 | |
*** ravig has quit IRC | 09:01 | |
*** ravig has joined #openstack-kolla | 09:02 | |
*** ravig has quit IRC | 09:04 | |
*** coolsvap has joined #openstack-kolla | 09:15 | |
*** ravig has joined #openstack-kolla | 09:18 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/kolla: Customizations for murano https://review.openstack.org/346340 | 09:23 |
*** salv-orlando has joined #openstack-kolla | 09:33 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/kolla: Customizations for trove https://review.openstack.org/346342 | 09:36 |
*** david-lyle_ has joined #openstack-kolla | 09:36 | |
*** tyrola has joined #openstack-kolla | 09:38 | |
*** salv-orlando has quit IRC | 09:38 | |
*** tyrola has quit IRC | 09:40 | |
*** david-lyle_ has quit IRC | 09:41 | |
*** dwalsh has joined #openstack-kolla | 09:53 | |
*** dwalsh_ has joined #openstack-kolla | 09:53 | |
openstackgerrit | Mathias proposed openstack/kolla: Implement Basic Performance Monitoring https://review.openstack.org/345938 | 09:54 |
Daviey | Mech422: I have no issue with dropping my stuff.. I have it working locally, but it will take about a day to clean it up. If I can claw that day back, i'm also happy. | 09:56 |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/kolla: Customizations for trove https://review.openstack.org/346342 | 10:08 |
*** Jeffrey4l_ has quit IRC | 10:13 | |
*** ravig has quit IRC | 10:24 | |
*** ravig has joined #openstack-kolla | 10:24 | |
*** ravig has quit IRC | 10:31 | |
*** ravig has joined #openstack-kolla | 10:31 | |
*** salv-orlando has joined #openstack-kolla | 10:35 | |
*** salv-orlando has quit IRC | 10:39 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/kolla: Customizations for zaqar https://review.openstack.org/346357 | 10:40 |
*** ravig has quit IRC | 10:43 | |
*** ravig has joined #openstack-kolla | 10:44 | |
*** Jeffrey4l_ has joined #openstack-kolla | 10:44 | |
*** mbound has joined #openstack-kolla | 10:48 | |
*** Jeffrey4l_ has quit IRC | 10:55 | |
*** mbound has quit IRC | 10:57 | |
*** ravig has quit IRC | 11:03 | |
*** dwalsh_ has quit IRC | 11:11 | |
*** dwalsh has quit IRC | 11:11 | |
*** JianqingJiang has joined #openstack-kolla | 11:28 | |
*** salv-orlando has joined #openstack-kolla | 11:36 | |
*** The_Ball has quit IRC | 11:36 | |
*** Jeffrey4l has joined #openstack-kolla | 11:37 | |
*** david-lyle_ has joined #openstack-kolla | 11:38 | |
*** JianqingJiang has quit IRC | 11:41 | |
*** salv-orlando has quit IRC | 11:42 | |
*** david-lyle_ has quit IRC | 11:43 | |
*** Jeffrey4l has quit IRC | 11:47 | |
*** Jeffrey4l has joined #openstack-kolla | 11:50 | |
*** godleon has quit IRC | 11:59 | |
*** Jeffrey4l has quit IRC | 12:14 | |
*** dave-mccowan has joined #openstack-kolla | 12:18 | |
*** dave-mcc_ has joined #openstack-kolla | 12:22 | |
*** dave-mccowan has quit IRC | 12:24 | |
openstackgerrit | Merged openstack/kolla: Add Watcher ansible roles and templates https://review.openstack.org/337556 | 12:35 |
*** rhallisey has joined #openstack-kolla | 12:36 | |
*** salv-orlando has joined #openstack-kolla | 12:38 | |
*** ravig has joined #openstack-kolla | 12:43 | |
*** salv-orlando has quit IRC | 12:44 | |
*** Jeffrey4l has joined #openstack-kolla | 12:56 | |
*** bdaca has quit IRC | 13:24 | |
*** ravig has quit IRC | 13:27 | |
*** salv-orlando has joined #openstack-kolla | 13:40 | |
*** coolsvap has quit IRC | 13:41 | |
*** salv-orlando has quit IRC | 13:45 | |
*** britthouser has joined #openstack-kolla | 13:49 | |
*** britthouser has quit IRC | 13:54 | |
*** Jeffrey4l has quit IRC | 14:12 | |
*** Jeffrey4l has joined #openstack-kolla | 14:13 | |
*** dave-mccowan has joined #openstack-kolla | 14:20 | |
openstackgerrit | Ryan Hallisey proposed openstack/kolla: Enable kolla k8s to override bind api bind address in genconfig https://review.openstack.org/327925 | 14:21 |
openstackgerrit | Ryan Hallisey proposed openstack/kolla: Fix interface address for memcached atop kubernetes https://review.openstack.org/327987 | 14:22 |
mewald | How to I split my commit into multiple commits with git? The comments in https://review.openstack.org/#/c/345938/ suggest to split if up, but I don't know how to do it easily | 14:22 |
patchbot | mewald: patch 345938 - kolla - Implement Basic Performance Monitoring | 14:22 |
openstackgerrit | Ryan Hallisey proposed openstack/kolla: Horizon interface address and memcached override https://review.openstack.org/330828 | 14:22 |
openstackgerrit | Ryan Hallisey proposed openstack/kolla: Glance interface address, memcached override, and glance override. https://review.openstack.org/332481 | 14:23 |
*** dave-mcc_ has quit IRC | 14:23 | |
*** ravig has joined #openstack-kolla | 14:28 | |
openstackgerrit | Ryan Hallisey proposed openstack/kolla: Horizon interface address and memcached override https://review.openstack.org/330828 | 14:32 |
openstackgerrit | Ryan Hallisey proposed openstack/kolla: Fix interface address for Neutron-server https://review.openstack.org/343117 | 14:32 |
openstackgerrit | Ryan Hallisey proposed openstack/kolla: Fix interface address for memcached atop kubernetes https://review.openstack.org/327987 | 14:32 |
openstackgerrit | Ryan Hallisey proposed openstack/kolla: Fix interface address for RabbitMQ and disable cluster for Kubernetes https://review.openstack.org/336751 | 14:32 |
openstackgerrit | Ryan Hallisey proposed openstack/kolla: Glance interface address, memcached override, and glance override. https://review.openstack.org/332481 | 14:32 |
rhallisey | mewald, wow that's a big patch | 14:32 |
*** ravig has quit IRC | 14:32 | |
rhallisey | mewald, make a patch for grafna, influxdb, and telegraf | 14:33 |
rhallisey | mewald, take your commit and reset the changes for the dirs 'ansible/roles/influxdb' and 'ansible/telegraf' | 14:34 |
rhallisey | commit the grafna changes | 14:34 |
rhallisey | then add the influxdb changes and commit them | 14:34 |
rhallisey | then same for telegraf | 14:35 |
mewald | rhallisey: yeah the question was more related to the workflow of how to split the commit into multiple :) But I think I have it under control ^^ | 14:36 |
rhallisey | mewald, ok | 14:36 |
rhallisey | let me know if you need assistance | 14:36 |
openstackgerrit | Mathias proposed openstack/kolla: Added telegraf container https://review.openstack.org/346397 | 14:37 |
openstackgerrit | Mathias proposed openstack/kolla: Add influxdb container https://review.openstack.org/346398 | 14:37 |
openstackgerrit | Mathias proposed openstack/kolla: Added grafana container https://review.openstack.org/346399 | 14:38 |
mewald | rhallisey: thanks for offering :) I got the first 3 commits up for review now. Hope it's ok | 14:38 |
rhallisey | nice | 14:38 |
rhallisey | that's perfect | 14:38 |
rhallisey | that giant patch can be split into liek 6 patches | 14:38 |
rhallisey | good start | 14:39 |
mewald | :) | 14:40 |
mewald | now best would be to commit the ansible patches with a dependency on the respective other I guess | 14:41 |
rhallisey | yes. So cherrypick each specific image on HEAD | 14:42 |
rhallisey | then commit the ansible patch over that | 14:42 |
*** salv-orlando has joined #openstack-kolla | 14:42 | |
mewald | this is where I start needing help ;) | 14:42 |
rhallisey | or you can do them all on top of each other | 14:42 |
rhallisey | ok for example | 14:42 |
rhallisey | https://review.openstack.org/#/c/346397/1 | 14:42 |
patchbot | rhallisey: patch 346397 - kolla - Added telegraf container | 14:42 |
rhallisey | top right hand corner | 14:42 |
rhallisey | under download | 14:42 |
rhallisey | grab the link from cherrypick | 14:43 |
rhallisey | make sure you have a clean kolla directory | 14:43 |
rhallisey | git reset --hard HEAD^^^^^^ | 14:43 |
rhallisey | git pull | 14:43 |
rhallisey | be sure to stash your ansible changes | 14:43 |
rhallisey | before you reset | 14:43 |
mewald | ok done | 14:43 |
mewald | no ansible changes are there atm | 14:44 |
rhallisey | ok | 14:44 |
mewald | I copied everything out of the git directory | 14:44 |
rhallisey | now make the ansible changes for that container (telegraf) | 14:44 |
rhallisey | add those changes, commit, and review them | 14:44 |
mewald | but I run the git fetch first? | 14:45 |
rhallisey | it pull push those changes on top of the container so that when the gate runs it will use both patches | 14:45 |
rhallisey | ok so you have the clean kolla dir | 14:45 |
rhallisey | do the cherrypick from telegraf | 14:45 |
rhallisey | then copy the ansible telegraf changes over from your other fir | 14:46 |
rhallisey | dir | 14:46 |
mewald | should I do this in a branch that I create from clean kolla dir? | 14:47 |
*** salv-orlando has quit IRC | 14:47 | |
mewald | or in the master branch as checkout from github? | 14:48 |
rhallisey | master is good | 14:48 |
openstackgerrit | Jeffrey Zhang proposed openstack/kolla: Simplify the Cinder LVM backend https://review.openstack.org/346400 | 14:49 |
*** jruano has joined #openstack-kolla | 14:50 | |
*** coolsvap has joined #openstack-kolla | 14:53 | |
mewald | rhallisey: something is wrong https://gist.github.com/mewald1/30e475c8e418080034b883143948788e | 14:54 |
openstackgerrit | Jeffrey Zhang proposed openstack/kolla: Implement mongodb replication set cluster https://review.openstack.org/345751 | 14:56 |
rhallisey | mewald, just amend the commit message in the top commit | 15:00 |
rhallisey | it will reset that | 15:00 |
*** salv-orlando has joined #openstack-kolla | 15:00 | |
mewald | I amended the message but still get that error | 15:01 |
*** salv-orl_ has joined #openstack-kolla | 15:03 | |
mewald | ah fuck it, I'll wait until the containers are merged ... | 15:03 |
rhallisey | amend to the container commit message | 15:06 |
rhallisey | the top cimmit | 15:06 |
*** salv-orlando has quit IRC | 15:07 | |
coolsvap | mewald: i added some comments for containers related to customization | 15:07 |
openstackgerrit | Mathias proposed openstack/kolla: Added telegraf container https://review.openstack.org/346397 | 15:08 |
mewald | coolsvap: where can I find them? | 15:09 |
coolsvap | mewald: mewald: https://review.openstack.org/#/q/topic:bp/third-party-plugin-support,n,z | 15:10 |
coolsvap | merged patchset https://review.openstack.org/329651/ | 15:11 |
coolsvap | should give you more info | 15:11 |
coolsvap | seems like it has been addressed in patch 346397 | 15:12 |
patchbot | coolsvap: https://review.openstack.org/#/c/346397/ - kolla - Added telegraf container | 15:12 |
mewald | did I do it right? I was just copy & pasting from your heat example | 15:13 |
coolsvap | mewald: I am not sure about it, I will let inc0 have a look at it | 15:13 |
*** sdake has joined #openstack-kolla | 15:16 | |
*** mbound has joined #openstack-kolla | 15:21 | |
*** sdake_ has joined #openstack-kolla | 15:21 | |
*** sdake has quit IRC | 15:21 | |
*** ravig has joined #openstack-kolla | 15:48 | |
*** britthouser has joined #openstack-kolla | 15:51 | |
*** ravig has quit IRC | 15:53 | |
*** salv-orl_ has quit IRC | 15:53 | |
*** daneyon has joined #openstack-kolla | 15:55 | |
*** britthouser has quit IRC | 15:57 | |
*** daneyon has quit IRC | 16:00 | |
mewald | coolsvap: hmm probably the RUNs should go in a separate if-else after the marco | 16:13 |
mewald | macro | 16:14 |
openstackgerrit | Mathias proposed openstack/kolla: Added ansible role for telegraf https://review.openstack.org/346435 | 16:21 |
*** banix has joined #openstack-kolla | 16:25 | |
*** britthouser has joined #openstack-kolla | 16:28 | |
openstackgerrit | Mathias proposed openstack/kolla: Influxdb role for ansible https://review.openstack.org/346437 | 16:30 |
openstackgerrit | Mathias proposed openstack/kolla: Add grafana role https://review.openstack.org/346439 | 16:39 |
rhallisey | https://review.openstack.org/#/c/327925/11 | 16:42 |
patchbot | rhallisey: patch 327925 - kolla - Enable kolla k8s to override bind api bind address... | 16:42 |
rhallisey | can we get some review pls? | 16:43 |
rhallisey | coolsvap, sdake_ ^ | 16:43 |
rhallisey | Jeffrey4l, | 16:43 |
sdake_ | weekend | 16:43 |
rhallisey | there's like 10 patches that kolla-k8s need | 16:43 |
sdake_ | but ok | 16:43 |
rhallisey | :) | 16:43 |
sdake_ | 10 patches | 16:43 |
sdake_ | meh | 16:43 |
sdake_ | too early | 16:43 |
rhallisey | it's an easy review | 16:43 |
sdake_ | did nobody ever revie wthat list i sent to the ml? | 16:43 |
sdake_ | saw startrek last night | 16:43 |
mewald | guys I am still playing with splitting my patch into 6 different commits | 16:44 |
mewald | just so you dont waste much time on that this weekend | 16:44 |
sdake_ | mewald do you need help or got it under control | 16:44 |
mewald | I still didnt get the dependency stuff right | 16:44 |
sdake_ | i mean do you need help using git /etc | 16:44 |
mewald | sdake_: I am going to play with it for a while and ask you if in trouble :) | 16:44 |
mewald | thanks a lot! | 16:44 |
sdake_ | cool | 16:44 |
sdake_ | so one thing i was thinking about with our split repo patchess | 16:44 |
sdake_ | that may not work well once we have voting gates | 16:45 |
sdake_ | some patches will have to go in together | 16:45 |
sdake_ | and in those cases, we will just have to suck up the backporting process if necessary | 16:45 |
sdake_ | mewald for your work i wouldn't worry about the backport email on the ml | 16:45 |
sdake_ | althogh splitting up reviews from 3 pages of commits to 3-5 filles is easier on reviewers | 16:45 |
mewald | I think such a situation is my grafana patch. I need a script in kolla-toolbox for my ansible role :) | 16:46 |
mewald | yeah I will do it as a pratice tasks. worst thing that can happen: I learn git :D | 16:46 |
mewald | does it work to have 2 patches in review as dependencies for a third patch? | 16:53 |
*** banix has quit IRC | 17:05 | |
sdake_ | mewald it does | 17:07 |
sdake_ | use "Depends-On: CHANGEID" | 17:07 |
sdake_ | in the commit message | 17:08 |
sdake_ | and the patch wont merge until the parent merges | 17:08 |
sdake_ | there is another technique which is less obvious and less recommended | 17:08 |
*** cfarquhar has quit IRC | 17:08 | |
sdake_ | so lets just skip that and use depends-on - thats what its for ;) | 17:08 |
mewald | sdake_: the other technique is cherry picking the patches from gerrit? | 17:08 |
sdake_ | yup that can work | 17:10 |
sdake_ | you submit the original patch | 17:10 |
sdake_ | then make two repos and cherrrypick the second patch twice | 17:10 |
sdake_ | on top of the original patch | 17:10 |
sdake_ | I'd just go with Depends-On: | 17:10 |
sdake_ | and make it 3 commits in a patch stream | 17:10 |
mewald | hmm I tried that but get "remote: (W) No changes between prior commit 987977d and new commit 2ea703d" when I try to git review | 17:12 |
mewald | how do I get the code from the previous patch if I just use Depends-On? | 17:14 |
*** david-lyle_ has joined #openstack-kolla | 17:16 | |
*** david-lyle_ has quit IRC | 17:21 | |
mewald | sdake_: can you help with that non-easy way please? I would like not to have to do it all over again :D | 17:25 |
sdake_ | mewald just make the patches in a stream | 17:26 |
sdake_ | git commit patch1 | 17:26 |
sdake_ | git commit patch2 | 17:26 |
sdake_ | git commit patch3 | 17:26 |
sdake_ | git review | 17:26 |
mewald | ok | 17:26 |
sdake_ | you sound like ou have a wierd scenario where ou have two patches at the same level | 17:26 |
mewald | yeah do complicated dependencies | 17:28 |
mewald | do = too | 17:31 |
openstackgerrit | Eduardo Gonzalez proposed openstack/kolla: Add Senlin Ansible role https://review.openstack.org/339725 | 17:35 |
openstackgerrit | Jeffrey Zhang proposed openstack/kolla: Optimize horizon cahce and compress for http response https://review.openstack.org/346444 | 17:40 |
*** daneyon has joined #openstack-kolla | 17:43 | |
*** daneyon has quit IRC | 17:48 | |
openstackgerrit | Mathias proposed openstack/kolla: Added telegraf container https://review.openstack.org/346445 | 17:52 |
openstackgerrit | Mathias proposed openstack/kolla: Added influxdb container https://review.openstack.org/346446 | 17:52 |
openstackgerrit | Mathias proposed openstack/kolla: Added grafana container https://review.openstack.org/346447 | 17:52 |
openstackgerrit | Mathias proposed openstack/kolla: Added telegraf role https://review.openstack.org/346448 | 17:52 |
openstackgerrit | Mathias proposed openstack/kolla: Added influxdb role https://review.openstack.org/346449 | 17:52 |
openstackgerrit | Mathias proposed openstack/kolla: Added grafana role https://review.openstack.org/346450 | 17:52 |
mewald | sdake_: did I do it right? | 17:52 |
sdake_ | no idea | 17:52 |
sdake_ | looks right so far | 17:52 |
*** sdake_ is now known as sdake | 17:54 | |
mewald | ok | 17:56 |
*** mbound has quit IRC | 17:59 | |
openstackgerrit | Jeffrey Zhang proposed openstack/kolla: Optimize horizon cahce and compress for http response https://review.openstack.org/346444 | 18:01 |
sdake | Jeffrey4l ping | 18:12 |
*** Jeffrey4l has quit IRC | 18:14 | |
sdake | rhallisey reviewed | 18:17 |
rhallisey | thank | 18:17 |
sdake | rhallisey you probably wont like my review though :( | 18:17 |
rhallisey | thanks | 18:17 |
rhallisey | brb | 18:19 |
openstackgerrit | Ken Wronkiewicz proposed openstack/kolla: Fix interface address for RabbitMQ and disable cluster for Kubernetes https://review.openstack.org/336751 | 18:23 |
openstackgerrit | Ken Wronkiewicz proposed openstack/kolla: Nova kubernetes changes https://review.openstack.org/346451 | 18:23 |
openstackgerrit | Ken Wronkiewicz proposed openstack/kolla-kubernetes: Fix Nova bootstrap https://review.openstack.org/346452 | 18:27 |
rhallisey | sdake, I'm not sure how that would work. enable_kubernetes? This could turn in a jinja2 hell | 18:31 |
rhallisey | I mean technically this is just exposing an additional var | 18:31 |
rhallisey | if kube in the future needs massive changes, then I'd agree | 18:32 |
rhallisey | but not sure how to do that without splitting out config from kolla | 18:32 |
rhallisey | or even having kube make its own | 18:32 |
*** ravig has joined #openstack-kolla | 18:51 | |
*** dwalsh has joined #openstack-kolla | 18:53 | |
*** dwalsh_ has joined #openstack-kolla | 18:53 | |
*** ravig has quit IRC | 18:56 | |
*** mbound has joined #openstack-kolla | 18:59 | |
*** bootsha has joined #openstack-kolla | 19:00 | |
sdake | grr | 19:01 |
sdake | i just wrote a 5 page essay for our stable follows review and vi failed to commit | 19:02 |
sdake | i've lost all motivation for the day | 19:03 |
* sdake shakes fists | 19:03 | |
*** mbound has quit IRC | 19:04 | |
*** bootsha has quit IRC | 19:10 | |
*** bootsha has joined #openstack-kolla | 19:11 | |
v1k0d3n | Mech422: hey man, you around today? | 19:16 |
*** bootsha has quit IRC | 19:16 | |
*** david-lyle_ has joined #openstack-kolla | 19:18 | |
sdake | https://review.openstack.org/346455 | 19:22 |
*** david-lyle_ has quit IRC | 19:23 | |
sdake | rhallisey read ^^ | 19:26 |
*** banix has joined #openstack-kolla | 19:28 | |
*** daneyon has joined #openstack-kolla | 19:32 | |
*** daneyon has quit IRC | 19:36 | |
Mech422 | v1k0d3n: hey | 19:46 |
v1k0d3n | hey one sec...need to switch wifi for a sec | 19:46 |
*** v1k0d3n__ has joined #openstack-kolla | 19:47 | |
*** sdake has quit IRC | 19:50 | |
*** sdake has joined #openstack-kolla | 19:50 | |
*** severion has quit IRC | 19:51 | |
*** v1k0d3n has quit IRC | 19:51 | |
*** severion has joined #openstack-kolla | 19:51 | |
*** severion has quit IRC | 19:51 | |
rhallisey | sdake, looks good | 19:53 |
sdake | thanks | 19:53 |
sdake | hopefully the essay hleps ;) | 19:53 |
*** v1k0d3n has joined #openstack-kolla | 19:53 | |
v1k0d3n | Mech422: ok back. sorry about that. | 19:53 |
v1k0d3n | hey, so looks like you're pulling in your own repo...is that right? | 19:54 |
v1k0d3n | or does pulling in master on kolla work just fine (what i think you said yesterday). | 19:54 |
*** v1k0d3n__ has quit IRC | 19:55 | |
Mech422 | v1k0d3n: I use master from github | 19:56 |
Mech422 | v1k0d3n: I just have some patches I apply locally | 19:56 |
*** dave-mccowan has quit IRC | 19:59 | |
Mech422 | v1k0d3n: btw - apperently my kolla 'driver' is missing a step, as sdake says I shouldn't need to run kolla-build from the .tox directory.. | 20:04 |
Mech422 | v1k0d3n: so I should review that at some point | 20:04 |
v1k0d3n | i'm still trying to break down your deployment. pretty advance ansible usage for group_vars and you're doing most everything with pip virtualenvs. awesome work, just harder for me to pull apart and work through the flow. | 20:05 |
v1k0d3n | in fact it's awesome. learning some things. but i am on such a crazy time constraint. bad timing for me. | 20:05 |
Mech422 | v1k0d3n: same here - 'someday' I'll get around to cleaning it up and maybe putting it on github without dieing of embarassment... | 20:07 |
Mech422 | but for now it works for me, and I have other stuff I gotta get done | 20:07 |
v1k0d3n | ha, please...putting it up is where you get recommendations ;) | 20:07 |
v1k0d3n | that's open source man. | 20:07 |
Mech422 | v1k0d3n: they'd revoke my geek card if they saw that code.... | 20:08 |
Mech422 | v1k0d3n: Actually, recently I've been thinking about using something docker compose or terraform to deploy kolla containers... | 20:08 |
v1k0d3n | i don't think so. i think it's pretty awesome. | 20:08 |
v1k0d3n | ^^ you wanna make it even more confusing? lol | 20:09 |
Mech422 | v1k0d3n: we're gonna have a LOT of 'options' and 'plugins' going forward... | 20:09 |
v1k0d3n | now you're showing off :) | 20:09 |
Mech422 | v1k0d3n: and I'm wondering if using kolla to build containers to a 'standard', and then compose/TF to actually deploy them might be the way to go | 20:10 |
Mech422 | v1k0d3n: rather then having playbooks that have to try and account for all possible permutations | 20:10 |
v1k0d3n | i think variables in group/host vars is really simple and straight forward. | 20:10 |
v1k0d3n | simple. modular. | 20:11 |
v1k0d3n | easy for others to follow along. | 20:11 |
v1k0d3n | most of the time. | 20:11 |
Mech422 | v1k0d3n: yeah - its not the user interface that gets bad, its the actual playbooks "if foo and bar or baz " | 20:12 |
Mech422 | v1k0d3n: anyway - it was just a thought, I haven't really done anythign with it yet | 20:12 |
*** banix has quit IRC | 20:20 | |
v1k0d3n | yeah, that's true. | 20:22 |
v1k0d3n | Mech422: the prereqs...are you installing that on all hosts (deploy and targets), or just the deployer? | 20:29 |
Mech422 | v1k0d3n: I believe those have a 'when: ansible_host in group...' | 20:44 |
Mech422 | v1k0d3n: so it only goes on the deployer | 20:44 |
v1k0d3n | they were commented out...so it looks like it went to the deployer at one point. | 20:45 |
v1k0d3n | that was similar with the kolla.git.src declaration pointing to openstack repo. | 20:47 |
*** mewald has quit IRC | 20:51 | |
*** coolsvap has quit IRC | 21:01 | |
*** dwalsh has quit IRC | 21:02 | |
*** dwalsh_ has quit IRC | 21:02 | |
Mech422 | v1k0d3n: nope - looking at the nodes - there's no home/kolla/kolla/src on anything except the deployer | 21:03 |
v1k0d3n | ok, so all the prereqs are on the deployer...makes sense. so the only thing you add to the targets is docker-py? sorry for all the stupid questions. | 21:04 |
Mech422 | v1k0d3n: I suppose - I haven't looked at this code in like 3 months | 21:04 |
v1k0d3n | i haven't done my playbooks like this yet...more advanced than i am at unfortunately. | 21:04 |
v1k0d3n | oh...i thought you said this is what you were using when you deployed a few days ago. i guess you used, just haven't looked at it? | 21:05 |
Mech422 | v1k0d3n: it wasnt meant to be a working, turn-key script - just an example of some ot the steps you need to perform | 21:05 |
v1k0d3n | yeah, that makes sense...i'm working through just the flow really...making changes as i need. | 21:05 |
Mech422 | v1k0d3n: yeah - I haven't changed it in 3 months (aside from adding/removing patches to the checkout task) - I deploy with it basically every day | 21:05 |
*** dave-mccowan has joined #openstack-kolla | 21:07 | |
v1k0d3n | the checkout task is interesting...trying to understand where it's pulling from github.com/openstack/kolla, or openstack.org at. | 21:08 |
*** dave-mccowan has quit IRC | 21:08 | |
Mech422 | v1k0d3n: the git task ? | 21:08 |
v1k0d3n | this looked like it was pulling from you're repo...but i'm probably missing it somewhere. i see the patches though. | 21:08 |
Mech422 | v1k0d3n: and the vars are populated from the kolla.yml file I pasted the other day | 21:08 |
v1k0d3n | sorry in your group_vars kolla.git.src. | 21:08 |
v1k0d3n | right...that one. | 21:09 |
Mech422 | I'm lost... kolla.git.src is the full url to the repo - THATS what gets installed ? | 21:09 |
v1k0d3n | no... | 21:09 |
v1k0d3n | so kolla.yml (which i can also use in a group_vars as a var file... | 21:10 |
Mech422 | v1k0d3n: oh - nice catch! | 21:10 |
Mech422 | v1k0d3n: I must have changed kolla.yml to test something | 21:10 |
v1k0d3n | kolla > git > src....that's it. | 21:10 |
v1k0d3n | ok...just checking. i was confused. | 21:10 |
Mech422 | v1k0d3n: its supposed to point to the github kolla repo | 21:11 |
v1k0d3n | ok...just checking. i changed. that | 21:12 |
Mech422 | v1k0d3n: ok - dropping a rebuild now...lets see if that changes anything | 21:13 |
Mech422 | v1k0d3n: thanks for finding that | 21:14 |
Mech422 | v1k0d3n: you can assume anything stupid like that is just me futzing around testing new stuff | 21:15 |
Mech422 | v1k0d3n: the whole cherrypick thing in checkout was just to grab 1 patch that hadn't been merged yet - its not 'supposed' to be there - I left it just as an example of how to do a cherry-pick | 21:16 |
*** v1k0d3n has quit IRC | 21:17 | |
*** severion has joined #openstack-kolla | 21:17 | |
*** mdnadeem_ has quit IRC | 21:19 | |
*** mdnadeem_ has joined #openstack-kolla | 21:19 | |
*** david-lyle_ has joined #openstack-kolla | 21:20 | |
*** daneyon has joined #openstack-kolla | 21:20 | |
*** banix has joined #openstack-kolla | 21:24 | |
*** daneyon has quit IRC | 21:25 | |
*** david-lyle_ has quit IRC | 21:25 | |
*** severion has left #openstack-kolla | 21:31 | |
*** severion has joined #openstack-kolla | 21:31 | |
*** sdake has quit IRC | 21:33 | |
*** sdake has joined #openstack-kolla | 21:39 | |
*** dwalsh has joined #openstack-kolla | 21:56 | |
*** dwalsh_ has joined #openstack-kolla | 21:56 | |
*** sdake has quit IRC | 22:04 | |
*** dwalsh_ has quit IRC | 22:16 | |
*** dwalsh has quit IRC | 22:16 | |
*** dwalsh_ has joined #openstack-kolla | 22:41 | |
*** dwalsh has joined #openstack-kolla | 22:41 | |
openstackgerrit | Dave Walker proposed openstack/kolla: Add Watcher default settings https://review.openstack.org/337559 | 22:43 |
severion | Mech422: any luck? | 22:52 |
Mech422 | severion: with ? | 22:53 |
severion | crap one sec... | 22:53 |
severion | severion == v1k0d3n (dropped connection name) | 22:53 |
*** severion has quit IRC | 22:53 | |
*** v1k0d3n has joined #openstack-kolla | 22:53 | |
v1k0d3n | sorry build i mean | 22:53 |
Mech422 | v1k0d3n: yeah - it rebuilt fine using the 'right' github repo | 22:53 |
v1k0d3n | ok | 22:54 |
v1k0d3n | i'm fighting some really wonky issue with ansible.... | 22:54 |
Mech422 | v1k0d3n: I generally don't have any issues with build/deploy - its configuration I gotta work out | 22:54 |
v1k0d3n | i have a group defined and it's skipping right over it...wildest thing. | 22:54 |
Mech422 | v1k0d3n: huh - what version of ansible and kolla you using ? | 22:54 |
v1k0d3n | no this is ansible on my host that i an using to prep the hosts with. | 22:55 |
Mech422 | ahh | 22:55 |
Mech422 | I use ansible 2 on all the hosts... | 22:55 |
Mech422 | I can't recall, but I think I had issues with ansible 1 | 22:55 |
v1k0d3n | i usually setup a site.yml...then use tags to step it along. | 22:55 |
Mech422 | btw - I've seen stuff where it looks like ansible is skipping a step, but it was actually because of an 'error' in the step before | 22:56 |
v1k0d3n | using 2.1, but there's gotta be something else...it's happening withe dev branch too (which is 2.2.0 | 22:56 |
v1k0d3n | interesting. possibly it. | 22:56 |
Mech422 | the ansible error reporting is pretty bad in that regard | 22:56 |
v1k0d3n | yeah, it's not that great imo either. | 22:57 |
v1k0d3n | hmmm you got me thinking though. let me see. | 22:57 |
v1k0d3n | it looooked like things were fine. | 22:57 |
v1k0d3n | but it's a really trivial step. it's the pip docker-py step for the targets. | 22:57 |
v1k0d3n | simple...everything else seemd to work just fine | 22:58 |
Mech422 | v1k0d3n: check the targets and see if docker-py actually installed ? | 22:58 |
Mech422 | v1k0d3n: my rebuild has ceph up, horizon up. I'm gonna start a cirros vm and see if that works | 22:59 |
v1k0d3n | you deploy automatically installs those? | 23:00 |
v1k0d3n | ceph i mean? | 23:00 |
Mech422 | yeah | 23:01 |
Mech422 | vnc is up too | 23:02 |
v1k0d3n | ok, still working through some of these plays... | 23:07 |
Mech422 | looks like I might have a firewalling issue on my 'public' network | 23:07 |
v1k0d3n | lot of work. can't wait until i can actually get a mult-node up again. not sure why i was having so many issues. hmmm | 23:08 |
Mech422 | but thats all the time I have to play with it right now - gotta do some stuff for $DayJob now | 23:08 |
*** daneyon has joined #openstack-kolla | 23:08 | |
*** daneyon has quit IRC | 23:13 | |
*** dwalsh_ has quit IRC | 23:21 | |
*** dwalsh has quit IRC | 23:21 | |
*** david-lyle_ has joined #openstack-kolla | 23:22 | |
*** david-lyle_ has quit IRC | 23:27 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!