Wednesday, 2023-01-18

opendevreviewGhanshyam proposed openstack/kolla-ansible master: Remove system scope token to access services  https://review.opendev.org/c/openstack/kolla-ansible/+/87087903:22
opendevreviewGhanshyam proposed openstack/kolla-ansible master: Remove system scope token to access services  https://review.opendev.org/c/openstack/kolla-ansible/+/87087903:27
sydheya all, wanted to check if I'm looking at a bug or local config issue. ceph-rgw plays seem to be running in all kinds of unexpected plays03:44
sydfor example bootstraps limited to compute nodes03:44
frickleroh my, we do we keep making incompatible backports? https://review.opendev.org/c/openstack/kolla-ansible/+/870494 should have had fallbacks allowing om_enable_rabbitmq_high_availability to be undefined06:16
opendevreviewMarcin Juszkiewicz proposed openstack/kolla master: grafana: remove SHA1 workaround  https://review.opendev.org/c/openstack/kolla/+/86899606:39
hrwbuilds!06:39
mnasiadkayay07:28
hrwzuul +108:11
kevkohi \o/08:35
kevkoany reviewers for https://review.opendev.org/c/openstack/kolla-ansible/+/870798 and https://review.opendev.org/c/openstack/kolla-ansible/+/865434  it's trivial 08:35
hrwhttps://review.opendev.org/c/openstack/kolla-ansible/+/870798 has so cryptic commit message that I had to look at source to find out what is going on08:40
kevkohrw: :( ..i didn't know how to describe ..point is that function gets 'common_options' by pop ..and then new_args are combination of common_options and module_params ...point is that conditional do this ->   create dict from common_options [new_args] -> iterate through all elems in module paramas and update new_args if not none ... point is that idea of common_options is to override module params ... as it is now in master ... common options are 09:06
kevkoreplaced by default values 09:06
kevkohrw: that added two lines are just saying -> ok if there is something defined in module_params (default values), but they are already defined in common_options (user_defined) ..just continue 09:07
kevkonow it is buggy ..because user defined options are always replaced by module_params default values 09:08
mnasiadkasometimes for adding 2 lines, you need 10 lines of commit message ;-)09:12
kevkomnasiadka: common, it's visible on first seen :D 09:14
kevkomnasiadka: i've added a comment into review ...09:14
opendevreviewMerged openstack/kolla master: grafana: remove SHA1 workaround  https://review.opendev.org/c/openstack/kolla/+/86899610:33
opendevreviewMarcin Juszkiewicz proposed openstack/kolla stable/zed: grafana: remove SHA1 workaround  https://review.opendev.org/c/openstack/kolla/+/87089710:41
hrwmnasiadka: later into yoga as well?10:41
mnasiadkahrw: yes, I'll include that in the backports10:54
opendevreviewMerged openstack/kolla-ansible stable/zed: Fix prechecks in check mode  https://review.opendev.org/c/openstack/kolla-ansible/+/87077310:55
kevkomgoddard: Could you please check my comment ? 11:19
opendevreviewMerged openstack/kolla-ansible stable/yoga: Fix issue with genconfig and octavia_auto_configure  https://review.opendev.org/c/openstack/kolla-ansible/+/87077011:20
opendevreviewMerged openstack/kolla-ansible stable/xena: Fix issue with genconfig and octavia_auto_configure  https://review.opendev.org/c/openstack/kolla-ansible/+/87077111:28
opendevreviewMerged openstack/kolla-ansible stable/wallaby: Fix issue with genconfig and octavia_auto_configure  https://review.opendev.org/c/openstack/kolla-ansible/+/87077211:36
opendevreviewVerification of a change to openstack/kolla-ansible master failed: Remove use_forwarded_for configuration option  https://review.opendev.org/c/openstack/kolla-ansible/+/87053411:42
opendevreviewVerification of a change to openstack/kolla-ansible master failed: Remove [trustee]/auth_uri option from heat.conf  https://review.opendev.org/c/openstack/kolla-ansible/+/87053511:46
kevkomgoddard: Here ? 11:52
opendevreviewMerged openstack/kolla-ansible stable/zed: Fix issue with genconfig and octavia_auto_configure  https://review.opendev.org/c/openstack/kolla-ansible/+/87050912:42
opendevreviewMerged openstack/kolla-ansible master: CI: Avoid running tgtd if BASE_DISTRO is rocky  https://review.opendev.org/c/openstack/kolla-ansible/+/87054212:52
opendevreviewMerged openstack/kolla-ansible master: Remove [trustee]/auth_uri option from heat.conf  https://review.opendev.org/c/openstack/kolla-ansible/+/87053513:09
opendevreviewMerged openstack/kolla-ansible master: Remove use_forwarded_for configuration option  https://review.opendev.org/c/openstack/kolla-ansible/+/87053413:15
mgoddardkevko: yes13:25
kevkomgoddard: regarding that patch about kolla_docker ...13:25
kevkomgoddard: i don't think module_defaults is good fix, 1. there no two lines, but several lines auth_user, auth_password, restart_policy, env ...etc .. moreover module_facts works per play (every block where hosts: whatever is defined - and this is lot of occurences in k-a) - moreover on module page there is a note >>13:27
kevkoAny module defaults set at the play level (and block/task level when using include_role or import_role) will apply to any roles used, which may cause unexpected behavior in the role.13:27
kevkomgoddard: but I think we can remove defaults='something' from params which are common ..move to dict with defaults and then just verify them13:29
mnasiadkamgoddard mnasiadka hrw  bbezak frickler kevko - meeting in 913:52
mnasiadka#startmeeting kolla14:00
opendevmeetMeeting started Wed Jan 18 14:00:02 2023 UTC and is due to finish in 60 minutes.  The chair is mnasiadka. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'kolla'14:00
mnasiadka#topic rollcall14:00
mnasiadkao/14:00
frickler\o14:00
bbezako\14:00
ebbexo/14:00
mnasiadka#topic agenda14:02
mnasiadka* CI status14:02
mnasiadka* Release tasks14:02
mnasiadka* Regular stable releases (first meeting in a month)14:02
mnasiadka* Current cycle planning14:02
mnasiadka* Additional agenda (from whiteboard)14:02
mnasiadka* Open discussion14:02
mnasiadka#topic CI status14:02
mnasiadkaThere have been some CI failures, we had to sort out some things after the switch of previous_release to zed14:02
mnasiadkabut I think everything is fine now14:03
mnasiadka#topic Release tasks14:04
mnasiadkabbezak: all required patches merged? :)14:04
bbezakI think so :)14:05
mnasiadkaOk, so let's assume your thinking is right14:05
bbezakhttps://docs.openstack.org/kolla/latest/contributor/release-management.html#r-17-switch-source-images-to-current-release14:05
bbezakr-17 and r-814:05
bbezakR-5: Cycle highlights deadline soon :)14:05
mnasiadkain 4 weeks, great14:05
mnasiadka#topic Current cycle planning14:06
mnasiadkaOk then, about the great features we want to get merged - Podman, systemd and let's encrypt14:06
mnasiadkaanybody had time to have a look?14:06
fricklernot /me, and likely won't have for the next 6 weeks or so14:07
mnasiadkaso maybe B :)14:07
mnasiadkaNo additional agenda14:07
mnasiadka#topic Open discussion14:07
mnasiadkaAnything, anyone?14:08
fricklerdo we want to talk about system scope?14:08
mnasiadkaebbex: any luck with network manager work?14:08
fricklerI didn't look at gmann's patch yet, though14:08
mnasiadkafrickler: I think Nova already broke on us :)14:08
frickleryes, iiuc because we were too far with system scope adoption14:08
mnasiadkaI didn't really have time to follow14:09
mnasiadkalast time it was mgoddard that had a look in system scope I think14:10
fricklero.k., so https://review.opendev.org/c/openstack/kolla-ansible/+/870879 needs some attention then, I guess14:10
mnasiadkaok, will try to have a look14:11
ebbexYep, I think I got the routing_options and rules working.14:13
mnasiadkagreat14:13
ebbexNeed bbezak to have a look at https://review.opendev.org/c/openstack/kayobe/+/869977 if it needs a recheck or somethin'.14:13
bbezakdoing that14:13
mnasiadkaI bet he's looking into it14:13
mnasiadka:)14:13
mnasiadkaOk, I think that's enough for today.14:14
mnasiadkaThanks for coming14:14
mnasiadka#endmeeting14:14
opendevmeetMeeting ended Wed Jan 18 14:14:32 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:14
opendevmeetMinutes:        https://meetings.opendev.org/meetings/kolla/2023/kolla.2023-01-18-14.00.html14:14
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/kolla/2023/kolla.2023-01-18-14.00.txt14:14
opendevmeetLog:            https://meetings.opendev.org/meetings/kolla/2023/kolla.2023-01-18-14.00.log.html14:14
fricklerthx mnasiadka 14:14
opendevreviewEbbex proposed openstack/kayobe master: [DNM] ansible-role-interfaces NetworkManager test  https://review.opendev.org/c/openstack/kayobe/+/86997714:45
opendevreviewWill Szumski proposed openstack/kolla-ansible master: firewalld is no longer configured during genconfig  https://review.opendev.org/c/openstack/kolla-ansible/+/87096514:54
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix kolla_toolbox module  https://review.opendev.org/c/openstack/kolla-ansible/+/87079814:56
opendevreviewMerged openstack/kolla stable/zed: grafana: remove SHA1 workaround  https://review.opendev.org/c/openstack/kolla/+/87089715:05
opendevreviewGhanshyam proposed openstack/kolla-ansible master: Remove system scope token to access services  https://review.opendev.org/c/openstack/kolla-ansible/+/87087915:08
kevkomnasiadka: sorry, I had a meeting with customer ..and still have :( 15:09
gmannfrickler: mnasiadka mgoddard priteau ^^ updated as per review comment. yes this is due to system scope adoption by kolla which was little pre-mature and in zed cycle changed. Every service dropped that except ironic and keystone. I linked governance patch/doc in commit message about it.15:09
gmannplease let me know if any query or update needed for this change15:09
mnasiadkakevko: no worries15:41
opendevreviewMerged openstack/kolla-ansible master: Stop firewalld config during kolla genconfig  https://review.opendev.org/c/openstack/kolla-ansible/+/86982116:26
*** gmann is now known as gmann_afk17:29
mnasiadkagmann_afk: thanks for handling that :)17:36
opendevreviewMichal Nasiadka proposed openstack/kolla master: Add Dockerfile for neutron-ovn-agent  https://review.opendev.org/c/openstack/kolla/+/87079317:40
*** gmann_afk is now known as gmann17:41
*** gmann is now known as gmann_afk18:06
supamattCan I have someone review this change for hacluster? https://review.opendev.org/c/openstack/kolla-ansible/+/87059118:26
supamattIt was blocking our deployment of getting masakari to work with fqdn names18:27
*** gmann_afk is now known as gmann18:56
gmannmnasiadka: frickler mgoddard priteau policy scope fix is passing the gate and ready for review https://review.opendev.org/c/openstack/kolla-ansible/+/870879 19:23
opendevreviewMerged openstack/kolla stable/yoga: relay non-zero exit codes when creating openvswitch bridges  https://review.opendev.org/c/openstack/kolla/+/87066519:25
opendevreviewMerged openstack/kolla stable/xena: relay non-zero exit codes when creating openvswitch bridges  https://review.opendev.org/c/openstack/kolla/+/87066622:00

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!