opendevreview | Ghanshyam proposed openstack/kolla-ansible master: Remove system scope token to access services https://review.opendev.org/c/openstack/kolla-ansible/+/870879 | 03:22 |
---|---|---|
opendevreview | Ghanshyam proposed openstack/kolla-ansible master: Remove system scope token to access services https://review.opendev.org/c/openstack/kolla-ansible/+/870879 | 03:27 |
syd | heya all, wanted to check if I'm looking at a bug or local config issue. ceph-rgw plays seem to be running in all kinds of unexpected plays | 03:44 |
syd | for example bootstraps limited to compute nodes | 03:44 |
frickler | oh my, we do we keep making incompatible backports? https://review.opendev.org/c/openstack/kolla-ansible/+/870494 should have had fallbacks allowing om_enable_rabbitmq_high_availability to be undefined | 06:16 |
opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: grafana: remove SHA1 workaround https://review.opendev.org/c/openstack/kolla/+/868996 | 06:39 |
hrw | builds! | 06:39 |
mnasiadka | yay | 07:28 |
hrw | zuul +1 | 08:11 |
kevko | hi \o/ | 08:35 |
kevko | any reviewers for https://review.opendev.org/c/openstack/kolla-ansible/+/870798 and https://review.opendev.org/c/openstack/kolla-ansible/+/865434 it's trivial | 08:35 |
hrw | https://review.opendev.org/c/openstack/kolla-ansible/+/870798 has so cryptic commit message that I had to look at source to find out what is going on | 08:40 |
kevko | hrw: :( ..i didn't know how to describe ..point is that function gets 'common_options' by pop ..and then new_args are combination of common_options and module_params ...point is that conditional do this -> create dict from common_options [new_args] -> iterate through all elems in module paramas and update new_args if not none ... point is that idea of common_options is to override module params ... as it is now in master ... common options are | 09:06 |
kevko | replaced by default values | 09:06 |
kevko | hrw: that added two lines are just saying -> ok if there is something defined in module_params (default values), but they are already defined in common_options (user_defined) ..just continue | 09:07 |
kevko | now it is buggy ..because user defined options are always replaced by module_params default values | 09:08 |
mnasiadka | sometimes for adding 2 lines, you need 10 lines of commit message ;-) | 09:12 |
kevko | mnasiadka: common, it's visible on first seen :D | 09:14 |
kevko | mnasiadka: i've added a comment into review ... | 09:14 |
opendevreview | Merged openstack/kolla master: grafana: remove SHA1 workaround https://review.opendev.org/c/openstack/kolla/+/868996 | 10:33 |
opendevreview | Marcin Juszkiewicz proposed openstack/kolla stable/zed: grafana: remove SHA1 workaround https://review.opendev.org/c/openstack/kolla/+/870897 | 10:41 |
hrw | mnasiadka: later into yoga as well? | 10:41 |
mnasiadka | hrw: yes, I'll include that in the backports | 10:54 |
opendevreview | Merged openstack/kolla-ansible stable/zed: Fix prechecks in check mode https://review.opendev.org/c/openstack/kolla-ansible/+/870773 | 10:55 |
kevko | mgoddard: Could you please check my comment ? | 11:19 |
opendevreview | Merged openstack/kolla-ansible stable/yoga: Fix issue with genconfig and octavia_auto_configure https://review.opendev.org/c/openstack/kolla-ansible/+/870770 | 11:20 |
opendevreview | Merged openstack/kolla-ansible stable/xena: Fix issue with genconfig and octavia_auto_configure https://review.opendev.org/c/openstack/kolla-ansible/+/870771 | 11:28 |
opendevreview | Merged openstack/kolla-ansible stable/wallaby: Fix issue with genconfig and octavia_auto_configure https://review.opendev.org/c/openstack/kolla-ansible/+/870772 | 11:36 |
opendevreview | Verification of a change to openstack/kolla-ansible master failed: Remove use_forwarded_for configuration option https://review.opendev.org/c/openstack/kolla-ansible/+/870534 | 11:42 |
opendevreview | Verification of a change to openstack/kolla-ansible master failed: Remove [trustee]/auth_uri option from heat.conf https://review.opendev.org/c/openstack/kolla-ansible/+/870535 | 11:46 |
kevko | mgoddard: Here ? | 11:52 |
opendevreview | Merged openstack/kolla-ansible stable/zed: Fix issue with genconfig and octavia_auto_configure https://review.opendev.org/c/openstack/kolla-ansible/+/870509 | 12:42 |
opendevreview | Merged openstack/kolla-ansible master: CI: Avoid running tgtd if BASE_DISTRO is rocky https://review.opendev.org/c/openstack/kolla-ansible/+/870542 | 12:52 |
opendevreview | Merged openstack/kolla-ansible master: Remove [trustee]/auth_uri option from heat.conf https://review.opendev.org/c/openstack/kolla-ansible/+/870535 | 13:09 |
opendevreview | Merged openstack/kolla-ansible master: Remove use_forwarded_for configuration option https://review.opendev.org/c/openstack/kolla-ansible/+/870534 | 13:15 |
mgoddard | kevko: yes | 13:25 |
kevko | mgoddard: regarding that patch about kolla_docker ... | 13:25 |
kevko | mgoddard: i don't think module_defaults is good fix, 1. there no two lines, but several lines auth_user, auth_password, restart_policy, env ...etc .. moreover module_facts works per play (every block where hosts: whatever is defined - and this is lot of occurences in k-a) - moreover on module page there is a note >> | 13:27 |
kevko | Any module defaults set at the play level (and block/task level when using include_role or import_role) will apply to any roles used, which may cause unexpected behavior in the role. | 13:27 |
kevko | mgoddard: but I think we can remove defaults='something' from params which are common ..move to dict with defaults and then just verify them | 13:29 |
mnasiadka | mgoddard mnasiadka hrw bbezak frickler kevko - meeting in 9 | 13:52 |
mnasiadka | #startmeeting kolla | 14:00 |
opendevmeet | Meeting started Wed Jan 18 14:00:02 2023 UTC and is due to finish in 60 minutes. The chair is mnasiadka. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
opendevmeet | The meeting name has been set to 'kolla' | 14:00 |
mnasiadka | #topic rollcall | 14:00 |
mnasiadka | o/ | 14:00 |
frickler | \o | 14:00 |
bbezak | o\ | 14:00 |
ebbex | o/ | 14:00 |
mnasiadka | #topic agenda | 14:02 |
mnasiadka | * CI status | 14:02 |
mnasiadka | * Release tasks | 14:02 |
mnasiadka | * Regular stable releases (first meeting in a month) | 14:02 |
mnasiadka | * Current cycle planning | 14:02 |
mnasiadka | * Additional agenda (from whiteboard) | 14:02 |
mnasiadka | * Open discussion | 14:02 |
mnasiadka | #topic CI status | 14:02 |
mnasiadka | There have been some CI failures, we had to sort out some things after the switch of previous_release to zed | 14:02 |
mnasiadka | but I think everything is fine now | 14:03 |
mnasiadka | #topic Release tasks | 14:04 |
mnasiadka | bbezak: all required patches merged? :) | 14:04 |
bbezak | I think so :) | 14:05 |
mnasiadka | Ok, so let's assume your thinking is right | 14:05 |
bbezak | https://docs.openstack.org/kolla/latest/contributor/release-management.html#r-17-switch-source-images-to-current-release | 14:05 |
bbezak | r-17 and r-8 | 14:05 |
bbezak | R-5: Cycle highlights deadline soon :) | 14:05 |
mnasiadka | in 4 weeks, great | 14:05 |
mnasiadka | #topic Current cycle planning | 14:06 |
mnasiadka | Ok then, about the great features we want to get merged - Podman, systemd and let's encrypt | 14:06 |
mnasiadka | anybody had time to have a look? | 14:06 |
frickler | not /me, and likely won't have for the next 6 weeks or so | 14:07 |
mnasiadka | so maybe B :) | 14:07 |
mnasiadka | No additional agenda | 14:07 |
mnasiadka | #topic Open discussion | 14:07 |
mnasiadka | Anything, anyone? | 14:08 |
frickler | do we want to talk about system scope? | 14:08 |
mnasiadka | ebbex: any luck with network manager work? | 14:08 |
frickler | I didn't look at gmann's patch yet, though | 14:08 |
mnasiadka | frickler: I think Nova already broke on us :) | 14:08 |
frickler | yes, iiuc because we were too far with system scope adoption | 14:08 |
mnasiadka | I didn't really have time to follow | 14:09 |
mnasiadka | last time it was mgoddard that had a look in system scope I think | 14:10 |
frickler | o.k., so https://review.opendev.org/c/openstack/kolla-ansible/+/870879 needs some attention then, I guess | 14:10 |
mnasiadka | ok, will try to have a look | 14:11 |
ebbex | Yep, I think I got the routing_options and rules working. | 14:13 |
mnasiadka | great | 14:13 |
ebbex | Need bbezak to have a look at https://review.opendev.org/c/openstack/kayobe/+/869977 if it needs a recheck or somethin'. | 14:13 |
bbezak | doing that | 14:13 |
mnasiadka | I bet he's looking into it | 14:13 |
mnasiadka | :) | 14:13 |
mnasiadka | Ok, I think that's enough for today. | 14:14 |
mnasiadka | Thanks for coming | 14:14 |
mnasiadka | #endmeeting | 14:14 |
opendevmeet | Meeting ended Wed Jan 18 14:14:32 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:14 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/kolla/2023/kolla.2023-01-18-14.00.html | 14:14 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/kolla/2023/kolla.2023-01-18-14.00.txt | 14:14 |
opendevmeet | Log: https://meetings.opendev.org/meetings/kolla/2023/kolla.2023-01-18-14.00.log.html | 14:14 |
frickler | thx mnasiadka | 14:14 |
opendevreview | Ebbex proposed openstack/kayobe master: [DNM] ansible-role-interfaces NetworkManager test https://review.opendev.org/c/openstack/kayobe/+/869977 | 14:45 |
opendevreview | Will Szumski proposed openstack/kolla-ansible master: firewalld is no longer configured during genconfig https://review.opendev.org/c/openstack/kolla-ansible/+/870965 | 14:54 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Fix kolla_toolbox module https://review.opendev.org/c/openstack/kolla-ansible/+/870798 | 14:56 |
opendevreview | Merged openstack/kolla stable/zed: grafana: remove SHA1 workaround https://review.opendev.org/c/openstack/kolla/+/870897 | 15:05 |
opendevreview | Ghanshyam proposed openstack/kolla-ansible master: Remove system scope token to access services https://review.opendev.org/c/openstack/kolla-ansible/+/870879 | 15:08 |
kevko | mnasiadka: sorry, I had a meeting with customer ..and still have :( | 15:09 |
gmann | frickler: mnasiadka mgoddard priteau ^^ updated as per review comment. yes this is due to system scope adoption by kolla which was little pre-mature and in zed cycle changed. Every service dropped that except ironic and keystone. I linked governance patch/doc in commit message about it. | 15:09 |
gmann | please let me know if any query or update needed for this change | 15:09 |
mnasiadka | kevko: no worries | 15:41 |
opendevreview | Merged openstack/kolla-ansible master: Stop firewalld config during kolla genconfig https://review.opendev.org/c/openstack/kolla-ansible/+/869821 | 16:26 |
*** gmann is now known as gmann_afk | 17:29 | |
mnasiadka | gmann_afk: thanks for handling that :) | 17:36 |
opendevreview | Michal Nasiadka proposed openstack/kolla master: Add Dockerfile for neutron-ovn-agent https://review.opendev.org/c/openstack/kolla/+/870793 | 17:40 |
*** gmann_afk is now known as gmann | 17:41 | |
*** gmann is now known as gmann_afk | 18:06 | |
supamatt | Can I have someone review this change for hacluster? https://review.opendev.org/c/openstack/kolla-ansible/+/870591 | 18:26 |
supamatt | It was blocking our deployment of getting masakari to work with fqdn names | 18:27 |
*** gmann_afk is now known as gmann | 18:56 | |
gmann | mnasiadka: frickler mgoddard priteau policy scope fix is passing the gate and ready for review https://review.opendev.org/c/openstack/kolla-ansible/+/870879 | 19:23 |
opendevreview | Merged openstack/kolla stable/yoga: relay non-zero exit codes when creating openvswitch bridges https://review.opendev.org/c/openstack/kolla/+/870665 | 19:25 |
opendevreview | Merged openstack/kolla stable/xena: relay non-zero exit codes when creating openvswitch bridges https://review.opendev.org/c/openstack/kolla/+/870666 | 22:00 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!