| opendevreview | Rocky proposed openstack/kolla-ansible master: Set config files to root/horizon https://review.opendev.org/c/openstack/kolla-ansible/+/893307 | 04:22 |
|---|---|---|
| mnasiadka | SvenKieske: I don’t think we can rely on the author to do it | 06:59 |
| SvenKieske | mnasiadka: you're referring to relnotes? | 07:02 |
| mnasiadka | SvenKieske: yup - volunteering to write it or should I? | 07:11 |
| SvenKieske | I was honestly asking for relnotes because I don't have the knowledge | 07:13 |
| SvenKieske | about what commit are we talking? I remember two are missing relnotes imho :D | 07:13 |
| SvenKieske | the octavia jobboard stuff is missing at least a link what's necessary to deploy/configure redis imho | 07:15 |
| *** ralonsoh_ooo is now known as ralonsoh | 07:18 | |
| mnasiadka | SvenKieske: jobboard is not merged, so poke a stick at the author :) | 07:39 |
| SvenKieske | I left a comment, that should suffice :) | 07:43 |
| SvenKieske | that being said it seems normal to merge stuff with open comments, which I find highly disturbing. | 07:43 |
| frickler | so we need a review policy in addition to style and coding. so much bureaucracy. and spelling that word without coffee is yet another challenge :-/ | 07:52 |
| mnasiadka | frickler: nice joke in the morning ;) | 08:00 |
| SvenKieske | I don't know, this seems very basic, no? all comments must be resolved before stuff get's merged.? Why would you just ignore comments? gitlab has a nice feature to mark a comment as resolved by creating a new issue from it with one click, wish gerrit/launchpad had something like this. | 08:05 |
| SvenKieske | it's imho basic decency to at least reply. and if you reply: "won't address this because blablabla" that's still more polite than just ignoring someone, no? | 08:06 |
| SvenKieske | it seems this is possible to enforce in gerrit: https://groups.google.com/g/repo-discuss/c/zzVtWXg0qSs | 08:11 |
| SvenKieske | so no need to write a policy ;) | 08:11 |
| SvenKieske | if something is really blocking just at least ACK it. | 08:12 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/yoga: opensearch-dashboard: fix permissions https://review.opendev.org/c/openstack/kolla-ansible/+/893249 | 08:12 |
| SvenKieske | I had good experience in the past with that kind of policy. you get less useless comments and overall higher quality commits imho. but ymmv. | 08:14 |
| opendevreview | Will Szumski proposed openstack/kolla-ansible master: Adds the neutron_service_limit option https://review.opendev.org/c/openstack/kolla-ansible/+/877776 | 09:01 |
| SvenKieske | has anybody else the problem that gerrit code review sometimes doesn't register keyboard shortcuts like "c" to comment on a selected piece of code? reloading the site helps, but it's cumbersome. | 09:02 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/yoga: Fixes task name in notify module to the actual task name https://review.opendev.org/c/openstack/kolla-ansible/+/893250 | 09:03 |
| SvenKieske | that one has relnotes which fail to link to the bug report, ah well. at least the commit message has the bug report link I guess.. | 09:05 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: ovn: Improve clustering https://review.opendev.org/c/openstack/kolla-ansible/+/868929 | 09:11 |
| frickler | SvenKieske: which browser are you using? I'm having relatively little issues with firefox. also might be an issue with your local CPE dropping idle sessions | 09:15 |
| SvenKieske | CPE? I'm also using firefox | 09:16 |
| SvenKieske | I doubt it's an idle session, it's even happening sometimes when I freshly load the site, want to comment, "c" does not work. hit reload, wait, "c" does work. | 09:17 |
| SvenKieske | maybe I'm too fast with loading a file while some async JS stuff hasn't finished loading the main review screen. | 09:18 |
| SvenKieske | was just curious, if nobody else has this problem it's probably something local | 09:21 |
| frickler | SvenKieske: CPE = the router from your carrier, like fritzbox or whatever | 09:21 |
| frickler | customer premise equipment, standard networker term, sorry for using it out of context | 09:22 |
| SvenKieske | never heard that term, but looked it up at wikipedia already :) | 09:26 |
| SvenKieske | the network stuff I do never has any customers :D | 09:26 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: ovn: Improve clustering https://review.opendev.org/c/openstack/kolla-ansible/+/868929 | 09:51 |
| opendevreview | Will Szumski proposed openstack/kayobe master: Honor custom ssh args in kayobe-ansible-user.yml https://review.opendev.org/c/openstack/kayobe/+/788276 | 09:58 |
| opendevreview | Merged openstack/kolla-ansible master: Change regex for the multiline parser at the fluentd rabbitmq input https://review.opendev.org/c/openstack/kolla-ansible/+/879426 | 10:29 |
| opendevreview | Merged openstack/kolla-ansible stable/2023.1: Fix D001 Line too long in mariadb-guide https://review.opendev.org/c/openstack/kolla-ansible/+/893214 | 10:29 |
| opendevreview | Merged openstack/kolla-ansible stable/xena: Fix D001 Line too long in mariadb-guide https://review.opendev.org/c/openstack/kolla-ansible/+/893217 | 10:29 |
| opendevreview | Merged openstack/kolla-ansible stable/yoga: Fix D001 Line too long in mariadb-guide https://review.opendev.org/c/openstack/kolla-ansible/+/893216 | 10:29 |
| opendevreview | Merged openstack/kolla-ansible stable/zed: Fix D001 Line too long in mariadb-guide https://review.opendev.org/c/openstack/kolla-ansible/+/893215 | 10:29 |
| opendevreview | Bartosz Bezak proposed openstack/kolla stable/yoga: Pin iptables to 1.8.4 in Centos Stream 8 https://review.opendev.org/c/openstack/kolla/+/893359 | 11:29 |
| opendevreview | Merged openstack/kayobe master: Fix firewalld configuration for monitoring hosts https://review.opendev.org/c/openstack/kayobe/+/883263 | 12:33 |
| opendevreview | Maksim Malchuk proposed openstack/kayobe stable/2023.1: Fix firewalld configuration for monitoring hosts https://review.opendev.org/c/openstack/kayobe/+/893252 | 12:46 |
| opendevreview | Maksim Malchuk proposed openstack/kayobe stable/zed: Fix firewalld configuration for monitoring hosts https://review.opendev.org/c/openstack/kayobe/+/893253 | 12:46 |
| opendevreview | Bartosz Bezak proposed openstack/kolla stable/xena: Pin iptables to 1.8.4 in Centos Stream 8 https://review.opendev.org/c/openstack/kolla/+/893364 | 12:46 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: ovn: Improve clustering https://review.opendev.org/c/openstack/kolla-ansible/+/868929 | 13:06 |
| opendevreview | Bartosz Bezak proposed openstack/kolla stable/yoga: Pin iptables to 1.8.4 in Centos Stream 8 https://review.opendev.org/c/openstack/kolla/+/893359 | 13:39 |
| opendevreview | Bartosz Bezak proposed openstack/kolla stable/xena: Pin iptables to 1.8.4 in Centos Stream 8 https://review.opendev.org/c/openstack/kolla/+/893364 | 14:00 |
| opendevreview | Merged openstack/kolla stable/xena: Pin iptables to 1.8.4 in Centos Stream 8 https://review.opendev.org/c/openstack/kolla/+/893364 | 17:01 |
| opendevreview | Maksim Malchuk proposed openstack/kolla-ansible stable/2023.1: Use better default bind address for ironic-tftp https://review.opendev.org/c/openstack/kolla-ansible/+/893385 | 17:28 |
| opendevreview | Maksim Malchuk proposed openstack/kolla-ansible stable/zed: Use better default bind address for ironic-tftp https://review.opendev.org/c/openstack/kolla-ansible/+/893386 | 17:28 |
| opendevreview | Maksim Malchuk proposed openstack/kolla-ansible stable/yoga: Use better default bind address for ironic-tftp https://review.opendev.org/c/openstack/kolla-ansible/+/893421 | 17:35 |
| opendevreview | Maksim Malchuk proposed openstack/kolla-ansible stable/xena: Use better default bind address for ironic-tftp https://review.opendev.org/c/openstack/kolla-ansible/+/893422 | 17:48 |
| opendevreview | Maksim Malchuk proposed openstack/kolla stable/xena: Add server-status handler to Rocky/Centos Apache conf https://review.opendev.org/c/openstack/kolla/+/893243 | 17:53 |
| opendevreview | Maksim Malchuk proposed openstack/kolla stable/yoga: Pin iptables to 1.8.4 in Centos Stream 8 https://review.opendev.org/c/openstack/kolla/+/893423 | 17:57 |
| opendevreview | Maksim Malchuk proposed openstack/kolla stable/yoga: Add server-status handler to Rocky/Centos Apache conf https://review.opendev.org/c/openstack/kolla/+/893242 | 17:58 |
| opendevreview | Maksim Malchuk proposed openstack/kolla stable/yoga: Pin iptables to 1.8.4 in Centos Stream 8 https://review.opendev.org/c/openstack/kolla/+/893423 | 18:36 |
| opendevreview | Maksim Malchuk proposed openstack/kolla stable/yoga: Add server-status handler to Rocky/Centos Apache conf https://review.opendev.org/c/openstack/kolla/+/893242 | 18:36 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/xena: Remove upgrade jobs following Wallaby EOL https://review.opendev.org/c/openstack/kayobe/+/893435 | 20:19 |
| opendevreview | Merged openstack/kolla-ansible master: Fix designate-producers not running properly https://review.opendev.org/c/openstack/kolla-ansible/+/892427 | 21:29 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/kolla-ansible stable/2023.1: Fix designate-producers not running properly https://review.opendev.org/c/openstack/kolla-ansible/+/893398 | 23:00 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/kolla-ansible stable/zed: Fix designate-producers not running properly https://review.opendev.org/c/openstack/kolla-ansible/+/893399 | 23:00 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/kolla-ansible stable/yoga: Fix designate-producers not running properly https://review.opendev.org/c/openstack/kolla-ansible/+/893400 | 23:00 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/kolla-ansible stable/xena: Fix designate-producers not running properly https://review.opendev.org/c/openstack/kolla-ansible/+/893441 | 23:00 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!