opendevreview | Xing Zhang proposed openstack/kolla-ansible master: Fix default_share_type for manila-api https://review.opendev.org/c/openstack/kolla-ansible/+/891588 | 04:02 |
---|---|---|
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck https://review.opendev.org/c/openstack/kolla-ansible/+/903871 | 06:58 |
SvenKieske | samcat116: can you tell me more about this amqp exception? is this thrown by the agent itself, or by rabbitmq? | 09:05 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck https://review.opendev.org/c/openstack/kolla-ansible/+/903871 | 09:50 |
opendevreview | scoopex proposed openstack/kolla-ansible master: configuration improvements https://review.opendev.org/c/openstack/kolla-ansible/+/900528 | 09:55 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck https://review.opendev.org/c/openstack/kolla-ansible/+/903871 | 10:40 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: treat ansible-lint warnings as errors https://review.opendev.org/c/openstack/kolla-ansible/+/903942 | 10:47 |
mnasiadka | SvenKieske: ^^ | 10:47 |
SvenKieske | mhm, but did you find docs which say what "strict" actually does? the ansible-lint page is a mess.. | 10:54 |
mnasiadka | https://ansible.readthedocs.io/projects/lint/usage/ | 10:55 |
SvenKieske | ah ty | 10:55 |
SvenKieske | if you search for "strict" on their page this result is buried after a link, because the preview is too long for the page.. | 10:57 |
SvenKieske | all other results are meaningless though and don't explain the term :D | 10:58 |
SvenKieske | mnasiadka: should we add this also as a command line switch to the tox.ini? it's a little split now with config in a dot file and in the tox.ini as commandline switches? | 11:00 |
mnasiadka | SvenKieske: well, if we can have everything in .ansible-lint.cfg then we can drop those options from tox.ini | 11:01 |
mnasiadka | this way at least it's consistent when somebody just runs ansible-lint | 11:01 |
SvenKieske | sure | 11:03 |
SvenKieske | so if we merge my patch the linter will be fine ;) | 11:05 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: treat ansible-lint warnings as errors https://review.opendev.org/c/openstack/kolla-ansible/+/903942 | 11:05 |
mnasiadka | ok, rebased this on your patch, if everything goes green - I'll merge it, it's CI only basically | 11:06 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: quorum: add missing octavia and masakari https://review.opendev.org/c/openstack/kolla-ansible/+/903946 | 11:13 |
SvenKieske | oh, did I miss some services? :/ | 11:27 |
mnasiadka | seems so | 11:28 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck https://review.opendev.org/c/openstack/kolla-ansible/+/903871 | 11:49 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: WIP: CI: Template out kolla-build.conf using role https://review.opendev.org/c/openstack/kolla-ansible/+/903771 | 11:57 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: Drop masakari jobs from project.yml https://review.opendev.org/c/openstack/kolla-ansible/+/903969 | 12:07 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: Drop masakari jobs from project.yaml https://review.opendev.org/c/openstack/kolla-ansible/+/903969 | 12:11 |
samcat116 | SvenKieske: it was being thrown by the agent itself. I looked into it more and it seems like the agent forces auto_delete to true no matter what you set in the config. auto_delete isn’t compatible with quorum queues | 12:36 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck https://review.opendev.org/c/openstack/kolla-ansible/+/903871 | 12:49 |
opendevreview | Matúš Jenča proposed openstack/kolla-ansible master: Implement Redis as caching backend https://review.opendev.org/c/openstack/kolla-ansible/+/903978 | 12:50 |
sylvr | Hi ! I'm using kayobe and in my deployment network and controllers are different nodes, should I add a file for network in inventory/group_vars for network nodes ? I already tweaked inventory/groups to separate network from controllers | 12:54 |
opendevreview | Merged openstack/kolla-ansible master: CI: fix two ansible-lint warnings https://review.opendev.org/c/openstack/kolla-ansible/+/903906 | 12:59 |
opendevreview | Merged openstack/kolla-ansible master: CI: treat ansible-lint warnings as errors https://review.opendev.org/c/openstack/kolla-ansible/+/903942 | 13:00 |
opendevreview | Merged openstack/kolla-ansible master: CI: Drop masakari jobs from project.yaml https://review.opendev.org/c/openstack/kolla-ansible/+/903969 | 13:00 |
mnasiadka | sylvr: you can use group_vars or host_vars | 13:02 |
sylvr | thanks! also, for now, all of my nodes are put in the same group (controllers) is it normal or should they already be "sorted" within the correct groups ? (according to their network interfaces for exemple) | 13:04 |
SvenKieske | samcat116: then that sounds like a bug worth reporting to the ironic folks? if they plan to support quorum queues, that is. | 13:14 |
SvenKieske | samcat116: If you file a bug, please link it here, so I can track that. if you can't file a bugreport yourself I can do that as well, but I would need a little bit more details like versions deployed, exact error message etc. | 13:15 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck https://review.opendev.org/c/openstack/kolla-ansible/+/903871 | 13:54 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck https://review.opendev.org/c/openstack/kolla-ansible/+/903871 | 14:26 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: WIP: CI: Template out kolla-build.conf using role https://review.opendev.org/c/openstack/kolla-ansible/+/903771 | 14:26 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.1: provide a flag to enable quorum queues https://review.opendev.org/c/openstack/kolla-ansible/+/902387 | 14:51 |
samcat116 | SvenKieske: Bug filed: https://bugs.launchpad.net/networking-baremetal/+bug/2046962 | 14:58 |
*** EugenMayer440189 is now known as EugenMayer44018 | 14:59 | |
SvenKieske | samcat116: thank you! | 15:00 |
SvenKieske | samcat116: looking at that code I maybe can even provide a sane patch for that, let's see if I find some time for that | 15:02 |
samcat116 | I was thinking that, but looking back at the reason it was introduced, I am not familiar enough with RabbitMQ to try and achieve the same thing with a newer method | 15:03 |
mnasiadka | samcat116: posted a reply - that should work as a workaround | 15:18 |
mnasiadka | samcat116: seems this is at least 4 years old - https://storyboard.openstack.org/#!/story/2004933 | 15:22 |
mnasiadka | but yes, quorum queues are to be persistent, so not temporary, so not autodeleted | 15:23 |
mnasiadka | maybe networking-baremetal should finally decide how they want to use RMQ | 15:23 |
SvenKieske | mnasiadka: I proposed a patch for networking-baremetal | 15:31 |
SvenKieske | I read the upstream code as, if this is disabled by config they explicitly enable that setting, so your workaround should not work? | 15:32 |
SvenKieske | ah my bad, I read that wrong | 15:32 |
SvenKieske | yeah I found the old commit mentioning this/that introduced this. It somehow feels like they are really using this message system wrong.. | 15:33 |
SvenKieske | they should use a queue/message system that guarantees at-least-once-delivery to each consumer and not invent funny algorithms that reinvent solutions to already solved problems. | 15:35 |
SvenKieske | samcat116: maybe you can test my patch? don't know if neutron will accept it, but worth a try? :) | 15:36 |
mnasiadka | SvenKieske: I think they invented this to orchestrate a rename for their queues, but what do I know ;) | 15:37 |
SvenKieske | interesting that OVH and others didn't stumble upon this, well maybe they don't use this agent | 15:38 |
mnasiadka | maybe they don't use Ironic ;) | 15:42 |
SvenKieske | might be :) do you think I can review the quorum queue precheck now or do you want to fiddle with it some more? :) | 15:44 |
mnasiadka | I think you can review, it's passing | 15:46 |
mnasiadka | at least the opensearch jobs are passing now | 15:48 |
mnasiadka | and you can see which queue is misconfigured | 15:48 |
SvenKieske | that's pretty nice; I had to look up that loop_control label stuff again though :D | 15:49 |
opendevreview | scoopex proposed openstack/kolla-ansible master: rabbitmq: configuration improvements https://review.opendev.org/c/openstack/kolla-ansible/+/900528 | 16:01 |
opendevreview | Merged openstack/kolla-ansible master: quorum: add missing octavia and masakari https://review.opendev.org/c/openstack/kolla-ansible/+/903946 | 16:12 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.2: quorum: add missing octavia and masakari https://review.opendev.org/c/openstack/kolla-ansible/+/904003 | 16:16 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.1: quorum: add missing octavia and masakari https://review.opendev.org/c/openstack/kolla-ansible/+/904004 | 16:16 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/zed: quorum: add missing octavia and masakari https://review.opendev.org/c/openstack/kolla-ansible/+/904005 | 16:17 |
SvenKieske | meh, some of these backports should probably wait until the proper quorum support is there in these release, but at least I will not forget them this way :D | 16:26 |
mnasiadka | would make sense to stack them on top of the quorum patch | 16:33 |
mnasiadka | so we don't merge them before :) | 16:33 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/2023.2: CI: treat ansible-lint warnings as errors https://review.opendev.org/c/openstack/kolla-ansible/+/904006 | 16:35 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/2023.1: CI: treat ansible-lint warnings as errors https://review.opendev.org/c/openstack/kolla-ansible/+/904007 | 16:35 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/zed: CI: treat ansible-lint warnings as errors https://review.opendev.org/c/openstack/kolla-ansible/+/904008 | 16:36 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/yoga: CI: treat ansible-lint warnings as errors https://review.opendev.org/c/openstack/kolla-ansible/+/904009 | 16:36 |
SvenKieske | well let me first backport the CI lint fixes ;) | 16:57 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.2: CI: fix two ansible-lint warnings https://review.opendev.org/c/openstack/kolla-ansible/+/904010 | 16:57 |
NeilHanlon | mnasiadka: just wondering, how have rocky jobs been for you the last ... week or so? | 16:58 |
SvenKieske | mhm, already got a merge conflict on stable/2023.1 .. :/ | 16:58 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.1: CI: fix two ansible-lint warnings https://review.opendev.org/c/openstack/kolla-ansible/+/904011 | 17:00 |
SvenKieske | nvm, that backport is unneeded for 2023.1 | 17:04 |
mnasiadka | NeilHanlon: I think they have been ok, but we haven't switched to baseurl vs mirrorlist | 17:57 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.1: provide a flag to enable quorum queues https://review.opendev.org/c/openstack/kolla-ansible/+/902387 | 18:01 |
opendevreview | Merged openstack/kolla-ansible master: Rework quorum queues precheck https://review.opendev.org/c/openstack/kolla-ansible/+/903871 | 19:11 |
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: WIP: CI: Template out kolla-build.conf using role https://review.opendev.org/c/openstack/kolla-ansible/+/903771 | 19:36 |
opendevreview | Pierre Riteau proposed openstack/kayobe-config-dev master: [DNM] Testing ansible facts https://review.opendev.org/c/openstack/kayobe-config-dev/+/904037 | 20:59 |
opendevreview | Pierre Riteau proposed openstack/kayobe master: [DNM] Testing ansible facts https://review.opendev.org/c/openstack/kayobe/+/904038 | 21:01 |
opendevreview | Pierre Riteau proposed openstack/kayobe-config-dev master: Use dummy1 as bridge port instead of eth1 https://review.opendev.org/c/openstack/kayobe-config-dev/+/904044 | 22:49 |
opendevreview | Pierre Riteau proposed openstack/kayobe master: Use dummy1 as bridge port instead of eth1 https://review.opendev.org/c/openstack/kayobe/+/904045 | 22:53 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!