opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: [yoga-only]: Use pyroute2 from distro vendors https://review.opendev.org/c/openstack/kolla/+/904781 | 05:53 |
---|---|---|
opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/yoga: CI: Test Nova server resize functionality https://review.opendev.org/c/openstack/kolla-ansible/+/904285 | 06:06 |
mnasiadka | btw, I’m off today - but would like to get reviews on 904781 if possible | 07:57 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Fix long service restarts while using systemd https://review.opendev.org/c/openstack/kolla-ansible/+/904805 | 07:58 |
mnasiadka | kevko: I meant an explanation why it’s 143 (128 + sigterm) - not the list in commit message :) | 08:05 |
mnasiadka | (Sorry for maybe being not enough detail in the comment) | 08:06 |
mnasiadka | It’s a bit weird that the list is so limited | 08:08 |
mnasiadka | Probably those services do not handle sigterm properly, as in it should exit 0 on sigterm, but they don’t (but still they terminate so it’s not sigkill) - I’ll do some digging on Monday | 08:15 |
mnasiadka | frickler: any thoughts? ^^ | 08:15 |
kevko | mnasiadka: check chatgpt answer :D :D ..i've posted into review :D | 08:44 |
kevko | mnasiadka: i'm surprised that it is very nice answer :P | 08:45 |
kevko | In summary, receiving a 143 exit code when stopping a Docker container is normal and indicates that the container was stopped due to receiving a SIGTERM signal. To change this behavior, you'd typically look into how the application inside the container handles signals and whether it can intercept and override the default action for SIGTERM. << | 08:45 |
kevko | This is main idea | 08:45 |
kevko | check it in comments | 08:46 |
bbezak | maybe let's add related-bug for now flag | 08:46 |
kevko | bbezak: why related-bug ? | 08:46 |
bbezak | or Partial-Bug - not to close the bug - until we're 100% sure that it can't be made exit 0 for all services | 08:48 |
bbezak | but it looks good for now - 143 looks harmless - maybe just not ideal | 08:49 |
bbezak | as we simply ignored 143 until today :) | 08:49 |
kevko | bbezak: but I am 100% sure that it can't be made exit 0 for all services ... | 08:50 |
kevko | bbezak: or do you want to compile your own haproxy for example and rewrite the code ? or openvswitch ? or others ? | 08:50 |
kevko | bbezak: well, i mainly testing master and other stable releases on my testing environment ..so i can also see differencies by an eye ...that's the reason why i started to investigate ... in CI it's just not visible | 08:51 |
mnasiadka | Let’s discuss it next week, it’s not urgent - although high priority bug | 08:55 |
bbezak | yeah, I've noticed it yesterday afternoon in one env on antelope. I agree that we probably won't be able to fix all services. I think partial-bug for now is a good idea | 08:55 |
bbezak | and let's merge it | 08:55 |
bbezak | and backport it | 08:55 |
kevko | bbezak: +1 | 09:06 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Fix long service restarts while using systemd https://review.opendev.org/c/openstack/kolla-ansible/+/904805 | 09:07 |
kevko | fg | 09:07 |
kevko | anyone for +2 or you want to discuss mnasiadka ? | 09:09 |
opendevreview | Mark Goddard proposed openstack/kolla-ansible stable/2023.2: post-2023.1: Remove keystone admin endpoint bits https://review.opendev.org/c/openstack/kolla-ansible/+/904724 | 09:45 |
kevko | frickler: how are u changing the status of launchpad bug ? api ? do i have permissions for that for example ? | 10:06 |
frickler | kevko: just via the UI. you'd need to be in some bug manager group on LP for that | 10:13 |
opendevreview | Dawud proposed openstack/kolla-ansible master: Remove the `grafana` volume https://review.opendev.org/c/openstack/kolla-ansible/+/899136 | 10:25 |
kevko | frickler: and should I ? | 10:28 |
opendevreview | Merged openstack/kolla stable/yoga: [yoga-only]: Use pyroute2 from distro vendors https://review.opendev.org/c/openstack/kolla/+/904781 | 10:29 |
opendevreview | Dawud proposed openstack/kolla-ansible master: Enable HAProxy Prometheus metrics endpoint https://review.opendev.org/c/openstack/kolla-ansible/+/877118 | 10:36 |
opendevreview | Mark Goddard proposed openstack/kolla-ansible master: cadvisor: Set housekeeping interval to Prometheus scrape interval https://review.opendev.org/c/openstack/kolla-ansible/+/904823 | 11:03 |
bbezak | https://launchpad.net/~kolla-drivers/+members#active | 11:06 |
bbezak | kevko, frickler | 11:06 |
frickler | best check with mnasiadka as PTL. that list also looks like some cleanup would be useful, but I think only admins can do that | 11:53 |
bbezak | indeed | 11:54 |
opendevreview | Pierre Riteau proposed openstack/kolla-ansible master: CI: Test Nova server resize functionality https://review.opendev.org/c/openstack/kolla-ansible/+/904249 | 12:07 |
opendevreview | Pierre Riteau proposed openstack/kolla-ansible master: CI: Test Nova server resize functionality https://review.opendev.org/c/openstack/kolla-ansible/+/904249 | 12:07 |
opendevreview | Pierre Riteau proposed openstack/kolla-ansible master: CI: Test Nova server resize functionality https://review.opendev.org/c/openstack/kolla-ansible/+/904249 | 12:10 |
bbezak | kevko: your're now hereby a member of kolla drivers team in launchpad | 12:32 |
kevko | bbezak: oh, thanks | 12:54 |
*** hrww is now known as hrw | 13:19 | |
opendevreview | Merged openstack/kolla-ansible master: Fix long service restarts while using systemd https://review.opendev.org/c/openstack/kolla-ansible/+/904805 | 13:38 |
opendevreview | Michal Arbet proposed openstack/kolla master: Drop root privileges for ovn https://review.opendev.org/c/openstack/kolla/+/665117 | 13:44 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible stable/2023.2: Fix long service restarts while using systemd https://review.opendev.org/c/openstack/kolla-ansible/+/904740 | 13:53 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible stable/2023.1: Fix long service restarts while using systemd https://review.opendev.org/c/openstack/kolla-ansible/+/904841 | 13:53 |
opendevreview | Pierre Riteau proposed openstack/kolla-ansible master: Configure sftp subsystem on Debian https://review.opendev.org/c/openstack/kolla-ansible/+/904838 | 14:02 |
opendevreview | Merged openstack/kayobe stable/2023.2: Ensure git is present before checkout tasks https://review.opendev.org/c/openstack/kayobe/+/904265 | 14:30 |
opendevreview | Merged openstack/kayobe stable/2023.1: Ensure git is present before checkout tasks https://review.opendev.org/c/openstack/kayobe/+/904266 | 14:30 |
opendevreview | Merged openstack/kayobe stable/zed: Ensure git is present before checkout tasks https://review.opendev.org/c/openstack/kayobe/+/904267 | 14:30 |
opendevreview | Merged openstack/kayobe stable/yoga: Ensure git is present before checkout tasks https://review.opendev.org/c/openstack/kayobe/+/904268 | 14:30 |
opendevreview | Martin Hiner proposed openstack/kolla-ansible master: Add container engine migration scenario https://review.opendev.org/c/openstack/kolla-ansible/+/836941 | 15:43 |
opendevreview | Pierre Riteau proposed openstack/kolla-ansible master: [DNM] Dummy change to trigger all CI jobs https://review.opendev.org/c/openstack/kolla-ansible/+/904864 | 15:45 |
opendevreview | Tadas proposed openstack/kolla master: add: cross-compile support https://review.opendev.org/c/openstack/kolla/+/889139 | 22:09 |
opendevreview | Tadas proposed openstack/kolla master: add: cross-compile support https://review.opendev.org/c/openstack/kolla/+/904880 | 22:16 |
opendevreview | Tadas proposed openstack/kolla master: remove IDE leftovers https://review.opendev.org/c/openstack/kolla/+/904881 | 22:19 |
opendevreview | Tadas proposed openstack/kolla master: remove IDE leftovers https://review.opendev.org/c/openstack/kolla/+/904882 | 22:30 |
opendevreview | Tadas proposed openstack/kolla master: add: cross-compile support https://review.opendev.org/c/openstack/kolla/+/904883 | 22:33 |
opendevreview | Tadas proposed openstack/kolla master: add: cross-compile support https://review.opendev.org/c/openstack/kolla/+/889139 | 22:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!