| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Fix coordination when redis used https://review.opendev.org/c/openstack/kolla-ansible/+/912341 | 06:32 |
|---|---|---|
| kevko | frickler, mnasiadka: Takashi reverting stuff around auth in tooz ... | 06:42 |
| mnasiadka | kevko: saw the mail, thanks ;) | 07:00 |
| kevko | mnasiadka: I still don't understand why Takashi wants to revert auth stuff | 07:06 |
| kevko | mnasiadka: as per his last email and my answer ... | 07:07 |
| mnasiadka | kevko: because maybe there are other people using it as we have been using ;-) | 07:07 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Fix creation of ovs bridges https://review.opendev.org/c/openstack/kolla-ansible/+/911591 | 07:08 |
| kevko | mnasiadka: yeah - maybe .... question is if it will work also after revert .. | 07:08 |
| mnasiadka | haha | 07:09 |
| kevko | I really hate all those machinations with code, reverts, release exceptions, and the like.... I just want to work and don't want to fix fix other things at night. :D | 07:12 |
| * frickler is glad that we have a CI that tells us about these issues. much better than to find out in production | 07:17 | |
| kevko | +1 | 07:20 |
| kevko | well, i found it firstly in my downstream CI :) | 07:25 |
| kevko | Why do I feel like everyone is releasing new versions and everything breaks, especially during RC1 and similar important time periods? :D | 07:27 |
| frickler | well that's what rc1 is for. one could argue whether projects would need to do more cross testing before, but then issues like CI bloat and instability come up | 07:36 |
| kevko | mnasiadka: frickler: so, does it mean that we are frozen for now - nothing can be merged until tooz,taskflow will be fixed/released and kolla images built and available in quay ? OR we can merge stuff as we have chain against which CI works and we can for example merge kolla-ansible stuff .. | 07:37 |
| frickler | well currently I don't see a chain of patches that passes CI completely. we also need to decide whether to cap or unpin tooz | 07:39 |
| kevko | frickler: this is passing https://review.opendev.org/c/openstack/kolla-ansible/+/912341 | 07:44 |
| kevko | frickler: for example this can be merged for sure ...as it is k-a https://review.opendev.org/c/openstack/kolla-ansible/+/911591/10 ..and passing | 07:44 |
| frickler | kevko: but depends-on is failing | 07:44 |
| kevko | frickler: it was some type of timeout if i remember correct ..recheck will work i woud say | 07:46 |
| kevko | which is currectly in progress | 07:46 |
| opendevreview | Ivan Halomi proposed openstack/ansible-collection-kolla master: Bump min. version of docker-py https://review.opendev.org/c/openstack/ansible-collection-kolla/+/910751 | 08:22 |
| mnasiadka | frickler: should we cap for now? I can restore the patch in Kolla | 08:37 |
| mnasiadka | https://review.opendev.org/c/openstack/kolla/+/911703?tab=change-view-tab-header-zuul-results-summary | 08:38 |
| mnasiadka | well, basically we can just merge it now | 08:38 |
| mnasiadka | and revert once things are safe | 08:38 |
| frickler | mnasiadka: those octavia failures worry me, but they seem to be happening for > 2 weeks already, so likely unrelated. so +2 to capping and waiting for tooz to stabilize | 08:42 |
| mnasiadka | I'll have a look in all failing jobs | 08:42 |
| mnasiadka | ubuntu-swift is failing due to some Ubuntu kernel bug, the same thing happens in Kayobe | 08:42 |
| frickler | kevko: can you depend your stack on ^^ instead? | 08:44 |
| kevko | frickler: yes of course, let me do it | 08:45 |
| opendevreview | Matúš Jenča proposed openstack/kolla-ansible master: Implement TLS for Redis https://review.opendev.org/c/openstack/kolla-ansible/+/909188 | 08:45 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Fix coordination when redis used https://review.opendev.org/c/openstack/kolla-ansible/+/912341 | 08:50 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Fix creation of ovs bridges https://review.opendev.org/c/openstack/kolla-ansible/+/911591 | 08:50 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: magnum: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912358 | 08:55 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: octavia: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912359 | 09:07 |
| mnasiadka | frickler: ^^ that should fix octavia, let's see | 09:07 |
| mnasiadka | will continue with other services | 09:07 |
| mnasiadka | frickler: should we drop Murano? | 09:10 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: octavia: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912359 | 09:12 |
| opendevreview | Roman Krček proposed openstack/kolla-ansible master: Split ipv4 and ipv6 systemctl config https://review.opendev.org/c/openstack/kolla-ansible/+/905831 | 09:16 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: heat: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912360 | 09:16 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: manila: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912361 | 09:16 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: neutron: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912362 | 09:16 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: zun: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912364 | 09:20 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: designate: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912365 | 09:20 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: kuryr: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912366 | 09:20 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: cyborg: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912367 | 09:20 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: murano: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912368 | 09:20 |
| mnasiadka | hmm, why is https://review.opendev.org/c/openstack/kolla/+/911703 not gating? | 09:24 |
| mnasiadka | frickler: another gerrit bug? ;-) | 09:24 |
| mnasiadka | even recheck doesn't work | 09:26 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: openstack-base: Pin tooz to 5.0.0 https://review.opendev.org/c/openstack/kolla/+/911703 | 09:28 |
| kevko | mnasiadka: depends on | 09:30 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: openstack-base: Pin tooz to 5.0.0 https://review.opendev.org/c/openstack/kolla/+/911703 | 09:30 |
| mnasiadka | holy crap | 09:30 |
| mnasiadka | it would be easier if zuul would send a comment that depends-on is abandoned, not doing shit | 09:30 |
| mnasiadka | :) | 09:30 |
| kevko | :D | 09:31 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: Fix aarch64 builds https://review.opendev.org/c/openstack/kolla/+/909915 | 09:33 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: Fix aarch64 builds https://review.opendev.org/c/openstack/kolla/+/909915 | 09:34 |
| mnasiadka | that one also needs to get in :) | 09:35 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: magnum: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912358 | 09:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: octavia: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912359 | 09:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: heat: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912360 | 09:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: manila: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912361 | 09:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: neutron: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912362 | 09:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: zun: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912364 | 09:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: designate: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912365 | 09:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: kuryr: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912366 | 09:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: cyborg: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912367 | 09:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: murano: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912368 | 09:38 |
| opendevreview | Ivan Halomi proposed openstack/ansible-collection-kolla master: Bump min. version of docker-py https://review.opendev.org/c/openstack/ansible-collection-kolla/+/910751 | 09:38 |
| mnasiadka | updated depends-on to point to tooz pin | 09:38 |
| opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.2: Keystone: Add service role https://review.opendev.org/c/openstack/kolla-ansible/+/912066 | 09:43 |
| SvenKieske | mnasiadka: seems we forgot to add the service role to the 2023.2 branch? at least I can't find it so far? | 09:44 |
| mnasiadka | SvenKieske: because keystone started to create that role in bootstrap since 2023.2 | 09:45 |
| SvenKieske | I'm also wondering why we didn't put the original patchset on master branch to begin with | 09:45 |
| mnasiadka | https://review.opendev.org/c/openstack/keystone/+/863420 | 09:45 |
| mnasiadka | so that's why it's not needed there | 09:45 |
| SvenKieske | mhm, weird, then it seems bootstrap isn't run on every upgrade somehow | 09:46 |
| mnasiadka | if it would be the case - then the cinder/nova service role patch would fail in CI | 09:48 |
| mnasiadka | and it passed nicely - https://review.opendev.org/c/openstack/kolla-ansible/+/909542?tab=change-view-tab-header-zuul-results-summary | 09:49 |
| SvenKieske | seems correct as far as I can see. weird, I wonder what is causing this issue downstream then. | 10:03 |
| kevko | SvenKieske: what downstream issue ...role cannot be found ? or what ? | 10:05 |
| SvenKieske | yeah, some users don't have that role, as I stated on friday when I began the investigation, in the meantime it seems we merged https://github.com/osism/container-image-kolla-ansible/pull/593/files but, I don't understand why we need it downstream on 2023.2 when upstream doesn't have it on that branch. either we are not seeing the issue upstream because we don't look hard enough or there is some other weird | 10:10 |
| SvenKieske | interaction. | 10:10 |
| SvenKieske | long lines and IRC will never be friends it seems :) | 10:11 |
| mnasiadka | you keep patches as files instead of having a proper fork? brave ;-) | 10:11 |
| SvenKieske | I don't know the history of that, I could imagine it's intentional to not have patching downstream being the happy path, we have very few patches actually | 10:15 |
| SvenKieske | that's also why I think about this problem so much, it doesn't seem we have any downstream patch that would explain this issue. | 10:16 |
| SvenKieske | mnasiadka: when I grep the upgrade job (https://zuul.opendev.org/t/openstack/build/57aaffa9822e4c8f8cda493459748e98) it doesn't say that it creates the service role | 10:31 |
| opendevreview | Roman Krček proposed openstack/kolla-ansible master: Fix trove module imports https://review.opendev.org/c/openstack/kolla-ansible/+/912378 | 10:32 |
| SvenKieske | https://github.com/openstack/keystone/blob/stable/2023.2/keystone/cmd/bootstrap.py#L130 is clearly being called (in the keystone bootstrap code with the service role, but the keystone log doesn't contain that. mhm | 10:33 |
| mnasiadka | SvenKieske: and are you sure keystone bootstrap cli says that it creates the role on non-upgrade jobs? | 10:33 |
| SvenKieske | that's what I wanted to look into now :D | 10:33 |
| mnasiadka | SvenKieske: I don't think we even log the bootstrap contents anywhere - https://github.com/openstack/kolla/blob/master/docker/keystone/keystone/keystone_bootstrap.sh | 10:35 |
| SvenKieske | yes it does: https://zuul.opendev.org/t/openstack/build/848d8f605b7449a38efb65f08f530a62/log/primary/logs/kolla/keystone/keystone.txt#70 | 10:35 |
| SvenKieske | but here it doesn't: https://zuul.opendev.org/t/openstack/build/57aaffa9822e4c8f8cda493459748e98/log/primary/logs/kolla/keystone/keystone.txt#74 | 10:38 |
| mnasiadka | so then it needs to work :) | 10:38 |
| mnasiadka | lol | 10:38 |
| SvenKieske | yeah :) | 10:39 |
| mnasiadka | then maybe we just need to add that in upgrade task for 2023.2, just to be sure | 10:39 |
| SvenKieske | so we are thus again at my backport above :D | 10:39 |
| mnasiadka | but if you run deploy with fresh 2023.1 code | 10:39 |
| mnasiadka | then you'll have that role anyway | 10:39 |
| SvenKieske | yeah, this is mostly a concern for older deployments I guess | 10:39 |
| mnasiadka | it's not backport | 10:39 |
| SvenKieske | I still don't understand _why_ though :D | 10:39 |
| mnasiadka | it's forwardport | 10:40 |
| SvenKieske | yeah | 10:40 |
| SvenKieske | let me fix the merge conflict | 10:40 |
| mnasiadka | and I think it should be a separate patch, because we only need to do it on upgrade | 10:40 |
| mnasiadka | not a normal deploy | 10:40 |
| SvenKieske | yes | 10:41 |
| mnasiadka | well, in upgrade we do this: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/keystone/tasks/upgrade.yml - actually this: https://github.com/openstack/kolla-ansible/blob/5169e3bcbe556eadbe60644f7acbed6e5d6ed358/ansible/roles/keystone/handlers/main.yml#L15 - so we run keystone_manage db_sync (as per | 10:42 |
| mnasiadka | https://github.com/openstack/kolla/blob/4b32dd50ab027e2b19c7c69f7fc5019ec3d1add7/docker/keystone/keystone/extend_start.sh#L24) | 10:42 |
| mnasiadka | so we don't run bootstrap on upgrade | 10:42 |
| mnasiadka | and that explains it | 10:42 |
| SvenKieske | I guess I saw that, but we run service-ks-register which in theory should also create roles? I found the code split there a little confusing tbh, some roles are only created via keystone bootstrap, other's are created via the service-ks-register role | 10:44 |
| mnasiadka | but we don't create those roles in 2023.2 - because we assume those are there | 10:44 |
| SvenKieske | I get that we want to create user supplied roles as well, but we should maybe move the service role from service-ks-register to keystone bootstrap? not sure though. | 10:45 |
| SvenKieske | because the service role is imho a system role, not something that should be configurable by users | 10:45 |
| mnasiadka | well, in register.yml we run bootstrap, but it's not called on upgrade :) | 10:46 |
| opendevreview | Ivan Halomi proposed openstack/kolla-ansible master: Refactor of kolla_container_facts https://review.opendev.org/c/openstack/kolla-ansible/+/911417 | 10:48 |
| SvenKieske | yeah I already saw that | 10:49 |
| SvenKieske | not sure if we should fix this via the extend_start.sh or via register.yml? it seems weird that all this stuff is spread over several files, I know there are many historical reasons why it is the case, but still :D | 10:50 |
| opendevreview | Ivan Halomi proposed openstack/kolla-ansible master: Refactor of kolla_container_facts https://review.opendev.org/c/openstack/kolla-ansible/+/911417 | 10:57 |
| opendevreview | Ivan Halomi proposed openstack/kolla-ansible master: Move actions to kolla_container_facts https://review.opendev.org/c/openstack/kolla-ansible/+/911505 | 10:59 |
| mnasiadka | SvenKieske: I think we just need to downsize the patch you're ''forwardporting'' to add a section in upgrade.yml to call service-ks-register and create the bloody role | 10:59 |
| SvenKieske | mnasiadka: seems sensible, should I propose a new patch from scratch or just adjust this one? | 11:01 |
| mnasiadka | new patch from scratch would be better I guess | 11:01 |
| SvenKieske | okay, fine | 11:01 |
| mnasiadka | kevko, frickler: Can you have a look in https://review.opendev.org/c/openstack/kolla/+/909915? It fixes aarch64 builds that I broke with the sources.py patch :) | 11:34 |
| kevko | mnasiadka: done | 11:42 |
| mnasiadka | thx | 11:43 |
| opendevreview | Roman Krček proposed openstack/kolla-ansible master: Fix trove module imports https://review.opendev.org/c/openstack/kolla-ansible/+/912378 | 11:54 |
| opendevreview | Roman Krček proposed openstack/kolla-ansible master: Split ipv4 and ipv6 systemctl config https://review.opendev.org/c/openstack/kolla-ansible/+/905831 | 11:56 |
| opendevreview | Alex Welsh proposed openstack/kolla-ansible master: WIP: Automate prometheus blackbox endpoint config https://review.opendev.org/c/openstack/kolla-ansible/+/912420 | 11:57 |
| opendevreview | Alex Welsh proposed openstack/kolla-ansible master: WIP: Automate prometheus blackbox endpoint config https://review.opendev.org/c/openstack/kolla-ansible/+/912420 | 11:59 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: Bump rabbitmq to 3.13 https://review.opendev.org/c/openstack/kolla/+/911093 | 12:31 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: octavia: Use valid_interfaces instead of endpoint_type https://review.opendev.org/c/openstack/kolla-ansible/+/912359 | 12:49 |
| mnasiadka | ok, tooz pin is gating, we should be good tomorrow | 12:50 |
| mnasiadka | (unless it fails in gate) | 12:50 |
| opendevreview | Ivan Halomi proposed openstack/kolla-ansible master: Refactor of kolla_container_facts https://review.opendev.org/c/openstack/kolla-ansible/+/911417 | 12:54 |
| opendevreview | Ivan Halomi proposed openstack/kolla-ansible master: Move actions to kolla_container_facts https://review.opendev.org/c/openstack/kolla-ansible/+/911505 | 12:55 |
| opendevreview | Merged openstack/kolla master: Fix aarch64 builds https://review.opendev.org/c/openstack/kolla/+/909915 | 13:22 |
| opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.2: fix creation of keystone service role on upgrade https://review.opendev.org/c/openstack/kolla-ansible/+/912452 | 13:29 |
| opendevreview | Simon Dodsley proposed openstack/kolla-ansible master: Add Pure Storage FlashBlade as Manila backend https://review.opendev.org/c/openstack/kolla-ansible/+/879846 | 13:33 |
| opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.2: fix creation of keystone service role on upgrade https://review.opendev.org/c/openstack/kolla-ansible/+/912452 | 13:35 |
| kevko | mnasiadka: frickler: so can we merge also https://review.opendev.org/c/openstack/kolla-ansible/+/911591/11 both in chain ? | 14:10 |
| opendevreview | Ivan Halomi proposed openstack/kolla-ansible master: Refactor of kolla_container_facts https://review.opendev.org/c/openstack/kolla-ansible/+/911417 | 14:21 |
| opendevreview | Ivan Halomi proposed openstack/kolla-ansible master: Move actions to kolla_container_facts https://review.opendev.org/c/openstack/kolla-ansible/+/911505 | 14:21 |
| opendevreview | Merged openstack/kolla master: openstack-base: Pin tooz to 5.0.0 https://review.opendev.org/c/openstack/kolla/+/911703 | 14:35 |
| opendevreview | Ivan Halomi proposed openstack/kolla-ansible master: Merge of container_facts modules https://review.opendev.org/c/openstack/kolla-ansible/+/912460 | 14:36 |
| opendevreview | Ivan Halomi proposed openstack/kolla-ansible master: Merge of container_facts modules https://review.opendev.org/c/openstack/kolla-ansible/+/912460 | 14:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: Bump rabbitmq to 3.13 https://review.opendev.org/c/openstack/kolla/+/911093 | 15:11 |
| opendevreview | Merged openstack/kolla-ansible master: Fix coordination when redis used https://review.opendev.org/c/openstack/kolla-ansible/+/912341 | 15:55 |
| SvenKieske | can this error be related to the recent tooz breakage? "TypeError: Redis.__init__() got multiple values for argument 'host'" | 15:57 |
| SvenKieske | I got this in https://zuul.opendev.org/t/openstack/build/995f77b643d34228b5d41a2a69001c60/log/primary/logs/kolla/cinder/cinder-api-error.txt | 16:00 |
| SvenKieske | could be related to https://review.opendev.org/c/openstack/tooz/+/911648/2/tooz/drivers/redis.py I guess | 16:01 |
| kevko | SvenKieske: yes | 16:08 |
| SvenKieske | mhm, so I'm not sure if this tooz fix fixes our sentinel problem or made it worse? :D | 16:21 |
| SvenKieske | ah mnasiadka commented, thanks for the heads up! I was not aware the multinode jobs are still broken! I thought somehow the pinning was already done and effective | 16:22 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: rabbitmq: configuration improvements https://review.opendev.org/c/openstack/kolla-ansible/+/900528 | 16:23 |
| kevko | SvenKieske: rebased .... | 16:23 |
| kevko | SvenKieske: sorry ...i meant add depends-on | 16:23 |
| SvenKieske | kevko: thank you, but Michal commented that we need to wait for the new pinned tooz images which seem to be available only tomorrow? | 16:23 |
| SvenKieske | at least for the multinode jobs | 16:23 |
| kevko | SvenKieske: if you have depends-on, you will have a fresh images .. | 16:25 |
| SvenKieske | ah, I just reread the ML thread around tooz, I was not aware of the additional breakage in other projects, good to know | 16:28 |
| opendevreview | Merged openstack/kolla-ansible master: Fix creation of ovs bridges https://review.opendev.org/c/openstack/kolla-ansible/+/911591 | 16:29 |
| kevko | we have also compare container broken :D | 16:51 |
| kevko | aaaaa | 16:51 |
| opendevreview | Uwe Jäger proposed openstack/kolla-ansible master: Skyline configure Prometheus https://review.opendev.org/c/openstack/kolla-ansible/+/910514 | 17:09 |
| opendevreview | Martin Hiner proposed openstack/kolla-ansible master: Move actions to kolla_container_facts https://review.opendev.org/c/openstack/kolla-ansible/+/911505 | 17:13 |
| kevko | mnasiadka: who removed docker_common_options option from kolla ? :( | 17:28 |
| kevko | mnasiadka: it completly broke compare container :'( | 17:29 |
| kevko | not removed ..but now it's broken i would say | 17:30 |
| kevko | :'( | 17:42 |
| kevko | compare_container functionality is just broken when environment changed | 17:42 |
| opendevreview | Doug Szumski proposed openstack/kolla-ansible master: Support custom Nova Compute Ironic host names https://review.opendev.org/c/openstack/kolla-ansible/+/912483 | 17:47 |
| opendevreview | Doug Szumski proposed openstack/kolla-ansible master: Support custom Nova Compute Ironic host names https://review.opendev.org/c/openstack/kolla-ansible/+/912483 | 17:48 |
| opendevreview | Doug Szumski proposed openstack/kolla-ansible master: Support custom Nova Compute Ironic host names https://review.opendev.org/c/openstack/kolla-ansible/+/912483 | 17:53 |
| opendevreview | Uwe Jäger proposed openstack/kolla-ansible master: Update Skyline configuration to enable SSO https://review.opendev.org/c/openstack/kolla-ansible/+/905860 | 18:07 |
| kevko | Well, in the end, it's not, it's just me being silly :D :D | 18:20 |
| mnasiadka | Lol | 18:22 |
| SvenKieske | :D | 18:23 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: Revert "openstack-base: Pin tooz to 5.0.0" https://review.opendev.org/c/openstack/kolla/+/912070 | 18:24 |
| mnasiadka | Leaving it here to not forget reverting :) | 18:24 |
| kevko | i'm writing some code | 18:27 |
| kevko | and i've put environment: item.environment(omit) | 18:28 |
| kevko | instead of item.value.environment(omit) | 18:28 |
| kevko | :D :D :D | 18:28 |
| kevko | so omit did the work ..so no error ..nothing ...but also not expected data :D | 18:28 |
| kevko | sh*t :D | 18:28 |
| SvenKieske | I guess we should have more prechecks to see if expected values are really there, this happens a lot imho :) | 18:29 |
| kevko | SvenKieske: this was not runtime error ...this was my stupidity | 18:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!