| opendevreview | Dr. Jens Harbott proposed openstack/kolla master: Add mechanism for patching files in containers https://review.opendev.org/c/openstack/kolla/+/829295 | 08:05 |
|---|---|---|
| frickler | hmm, looks like shpc is completely offline? anyway, ^^ should be ready to go now IMO | 08:06 |
| mnasiadka | I'm back | 08:10 |
| mnasiadka | Just did +w that, your changes looked cosmetic so it should pass | 08:10 |
| mnasiadka | Don't we have codespell in Kolla that should catch some of these errors? | 08:11 |
| frickler | looks like we don't, the pep8 job passed on the broken PS25 | 08:16 |
| moot | Hello I wanted to ask why this should be a partial-bug I am not sure : https://review.opendev.org/c/openstack/kolla/+/934952/2..3//COMMIT_MSG#b12 | 09:13 |
| SvenKieske | moot: just looking at the comments on the commit message: if this fixes the bug only for debian ubuntu, and it doesn't fix it for e.g. rocky linux it's only partially fixing the bug. closing bug means it's fixed on all supported platform | 09:19 |
| SvenKieske | but not sure if this bug even affects other distributions? the dependency chain might look different there | 09:19 |
| SvenKieske | seems mdevctl is at least a distinct package on most rpm based distros as well, so probably worth it to fix there as well, not sure we even would want to merge a debian/ubuntu only fix in such a case? | 09:21 |
| moot | I tester all rpm distros mdev is already here | 09:22 |
| moot | tested* | 09:22 |
| moot | "The fix is not needed for centos and rocky containers as mdevctl is already present, perhaps it's build in the base image ? | 09:22 |
| moot | Do I still need to mark it as Partial-Bug ?" | 09:22 |
| SvenKieske | no, but maybe include that information either in the bug report or the commit message, that this only affects debian/ubuntu because the dependency is automatically installed on rpm based distros | 09:23 |
| SvenKieske | reviewers can and will also do mistakes, we're all human :) it happens | 09:24 |
| moot | OK I will add this info to the bug report | 09:24 |
| moot | no problem I m just new to this so I was searching a mistake on my end | 09:25 |
| opendevreview | Will Szumski proposed openstack/kayobe master: WIP: CI: Test interface bounce https://review.opendev.org/c/openstack/kayobe/+/934643 | 10:30 |
| opendevreview | Seunghun Lee proposed openstack/kolla master: Fix Bifrost install playbook ignoring openstack-base upper-constraints https://review.opendev.org/c/openstack/kolla/+/934735 | 10:53 |
| opendevreview | Seunghun Lee proposed openstack/kolla master: Fix Bifrost install playbook ignoring openstack-base upper-constraints https://review.opendev.org/c/openstack/kolla/+/934735 | 10:54 |
| opendevreview | Will Szumski proposed openstack/kayobe master: WIP: CI: Test interface bounce https://review.opendev.org/c/openstack/kayobe/+/934643 | 11:05 |
| opendevreview | Will Szumski proposed openstack/kayobe master: WIP: CI: Test interface bounce https://review.opendev.org/c/openstack/kayobe/+/934643 | 11:07 |
| mnasiadka | SvenKieske frickler would appreciate a review on https://review.opendev.org/c/openstack/kolla-ansible/+/934415 :) | 11:32 |
| frickler | nice trick, hiding a stack of 3 in a single review request ;-D | 11:56 |
| opendevreview | Merged openstack/kolla master: Add mechanism for patching files in containers https://review.opendev.org/c/openstack/kolla/+/829295 | 12:09 |
| frickler | \o/ | 12:10 |
| opendevreview | Matt Crees proposed openstack/kolla-ansible master: Give ironic-inspector system scope `all` https://review.opendev.org/c/openstack/kolla-ansible/+/934415 | 12:59 |
| SvenKieske | got a question posted on the above regarding one of the changes not mentioned in the commit message | 13:11 |
| SvenKieske | btw, wasn't there some fake/virtual ironic driver so maybe such stuff could get tested as well? | 13:20 |
| opendevreview | Matt Crees proposed openstack/kolla-ansible master: Give ironic-inspector system scope ``all`` https://review.opendev.org/c/openstack/kolla-ansible/+/934415 | 13:25 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Use new module names from openstack.cloud https://review.opendev.org/c/openstack/kolla-ansible/+/914325 | 13:38 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Update user role assignments https://review.opendev.org/c/openstack/kolla-ansible/+/934414 | 13:38 |
| xiaolong | hello | 13:40 |
| opendevreview | OpenStack Release Bot proposed openstack/kayobe stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/kayobe/+/935349 | 13:54 |
| opendevreview | OpenStack Release Bot proposed openstack/kayobe master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/kayobe/+/935350 | 13:54 |
| opendevreview | OpenStack Release Bot proposed openstack/kayobe-config stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/kayobe-config/+/935351 | 13:54 |
| opendevreview | OpenStack Release Bot proposed openstack/kayobe-config stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/kayobe-config/+/935352 | 13:54 |
| opendevreview | OpenStack Release Bot proposed openstack/kayobe-config-dev stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/kayobe-config-dev/+/935353 | 13:55 |
| opendevreview | OpenStack Release Bot proposed openstack/kayobe-config-dev stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/kayobe-config-dev/+/935354 | 13:55 |
| frickler | yay, well before the deadline \o/ | 14:01 |
| opendevreview | Matt Crees proposed openstack/kolla-ansible master: Support removing user role assignments https://review.opendev.org/c/openstack/kolla-ansible/+/935356 | 14:10 |
| opendevreview | Matt Crees proposed openstack/kolla-ansible master: Remove service role from ironic-inspector user https://review.opendev.org/c/openstack/kolla-ansible/+/935357 | 14:10 |
| greatgatsby_ | Good day. Little more info on our outage during a kolla-ansible upgrade. During our last 3 test upgrades, we've had an approx 5 minute outage to the VMs FIPs. We've now identified that it's occurring during the openvswitch container restarts: | 14:14 |
| greatgatsby_ | https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/openvswitch/handlers/main.yml | 14:14 |
| greatgatsby_ | what's happening is, the openvswitch-db-server container restart triggers neutron openvswitch agent to delete and re-create all the flows (br-ex, br-int, etc). The handler then restarts openvswitch-vswitchd which again triggers another re-creation of all the flows. Somehow, in the last 2 of 3 of out test upgrades, the neutron openvswitch agent has not handled this correctly and connectivity to | 14:16 |
| greatgatsby_ | VM FIPs is broken until kolla-ansible gets to where it restarts the neutron containers, approx 5 minutes later | 14:16 |
| opendevreview | Seunghun Lee proposed openstack/kolla master: Fix Bifrost install playbook ignoring openstack-base upper-constraints https://review.opendev.org/c/openstack/kolla/+/934735 | 14:36 |
| opendevreview | Seunghun Lee proposed openstack/kolla master: Fix Bifrost install playbook ignoring openstack-base upper-constraints https://review.opendev.org/c/openstack/kolla/+/934735 | 14:37 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Use new module names from openstack.cloud https://review.opendev.org/c/openstack/kolla-ansible/+/914325 | 18:37 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Update user role assignments https://review.opendev.org/c/openstack/kolla-ansible/+/934414 | 18:38 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Use new module names from openstack.cloud https://review.opendev.org/c/openstack/kolla-ansible/+/914325 | 20:32 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Update user role assignments https://review.opendev.org/c/openstack/kolla-ansible/+/934414 | 20:32 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Give ironic-inspector system scope ``all`` https://review.opendev.org/c/openstack/kolla-ansible/+/934415 | 20:32 |
| frickler | meh | 20:47 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Give ironic-inspector system scope ``all`` https://review.opendev.org/c/openstack/kolla-ansible/+/934415 | 22:31 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Update user role assignments https://review.opendev.org/c/openstack/kolla-ansible/+/934414 | 22:51 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Use new module names from openstack.cloud https://review.opendev.org/c/openstack/kolla-ansible/+/914325 | 22:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!