| opendevreview | Bertrand Lanson proposed openstack/kolla-ansible master: DNM: Making iterated container-check idempotent https://review.opendev.org/c/openstack/kolla-ansible/+/973803 | 07:43 |
|---|---|---|
| blanson[m] | https://review.opendev.org/c/openstack/kolla-ansible/+/972841 and https://review.opendev.org/c/openstack/kolla-ansible/+/972838 and https://review.opendev.org/c/openstack/kolla-ansible/+/972831 are ready for backports if anyone has time :) | 07:50 |
| opendevreview | Piotr Milewski proposed openstack/kolla-ansible master: Implement neutron-ovn-vpn-agent https://review.opendev.org/c/openstack/kolla-ansible/+/924575 | 08:23 |
| opendevreview | Piotr Milewski proposed openstack/kolla-ansible master: Implement neutron-ovn-vpn-agent https://review.opendev.org/c/openstack/kolla-ansible/+/924575 | 08:27 |
| opendevreview | Piotr Milewski proposed openstack/kolla-ansible master: Implement neutron-ovn-vpn-agent https://review.opendev.org/c/openstack/kolla-ansible/+/924575 | 08:28 |
| bbezak | blanson[m]: I’ll take a look | 09:09 |
| blanson[m] | ty ! | 09:10 |
| Vii | why don't you make a "cherry pick" but always new ones | 09:30 |
| Vii | I have one comment, I see that master is probably merge but | 09:31 |
| Vii | u lost "return False" | 09:32 |
| Vii | in compare_volumes def | 09:32 |
| blanson[m] | Hm did I ? I'll double check when I get to the office. thanks for letting me know ! | 09:45 |
| blanson[m] | I do cherry picks tho, maybe I messed something up ? | 09:47 |
| blanson[m] | You're right about the return tho but I think I just left it as it was initially which relies on evaluation of None to False | 09:49 |
| blanson[m] | Yeah the initial commit does the same so it's all good. It'll evaluate to False because of no return. We could make this more explicit, but it works as is | 09:51 |
| Vii | True, it evaluates to False implicitly, but for the sake of consistency with other methods in PodmanWorker (like compare_config) and to avoid potential issues if someone later uses an explicit check (e.g., is False), it would be much cleaner to have it explicit. | 09:58 |
| *** jhorstmann is now known as Guest908 | 10:33 | |
| opendevreview | Merged openstack/kolla-ansible master: Try not to return loopback addresses with kolla_address in ipv4 https://review.opendev.org/c/openstack/kolla-ansible/+/933835 | 10:37 |
| opendevreview | Will Szumski proposed openstack/kayobe master: [networkd] Fix broken conditional https://review.opendev.org/c/openstack/kayobe/+/975173 | 11:26 |
| opendevreview | Will Szumski proposed openstack/kayobe master: [firewalld] Fix broken conditional https://review.opendev.org/c/openstack/kayobe/+/975186 | 11:26 |
| opendevreview | Will Szumski proposed openstack/kayobe master: [networkd] Fix broken conditional https://review.opendev.org/c/openstack/kayobe/+/975173 | 11:34 |
| opendevreview | Will Szumski proposed openstack/kayobe master: [firewalld] Fix broken conditional https://review.opendev.org/c/openstack/kayobe/+/975186 | 11:34 |
| opendevreview | Verification of a change to openstack/kayobe-config-dev stable/2025.2 failed: Use CentOS Stream 9 IPA deployment images https://review.opendev.org/c/openstack/kayobe-config-dev/+/974899 | 11:36 |
| eduardomorais | hey guys can anyone take a look, https://review.opendev.org/c/openstack/octavia/+/975190 | 12:17 |
| Vii | not this channel | 12:23 |
| Vii | #openstack-octavia | 12:23 |
| eduardomorais | sorry | 12:32 |
| opendevreview | Verification of a change to openstack/kayobe-config-dev stable/2025.2 failed: Use CentOS Stream 9 IPA deployment images https://review.opendev.org/c/openstack/kayobe-config-dev/+/974899 | 14:39 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!