| opendevreview | Merged openstack/kayobe master: Drop backwards compatibility for template trusting https://review.opendev.org/c/openstack/kayobe/+/978735 | 00:43 |
|---|---|---|
| opendevreview | Pierre Riteau proposed openstack/kayobe master: Fix lookup plugins for external playbooks https://review.opendev.org/c/openstack/kayobe/+/978058 | 08:47 |
| opendevreview | Pierre Riteau proposed openstack/kayobe master: Add kayobe_path variable https://review.opendev.org/c/openstack/kayobe/+/977845 | 08:47 |
| opendevreview | Taavi Ansper proposed openstack/kolla-ansible master: Fix keystone with IDP configured. https://review.opendev.org/c/openstack/kolla-ansible/+/975901 | 09:40 |
| tafkamax | blanson: thanks for the comments. | 09:41 |
| tafkamax | I have an question regarding the openstack domain_id and commented under there. I think the better way would be to do a lookup, but as it requires looping over the keystone_identity_providers, then thanks to our genius ansible I would need to create another sub_task file, as I cant loop over multiple tasks. Do you think is accepatable? | 09:42 |
| tafkamax | I really wish blocks would support looping q_q | 09:42 |
| *** jhorstmann is now known as Guest5611 | 09:42 | |
| blanson[m] | ah yes, oldest trick in the book | 10:02 |
| opendevreview | Merged openstack/kolla-ansible master: ansible-lint: Fix fqcn[actions-core] for haproxy-config https://review.opendev.org/c/openstack/kolla-ansible/+/981432 | 10:05 |
| blanson[m] | Taavi Ansper: I'm failing to see why you'd want to loop over multiple tasks in sequence here tho ? wouldn't you be fine with independent loops ? | 10:06 |
| blanson[m] | in my exp, loopfiles are only really necessary to do sequential execution, but in this case I don't get why you'd need sequential execution ? can't you look them all up, then create them ? | 10:07 |
| tafkamax | I was thinking I would loop over the providers list. Then I would query for identity_domain and search for matching name in the identity_domains and fetch the ID from there. But yes I could just use https://docs.ansible.com/projects/ansible/latest/collections/openstack/cloud/identity_domain_info_module.html#ansible-collections-openstack-cloud-identity-domain-info-module to fetch all domains. And then find the first matching one. | 10:13 |
| tafkamax | It does have the edge case if there are multiple domains with the same name, but different ID. | 10:13 |
| tafkamax | I think it is a stupid idea to do multiple domains with same name :D | 10:13 |
| tafkamax | so this would be an acceptable caveat | 10:13 |
| blanson[m] | yh I think multiple domains with the same name is a stupid edge case aswell, and you can't really work around it unless you know the id which you might not. I think it's fine to assume (and maybe document?) that this works only as long as your domains have unique names (which shouldn't be too hard of a requirement) | 10:21 |
| tafkamax | OK here goes nothing. First attempt. | 10:40 |
| opendevreview | Taavi Ansper proposed openstack/kolla-ansible master: Fix keystone with IDP configured. https://review.opendev.org/c/openstack/kolla-ansible/+/975901 | 10:41 |
| tafkamax | Also added my first docs entry. | 10:41 |
| opendevreview | Piotr Milewski proposed openstack/kolla-ansible master: Implement neutron-ovn-vpn-agent https://review.opendev.org/c/openstack/kolla-ansible/+/924575 | 10:51 |
| tafkamax | I have two fixes in a-c-k, who would I need to assign them to for reviews? | 10:52 |
| tafkamax | I got one +1 review | 10:52 |
| tafkamax | But no +2 | 10:52 |
| tafkamax | Sorry I meant a-c-o | 10:53 |
| priteau | mnasiadka: It appears that my a-c-k docker_host_info change broke nightly image builds, because requests is not installed. Do you know where this dependency should be added? | 11:52 |
| opendevreview | Piotr Milewski proposed openstack/kolla-ansible master: Implement neutron-ovn-vpn-agent https://review.opendev.org/c/openstack/kolla-ansible/+/924575 | 12:31 |
| mnasiadka | priteau: if we need that jn docker role - then it would make sense to do it in docker_sdk or docker role I guess | 13:33 |
| opendevreview | Piotr Milewski proposed openstack/kolla-ansible master: Implement neutron-ovn-vpn-agent https://review.opendev.org/c/openstack/kolla-ansible/+/924575 | 14:12 |
| opendevreview | Taavi Ansper proposed openstack/kolla-ansible master: Fix keystone with IDP configured. https://review.opendev.org/c/openstack/kolla-ansible/+/975901 | 14:31 |
| opendevreview | Merged openstack/kolla-ansible master: ansible-lint: Fix fqcn[actions-core] for heat https://review.opendev.org/c/openstack/kolla-ansible/+/981433 | 16:49 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: ansible-lint: Fix fqcn[actions-core] for horizon https://review.opendev.org/c/openstack/kolla-ansible/+/981434 | 16:49 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: ansible-lint: Fix fqcn[actions-core] for ironic https://review.opendev.org/c/openstack/kolla-ansible/+/981435 | 16:50 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: ansible-lint: Fix fqcn[actions-core] for iscsi https://review.opendev.org/c/openstack/kolla-ansible/+/981436 | 16:50 |
| opendevreview | Piotr Milewski proposed openstack/kolla master: Add Dockerfile for neutron-ovn-vpn-agent https://review.opendev.org/c/openstack/kolla/+/924302 | 17:19 |
| opendevreview | Piotr Milewski proposed openstack/kolla-ansible master: Implement neutron-ovn-vpn-agent https://review.opendev.org/c/openstack/kolla-ansible/+/924575 | 17:22 |
| opendevreview | Piotr Milewski proposed openstack/kolla-ansible master: Implement neutron-ovn-vpn-agent https://review.opendev.org/c/openstack/kolla-ansible/+/924575 | 20:02 |
| opendevreview | Taavi Ansper proposed openstack/kolla-ansible master: Fix keystone with IDP configured. https://review.opendev.org/c/openstack/kolla-ansible/+/975901 | 20:16 |
| tafkamax | What do you think of this: domain_id: "{{ '{{ existing_identity_domains | selectattr('name', 'equalto', item.openstack_domain) | map(attribute='id') | first }}' }}" | 20:18 |
| tafkamax | reasonable? | 20:18 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: ansible-lint: Fix fqcn[actions-core] for horizon https://review.opendev.org/c/openstack/kolla-ansible/+/981434 | 20:37 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!