| opendevreview | OpenStack Proposal Bot proposed openstack/kolla master: Updated from check-sources https://review.opendev.org/c/openstack/kolla/+/1007806 | 02:19 |
|---|---|---|
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: keystone: Use keystone-api container image instead of keystone https://review.opendev.org/c/openstack/kolla-ansible/+/962120 | 05:28 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: keystone: Use keystone-api container image instead of keystone https://review.opendev.org/c/openstack/kolla-ansible/+/962120 | 05:30 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: keystone: Use keystone-api container image instead of keystone https://review.opendev.org/c/openstack/kolla-ansible/+/962120 | 05:30 |
| opendevreview | Franciszek Przewoźny proposed openstack/kolla-ansible master: grafana: do not log datasource secrets https://review.opendev.org/c/openstack/kolla-ansible/+/1008417 | 06:59 |
| opendevreview | Franciszek Przewoźny proposed openstack/kolla-ansible master: grafana: do not log datasource secrets https://review.opendev.org/c/openstack/kolla-ansible/+/1008417 | 07:01 |
| opendevreview | Pierre Riteau proposed openstack/kayobe master: CI: Make all experimental jobs voting https://review.opendev.org/c/openstack/kayobe/+/1008420 | 07:57 |
| opendevreview | Franciszek Przewoźny proposed openstack/kolla-ansible master: grafana: do not log datasource secrets https://review.opendev.org/c/openstack/kolla-ansible/+/1008417 | 08:17 |
| fprzewozn | Morning! | 08:17 |
| opendevreview | Merged openstack/kolla-ansible master: CI: Install tempest in a separate venv https://review.opendev.org/c/openstack/kolla-ansible/+/1008338 | 08:17 |
| fprzewozn | This morning found that one of Grafana tasks is leaking its datasource secrets during configuration. In default config it's the Alertmanager admin account login and password, but based on configuration it could be anything. | 08:18 |
| fprzewozn | https://launchpad.net/bugs/2169248 | 08:18 |
| fprzewozn | https://review.opendev.org/c/openstack/kolla-ansible/+/1008417 | 08:18 |
| fprzewozn | patch fixes it, but with a cost | 08:19 |
| fprzewozn | https://paste.opendev.org/show/bysWuqpPGCNWuf15wXdx/ | 08:19 |
| fprzewozn | looped items are not visible anymore | 08:19 |
| mnasiadka | It’s been leaking for very long time, it’s not new - https://opendev.org/openstack/kolla-ansible/src/branch/master/roles/kolla-ansible-check/defaults/main.yml | 08:27 |
| opendevreview | Jed Preist proposed openstack/kolla-ansible master: CI: Test virtual media boot https://review.opendev.org/c/openstack/kolla-ansible/+/1000730 | 08:39 |
| opendevreview | Bartosz Bezak proposed openstack/kolla-ansible master: Revert "CI: Prefer ipv4 over ipv6 and disable docker mirror" https://review.opendev.org/c/openstack/kolla-ansible/+/1008425 | 08:57 |
| fprzewozn | mnasiadka is there anything blocking us from covering those leaks? any reason why wasn't that fixed in past? | 08:58 |
| mnasiadka | As with everything, not enough contributors, not enough maintainers, not enough <you name it> | 08:59 |
| opendevreview | Verification of a change to openstack/kayobe stable/2025.1 failed: Wait for firewalld to be ready before configuring https://review.opendev.org/c/openstack/kayobe/+/1008204 | 09:49 |
| opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Rework network interface to host mapping https://review.opendev.org/c/openstack/kayobe/+/825832 | 09:53 |
| frickler | mnasiadka: fprzewozn: IMO there is a simple fix that doesn't need any patches, just some operational sanity: treat logs like secrets | 10:02 |
| fprzewozn | I'm not buying that one :P | 10:03 |
| mnasiadka | frickler: we have that in our docs somewhere :) | 10:03 |
| AlmaMC[m] | I'll take a look to leaks you sent mnasiadka | 10:05 |
| AlmaMC[m] | I think adding "no_log" on the blocks, as did fprzewozn, is the good approach. Unless someone has another idea? | 10:13 |
| fprzewozn | other approaches require adding some logic there, in the Grafana example the cost is that we're no longer able to see the configured elements (even just names) | 10:16 |
| fprzewozn | so either we add debug step before and just list it | 10:17 |
| fprzewozn | or sanitize known param names in variables in python | 10:17 |
| fprzewozn | so yeah, I went with no_log approach on my proposition :) | 10:18 |
| AlmaMC[m] | imo it's would just add more complexity and some work to sanitize. Maybe it's something we want to do ? | 10:19 |
| opendevreview | Merged openstack/kayobe master: Add ansible-pylibssh https://review.opendev.org/c/openstack/kayobe/+/1007873 | 11:43 |
| opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Rework network interface to host mapping https://review.opendev.org/c/openstack/kayobe/+/825832 | 12:32 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: keystone: Use keystone-api container image instead of keystone https://review.opendev.org/c/openstack/kolla-ansible/+/962120 | 12:42 |
| mnasiadka | I’m not a fan of using no_log: true | 12:45 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: keystone: Use keystone-api container image instead of keystone https://review.opendev.org/c/openstack/kolla-ansible/+/962120 | 12:49 |
| mnasiadka | Because when this fails in CI, we’re blind - and the only way to understand what went wrong is removing no_log: true | 12:58 |
| mnasiadka | In alert manager case - IMHO we’re just very bad in putting secret in the dict and not handling loop_control in a proper manner | 12:59 |
| opendevreview | Thomas Bechtold proposed openstack/kolla master: Allow stable branch override-checkout for tarball sources https://review.opendev.org/c/openstack/kolla/+/1008463 | 13:29 |
| opendevreview | Merged openstack/kolla-ansible master: Revert "CI: Prefer ipv4 over ipv6 and disable docker mirror" https://review.opendev.org/c/openstack/kolla-ansible/+/1008425 | 14:54 |
| opendevreview | Verification of a change to openstack/kayobe master failed: Remove ALLOW_BROKEN_CONDITIONALS workaround https://review.opendev.org/c/openstack/kayobe/+/986333 | 17:03 |
| mnasiadka | frickler, blanson[m]: me and bbezak are on Open Source Summit in Prague next week - should I cancel the meeting? | 17:14 |
| opendevreview | Merged openstack/kayobe master: Fix diff mode for AlliedWare Plus switches https://review.opendev.org/c/openstack/kayobe/+/1008237 | 17:24 |
| opendevreview | Merged openstack/kayobe master: feat: bump `stackhpc.libvirt-vm` to `v1.17.1` https://review.opendev.org/c/openstack/kayobe/+/1008342 | 17:24 |
| frickler | fine with me | 17:58 |
| opendevreview | Pierre Riteau proposed openstack/kayobe master: Revert "CI: Prefer ipv4 over ipv6" https://review.opendev.org/c/openstack/kayobe/+/1008527 | 19:53 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/2026.1: Fix diff mode for AlliedWare Plus switches https://review.opendev.org/c/openstack/kayobe/+/1008528 | 19:56 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/2025.2: Fix diff mode for AlliedWare Plus switches https://review.opendev.org/c/openstack/kayobe/+/1008529 | 19:57 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/2025.1: Fix diff mode for AlliedWare Plus switches https://review.opendev.org/c/openstack/kayobe/+/1008530 | 19:57 |
| opendevreview | Merged openstack/kayobe master: Remove ALLOW_BROKEN_CONDITIONALS workaround https://review.opendev.org/c/openstack/kayobe/+/986333 | 23:45 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!