| opendevreview | OpenStack Proposal Bot proposed openstack/kolla master: Updated from check-sources https://review.opendev.org/c/openstack/kolla/+/1007806 | 02:40 |
|---|---|---|
| mnasiadka | blanson[m]: that shows it would be nice if it would be a patch per service to enable waiting ;) | 05:38 |
| kkaptanoglu | hi, could someone please review this patch https://review.opendev.org/c/openstack/kolla-ansible/+/1007439 | 08:03 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Wait for fluentd to tail late log files. https://review.opendev.org/c/openstack/kolla-ansible/+/1001633 | 08:16 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: fluentd: Collect the nova_libvirt virtlogd log https://review.opendev.org/c/openstack/kolla-ansible/+/1010532 | 08:17 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: nova: Precheck for a host virtlogd https://review.opendev.org/c/openstack/kolla-ansible/+/1010517 | 08:17 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Pin MariaDB character_set_collations to pre-11.5. https://review.opendev.org/c/openstack/kolla-ansible/+/1007308 | 08:18 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Report databases with mixed utf8mb3 collations. https://review.opendev.org/c/openstack/kolla-ansible/+/1007309 | 08:18 |
| opendevreview | Michael Still proposed openstack/kolla master: Add a kolla-ansible deployer image. https://review.opendev.org/c/openstack/kolla/+/1011443 | 08:18 |
| opendevreview | Michael Still proposed openstack/kolla master: Install the kerbside-proxy wheel into kerbside images. https://review.opendev.org/c/openstack/kolla/+/998073 | 08:19 |
| opendevreview | Michael Still proposed openstack/kolla master: magnum: pin setuptools <82. https://review.opendev.org/c/openstack/kolla/+/1007307 | 08:19 |
| opendevreview | Michael Still proposed openstack/kolla master: CI: fix the cells scenario file trigger. https://review.opendev.org/c/openstack/kolla/+/1007449 | 08:19 |
| opendevreview | Michael Still proposed openstack/kolla master: CI: run the magnum, NFV and CloudKitty scenarios. https://review.opendev.org/c/openstack/kolla/+/1007450 | 08:19 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Allow validate-config to skip become on localhost. https://review.opendev.org/c/openstack/kolla-ansible/+/1011940 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Ignore deployer.conf in check-config.sh. https://review.opendev.org/c/openstack/kolla-ansible/+/1011941 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Guard deployments against the wrong deployer. https://review.opendev.org/c/openstack/kolla-ansible/+/1011942 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Support image digests in kolla_container. https://review.opendev.org/c/openstack/kolla-ansible/+/1011943 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Pull images by digest from a build manifest. https://review.opendev.org/c/openstack/kolla-ansible/+/1011944 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Add an nsenter friendly all-in-one inventory. https://review.opendev.org/c/openstack/kolla-ansible/+/1011945 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Detect log levels in JSON formatted logs. https://review.opendev.org/c/openstack/kolla-ansible/+/1005459 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Add a fluentd path for JSON formatted OpenStack logs. https://review.opendev.org/c/openstack/kolla-ansible/+/1005460 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Let Keystone log JSON. https://review.opendev.org/c/openstack/kolla-ansible/+/1005461 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Convert the core services to JSON logging. https://review.opendev.org/c/openstack/kolla-ansible/+/1005462 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Convert the compute services to JSON logging. https://review.opendev.org/c/openstack/kolla-ansible/+/1005463 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Convert the networking services to JSON logging. https://review.opendev.org/c/openstack/kolla-ansible/+/1005464 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Convert the storage services to JSON logging. https://review.opendev.org/c/openstack/kolla-ansible/+/1005465 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Convert the telemetry services to JSON logging. https://review.opendev.org/c/openstack/kolla-ansible/+/1005466 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Convert the remaining services to JSON logging. https://review.opendev.org/c/openstack/kolla-ansible/+/1005467 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Exercise JSON logging in the telemetry scenario. https://review.opendev.org/c/openstack/kolla-ansible/+/1005468 | 08:30 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Document JSON logging. https://review.opendev.org/c/openstack/kolla-ansible/+/1005469 | 08:31 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Deploy Kerbside with Kolla-Ansible. https://review.opendev.org/c/openstack/kolla-ansible/+/976889 | 08:31 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Use a routable IP for qemu SPICE consoles. https://review.opendev.org/c/openstack/kolla-ansible/+/967801 | 08:31 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Add kerbside CI scenario jobs. https://review.opendev.org/c/openstack/kolla-ansible/+/988189 | 08:31 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Run the spice-direct tempest test in the kerbside scenario. https://review.opendev.org/c/openstack/kolla-ansible/+/988913 | 08:31 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Run a Kerbside-fronted SPICE tempest test in the kerbside scenario. https://review.opendev.org/c/openstack/kolla-ansible/+/989614 | 08:31 |
| opendevreview | Michael Still proposed openstack/kolla-ansible master: Collect etcd logs with Fluentd. https://review.opendev.org/c/openstack/kolla-ansible/+/1005458 | 08:31 |
| opendevreview | Michael Still proposed openstack/kolla master: nova: Fail nova_libvirt start without virtlogd https://review.opendev.org/c/openstack/kolla/+/1010516 | 08:31 |
| blanson[m] | mnasiadka: how do you mean ? like patching every service to use this ? :) I'm planning on taking on this crusade once the attribute is available on master, I'd like proper rolling restarts at least on the APIs for Indri release :) | 10:09 |
| mnasiadka | blanson[m]: just meaning that don’t send a huge patch for all services at once :) | 10:13 |
| blanson[m] | mnasiadka: I would never, I am traumatized enough by big patches :D | 10:14 |
| opendevreview | Jed Preist proposed openstack/kolla-ansible master: CI: multi-compute-ironic deploy on all hosts https://review.opendev.org/c/openstack/kolla-ansible/+/1001634 | 10:15 |
| opendevreview | Will Szumski proposed openstack/kayobe master: CI: Fix experimental seed image jobs https://review.opendev.org/c/openstack/kayobe/+/1012836 | 10:27 |
| tafkamax | "I am once again asking for your review support" -> https://review.opendev.org/c/openstack/kolla-ansible/+/1002530 | 10:31 |
| tafkamax | Small patch overall, but thoughts needed :-) | 10:31 |
| tafkamax | Running this in prod already with cherry-pick | 10:31 |
| mnasiadka | I would prefer we stop having multiple ways to upgrade which are not tested anywhere, but multiplying CI scenarios is also not my favorite kind of thing | 10:32 |
| opendevreview | Will Szumski proposed openstack/kayobe master: CI: Fix experimental seed image jobs https://review.opendev.org/c/openstack/kayobe/+/1012836 | 10:32 |
| mnasiadka | The fact you’re running it in production doesn’t change a thing from project perspective | 10:33 |
| opendevreview | Will Szumski proposed openstack/kayobe master: CI: Fix experimental seed image jobs https://review.opendev.org/c/openstack/kayobe/+/1012836 | 10:34 |
| tafkamax | Well I understand that you are under loads of work, but just avoiding reviewing patches is not good imho. there are lots of great ideas and ppl who are wanting to contribute. I understand that not all have time to review other stuff and focus on their specific things. But just not wanting to support something and then ignoring the broken code is not good aswell imho? | 10:37 |
| tafkamax | If you don't want the broken code, then one option would be to remove it and then we can migrate over to the version where the API services are kept running. | 10:37 |
| mnasiadka | tafkamax: we are voluntarily reviewing patches, once we start getting paid for our work - then you can criticise us in that manner - until that happens - you’re just making enemies | 10:38 |
| mnasiadka | Most of us is devoting our own private time to make this prijecy | 10:39 |
| mnasiadka | project work | 10:39 |
| mnasiadka | So comments like this are not helping anybody | 10:40 |
| mnasiadka | Unfortunately kolla historically has really a big bunch of features that are not tested anywhere, and we’re trying to make it better - but it seems we’re not good enough at it | 10:41 |
| mnasiadka | So maybe instead of complaining you’ll help us out here? | 10:42 |
| kkaptanoglu | blanson[m]: thanks for review | 10:47 |
| tafkamax | First of all, I am sorry for being so blunt. I understand these predicaments. I just wanted to nudge the in my opinon, small things along... | 10:47 |
| tafkamax | Second of all, I have contributed patches to fix broken logic. For other things, as I said, I don't have time to review the things or maybe even knowledge of some of the OS services or Kolla inner workings which we do not personally use... which would be understandable. | 10:47 |
| blanson[m] | kkaptanoglu: no worries, I remembered this from earlier, and I also remember I said backporting it was a good idea | 10:50 |
| blanson[m] | Taavi Ansper: that's fair, but the time bottleneck part of this is review time, because of the count difference of contributors vs reviewers. not reviewing patches is totally fine, we understand not everyone has time to do it, but you can't expect reviewers to possibly match the velocity of people submitting patches. as mnasiadka said, that's our unpaid second job ( on top of an actual first job that's already full time). I don't | 10:54 |
| blanson[m] | have a solution except we need more reviewers, but people aren't reviewing so | 10:54 |
| kkaptanoglu | tafkamax: Just to jump in and share my own experience: It took quite a long time for some of my contributions to get merged upstream. However, I waited patiently because I understand that giving a +1 is a significant responsibility and requires time and careful review. Changes that work perfectly in my environment could potentially affect of other deployments and organizations. I also had to adjust my upgrade plans around the me | 10:55 |
| kkaptanoglu | rge timeline. If a patch is critical, you can always apply a temporary fix locally, as we sometimes do in urgent situations. However, this can introduce additional challenges with version management and future upgrades. I understand the frustration, but I also appreciate the responsibility reviewers take on. | 10:55 |
| *** LukaszCh0 is now known as LukaszCh | 10:58 | |
| *** fprzewozn2 is now known as fprzewozn | 10:58 | |
| mnasiadka | I think the issue with tafkamax’s patch is that this is not tested in CI, I don’t know if it should, I don’t know if we shouldn’t drop it, but tafkamax is just asking for reviews to stop carrying a small downstream patch - and that’s fine - but project maintainers need to weigh in other factors | 10:59 |
| mnasiadka | And since it’s not on a critical path - it doesn’t really have priority | 10:59 |
| tafkamax | I understand bugfixes vs new logic. Currently it is bugfix type, which could be more light-weight... | 10:59 |
| mnasiadka | And reviewing each patch is not really 5 minutes | 10:59 |
| tafkamax | I could make the patch split again, CI logic could come later, but I don't know if it would make a diff... | 11:00 |
| tafkamax | OK but overall I'll just keep waiting until some time pops up... | 11:03 |
| tafkamax | We have applied the temp fix locally as an cherry-pick. | 11:04 |
| tafkamax | Sorry for (possibily) raising your blood-pressure | 11:04 |
| opendevreview | OpenStack Release Bot proposed openstack/ansible-collection-kolla master: reno: Update master for unmaintained/2025.1 https://review.opendev.org/c/openstack/ansible-collection-kolla/+/1013835 | 11:25 |
| opendevreview | OpenStack Release Bot proposed openstack/kayobe master: reno: Update master for unmaintained/2025.1 https://review.opendev.org/c/openstack/kayobe/+/1013837 | 11:26 |
| opendevreview | OpenStack Release Bot proposed openstack/kolla-ansible master: reno: Update master for unmaintained/2025.1 https://review.opendev.org/c/openstack/kolla-ansible/+/1013842 | 11:27 |
| opendevreview | OpenStack Release Bot proposed openstack/kolla master: reno: Update master for unmaintained/2025.1 https://review.opendev.org/c/openstack/kolla/+/1013844 | 11:28 |
| opendevreview | Andriy Kurilin proposed openstack/kolla-ansible master: grafana: Add back-end TLS support https://review.opendev.org/c/openstack/kolla-ansible/+/940825 | 11:34 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/2025.1: Rename stable/2025.1 to unmaintained/2025.1 https://review.opendev.org/c/openstack/kayobe/+/1013846 | 11:34 |
| opendevreview | Jed Preist proposed openstack/kolla-ansible master: CI: multi-compute-ironic deploy on all hosts https://review.opendev.org/c/openstack/kolla-ansible/+/1001634 | 11:43 |
| opendevreview | Will Szumski proposed openstack/kayobe master: CI: Fix experimental seed image jobs https://review.opendev.org/c/openstack/kayobe/+/1012836 | 12:22 |
| opendevreview | Andriy Kurilin proposed openstack/kolla-ansible master: grafana: Add back-end TLS support https://review.opendev.org/c/openstack/kolla-ansible/+/940825 | 12:53 |
| *** M00SE7 is now known as M00SE | 12:53 | |
| opendevreview | Jed Preist proposed openstack/kolla-ansible master: CI: multi-compute-ironic deploy on all hosts https://review.opendev.org/c/openstack/kolla-ansible/+/1001634 | 13:09 |
| opendevreview | yosef proposed openstack/kolla-ansible master: Add election-timer option to ovn-db role https://review.opendev.org/c/openstack/kolla-ansible/+/934106 | 13:39 |
| opendevreview | Jakub Darmach proposed openstack/ansible-collection-kolla stable/2025.1: Fix docker restart after systemd configuration change https://review.opendev.org/c/openstack/ansible-collection-kolla/+/1013885 | 13:41 |
| opendevreview | Alex Welsh proposed openstack/kolla-ansible master: Ensure Check containers does not leak secrets https://review.opendev.org/c/openstack/kolla-ansible/+/1013887 | 13:47 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: WIP: Add Ubuntu 26.04 (Resolute) support https://review.opendev.org/c/openstack/kolla/+/1010469 | 14:32 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: Reorganise header/footer to match one scheme https://review.opendev.org/c/openstack/kolla/+/996979 | 14:37 |
| opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Add kolla ansible version check to kayobe commands https://review.opendev.org/c/openstack/kayobe/+/1006181 | 15:46 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: set_configs: Fix glob-sources files tracking https://review.opendev.org/c/openstack/kolla/+/1013932 | 15:51 |
| opendevreview | Michal Arbet proposed openstack/kolla master: Switch OpenStack release codename to Hibiscus https://review.opendev.org/c/openstack/kolla/+/1013964 | 19:03 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!