*** prithiv1 has quit IRC | 00:02 | |
*** banix has joined #openstack-kuryr | 00:42 | |
*** abhiraut has quit IRC | 00:45 | |
*** diogogmt has quit IRC | 00:48 | |
*** limao_ has joined #openstack-kuryr | 00:51 | |
*** abhiraut has joined #openstack-kuryr | 00:55 | |
*** abhiraut has quit IRC | 00:59 | |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 01:01 |
---|---|---|
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 01:21 |
openstackgerrit | Merged openstack/kuryr: Fixes problem with flask 0.11 https://review.openstack.org/329620 | 01:22 |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 01:49 |
*** diogogmt has joined #openstack-kuryr | 01:52 | |
*** huikang has quit IRC | 02:40 | |
*** yuanying has quit IRC | 02:50 | |
*** yuanying has joined #openstack-kuryr | 02:53 | |
*** hongbin has joined #openstack-kuryr | 03:13 | |
*** tfukushima has joined #openstack-kuryr | 03:27 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr: Updated from global requirements https://review.openstack.org/323895 | 03:44 |
*** banix has quit IRC | 03:46 | |
*** hongbin has quit IRC | 03:47 | |
*** yuanying_ has joined #openstack-kuryr | 03:48 | |
*** yuanying has quit IRC | 03:49 | |
openstackgerrit | Taku Fukushima proposed openstack/kuryr: Add trailing commans to follow the coding standard https://review.openstack.org/254493 | 04:24 |
*** oanson has joined #openstack-kuryr | 04:28 | |
openstackgerrit | Taku Fukushima proposed openstack/kuryr: Fix typos in the watcher desing devref https://review.openstack.org/328059 | 04:30 |
*** vikasc has joined #openstack-kuryr | 04:32 | |
*** salv-orl_ has quit IRC | 04:54 | |
*** salv-orlando has joined #openstack-kuryr | 04:54 | |
vikasc | tfukushima, Hi, https://review.openstack.org/#/c/328656/ PTAL once you got some time. | 04:58 |
*** yamamot__ has joined #openstack-kuryr | 05:01 | |
openstackgerrit | Taku Fukushima proposed openstack/kuryr: Add trailing commas to follow the coding standard https://review.openstack.org/254493 | 05:13 |
*** salv-orlando has quit IRC | 05:17 | |
*** salv-orlando has joined #openstack-kuryr | 05:17 | |
*** salv-orl_ has joined #openstack-kuryr | 05:29 | |
*** salv-orlando has quit IRC | 05:32 | |
*** tfukushima has quit IRC | 05:40 | |
*** tfukushima has joined #openstack-kuryr | 05:41 | |
*** diga has joined #openstack-kuryr | 05:50 | |
*** tfukushima has quit IRC | 05:51 | |
*** yuanying has joined #openstack-kuryr | 06:03 | |
*** yuanying_ has quit IRC | 06:05 | |
*** irenab has quit IRC | 06:05 | |
*** irenab has joined #openstack-kuryr | 06:05 | |
openstackgerrit | Merged openstack/kuryr: Fix style issues in existing-neutron-network spec https://review.openstack.org/329337 | 06:07 |
*** openstackgerrit has quit IRC | 06:18 | |
*** openstackgerrit has joined #openstack-kuryr | 06:18 | |
*** yuanying has quit IRC | 06:21 | |
*** salv-orlando has joined #openstack-kuryr | 06:24 | |
*** yuanying has joined #openstack-kuryr | 06:28 | |
*** salv-orl_ has quit IRC | 06:28 | |
*** irenab has quit IRC | 06:28 | |
*** salv-orlando has quit IRC | 06:29 | |
*** tfukushima has joined #openstack-kuryr | 06:34 | |
*** irenab has joined #openstack-kuryr | 06:44 | |
*** yuanying has quit IRC | 07:05 | |
*** yuanying has joined #openstack-kuryr | 07:08 | |
*** diga has quit IRC | 07:21 | |
*** openstackgerrit has quit IRC | 07:33 | |
*** openstackgerrit has joined #openstack-kuryr | 07:33 | |
*** salv-orlando has joined #openstack-kuryr | 07:41 | |
*** diga has joined #openstack-kuryr | 07:59 | |
*** diga has quit IRC | 08:30 | |
openstackgerrit | vikas choudhary proposed openstack/kuryr: Releasing address for the gateway address https://review.openstack.org/329404 | 08:40 |
*** diga has joined #openstack-kuryr | 09:05 | |
*** tfukushima has quit IRC | 09:37 | |
*** tfukushima has joined #openstack-kuryr | 09:38 | |
*** salv-orlando has quit IRC | 09:47 | |
*** salv-orlando has joined #openstack-kuryr | 09:48 | |
*** vikasc has quit IRC | 09:58 | |
*** vikasc has joined #openstack-kuryr | 10:10 | |
*** limao_ has quit IRC | 10:13 | |
*** limao_ has joined #openstack-kuryr | 10:14 | |
*** limao_ has quit IRC | 10:18 | |
*** tfukushima has quit IRC | 10:18 | |
vikasc | irenab, ping | 10:19 |
irenab | vikasc: pong | 10:19 |
vikasc | pinged you regarding your comment on release address | 10:19 |
vikasc | this case will hit only when release_address is called for releasing gw ip. This will happen at network deletion time. Subnet will be deleted in delete_network api. | 10:20 |
vikasc | Please note that, we dont even create neutron port for gw ip address received from libnetwork. | 10:20 |
vikasc | Was just about to post this comment, then thought of pinging directly | 10:20 |
vikasc | irenab, | 10:23 |
irenab | vikasc: so, you are sying there is explicit call for release GW ip without explicit call to allocate it? | 10:26 |
vikasc | irenab, we dont create port when request_address is invoked for gw ip | 10:28 |
irenab | what I just want to make sure that kuryr handles the Network IPAM Driver calls properly, making the proper translations to neutron. | 10:28 |
irenab | vikasc: from neutron perspective, it should assign gw ip for the subnet, not create port | 10:28 |
irenab | vikasc: may I ask you to check the kuryr devref for the libnetwork driver mapping and see if we have the required translation up to date | 10:29 |
vikasc | irenab, to reserve address we create ports in neutron | 10:29 |
irenab | vikasc: this is for the container attachment port | 10:29 |
irenab | in neutron gw_ip is actually property of the subnet | 10:29 |
vikasc | irenab, for gw we just pass 'gateway' paarmeter to subnet creation api | 10:30 |
vikasc | yes | 10:30 |
vikasc | irenab, i will check devref also | 10:31 |
vikasc | irenab, is your concern is we reserved gw ip address and not releasing it? | 10:32 |
irenab | this seems correct to just handle gracefully the gw ip release request incase subnet is already removed, so I will + 1 your fix. Just lets make sure that the libnetwork calls are handled properly | 10:32 |
vikasc | irenab, I will think more on your words | 10:33 |
irenab | vikasc: my concern was the opposite, that libnetwork still assumes it is reserved, but we actually already deleted the subnet with gw | 10:33 |
vikasc | irenab, but why libnetwork will think so. I mean at network delete only gw ip release request will be recieved and gw ip allocate was done at network creation. So libnetwork should not be assuming so. | 10:34 |
irenab | so it seems wierd that release gw ip comes after delete network | 10:35 |
vikasc | yes | 10:35 |
vikasc | irenab, agreed, it weird from libnetwork side | 10:36 |
irenab | I am just afraid there can be some assumptions | 10:36 |
irenab | but anyway your fix is correct, just wanted to kick a discussion :-) | 10:36 |
vikasc | irenab, I appreciate that :) | 10:36 |
vikasc | anyways I will think more on your points | 10:37 |
irenab | lets merge the fix and verify the devref to reflect the libnetwork calls handling | 10:37 |
vikasc | irenab, sure | 10:37 |
irenab | vikasc: thanks a lot for taking care of this issue | 10:37 |
gsagie | irenab: i saw you presenting Kuryr tommorow :) | 10:51 |
irenab | yea … | 10:51 |
irenab | Are you going to attend? | 10:51 |
gsagie | nope | 10:51 |
irenab | I am trying to make most of the agenda in 20 mins I was given | 10:52 |
gsagie | only 20? | 10:52 |
irenab | and 2 mins for questions :-) | 10:52 |
gsagie | How was Budapest? :) | 10:52 |
irenab | generally ok, just my talk was rescheduled at last moment | 10:53 |
gsagie | ohhh :( | 10:53 |
irenab | so I received the slot after lunch… | 10:53 |
irenab | some guy was sleeping on the first row | 10:53 |
*** salv-orlando has quit IRC | 10:56 | |
*** salv-orlando has joined #openstack-kuryr | 10:57 | |
gsagie | :[ | 11:01 |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 11:03 |
gsagie | irenab: Good luck tommorrow.. | 11:05 |
*** limao_ has joined #openstack-kuryr | 11:05 | |
*** salv-orlando has quit IRC | 11:06 | |
irenab | gsagie: thanks | 11:06 |
*** yamamot__ has quit IRC | 11:10 | |
*** limao_ has quit IRC | 11:31 | |
*** limao_ has joined #openstack-kuryr | 11:32 | |
*** limao_ has quit IRC | 11:36 | |
*** yamamoto has joined #openstack-kuryr | 11:48 | |
*** vikasc has quit IRC | 11:50 | |
*** banix has joined #openstack-kuryr | 11:56 | |
*** vikasc has joined #openstack-kuryr | 11:57 | |
*** banix has quit IRC | 12:00 | |
*** vikasc has quit IRC | 12:02 | |
*** diga has quit IRC | 12:03 | |
*** prithiv has joined #openstack-kuryr | 12:16 | |
*** salv-orlando has joined #openstack-kuryr | 12:56 | |
*** salv-orlando has quit IRC | 12:56 | |
*** salv-orlando has joined #openstack-kuryr | 12:56 | |
*** prithiv has quit IRC | 12:57 | |
*** limao_ has joined #openstack-kuryr | 12:59 | |
*** limao_ has quit IRC | 12:59 | |
*** limao_ has joined #openstack-kuryr | 13:00 | |
*** diogogmt has quit IRC | 13:21 | |
*** yamamoto has quit IRC | 13:25 | |
*** yamamoto has joined #openstack-kuryr | 13:28 | |
*** diogogmt has joined #openstack-kuryr | 13:31 | |
*** yamamoto has quit IRC | 13:32 | |
*** yamamoto has joined #openstack-kuryr | 13:32 | |
*** yamamoto has quit IRC | 13:46 | |
*** yamamoto has joined #openstack-kuryr | 13:48 | |
*** yamamoto has quit IRC | 13:53 | |
*** yamamoto has joined #openstack-kuryr | 13:53 | |
*** diogogmt has quit IRC | 13:53 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr: Updated from global requirements https://review.openstack.org/323895 | 13:58 |
openstackgerrit | Merged openstack/kuryr: Fix typos in the watcher desing devref https://review.openstack.org/328059 | 14:01 |
*** diogogmt has joined #openstack-kuryr | 14:04 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr: Updated from global requirements https://review.openstack.org/323895 | 14:08 |
openstackgerrit | Merged openstack/kuryr: Fix the style of Raven devref https://review.openstack.org/319125 | 14:11 |
*** diogogmt has quit IRC | 14:15 | |
*** hongbin has joined #openstack-kuryr | 14:15 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr: Updated from global requirements https://review.openstack.org/323895 | 14:18 |
*** oanson has quit IRC | 14:19 | |
openstackgerrit | Merged openstack/kuryr: Eliminate unecessary ", or" in watcher design devref https://review.openstack.org/328061 | 14:43 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr: Updated from global requirements https://review.openstack.org/323895 | 14:46 |
*** yamamoto has quit IRC | 14:46 | |
*** diogogmt has joined #openstack-kuryr | 15:08 | |
*** yamamoto has joined #openstack-kuryr | 15:12 | |
*** banix has joined #openstack-kuryr | 15:18 | |
*** oanson has joined #openstack-kuryr | 15:21 | |
*** limao_ has quit IRC | 15:25 | |
banix | apuimedo: gsagie you guys around? | 15:27 |
gsagie | here | 15:28 |
banix | hi; there is a problem with what we want to add to the fullstack tests; i was wondering if you can think of a solution | 15:28 |
banix | essentially the ipdb stuff don’t seem to run properly and i think it is due to not having the correct permissions/privilidge | 15:29 |
banix | i triesd a simple minded change here but that didn’t help: | 15:29 |
banix | https://review.openstack.org/#/c/329729/4/kuryr/tests/contrib/post_test_hook.sh | 15:30 |
gsagie | banix: i think you need to run the Kuryr process with root | 15:31 |
gsagie | dont see how this change can help with that | 15:31 |
banix | yes, how do i that? | 15:31 |
gsagie | from plugin.sh | 15:31 |
banix | is that part of our tree? | 15:32 |
gsagie | run_process kuryr "sudo PYTHONPATH=$PYTHONPATH:$DEST... | 15:32 |
gsagie | yes but i see its already started with sudo | 15:32 |
gsagie | its in kuryr/devstack/plugin.sh | 15:32 |
gsagie | this is what is running the kuryr process | 15:32 |
gsagie | ahh ops | 15:33 |
gsagie | maybe need another sudo before "python $DEST/kuryr/scripts/run_server.py" | 15:33 |
gsagie | this line maybe needs some fix | 15:33 |
gsagie | but is it running ok in your setup? | 15:33 |
banix | no for the new stuff we want to add that do binding etc; the current tests now work fine. | 15:34 |
banix | by current tests i mean those already in tree | 15:34 |
banix | thx for the pointer let me look into it | 15:35 |
gsagie | where is it failing? | 15:35 |
gsagie | in the binding script? | 15:35 |
banix | yes | 15:35 |
gsagie | maybe we dont run that as root | 15:35 |
gsagie | i think apuimedo was doing some work there with capabilities, or at least checking that part | 15:36 |
gsagie | apuimedo ? | 15:36 |
banix | well, it is the binding.py | 15:36 |
banix | so it is kuryr itself | 15:36 |
*** yamamoto has quit IRC | 15:36 | |
banix | the veth pair creation returns null | 15:36 |
*** yamamoto has joined #openstack-kuryr | 15:36 | |
banix | so not the script; we dont get to that point yet. | 15:37 |
*** yamamoto has quit IRC | 15:40 | |
*** yamamoto has joined #openstack-kuryr | 15:48 | |
*** vikasc has joined #openstack-kuryr | 15:55 | |
*** oanson has quit IRC | 16:01 | |
*** vikasc has quit IRC | 16:19 | |
openstackgerrit | vikas choudhary proposed openstack/kuryr: Add test case for two containers on same network https://review.openstack.org/328236 | 16:30 |
*** hongbin has quit IRC | 16:34 | |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 16:39 |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 16:49 |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 17:04 |
*** hongbin has joined #openstack-kuryr | 17:42 | |
*** banix has quit IRC | 18:04 | |
*** oanson has joined #openstack-kuryr | 18:08 | |
*** banix has joined #openstack-kuryr | 18:09 | |
*** hongbin has quit IRC | 18:15 | |
*** hongbin has joined #openstack-kuryr | 18:16 | |
*** abhiraut has joined #openstack-kuryr | 18:20 | |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 18:20 |
*** abhiraut has quit IRC | 18:23 | |
*** abhiraut has joined #openstack-kuryr | 18:35 | |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 18:36 |
*** salv-orlando has quit IRC | 18:43 | |
*** salv-orlando has joined #openstack-kuryr | 18:44 | |
*** salv-orl_ has joined #openstack-kuryr | 18:55 | |
*** salv-orlando has quit IRC | 18:58 | |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 19:06 |
*** abhiraut has quit IRC | 19:11 | |
*** abhiraut has joined #openstack-kuryr | 19:16 | |
*** abhiraut has quit IRC | 19:26 | |
*** abhiraut has joined #openstack-kuryr | 19:28 | |
*** openstackgerrit has quit IRC | 19:33 | |
*** openstackgerrit has joined #openstack-kuryr | 19:33 | |
*** oanson has quit IRC | 19:35 | |
openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Allowing ip operations in fullstack test https://review.openstack.org/329729 | 19:45 |
*** salv-orl_ has quit IRC | 19:45 | |
*** salv-orlando has joined #openstack-kuryr | 19:45 | |
*** abhiraut has quit IRC | 20:05 | |
*** abhiraut has joined #openstack-kuryr | 20:17 | |
banix | apuimedo: interesting enough the binding “script” gets executed nicely and creates the interfaces and the linux bridge, etc without any problems | 21:23 |
banix | apuimedo: the main veth pair that gets created in the binding.py file using pyroute2, does not get created | 21:24 |
*** banix has quit IRC | 21:29 | |
apuimedo | mmm | 21:39 |
*** openstackgerrit has quit IRC | 22:02 | |
*** openstackgerrit has joined #openstack-kuryr | 22:05 | |
*** salv-orlando has quit IRC | 22:25 | |
*** salv-orlando has joined #openstack-kuryr | 22:26 | |
*** abhiraut has quit IRC | 22:30 | |
*** limao_ has joined #openstack-kuryr | 22:31 | |
*** banix has joined #openstack-kuryr | 22:44 | |
*** hongbin has quit IRC | 22:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!