| *** huikang has quit IRC | 00:10 | |
| *** huikang has joined #openstack-kuryr | 00:11 | |
| *** huikang has quit IRC | 00:12 | |
| *** huikang has joined #openstack-kuryr | 00:12 | |
| *** sdake_ has quit IRC | 00:25 | |
| *** lezbar has quit IRC | 00:43 | |
| *** lezbar has joined #openstack-kuryr | 00:44 | |
| *** sdake has joined #openstack-kuryr | 00:52 | |
| openstackgerrit | Zhang Ni proposed openstack/fuxi: Enable Fuxi to use Manila share https://review.openstack.org/375452 | 00:59 |
|---|---|---|
| *** huikang has quit IRC | 01:16 | |
| *** huikang has joined #openstack-kuryr | 01:17 | |
| *** huikang has quit IRC | 01:21 | |
| *** huikang has joined #openstack-kuryr | 01:22 | |
| *** reedip has quit IRC | 01:27 | |
| *** reedip has joined #openstack-kuryr | 01:28 | |
| *** huikang has quit IRC | 01:55 | |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr: binding: Add driver based subsystem https://review.openstack.org/375864 | 01:55 |
| apuimedo | limao: thanks for the review | 01:55 |
| apuimedo | I just pushed a huge change to that patchset, to address all the comments, ivc's and yours | 01:56 |
| *** huikang has joined #openstack-kuryr | 01:56 | |
| apuimedo | it's still a bit of a WIP because I have to do fullstack testing and I want to add a couple of unit tests more | 01:56 |
| apuimedo | but it's 4am, so it will have to wait for when I wake up :-) | 01:56 |
| limao | apuimedo: cool | 01:59 |
| limao | Good Night (maybe morning)! | 01:59 |
| *** huikang_ has joined #openstack-kuryr | 02:00 | |
| *** huikang has quit IRC | 02:01 | |
| *** salv-orlando has joined #openstack-kuryr | 02:01 | |
| *** salv-orlando has quit IRC | 02:05 | |
| *** huikang_ has quit IRC | 02:09 | |
| *** huikang has joined #openstack-kuryr | 02:10 | |
| *** huikang has quit IRC | 02:14 | |
| *** huikang has joined #openstack-kuryr | 02:28 | |
| *** lezbar has quit IRC | 02:37 | |
| *** lezbar has joined #openstack-kuryr | 02:38 | |
| *** yuanying_ has quit IRC | 02:50 | |
| *** sdake has quit IRC | 02:52 | |
| *** yamamoto_ has joined #openstack-kuryr | 02:59 | |
| *** yedongcan has joined #openstack-kuryr | 03:01 | |
| *** yuanying has joined #openstack-kuryr | 03:05 | |
| *** sdake has joined #openstack-kuryr | 03:16 | |
| *** huikang has quit IRC | 03:18 | |
| *** huikang has joined #openstack-kuryr | 03:19 | |
| *** vikasc has quit IRC | 03:19 | |
| *** sdake has quit IRC | 03:19 | |
| *** huikang_ has joined #openstack-kuryr | 03:21 | |
| *** huikang has quit IRC | 03:24 | |
| *** vikasc has joined #openstack-kuryr | 03:26 | |
| *** sdake has joined #openstack-kuryr | 03:32 | |
| *** yuanying has quit IRC | 03:33 | |
| *** yuanying has joined #openstack-kuryr | 03:34 | |
| *** fkautz_ has quit IRC | 03:48 | |
| *** limao has quit IRC | 03:49 | |
| *** yuanying has quit IRC | 03:49 | |
| *** fkautz_ has joined #openstack-kuryr | 03:50 | |
| *** huikang_ has quit IRC | 03:51 | |
| *** huikang has joined #openstack-kuryr | 03:51 | |
| *** yuanying has joined #openstack-kuryr | 03:52 | |
| *** tonanhngo has joined #openstack-kuryr | 03:54 | |
| *** lezbar has quit IRC | 03:54 | |
| *** limao has joined #openstack-kuryr | 03:55 | |
| *** lezbar has joined #openstack-kuryr | 03:55 | |
| *** huikang has quit IRC | 03:56 | |
| *** salv-orlando has joined #openstack-kuryr | 04:03 | |
| *** salv-orlando has quit IRC | 04:07 | |
| *** salv-orlando has joined #openstack-kuryr | 04:42 | |
| *** salv-orlando has quit IRC | 04:42 | |
| *** salv-orlando has joined #openstack-kuryr | 04:43 | |
| *** sdake has quit IRC | 05:00 | |
| *** yamamoto_ has quit IRC | 05:04 | |
| *** yedongcan_ has joined #openstack-kuryr | 05:36 | |
| *** yamamoto_ has joined #openstack-kuryr | 05:46 | |
| *** ivc_ has joined #openstack-kuryr | 06:08 | |
| *** yedongcan_ has quit IRC | 06:14 | |
| *** limao has quit IRC | 06:29 | |
| *** yedongcan1 has joined #openstack-kuryr | 06:31 | |
| *** limao has joined #openstack-kuryr | 06:32 | |
| *** yedongcan has quit IRC | 06:32 | |
| *** lezbar has quit IRC | 06:47 | |
| *** lezbar has joined #openstack-kuryr | 06:48 | |
| *** tonanhngo has quit IRC | 06:53 | |
| *** tonanhngo has joined #openstack-kuryr | 07:00 | |
| *** tonanhngo has quit IRC | 07:02 | |
| apuimedo | ivc_: limao: did you have a chance to look at https://review.openstack.org/#/c/375864/5 ? | 07:14 |
| apuimedo | (now I'm fixing pep8 | 07:20 |
| apuimedo | ) | 07:20 |
| ivc_ | apuimedo looks nice. tho i was thinking about driver as class/methods rather then module/functions. | 07:22 |
| apuimedo | ivc_: I have a strong bias about classes that don't hold state | 07:22 |
| apuimedo | so that's why it probably ended up different :P | 07:23 |
| ivc_ | yeah i can understand that | 07:23 |
| *** yedongcan has joined #openstack-kuryr | 07:25 | |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr: binding: Add driver based subsystem https://review.openstack.org/375864 | 07:26 |
| apuimedo | pep8 fixed in ^^ | 07:26 |
| * apuimedo going to add a few more unit tests | 07:27 | |
| ivc_ | also i'm not a big fan of non-empty __init__.py, but that's just a matter of habbit | 07:27 |
| ivc_ | maybe drivers/__init__ could be drivers/common or drivers/base | 07:28 |
| ivc_ | as it has some real code (while binding/__init__ is just a proxy) | 07:29 |
| *** yedongcan1 has quit IRC | 07:29 | |
| apuimedo | ivc_: sounds good | 07:30 |
| apuimedo | I'll change that | 07:31 |
| ivc_ | cool thnx | 07:31 |
| ivc_ | i'll do a proper review later | 07:32 |
| apuimedo | ivc_: much appreciated | 07:32 |
| *** salv-orlando has quit IRC | 07:37 | |
| *** oanson has joined #openstack-kuryr | 07:43 | |
| *** salv-orlando has joined #openstack-kuryr | 07:50 | |
| limao | apuimedo: the whole day in meeting till now :-( , will review and update on the patch soon | 07:57 |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr: binding: Add driver based subsystem https://review.openstack.org/375864 | 08:06 |
| apuimedo | ivc_: __init__.py emptied in latest revision ;-) | 08:06 |
| ivc_ | apuimedo awesome! :) | 08:07 |
| *** yedongcan has quit IRC | 08:15 | |
| *** dingboopt_ has joined #openstack-kuryr | 08:18 | |
| *** yedongcan has joined #openstack-kuryr | 08:20 | |
| *** yedongcan1 has joined #openstack-kuryr | 08:49 | |
| *** ivc_ has quit IRC | 08:50 | |
| apuimedo | tox coverage is brain fscking me | 08:51 |
| apuimedo | :( | 08:51 |
| apuimedo | it doesn't show coverage unless I change setup.cfg to kuryr.lib instead of kuryr-lib | 08:51 |
| apuimedo | I wonder if it's possible for it not to use the metadata name as the module to import coverage for | 08:52 |
| *** yedongcan has quit IRC | 08:52 | |
| *** yedongcan has joined #openstack-kuryr | 08:59 | |
| *** yedongcan1 has quit IRC | 09:02 | |
| janonymous | Hahaa | 09:03 |
| apuimedo | janonymous: bastard testrepository gets the name from self.distribution.get_name | 09:04 |
| apuimedo | I don't think it is configurable | 09:04 |
| apuimedo | fucking finally | 09:09 |
| apuimedo | I fixed it :-) | 09:09 |
| openstackgerrit | Liping Mao proposed openstack/kuryr-libnetwork: [DO NOT MERGE] Test UT https://review.openstack.org/379295 | 09:09 |
| janonymous | apuimedo: hahaa | 09:11 |
| janonymous | apuimedo: great | 09:11 |
| apuimedo | thank God there was an option for testr | 09:12 |
| janonymous | otherwise we had to change the name of project :P | 09:12 |
| apuimedo | yup | 09:12 |
| apuimedo | or patch it live | 09:12 |
| apuimedo | :P | 09:12 |
| *** ivc_ has joined #openstack-kuryr | 09:17 | |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr: tox: fix coverage call https://review.openstack.org/379305 | 09:21 |
| apuimedo | janonymous: limao: ivc_: fix for tox -e cover ^^ | 09:22 |
| apuimedo | vikasc: if you can approve the tox fix it would be great | 09:24 |
| apuimedo | :-) | 09:24 |
| limao | apuimedo: Toni , are you sure you fixed it? :) | 09:32 |
| apuimedo | limao: works for me | 09:32 |
| apuimedo | can you paste me your breakage output? | 09:32 |
| limao | error: option --coverage-package-name not recognized | 09:33 |
| limao | ERROR: InvocationError: '/root/kuryr/.tox/cover/bin/python setup.py testr --coverage --testr-args= --coverage-package-name=kuryr.lib' | 09:33 |
| limao | ________________________________________________________________________________________________ summary _________________________________________________________________________________________________ | 09:33 |
| limao | ERROR: cover: commands failed | 09:33 |
| limao | I download kuryr in /root/kuyur, and switch to your fix branch | 09:33 |
| limao | and run tox -e cover | 09:33 |
| limao | anything missed? | 09:34 |
| apuimedo | limao: can you do a paste.openstack.org of .tox/cover/bin/pip list ? | 09:34 |
| apuimedo | I can only thing about an older testr version | 09:34 |
| apuimedo | s/thing/think/ | 09:34 |
| limao | ok let me see | 09:35 |
| apuimedo | here's mine http://paste.openstack.org/show/583448/ | 09:36 |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Optimize add security group rules for exposed ports https://review.openstack.org/378485 | 09:36 |
| limao | apuimedo: http://paste.openstack.org/show/583449/ | 09:37 |
| limao | mine | 09:37 |
| apuimedo | that's very odd | 09:38 |
| limao | kuryr.lib (0.1.1.dev7, /home/celebdor/code/github.com/openstack/kuryr) You have this? | 09:39 |
| apuimedo | oh | 09:39 |
| apuimedo | wait, let me clean it up | 09:39 |
| limao | ok | 09:40 |
| * apuimedo removing .tox/cover | 09:41 | |
| yedongcan | limao: Hello, address your comments in new patch https://review.openstack.org/#/c/378485/, maybe can resolve it. Hope for your reply. | 09:41 |
| limao | yedongcan: thanks! let check | 09:41 |
| *** diga_ has joined #openstack-kuryr | 09:42 | |
| apuimedo | limao: please, check that you don't have old .pyc files in the tree | 09:43 |
| yedongcan | limao: thanks | 09:43 |
| apuimedo | limao: this is what I get in a clean environment http://paste.openstack.org/show/583454/ | 09:44 |
| limao | apuimedo: let me see | 09:45 |
| limao | apuimedo: http://paste.openstack.org/show/583458/ | 09:46 |
| limao | apuimedo: Toni, I believe this is not because old .pyc, I even tried git clone a new kuryr repo | 09:46 |
| *** sdake has joined #openstack-kuryr | 09:47 | |
| *** tonanhngo has joined #openstack-kuryr | 09:49 | |
| *** tonanhngo has quit IRC | 09:50 | |
| apuimedo | let me try that, then :-) | 09:52 |
| limao | apuimedo: thanks | 09:53 |
| apuimedo | limao: I'm a bit puzzled, for me it works in a new clone | 09:56 |
| apuimedo | http://paste.openstack.org/show/583460/ | 09:56 |
| limao | Did you remove kuryr.lib ? | 09:58 |
| limao | kuryr.lib (0.1.1.dev7, /home/celebdor/code/github.com/openstack/kuryr) You have this? | 09:58 |
| apuimedo | elebdor@s21 ~/Downloads/kuryr (5f00a35*) $ pip list | grep kuryr | 09:58 |
| apuimedo | celebdor@s21 ~/Downloads/kuryr (5f00a35*) $ | 09:58 |
| apuimedo | celebdor@s21 ~/Downloads/kuryr (5f00a35*) $ .tox/cover/bin/pip list | grep kuryr | 09:58 |
| apuimedo | kuryr-lib (0.1.1.dev7, /home/celebdor/Downloads/kuryr) | 09:58 |
| apuimedo | celebdor@s21 ~/Downloads/kuryr (5f00a35*) $ | 09:58 |
| limao | *_* | 09:58 |
| apuimedo | *_* indeed | 09:59 |
| apuimedo | let me check with bash (I use zsh) | 09:59 |
| apuimedo | nope, works also | 09:59 |
| limao | root@devstack:~/kuryr# .tox/cover/bin/pip list | grep kuryr | 09:59 |
| limao | kuryr-lib (0.1.1.dev7, /root/kuryr) | 09:59 |
| limao | I use vagrant up | 10:00 |
| limao | ubuntu server | 10:00 |
| * apuimedo locally on my arch linux server | 10:00 | |
| apuimedo | maybe I use a newer tox? | 10:00 |
| limao | let me see | 10:00 |
| limao | root@devstack:~/kuryr# tox --version | 10:01 |
| limao | 2.3.1 imported from /usr/local/lib/python2.7/dist-packages/tox/__init__.pyc | 10:01 |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Optimize add security group rules for exposed ports https://review.openstack.org/378485 | 10:01 |
| apuimedo | I have 2.3.1 | 10:01 |
| apuimedo | [celebdor@s21 kuryr]$ tox --version | 10:01 |
| apuimedo | 2.3.1 imported from /usr/lib/python2.7/site-packages/tox/__init__.pyc | 10:01 |
| apuimedo | [celebdor@s21 kuryr]$ | 10:01 |
| apuimedo | ok, let's do another check | 10:02 |
| apuimedo | limao: please, do: | 10:03 |
| apuimedo | celebdor@s21 ~/Downloads/kuryr (5f00a35*) $ grep "coverage-package-name" -R .tox/cover/ | 10:03 |
| apuimedo | Binary file .tox/cover/lib/python2.7/site-packages/pbr/testr_command.pyc matches | 10:03 |
| apuimedo | .tox/cover/lib/python2.7/site-packages/pbr/testr_command.py: ('coverage-package-name=', None, "Use this name for coverage package"), | 10:03 |
| apuimedo | celebdor@s21 ~/Downloads/kuryr (5f00a35*) $ | 10:03 |
| limao | root@devstack:~/kuryr# grep "coverage-package-name" -R .tox/cover/ | 10:04 |
| limao | .tox/cover/local/lib/python2.7/site-packages/pbr/testr_command.py: ('coverage-package-name=', None, "Use this name for coverage package"), | 10:04 |
| limao | Binary file .tox/cover/local/lib/python2.7/site-packages/pbr/testr_command.pyc matches | 10:04 |
| limao | .tox/cover/lib/python2.7/site-packages/pbr/testr_command.py: ('coverage-package-name=', None, "Use this name for coverage package"), | 10:04 |
| limao | Binary file .tox/cover/lib/python2.7/site-packages/pbr/testr_command.pyc matches | 10:04 |
| apuimedo | that's odd, you have the code, then | 10:05 |
| limao | Sure, I switch to your branch :) | 10:05 |
| janonymous | apuimedo: can you paste the output of python setup.py testr --coverage --testr-args --help | 10:06 |
| apuimedo | sure | 10:06 |
| janonymous | from your cover env | 10:06 |
| apuimedo | limao: no, I meant that your pbr has the code | 10:06 |
| apuimedo | not my change | 10:06 |
| apuimedo | I wanted to check the deps | 10:07 |
| apuimedo | janonymous: does it work for you? | 10:07 |
| janonymous | nopes,no option --coverage-package-name option | 10:07 |
| limao | Anyway, I have to leave now, I will try to build a new vm and try again on that... I will check message later here | 10:07 |
| apuimedo | janonymous: weird | 10:08 |
| apuimedo | limao: I'll try on my devstack machine too | 10:08 |
| limao | apuimedo: Thanks | 10:08 |
| *** limao has quit IRC | 10:09 | |
| janonymous | apuimedo : as my python setup.py testr --coverage --testr-args --help does not show --coverage-package-name options | 10:09 |
| apuimedo | janonymous: http://paste.openstack.org/show/583464/ | 10:11 |
| apuimedo | I put a breakpoint to see if it stops there in pbr | 10:11 |
| apuimedo | could you try to put the breakpoint too? | 10:11 |
| apuimedo | janonymous: my --help output http://paste.openstack.org/show/583465/ | 10:12 |
| janonymous | apuimedo: nopes doesn't stop at pdb | 10:14 |
| apuimedo | that's really curious | 10:15 |
| janonymous | apuimedo: you have --coverage-package-name option in your help which is missing from mine | 10:15 |
| apuimedo | yup | 10:15 |
| apuimedo | distro? | 10:15 |
| janonymous | apuimedo: http://paste.openstack.org/show/583466/ | 10:16 |
| janonymous | Linux janonymous 3.13.0-86-generic #131-Ubuntu SMP Thu May 12 23:33:13 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | 10:16 |
| apuimedo | wth | 10:17 |
| apuimedo | this will be some retarded Ubuntu distutils crap | 10:17 |
| apuimedo | janonymous: in usr/lib64/python2.7/distutils/dist.py | 10:17 |
| apuimedo | just before it does the cmd_job.run() | 10:18 |
| apuimedo | can you put a trace there | 10:18 |
| apuimedo | and see where it goes? | 10:18 |
| janonymous | Hehee, my distutils dir has only : | 10:18 |
| janonymous | distutils.cfg __init__.py __init__.pyc | 10:19 |
| apuimedo | why does debian world always patch upstream distutils in funny ways? | 10:21 |
| * apuimedo trying to reproduce on an devstack centos now | 10:21 | |
| apuimedo | janonymous: this is with a clean centos http://paste.openstack.org/show/583467/ | 10:22 |
| apuimedo | janonymous: you run ubuntu 14.04.3, right? | 10:23 |
| janonymous | yup | 10:27 |
| janonymous | apuimedo: seems i do not have that option in my /usr/lib/python2.7/dist-packages/pbr/testr_command.py | 10:27 |
| apuimedo | janonymous: but it should not use the /usr/lib one, it should use the tox virtualenv one | 10:28 |
| *** dingboopt_ has quit IRC | 10:30 | |
| janonymous | apuimedo:yes... virtual one have that option though | 10:31 |
| *** yamamoto_ has quit IRC | 10:40 | |
| *** salv-orlando has quit IRC | 10:40 | |
| *** salv-orlando has joined #openstack-kuryr | 10:41 | |
| apuimedo | janonymous: ok. I could reproduce it in ubuntu 14.04 | 10:49 |
| apuimedo | I'll check if it happens on 16.06 | 10:49 |
| janonymous | apuimedo: i will update if i get anything,i am also trying to find the cause | 10:50 |
| *** salv-orlando has quit IRC | 10:54 | |
| apuimedo | thanks | 11:13 |
| *** limao has joined #openstack-kuryr | 11:14 | |
| *** yamamoto has joined #openstack-kuryr | 11:18 | |
| *** yamamoto_ has joined #openstack-kuryr | 11:18 | |
| *** yamamoto has quit IRC | 11:18 | |
| *** openstackgerrit has quit IRC | 11:19 | |
| *** openstackgerrit has joined #openstack-kuryr | 11:19 | |
| *** limao has quit IRC | 11:20 | |
| *** limao has joined #openstack-kuryr | 11:20 | |
| *** yedongcan has left #openstack-kuryr | 11:37 | |
| limao | Hi apuimedo | 11:47 |
| limao | [testenv:cover] | 11:47 |
| limao | commands = | 11:47 |
| limao | python setup.py test --coverage --testr-args='{posargs}' \ | 11:47 |
| limao | --coverage-package-name=kuryr.lib | 11:47 |
| limao | The problem can be fixed by change testr to test | 11:47 |
| limao | Name Stmts Miss Branch BrPart Cover | 11:48 |
| limao | ----------------------------------------------------------- | 11:48 |
| limao | kuryr/lib/__init__.py 0 0 0 0 100% | 11:48 |
| limao | kuryr/lib/_i18n.py 12 1 0 0 92% | 11:48 |
| limao | kuryr/lib/binding.py 104 23 26 7 72% | 11:48 |
| limao | kuryr/lib/config.py 13 0 0 0 100% | 11:48 |
| limao | kuryr/lib/constants.py 18 0 0 0 100% | 11:48 |
| limao | kuryr/lib/exceptions.py 11 0 0 0 100% | 11:48 |
| limao | kuryr/lib/opts.py 25 9 7 0 50% | 11:48 |
| limao | kuryr/lib/utils.py 44 0 6 0 100% | 11:48 |
| limao | ----------------------------------------------------------- | 11:48 |
| limao | TOTAL 227 33 39 7 80% | 11:48 |
| limao | ________________________________________________________________________________________________ summary _________________________________________________________________________________________________ | 11:48 |
| limao | cover: commands succeeded | 11:48 |
| limao | congratulations :) | 11:48 |
| *** yedongcan has joined #openstack-kuryr | 11:49 | |
| *** yedongcan has quit IRC | 11:50 | |
| limao | apuimedo: janonymous: Thanks for your help and debug | 11:52 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Code restructuring: neutron client as rest driver from Kuryr lib https://review.openstack.org/342614 | 11:52 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Add neutron client generic rest driver https://review.openstack.org/342624 | 11:53 |
| limao | hi vikasc | 11:55 |
| vikasc | hi limao | 11:55 |
| limao | [files] | 11:55 |
| limao | packages = | 11:55 |
| limao | kuryr-libnetwork | 11:55 |
| limao | I think it should not change to kuryr-libnetwork here | 11:56 |
| limao | it should be kuryr_libnetwork | 11:56 |
| limao | which is the dir name | 11:56 |
| limao | https://review.openstack.org/#/c/342614/19/setup.cfg | 11:56 |
| * vikasc checking | 11:56 | |
| limao | Thanks | 11:56 |
| *** limao has quit IRC | 11:58 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Code restructuring: neutron client as rest driver from Kuryr lib https://review.openstack.org/342614 | 11:59 |
| apuimedo | very interesting | 12:00 |
| apuimedo | thanks limao | 12:00 |
| *** yedongcan has joined #openstack-kuryr | 12:00 | |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr: tox: fix coverage call https://review.openstack.org/379305 | 12:03 |
| apuimedo | vikasc: I updated the change with limao's suggestion | 12:04 |
| vikasc | thanks apuimedo , please allow me couple of minutes | 12:05 |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr: tox: fix coverage call https://review.openstack.org/379305 | 12:05 |
| apuimedo | thanks vikasc | 12:05 |
| *** yedongcan has quit IRC | 12:05 | |
| vikasc | apuimedo, Can you please review https://review.openstack.org/342624 ? I have to rebase these changes for almost each patch merge. | 12:09 |
| apuimedo | ok | 12:09 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Add neutron client generic rest driver https://review.openstack.org/342624 | 12:09 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Nested-Containers: Add vlan management apis https://review.openstack.org/361993 | 12:09 |
| apuimedo | vikasc: are these new methods in https://review.openstack.org/#/c/342624/17/kuryr/tests/unit/base.py part of the patch? | 12:13 |
| apuimedo | (they seem unrelated for now) | 12:13 |
| vikasc | apuimedo, let me check, AFAIR i added some tests for which i added these | 12:14 |
| *** diga_ has quit IRC | 12:16 | |
| vikasc | apuimedo, there are test cases in test_neutron_rest.py | 12:17 |
| apuimedo | ok, thanks vikas | 12:18 |
| vikasc | apuimedo, yw | 12:19 |
| vikasc | apuimedo, i am trying coverage patch locally | 12:19 |
| apuimedo | vikasc: I found some requirements issue in the kuryr-libnetwork patch | 12:19 |
| apuimedo | I already commented it and posted it, but I'm continuing with the rest of the review | 12:19 |
| vikasc | apuimedo, in kuryr-libnetwork, test cases will get passed once kuryr-lib changes are merged. I have tested locally. | 12:20 |
| apuimedo | vikasc: I haven't gotten to it yet, but... Is there any authentication between kuryr-libnetwork and kuryr-lib? | 12:23 |
| *** salv-orlando has joined #openstack-kuryr | 12:25 | |
| vikasc | apuimedo, in rest driver case neutron calls will be made from same host unlike rpc case... so no additional authentication | 12:27 |
| apuimedo | vikasc: in this rest case, we are just moving the code to kuryr-lib without adding the server, which will be done for the rpc patch, right? | 12:28 |
| vikasc | apuimedo, right | 12:28 |
| vikasc | apuimedo, changes in rest driver are just adding layer/abstraction only | 12:29 |
| apuimedo | cool | 12:29 |
| apuimedo | sorry for asking again | 12:29 |
| apuimedo | I'm sure I asked before | 12:29 |
| *** salv-orlando has quit IRC | 12:30 | |
| vikasc | apuimedo, yw | 12:33 |
| apuimedo | vikasc: what about we do it like in my ipvlan/macvlan driver patch | 12:33 |
| apuimedo | we keep having app.neutron in kuryr-libnetwork | 12:33 |
| apuimedo | and we have a configuration option that is kuryr.neutron.driver = 'kuryr.lib.neutron.rest' | 12:34 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Code restructuring: neutron client as rest driver from Kuryr lib https://review.openstack.org/342614 | 12:34 |
| apuimedo | as the default value | 12:34 |
| apuimedo | ivc_ suggested it to me for the macvlan and ipvlan and I have to say, after changing it to that, I find it much cleaner | 12:35 |
| apuimedo | and the kuryr-libnetwork patch would be smaller too | 12:36 |
| vikasc | apuimedo, it is likt this only IIUC | 12:36 |
| vikasc | *like | 12:36 |
| apuimedo | ? | 12:36 |
| vikasc | apuimedo, can you please reword this for me " we have a configuration option that is kuryr.neutron.driver = 'kuryr.lib.neutron.rest'" | 12:37 |
| apuimedo | sure | 12:37 |
| apuimedo | vikasc: just like in https://review.openstack.org/#/c/375864/7/kuryr/lib/config.py | 12:37 |
| apuimedo | where there is a config option with the python path to the importable object that implements the driver | 12:38 |
| apuimedo | and in https://review.openstack.org/#/c/375864/7/kuryr/lib/binding/__init__.py we load it transparently | 12:39 |
| apuimedo | so, following this approach | 12:39 |
| vikasc | apuimedo, please allow me some time to think over it. | 12:39 |
| apuimedo | in kuryr-lib, there would be kuryr/lib/neutron/__init__.py that would be similar to kuryr/lib/binding/__init__.py | 12:39 |
| vikasc | apuimedo, i will get back | 12:39 |
| apuimedo | and then kuryr/lib/neutron/rest.py and kuryr/lib/neutron/rpc.py would be the implementations | 12:40 |
| vikasc | apuimedo, in rpc case we need changes on both the sides, clinet and server | 12:41 |
| apuimedo | sure | 12:41 |
| vikasc | apuimedo, though i need more time to think | 12:41 |
| apuimedo | vikasc: sure, it's just for consistency and cleanliness, if you prefer I can do the move to this new driver mechanism after your patches get merged | 12:41 |
| vikasc | apuimedo, quick feeling is that possible for rest case but might face problem in rpc.. not sure | 12:41 |
| *** yedongcan has joined #openstack-kuryr | 12:42 | |
| *** limao has joined #openstack-kuryr | 12:42 | |
| apuimedo | vikasc: where is the rpc code? | 12:42 |
| vikasc | apuimedo, i will get back with my understanding | 12:42 |
| vikasc | apuimedo, u mean link to patch? | 12:42 |
| apuimedo | yeah | 12:42 |
| vikasc | apuimedo, https://review.openstack.org/#/c/340147/ | 12:43 |
| vikasc | apuimedo, https://review.openstack.org/#/c/340143/ | 12:43 |
| vikasc | apuimedo, first is kuryr-lib and later in kuryr-libnetwork | 12:43 |
| vikasc | apuimedo, yes.. what you suggested is possible | 12:46 |
| vikasc | apuimedo, and makes sense to me as well | 12:47 |
| vikasc | apuimedo, whatever changes current rest_driver patch has in kuryr_libnetwork, these can be put kin kuryr_lib and reused by kuryr_kubernetes as well | 12:48 |
| vikasc | apuimedo, little bit extra work for me but ofcourse worth doing | 12:49 |
| vikasc | apuimedo, i could have think like that in first place :'( | 12:53 |
| *** yamamoto_ has quit IRC | 12:54 | |
| *** ivc_ has quit IRC | 13:01 | |
| *** oanson has quit IRC | 13:05 | |
| apuimedo | vikasc: I also didn't think about it at first :P | 13:07 |
| vikasc | apuimedo, by tomorrow will be updating as per our current discussions | 13:07 |
| apuimedo | vikasc: cool! | 13:07 |
| *** yamamoto has joined #openstack-kuryr | 13:16 | |
| openstackgerrit | Merged openstack/kuryr-libnetwork: call start in sys.exit(start()) instead of start() https://review.openstack.org/376162 | 13:22 |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Update the kuryr-libnetwork repository https://review.openstack.org/378227 | 13:23 |
| apuimedo | vikasc: did https://review.openstack.org/#/c/379305/ work for you? | 13:24 |
| *** limao has quit IRC | 13:25 | |
| vikasc | apuimedo, just finished a meeting | 13:26 |
| apuimedo | ;-) | 13:26 |
| vikasc | apuimedo, trying it now | 13:26 |
| apuimedo | perfect | 13:26 |
| apuimedo | I want to start measuring coverage so that we don't decrease it | 13:26 |
| *** ivc_ has joined #openstack-kuryr | 13:26 | |
| *** salv-orlando has joined #openstack-kuryr | 13:27 | |
| vikasc | apuimedo, good idea indeed ! | 13:27 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-libnetwork: Updated from global requirements https://review.openstack.org/351976 | 13:28 |
| *** salv-orlando has quit IRC | 13:31 | |
| *** limao has joined #openstack-kuryr | 13:33 | |
| janonymous | limao: great! | 13:36 |
| limao | janonymous: :-) | 13:36 |
| *** yamamoto has quit IRC | 13:57 | |
| *** lezbar has quit IRC | 14:00 | |
| *** lezbar has joined #openstack-kuryr | 14:01 | |
| *** tonanhngo has joined #openstack-kuryr | 14:02 | |
| *** tonanhngo has quit IRC | 14:03 | |
| *** banix has joined #openstack-kuryr | 14:04 | |
| *** yamamoto has joined #openstack-kuryr | 14:05 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Optimize add security group rules for exposed ports https://review.openstack.org/378485 | 14:13 |
| openstackgerrit | Merged openstack/kuryr-libnetwork: move to python3.3+ ipaddress backport https://review.openstack.org/374257 | 14:17 |
| openstackgerrit | Merged openstack/kuryr: tox: fix coverage call https://review.openstack.org/379305 | 14:19 |
| *** yamamoto has quit IRC | 14:22 | |
| apuimedo | banix: thanks a lot for the review! | 14:22 |
| *** yamamoto has joined #openstack-kuryr | 14:23 | |
| *** sdake has quit IRC | 14:24 | |
| *** hongbin has joined #openstack-kuryr | 14:25 | |
| *** sdake has joined #openstack-kuryr | 14:26 | |
| *** yamamoto has quit IRC | 14:27 | |
| *** yamamoto has joined #openstack-kuryr | 14:27 | |
| *** yamamoto has quit IRC | 14:27 | |
| *** salv-orlando has joined #openstack-kuryr | 14:29 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Optimize add security group rules for exposed ports https://review.openstack.org/378485 | 14:31 |
| *** sdake_ has joined #openstack-kuryr | 14:34 | |
| *** lezbar has quit IRC | 14:35 | |
| *** lezbar has joined #openstack-kuryr | 14:36 | |
| *** sdake has quit IRC | 14:36 | |
| apuimedo | banix: this one could really use your eye https://review.openstack.org/#/c/378485/5/kuryr_libnetwork/controllers.py | 14:37 |
| banix | sure will review | 14:40 |
| apuimedo | thanks banix! | 14:41 |
| apuimedo | banix: did you manage to shake out the cold? | 14:41 |
| banix | no still going on… not too bad though | 14:42 |
| banix | thx for asking | 14:42 |
| apuimedo | banix: is there any code/bug you need/want me to check? | 14:44 |
| banix | the bug in my stuffed head! :) what is the plan for the release? | 14:45 |
| banix | we have to also work on the presentation for the summit… have been neglecting that till now | 14:46 |
| apuimedo | banix: same boat of neglect here | 14:47 |
| apuimedo | I'm not happy with what we can show, so I'm trying to advance | 14:48 |
| apuimedo | :-) | 14:48 |
| apuimedo | having minimum the ipvlan/macvlan support would be nice | 14:48 |
| apuimedo | banix: but I think we can cut a 0.1.0 right now | 14:48 |
| apuimedo | then make the 1.0.0 | 14:48 |
| banix | agree; so far we are where we were last summit functionality wise; even though have made the code better, etc | 14:49 |
| apuimedo | yedongcan: I rebased your https://review.openstack.org/374591 on top of my kuryr-lib refactor | 14:49 |
| apuimedo | banix: exactly | 14:49 |
| apuimedo | well, you added some SG based port expose | 14:50 |
| banix | we had the split and the k8s stuff coming in | 14:51 |
| banix | and the rest of the presentation you can talk about Barcelona; i am sure people will like it | 14:51 |
| *** lmdaly has joined #openstack-kuryr | 14:53 | |
| apuimedo | banix: :-) | 14:53 |
| *** sdake_ is now known as sdake_dnd | 14:53 | |
| yedongcan | apuidemo: Had seen that, thanks. | 14:56 |
| *** sdake has joined #openstack-kuryr | 14:59 | |
| apuimedo | thanks to you for the patch ;-) | 15:00 |
| *** sdake_dnd has quit IRC | 15:00 | |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr: binding: use cached interface info https://review.openstack.org/335500 | 15:01 |
| *** mchiappero has joined #openstack-kuryr | 15:22 | |
| *** sdake is now known as sdake_dnd | 15:26 | |
| *** yamamoto has joined #openstack-kuryr | 15:28 | |
| *** yamamoto has quit IRC | 15:33 | |
| *** huikang has joined #openstack-kuryr | 15:37 | |
| *** huikang has quit IRC | 15:37 | |
| *** huikang has joined #openstack-kuryr | 15:38 | |
| yedongcan | apuimedo: Hi, bother you again, do you have time to review https://review.openstack.org/#/c/373977/, had already address vikas, berezovsky, and your comments. | 15:40 |
| apuimedo | yedongcan: I like to be bothered :-) | 15:41 |
| apuimedo | otherwise I forget patches | 15:41 |
| yedongcan | If still have some problem, please let me known, we can move on. | 15:41 |
| *** tonanhngo has joined #openstack-kuryr | 15:42 | |
| apuimedo | yedongcan: well, I would prefer if the slightly unrelated test improvements were in a separate patch | 15:42 |
| apuimedo | cause otherwise it's a bit confusing, since the test improvements don't check the new warning message | 15:42 |
| *** tonanhngo has quit IRC | 15:44 | |
| yedongcan | apuidemo: Understood, I will check the warning message. | 15:45 |
| apuimedo | yedongcan: I mean, one patch should be the warning message you add, another the test improvements | 15:47 |
| yedongcan | apuidemo: Additional, that tests is needed, we call list subnets in the code, so I think it must add in this patch, otherwise UT will failed | 15:47 |
| apuimedo | yedongcan: oh, ok. I did not realise that | 15:47 |
| apuimedo | darned mox | 15:48 |
| yedongcan | :-( | 15:48 |
| *** openstackgerrit has quit IRC | 15:49 | |
| *** openstackgerrit has joined #openstack-kuryr | 15:50 | |
| apuimedo | yedongcan: in that case the tests are okay in the patch | 15:52 |
| apuimedo | yedongcan: however, my last question is | 15:52 |
| *** tonanhngo has joined #openstack-kuryr | 15:53 | |
| apuimedo | what is your observed result when there is the warning | 15:53 |
| yedongcan | apuimedo: um | 15:53 |
| apuimedo | does something break? | 15:53 |
| yedongcan | no, just a warning | 15:53 |
| *** tonanhngo has quit IRC | 15:54 | |
| yedongcan | apuidemo: I think that bug needs more discussion | 15:55 |
| apuimedo | yedongcan: I think we can take in the warning | 15:56 |
| apuimedo | and improve the pool/overlapping in another patch | 15:57 |
| yedongcan | apuidemo: um... | 15:58 |
| apuimedo | yedongcan: https://review.openstack.org/#/c/373977/ +2ed | 15:58 |
| apuimedo | now you have to get vikasc or banix to get it in ;-) | 15:58 |
| yedongcan | apuidemo: sorry for reply this patch(https://review.openstack.org/#/c/378485/) in wrong PS. :-( | 15:59 |
| yedongcan | apuidemo: Thanks. | 15:59 |
| apuimedo | yedongcan: thanks to you ;-) | 16:02 |
| *** huikang has quit IRC | 16:09 | |
| *** huikang has joined #openstack-kuryr | 16:10 | |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Check overlapping subnet cidr when creating subnetpool https://review.openstack.org/373977 | 16:12 |
| *** huikang has quit IRC | 16:14 | |
| limao | apuimedo: ping | 16:16 |
| apuimedo | limao: pong! | 16:17 |
| apuimedo | you're up late | 16:17 |
| limao | Do you familar with how to cross-project dependency? | 16:17 |
| limao | :) | 16:17 |
| *** reedip has quit IRC | 16:18 | |
| limao | I mean I want to check the UT of kuryr-libnetwork will not break by your change in kuryr | 16:18 |
| limao | we'd better to have some CI Job to do this kind of check | 16:18 |
| apuimedo | limao: well, the only thing I'm aware of is the commit msg tag | 16:18 |
| limao | But Looks like it did not work | 16:19 |
| apuimedo | depends-on: <gerrit-change-id> | 16:19 |
| limao | https://review.openstack.org/#/c/379295/ | 16:19 |
| apuimedo | that should make it fetch the patch | 16:19 |
| limao | I believe your patch should break kuryr-libnetwork | 16:19 |
| apuimedo | limao: I'll try to make it so it does not break it | 16:20 |
| apuimedo | but it could be broken due to config | 16:20 |
| limao | Yeah, it should break | 16:20 |
| limao | but it is all green now... | 16:20 |
| limao | So looks like the cross project dependency did not work as I want | 16:21 |
| limao | http://docs.openstack.org/infra/manual/developers.html#cross-repository-dependencies | 16:21 |
| limao | I refer to this | 16:22 |
| apuimedo | same here | 16:24 |
| apuimedo | we'll have to ask the #openstack-infra guys about | 16:24 |
| *** lmdaly has quit IRC | 16:24 | |
| *** lezbar has quit IRC | 16:26 | |
| limao | anyway, I will double check it tomorrow. Btw, I submit a similar patch in kuryr-libnetwork(as what you did in kuryr) to fix tox, and enable code coverage ci job in kuryr and kuryr-libnetwork | 16:26 |
| apuimedo | great | 16:26 |
| apuimedo | I'll check it | 16:26 |
| apuimedo | thanks a lot limao! | 16:26 |
| *** lezbar has joined #openstack-kuryr | 16:27 | |
| *** sdake_dnd is now known as sdake | 16:27 | |
| *** limao has quit IRC | 16:29 | |
| *** yedongcan has left #openstack-kuryr | 16:30 | |
| *** reedip has joined #openstack-kuryr | 16:32 | |
| *** huikang has joined #openstack-kuryr | 16:33 | |
| *** reedip has quit IRC | 17:02 | |
| *** mchiappero has quit IRC | 17:11 | |
| *** reedip has joined #openstack-kuryr | 17:15 | |
| *** tonanhngo has joined #openstack-kuryr | 17:25 | |
| *** reedip has quit IRC | 17:25 | |
| *** huikang has quit IRC | 17:26 | |
| *** huikang has joined #openstack-kuryr | 17:27 | |
| *** tonanhngo has quit IRC | 17:29 | |
| *** huikang has quit IRC | 17:31 | |
| *** tonanhngo has joined #openstack-kuryr | 17:32 | |
| *** banix has quit IRC | 17:35 | |
| *** reedip has joined #openstack-kuryr | 17:38 | |
| *** banix has joined #openstack-kuryr | 17:45 | |
| *** huikang has joined #openstack-kuryr | 17:57 | |
| *** reedip has quit IRC | 18:03 | |
| *** reedip has joined #openstack-kuryr | 18:15 | |
| *** huikang has quit IRC | 18:33 | |
| *** huikang has joined #openstack-kuryr | 18:33 | |
| *** huikang has quit IRC | 18:34 | |
| *** huikang has joined #openstack-kuryr | 18:34 | |
| *** reedip has quit IRC | 18:42 | |
| *** sdake has quit IRC | 18:50 | |
| *** sdake has joined #openstack-kuryr | 18:50 | |
| *** salv-orlando has quit IRC | 18:56 | |
| *** banix has quit IRC | 18:59 | |
| *** ivc_ has quit IRC | 19:07 | |
| *** banix has joined #openstack-kuryr | 19:08 | |
| *** salv-orlando has joined #openstack-kuryr | 19:18 | |
| *** huikang has quit IRC | 19:25 | |
| *** huikang has joined #openstack-kuryr | 19:26 | |
| *** huikang has quit IRC | 19:31 | |
| *** tonanhngo has quit IRC | 19:44 | |
| *** salv-orl_ has joined #openstack-kuryr | 19:44 | |
| *** salv-orlando has quit IRC | 19:47 | |
| *** huikang has joined #openstack-kuryr | 19:50 | |
| *** tonanhngo has joined #openstack-kuryr | 20:05 | |
| *** sdake has quit IRC | 20:08 | |
| *** tonanhngo has quit IRC | 20:10 | |
| *** lezbar has quit IRC | 20:33 | |
| *** lezbar has joined #openstack-kuryr | 20:34 | |
| *** ivc_ has joined #openstack-kuryr | 20:40 | |
| *** ivc_ has quit IRC | 20:42 | |
| *** lezbar has quit IRC | 20:52 | |
| *** lezbar has joined #openstack-kuryr | 20:52 | |
| *** huikang has quit IRC | 20:53 | |
| *** huikang has joined #openstack-kuryr | 20:54 | |
| *** huikang has quit IRC | 20:58 | |
| *** lezbar has quit IRC | 21:10 | |
| *** lezbar has joined #openstack-kuryr | 21:10 | |
| *** sdake has joined #openstack-kuryr | 21:13 | |
| *** ivc_ has joined #openstack-kuryr | 21:54 | |
| *** tonanhngo has joined #openstack-kuryr | 21:59 | |
| *** lezbar has quit IRC | 22:27 | |
| *** akanksha_ has joined #openstack-kuryr | 22:27 | |
| *** lezbar has joined #openstack-kuryr | 22:27 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr: Updated from global requirements https://review.openstack.org/357683 | 22:32 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-libnetwork: Updated from global requirements https://review.openstack.org/351976 | 22:32 |
| *** hongbin has quit IRC | 23:00 | |
| *** huikang has joined #openstack-kuryr | 23:03 | |
| *** sdake has quit IRC | 23:12 | |
| *** lezbar has quit IRC | 23:40 | |
| *** lezbar has joined #openstack-kuryr | 23:40 | |
| *** sdake has joined #openstack-kuryr | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!